ChangeLog-2009-06-16 4.0 MB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631563256335634563556365637563856395640564156425643564456455646564756485649565056515652565356545655565656575658565956605661566256635664566556665667566856695670567156725673567456755676567756785679568056815682568356845685568656875688568956905691569256935694569556965697569856995700570157025703570457055706570757085709571057115712571357145715571657175718571957205721572257235724572557265727572857295730573157325733573457355736573757385739574057415742574357445745574657475748574957505751575257535754575557565757575857595760576157625763576457655766576757685769577057715772577357745775577657775778577957805781578257835784578557865787578857895790579157925793579457955796579757985799580058015802580358045805580658075808580958105811581258135814581558165817581858195820582158225823582458255826582758285829583058315832583358345835583658375838583958405841584258435844584558465847584858495850585158525853585458555856585758585859586058615862586358645865586658675868586958705871587258735874587558765877587858795880588158825883588458855886588758885889589058915892589358945895589658975898589959005901590259035904590559065907590859095910591159125913591459155916591759185919592059215922592359245925592659275928592959305931593259335934593559365937593859395940594159425943594459455946594759485949595059515952595359545955595659575958595959605961596259635964596559665967596859695970597159725973597459755976597759785979598059815982598359845985598659875988598959905991599259935994599559965997599859996000600160026003600460056006600760086009601060116012601360146015601660176018601960206021602260236024602560266027602860296030603160326033603460356036603760386039604060416042604360446045604660476048604960506051605260536054605560566057605860596060606160626063606460656066606760686069607060716072607360746075607660776078607960806081608260836084608560866087608860896090609160926093609460956096609760986099610061016102610361046105610661076108610961106111611261136114611561166117611861196120612161226123612461256126612761286129613061316132613361346135613661376138613961406141614261436144614561466147614861496150615161526153615461556156615761586159616061616162616361646165616661676168616961706171617261736174617561766177617861796180618161826183618461856186618761886189619061916192619361946195619661976198619962006201620262036204620562066207620862096210621162126213621462156216621762186219622062216222622362246225622662276228622962306231623262336234623562366237623862396240624162426243624462456246624762486249625062516252625362546255625662576258625962606261626262636264626562666267626862696270627162726273627462756276627762786279628062816282628362846285628662876288628962906291629262936294629562966297629862996300630163026303630463056306630763086309631063116312631363146315631663176318631963206321632263236324632563266327632863296330633163326333633463356336633763386339634063416342634363446345634663476348634963506351635263536354635563566357635863596360636163626363636463656366636763686369637063716372637363746375637663776378637963806381638263836384638563866387638863896390639163926393639463956396639763986399640064016402640364046405640664076408640964106411641264136414641564166417641864196420642164226423642464256426642764286429643064316432643364346435643664376438643964406441644264436444644564466447644864496450645164526453645464556456645764586459646064616462646364646465646664676468646964706471647264736474647564766477647864796480648164826483648464856486648764886489649064916492649364946495649664976498649965006501650265036504650565066507650865096510651165126513651465156516651765186519652065216522652365246525652665276528652965306531653265336534653565366537653865396540654165426543654465456546654765486549655065516552655365546555655665576558655965606561656265636564656565666567656865696570657165726573657465756576657765786579658065816582658365846585658665876588658965906591659265936594659565966597659865996600660166026603660466056606660766086609661066116612661366146615661666176618661966206621662266236624662566266627662866296630663166326633663466356636663766386639664066416642664366446645664666476648664966506651665266536654665566566657665866596660666166626663666466656666666766686669667066716672667366746675667666776678667966806681668266836684668566866687668866896690669166926693669466956696669766986699670067016702670367046705670667076708670967106711671267136714671567166717671867196720672167226723672467256726672767286729673067316732673367346735673667376738673967406741674267436744674567466747674867496750675167526753675467556756675767586759676067616762676367646765676667676768676967706771677267736774677567766777677867796780678167826783678467856786678767886789679067916792679367946795679667976798679968006801680268036804680568066807680868096810681168126813681468156816681768186819682068216822682368246825682668276828682968306831683268336834683568366837683868396840684168426843684468456846684768486849685068516852685368546855685668576858685968606861686268636864686568666867686868696870687168726873687468756876687768786879688068816882688368846885688668876888688968906891689268936894689568966897689868996900690169026903690469056906690769086909691069116912691369146915691669176918691969206921692269236924692569266927692869296930693169326933693469356936693769386939694069416942694369446945694669476948694969506951695269536954695569566957695869596960696169626963696469656966696769686969697069716972697369746975697669776978697969806981698269836984698569866987698869896990699169926993699469956996699769986999700070017002700370047005700670077008700970107011701270137014701570167017701870197020702170227023702470257026702770287029703070317032703370347035703670377038703970407041704270437044704570467047704870497050705170527053705470557056705770587059706070617062706370647065706670677068706970707071707270737074707570767077707870797080708170827083708470857086708770887089709070917092709370947095709670977098709971007101710271037104710571067107710871097110711171127113711471157116711771187119712071217122712371247125712671277128712971307131713271337134713571367137713871397140714171427143714471457146714771487149715071517152715371547155715671577158715971607161716271637164716571667167716871697170717171727173717471757176717771787179718071817182718371847185718671877188718971907191719271937194719571967197719871997200720172027203720472057206720772087209721072117212721372147215721672177218721972207221722272237224722572267227722872297230723172327233723472357236723772387239724072417242724372447245724672477248724972507251725272537254725572567257725872597260726172627263726472657266726772687269727072717272727372747275727672777278727972807281728272837284728572867287728872897290729172927293729472957296729772987299730073017302730373047305730673077308730973107311731273137314731573167317731873197320732173227323732473257326732773287329733073317332733373347335733673377338733973407341734273437344734573467347734873497350735173527353735473557356735773587359736073617362736373647365736673677368736973707371737273737374737573767377737873797380738173827383738473857386738773887389739073917392739373947395739673977398739974007401740274037404740574067407740874097410741174127413741474157416741774187419742074217422742374247425742674277428742974307431743274337434743574367437743874397440744174427443744474457446744774487449745074517452745374547455745674577458745974607461746274637464746574667467746874697470747174727473747474757476747774787479748074817482748374847485748674877488748974907491749274937494749574967497749874997500750175027503750475057506750775087509751075117512751375147515751675177518751975207521752275237524752575267527752875297530753175327533753475357536753775387539754075417542754375447545754675477548754975507551755275537554755575567557755875597560756175627563756475657566756775687569757075717572757375747575757675777578757975807581758275837584758575867587758875897590759175927593759475957596759775987599760076017602760376047605760676077608760976107611761276137614761576167617761876197620762176227623762476257626762776287629763076317632763376347635763676377638763976407641764276437644764576467647764876497650765176527653765476557656765776587659766076617662766376647665766676677668766976707671767276737674767576767677767876797680768176827683768476857686768776887689769076917692769376947695769676977698769977007701770277037704770577067707770877097710771177127713771477157716771777187719772077217722772377247725772677277728772977307731773277337734773577367737773877397740774177427743774477457746774777487749775077517752775377547755775677577758775977607761776277637764776577667767776877697770777177727773777477757776777777787779778077817782778377847785778677877788778977907791779277937794779577967797779877997800780178027803780478057806780778087809781078117812781378147815781678177818781978207821782278237824782578267827782878297830783178327833783478357836783778387839784078417842784378447845784678477848784978507851785278537854785578567857785878597860786178627863786478657866786778687869787078717872787378747875787678777878787978807881788278837884788578867887788878897890789178927893789478957896789778987899790079017902790379047905790679077908790979107911791279137914791579167917791879197920792179227923792479257926792779287929793079317932793379347935793679377938793979407941794279437944794579467947794879497950795179527953795479557956795779587959796079617962796379647965796679677968796979707971797279737974797579767977797879797980798179827983798479857986798779887989799079917992799379947995799679977998799980008001800280038004800580068007800880098010801180128013801480158016801780188019802080218022802380248025802680278028802980308031803280338034803580368037803880398040804180428043804480458046804780488049805080518052805380548055805680578058805980608061806280638064806580668067806880698070807180728073807480758076807780788079808080818082808380848085808680878088808980908091809280938094809580968097809880998100810181028103810481058106810781088109811081118112811381148115811681178118811981208121812281238124812581268127812881298130813181328133813481358136813781388139814081418142814381448145814681478148814981508151815281538154815581568157815881598160816181628163816481658166816781688169817081718172817381748175817681778178817981808181818281838184818581868187818881898190819181928193819481958196819781988199820082018202820382048205820682078208820982108211821282138214821582168217821882198220822182228223822482258226822782288229823082318232823382348235823682378238823982408241824282438244824582468247824882498250825182528253825482558256825782588259826082618262826382648265826682678268826982708271827282738274827582768277827882798280828182828283828482858286828782888289829082918292829382948295829682978298829983008301830283038304830583068307830883098310831183128313831483158316831783188319832083218322832383248325832683278328832983308331833283338334833583368337833883398340834183428343834483458346834783488349835083518352835383548355835683578358835983608361836283638364836583668367836883698370837183728373837483758376837783788379838083818382838383848385838683878388838983908391839283938394839583968397839883998400840184028403840484058406840784088409841084118412841384148415841684178418841984208421842284238424842584268427842884298430843184328433843484358436843784388439844084418442844384448445844684478448844984508451845284538454845584568457845884598460846184628463846484658466846784688469847084718472847384748475847684778478847984808481848284838484848584868487848884898490849184928493849484958496849784988499850085018502850385048505850685078508850985108511851285138514851585168517851885198520852185228523852485258526852785288529853085318532853385348535853685378538853985408541854285438544854585468547854885498550855185528553855485558556855785588559856085618562856385648565856685678568856985708571857285738574857585768577857885798580858185828583858485858586858785888589859085918592859385948595859685978598859986008601860286038604860586068607860886098610861186128613861486158616861786188619862086218622862386248625862686278628862986308631863286338634863586368637863886398640864186428643864486458646864786488649865086518652865386548655865686578658865986608661866286638664866586668667866886698670867186728673867486758676867786788679868086818682868386848685868686878688868986908691869286938694869586968697869886998700870187028703870487058706870787088709871087118712871387148715871687178718871987208721872287238724872587268727872887298730873187328733873487358736873787388739874087418742874387448745874687478748874987508751875287538754875587568757875887598760876187628763876487658766876787688769877087718772877387748775877687778778877987808781878287838784878587868787878887898790879187928793879487958796879787988799880088018802880388048805880688078808880988108811881288138814881588168817881888198820882188228823882488258826882788288829883088318832883388348835883688378838883988408841884288438844884588468847884888498850885188528853885488558856885788588859886088618862886388648865886688678868886988708871887288738874887588768877887888798880888188828883888488858886888788888889889088918892889388948895889688978898889989008901890289038904890589068907890889098910891189128913891489158916891789188919892089218922892389248925892689278928892989308931893289338934893589368937893889398940894189428943894489458946894789488949895089518952895389548955895689578958895989608961896289638964896589668967896889698970897189728973897489758976897789788979898089818982898389848985898689878988898989908991899289938994899589968997899889999000900190029003900490059006900790089009901090119012901390149015901690179018901990209021902290239024902590269027902890299030903190329033903490359036903790389039904090419042904390449045904690479048904990509051905290539054905590569057905890599060906190629063906490659066906790689069907090719072907390749075907690779078907990809081908290839084908590869087908890899090909190929093909490959096909790989099910091019102910391049105910691079108910991109111911291139114911591169117911891199120912191229123912491259126912791289129913091319132913391349135913691379138913991409141914291439144914591469147914891499150915191529153915491559156915791589159916091619162916391649165916691679168916991709171917291739174917591769177917891799180918191829183918491859186918791889189919091919192919391949195919691979198919992009201920292039204920592069207920892099210921192129213921492159216921792189219922092219222922392249225922692279228922992309231923292339234923592369237923892399240924192429243924492459246924792489249925092519252925392549255925692579258925992609261926292639264926592669267926892699270927192729273927492759276927792789279928092819282928392849285928692879288928992909291929292939294929592969297929892999300930193029303930493059306930793089309931093119312931393149315931693179318931993209321932293239324932593269327932893299330933193329333933493359336933793389339934093419342934393449345934693479348934993509351935293539354935593569357935893599360936193629363936493659366936793689369937093719372937393749375937693779378937993809381938293839384938593869387938893899390939193929393939493959396939793989399940094019402940394049405940694079408940994109411941294139414941594169417941894199420942194229423942494259426942794289429943094319432943394349435943694379438943994409441944294439444944594469447944894499450945194529453945494559456945794589459946094619462946394649465946694679468946994709471947294739474947594769477947894799480948194829483948494859486948794889489949094919492949394949495949694979498949995009501950295039504950595069507950895099510951195129513951495159516951795189519952095219522952395249525952695279528952995309531953295339534953595369537953895399540954195429543954495459546954795489549955095519552955395549555955695579558955995609561956295639564956595669567956895699570957195729573957495759576957795789579958095819582958395849585958695879588958995909591959295939594959595969597959895999600960196029603960496059606960796089609961096119612961396149615961696179618961996209621962296239624962596269627962896299630963196329633963496359636963796389639964096419642964396449645964696479648964996509651965296539654965596569657965896599660966196629663966496659666966796689669967096719672967396749675967696779678967996809681968296839684968596869687968896899690969196929693969496959696969796989699970097019702970397049705970697079708970997109711971297139714971597169717971897199720972197229723972497259726972797289729973097319732973397349735973697379738973997409741974297439744974597469747974897499750975197529753975497559756975797589759976097619762976397649765976697679768976997709771977297739774977597769777977897799780978197829783978497859786978797889789979097919792979397949795979697979798979998009801980298039804980598069807980898099810981198129813981498159816981798189819982098219822982398249825982698279828982998309831983298339834983598369837983898399840984198429843984498459846984798489849985098519852985398549855985698579858985998609861986298639864986598669867986898699870987198729873987498759876987798789879988098819882988398849885988698879888988998909891989298939894989598969897989898999900990199029903990499059906990799089909991099119912991399149915991699179918991999209921992299239924992599269927992899299930993199329933993499359936993799389939994099419942994399449945994699479948994999509951995299539954995599569957995899599960996199629963996499659966996799689969997099719972997399749975997699779978997999809981998299839984998599869987998899899990999199929993999499959996999799989999100001000110002100031000410005100061000710008100091001010011100121001310014100151001610017100181001910020100211002210023100241002510026100271002810029100301003110032100331003410035100361003710038100391004010041100421004310044100451004610047100481004910050100511005210053100541005510056100571005810059100601006110062100631006410065100661006710068100691007010071100721007310074100751007610077100781007910080100811008210083100841008510086100871008810089100901009110092100931009410095100961009710098100991010010101101021010310104101051010610107101081010910110101111011210113101141011510116101171011810119101201012110122101231012410125101261012710128101291013010131101321013310134101351013610137101381013910140101411014210143101441014510146101471014810149101501015110152101531015410155101561015710158101591016010161101621016310164101651016610167101681016910170101711017210173101741017510176101771017810179101801018110182101831018410185101861018710188101891019010191101921019310194101951019610197101981019910200102011020210203102041020510206102071020810209102101021110212102131021410215102161021710218102191022010221102221022310224102251022610227102281022910230102311023210233102341023510236102371023810239102401024110242102431024410245102461024710248102491025010251102521025310254102551025610257102581025910260102611026210263102641026510266102671026810269102701027110272102731027410275102761027710278102791028010281102821028310284102851028610287102881028910290102911029210293102941029510296102971029810299103001030110302103031030410305103061030710308103091031010311103121031310314103151031610317103181031910320103211032210323103241032510326103271032810329103301033110332103331033410335103361033710338103391034010341103421034310344103451034610347103481034910350103511035210353103541035510356103571035810359103601036110362103631036410365103661036710368103691037010371103721037310374103751037610377103781037910380103811038210383103841038510386103871038810389103901039110392103931039410395103961039710398103991040010401104021040310404104051040610407104081040910410104111041210413104141041510416104171041810419104201042110422104231042410425104261042710428104291043010431104321043310434104351043610437104381043910440104411044210443104441044510446104471044810449104501045110452104531045410455104561045710458104591046010461104621046310464104651046610467104681046910470104711047210473104741047510476104771047810479104801048110482104831048410485104861048710488104891049010491104921049310494104951049610497104981049910500105011050210503105041050510506105071050810509105101051110512105131051410515105161051710518105191052010521105221052310524105251052610527105281052910530105311053210533105341053510536105371053810539105401054110542105431054410545105461054710548105491055010551105521055310554105551055610557105581055910560105611056210563105641056510566105671056810569105701057110572105731057410575105761057710578105791058010581105821058310584105851058610587105881058910590105911059210593105941059510596105971059810599106001060110602106031060410605106061060710608106091061010611106121061310614106151061610617106181061910620106211062210623106241062510626106271062810629106301063110632106331063410635106361063710638106391064010641106421064310644106451064610647106481064910650106511065210653106541065510656106571065810659106601066110662106631066410665106661066710668106691067010671106721067310674106751067610677106781067910680106811068210683106841068510686106871068810689106901069110692106931069410695106961069710698106991070010701107021070310704107051070610707107081070910710107111071210713107141071510716107171071810719107201072110722107231072410725107261072710728107291073010731107321073310734107351073610737107381073910740107411074210743107441074510746107471074810749107501075110752107531075410755107561075710758107591076010761107621076310764107651076610767107681076910770107711077210773107741077510776107771077810779107801078110782107831078410785107861078710788107891079010791107921079310794107951079610797107981079910800108011080210803108041080510806108071080810809108101081110812108131081410815108161081710818108191082010821108221082310824108251082610827108281082910830108311083210833108341083510836108371083810839108401084110842108431084410845108461084710848108491085010851108521085310854108551085610857108581085910860108611086210863108641086510866108671086810869108701087110872108731087410875108761087710878108791088010881108821088310884108851088610887108881088910890108911089210893108941089510896108971089810899109001090110902109031090410905109061090710908109091091010911109121091310914109151091610917109181091910920109211092210923109241092510926109271092810929109301093110932109331093410935109361093710938109391094010941109421094310944109451094610947109481094910950109511095210953109541095510956109571095810959109601096110962109631096410965109661096710968109691097010971109721097310974109751097610977109781097910980109811098210983109841098510986109871098810989109901099110992109931099410995109961099710998109991100011001110021100311004110051100611007110081100911010110111101211013110141101511016110171101811019110201102111022110231102411025110261102711028110291103011031110321103311034110351103611037110381103911040110411104211043110441104511046110471104811049110501105111052110531105411055110561105711058110591106011061110621106311064110651106611067110681106911070110711107211073110741107511076110771107811079110801108111082110831108411085110861108711088110891109011091110921109311094110951109611097110981109911100111011110211103111041110511106111071110811109111101111111112111131111411115111161111711118111191112011121111221112311124111251112611127111281112911130111311113211133111341113511136111371113811139111401114111142111431114411145111461114711148111491115011151111521115311154111551115611157111581115911160111611116211163111641116511166111671116811169111701117111172111731117411175111761117711178111791118011181111821118311184111851118611187111881118911190111911119211193111941119511196111971119811199112001120111202112031120411205112061120711208112091121011211112121121311214112151121611217112181121911220112211122211223112241122511226112271122811229112301123111232112331123411235112361123711238112391124011241112421124311244112451124611247112481124911250112511125211253112541125511256112571125811259112601126111262112631126411265112661126711268112691127011271112721127311274112751127611277112781127911280112811128211283112841128511286112871128811289112901129111292112931129411295112961129711298112991130011301113021130311304113051130611307113081130911310113111131211313113141131511316113171131811319113201132111322113231132411325113261132711328113291133011331113321133311334113351133611337113381133911340113411134211343113441134511346113471134811349113501135111352113531135411355113561135711358113591136011361113621136311364113651136611367113681136911370113711137211373113741137511376113771137811379113801138111382113831138411385113861138711388113891139011391113921139311394113951139611397113981139911400114011140211403114041140511406114071140811409114101141111412114131141411415114161141711418114191142011421114221142311424114251142611427114281142911430114311143211433114341143511436114371143811439114401144111442114431144411445114461144711448114491145011451114521145311454114551145611457114581145911460114611146211463114641146511466114671146811469114701147111472114731147411475114761147711478114791148011481114821148311484114851148611487114881148911490114911149211493114941149511496114971149811499115001150111502115031150411505115061150711508115091151011511115121151311514115151151611517115181151911520115211152211523115241152511526115271152811529115301153111532115331153411535115361153711538115391154011541115421154311544115451154611547115481154911550115511155211553115541155511556115571155811559115601156111562115631156411565115661156711568115691157011571115721157311574115751157611577115781157911580115811158211583115841158511586115871158811589115901159111592115931159411595115961159711598115991160011601116021160311604116051160611607116081160911610116111161211613116141161511616116171161811619116201162111622116231162411625116261162711628116291163011631116321163311634116351163611637116381163911640116411164211643116441164511646116471164811649116501165111652116531165411655116561165711658116591166011661116621166311664116651166611667116681166911670116711167211673116741167511676116771167811679116801168111682116831168411685116861168711688116891169011691116921169311694116951169611697116981169911700117011170211703117041170511706117071170811709117101171111712117131171411715117161171711718117191172011721117221172311724117251172611727117281172911730117311173211733117341173511736117371173811739117401174111742117431174411745117461174711748117491175011751117521175311754117551175611757117581175911760117611176211763117641176511766117671176811769117701177111772117731177411775117761177711778117791178011781117821178311784117851178611787117881178911790117911179211793117941179511796117971179811799118001180111802118031180411805118061180711808118091181011811118121181311814118151181611817118181181911820118211182211823118241182511826118271182811829118301183111832118331183411835118361183711838118391184011841118421184311844118451184611847118481184911850118511185211853118541185511856118571185811859118601186111862118631186411865118661186711868118691187011871118721187311874118751187611877118781187911880118811188211883118841188511886118871188811889118901189111892118931189411895118961189711898118991190011901119021190311904119051190611907119081190911910119111191211913119141191511916119171191811919119201192111922119231192411925119261192711928119291193011931119321193311934119351193611937119381193911940119411194211943119441194511946119471194811949119501195111952119531195411955119561195711958119591196011961119621196311964119651196611967119681196911970119711197211973119741197511976119771197811979119801198111982119831198411985119861198711988119891199011991119921199311994119951199611997119981199912000120011200212003120041200512006120071200812009120101201112012120131201412015120161201712018120191202012021120221202312024120251202612027120281202912030120311203212033120341203512036120371203812039120401204112042120431204412045120461204712048120491205012051120521205312054120551205612057120581205912060120611206212063120641206512066120671206812069120701207112072120731207412075120761207712078120791208012081120821208312084120851208612087120881208912090120911209212093120941209512096120971209812099121001210112102121031210412105121061210712108121091211012111121121211312114121151211612117121181211912120121211212212123121241212512126121271212812129121301213112132121331213412135121361213712138121391214012141121421214312144121451214612147121481214912150121511215212153121541215512156121571215812159121601216112162121631216412165121661216712168121691217012171121721217312174121751217612177121781217912180121811218212183121841218512186121871218812189121901219112192121931219412195121961219712198121991220012201122021220312204122051220612207122081220912210122111221212213122141221512216122171221812219122201222112222122231222412225122261222712228122291223012231122321223312234122351223612237122381223912240122411224212243122441224512246122471224812249122501225112252122531225412255122561225712258122591226012261122621226312264122651226612267122681226912270122711227212273122741227512276122771227812279122801228112282122831228412285122861228712288122891229012291122921229312294122951229612297122981229912300123011230212303123041230512306123071230812309123101231112312123131231412315123161231712318123191232012321123221232312324123251232612327123281232912330123311233212333123341233512336123371233812339123401234112342123431234412345123461234712348123491235012351123521235312354123551235612357123581235912360123611236212363123641236512366123671236812369123701237112372123731237412375123761237712378123791238012381123821238312384123851238612387123881238912390123911239212393123941239512396123971239812399124001240112402124031240412405124061240712408124091241012411124121241312414124151241612417124181241912420124211242212423124241242512426124271242812429124301243112432124331243412435124361243712438124391244012441124421244312444124451244612447124481244912450124511245212453124541245512456124571245812459124601246112462124631246412465124661246712468124691247012471124721247312474124751247612477124781247912480124811248212483124841248512486124871248812489124901249112492124931249412495124961249712498124991250012501125021250312504125051250612507125081250912510125111251212513125141251512516125171251812519125201252112522125231252412525125261252712528125291253012531125321253312534125351253612537125381253912540125411254212543125441254512546125471254812549125501255112552125531255412555125561255712558125591256012561125621256312564125651256612567125681256912570125711257212573125741257512576125771257812579125801258112582125831258412585125861258712588125891259012591125921259312594125951259612597125981259912600126011260212603126041260512606126071260812609126101261112612126131261412615126161261712618126191262012621126221262312624126251262612627126281262912630126311263212633126341263512636126371263812639126401264112642126431264412645126461264712648126491265012651126521265312654126551265612657126581265912660126611266212663126641266512666126671266812669126701267112672126731267412675126761267712678126791268012681126821268312684126851268612687126881268912690126911269212693126941269512696126971269812699127001270112702127031270412705127061270712708127091271012711127121271312714127151271612717127181271912720127211272212723127241272512726127271272812729127301273112732127331273412735127361273712738127391274012741127421274312744127451274612747127481274912750127511275212753127541275512756127571275812759127601276112762127631276412765127661276712768127691277012771127721277312774127751277612777127781277912780127811278212783127841278512786127871278812789127901279112792127931279412795127961279712798127991280012801128021280312804128051280612807128081280912810128111281212813128141281512816128171281812819128201282112822128231282412825128261282712828128291283012831128321283312834128351283612837128381283912840128411284212843128441284512846128471284812849128501285112852128531285412855128561285712858128591286012861128621286312864128651286612867128681286912870128711287212873128741287512876128771287812879128801288112882128831288412885128861288712888128891289012891128921289312894128951289612897128981289912900129011290212903129041290512906129071290812909129101291112912129131291412915129161291712918129191292012921129221292312924129251292612927129281292912930129311293212933129341293512936129371293812939129401294112942129431294412945129461294712948129491295012951129521295312954129551295612957129581295912960129611296212963129641296512966129671296812969129701297112972129731297412975129761297712978129791298012981129821298312984129851298612987129881298912990129911299212993129941299512996129971299812999130001300113002130031300413005130061300713008130091301013011130121301313014130151301613017130181301913020130211302213023130241302513026130271302813029130301303113032130331303413035130361303713038130391304013041130421304313044130451304613047130481304913050130511305213053130541305513056130571305813059130601306113062130631306413065130661306713068130691307013071130721307313074130751307613077130781307913080130811308213083130841308513086130871308813089130901309113092130931309413095130961309713098130991310013101131021310313104131051310613107131081310913110131111311213113131141311513116131171311813119131201312113122131231312413125131261312713128131291313013131131321313313134131351313613137131381313913140131411314213143131441314513146131471314813149131501315113152131531315413155131561315713158131591316013161131621316313164131651316613167131681316913170131711317213173131741317513176131771317813179131801318113182131831318413185131861318713188131891319013191131921319313194131951319613197131981319913200132011320213203132041320513206132071320813209132101321113212132131321413215132161321713218132191322013221132221322313224132251322613227132281322913230132311323213233132341323513236132371323813239132401324113242132431324413245132461324713248132491325013251132521325313254132551325613257132581325913260132611326213263132641326513266132671326813269132701327113272132731327413275132761327713278132791328013281132821328313284132851328613287132881328913290132911329213293132941329513296132971329813299133001330113302133031330413305133061330713308133091331013311133121331313314133151331613317133181331913320133211332213323133241332513326133271332813329133301333113332133331333413335133361333713338133391334013341133421334313344133451334613347133481334913350133511335213353133541335513356133571335813359133601336113362133631336413365133661336713368133691337013371133721337313374133751337613377133781337913380133811338213383133841338513386133871338813389133901339113392133931339413395133961339713398133991340013401134021340313404134051340613407134081340913410134111341213413134141341513416134171341813419134201342113422134231342413425134261342713428134291343013431134321343313434134351343613437134381343913440134411344213443134441344513446134471344813449134501345113452134531345413455134561345713458134591346013461134621346313464134651346613467134681346913470134711347213473134741347513476134771347813479134801348113482134831348413485134861348713488134891349013491134921349313494134951349613497134981349913500135011350213503135041350513506135071350813509135101351113512135131351413515135161351713518135191352013521135221352313524135251352613527135281352913530135311353213533135341353513536135371353813539135401354113542135431354413545135461354713548135491355013551135521355313554135551355613557135581355913560135611356213563135641356513566135671356813569135701357113572135731357413575135761357713578135791358013581135821358313584135851358613587135881358913590135911359213593135941359513596135971359813599136001360113602136031360413605136061360713608136091361013611136121361313614136151361613617136181361913620136211362213623136241362513626136271362813629136301363113632136331363413635136361363713638136391364013641136421364313644136451364613647136481364913650136511365213653136541365513656136571365813659136601366113662136631366413665136661366713668136691367013671136721367313674136751367613677136781367913680136811368213683136841368513686136871368813689136901369113692136931369413695136961369713698136991370013701137021370313704137051370613707137081370913710137111371213713137141371513716137171371813719137201372113722137231372413725137261372713728137291373013731137321373313734137351373613737137381373913740137411374213743137441374513746137471374813749137501375113752137531375413755137561375713758137591376013761137621376313764137651376613767137681376913770137711377213773137741377513776137771377813779137801378113782137831378413785137861378713788137891379013791137921379313794137951379613797137981379913800138011380213803138041380513806138071380813809138101381113812138131381413815138161381713818138191382013821138221382313824138251382613827138281382913830138311383213833138341383513836138371383813839138401384113842138431384413845138461384713848138491385013851138521385313854138551385613857138581385913860138611386213863138641386513866138671386813869138701387113872138731387413875138761387713878138791388013881138821388313884138851388613887138881388913890138911389213893138941389513896138971389813899139001390113902139031390413905139061390713908139091391013911139121391313914139151391613917139181391913920139211392213923139241392513926139271392813929139301393113932139331393413935139361393713938139391394013941139421394313944139451394613947139481394913950139511395213953139541395513956139571395813959139601396113962139631396413965139661396713968139691397013971139721397313974139751397613977139781397913980139811398213983139841398513986139871398813989139901399113992139931399413995139961399713998139991400014001140021400314004140051400614007140081400914010140111401214013140141401514016140171401814019140201402114022140231402414025140261402714028140291403014031140321403314034140351403614037140381403914040140411404214043140441404514046140471404814049140501405114052140531405414055140561405714058140591406014061140621406314064140651406614067140681406914070140711407214073140741407514076140771407814079140801408114082140831408414085140861408714088140891409014091140921409314094140951409614097140981409914100141011410214103141041410514106141071410814109141101411114112141131411414115141161411714118141191412014121141221412314124141251412614127141281412914130141311413214133141341413514136141371413814139141401414114142141431414414145141461414714148141491415014151141521415314154141551415614157141581415914160141611416214163141641416514166141671416814169141701417114172141731417414175141761417714178141791418014181141821418314184141851418614187141881418914190141911419214193141941419514196141971419814199142001420114202142031420414205142061420714208142091421014211142121421314214142151421614217142181421914220142211422214223142241422514226142271422814229142301423114232142331423414235142361423714238142391424014241142421424314244142451424614247142481424914250142511425214253142541425514256142571425814259142601426114262142631426414265142661426714268142691427014271142721427314274142751427614277142781427914280142811428214283142841428514286142871428814289142901429114292142931429414295142961429714298142991430014301143021430314304143051430614307143081430914310143111431214313143141431514316143171431814319143201432114322143231432414325143261432714328143291433014331143321433314334143351433614337143381433914340143411434214343143441434514346143471434814349143501435114352143531435414355143561435714358143591436014361143621436314364143651436614367143681436914370143711437214373143741437514376143771437814379143801438114382143831438414385143861438714388143891439014391143921439314394143951439614397143981439914400144011440214403144041440514406144071440814409144101441114412144131441414415144161441714418144191442014421144221442314424144251442614427144281442914430144311443214433144341443514436144371443814439144401444114442144431444414445144461444714448144491445014451144521445314454144551445614457144581445914460144611446214463144641446514466144671446814469144701447114472144731447414475144761447714478144791448014481144821448314484144851448614487144881448914490144911449214493144941449514496144971449814499145001450114502145031450414505145061450714508145091451014511145121451314514145151451614517145181451914520145211452214523145241452514526145271452814529145301453114532145331453414535145361453714538145391454014541145421454314544145451454614547145481454914550145511455214553145541455514556145571455814559145601456114562145631456414565145661456714568145691457014571145721457314574145751457614577145781457914580145811458214583145841458514586145871458814589145901459114592145931459414595145961459714598145991460014601146021460314604146051460614607146081460914610146111461214613146141461514616146171461814619146201462114622146231462414625146261462714628146291463014631146321463314634146351463614637146381463914640146411464214643146441464514646146471464814649146501465114652146531465414655146561465714658146591466014661146621466314664146651466614667146681466914670146711467214673146741467514676146771467814679146801468114682146831468414685146861468714688146891469014691146921469314694146951469614697146981469914700147011470214703147041470514706147071470814709147101471114712147131471414715147161471714718147191472014721147221472314724147251472614727147281472914730147311473214733147341473514736147371473814739147401474114742147431474414745147461474714748147491475014751147521475314754147551475614757147581475914760147611476214763147641476514766147671476814769147701477114772147731477414775147761477714778147791478014781147821478314784147851478614787147881478914790147911479214793147941479514796147971479814799148001480114802148031480414805148061480714808148091481014811148121481314814148151481614817148181481914820148211482214823148241482514826148271482814829148301483114832148331483414835148361483714838148391484014841148421484314844148451484614847148481484914850148511485214853148541485514856148571485814859148601486114862148631486414865148661486714868148691487014871148721487314874148751487614877148781487914880148811488214883148841488514886148871488814889148901489114892148931489414895148961489714898148991490014901149021490314904149051490614907149081490914910149111491214913149141491514916149171491814919149201492114922149231492414925149261492714928149291493014931149321493314934149351493614937149381493914940149411494214943149441494514946149471494814949149501495114952149531495414955149561495714958149591496014961149621496314964149651496614967149681496914970149711497214973149741497514976149771497814979149801498114982149831498414985149861498714988149891499014991149921499314994149951499614997149981499915000150011500215003150041500515006150071500815009150101501115012150131501415015150161501715018150191502015021150221502315024150251502615027150281502915030150311503215033150341503515036150371503815039150401504115042150431504415045150461504715048150491505015051150521505315054150551505615057150581505915060150611506215063150641506515066150671506815069150701507115072150731507415075150761507715078150791508015081150821508315084150851508615087150881508915090150911509215093150941509515096150971509815099151001510115102151031510415105151061510715108151091511015111151121511315114151151511615117151181511915120151211512215123151241512515126151271512815129151301513115132151331513415135151361513715138151391514015141151421514315144151451514615147151481514915150151511515215153151541515515156151571515815159151601516115162151631516415165151661516715168151691517015171151721517315174151751517615177151781517915180151811518215183151841518515186151871518815189151901519115192151931519415195151961519715198151991520015201152021520315204152051520615207152081520915210152111521215213152141521515216152171521815219152201522115222152231522415225152261522715228152291523015231152321523315234152351523615237152381523915240152411524215243152441524515246152471524815249152501525115252152531525415255152561525715258152591526015261152621526315264152651526615267152681526915270152711527215273152741527515276152771527815279152801528115282152831528415285152861528715288152891529015291152921529315294152951529615297152981529915300153011530215303153041530515306153071530815309153101531115312153131531415315153161531715318153191532015321153221532315324153251532615327153281532915330153311533215333153341533515336153371533815339153401534115342153431534415345153461534715348153491535015351153521535315354153551535615357153581535915360153611536215363153641536515366153671536815369153701537115372153731537415375153761537715378153791538015381153821538315384153851538615387153881538915390153911539215393153941539515396153971539815399154001540115402154031540415405154061540715408154091541015411154121541315414154151541615417154181541915420154211542215423154241542515426154271542815429154301543115432154331543415435154361543715438154391544015441154421544315444154451544615447154481544915450154511545215453154541545515456154571545815459154601546115462154631546415465154661546715468154691547015471154721547315474154751547615477154781547915480154811548215483154841548515486154871548815489154901549115492154931549415495154961549715498154991550015501155021550315504155051550615507155081550915510155111551215513155141551515516155171551815519155201552115522155231552415525155261552715528155291553015531155321553315534155351553615537155381553915540155411554215543155441554515546155471554815549155501555115552155531555415555155561555715558155591556015561155621556315564155651556615567155681556915570155711557215573155741557515576155771557815579155801558115582155831558415585155861558715588155891559015591155921559315594155951559615597155981559915600156011560215603156041560515606156071560815609156101561115612156131561415615156161561715618156191562015621156221562315624156251562615627156281562915630156311563215633156341563515636156371563815639156401564115642156431564415645156461564715648156491565015651156521565315654156551565615657156581565915660156611566215663156641566515666156671566815669156701567115672156731567415675156761567715678156791568015681156821568315684156851568615687156881568915690156911569215693156941569515696156971569815699157001570115702157031570415705157061570715708157091571015711157121571315714157151571615717157181571915720157211572215723157241572515726157271572815729157301573115732157331573415735157361573715738157391574015741157421574315744157451574615747157481574915750157511575215753157541575515756157571575815759157601576115762157631576415765157661576715768157691577015771157721577315774157751577615777157781577915780157811578215783157841578515786157871578815789157901579115792157931579415795157961579715798157991580015801158021580315804158051580615807158081580915810158111581215813158141581515816158171581815819158201582115822158231582415825158261582715828158291583015831158321583315834158351583615837158381583915840158411584215843158441584515846158471584815849158501585115852158531585415855158561585715858158591586015861158621586315864158651586615867158681586915870158711587215873158741587515876158771587815879158801588115882158831588415885158861588715888158891589015891158921589315894158951589615897158981589915900159011590215903159041590515906159071590815909159101591115912159131591415915159161591715918159191592015921159221592315924159251592615927159281592915930159311593215933159341593515936159371593815939159401594115942159431594415945159461594715948159491595015951159521595315954159551595615957159581595915960159611596215963159641596515966159671596815969159701597115972159731597415975159761597715978159791598015981159821598315984159851598615987159881598915990159911599215993159941599515996159971599815999160001600116002160031600416005160061600716008160091601016011160121601316014160151601616017160181601916020160211602216023160241602516026160271602816029160301603116032160331603416035160361603716038160391604016041160421604316044160451604616047160481604916050160511605216053160541605516056160571605816059160601606116062160631606416065160661606716068160691607016071160721607316074160751607616077160781607916080160811608216083160841608516086160871608816089160901609116092160931609416095160961609716098160991610016101161021610316104161051610616107161081610916110161111611216113161141611516116161171611816119161201612116122161231612416125161261612716128161291613016131161321613316134161351613616137161381613916140161411614216143161441614516146161471614816149161501615116152161531615416155161561615716158161591616016161161621616316164161651616616167161681616916170161711617216173161741617516176161771617816179161801618116182161831618416185161861618716188161891619016191161921619316194161951619616197161981619916200162011620216203162041620516206162071620816209162101621116212162131621416215162161621716218162191622016221162221622316224162251622616227162281622916230162311623216233162341623516236162371623816239162401624116242162431624416245162461624716248162491625016251162521625316254162551625616257162581625916260162611626216263162641626516266162671626816269162701627116272162731627416275162761627716278162791628016281162821628316284162851628616287162881628916290162911629216293162941629516296162971629816299163001630116302163031630416305163061630716308163091631016311163121631316314163151631616317163181631916320163211632216323163241632516326163271632816329163301633116332163331633416335163361633716338163391634016341163421634316344163451634616347163481634916350163511635216353163541635516356163571635816359163601636116362163631636416365163661636716368163691637016371163721637316374163751637616377163781637916380163811638216383163841638516386163871638816389163901639116392163931639416395163961639716398163991640016401164021640316404164051640616407164081640916410164111641216413164141641516416164171641816419164201642116422164231642416425164261642716428164291643016431164321643316434164351643616437164381643916440164411644216443164441644516446164471644816449164501645116452164531645416455164561645716458164591646016461164621646316464164651646616467164681646916470164711647216473164741647516476164771647816479164801648116482164831648416485164861648716488164891649016491164921649316494164951649616497164981649916500165011650216503165041650516506165071650816509165101651116512165131651416515165161651716518165191652016521165221652316524165251652616527165281652916530165311653216533165341653516536165371653816539165401654116542165431654416545165461654716548165491655016551165521655316554165551655616557165581655916560165611656216563165641656516566165671656816569165701657116572165731657416575165761657716578165791658016581165821658316584165851658616587165881658916590165911659216593165941659516596165971659816599166001660116602166031660416605166061660716608166091661016611166121661316614166151661616617166181661916620166211662216623166241662516626166271662816629166301663116632166331663416635166361663716638166391664016641166421664316644166451664616647166481664916650166511665216653166541665516656166571665816659166601666116662166631666416665166661666716668166691667016671166721667316674166751667616677166781667916680166811668216683166841668516686166871668816689166901669116692166931669416695166961669716698166991670016701167021670316704167051670616707167081670916710167111671216713167141671516716167171671816719167201672116722167231672416725167261672716728167291673016731167321673316734167351673616737167381673916740167411674216743167441674516746167471674816749167501675116752167531675416755167561675716758167591676016761167621676316764167651676616767167681676916770167711677216773167741677516776167771677816779167801678116782167831678416785167861678716788167891679016791167921679316794167951679616797167981679916800168011680216803168041680516806168071680816809168101681116812168131681416815168161681716818168191682016821168221682316824168251682616827168281682916830168311683216833168341683516836168371683816839168401684116842168431684416845168461684716848168491685016851168521685316854168551685616857168581685916860168611686216863168641686516866168671686816869168701687116872168731687416875168761687716878168791688016881168821688316884168851688616887168881688916890168911689216893168941689516896168971689816899169001690116902169031690416905169061690716908169091691016911169121691316914169151691616917169181691916920169211692216923169241692516926169271692816929169301693116932169331693416935169361693716938169391694016941169421694316944169451694616947169481694916950169511695216953169541695516956169571695816959169601696116962169631696416965169661696716968169691697016971169721697316974169751697616977169781697916980169811698216983169841698516986169871698816989169901699116992169931699416995169961699716998169991700017001170021700317004170051700617007170081700917010170111701217013170141701517016170171701817019170201702117022170231702417025170261702717028170291703017031170321703317034170351703617037170381703917040170411704217043170441704517046170471704817049170501705117052170531705417055170561705717058170591706017061170621706317064170651706617067170681706917070170711707217073170741707517076170771707817079170801708117082170831708417085170861708717088170891709017091170921709317094170951709617097170981709917100171011710217103171041710517106171071710817109171101711117112171131711417115171161711717118171191712017121171221712317124171251712617127171281712917130171311713217133171341713517136171371713817139171401714117142171431714417145171461714717148171491715017151171521715317154171551715617157171581715917160171611716217163171641716517166171671716817169171701717117172171731717417175171761717717178171791718017181171821718317184171851718617187171881718917190171911719217193171941719517196171971719817199172001720117202172031720417205172061720717208172091721017211172121721317214172151721617217172181721917220172211722217223172241722517226172271722817229172301723117232172331723417235172361723717238172391724017241172421724317244172451724617247172481724917250172511725217253172541725517256172571725817259172601726117262172631726417265172661726717268172691727017271172721727317274172751727617277172781727917280172811728217283172841728517286172871728817289172901729117292172931729417295172961729717298172991730017301173021730317304173051730617307173081730917310173111731217313173141731517316173171731817319173201732117322173231732417325173261732717328173291733017331173321733317334173351733617337173381733917340173411734217343173441734517346173471734817349173501735117352173531735417355173561735717358173591736017361173621736317364173651736617367173681736917370173711737217373173741737517376173771737817379173801738117382173831738417385173861738717388173891739017391173921739317394173951739617397173981739917400174011740217403174041740517406174071740817409174101741117412174131741417415174161741717418174191742017421174221742317424174251742617427174281742917430174311743217433174341743517436174371743817439174401744117442174431744417445174461744717448174491745017451174521745317454174551745617457174581745917460174611746217463174641746517466174671746817469174701747117472174731747417475174761747717478174791748017481174821748317484174851748617487174881748917490174911749217493174941749517496174971749817499175001750117502175031750417505175061750717508175091751017511175121751317514175151751617517175181751917520175211752217523175241752517526175271752817529175301753117532175331753417535175361753717538175391754017541175421754317544175451754617547175481754917550175511755217553175541755517556175571755817559175601756117562175631756417565175661756717568175691757017571175721757317574175751757617577175781757917580175811758217583175841758517586175871758817589175901759117592175931759417595175961759717598175991760017601176021760317604176051760617607176081760917610176111761217613176141761517616176171761817619176201762117622176231762417625176261762717628176291763017631176321763317634176351763617637176381763917640176411764217643176441764517646176471764817649176501765117652176531765417655176561765717658176591766017661176621766317664176651766617667176681766917670176711767217673176741767517676176771767817679176801768117682176831768417685176861768717688176891769017691176921769317694176951769617697176981769917700177011770217703177041770517706177071770817709177101771117712177131771417715177161771717718177191772017721177221772317724177251772617727177281772917730177311773217733177341773517736177371773817739177401774117742177431774417745177461774717748177491775017751177521775317754177551775617757177581775917760177611776217763177641776517766177671776817769177701777117772177731777417775177761777717778177791778017781177821778317784177851778617787177881778917790177911779217793177941779517796177971779817799178001780117802178031780417805178061780717808178091781017811178121781317814178151781617817178181781917820178211782217823178241782517826178271782817829178301783117832178331783417835178361783717838178391784017841178421784317844178451784617847178481784917850178511785217853178541785517856178571785817859178601786117862178631786417865178661786717868178691787017871178721787317874178751787617877178781787917880178811788217883178841788517886178871788817889178901789117892178931789417895178961789717898178991790017901179021790317904179051790617907179081790917910179111791217913179141791517916179171791817919179201792117922179231792417925179261792717928179291793017931179321793317934179351793617937179381793917940179411794217943179441794517946179471794817949179501795117952179531795417955179561795717958179591796017961179621796317964179651796617967179681796917970179711797217973179741797517976179771797817979179801798117982179831798417985179861798717988179891799017991179921799317994179951799617997179981799918000180011800218003180041800518006180071800818009180101801118012180131801418015180161801718018180191802018021180221802318024180251802618027180281802918030180311803218033180341803518036180371803818039180401804118042180431804418045180461804718048180491805018051180521805318054180551805618057180581805918060180611806218063180641806518066180671806818069180701807118072180731807418075180761807718078180791808018081180821808318084180851808618087180881808918090180911809218093180941809518096180971809818099181001810118102181031810418105181061810718108181091811018111181121811318114181151811618117181181811918120181211812218123181241812518126181271812818129181301813118132181331813418135181361813718138181391814018141181421814318144181451814618147181481814918150181511815218153181541815518156181571815818159181601816118162181631816418165181661816718168181691817018171181721817318174181751817618177181781817918180181811818218183181841818518186181871818818189181901819118192181931819418195181961819718198181991820018201182021820318204182051820618207182081820918210182111821218213182141821518216182171821818219182201822118222182231822418225182261822718228182291823018231182321823318234182351823618237182381823918240182411824218243182441824518246182471824818249182501825118252182531825418255182561825718258182591826018261182621826318264182651826618267182681826918270182711827218273182741827518276182771827818279182801828118282182831828418285182861828718288182891829018291182921829318294182951829618297182981829918300183011830218303183041830518306183071830818309183101831118312183131831418315183161831718318183191832018321183221832318324183251832618327183281832918330183311833218333183341833518336183371833818339183401834118342183431834418345183461834718348183491835018351183521835318354183551835618357183581835918360183611836218363183641836518366183671836818369183701837118372183731837418375183761837718378183791838018381183821838318384183851838618387183881838918390183911839218393183941839518396183971839818399184001840118402184031840418405184061840718408184091841018411184121841318414184151841618417184181841918420184211842218423184241842518426184271842818429184301843118432184331843418435184361843718438184391844018441184421844318444184451844618447184481844918450184511845218453184541845518456184571845818459184601846118462184631846418465184661846718468184691847018471184721847318474184751847618477184781847918480184811848218483184841848518486184871848818489184901849118492184931849418495184961849718498184991850018501185021850318504185051850618507185081850918510185111851218513185141851518516185171851818519185201852118522185231852418525185261852718528185291853018531185321853318534185351853618537185381853918540185411854218543185441854518546185471854818549185501855118552185531855418555185561855718558185591856018561185621856318564185651856618567185681856918570185711857218573185741857518576185771857818579185801858118582185831858418585185861858718588185891859018591185921859318594185951859618597185981859918600186011860218603186041860518606186071860818609186101861118612186131861418615186161861718618186191862018621186221862318624186251862618627186281862918630186311863218633186341863518636186371863818639186401864118642186431864418645186461864718648186491865018651186521865318654186551865618657186581865918660186611866218663186641866518666186671866818669186701867118672186731867418675186761867718678186791868018681186821868318684186851868618687186881868918690186911869218693186941869518696186971869818699187001870118702187031870418705187061870718708187091871018711187121871318714187151871618717187181871918720187211872218723187241872518726187271872818729187301873118732187331873418735187361873718738187391874018741187421874318744187451874618747187481874918750187511875218753187541875518756187571875818759187601876118762187631876418765187661876718768187691877018771187721877318774187751877618777187781877918780187811878218783187841878518786187871878818789187901879118792187931879418795187961879718798187991880018801188021880318804188051880618807188081880918810188111881218813188141881518816188171881818819188201882118822188231882418825188261882718828188291883018831188321883318834188351883618837188381883918840188411884218843188441884518846188471884818849188501885118852188531885418855188561885718858188591886018861188621886318864188651886618867188681886918870188711887218873188741887518876188771887818879188801888118882188831888418885188861888718888188891889018891188921889318894188951889618897188981889918900189011890218903189041890518906189071890818909189101891118912189131891418915189161891718918189191892018921189221892318924189251892618927189281892918930189311893218933189341893518936189371893818939189401894118942189431894418945189461894718948189491895018951189521895318954189551895618957189581895918960189611896218963189641896518966189671896818969189701897118972189731897418975189761897718978189791898018981189821898318984189851898618987189881898918990189911899218993189941899518996189971899818999190001900119002190031900419005190061900719008190091901019011190121901319014190151901619017190181901919020190211902219023190241902519026190271902819029190301903119032190331903419035190361903719038190391904019041190421904319044190451904619047190481904919050190511905219053190541905519056190571905819059190601906119062190631906419065190661906719068190691907019071190721907319074190751907619077190781907919080190811908219083190841908519086190871908819089190901909119092190931909419095190961909719098190991910019101191021910319104191051910619107191081910919110191111911219113191141911519116191171911819119191201912119122191231912419125191261912719128191291913019131191321913319134191351913619137191381913919140191411914219143191441914519146191471914819149191501915119152191531915419155191561915719158191591916019161191621916319164191651916619167191681916919170191711917219173191741917519176191771917819179191801918119182191831918419185191861918719188191891919019191191921919319194191951919619197191981919919200192011920219203192041920519206192071920819209192101921119212192131921419215192161921719218192191922019221192221922319224192251922619227192281922919230192311923219233192341923519236192371923819239192401924119242192431924419245192461924719248192491925019251192521925319254192551925619257192581925919260192611926219263192641926519266192671926819269192701927119272192731927419275192761927719278192791928019281192821928319284192851928619287192881928919290192911929219293192941929519296192971929819299193001930119302193031930419305193061930719308193091931019311193121931319314193151931619317193181931919320193211932219323193241932519326193271932819329193301933119332193331933419335193361933719338193391934019341193421934319344193451934619347193481934919350193511935219353193541935519356193571935819359193601936119362193631936419365193661936719368193691937019371193721937319374193751937619377193781937919380193811938219383193841938519386193871938819389193901939119392193931939419395193961939719398193991940019401194021940319404194051940619407194081940919410194111941219413194141941519416194171941819419194201942119422194231942419425194261942719428194291943019431194321943319434194351943619437194381943919440194411944219443194441944519446194471944819449194501945119452194531945419455194561945719458194591946019461194621946319464194651946619467194681946919470194711947219473194741947519476194771947819479194801948119482194831948419485194861948719488194891949019491194921949319494194951949619497194981949919500195011950219503195041950519506195071950819509195101951119512195131951419515195161951719518195191952019521195221952319524195251952619527195281952919530195311953219533195341953519536195371953819539195401954119542195431954419545195461954719548195491955019551195521955319554195551955619557195581955919560195611956219563195641956519566195671956819569195701957119572195731957419575195761957719578195791958019581195821958319584195851958619587195881958919590195911959219593195941959519596195971959819599196001960119602196031960419605196061960719608196091961019611196121961319614196151961619617196181961919620196211962219623196241962519626196271962819629196301963119632196331963419635196361963719638196391964019641196421964319644196451964619647196481964919650196511965219653196541965519656196571965819659196601966119662196631966419665196661966719668196691967019671196721967319674196751967619677196781967919680196811968219683196841968519686196871968819689196901969119692196931969419695196961969719698196991970019701197021970319704197051970619707197081970919710197111971219713197141971519716197171971819719197201972119722197231972419725197261972719728197291973019731197321973319734197351973619737197381973919740197411974219743197441974519746197471974819749197501975119752197531975419755197561975719758197591976019761197621976319764197651976619767197681976919770197711977219773197741977519776197771977819779197801978119782197831978419785197861978719788197891979019791197921979319794197951979619797197981979919800198011980219803198041980519806198071980819809198101981119812198131981419815198161981719818198191982019821198221982319824198251982619827198281982919830198311983219833198341983519836198371983819839198401984119842198431984419845198461984719848198491985019851198521985319854198551985619857198581985919860198611986219863198641986519866198671986819869198701987119872198731987419875198761987719878198791988019881198821988319884198851988619887198881988919890198911989219893198941989519896198971989819899199001990119902199031990419905199061990719908199091991019911199121991319914199151991619917199181991919920199211992219923199241992519926199271992819929199301993119932199331993419935199361993719938199391994019941199421994319944199451994619947199481994919950199511995219953199541995519956199571995819959199601996119962199631996419965199661996719968199691997019971199721997319974199751997619977199781997919980199811998219983199841998519986199871998819989199901999119992199931999419995199961999719998199992000020001200022000320004200052000620007200082000920010200112001220013200142001520016200172001820019200202002120022200232002420025200262002720028200292003020031200322003320034200352003620037200382003920040200412004220043200442004520046200472004820049200502005120052200532005420055200562005720058200592006020061200622006320064200652006620067200682006920070200712007220073200742007520076200772007820079200802008120082200832008420085200862008720088200892009020091200922009320094200952009620097200982009920100201012010220103201042010520106201072010820109201102011120112201132011420115201162011720118201192012020121201222012320124201252012620127201282012920130201312013220133201342013520136201372013820139201402014120142201432014420145201462014720148201492015020151201522015320154201552015620157201582015920160201612016220163201642016520166201672016820169201702017120172201732017420175201762017720178201792018020181201822018320184201852018620187201882018920190201912019220193201942019520196201972019820199202002020120202202032020420205202062020720208202092021020211202122021320214202152021620217202182021920220202212022220223202242022520226202272022820229202302023120232202332023420235202362023720238202392024020241202422024320244202452024620247202482024920250202512025220253202542025520256202572025820259202602026120262202632026420265202662026720268202692027020271202722027320274202752027620277202782027920280202812028220283202842028520286202872028820289202902029120292202932029420295202962029720298202992030020301203022030320304203052030620307203082030920310203112031220313203142031520316203172031820319203202032120322203232032420325203262032720328203292033020331203322033320334203352033620337203382033920340203412034220343203442034520346203472034820349203502035120352203532035420355203562035720358203592036020361203622036320364203652036620367203682036920370203712037220373203742037520376203772037820379203802038120382203832038420385203862038720388203892039020391203922039320394203952039620397203982039920400204012040220403204042040520406204072040820409204102041120412204132041420415204162041720418204192042020421204222042320424204252042620427204282042920430204312043220433204342043520436204372043820439204402044120442204432044420445204462044720448204492045020451204522045320454204552045620457204582045920460204612046220463204642046520466204672046820469204702047120472204732047420475204762047720478204792048020481204822048320484204852048620487204882048920490204912049220493204942049520496204972049820499205002050120502205032050420505205062050720508205092051020511205122051320514205152051620517205182051920520205212052220523205242052520526205272052820529205302053120532205332053420535205362053720538205392054020541205422054320544205452054620547205482054920550205512055220553205542055520556205572055820559205602056120562205632056420565205662056720568205692057020571205722057320574205752057620577205782057920580205812058220583205842058520586205872058820589205902059120592205932059420595205962059720598205992060020601206022060320604206052060620607206082060920610206112061220613206142061520616206172061820619206202062120622206232062420625206262062720628206292063020631206322063320634206352063620637206382063920640206412064220643206442064520646206472064820649206502065120652206532065420655206562065720658206592066020661206622066320664206652066620667206682066920670206712067220673206742067520676206772067820679206802068120682206832068420685206862068720688206892069020691206922069320694206952069620697206982069920700207012070220703207042070520706207072070820709207102071120712207132071420715207162071720718207192072020721207222072320724207252072620727207282072920730207312073220733207342073520736207372073820739207402074120742207432074420745207462074720748207492075020751207522075320754207552075620757207582075920760207612076220763207642076520766207672076820769207702077120772207732077420775207762077720778207792078020781207822078320784207852078620787207882078920790207912079220793207942079520796207972079820799208002080120802208032080420805208062080720808208092081020811208122081320814208152081620817208182081920820208212082220823208242082520826208272082820829208302083120832208332083420835208362083720838208392084020841208422084320844208452084620847208482084920850208512085220853208542085520856208572085820859208602086120862208632086420865208662086720868208692087020871208722087320874208752087620877208782087920880208812088220883208842088520886208872088820889208902089120892208932089420895208962089720898208992090020901209022090320904209052090620907209082090920910209112091220913209142091520916209172091820919209202092120922209232092420925209262092720928209292093020931209322093320934209352093620937209382093920940209412094220943209442094520946209472094820949209502095120952209532095420955209562095720958209592096020961209622096320964209652096620967209682096920970209712097220973209742097520976209772097820979209802098120982209832098420985209862098720988209892099020991209922099320994209952099620997209982099921000210012100221003210042100521006210072100821009210102101121012210132101421015210162101721018210192102021021210222102321024210252102621027210282102921030210312103221033210342103521036210372103821039210402104121042210432104421045210462104721048210492105021051210522105321054210552105621057210582105921060210612106221063210642106521066210672106821069210702107121072210732107421075210762107721078210792108021081210822108321084210852108621087210882108921090210912109221093210942109521096210972109821099211002110121102211032110421105211062110721108211092111021111211122111321114211152111621117211182111921120211212112221123211242112521126211272112821129211302113121132211332113421135211362113721138211392114021141211422114321144211452114621147211482114921150211512115221153211542115521156211572115821159211602116121162211632116421165211662116721168211692117021171211722117321174211752117621177211782117921180211812118221183211842118521186211872118821189211902119121192211932119421195211962119721198211992120021201212022120321204212052120621207212082120921210212112121221213212142121521216212172121821219212202122121222212232122421225212262122721228212292123021231212322123321234212352123621237212382123921240212412124221243212442124521246212472124821249212502125121252212532125421255212562125721258212592126021261212622126321264212652126621267212682126921270212712127221273212742127521276212772127821279212802128121282212832128421285212862128721288212892129021291212922129321294212952129621297212982129921300213012130221303213042130521306213072130821309213102131121312213132131421315213162131721318213192132021321213222132321324213252132621327213282132921330213312133221333213342133521336213372133821339213402134121342213432134421345213462134721348213492135021351213522135321354213552135621357213582135921360213612136221363213642136521366213672136821369213702137121372213732137421375213762137721378213792138021381213822138321384213852138621387213882138921390213912139221393213942139521396213972139821399214002140121402214032140421405214062140721408214092141021411214122141321414214152141621417214182141921420214212142221423214242142521426214272142821429214302143121432214332143421435214362143721438214392144021441214422144321444214452144621447214482144921450214512145221453214542145521456214572145821459214602146121462214632146421465214662146721468214692147021471214722147321474214752147621477214782147921480214812148221483214842148521486214872148821489214902149121492214932149421495214962149721498214992150021501215022150321504215052150621507215082150921510215112151221513215142151521516215172151821519215202152121522215232152421525215262152721528215292153021531215322153321534215352153621537215382153921540215412154221543215442154521546215472154821549215502155121552215532155421555215562155721558215592156021561215622156321564215652156621567215682156921570215712157221573215742157521576215772157821579215802158121582215832158421585215862158721588215892159021591215922159321594215952159621597215982159921600216012160221603216042160521606216072160821609216102161121612216132161421615216162161721618216192162021621216222162321624216252162621627216282162921630216312163221633216342163521636216372163821639216402164121642216432164421645216462164721648216492165021651216522165321654216552165621657216582165921660216612166221663216642166521666216672166821669216702167121672216732167421675216762167721678216792168021681216822168321684216852168621687216882168921690216912169221693216942169521696216972169821699217002170121702217032170421705217062170721708217092171021711217122171321714217152171621717217182171921720217212172221723217242172521726217272172821729217302173121732217332173421735217362173721738217392174021741217422174321744217452174621747217482174921750217512175221753217542175521756217572175821759217602176121762217632176421765217662176721768217692177021771217722177321774217752177621777217782177921780217812178221783217842178521786217872178821789217902179121792217932179421795217962179721798217992180021801218022180321804218052180621807218082180921810218112181221813218142181521816218172181821819218202182121822218232182421825218262182721828218292183021831218322183321834218352183621837218382183921840218412184221843218442184521846218472184821849218502185121852218532185421855218562185721858218592186021861218622186321864218652186621867218682186921870218712187221873218742187521876218772187821879218802188121882218832188421885218862188721888218892189021891218922189321894218952189621897218982189921900219012190221903219042190521906219072190821909219102191121912219132191421915219162191721918219192192021921219222192321924219252192621927219282192921930219312193221933219342193521936219372193821939219402194121942219432194421945219462194721948219492195021951219522195321954219552195621957219582195921960219612196221963219642196521966219672196821969219702197121972219732197421975219762197721978219792198021981219822198321984219852198621987219882198921990219912199221993219942199521996219972199821999220002200122002220032200422005220062200722008220092201022011220122201322014220152201622017220182201922020220212202222023220242202522026220272202822029220302203122032220332203422035220362203722038220392204022041220422204322044220452204622047220482204922050220512205222053220542205522056220572205822059220602206122062220632206422065220662206722068220692207022071220722207322074220752207622077220782207922080220812208222083220842208522086220872208822089220902209122092220932209422095220962209722098220992210022101221022210322104221052210622107221082210922110221112211222113221142211522116221172211822119221202212122122221232212422125221262212722128221292213022131221322213322134221352213622137221382213922140221412214222143221442214522146221472214822149221502215122152221532215422155221562215722158221592216022161221622216322164221652216622167221682216922170221712217222173221742217522176221772217822179221802218122182221832218422185221862218722188221892219022191221922219322194221952219622197221982219922200222012220222203222042220522206222072220822209222102221122212222132221422215222162221722218222192222022221222222222322224222252222622227222282222922230222312223222233222342223522236222372223822239222402224122242222432224422245222462224722248222492225022251222522225322254222552225622257222582225922260222612226222263222642226522266222672226822269222702227122272222732227422275222762227722278222792228022281222822228322284222852228622287222882228922290222912229222293222942229522296222972229822299223002230122302223032230422305223062230722308223092231022311223122231322314223152231622317223182231922320223212232222323223242232522326223272232822329223302233122332223332233422335223362233722338223392234022341223422234322344223452234622347223482234922350223512235222353223542235522356223572235822359223602236122362223632236422365223662236722368223692237022371223722237322374223752237622377223782237922380223812238222383223842238522386223872238822389223902239122392223932239422395223962239722398223992240022401224022240322404224052240622407224082240922410224112241222413224142241522416224172241822419224202242122422224232242422425224262242722428224292243022431224322243322434224352243622437224382243922440224412244222443224442244522446224472244822449224502245122452224532245422455224562245722458224592246022461224622246322464224652246622467224682246922470224712247222473224742247522476224772247822479224802248122482224832248422485224862248722488224892249022491224922249322494224952249622497224982249922500225012250222503225042250522506225072250822509225102251122512225132251422515225162251722518225192252022521225222252322524225252252622527225282252922530225312253222533225342253522536225372253822539225402254122542225432254422545225462254722548225492255022551225522255322554225552255622557225582255922560225612256222563225642256522566225672256822569225702257122572225732257422575225762257722578225792258022581225822258322584225852258622587225882258922590225912259222593225942259522596225972259822599226002260122602226032260422605226062260722608226092261022611226122261322614226152261622617226182261922620226212262222623226242262522626226272262822629226302263122632226332263422635226362263722638226392264022641226422264322644226452264622647226482264922650226512265222653226542265522656226572265822659226602266122662226632266422665226662266722668226692267022671226722267322674226752267622677226782267922680226812268222683226842268522686226872268822689226902269122692226932269422695226962269722698226992270022701227022270322704227052270622707227082270922710227112271222713227142271522716227172271822719227202272122722227232272422725227262272722728227292273022731227322273322734227352273622737227382273922740227412274222743227442274522746227472274822749227502275122752227532275422755227562275722758227592276022761227622276322764227652276622767227682276922770227712277222773227742277522776227772277822779227802278122782227832278422785227862278722788227892279022791227922279322794227952279622797227982279922800228012280222803228042280522806228072280822809228102281122812228132281422815228162281722818228192282022821228222282322824228252282622827228282282922830228312283222833228342283522836228372283822839228402284122842228432284422845228462284722848228492285022851228522285322854228552285622857228582285922860228612286222863228642286522866228672286822869228702287122872228732287422875228762287722878228792288022881228822288322884228852288622887228882288922890228912289222893228942289522896228972289822899229002290122902229032290422905229062290722908229092291022911229122291322914229152291622917229182291922920229212292222923229242292522926229272292822929229302293122932229332293422935229362293722938229392294022941229422294322944229452294622947229482294922950229512295222953229542295522956229572295822959229602296122962229632296422965229662296722968229692297022971229722297322974229752297622977229782297922980229812298222983229842298522986229872298822989229902299122992229932299422995229962299722998229992300023001230022300323004230052300623007230082300923010230112301223013230142301523016230172301823019230202302123022230232302423025230262302723028230292303023031230322303323034230352303623037230382303923040230412304223043230442304523046230472304823049230502305123052230532305423055230562305723058230592306023061230622306323064230652306623067230682306923070230712307223073230742307523076230772307823079230802308123082230832308423085230862308723088230892309023091230922309323094230952309623097230982309923100231012310223103231042310523106231072310823109231102311123112231132311423115231162311723118231192312023121231222312323124231252312623127231282312923130231312313223133231342313523136231372313823139231402314123142231432314423145231462314723148231492315023151231522315323154231552315623157231582315923160231612316223163231642316523166231672316823169231702317123172231732317423175231762317723178231792318023181231822318323184231852318623187231882318923190231912319223193231942319523196231972319823199232002320123202232032320423205232062320723208232092321023211232122321323214232152321623217232182321923220232212322223223232242322523226232272322823229232302323123232232332323423235232362323723238232392324023241232422324323244232452324623247232482324923250232512325223253232542325523256232572325823259232602326123262232632326423265232662326723268232692327023271232722327323274232752327623277232782327923280232812328223283232842328523286232872328823289232902329123292232932329423295232962329723298232992330023301233022330323304233052330623307233082330923310233112331223313233142331523316233172331823319233202332123322233232332423325233262332723328233292333023331233322333323334233352333623337233382333923340233412334223343233442334523346233472334823349233502335123352233532335423355233562335723358233592336023361233622336323364233652336623367233682336923370233712337223373233742337523376233772337823379233802338123382233832338423385233862338723388233892339023391233922339323394233952339623397233982339923400234012340223403234042340523406234072340823409234102341123412234132341423415234162341723418234192342023421234222342323424234252342623427234282342923430234312343223433234342343523436234372343823439234402344123442234432344423445234462344723448234492345023451234522345323454234552345623457234582345923460234612346223463234642346523466234672346823469234702347123472234732347423475234762347723478234792348023481234822348323484234852348623487234882348923490234912349223493234942349523496234972349823499235002350123502235032350423505235062350723508235092351023511235122351323514235152351623517235182351923520235212352223523235242352523526235272352823529235302353123532235332353423535235362353723538235392354023541235422354323544235452354623547235482354923550235512355223553235542355523556235572355823559235602356123562235632356423565235662356723568235692357023571235722357323574235752357623577235782357923580235812358223583235842358523586235872358823589235902359123592235932359423595235962359723598235992360023601236022360323604236052360623607236082360923610236112361223613236142361523616236172361823619236202362123622236232362423625236262362723628236292363023631236322363323634236352363623637236382363923640236412364223643236442364523646236472364823649236502365123652236532365423655236562365723658236592366023661236622366323664236652366623667236682366923670236712367223673236742367523676236772367823679236802368123682236832368423685236862368723688236892369023691236922369323694236952369623697236982369923700237012370223703237042370523706237072370823709237102371123712237132371423715237162371723718237192372023721237222372323724237252372623727237282372923730237312373223733237342373523736237372373823739237402374123742237432374423745237462374723748237492375023751237522375323754237552375623757237582375923760237612376223763237642376523766237672376823769237702377123772237732377423775237762377723778237792378023781237822378323784237852378623787237882378923790237912379223793237942379523796237972379823799238002380123802238032380423805238062380723808238092381023811238122381323814238152381623817238182381923820238212382223823238242382523826238272382823829238302383123832238332383423835238362383723838238392384023841238422384323844238452384623847238482384923850238512385223853238542385523856238572385823859238602386123862238632386423865238662386723868238692387023871238722387323874238752387623877238782387923880238812388223883238842388523886238872388823889238902389123892238932389423895238962389723898238992390023901239022390323904239052390623907239082390923910239112391223913239142391523916239172391823919239202392123922239232392423925239262392723928239292393023931239322393323934239352393623937239382393923940239412394223943239442394523946239472394823949239502395123952239532395423955239562395723958239592396023961239622396323964239652396623967239682396923970239712397223973239742397523976239772397823979239802398123982239832398423985239862398723988239892399023991239922399323994239952399623997239982399924000240012400224003240042400524006240072400824009240102401124012240132401424015240162401724018240192402024021240222402324024240252402624027240282402924030240312403224033240342403524036240372403824039240402404124042240432404424045240462404724048240492405024051240522405324054240552405624057240582405924060240612406224063240642406524066240672406824069240702407124072240732407424075240762407724078240792408024081240822408324084240852408624087240882408924090240912409224093240942409524096240972409824099241002410124102241032410424105241062410724108241092411024111241122411324114241152411624117241182411924120241212412224123241242412524126241272412824129241302413124132241332413424135241362413724138241392414024141241422414324144241452414624147241482414924150241512415224153241542415524156241572415824159241602416124162241632416424165241662416724168241692417024171241722417324174241752417624177241782417924180241812418224183241842418524186241872418824189241902419124192241932419424195241962419724198241992420024201242022420324204242052420624207242082420924210242112421224213242142421524216242172421824219242202422124222242232422424225242262422724228242292423024231242322423324234242352423624237242382423924240242412424224243242442424524246242472424824249242502425124252242532425424255242562425724258242592426024261242622426324264242652426624267242682426924270242712427224273242742427524276242772427824279242802428124282242832428424285242862428724288242892429024291242922429324294242952429624297242982429924300243012430224303243042430524306243072430824309243102431124312243132431424315243162431724318243192432024321243222432324324243252432624327243282432924330243312433224333243342433524336243372433824339243402434124342243432434424345243462434724348243492435024351243522435324354243552435624357243582435924360243612436224363243642436524366243672436824369243702437124372243732437424375243762437724378243792438024381243822438324384243852438624387243882438924390243912439224393243942439524396243972439824399244002440124402244032440424405244062440724408244092441024411244122441324414244152441624417244182441924420244212442224423244242442524426244272442824429244302443124432244332443424435244362443724438244392444024441244422444324444244452444624447244482444924450244512445224453244542445524456244572445824459244602446124462244632446424465244662446724468244692447024471244722447324474244752447624477244782447924480244812448224483244842448524486244872448824489244902449124492244932449424495244962449724498244992450024501245022450324504245052450624507245082450924510245112451224513245142451524516245172451824519245202452124522245232452424525245262452724528245292453024531245322453324534245352453624537245382453924540245412454224543245442454524546245472454824549245502455124552245532455424555245562455724558245592456024561245622456324564245652456624567245682456924570245712457224573245742457524576245772457824579245802458124582245832458424585245862458724588245892459024591245922459324594245952459624597245982459924600246012460224603246042460524606246072460824609246102461124612246132461424615246162461724618246192462024621246222462324624246252462624627246282462924630246312463224633246342463524636246372463824639246402464124642246432464424645246462464724648246492465024651246522465324654246552465624657246582465924660246612466224663246642466524666246672466824669246702467124672246732467424675246762467724678246792468024681246822468324684246852468624687246882468924690246912469224693246942469524696246972469824699247002470124702247032470424705247062470724708247092471024711247122471324714247152471624717247182471924720247212472224723247242472524726247272472824729247302473124732247332473424735247362473724738247392474024741247422474324744247452474624747247482474924750247512475224753247542475524756247572475824759247602476124762247632476424765247662476724768247692477024771247722477324774247752477624777247782477924780247812478224783247842478524786247872478824789247902479124792247932479424795247962479724798247992480024801248022480324804248052480624807248082480924810248112481224813248142481524816248172481824819248202482124822248232482424825248262482724828248292483024831248322483324834248352483624837248382483924840248412484224843248442484524846248472484824849248502485124852248532485424855248562485724858248592486024861248622486324864248652486624867248682486924870248712487224873248742487524876248772487824879248802488124882248832488424885248862488724888248892489024891248922489324894248952489624897248982489924900249012490224903249042490524906249072490824909249102491124912249132491424915249162491724918249192492024921249222492324924249252492624927249282492924930249312493224933249342493524936249372493824939249402494124942249432494424945249462494724948249492495024951249522495324954249552495624957249582495924960249612496224963249642496524966249672496824969249702497124972249732497424975249762497724978249792498024981249822498324984249852498624987249882498924990249912499224993249942499524996249972499824999250002500125002250032500425005250062500725008250092501025011250122501325014250152501625017250182501925020250212502225023250242502525026250272502825029250302503125032250332503425035250362503725038250392504025041250422504325044250452504625047250482504925050250512505225053250542505525056250572505825059250602506125062250632506425065250662506725068250692507025071250722507325074250752507625077250782507925080250812508225083250842508525086250872508825089250902509125092250932509425095250962509725098250992510025101251022510325104251052510625107251082510925110251112511225113251142511525116251172511825119251202512125122251232512425125251262512725128251292513025131251322513325134251352513625137251382513925140251412514225143251442514525146251472514825149251502515125152251532515425155251562515725158251592516025161251622516325164251652516625167251682516925170251712517225173251742517525176251772517825179251802518125182251832518425185251862518725188251892519025191251922519325194251952519625197251982519925200252012520225203252042520525206252072520825209252102521125212252132521425215252162521725218252192522025221252222522325224252252522625227252282522925230252312523225233252342523525236252372523825239252402524125242252432524425245252462524725248252492525025251252522525325254252552525625257252582525925260252612526225263252642526525266252672526825269252702527125272252732527425275252762527725278252792528025281252822528325284252852528625287252882528925290252912529225293252942529525296252972529825299253002530125302253032530425305253062530725308253092531025311253122531325314253152531625317253182531925320253212532225323253242532525326253272532825329253302533125332253332533425335253362533725338253392534025341253422534325344253452534625347253482534925350253512535225353253542535525356253572535825359253602536125362253632536425365253662536725368253692537025371253722537325374253752537625377253782537925380253812538225383253842538525386253872538825389253902539125392253932539425395253962539725398253992540025401254022540325404254052540625407254082540925410254112541225413254142541525416254172541825419254202542125422254232542425425254262542725428254292543025431254322543325434254352543625437254382543925440254412544225443254442544525446254472544825449254502545125452254532545425455254562545725458254592546025461254622546325464254652546625467254682546925470254712547225473254742547525476254772547825479254802548125482254832548425485254862548725488254892549025491254922549325494254952549625497254982549925500255012550225503255042550525506255072550825509255102551125512255132551425515255162551725518255192552025521255222552325524255252552625527255282552925530255312553225533255342553525536255372553825539255402554125542255432554425545255462554725548255492555025551255522555325554255552555625557255582555925560255612556225563255642556525566255672556825569255702557125572255732557425575255762557725578255792558025581255822558325584255852558625587255882558925590255912559225593255942559525596255972559825599256002560125602256032560425605256062560725608256092561025611256122561325614256152561625617256182561925620256212562225623256242562525626256272562825629256302563125632256332563425635256362563725638256392564025641256422564325644256452564625647256482564925650256512565225653256542565525656256572565825659256602566125662256632566425665256662566725668256692567025671256722567325674256752567625677256782567925680256812568225683256842568525686256872568825689256902569125692256932569425695256962569725698256992570025701257022570325704257052570625707257082570925710257112571225713257142571525716257172571825719257202572125722257232572425725257262572725728257292573025731257322573325734257352573625737257382573925740257412574225743257442574525746257472574825749257502575125752257532575425755257562575725758257592576025761257622576325764257652576625767257682576925770257712577225773257742577525776257772577825779257802578125782257832578425785257862578725788257892579025791257922579325794257952579625797257982579925800258012580225803258042580525806258072580825809258102581125812258132581425815258162581725818258192582025821258222582325824258252582625827258282582925830258312583225833258342583525836258372583825839258402584125842258432584425845258462584725848258492585025851258522585325854258552585625857258582585925860258612586225863258642586525866258672586825869258702587125872258732587425875258762587725878258792588025881258822588325884258852588625887258882588925890258912589225893258942589525896258972589825899259002590125902259032590425905259062590725908259092591025911259122591325914259152591625917259182591925920259212592225923259242592525926259272592825929259302593125932259332593425935259362593725938259392594025941259422594325944259452594625947259482594925950259512595225953259542595525956259572595825959259602596125962259632596425965259662596725968259692597025971259722597325974259752597625977259782597925980259812598225983259842598525986259872598825989259902599125992259932599425995259962599725998259992600026001260022600326004260052600626007260082600926010260112601226013260142601526016260172601826019260202602126022260232602426025260262602726028260292603026031260322603326034260352603626037260382603926040260412604226043260442604526046260472604826049260502605126052260532605426055260562605726058260592606026061260622606326064260652606626067260682606926070260712607226073260742607526076260772607826079260802608126082260832608426085260862608726088260892609026091260922609326094260952609626097260982609926100261012610226103261042610526106261072610826109261102611126112261132611426115261162611726118261192612026121261222612326124261252612626127261282612926130261312613226133261342613526136261372613826139261402614126142261432614426145261462614726148261492615026151261522615326154261552615626157261582615926160261612616226163261642616526166261672616826169261702617126172261732617426175261762617726178261792618026181261822618326184261852618626187261882618926190261912619226193261942619526196261972619826199262002620126202262032620426205262062620726208262092621026211262122621326214262152621626217262182621926220262212622226223262242622526226262272622826229262302623126232262332623426235262362623726238262392624026241262422624326244262452624626247262482624926250262512625226253262542625526256262572625826259262602626126262262632626426265262662626726268262692627026271262722627326274262752627626277262782627926280262812628226283262842628526286262872628826289262902629126292262932629426295262962629726298262992630026301263022630326304263052630626307263082630926310263112631226313263142631526316263172631826319263202632126322263232632426325263262632726328263292633026331263322633326334263352633626337263382633926340263412634226343263442634526346263472634826349263502635126352263532635426355263562635726358263592636026361263622636326364263652636626367263682636926370263712637226373263742637526376263772637826379263802638126382263832638426385263862638726388263892639026391263922639326394263952639626397263982639926400264012640226403264042640526406264072640826409264102641126412264132641426415264162641726418264192642026421264222642326424264252642626427264282642926430264312643226433264342643526436264372643826439264402644126442264432644426445264462644726448264492645026451264522645326454264552645626457264582645926460264612646226463264642646526466264672646826469264702647126472264732647426475264762647726478264792648026481264822648326484264852648626487264882648926490264912649226493264942649526496264972649826499265002650126502265032650426505265062650726508265092651026511265122651326514265152651626517265182651926520265212652226523265242652526526265272652826529265302653126532265332653426535265362653726538265392654026541265422654326544265452654626547265482654926550265512655226553265542655526556265572655826559265602656126562265632656426565265662656726568265692657026571265722657326574265752657626577265782657926580265812658226583265842658526586265872658826589265902659126592265932659426595265962659726598265992660026601266022660326604266052660626607266082660926610266112661226613266142661526616266172661826619266202662126622266232662426625266262662726628266292663026631266322663326634266352663626637266382663926640266412664226643266442664526646266472664826649266502665126652266532665426655266562665726658266592666026661266622666326664266652666626667266682666926670266712667226673266742667526676266772667826679266802668126682266832668426685266862668726688266892669026691266922669326694266952669626697266982669926700267012670226703267042670526706267072670826709267102671126712267132671426715267162671726718267192672026721267222672326724267252672626727267282672926730267312673226733267342673526736267372673826739267402674126742267432674426745267462674726748267492675026751267522675326754267552675626757267582675926760267612676226763267642676526766267672676826769267702677126772267732677426775267762677726778267792678026781267822678326784267852678626787267882678926790267912679226793267942679526796267972679826799268002680126802268032680426805268062680726808268092681026811268122681326814268152681626817268182681926820268212682226823268242682526826268272682826829268302683126832268332683426835268362683726838268392684026841268422684326844268452684626847268482684926850268512685226853268542685526856268572685826859268602686126862268632686426865268662686726868268692687026871268722687326874268752687626877268782687926880268812688226883268842688526886268872688826889268902689126892268932689426895268962689726898268992690026901269022690326904269052690626907269082690926910269112691226913269142691526916269172691826919269202692126922269232692426925269262692726928269292693026931269322693326934269352693626937269382693926940269412694226943269442694526946269472694826949269502695126952269532695426955269562695726958269592696026961269622696326964269652696626967269682696926970269712697226973269742697526976269772697826979269802698126982269832698426985269862698726988269892699026991269922699326994269952699626997269982699927000270012700227003270042700527006270072700827009270102701127012270132701427015270162701727018270192702027021270222702327024270252702627027270282702927030270312703227033270342703527036270372703827039270402704127042270432704427045270462704727048270492705027051270522705327054270552705627057270582705927060270612706227063270642706527066270672706827069270702707127072270732707427075270762707727078270792708027081270822708327084270852708627087270882708927090270912709227093270942709527096270972709827099271002710127102271032710427105271062710727108271092711027111271122711327114271152711627117271182711927120271212712227123271242712527126271272712827129271302713127132271332713427135271362713727138271392714027141271422714327144271452714627147271482714927150271512715227153271542715527156271572715827159271602716127162271632716427165271662716727168271692717027171271722717327174271752717627177271782717927180271812718227183271842718527186271872718827189271902719127192271932719427195271962719727198271992720027201272022720327204272052720627207272082720927210272112721227213272142721527216272172721827219272202722127222272232722427225272262722727228272292723027231272322723327234272352723627237272382723927240272412724227243272442724527246272472724827249272502725127252272532725427255272562725727258272592726027261272622726327264272652726627267272682726927270272712727227273272742727527276272772727827279272802728127282272832728427285272862728727288272892729027291272922729327294272952729627297272982729927300273012730227303273042730527306273072730827309273102731127312273132731427315273162731727318273192732027321273222732327324273252732627327273282732927330273312733227333273342733527336273372733827339273402734127342273432734427345273462734727348273492735027351273522735327354273552735627357273582735927360273612736227363273642736527366273672736827369273702737127372273732737427375273762737727378273792738027381273822738327384273852738627387273882738927390273912739227393273942739527396273972739827399274002740127402274032740427405274062740727408274092741027411274122741327414274152741627417274182741927420274212742227423274242742527426274272742827429274302743127432274332743427435274362743727438274392744027441274422744327444274452744627447274482744927450274512745227453274542745527456274572745827459274602746127462274632746427465274662746727468274692747027471274722747327474274752747627477274782747927480274812748227483274842748527486274872748827489274902749127492274932749427495274962749727498274992750027501275022750327504275052750627507275082750927510275112751227513275142751527516275172751827519275202752127522275232752427525275262752727528275292753027531275322753327534275352753627537275382753927540275412754227543275442754527546275472754827549275502755127552275532755427555275562755727558275592756027561275622756327564275652756627567275682756927570275712757227573275742757527576275772757827579275802758127582275832758427585275862758727588275892759027591275922759327594275952759627597275982759927600276012760227603276042760527606276072760827609276102761127612276132761427615276162761727618276192762027621276222762327624276252762627627276282762927630276312763227633276342763527636276372763827639276402764127642276432764427645276462764727648276492765027651276522765327654276552765627657276582765927660276612766227663276642766527666276672766827669276702767127672276732767427675276762767727678276792768027681276822768327684276852768627687276882768927690276912769227693276942769527696276972769827699277002770127702277032770427705277062770727708277092771027711277122771327714277152771627717277182771927720277212772227723277242772527726277272772827729277302773127732277332773427735277362773727738277392774027741277422774327744277452774627747277482774927750277512775227753277542775527756277572775827759277602776127762277632776427765277662776727768277692777027771277722777327774277752777627777277782777927780277812778227783277842778527786277872778827789277902779127792277932779427795277962779727798277992780027801278022780327804278052780627807278082780927810278112781227813278142781527816278172781827819278202782127822278232782427825278262782727828278292783027831278322783327834278352783627837278382783927840278412784227843278442784527846278472784827849278502785127852278532785427855278562785727858278592786027861278622786327864278652786627867278682786927870278712787227873278742787527876278772787827879278802788127882278832788427885278862788727888278892789027891278922789327894278952789627897278982789927900279012790227903279042790527906279072790827909279102791127912279132791427915279162791727918279192792027921279222792327924279252792627927279282792927930279312793227933279342793527936279372793827939279402794127942279432794427945279462794727948279492795027951279522795327954279552795627957279582795927960279612796227963279642796527966279672796827969279702797127972279732797427975279762797727978279792798027981279822798327984279852798627987279882798927990279912799227993279942799527996279972799827999280002800128002280032800428005280062800728008280092801028011280122801328014280152801628017280182801928020280212802228023280242802528026280272802828029280302803128032280332803428035280362803728038280392804028041280422804328044280452804628047280482804928050280512805228053280542805528056280572805828059280602806128062280632806428065280662806728068280692807028071280722807328074280752807628077280782807928080280812808228083280842808528086280872808828089280902809128092280932809428095280962809728098280992810028101281022810328104281052810628107281082810928110281112811228113281142811528116281172811828119281202812128122281232812428125281262812728128281292813028131281322813328134281352813628137281382813928140281412814228143281442814528146281472814828149281502815128152281532815428155281562815728158281592816028161281622816328164281652816628167281682816928170281712817228173281742817528176281772817828179281802818128182281832818428185281862818728188281892819028191281922819328194281952819628197281982819928200282012820228203282042820528206282072820828209282102821128212282132821428215282162821728218282192822028221282222822328224282252822628227282282822928230282312823228233282342823528236282372823828239282402824128242282432824428245282462824728248282492825028251282522825328254282552825628257282582825928260282612826228263282642826528266282672826828269282702827128272282732827428275282762827728278282792828028281282822828328284282852828628287282882828928290282912829228293282942829528296282972829828299283002830128302283032830428305283062830728308283092831028311283122831328314283152831628317283182831928320283212832228323283242832528326283272832828329283302833128332283332833428335283362833728338283392834028341283422834328344283452834628347283482834928350283512835228353283542835528356283572835828359283602836128362283632836428365283662836728368283692837028371283722837328374283752837628377283782837928380283812838228383283842838528386283872838828389283902839128392283932839428395283962839728398283992840028401284022840328404284052840628407284082840928410284112841228413284142841528416284172841828419284202842128422284232842428425284262842728428284292843028431284322843328434284352843628437284382843928440284412844228443284442844528446284472844828449284502845128452284532845428455284562845728458284592846028461284622846328464284652846628467284682846928470284712847228473284742847528476284772847828479284802848128482284832848428485284862848728488284892849028491284922849328494284952849628497284982849928500285012850228503285042850528506285072850828509285102851128512285132851428515285162851728518285192852028521285222852328524285252852628527285282852928530285312853228533285342853528536285372853828539285402854128542285432854428545285462854728548285492855028551285522855328554285552855628557285582855928560285612856228563285642856528566285672856828569285702857128572285732857428575285762857728578285792858028581285822858328584285852858628587285882858928590285912859228593285942859528596285972859828599286002860128602286032860428605286062860728608286092861028611286122861328614286152861628617286182861928620286212862228623286242862528626286272862828629286302863128632286332863428635286362863728638286392864028641286422864328644286452864628647286482864928650286512865228653286542865528656286572865828659286602866128662286632866428665286662866728668286692867028671286722867328674286752867628677286782867928680286812868228683286842868528686286872868828689286902869128692286932869428695286962869728698286992870028701287022870328704287052870628707287082870928710287112871228713287142871528716287172871828719287202872128722287232872428725287262872728728287292873028731287322873328734287352873628737287382873928740287412874228743287442874528746287472874828749287502875128752287532875428755287562875728758287592876028761287622876328764287652876628767287682876928770287712877228773287742877528776287772877828779287802878128782287832878428785287862878728788287892879028791287922879328794287952879628797287982879928800288012880228803288042880528806288072880828809288102881128812288132881428815288162881728818288192882028821288222882328824288252882628827288282882928830288312883228833288342883528836288372883828839288402884128842288432884428845288462884728848288492885028851288522885328854288552885628857288582885928860288612886228863288642886528866288672886828869288702887128872288732887428875288762887728878288792888028881288822888328884288852888628887288882888928890288912889228893288942889528896288972889828899289002890128902289032890428905289062890728908289092891028911289122891328914289152891628917289182891928920289212892228923289242892528926289272892828929289302893128932289332893428935289362893728938289392894028941289422894328944289452894628947289482894928950289512895228953289542895528956289572895828959289602896128962289632896428965289662896728968289692897028971289722897328974289752897628977289782897928980289812898228983289842898528986289872898828989289902899128992289932899428995289962899728998289992900029001290022900329004290052900629007290082900929010290112901229013290142901529016290172901829019290202902129022290232902429025290262902729028290292903029031290322903329034290352903629037290382903929040290412904229043290442904529046290472904829049290502905129052290532905429055290562905729058290592906029061290622906329064290652906629067290682906929070290712907229073290742907529076290772907829079290802908129082290832908429085290862908729088290892909029091290922909329094290952909629097290982909929100291012910229103291042910529106291072910829109291102911129112291132911429115291162911729118291192912029121291222912329124291252912629127291282912929130291312913229133291342913529136291372913829139291402914129142291432914429145291462914729148291492915029151291522915329154291552915629157291582915929160291612916229163291642916529166291672916829169291702917129172291732917429175291762917729178291792918029181291822918329184291852918629187291882918929190291912919229193291942919529196291972919829199292002920129202292032920429205292062920729208292092921029211292122921329214292152921629217292182921929220292212922229223292242922529226292272922829229292302923129232292332923429235292362923729238292392924029241292422924329244292452924629247292482924929250292512925229253292542925529256292572925829259292602926129262292632926429265292662926729268292692927029271292722927329274292752927629277292782927929280292812928229283292842928529286292872928829289292902929129292292932929429295292962929729298292992930029301293022930329304293052930629307293082930929310293112931229313293142931529316293172931829319293202932129322293232932429325293262932729328293292933029331293322933329334293352933629337293382933929340293412934229343293442934529346293472934829349293502935129352293532935429355293562935729358293592936029361293622936329364293652936629367293682936929370293712937229373293742937529376293772937829379293802938129382293832938429385293862938729388293892939029391293922939329394293952939629397293982939929400294012940229403294042940529406294072940829409294102941129412294132941429415294162941729418294192942029421294222942329424294252942629427294282942929430294312943229433294342943529436294372943829439294402944129442294432944429445294462944729448294492945029451294522945329454294552945629457294582945929460294612946229463294642946529466294672946829469294702947129472294732947429475294762947729478294792948029481294822948329484294852948629487294882948929490294912949229493294942949529496294972949829499295002950129502295032950429505295062950729508295092951029511295122951329514295152951629517295182951929520295212952229523295242952529526295272952829529295302953129532295332953429535295362953729538295392954029541295422954329544295452954629547295482954929550295512955229553295542955529556295572955829559295602956129562295632956429565295662956729568295692957029571295722957329574295752957629577295782957929580295812958229583295842958529586295872958829589295902959129592295932959429595295962959729598295992960029601296022960329604296052960629607296082960929610296112961229613296142961529616296172961829619296202962129622296232962429625296262962729628296292963029631296322963329634296352963629637296382963929640296412964229643296442964529646296472964829649296502965129652296532965429655296562965729658296592966029661296622966329664296652966629667296682966929670296712967229673296742967529676296772967829679296802968129682296832968429685296862968729688296892969029691296922969329694296952969629697296982969929700297012970229703297042970529706297072970829709297102971129712297132971429715297162971729718297192972029721297222972329724297252972629727297282972929730297312973229733297342973529736297372973829739297402974129742297432974429745297462974729748297492975029751297522975329754297552975629757297582975929760297612976229763297642976529766297672976829769297702977129772297732977429775297762977729778297792978029781297822978329784297852978629787297882978929790297912979229793297942979529796297972979829799298002980129802298032980429805298062980729808298092981029811298122981329814298152981629817298182981929820298212982229823298242982529826298272982829829298302983129832298332983429835298362983729838298392984029841298422984329844298452984629847298482984929850298512985229853298542985529856298572985829859298602986129862298632986429865298662986729868298692987029871298722987329874298752987629877298782987929880298812988229883298842988529886298872988829889298902989129892298932989429895298962989729898298992990029901299022990329904299052990629907299082990929910299112991229913299142991529916299172991829919299202992129922299232992429925299262992729928299292993029931299322993329934299352993629937299382993929940299412994229943299442994529946299472994829949299502995129952299532995429955299562995729958299592996029961299622996329964299652996629967299682996929970299712997229973299742997529976299772997829979299802998129982299832998429985299862998729988299892999029991299922999329994299952999629997299982999930000300013000230003300043000530006300073000830009300103001130012300133001430015300163001730018300193002030021300223002330024300253002630027300283002930030300313003230033300343003530036300373003830039300403004130042300433004430045300463004730048300493005030051300523005330054300553005630057300583005930060300613006230063300643006530066300673006830069300703007130072300733007430075300763007730078300793008030081300823008330084300853008630087300883008930090300913009230093300943009530096300973009830099301003010130102301033010430105301063010730108301093011030111301123011330114301153011630117301183011930120301213012230123301243012530126301273012830129301303013130132301333013430135301363013730138301393014030141301423014330144301453014630147301483014930150301513015230153301543015530156301573015830159301603016130162301633016430165301663016730168301693017030171301723017330174301753017630177301783017930180301813018230183301843018530186301873018830189301903019130192301933019430195301963019730198301993020030201302023020330204302053020630207302083020930210302113021230213302143021530216302173021830219302203022130222302233022430225302263022730228302293023030231302323023330234302353023630237302383023930240302413024230243302443024530246302473024830249302503025130252302533025430255302563025730258302593026030261302623026330264302653026630267302683026930270302713027230273302743027530276302773027830279302803028130282302833028430285302863028730288302893029030291302923029330294302953029630297302983029930300303013030230303303043030530306303073030830309303103031130312303133031430315303163031730318303193032030321303223032330324303253032630327303283032930330303313033230333303343033530336303373033830339303403034130342303433034430345303463034730348303493035030351303523035330354303553035630357303583035930360303613036230363303643036530366303673036830369303703037130372303733037430375303763037730378303793038030381303823038330384303853038630387303883038930390303913039230393303943039530396303973039830399304003040130402304033040430405304063040730408304093041030411304123041330414304153041630417304183041930420304213042230423304243042530426304273042830429304303043130432304333043430435304363043730438304393044030441304423044330444304453044630447304483044930450304513045230453304543045530456304573045830459304603046130462304633046430465304663046730468304693047030471304723047330474304753047630477304783047930480304813048230483304843048530486304873048830489304903049130492304933049430495304963049730498304993050030501305023050330504305053050630507305083050930510305113051230513305143051530516305173051830519305203052130522305233052430525305263052730528305293053030531305323053330534305353053630537305383053930540305413054230543305443054530546305473054830549305503055130552305533055430555305563055730558305593056030561305623056330564305653056630567305683056930570305713057230573305743057530576305773057830579305803058130582305833058430585305863058730588305893059030591305923059330594305953059630597305983059930600306013060230603306043060530606306073060830609306103061130612306133061430615306163061730618306193062030621306223062330624306253062630627306283062930630306313063230633306343063530636306373063830639306403064130642306433064430645306463064730648306493065030651306523065330654306553065630657306583065930660306613066230663306643066530666306673066830669306703067130672306733067430675306763067730678306793068030681306823068330684306853068630687306883068930690306913069230693306943069530696306973069830699307003070130702307033070430705307063070730708307093071030711307123071330714307153071630717307183071930720307213072230723307243072530726307273072830729307303073130732307333073430735307363073730738307393074030741307423074330744307453074630747307483074930750307513075230753307543075530756307573075830759307603076130762307633076430765307663076730768307693077030771307723077330774307753077630777307783077930780307813078230783307843078530786307873078830789307903079130792307933079430795307963079730798307993080030801308023080330804308053080630807308083080930810308113081230813308143081530816308173081830819308203082130822308233082430825308263082730828308293083030831308323083330834308353083630837308383083930840308413084230843308443084530846308473084830849308503085130852308533085430855308563085730858308593086030861308623086330864308653086630867308683086930870308713087230873308743087530876308773087830879308803088130882308833088430885308863088730888308893089030891308923089330894308953089630897308983089930900309013090230903309043090530906309073090830909309103091130912309133091430915309163091730918309193092030921309223092330924309253092630927309283092930930309313093230933309343093530936309373093830939309403094130942309433094430945309463094730948309493095030951309523095330954309553095630957309583095930960309613096230963309643096530966309673096830969309703097130972309733097430975309763097730978309793098030981309823098330984309853098630987309883098930990309913099230993309943099530996309973099830999310003100131002310033100431005310063100731008310093101031011310123101331014310153101631017310183101931020310213102231023310243102531026310273102831029310303103131032310333103431035310363103731038310393104031041310423104331044310453104631047310483104931050310513105231053310543105531056310573105831059310603106131062310633106431065310663106731068310693107031071310723107331074310753107631077310783107931080310813108231083310843108531086310873108831089310903109131092310933109431095310963109731098310993110031101311023110331104311053110631107311083110931110311113111231113311143111531116311173111831119311203112131122311233112431125311263112731128311293113031131311323113331134311353113631137311383113931140311413114231143311443114531146311473114831149311503115131152311533115431155311563115731158311593116031161311623116331164311653116631167311683116931170311713117231173311743117531176311773117831179311803118131182311833118431185311863118731188311893119031191311923119331194311953119631197311983119931200312013120231203312043120531206312073120831209312103121131212312133121431215312163121731218312193122031221312223122331224312253122631227312283122931230312313123231233312343123531236312373123831239312403124131242312433124431245312463124731248312493125031251312523125331254312553125631257312583125931260312613126231263312643126531266312673126831269312703127131272312733127431275312763127731278312793128031281312823128331284312853128631287312883128931290312913129231293312943129531296312973129831299313003130131302313033130431305313063130731308313093131031311313123131331314313153131631317313183131931320313213132231323313243132531326313273132831329313303133131332313333133431335313363133731338313393134031341313423134331344313453134631347313483134931350313513135231353313543135531356313573135831359313603136131362313633136431365313663136731368313693137031371313723137331374313753137631377313783137931380313813138231383313843138531386313873138831389313903139131392313933139431395313963139731398313993140031401314023140331404314053140631407314083140931410314113141231413314143141531416314173141831419314203142131422314233142431425314263142731428314293143031431314323143331434314353143631437314383143931440314413144231443314443144531446314473144831449314503145131452314533145431455314563145731458314593146031461314623146331464314653146631467314683146931470314713147231473314743147531476314773147831479314803148131482314833148431485314863148731488314893149031491314923149331494314953149631497314983149931500315013150231503315043150531506315073150831509315103151131512315133151431515315163151731518315193152031521315223152331524315253152631527315283152931530315313153231533315343153531536315373153831539315403154131542315433154431545315463154731548315493155031551315523155331554315553155631557315583155931560315613156231563315643156531566315673156831569315703157131572315733157431575315763157731578315793158031581315823158331584315853158631587315883158931590315913159231593315943159531596315973159831599316003160131602316033160431605316063160731608316093161031611316123161331614316153161631617316183161931620316213162231623316243162531626316273162831629316303163131632316333163431635316363163731638316393164031641316423164331644316453164631647316483164931650316513165231653316543165531656316573165831659316603166131662316633166431665316663166731668316693167031671316723167331674316753167631677316783167931680316813168231683316843168531686316873168831689316903169131692316933169431695316963169731698316993170031701317023170331704317053170631707317083170931710317113171231713317143171531716317173171831719317203172131722317233172431725317263172731728317293173031731317323173331734317353173631737317383173931740317413174231743317443174531746317473174831749317503175131752317533175431755317563175731758317593176031761317623176331764317653176631767317683176931770317713177231773317743177531776317773177831779317803178131782317833178431785317863178731788317893179031791317923179331794317953179631797317983179931800318013180231803318043180531806318073180831809318103181131812318133181431815318163181731818318193182031821318223182331824318253182631827318283182931830318313183231833318343183531836318373183831839318403184131842318433184431845318463184731848318493185031851318523185331854318553185631857318583185931860318613186231863318643186531866318673186831869318703187131872318733187431875318763187731878318793188031881318823188331884318853188631887318883188931890318913189231893318943189531896318973189831899319003190131902319033190431905319063190731908319093191031911319123191331914319153191631917319183191931920319213192231923319243192531926319273192831929319303193131932319333193431935319363193731938319393194031941319423194331944319453194631947319483194931950319513195231953319543195531956319573195831959319603196131962319633196431965319663196731968319693197031971319723197331974319753197631977319783197931980319813198231983319843198531986319873198831989319903199131992319933199431995319963199731998319993200032001320023200332004320053200632007320083200932010320113201232013320143201532016320173201832019320203202132022320233202432025320263202732028320293203032031320323203332034320353203632037320383203932040320413204232043320443204532046320473204832049320503205132052320533205432055320563205732058320593206032061320623206332064320653206632067320683206932070320713207232073320743207532076320773207832079320803208132082320833208432085320863208732088320893209032091320923209332094320953209632097320983209932100321013210232103321043210532106321073210832109321103211132112321133211432115321163211732118321193212032121321223212332124321253212632127321283212932130321313213232133321343213532136321373213832139321403214132142321433214432145321463214732148321493215032151321523215332154321553215632157321583215932160321613216232163321643216532166321673216832169321703217132172321733217432175321763217732178321793218032181321823218332184321853218632187321883218932190321913219232193321943219532196321973219832199322003220132202322033220432205322063220732208322093221032211322123221332214322153221632217322183221932220322213222232223322243222532226322273222832229322303223132232322333223432235322363223732238322393224032241322423224332244322453224632247322483224932250322513225232253322543225532256322573225832259322603226132262322633226432265322663226732268322693227032271322723227332274322753227632277322783227932280322813228232283322843228532286322873228832289322903229132292322933229432295322963229732298322993230032301323023230332304323053230632307323083230932310323113231232313323143231532316323173231832319323203232132322323233232432325323263232732328323293233032331323323233332334323353233632337323383233932340323413234232343323443234532346323473234832349323503235132352323533235432355323563235732358323593236032361323623236332364323653236632367323683236932370323713237232373323743237532376323773237832379323803238132382323833238432385323863238732388323893239032391323923239332394323953239632397323983239932400324013240232403324043240532406324073240832409324103241132412324133241432415324163241732418324193242032421324223242332424324253242632427324283242932430324313243232433324343243532436324373243832439324403244132442324433244432445324463244732448324493245032451324523245332454324553245632457324583245932460324613246232463324643246532466324673246832469324703247132472324733247432475324763247732478324793248032481324823248332484324853248632487324883248932490324913249232493324943249532496324973249832499325003250132502325033250432505325063250732508325093251032511325123251332514325153251632517325183251932520325213252232523325243252532526325273252832529325303253132532325333253432535325363253732538325393254032541325423254332544325453254632547325483254932550325513255232553325543255532556325573255832559325603256132562325633256432565325663256732568325693257032571325723257332574325753257632577325783257932580325813258232583325843258532586325873258832589325903259132592325933259432595325963259732598325993260032601326023260332604326053260632607326083260932610326113261232613326143261532616326173261832619326203262132622326233262432625326263262732628326293263032631326323263332634326353263632637326383263932640326413264232643326443264532646326473264832649326503265132652326533265432655326563265732658326593266032661326623266332664326653266632667326683266932670326713267232673326743267532676326773267832679326803268132682326833268432685326863268732688326893269032691326923269332694326953269632697326983269932700327013270232703327043270532706327073270832709327103271132712327133271432715327163271732718327193272032721327223272332724327253272632727327283272932730327313273232733327343273532736327373273832739327403274132742327433274432745327463274732748327493275032751327523275332754327553275632757327583275932760327613276232763327643276532766327673276832769327703277132772327733277432775327763277732778327793278032781327823278332784327853278632787327883278932790327913279232793327943279532796327973279832799328003280132802328033280432805328063280732808328093281032811328123281332814328153281632817328183281932820328213282232823328243282532826328273282832829328303283132832328333283432835328363283732838328393284032841328423284332844328453284632847328483284932850328513285232853328543285532856328573285832859328603286132862328633286432865328663286732868328693287032871328723287332874328753287632877328783287932880328813288232883328843288532886328873288832889328903289132892328933289432895328963289732898328993290032901329023290332904329053290632907329083290932910329113291232913329143291532916329173291832919329203292132922329233292432925329263292732928329293293032931329323293332934329353293632937329383293932940329413294232943329443294532946329473294832949329503295132952329533295432955329563295732958329593296032961329623296332964329653296632967329683296932970329713297232973329743297532976329773297832979329803298132982329833298432985329863298732988329893299032991329923299332994329953299632997329983299933000330013300233003330043300533006330073300833009330103301133012330133301433015330163301733018330193302033021330223302333024330253302633027330283302933030330313303233033330343303533036330373303833039330403304133042330433304433045330463304733048330493305033051330523305333054330553305633057330583305933060330613306233063330643306533066330673306833069330703307133072330733307433075330763307733078330793308033081330823308333084330853308633087330883308933090330913309233093330943309533096330973309833099331003310133102331033310433105331063310733108331093311033111331123311333114331153311633117331183311933120331213312233123331243312533126331273312833129331303313133132331333313433135331363313733138331393314033141331423314333144331453314633147331483314933150331513315233153331543315533156331573315833159331603316133162331633316433165331663316733168331693317033171331723317333174331753317633177331783317933180331813318233183331843318533186331873318833189331903319133192331933319433195331963319733198331993320033201332023320333204332053320633207332083320933210332113321233213332143321533216332173321833219332203322133222332233322433225332263322733228332293323033231332323323333234332353323633237332383323933240332413324233243332443324533246332473324833249332503325133252332533325433255332563325733258332593326033261332623326333264332653326633267332683326933270332713327233273332743327533276332773327833279332803328133282332833328433285332863328733288332893329033291332923329333294332953329633297332983329933300333013330233303333043330533306333073330833309333103331133312333133331433315333163331733318333193332033321333223332333324333253332633327333283332933330333313333233333333343333533336333373333833339333403334133342333433334433345333463334733348333493335033351333523335333354333553335633357333583335933360333613336233363333643336533366333673336833369333703337133372333733337433375333763337733378333793338033381333823338333384333853338633387333883338933390333913339233393333943339533396333973339833399334003340133402334033340433405334063340733408334093341033411334123341333414334153341633417334183341933420334213342233423334243342533426334273342833429334303343133432334333343433435334363343733438334393344033441334423344333444334453344633447334483344933450334513345233453334543345533456334573345833459334603346133462334633346433465334663346733468334693347033471334723347333474334753347633477334783347933480334813348233483334843348533486334873348833489334903349133492334933349433495334963349733498334993350033501335023350333504335053350633507335083350933510335113351233513335143351533516335173351833519335203352133522335233352433525335263352733528335293353033531335323353333534335353353633537335383353933540335413354233543335443354533546335473354833549335503355133552335533355433555335563355733558335593356033561335623356333564335653356633567335683356933570335713357233573335743357533576335773357833579335803358133582335833358433585335863358733588335893359033591335923359333594335953359633597335983359933600336013360233603336043360533606336073360833609336103361133612336133361433615336163361733618336193362033621336223362333624336253362633627336283362933630336313363233633336343363533636336373363833639336403364133642336433364433645336463364733648336493365033651336523365333654336553365633657336583365933660336613366233663336643366533666336673366833669336703367133672336733367433675336763367733678336793368033681336823368333684336853368633687336883368933690336913369233693336943369533696336973369833699337003370133702337033370433705337063370733708337093371033711337123371333714337153371633717337183371933720337213372233723337243372533726337273372833729337303373133732337333373433735337363373733738337393374033741337423374333744337453374633747337483374933750337513375233753337543375533756337573375833759337603376133762337633376433765337663376733768337693377033771337723377333774337753377633777337783377933780337813378233783337843378533786337873378833789337903379133792337933379433795337963379733798337993380033801338023380333804338053380633807338083380933810338113381233813338143381533816338173381833819338203382133822338233382433825338263382733828338293383033831338323383333834338353383633837338383383933840338413384233843338443384533846338473384833849338503385133852338533385433855338563385733858338593386033861338623386333864338653386633867338683386933870338713387233873338743387533876338773387833879338803388133882338833388433885338863388733888338893389033891338923389333894338953389633897338983389933900339013390233903339043390533906339073390833909339103391133912339133391433915339163391733918339193392033921339223392333924339253392633927339283392933930339313393233933339343393533936339373393833939339403394133942339433394433945339463394733948339493395033951339523395333954339553395633957339583395933960339613396233963339643396533966339673396833969339703397133972339733397433975339763397733978339793398033981339823398333984339853398633987339883398933990339913399233993339943399533996339973399833999340003400134002340033400434005340063400734008340093401034011340123401334014340153401634017340183401934020340213402234023340243402534026340273402834029340303403134032340333403434035340363403734038340393404034041340423404334044340453404634047340483404934050340513405234053340543405534056340573405834059340603406134062340633406434065340663406734068340693407034071340723407334074340753407634077340783407934080340813408234083340843408534086340873408834089340903409134092340933409434095340963409734098340993410034101341023410334104341053410634107341083410934110341113411234113341143411534116341173411834119341203412134122341233412434125341263412734128341293413034131341323413334134341353413634137341383413934140341413414234143341443414534146341473414834149341503415134152341533415434155341563415734158341593416034161341623416334164341653416634167341683416934170341713417234173341743417534176341773417834179341803418134182341833418434185341863418734188341893419034191341923419334194341953419634197341983419934200342013420234203342043420534206342073420834209342103421134212342133421434215342163421734218342193422034221342223422334224342253422634227342283422934230342313423234233342343423534236342373423834239342403424134242342433424434245342463424734248342493425034251342523425334254342553425634257342583425934260342613426234263342643426534266342673426834269342703427134272342733427434275342763427734278342793428034281342823428334284342853428634287342883428934290342913429234293342943429534296342973429834299343003430134302343033430434305343063430734308343093431034311343123431334314343153431634317343183431934320343213432234323343243432534326343273432834329343303433134332343333433434335343363433734338343393434034341343423434334344343453434634347343483434934350343513435234353343543435534356343573435834359343603436134362343633436434365343663436734368343693437034371343723437334374343753437634377343783437934380343813438234383343843438534386343873438834389343903439134392343933439434395343963439734398343993440034401344023440334404344053440634407344083440934410344113441234413344143441534416344173441834419344203442134422344233442434425344263442734428344293443034431344323443334434344353443634437344383443934440344413444234443344443444534446344473444834449344503445134452344533445434455344563445734458344593446034461344623446334464344653446634467344683446934470344713447234473344743447534476344773447834479344803448134482344833448434485344863448734488344893449034491344923449334494344953449634497344983449934500345013450234503345043450534506345073450834509345103451134512345133451434515345163451734518345193452034521345223452334524345253452634527345283452934530345313453234533345343453534536345373453834539345403454134542345433454434545345463454734548345493455034551345523455334554345553455634557345583455934560345613456234563345643456534566345673456834569345703457134572345733457434575345763457734578345793458034581345823458334584345853458634587345883458934590345913459234593345943459534596345973459834599346003460134602346033460434605346063460734608346093461034611346123461334614346153461634617346183461934620346213462234623346243462534626346273462834629346303463134632346333463434635346363463734638346393464034641346423464334644346453464634647346483464934650346513465234653346543465534656346573465834659346603466134662346633466434665346663466734668346693467034671346723467334674346753467634677346783467934680346813468234683346843468534686346873468834689346903469134692346933469434695346963469734698346993470034701347023470334704347053470634707347083470934710347113471234713347143471534716347173471834719347203472134722347233472434725347263472734728347293473034731347323473334734347353473634737347383473934740347413474234743347443474534746347473474834749347503475134752347533475434755347563475734758347593476034761347623476334764347653476634767347683476934770347713477234773347743477534776347773477834779347803478134782347833478434785347863478734788347893479034791347923479334794347953479634797347983479934800348013480234803348043480534806348073480834809348103481134812348133481434815348163481734818348193482034821348223482334824348253482634827348283482934830348313483234833348343483534836348373483834839348403484134842348433484434845348463484734848348493485034851348523485334854348553485634857348583485934860348613486234863348643486534866348673486834869348703487134872348733487434875348763487734878348793488034881348823488334884348853488634887348883488934890348913489234893348943489534896348973489834899349003490134902349033490434905349063490734908349093491034911349123491334914349153491634917349183491934920349213492234923349243492534926349273492834929349303493134932349333493434935349363493734938349393494034941349423494334944349453494634947349483494934950349513495234953349543495534956349573495834959349603496134962349633496434965349663496734968349693497034971349723497334974349753497634977349783497934980349813498234983349843498534986349873498834989349903499134992349933499434995349963499734998349993500035001350023500335004350053500635007350083500935010350113501235013350143501535016350173501835019350203502135022350233502435025350263502735028350293503035031350323503335034350353503635037350383503935040350413504235043350443504535046350473504835049350503505135052350533505435055350563505735058350593506035061350623506335064350653506635067350683506935070350713507235073350743507535076350773507835079350803508135082350833508435085350863508735088350893509035091350923509335094350953509635097350983509935100351013510235103351043510535106351073510835109351103511135112351133511435115351163511735118351193512035121351223512335124351253512635127351283512935130351313513235133351343513535136351373513835139351403514135142351433514435145351463514735148351493515035151351523515335154351553515635157351583515935160351613516235163351643516535166351673516835169351703517135172351733517435175351763517735178351793518035181351823518335184351853518635187351883518935190351913519235193351943519535196351973519835199352003520135202352033520435205352063520735208352093521035211352123521335214352153521635217352183521935220352213522235223352243522535226352273522835229352303523135232352333523435235352363523735238352393524035241352423524335244352453524635247352483524935250352513525235253352543525535256352573525835259352603526135262352633526435265352663526735268352693527035271352723527335274352753527635277352783527935280352813528235283352843528535286352873528835289352903529135292352933529435295352963529735298352993530035301353023530335304353053530635307353083530935310353113531235313353143531535316353173531835319353203532135322353233532435325353263532735328353293533035331353323533335334353353533635337353383533935340353413534235343353443534535346353473534835349353503535135352353533535435355353563535735358353593536035361353623536335364353653536635367353683536935370353713537235373353743537535376353773537835379353803538135382353833538435385353863538735388353893539035391353923539335394353953539635397353983539935400354013540235403354043540535406354073540835409354103541135412354133541435415354163541735418354193542035421354223542335424354253542635427354283542935430354313543235433354343543535436354373543835439354403544135442354433544435445354463544735448354493545035451354523545335454354553545635457354583545935460354613546235463354643546535466354673546835469354703547135472354733547435475354763547735478354793548035481354823548335484354853548635487354883548935490354913549235493354943549535496354973549835499355003550135502355033550435505355063550735508355093551035511355123551335514355153551635517355183551935520355213552235523355243552535526355273552835529355303553135532355333553435535355363553735538355393554035541355423554335544355453554635547355483554935550355513555235553355543555535556355573555835559355603556135562355633556435565355663556735568355693557035571355723557335574355753557635577355783557935580355813558235583355843558535586355873558835589355903559135592355933559435595355963559735598355993560035601356023560335604356053560635607356083560935610356113561235613356143561535616356173561835619356203562135622356233562435625356263562735628356293563035631356323563335634356353563635637356383563935640356413564235643356443564535646356473564835649356503565135652356533565435655356563565735658356593566035661356623566335664356653566635667356683566935670356713567235673356743567535676356773567835679356803568135682356833568435685356863568735688356893569035691356923569335694356953569635697356983569935700357013570235703357043570535706357073570835709357103571135712357133571435715357163571735718357193572035721357223572335724357253572635727357283572935730357313573235733357343573535736357373573835739357403574135742357433574435745357463574735748357493575035751357523575335754357553575635757357583575935760357613576235763357643576535766357673576835769357703577135772357733577435775357763577735778357793578035781357823578335784357853578635787357883578935790357913579235793357943579535796357973579835799358003580135802358033580435805358063580735808358093581035811358123581335814358153581635817358183581935820358213582235823358243582535826358273582835829358303583135832358333583435835358363583735838358393584035841358423584335844358453584635847358483584935850358513585235853358543585535856358573585835859358603586135862358633586435865358663586735868358693587035871358723587335874358753587635877358783587935880358813588235883358843588535886358873588835889358903589135892358933589435895358963589735898358993590035901359023590335904359053590635907359083590935910359113591235913359143591535916359173591835919359203592135922359233592435925359263592735928359293593035931359323593335934359353593635937359383593935940359413594235943359443594535946359473594835949359503595135952359533595435955359563595735958359593596035961359623596335964359653596635967359683596935970359713597235973359743597535976359773597835979359803598135982359833598435985359863598735988359893599035991359923599335994359953599635997359983599936000360013600236003360043600536006360073600836009360103601136012360133601436015360163601736018360193602036021360223602336024360253602636027360283602936030360313603236033360343603536036360373603836039360403604136042360433604436045360463604736048360493605036051360523605336054360553605636057360583605936060360613606236063360643606536066360673606836069360703607136072360733607436075360763607736078360793608036081360823608336084360853608636087360883608936090360913609236093360943609536096360973609836099361003610136102361033610436105361063610736108361093611036111361123611336114361153611636117361183611936120361213612236123361243612536126361273612836129361303613136132361333613436135361363613736138361393614036141361423614336144361453614636147361483614936150361513615236153361543615536156361573615836159361603616136162361633616436165361663616736168361693617036171361723617336174361753617636177361783617936180361813618236183361843618536186361873618836189361903619136192361933619436195361963619736198361993620036201362023620336204362053620636207362083620936210362113621236213362143621536216362173621836219362203622136222362233622436225362263622736228362293623036231362323623336234362353623636237362383623936240362413624236243362443624536246362473624836249362503625136252362533625436255362563625736258362593626036261362623626336264362653626636267362683626936270362713627236273362743627536276362773627836279362803628136282362833628436285362863628736288362893629036291362923629336294362953629636297362983629936300363013630236303363043630536306363073630836309363103631136312363133631436315363163631736318363193632036321363223632336324363253632636327363283632936330363313633236333363343633536336363373633836339363403634136342363433634436345363463634736348363493635036351363523635336354363553635636357363583635936360363613636236363363643636536366363673636836369363703637136372363733637436375363763637736378363793638036381363823638336384363853638636387363883638936390363913639236393363943639536396363973639836399364003640136402364033640436405364063640736408364093641036411364123641336414364153641636417364183641936420364213642236423364243642536426364273642836429364303643136432364333643436435364363643736438364393644036441364423644336444364453644636447364483644936450364513645236453364543645536456364573645836459364603646136462364633646436465364663646736468364693647036471364723647336474364753647636477364783647936480364813648236483364843648536486364873648836489364903649136492364933649436495364963649736498364993650036501365023650336504365053650636507365083650936510365113651236513365143651536516365173651836519365203652136522365233652436525365263652736528365293653036531365323653336534365353653636537365383653936540365413654236543365443654536546365473654836549365503655136552365533655436555365563655736558365593656036561365623656336564365653656636567365683656936570365713657236573365743657536576365773657836579365803658136582365833658436585365863658736588365893659036591365923659336594365953659636597365983659936600366013660236603366043660536606366073660836609366103661136612366133661436615366163661736618366193662036621366223662336624366253662636627366283662936630366313663236633366343663536636366373663836639366403664136642366433664436645366463664736648366493665036651366523665336654366553665636657366583665936660366613666236663366643666536666366673666836669366703667136672366733667436675366763667736678366793668036681366823668336684366853668636687366883668936690366913669236693366943669536696366973669836699367003670136702367033670436705367063670736708367093671036711367123671336714367153671636717367183671936720367213672236723367243672536726367273672836729367303673136732367333673436735367363673736738367393674036741367423674336744367453674636747367483674936750367513675236753367543675536756367573675836759367603676136762367633676436765367663676736768367693677036771367723677336774367753677636777367783677936780367813678236783367843678536786367873678836789367903679136792367933679436795367963679736798367993680036801368023680336804368053680636807368083680936810368113681236813368143681536816368173681836819368203682136822368233682436825368263682736828368293683036831368323683336834368353683636837368383683936840368413684236843368443684536846368473684836849368503685136852368533685436855368563685736858368593686036861368623686336864368653686636867368683686936870368713687236873368743687536876368773687836879368803688136882368833688436885368863688736888368893689036891368923689336894368953689636897368983689936900369013690236903369043690536906369073690836909369103691136912369133691436915369163691736918369193692036921369223692336924369253692636927369283692936930369313693236933369343693536936369373693836939369403694136942369433694436945369463694736948369493695036951369523695336954369553695636957369583695936960369613696236963369643696536966369673696836969369703697136972369733697436975369763697736978369793698036981369823698336984369853698636987369883698936990369913699236993369943699536996369973699836999370003700137002370033700437005370063700737008370093701037011370123701337014370153701637017370183701937020370213702237023370243702537026370273702837029370303703137032370333703437035370363703737038370393704037041370423704337044370453704637047370483704937050370513705237053370543705537056370573705837059370603706137062370633706437065370663706737068370693707037071370723707337074370753707637077370783707937080370813708237083370843708537086370873708837089370903709137092370933709437095370963709737098370993710037101371023710337104371053710637107371083710937110371113711237113371143711537116371173711837119371203712137122371233712437125371263712737128371293713037131371323713337134371353713637137371383713937140371413714237143371443714537146371473714837149371503715137152371533715437155371563715737158371593716037161371623716337164371653716637167371683716937170371713717237173371743717537176371773717837179371803718137182371833718437185371863718737188371893719037191371923719337194371953719637197371983719937200372013720237203372043720537206372073720837209372103721137212372133721437215372163721737218372193722037221372223722337224372253722637227372283722937230372313723237233372343723537236372373723837239372403724137242372433724437245372463724737248372493725037251372523725337254372553725637257372583725937260372613726237263372643726537266372673726837269372703727137272372733727437275372763727737278372793728037281372823728337284372853728637287372883728937290372913729237293372943729537296372973729837299373003730137302373033730437305373063730737308373093731037311373123731337314373153731637317373183731937320373213732237323373243732537326373273732837329373303733137332373333733437335373363733737338373393734037341373423734337344373453734637347373483734937350373513735237353373543735537356373573735837359373603736137362373633736437365373663736737368373693737037371373723737337374373753737637377373783737937380373813738237383373843738537386373873738837389373903739137392373933739437395373963739737398373993740037401374023740337404374053740637407374083740937410374113741237413374143741537416374173741837419374203742137422374233742437425374263742737428374293743037431374323743337434374353743637437374383743937440374413744237443374443744537446374473744837449374503745137452374533745437455374563745737458374593746037461374623746337464374653746637467374683746937470374713747237473374743747537476374773747837479374803748137482374833748437485374863748737488374893749037491374923749337494374953749637497374983749937500375013750237503375043750537506375073750837509375103751137512375133751437515375163751737518375193752037521375223752337524375253752637527375283752937530375313753237533375343753537536375373753837539375403754137542375433754437545375463754737548375493755037551375523755337554375553755637557375583755937560375613756237563375643756537566375673756837569375703757137572375733757437575375763757737578375793758037581375823758337584375853758637587375883758937590375913759237593375943759537596375973759837599376003760137602376033760437605376063760737608376093761037611376123761337614376153761637617376183761937620376213762237623376243762537626376273762837629376303763137632376333763437635376363763737638376393764037641376423764337644376453764637647376483764937650376513765237653376543765537656376573765837659376603766137662376633766437665376663766737668376693767037671376723767337674376753767637677376783767937680376813768237683376843768537686376873768837689376903769137692376933769437695376963769737698376993770037701377023770337704377053770637707377083770937710377113771237713377143771537716377173771837719377203772137722377233772437725377263772737728377293773037731377323773337734377353773637737377383773937740377413774237743377443774537746377473774837749377503775137752377533775437755377563775737758377593776037761377623776337764377653776637767377683776937770377713777237773377743777537776377773777837779377803778137782377833778437785377863778737788377893779037791377923779337794377953779637797377983779937800378013780237803378043780537806378073780837809378103781137812378133781437815378163781737818378193782037821378223782337824378253782637827378283782937830378313783237833378343783537836378373783837839378403784137842378433784437845378463784737848378493785037851378523785337854378553785637857378583785937860378613786237863378643786537866378673786837869378703787137872378733787437875378763787737878378793788037881378823788337884378853788637887378883788937890378913789237893378943789537896378973789837899379003790137902379033790437905379063790737908379093791037911379123791337914379153791637917379183791937920379213792237923379243792537926379273792837929379303793137932379333793437935379363793737938379393794037941379423794337944379453794637947379483794937950379513795237953379543795537956379573795837959379603796137962379633796437965379663796737968379693797037971379723797337974379753797637977379783797937980379813798237983379843798537986379873798837989379903799137992379933799437995379963799737998379993800038001380023800338004380053800638007380083800938010380113801238013380143801538016380173801838019380203802138022380233802438025380263802738028380293803038031380323803338034380353803638037380383803938040380413804238043380443804538046380473804838049380503805138052380533805438055380563805738058380593806038061380623806338064380653806638067380683806938070380713807238073380743807538076380773807838079380803808138082380833808438085380863808738088380893809038091380923809338094380953809638097380983809938100381013810238103381043810538106381073810838109381103811138112381133811438115381163811738118381193812038121381223812338124381253812638127381283812938130381313813238133381343813538136381373813838139381403814138142381433814438145381463814738148381493815038151381523815338154381553815638157381583815938160381613816238163381643816538166381673816838169381703817138172381733817438175381763817738178381793818038181381823818338184381853818638187381883818938190381913819238193381943819538196381973819838199382003820138202382033820438205382063820738208382093821038211382123821338214382153821638217382183821938220382213822238223382243822538226382273822838229382303823138232382333823438235382363823738238382393824038241382423824338244382453824638247382483824938250382513825238253382543825538256382573825838259382603826138262382633826438265382663826738268382693827038271382723827338274382753827638277382783827938280382813828238283382843828538286382873828838289382903829138292382933829438295382963829738298382993830038301383023830338304383053830638307383083830938310383113831238313383143831538316383173831838319383203832138322383233832438325383263832738328383293833038331383323833338334383353833638337383383833938340383413834238343383443834538346383473834838349383503835138352383533835438355383563835738358383593836038361383623836338364383653836638367383683836938370383713837238373383743837538376383773837838379383803838138382383833838438385383863838738388383893839038391383923839338394383953839638397383983839938400384013840238403384043840538406384073840838409384103841138412384133841438415384163841738418384193842038421384223842338424384253842638427384283842938430384313843238433384343843538436384373843838439384403844138442384433844438445384463844738448384493845038451384523845338454384553845638457384583845938460384613846238463384643846538466384673846838469384703847138472384733847438475384763847738478384793848038481384823848338484384853848638487384883848938490384913849238493384943849538496384973849838499385003850138502385033850438505385063850738508385093851038511385123851338514385153851638517385183851938520385213852238523385243852538526385273852838529385303853138532385333853438535385363853738538385393854038541385423854338544385453854638547385483854938550385513855238553385543855538556385573855838559385603856138562385633856438565385663856738568385693857038571385723857338574385753857638577385783857938580385813858238583385843858538586385873858838589385903859138592385933859438595385963859738598385993860038601386023860338604386053860638607386083860938610386113861238613386143861538616386173861838619386203862138622386233862438625386263862738628386293863038631386323863338634386353863638637386383863938640386413864238643386443864538646386473864838649386503865138652386533865438655386563865738658386593866038661386623866338664386653866638667386683866938670386713867238673386743867538676386773867838679386803868138682386833868438685386863868738688386893869038691386923869338694386953869638697386983869938700387013870238703387043870538706387073870838709387103871138712387133871438715387163871738718387193872038721387223872338724387253872638727387283872938730387313873238733387343873538736387373873838739387403874138742387433874438745387463874738748387493875038751387523875338754387553875638757387583875938760387613876238763387643876538766387673876838769387703877138772387733877438775387763877738778387793878038781387823878338784387853878638787387883878938790387913879238793387943879538796387973879838799388003880138802388033880438805388063880738808388093881038811388123881338814388153881638817388183881938820388213882238823388243882538826388273882838829388303883138832388333883438835388363883738838388393884038841388423884338844388453884638847388483884938850388513885238853388543885538856388573885838859388603886138862388633886438865388663886738868388693887038871388723887338874388753887638877388783887938880388813888238883388843888538886388873888838889388903889138892388933889438895388963889738898388993890038901389023890338904389053890638907389083890938910389113891238913389143891538916389173891838919389203892138922389233892438925389263892738928389293893038931389323893338934389353893638937389383893938940389413894238943389443894538946389473894838949389503895138952389533895438955389563895738958389593896038961389623896338964389653896638967389683896938970389713897238973389743897538976389773897838979389803898138982389833898438985389863898738988389893899038991389923899338994389953899638997389983899939000390013900239003390043900539006390073900839009390103901139012390133901439015390163901739018390193902039021390223902339024390253902639027390283902939030390313903239033390343903539036390373903839039390403904139042390433904439045390463904739048390493905039051390523905339054390553905639057390583905939060390613906239063390643906539066390673906839069390703907139072390733907439075390763907739078390793908039081390823908339084390853908639087390883908939090390913909239093390943909539096390973909839099391003910139102391033910439105391063910739108391093911039111391123911339114391153911639117391183911939120391213912239123391243912539126391273912839129391303913139132391333913439135391363913739138391393914039141391423914339144391453914639147391483914939150391513915239153391543915539156391573915839159391603916139162391633916439165391663916739168391693917039171391723917339174391753917639177391783917939180391813918239183391843918539186391873918839189391903919139192391933919439195391963919739198391993920039201392023920339204392053920639207392083920939210392113921239213392143921539216392173921839219392203922139222392233922439225392263922739228392293923039231392323923339234392353923639237392383923939240392413924239243392443924539246392473924839249392503925139252392533925439255392563925739258392593926039261392623926339264392653926639267392683926939270392713927239273392743927539276392773927839279392803928139282392833928439285392863928739288392893929039291392923929339294392953929639297392983929939300393013930239303393043930539306393073930839309393103931139312393133931439315393163931739318393193932039321393223932339324393253932639327393283932939330393313933239333393343933539336393373933839339393403934139342393433934439345393463934739348393493935039351393523935339354393553935639357393583935939360393613936239363393643936539366393673936839369393703937139372393733937439375393763937739378393793938039381393823938339384393853938639387393883938939390393913939239393393943939539396393973939839399394003940139402394033940439405394063940739408394093941039411394123941339414394153941639417394183941939420394213942239423394243942539426394273942839429394303943139432394333943439435394363943739438394393944039441394423944339444394453944639447394483944939450394513945239453394543945539456394573945839459394603946139462394633946439465394663946739468394693947039471394723947339474394753947639477394783947939480394813948239483394843948539486394873948839489394903949139492394933949439495394963949739498394993950039501395023950339504395053950639507395083950939510395113951239513395143951539516395173951839519395203952139522395233952439525395263952739528395293953039531395323953339534395353953639537395383953939540395413954239543395443954539546395473954839549395503955139552395533955439555395563955739558395593956039561395623956339564395653956639567395683956939570395713957239573395743957539576395773957839579395803958139582395833958439585395863958739588395893959039591395923959339594395953959639597395983959939600396013960239603396043960539606396073960839609396103961139612396133961439615396163961739618396193962039621396223962339624396253962639627396283962939630396313963239633396343963539636396373963839639396403964139642396433964439645396463964739648396493965039651396523965339654396553965639657396583965939660396613966239663396643966539666396673966839669396703967139672396733967439675396763967739678396793968039681396823968339684396853968639687396883968939690396913969239693396943969539696396973969839699397003970139702397033970439705397063970739708397093971039711397123971339714397153971639717397183971939720397213972239723397243972539726397273972839729397303973139732397333973439735397363973739738397393974039741397423974339744397453974639747397483974939750397513975239753397543975539756397573975839759397603976139762397633976439765397663976739768397693977039771397723977339774397753977639777397783977939780397813978239783397843978539786397873978839789397903979139792397933979439795397963979739798397993980039801398023980339804398053980639807398083980939810398113981239813398143981539816398173981839819398203982139822398233982439825398263982739828398293983039831398323983339834398353983639837398383983939840398413984239843398443984539846398473984839849398503985139852398533985439855398563985739858398593986039861398623986339864398653986639867398683986939870398713987239873398743987539876398773987839879398803988139882398833988439885398863988739888398893989039891398923989339894398953989639897398983989939900399013990239903399043990539906399073990839909399103991139912399133991439915399163991739918399193992039921399223992339924399253992639927399283992939930399313993239933399343993539936399373993839939399403994139942399433994439945399463994739948399493995039951399523995339954399553995639957399583995939960399613996239963399643996539966399673996839969399703997139972399733997439975399763997739978399793998039981399823998339984399853998639987399883998939990399913999239993399943999539996399973999839999400004000140002400034000440005400064000740008400094001040011400124001340014400154001640017400184001940020400214002240023400244002540026400274002840029400304003140032400334003440035400364003740038400394004040041400424004340044400454004640047400484004940050400514005240053400544005540056400574005840059400604006140062400634006440065400664006740068400694007040071400724007340074400754007640077400784007940080400814008240083400844008540086400874008840089400904009140092400934009440095400964009740098400994010040101401024010340104401054010640107401084010940110401114011240113401144011540116401174011840119401204012140122401234012440125401264012740128401294013040131401324013340134401354013640137401384013940140401414014240143401444014540146401474014840149401504015140152401534015440155401564015740158401594016040161401624016340164401654016640167401684016940170401714017240173401744017540176401774017840179401804018140182401834018440185401864018740188401894019040191401924019340194401954019640197401984019940200402014020240203402044020540206402074020840209402104021140212402134021440215402164021740218402194022040221402224022340224402254022640227402284022940230402314023240233402344023540236402374023840239402404024140242402434024440245402464024740248402494025040251402524025340254402554025640257402584025940260402614026240263402644026540266402674026840269402704027140272402734027440275402764027740278402794028040281402824028340284402854028640287402884028940290402914029240293402944029540296402974029840299403004030140302403034030440305403064030740308403094031040311403124031340314403154031640317403184031940320403214032240323403244032540326403274032840329403304033140332403334033440335403364033740338403394034040341403424034340344403454034640347403484034940350403514035240353403544035540356403574035840359403604036140362403634036440365403664036740368403694037040371403724037340374403754037640377403784037940380403814038240383403844038540386403874038840389403904039140392403934039440395403964039740398403994040040401404024040340404404054040640407404084040940410404114041240413404144041540416404174041840419404204042140422404234042440425404264042740428404294043040431404324043340434404354043640437404384043940440404414044240443404444044540446404474044840449404504045140452404534045440455404564045740458404594046040461404624046340464404654046640467404684046940470404714047240473404744047540476404774047840479404804048140482404834048440485404864048740488404894049040491404924049340494404954049640497404984049940500405014050240503405044050540506405074050840509405104051140512405134051440515405164051740518405194052040521405224052340524405254052640527405284052940530405314053240533405344053540536405374053840539405404054140542405434054440545405464054740548405494055040551405524055340554405554055640557405584055940560405614056240563405644056540566405674056840569405704057140572405734057440575405764057740578405794058040581405824058340584405854058640587405884058940590405914059240593405944059540596405974059840599406004060140602406034060440605406064060740608406094061040611406124061340614406154061640617406184061940620406214062240623406244062540626406274062840629406304063140632406334063440635406364063740638406394064040641406424064340644406454064640647406484064940650406514065240653406544065540656406574065840659406604066140662406634066440665406664066740668406694067040671406724067340674406754067640677406784067940680406814068240683406844068540686406874068840689406904069140692406934069440695406964069740698406994070040701407024070340704407054070640707407084070940710407114071240713407144071540716407174071840719407204072140722407234072440725407264072740728407294073040731407324073340734407354073640737407384073940740407414074240743407444074540746407474074840749407504075140752407534075440755407564075740758407594076040761407624076340764407654076640767407684076940770407714077240773407744077540776407774077840779407804078140782407834078440785407864078740788407894079040791407924079340794407954079640797407984079940800408014080240803408044080540806408074080840809408104081140812408134081440815408164081740818408194082040821408224082340824408254082640827408284082940830408314083240833408344083540836408374083840839408404084140842408434084440845408464084740848408494085040851408524085340854408554085640857408584085940860408614086240863408644086540866408674086840869408704087140872408734087440875408764087740878408794088040881408824088340884408854088640887408884088940890408914089240893408944089540896408974089840899409004090140902409034090440905409064090740908409094091040911409124091340914409154091640917409184091940920409214092240923409244092540926409274092840929409304093140932409334093440935409364093740938409394094040941409424094340944409454094640947409484094940950409514095240953409544095540956409574095840959409604096140962409634096440965409664096740968409694097040971409724097340974409754097640977409784097940980409814098240983409844098540986409874098840989409904099140992409934099440995409964099740998409994100041001410024100341004410054100641007410084100941010410114101241013410144101541016410174101841019410204102141022410234102441025410264102741028410294103041031410324103341034410354103641037410384103941040410414104241043410444104541046410474104841049410504105141052410534105441055410564105741058410594106041061410624106341064410654106641067410684106941070410714107241073410744107541076410774107841079410804108141082410834108441085410864108741088410894109041091410924109341094410954109641097410984109941100411014110241103411044110541106411074110841109411104111141112411134111441115411164111741118411194112041121411224112341124411254112641127411284112941130411314113241133411344113541136411374113841139411404114141142411434114441145411464114741148411494115041151411524115341154411554115641157411584115941160411614116241163411644116541166411674116841169411704117141172411734117441175411764117741178411794118041181411824118341184411854118641187411884118941190411914119241193411944119541196411974119841199412004120141202412034120441205412064120741208412094121041211412124121341214412154121641217412184121941220412214122241223412244122541226412274122841229412304123141232412334123441235412364123741238412394124041241412424124341244412454124641247412484124941250412514125241253412544125541256412574125841259412604126141262412634126441265412664126741268412694127041271412724127341274412754127641277412784127941280412814128241283412844128541286412874128841289412904129141292412934129441295412964129741298412994130041301413024130341304413054130641307413084130941310413114131241313413144131541316413174131841319413204132141322413234132441325413264132741328413294133041331413324133341334413354133641337413384133941340413414134241343413444134541346413474134841349413504135141352413534135441355413564135741358413594136041361413624136341364413654136641367413684136941370413714137241373413744137541376413774137841379413804138141382413834138441385413864138741388413894139041391413924139341394413954139641397413984139941400414014140241403414044140541406414074140841409414104141141412414134141441415414164141741418414194142041421414224142341424414254142641427414284142941430414314143241433414344143541436414374143841439414404144141442414434144441445414464144741448414494145041451414524145341454414554145641457414584145941460414614146241463414644146541466414674146841469414704147141472414734147441475414764147741478414794148041481414824148341484414854148641487414884148941490414914149241493414944149541496414974149841499415004150141502415034150441505415064150741508415094151041511415124151341514415154151641517415184151941520415214152241523415244152541526415274152841529415304153141532415334153441535415364153741538415394154041541415424154341544415454154641547415484154941550415514155241553415544155541556415574155841559415604156141562415634156441565415664156741568415694157041571415724157341574415754157641577415784157941580415814158241583415844158541586415874158841589415904159141592415934159441595415964159741598415994160041601416024160341604416054160641607416084160941610416114161241613416144161541616416174161841619416204162141622416234162441625416264162741628416294163041631416324163341634416354163641637416384163941640416414164241643416444164541646416474164841649416504165141652416534165441655416564165741658416594166041661416624166341664416654166641667416684166941670416714167241673416744167541676416774167841679416804168141682416834168441685416864168741688416894169041691416924169341694416954169641697416984169941700417014170241703417044170541706417074170841709417104171141712417134171441715417164171741718417194172041721417224172341724417254172641727417284172941730417314173241733417344173541736417374173841739417404174141742417434174441745417464174741748417494175041751417524175341754417554175641757417584175941760417614176241763417644176541766417674176841769417704177141772417734177441775417764177741778417794178041781417824178341784417854178641787417884178941790417914179241793417944179541796417974179841799418004180141802418034180441805418064180741808418094181041811418124181341814418154181641817418184181941820418214182241823418244182541826418274182841829418304183141832418334183441835418364183741838418394184041841418424184341844418454184641847418484184941850418514185241853418544185541856418574185841859418604186141862418634186441865418664186741868418694187041871418724187341874418754187641877418784187941880418814188241883418844188541886418874188841889418904189141892418934189441895418964189741898418994190041901419024190341904419054190641907419084190941910419114191241913419144191541916419174191841919419204192141922419234192441925419264192741928419294193041931419324193341934419354193641937419384193941940419414194241943419444194541946419474194841949419504195141952419534195441955419564195741958419594196041961419624196341964419654196641967419684196941970419714197241973419744197541976419774197841979419804198141982419834198441985419864198741988419894199041991419924199341994419954199641997419984199942000420014200242003420044200542006420074200842009420104201142012420134201442015420164201742018420194202042021420224202342024420254202642027420284202942030420314203242033420344203542036420374203842039420404204142042420434204442045420464204742048420494205042051420524205342054420554205642057420584205942060420614206242063420644206542066420674206842069420704207142072420734207442075420764207742078420794208042081420824208342084420854208642087420884208942090420914209242093420944209542096420974209842099421004210142102421034210442105421064210742108421094211042111421124211342114421154211642117421184211942120421214212242123421244212542126421274212842129421304213142132421334213442135421364213742138421394214042141421424214342144421454214642147421484214942150421514215242153421544215542156421574215842159421604216142162421634216442165421664216742168421694217042171421724217342174421754217642177421784217942180421814218242183421844218542186421874218842189421904219142192421934219442195421964219742198421994220042201422024220342204422054220642207422084220942210422114221242213422144221542216422174221842219422204222142222422234222442225422264222742228422294223042231422324223342234422354223642237422384223942240422414224242243422444224542246422474224842249422504225142252422534225442255422564225742258422594226042261422624226342264422654226642267422684226942270422714227242273422744227542276422774227842279422804228142282422834228442285422864228742288422894229042291422924229342294422954229642297422984229942300423014230242303423044230542306423074230842309423104231142312423134231442315423164231742318423194232042321423224232342324423254232642327423284232942330423314233242333423344233542336423374233842339423404234142342423434234442345423464234742348423494235042351423524235342354423554235642357423584235942360423614236242363423644236542366423674236842369423704237142372423734237442375423764237742378423794238042381423824238342384423854238642387423884238942390423914239242393423944239542396423974239842399424004240142402424034240442405424064240742408424094241042411424124241342414424154241642417424184241942420424214242242423424244242542426424274242842429424304243142432424334243442435424364243742438424394244042441424424244342444424454244642447424484244942450424514245242453424544245542456424574245842459424604246142462424634246442465424664246742468424694247042471424724247342474424754247642477424784247942480424814248242483424844248542486424874248842489424904249142492424934249442495424964249742498424994250042501425024250342504425054250642507425084250942510425114251242513425144251542516425174251842519425204252142522425234252442525425264252742528425294253042531425324253342534425354253642537425384253942540425414254242543425444254542546425474254842549425504255142552425534255442555425564255742558425594256042561425624256342564425654256642567425684256942570425714257242573425744257542576425774257842579425804258142582425834258442585425864258742588425894259042591425924259342594425954259642597425984259942600426014260242603426044260542606426074260842609426104261142612426134261442615426164261742618426194262042621426224262342624426254262642627426284262942630426314263242633426344263542636426374263842639426404264142642426434264442645426464264742648426494265042651426524265342654426554265642657426584265942660426614266242663426644266542666426674266842669426704267142672426734267442675426764267742678426794268042681426824268342684426854268642687426884268942690426914269242693426944269542696426974269842699427004270142702427034270442705427064270742708427094271042711427124271342714427154271642717427184271942720427214272242723427244272542726427274272842729427304273142732427334273442735427364273742738427394274042741427424274342744427454274642747427484274942750427514275242753427544275542756427574275842759427604276142762427634276442765427664276742768427694277042771427724277342774427754277642777427784277942780427814278242783427844278542786427874278842789427904279142792427934279442795427964279742798427994280042801428024280342804428054280642807428084280942810428114281242813428144281542816428174281842819428204282142822428234282442825428264282742828428294283042831428324283342834428354283642837428384283942840428414284242843428444284542846428474284842849428504285142852428534285442855428564285742858428594286042861428624286342864428654286642867428684286942870428714287242873428744287542876428774287842879428804288142882428834288442885428864288742888428894289042891428924289342894428954289642897428984289942900429014290242903429044290542906429074290842909429104291142912429134291442915429164291742918429194292042921429224292342924429254292642927429284292942930429314293242933429344293542936429374293842939429404294142942429434294442945429464294742948429494295042951429524295342954429554295642957429584295942960429614296242963429644296542966429674296842969429704297142972429734297442975429764297742978429794298042981429824298342984429854298642987429884298942990429914299242993429944299542996429974299842999430004300143002430034300443005430064300743008430094301043011430124301343014430154301643017430184301943020430214302243023430244302543026430274302843029430304303143032430334303443035430364303743038430394304043041430424304343044430454304643047430484304943050430514305243053430544305543056430574305843059430604306143062430634306443065430664306743068430694307043071430724307343074430754307643077430784307943080430814308243083430844308543086430874308843089430904309143092430934309443095430964309743098430994310043101431024310343104431054310643107431084310943110431114311243113431144311543116431174311843119431204312143122431234312443125431264312743128431294313043131431324313343134431354313643137431384313943140431414314243143431444314543146431474314843149431504315143152431534315443155431564315743158431594316043161431624316343164431654316643167431684316943170431714317243173431744317543176431774317843179431804318143182431834318443185431864318743188431894319043191431924319343194431954319643197431984319943200432014320243203432044320543206432074320843209432104321143212432134321443215432164321743218432194322043221432224322343224432254322643227432284322943230432314323243233432344323543236432374323843239432404324143242432434324443245432464324743248432494325043251432524325343254432554325643257432584325943260432614326243263432644326543266432674326843269432704327143272432734327443275432764327743278432794328043281432824328343284432854328643287432884328943290432914329243293432944329543296432974329843299433004330143302433034330443305433064330743308433094331043311433124331343314433154331643317433184331943320433214332243323433244332543326433274332843329433304333143332433334333443335433364333743338433394334043341433424334343344433454334643347433484334943350433514335243353433544335543356433574335843359433604336143362433634336443365433664336743368433694337043371433724337343374433754337643377433784337943380433814338243383433844338543386433874338843389433904339143392433934339443395433964339743398433994340043401434024340343404434054340643407434084340943410434114341243413434144341543416434174341843419434204342143422434234342443425434264342743428434294343043431434324343343434434354343643437434384343943440434414344243443434444344543446434474344843449434504345143452434534345443455434564345743458434594346043461434624346343464434654346643467434684346943470434714347243473434744347543476434774347843479434804348143482434834348443485434864348743488434894349043491434924349343494434954349643497434984349943500435014350243503435044350543506435074350843509435104351143512435134351443515435164351743518435194352043521435224352343524435254352643527435284352943530435314353243533435344353543536435374353843539435404354143542435434354443545435464354743548435494355043551435524355343554435554355643557435584355943560435614356243563435644356543566435674356843569435704357143572435734357443575435764357743578435794358043581435824358343584435854358643587435884358943590435914359243593435944359543596435974359843599436004360143602436034360443605436064360743608436094361043611436124361343614436154361643617436184361943620436214362243623436244362543626436274362843629436304363143632436334363443635436364363743638436394364043641436424364343644436454364643647436484364943650436514365243653436544365543656436574365843659436604366143662436634366443665436664366743668436694367043671436724367343674436754367643677436784367943680436814368243683436844368543686436874368843689436904369143692436934369443695436964369743698436994370043701437024370343704437054370643707437084370943710437114371243713437144371543716437174371843719437204372143722437234372443725437264372743728437294373043731437324373343734437354373643737437384373943740437414374243743437444374543746437474374843749437504375143752437534375443755437564375743758437594376043761437624376343764437654376643767437684376943770437714377243773437744377543776437774377843779437804378143782437834378443785437864378743788437894379043791437924379343794437954379643797437984379943800438014380243803438044380543806438074380843809438104381143812438134381443815438164381743818438194382043821438224382343824438254382643827438284382943830438314383243833438344383543836438374383843839438404384143842438434384443845438464384743848438494385043851438524385343854438554385643857438584385943860438614386243863438644386543866438674386843869438704387143872438734387443875438764387743878438794388043881438824388343884438854388643887438884388943890438914389243893438944389543896438974389843899439004390143902439034390443905439064390743908439094391043911439124391343914439154391643917439184391943920439214392243923439244392543926439274392843929439304393143932439334393443935439364393743938439394394043941439424394343944439454394643947439484394943950439514395243953439544395543956439574395843959439604396143962439634396443965439664396743968439694397043971439724397343974439754397643977439784397943980439814398243983439844398543986439874398843989439904399143992439934399443995439964399743998439994400044001440024400344004440054400644007440084400944010440114401244013440144401544016440174401844019440204402144022440234402444025440264402744028440294403044031440324403344034440354403644037440384403944040440414404244043440444404544046440474404844049440504405144052440534405444055440564405744058440594406044061440624406344064440654406644067440684406944070440714407244073440744407544076440774407844079440804408144082440834408444085440864408744088440894409044091440924409344094440954409644097440984409944100441014410244103441044410544106441074410844109441104411144112441134411444115441164411744118441194412044121441224412344124441254412644127441284412944130441314413244133441344413544136441374413844139441404414144142441434414444145441464414744148441494415044151441524415344154441554415644157441584415944160441614416244163441644416544166441674416844169441704417144172441734417444175441764417744178441794418044181441824418344184441854418644187441884418944190441914419244193441944419544196441974419844199442004420144202442034420444205442064420744208442094421044211442124421344214442154421644217442184421944220442214422244223442244422544226442274422844229442304423144232442334423444235442364423744238442394424044241442424424344244442454424644247442484424944250442514425244253442544425544256442574425844259442604426144262442634426444265442664426744268442694427044271442724427344274442754427644277442784427944280442814428244283442844428544286442874428844289442904429144292442934429444295442964429744298442994430044301443024430344304443054430644307443084430944310443114431244313443144431544316443174431844319443204432144322443234432444325443264432744328443294433044331443324433344334443354433644337443384433944340443414434244343443444434544346443474434844349443504435144352443534435444355443564435744358443594436044361443624436344364443654436644367443684436944370443714437244373443744437544376443774437844379443804438144382443834438444385443864438744388443894439044391443924439344394443954439644397443984439944400444014440244403444044440544406444074440844409444104441144412444134441444415444164441744418444194442044421444224442344424444254442644427444284442944430444314443244433444344443544436444374443844439444404444144442444434444444445444464444744448444494445044451444524445344454444554445644457444584445944460444614446244463444644446544466444674446844469444704447144472444734447444475444764447744478444794448044481444824448344484444854448644487444884448944490444914449244493444944449544496444974449844499445004450144502445034450444505445064450744508445094451044511445124451344514445154451644517445184451944520445214452244523445244452544526445274452844529445304453144532445334453444535445364453744538445394454044541445424454344544445454454644547445484454944550445514455244553445544455544556445574455844559445604456144562445634456444565445664456744568445694457044571445724457344574445754457644577445784457944580445814458244583445844458544586445874458844589445904459144592445934459444595445964459744598445994460044601446024460344604446054460644607446084460944610446114461244613446144461544616446174461844619446204462144622446234462444625446264462744628446294463044631446324463344634446354463644637446384463944640446414464244643446444464544646446474464844649446504465144652446534465444655446564465744658446594466044661446624466344664446654466644667446684466944670446714467244673446744467544676446774467844679446804468144682446834468444685446864468744688446894469044691446924469344694446954469644697446984469944700447014470244703447044470544706447074470844709447104471144712447134471444715447164471744718447194472044721447224472344724447254472644727447284472944730447314473244733447344473544736447374473844739447404474144742447434474444745447464474744748447494475044751447524475344754447554475644757447584475944760447614476244763447644476544766447674476844769447704477144772447734477444775447764477744778447794478044781447824478344784447854478644787447884478944790447914479244793447944479544796447974479844799448004480144802448034480444805448064480744808448094481044811448124481344814448154481644817448184481944820448214482244823448244482544826448274482844829448304483144832448334483444835448364483744838448394484044841448424484344844448454484644847448484484944850448514485244853448544485544856448574485844859448604486144862448634486444865448664486744868448694487044871448724487344874448754487644877448784487944880448814488244883448844488544886448874488844889448904489144892448934489444895448964489744898448994490044901449024490344904449054490644907449084490944910449114491244913449144491544916449174491844919449204492144922449234492444925449264492744928449294493044931449324493344934449354493644937449384493944940449414494244943449444494544946449474494844949449504495144952449534495444955449564495744958449594496044961449624496344964449654496644967449684496944970449714497244973449744497544976449774497844979449804498144982449834498444985449864498744988449894499044991449924499344994449954499644997449984499945000450014500245003450044500545006450074500845009450104501145012450134501445015450164501745018450194502045021450224502345024450254502645027450284502945030450314503245033450344503545036450374503845039450404504145042450434504445045450464504745048450494505045051450524505345054450554505645057450584505945060450614506245063450644506545066450674506845069450704507145072450734507445075450764507745078450794508045081450824508345084450854508645087450884508945090450914509245093450944509545096450974509845099451004510145102451034510445105451064510745108451094511045111451124511345114451154511645117451184511945120451214512245123451244512545126451274512845129451304513145132451334513445135451364513745138451394514045141451424514345144451454514645147451484514945150451514515245153451544515545156451574515845159451604516145162451634516445165451664516745168451694517045171451724517345174451754517645177451784517945180451814518245183451844518545186451874518845189451904519145192451934519445195451964519745198451994520045201452024520345204452054520645207452084520945210452114521245213452144521545216452174521845219452204522145222452234522445225452264522745228452294523045231452324523345234452354523645237452384523945240452414524245243452444524545246452474524845249452504525145252452534525445255452564525745258452594526045261452624526345264452654526645267452684526945270452714527245273452744527545276452774527845279452804528145282452834528445285452864528745288452894529045291452924529345294452954529645297452984529945300453014530245303453044530545306453074530845309453104531145312453134531445315453164531745318453194532045321453224532345324453254532645327453284532945330453314533245333453344533545336453374533845339453404534145342453434534445345453464534745348453494535045351453524535345354453554535645357453584535945360453614536245363453644536545366453674536845369453704537145372453734537445375453764537745378453794538045381453824538345384453854538645387453884538945390453914539245393453944539545396453974539845399454004540145402454034540445405454064540745408454094541045411454124541345414454154541645417454184541945420454214542245423454244542545426454274542845429454304543145432454334543445435454364543745438454394544045441454424544345444454454544645447454484544945450454514545245453454544545545456454574545845459454604546145462454634546445465454664546745468454694547045471454724547345474454754547645477454784547945480454814548245483454844548545486454874548845489454904549145492454934549445495454964549745498454994550045501455024550345504455054550645507455084550945510455114551245513455144551545516455174551845519455204552145522455234552445525455264552745528455294553045531455324553345534455354553645537455384553945540455414554245543455444554545546455474554845549455504555145552455534555445555455564555745558455594556045561455624556345564455654556645567455684556945570455714557245573455744557545576455774557845579455804558145582455834558445585455864558745588455894559045591455924559345594455954559645597455984559945600456014560245603456044560545606456074560845609456104561145612456134561445615456164561745618456194562045621456224562345624456254562645627456284562945630456314563245633456344563545636456374563845639456404564145642456434564445645456464564745648456494565045651456524565345654456554565645657456584565945660456614566245663456644566545666456674566845669456704567145672456734567445675456764567745678456794568045681456824568345684456854568645687456884568945690456914569245693456944569545696456974569845699457004570145702457034570445705457064570745708457094571045711457124571345714457154571645717457184571945720457214572245723457244572545726457274572845729457304573145732457334573445735457364573745738457394574045741457424574345744457454574645747457484574945750457514575245753457544575545756457574575845759457604576145762457634576445765457664576745768457694577045771457724577345774457754577645777457784577945780457814578245783457844578545786457874578845789457904579145792457934579445795457964579745798457994580045801458024580345804458054580645807458084580945810458114581245813458144581545816458174581845819458204582145822458234582445825458264582745828458294583045831458324583345834458354583645837458384583945840458414584245843458444584545846458474584845849458504585145852458534585445855458564585745858458594586045861458624586345864458654586645867458684586945870458714587245873458744587545876458774587845879458804588145882458834588445885458864588745888458894589045891458924589345894458954589645897458984589945900459014590245903459044590545906459074590845909459104591145912459134591445915459164591745918459194592045921459224592345924459254592645927459284592945930459314593245933459344593545936459374593845939459404594145942459434594445945459464594745948459494595045951459524595345954459554595645957459584595945960459614596245963459644596545966459674596845969459704597145972459734597445975459764597745978459794598045981459824598345984459854598645987459884598945990459914599245993459944599545996459974599845999460004600146002460034600446005460064600746008460094601046011460124601346014460154601646017460184601946020460214602246023460244602546026460274602846029460304603146032460334603446035460364603746038460394604046041460424604346044460454604646047460484604946050460514605246053460544605546056460574605846059460604606146062460634606446065460664606746068460694607046071460724607346074460754607646077460784607946080460814608246083460844608546086460874608846089460904609146092460934609446095460964609746098460994610046101461024610346104461054610646107461084610946110461114611246113461144611546116461174611846119461204612146122461234612446125461264612746128461294613046131461324613346134461354613646137461384613946140461414614246143461444614546146461474614846149461504615146152461534615446155461564615746158461594616046161461624616346164461654616646167461684616946170461714617246173461744617546176461774617846179461804618146182461834618446185461864618746188461894619046191461924619346194461954619646197461984619946200462014620246203462044620546206462074620846209462104621146212462134621446215462164621746218462194622046221462224622346224462254622646227462284622946230462314623246233462344623546236462374623846239462404624146242462434624446245462464624746248462494625046251462524625346254462554625646257462584625946260462614626246263462644626546266462674626846269462704627146272462734627446275462764627746278462794628046281462824628346284462854628646287462884628946290462914629246293462944629546296462974629846299463004630146302463034630446305463064630746308463094631046311463124631346314463154631646317463184631946320463214632246323463244632546326463274632846329463304633146332463334633446335463364633746338463394634046341463424634346344463454634646347463484634946350463514635246353463544635546356463574635846359463604636146362463634636446365463664636746368463694637046371463724637346374463754637646377463784637946380463814638246383463844638546386463874638846389463904639146392463934639446395463964639746398463994640046401464024640346404464054640646407464084640946410464114641246413464144641546416464174641846419464204642146422464234642446425464264642746428464294643046431464324643346434464354643646437464384643946440464414644246443464444644546446464474644846449464504645146452464534645446455464564645746458464594646046461464624646346464464654646646467464684646946470464714647246473464744647546476464774647846479464804648146482464834648446485464864648746488464894649046491464924649346494464954649646497464984649946500465014650246503465044650546506465074650846509465104651146512465134651446515465164651746518465194652046521465224652346524465254652646527465284652946530465314653246533465344653546536465374653846539465404654146542465434654446545465464654746548465494655046551465524655346554465554655646557465584655946560465614656246563465644656546566465674656846569465704657146572465734657446575465764657746578465794658046581465824658346584465854658646587465884658946590465914659246593465944659546596465974659846599466004660146602466034660446605466064660746608466094661046611466124661346614466154661646617466184661946620466214662246623466244662546626466274662846629466304663146632466334663446635466364663746638466394664046641466424664346644466454664646647466484664946650466514665246653466544665546656466574665846659466604666146662466634666446665466664666746668466694667046671466724667346674466754667646677466784667946680466814668246683466844668546686466874668846689466904669146692466934669446695466964669746698466994670046701467024670346704467054670646707467084670946710467114671246713467144671546716467174671846719467204672146722467234672446725467264672746728467294673046731467324673346734467354673646737467384673946740467414674246743467444674546746467474674846749467504675146752467534675446755467564675746758467594676046761467624676346764467654676646767467684676946770467714677246773467744677546776467774677846779467804678146782467834678446785467864678746788467894679046791467924679346794467954679646797467984679946800468014680246803468044680546806468074680846809468104681146812468134681446815468164681746818468194682046821468224682346824468254682646827468284682946830468314683246833468344683546836468374683846839468404684146842468434684446845468464684746848468494685046851468524685346854468554685646857468584685946860468614686246863468644686546866468674686846869468704687146872468734687446875468764687746878468794688046881468824688346884468854688646887468884688946890468914689246893468944689546896468974689846899469004690146902469034690446905469064690746908469094691046911469124691346914469154691646917469184691946920469214692246923469244692546926469274692846929469304693146932469334693446935469364693746938469394694046941469424694346944469454694646947469484694946950469514695246953469544695546956469574695846959469604696146962469634696446965469664696746968469694697046971469724697346974469754697646977469784697946980469814698246983469844698546986469874698846989469904699146992469934699446995469964699746998469994700047001470024700347004470054700647007470084700947010470114701247013470144701547016470174701847019470204702147022470234702447025470264702747028470294703047031470324703347034470354703647037470384703947040470414704247043470444704547046470474704847049470504705147052470534705447055470564705747058470594706047061470624706347064470654706647067470684706947070470714707247073470744707547076470774707847079470804708147082470834708447085470864708747088470894709047091470924709347094470954709647097470984709947100471014710247103471044710547106471074710847109471104711147112471134711447115471164711747118471194712047121471224712347124471254712647127471284712947130471314713247133471344713547136471374713847139471404714147142471434714447145471464714747148471494715047151471524715347154471554715647157471584715947160471614716247163471644716547166471674716847169471704717147172471734717447175471764717747178471794718047181471824718347184471854718647187471884718947190471914719247193471944719547196471974719847199472004720147202472034720447205472064720747208472094721047211472124721347214472154721647217472184721947220472214722247223472244722547226472274722847229472304723147232472334723447235472364723747238472394724047241472424724347244472454724647247472484724947250472514725247253472544725547256472574725847259472604726147262472634726447265472664726747268472694727047271472724727347274472754727647277472784727947280472814728247283472844728547286472874728847289472904729147292472934729447295472964729747298472994730047301473024730347304473054730647307473084730947310473114731247313473144731547316473174731847319473204732147322473234732447325473264732747328473294733047331473324733347334473354733647337473384733947340473414734247343473444734547346473474734847349473504735147352473534735447355473564735747358473594736047361473624736347364473654736647367473684736947370473714737247373473744737547376473774737847379473804738147382473834738447385473864738747388473894739047391473924739347394473954739647397473984739947400474014740247403474044740547406474074740847409474104741147412474134741447415474164741747418474194742047421474224742347424474254742647427474284742947430474314743247433474344743547436474374743847439474404744147442474434744447445474464744747448474494745047451474524745347454474554745647457474584745947460474614746247463474644746547466474674746847469474704747147472474734747447475474764747747478474794748047481474824748347484474854748647487474884748947490474914749247493474944749547496474974749847499475004750147502475034750447505475064750747508475094751047511475124751347514475154751647517475184751947520475214752247523475244752547526475274752847529475304753147532475334753447535475364753747538475394754047541475424754347544475454754647547475484754947550475514755247553475544755547556475574755847559475604756147562475634756447565475664756747568475694757047571475724757347574475754757647577475784757947580475814758247583475844758547586475874758847589475904759147592475934759447595475964759747598475994760047601476024760347604476054760647607476084760947610476114761247613476144761547616476174761847619476204762147622476234762447625476264762747628476294763047631476324763347634476354763647637476384763947640476414764247643476444764547646476474764847649476504765147652476534765447655476564765747658476594766047661476624766347664476654766647667476684766947670476714767247673476744767547676476774767847679476804768147682476834768447685476864768747688476894769047691476924769347694476954769647697476984769947700477014770247703477044770547706477074770847709477104771147712477134771447715477164771747718477194772047721477224772347724477254772647727477284772947730477314773247733477344773547736477374773847739477404774147742477434774447745477464774747748477494775047751477524775347754477554775647757477584775947760477614776247763477644776547766477674776847769477704777147772477734777447775477764777747778477794778047781477824778347784477854778647787477884778947790477914779247793477944779547796477974779847799478004780147802478034780447805478064780747808478094781047811478124781347814478154781647817478184781947820478214782247823478244782547826478274782847829478304783147832478334783447835478364783747838478394784047841478424784347844478454784647847478484784947850478514785247853478544785547856478574785847859478604786147862478634786447865478664786747868478694787047871478724787347874478754787647877478784787947880478814788247883478844788547886478874788847889478904789147892478934789447895478964789747898478994790047901479024790347904479054790647907479084790947910479114791247913479144791547916479174791847919479204792147922479234792447925479264792747928479294793047931479324793347934479354793647937479384793947940479414794247943479444794547946479474794847949479504795147952479534795447955479564795747958479594796047961479624796347964479654796647967479684796947970479714797247973479744797547976479774797847979479804798147982479834798447985479864798747988479894799047991479924799347994479954799647997479984799948000480014800248003480044800548006480074800848009480104801148012480134801448015480164801748018480194802048021480224802348024480254802648027480284802948030480314803248033480344803548036480374803848039480404804148042480434804448045480464804748048480494805048051480524805348054480554805648057480584805948060480614806248063480644806548066480674806848069480704807148072480734807448075480764807748078480794808048081480824808348084480854808648087480884808948090480914809248093480944809548096480974809848099481004810148102481034810448105481064810748108481094811048111481124811348114481154811648117481184811948120481214812248123481244812548126481274812848129481304813148132481334813448135481364813748138481394814048141481424814348144481454814648147481484814948150481514815248153481544815548156481574815848159481604816148162481634816448165481664816748168481694817048171481724817348174481754817648177481784817948180481814818248183481844818548186481874818848189481904819148192481934819448195481964819748198481994820048201482024820348204482054820648207482084820948210482114821248213482144821548216482174821848219482204822148222482234822448225482264822748228482294823048231482324823348234482354823648237482384823948240482414824248243482444824548246482474824848249482504825148252482534825448255482564825748258482594826048261482624826348264482654826648267482684826948270482714827248273482744827548276482774827848279482804828148282482834828448285482864828748288482894829048291482924829348294482954829648297482984829948300483014830248303483044830548306483074830848309483104831148312483134831448315483164831748318483194832048321483224832348324483254832648327483284832948330483314833248333483344833548336483374833848339483404834148342483434834448345483464834748348483494835048351483524835348354483554835648357483584835948360483614836248363483644836548366483674836848369483704837148372483734837448375483764837748378483794838048381483824838348384483854838648387483884838948390483914839248393483944839548396483974839848399484004840148402484034840448405484064840748408484094841048411484124841348414484154841648417484184841948420484214842248423484244842548426484274842848429484304843148432484334843448435484364843748438484394844048441484424844348444484454844648447484484844948450484514845248453484544845548456484574845848459484604846148462484634846448465484664846748468484694847048471484724847348474484754847648477484784847948480484814848248483484844848548486484874848848489484904849148492484934849448495484964849748498484994850048501485024850348504485054850648507485084850948510485114851248513485144851548516485174851848519485204852148522485234852448525485264852748528485294853048531485324853348534485354853648537485384853948540485414854248543485444854548546485474854848549485504855148552485534855448555485564855748558485594856048561485624856348564485654856648567485684856948570485714857248573485744857548576485774857848579485804858148582485834858448585485864858748588485894859048591485924859348594485954859648597485984859948600486014860248603486044860548606486074860848609486104861148612486134861448615486164861748618486194862048621486224862348624486254862648627486284862948630486314863248633486344863548636486374863848639486404864148642486434864448645486464864748648486494865048651486524865348654486554865648657486584865948660486614866248663486644866548666486674866848669486704867148672486734867448675486764867748678486794868048681486824868348684486854868648687486884868948690486914869248693486944869548696486974869848699487004870148702487034870448705487064870748708487094871048711487124871348714487154871648717487184871948720487214872248723487244872548726487274872848729487304873148732487334873448735487364873748738487394874048741487424874348744487454874648747487484874948750487514875248753487544875548756487574875848759487604876148762487634876448765487664876748768487694877048771487724877348774487754877648777487784877948780487814878248783487844878548786487874878848789487904879148792487934879448795487964879748798487994880048801488024880348804488054880648807488084880948810488114881248813488144881548816488174881848819488204882148822488234882448825488264882748828488294883048831488324883348834488354883648837488384883948840488414884248843488444884548846488474884848849488504885148852488534885448855488564885748858488594886048861488624886348864488654886648867488684886948870488714887248873488744887548876488774887848879488804888148882488834888448885488864888748888488894889048891488924889348894488954889648897488984889948900489014890248903489044890548906489074890848909489104891148912489134891448915489164891748918489194892048921489224892348924489254892648927489284892948930489314893248933489344893548936489374893848939489404894148942489434894448945489464894748948489494895048951489524895348954489554895648957489584895948960489614896248963489644896548966489674896848969489704897148972489734897448975489764897748978489794898048981489824898348984489854898648987489884898948990489914899248993489944899548996489974899848999490004900149002490034900449005490064900749008490094901049011490124901349014490154901649017490184901949020490214902249023490244902549026490274902849029490304903149032490334903449035490364903749038490394904049041490424904349044490454904649047490484904949050490514905249053490544905549056490574905849059490604906149062490634906449065490664906749068490694907049071490724907349074490754907649077490784907949080490814908249083490844908549086490874908849089490904909149092490934909449095490964909749098490994910049101491024910349104491054910649107491084910949110491114911249113491144911549116491174911849119491204912149122491234912449125491264912749128491294913049131491324913349134491354913649137491384913949140491414914249143491444914549146491474914849149491504915149152491534915449155491564915749158491594916049161491624916349164491654916649167491684916949170491714917249173491744917549176491774917849179491804918149182491834918449185491864918749188491894919049191491924919349194491954919649197491984919949200492014920249203492044920549206492074920849209492104921149212492134921449215492164921749218492194922049221492224922349224492254922649227492284922949230492314923249233492344923549236492374923849239492404924149242492434924449245492464924749248492494925049251492524925349254492554925649257492584925949260492614926249263492644926549266492674926849269492704927149272492734927449275492764927749278492794928049281492824928349284492854928649287492884928949290492914929249293492944929549296492974929849299493004930149302493034930449305493064930749308493094931049311493124931349314493154931649317493184931949320493214932249323493244932549326493274932849329493304933149332493334933449335493364933749338493394934049341493424934349344493454934649347493484934949350493514935249353493544935549356493574935849359493604936149362493634936449365493664936749368493694937049371493724937349374493754937649377493784937949380493814938249383493844938549386493874938849389493904939149392493934939449395493964939749398493994940049401494024940349404494054940649407494084940949410494114941249413494144941549416494174941849419494204942149422494234942449425494264942749428494294943049431494324943349434494354943649437494384943949440494414944249443494444944549446494474944849449494504945149452494534945449455494564945749458494594946049461494624946349464494654946649467494684946949470494714947249473494744947549476494774947849479494804948149482494834948449485494864948749488494894949049491494924949349494494954949649497494984949949500495014950249503495044950549506495074950849509495104951149512495134951449515495164951749518495194952049521495224952349524495254952649527495284952949530495314953249533495344953549536495374953849539495404954149542495434954449545495464954749548495494955049551495524955349554495554955649557495584955949560495614956249563495644956549566495674956849569495704957149572495734957449575495764957749578495794958049581495824958349584495854958649587495884958949590495914959249593495944959549596495974959849599496004960149602496034960449605496064960749608496094961049611496124961349614496154961649617496184961949620496214962249623496244962549626496274962849629496304963149632496334963449635496364963749638496394964049641496424964349644496454964649647496484964949650496514965249653496544965549656496574965849659496604966149662496634966449665496664966749668496694967049671496724967349674496754967649677496784967949680496814968249683496844968549686496874968849689496904969149692496934969449695496964969749698496994970049701497024970349704497054970649707497084970949710497114971249713497144971549716497174971849719497204972149722497234972449725497264972749728497294973049731497324973349734497354973649737497384973949740497414974249743497444974549746497474974849749497504975149752497534975449755497564975749758497594976049761497624976349764497654976649767497684976949770497714977249773497744977549776497774977849779497804978149782497834978449785497864978749788497894979049791497924979349794497954979649797497984979949800498014980249803498044980549806498074980849809498104981149812498134981449815498164981749818498194982049821498224982349824498254982649827498284982949830498314983249833498344983549836498374983849839498404984149842498434984449845498464984749848498494985049851498524985349854498554985649857498584985949860498614986249863498644986549866498674986849869498704987149872498734987449875498764987749878498794988049881498824988349884498854988649887498884988949890498914989249893498944989549896498974989849899499004990149902499034990449905499064990749908499094991049911499124991349914499154991649917499184991949920499214992249923499244992549926499274992849929499304993149932499334993449935499364993749938499394994049941499424994349944499454994649947499484994949950499514995249953499544995549956499574995849959499604996149962499634996449965499664996749968499694997049971499724997349974499754997649977499784997949980499814998249983499844998549986499874998849989499904999149992499934999449995499964999749998499995000050001500025000350004500055000650007500085000950010500115001250013500145001550016500175001850019500205002150022500235002450025500265002750028500295003050031500325003350034500355003650037500385003950040500415004250043500445004550046500475004850049500505005150052500535005450055500565005750058500595006050061500625006350064500655006650067500685006950070500715007250073500745007550076500775007850079500805008150082500835008450085500865008750088500895009050091500925009350094500955009650097500985009950100501015010250103501045010550106501075010850109501105011150112501135011450115501165011750118501195012050121501225012350124501255012650127501285012950130501315013250133501345013550136501375013850139501405014150142501435014450145501465014750148501495015050151501525015350154501555015650157501585015950160501615016250163501645016550166501675016850169501705017150172501735017450175501765017750178501795018050181501825018350184501855018650187501885018950190501915019250193501945019550196501975019850199502005020150202502035020450205502065020750208502095021050211502125021350214502155021650217502185021950220502215022250223502245022550226502275022850229502305023150232502335023450235502365023750238502395024050241502425024350244502455024650247502485024950250502515025250253502545025550256502575025850259502605026150262502635026450265502665026750268502695027050271502725027350274502755027650277502785027950280502815028250283502845028550286502875028850289502905029150292502935029450295502965029750298502995030050301503025030350304503055030650307503085030950310503115031250313503145031550316503175031850319503205032150322503235032450325503265032750328503295033050331503325033350334503355033650337503385033950340503415034250343503445034550346503475034850349503505035150352503535035450355503565035750358503595036050361503625036350364503655036650367503685036950370503715037250373503745037550376503775037850379503805038150382503835038450385503865038750388503895039050391503925039350394503955039650397503985039950400504015040250403504045040550406504075040850409504105041150412504135041450415504165041750418504195042050421504225042350424504255042650427504285042950430504315043250433504345043550436504375043850439504405044150442504435044450445504465044750448504495045050451504525045350454504555045650457504585045950460504615046250463504645046550466504675046850469504705047150472504735047450475504765047750478504795048050481504825048350484504855048650487504885048950490504915049250493504945049550496504975049850499505005050150502505035050450505505065050750508505095051050511505125051350514505155051650517505185051950520505215052250523505245052550526505275052850529505305053150532505335053450535505365053750538505395054050541505425054350544505455054650547505485054950550505515055250553505545055550556505575055850559505605056150562505635056450565505665056750568505695057050571505725057350574505755057650577505785057950580505815058250583505845058550586505875058850589505905059150592505935059450595505965059750598505995060050601506025060350604506055060650607506085060950610506115061250613506145061550616506175061850619506205062150622506235062450625506265062750628506295063050631506325063350634506355063650637506385063950640506415064250643506445064550646506475064850649506505065150652506535065450655506565065750658506595066050661506625066350664506655066650667506685066950670506715067250673506745067550676506775067850679506805068150682506835068450685506865068750688506895069050691506925069350694506955069650697506985069950700507015070250703507045070550706507075070850709507105071150712507135071450715507165071750718507195072050721507225072350724507255072650727507285072950730507315073250733507345073550736507375073850739507405074150742507435074450745507465074750748507495075050751507525075350754507555075650757507585075950760507615076250763507645076550766507675076850769507705077150772507735077450775507765077750778507795078050781507825078350784507855078650787507885078950790507915079250793507945079550796507975079850799508005080150802508035080450805508065080750808508095081050811508125081350814508155081650817508185081950820508215082250823508245082550826508275082850829508305083150832508335083450835508365083750838508395084050841508425084350844508455084650847508485084950850508515085250853508545085550856508575085850859508605086150862508635086450865508665086750868508695087050871508725087350874508755087650877508785087950880508815088250883508845088550886508875088850889508905089150892508935089450895508965089750898508995090050901509025090350904509055090650907509085090950910509115091250913509145091550916509175091850919509205092150922509235092450925509265092750928509295093050931509325093350934509355093650937509385093950940509415094250943509445094550946509475094850949509505095150952509535095450955509565095750958509595096050961509625096350964509655096650967509685096950970509715097250973509745097550976509775097850979509805098150982509835098450985509865098750988509895099050991509925099350994509955099650997509985099951000510015100251003510045100551006510075100851009510105101151012510135101451015510165101751018510195102051021510225102351024510255102651027510285102951030510315103251033510345103551036510375103851039510405104151042510435104451045510465104751048510495105051051510525105351054510555105651057510585105951060510615106251063510645106551066510675106851069510705107151072510735107451075510765107751078510795108051081510825108351084510855108651087510885108951090510915109251093510945109551096510975109851099511005110151102511035110451105511065110751108511095111051111511125111351114511155111651117511185111951120511215112251123511245112551126511275112851129511305113151132511335113451135511365113751138511395114051141511425114351144511455114651147511485114951150511515115251153511545115551156511575115851159511605116151162511635116451165511665116751168511695117051171511725117351174511755117651177511785117951180511815118251183511845118551186511875118851189511905119151192511935119451195511965119751198511995120051201512025120351204512055120651207512085120951210512115121251213512145121551216512175121851219512205122151222512235122451225512265122751228512295123051231512325123351234512355123651237512385123951240512415124251243512445124551246512475124851249512505125151252512535125451255512565125751258512595126051261512625126351264512655126651267512685126951270512715127251273512745127551276512775127851279512805128151282512835128451285512865128751288512895129051291512925129351294512955129651297512985129951300513015130251303513045130551306513075130851309513105131151312513135131451315513165131751318513195132051321513225132351324513255132651327513285132951330513315133251333513345133551336513375133851339513405134151342513435134451345513465134751348513495135051351513525135351354513555135651357513585135951360513615136251363513645136551366513675136851369513705137151372513735137451375513765137751378513795138051381513825138351384513855138651387513885138951390513915139251393513945139551396513975139851399514005140151402514035140451405514065140751408514095141051411514125141351414514155141651417514185141951420514215142251423514245142551426514275142851429514305143151432514335143451435514365143751438514395144051441514425144351444514455144651447514485144951450514515145251453514545145551456514575145851459514605146151462514635146451465514665146751468514695147051471514725147351474514755147651477514785147951480514815148251483514845148551486514875148851489514905149151492514935149451495514965149751498514995150051501515025150351504515055150651507515085150951510515115151251513515145151551516515175151851519515205152151522515235152451525515265152751528515295153051531515325153351534515355153651537515385153951540515415154251543515445154551546515475154851549515505155151552515535155451555515565155751558515595156051561515625156351564515655156651567515685156951570515715157251573515745157551576515775157851579515805158151582515835158451585515865158751588515895159051591515925159351594515955159651597515985159951600516015160251603516045160551606516075160851609516105161151612516135161451615516165161751618516195162051621516225162351624516255162651627516285162951630516315163251633516345163551636516375163851639516405164151642516435164451645516465164751648516495165051651516525165351654516555165651657516585165951660516615166251663516645166551666516675166851669516705167151672516735167451675516765167751678516795168051681516825168351684516855168651687516885168951690516915169251693516945169551696516975169851699517005170151702517035170451705517065170751708517095171051711517125171351714517155171651717517185171951720517215172251723517245172551726517275172851729517305173151732517335173451735517365173751738517395174051741517425174351744517455174651747517485174951750517515175251753517545175551756517575175851759517605176151762517635176451765517665176751768517695177051771517725177351774517755177651777517785177951780517815178251783517845178551786517875178851789517905179151792517935179451795517965179751798517995180051801518025180351804518055180651807518085180951810518115181251813518145181551816518175181851819518205182151822518235182451825518265182751828518295183051831518325183351834518355183651837518385183951840518415184251843518445184551846518475184851849518505185151852518535185451855518565185751858518595186051861518625186351864518655186651867518685186951870518715187251873518745187551876518775187851879518805188151882518835188451885518865188751888518895189051891518925189351894518955189651897518985189951900519015190251903519045190551906519075190851909519105191151912519135191451915519165191751918519195192051921519225192351924519255192651927519285192951930519315193251933519345193551936519375193851939519405194151942519435194451945519465194751948519495195051951519525195351954519555195651957519585195951960519615196251963519645196551966519675196851969519705197151972519735197451975519765197751978519795198051981519825198351984519855198651987519885198951990519915199251993519945199551996519975199851999520005200152002520035200452005520065200752008520095201052011520125201352014520155201652017520185201952020520215202252023520245202552026520275202852029520305203152032520335203452035520365203752038520395204052041520425204352044520455204652047520485204952050520515205252053520545205552056520575205852059520605206152062520635206452065520665206752068520695207052071520725207352074520755207652077520785207952080520815208252083520845208552086520875208852089520905209152092520935209452095520965209752098520995210052101521025210352104521055210652107521085210952110521115211252113521145211552116521175211852119521205212152122521235212452125521265212752128521295213052131521325213352134521355213652137521385213952140521415214252143521445214552146521475214852149521505215152152521535215452155521565215752158521595216052161521625216352164521655216652167521685216952170521715217252173521745217552176521775217852179521805218152182521835218452185521865218752188521895219052191521925219352194521955219652197521985219952200522015220252203522045220552206522075220852209522105221152212522135221452215522165221752218522195222052221522225222352224522255222652227522285222952230522315223252233522345223552236522375223852239522405224152242522435224452245522465224752248522495225052251522525225352254522555225652257522585225952260522615226252263522645226552266522675226852269522705227152272522735227452275522765227752278522795228052281522825228352284522855228652287522885228952290522915229252293522945229552296522975229852299523005230152302523035230452305523065230752308523095231052311523125231352314523155231652317523185231952320523215232252323523245232552326523275232852329523305233152332523335233452335523365233752338523395234052341523425234352344523455234652347523485234952350523515235252353523545235552356523575235852359523605236152362523635236452365523665236752368523695237052371523725237352374523755237652377523785237952380523815238252383523845238552386523875238852389523905239152392523935239452395523965239752398523995240052401524025240352404524055240652407524085240952410524115241252413524145241552416524175241852419524205242152422524235242452425524265242752428524295243052431524325243352434524355243652437524385243952440524415244252443524445244552446524475244852449524505245152452524535245452455524565245752458524595246052461524625246352464524655246652467524685246952470524715247252473524745247552476524775247852479524805248152482524835248452485524865248752488524895249052491524925249352494524955249652497524985249952500525015250252503525045250552506525075250852509525105251152512525135251452515525165251752518525195252052521525225252352524525255252652527525285252952530525315253252533525345253552536525375253852539525405254152542525435254452545525465254752548525495255052551525525255352554525555255652557525585255952560525615256252563525645256552566525675256852569525705257152572525735257452575525765257752578525795258052581525825258352584525855258652587525885258952590525915259252593525945259552596525975259852599526005260152602526035260452605526065260752608526095261052611526125261352614526155261652617526185261952620526215262252623526245262552626526275262852629526305263152632526335263452635526365263752638526395264052641526425264352644526455264652647526485264952650526515265252653526545265552656526575265852659526605266152662526635266452665526665266752668526695267052671526725267352674526755267652677526785267952680526815268252683526845268552686526875268852689526905269152692526935269452695526965269752698526995270052701527025270352704527055270652707527085270952710527115271252713527145271552716527175271852719527205272152722527235272452725527265272752728527295273052731527325273352734527355273652737527385273952740527415274252743527445274552746527475274852749527505275152752527535275452755527565275752758527595276052761527625276352764527655276652767527685276952770527715277252773527745277552776527775277852779527805278152782527835278452785527865278752788527895279052791527925279352794527955279652797527985279952800528015280252803528045280552806528075280852809528105281152812528135281452815528165281752818528195282052821528225282352824528255282652827528285282952830528315283252833528345283552836528375283852839528405284152842528435284452845528465284752848528495285052851528525285352854528555285652857528585285952860528615286252863528645286552866528675286852869528705287152872528735287452875528765287752878528795288052881528825288352884528855288652887528885288952890528915289252893528945289552896528975289852899529005290152902529035290452905529065290752908529095291052911529125291352914529155291652917529185291952920529215292252923529245292552926529275292852929529305293152932529335293452935529365293752938529395294052941529425294352944529455294652947529485294952950529515295252953529545295552956529575295852959529605296152962529635296452965529665296752968529695297052971529725297352974529755297652977529785297952980529815298252983529845298552986529875298852989529905299152992529935299452995529965299752998529995300053001530025300353004530055300653007530085300953010530115301253013530145301553016530175301853019530205302153022530235302453025530265302753028530295303053031530325303353034530355303653037530385303953040530415304253043530445304553046530475304853049530505305153052530535305453055530565305753058530595306053061530625306353064530655306653067530685306953070530715307253073530745307553076530775307853079530805308153082530835308453085530865308753088530895309053091530925309353094530955309653097530985309953100531015310253103531045310553106531075310853109531105311153112531135311453115531165311753118531195312053121531225312353124531255312653127531285312953130531315313253133531345313553136531375313853139531405314153142531435314453145531465314753148531495315053151531525315353154531555315653157531585315953160531615316253163531645316553166531675316853169531705317153172531735317453175531765317753178531795318053181531825318353184531855318653187531885318953190531915319253193531945319553196531975319853199532005320153202532035320453205532065320753208532095321053211532125321353214532155321653217532185321953220532215322253223532245322553226532275322853229532305323153232532335323453235532365323753238532395324053241532425324353244532455324653247532485324953250532515325253253532545325553256532575325853259532605326153262532635326453265532665326753268532695327053271532725327353274532755327653277532785327953280532815328253283532845328553286532875328853289532905329153292532935329453295532965329753298532995330053301533025330353304533055330653307533085330953310533115331253313533145331553316533175331853319533205332153322533235332453325533265332753328533295333053331533325333353334533355333653337533385333953340533415334253343533445334553346533475334853349533505335153352533535335453355533565335753358533595336053361533625336353364533655336653367533685336953370533715337253373533745337553376533775337853379533805338153382533835338453385533865338753388533895339053391533925339353394533955339653397533985339953400534015340253403534045340553406534075340853409534105341153412534135341453415534165341753418534195342053421534225342353424534255342653427534285342953430534315343253433534345343553436534375343853439534405344153442534435344453445534465344753448534495345053451534525345353454534555345653457534585345953460534615346253463534645346553466534675346853469534705347153472534735347453475534765347753478534795348053481534825348353484534855348653487534885348953490534915349253493534945349553496534975349853499535005350153502535035350453505535065350753508535095351053511535125351353514535155351653517535185351953520535215352253523535245352553526535275352853529535305353153532535335353453535535365353753538535395354053541535425354353544535455354653547535485354953550535515355253553535545355553556535575355853559535605356153562535635356453565535665356753568535695357053571535725357353574535755357653577535785357953580535815358253583535845358553586535875358853589535905359153592535935359453595535965359753598535995360053601536025360353604536055360653607536085360953610536115361253613536145361553616536175361853619536205362153622536235362453625536265362753628536295363053631536325363353634536355363653637536385363953640536415364253643536445364553646536475364853649536505365153652536535365453655536565365753658536595366053661536625366353664536655366653667536685366953670536715367253673536745367553676536775367853679536805368153682536835368453685536865368753688536895369053691536925369353694536955369653697536985369953700537015370253703537045370553706537075370853709537105371153712537135371453715537165371753718537195372053721537225372353724537255372653727537285372953730537315373253733537345373553736537375373853739537405374153742537435374453745537465374753748537495375053751537525375353754537555375653757537585375953760537615376253763537645376553766537675376853769537705377153772537735377453775537765377753778537795378053781537825378353784537855378653787537885378953790537915379253793537945379553796537975379853799538005380153802538035380453805538065380753808538095381053811538125381353814538155381653817538185381953820538215382253823538245382553826538275382853829538305383153832538335383453835538365383753838538395384053841538425384353844538455384653847538485384953850538515385253853538545385553856538575385853859538605386153862538635386453865538665386753868538695387053871538725387353874538755387653877538785387953880538815388253883538845388553886538875388853889538905389153892538935389453895538965389753898538995390053901539025390353904539055390653907539085390953910539115391253913539145391553916539175391853919539205392153922539235392453925539265392753928539295393053931539325393353934539355393653937539385393953940539415394253943539445394553946539475394853949539505395153952539535395453955539565395753958539595396053961539625396353964539655396653967539685396953970539715397253973539745397553976539775397853979539805398153982539835398453985539865398753988539895399053991539925399353994539955399653997539985399954000540015400254003540045400554006540075400854009540105401154012540135401454015540165401754018540195402054021540225402354024540255402654027540285402954030540315403254033540345403554036540375403854039540405404154042540435404454045540465404754048540495405054051540525405354054540555405654057540585405954060540615406254063540645406554066540675406854069540705407154072540735407454075540765407754078540795408054081540825408354084540855408654087540885408954090540915409254093540945409554096540975409854099541005410154102541035410454105541065410754108541095411054111541125411354114541155411654117541185411954120541215412254123541245412554126541275412854129541305413154132541335413454135541365413754138541395414054141541425414354144541455414654147541485414954150541515415254153541545415554156541575415854159541605416154162541635416454165541665416754168541695417054171541725417354174541755417654177541785417954180541815418254183541845418554186541875418854189541905419154192541935419454195541965419754198541995420054201542025420354204542055420654207542085420954210542115421254213542145421554216542175421854219542205422154222542235422454225542265422754228542295423054231542325423354234542355423654237542385423954240542415424254243542445424554246542475424854249542505425154252542535425454255542565425754258542595426054261542625426354264542655426654267542685426954270542715427254273542745427554276542775427854279542805428154282542835428454285542865428754288542895429054291542925429354294542955429654297542985429954300543015430254303543045430554306543075430854309543105431154312543135431454315543165431754318543195432054321543225432354324543255432654327543285432954330543315433254333543345433554336543375433854339543405434154342543435434454345543465434754348543495435054351543525435354354543555435654357543585435954360543615436254363543645436554366543675436854369543705437154372543735437454375543765437754378543795438054381543825438354384543855438654387543885438954390543915439254393543945439554396543975439854399544005440154402544035440454405544065440754408544095441054411544125441354414544155441654417544185441954420544215442254423544245442554426544275442854429544305443154432544335443454435544365443754438544395444054441544425444354444544455444654447544485444954450544515445254453544545445554456544575445854459544605446154462544635446454465544665446754468544695447054471544725447354474544755447654477544785447954480544815448254483544845448554486544875448854489544905449154492544935449454495544965449754498544995450054501545025450354504545055450654507545085450954510545115451254513545145451554516545175451854519545205452154522545235452454525545265452754528545295453054531545325453354534545355453654537545385453954540545415454254543545445454554546545475454854549545505455154552545535455454555545565455754558545595456054561545625456354564545655456654567545685456954570545715457254573545745457554576545775457854579545805458154582545835458454585545865458754588545895459054591545925459354594545955459654597545985459954600546015460254603546045460554606546075460854609546105461154612546135461454615546165461754618546195462054621546225462354624546255462654627546285462954630546315463254633546345463554636546375463854639546405464154642546435464454645546465464754648546495465054651546525465354654546555465654657546585465954660546615466254663546645466554666546675466854669546705467154672546735467454675546765467754678546795468054681546825468354684546855468654687546885468954690546915469254693546945469554696546975469854699547005470154702547035470454705547065470754708547095471054711547125471354714547155471654717547185471954720547215472254723547245472554726547275472854729547305473154732547335473454735547365473754738547395474054741547425474354744547455474654747547485474954750547515475254753547545475554756547575475854759547605476154762547635476454765547665476754768547695477054771547725477354774547755477654777547785477954780547815478254783547845478554786547875478854789547905479154792547935479454795547965479754798547995480054801548025480354804548055480654807548085480954810548115481254813548145481554816548175481854819548205482154822548235482454825548265482754828548295483054831548325483354834548355483654837548385483954840548415484254843548445484554846548475484854849548505485154852548535485454855548565485754858548595486054861548625486354864548655486654867548685486954870548715487254873548745487554876548775487854879548805488154882548835488454885548865488754888548895489054891548925489354894548955489654897548985489954900549015490254903549045490554906549075490854909549105491154912549135491454915549165491754918549195492054921549225492354924549255492654927549285492954930549315493254933549345493554936549375493854939549405494154942549435494454945549465494754948549495495054951549525495354954549555495654957549585495954960549615496254963549645496554966549675496854969549705497154972549735497454975549765497754978549795498054981549825498354984549855498654987549885498954990549915499254993549945499554996549975499854999550005500155002550035500455005550065500755008550095501055011550125501355014550155501655017550185501955020550215502255023550245502555026550275502855029550305503155032550335503455035550365503755038550395504055041550425504355044550455504655047550485504955050550515505255053550545505555056550575505855059550605506155062550635506455065550665506755068550695507055071550725507355074550755507655077550785507955080550815508255083550845508555086550875508855089550905509155092550935509455095550965509755098550995510055101551025510355104551055510655107551085510955110551115511255113551145511555116551175511855119551205512155122551235512455125551265512755128551295513055131551325513355134551355513655137551385513955140551415514255143551445514555146551475514855149551505515155152551535515455155551565515755158551595516055161551625516355164551655516655167551685516955170551715517255173551745517555176551775517855179551805518155182551835518455185551865518755188551895519055191551925519355194551955519655197551985519955200552015520255203552045520555206552075520855209552105521155212552135521455215552165521755218552195522055221552225522355224552255522655227552285522955230552315523255233552345523555236552375523855239552405524155242552435524455245552465524755248552495525055251552525525355254552555525655257552585525955260552615526255263552645526555266552675526855269552705527155272552735527455275552765527755278552795528055281552825528355284552855528655287552885528955290552915529255293552945529555296552975529855299553005530155302553035530455305553065530755308553095531055311553125531355314553155531655317553185531955320553215532255323553245532555326553275532855329553305533155332553335533455335553365533755338553395534055341553425534355344553455534655347553485534955350553515535255353553545535555356553575535855359553605536155362553635536455365553665536755368553695537055371553725537355374553755537655377553785537955380553815538255383553845538555386553875538855389553905539155392553935539455395553965539755398553995540055401554025540355404554055540655407554085540955410554115541255413554145541555416554175541855419554205542155422554235542455425554265542755428554295543055431554325543355434554355543655437554385543955440554415544255443554445544555446554475544855449554505545155452554535545455455554565545755458554595546055461554625546355464554655546655467554685546955470554715547255473554745547555476554775547855479554805548155482554835548455485554865548755488554895549055491554925549355494554955549655497554985549955500555015550255503555045550555506555075550855509555105551155512555135551455515555165551755518555195552055521555225552355524555255552655527555285552955530555315553255533555345553555536555375553855539555405554155542555435554455545555465554755548555495555055551555525555355554555555555655557555585555955560555615556255563555645556555566555675556855569555705557155572555735557455575555765557755578555795558055581555825558355584555855558655587555885558955590555915559255593555945559555596555975559855599556005560155602556035560455605556065560755608556095561055611556125561355614556155561655617556185561955620556215562255623556245562555626556275562855629556305563155632556335563455635556365563755638556395564055641556425564355644556455564655647556485564955650556515565255653556545565555656556575565855659556605566155662556635566455665556665566755668556695567055671556725567355674556755567655677556785567955680556815568255683556845568555686556875568855689556905569155692556935569455695556965569755698556995570055701557025570355704557055570655707557085570955710557115571255713557145571555716557175571855719557205572155722557235572455725557265572755728557295573055731557325573355734557355573655737557385573955740557415574255743557445574555746557475574855749557505575155752557535575455755557565575755758557595576055761557625576355764557655576655767557685576955770557715577255773557745577555776557775577855779557805578155782557835578455785557865578755788557895579055791557925579355794557955579655797557985579955800558015580255803558045580555806558075580855809558105581155812558135581455815558165581755818558195582055821558225582355824558255582655827558285582955830558315583255833558345583555836558375583855839558405584155842558435584455845558465584755848558495585055851558525585355854558555585655857558585585955860558615586255863558645586555866558675586855869558705587155872558735587455875558765587755878558795588055881558825588355884558855588655887558885588955890558915589255893558945589555896558975589855899559005590155902559035590455905559065590755908559095591055911559125591355914559155591655917559185591955920559215592255923559245592555926559275592855929559305593155932559335593455935559365593755938559395594055941559425594355944559455594655947559485594955950559515595255953559545595555956559575595855959559605596155962559635596455965559665596755968559695597055971559725597355974559755597655977559785597955980559815598255983559845598555986559875598855989559905599155992559935599455995559965599755998559995600056001560025600356004560055600656007560085600956010560115601256013560145601556016560175601856019560205602156022560235602456025560265602756028560295603056031560325603356034560355603656037560385603956040560415604256043560445604556046560475604856049560505605156052560535605456055560565605756058560595606056061560625606356064560655606656067560685606956070560715607256073560745607556076560775607856079560805608156082560835608456085560865608756088560895609056091560925609356094560955609656097560985609956100561015610256103561045610556106561075610856109561105611156112561135611456115561165611756118561195612056121561225612356124561255612656127561285612956130561315613256133561345613556136561375613856139561405614156142561435614456145561465614756148561495615056151561525615356154561555615656157561585615956160561615616256163561645616556166561675616856169561705617156172561735617456175561765617756178561795618056181561825618356184561855618656187561885618956190561915619256193561945619556196561975619856199562005620156202562035620456205562065620756208562095621056211562125621356214562155621656217562185621956220562215622256223562245622556226562275622856229562305623156232562335623456235562365623756238562395624056241562425624356244562455624656247562485624956250562515625256253562545625556256562575625856259562605626156262562635626456265562665626756268562695627056271562725627356274562755627656277562785627956280562815628256283562845628556286562875628856289562905629156292562935629456295562965629756298562995630056301563025630356304563055630656307563085630956310563115631256313563145631556316563175631856319563205632156322563235632456325563265632756328563295633056331563325633356334563355633656337563385633956340563415634256343563445634556346563475634856349563505635156352563535635456355563565635756358563595636056361563625636356364563655636656367563685636956370563715637256373563745637556376563775637856379563805638156382563835638456385563865638756388563895639056391563925639356394563955639656397563985639956400564015640256403564045640556406564075640856409564105641156412564135641456415564165641756418564195642056421564225642356424564255642656427564285642956430564315643256433564345643556436564375643856439564405644156442564435644456445564465644756448564495645056451564525645356454564555645656457564585645956460564615646256463564645646556466564675646856469564705647156472564735647456475564765647756478564795648056481564825648356484564855648656487564885648956490564915649256493564945649556496564975649856499565005650156502565035650456505565065650756508565095651056511565125651356514565155651656517565185651956520565215652256523565245652556526565275652856529565305653156532565335653456535565365653756538565395654056541565425654356544565455654656547565485654956550565515655256553565545655556556565575655856559565605656156562565635656456565565665656756568565695657056571565725657356574565755657656577565785657956580565815658256583565845658556586565875658856589565905659156592565935659456595565965659756598565995660056601566025660356604566055660656607566085660956610566115661256613566145661556616566175661856619566205662156622566235662456625566265662756628566295663056631566325663356634566355663656637566385663956640566415664256643566445664556646566475664856649566505665156652566535665456655566565665756658566595666056661566625666356664566655666656667566685666956670566715667256673566745667556676566775667856679566805668156682566835668456685566865668756688566895669056691566925669356694566955669656697566985669956700567015670256703567045670556706567075670856709567105671156712567135671456715567165671756718567195672056721567225672356724567255672656727567285672956730567315673256733567345673556736567375673856739567405674156742567435674456745567465674756748567495675056751567525675356754567555675656757567585675956760567615676256763567645676556766567675676856769567705677156772567735677456775567765677756778567795678056781567825678356784567855678656787567885678956790567915679256793567945679556796567975679856799568005680156802568035680456805568065680756808568095681056811568125681356814568155681656817568185681956820568215682256823568245682556826568275682856829568305683156832568335683456835568365683756838568395684056841568425684356844568455684656847568485684956850568515685256853568545685556856568575685856859568605686156862568635686456865568665686756868568695687056871568725687356874568755687656877568785687956880568815688256883568845688556886568875688856889568905689156892568935689456895568965689756898568995690056901569025690356904569055690656907569085690956910569115691256913569145691556916569175691856919569205692156922569235692456925569265692756928569295693056931569325693356934569355693656937569385693956940569415694256943569445694556946569475694856949569505695156952569535695456955569565695756958569595696056961569625696356964569655696656967569685696956970569715697256973569745697556976569775697856979569805698156982569835698456985569865698756988569895699056991569925699356994569955699656997569985699957000570015700257003570045700557006570075700857009570105701157012570135701457015570165701757018570195702057021570225702357024570255702657027570285702957030570315703257033570345703557036570375703857039570405704157042570435704457045570465704757048570495705057051570525705357054570555705657057570585705957060570615706257063570645706557066570675706857069570705707157072570735707457075570765707757078570795708057081570825708357084570855708657087570885708957090570915709257093570945709557096570975709857099571005710157102571035710457105571065710757108571095711057111571125711357114571155711657117571185711957120571215712257123571245712557126571275712857129571305713157132571335713457135571365713757138571395714057141571425714357144571455714657147571485714957150571515715257153571545715557156571575715857159571605716157162571635716457165571665716757168571695717057171571725717357174571755717657177571785717957180571815718257183571845718557186571875718857189571905719157192571935719457195571965719757198571995720057201572025720357204572055720657207572085720957210572115721257213572145721557216572175721857219572205722157222572235722457225572265722757228572295723057231572325723357234572355723657237572385723957240572415724257243572445724557246572475724857249572505725157252572535725457255572565725757258572595726057261572625726357264572655726657267572685726957270572715727257273572745727557276572775727857279572805728157282572835728457285572865728757288572895729057291572925729357294572955729657297572985729957300573015730257303573045730557306573075730857309573105731157312573135731457315573165731757318573195732057321573225732357324573255732657327573285732957330573315733257333573345733557336573375733857339573405734157342573435734457345573465734757348573495735057351573525735357354573555735657357573585735957360573615736257363573645736557366573675736857369573705737157372573735737457375573765737757378573795738057381573825738357384573855738657387573885738957390573915739257393573945739557396573975739857399574005740157402574035740457405574065740757408574095741057411574125741357414574155741657417574185741957420574215742257423574245742557426574275742857429574305743157432574335743457435574365743757438574395744057441574425744357444574455744657447574485744957450574515745257453574545745557456574575745857459574605746157462574635746457465574665746757468574695747057471574725747357474574755747657477574785747957480574815748257483574845748557486574875748857489574905749157492574935749457495574965749757498574995750057501575025750357504575055750657507575085750957510575115751257513575145751557516575175751857519575205752157522575235752457525575265752757528575295753057531575325753357534575355753657537575385753957540575415754257543575445754557546575475754857549575505755157552575535755457555575565755757558575595756057561575625756357564575655756657567575685756957570575715757257573575745757557576575775757857579575805758157582575835758457585575865758757588575895759057591575925759357594575955759657597575985759957600576015760257603576045760557606576075760857609576105761157612576135761457615576165761757618576195762057621576225762357624576255762657627576285762957630576315763257633576345763557636576375763857639576405764157642576435764457645576465764757648576495765057651576525765357654576555765657657576585765957660576615766257663576645766557666576675766857669576705767157672576735767457675576765767757678576795768057681576825768357684576855768657687576885768957690576915769257693576945769557696576975769857699577005770157702577035770457705577065770757708577095771057711577125771357714577155771657717577185771957720577215772257723577245772557726577275772857729577305773157732577335773457735577365773757738577395774057741577425774357744577455774657747577485774957750577515775257753577545775557756577575775857759577605776157762577635776457765577665776757768577695777057771577725777357774577755777657777577785777957780577815778257783577845778557786577875778857789577905779157792577935779457795577965779757798577995780057801578025780357804578055780657807578085780957810578115781257813578145781557816578175781857819578205782157822578235782457825578265782757828578295783057831578325783357834578355783657837578385783957840578415784257843578445784557846578475784857849578505785157852578535785457855578565785757858578595786057861578625786357864578655786657867578685786957870578715787257873578745787557876578775787857879578805788157882578835788457885578865788757888578895789057891578925789357894578955789657897578985789957900579015790257903579045790557906579075790857909579105791157912579135791457915579165791757918579195792057921579225792357924579255792657927579285792957930579315793257933579345793557936579375793857939579405794157942579435794457945579465794757948579495795057951579525795357954579555795657957579585795957960579615796257963579645796557966579675796857969579705797157972579735797457975579765797757978579795798057981579825798357984579855798657987579885798957990579915799257993579945799557996579975799857999580005800158002580035800458005580065800758008580095801058011580125801358014580155801658017580185801958020580215802258023580245802558026580275802858029580305803158032580335803458035580365803758038580395804058041580425804358044580455804658047580485804958050580515805258053580545805558056580575805858059580605806158062580635806458065580665806758068580695807058071580725807358074580755807658077580785807958080580815808258083580845808558086580875808858089580905809158092580935809458095580965809758098580995810058101581025810358104581055810658107581085810958110581115811258113581145811558116581175811858119581205812158122581235812458125581265812758128581295813058131581325813358134581355813658137581385813958140581415814258143581445814558146581475814858149581505815158152581535815458155581565815758158581595816058161581625816358164581655816658167581685816958170581715817258173581745817558176581775817858179581805818158182581835818458185581865818758188581895819058191581925819358194581955819658197581985819958200582015820258203582045820558206582075820858209582105821158212582135821458215582165821758218582195822058221582225822358224582255822658227582285822958230582315823258233582345823558236582375823858239582405824158242582435824458245582465824758248582495825058251582525825358254582555825658257582585825958260582615826258263582645826558266582675826858269582705827158272582735827458275582765827758278582795828058281582825828358284582855828658287582885828958290582915829258293582945829558296582975829858299583005830158302583035830458305583065830758308583095831058311583125831358314583155831658317583185831958320583215832258323583245832558326583275832858329583305833158332583335833458335583365833758338583395834058341583425834358344583455834658347583485834958350583515835258353583545835558356583575835858359583605836158362583635836458365583665836758368583695837058371583725837358374583755837658377583785837958380583815838258383583845838558386583875838858389583905839158392583935839458395583965839758398583995840058401584025840358404584055840658407584085840958410584115841258413584145841558416584175841858419584205842158422584235842458425584265842758428584295843058431584325843358434584355843658437584385843958440584415844258443584445844558446584475844858449584505845158452584535845458455584565845758458584595846058461584625846358464584655846658467584685846958470584715847258473584745847558476584775847858479584805848158482584835848458485584865848758488584895849058491584925849358494584955849658497584985849958500585015850258503585045850558506585075850858509585105851158512585135851458515585165851758518585195852058521585225852358524585255852658527585285852958530585315853258533585345853558536585375853858539585405854158542585435854458545585465854758548585495855058551585525855358554585555855658557585585855958560585615856258563585645856558566585675856858569585705857158572585735857458575585765857758578585795858058581585825858358584585855858658587585885858958590585915859258593585945859558596585975859858599586005860158602586035860458605586065860758608586095861058611586125861358614586155861658617586185861958620586215862258623586245862558626586275862858629586305863158632586335863458635586365863758638586395864058641586425864358644586455864658647586485864958650586515865258653586545865558656586575865858659586605866158662586635866458665586665866758668586695867058671586725867358674586755867658677586785867958680586815868258683586845868558686586875868858689586905869158692586935869458695586965869758698586995870058701587025870358704587055870658707587085870958710587115871258713587145871558716587175871858719587205872158722587235872458725587265872758728587295873058731587325873358734587355873658737587385873958740587415874258743587445874558746587475874858749587505875158752587535875458755587565875758758587595876058761587625876358764587655876658767587685876958770587715877258773587745877558776587775877858779587805878158782587835878458785587865878758788587895879058791587925879358794587955879658797587985879958800588015880258803588045880558806588075880858809588105881158812588135881458815588165881758818588195882058821588225882358824588255882658827588285882958830588315883258833588345883558836588375883858839588405884158842588435884458845588465884758848588495885058851588525885358854588555885658857588585885958860588615886258863588645886558866588675886858869588705887158872588735887458875588765887758878588795888058881588825888358884588855888658887588885888958890588915889258893588945889558896588975889858899589005890158902589035890458905589065890758908589095891058911589125891358914589155891658917589185891958920589215892258923589245892558926589275892858929589305893158932589335893458935589365893758938589395894058941589425894358944589455894658947589485894958950589515895258953589545895558956589575895858959589605896158962589635896458965589665896758968589695897058971589725897358974589755897658977589785897958980589815898258983589845898558986589875898858989589905899158992589935899458995589965899758998589995900059001590025900359004590055900659007590085900959010590115901259013590145901559016590175901859019590205902159022590235902459025590265902759028590295903059031590325903359034590355903659037590385903959040590415904259043590445904559046590475904859049590505905159052590535905459055590565905759058590595906059061590625906359064590655906659067590685906959070590715907259073590745907559076590775907859079590805908159082590835908459085590865908759088590895909059091590925909359094590955909659097590985909959100591015910259103591045910559106591075910859109591105911159112591135911459115591165911759118591195912059121591225912359124591255912659127591285912959130591315913259133591345913559136591375913859139591405914159142591435914459145591465914759148591495915059151591525915359154591555915659157591585915959160591615916259163591645916559166591675916859169591705917159172591735917459175591765917759178591795918059181591825918359184591855918659187591885918959190591915919259193591945919559196591975919859199592005920159202592035920459205592065920759208592095921059211592125921359214592155921659217592185921959220592215922259223592245922559226592275922859229592305923159232592335923459235592365923759238592395924059241592425924359244592455924659247592485924959250592515925259253592545925559256592575925859259592605926159262592635926459265592665926759268592695927059271592725927359274592755927659277592785927959280592815928259283592845928559286592875928859289592905929159292592935929459295592965929759298592995930059301593025930359304593055930659307593085930959310593115931259313593145931559316593175931859319593205932159322593235932459325593265932759328593295933059331593325933359334593355933659337593385933959340593415934259343593445934559346593475934859349593505935159352593535935459355593565935759358593595936059361593625936359364593655936659367593685936959370593715937259373593745937559376593775937859379593805938159382593835938459385593865938759388593895939059391593925939359394593955939659397593985939959400594015940259403594045940559406594075940859409594105941159412594135941459415594165941759418594195942059421594225942359424594255942659427594285942959430594315943259433594345943559436594375943859439594405944159442594435944459445594465944759448594495945059451594525945359454594555945659457594585945959460594615946259463594645946559466594675946859469594705947159472594735947459475594765947759478594795948059481594825948359484594855948659487594885948959490594915949259493594945949559496594975949859499595005950159502595035950459505595065950759508595095951059511595125951359514595155951659517595185951959520595215952259523595245952559526595275952859529595305953159532595335953459535595365953759538595395954059541595425954359544595455954659547595485954959550595515955259553595545955559556595575955859559595605956159562595635956459565595665956759568595695957059571595725957359574595755957659577595785957959580595815958259583595845958559586595875958859589595905959159592595935959459595595965959759598595995960059601596025960359604596055960659607596085960959610596115961259613596145961559616596175961859619596205962159622596235962459625596265962759628596295963059631596325963359634596355963659637596385963959640596415964259643596445964559646596475964859649596505965159652596535965459655596565965759658596595966059661596625966359664596655966659667596685966959670596715967259673596745967559676596775967859679596805968159682596835968459685596865968759688596895969059691596925969359694596955969659697596985969959700597015970259703597045970559706597075970859709597105971159712597135971459715597165971759718597195972059721597225972359724597255972659727597285972959730597315973259733597345973559736597375973859739597405974159742597435974459745597465974759748597495975059751597525975359754597555975659757597585975959760597615976259763597645976559766597675976859769597705977159772597735977459775597765977759778597795978059781597825978359784597855978659787597885978959790597915979259793597945979559796597975979859799598005980159802598035980459805598065980759808598095981059811598125981359814598155981659817598185981959820598215982259823598245982559826598275982859829598305983159832598335983459835598365983759838598395984059841598425984359844598455984659847598485984959850598515985259853598545985559856598575985859859598605986159862598635986459865598665986759868598695987059871598725987359874598755987659877598785987959880598815988259883598845988559886598875988859889598905989159892598935989459895598965989759898598995990059901599025990359904599055990659907599085990959910599115991259913599145991559916599175991859919599205992159922599235992459925599265992759928599295993059931599325993359934599355993659937599385993959940599415994259943599445994559946599475994859949599505995159952599535995459955599565995759958599595996059961599625996359964599655996659967599685996959970599715997259973599745997559976599775997859979599805998159982599835998459985599865998759988599895999059991599925999359994599955999659997599985999960000600016000260003600046000560006600076000860009600106001160012600136001460015600166001760018600196002060021600226002360024600256002660027600286002960030600316003260033600346003560036600376003860039600406004160042600436004460045600466004760048600496005060051600526005360054600556005660057600586005960060600616006260063600646006560066600676006860069600706007160072600736007460075600766007760078600796008060081600826008360084600856008660087600886008960090600916009260093600946009560096600976009860099601006010160102601036010460105601066010760108601096011060111601126011360114601156011660117601186011960120601216012260123601246012560126601276012860129601306013160132601336013460135601366013760138601396014060141601426014360144601456014660147601486014960150601516015260153601546015560156601576015860159601606016160162601636016460165601666016760168601696017060171601726017360174601756017660177601786017960180601816018260183601846018560186601876018860189601906019160192601936019460195601966019760198601996020060201602026020360204602056020660207602086020960210602116021260213602146021560216602176021860219602206022160222602236022460225602266022760228602296023060231602326023360234602356023660237602386023960240602416024260243602446024560246602476024860249602506025160252602536025460255602566025760258602596026060261602626026360264602656026660267602686026960270602716027260273602746027560276602776027860279602806028160282602836028460285602866028760288602896029060291602926029360294602956029660297602986029960300603016030260303603046030560306603076030860309603106031160312603136031460315603166031760318603196032060321603226032360324603256032660327603286032960330603316033260333603346033560336603376033860339603406034160342603436034460345603466034760348603496035060351603526035360354603556035660357603586035960360603616036260363603646036560366603676036860369603706037160372603736037460375603766037760378603796038060381603826038360384603856038660387603886038960390603916039260393603946039560396603976039860399604006040160402604036040460405604066040760408604096041060411604126041360414604156041660417604186041960420604216042260423604246042560426604276042860429604306043160432604336043460435604366043760438604396044060441604426044360444604456044660447604486044960450604516045260453604546045560456604576045860459604606046160462604636046460465604666046760468604696047060471604726047360474604756047660477604786047960480604816048260483604846048560486604876048860489604906049160492604936049460495604966049760498604996050060501605026050360504605056050660507605086050960510605116051260513605146051560516605176051860519605206052160522605236052460525605266052760528605296053060531605326053360534605356053660537605386053960540605416054260543605446054560546605476054860549605506055160552605536055460555605566055760558605596056060561605626056360564605656056660567605686056960570605716057260573605746057560576605776057860579605806058160582605836058460585605866058760588605896059060591605926059360594605956059660597605986059960600606016060260603606046060560606606076060860609606106061160612606136061460615606166061760618606196062060621606226062360624606256062660627606286062960630606316063260633606346063560636606376063860639606406064160642606436064460645606466064760648606496065060651606526065360654606556065660657606586065960660606616066260663606646066560666606676066860669606706067160672606736067460675606766067760678606796068060681606826068360684606856068660687606886068960690606916069260693606946069560696606976069860699607006070160702607036070460705607066070760708607096071060711607126071360714607156071660717607186071960720607216072260723607246072560726607276072860729607306073160732607336073460735607366073760738607396074060741607426074360744607456074660747607486074960750607516075260753607546075560756607576075860759607606076160762607636076460765607666076760768607696077060771607726077360774607756077660777607786077960780607816078260783607846078560786607876078860789607906079160792607936079460795607966079760798607996080060801608026080360804608056080660807608086080960810608116081260813608146081560816608176081860819608206082160822608236082460825608266082760828608296083060831608326083360834608356083660837608386083960840608416084260843608446084560846608476084860849608506085160852608536085460855608566085760858608596086060861608626086360864608656086660867608686086960870608716087260873608746087560876608776087860879608806088160882608836088460885608866088760888608896089060891608926089360894608956089660897608986089960900609016090260903609046090560906609076090860909609106091160912609136091460915609166091760918609196092060921609226092360924609256092660927609286092960930609316093260933609346093560936609376093860939609406094160942609436094460945609466094760948609496095060951609526095360954609556095660957609586095960960609616096260963609646096560966609676096860969609706097160972609736097460975609766097760978609796098060981609826098360984609856098660987609886098960990609916099260993609946099560996609976099860999610006100161002610036100461005610066100761008610096101061011610126101361014610156101661017610186101961020610216102261023610246102561026610276102861029610306103161032610336103461035610366103761038610396104061041610426104361044610456104661047610486104961050610516105261053610546105561056610576105861059610606106161062610636106461065610666106761068610696107061071610726107361074610756107661077610786107961080610816108261083610846108561086610876108861089610906109161092610936109461095610966109761098610996110061101611026110361104611056110661107611086110961110611116111261113611146111561116611176111861119611206112161122611236112461125611266112761128611296113061131611326113361134611356113661137611386113961140611416114261143611446114561146611476114861149611506115161152611536115461155611566115761158611596116061161611626116361164611656116661167611686116961170611716117261173611746117561176611776117861179611806118161182611836118461185611866118761188611896119061191611926119361194611956119661197611986119961200612016120261203612046120561206612076120861209612106121161212612136121461215612166121761218612196122061221612226122361224612256122661227612286122961230612316123261233612346123561236612376123861239612406124161242612436124461245612466124761248612496125061251612526125361254612556125661257612586125961260612616126261263612646126561266612676126861269612706127161272612736127461275612766127761278612796128061281612826128361284612856128661287612886128961290612916129261293612946129561296612976129861299613006130161302613036130461305613066130761308613096131061311613126131361314613156131661317613186131961320613216132261323613246132561326613276132861329613306133161332613336133461335613366133761338613396134061341613426134361344613456134661347613486134961350613516135261353613546135561356613576135861359613606136161362613636136461365613666136761368613696137061371613726137361374613756137661377613786137961380613816138261383613846138561386613876138861389613906139161392613936139461395613966139761398613996140061401614026140361404614056140661407614086140961410614116141261413614146141561416614176141861419614206142161422614236142461425614266142761428614296143061431614326143361434614356143661437614386143961440614416144261443614446144561446614476144861449614506145161452614536145461455614566145761458614596146061461614626146361464614656146661467614686146961470614716147261473614746147561476614776147861479614806148161482614836148461485614866148761488614896149061491614926149361494614956149661497614986149961500615016150261503615046150561506615076150861509615106151161512615136151461515615166151761518615196152061521615226152361524615256152661527615286152961530615316153261533615346153561536615376153861539615406154161542615436154461545615466154761548615496155061551615526155361554615556155661557615586155961560615616156261563615646156561566615676156861569615706157161572615736157461575615766157761578615796158061581615826158361584615856158661587615886158961590615916159261593615946159561596615976159861599616006160161602616036160461605616066160761608616096161061611616126161361614616156161661617616186161961620616216162261623616246162561626616276162861629616306163161632616336163461635616366163761638616396164061641616426164361644616456164661647616486164961650616516165261653616546165561656616576165861659616606166161662616636166461665616666166761668616696167061671616726167361674616756167661677616786167961680616816168261683616846168561686616876168861689616906169161692616936169461695616966169761698616996170061701617026170361704617056170661707617086170961710617116171261713617146171561716617176171861719617206172161722617236172461725617266172761728617296173061731617326173361734617356173661737617386173961740617416174261743617446174561746617476174861749617506175161752617536175461755617566175761758617596176061761617626176361764617656176661767617686176961770617716177261773617746177561776617776177861779617806178161782617836178461785617866178761788617896179061791617926179361794617956179661797617986179961800618016180261803618046180561806618076180861809618106181161812618136181461815618166181761818618196182061821618226182361824618256182661827618286182961830618316183261833618346183561836618376183861839618406184161842618436184461845618466184761848618496185061851618526185361854618556185661857618586185961860618616186261863618646186561866618676186861869618706187161872618736187461875618766187761878618796188061881618826188361884618856188661887618886188961890618916189261893618946189561896618976189861899619006190161902619036190461905619066190761908619096191061911619126191361914619156191661917619186191961920619216192261923619246192561926619276192861929619306193161932619336193461935619366193761938619396194061941619426194361944619456194661947619486194961950619516195261953619546195561956619576195861959619606196161962619636196461965619666196761968619696197061971619726197361974619756197661977619786197961980619816198261983619846198561986619876198861989619906199161992619936199461995619966199761998619996200062001620026200362004620056200662007620086200962010620116201262013620146201562016620176201862019620206202162022620236202462025620266202762028620296203062031620326203362034620356203662037620386203962040620416204262043620446204562046620476204862049620506205162052620536205462055620566205762058620596206062061620626206362064620656206662067620686206962070620716207262073620746207562076620776207862079620806208162082620836208462085620866208762088620896209062091620926209362094620956209662097620986209962100621016210262103621046210562106621076210862109621106211162112621136211462115621166211762118621196212062121621226212362124621256212662127621286212962130621316213262133621346213562136621376213862139621406214162142621436214462145621466214762148621496215062151621526215362154621556215662157621586215962160621616216262163621646216562166621676216862169621706217162172621736217462175621766217762178621796218062181621826218362184621856218662187621886218962190621916219262193621946219562196621976219862199622006220162202622036220462205622066220762208622096221062211622126221362214622156221662217622186221962220622216222262223622246222562226622276222862229622306223162232622336223462235622366223762238622396224062241622426224362244622456224662247622486224962250622516225262253622546225562256622576225862259622606226162262622636226462265622666226762268622696227062271622726227362274622756227662277622786227962280622816228262283622846228562286622876228862289622906229162292622936229462295622966229762298622996230062301623026230362304623056230662307623086230962310623116231262313623146231562316623176231862319623206232162322623236232462325623266232762328623296233062331623326233362334623356233662337623386233962340623416234262343623446234562346623476234862349623506235162352623536235462355623566235762358623596236062361623626236362364623656236662367623686236962370623716237262373623746237562376623776237862379623806238162382623836238462385623866238762388623896239062391623926239362394623956239662397623986239962400624016240262403624046240562406624076240862409624106241162412624136241462415624166241762418624196242062421624226242362424624256242662427624286242962430624316243262433624346243562436624376243862439624406244162442624436244462445624466244762448624496245062451624526245362454624556245662457624586245962460624616246262463624646246562466624676246862469624706247162472624736247462475624766247762478624796248062481624826248362484624856248662487624886248962490624916249262493624946249562496624976249862499625006250162502625036250462505625066250762508625096251062511625126251362514625156251662517625186251962520625216252262523625246252562526625276252862529625306253162532625336253462535625366253762538625396254062541625426254362544625456254662547625486254962550625516255262553625546255562556625576255862559625606256162562625636256462565625666256762568625696257062571625726257362574625756257662577625786257962580625816258262583625846258562586625876258862589625906259162592625936259462595625966259762598625996260062601626026260362604626056260662607626086260962610626116261262613626146261562616626176261862619626206262162622626236262462625626266262762628626296263062631626326263362634626356263662637626386263962640626416264262643626446264562646626476264862649626506265162652626536265462655626566265762658626596266062661626626266362664626656266662667626686266962670626716267262673626746267562676626776267862679626806268162682626836268462685626866268762688626896269062691626926269362694626956269662697626986269962700627016270262703627046270562706627076270862709627106271162712627136271462715627166271762718627196272062721627226272362724627256272662727627286272962730627316273262733627346273562736627376273862739627406274162742627436274462745627466274762748627496275062751627526275362754627556275662757627586275962760627616276262763627646276562766627676276862769627706277162772627736277462775627766277762778627796278062781627826278362784627856278662787627886278962790627916279262793627946279562796627976279862799628006280162802628036280462805628066280762808628096281062811628126281362814628156281662817628186281962820628216282262823628246282562826628276282862829628306283162832628336283462835628366283762838628396284062841628426284362844628456284662847628486284962850628516285262853628546285562856628576285862859628606286162862628636286462865628666286762868628696287062871628726287362874628756287662877628786287962880628816288262883628846288562886628876288862889628906289162892628936289462895628966289762898628996290062901629026290362904629056290662907629086290962910629116291262913629146291562916629176291862919629206292162922629236292462925629266292762928629296293062931629326293362934629356293662937629386293962940629416294262943629446294562946629476294862949629506295162952629536295462955629566295762958629596296062961629626296362964629656296662967629686296962970629716297262973629746297562976629776297862979629806298162982629836298462985629866298762988629896299062991629926299362994629956299662997629986299963000630016300263003630046300563006630076300863009630106301163012630136301463015630166301763018630196302063021630226302363024630256302663027630286302963030630316303263033630346303563036630376303863039630406304163042630436304463045630466304763048630496305063051630526305363054630556305663057630586305963060630616306263063630646306563066630676306863069630706307163072630736307463075630766307763078630796308063081630826308363084630856308663087630886308963090630916309263093630946309563096630976309863099631006310163102631036310463105631066310763108631096311063111631126311363114631156311663117631186311963120631216312263123631246312563126631276312863129631306313163132631336313463135631366313763138631396314063141631426314363144631456314663147631486314963150631516315263153631546315563156631576315863159631606316163162631636316463165631666316763168631696317063171631726317363174631756317663177631786317963180631816318263183631846318563186631876318863189631906319163192631936319463195631966319763198631996320063201632026320363204632056320663207632086320963210632116321263213632146321563216632176321863219632206322163222632236322463225632266322763228632296323063231632326323363234632356323663237632386323963240632416324263243632446324563246632476324863249632506325163252632536325463255632566325763258632596326063261632626326363264632656326663267632686326963270632716327263273632746327563276632776327863279632806328163282632836328463285632866328763288632896329063291632926329363294632956329663297632986329963300633016330263303633046330563306633076330863309633106331163312633136331463315633166331763318633196332063321633226332363324633256332663327633286332963330633316333263333633346333563336633376333863339633406334163342633436334463345633466334763348633496335063351633526335363354633556335663357633586335963360633616336263363633646336563366633676336863369633706337163372633736337463375633766337763378633796338063381633826338363384633856338663387633886338963390633916339263393633946339563396633976339863399634006340163402634036340463405634066340763408634096341063411634126341363414634156341663417634186341963420634216342263423634246342563426634276342863429634306343163432634336343463435634366343763438634396344063441634426344363444634456344663447634486344963450634516345263453634546345563456634576345863459634606346163462634636346463465634666346763468634696347063471634726347363474634756347663477634786347963480634816348263483634846348563486634876348863489634906349163492634936349463495634966349763498634996350063501635026350363504635056350663507635086350963510635116351263513635146351563516635176351863519635206352163522635236352463525635266352763528635296353063531635326353363534635356353663537635386353963540635416354263543635446354563546635476354863549635506355163552635536355463555635566355763558635596356063561635626356363564635656356663567635686356963570635716357263573635746357563576635776357863579635806358163582635836358463585635866358763588635896359063591635926359363594635956359663597635986359963600636016360263603636046360563606636076360863609636106361163612636136361463615636166361763618636196362063621636226362363624636256362663627636286362963630636316363263633636346363563636636376363863639636406364163642636436364463645636466364763648636496365063651636526365363654636556365663657636586365963660636616366263663636646366563666636676366863669636706367163672636736367463675636766367763678636796368063681636826368363684636856368663687636886368963690636916369263693636946369563696636976369863699637006370163702637036370463705637066370763708637096371063711637126371363714637156371663717637186371963720637216372263723637246372563726637276372863729637306373163732637336373463735637366373763738637396374063741637426374363744637456374663747637486374963750637516375263753637546375563756637576375863759637606376163762637636376463765637666376763768637696377063771637726377363774637756377663777637786377963780637816378263783637846378563786637876378863789637906379163792637936379463795637966379763798637996380063801638026380363804638056380663807638086380963810638116381263813638146381563816638176381863819638206382163822638236382463825638266382763828638296383063831638326383363834638356383663837638386383963840638416384263843638446384563846638476384863849638506385163852638536385463855638566385763858638596386063861638626386363864638656386663867638686386963870638716387263873638746387563876638776387863879638806388163882638836388463885638866388763888638896389063891638926389363894638956389663897638986389963900639016390263903639046390563906639076390863909639106391163912639136391463915639166391763918639196392063921639226392363924639256392663927639286392963930639316393263933639346393563936639376393863939639406394163942639436394463945639466394763948639496395063951639526395363954639556395663957639586395963960639616396263963639646396563966639676396863969639706397163972639736397463975639766397763978639796398063981639826398363984639856398663987639886398963990639916399263993639946399563996639976399863999640006400164002640036400464005640066400764008640096401064011640126401364014640156401664017640186401964020640216402264023640246402564026640276402864029640306403164032640336403464035640366403764038640396404064041640426404364044640456404664047640486404964050640516405264053640546405564056640576405864059640606406164062640636406464065640666406764068640696407064071640726407364074640756407664077640786407964080640816408264083640846408564086640876408864089640906409164092640936409464095640966409764098640996410064101641026410364104641056410664107641086410964110641116411264113641146411564116641176411864119641206412164122641236412464125641266412764128641296413064131641326413364134641356413664137641386413964140641416414264143641446414564146641476414864149641506415164152641536415464155641566415764158641596416064161641626416364164641656416664167641686416964170641716417264173641746417564176641776417864179641806418164182641836418464185641866418764188641896419064191641926419364194641956419664197641986419964200642016420264203642046420564206642076420864209642106421164212642136421464215642166421764218642196422064221642226422364224642256422664227642286422964230642316423264233642346423564236642376423864239642406424164242642436424464245642466424764248642496425064251642526425364254642556425664257642586425964260642616426264263642646426564266642676426864269642706427164272642736427464275642766427764278642796428064281642826428364284642856428664287642886428964290642916429264293642946429564296642976429864299643006430164302643036430464305643066430764308643096431064311643126431364314643156431664317643186431964320643216432264323643246432564326643276432864329643306433164332643336433464335643366433764338643396434064341643426434364344643456434664347643486434964350643516435264353643546435564356643576435864359643606436164362643636436464365643666436764368643696437064371643726437364374643756437664377643786437964380643816438264383643846438564386643876438864389643906439164392643936439464395643966439764398643996440064401644026440364404644056440664407644086440964410644116441264413644146441564416644176441864419644206442164422644236442464425644266442764428644296443064431644326443364434644356443664437644386443964440644416444264443644446444564446644476444864449644506445164452644536445464455644566445764458644596446064461644626446364464644656446664467644686446964470644716447264473644746447564476644776447864479644806448164482644836448464485644866448764488644896449064491644926449364494644956449664497644986449964500645016450264503645046450564506645076450864509645106451164512645136451464515645166451764518645196452064521645226452364524645256452664527645286452964530645316453264533645346453564536645376453864539645406454164542645436454464545645466454764548645496455064551645526455364554645556455664557645586455964560645616456264563645646456564566645676456864569645706457164572645736457464575645766457764578645796458064581645826458364584645856458664587645886458964590645916459264593645946459564596645976459864599646006460164602646036460464605646066460764608646096461064611646126461364614646156461664617646186461964620646216462264623646246462564626646276462864629646306463164632646336463464635646366463764638646396464064641646426464364644646456464664647646486464964650646516465264653646546465564656646576465864659646606466164662646636466464665646666466764668646696467064671646726467364674646756467664677646786467964680646816468264683646846468564686646876468864689646906469164692646936469464695646966469764698646996470064701647026470364704647056470664707647086470964710647116471264713647146471564716647176471864719647206472164722647236472464725647266472764728647296473064731647326473364734647356473664737647386473964740647416474264743647446474564746647476474864749647506475164752647536475464755647566475764758647596476064761647626476364764647656476664767647686476964770647716477264773647746477564776647776477864779647806478164782647836478464785647866478764788647896479064791647926479364794647956479664797647986479964800648016480264803648046480564806648076480864809648106481164812648136481464815648166481764818648196482064821648226482364824648256482664827648286482964830648316483264833648346483564836648376483864839648406484164842648436484464845648466484764848648496485064851648526485364854648556485664857648586485964860648616486264863648646486564866648676486864869648706487164872648736487464875648766487764878648796488064881648826488364884648856488664887648886488964890648916489264893648946489564896648976489864899649006490164902649036490464905649066490764908649096491064911649126491364914649156491664917649186491964920649216492264923649246492564926649276492864929649306493164932649336493464935649366493764938649396494064941649426494364944649456494664947649486494964950649516495264953649546495564956649576495864959649606496164962649636496464965649666496764968649696497064971649726497364974649756497664977649786497964980649816498264983649846498564986649876498864989649906499164992649936499464995649966499764998649996500065001650026500365004650056500665007650086500965010650116501265013650146501565016650176501865019650206502165022650236502465025650266502765028650296503065031650326503365034650356503665037650386503965040650416504265043650446504565046650476504865049650506505165052650536505465055650566505765058650596506065061650626506365064650656506665067650686506965070650716507265073650746507565076650776507865079650806508165082650836508465085650866508765088650896509065091650926509365094650956509665097650986509965100651016510265103651046510565106651076510865109651106511165112651136511465115651166511765118651196512065121651226512365124651256512665127651286512965130651316513265133651346513565136651376513865139651406514165142651436514465145651466514765148651496515065151651526515365154651556515665157651586515965160651616516265163651646516565166651676516865169651706517165172651736517465175651766517765178651796518065181651826518365184651856518665187651886518965190651916519265193651946519565196651976519865199652006520165202652036520465205652066520765208652096521065211652126521365214652156521665217652186521965220652216522265223652246522565226652276522865229652306523165232652336523465235652366523765238652396524065241652426524365244652456524665247652486524965250652516525265253652546525565256652576525865259652606526165262652636526465265652666526765268652696527065271652726527365274652756527665277652786527965280652816528265283652846528565286652876528865289652906529165292652936529465295652966529765298652996530065301653026530365304653056530665307653086530965310653116531265313653146531565316653176531865319653206532165322653236532465325653266532765328653296533065331653326533365334653356533665337653386533965340653416534265343653446534565346653476534865349653506535165352653536535465355653566535765358653596536065361653626536365364653656536665367653686536965370653716537265373653746537565376653776537865379653806538165382653836538465385653866538765388653896539065391653926539365394653956539665397653986539965400654016540265403654046540565406654076540865409654106541165412654136541465415654166541765418654196542065421654226542365424654256542665427654286542965430654316543265433654346543565436654376543865439654406544165442654436544465445654466544765448654496545065451654526545365454654556545665457654586545965460654616546265463654646546565466654676546865469654706547165472654736547465475654766547765478654796548065481654826548365484654856548665487654886548965490654916549265493654946549565496654976549865499655006550165502655036550465505655066550765508655096551065511655126551365514655156551665517655186551965520655216552265523655246552565526655276552865529655306553165532655336553465535655366553765538655396554065541655426554365544655456554665547655486554965550655516555265553655546555565556655576555865559655606556165562655636556465565655666556765568655696557065571655726557365574655756557665577655786557965580655816558265583655846558565586655876558865589655906559165592655936559465595655966559765598655996560065601656026560365604656056560665607656086560965610656116561265613656146561565616656176561865619656206562165622656236562465625656266562765628656296563065631656326563365634656356563665637656386563965640656416564265643656446564565646656476564865649656506565165652656536565465655656566565765658656596566065661656626566365664656656566665667656686566965670656716567265673656746567565676656776567865679656806568165682656836568465685656866568765688656896569065691656926569365694656956569665697656986569965700657016570265703657046570565706657076570865709657106571165712657136571465715657166571765718657196572065721657226572365724657256572665727657286572965730657316573265733657346573565736657376573865739657406574165742657436574465745657466574765748657496575065751657526575365754657556575665757657586575965760657616576265763657646576565766657676576865769657706577165772657736577465775657766577765778657796578065781657826578365784657856578665787657886578965790657916579265793657946579565796657976579865799658006580165802658036580465805658066580765808658096581065811658126581365814658156581665817658186581965820658216582265823658246582565826658276582865829658306583165832658336583465835658366583765838658396584065841658426584365844658456584665847658486584965850658516585265853658546585565856658576585865859658606586165862658636586465865658666586765868658696587065871658726587365874658756587665877658786587965880658816588265883658846588565886658876588865889658906589165892658936589465895658966589765898658996590065901659026590365904659056590665907659086590965910659116591265913659146591565916659176591865919659206592165922659236592465925659266592765928659296593065931659326593365934659356593665937659386593965940659416594265943659446594565946659476594865949659506595165952659536595465955659566595765958659596596065961659626596365964659656596665967659686596965970659716597265973659746597565976659776597865979659806598165982659836598465985659866598765988659896599065991659926599365994659956599665997659986599966000660016600266003660046600566006660076600866009660106601166012660136601466015660166601766018660196602066021660226602366024660256602666027660286602966030660316603266033660346603566036660376603866039660406604166042660436604466045660466604766048660496605066051660526605366054660556605666057660586605966060660616606266063660646606566066660676606866069660706607166072660736607466075660766607766078660796608066081660826608366084660856608666087660886608966090660916609266093660946609566096660976609866099661006610166102661036610466105661066610766108661096611066111661126611366114661156611666117661186611966120661216612266123661246612566126661276612866129661306613166132661336613466135661366613766138661396614066141661426614366144661456614666147661486614966150661516615266153661546615566156661576615866159661606616166162661636616466165661666616766168661696617066171661726617366174661756617666177661786617966180661816618266183661846618566186661876618866189661906619166192661936619466195661966619766198661996620066201662026620366204662056620666207662086620966210662116621266213662146621566216662176621866219662206622166222662236622466225662266622766228662296623066231662326623366234662356623666237662386623966240662416624266243662446624566246662476624866249662506625166252662536625466255662566625766258662596626066261662626626366264662656626666267662686626966270662716627266273662746627566276662776627866279662806628166282662836628466285662866628766288662896629066291662926629366294662956629666297662986629966300663016630266303663046630566306663076630866309663106631166312663136631466315663166631766318663196632066321663226632366324663256632666327663286632966330663316633266333663346633566336663376633866339663406634166342663436634466345663466634766348663496635066351663526635366354663556635666357663586635966360663616636266363663646636566366663676636866369663706637166372663736637466375663766637766378663796638066381663826638366384663856638666387663886638966390663916639266393663946639566396663976639866399664006640166402664036640466405664066640766408664096641066411664126641366414664156641666417664186641966420664216642266423664246642566426664276642866429664306643166432664336643466435664366643766438664396644066441664426644366444664456644666447664486644966450664516645266453664546645566456664576645866459664606646166462664636646466465664666646766468664696647066471664726647366474664756647666477664786647966480664816648266483664846648566486664876648866489664906649166492664936649466495664966649766498664996650066501665026650366504665056650666507665086650966510665116651266513665146651566516665176651866519665206652166522665236652466525665266652766528665296653066531665326653366534665356653666537665386653966540665416654266543665446654566546665476654866549665506655166552665536655466555665566655766558665596656066561665626656366564665656656666567665686656966570665716657266573665746657566576665776657866579665806658166582665836658466585665866658766588665896659066591665926659366594665956659666597665986659966600666016660266603666046660566606666076660866609666106661166612666136661466615666166661766618666196662066621666226662366624666256662666627666286662966630666316663266633666346663566636666376663866639666406664166642666436664466645666466664766648666496665066651666526665366654666556665666657666586665966660666616666266663666646666566666666676666866669666706667166672666736667466675666766667766678666796668066681666826668366684666856668666687666886668966690666916669266693666946669566696666976669866699667006670166702667036670466705667066670766708667096671066711667126671366714667156671666717667186671966720667216672266723667246672566726667276672866729667306673166732667336673466735667366673766738667396674066741667426674366744667456674666747667486674966750667516675266753667546675566756667576675866759667606676166762667636676466765667666676766768667696677066771667726677366774667756677666777667786677966780667816678266783667846678566786667876678866789667906679166792667936679466795667966679766798667996680066801668026680366804668056680666807668086680966810668116681266813668146681566816668176681866819668206682166822668236682466825668266682766828668296683066831668326683366834668356683666837668386683966840668416684266843668446684566846668476684866849668506685166852668536685466855668566685766858668596686066861668626686366864668656686666867668686686966870668716687266873668746687566876668776687866879668806688166882668836688466885668866688766888668896689066891668926689366894668956689666897668986689966900669016690266903669046690566906669076690866909669106691166912669136691466915669166691766918669196692066921669226692366924669256692666927669286692966930669316693266933669346693566936669376693866939669406694166942669436694466945669466694766948669496695066951669526695366954669556695666957669586695966960669616696266963669646696566966669676696866969669706697166972669736697466975669766697766978669796698066981669826698366984669856698666987669886698966990669916699266993669946699566996669976699866999670006700167002670036700467005670066700767008670096701067011670126701367014670156701667017670186701967020670216702267023670246702567026670276702867029670306703167032670336703467035670366703767038670396704067041670426704367044670456704667047670486704967050670516705267053670546705567056670576705867059670606706167062670636706467065670666706767068670696707067071670726707367074670756707667077670786707967080670816708267083670846708567086670876708867089670906709167092670936709467095670966709767098670996710067101671026710367104671056710667107671086710967110671116711267113671146711567116671176711867119671206712167122671236712467125671266712767128671296713067131671326713367134671356713667137671386713967140671416714267143671446714567146671476714867149671506715167152671536715467155671566715767158671596716067161671626716367164671656716667167671686716967170671716717267173671746717567176671776717867179671806718167182671836718467185671866718767188671896719067191671926719367194671956719667197671986719967200672016720267203672046720567206672076720867209672106721167212672136721467215672166721767218672196722067221672226722367224672256722667227672286722967230672316723267233672346723567236672376723867239672406724167242672436724467245672466724767248672496725067251672526725367254672556725667257672586725967260672616726267263672646726567266672676726867269672706727167272672736727467275672766727767278672796728067281672826728367284672856728667287672886728967290672916729267293672946729567296672976729867299673006730167302673036730467305673066730767308673096731067311673126731367314673156731667317673186731967320673216732267323673246732567326673276732867329673306733167332673336733467335673366733767338673396734067341673426734367344673456734667347673486734967350673516735267353673546735567356673576735867359673606736167362673636736467365673666736767368673696737067371673726737367374673756737667377673786737967380673816738267383673846738567386673876738867389673906739167392673936739467395673966739767398673996740067401674026740367404674056740667407674086740967410674116741267413674146741567416674176741867419674206742167422674236742467425674266742767428674296743067431674326743367434674356743667437674386743967440674416744267443674446744567446674476744867449674506745167452674536745467455674566745767458674596746067461674626746367464674656746667467674686746967470674716747267473674746747567476674776747867479674806748167482674836748467485674866748767488674896749067491674926749367494674956749667497674986749967500675016750267503675046750567506675076750867509675106751167512675136751467515675166751767518675196752067521675226752367524675256752667527675286752967530675316753267533675346753567536675376753867539675406754167542675436754467545675466754767548675496755067551675526755367554675556755667557675586755967560675616756267563675646756567566675676756867569675706757167572675736757467575675766757767578675796758067581675826758367584675856758667587675886758967590675916759267593675946759567596675976759867599676006760167602676036760467605676066760767608676096761067611676126761367614676156761667617676186761967620676216762267623676246762567626676276762867629676306763167632676336763467635676366763767638676396764067641676426764367644676456764667647676486764967650676516765267653676546765567656676576765867659676606766167662676636766467665676666766767668676696767067671676726767367674676756767667677676786767967680676816768267683676846768567686676876768867689676906769167692676936769467695676966769767698676996770067701677026770367704677056770667707677086770967710677116771267713677146771567716677176771867719677206772167722677236772467725677266772767728677296773067731677326773367734677356773667737677386773967740677416774267743677446774567746677476774867749677506775167752677536775467755677566775767758677596776067761677626776367764677656776667767677686776967770677716777267773677746777567776677776777867779677806778167782677836778467785677866778767788677896779067791677926779367794677956779667797677986779967800678016780267803678046780567806678076780867809678106781167812678136781467815678166781767818678196782067821678226782367824678256782667827678286782967830678316783267833678346783567836678376783867839678406784167842678436784467845678466784767848678496785067851678526785367854678556785667857678586785967860678616786267863678646786567866678676786867869678706787167872678736787467875678766787767878678796788067881678826788367884678856788667887678886788967890678916789267893678946789567896678976789867899679006790167902679036790467905679066790767908679096791067911679126791367914679156791667917679186791967920679216792267923679246792567926679276792867929679306793167932679336793467935679366793767938679396794067941679426794367944679456794667947679486794967950679516795267953679546795567956679576795867959679606796167962679636796467965679666796767968679696797067971679726797367974679756797667977679786797967980679816798267983679846798567986679876798867989679906799167992679936799467995679966799767998679996800068001680026800368004680056800668007680086800968010680116801268013680146801568016680176801868019680206802168022680236802468025680266802768028680296803068031680326803368034680356803668037680386803968040680416804268043680446804568046680476804868049680506805168052680536805468055680566805768058680596806068061680626806368064680656806668067680686806968070680716807268073680746807568076680776807868079680806808168082680836808468085680866808768088680896809068091680926809368094680956809668097680986809968100681016810268103681046810568106681076810868109681106811168112681136811468115681166811768118681196812068121681226812368124681256812668127681286812968130681316813268133681346813568136681376813868139681406814168142681436814468145681466814768148681496815068151681526815368154681556815668157681586815968160681616816268163681646816568166681676816868169681706817168172681736817468175681766817768178681796818068181681826818368184681856818668187681886818968190681916819268193681946819568196681976819868199682006820168202682036820468205682066820768208682096821068211682126821368214682156821668217682186821968220682216822268223682246822568226682276822868229682306823168232682336823468235682366823768238682396824068241682426824368244682456824668247682486824968250682516825268253682546825568256682576825868259682606826168262682636826468265682666826768268682696827068271682726827368274682756827668277682786827968280682816828268283682846828568286682876828868289682906829168292682936829468295682966829768298682996830068301683026830368304683056830668307683086830968310683116831268313683146831568316683176831868319683206832168322683236832468325683266832768328683296833068331683326833368334683356833668337683386833968340683416834268343683446834568346683476834868349683506835168352683536835468355683566835768358683596836068361683626836368364683656836668367683686836968370683716837268373683746837568376683776837868379683806838168382683836838468385683866838768388683896839068391683926839368394683956839668397683986839968400684016840268403684046840568406684076840868409684106841168412684136841468415684166841768418684196842068421684226842368424684256842668427684286842968430684316843268433684346843568436684376843868439684406844168442684436844468445684466844768448684496845068451684526845368454684556845668457684586845968460684616846268463684646846568466684676846868469684706847168472684736847468475684766847768478684796848068481684826848368484684856848668487684886848968490684916849268493684946849568496684976849868499685006850168502685036850468505685066850768508685096851068511685126851368514685156851668517685186851968520685216852268523685246852568526685276852868529685306853168532685336853468535685366853768538685396854068541685426854368544685456854668547685486854968550685516855268553685546855568556685576855868559685606856168562685636856468565685666856768568685696857068571685726857368574685756857668577685786857968580685816858268583685846858568586685876858868589685906859168592685936859468595685966859768598685996860068601686026860368604686056860668607686086860968610686116861268613686146861568616686176861868619686206862168622686236862468625686266862768628686296863068631686326863368634686356863668637686386863968640686416864268643686446864568646686476864868649686506865168652686536865468655686566865768658686596866068661686626866368664686656866668667686686866968670686716867268673686746867568676686776867868679686806868168682686836868468685686866868768688686896869068691686926869368694686956869668697686986869968700687016870268703687046870568706687076870868709687106871168712687136871468715687166871768718687196872068721687226872368724687256872668727687286872968730687316873268733687346873568736687376873868739687406874168742687436874468745687466874768748687496875068751687526875368754687556875668757687586875968760687616876268763687646876568766687676876868769687706877168772687736877468775687766877768778687796878068781687826878368784687856878668787687886878968790687916879268793687946879568796687976879868799688006880168802688036880468805688066880768808688096881068811688126881368814688156881668817688186881968820688216882268823688246882568826688276882868829688306883168832688336883468835688366883768838688396884068841688426884368844688456884668847688486884968850688516885268853688546885568856688576885868859688606886168862688636886468865688666886768868688696887068871688726887368874688756887668877688786887968880688816888268883688846888568886688876888868889688906889168892688936889468895688966889768898688996890068901689026890368904689056890668907689086890968910689116891268913689146891568916689176891868919689206892168922689236892468925689266892768928689296893068931689326893368934689356893668937689386893968940689416894268943689446894568946689476894868949689506895168952689536895468955689566895768958689596896068961689626896368964689656896668967689686896968970689716897268973689746897568976689776897868979689806898168982689836898468985689866898768988689896899068991689926899368994689956899668997689986899969000690016900269003690046900569006690076900869009690106901169012690136901469015690166901769018690196902069021690226902369024690256902669027690286902969030690316903269033690346903569036690376903869039690406904169042690436904469045690466904769048690496905069051690526905369054690556905669057690586905969060690616906269063690646906569066690676906869069690706907169072690736907469075690766907769078690796908069081690826908369084690856908669087690886908969090690916909269093690946909569096690976909869099691006910169102691036910469105691066910769108691096911069111691126911369114691156911669117691186911969120691216912269123691246912569126691276912869129691306913169132691336913469135691366913769138691396914069141691426914369144691456914669147691486914969150691516915269153691546915569156691576915869159691606916169162691636916469165691666916769168691696917069171691726917369174691756917669177691786917969180691816918269183691846918569186691876918869189691906919169192691936919469195691966919769198691996920069201692026920369204692056920669207692086920969210692116921269213692146921569216692176921869219692206922169222692236922469225692266922769228692296923069231692326923369234692356923669237692386923969240692416924269243692446924569246692476924869249692506925169252692536925469255692566925769258692596926069261692626926369264692656926669267692686926969270692716927269273692746927569276692776927869279692806928169282692836928469285692866928769288692896929069291692926929369294692956929669297692986929969300693016930269303693046930569306693076930869309693106931169312693136931469315693166931769318693196932069321693226932369324693256932669327693286932969330693316933269333693346933569336693376933869339693406934169342693436934469345693466934769348693496935069351693526935369354693556935669357693586935969360693616936269363693646936569366693676936869369693706937169372693736937469375693766937769378693796938069381693826938369384693856938669387693886938969390693916939269393693946939569396693976939869399694006940169402694036940469405694066940769408694096941069411694126941369414694156941669417694186941969420694216942269423694246942569426694276942869429694306943169432694336943469435694366943769438694396944069441694426944369444694456944669447694486944969450694516945269453694546945569456694576945869459694606946169462694636946469465694666946769468694696947069471694726947369474694756947669477694786947969480694816948269483694846948569486694876948869489694906949169492694936949469495694966949769498694996950069501695026950369504695056950669507695086950969510695116951269513695146951569516695176951869519695206952169522695236952469525695266952769528695296953069531695326953369534695356953669537695386953969540695416954269543695446954569546695476954869549695506955169552695536955469555695566955769558695596956069561695626956369564695656956669567695686956969570695716957269573695746957569576695776957869579695806958169582695836958469585695866958769588695896959069591695926959369594695956959669597695986959969600696016960269603696046960569606696076960869609696106961169612696136961469615696166961769618696196962069621696226962369624696256962669627696286962969630696316963269633696346963569636696376963869639696406964169642696436964469645696466964769648696496965069651696526965369654696556965669657696586965969660696616966269663696646966569666696676966869669696706967169672696736967469675696766967769678696796968069681696826968369684696856968669687696886968969690696916969269693696946969569696696976969869699697006970169702697036970469705697066970769708697096971069711697126971369714697156971669717697186971969720697216972269723697246972569726697276972869729697306973169732697336973469735697366973769738697396974069741697426974369744697456974669747697486974969750697516975269753697546975569756697576975869759697606976169762697636976469765697666976769768697696977069771697726977369774697756977669777697786977969780697816978269783697846978569786697876978869789697906979169792697936979469795697966979769798697996980069801698026980369804698056980669807698086980969810698116981269813698146981569816698176981869819698206982169822698236982469825698266982769828698296983069831698326983369834698356983669837698386983969840698416984269843698446984569846698476984869849698506985169852698536985469855698566985769858698596986069861698626986369864698656986669867698686986969870698716987269873698746987569876698776987869879698806988169882698836988469885698866988769888698896989069891698926989369894698956989669897698986989969900699016990269903699046990569906699076990869909699106991169912699136991469915699166991769918699196992069921699226992369924699256992669927699286992969930699316993269933699346993569936699376993869939699406994169942699436994469945699466994769948699496995069951699526995369954699556995669957699586995969960699616996269963699646996569966699676996869969699706997169972699736997469975699766997769978699796998069981699826998369984699856998669987699886998969990699916999269993699946999569996699976999869999700007000170002700037000470005700067000770008700097001070011700127001370014700157001670017700187001970020700217002270023700247002570026700277002870029700307003170032700337003470035700367003770038700397004070041700427004370044700457004670047700487004970050700517005270053700547005570056700577005870059700607006170062700637006470065700667006770068700697007070071700727007370074700757007670077700787007970080700817008270083700847008570086700877008870089700907009170092700937009470095700967009770098700997010070101701027010370104701057010670107701087010970110701117011270113701147011570116701177011870119701207012170122701237012470125701267012770128701297013070131701327013370134701357013670137701387013970140701417014270143701447014570146701477014870149701507015170152701537015470155701567015770158701597016070161701627016370164701657016670167701687016970170701717017270173701747017570176701777017870179701807018170182701837018470185701867018770188701897019070191701927019370194701957019670197701987019970200702017020270203702047020570206702077020870209702107021170212702137021470215702167021770218702197022070221702227022370224702257022670227702287022970230702317023270233702347023570236702377023870239702407024170242702437024470245702467024770248702497025070251702527025370254702557025670257702587025970260702617026270263702647026570266702677026870269702707027170272702737027470275702767027770278702797028070281702827028370284702857028670287702887028970290702917029270293702947029570296702977029870299703007030170302703037030470305703067030770308703097031070311703127031370314703157031670317703187031970320703217032270323703247032570326703277032870329703307033170332703337033470335703367033770338703397034070341703427034370344703457034670347703487034970350703517035270353703547035570356703577035870359703607036170362703637036470365703667036770368703697037070371703727037370374703757037670377703787037970380703817038270383703847038570386703877038870389703907039170392703937039470395703967039770398703997040070401704027040370404704057040670407704087040970410704117041270413704147041570416704177041870419704207042170422704237042470425704267042770428704297043070431704327043370434704357043670437704387043970440704417044270443704447044570446704477044870449704507045170452704537045470455704567045770458704597046070461704627046370464704657046670467704687046970470704717047270473704747047570476704777047870479704807048170482704837048470485704867048770488704897049070491704927049370494704957049670497704987049970500705017050270503705047050570506705077050870509705107051170512705137051470515705167051770518705197052070521705227052370524705257052670527705287052970530705317053270533705347053570536705377053870539705407054170542705437054470545705467054770548705497055070551705527055370554705557055670557705587055970560705617056270563705647056570566705677056870569705707057170572705737057470575705767057770578705797058070581705827058370584705857058670587705887058970590705917059270593705947059570596705977059870599706007060170602706037060470605706067060770608706097061070611706127061370614706157061670617706187061970620706217062270623706247062570626706277062870629706307063170632706337063470635706367063770638706397064070641706427064370644706457064670647706487064970650706517065270653706547065570656706577065870659706607066170662706637066470665706667066770668706697067070671706727067370674706757067670677706787067970680706817068270683706847068570686706877068870689706907069170692706937069470695706967069770698706997070070701707027070370704707057070670707707087070970710707117071270713707147071570716707177071870719707207072170722707237072470725707267072770728707297073070731707327073370734707357073670737707387073970740707417074270743707447074570746707477074870749707507075170752707537075470755707567075770758707597076070761707627076370764707657076670767707687076970770707717077270773707747077570776707777077870779707807078170782707837078470785707867078770788707897079070791707927079370794707957079670797707987079970800708017080270803708047080570806708077080870809708107081170812708137081470815708167081770818708197082070821708227082370824708257082670827708287082970830708317083270833708347083570836708377083870839708407084170842708437084470845708467084770848708497085070851708527085370854708557085670857708587085970860708617086270863708647086570866708677086870869708707087170872708737087470875708767087770878708797088070881708827088370884708857088670887708887088970890708917089270893708947089570896708977089870899709007090170902709037090470905709067090770908709097091070911709127091370914709157091670917709187091970920709217092270923709247092570926709277092870929709307093170932709337093470935709367093770938709397094070941709427094370944709457094670947709487094970950709517095270953709547095570956709577095870959709607096170962709637096470965709667096770968709697097070971709727097370974709757097670977709787097970980709817098270983709847098570986709877098870989709907099170992709937099470995709967099770998709997100071001710027100371004710057100671007710087100971010710117101271013710147101571016710177101871019710207102171022710237102471025710267102771028710297103071031710327103371034710357103671037710387103971040710417104271043710447104571046710477104871049710507105171052710537105471055710567105771058710597106071061710627106371064710657106671067710687106971070710717107271073710747107571076710777107871079710807108171082710837108471085710867108771088710897109071091710927109371094710957109671097710987109971100711017110271103711047110571106711077110871109711107111171112711137111471115711167111771118711197112071121711227112371124711257112671127711287112971130711317113271133711347113571136711377113871139711407114171142711437114471145711467114771148711497115071151711527115371154711557115671157711587115971160711617116271163711647116571166711677116871169711707117171172711737117471175711767117771178711797118071181711827118371184711857118671187711887118971190711917119271193711947119571196711977119871199712007120171202712037120471205712067120771208712097121071211712127121371214712157121671217712187121971220712217122271223712247122571226712277122871229712307123171232712337123471235712367123771238712397124071241712427124371244712457124671247712487124971250712517125271253712547125571256712577125871259712607126171262712637126471265712667126771268712697127071271712727127371274712757127671277712787127971280712817128271283712847128571286712877128871289712907129171292712937129471295712967129771298712997130071301713027130371304713057130671307713087130971310713117131271313713147131571316713177131871319713207132171322713237132471325713267132771328713297133071331713327133371334713357133671337713387133971340713417134271343713447134571346713477134871349713507135171352713537135471355713567135771358713597136071361713627136371364713657136671367713687136971370713717137271373713747137571376713777137871379713807138171382713837138471385713867138771388713897139071391713927139371394713957139671397713987139971400714017140271403714047140571406714077140871409714107141171412714137141471415714167141771418714197142071421714227142371424714257142671427714287142971430714317143271433714347143571436714377143871439714407144171442714437144471445714467144771448714497145071451714527145371454714557145671457714587145971460714617146271463714647146571466714677146871469714707147171472714737147471475714767147771478714797148071481714827148371484714857148671487714887148971490714917149271493714947149571496714977149871499715007150171502715037150471505715067150771508715097151071511715127151371514715157151671517715187151971520715217152271523715247152571526715277152871529715307153171532715337153471535715367153771538715397154071541715427154371544715457154671547715487154971550715517155271553715547155571556715577155871559715607156171562715637156471565715667156771568715697157071571715727157371574715757157671577715787157971580715817158271583715847158571586715877158871589715907159171592715937159471595715967159771598715997160071601716027160371604716057160671607716087160971610716117161271613716147161571616716177161871619716207162171622716237162471625716267162771628716297163071631716327163371634716357163671637716387163971640716417164271643716447164571646716477164871649716507165171652716537165471655716567165771658716597166071661716627166371664716657166671667716687166971670716717167271673716747167571676716777167871679716807168171682716837168471685716867168771688716897169071691716927169371694716957169671697716987169971700717017170271703717047170571706717077170871709717107171171712717137171471715717167171771718717197172071721717227172371724717257172671727717287172971730717317173271733717347173571736717377173871739717407174171742717437174471745717467174771748717497175071751717527175371754717557175671757717587175971760717617176271763717647176571766717677176871769717707177171772717737177471775717767177771778717797178071781717827178371784717857178671787717887178971790717917179271793717947179571796717977179871799718007180171802718037180471805718067180771808718097181071811718127181371814718157181671817718187181971820718217182271823718247182571826718277182871829718307183171832718337183471835718367183771838718397184071841718427184371844718457184671847718487184971850718517185271853718547185571856718577185871859718607186171862718637186471865718667186771868718697187071871718727187371874718757187671877718787187971880718817188271883718847188571886718877188871889718907189171892718937189471895718967189771898718997190071901719027190371904719057190671907719087190971910719117191271913719147191571916719177191871919719207192171922719237192471925719267192771928719297193071931719327193371934719357193671937719387193971940719417194271943719447194571946719477194871949719507195171952719537195471955719567195771958719597196071961719627196371964719657196671967719687196971970719717197271973719747197571976719777197871979719807198171982719837198471985719867198771988719897199071991719927199371994719957199671997719987199972000720017200272003720047200572006720077200872009720107201172012720137201472015720167201772018720197202072021720227202372024720257202672027720287202972030720317203272033720347203572036720377203872039720407204172042720437204472045720467204772048720497205072051720527205372054720557205672057720587205972060720617206272063720647206572066720677206872069720707207172072720737207472075720767207772078720797208072081720827208372084720857208672087720887208972090720917209272093720947209572096720977209872099721007210172102721037210472105721067210772108721097211072111721127211372114721157211672117721187211972120721217212272123721247212572126721277212872129721307213172132721337213472135721367213772138721397214072141721427214372144721457214672147721487214972150721517215272153721547215572156721577215872159721607216172162721637216472165721667216772168721697217072171721727217372174721757217672177721787217972180721817218272183721847218572186721877218872189721907219172192721937219472195721967219772198721997220072201722027220372204722057220672207722087220972210722117221272213722147221572216722177221872219722207222172222722237222472225722267222772228722297223072231722327223372234722357223672237722387223972240722417224272243722447224572246722477224872249722507225172252722537225472255722567225772258722597226072261722627226372264722657226672267722687226972270722717227272273722747227572276722777227872279722807228172282722837228472285722867228772288722897229072291722927229372294722957229672297722987229972300723017230272303723047230572306723077230872309723107231172312723137231472315723167231772318723197232072321723227232372324723257232672327723287232972330723317233272333723347233572336723377233872339723407234172342723437234472345723467234772348723497235072351723527235372354723557235672357723587235972360723617236272363723647236572366723677236872369723707237172372723737237472375723767237772378723797238072381723827238372384723857238672387723887238972390723917239272393723947239572396723977239872399724007240172402724037240472405724067240772408724097241072411724127241372414724157241672417724187241972420724217242272423724247242572426724277242872429724307243172432724337243472435724367243772438724397244072441724427244372444724457244672447724487244972450724517245272453724547245572456724577245872459724607246172462724637246472465724667246772468724697247072471724727247372474724757247672477724787247972480724817248272483724847248572486724877248872489724907249172492724937249472495724967249772498724997250072501725027250372504725057250672507725087250972510725117251272513725147251572516725177251872519725207252172522725237252472525725267252772528725297253072531725327253372534725357253672537725387253972540725417254272543725447254572546725477254872549725507255172552725537255472555725567255772558725597256072561725627256372564725657256672567725687256972570725717257272573725747257572576725777257872579725807258172582725837258472585725867258772588725897259072591725927259372594725957259672597725987259972600726017260272603726047260572606726077260872609726107261172612726137261472615726167261772618726197262072621726227262372624726257262672627726287262972630726317263272633726347263572636726377263872639726407264172642726437264472645726467264772648726497265072651726527265372654726557265672657726587265972660726617266272663726647266572666726677266872669726707267172672726737267472675726767267772678726797268072681726827268372684726857268672687726887268972690726917269272693726947269572696726977269872699727007270172702727037270472705727067270772708727097271072711727127271372714727157271672717727187271972720727217272272723727247272572726727277272872729727307273172732727337273472735727367273772738727397274072741727427274372744727457274672747727487274972750727517275272753727547275572756727577275872759727607276172762727637276472765727667276772768727697277072771727727277372774727757277672777727787277972780727817278272783727847278572786727877278872789727907279172792727937279472795727967279772798727997280072801728027280372804728057280672807728087280972810728117281272813728147281572816728177281872819728207282172822728237282472825728267282772828728297283072831728327283372834728357283672837728387283972840728417284272843728447284572846728477284872849728507285172852728537285472855728567285772858728597286072861728627286372864728657286672867728687286972870728717287272873728747287572876728777287872879728807288172882728837288472885728867288772888728897289072891728927289372894728957289672897728987289972900729017290272903729047290572906729077290872909729107291172912729137291472915729167291772918729197292072921729227292372924729257292672927729287292972930729317293272933729347293572936729377293872939729407294172942729437294472945729467294772948729497295072951729527295372954729557295672957729587295972960729617296272963729647296572966729677296872969729707297172972729737297472975729767297772978729797298072981729827298372984729857298672987729887298972990729917299272993729947299572996729977299872999730007300173002730037300473005730067300773008730097301073011730127301373014730157301673017730187301973020730217302273023730247302573026730277302873029730307303173032730337303473035730367303773038730397304073041730427304373044730457304673047730487304973050730517305273053730547305573056730577305873059730607306173062730637306473065730667306773068730697307073071730727307373074730757307673077730787307973080730817308273083730847308573086730877308873089730907309173092730937309473095730967309773098730997310073101731027310373104731057310673107731087310973110731117311273113731147311573116731177311873119731207312173122731237312473125731267312773128731297313073131731327313373134731357313673137731387313973140731417314273143731447314573146731477314873149731507315173152731537315473155731567315773158731597316073161731627316373164731657316673167731687316973170731717317273173731747317573176731777317873179731807318173182731837318473185731867318773188731897319073191731927319373194731957319673197731987319973200732017320273203732047320573206732077320873209732107321173212732137321473215732167321773218732197322073221732227322373224732257322673227732287322973230732317323273233732347323573236732377323873239732407324173242732437324473245732467324773248732497325073251732527325373254732557325673257732587325973260732617326273263732647326573266732677326873269732707327173272732737327473275732767327773278732797328073281732827328373284732857328673287732887328973290732917329273293732947329573296732977329873299733007330173302733037330473305733067330773308733097331073311733127331373314733157331673317733187331973320733217332273323733247332573326733277332873329733307333173332733337333473335733367333773338733397334073341733427334373344733457334673347733487334973350733517335273353733547335573356733577335873359733607336173362733637336473365733667336773368733697337073371733727337373374733757337673377733787337973380733817338273383733847338573386733877338873389733907339173392733937339473395733967339773398733997340073401734027340373404734057340673407734087340973410734117341273413734147341573416734177341873419734207342173422734237342473425734267342773428734297343073431734327343373434734357343673437734387343973440734417344273443734447344573446734477344873449734507345173452734537345473455734567345773458734597346073461734627346373464734657346673467734687346973470734717347273473734747347573476734777347873479734807348173482734837348473485734867348773488734897349073491734927349373494734957349673497734987349973500735017350273503735047350573506735077350873509735107351173512735137351473515735167351773518735197352073521735227352373524735257352673527735287352973530735317353273533735347353573536735377353873539735407354173542735437354473545735467354773548735497355073551735527355373554735557355673557735587355973560735617356273563735647356573566735677356873569735707357173572735737357473575735767357773578735797358073581735827358373584735857358673587735887358973590735917359273593735947359573596735977359873599736007360173602736037360473605736067360773608736097361073611736127361373614736157361673617736187361973620736217362273623736247362573626736277362873629736307363173632736337363473635736367363773638736397364073641736427364373644736457364673647736487364973650736517365273653736547365573656736577365873659736607366173662736637366473665736667366773668736697367073671736727367373674736757367673677736787367973680736817368273683736847368573686736877368873689736907369173692736937369473695736967369773698736997370073701737027370373704737057370673707737087370973710737117371273713737147371573716737177371873719737207372173722737237372473725737267372773728737297373073731737327373373734737357373673737737387373973740737417374273743737447374573746737477374873749737507375173752737537375473755737567375773758737597376073761737627376373764737657376673767737687376973770737717377273773737747377573776737777377873779737807378173782737837378473785737867378773788737897379073791737927379373794737957379673797737987379973800738017380273803738047380573806738077380873809738107381173812738137381473815738167381773818738197382073821738227382373824738257382673827738287382973830738317383273833738347383573836738377383873839738407384173842738437384473845738467384773848738497385073851738527385373854738557385673857738587385973860738617386273863738647386573866738677386873869738707387173872738737387473875738767387773878738797388073881738827388373884738857388673887738887388973890738917389273893738947389573896738977389873899739007390173902739037390473905739067390773908739097391073911739127391373914739157391673917739187391973920739217392273923739247392573926739277392873929739307393173932739337393473935739367393773938739397394073941739427394373944739457394673947739487394973950739517395273953739547395573956739577395873959739607396173962739637396473965739667396773968739697397073971739727397373974739757397673977739787397973980739817398273983739847398573986739877398873989739907399173992739937399473995739967399773998739997400074001740027400374004740057400674007740087400974010740117401274013740147401574016740177401874019740207402174022740237402474025740267402774028740297403074031740327403374034740357403674037740387403974040740417404274043740447404574046740477404874049740507405174052740537405474055740567405774058740597406074061740627406374064740657406674067740687406974070740717407274073740747407574076740777407874079740807408174082740837408474085740867408774088740897409074091740927409374094740957409674097740987409974100741017410274103741047410574106741077410874109741107411174112741137411474115741167411774118741197412074121741227412374124741257412674127741287412974130741317413274133741347413574136741377413874139741407414174142741437414474145741467414774148741497415074151741527415374154741557415674157741587415974160741617416274163741647416574166741677416874169741707417174172741737417474175741767417774178741797418074181741827418374184741857418674187741887418974190741917419274193741947419574196741977419874199742007420174202742037420474205742067420774208742097421074211742127421374214742157421674217742187421974220742217422274223742247422574226742277422874229742307423174232742337423474235742367423774238742397424074241742427424374244742457424674247742487424974250742517425274253742547425574256742577425874259742607426174262742637426474265742667426774268742697427074271742727427374274742757427674277742787427974280742817428274283742847428574286742877428874289742907429174292742937429474295742967429774298742997430074301743027430374304743057430674307743087430974310743117431274313743147431574316743177431874319743207432174322743237432474325743267432774328743297433074331743327433374334743357433674337743387433974340743417434274343743447434574346743477434874349743507435174352743537435474355743567435774358743597436074361743627436374364743657436674367743687436974370743717437274373743747437574376743777437874379743807438174382743837438474385743867438774388743897439074391743927439374394743957439674397743987439974400744017440274403744047440574406744077440874409744107441174412744137441474415744167441774418744197442074421744227442374424744257442674427744287442974430744317443274433744347443574436744377443874439744407444174442744437444474445744467444774448744497445074451744527445374454744557445674457744587445974460744617446274463744647446574466744677446874469744707447174472744737447474475744767447774478744797448074481744827448374484744857448674487744887448974490744917449274493744947449574496744977449874499745007450174502745037450474505745067450774508745097451074511745127451374514745157451674517745187451974520745217452274523745247452574526745277452874529745307453174532745337453474535745367453774538745397454074541745427454374544745457454674547745487454974550745517455274553745547455574556745577455874559745607456174562745637456474565745667456774568745697457074571745727457374574745757457674577745787457974580745817458274583745847458574586745877458874589745907459174592745937459474595745967459774598745997460074601746027460374604746057460674607746087460974610746117461274613746147461574616746177461874619746207462174622746237462474625746267462774628746297463074631746327463374634746357463674637746387463974640746417464274643746447464574646746477464874649746507465174652746537465474655746567465774658746597466074661746627466374664746657466674667746687466974670746717467274673746747467574676746777467874679746807468174682746837468474685746867468774688746897469074691746927469374694746957469674697746987469974700747017470274703747047470574706747077470874709747107471174712747137471474715747167471774718747197472074721747227472374724747257472674727747287472974730747317473274733747347473574736747377473874739747407474174742747437474474745747467474774748747497475074751747527475374754747557475674757747587475974760747617476274763747647476574766747677476874769747707477174772747737477474775747767477774778747797478074781747827478374784747857478674787747887478974790747917479274793747947479574796747977479874799748007480174802748037480474805748067480774808748097481074811748127481374814748157481674817748187481974820748217482274823748247482574826748277482874829748307483174832748337483474835748367483774838748397484074841748427484374844748457484674847748487484974850748517485274853748547485574856748577485874859748607486174862748637486474865748667486774868748697487074871748727487374874748757487674877748787487974880748817488274883748847488574886748877488874889748907489174892748937489474895748967489774898748997490074901749027490374904749057490674907749087490974910749117491274913749147491574916749177491874919749207492174922749237492474925749267492774928749297493074931749327493374934749357493674937749387493974940749417494274943749447494574946749477494874949749507495174952749537495474955749567495774958749597496074961749627496374964749657496674967749687496974970749717497274973749747497574976749777497874979749807498174982749837498474985749867498774988749897499074991749927499374994749957499674997749987499975000750017500275003750047500575006750077500875009750107501175012750137501475015750167501775018750197502075021750227502375024750257502675027750287502975030750317503275033750347503575036750377503875039750407504175042750437504475045750467504775048750497505075051750527505375054750557505675057750587505975060750617506275063750647506575066750677506875069750707507175072750737507475075750767507775078750797508075081750827508375084750857508675087750887508975090750917509275093750947509575096750977509875099751007510175102751037510475105751067510775108751097511075111751127511375114751157511675117751187511975120751217512275123751247512575126751277512875129751307513175132751337513475135751367513775138751397514075141751427514375144751457514675147751487514975150751517515275153751547515575156751577515875159751607516175162751637516475165751667516775168751697517075171751727517375174751757517675177751787517975180751817518275183751847518575186751877518875189751907519175192751937519475195751967519775198751997520075201752027520375204752057520675207752087520975210752117521275213752147521575216752177521875219752207522175222752237522475225752267522775228752297523075231752327523375234752357523675237752387523975240752417524275243752447524575246752477524875249752507525175252752537525475255752567525775258752597526075261752627526375264752657526675267752687526975270752717527275273752747527575276752777527875279752807528175282752837528475285752867528775288752897529075291752927529375294752957529675297752987529975300753017530275303753047530575306753077530875309753107531175312753137531475315753167531775318753197532075321753227532375324753257532675327753287532975330753317533275333753347533575336753377533875339753407534175342753437534475345753467534775348753497535075351753527535375354753557535675357753587535975360753617536275363753647536575366753677536875369753707537175372753737537475375753767537775378753797538075381753827538375384753857538675387753887538975390753917539275393753947539575396753977539875399754007540175402754037540475405754067540775408754097541075411754127541375414754157541675417754187541975420754217542275423754247542575426754277542875429754307543175432754337543475435754367543775438754397544075441754427544375444754457544675447754487544975450754517545275453754547545575456754577545875459754607546175462754637546475465754667546775468754697547075471754727547375474754757547675477754787547975480754817548275483754847548575486754877548875489754907549175492754937549475495754967549775498754997550075501755027550375504755057550675507755087550975510755117551275513755147551575516755177551875519755207552175522755237552475525755267552775528755297553075531755327553375534755357553675537755387553975540755417554275543755447554575546755477554875549755507555175552755537555475555755567555775558755597556075561755627556375564755657556675567755687556975570755717557275573755747557575576755777557875579755807558175582755837558475585755867558775588755897559075591755927559375594755957559675597755987559975600756017560275603756047560575606756077560875609756107561175612756137561475615756167561775618756197562075621756227562375624756257562675627756287562975630756317563275633756347563575636756377563875639756407564175642756437564475645756467564775648756497565075651756527565375654756557565675657756587565975660756617566275663756647566575666756677566875669756707567175672756737567475675756767567775678756797568075681756827568375684756857568675687756887568975690756917569275693756947569575696756977569875699757007570175702757037570475705757067570775708757097571075711757127571375714757157571675717757187571975720757217572275723757247572575726757277572875729757307573175732757337573475735757367573775738757397574075741757427574375744757457574675747757487574975750757517575275753757547575575756757577575875759757607576175762757637576475765757667576775768757697577075771757727577375774757757577675777757787577975780757817578275783757847578575786757877578875789757907579175792757937579475795757967579775798757997580075801758027580375804758057580675807758087580975810758117581275813758147581575816758177581875819758207582175822758237582475825758267582775828758297583075831758327583375834758357583675837758387583975840758417584275843758447584575846758477584875849758507585175852758537585475855758567585775858758597586075861758627586375864758657586675867758687586975870758717587275873758747587575876758777587875879758807588175882758837588475885758867588775888758897589075891758927589375894758957589675897758987589975900759017590275903759047590575906759077590875909759107591175912759137591475915759167591775918759197592075921759227592375924759257592675927759287592975930759317593275933759347593575936759377593875939759407594175942759437594475945759467594775948759497595075951759527595375954759557595675957759587595975960759617596275963759647596575966759677596875969759707597175972759737597475975759767597775978759797598075981759827598375984759857598675987759887598975990759917599275993759947599575996759977599875999760007600176002760037600476005760067600776008760097601076011760127601376014760157601676017760187601976020760217602276023760247602576026760277602876029760307603176032760337603476035760367603776038760397604076041760427604376044760457604676047760487604976050760517605276053760547605576056760577605876059760607606176062760637606476065760667606776068760697607076071760727607376074760757607676077760787607976080760817608276083760847608576086760877608876089760907609176092760937609476095760967609776098760997610076101761027610376104761057610676107761087610976110761117611276113761147611576116761177611876119761207612176122761237612476125761267612776128761297613076131761327613376134761357613676137761387613976140761417614276143761447614576146761477614876149761507615176152761537615476155761567615776158761597616076161761627616376164761657616676167761687616976170761717617276173761747617576176761777617876179761807618176182761837618476185761867618776188761897619076191761927619376194761957619676197761987619976200762017620276203762047620576206762077620876209762107621176212762137621476215762167621776218762197622076221762227622376224762257622676227762287622976230762317623276233762347623576236762377623876239762407624176242762437624476245762467624776248762497625076251762527625376254762557625676257762587625976260762617626276263762647626576266762677626876269762707627176272762737627476275762767627776278762797628076281762827628376284762857628676287762887628976290762917629276293762947629576296762977629876299763007630176302763037630476305763067630776308763097631076311763127631376314763157631676317763187631976320763217632276323763247632576326763277632876329763307633176332763337633476335763367633776338763397634076341763427634376344763457634676347763487634976350763517635276353763547635576356763577635876359763607636176362763637636476365763667636776368763697637076371763727637376374763757637676377763787637976380763817638276383763847638576386763877638876389763907639176392763937639476395763967639776398763997640076401764027640376404764057640676407764087640976410764117641276413764147641576416764177641876419764207642176422764237642476425764267642776428764297643076431764327643376434764357643676437764387643976440764417644276443764447644576446764477644876449764507645176452764537645476455764567645776458764597646076461764627646376464764657646676467764687646976470764717647276473764747647576476764777647876479764807648176482764837648476485764867648776488764897649076491764927649376494764957649676497764987649976500765017650276503765047650576506765077650876509765107651176512765137651476515765167651776518765197652076521765227652376524765257652676527765287652976530765317653276533765347653576536765377653876539765407654176542765437654476545765467654776548765497655076551765527655376554765557655676557765587655976560765617656276563765647656576566765677656876569765707657176572765737657476575765767657776578765797658076581765827658376584765857658676587765887658976590765917659276593765947659576596765977659876599766007660176602766037660476605766067660776608766097661076611766127661376614766157661676617766187661976620766217662276623766247662576626766277662876629766307663176632766337663476635766367663776638766397664076641766427664376644766457664676647766487664976650766517665276653766547665576656766577665876659766607666176662766637666476665766667666776668766697667076671766727667376674766757667676677766787667976680766817668276683766847668576686766877668876689766907669176692766937669476695766967669776698766997670076701767027670376704767057670676707767087670976710767117671276713767147671576716767177671876719767207672176722767237672476725767267672776728767297673076731767327673376734767357673676737767387673976740767417674276743767447674576746767477674876749767507675176752767537675476755767567675776758767597676076761767627676376764767657676676767767687676976770767717677276773767747677576776767777677876779767807678176782767837678476785767867678776788767897679076791767927679376794767957679676797767987679976800768017680276803768047680576806768077680876809768107681176812768137681476815768167681776818768197682076821768227682376824768257682676827768287682976830768317683276833768347683576836768377683876839768407684176842768437684476845768467684776848768497685076851768527685376854768557685676857768587685976860768617686276863768647686576866768677686876869768707687176872768737687476875768767687776878768797688076881768827688376884768857688676887768887688976890768917689276893768947689576896768977689876899769007690176902769037690476905769067690776908769097691076911769127691376914769157691676917769187691976920769217692276923769247692576926769277692876929769307693176932769337693476935769367693776938769397694076941769427694376944769457694676947769487694976950769517695276953769547695576956769577695876959769607696176962769637696476965769667696776968769697697076971769727697376974769757697676977769787697976980769817698276983769847698576986769877698876989769907699176992769937699476995769967699776998769997700077001770027700377004770057700677007770087700977010770117701277013770147701577016770177701877019770207702177022770237702477025770267702777028770297703077031770327703377034770357703677037770387703977040770417704277043770447704577046770477704877049770507705177052770537705477055770567705777058770597706077061770627706377064770657706677067770687706977070770717707277073770747707577076770777707877079770807708177082770837708477085770867708777088770897709077091770927709377094770957709677097770987709977100771017710277103771047710577106771077710877109771107711177112771137711477115771167711777118771197712077121771227712377124771257712677127771287712977130771317713277133771347713577136771377713877139771407714177142771437714477145771467714777148771497715077151771527715377154771557715677157771587715977160771617716277163771647716577166771677716877169771707717177172771737717477175771767717777178771797718077181771827718377184771857718677187771887718977190771917719277193771947719577196771977719877199772007720177202772037720477205772067720777208772097721077211772127721377214772157721677217772187721977220772217722277223772247722577226772277722877229772307723177232772337723477235772367723777238772397724077241772427724377244772457724677247772487724977250772517725277253772547725577256772577725877259772607726177262772637726477265772667726777268772697727077271772727727377274772757727677277772787727977280772817728277283772847728577286772877728877289772907729177292772937729477295772967729777298772997730077301773027730377304773057730677307773087730977310773117731277313773147731577316773177731877319773207732177322773237732477325773267732777328773297733077331773327733377334773357733677337773387733977340773417734277343773447734577346773477734877349773507735177352773537735477355773567735777358773597736077361773627736377364773657736677367773687736977370773717737277373773747737577376773777737877379773807738177382773837738477385773867738777388773897739077391773927739377394773957739677397773987739977400774017740277403774047740577406774077740877409774107741177412774137741477415774167741777418774197742077421774227742377424774257742677427774287742977430774317743277433774347743577436774377743877439774407744177442774437744477445774467744777448774497745077451774527745377454774557745677457774587745977460774617746277463774647746577466774677746877469774707747177472774737747477475774767747777478774797748077481774827748377484774857748677487774887748977490774917749277493774947749577496774977749877499775007750177502775037750477505775067750777508775097751077511775127751377514775157751677517775187751977520775217752277523775247752577526775277752877529775307753177532775337753477535775367753777538775397754077541775427754377544775457754677547775487754977550775517755277553775547755577556775577755877559775607756177562775637756477565775667756777568775697757077571775727757377574775757757677577775787757977580775817758277583775847758577586775877758877589775907759177592775937759477595775967759777598775997760077601776027760377604776057760677607776087760977610776117761277613776147761577616776177761877619776207762177622776237762477625776267762777628776297763077631776327763377634776357763677637776387763977640776417764277643776447764577646776477764877649776507765177652776537765477655776567765777658776597766077661776627766377664776657766677667776687766977670776717767277673776747767577676776777767877679776807768177682776837768477685776867768777688776897769077691776927769377694776957769677697776987769977700777017770277703777047770577706777077770877709777107771177712777137771477715777167771777718777197772077721777227772377724777257772677727777287772977730777317773277733777347773577736777377773877739777407774177742777437774477745777467774777748777497775077751777527775377754777557775677757777587775977760777617776277763777647776577766777677776877769777707777177772777737777477775777767777777778777797778077781777827778377784777857778677787777887778977790777917779277793777947779577796777977779877799778007780177802778037780477805778067780777808778097781077811778127781377814778157781677817778187781977820778217782277823778247782577826778277782877829778307783177832778337783477835778367783777838778397784077841778427784377844778457784677847778487784977850778517785277853778547785577856778577785877859778607786177862778637786477865778667786777868778697787077871778727787377874778757787677877778787787977880778817788277883778847788577886778877788877889778907789177892778937789477895778967789777898778997790077901779027790377904779057790677907779087790977910779117791277913779147791577916779177791877919779207792177922779237792477925779267792777928779297793077931779327793377934779357793677937779387793977940779417794277943779447794577946779477794877949779507795177952779537795477955779567795777958779597796077961779627796377964779657796677967779687796977970779717797277973779747797577976779777797877979779807798177982779837798477985779867798777988779897799077991779927799377994779957799677997779987799978000780017800278003780047800578006780077800878009780107801178012780137801478015780167801778018780197802078021780227802378024780257802678027780287802978030780317803278033780347803578036780377803878039780407804178042780437804478045780467804778048780497805078051780527805378054780557805678057780587805978060780617806278063780647806578066780677806878069780707807178072780737807478075780767807778078780797808078081780827808378084780857808678087780887808978090780917809278093780947809578096780977809878099781007810178102781037810478105781067810778108781097811078111781127811378114781157811678117781187811978120781217812278123781247812578126781277812878129781307813178132781337813478135781367813778138781397814078141781427814378144781457814678147781487814978150781517815278153781547815578156781577815878159781607816178162781637816478165781667816778168781697817078171781727817378174781757817678177781787817978180781817818278183781847818578186781877818878189781907819178192781937819478195781967819778198781997820078201782027820378204782057820678207782087820978210782117821278213782147821578216782177821878219782207822178222782237822478225782267822778228782297823078231782327823378234782357823678237782387823978240782417824278243782447824578246782477824878249782507825178252782537825478255782567825778258782597826078261782627826378264782657826678267782687826978270782717827278273782747827578276782777827878279782807828178282782837828478285782867828778288782897829078291782927829378294782957829678297782987829978300783017830278303783047830578306783077830878309783107831178312783137831478315783167831778318783197832078321783227832378324783257832678327783287832978330783317833278333783347833578336783377833878339783407834178342783437834478345783467834778348783497835078351783527835378354783557835678357783587835978360783617836278363783647836578366783677836878369783707837178372783737837478375783767837778378783797838078381783827838378384783857838678387783887838978390783917839278393783947839578396783977839878399784007840178402784037840478405784067840778408784097841078411784127841378414784157841678417784187841978420784217842278423784247842578426784277842878429784307843178432784337843478435784367843778438784397844078441784427844378444784457844678447784487844978450784517845278453784547845578456784577845878459784607846178462784637846478465784667846778468784697847078471784727847378474784757847678477784787847978480784817848278483784847848578486784877848878489784907849178492784937849478495784967849778498784997850078501785027850378504785057850678507785087850978510785117851278513785147851578516785177851878519785207852178522785237852478525785267852778528785297853078531785327853378534785357853678537785387853978540785417854278543785447854578546785477854878549785507855178552785537855478555785567855778558785597856078561785627856378564785657856678567785687856978570785717857278573785747857578576785777857878579785807858178582785837858478585785867858778588785897859078591785927859378594785957859678597785987859978600786017860278603786047860578606786077860878609786107861178612786137861478615786167861778618786197862078621786227862378624786257862678627786287862978630786317863278633786347863578636786377863878639786407864178642786437864478645786467864778648786497865078651786527865378654786557865678657786587865978660786617866278663786647866578666786677866878669786707867178672786737867478675786767867778678786797868078681786827868378684786857868678687786887868978690786917869278693786947869578696786977869878699787007870178702787037870478705787067870778708787097871078711787127871378714787157871678717787187871978720787217872278723787247872578726787277872878729787307873178732787337873478735787367873778738787397874078741787427874378744787457874678747787487874978750787517875278753787547875578756787577875878759787607876178762787637876478765787667876778768787697877078771787727877378774787757877678777787787877978780787817878278783787847878578786787877878878789787907879178792787937879478795787967879778798787997880078801788027880378804788057880678807788087880978810788117881278813788147881578816788177881878819788207882178822788237882478825788267882778828788297883078831788327883378834788357883678837788387883978840788417884278843788447884578846788477884878849788507885178852788537885478855788567885778858788597886078861788627886378864788657886678867788687886978870788717887278873788747887578876788777887878879788807888178882788837888478885788867888778888788897889078891788927889378894788957889678897788987889978900789017890278903789047890578906789077890878909789107891178912789137891478915789167891778918789197892078921789227892378924789257892678927789287892978930789317893278933789347893578936789377893878939789407894178942789437894478945789467894778948789497895078951789527895378954789557895678957789587895978960789617896278963789647896578966789677896878969789707897178972789737897478975789767897778978789797898078981789827898378984789857898678987789887898978990789917899278993789947899578996789977899878999790007900179002790037900479005790067900779008790097901079011790127901379014790157901679017790187901979020790217902279023790247902579026790277902879029790307903179032790337903479035790367903779038790397904079041790427904379044790457904679047790487904979050790517905279053790547905579056790577905879059790607906179062790637906479065790667906779068790697907079071790727907379074790757907679077790787907979080790817908279083790847908579086790877908879089790907909179092790937909479095790967909779098790997910079101791027910379104791057910679107791087910979110791117911279113791147911579116791177911879119791207912179122791237912479125791267912779128791297913079131791327913379134791357913679137791387913979140791417914279143791447914579146791477914879149791507915179152791537915479155791567915779158791597916079161791627916379164791657916679167791687916979170791717917279173791747917579176791777917879179791807918179182791837918479185791867918779188791897919079191791927919379194791957919679197791987919979200792017920279203792047920579206792077920879209792107921179212792137921479215792167921779218792197922079221792227922379224792257922679227792287922979230792317923279233792347923579236792377923879239792407924179242792437924479245792467924779248792497925079251792527925379254792557925679257792587925979260792617926279263792647926579266792677926879269792707927179272792737927479275792767927779278792797928079281792827928379284792857928679287792887928979290792917929279293792947929579296792977929879299793007930179302793037930479305793067930779308793097931079311793127931379314793157931679317793187931979320793217932279323793247932579326793277932879329793307933179332793337933479335793367933779338793397934079341793427934379344793457934679347793487934979350793517935279353793547935579356793577935879359793607936179362793637936479365793667936779368793697937079371793727937379374793757937679377793787937979380793817938279383793847938579386793877938879389793907939179392793937939479395793967939779398793997940079401794027940379404794057940679407794087940979410794117941279413794147941579416794177941879419794207942179422794237942479425794267942779428794297943079431794327943379434794357943679437794387943979440794417944279443794447944579446794477944879449794507945179452794537945479455794567945779458794597946079461794627946379464794657946679467794687946979470794717947279473794747947579476794777947879479794807948179482794837948479485794867948779488794897949079491794927949379494794957949679497794987949979500795017950279503795047950579506795077950879509795107951179512795137951479515795167951779518795197952079521795227952379524795257952679527795287952979530795317953279533795347953579536795377953879539795407954179542795437954479545795467954779548795497955079551795527955379554795557955679557795587955979560795617956279563795647956579566795677956879569795707957179572795737957479575795767957779578795797958079581795827958379584795857958679587795887958979590795917959279593795947959579596795977959879599796007960179602796037960479605796067960779608796097961079611796127961379614796157961679617796187961979620796217962279623796247962579626796277962879629796307963179632796337963479635796367963779638796397964079641796427964379644796457964679647796487964979650796517965279653796547965579656796577965879659796607966179662796637966479665796667966779668796697967079671796727967379674796757967679677796787967979680796817968279683796847968579686796877968879689796907969179692796937969479695796967969779698796997970079701797027970379704797057970679707797087970979710797117971279713797147971579716797177971879719797207972179722797237972479725797267972779728797297973079731797327973379734797357973679737797387973979740797417974279743797447974579746797477974879749797507975179752797537975479755797567975779758797597976079761797627976379764797657976679767797687976979770797717977279773797747977579776797777977879779797807978179782797837978479785797867978779788797897979079791797927979379794797957979679797797987979979800798017980279803798047980579806798077980879809798107981179812798137981479815798167981779818798197982079821798227982379824798257982679827798287982979830798317983279833798347983579836798377983879839798407984179842798437984479845798467984779848798497985079851798527985379854798557985679857798587985979860798617986279863798647986579866798677986879869798707987179872798737987479875798767987779878798797988079881798827988379884798857988679887798887988979890798917989279893798947989579896798977989879899799007990179902799037990479905799067990779908799097991079911799127991379914799157991679917799187991979920799217992279923799247992579926799277992879929799307993179932799337993479935799367993779938799397994079941799427994379944799457994679947799487994979950799517995279953799547995579956799577995879959799607996179962799637996479965799667996779968799697997079971799727997379974799757997679977799787997979980799817998279983799847998579986799877998879989799907999179992799937999479995799967999779998799998000080001800028000380004800058000680007800088000980010800118001280013800148001580016800178001880019800208002180022800238002480025800268002780028800298003080031800328003380034800358003680037800388003980040800418004280043800448004580046800478004880049800508005180052800538005480055800568005780058800598006080061800628006380064800658006680067800688006980070800718007280073800748007580076800778007880079800808008180082800838008480085800868008780088800898009080091800928009380094800958009680097800988009980100801018010280103801048010580106801078010880109801108011180112801138011480115801168011780118801198012080121801228012380124801258012680127801288012980130801318013280133801348013580136801378013880139801408014180142801438014480145801468014780148801498015080151801528015380154801558015680157801588015980160801618016280163801648016580166801678016880169801708017180172801738017480175801768017780178801798018080181801828018380184801858018680187801888018980190801918019280193801948019580196801978019880199802008020180202802038020480205802068020780208802098021080211802128021380214802158021680217802188021980220802218022280223802248022580226802278022880229802308023180232802338023480235802368023780238802398024080241802428024380244802458024680247802488024980250802518025280253802548025580256802578025880259802608026180262802638026480265802668026780268802698027080271802728027380274802758027680277802788027980280802818028280283802848028580286802878028880289802908029180292802938029480295802968029780298802998030080301803028030380304803058030680307803088030980310803118031280313803148031580316803178031880319803208032180322803238032480325803268032780328803298033080331803328033380334803358033680337803388033980340803418034280343803448034580346803478034880349803508035180352803538035480355803568035780358803598036080361803628036380364803658036680367803688036980370803718037280373803748037580376803778037880379803808038180382803838038480385803868038780388803898039080391803928039380394803958039680397803988039980400804018040280403804048040580406804078040880409804108041180412804138041480415804168041780418804198042080421804228042380424804258042680427804288042980430804318043280433804348043580436804378043880439804408044180442804438044480445804468044780448804498045080451804528045380454804558045680457804588045980460804618046280463804648046580466804678046880469804708047180472804738047480475804768047780478804798048080481804828048380484804858048680487804888048980490804918049280493804948049580496804978049880499805008050180502805038050480505805068050780508805098051080511805128051380514805158051680517805188051980520805218052280523805248052580526805278052880529805308053180532805338053480535805368053780538805398054080541805428054380544805458054680547805488054980550805518055280553805548055580556805578055880559805608056180562805638056480565805668056780568805698057080571805728057380574805758057680577805788057980580805818058280583805848058580586805878058880589805908059180592805938059480595805968059780598805998060080601806028060380604806058060680607806088060980610806118061280613806148061580616806178061880619806208062180622806238062480625806268062780628806298063080631806328063380634806358063680637806388063980640806418064280643806448064580646806478064880649806508065180652806538065480655806568065780658806598066080661806628066380664806658066680667806688066980670806718067280673806748067580676806778067880679806808068180682806838068480685806868068780688806898069080691806928069380694806958069680697806988069980700807018070280703807048070580706807078070880709807108071180712807138071480715807168071780718807198072080721807228072380724807258072680727807288072980730807318073280733807348073580736807378073880739807408074180742807438074480745807468074780748807498075080751807528075380754807558075680757807588075980760807618076280763807648076580766807678076880769807708077180772807738077480775807768077780778807798078080781807828078380784807858078680787807888078980790807918079280793807948079580796807978079880799808008080180802808038080480805808068080780808808098081080811808128081380814808158081680817808188081980820808218082280823808248082580826808278082880829808308083180832808338083480835808368083780838808398084080841808428084380844808458084680847808488084980850808518085280853808548085580856808578085880859808608086180862808638086480865808668086780868808698087080871808728087380874808758087680877808788087980880808818088280883808848088580886808878088880889808908089180892808938089480895808968089780898808998090080901809028090380904809058090680907809088090980910809118091280913809148091580916809178091880919809208092180922809238092480925809268092780928809298093080931809328093380934809358093680937809388093980940809418094280943809448094580946809478094880949809508095180952809538095480955809568095780958809598096080961809628096380964809658096680967809688096980970809718097280973809748097580976809778097880979809808098180982809838098480985809868098780988809898099080991809928099380994809958099680997809988099981000810018100281003810048100581006810078100881009810108101181012810138101481015810168101781018810198102081021810228102381024810258102681027810288102981030810318103281033810348103581036810378103881039810408104181042810438104481045810468104781048810498105081051810528105381054810558105681057810588105981060810618106281063810648106581066810678106881069810708107181072810738107481075810768107781078810798108081081810828108381084810858108681087810888108981090810918109281093810948109581096810978109881099811008110181102811038110481105811068110781108811098111081111811128111381114811158111681117811188111981120811218112281123811248112581126811278112881129811308113181132811338113481135811368113781138811398114081141811428114381144811458114681147811488114981150811518115281153811548115581156811578115881159811608116181162811638116481165811668116781168811698117081171811728117381174811758117681177811788117981180811818118281183811848118581186811878118881189811908119181192811938119481195811968119781198811998120081201812028120381204812058120681207812088120981210812118121281213812148121581216812178121881219812208122181222812238122481225812268122781228812298123081231812328123381234812358123681237812388123981240812418124281243812448124581246812478124881249812508125181252812538125481255812568125781258812598126081261812628126381264812658126681267812688126981270812718127281273812748127581276812778127881279812808128181282812838128481285812868128781288812898129081291812928129381294812958129681297812988129981300813018130281303813048130581306813078130881309813108131181312813138131481315813168131781318813198132081321813228132381324813258132681327813288132981330813318133281333813348133581336813378133881339813408134181342813438134481345813468134781348813498135081351813528135381354813558135681357813588135981360813618136281363813648136581366813678136881369813708137181372813738137481375813768137781378813798138081381813828138381384813858138681387813888138981390813918139281393813948139581396813978139881399814008140181402814038140481405814068140781408814098141081411814128141381414814158141681417814188141981420814218142281423814248142581426814278142881429814308143181432814338143481435814368143781438814398144081441814428144381444814458144681447814488144981450814518145281453814548145581456814578145881459814608146181462814638146481465814668146781468814698147081471814728147381474814758147681477814788147981480814818148281483814848148581486814878148881489814908149181492814938149481495814968149781498814998150081501815028150381504815058150681507815088150981510815118151281513815148151581516815178151881519815208152181522815238152481525815268152781528815298153081531815328153381534815358153681537815388153981540815418154281543815448154581546815478154881549815508155181552815538155481555815568155781558815598156081561815628156381564815658156681567815688156981570815718157281573815748157581576815778157881579815808158181582815838158481585815868158781588815898159081591815928159381594815958159681597815988159981600816018160281603816048160581606816078160881609816108161181612816138161481615816168161781618816198162081621816228162381624816258162681627816288162981630816318163281633816348163581636816378163881639816408164181642816438164481645816468164781648816498165081651816528165381654816558165681657816588165981660816618166281663816648166581666816678166881669816708167181672816738167481675816768167781678816798168081681816828168381684816858168681687816888168981690816918169281693816948169581696816978169881699817008170181702817038170481705817068170781708817098171081711817128171381714817158171681717817188171981720817218172281723817248172581726817278172881729817308173181732817338173481735817368173781738817398174081741817428174381744817458174681747817488174981750817518175281753817548175581756817578175881759817608176181762817638176481765817668176781768817698177081771817728177381774817758177681777817788177981780817818178281783817848178581786817878178881789817908179181792817938179481795817968179781798817998180081801818028180381804818058180681807818088180981810818118181281813818148181581816818178181881819818208182181822818238182481825818268182781828818298183081831818328183381834818358183681837818388183981840818418184281843818448184581846818478184881849818508185181852818538185481855818568185781858818598186081861818628186381864818658186681867818688186981870818718187281873818748187581876818778187881879818808188181882818838188481885818868188781888818898189081891818928189381894818958189681897818988189981900819018190281903819048190581906819078190881909819108191181912819138191481915819168191781918819198192081921819228192381924819258192681927819288192981930819318193281933819348193581936819378193881939819408194181942819438194481945819468194781948819498195081951819528195381954819558195681957819588195981960819618196281963819648196581966819678196881969819708197181972819738197481975819768197781978819798198081981819828198381984819858198681987819888198981990819918199281993819948199581996819978199881999820008200182002820038200482005820068200782008820098201082011820128201382014820158201682017820188201982020820218202282023820248202582026820278202882029820308203182032820338203482035820368203782038820398204082041820428204382044820458204682047820488204982050820518205282053820548205582056820578205882059820608206182062820638206482065820668206782068820698207082071820728207382074820758207682077820788207982080820818208282083820848208582086820878208882089820908209182092820938209482095820968209782098820998210082101821028210382104821058210682107821088210982110821118211282113821148211582116821178211882119821208212182122821238212482125821268212782128821298213082131821328213382134821358213682137821388213982140821418214282143821448214582146821478214882149821508215182152821538215482155821568215782158821598216082161821628216382164821658216682167821688216982170821718217282173821748217582176821778217882179821808218182182821838218482185821868218782188821898219082191821928219382194821958219682197821988219982200822018220282203822048220582206822078220882209822108221182212822138221482215822168221782218822198222082221822228222382224822258222682227822288222982230822318223282233822348223582236822378223882239822408224182242822438224482245822468224782248822498225082251822528225382254822558225682257822588225982260822618226282263822648226582266822678226882269822708227182272822738227482275822768227782278822798228082281822828228382284822858228682287822888228982290822918229282293822948229582296822978229882299823008230182302823038230482305823068230782308823098231082311823128231382314823158231682317823188231982320823218232282323823248232582326823278232882329823308233182332823338233482335823368233782338823398234082341823428234382344823458234682347823488234982350823518235282353823548235582356823578235882359823608236182362823638236482365823668236782368823698237082371823728237382374823758237682377823788237982380823818238282383823848238582386823878238882389823908239182392823938239482395823968239782398823998240082401824028240382404824058240682407824088240982410824118241282413824148241582416824178241882419824208242182422824238242482425824268242782428824298243082431824328243382434824358243682437824388243982440824418244282443824448244582446824478244882449824508245182452824538245482455824568245782458824598246082461824628246382464824658246682467824688246982470824718247282473824748247582476824778247882479824808248182482824838248482485824868248782488824898249082491824928249382494824958249682497824988249982500825018250282503825048250582506825078250882509825108251182512825138251482515825168251782518825198252082521825228252382524825258252682527825288252982530825318253282533825348253582536825378253882539825408254182542825438254482545825468254782548825498255082551825528255382554825558255682557825588255982560825618256282563825648256582566825678256882569825708257182572825738257482575825768257782578825798258082581825828258382584825858258682587825888258982590825918259282593825948259582596825978259882599826008260182602826038260482605826068260782608826098261082611826128261382614826158261682617826188261982620826218262282623826248262582626826278262882629826308263182632826338263482635826368263782638826398264082641826428264382644826458264682647826488264982650826518265282653826548265582656826578265882659826608266182662826638266482665826668266782668826698267082671826728267382674826758267682677826788267982680826818268282683826848268582686826878268882689826908269182692826938269482695826968269782698826998270082701827028270382704827058270682707827088270982710827118271282713827148271582716827178271882719827208272182722827238272482725827268272782728827298273082731827328273382734827358273682737827388273982740827418274282743827448274582746827478274882749827508275182752827538275482755827568275782758827598276082761827628276382764827658276682767827688276982770827718277282773827748277582776827778277882779827808278182782827838278482785827868278782788827898279082791827928279382794827958279682797827988279982800828018280282803828048280582806828078280882809828108281182812828138281482815828168281782818828198282082821828228282382824828258282682827828288282982830828318283282833828348283582836828378283882839828408284182842828438284482845828468284782848828498285082851828528285382854828558285682857828588285982860828618286282863828648286582866828678286882869828708287182872828738287482875828768287782878828798288082881828828288382884828858288682887828888288982890828918289282893828948289582896828978289882899829008290182902829038290482905829068290782908829098291082911829128291382914829158291682917829188291982920829218292282923829248292582926829278292882929829308293182932829338293482935829368293782938829398294082941829428294382944829458294682947829488294982950829518295282953829548295582956829578295882959829608296182962829638296482965829668296782968829698297082971829728297382974829758297682977829788297982980829818298282983829848298582986829878298882989829908299182992829938299482995829968299782998829998300083001830028300383004830058300683007830088300983010830118301283013830148301583016830178301883019830208302183022830238302483025830268302783028830298303083031830328303383034830358303683037830388303983040830418304283043830448304583046830478304883049830508305183052830538305483055830568305783058830598306083061830628306383064830658306683067830688306983070830718307283073830748307583076830778307883079830808308183082830838308483085830868308783088830898309083091830928309383094830958309683097830988309983100831018310283103831048310583106831078310883109831108311183112831138311483115831168311783118831198312083121831228312383124831258312683127831288312983130831318313283133831348313583136831378313883139831408314183142831438314483145831468314783148831498315083151831528315383154831558315683157831588315983160831618316283163831648316583166831678316883169831708317183172831738317483175831768317783178831798318083181831828318383184831858318683187831888318983190831918319283193831948319583196831978319883199832008320183202832038320483205832068320783208832098321083211832128321383214832158321683217832188321983220832218322283223832248322583226832278322883229832308323183232832338323483235832368323783238832398324083241832428324383244832458324683247832488324983250832518325283253832548325583256832578325883259832608326183262832638326483265832668326783268832698327083271832728327383274832758327683277832788327983280832818328283283832848328583286832878328883289832908329183292832938329483295832968329783298832998330083301833028330383304833058330683307833088330983310833118331283313833148331583316833178331883319833208332183322833238332483325833268332783328833298333083331833328333383334833358333683337833388333983340833418334283343833448334583346833478334883349833508335183352833538335483355833568335783358833598336083361833628336383364833658336683367833688336983370833718337283373833748337583376833778337883379833808338183382833838338483385833868338783388833898339083391833928339383394833958339683397833988339983400834018340283403834048340583406834078340883409834108341183412834138341483415834168341783418834198342083421834228342383424834258342683427834288342983430834318343283433834348343583436834378343883439834408344183442834438344483445834468344783448834498345083451834528345383454834558345683457834588345983460834618346283463834648346583466834678346883469834708347183472834738347483475834768347783478834798348083481834828348383484834858348683487834888348983490834918349283493834948349583496834978349883499835008350183502835038350483505835068350783508835098351083511835128351383514835158351683517835188351983520835218352283523835248352583526835278352883529835308353183532835338353483535835368353783538835398354083541835428354383544835458354683547835488354983550835518355283553835548355583556835578355883559835608356183562835638356483565835668356783568835698357083571835728357383574835758357683577835788357983580835818358283583835848358583586835878358883589835908359183592835938359483595835968359783598835998360083601836028360383604836058360683607836088360983610836118361283613836148361583616836178361883619836208362183622836238362483625836268362783628836298363083631836328363383634836358363683637836388363983640836418364283643836448364583646836478364883649836508365183652836538365483655836568365783658836598366083661836628366383664836658366683667836688366983670836718367283673836748367583676836778367883679836808368183682836838368483685836868368783688836898369083691836928369383694836958369683697836988369983700837018370283703837048370583706837078370883709837108371183712837138371483715837168371783718837198372083721837228372383724837258372683727837288372983730837318373283733837348373583736837378373883739837408374183742837438374483745837468374783748837498375083751837528375383754837558375683757837588375983760837618376283763837648376583766837678376883769837708377183772837738377483775837768377783778837798378083781837828378383784837858378683787837888378983790837918379283793837948379583796837978379883799838008380183802838038380483805838068380783808838098381083811838128381383814838158381683817838188381983820838218382283823838248382583826838278382883829838308383183832838338383483835838368383783838838398384083841838428384383844838458384683847838488384983850838518385283853838548385583856838578385883859838608386183862838638386483865838668386783868838698387083871838728387383874838758387683877838788387983880838818388283883838848388583886838878388883889838908389183892838938389483895838968389783898838998390083901839028390383904839058390683907839088390983910839118391283913839148391583916839178391883919839208392183922839238392483925839268392783928839298393083931839328393383934839358393683937839388393983940839418394283943839448394583946839478394883949839508395183952839538395483955839568395783958839598396083961839628396383964839658396683967839688396983970839718397283973839748397583976839778397883979839808398183982839838398483985839868398783988839898399083991839928399383994839958399683997839988399984000840018400284003840048400584006840078400884009840108401184012840138401484015840168401784018840198402084021840228402384024840258402684027840288402984030840318403284033840348403584036840378403884039840408404184042840438404484045840468404784048840498405084051840528405384054840558405684057840588405984060840618406284063840648406584066840678406884069840708407184072840738407484075840768407784078840798408084081840828408384084840858408684087840888408984090840918409284093840948409584096840978409884099841008410184102841038410484105841068410784108841098411084111841128411384114841158411684117841188411984120841218412284123841248412584126841278412884129841308413184132841338413484135841368413784138841398414084141841428414384144841458414684147841488414984150841518415284153841548415584156841578415884159841608416184162841638416484165841668416784168841698417084171841728417384174841758417684177841788417984180841818418284183841848418584186841878418884189841908419184192841938419484195841968419784198841998420084201842028420384204842058420684207842088420984210842118421284213842148421584216842178421884219842208422184222842238422484225842268422784228842298423084231842328423384234842358423684237842388423984240842418424284243842448424584246842478424884249842508425184252842538425484255842568425784258842598426084261842628426384264842658426684267842688426984270842718427284273842748427584276842778427884279842808428184282842838428484285842868428784288842898429084291842928429384294842958429684297842988429984300843018430284303843048430584306843078430884309843108431184312843138431484315843168431784318843198432084321843228432384324843258432684327843288432984330843318433284333843348433584336843378433884339843408434184342843438434484345843468434784348843498435084351843528435384354843558435684357843588435984360843618436284363843648436584366843678436884369843708437184372843738437484375843768437784378843798438084381843828438384384843858438684387843888438984390843918439284393843948439584396843978439884399844008440184402844038440484405844068440784408844098441084411844128441384414844158441684417844188441984420844218442284423844248442584426844278442884429844308443184432844338443484435844368443784438844398444084441844428444384444844458444684447844488444984450844518445284453844548445584456844578445884459844608446184462844638446484465844668446784468844698447084471844728447384474844758447684477844788447984480844818448284483844848448584486844878448884489844908449184492844938449484495844968449784498844998450084501845028450384504845058450684507845088450984510845118451284513845148451584516845178451884519845208452184522845238452484525845268452784528845298453084531845328453384534845358453684537845388453984540845418454284543845448454584546845478454884549845508455184552845538455484555845568455784558845598456084561845628456384564845658456684567845688456984570845718457284573845748457584576845778457884579845808458184582845838458484585845868458784588845898459084591845928459384594845958459684597845988459984600846018460284603846048460584606846078460884609846108461184612846138461484615846168461784618846198462084621846228462384624846258462684627846288462984630846318463284633846348463584636846378463884639846408464184642846438464484645846468464784648846498465084651846528465384654846558465684657846588465984660846618466284663846648466584666846678466884669846708467184672846738467484675846768467784678846798468084681846828468384684846858468684687846888468984690846918469284693846948469584696846978469884699847008470184702847038470484705847068470784708847098471084711847128471384714847158471684717847188471984720847218472284723847248472584726847278472884729847308473184732847338473484735847368473784738847398474084741847428474384744847458474684747847488474984750847518475284753847548475584756847578475884759847608476184762847638476484765847668476784768847698477084771847728477384774847758477684777847788477984780847818478284783847848478584786847878478884789847908479184792847938479484795847968479784798847998480084801848028480384804848058480684807848088480984810848118481284813848148481584816848178481884819848208482184822848238482484825848268482784828848298483084831848328483384834848358483684837848388483984840848418484284843848448484584846848478484884849848508485184852848538485484855848568485784858848598486084861848628486384864848658486684867848688486984870848718487284873848748487584876848778487884879848808488184882848838488484885848868488784888848898489084891848928489384894848958489684897848988489984900849018490284903849048490584906849078490884909849108491184912849138491484915849168491784918849198492084921849228492384924849258492684927849288492984930849318493284933849348493584936849378493884939849408494184942849438494484945849468494784948849498495084951849528495384954849558495684957849588495984960849618496284963849648496584966849678496884969849708497184972849738497484975849768497784978849798498084981849828498384984849858498684987849888498984990849918499284993849948499584996849978499884999850008500185002850038500485005850068500785008850098501085011850128501385014850158501685017850188501985020850218502285023850248502585026850278502885029850308503185032850338503485035850368503785038850398504085041850428504385044850458504685047850488504985050850518505285053850548505585056850578505885059850608506185062850638506485065850668506785068850698507085071850728507385074850758507685077850788507985080850818508285083850848508585086850878508885089850908509185092850938509485095850968509785098850998510085101851028510385104851058510685107851088510985110851118511285113851148511585116851178511885119851208512185122851238512485125851268512785128851298513085131851328513385134851358513685137851388513985140851418514285143851448514585146851478514885149851508515185152851538515485155851568515785158851598516085161851628516385164851658516685167851688516985170851718517285173851748517585176851778517885179851808518185182851838518485185851868518785188851898519085191851928519385194851958519685197851988519985200852018520285203852048520585206852078520885209852108521185212852138521485215852168521785218852198522085221852228522385224852258522685227852288522985230852318523285233852348523585236852378523885239852408524185242852438524485245852468524785248852498525085251852528525385254852558525685257852588525985260852618526285263852648526585266852678526885269852708527185272852738527485275852768527785278852798528085281852828528385284852858528685287852888528985290852918529285293852948529585296852978529885299853008530185302853038530485305853068530785308853098531085311853128531385314853158531685317853188531985320853218532285323853248532585326853278532885329853308533185332853338533485335853368533785338853398534085341853428534385344853458534685347853488534985350853518535285353853548535585356853578535885359853608536185362853638536485365853668536785368853698537085371853728537385374853758537685377853788537985380853818538285383853848538585386853878538885389853908539185392853938539485395853968539785398853998540085401854028540385404854058540685407854088540985410854118541285413854148541585416854178541885419854208542185422854238542485425854268542785428854298543085431854328543385434854358543685437854388543985440854418544285443854448544585446854478544885449854508545185452854538545485455854568545785458854598546085461854628546385464854658546685467854688546985470854718547285473854748547585476854778547885479854808548185482854838548485485854868548785488854898549085491854928549385494854958549685497854988549985500855018550285503855048550585506855078550885509855108551185512855138551485515855168551785518855198552085521855228552385524855258552685527855288552985530855318553285533855348553585536855378553885539855408554185542855438554485545855468554785548855498555085551855528555385554855558555685557855588555985560855618556285563855648556585566855678556885569855708557185572855738557485575855768557785578855798558085581855828558385584855858558685587855888558985590855918559285593855948559585596855978559885599856008560185602856038560485605856068560785608856098561085611856128561385614856158561685617856188561985620856218562285623856248562585626856278562885629856308563185632856338563485635856368563785638856398564085641856428564385644856458564685647856488564985650856518565285653856548565585656856578565885659856608566185662856638566485665856668566785668856698567085671856728567385674856758567685677856788567985680856818568285683856848568585686856878568885689856908569185692856938569485695856968569785698856998570085701857028570385704857058570685707857088570985710857118571285713857148571585716857178571885719857208572185722857238572485725857268572785728857298573085731857328573385734857358573685737857388573985740857418574285743857448574585746857478574885749857508575185752857538575485755857568575785758857598576085761857628576385764857658576685767857688576985770857718577285773857748577585776857778577885779857808578185782857838578485785857868578785788857898579085791857928579385794857958579685797857988579985800858018580285803858048580585806858078580885809858108581185812858138581485815858168581785818858198582085821858228582385824858258582685827858288582985830858318583285833858348583585836858378583885839858408584185842858438584485845858468584785848858498585085851858528585385854858558585685857858588585985860858618586285863858648586585866858678586885869858708587185872858738587485875858768587785878858798588085881858828588385884858858588685887858888588985890858918589285893858948589585896858978589885899859008590185902859038590485905859068590785908859098591085911859128591385914859158591685917859188591985920859218592285923859248592585926859278592885929859308593185932859338593485935859368593785938859398594085941859428594385944859458594685947859488594985950859518595285953859548595585956859578595885959859608596185962859638596485965859668596785968859698597085971859728597385974859758597685977859788597985980859818598285983859848598585986859878598885989859908599185992859938599485995859968599785998859998600086001860028600386004860058600686007860088600986010860118601286013860148601586016860178601886019860208602186022860238602486025860268602786028860298603086031860328603386034860358603686037860388603986040860418604286043860448604586046860478604886049860508605186052860538605486055860568605786058860598606086061860628606386064860658606686067860688606986070860718607286073860748607586076860778607886079860808608186082860838608486085860868608786088860898609086091860928609386094860958609686097860988609986100861018610286103861048610586106861078610886109861108611186112861138611486115861168611786118861198612086121861228612386124861258612686127861288612986130861318613286133861348613586136861378613886139861408614186142861438614486145861468614786148861498615086151861528615386154861558615686157861588615986160861618616286163861648616586166861678616886169861708617186172861738617486175861768617786178861798618086181861828618386184861858618686187861888618986190861918619286193861948619586196861978619886199862008620186202862038620486205862068620786208862098621086211862128621386214862158621686217862188621986220862218622286223862248622586226862278622886229862308623186232862338623486235862368623786238862398624086241862428624386244862458624686247862488624986250862518625286253862548625586256862578625886259862608626186262862638626486265862668626786268862698627086271862728627386274862758627686277862788627986280862818628286283862848628586286862878628886289862908629186292862938629486295862968629786298862998630086301863028630386304863058630686307863088630986310863118631286313863148631586316863178631886319863208632186322863238632486325863268632786328863298633086331863328633386334863358633686337863388633986340863418634286343863448634586346863478634886349863508635186352863538635486355863568635786358863598636086361863628636386364863658636686367863688636986370863718637286373863748637586376863778637886379863808638186382863838638486385863868638786388863898639086391863928639386394863958639686397863988639986400864018640286403864048640586406864078640886409864108641186412864138641486415864168641786418864198642086421864228642386424864258642686427864288642986430864318643286433864348643586436864378643886439864408644186442864438644486445864468644786448864498645086451864528645386454864558645686457864588645986460864618646286463864648646586466864678646886469864708647186472864738647486475864768647786478864798648086481864828648386484864858648686487864888648986490864918649286493864948649586496864978649886499865008650186502865038650486505865068650786508865098651086511865128651386514865158651686517865188651986520865218652286523865248652586526865278652886529865308653186532865338653486535865368653786538865398654086541865428654386544865458654686547865488654986550865518655286553865548655586556865578655886559865608656186562865638656486565865668656786568865698657086571865728657386574865758657686577865788657986580865818658286583865848658586586865878658886589865908659186592865938659486595865968659786598865998660086601866028660386604866058660686607866088660986610866118661286613866148661586616866178661886619866208662186622866238662486625866268662786628866298663086631866328663386634866358663686637866388663986640866418664286643866448664586646866478664886649866508665186652866538665486655866568665786658866598666086661866628666386664866658666686667866688666986670866718667286673866748667586676866778667886679866808668186682866838668486685866868668786688866898669086691866928669386694866958669686697866988669986700867018670286703867048670586706867078670886709867108671186712867138671486715867168671786718867198672086721867228672386724867258672686727867288672986730867318673286733867348673586736867378673886739867408674186742867438674486745867468674786748867498675086751867528675386754867558675686757867588675986760867618676286763867648676586766867678676886769867708677186772867738677486775867768677786778867798678086781867828678386784867858678686787867888678986790867918679286793867948679586796867978679886799868008680186802868038680486805868068680786808868098681086811868128681386814868158681686817868188681986820868218682286823868248682586826868278682886829868308683186832868338683486835868368683786838868398684086841868428684386844868458684686847868488684986850868518685286853868548685586856868578685886859868608686186862868638686486865868668686786868868698687086871868728687386874868758687686877868788687986880868818688286883868848688586886868878688886889868908689186892868938689486895868968689786898868998690086901869028690386904869058690686907869088690986910869118691286913869148691586916869178691886919869208692186922869238692486925869268692786928869298693086931869328693386934869358693686937869388693986940869418694286943869448694586946869478694886949869508695186952869538695486955869568695786958869598696086961869628696386964869658696686967869688696986970869718697286973869748697586976869778697886979869808698186982869838698486985869868698786988869898699086991869928699386994869958699686997869988699987000870018700287003870048700587006870078700887009870108701187012870138701487015870168701787018870198702087021870228702387024870258702687027870288702987030870318703287033870348703587036870378703887039870408704187042870438704487045870468704787048870498705087051870528705387054870558705687057870588705987060870618706287063870648706587066870678706887069870708707187072870738707487075870768707787078870798708087081870828708387084870858708687087870888708987090870918709287093870948709587096870978709887099871008710187102871038710487105871068710787108871098711087111871128711387114871158711687117871188711987120871218712287123871248712587126871278712887129871308713187132871338713487135871368713787138871398714087141871428714387144871458714687147871488714987150871518715287153871548715587156871578715887159871608716187162871638716487165871668716787168871698717087171871728717387174871758717687177871788717987180871818718287183871848718587186871878718887189871908719187192871938719487195871968719787198871998720087201872028720387204872058720687207872088720987210872118721287213872148721587216872178721887219872208722187222872238722487225872268722787228872298723087231872328723387234872358723687237872388723987240872418724287243872448724587246872478724887249872508725187252872538725487255872568725787258872598726087261872628726387264872658726687267872688726987270872718727287273872748727587276872778727887279872808728187282872838728487285872868728787288872898729087291872928729387294872958729687297872988729987300873018730287303873048730587306873078730887309873108731187312873138731487315873168731787318873198732087321873228732387324873258732687327873288732987330873318733287333873348733587336873378733887339873408734187342873438734487345873468734787348873498735087351873528735387354873558735687357873588735987360873618736287363873648736587366873678736887369873708737187372873738737487375873768737787378873798738087381873828738387384873858738687387873888738987390873918739287393873948739587396873978739887399874008740187402874038740487405874068740787408874098741087411874128741387414874158741687417874188741987420874218742287423874248742587426874278742887429874308743187432874338743487435874368743787438874398744087441874428744387444874458744687447874488744987450874518745287453874548745587456874578745887459874608746187462874638746487465874668746787468874698747087471874728747387474874758747687477874788747987480874818748287483874848748587486874878748887489874908749187492874938749487495874968749787498874998750087501875028750387504875058750687507875088750987510875118751287513875148751587516875178751887519875208752187522875238752487525875268752787528875298753087531875328753387534875358753687537875388753987540875418754287543875448754587546875478754887549875508755187552875538755487555875568755787558875598756087561875628756387564875658756687567875688756987570875718757287573875748757587576875778757887579875808758187582875838758487585875868758787588875898759087591875928759387594875958759687597875988759987600876018760287603876048760587606876078760887609876108761187612876138761487615876168761787618876198762087621876228762387624876258762687627876288762987630876318763287633876348763587636876378763887639876408764187642876438764487645876468764787648876498765087651876528765387654876558765687657876588765987660876618766287663876648766587666876678766887669876708767187672876738767487675876768767787678876798768087681876828768387684876858768687687876888768987690876918769287693876948769587696876978769887699877008770187702877038770487705877068770787708877098771087711877128771387714877158771687717877188771987720877218772287723877248772587726877278772887729877308773187732877338773487735877368773787738877398774087741877428774387744877458774687747877488774987750877518775287753877548775587756877578775887759877608776187762877638776487765877668776787768877698777087771877728777387774877758777687777877788777987780877818778287783877848778587786877878778887789877908779187792877938779487795877968779787798877998780087801878028780387804878058780687807878088780987810878118781287813878148781587816878178781887819878208782187822878238782487825878268782787828878298783087831878328783387834878358783687837878388783987840878418784287843878448784587846878478784887849878508785187852878538785487855878568785787858878598786087861878628786387864878658786687867878688786987870878718787287873878748787587876878778787887879878808788187882878838788487885878868788787888878898789087891878928789387894878958789687897878988789987900879018790287903879048790587906879078790887909879108791187912879138791487915879168791787918879198792087921879228792387924879258792687927879288792987930879318793287933879348793587936879378793887939879408794187942879438794487945879468794787948879498795087951879528795387954879558795687957879588795987960879618796287963879648796587966879678796887969879708797187972879738797487975879768797787978879798798087981879828798387984879858798687987879888798987990879918799287993879948799587996879978799887999880008800188002880038800488005880068800788008880098801088011880128801388014880158801688017880188801988020880218802288023880248802588026880278802888029880308803188032880338803488035880368803788038880398804088041880428804388044880458804688047880488804988050880518805288053880548805588056880578805888059880608806188062880638806488065880668806788068880698807088071880728807388074880758807688077880788807988080880818808288083880848808588086880878808888089880908809188092880938809488095880968809788098880998810088101881028810388104881058810688107881088810988110881118811288113881148811588116881178811888119881208812188122881238812488125881268812788128881298813088131881328813388134881358813688137881388813988140881418814288143881448814588146881478814888149881508815188152881538815488155881568815788158881598816088161881628816388164881658816688167881688816988170881718817288173881748817588176881778817888179881808818188182881838818488185881868818788188881898819088191881928819388194881958819688197881988819988200882018820288203882048820588206882078820888209882108821188212882138821488215882168821788218882198822088221882228822388224882258822688227882288822988230882318823288233882348823588236882378823888239882408824188242882438824488245882468824788248882498825088251882528825388254882558825688257882588825988260882618826288263882648826588266882678826888269882708827188272882738827488275882768827788278882798828088281882828828388284882858828688287882888828988290882918829288293882948829588296882978829888299883008830188302883038830488305883068830788308883098831088311883128831388314883158831688317883188831988320883218832288323883248832588326883278832888329883308833188332883338833488335883368833788338883398834088341883428834388344883458834688347883488834988350883518835288353883548835588356883578835888359883608836188362883638836488365883668836788368883698837088371883728837388374883758837688377883788837988380883818838288383883848838588386883878838888389883908839188392883938839488395883968839788398883998840088401884028840388404884058840688407884088840988410884118841288413884148841588416884178841888419884208842188422884238842488425884268842788428884298843088431884328843388434884358843688437884388843988440884418844288443884448844588446884478844888449884508845188452884538845488455884568845788458884598846088461884628846388464884658846688467884688846988470884718847288473884748847588476884778847888479884808848188482884838848488485884868848788488884898849088491884928849388494884958849688497884988849988500885018850288503885048850588506885078850888509885108851188512885138851488515885168851788518885198852088521885228852388524885258852688527885288852988530885318853288533885348853588536885378853888539885408854188542885438854488545885468854788548885498855088551885528855388554885558855688557885588855988560885618856288563885648856588566885678856888569885708857188572885738857488575885768857788578885798858088581885828858388584885858858688587885888858988590885918859288593885948859588596885978859888599886008860188602886038860488605886068860788608886098861088611886128861388614886158861688617886188861988620886218862288623886248862588626886278862888629886308863188632886338863488635886368863788638886398864088641886428864388644886458864688647886488864988650886518865288653886548865588656886578865888659886608866188662886638866488665886668866788668886698867088671886728867388674886758867688677886788867988680886818868288683886848868588686886878868888689886908869188692886938869488695886968869788698886998870088701887028870388704887058870688707887088870988710887118871288713887148871588716887178871888719887208872188722887238872488725887268872788728887298873088731887328873388734887358873688737887388873988740887418874288743887448874588746887478874888749887508875188752887538875488755887568875788758887598876088761887628876388764887658876688767887688876988770887718877288773887748877588776887778877888779887808878188782887838878488785887868878788788887898879088791887928879388794887958879688797887988879988800888018880288803888048880588806888078880888809888108881188812888138881488815888168881788818888198882088821888228882388824888258882688827888288882988830888318883288833888348883588836888378883888839888408884188842888438884488845888468884788848888498885088851888528885388854888558885688857888588885988860888618886288863888648886588866888678886888869888708887188872888738887488875888768887788878888798888088881888828888388884888858888688887888888888988890888918889288893888948889588896888978889888899889008890188902889038890488905889068890788908889098891088911889128891388914889158891688917889188891988920889218892288923889248892588926889278892888929889308893188932889338893488935889368893788938889398894088941889428894388944889458894688947889488894988950889518895288953889548895588956889578895888959889608896188962889638896488965889668896788968889698897088971889728897388974889758897688977889788897988980889818898288983889848898588986889878898888989889908899188992889938899488995889968899788998889998900089001890028900389004890058900689007890088900989010890118901289013890148901589016890178901889019890208902189022890238902489025890268902789028890298903089031890328903389034890358903689037890388903989040890418904289043890448904589046890478904889049890508905189052890538905489055890568905789058890598906089061890628906389064890658906689067890688906989070890718907289073890748907589076890778907889079890808908189082890838908489085890868908789088890898909089091890928909389094890958909689097890988909989100891018910289103891048910589106891078910889109891108911189112891138911489115891168911789118891198912089121891228912389124891258912689127891288912989130891318913289133891348913589136891378913889139891408914189142891438914489145891468914789148891498915089151891528915389154891558915689157891588915989160891618916289163891648916589166891678916889169891708917189172891738917489175891768917789178891798918089181891828918389184891858918689187891888918989190891918919289193891948919589196891978919889199892008920189202892038920489205892068920789208892098921089211892128921389214892158921689217892188921989220892218922289223892248922589226892278922889229892308923189232892338923489235892368923789238892398924089241892428924389244892458924689247892488924989250892518925289253892548925589256892578925889259892608926189262892638926489265892668926789268892698927089271892728927389274892758927689277892788927989280892818928289283892848928589286892878928889289892908929189292892938929489295892968929789298892998930089301893028930389304893058930689307893088930989310893118931289313893148931589316893178931889319893208932189322893238932489325893268932789328893298933089331893328933389334893358933689337893388933989340893418934289343893448934589346893478934889349893508935189352893538935489355893568935789358893598936089361893628936389364893658936689367893688936989370893718937289373893748937589376893778937889379893808938189382893838938489385893868938789388893898939089391893928939389394893958939689397893988939989400894018940289403894048940589406894078940889409894108941189412894138941489415894168941789418894198942089421894228942389424894258942689427894288942989430894318943289433894348943589436894378943889439894408944189442894438944489445894468944789448894498945089451894528945389454894558945689457894588945989460894618946289463894648946589466894678946889469894708947189472894738947489475894768947789478894798948089481894828948389484894858948689487894888948989490894918949289493894948949589496894978949889499895008950189502895038950489505895068950789508895098951089511895128951389514895158951689517895188951989520895218952289523895248952589526895278952889529895308953189532895338953489535895368953789538895398954089541895428954389544895458954689547895488954989550895518955289553895548955589556895578955889559895608956189562895638956489565895668956789568895698957089571895728957389574895758957689577895788957989580895818958289583895848958589586895878958889589895908959189592895938959489595895968959789598895998960089601896028960389604896058960689607896088960989610896118961289613896148961589616896178961889619896208962189622896238962489625896268962789628896298963089631896328963389634896358963689637896388963989640896418964289643896448964589646896478964889649896508965189652896538965489655896568965789658896598966089661896628966389664896658966689667896688966989670896718967289673896748967589676896778967889679896808968189682896838968489685896868968789688896898969089691896928969389694896958969689697896988969989700897018970289703897048970589706897078970889709897108971189712897138971489715897168971789718897198972089721897228972389724897258972689727897288972989730897318973289733897348973589736897378973889739897408974189742897438974489745897468974789748897498975089751897528975389754897558975689757897588975989760897618976289763897648976589766897678976889769897708977189772897738977489775897768977789778897798978089781897828978389784897858978689787897888978989790897918979289793897948979589796897978979889799898008980189802898038980489805898068980789808898098981089811898128981389814898158981689817898188981989820898218982289823898248982589826898278982889829898308983189832898338983489835898368983789838898398984089841898428984389844898458984689847898488984989850898518985289853898548985589856898578985889859898608986189862898638986489865898668986789868898698987089871898728987389874898758987689877898788987989880898818988289883898848988589886898878988889889898908989189892898938989489895898968989789898898998990089901899028990389904899058990689907899088990989910899118991289913899148991589916899178991889919899208992189922899238992489925899268992789928899298993089931899328993389934899358993689937899388993989940899418994289943899448994589946899478994889949899508995189952899538995489955899568995789958899598996089961899628996389964899658996689967899688996989970899718997289973899748997589976899778997889979899808998189982899838998489985899868998789988899898999089991899928999389994899958999689997899988999990000900019000290003900049000590006900079000890009900109001190012900139001490015900169001790018900199002090021900229002390024900259002690027900289002990030900319003290033900349003590036900379003890039900409004190042900439004490045900469004790048900499005090051900529005390054900559005690057900589005990060900619006290063900649006590066900679006890069900709007190072900739007490075900769007790078900799008090081900829008390084900859008690087900889008990090900919009290093900949009590096900979009890099901009010190102901039010490105901069010790108901099011090111901129011390114901159011690117901189011990120901219012290123901249012590126901279012890129901309013190132901339013490135901369013790138901399014090141901429014390144901459014690147901489014990150901519015290153901549015590156901579015890159901609016190162901639016490165901669016790168901699017090171901729017390174901759017690177901789017990180901819018290183901849018590186901879018890189901909019190192901939019490195901969019790198901999020090201902029020390204902059020690207902089020990210902119021290213902149021590216902179021890219902209022190222902239022490225902269022790228902299023090231902329023390234902359023690237902389023990240902419024290243902449024590246902479024890249902509025190252902539025490255902569025790258902599026090261902629026390264902659026690267902689026990270902719027290273902749027590276902779027890279902809028190282902839028490285902869028790288902899029090291902929029390294902959029690297902989029990300903019030290303903049030590306903079030890309903109031190312903139031490315903169031790318903199032090321903229032390324903259032690327903289032990330903319033290333903349033590336903379033890339903409034190342903439034490345903469034790348903499035090351903529035390354903559035690357903589035990360903619036290363903649036590366903679036890369903709037190372903739037490375903769037790378903799038090381903829038390384903859038690387903889038990390903919039290393903949039590396903979039890399904009040190402904039040490405904069040790408904099041090411904129041390414904159041690417904189041990420904219042290423904249042590426904279042890429904309043190432904339043490435904369043790438904399044090441904429044390444904459044690447904489044990450904519045290453904549045590456904579045890459904609046190462904639046490465904669046790468904699047090471904729047390474904759047690477904789047990480904819048290483904849048590486904879048890489904909049190492904939049490495904969049790498904999050090501905029050390504905059050690507905089050990510905119051290513905149051590516905179051890519905209052190522905239052490525905269052790528905299053090531905329053390534905359053690537905389053990540905419054290543905449054590546905479054890549905509055190552905539055490555905569055790558905599056090561905629056390564905659056690567905689056990570905719057290573905749057590576905779057890579905809058190582905839058490585905869058790588905899059090591905929059390594905959059690597905989059990600906019060290603906049060590606906079060890609906109061190612906139061490615906169061790618906199062090621906229062390624906259062690627906289062990630906319063290633906349063590636906379063890639906409064190642906439064490645906469064790648906499065090651906529065390654906559065690657906589065990660906619066290663906649066590666906679066890669906709067190672906739067490675906769067790678906799068090681906829068390684906859068690687906889068990690906919069290693906949069590696906979069890699907009070190702907039070490705907069070790708907099071090711907129071390714907159071690717907189071990720907219072290723907249072590726907279072890729907309073190732907339073490735907369073790738907399074090741907429074390744907459074690747907489074990750907519075290753907549075590756907579075890759907609076190762907639076490765907669076790768907699077090771907729077390774907759077690777907789077990780907819078290783907849078590786907879078890789907909079190792907939079490795907969079790798907999080090801908029080390804908059080690807908089080990810908119081290813908149081590816908179081890819908209082190822908239082490825908269082790828908299083090831908329083390834908359083690837908389083990840908419084290843908449084590846908479084890849908509085190852908539085490855908569085790858908599086090861908629086390864908659086690867908689086990870908719087290873908749087590876908779087890879908809088190882908839088490885908869088790888908899089090891908929089390894908959089690897908989089990900909019090290903909049090590906909079090890909909109091190912909139091490915909169091790918909199092090921909229092390924909259092690927909289092990930909319093290933909349093590936909379093890939909409094190942909439094490945909469094790948909499095090951909529095390954909559095690957909589095990960909619096290963909649096590966909679096890969909709097190972909739097490975909769097790978909799098090981909829098390984909859098690987909889098990990909919099290993909949099590996909979099890999910009100191002910039100491005910069100791008910099101091011910129101391014910159101691017910189101991020910219102291023910249102591026910279102891029910309103191032910339103491035910369103791038910399104091041910429104391044910459104691047910489104991050910519105291053910549105591056910579105891059910609106191062910639106491065910669106791068910699107091071910729107391074910759107691077910789107991080910819108291083910849108591086910879108891089910909109191092910939109491095910969109791098910999110091101911029110391104911059110691107911089110991110911119111291113911149111591116911179111891119911209112191122911239112491125911269112791128911299113091131911329113391134911359113691137911389113991140911419114291143911449114591146911479114891149911509115191152911539115491155911569115791158911599116091161911629116391164911659116691167911689116991170911719117291173911749117591176911779117891179911809118191182911839118491185911869118791188911899119091191911929119391194911959119691197911989119991200912019120291203912049120591206912079120891209912109121191212912139121491215912169121791218912199122091221912229122391224912259122691227912289122991230912319123291233912349123591236912379123891239912409124191242912439124491245912469124791248912499125091251912529125391254912559125691257912589125991260912619126291263912649126591266912679126891269912709127191272912739127491275912769127791278912799128091281912829128391284912859128691287912889128991290912919129291293912949129591296912979129891299913009130191302913039130491305913069130791308913099131091311913129131391314913159131691317913189131991320913219132291323913249132591326913279132891329913309133191332913339133491335913369133791338913399134091341913429134391344913459134691347913489134991350913519135291353913549135591356913579135891359913609136191362913639136491365913669136791368913699137091371913729137391374913759137691377913789137991380913819138291383913849138591386913879138891389913909139191392913939139491395913969139791398913999140091401914029140391404914059140691407914089140991410914119141291413914149141591416914179141891419914209142191422914239142491425914269142791428914299143091431914329143391434914359143691437914389143991440914419144291443914449144591446914479144891449914509145191452914539145491455914569145791458914599146091461914629146391464914659146691467914689146991470914719147291473914749147591476914779147891479914809148191482914839148491485914869148791488914899149091491914929149391494914959149691497914989149991500915019150291503915049150591506915079150891509915109151191512915139151491515915169151791518915199152091521915229152391524915259152691527915289152991530915319153291533915349153591536915379153891539915409154191542915439154491545915469154791548915499155091551915529155391554915559155691557915589155991560915619156291563915649156591566915679156891569915709157191572915739157491575915769157791578915799158091581915829158391584915859158691587915889158991590915919159291593915949159591596915979159891599916009160191602916039160491605916069160791608916099161091611916129161391614916159161691617916189161991620916219162291623916249162591626916279162891629916309163191632916339163491635916369163791638916399164091641916429164391644916459164691647916489164991650916519165291653916549165591656916579165891659916609166191662916639166491665916669166791668916699167091671916729167391674916759167691677916789167991680916819168291683916849168591686916879168891689916909169191692916939169491695916969169791698916999170091701917029170391704917059170691707917089170991710917119171291713917149171591716917179171891719917209172191722917239172491725917269172791728917299173091731917329173391734917359173691737917389173991740917419174291743917449174591746917479174891749917509175191752917539175491755917569175791758917599176091761917629176391764917659176691767917689176991770917719177291773917749177591776917779177891779917809178191782917839178491785917869178791788917899179091791917929179391794917959179691797917989179991800918019180291803918049180591806918079180891809918109181191812918139181491815918169181791818918199182091821918229182391824918259182691827918289182991830918319183291833918349183591836918379183891839918409184191842918439184491845918469184791848918499185091851918529185391854918559185691857918589185991860918619186291863918649186591866918679186891869918709187191872918739187491875918769187791878918799188091881918829188391884918859188691887918889188991890918919189291893918949189591896918979189891899919009190191902919039190491905919069190791908919099191091911919129191391914919159191691917919189191991920919219192291923919249192591926919279192891929919309193191932919339193491935919369193791938919399194091941919429194391944919459194691947919489194991950919519195291953919549195591956919579195891959919609196191962919639196491965919669196791968919699197091971919729197391974919759197691977919789197991980919819198291983919849198591986919879198891989919909199191992919939199491995919969199791998919999200092001920029200392004920059200692007920089200992010920119201292013920149201592016920179201892019920209202192022920239202492025920269202792028920299203092031920329203392034920359203692037920389203992040920419204292043920449204592046920479204892049920509205192052920539205492055920569205792058920599206092061920629206392064920659206692067920689206992070920719207292073920749207592076920779207892079920809208192082920839208492085920869208792088920899209092091920929209392094920959209692097920989209992100921019210292103921049210592106921079210892109921109211192112921139211492115921169211792118921199212092121921229212392124921259212692127921289212992130921319213292133921349213592136921379213892139921409214192142921439214492145921469214792148921499215092151921529215392154921559215692157921589215992160921619216292163921649216592166921679216892169921709217192172921739217492175921769217792178921799218092181921829218392184921859218692187921889218992190921919219292193921949219592196921979219892199922009220192202922039220492205922069220792208922099221092211922129221392214922159221692217922189221992220922219222292223922249222592226922279222892229922309223192232922339223492235922369223792238922399224092241922429224392244922459224692247922489224992250922519225292253922549225592256922579225892259922609226192262922639226492265922669226792268922699227092271922729227392274922759227692277922789227992280922819228292283922849228592286922879228892289922909229192292922939229492295922969229792298922999230092301923029230392304923059230692307923089230992310923119231292313923149231592316923179231892319923209232192322923239232492325923269232792328923299233092331923329233392334923359233692337923389233992340923419234292343923449234592346923479234892349923509235192352923539235492355923569235792358923599236092361923629236392364923659236692367923689236992370923719237292373923749237592376923779237892379923809238192382923839238492385923869238792388923899239092391923929239392394923959239692397923989239992400924019240292403924049240592406924079240892409924109241192412924139241492415924169241792418924199242092421924229242392424924259242692427924289242992430924319243292433924349243592436924379243892439924409244192442924439244492445924469244792448924499245092451924529245392454924559245692457924589245992460924619246292463924649246592466924679246892469924709247192472924739247492475924769247792478924799248092481924829248392484924859248692487924889248992490924919249292493924949249592496924979249892499925009250192502925039250492505925069250792508925099251092511925129251392514925159251692517925189251992520925219252292523925249252592526925279252892529925309253192532925339253492535925369253792538925399254092541925429254392544925459254692547925489254992550925519255292553925549255592556925579255892559925609256192562925639256492565925669256792568925699257092571925729257392574925759257692577925789257992580925819258292583925849258592586925879258892589925909259192592925939259492595925969259792598925999260092601926029260392604926059260692607926089260992610926119261292613926149261592616926179261892619926209262192622926239262492625926269262792628926299263092631926329263392634926359263692637926389263992640926419264292643926449264592646926479264892649926509265192652926539265492655926569265792658926599266092661926629266392664926659266692667926689266992670926719267292673926749267592676926779267892679926809268192682926839268492685926869268792688926899269092691926929269392694926959269692697926989269992700927019270292703927049270592706927079270892709927109271192712927139271492715927169271792718927199272092721927229272392724927259272692727927289272992730927319273292733927349273592736927379273892739927409274192742927439274492745927469274792748927499275092751927529275392754927559275692757927589275992760927619276292763927649276592766927679276892769927709277192772927739277492775927769277792778927799278092781927829278392784927859278692787927889278992790927919279292793927949279592796927979279892799928009280192802928039280492805928069280792808928099281092811928129281392814928159281692817928189281992820928219282292823928249282592826928279282892829928309283192832928339283492835928369283792838928399284092841928429284392844928459284692847928489284992850928519285292853928549285592856928579285892859928609286192862928639286492865928669286792868928699287092871928729287392874928759287692877928789287992880928819288292883928849288592886928879288892889928909289192892928939289492895928969289792898928999290092901929029290392904929059290692907929089290992910929119291292913929149291592916929179291892919929209292192922929239292492925929269292792928929299293092931929329293392934929359293692937929389293992940929419294292943929449294592946929479294892949929509295192952929539295492955929569295792958929599296092961929629296392964929659296692967929689296992970929719297292973929749297592976929779297892979929809298192982929839298492985929869298792988929899299092991929929299392994929959299692997929989299993000930019300293003930049300593006930079300893009930109301193012930139301493015930169301793018930199302093021930229302393024930259302693027930289302993030930319303293033930349303593036930379303893039930409304193042930439304493045930469304793048930499305093051930529305393054930559305693057930589305993060930619306293063930649306593066930679306893069930709307193072930739307493075930769307793078930799308093081930829308393084930859308693087930889308993090930919309293093930949309593096930979309893099931009310193102931039310493105931069310793108931099311093111931129311393114931159311693117931189311993120931219312293123931249312593126931279312893129931309313193132931339313493135931369313793138931399314093141931429314393144931459314693147931489314993150931519315293153931549315593156931579315893159931609316193162931639316493165931669316793168931699317093171931729317393174931759317693177931789317993180931819318293183931849318593186931879318893189931909319193192931939319493195931969319793198931999320093201932029320393204932059320693207932089320993210932119321293213932149321593216932179321893219932209322193222932239322493225932269322793228932299323093231932329323393234932359323693237932389323993240932419324293243932449324593246932479324893249932509325193252932539325493255932569325793258932599326093261932629326393264932659326693267932689326993270932719327293273932749327593276932779327893279932809328193282932839328493285932869328793288932899329093291932929329393294932959329693297932989329993300933019330293303933049330593306933079330893309933109331193312933139331493315933169331793318933199332093321933229332393324933259332693327933289332993330933319333293333933349333593336933379333893339933409334193342933439334493345933469334793348933499335093351933529335393354933559335693357933589335993360933619336293363933649336593366933679336893369933709337193372933739337493375933769337793378933799338093381933829338393384933859338693387933889338993390933919339293393933949339593396933979339893399934009340193402934039340493405934069340793408934099341093411934129341393414934159341693417934189341993420934219342293423934249342593426934279342893429934309343193432934339343493435934369343793438934399344093441934429344393444934459344693447934489344993450934519345293453934549345593456934579345893459934609346193462934639346493465934669346793468934699347093471934729347393474934759347693477934789347993480934819348293483934849348593486934879348893489934909349193492934939349493495934969349793498934999350093501935029350393504935059350693507935089350993510935119351293513935149351593516935179351893519935209352193522935239352493525935269352793528935299353093531935329353393534935359353693537935389353993540935419354293543935449354593546935479354893549935509355193552935539355493555935569355793558935599356093561935629356393564935659356693567935689356993570935719357293573935749357593576935779357893579935809358193582935839358493585935869358793588935899359093591935929359393594935959359693597935989359993600936019360293603936049360593606936079360893609936109361193612936139361493615936169361793618936199362093621936229362393624936259362693627936289362993630936319363293633936349363593636936379363893639936409364193642936439364493645936469364793648936499365093651936529365393654936559365693657936589365993660936619366293663936649366593666936679366893669936709367193672936739367493675936769367793678936799368093681936829368393684936859368693687936889368993690936919369293693936949369593696936979369893699937009370193702937039370493705937069370793708937099371093711937129371393714937159371693717937189371993720937219372293723937249372593726937279372893729937309373193732937339373493735937369373793738937399374093741937429374393744937459374693747937489374993750937519375293753937549375593756937579375893759937609376193762937639376493765937669376793768937699377093771937729377393774937759377693777937789377993780937819378293783937849378593786937879378893789937909379193792937939379493795937969379793798937999380093801938029380393804938059380693807938089380993810938119381293813938149381593816938179381893819938209382193822938239382493825938269382793828938299383093831938329383393834938359383693837938389383993840938419384293843938449384593846938479384893849938509385193852938539385493855938569385793858938599386093861938629386393864938659386693867938689386993870938719387293873938749387593876938779387893879938809388193882938839388493885938869388793888938899389093891938929389393894938959389693897938989389993900939019390293903939049390593906939079390893909939109391193912939139391493915939169391793918939199392093921939229392393924939259392693927939289392993930939319393293933939349393593936939379393893939939409394193942939439394493945939469394793948939499395093951939529395393954939559395693957939589395993960939619396293963939649396593966939679396893969939709397193972939739397493975939769397793978939799398093981939829398393984939859398693987939889398993990939919399293993939949399593996939979399893999940009400194002940039400494005940069400794008940099401094011940129401394014940159401694017940189401994020940219402294023940249402594026940279402894029940309403194032940339403494035940369403794038940399404094041940429404394044940459404694047940489404994050940519405294053940549405594056940579405894059940609406194062940639406494065940669406794068940699407094071940729407394074940759407694077940789407994080940819408294083940849408594086940879408894089940909409194092940939409494095940969409794098940999410094101941029410394104941059410694107941089410994110941119411294113941149411594116941179411894119941209412194122941239412494125941269412794128941299413094131941329413394134941359413694137941389413994140941419414294143941449414594146941479414894149941509415194152941539415494155941569415794158941599416094161941629416394164941659416694167941689416994170941719417294173941749417594176941779417894179941809418194182941839418494185941869418794188941899419094191941929419394194941959419694197941989419994200942019420294203942049420594206942079420894209942109421194212942139421494215942169421794218942199422094221942229422394224942259422694227942289422994230942319423294233942349423594236942379423894239942409424194242942439424494245942469424794248942499425094251942529425394254942559425694257942589425994260942619426294263942649426594266942679426894269942709427194272942739427494275942769427794278942799428094281942829428394284942859428694287942889428994290942919429294293942949429594296942979429894299943009430194302943039430494305943069430794308943099431094311943129431394314943159431694317943189431994320943219432294323943249432594326943279432894329943309433194332943339433494335943369433794338943399434094341943429434394344943459434694347943489434994350943519435294353943549435594356943579435894359943609436194362943639436494365943669436794368943699437094371943729437394374943759437694377943789437994380943819438294383943849438594386943879438894389943909439194392943939439494395943969439794398943999440094401944029440394404944059440694407944089440994410944119441294413944149441594416944179441894419944209442194422944239442494425944269442794428944299443094431944329443394434944359443694437944389443994440944419444294443944449444594446944479444894449944509445194452944539445494455944569445794458944599446094461944629446394464944659446694467944689446994470944719447294473944749447594476944779447894479944809448194482944839448494485944869448794488944899449094491944929449394494944959449694497944989449994500945019450294503945049450594506945079450894509945109451194512945139451494515945169451794518945199452094521945229452394524945259452694527945289452994530945319453294533945349453594536945379453894539945409454194542945439454494545945469454794548945499455094551945529455394554945559455694557945589455994560945619456294563945649456594566945679456894569945709457194572945739457494575945769457794578945799458094581945829458394584945859458694587945889458994590945919459294593945949459594596945979459894599946009460194602946039460494605946069460794608946099461094611946129461394614946159461694617946189461994620946219462294623946249462594626946279462894629946309463194632946339463494635946369463794638946399464094641946429464394644946459464694647946489464994650946519465294653946549465594656946579465894659946609466194662946639466494665946669466794668946699467094671946729467394674946759467694677946789467994680946819468294683946849468594686946879468894689946909469194692946939469494695946969469794698946999470094701947029470394704947059470694707947089470994710947119471294713947149471594716947179471894719947209472194722947239472494725947269472794728947299473094731947329473394734947359473694737947389473994740947419474294743947449474594746947479474894749947509475194752947539475494755947569475794758947599476094761947629476394764947659476694767947689476994770947719477294773947749477594776947779477894779947809478194782947839478494785947869478794788947899479094791947929479394794947959479694797947989479994800948019480294803948049480594806948079480894809948109481194812948139481494815948169481794818948199482094821948229482394824948259482694827948289482994830948319483294833948349483594836948379483894839948409484194842948439484494845948469484794848948499485094851948529485394854948559485694857948589485994860948619486294863948649486594866948679486894869948709487194872948739487494875948769487794878948799488094881948829488394884948859488694887948889488994890948919489294893948949489594896948979489894899949009490194902949039490494905949069490794908949099491094911949129491394914949159491694917949189491994920949219492294923949249492594926949279492894929949309493194932949339493494935949369493794938949399494094941949429494394944949459494694947949489494994950949519495294953949549495594956949579495894959949609496194962949639496494965949669496794968949699497094971949729497394974949759497694977949789497994980949819498294983949849498594986949879498894989949909499194992949939499494995949969499794998949999500095001950029500395004950059500695007950089500995010950119501295013950149501595016950179501895019950209502195022950239502495025950269502795028950299503095031950329503395034950359503695037950389503995040950419504295043950449504595046950479504895049950509505195052950539505495055950569505795058950599506095061950629506395064950659506695067950689506995070950719507295073950749507595076950779507895079950809508195082950839508495085950869508795088950899509095091950929509395094950959509695097950989509995100951019510295103951049510595106951079510895109951109511195112951139511495115951169511795118951199512095121951229512395124951259512695127951289512995130951319513295133951349513595136951379513895139951409514195142951439514495145951469514795148951499515095151951529515395154951559515695157951589515995160951619516295163951649516595166951679516895169951709517195172951739517495175951769517795178951799518095181951829518395184951859518695187951889518995190951919519295193951949519595196951979519895199952009520195202952039520495205952069520795208952099521095211952129521395214952159521695217952189521995220952219522295223952249522595226952279522895229952309523195232952339523495235952369523795238952399524095241952429524395244952459524695247952489524995250952519525295253952549525595256952579525895259952609526195262952639526495265952669526795268952699527095271952729527395274952759527695277952789527995280952819528295283952849528595286952879528895289952909529195292952939529495295952969529795298952999530095301953029530395304953059530695307953089530995310953119531295313953149531595316953179531895319953209532195322953239532495325953269532795328953299533095331953329533395334953359533695337953389533995340953419534295343953449534595346953479534895349953509535195352953539535495355953569535795358953599536095361953629536395364953659536695367953689536995370953719537295373953749537595376953779537895379953809538195382953839538495385953869538795388953899539095391953929539395394953959539695397953989539995400954019540295403954049540595406954079540895409954109541195412954139541495415954169541795418954199542095421954229542395424954259542695427954289542995430954319543295433954349543595436954379543895439954409544195442954439544495445954469544795448954499545095451954529545395454954559545695457954589545995460954619546295463954649546595466954679546895469954709547195472954739547495475954769547795478954799548095481954829548395484954859548695487954889548995490954919549295493954949549595496954979549895499955009550195502955039550495505955069550795508955099551095511955129551395514955159551695517955189551995520955219552295523955249552595526955279552895529955309553195532955339553495535955369553795538955399554095541955429554395544955459554695547955489554995550955519555295553955549555595556955579555895559955609556195562955639556495565955669556795568955699557095571955729557395574955759557695577955789557995580955819558295583955849558595586955879558895589955909559195592955939559495595955969559795598955999560095601956029560395604956059560695607956089560995610956119561295613956149561595616956179561895619956209562195622956239562495625956269562795628956299563095631956329563395634956359563695637956389563995640956419564295643956449564595646956479564895649956509565195652956539565495655956569565795658956599566095661956629566395664956659566695667956689566995670956719567295673956749567595676956779567895679956809568195682956839568495685956869568795688956899569095691956929569395694956959569695697956989569995700957019570295703957049570595706957079570895709957109571195712957139571495715957169571795718957199572095721957229572395724957259572695727957289572995730957319573295733957349573595736957379573895739957409574195742957439574495745957469574795748957499575095751957529575395754957559575695757957589575995760957619576295763957649576595766957679576895769957709577195772957739577495775957769577795778957799578095781957829578395784957859578695787957889578995790957919579295793957949579595796957979579895799958009580195802958039580495805958069580795808958099581095811958129581395814958159581695817958189581995820958219582295823958249582595826958279582895829958309583195832958339583495835958369583795838958399584095841958429584395844958459584695847958489584995850958519585295853958549585595856958579585895859958609586195862958639586495865958669586795868958699587095871958729587395874958759587695877958789587995880958819588295883958849588595886958879588895889958909589195892958939589495895958969589795898958999590095901959029590395904959059590695907959089590995910959119591295913959149591595916959179591895919959209592195922959239592495925959269592795928959299593095931959329593395934959359593695937959389593995940959419594295943959449594595946959479594895949959509595195952959539595495955959569595795958959599596095961959629596395964959659596695967959689596995970959719597295973959749597595976959779597895979959809598195982959839598495985959869598795988959899599095991959929599395994959959599695997959989599996000960019600296003960049600596006960079600896009960109601196012960139601496015960169601796018960199602096021960229602396024960259602696027960289602996030960319603296033960349603596036960379603896039960409604196042960439604496045960469604796048960499605096051960529605396054960559605696057960589605996060960619606296063960649606596066960679606896069960709607196072960739607496075960769607796078960799608096081960829608396084960859608696087960889608996090960919609296093960949609596096960979609896099961009610196102961039610496105961069610796108961099611096111961129611396114961159611696117961189611996120961219612296123961249612596126961279612896129961309613196132961339613496135961369613796138961399614096141961429614396144961459614696147961489614996150961519615296153961549615596156961579615896159961609616196162961639616496165961669616796168961699617096171961729617396174961759617696177961789617996180961819618296183961849618596186961879618896189961909619196192961939619496195961969619796198961999620096201962029620396204962059620696207962089620996210962119621296213962149621596216962179621896219962209622196222962239622496225962269622796228962299623096231962329623396234962359623696237962389623996240962419624296243962449624596246962479624896249962509625196252962539625496255962569625796258962599626096261962629626396264962659626696267962689626996270962719627296273962749627596276962779627896279962809628196282962839628496285962869628796288962899629096291962929629396294962959629696297962989629996300963019630296303963049630596306963079630896309963109631196312963139631496315963169631796318963199632096321963229632396324963259632696327963289632996330963319633296333963349633596336963379633896339963409634196342963439634496345963469634796348963499635096351963529635396354963559635696357963589635996360963619636296363963649636596366963679636896369963709637196372963739637496375963769637796378963799638096381963829638396384963859638696387963889638996390963919639296393963949639596396963979639896399964009640196402964039640496405964069640796408964099641096411964129641396414964159641696417964189641996420964219642296423964249642596426964279642896429964309643196432964339643496435964369643796438964399644096441964429644396444964459644696447964489644996450964519645296453964549645596456964579645896459964609646196462964639646496465964669646796468964699647096471964729647396474964759647696477964789647996480964819648296483964849648596486964879648896489964909649196492964939649496495964969649796498964999650096501965029650396504965059650696507965089650996510965119651296513965149651596516965179651896519965209652196522965239652496525965269652796528965299653096531965329653396534965359653696537965389653996540965419654296543965449654596546965479654896549965509655196552965539655496555965569655796558965599656096561965629656396564965659656696567965689656996570965719657296573965749657596576965779657896579965809658196582965839658496585965869658796588965899659096591965929659396594965959659696597965989659996600966019660296603966049660596606966079660896609966109661196612966139661496615966169661796618966199662096621966229662396624966259662696627966289662996630966319663296633966349663596636966379663896639966409664196642966439664496645966469664796648966499665096651966529665396654966559665696657966589665996660966619666296663966649666596666966679666896669966709667196672966739667496675966769667796678966799668096681966829668396684966859668696687966889668996690966919669296693966949669596696966979669896699967009670196702967039670496705967069670796708967099671096711967129671396714967159671696717967189671996720967219672296723967249672596726967279672896729967309673196732967339673496735967369673796738967399674096741967429674396744967459674696747967489674996750967519675296753967549675596756967579675896759967609676196762967639676496765967669676796768967699677096771967729677396774967759677696777967789677996780967819678296783967849678596786967879678896789967909679196792967939679496795967969679796798967999680096801968029680396804968059680696807968089680996810968119681296813968149681596816968179681896819968209682196822968239682496825968269682796828968299683096831968329683396834968359683696837968389683996840968419684296843968449684596846968479684896849968509685196852968539685496855968569685796858968599686096861968629686396864968659686696867968689686996870968719687296873968749687596876968779687896879968809688196882968839688496885968869688796888968899689096891968929689396894968959689696897968989689996900969019690296903969049690596906969079690896909969109691196912969139691496915969169691796918969199692096921969229692396924969259692696927969289692996930969319693296933969349693596936969379693896939969409694196942969439694496945969469694796948969499695096951969529695396954969559695696957969589695996960969619696296963969649696596966969679696896969969709697196972969739697496975969769697796978969799698096981969829698396984969859698696987969889698996990969919699296993969949699596996969979699896999970009700197002970039700497005970069700797008970099701097011970129701397014970159701697017970189701997020970219702297023970249702597026970279702897029970309703197032970339703497035970369703797038970399704097041970429704397044970459704697047970489704997050970519705297053970549705597056970579705897059970609706197062970639706497065970669706797068970699707097071970729707397074970759707697077970789707997080970819708297083970849708597086970879708897089970909709197092970939709497095970969709797098970999710097101971029710397104971059710697107971089710997110971119711297113971149711597116971179711897119971209712197122971239712497125971269712797128971299713097131971329713397134971359713697137971389713997140971419714297143971449714597146971479714897149971509715197152971539715497155971569715797158971599716097161971629716397164971659716697167971689716997170971719717297173971749717597176971779717897179971809718197182971839718497185971869718797188971899719097191971929719397194971959719697197971989719997200972019720297203972049720597206972079720897209972109721197212972139721497215972169721797218972199722097221972229722397224972259722697227972289722997230972319723297233972349723597236972379723897239972409724197242972439724497245972469724797248972499725097251972529725397254972559725697257972589725997260972619726297263972649726597266972679726897269972709727197272972739727497275972769727797278972799728097281972829728397284972859728697287972889728997290972919729297293972949729597296972979729897299973009730197302973039730497305973069730797308973099731097311973129731397314973159731697317973189731997320973219732297323973249732597326973279732897329973309733197332973339733497335973369733797338973399734097341973429734397344973459734697347973489734997350973519735297353973549735597356973579735897359973609736197362973639736497365973669736797368973699737097371973729737397374973759737697377973789737997380973819738297383973849738597386973879738897389973909739197392973939739497395973969739797398973999740097401974029740397404974059740697407974089740997410974119741297413974149741597416974179741897419974209742197422974239742497425974269742797428974299743097431974329743397434974359743697437974389743997440974419744297443974449744597446974479744897449974509745197452974539745497455974569745797458974599746097461974629746397464974659746697467974689746997470974719747297473974749747597476974779747897479974809748197482974839748497485974869748797488974899749097491974929749397494974959749697497974989749997500975019750297503975049750597506975079750897509975109751197512975139751497515975169751797518975199752097521975229752397524975259752697527975289752997530975319753297533975349753597536975379753897539975409754197542975439754497545975469754797548975499755097551975529755397554975559755697557975589755997560
  1. 2009-06-15 Adele Peterson <adele@apple.com>
  2. Reviewed by Darin Adler.
  3. Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
  4. * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  5. When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.
  6. 2009-06-15 Sam Weinig <sam@webkit.org>
  7. Reviewed by Anders Carlsson.
  8. Remove outdated comment.
  9. * bindings/js/JSDOMWindowBase.h:
  10. 2009-06-15 Sam Weinig <sam@webkit.org>
  11. Reviewed by Anders Carlsson.
  12. Bring CustomGetPropertyNames more inline with the other
  13. extended attributes prefixed with Custom, by making it
  14. require a complete implementation.
  15. * bindings/js/JSDOMWindowCustom.cpp:
  16. (WebCore::JSDOMWindow::getPropertyNames):
  17. * bindings/js/JSHistoryCustom.cpp:
  18. (WebCore::JSHistory::getPropertyNames):
  19. * bindings/js/JSLocationCustom.cpp:
  20. (WebCore::JSLocation::getPropertyNames):
  21. * bindings/js/JSStorageCustom.cpp:
  22. (WebCore::JSStorage::getPropertyNames):
  23. * bindings/scripts/CodeGeneratorJS.pm:
  24. 2009-06-15 Sam Weinig <sam@webkit.org>
  25. Reviewed by Anders Carlsson.
  26. Remove commented out ondataunavailable attribute event listener which
  27. has now been removed from HTML 5.
  28. * page/DOMWindow.idl:
  29. 2009-06-15 Sam Weinig <sam@webkit.org>
  30. Reviewed by Anders Carlsson.
  31. Move entire custom implementation of getOwnPropertySlot and put
  32. for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
  33. JSDOMWindowBase.
  34. * bindings/js/JSDOMWindowBase.cpp:
  35. * bindings/js/JSDOMWindowBase.h:
  36. * bindings/js/JSDOMWindowCustom.cpp:
  37. (WebCore::nonCachingStaticFunctionGetter):
  38. (WebCore::childFrameGetter):
  39. (WebCore::indexGetter):
  40. (WebCore::namedItemGetter):
  41. (WebCore::JSDOMWindow::getOwnPropertySlot):
  42. (WebCore::JSDOMWindow::put):
  43. (WebCore::JSDOMWindow::getPropertyAttributes):
  44. * bindings/js/JSDOMWindowCustom.h:
  45. * page/DOMWindow.idl:
  46. 2009-06-15 Jeremy Orlow (jorlow@chromium.org)
  47. Reviewed by Dimitri Glazkov.
  48. https://bugs.webkit.org/show_bug.cgi?id=26356
  49. Define the functions in V8CustomBindings.h. "Forgot" this in my
  50. earlier patch since it wasn't fully upstreamed when I wrote the
  51. patch.
  52. * bindings/v8/custom/V8CustomBinding.h:
  53. 2009-06-15 Andre Boule <aboule@apple.com>
  54. Reviewed by Cameron Zwarich and Dan Bernstein.
  55. - fix <rdar://problem/6967975> crash with NSString drawAtPoint
  56. No test possible because this crash can only occur if the client uses
  57. WebKit text drawing without ever using WebCore text, and DumpRenderTree
  58. cannot do either.
  59. * platform/graphics/FontCache.cpp:
  60. (WebCore::FontCache::purgeInactiveFontData): Null-check
  61. gFontPlatformDataCache.
  62. 2009-06-15 Simon Fraser <simon.fraser@apple.com>
  63. Reviewed by Mark Rowe.
  64. <rdar://problem/6974857>
  65. Define ENABLE_3D_RENDERING when building on 10.6, and move ENABLE_3D_RENDERING
  66. switch from config.h to wtf/Platform.h.
  67. * Configurations/FeatureDefines.xcconfig:
  68. * config.h:
  69. 2009-06-15 Pavel Feldman <pfeldman@chromium.org>
  70. Reviewed by Timothy Hatcher.
  71. Make WebInspector's console evaluation/completion asynchronous.
  72. This way of evaluation allows serializing calls between
  73. InspectorController and its frontend.
  74. https://bugs.webkit.org/show_bug.cgi?id=26350
  75. * inspector/front-end/Console.js:
  76. (WebInspector.Console.prototype.completions):
  77. (WebInspector.Console.prototype._reportCompletions):
  78. (WebInspector.Console.prototype._evalInInspectedWindow):
  79. (WebInspector.Console.prototype._enterKeyPressed.printResult):
  80. (WebInspector.Console.prototype._enterKeyPressed):
  81. * inspector/front-end/DatabaseQueryView.js:
  82. * inspector/front-end/ObjectPropertiesSection.js:
  83. (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
  84. * inspector/front-end/ScriptsPanel.js:
  85. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  86. * inspector/front-end/TextPrompt.js:
  87. (WebInspector.TextPrompt.prototype.complete):
  88. (WebInspector.TextPrompt.prototype._completionsReady):
  89. 2009-06-15 Kevin McCullough <kmccullough@apple.com>
  90. Reviewed by Tim Hatcher.
  91. Reverted previous change as the old behavior was correct for heavy view.
  92. * inspector/front-end/BottomUpProfileDataGridTree.js:
  93. (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
  94. 2009-06-15 Kevin McCullough <kmccullough@apple.com>
  95. Reviewed by Tim Hatcher.
  96. <rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
  97. view (26418)
  98. - Removed code that copied call and time data from it's ancestor.
  99. * inspector/front-end/BottomUpProfileDataGridTree.js:
  100. (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
  101. 2009-06-15 Chris Marrin <cmarrin@apple.com>
  102. Reviewed by Simon Fraser <simon.fraser@apple.com>.
  103. https://bugs.webkit.org/show_bug.cgi?id=26163
  104. Added logic to updateTransitions similar to that in updateKeyframeAnimations
  105. which detects and removes stale transitions.
  106. Test: transitions/cancel-transition.html
  107. * page/animation/CompositeAnimation.cpp:
  108. (WebCore::CompositeAnimation::updateTransitions):
  109. * page/animation/ImplicitAnimation.cpp:
  110. (WebCore::ImplicitAnimation::ImplicitAnimation):
  111. * page/animation/ImplicitAnimation.h:
  112. (WebCore::ImplicitAnimation::active):
  113. (WebCore::ImplicitAnimation::setActive):
  114. 2009-06-15 Dan Bernstein <mitz@apple.com>
  115. Reviewed by Tim Hatcher.
  116. - allow the source code font in the Web Inspector to be customized
  117. * css/view-source.css: Use the default monospace font family and size
  118. for source code.
  119. * inspector/front-end/inspector.css: Use the default monospace font
  120. family and size for console I/O.
  121. 2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
  122. Reviewed by and done with Tor Arne Vestbø.
  123. Fix initialization of uninitialized members in FontFallbackListQt, leading
  124. to random crashes when rendering text.
  125. * platform/graphics/qt/FontFallbackListQt.cpp:
  126. (WebCore::FontFallbackList::FontFallbackList):
  127. (WebCore::FontFallbackList::invalidate):
  128. 2009-06-15 Xan Lopez <xlopez@igalia.com>
  129. Reviewed by Holger Freyther.
  130. https://bugs.webkit.org/show_bug.cgi?id=25895
  131. [Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled
  132. Use computeOffsetInContainerNode instead of the inline
  133. offsetInContainerNode to return the caret offset, since the former
  134. can handle all types of anchoring. Otherwise we'll hit an ASSERT
  135. in some situations in debug builds, and crash.
  136. * editing/gtk/SelectionControllerGtk.cpp:
  137. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  138. 2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
  139. Reviewed by Simon Hausmann.
  140. [Qt] Fix build break
  141. Rename JSONObject to InspectorJSONObject
  142. https://bugs.webkit.org/show_bug.cgi?id=26340
  143. * GNUmakefile.am:
  144. * WebCore.pro:
  145. * WebCore.vcproj/WebCore.vcproj:
  146. * WebCore.xcodeproj/project.pbxproj:
  147. * WebCoreSources.bkl:
  148. * inspector/ConsoleMessage.cpp:
  149. (WebCore::ConsoleMessage::addToConsole):
  150. * inspector/InspectorDOMStorageResource.cpp:
  151. (WebCore::InspectorDOMStorageResource::bind):
  152. * inspector/InspectorDatabaseResource.cpp:
  153. (WebCore::InspectorDatabaseResource::bind):
  154. * inspector/InspectorFrontend.cpp:
  155. (WebCore::InspectorFrontend::newInspectorJSONObject):
  156. (WebCore::InspectorFrontend::addMessageToConsole):
  157. (WebCore::InspectorFrontend::addResource):
  158. (WebCore::InspectorFrontend::updateResource):
  159. (WebCore::InspectorFrontend::addDatabase):
  160. (WebCore::InspectorFrontend::addDOMStorage):
  161. * inspector/InspectorFrontend.h:
  162. * inspector/InspectorJSONObject.cpp: Copied from WebCore/inspector/JSONObject.cpp.
  163. (WebCore::InspectorJSONObject::InspectorJSONObject):
  164. (WebCore::InspectorJSONObject::set):
  165. (WebCore::InspectorJSONObject::scriptObject):
  166. (WebCore::InspectorJSONObject::createNew):
  167. * inspector/InspectorJSONObject.h: Copied from WebCore/inspector/JSONObject.h.
  168. * inspector/InspectorResource.cpp:
  169. (WebCore::populateHeadersObject):
  170. (WebCore::InspectorResource::createScriptObject):
  171. (WebCore::InspectorResource::updateScriptObject):
  172. * inspector/JSONObject.cpp: Removed.
  173. * inspector/JSONObject.h: Removed.
  174. 2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  175. Reviewed by Simon Hausmann.
  176. Refactor handling of options in the build-webkit script
  177. Options are now defined in one place, and then reused when creating
  178. the usage help text, the arguments to GetOptions(), and when passing
  179. the options on to the underlying port-dependent build systems.
  180. This allows the Qt port to read the defaults for the options from the
  181. pro file (dynamically), and to pass the options on to qmake at build.
  182. * WebCore.pro:
  183. 2009-06-14 chris fleizach <cfleizach@apple.com>
  184. Reviewed by Darin Adler.
  185. Bug 26399: REGRESSION: java applet accessibility broken
  186. https://bugs.webkit.org/show_bug.cgi?id=26399
  187. Accessibility could not access the elements in a java applet
  188. when going down the AX hierarchy.
  189. Test: DRT does not allow java applets so add a manual test:
  190. manual-tests/accessibility/java-applet.html
  191. * accessibility/AccessibilityRenderObject.cpp:
  192. (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  193. * accessibility/mac/AccessibilityObjectMac.mm:
  194. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  195. * accessibility/mac/AccessibilityObjectWrapper.mm:
  196. (-[AccessibilityObjectWrapper attachmentView]):
  197. * manual-tests/accessibility: Added.
  198. * manual-tests/accessibility/java-applet.html: Added.
  199. * manual-tests/accessibility/resources: Added.
  200. * manual-tests/accessibility/resources/AppletTest.class: Added.
  201. * manual-tests/accessibility/resources/AppletTest.java: Added.
  202. (AppletTest):
  203. (AppletTest.init):
  204. 2009-06-14 Sam Weinig <sam@webkit.org>
  205. Reviewed by Cameron Zwarich.
  206. Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
  207. to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
  208. their functionality (customGetOwnPropertySlot and customPut member functions have
  209. been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
  210. and CustomPutFunction have been repurposed to mean a complete custom implementation
  211. of the function which is inline with other extended attributes prefixed with Custom.
  212. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  213. (WebCore::JSCSSStyleDeclaration::putDelegate):
  214. * bindings/js/JSDOMWindowCustom.h:
  215. (WebCore::JSDOMWindow::getOwnPropertySlotDelegate):
  216. (WebCore::JSDOMWindow::putDelegate):
  217. * bindings/js/JSHTMLAppletElementCustom.cpp:
  218. (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
  219. (WebCore::JSHTMLAppletElement::putDelegate):
  220. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  221. (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
  222. (WebCore::JSHTMLEmbedElement::putDelegate):
  223. * bindings/js/JSHTMLObjectElementCustom.cpp:
  224. (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
  225. (WebCore::JSHTMLObjectElement::putDelegate):
  226. * bindings/js/JSHistoryCustom.cpp:
  227. (WebCore::JSHistory::getOwnPropertySlotDelegate):
  228. (WebCore::JSHistory::putDelegate):
  229. * bindings/js/JSLocationCustom.cpp:
  230. (WebCore::JSLocation::getOwnPropertySlotDelegate):
  231. (WebCore::JSLocation::putDelegate):
  232. (WebCore::JSLocationPrototype::putDelegate):
  233. * bindings/js/JSStorageCustom.cpp:
  234. (WebCore::JSStorage::putDelegate):
  235. * bindings/js/JSWorkerContextCustom.cpp:
  236. (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
  237. * bindings/scripts/CodeGeneratorJS.pm:
  238. * css/CSSStyleDeclaration.idl:
  239. * html/HTMLAppletElement.idl:
  240. * html/HTMLEmbedElement.idl:
  241. * html/HTMLObjectElement.idl:
  242. * page/DOMWindow.idl:
  243. * page/History.idl:
  244. * page/Location.idl:
  245. * storage/Storage.idl:
  246. * workers/WorkerContext.idl:
  247. 2009-06-14 Dan Bernstein <mitz@apple.com>
  248. Reviewed by Darin Adler.
  249. - fix https://bugs.webkit.org/show_bug.cgi?id=26395
  250. <rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after
  251. going back/forward to page with focused text field
  252. No test, since the back/forward cache is disabled in DumpRenderTree
  253. * loader/FrameLoader.cpp:
  254. (WebCore::FrameLoader::open): Added a call to CachedPage::restore(),
  255. which was removed in r40870.
  256. 2009-06-14 Darin Adler <darin@apple.com>
  257. * editing/TextIterator.cpp:
  258. (WebCore::BitStack::push): Use named constant instead of hardcoded numbers.
  259. (WebCore::BitStack::top): Ditto.
  260. 2009-06-14 Darin Adler <darin@apple.com>
  261. Reviewed by Dan Bernstein.
  262. Bug 26364: Search can find text that's hidden by overflow:hidden
  263. https://bugs.webkit.org/show_bug.cgi?id=26364
  264. <rdar://problem/6952081>
  265. Test: fast/text/find-hidden-text.html
  266. * editing/TextIterator.cpp:
  267. (WebCore::BitStack::BitStack): Added.
  268. (WebCore::BitStack::push): Added.
  269. (WebCore::BitStack::pop): Added.
  270. (WebCore::BitStack::top): Added.
  271. (WebCore::BitStack::size): Added.
  272. (WebCore::parentOrShadowParent): Added. Helper function for walking up
  273. the parent node chain, crossing shadow tree boundaries.
  274. (WebCore::depthCrossingShadowBoundaries): Added for use in assertions.
  275. Counts the depth of a node using the parentOrShadowParent function.
  276. (WebCore::fullyClipsContents): Added. Returns true for an element that
  277. fully clips its contents, currently defined as a box that has zero width
  278. or height and hides overflow. We can add other cases here later.
  279. (WebCore::ignoresContainerClip): Added. Returns true for an element that
  280. ignores its container clip, currently defined as an element with absolute
  281. or fixed positioning.
  282. (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating
  283. if the node in question fully clips its contents.
  284. (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of
  285. a node. Used when creating an iterator.
  286. (WebCore::TextIterator::TextIterator): Removed code to initialize
  287. m_inShadowContent. Call setUpFullyClippedStack.
  288. (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving
  289. up to a parent node, and also one extra time when moving to a sibling node.
  290. Call pushFullyClippedState when moving to a child node, or when moving to a
  291. sibling node after the aforementioned call to pop.
  292. (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped.
  293. (WebCore::TextIterator::handleReplacedElement): Ditto.
  294. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
  295. Call setUpFullyClippedStack.
  296. (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as
  297. TextIterator::advance above.
  298. * editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both
  299. TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.
  300. 2009-06-14 David Hyatt <hyatt@apple.com>
  301. Reviewed by Simon Fraser.
  302. https://bugs.webkit.org/show_bug.cgi?id=26362
  303. Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
  304. Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
  305. changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.
  306. * dom/Element.cpp:
  307. (WebCore::Element::recalcStyle):
  308. * dom/Node.cpp:
  309. (WebCore::Node::diff):
  310. * rendering/style/RenderStyle.h:
  311. (WebCore::InheritedFlags::setChildIndex):
  312. 2009-06-14 David Hyatt <hyatt@apple.com>
  313. Reviewed by Dan Bernstein.
  314. Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
  315. copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
  316. inside the FontFallbackList.
  317. * WebCore.base.exp:
  318. * platform/graphics/Font.cpp:
  319. (WebCore::Font::Font):
  320. (WebCore::Font::operator=):
  321. (WebCore::Font::primaryFont):
  322. (WebCore::Font::update):
  323. * platform/graphics/Font.h:
  324. (WebCore::Font::setWordSpacing):
  325. (WebCore::Font::setLetterSpacing):
  326. * platform/graphics/FontFallbackList.cpp:
  327. (WebCore::FontFallbackList::FontFallbackList):
  328. (WebCore::FontFallbackList::invalidate):
  329. (WebCore::FontFallbackList::determinePitch):
  330. * platform/graphics/FontFallbackList.h:
  331. (WebCore::FontFallbackList::primarySimpleFontData):
  332. (WebCore::FontFallbackList::primaryFontData):
  333. * platform/graphics/FontFastPath.cpp:
  334. (WebCore::Font::glyphDataForCharacter):
  335. 2009-06-14 Simon Fraser <simon.fraser@apple.com>
  336. Reviewed by Darin Adler
  337. https://bugs.webkit.org/show_bug.cgi?id=26362
  338. Fix an issue noted on quirksmode.com where dynamically adding siblings does not
  339. update :nth-child style correctly.
  340. Test: fast/css/nth-child-dynamic.html
  341. * dom/Node.h:
  342. Change diff() to take const RenderStyle*
  343. * dom/Node.cpp:
  344. (WebCore::Node::diff):
  345. When comparing styles to decide whether to detach and reattach, we
  346. need to look at whether the pseudoclass-related data in the style
  347. changed (since RenderStyle::diff doesn't check this).
  348. * rendering/style/RenderStyle.cpp:
  349. (WebCore::RenderStyle::getCachedPseudoStyle):
  350. (WebCore::RenderStyle::inheritedNotEqual):
  351. Make these methods const.
  352. * rendering/style/RenderStyle.h:
  353. (WebCore::InheritedFlags::styleType):
  354. (WebCore::InheritedFlags::pseudoClassStateEquivalent):
  355. Make methods const.
  356. Add new method that compares the pseudoclass-related members.
  357. 2009-06-13 Peter Kasting <pkasting@google.com>
  358. Reviewed by Kevin Ollivier.
  359. https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
  360. Write a wx implementation so the wx port can compile. For now this is
  361. mostly a copy of the Cairo port, but in the future it can be changed to
  362. use a wxBitmap as the storage type everywhere (just as Cairo can
  363. probably be changed).
  364. Also ASSERT for any other ports who call getAddr() (I don't think there
  365. are any, and besides, they probably won't link, but this doesn't hurt).
  366. Also fixes a dumb Cairo build bustage typo introduced in part ten.
  367. * platform/graphics/wx/ImageSourceWx.cpp:
  368. (WebCore::ImageSource::createFrameAtIndex):
  369. * platform/image-decoders/ImageDecoder.h:
  370. (WebCore::RGBA32Buffer::getAddr):
  371. * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
  372. (WebCore::RGBA32Buffer::setStatus):
  373. * platform/image-decoders/wx: Added.
  374. * platform/image-decoders/wx/ImageDecoderWx.cpp: Added.
  375. (WebCore::RGBA32Buffer::RGBA32Buffer):
  376. (WebCore::RGBA32Buffer::clear):
  377. (WebCore::RGBA32Buffer::zeroFill):
  378. (WebCore::RGBA32Buffer::copyBitmapData):
  379. (WebCore::RGBA32Buffer::setSize):
  380. (WebCore::RGBA32Buffer::asNewNativeImage):
  381. (WebCore::RGBA32Buffer::hasAlpha):
  382. (WebCore::RGBA32Buffer::setHasAlpha):
  383. (WebCore::RGBA32Buffer::setStatus):
  384. (WebCore::RGBA32Buffer::operator=):
  385. (WebCore::RGBA32Buffer::width):
  386. (WebCore::RGBA32Buffer::height):
  387. * webcore-wx.bkl:
  388. 2009-06-13 Stephen White <senorblanco@chromium.org>
  389. Reviewed by Dimitri Glazkov. Landed by Adam Barth.
  390. https://bugs.webkit.org/show_bug.cgi?id=26320
  391. Some minor code cleanup for chromium/skia port. Removed #ifdef's
  392. around skia API changes, since the new version seems solid and we
  393. don't need to go back. Added some comments to
  394. TransparencyWin.h, as requested by Brett in
  395. https://bugs.webkit.org/show_bug.cgi?id=24584.
  396. * platform/graphics/chromium/FontCacheLinux.cpp:
  397. (WebCore::FontCache::createFontPlatformData):
  398. * platform/graphics/chromium/TransparencyWin.h:
  399. * platform/graphics/skia/PathSkia.cpp:
  400. (WebCore::Path::boundingRect):
  401. (WebCore::boundingBoxForCurrentStroke):
  402. * platform/graphics/skia/SkiaUtils.cpp:
  403. (WebCore::SkPathContainsPoint):
  404. 2009-06-13 Adam Barth <abarth@webkit.org>
  405. Reviewed by Darin Fisher.
  406. https://bugs.webkit.org/show_bug.cgi?id=24492
  407. Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
  408. FrameLoader to SecurityOrigin.
  409. * WebCore.base.exp:
  410. * loader/FrameLoader.cpp:
  411. (WebCore::FrameLoader::loadFrameRequest):
  412. (WebCore::FrameLoader::canLoad):
  413. * loader/FrameLoader.h:
  414. * page/SecurityOrigin.cpp:
  415. (WebCore::localSchemes):
  416. (WebCore::noAccessSchemes):
  417. (WebCore::SecurityOrigin::SecurityOrigin):
  418. (WebCore::SecurityOrigin::isLocal):
  419. (WebCore::SecurityOrigin::registerURLSchemeAsLocal):
  420. (WebCore::SecurityOrigin::shouldTreatURLAsLocal):
  421. (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal):
  422. (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
  423. (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
  424. * page/SecurityOrigin.h:
  425. 2009-06-13 Ben Murdoch <benm@google.com>
  426. Reviewed by David Kilzer. Landed by Adam Barth.
  427. https://bugs.webkit.org/show_bug.cgi?id=26189
  428. This patch changes the way PageGroups create their localStorage
  429. objects. Rather than creating a local storage object for the page group
  430. when a page is added to the group, the local storage object is now
  431. created lazily when the local storage object is requested by the
  432. DOMWindow.
  433. * page/PageGroup.cpp:
  434. (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created.
  435. (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group.
  436. (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
  437. * page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
  438. 2009-06-13 Ben Murdoch <benm@google.com>
  439. Reviewed by Eric Seidel. Landed by Adam Barth.
  440. https://bugs.webkit.org/show_bug.cgi?id=26189
  441. Add ENABLE(DOM_STORAGE) guards to the dom storage source files.
  442. * storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
  443. * storage/LocalStorage.h: Ditto
  444. * storage/LocalStorageArea.cpp: Ditto
  445. * storage/LocalStorageArea.h: Ditto
  446. * storage/LocalStorageTask.cpp: Ditto
  447. * storage/LocalStorageTask.h: Ditto
  448. * storage/LocalStorageThread.cpp: Ditto
  449. * storage/LocalStorageThread.h: Ditto
  450. * storage/SessionStorage.cpp: Ditto
  451. * storage/SessionStorage.h: Ditto
  452. * storage/SessionStorageArea.cpp: Ditto
  453. * storage/SessionStorageArea.h: Ditto
  454. * storage/Storage.cpp: Ditto
  455. * storage/Storage.h: Ditto
  456. * storage/StorageArea.cpp: Ditto
  457. * storage/StorageArea.h: Ditto
  458. * storage/StorageEvent.cpp: Ditto
  459. * storage/StorageEvent.h: Ditto
  460. * storage/StorageMap.cpp: Ditto
  461. * storage/StorageMap.h: Ditto
  462. * storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
  463. * storage/Storage.idl: Ditto
  464. 2009-06-13 Peter Kasting <pkasting@google.com>
  465. Reviewed by Eric Seidel.
  466. https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
  467. Make Skia use the root directory ImageDecoder.h and factor out most
  468. Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
  469. style violations in ImageDecoderCairo.cpp. This is the last patch for
  470. this bug, everything beyond this is an enhancement rather than
  471. unforking.
  472. * platform/image-decoders/ImageDecoder.h:
  473. (WebCore::RGBA32Buffer::getAddr):
  474. * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
  475. (WebCore::RGBA32Buffer::hasAlpha):
  476. (WebCore::RGBA32Buffer::setHasAlpha):
  477. (WebCore::setStatus):
  478. * platform/image-decoders/skia/ImageDecoder.h: Removed.
  479. * platform/image-decoders/skia/ImageDecoderSkia.cpp: Added.
  480. (WebCore::RGBA32Buffer::RGBA32Buffer):
  481. (WebCore::RGBA32Buffer::clear):
  482. (WebCore::RGBA32Buffer::zeroFill):
  483. (WebCore::RGBA32Buffer::copyBitmapData):
  484. (WebCore::RGBA32Buffer::setSize):
  485. (WebCore::RGBA32Buffer::asNewNativeImage):
  486. (WebCore::RGBA32Buffer::hasAlpha):
  487. (WebCore::RGBA32Buffer::setHasAlpha):
  488. (WebCore::RGBA32Buffer::setStatus):
  489. (WebCore::RGBA32Buffer::operator=):
  490. (WebCore::RGBA32Buffer::width):
  491. (WebCore::RGBA32Buffer::height):
  492. 2009-06-13 Victor Wang <victorw@chromium.org>
  493. Reviewed by Eric Seidel. Landed by Adam Barth.
  494. https://bugs.webkit.org/show_bug.cgi?id=26333
  495. Alert during a dragenter event handler will crash the renderer
  496. This crash is casued by calling NULL pointer m_documentUnderMouse in
  497. DragController::tryDocumentDrag()
  498. tryDHTMLDrag fires dragenter event. The event listener that listens
  499. to this event may create a nested message loop (open a modal dialog),
  500. which could process dragleave event and reset m_documentUnderMouse in
  501. dragExited.
  502. Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
  503. do not continue if the pointer has been set to NULL.
  504. Test: DRT does not show alerts so add a manual test:
  505. manual-tests/drag-enter-alert.html
  506. * manual-tests/drag-enter-alert.html: Added.
  507. * manual-tests/resources/drag-image.png: Added.
  508. * page/DragController.cpp:
  509. (WebCore::DragController::tryDocumentDrag):
  510. 2009-06-13 Nate Chapin <japhet@google.com>
  511. Reviewed by Dimitri Glazkov. Landed by Adam Barth.
  512. Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.
  513. https://bugs.webkit.org/show_bug.cgi?id=26227
  514. * bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added.
  515. (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org.
  516. (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org.
  517. (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
  518. * bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
  519. * bindings/v8/custom/V8DocumentCustom.cpp: Updated includes.
  520. (WebCore::CALLBACK_FUNC_DECL): Updated class name.
  521. 2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  522. Reviewed by Mark Rowe. Landed by Adam Barth.
  523. Remove obsolete declarations for old Symbian port
  524. https://bugs.webkit.org/show_bug.cgi?id=26339
  525. * platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
  526. * platform/graphics/FloatRect.h: Ditto.
  527. * platform/graphics/IntPoint.h: Ditto.
  528. * platform/graphics/IntRect.h: Ditto.
  529. * platform/graphics/IntSize.h: Ditto.
  530. 2009-06-13 Dirk Schulze <krit@webkit.org>
  531. Reviewed by Eric Seidel.
  532. Added subRegion calculation to SVG filter. Every filter effect is
  533. clipped to the filter region (according to the spec). This makes
  534. ImageBuffers for filter effects smaller and we just need to take
  535. care about big filter regions.
  536. SVGFEImage needed a correction, to avoid an ASSERT. The two filter
  537. effects feOffset and feFlood help to test the new subRegion code.
  538. Tests: svg/filters/subRegion-one-effect.svg
  539. svg/filters/subRegion-two-effects.svg
  540. * platform/graphics/filters/FEBlend.h:
  541. (WebCore::FEBlend::uniteChildEffectSubregions):
  542. * platform/graphics/filters/FEColorMatrix.h:
  543. (WebCore::FEColorMatrix::uniteChildEffectSubregions):
  544. * platform/graphics/filters/FEComponentTransfer.h:
  545. (WebCore::FEComponentTransfer::uniteChildEffectSubregions):
  546. * platform/graphics/filters/FEComposite.h:
  547. (WebCore::FEComposite::uniteChildEffectSubregions):
  548. * platform/graphics/filters/Filter.h:
  549. (WebCore::Filter::setSourceImage):
  550. (WebCore::Filter::sourceImage):
  551. * platform/graphics/filters/FilterEffect.cpp:
  552. (WebCore::FilterEffect::FilterEffect):
  553. (WebCore::FilterEffect::calculateUnionOfChildEffectSubregions):
  554. (WebCore::FilterEffect::calculateEffectRect):
  555. * platform/graphics/filters/FilterEffect.h:
  556. (WebCore::FilterEffect::setUnionOfChildEffectSubregions):
  557. (WebCore::FilterEffect::unionOfChildEffectSubregions):
  558. (WebCore::FilterEffect::hasX):
  559. (WebCore::FilterEffect::setHasX):
  560. (WebCore::FilterEffect::hasY):
  561. (WebCore::FilterEffect::setHasY):
  562. (WebCore::FilterEffect::hasWidth):
  563. (WebCore::FilterEffect::setHasWidth):
  564. (WebCore::FilterEffect::hasHeight):
  565. (WebCore::FilterEffect::setHasHeight):
  566. (WebCore::FilterEffect::setEffectBuffer):
  567. (WebCore::FilterEffect::uniteChildEffectSubregions):
  568. * platform/graphics/filters/SourceAlpha.h:
  569. (WebCore::SourceAlpha::calculateEffectRect):
  570. * platform/graphics/filters/SourceGraphic.cpp:
  571. (WebCore::SourceGraphic::calculateEffectRect):
  572. (WebCore::SourceGraphic::apply):
  573. * platform/graphics/filters/SourceGraphic.h:
  574. * rendering/SVGRenderSupport.cpp:
  575. (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  576. (WebCore::SVGRenderBase::finishRenderSVGContent):
  577. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  578. (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  579. * svg/graphics/SVGResourceFilter.cpp:
  580. (WebCore::SVGResourceFilter::prepareFilter):
  581. (WebCore::SVGResourceFilter::applyFilter):
  582. * svg/graphics/SVGResourceFilter.h:
  583. * svg/graphics/filters/SVGFEConvolveMatrix.h:
  584. (WebCore::FEConvolveMatrix::uniteChildEffectSubregions):
  585. * svg/graphics/filters/SVGFEDiffuseLighting.h:
  586. (WebCore::FEDiffuseLighting::uniteChildEffectSubregions):
  587. * svg/graphics/filters/SVGFEDisplacementMap.h:
  588. (WebCore::FEDisplacementMap::uniteChildEffectSubregions):
  589. * svg/graphics/filters/SVGFEFlood.cpp:
  590. (WebCore::FEFlood::apply):
  591. * svg/graphics/filters/SVGFEGaussianBlur.h:
  592. (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
  593. * svg/graphics/filters/SVGFEImage.cpp:
  594. (WebCore::FEImage::FEImage):
  595. * svg/graphics/filters/SVGFEImage.h:
  596. * svg/graphics/filters/SVGFEMerge.cpp:
  597. (WebCore::FEMerge::uniteEffectRect):
  598. * svg/graphics/filters/SVGFEMerge.h:
  599. * svg/graphics/filters/SVGFEMorphology.h:
  600. (WebCore::FEMorphology::uniteChildEffectSubregions):
  601. * svg/graphics/filters/SVGFEOffset.cpp:
  602. (WebCore::FEOffset::apply):
  603. * svg/graphics/filters/SVGFEOffset.h:
  604. (WebCore::FEOffset::uniteChildEffectSubregions):
  605. * svg/graphics/filters/SVGFESpecularLighting.h:
  606. (WebCore::FESpecularLighting::uniteEffectRect):
  607. * svg/graphics/filters/SVGFETile.cpp:
  608. (WebCore::FETile::uniteChildEffectSubregions):
  609. * svg/graphics/filters/SVGFETile.h:
  610. * svg/graphics/filters/SVGFilter.cpp:
  611. (WebCore::SVGFilter::calculateEffectSubRegion):
  612. * svg/graphics/filters/SVGFilter.h:
  613. (WebCore::SVGFilter::effectBoundingBoxMode):
  614. (WebCore::SVGFilter::filterRegion):
  615. (WebCore::SVGFilter::sourceImageRect):
  616. 2009-06-13 Peter Kasting <pkasting@google.com>
  617. Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.
  618. * platform/image-decoders/ImageDecoder.h:
  619. (WebCore::RGBA32Buffer::copyRowNTimes):
  620. * platform/image-decoders/bmp/BMPImageReader.cpp:
  621. (WebCore::BMPImageReader::processBitmasks):
  622. 2009-06-13 Peter Kasting <pkasting@google.com>
  623. GTK bustage fix. "inline" is handled differently by different compilers.
  624. * platform/image-decoders/ImageDecoder.h:
  625. (WebCore::RGBA32Buffer::getAddr):
  626. * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
  627. 2009-06-13 Peter Kasting <pkasting@google.com>
  628. Reviewed by Eric Seidel.
  629. https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
  630. Factor Cairo-specific implementation out of ImageDecoder.h into
  631. ImageDecoderCairo.cpp. Add some comments to functions declared
  632. in ImageDecoder.h.
  633. * GNUmakefile.am:
  634. * WebCore.vcproj/WebCore.vcproj:
  635. * platform/image-decoders/ImageDecoder.h:
  636. * platform/image-decoders/cairo: Added.
  637. * platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added.
  638. (WebCore::RGBA32Buffer::RGBA32Buffer):
  639. (WebCore::RGBA32Buffer::clear):
  640. (WebCore::RGBA32Buffer::zeroFill):
  641. (WebCore::RGBA32Buffer::copyBitmapData):
  642. (WebCore::RGBA32Buffer::setSize):
  643. (WebCore::RGBA32Buffer::asNewNativeImage):
  644. (WebCore::RGBA32Buffer::hasAlpha):
  645. (WebCore::RGBA32Buffer::setHasAlpha):
  646. (WebCore::RGBA32Buffer::operator=):
  647. (WebCore::RGBA32Buffer::width):
  648. (WebCore::RGBA32Buffer::height):
  649. (WebCore::RGBA32Buffer::getAddr):
  650. 2009-06-13 David Hyatt <hyatt@apple.com>
  651. Reviewed by Darin Adler.
  652. Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
  653. assertion removal and some unintentional whitespace changes.
  654. * platform/text/BidiResolver.h:
  655. (WebCore::MidpointState::reset):
  656. * rendering/RenderBlock.h:
  657. * rendering/bidi.cpp:
  658. (WebCore::BidiRun::operator delete):
  659. (WebCore::chopMidpointsAt):
  660. (WebCore::checkMidpoints):
  661. (WebCore::addMidpoint):
  662. (WebCore::appendRunsForObject):
  663. (WebCore::RenderBlock::findNextLineBreak):
  664. 2009-06-12 David Hyatt <hyatt@apple.com>
  665. Reviewed by Dan Bernstein.
  666. https://bugs.webkit.org/show_bug.cgi?id=26367
  667. Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
  668. midpoint information. Add the remaining global variables as arguments passed down through functions
  669. as needed.
  670. * platform/text/BidiResolver.h:
  671. (WebCore::MidpointState::MidpointState):
  672. (WebCore::MidpointState::reset):
  673. (WebCore::BidiResolver::midpointState):
  674. * rendering/RenderBlock.h:
  675. * rendering/bidi.cpp:
  676. (WebCore::BidiRun::operator delete):
  677. (WebCore::chopMidpointsAt):
  678. (WebCore::checkMidpoints):
  679. (WebCore::addMidpoint):
  680. (WebCore::appendRunsForObject):
  681. (WebCore::RenderBlock::bidiReorderLine):
  682. (WebCore::RenderBlock::layoutInlineChildren):
  683. (WebCore::RenderBlock::determineStartPosition):
  684. (WebCore::skipNonBreakingSpace):
  685. (WebCore::shouldCollapseWhiteSpace):
  686. (WebCore::requiresLineBox):
  687. (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
  688. (WebCore::RenderBlock::skipTrailingWhitespace):
  689. (WebCore::RenderBlock::skipLeadingWhitespace):
  690. (WebCore::shouldSkipWhitespaceAfterStartObject):
  691. (WebCore::RenderBlock::findNextLineBreak):
  692. 2009-06-12 Holger Hans Peter Freyther <zecke@selfish.org>
  693. Build fix for Qt. After recent ImageDeocder.h changes. I want
  694. the original change to be backed out as the whole Skia merging
  695. is going in the wrong direction. The discussion will happen in
  696. the bugtracker.
  697. https://bugs.webkit.org/show_bug.cgi?id=25709.
  698. * platform/image-decoders/ImageDecoder.h:
  699. 2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
  700. Gtk build fix: include cstdio so we can use sscanf
  701. Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
  702. Suggested by Brent Fulgham
  703. * platform/image-decoders/xbm/XBMImageDecoder.cpp:
  704. (WebCore::XBMImageDecoder::decodeDatum):
  705. 2009-06-12 Peter Kasting <pkasting@google.com>
  706. Yet another Skia bustage fix.
  707. * platform/image-decoders/skia/ImageDecoder.h:
  708. (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
  709. 2009-06-12 Peter Kasting <pkasting@google.com>
  710. Fix remaining Cairo build bustage from
  711. https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
  712. Vector<char> in place of std::string.
  713. * platform/image-decoders/xbm/XBMImageDecoder.cpp:
  714. (WebCore::XBMImageDecoder::setData):
  715. (WebCore::XBMImageDecoder::decodeHeader):
  716. (WebCore::XBMImageDecoder::decodeDatum):
  717. * platform/image-decoders/xbm/XBMImageDecoder.h:
  718. 2009-06-12 David Levin <levin@chromium.org>
  719. Reviewed by Darin Adler.
  720. UString shouldn't create sharedBuffer for SmallStrings.
  721. https://bugs.webkit.org/show_bug.cgi?id=26347
  722. Change the call to use the method UString::Rep::sharedBuffer due
  723. to changes in UString.
  724. No noticable change in behavior, so no test.
  725. * platform/text/StringImpl.cpp:
  726. (WebCore::StringImpl::create):
  727. 2009-06-12 Peter Kasting <pkasting@google.com>
  728. Fix Chromium and some of Cairo build bustage, fallout from
  729. https://bugs.webkit.org/show_bug.cgi?id=25709 changes.
  730. * WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
  731. * platform/image-decoders/skia/ImageDecoder.h:
  732. (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
  733. 2009-06-12 Simon Fraser <simon.fraser@apple.com>
  734. Reviewed by Dan Bernstein
  735. https://bugs.webkit.org/show_bug.cgi?id=26095
  736. Fix crash when a renderer for an anonymous node is composited
  737. by null-checking renderer()->node().
  738. Test: compositing/generated-content.html
  739. * rendering/RenderLayerBacking.cpp:
  740. (WebCore::RenderLayerBacking::createGraphicsLayer):
  741. (WebCore::RenderLayerBacking::rendererHasBackground):
  742. (WebCore::RenderLayerBacking::rendererBackgroundColor):
  743. (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
  744. (WebCore::RenderLayerBacking::paintIntoLayer):
  745. 2009-06-12 Simon Fraser <simon.fraser@apple.com>
  746. Fix build when ACCELERATED_COMPOSITING is defined.
  747. * loader/EmptyClients.h:
  748. (WebCore::EmptyChromeClient::attachRootGraphicsLayer):
  749. (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization):
  750. (WebCore::EmptyChromeClient::scheduleViewUpdate):
  751. Add stubs for the compositing-related ChromeClient methods.
  752. * rendering/RenderLayerCompositor.cpp:
  753. (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  754. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  755. docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which
  756. matches what is used to size the WebHTMLView.
  757. 2009-06-12 jorlow <jorlow@chromium.org>
  758. Reviewed by David Levin.
  759. https://bugs.webkit.org/show_bug.cgi?id=26356
  760. http://crbug.com/14006
  761. Create custom bindings for v8. The rest of these files are still
  762. forked (so the review is happening on the chromium review site).
  763. These bindings have been tested on a hacked up Chromium instance
  764. (also running --single-process) and Android.
  765. * bindings/v8/custom/V8StorageCustom.cpp: Added.
  766. 2009-06-12 Dmitry Titov <dimich@chromium.org>
  767. Reviewed by David Levin.
  768. https://bugs.webkit.org/show_bug.cgi?id=26359
  769. [v8] Add XMLHttpRequest to WorkerContextExecutionProxy.
  770. * bindings/v8/WorkerContextExecutionProxy.cpp:
  771. (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types.
  772. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
  773. * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
  774. 2009-06-12 Peter Kasting <pkasting@google.com>
  775. Reviewed by Eric Seidel.
  776. https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
  777. Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
  778. all the decoders from skia/ since they are now just mirrors of the Cairo
  779. ones.
  780. * GNUmakefile.am:
  781. * WebCore.vcproj/WebCore.vcproj:
  782. * WebCoreSources.bkl:
  783. * platform/graphics/cairo/ImageSourceCairo.cpp:
  784. (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
  785. * platform/graphics/skia/ImageSourceSkia.cpp:
  786. * platform/graphics/wx/ImageSourceWx.cpp:
  787. (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
  788. * platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
  789. * platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
  790. * platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
  791. * platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
  792. * platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
  793. * platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
  794. * platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
  795. * platform/image-decoders/skia/BMPImageDecoder.h: Removed.
  796. * platform/image-decoders/skia/BMPImageReader.cpp: Removed.
  797. * platform/image-decoders/skia/BMPImageReader.h: Removed.
  798. * platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
  799. * platform/image-decoders/skia/GIFImageDecoder.h: Removed.
  800. * platform/image-decoders/skia/GIFImageReader.cpp: Removed.
  801. * platform/image-decoders/skia/GIFImageReader.h: Removed.
  802. * platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
  803. * platform/image-decoders/skia/ICOImageDecoder.h: Removed.
  804. * platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
  805. * platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
  806. * platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
  807. * platform/image-decoders/skia/PNGImageDecoder.h: Removed.
  808. * platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
  809. * platform/image-decoders/skia/XBMImageDecoder.h: Removed.
  810. * platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
  811. * platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
  812. 2009-06-11 Peter Kasting <pkasting@google.com>
  813. Reviewed by Eric Seidel.
  814. https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
  815. Update Skia's ImageDecoder.h with a few changes designed to reduce the
  816. delta between specific implementations of ImageDecoder.h. Update
  817. Cairo's ImageDecoder.h to sync up with the API changes in the Skia
  818. version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
  819. decoders to use the APIs as well. All the Cairo image decoder changes
  820. are direct copies of the Skia versions except ImageDecoder.h, which is
  821. modified in the necessary ways for the differences between Cairo and
  822. Skia.
  823. * platform/graphics/cairo/ImageSourceCairo.cpp:
  824. (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
  825. * platform/image-decoders/ImageDecoder.h: Sync up with Skia version.
  826. (WebCore::RGBA32Buffer::):
  827. (WebCore::RGBA32Buffer::RGBA32Buffer):
  828. (WebCore::RGBA32Buffer::clear):
  829. (WebCore::RGBA32Buffer::zeroFill):
  830. (WebCore::RGBA32Buffer::copyBitmapData):
  831. (WebCore::RGBA32Buffer::copyRowNTimes):
  832. (WebCore::RGBA32Buffer::setSize):
  833. (WebCore::RGBA32Buffer::asNewNativeImage):
  834. (WebCore::RGBA32Buffer::hasAlpha):
  835. (WebCore::RGBA32Buffer::disposalMethod):
  836. (WebCore::RGBA32Buffer::setHasAlpha):
  837. (WebCore::RGBA32Buffer::setDisposalMethod):
  838. (WebCore::RGBA32Buffer::setRGBA):
  839. (WebCore::RGBA32Buffer::operator=):
  840. (WebCore::RGBA32Buffer::width):
  841. (WebCore::RGBA32Buffer::height):
  842. (WebCore::RGBA32Buffer::getAddr):
  843. * platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version.
  844. (WebCore::GIFImageDecoder::initFrameBuffer):
  845. (WebCore::GIFImageDecoder::haveDecodedRow):
  846. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version.
  847. (WebCore::JPEGImageDecoder::outputScanlines):
  848. * platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version.
  849. (WebCore::PNGImageDecoder::rowAvailable):
  850. * platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability.
  851. (WebCore::RGBA32Buffer::):
  852. (WebCore::RGBA32Buffer::copyRowNTimes):
  853. (WebCore::RGBA32Buffer::setSize):
  854. (WebCore::RGBA32Buffer::asNewNativeImage):
  855. (WebCore::RGBA32Buffer::hasAlpha):
  856. (WebCore::RGBA32Buffer::disposalMethod):
  857. (WebCore::RGBA32Buffer::setHasAlpha):
  858. (WebCore::RGBA32Buffer::setStatus):
  859. (WebCore::RGBA32Buffer::setDisposalMethod):
  860. (WebCore::RGBA32Buffer::setRGBA):
  861. (WebCore::RGBA32Buffer::operator=):
  862. (WebCore::RGBA32Buffer::width):
  863. (WebCore::RGBA32Buffer::height):
  864. (WebCore::RGBA32Buffer::getAddr):
  865. * platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
  866. 2009-06-12 Brent Fulgham <bfulgham@webkit.org>
  867. Unreviewed build correction.
  868. Revert accidental configuration checkin. Was not meant to
  869. be part of the last changeset.
  870. * config.h:
  871. 2009-06-12 Brent Fulgham <bfulgham@webkit.org>
  872. Reviewed by Eric Seidel.
  873. https://bugs.webkit.org/show_bug.cgi?id=26353
  874. Corrects handling of Cairo fonts that were getting out of
  875. sync due to default copy construction. Also refactors
  876. some incorrect platform font destruction code that belongs
  877. in the font object's destructor.
  878. * platform/graphics/win/FontPlatformData.h:
  879. * platform/graphics/win/FontPlatformDataCGWin.cpp:
  880. (WebCore::FontPlatformData::~FontPlatformData):
  881. * platform/graphics/win/FontPlatformDataCairoWin.cpp:
  882. (WebCore::FontPlatformData::platformDataInit):
  883. (WebCore::FontPlatformData::FontPlatformData):
  884. (WebCore::FontPlatformData::setFont):
  885. (WebCore::FontPlatformData::~FontPlatformData):
  886. * platform/graphics/win/FontPlatformDataWin.cpp:
  887. * platform/graphics/win/SimpleFontDataCGWin.cpp:
  888. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  889. (WebCore::SimpleFontData::platformInit):
  890. (WebCore::SimpleFontData::platformWidthForGlyph):
  891. * platform/graphics/win/SimpleFontDataWin.cpp:
  892. 2009-06-12 Peter Kasting <pkasting@google.com>
  893. Reviewed by Eric Seidel.
  894. * ChangeLog-2007-10-14: Update my email address.
  895. * ChangeLog-2008-08-10: Update my email address.
  896. 2009-06-12 Nate Chapin <japhet@google.com>
  897. Reviewed by David Levin.
  898. Upstream V8Helpers.
  899. https://bugs.webkit.org/show_bug.cgi?id=26332
  900. * bindings/v8/V8Helpers.cpp: Added.
  901. (wrapNPObject): Moved from v8_helpers.cpp.
  902. (toV8Context): Moved from v8_helpers.cpp.
  903. (toV8Proxy): Moved from v8_helpers.cpp.
  904. * bindings/v8/V8Helpers.h: Added.
  905. 2009-06-12 Jessie Berlin <jberlin@apple.com>
  906. Reviewed by Mark Rowe.
  907. https://bugs.webkit.org/show_bug.cgi?id=24792
  908. rdar://problem/6933055
  909. Changes the radius in which cursor movement around the 4 arrow icon
  910. while pan-scrolling does not cause scrolling from around 10 pixels to
  911. 15 pixels, similar to what is found in IE and Firefox.
  912. * page/EventHandler.cpp:
  913. (WebCore::EventHandler::setPanScrollCursor):
  914. Factor out the no-pan-scroll radius.
  915. * platform/ScrollView.h:
  916. Create a constant for the no-pan-scroll radius.
  917. * rendering/RenderLayer.cpp:
  918. (WebCore::RenderLayer::panScrollFromPoint):
  919. Factor out the no-pan-scroll radius.
  920. 2009-06-12 Xan Lopez <xlopez@igalia.com>
  921. Reviewed by Gustavo Noronha.
  922. https://bugs.webkit.org/show_bug.cgi?id=25609
  923. [GTK] Implement support for get_selection and get_n_selections
  924. Only use the VisibleSelection object if it actually belongs to the
  925. object we are using.
  926. This is pretty hacky-ish, but I can't seem to find a direct API to
  927. get the VisibleSelection for a given object, only the global one.
  928. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  929. (selectionBelongsToObject):
  930. (webkit_accessible_text_get_n_selections):
  931. (webkit_accessible_text_get_selection):
  932. 2009-06-03 Eric Seidel <eric@webkit.org>
  933. Reviewed by Darin Adler.
  934. Crash at Node::nodeIndex()
  935. https://bugs.webkit.org/show_bug.cgi?id=26044
  936. This crash seems to be caused by calling nodeIndex() on
  937. and invalid Node pointer. As far as I can tell, the most likely
  938. explanation is that the Range holding the node is actually
  939. deleted already (thus the memory is junk). Looking at the code
  940. Range changes m_start.container() in its destructor to tell if
  941. the range is detached or not. If somehow m_start.container() was
  942. cleared, the range will never be detached and the Document will end
  943. up with pointers to deleted ranges. I don't know how to reproduce this
  944. any reproduction I could think of would hit ASSERTS in Debug mode.
  945. One reproduction I tried, did not crash in Release mode, even though it
  946. did in Debug mode.
  947. I'm making a speculative fix by always detaching the Range from the document
  948. during ~Range. This is safer, and all we lose is an ASSERT to prevent double-detach.
  949. Another solution would be to instead store an m_attached bool on the Range object, or
  950. expose a Document::isRangeAttached(range) call. Either of those solutions
  951. could affect performance, so I went with this solution for now.
  952. I also removed the RangeBoundaryPoint default constructor
  953. as it is not used anywhere (and is more likely to cause confusion).
  954. Since I can't reproduce the crash, no test.
  955. * dom/Document.cpp:
  956. (WebCore::Document::detachRange):
  957. * dom/Range.cpp:
  958. (WebCore::Range::~Range):
  959. (WebCore::Range::detach):
  960. * dom/RangeBoundaryPoint.h:
  961. (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
  962. RangeBoundaryPoints always have an m_containerNode, ASSERT that.
  963. (WebCore::RangeBoundaryPoint::set):
  964. ASSERT(container) to match all the other functions.
  965. All callers already ASSERT(container). Since we only
  966. have reports if this crash from Release mode, I can only
  967. assume that those ASSERTs would have been hit in a Debug reproduction.
  968. 2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>
  969. Reviewed by Adam Barth.
  970. https://bugs.webkit.org/show_bug.cgi?id=25512
  971. Handle texts after unfinished special tags (i.e., script, style, textarea,
  972. title, xmp, and iframe) as the text node under the tags in view-source mode.
  973. Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.
  974. This was already done only for title. This change allows other special tags to be handled as well.
  975. Test: fast/frames/viewsource-unfinished-tags.html
  976. * html/HTMLTokenizer.cpp:
  977. (WebCore::HTMLTokenizer::parseNonHTMLText):
  978. (WebCore::HTMLTokenizer::parseTag):
  979. (WebCore::HTMLTokenizer::write):
  980. * html/HTMLTokenizer.h:
  981. (WebCore::HTMLTokenizer::State::inAnyNonHTMLText):
  982. 2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>
  983. Reviewed by Ariya Hidayat.
  984. https://bugs.webkit.org/show_bug.cgi?id=26291
  985. [Qt] build break in ImageDecoderQt.cpp.
  986. * platform/graphics/qt/ImageDecoderQt.cpp:
  987. (WebCore::ImageDecoderQt::reset):
  988. (WebCore::ImageDecoderQt::setData):
  989. (WebCore::ImageDecoderQt::isSizeAvailable):
  990. * platform/image-decoders/ImageDecoder.h:
  991. (WebCore::ImageDecoder::setSize):
  992. 2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>
  993. Rubber-stamped by Ariya Hidayat.
  994. Removed obsolete and unmaintained files from the old Symbian port.
  995. * platform/symbian/FloatPointSymbian.cpp: Removed.
  996. * platform/symbian/FloatRectSymbian.cpp: Removed.
  997. * platform/symbian/IntPointSymbian.cpp: Removed.
  998. * platform/symbian/IntRectSymbian.cpp: Removed.
  999. * platform/symbian/IntSizeSymbian.cpp: Removed.
  1000. * platform/text/symbian/StringImplSymbian.cpp: Removed.
  1001. * platform/text/symbian/StringSymbian.cpp: Removed.
  1002. 2009-06-10 Peter Kasting <pkasting@google.com>
  1003. Reviewed by Eric Seidel.
  1004. https://bugs.webkit.org/show_bug.cgi?id=25709 part six
  1005. Miscellaneous tiny changes. The important bits here are the ANSI C++
  1006. compliance fix in skia/ImageDecoders.h (needed to compile this file on
  1007. non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
  1008. unit tests partly exposed. Other changes are mostly cosmetic.
  1009. * platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
  1010. * platform/image-decoders/gif/GIFImageDecoder.cpp:
  1011. (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
  1012. (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  1013. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  1014. (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  1015. * platform/image-decoders/png/PNGImageDecoder.cpp:
  1016. (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  1017. * platform/image-decoders/skia/BMPImageReader.cpp:
  1018. (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity.
  1019. (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity.
  1020. (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
  1021. * platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0).
  1022. (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
  1023. (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  1024. * platform/image-decoders/skia/ImageDecoder.h:
  1025. (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
  1026. * platform/image-decoders/skia/JPEGImageDecoder.cpp:
  1027. (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  1028. * platform/image-decoders/skia/PNGImageDecoder.cpp:
  1029. (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  1030. * platform/image-decoders/skia/XBMImageDecoder.cpp:
  1031. (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
  1032. 2009-06-10 Ojan Vafai <ojan@chromium.org>
  1033. Reviewed by Eric Seidel.
  1034. The shadow node inside empty textareas gets collapsed in disabled
  1035. textareas. This is a regression from moving the overflow from
  1036. the shadow node to it's parent. The fix is to return true in
  1037. RenderBlock::hasLineIfEmpty for textarea shadow nodes as we
  1038. currently do for input shadow nodes.
  1039. https://bugs.webkit.org/show_bug.cgi?id=26296
  1040. Test: fast/forms/empty-textarea-toggle-disabled.html
  1041. * rendering/RenderBlock.cpp:
  1042. (WebCore::RenderBlock::hasLineIfEmpty):
  1043. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1044. Reviewed by Gustavo Noronha.
  1045. https://bugs.webkit.org/show_bug.cgi?id=25609
  1046. [GTK] Implement support for get_selection and get_n_selections
  1047. Implement atk_text_get_n_selections.
  1048. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1049. (webkit_accessible_text_get_n_selections):
  1050. 2009-06-10 Dan Bernstein <mitz@apple.com>
  1051. Reviewed by Anders Carlsson.
  1052. - fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a
  1053. Google map in iPhoto Places, it drags a map tile instead
  1054. Calling stopLoadRequest() from notifyFinished() removed the
  1055. ScriptElementData from the CachedScript's client set, which could make
  1056. it eligible for purging. The fix is to call removeClient() only after
  1057. executing the script, which protects it from being purged while it is
  1058. in the document's queue of scripts to execute soon.
  1059. * dom/ScriptElement.cpp:
  1060. (WebCore::ScriptElementData::execute): Call removeClient() here.
  1061. (WebCore::ScriptElementData::notifyFinished): Instead of calling
  1062. stopLoadRequest(), which calls removeClient(), just reset
  1063. m_cachedScript.
  1064. 2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
  1065. Reviewed by Mark Rowe and Eric Seidel.
  1066. Update WebInspector localizedStrings.js with new resource tracking strings
  1067. https://bugs.webkit.org/show_bug.cgi?id=26247
  1068. * English.lproj/localizedStrings.js:
  1069. 2009-06-10 Feng Qian <feng@chromium.org>
  1070. Reviewed by Eric Seidel.
  1071. Add Android specific files.
  1072. https://bugs.webkit.org/show_bug.cgi?id=26280
  1073. * platform/text/android: Added.
  1074. * platform/text/android/TextBreakIteratorInternalICU.cpp: Added.
  1075. 2009-06-10 Feng Qian <feng@chromium.org>
  1076. Reviewed by Eric Seidel.
  1077. Add Android specific file to WebCore/platform/android (part 9).
  1078. https://bugs.webkit.org/show_bug.cgi?id=26266
  1079. * platform/android/TemporaryLinkStubs.cpp: Added.
  1080. 2009-06-10 Feng Qian <feng@chromium.org>
  1081. Reviewed by Eric Seidel.
  1082. Add Android platform specific files.
  1083. https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).
  1084. * platform/android/SystemTimeAndroid.cpp: Added.
  1085. * platform/android/WidgetAndroid.cpp: Added.
  1086. 2009-06-10 Feng Qian <feng@chromium.org>
  1087. Reviewed by Eric Seidel.
  1088. Add Android port files to WebCore/platform. (part 6).
  1089. https://bugs.webkit.org/show_bug.cgi?id=26264
  1090. * platform/android/RenderThemeAndroid.cpp: Added.
  1091. * platform/android/RenderThemeAndroid.h: Added.
  1092. 2009-06-10 Feng Qian <feng@chromium.org>
  1093. Reviewed by Eric Seidel.
  1094. Add Android port files to WebCore/platform (part 7).
  1095. https://bugs.webkit.org/show_bug.cgi?id=23296
  1096. * platform/android/ScreenAndroid.cpp: Added.
  1097. * platform/android/ScrollViewAndroid.cpp: Added.
  1098. * platform/android/SearchPopupMenuAndroid.cpp: Added.
  1099. 2009-06-10 Feng Qian <feng@chromium.org>
  1100. Reviewed by Eric Seidel.
  1101. Add Android port files to WebCore/platform (part 5).
  1102. https://bugs.webkit.org/show_bug.cgi?id=23296
  1103. * platform/android/LocalizedStringsAndroid.cpp: Added.
  1104. * platform/android/PopupMenuAndroid.cpp: Added.
  1105. 2009-06-10 Feng Qian <feng@chromium.org>
  1106. Reviewed by Eric Seidel.
  1107. Add Android port files to WebCore/platform (part 4).
  1108. https://bugs.webkit.org/show_bug.cgi?id=23296
  1109. * platform/android/KeyEventAndroid.cpp: Added.
  1110. * platform/android/KeyboardCodes.h: Added.
  1111. 2009-06-10 Feng Qian <feng@chromium.org>
  1112. Reviewed by Eric Seidel.
  1113. Add Android port files to WebCore/platform (part 3).
  1114. https://bugs.webkit.org/show_bug.cgi?id=23296
  1115. * platform/android/FileChooserAndroid.cpp: Added.
  1116. * platform/android/FileSystemAndroid.cpp: Added.
  1117. 2009-06-10 Feng Qian <feng@chromium.org>
  1118. Reviewed by Eric Seidel.
  1119. Add Android port files to WebCore/platform (part 2).
  1120. https://bugs.webkit.org/show_bug.cgi?id=23296
  1121. * platform/android/CursorAndroid.cpp: Added.
  1122. * platform/android/DragDataAndroid.cpp: Added.
  1123. * platform/android/EventLoopAndroid.cpp: Added.
  1124. 2009-06-10 Nate Chapin <japhet@google.com>
  1125. Reviewed by David Levin.
  1126. Finish moving V8Custom from src.chromium.org to svn.webkit.org.
  1127. https://bugs.webkit.org/show_bug.cgi?id=26258
  1128. * bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming.
  1129. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
  1130. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
  1131. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
  1132. (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp.
  1133. (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
  1134. * bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
  1135. * bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
  1136. * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
  1137. * bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
  1138. * bindings/v8/custom/V8WebKitPointConstructor.cpp: Added.
  1139. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
  1140. 2009-06-10 Takeshi Yoshino <tyoshino@google.com>
  1141. Reviewed by Justin Garcia.
  1142. Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.
  1143. https://bugs.webkit.org/show_bug.cgi?id=26214
  1144. visiblePositionForIndex can return an instance that returns true for
  1145. isNotNull(). One of common case is when the corresponding input element has
  1146. "-webkit-user-select: none" style attribute. We should allow the case instead
  1147. of putting ASSERT.
  1148. Test: fast/forms/input-select-webkit-user-select-none.html
  1149. * rendering/RenderTextControl.cpp:
  1150. (WebCore::RenderTextControl::setSelectionRange):
  1151. 2009-06-10 Roland Steiner <rolandsteiner@google.com>
  1152. Reviewed by Eric Seidel.
  1153. Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp
  1154. https://bugs.webkit.org/show_bug.cgi?id=26197
  1155. The PlatformContextSkia constructor does a (very likely) wrong size
  1156. initialization for its m_stateStack member:
  1157. m_stateStack(sizeof(State))
  1158. The intended initialization is probably rather
  1159. m_stateStack(1)
  1160. However, since this doesn't buy much (see also comment #4),
  1161. I removed the initialization completely.
  1162. * platform/graphics/skia/PlatformContextSkia.cpp:
  1163. (PlatformContextSkia::PlatformContextSkia): remove member initialization
  1164. 2009-06-10 Dean McNamee <deanm@chromium.org>
  1165. Reviewed by Eric Seidel.
  1166. When there is no backing bitmap, return a transparent pattern.
  1167. https://bugs.webkit.org/show_bug.cgi?id=26061
  1168. Test: fast/canvas/canvas-empty-image-pattern.html
  1169. * platform/graphics/skia/PatternSkia.cpp:
  1170. (WebCore::Pattern::createPlatformPattern):
  1171. 2009-06-10 Dean McNamee <deanm@chromium.org>
  1172. Reviewed by Eric Seidel.
  1173. Fix a crash for radial gradients with a zero radius.
  1174. https://bugs.webkit.org/show_bug.cgi?id=26059
  1175. Test: fast/gradients/crash-on-zero-radius.html
  1176. * platform/graphics/skia/GradientSkia.cpp:
  1177. (WebCore::Gradient::platformGradient):
  1178. 2009-06-10 Peter Kasting <pkasting@google.com>
  1179. Reviewed by Eric Seidel.
  1180. https://bugs.webkit.org/show_bug.cgi?id=25709 part five
  1181. Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
  1182. This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
  1183. well and modifies Skia's usage of those interfaces accordingly. Once a
  1184. similar change lands on the Cairo side, the Skia and Cairo decoders
  1185. should be identical except for the implementation of RGBA32Buffer.
  1186. * platform/graphics/skia/ImageSourceSkia.cpp:
  1187. (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
  1188. * platform/image-decoders/skia/BMPImageReader.cpp:
  1189. (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
  1190. * platform/image-decoders/skia/GIFImageDecoder.cpp:
  1191. (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
  1192. * platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height().
  1193. (WebCore::RGBA32Buffer::zeroFill): Added.
  1194. (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away.
  1195. (WebCore::RGBA32Buffer::copyRowNTimes): Added.
  1196. (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function.
  1197. (WebCore::RGBA32Buffer::asNewNativeImage): Added.
  1198. (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
  1199. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1200. Reviewed by Gustavo Noronha.
  1201. https://bugs.webkit.org/show_bug.cgi?id=25671
  1202. [GTK] Implement support for set_caret_offset
  1203. Make an implementation that actually works.
  1204. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1205. (webkit_accessible_text_set_caret_offset):
  1206. 2009-06-10 Darin Fisher <darin@chromium.org>
  1207. Reviewed by Dimitri Glazkov.
  1208. https://bugs.webkit.org/show_bug.cgi?id=26294
  1209. Make sure all member variables are initialized so that the default
  1210. assignment operator and copy constructors do not read uninitialized
  1211. memory.
  1212. * platform/network/ResourceResponseBase.cpp:
  1213. 2009-06-10 Yury Semikhatsky <yurys@chromium.org>
  1214. Reviewed by Timothy Hatcher.
  1215. Update main resource meta-data when resource tracking is disabled.
  1216. https://bugs.webkit.org/show_bug.cgi?id=26253
  1217. * inspector/InspectorController.cpp:
  1218. (WebCore::InspectorController::getTrackedResource):
  1219. (WebCore::InspectorController::willSendRequest):
  1220. (WebCore::InspectorController::didReceiveResponse):
  1221. (WebCore::InspectorController::didReceiveContentLength):
  1222. (WebCore::InspectorController::didFinishLoading):
  1223. (WebCore::InspectorController::didFailLoading):
  1224. * inspector/InspectorController.h:
  1225. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1226. Reviewed by Gustavo Noronha.
  1227. https://bugs.webkit.org/show_bug.cgi?id=25609
  1228. [GTK] Implement support for get_selection and get_n_selections
  1229. Implement atk_text_get_selection.
  1230. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1231. (webkit_accessible_text_get_selection):
  1232. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1233. Reviewed by Gustavo Noronha.
  1234. Do not check if our parent class has the finalize method, it's
  1235. guaranteed to be there.
  1236. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1237. (webkit_accessible_finalize):
  1238. 2009-06-10 Brent Fulgham <bfulgham@webkit.org>
  1239. Build correct for Windows Cairo targets.
  1240. * WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction
  1241. between '_setjmp' and C++ object destruction is non-portable) for
  1242. the two Cairo targets. This used to be disabled in a #pragma,
  1243. but recent refactoring removed these lines.
  1244. 2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1245. Reviewed by Simon Hausmann.
  1246. Fix the build of PluginView on Qt with 64-bit where we disable plugins
  1247. at compile time.
  1248. Use the FooNone.cpp files at compile-time.
  1249. * plugins/PluginPackageNone.cpp:
  1250. * plugins/mac/PluginPackageMac.cpp:
  1251. * plugins/mac/PluginViewMac.cpp:
  1252. 2009-06-10 Simon Hausmann <simon.hausmann@nokia.com>
  1253. Fix the Qt build.
  1254. ImageDecoderQt needs m_size and m_sizeAvailable to be protected.
  1255. * platform/image-decoders/ImageDecoder.h:
  1256. 2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1257. Reviewed by Simon Hausmann.
  1258. [Qt] Use absolute path for install_name on Mac
  1259. * WebCore.pro:
  1260. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1261. Reviewed by Jan Alonzo.
  1262. https://bugs.webkit.org/show_bug.cgi?id=25415
  1263. [GTK][ATK] Please implement support for get_text_at_offset
  1264. Reduce duplicated code to access the text of a AtkText
  1265. object. doAXStringForRange calls text() internally, so we are
  1266. doing exactly the same after the change.
  1267. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1268. (getGailTextUtilForAtk):
  1269. (getPangoLayoutForAtk):
  1270. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1271. Reviewed by Jan Alonzo.
  1272. https://bugs.webkit.org/show_bug.cgi?id=25415
  1273. [GTK][ATK] Please implement support for get_text_at_offset
  1274. Pass a PangoLayout to the GailTextUtil function calls.
  1275. It's needed for LINE boundary calls to work correctly.
  1276. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1277. (updateLayout):
  1278. (getPangoLayoutForAtk):
  1279. (webkit_accessible_text_get_text_after_offset):
  1280. (webkit_accessible_text_get_text_at_offset):
  1281. 2009-06-10 Xan Lopez <xlopez@igalia.com>
  1282. Reviewed by Jan Alonzo.
  1283. https://bugs.webkit.org/show_bug.cgi?id=25415
  1284. [GTK][ATK] Please implement support for get_text_at_offset
  1285. Use GailUtilText instead of my crappy partial reimplementation of
  1286. it. This should add support for LINE boundaries too, although it's
  1287. mostly untested for now.
  1288. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  1289. (getGailTextUtilForAtk):
  1290. (webkit_accessible_text_get_text_after_offset):
  1291. (webkit_accessible_text_get_text_at_offset):
  1292. 2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
  1293. Gtk build fix: include <stdio.h> as it is required in jpeglib.h
  1294. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  1295. 2009-06-09 Peter Kasting <pkasting@google.com>
  1296. Reviewed by Eric Seidel.
  1297. https://bugs.webkit.org/show_bug.cgi?id=25709 part four
  1298. Most of the remaining Cairo changes needed before merging Skia/Cairo
  1299. image decoders. Most of these involve plumbing more error detection and
  1300. handling (or, in some cases, merely the capability to detect errors, as
  1301. e.g. Skia detects and handles image allocation failure while Cairo
  1302. currently doesn't). There is also some general cleanup and
  1303. simplification; RGBA32Buffer::m_height and all associated functions have
  1304. been removed (set but never used) and some places now rely on superclass
  1305. implementations.
  1306. * platform/image-decoders/ImageDecoder.h:
  1307. (WebCore::RGBA32Buffer::RGBA32Buffer): Remove m_height, ensureHeight() and associated stuff
  1308. (WebCore::RGBA32Buffer::copyBitmapData): Add API function so refcounted backing stores (like Skia uses) can be used with GIFs
  1309. (WebCore::RGBA32Buffer::setSize): Zero-fill image to avoid garbage
  1310. (WebCore::RGBA32Buffer::height): Remove
  1311. (WebCore::RGBA32Buffer::ensureHeight): Remove
  1312. (WebCore::ImageDecoder::ImageDecoder): Keep member initialization in order, force subclasses to go through size() instead of accessing m_size directly
  1313. (WebCore::ImageDecoder::isSizeAvailable): Check that decoding hasn't failed
  1314. (WebCore::ImageDecoder::size): Check that decoding hasn't failed
  1315. (WebCore::ImageDecoder::setSize): Protect against integer overflow
  1316. (WebCore::ImageDecoder::isOverSize): Protect against integer overflow
  1317. * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove prepEmptyFrameBuffer()
  1318. (WebCore::GIFImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling
  1319. (WebCore::GIFImageDecoder::sizeNowAvailable): Add return values for better failure handling, rely on superclass setSize() for overflow protection
  1320. (WebCore::GIFImageDecoder::initFrameBuffer): Add return values for better failure handling, remove prepEmptyFrameBuffer(), use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), use RGBA32Buffer::copyBitmapData() so backing store can be refcounted internally (Cairo won't be, Skia is), rely on superclass size() for better failure handling
  1321. (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation, remove RGBA32Buffer::ensureHeight()
  1322. (WebCore::GIFImageDecoder::frameComplete): Remove RGBA32Buffer::ensureHeight()
  1323. * platform/image-decoders/gif/GIFImageDecoder.h: Remove prepEmptyFrameBuffer(), add return values for better failure handling
  1324. * platform/image-decoders/gif/GIFImageReader.cpp:
  1325. (GIFImageReader::do_lzw): Protect against array overflow, add comments
  1326. (GIFImageReader::read): Protect against array overflow, be more tolerant of bad data, better failure handling
  1327. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files)
  1328. (WebCore::JPEGImageReader::decode): Better failure handling
  1329. (WebCore::JPEGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling
  1330. (WebCore::JPEGImageDecoder::outputScanlines): Use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), rely on superclass size() for better failure handling, remove RGBA32Buffer::ensureHeight()
  1331. * platform/image-decoders/jpeg/JPEGImageDecoder.h: Rely on superclass setSize() for overflow protection
  1332. * platform/image-decoders/png/PNGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files)
  1333. (WebCore::PNGImageDecoder::PNGImageDecoder): Don't allocate a slot in the framebuffer cache until it's needed
  1334. (WebCore::PNGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling
  1335. (WebCore::PNGImageDecoder::frameBufferAtIndex): Don't allocate a slot in the framebuffer cache until it's needed
  1336. (WebCore::PNGImageDecoder::decode): Don't allocate a slot in the framebuffer cache until it's needed
  1337. (WebCore::PNGImageDecoder::decodingFailed): Fix style violation
  1338. (WebCore::PNGImageDecoder::headerAvailable): Rely on superclass isSizeAvailable() and setSize() for overflow protection and better failure handling
  1339. (WebCore::PNGImageDecoder::rowAvailable): Don't allocate a slot in the framebuffer cache until it's needed, use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), remove RGBA32Buffer::ensureHeight()
  1340. (WebCore::PNGImageDecoder::pngComplete): Don't allocate a slot in the framebuffer cache until it's needed
  1341. 2009-06-09 Kevin Ollivier <kevino@theolliviers.com>
  1342. wx build fix, adding JSCore/assembler to the list of include dirs, and
  1343. adding editing/ReplaceNodeSpanCommand.cpp to the build.
  1344. * WebCoreSources.bkl:
  1345. * webcore-base.bkl:
  1346. 2009-06-09 Yury Semikhatsky <yurys@chromium.org>
  1347. Reviewed by Timothy Hatcher.
  1348. When checking if the loader is the main resource loader make sure that the loader's frame is the main frame.
  1349. https://bugs.webkit.org/show_bug.cgi?id=26218
  1350. * inspector/InspectorController.cpp:
  1351. (WebCore::InspectorController::didLoadResourceFromMemoryCache):
  1352. (WebCore::InspectorController::identifierForInitialRequest):
  1353. (WebCore::InspectorController::isMainResourceLoader):
  1354. * inspector/InspectorController.h:
  1355. 2009-06-09 Pierre d'Herbemont <pdherbemont@apple.com>
  1356. Reviewed by Eric Seidel.
  1357. https://bugs.webkit.org/show_bug.cgi?id=26190
  1358. Test: media/controls-css-overload.html
  1359. * rendering/RenderMedia.cpp:
  1360. (WebCore::RenderMedia::updateControls): Prevent NULL dereference in case containers gets hidden.
  1361. 2009-06-08 Peter Kasting <pkasting@google.com>
  1362. Reviewed by Eric Seidel.
  1363. https://bugs.webkit.org/show_bug.cgi?id=25709 part three
  1364. Various minor cleanups to the Skia files. Mostly non-functional, except
  1365. for two specific changes:
  1366. * JPEGs and PNGs were always marked as transparent; now they are only
  1367. marked as transparent when they actually are. I doubt this has much
  1368. of an effect but in theory it could be used to optimize their display.
  1369. * Instead of arbitrarily disallowing images over 32 * 1024 * 1024 px^2,
  1370. only disallow images which are so large they will cause overflow in
  1371. other parts of the code. This should fix the testcase on
  1372. http://code.google.com/p/chromium/issues/detail?id=3643.
  1373. * platform/image-decoders/skia/BMPImageReader.h:
  1374. (WebCore::BMPImageReader::setRGBA): Use simpler non-static setRGBA() form
  1375. * platform/image-decoders/skia/GIFImageDecoder.cpp:
  1376. (WebCore::GIFImageDecoder::initFrameBuffer): Remove unneeded code, use more readable setRGBA() form
  1377. (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation
  1378. * platform/image-decoders/skia/GIFImageDecoder.h: Remove unneeded code
  1379. * platform/image-decoders/skia/ImageDecoder.h:
  1380. (WebCore::RGBA32Buffer::setSize): setSize() should just setStatus() when it fails since all callers were doing it
  1381. (WebCore::ImageDecoder::isOverSize): Ease "oversized" image constraints to allow any image that won't overflow
  1382. * platform/image-decoders/skia/JPEGImageDecoder.cpp:
  1383. (WebCore::JPEGImageDecoder::outputScanlines): Remove unneeded code, mark JPEGs as non-transparent
  1384. * platform/image-decoders/skia/PNGImageDecoder.cpp:
  1385. (WebCore::PNGImageDecoder::decodingFailed): Fix style violation
  1386. (WebCore::PNGImageDecoder::rowAvailable): Mark un-decoded PNGs as non-transparent (this will get reset later as needed)
  1387. * platform/image-decoders/skia/XBMImageDecoder.cpp:
  1388. (WebCore::XBMImageDecoder::frameBufferAtIndex): Remove unneeded code
  1389. 2009-06-09 Darin Fisher <darin@chromium.org>
  1390. Fix Chromium build bustage.
  1391. CachedResource.cpp no longer compiles if USE(JSC) is not defined. The
  1392. problem is that this file is using a macro from StdLibExtras.h without
  1393. including that file. It just happenes to get that file via a JSC
  1394. specific include.
  1395. * loader/CachedResource.cpp:
  1396. 2009-06-09 Dean McNamee <deanm@chromium.org>
  1397. Reviewed by Oliver Hunt.
  1398. Make sure the graphics backends are in sync with the canvas lineWidth state.
  1399. https://bugs.webkit.org/show_bug.cgi?id=26187
  1400. Test: fast/canvas/canvas-line-width.html
  1401. * html/CanvasRenderingContext2D.cpp:
  1402. (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
  1403. 2009-06-09 Michael Nordman <michaeln@google.com>
  1404. Reviewed by Eric Seidel.
  1405. Proactively cancel pending requests at DocLoader dtor time,
  1406. otherwise crashes can occur.
  1407. https://bugs.webkit.org/show_bug.cgi?id=26230
  1408. http://code.google.com/p/chromium/issues/detail?id=12161
  1409. Test: fast/frames/javascript-url-as-framesrc-crash.html
  1410. * loader/DocLoader.cpp:
  1411. (WebCore::DocLoader::~DocLoader):
  1412. 2009-06-09 Eric Seidel <eric@webkit.org>
  1413. Reviewed by Darin Adler.
  1414. Fix ASSERT seen in shadow tree testing
  1415. https://bugs.webkit.org/show_bug.cgi?id=25092
  1416. Test: svg/custom/use-mutation-event-crash.svg
  1417. * svg/SVGUseElement.cpp:
  1418. (WebCore::SVGUseElement::instanceForShadowTreeElement):
  1419. 2009-06-09 Brent Fulgham <bfulgham@webkit.org>
  1420. Reviewed by Eric Seidel.
  1421. Fixes https://bugs.webkit.org/show_bug.cgi?id=22891
  1422. Scrolling in Windows Cairo Broken if no background color set.
  1423. * platform/graphics/cairo/GradientCairo.cpp:
  1424. (WebCore::Gradient::fill): Use the GraphicsContext save and restore
  1425. methods (rather than the Cairo-only functions) so that the Windows
  1426. device context is kept in sync.
  1427. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  1428. (WebCore::GraphicsContext::GraphicsContext): Add new constructor call
  1429. to sync Windows HDC with Cairo surface.
  1430. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  1431. (WebCore::GraphicsContextPlatformPrivate::syncContext): Provide
  1432. declaration for Windows HDC sync method (and stub for non-Windows
  1433. Cairo implementations).
  1434. * platform/graphics/cairo/ImageCairo.cpp:
  1435. (WebCore::BitmapImage::draw): Use GraphicsContext save and restore
  1436. methods (rather than the Cairo-only functions) so that the Windows
  1437. device context is kept in sync.
  1438. * platform/graphics/win/GraphicsContextCairoWin.cpp:
  1439. (WebCore::CairoContextWithHDC): New method to create a valid Cairo
  1440. context for a given HDC.
  1441. (WebCore::GraphicsContext::GraphicsContext): Modify constructor to
  1442. use new CairoContextWithHDC call.
  1443. (WebCore::GraphicsContext::getWindowsContext): Revise to match
  1444. behavior of CG implementation.
  1445. (WebCore::GraphicsContext::releaseWindowsContext): Revise to match
  1446. behavior of CG implementation.
  1447. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Get rid of
  1448. incorrect new HDC, and use object's HDC member for dealing with
  1449. concatCTM operations.
  1450. (WebCore::GraphicsContextPlatformPrivate::syncContext): New method
  1451. to sync Windows HDC with Cairo context.
  1452. * platform/graphics/win/ImageCairoWin.cpp:
  1453. (WebCore::BitmapImage::getHBITMAPOfSize): Revise implementation to
  1454. match CG behavior.
  1455. 2009-06-09 Jian Li <jianli@chromium.org>
  1456. Reviewed by David Levin.
  1457. Bug 26196: Fix the problem that worker's importScripts fails if the
  1458. script URL is redirected from different origin.
  1459. https://bugs.webkit.org/show_bug.cgi?id=26196
  1460. Test: http/tests/workers/worker-importScripts.html
  1461. The fix is to pass an additional enum parameter to the loader in
  1462. order to tell it to perform the redirect origin check or not.
  1463. * loader/DocumentThreadableLoader.cpp:
  1464. (WebCore::DocumentThreadableLoader::create):
  1465. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
  1466. (WebCore::DocumentThreadableLoader::willSendRequest):
  1467. * loader/DocumentThreadableLoader.h:
  1468. * loader/ThreadableLoader.cpp:
  1469. (WebCore::ThreadableLoader::create):
  1470. (WebCore::ThreadableLoader::loadResourceSynchronously):
  1471. * loader/ThreadableLoader.h:
  1472. (WebCore::):
  1473. * loader/WorkerThreadableLoader.cpp:
  1474. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  1475. (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
  1476. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  1477. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  1478. * loader/WorkerThreadableLoader.h:
  1479. (WebCore::WorkerThreadableLoader::create):
  1480. * workers/WorkerContext.cpp:
  1481. (WebCore::WorkerContext::importScripts):
  1482. * xml/XMLHttpRequest.cpp:
  1483. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  1484. 2009-06-09 Anand K. Mistry <amistry@google.com>
  1485. Reviewed by Dimitri Glazkov.
  1486. Paint bitmaps with the alpha channel in Skia.
  1487. https://bugs.webkit.org/show_bug.cgi?id=26037
  1488. Test: fast/canvas/drawImage-with-globalAlpha.html
  1489. * platform/graphics/skia/ImageSkia.cpp:
  1490. (WebCore::paintSkBitmap):
  1491. * platform/graphics/skia/PlatformContextSkia.cpp:
  1492. (PlatformContextSkia::getAlpha):
  1493. * platform/graphics/skia/PlatformContextSkia.h:
  1494. 2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  1495. Reviewed by Xan Lopez.
  1496. https://bugs.webkit.org/show_bug.cgi?id=26104
  1497. [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
  1498. Refactor how SoupMessage is handled, so that our ResourceRequest
  1499. object doesn't have to store it as a member, which complicates
  1500. managing ResourceRequest's lifetime.
  1501. * platform/network/soup/ResourceHandleSoup.cpp:
  1502. (WebCore::ResourceHandle::startHttp):
  1503. * platform/network/soup/ResourceRequest.h:
  1504. (WebCore::ResourceRequest::ResourceRequest):
  1505. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  1506. (WebCore::ResourceRequest::doUpdateResourceRequest):
  1507. * platform/network/soup/ResourceRequestSoup.cpp:
  1508. (WebCore::ResourceRequest::toSoupMessage):
  1509. (WebCore::ResourceRequest::updateFromSoupMessage):
  1510. 2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
  1511. Fix the Qt build, the time functions moved into the WTF namespace.
  1512. * bridge/qt/qt_runtime.cpp:
  1513. (JSC::Bindings::convertValueToQVariant):
  1514. (JSC::Bindings::convertQVariantToValue):
  1515. 2009-06-08 Brady Eidson <beidson@apple.com>
  1516. Reviewed by Antti Koivisto
  1517. <rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.
  1518. Test: http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
  1519. Loader::Host objects were manually managed via new/delete.
  1520. There's a variety of circumstances where a Host might've been deleted while it was still in the middle
  1521. of a resource load delegate callback.
  1522. Changing them to be RefCounted then adding protectors in the callbacks makes this possibility disappear.
  1523. At the same time, remove ProcessingResource which was an earlier fix for this same problem that wasn't
  1524. fully implemented.
  1525. * loader/loader.cpp:
  1526. (WebCore::Loader::Loader):
  1527. (WebCore::Loader::load):
  1528. (WebCore::Loader::servePendingRequests):
  1529. (WebCore::Loader::resumePendingRequests):
  1530. (WebCore::Loader::cancelRequests):
  1531. (WebCore::Loader::Host::didFinishLoading):
  1532. (WebCore::Loader::Host::didFail):
  1533. (WebCore::Loader::Host::didReceiveResponse):
  1534. (WebCore::Loader::Host::didReceiveData):
  1535. * loader/loader.h:
  1536. (WebCore::Loader::Host::create):
  1537. 2009-06-08 Dmitry Titov <dimich@chromium.org>
  1538. Reviewed by David Levin.
  1539. https://bugs.webkit.org/show_bug.cgi?id=26126
  1540. Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.
  1541. Split a couple of methods used to schedule cross-thread tasks between worker thread and loader thread
  1542. implemented on WorkerMessagingProxy into a separate interface so the loading can be implemented in
  1543. Chromium's workers.
  1544. No changes in functionality so no tests added.
  1545. * GNUmakefile.am:
  1546. * WebCore.vcproj/WebCore.vcproj:
  1547. * WebCore.xcodeproj/project.pbxproj:
  1548. Added WorkerLoaderProxy.h to the bulid.
  1549. * bindings/js/WorkerScriptController.cpp:
  1550. (WebCore::WorkerScriptController::evaluate): WorkerThread::workerObjectProxy() now returns & instead of *
  1551. * bindings/v8/WorkerScriptController.cpp:
  1552. (WebCore::WorkerScriptController::evaluate): same.
  1553. * workers/WorkerContext.cpp:
  1554. (WebCore::WorkerContext::~WorkerContext): same.
  1555. (WebCore::WorkerContext::reportException): same.
  1556. (WebCore::WorkerContext::addMessage): same.
  1557. (WebCore::WorkerContext::postMessage): same.
  1558. * loader/WorkerThreadableLoader.cpp:
  1559. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  1560. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  1561. (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
  1562. (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
  1563. (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
  1564. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
  1565. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
  1566. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  1567. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
  1568. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
  1569. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
  1570. Use WorkerLoaderProxy instead of WorkerMessagingProxy for the MainThreadBridge.
  1571. Mostly rename.
  1572. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  1573. In addition to using WorkerLoaderProxy instead of WorkerMessagingProxy, the check for
  1574. AskedToTerminate is removed. It seems to be an optimization for a very small number of cases
  1575. when worker termination is requested a very short time before the request to load something
  1576. (XHR or importScript) was dispatched on the main thread.
  1577. * loader/WorkerThreadableLoader.h:
  1578. Now keeps a pointer to WorkerLoaderProxy rather then to a WorkerMessagingProxy. This allows
  1579. to implement WorkerThreadableLoader for Chromium.
  1580. * workers/WorkerLoaderProxy.h: Added.
  1581. (WebCore::WorkerLoaderProxy::~WorkerLoaderProxy):
  1582. * workers/WorkerMessagingProxy.cpp:
  1583. (WebCore::WorkerMessagingProxy::startWorkerContext):
  1584. (WebCore::WorkerMessagingProxy::postTaskToLoader): Added ASSERT since this needs to be implemented for nested workers.
  1585. * workers/WorkerMessagingProxy.h:
  1586. Derived from WorkerLoaderProxy, the methods for posting tasks cross-thread are now virtual.
  1587. Removed unused postTaskToWorkerContext() method.
  1588. * workers/WorkerThread.cpp:
  1589. (WebCore::WorkerThread::create):
  1590. (WebCore::WorkerThread::WorkerThread):
  1591. * workers/WorkerThread.h:
  1592. (WebCore::WorkerThread::workerLoaderProxy):
  1593. * workers/WorkerThread.cpp:
  1594. (WebCore::WorkerThread::create):
  1595. (WebCore::WorkerThread::WorkerThread):
  1596. (WebCore::WorkerThread::workerThread):
  1597. * workers/WorkerThread.h:
  1598. (WebCore::WorkerThread::workerLoaderProxy):
  1599. (WebCore::WorkerThread::workerObjectProxy):
  1600. WorkerThread gets a new member of type WorkerLoaderProxy&, and accessor.
  1601. Also, existing WorkerObjectProxy* member is now WorkerObjectProxy& because it can't be null.
  1602. 2009-06-08 Dimitri Glazkov <dglazkov@chromium.org>
  1603. Reviewed by Eric Seidel.
  1604. https://bugs.webkit.org/show_bug.cgi?id=26238
  1605. Add parseDate helper to HTTPParsers, which uses WTF::parseDateFromNullTerminatedCharacters.
  1606. * ForwardingHeaders/runtime/DateMath.h: Removed.
  1607. * ForwardingHeaders/wtf/DateMath.h: Copied from WebCore/ForwardingHeaders/runtime/DateMath.h.
  1608. * platform/network/HTTPParsers.cpp:
  1609. (WebCore::parseDate): Added.
  1610. * platform/network/HTTPParsers.h:
  1611. * platform/network/ResourceResponseBase.cpp:
  1612. (WebCore::parseDateValueInHeader): Changed to use the new helper.
  1613. 2009-06-08 Adam Langley <agl@google.com>
  1614. Reviewed by Eric Siedel.
  1615. Chromium Linux ignored the background color on <select>s. Rather
  1616. than encode magic colours, we start with a base color (specified
  1617. via CSS) and derive the other colors from it. Thus, setting the
  1618. CSS background-color now correctly changes the colour of the
  1619. control.
  1620. This should not change the appearence controls without
  1621. background-colors. However, <select>s with a background-color
  1622. will now renderer correctly, which may require rebaselining
  1623. pixel tests in the Chromium tree.
  1624. https://bugs.webkit.org/show_bug.cgi?id=26030
  1625. http://code.google.com/p/chromium/issues/detail?id=12596
  1626. * platform/graphics/Color.cpp:
  1627. (WebCore::Color::getHSL): new member
  1628. * platform/graphics/Color.h:
  1629. * rendering/RenderThemeChromiumLinux.cpp:
  1630. (WebCore::RenderThemeChromiumLinux::systemColor):
  1631. (WebCore::brightenColor):
  1632. (WebCore::paintButtonLike):
  1633. 2009-06-08 Victor Wang <victorw@chromium.org>
  1634. Reviewed by Dimitri Glazkov.
  1635. https://bugs.webkit.org/show_bug.cgi?id=26087
  1636. Bug 26087: Removing element in JS crashes Chrome tab if it fired the change event
  1637. Fix tab crash caused by destroying the popup list that fired the change event on abandon.
  1638. If a popup list is abandoned (press a key to jump to an item
  1639. and then use tab or mouse to get away from the select box),
  1640. the current code fires a change event in PopupListBox::updateFromElemt().
  1641. The JS that listens to this event may destroy the object and cause the
  1642. rest of popup list code crashes.
  1643. The updateFromElement() is called before abandon() and this causes
  1644. the selected index to be discarded after updateFromElement(). From
  1645. the code comments, this appears to be the reason why valueChanged is
  1646. called in updateFromElement.
  1647. Fix the issue by removing the valueChanged call in updateFromElement,
  1648. saving the selected index that we should accept on abandon and pass
  1649. it to the valueChange in abandon().
  1650. A manual test has been added.
  1651. * manual-tests/chromium: Added.
  1652. * manual-tests/chromium/onchange-reload-popup.html: Added.
  1653. * platform/chromium/PopupMenuChromium.cpp:
  1654. (WebCore::PopupListBox::PopupListBox):
  1655. (WebCore::PopupListBox::handleKeyEvent):
  1656. (WebCore::PopupListBox::abandon):
  1657. (WebCore::PopupListBox::updateFromElement):
  1658. 2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1659. Reviewed by Simon Hausmann.
  1660. [Qt] Disable a few warnings on Windows
  1661. * WebCore.pro:
  1662. 2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1663. Reviewed by Simon Hausmann.
  1664. [Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows
  1665. This define was brought in after refactoring some code from
  1666. PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.
  1667. * WebCore.pro:
  1668. 2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1669. Reviewed by Simon Hausmann.
  1670. [Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build
  1671. * WebCore.pro:
  1672. 2009-06-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  1673. Reviewed by Ariya Hidayat.
  1674. [Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
  1675. https://bugs.webkit.org/show_bug.cgi?id=26244
  1676. * WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if
  1677. NETSCAPE_PLUGIN_API is turned on
  1678. * plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
  1679. * plugins/PluginViewNone.cpp: Match guards with PluginView.h
  1680. 2009-06-07 Dan Bernstein <mitz@apple.com>
  1681. Reviewed by Sam Weinig.
  1682. - fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES
  1683. when the selection is inside a text field.
  1684. * editing/VisibleSelection.cpp:
  1685. (WebCore::VisibleSelection::isAll): Return false if the selection is in
  1686. a shadow tree.
  1687. 2009-06-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  1688. Reviewed by Holger Freyther.
  1689. https://bugs.webkit.org/show_bug.cgi?id=26106
  1690. [GTK] Crashes when you keep a combo open during a page transition, then close it
  1691. Hide the combo popup and disconnect from its signals during
  1692. PopupMenu destruction to handle this exceptional case with no
  1693. crash.
  1694. * platform/gtk/PopupMenuGtk.cpp:
  1695. (WebCore::PopupMenu::~PopupMenu):
  1696. (WebCore::PopupMenu::menuUnmapped):
  1697. 2009-06-06 Sam Weinig <sam@webkit.org>
  1698. Reviewed by Dan Bernstein.
  1699. Fix for <rdar://problem/6930540>
  1700. REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
  1701. Test: fast/css/font-family-builtins.html
  1702. * css/CSSComputedStyleDeclaration.cpp:
  1703. (WebCore::identifierForFamily): Fix typo. Fantasy family should be
  1704. -webkit-fantasy not, -webkit-serif.
  1705. 2009-06-06 Sam Weinig <sam@webkit.org>
  1706. Reviewed by Brady Eidson.
  1707. Fix for <rdar://problem/6936235>
  1708. Need to support StorageEvent.storageArea to meet the Web Storage spec
  1709. * storage/LocalStorageArea.cpp:
  1710. (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for
  1711. the frame being dispatched to.
  1712. * storage/SessionStorageArea.cpp:
  1713. (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.
  1714. * storage/StorageEvent.cpp:
  1715. (WebCore::StorageEvent::StorageEvent):
  1716. (WebCore::StorageEvent::initStorageEvent):
  1717. * storage/StorageEvent.h:
  1718. (WebCore::StorageEvent::create):
  1719. (WebCore::StorageEvent::storageArea):
  1720. * storage/StorageEvent.idl:
  1721. Add storageArea member.
  1722. 2009-06-05 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  1723. Reviewed by Anders Carlsson.
  1724. Fix WMLInputElement initialization code. Don't call initialize() on attach(), let
  1725. WMLCardElement handle initialization once, after the document has been parsed.
  1726. To keep layout tests working introduce a new function in Document.idl: initializeWMLPageState().
  1727. WMLTestCase.js (the wml/ layout test framework) will use it to simulate a regular WML document,
  1728. whose variable state gets initialized on WMLDocument::finishedParsing(). Force initialization
  1729. of the WML variable state, right after the dynamically created elements have been inserted into the tree.
  1730. * dom/Document.cpp:
  1731. (WebCore::Document::initializeWMLPageState):
  1732. * dom/Document.h:
  1733. * dom/Document.idl:
  1734. * wml/WMLCardElement.cpp:
  1735. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
  1736. * wml/WMLDocument.cpp:
  1737. (WebCore::WMLDocument::finishedParsing):
  1738. (WebCore::WMLDocument::initialize):
  1739. * wml/WMLDocument.h:
  1740. * wml/WMLInputElement.cpp:
  1741. (WebCore::WMLInputElement::initialize):
  1742. * wml/WMLInputElement.h:
  1743. 2009-06-05 Sam Weinig <sam@webkit.org>
  1744. Reviewed by Anders Carlsson.
  1745. Add ononline and onoffline attributes for the <body> element.
  1746. * html/HTMLAttributeNames.in: Added ononlineAttr and onofflineAttr.
  1747. * html/HTMLBodyElement.cpp:
  1748. (WebCore::HTMLBodyElement::parseMappedAttribute): Map ononlineAttr
  1749. and onofflineAttr to window event listeners.
  1750. 2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1751. Reviewed by Simon Hausmann.
  1752. [Qt] Add missing includes of config.h
  1753. * platform/qt/QWebPopup.cpp:
  1754. * platform/text/qt/TextBreakIteratorQt.cpp:
  1755. 2009-06-05 Fumitoshi Ukai <ukai@google.com>
  1756. Reviewed by Dimitri Glazkov.
  1757. https://bugs.webkit.org/show_bug.cgi?id=26215
  1758. Try to fix the Chromium build.
  1759. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  1760. (WebCore::fillBMPGlyphs):
  1761. (WebCore::fillNonBMPGlyphs):
  1762. 2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
  1763. Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
  1764. <https://bugs.webkit.org/show_bug.cgi?id=26160>
  1765. Reviewed by Alexey Proskuryakov.
  1766. Use /bin/ln instead of ln for cases where this command is used with -h option.
  1767. As this option is not supported by GNU fileutils, this change helps users
  1768. who have GNU fileutils in their PATH.
  1769. * WebCore.xcodeproj/project.pbxproj:
  1770. 2009-06-03 Ben Murdoch <benm@google.com>
  1771. <https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.
  1772. Reviewed by Alexey Proskuryakov.
  1773. Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading
  1774. Test: storage/hash-change-with-xhr.html
  1775. * loader/DocumentLoader.cpp:
  1776. (WebCore::DocumentLoader::stopLoading):
  1777. * loader/DocumentLoader.h:
  1778. * loader/FrameLoader.cpp:
  1779. (WebCore::FrameLoader::stopLoading):
  1780. (WebCore::FrameLoader::stopAllLoaders):
  1781. * loader/FrameLoader.h:
  1782. * loader/FrameLoaderTypes.h:
  1783. (WebCore::):
  1784. * page/Page.cpp:
  1785. (WebCore::Page::goToItem):
  1786. * WebCore.base.exp:
  1787. 2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1788. Reviewed by Simon Hausmann.
  1789. [Qt] Make sure the correct config.h is included when shadowbuilding
  1790. * WebCore.pro:
  1791. 2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1792. Reviewed by Simon Hausmann.
  1793. Fix Qt build after r44452
  1794. * platform/network/qt/QNetworkReplyHandler.cpp:
  1795. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  1796. 2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1797. Reviewed by Simon Hausmann.
  1798. [Qt] Remove some dead code (MenuEventProxy)
  1799. * WebCore.pro:
  1800. * platform/ContextMenu.h:
  1801. * platform/qt/ContextMenuQt.cpp:
  1802. * platform/qt/MenuEventProxy.h: Removed.
  1803. 2009-06-05 Xan Lopez <xlopez@igalia.com>
  1804. More build fixes.
  1805. * platform/graphics/gtk/GlyphPageTreeNodePango.cpp:
  1806. (WebCore::GlyphPage::fill):
  1807. 2009-06-05 Xan Lopez <xlopez@igalia.com>
  1808. Fix the GTK+ build.
  1809. * GNUmakefile.am:
  1810. * platform/graphics/gtk/FontCacheGtk.cpp:
  1811. (WebCore::FontCache::getFontDataForCharacters):
  1812. * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp:
  1813. (WebCore::GlyphPage::fill):
  1814. 2009-06-05 Antti Koivisto <antti@apple.com>
  1815. Try to fix Windows (and possibly other platforms) build.
  1816. Restore ResourceResponseBase::lastModifiedDate() and setLastModifiedDate() removed in previous commit.
  1817. for now since PluginStream used on some platforms expects them and calculations differ from plain
  1818. Last-modified header value.
  1819. Also include <wtf/MathExtras.h> to get isfinite().
  1820. * platform/network/ResourceResponseBase.cpp:
  1821. (WebCore::ResourceResponseBase::adopt):
  1822. (WebCore::ResourceResponseBase::copyData):
  1823. (WebCore::ResourceResponseBase::setLastModifiedDate):
  1824. (WebCore::ResourceResponseBase::lastModifiedDate):
  1825. * platform/network/ResourceResponseBase.h:
  1826. * platform/network/cf/ResourceResponseCFNet.cpp:
  1827. (WebCore::ResourceResponse::platformLazyInit):
  1828. 2009-06-03 Antti Koivisto <antti@apple.com>
  1829. Reviewed by Dave Kilzer.
  1830. https://bugs.webkit.org/show_bug.cgi?id=13128
  1831. Safari not obeying cache header
  1832. Implement RFC 2616 cache expiration calculations in WebKit instead of
  1833. relying on the networking layer.
  1834. * ForwardingHeaders/runtime/DateMath.h: Added.
  1835. * WebCore.base.exp:
  1836. * loader/Cache.cpp:
  1837. (WebCore::Cache::revalidationSucceeded):
  1838. * loader/CachedResource.cpp:
  1839. (WebCore::CachedResource::CachedResource):
  1840. (WebCore::CachedResource::isExpired):
  1841. (WebCore::CachedResource::currentAge):
  1842. (WebCore::CachedResource::freshnessLifetime):
  1843. (WebCore::CachedResource::setResponse):
  1844. (WebCore::CachedResource::updateResponseAfterRevalidation):
  1845. (WebCore::CachedResource::mustRevalidate):
  1846. * loader/CachedResource.h:
  1847. * platform/network/ResourceResponseBase.cpp:
  1848. (WebCore::ResourceResponseBase::ResourceResponseBase):
  1849. (WebCore::ResourceResponseBase::adopt):
  1850. (WebCore::ResourceResponseBase::copyData):
  1851. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  1852. (WebCore::ResourceResponseBase::parseCacheControlDirectives):
  1853. (WebCore::ResourceResponseBase::cacheControlContainsNoCache):
  1854. (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate):
  1855. (WebCore::ResourceResponseBase::cacheControlMaxAge):
  1856. (WebCore::parseDateValueInHeader):
  1857. (WebCore::ResourceResponseBase::date):
  1858. (WebCore::ResourceResponseBase::age):
  1859. (WebCore::ResourceResponseBase::expires):
  1860. (WebCore::ResourceResponseBase::lastModified):
  1861. (WebCore::ResourceResponseBase::isAttachment):
  1862. (WebCore::ResourceResponseBase::compare):
  1863. * platform/network/ResourceResponseBase.h:
  1864. * platform/network/cf/ResourceResponseCFNet.cpp:
  1865. (WebCore::ResourceResponse::platformLazyInit):
  1866. * platform/network/mac/ResourceResponseMac.mm:
  1867. (WebCore::ResourceResponse::platformLazyInit):
  1868. 2009-06-04 Roland Steiner <rolandsteiner@google.com>
  1869. Reviewed by Eric Seidel.
  1870. Bug 26201: Remove superfluous 'if' statements in RenderTable::addChild
  1871. https://bugs.webkit.org/show_bug.cgi?id=26201
  1872. * rendering/RenderTable.cpp:
  1873. (WebCore::RenderTable::addChild): remove superfluous 'if' statements
  1874. 2009-06-04 Roland Steiner <rolandsteiner@google.com>
  1875. Reviewed by Eric Seidel.
  1876. Bug 26202: add macros for primitive values to simplify CSSStyleSelector::applyProperty
  1877. https://bugs.webkit.org/show_bug.cgi?id=26202
  1878. * css/CSSStyleSelector.cpp: add HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE[_WITH_VALUE] macros
  1879. (WebCore::CSSStyleSelector::applyProperty): use new macros
  1880. 2009-06-04 Roland Steiner <rolandsteiner@google.com>
  1881. Reviewed by Eric Seidel
  1882. Bug 26203: Move parsing of 'attr(X)' values to own method
  1883. https://bugs.webkit.org/show_bug.cgi?id=26203
  1884. * css/CSSParser.cpp:
  1885. (WebCore::CSSParser::parseAttr): new method
  1886. (WebCore::CSSParser::parseContent): use new parseAttr method
  1887. * css/CSSParser.h:
  1888. (WebCore::CSSParser::parseAttr): new method
  1889. 2009-06-04 Roland Steiner <rolandsteiner@google.com>
  1890. Reviewed by Eric Seidel.
  1891. Bug 26205: RenderTableSection::addChild : correct comment
  1892. https://bugs.webkit.org/show_bug.cgi?id=26205
  1893. * rendering/RenderTableSection.cpp:
  1894. (WebCore::RenderTableSection::addChild): correct comment
  1895. 2009-06-04 Roland Steiner <rolandsteiner@google.com>
  1896. Reviewed by Eric Seidel.
  1897. Bug 26204: RenderBlock : simplify handleSpecialChild, comment correction
  1898. https://bugs.webkit.org/show_bug.cgi?id=26204
  1899. * rendering/RenderBlock.cpp:
  1900. (WebCore::RenderBlock::handleSpecialChild): simplify usage
  1901. (WebCore::RenderBlock::handlePositionedChild): simplify usage
  1902. (WebCore::RenderBlock::handleFloatingChild): simplify usage
  1903. (WebCore::RenderBlock::handleRunInChild): simplify usage
  1904. (WebCore::RenderBlock::layoutBlock): correct comment
  1905. (WebCore::RenderBlock::layoutBlockChildren): simplify loop, change call to handleSpecialChild
  1906. * rendering/RenderBlock.h:
  1907. (WebCore::RenderBlock::handleSpecialChild): change signature
  1908. (WebCore::RenderBlock::handlePositionedChild): change signature
  1909. (WebCore::RenderBlock::handleFloatingChild): change signature
  1910. (WebCore::RenderBlock::handleRunInChild): change signature
  1911. 2009-06-04 Dan Bernstein <mitz@apple.com>
  1912. - retry to fix the Tiger build
  1913. * platform/graphics/mac/SimpleFontDataMac.mm:
  1914. (WebCore::initFontData):
  1915. 2009-06-04 Dan Bernstein <mitz@apple.com>
  1916. - try to fix the Tiger build
  1917. * platform/graphics/SimpleFontData.h:
  1918. 2009-06-04 Dan Bernstein <mitz@apple.com>
  1919. - try to fix the Leopard and Tiger builds
  1920. * platform/graphics/SimpleFontData.h:
  1921. 2009-06-04 Dan Bernstein <mitz@apple.com>
  1922. - try to fix the Windows build
  1923. * platform/graphics/win/UniscribeController.cpp:
  1924. (WebCore::UniscribeController::shapeAndPlaceItem):
  1925. 2009-06-04 Dan Bernstein <mitz@apple.com>
  1926. Reviewed by Sam Weinig.
  1927. - make SimpleFontData's data members private
  1928. - rename SimpleFontData's m_font member to m_platformData
  1929. * platform/graphics/Font.h:
  1930. (WebCore::Font::spaceWidth):
  1931. * platform/graphics/SimpleFontData.cpp:
  1932. (WebCore::SimpleFontData::SimpleFontData):
  1933. * platform/graphics/SimpleFontData.h:
  1934. (WebCore::SimpleFontData::platformData):
  1935. (WebCore::SimpleFontData::spaceWidth):
  1936. (WebCore::SimpleFontData::adjustedSpaceWidth):
  1937. (WebCore::SimpleFontData::syntheticBoldOffset):
  1938. (WebCore::SimpleFontData::spaceGlyph):
  1939. (WebCore::SimpleFontData::getNSFont):
  1940. (WebCore::SimpleFontData::getQtFont):
  1941. (WebCore::SimpleFontData::getWxFont):
  1942. * platform/graphics/WidthIterator.cpp:
  1943. (WebCore::WidthIterator::advance):
  1944. * platform/graphics/cairo/FontCairo.cpp:
  1945. (WebCore::Font::drawGlyphs):
  1946. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  1947. (WebCore::SimpleFontData::platformInit):
  1948. (WebCore::SimpleFontData::smallCapsFontData):
  1949. (WebCore::SimpleFontData::determinePitch):
  1950. (WebCore::SimpleFontData::platformWidthForGlyph):
  1951. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  1952. (WebCore::SimpleFontData::platformInit):
  1953. (WebCore::SimpleFontData::smallCapsFontData):
  1954. (WebCore::SimpleFontData::containsCharacters):
  1955. (WebCore::SimpleFontData::platformWidthForGlyph):
  1956. * platform/graphics/gtk/FontGtk.cpp:
  1957. (WebCore::setPangoAttributes):
  1958. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  1959. (WebCore::SimpleFontData::platformInit):
  1960. (WebCore::SimpleFontData::containsCharacters):
  1961. (WebCore::SimpleFontData::determinePitch):
  1962. (WebCore::SimpleFontData::platformWidthForGlyph):
  1963. (WebCore::SimpleFontData::setFont):
  1964. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  1965. (WebCore::SimpleFontData::platformInit):
  1966. (WebCore::SimpleFontData::containsCharacters):
  1967. (WebCore::SimpleFontData::determinePitch):
  1968. (WebCore::SimpleFontData::platformWidthForGlyph):
  1969. (WebCore::SimpleFontData::setFont):
  1970. * platform/graphics/mac/CoreTextController.cpp:
  1971. (WebCore::CoreTextController::adjustGlyphsAndAdvances):
  1972. * platform/graphics/mac/FontMac.mm:
  1973. (WebCore::Font::drawGlyphs):
  1974. * platform/graphics/mac/FontMacATSUI.mm:
  1975. (WebCore::initializeATSUStyle):
  1976. (WebCore::overrideLayoutOperation):
  1977. (WebCore::ATSULayoutParameters::initialize):
  1978. * platform/graphics/mac/SimpleFontDataMac.mm:
  1979. (WebCore::initFontData):
  1980. (WebCore::SimpleFontData::platformInit):
  1981. (WebCore::SimpleFontData::platformCharWidthInit):
  1982. (WebCore::SimpleFontData::smallCapsFontData):
  1983. (WebCore::SimpleFontData::containsCharacters):
  1984. (WebCore::SimpleFontData::determinePitch):
  1985. (WebCore::SimpleFontData::platformWidthForGlyph):
  1986. (WebCore::SimpleFontData::checkShapesArabic):
  1987. (WebCore::SimpleFontData::getCTFont):
  1988. * platform/graphics/qt/SimpleFontDataQt.cpp:
  1989. (WebCore::SimpleFontData::determinePitch):
  1990. (WebCore::SimpleFontData::platformInit):
  1991. (WebCore::SimpleFontData::platformCharWidthInit):
  1992. * platform/graphics/win/FontCGWin.cpp:
  1993. (WebCore::drawGDIGlyphs):
  1994. (WebCore::Font::drawGlyphs):
  1995. * platform/graphics/win/SimpleFontDataCGWin.cpp:
  1996. (WebCore::SimpleFontData::platformInit):
  1997. (WebCore::SimpleFontData::platformCharWidthInit):
  1998. (WebCore::SimpleFontData::platformWidthForGlyph):
  1999. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  2000. (WebCore::SimpleFontData::platformInit):
  2001. (WebCore::SimpleFontData::platformDestroy):
  2002. (WebCore::SimpleFontData::platformWidthForGlyph):
  2003. (WebCore::SimpleFontData::setFont):
  2004. * platform/graphics/win/SimpleFontDataWin.cpp:
  2005. (WebCore::SimpleFontData::initGDIFont):
  2006. (WebCore::SimpleFontData::smallCapsFontData):
  2007. (WebCore::SimpleFontData::containsCharacters):
  2008. (WebCore::SimpleFontData::determinePitch):
  2009. (WebCore::SimpleFontData::widthForGDIGlyph):
  2010. (WebCore::SimpleFontData::scriptFontProperties):
  2011. * platform/graphics/wx/SimpleFontDataWx.cpp:
  2012. (WebCore::SimpleFontData::platformInit):
  2013. (WebCore::SimpleFontData::determinePitch):
  2014. (WebCore::SimpleFontData::platformWidthForGlyph):
  2015. 2009-06-04 Paul Godavari <paul@chromium.org>
  2016. Reviewed by Eric Seidel.
  2017. Initialize the width of PopupMenuListBox properly for Mac Chromium.
  2018. Added a test that works only with this patch applied. The test is
  2019. a manual one, since the hit testing infrastructure in the layout
  2020. tests sends keyboard and mouse events to the main window and not
  2021. the cocoa control that implements the popup up, which means we can't
  2022. select items from the popup up.
  2023. https://bugs.webkit.org/show_bug.cgi?id=25904
  2024. * manual-tests/select-narrow-width.html: Added.
  2025. * platform/chromium/PopupMenuChromium.cpp:
  2026. (WebCore::PopupListBox::PopupListBox):
  2027. (WebCore::PopupContainer::showExternal):
  2028. 2009-06-04 Brent Fulgham <bfulgham@webkit.org>
  2029. Unreviewed Windows build correction.
  2030. * WebCore.vcproj/WebCore.vcproj: Add missing 'ReplaceNodeWithSpanCommand.cpp'
  2031. and 'ReplaceNodeWithSpanCommand.h'
  2032. 2009-02-03 Eric Seidel <eric@webkit.org>
  2033. Reviewed by Justin Garcia.
  2034. Make sure execCommand("bold") on <b style="text-decoration: underline">test</b>
  2035. only removes the bold and not the underline.
  2036. https://bugs.webkit.org/show_bug.cgi?id=23496
  2037. Test: editing/execCommand/convert-style-elements-to-spans.html
  2038. * WebCore.xcodeproj/project.pbxproj:
  2039. * css/CSSStyleDeclaration.h:
  2040. (WebCore::CSSStyleDeclaration::isEmpty):
  2041. * dom/NamedAttrMap.h:
  2042. (WebCore::NamedAttrMap::isEmpty):
  2043. * editing/ApplyStyleCommand.cpp:
  2044. (WebCore::isUnstyledStyleSpan):
  2045. (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
  2046. (WebCore::ApplyStyleCommand::applyBlockStyle):
  2047. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  2048. (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle):
  2049. (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
  2050. (WebCore::ApplyStyleCommand::removeCSSStyle):
  2051. (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
  2052. (WebCore::ApplyStyleCommand::removeInlineStyle):
  2053. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  2054. * editing/ApplyStyleCommand.h:
  2055. * editing/CompositeEditCommand.cpp:
  2056. (WebCore::CompositeEditCommand::replaceNodeWithSpanPreservingChildrenAndAttributes):
  2057. * editing/CompositeEditCommand.h:
  2058. * editing/RemoveNodePreservingChildrenCommand.cpp:
  2059. (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
  2060. * editing/ReplaceNodeWithSpanCommand.cpp: Added.
  2061. (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand):
  2062. (WebCore::swapInNodePreservingAttributesAndChildren):
  2063. (WebCore::ReplaceNodeWithSpanCommand::doApply):
  2064. (WebCore::ReplaceNodeWithSpanCommand::doUnapply):
  2065. * editing/ReplaceNodeWithSpanCommand.h: Added.
  2066. (WebCore::ReplaceNodeWithSpanCommand::create):
  2067. 2009-06-04 Brent Fulgham <bfulgham@webkit.org>
  2068. Unreviewed build fix for Windows Cairo target.
  2069. Add missing post-build command to copy history/cf contents
  2070. to output directory.
  2071. * WebCore.vcproj/WebCore.vcproj: Update Debug_Cairo and Release_Cairo
  2072. target post-build steps with copy commands.
  2073. 2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
  2074. Reviewed by Simon Fraser.
  2075. <rdar://problem/6854695> Movie controller thumb fails to scale with full page zoom
  2076. Account for zoom level when drawing media controller thumb on Windows.
  2077. * rendering/RenderMediaControls.cpp:
  2078. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
  2079. 2009-06-04 David Hyatt <hyatt@apple.com>
  2080. Reviewed by Sam Weinig.
  2081. Move DOM window focus/blur out of SelectionController and into FocusController. Make sure it
  2082. fires on the focused frame when the page activation state changes also. This is covered by an existing
  2083. layout test (albeit badly). I have modified the test to be correct.
  2084. * editing/SelectionController.cpp:
  2085. (WebCore::SelectionController::setFocused):
  2086. * page/FocusController.cpp:
  2087. (WebCore::FocusController::setFocusedFrame):
  2088. (WebCore::FocusController::setActive):
  2089. 2009-06-04 Albert J. Wong <ajwong@chromium.org>
  2090. Reviewed by Eric Seidel.
  2091. https://bugs.webkit.org/show_bug.cgi?id=26148
  2092. Adding in empty files to stage the extract of RenderThemeChromiumSkia
  2093. from RenderThemeChromiumLinux and RenderThemeChromiumWindows.
  2094. * rendering/RenderThemeChromiumSkia.cpp: Added.
  2095. * rendering/RenderThemeChromiumSkia.h: Added.
  2096. 2009-06-04 Andrei Popescu <andreip@google.com>
  2097. Reviewed by Alexey Proskuryakov.
  2098. https://bugs.webkit.org/show_bug.cgi?id=25562
  2099. Potential crash after ApplicationCacheStorage::storeNewestCache() fails
  2100. Fix the crash by checking the return value of cacheStorage().storeNewestCache(this)
  2101. in WebCore::ApplicationCacheGroup::checkIfLoadIsComplete. If storeNewestCache failed,
  2102. we run the cache failure steps:
  2103. 1. Fire the error events to all pending master entries, as well any other cache hosts
  2104. currently associated with a cache in this group.
  2105. 2. Disassociate the pending master entries from the failed new cache.
  2106. 3. Reinstate the old "newest cache", if there was one.
  2107. We also introduce two other changes:
  2108. 1. a mechanism to rollback storageID changes to the in-memory resource
  2109. objects when the storing of an ApplicationCache object fails.
  2110. 2. defer removing the pending master entries from the list of pending master entries
  2111. until the entire load is complete. This matches the HTML 5 spec better. To track
  2112. if the load is complete we now introduce a counter for those pending master entries
  2113. that haven't yet finshed downloading.
  2114. * loader/appcache/ApplicationCacheGroup.cpp:
  2115. (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): initializes the new counter to 0
  2116. (WebCore::ApplicationCacheGroup::selectCache): increments the counter when a new pending
  2117. master entry is added.
  2118. (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): decrements the counter
  2119. instead of removing the pending master entry.
  2120. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): decrements the counter
  2121. instead of removing the pending master entry.
  2122. (WebCore::ApplicationCacheGroup::setNewestCache): removes an assertion that no longer
  2123. holds true. In particular, the newest cache is not necessarily new anymore. We can
  2124. set an old cache as the new cache. This can happen if we failed to store a newly
  2125. downloaded cache to the database and we are now reinstating the former newest cache.
  2126. (WebCore::ApplicationCacheGroup::manifestNotFound): resets the counter to 0.
  2127. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): check if the loading is complete
  2128. based on the counter instead of the list of pending master entries. Empty the list of
  2129. master entries if the load is complete.
  2130. * loader/appcache/ApplicationCacheGroup.h: add the new counter.
  2131. * loader/appcache/ApplicationCacheStorage.cpp: introduce the journaling mechanism for
  2132. in-memory resource objects.
  2133. (WebCore::ResourceStorageIDJournal::~ResourceStorageIDJournal):
  2134. (WebCore::ResourceStorageIDJournal::add):
  2135. (WebCore::ResourceStorageIDJournal::commit):
  2136. (WebCore::ResourceStorageIDJournal::Record::Record):
  2137. (WebCore::ResourceStorageIDJournal::Record::restore):
  2138. (WebCore::ApplicationCacheStorage::store): log the changes to the in-memory resource
  2139. objects.
  2140. (WebCore::ApplicationCacheStorage::storeNewestCache): create the journal object.
  2141. * loader/appcache/ApplicationCacheStorage.h: modify the signature of
  2142. bool store(ApplicationCache*) to add a pointer to the logger object used to
  2143. trace the changes to the storageID of the resource objects.
  2144. 2009-06-04 Jeremy Orlow <jorlow@chromium.org>
  2145. Reviewed by Darin Adler.
  2146. https://bugs.webkit.org/show_bug.cgi?id=26154
  2147. Allow underscores in the hostnames we parse out of databaseIdentifiers.
  2148. This code is used for HTML 5 database support.
  2149. * page/SecurityOrigin.cpp:
  2150. (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
  2151. 2009-06-04 Mihnea Ovidenie <mihnea@adobe.com>
  2152. Reviewed by Darin Adler.
  2153. Bug 26084: Multiple missing images in webkit-mask-image prevent rendering
  2154. https://bugs.webkit.org/show_bug.cgi?id=26084
  2155. When painting multiple images, make sure that at least one image is valid before pushing a transparency layer.
  2156. Added a manual test.
  2157. * manual-tests/mask-composite-missing-images.html: Added.
  2158. * rendering/RenderBox.cpp:
  2159. (WebCore::RenderBox::paintMaskImages):
  2160. 2009-06-04 Jeremy Orlow <jorlow@chromium.org>
  2161. Reviewed by Darin Adler.
  2162. https://bugs.webkit.org/show_bug.cgi?id=26180
  2163. Add a fast path for SecurityOrigin::equal. If "other == this" (where
  2164. other is the other security origin), then we really don't need to do
  2165. all the other (expensive) comparisons. We know it's equal.
  2166. * page/SecurityOrigin.cpp:
  2167. (WebCore::SecurityOrigin::equal):
  2168. 2009-06-03 David Hyatt <hyatt@apple.com>
  2169. Reviewed by Sam Weinig.
  2170. Improvements in how selection behaves with focus/activation and a reversion back to using isActive
  2171. in the scrollbar theme code to remove a Chromium ifdef.
  2172. * editing/SelectionController.cpp:
  2173. (WebCore::SelectionController::SelectionController):
  2174. Make the controller set its focused state correctly upon initial creation.
  2175. (WebCore::SelectionController::setSelection):
  2176. Make selection willing to shift the focus node if the selection is focused even if the
  2177. selection is not active. Whether or not the Page is active is irrelevant to focus changes.
  2178. (WebCore::SelectionController::setFocused):
  2179. * editing/SelectionController.h:
  2180. (WebCore::SelectionController::isFocused):
  2181. Add a new isFocused() method so that code can check if the Selection is focused without caring
  2182. about the active state.
  2183. * page/Frame.cpp:
  2184. (WebCore::Frame::setFocusedNodeIfNeeded):
  2185. Allow focus shifts even when the selection is not active.
  2186. * platform/mac/ScrollbarThemeMac.mm:
  2187. (WebCore::ScrollbarThemeMac::paint):
  2188. Revert Dan's change to directly talk to AppKit for checking active state. Now that the WebCore isActive
  2189. method works, ditch the Chromium-specific #ifdef and go back to the original code.
  2190. 2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
  2191. Reviewed by Darin Adler.
  2192. Test: media/before-load-member-access.html
  2193. https://bugs.webkit.org/show_bug.cgi?id=26081
  2194. * html/HTMLMediaElement.cpp:
  2195. (WebCore::HTMLMediaElement::played): Ensure that if m_playedTimeRanges,
  2196. is not initialized we return a valid range, and don't attempt to use it.
  2197. 2009-06-03 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  2198. Reviewed by Simon Hausmann.
  2199. Implement a way to invalidate the FontCache used by the Qt port.
  2200. * platform/graphics/qt/FontCacheQt.cpp:
  2201. (WebCore::FontCache::invalidate):
  2202. 2009-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  2203. Reviewed by Ariya Hidayat.
  2204. https://bugs.webkit.org/show_bug.cgi?id=26015
  2205. [Qt] Single-threaded QtWebKit configuration
  2206. Turn off Database, DOM storage, icon database and Web Workers support
  2207. when ENABLE_SINGLE_THREADED is turned on.
  2208. Set SQLITE_THREADSAFE to false to turn off SQLite mutexes
  2209. when ENABLE_SINGLE_THREADED is turned on.
  2210. * WebCore.pro:
  2211. 2009-06-03 Dan Bernstein <mitz@apple.com>
  2212. Reviewed by Sam Weinig.
  2213. - add some assertions that Font methods are used on the main thread
  2214. * platform/graphics/Font.cpp:
  2215. (WebCore::Font::setShouldUseSmoothing):
  2216. * platform/graphics/Font.h:
  2217. (WebCore::Font::primaryFont):
  2218. * platform/graphics/FontFastPath.cpp:
  2219. (WebCore::Font::glyphDataForCharacter):
  2220. 2009-06-03 Dan Bernstein <mitz@apple.com>
  2221. - Windows build fix
  2222. Rolled out apparently-accidental changes to config.h from r44398. These
  2223. were not part of the patch as reviewed.
  2224. * config.h:
  2225. 2009-06-03 Dmitry Titov <dimich@chromium.org>
  2226. Not reviewed, Chromium build fix.
  2227. https://bugs.webkit.org/show_bug.cgi?id=26177
  2228. Reverting 'private' to 'protected' on 2 classes.
  2229. Chromium glue layer (not yet in Webkit tree) relies on ability to derive
  2230. Chromium-specific platform classes and access the data members.
  2231. See bug for more details.
  2232. * platform/PlatformMouseEvent.h:
  2233. * platform/PlatformWheelEvent.h:
  2234. 2009-06-03 Chris Marrin <cmarrin@apple.com>
  2235. Reviewed by Simon Fraser <simonfr@apple.com>.
  2236. Fixed https://bugs.webkit.org/show_bug.cgi?id=26162
  2237. This corrects an error when destroying an animation
  2238. or transition where endAnimation was never getting
  2239. called and therefore the hardware animation was never
  2240. getting removed.
  2241. This includes a manual-test since it's really impossible
  2242. to make a meaningful automatic test for an animation
  2243. bug like this.
  2244. This has no effect unless accelerated compositing is
  2245. enabled.
  2246. * manual-tests/interrupted-compound-transform.html: Added.
  2247. * page/animation/ImplicitAnimation.cpp:
  2248. (WebCore::ImplicitAnimation::~ImplicitAnimation):
  2249. * page/animation/KeyframeAnimation.cpp:
  2250. (WebCore::KeyframeAnimation::~KeyframeAnimation):
  2251. 2009-06-03 Adam Langley <agl@google.com>
  2252. Reviewed by Eric Seidel.
  2253. Make the scrollbar thumb size twice the width for Chromium Linux. This
  2254. matches Firefox on Linux.
  2255. This will need layout test pixel results to be rebaselined in the
  2256. Chromium tree.
  2257. http://code.google.com/p/chromium/issues/detail?id=12602
  2258. https://bugs.webkit.org/show_bug.cgi?id=26176
  2259. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  2260. (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
  2261. * platform/chromium/ScrollbarThemeChromiumLinux.h:
  2262. 2009-06-03 Adam Langley <agl@google.com>
  2263. Reviewed by Eric Seidel.
  2264. Change Chromium scrollbar theme code to use different classes on
  2265. Windows and Linux rather than suppling symbols. The ScrollbarTheme
  2266. class is already using virtual dispatch, so there's no reason not to.
  2267. This should not affect any layout tests.
  2268. https://bugs.webkit.org/show_bug.cgi?id=26174
  2269. * platform/chromium/ScrollbarThemeChromium.cpp:
  2270. * platform/chromium/ScrollbarThemeChromium.h:
  2271. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  2272. (WebCore::ScrollbarTheme::nativeTheme):
  2273. (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
  2274. (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
  2275. (WebCore::ScrollbarThemeChromiumLinux::paintButton):
  2276. (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
  2277. (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
  2278. * platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
  2279. * platform/chromium/ScrollbarThemeChromiumWin.cpp:
  2280. (WebCore::ScrollbarTheme::nativeTheme):
  2281. (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
  2282. (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
  2283. (WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
  2284. (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
  2285. (WebCore::ScrollbarThemeChromiumWin::paintButton):
  2286. (WebCore::ScrollbarThemeChromiumWin::paintThumb):
  2287. (WebCore::ScrollbarThemeChromiumWin::getThemeState):
  2288. (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
  2289. (WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
  2290. (WebCore::ScrollbarThemeChromiumWin::buttonSize):
  2291. * platform/chromium/ScrollbarThemeChromiumWin.h: Added.
  2292. 2009-06-03 Pavel Feldman <pfeldman@chromium.org>
  2293. Reviewed by Timothy Hatcher.
  2294. Enabling debugger requires that Scripts panel is already attached to the
  2295. render tree. The reason is that recompile events result in script sources
  2296. being added into the source frames. Prior to the global options introduced,
  2297. debugger was enabled from the Scripts panel, so that it was guaranteed to
  2298. exist. The InspectorController::enableDebugger API calls with no inspector
  2299. frontend showing were failing though.
  2300. https://bugs.webkit.org/show_bug.cgi?id=26145
  2301. * WebCore.base.exp:
  2302. * inspector/InspectorController.cpp:
  2303. (WebCore::InspectorController::setWindowVisible):
  2304. (WebCore::InspectorController::scriptObjectReady):
  2305. (WebCore::InspectorController::enableDebuggerFromFrontend):
  2306. (WebCore::InspectorController::enableDebugger):
  2307. * inspector/InspectorController.h:
  2308. * inspector/InspectorController.idl:
  2309. * inspector/InspectorFrontend.cpp:
  2310. (WebCore::InspectorFrontend::attachDebuggerWhenShown):
  2311. * inspector/InspectorFrontend.h:
  2312. * inspector/front-end/ScriptsPanel.js:
  2313. (WebInspector.ScriptsPanel.prototype.show):
  2314. (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
  2315. * inspector/front-end/inspector.js:
  2316. (WebInspector.attachDebuggerWhenShown):
  2317. 2009-06-03 Dan Bernstein <mitz@apple.com>
  2318. Reviewed by Anders Carlsson.
  2319. - fix a regression from the previous patch
  2320. * platform/graphics/Font.cpp: Initialize shouldUseFontSmoothing to true.
  2321. 2009-06-03 Dan Bernstein <mitz@apple.com>
  2322. Reviewed by Anders Carlsson.
  2323. - eliminate WebCoreTextRenderer
  2324. * WebCore.base.exp: Updated.
  2325. * WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}
  2326. and promoted WebFontCache.h to private.
  2327. * platform/graphics/Font.cpp:
  2328. (WebCore::Font::setShouldUseSmoothing): Added this static setter for
  2329. a new file-static boolean.
  2330. (WebCore::Font::shouldUseSmoothing): Added this static getter.
  2331. * platform/graphics/Font.h: Decleared setShouldUseSmoothing() and
  2332. shouldUseSmoothing().
  2333. * platform/graphics/mac/FontMac.mm:
  2334. (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of
  2335. WebCoreShouldUseFontSmoothing().
  2336. * platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
  2337. * platform/mac/WebCoreTextRenderer.h: Removed.
  2338. * platform/mac/WebCoreTextRenderer.mm: Removed.
  2339. 2009-06-03 David Levin <levin@chromium.org>
  2340. Reviewed by Dimitri Glazkov.
  2341. v8's ScriptController::evaluate should protect the Frame like the jsc version.
  2342. https://bugs.webkit.org/show_bug.cgi?id=26172
  2343. This change is simply copying protections done for Frame in the method
  2344. WebCore::ScriptController::evaluate in the file js/ScriptController.cpp.
  2345. * bindings/v8/ScriptController.cpp:
  2346. (WebCore::ScriptController::evaluate):
  2347. 2009-06-03 Dan Bernstein <mitz@apple.com>
  2348. Reviewed by John Sullivan.
  2349. - fix <rdar://problem/6841120> Use CTFontManager notifications instead
  2350. of ATS notifications
  2351. * platform/graphics/FontCache.h: Made it an error to destroy a
  2352. FontCache instance.
  2353. * platform/graphics/mac/FontCacheMac.mm:
  2354. (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Added
  2355. this notification callback for the
  2356. kCTFontManagerRegisteredFontsChangedNotification, which calls
  2357. invalidate().
  2358. (WebCore::FontCache::platformInit): Register for
  2359. kCTFontManagerRegisteredFontsChangedNotification.
  2360. 2009-06-03 Kevin Watters <kevinwatters@gmail.com>
  2361. Reviewed by Kevin Ollivier.
  2362. Use CGContextShowGlyphsWithAdvances to get more accurate text rendering on Mac.
  2363. https://bugs.webkit.org/show_bug.cgi?id=26161
  2364. * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
  2365. (WebCore::drawTextWithSpacing):
  2366. 2009-06-03 Pavel Feldman <pfeldman@chromium.org>
  2367. Reviewed by Timothy Hatcher.
  2368. Reorder ResourcesPanel components initialization to unfreeze resource list scroller.
  2369. https://bugs.webkit.org/show_bug.cgi?id=26159
  2370. * inspector/front-end/ResourcesPanel.js:
  2371. (WebInspector.ResourcesPanel):
  2372. 2009-06-03 Pavel Feldman <pfeldman@chromium.org>
  2373. Reviewed by Timothy Hatcher.
  2374. - Fix for crash (preceded by assertion) in InspectorController::didCommitLoad
  2375. when reloading or navigating with the Inspector open.
  2376. - Fix for Inspector's Elements panel being empty when Inspector first appears.
  2377. https://bugs.webkit.org/show_bug.cgi?id=26134
  2378. https://bugs.webkit.org/show_bug.cgi?id=26135
  2379. * inspector/InspectorController.cpp:
  2380. (WebCore::InspectorController::scriptObjectReady):
  2381. (WebCore::InspectorController::didLoadResourceFromMemoryCache):
  2382. (WebCore::InspectorController::identifierForInitialRequest):
  2383. (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
  2384. * inspector/InspectorController.h:
  2385. 2009-06-03 Adam Roben <aroben@apple.com>
  2386. Windows build fix after r44379
  2387. * svg/graphics/SVGImage.cpp: Move EmptyClients.h back down below the
  2388. other #includes to fix a compiler warning on Windows.
  2389. 2009-06-02 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  2390. Reviewed by Simon Hausmann.
  2391. Add workaround for crash in Linux Flash Player when hosted by
  2392. another toolkit than GTK+. Bug fixed at the Flash Player bugzilla,
  2393. issue (FP-2140).
  2394. * plugins/qt/PluginViewQt.cpp:
  2395. (WebCore::PluginView::setNPWindowIfNeeded):
  2396. 2009-06-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  2397. Reviewed by Simon Hausmann.
  2398. Refactor the Qt plugin code to use NPP_SetWindow correctly,
  2399. to make resizing of plugins work.
  2400. Attention was paid to make sure that the windowed plugins scroll
  2401. synchronized with the page view. A manual test has been added.
  2402. * manual-tests/qt/plugin-iframe.html: Added.
  2403. * plugins/PluginView.cpp:
  2404. (WebCore::PluginView::setFrameRect):
  2405. (WebCore::PluginView::frameRectsChanged):
  2406. * plugins/PluginView.h:
  2407. * plugins/qt/PluginContainerQt.cpp:
  2408. (PluginContainerQt::PluginContainerQt):
  2409. * plugins/qt/PluginContainerQt.h:
  2410. * plugins/qt/PluginPackageQt.cpp:
  2411. (WebCore::PluginPackage::load):
  2412. * plugins/qt/PluginViewQt.cpp:
  2413. (WebCore::PluginView::updatePluginWidget):
  2414. (WebCore::PluginView::paint):
  2415. (WebCore::PluginView::setParent):
  2416. (WebCore::PluginView::setNPWindowRect):
  2417. (WebCore::PluginView::setNPWindowIfNeeded):
  2418. (WebCore::PluginView::handlePostReadFile):
  2419. (WebCore::PluginView::getValue):
  2420. (WebCore::PluginView::invalidateRect):
  2421. (WebCore::PluginView::init):
  2422. 2009-06-02 Darin Adler <darin@apple.com>
  2423. Reviewed by David Hyatt.
  2424. Bug 26112: viewless WebKit -- make events work
  2425. https://bugs.webkit.org/show_bug.cgi?id=26112
  2426. The main fix here is to make mouse and wheel event coordinates in the coordinate
  2427. system of the top level NSView rather than the NSWindow when in the viewless mode.
  2428. This is the design Hyatt chose, but the event part of it wasn't done yet.
  2429. Also fix FrameView to do normal reference counting instead of a strange model with
  2430. an explicit deref near creation time.
  2431. * WebCore.base.exp: Updated.
  2432. * page/EventHandler.cpp:
  2433. (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file
  2434. to reduce conditionals in the header.
  2435. (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
  2436. * page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types.
  2437. Made currentNSEvent a static member function. Added sendContextMenuEvent and
  2438. eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent
  2439. can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and
  2440. eventLoopHandleMouseDragged unconditional.
  2441. * page/Frame.cpp:
  2442. (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership.
  2443. (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove
  2444. the explicit deref.
  2445. * page/Frame.h: Changed setView to take a PassRefPtr.
  2446. * page/FrameTree.cpp: Added newly-needed include.
  2447. * page/FrameView.cpp:
  2448. (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed
  2449. the initialization of m_refCount and call to show from the reamining one.
  2450. (WebCore::FrameView::create): Added two create functions that do what the two
  2451. constructors did before, except that they return a PassRefPtr to make sure the
  2452. reference counting is handled correctly.
  2453. (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented
  2454. its own reference counting.
  2455. * page/FrameView.h: Inherit from RefCounted for reference counting. Made the
  2456. constructor private and added create functions. Got rid of the hand-implemented
  2457. reference counting in this class.
  2458. * page/mac/EventHandlerMac.mm:
  2459. (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to
  2460. make it more clear how it relates to currentNSEvent.
  2461. (WebCore::EventHandler::currentNSEvent): Updated.
  2462. (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the
  2463. current event in a foolproof way.
  2464. (WebCore::CurrentEventScope::~CurrentEventScope): Ditto.
  2465. (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform
  2466. window in when constructing the PlatformWheelEvent.
  2467. (WebCore::EventHandler::keyEvent): Use CurrentEventScope.
  2468. (WebCore::lastEventIsMouseUp): Use currentNSEvent.
  2469. (WebCore::EventHandler::passMouseDownEventToWidget): Ditto.
  2470. (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
  2471. (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto.
  2472. (WebCore::EventHandler::passSubframeEventToSubframe): Use
  2473. currentPlatformMouseEvent to get a mouse event that has the appropriate
  2474. platform window passed to create it.
  2475. (WebCore::EventHandler::passWheelEventToWidget): Ditto.
  2476. (WebCore::EventHandler::mouseDown): Ditto.
  2477. (WebCore::EventHandler::mouseDragged): Ditto.
  2478. (WebCore::EventHandler::mouseUp): Ditto.
  2479. (WebCore::EventHandler::mouseMoved): Ditto.
  2480. (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the
  2481. platform window that's now needed to create a PlatformMouseEvent.
  2482. (WebCore::EventHandler::sendContextMenuEvent): Added.
  2483. (WebCore::EventHandler::eventMayStartDrag): Added.
  2484. * platform/HostWindow.h: Removed unneeded includes and constructor definition.
  2485. * platform/PlatformMouseEvent.h: Sorted things in alphabetical order.
  2486. Changed Mac constructor to take a windowView as well as the event. This is
  2487. needed in viewless mode, since the "window" is actually an NSView, so the
  2488. event has to know which view to compute the coordinates with. Made the
  2489. same change to pointForEvent.
  2490. * platform/PlatformWheelEvent.h: Ditto.
  2491. * platform/mac/PlatformMouseEventMac.mm:
  2492. (WebCore::pointForEvent): Convert point from window coordinates to view
  2493. coordinates if a windowView is passed in. This is used in viewless mode.
  2494. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
  2495. * platform/mac/WheelEventMac.mm:
  2496. (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.
  2497. * platform/mac/WidgetMac.mm:
  2498. (WebCore::Widget::convertFromContainingWindow): Fixed case where there
  2499. is no platform widget and no parent. Before it would yield unpredictable
  2500. results because of dispatching to a nil object and returning a structure.
  2501. Now it returns the point without changing coordinates at all, which is what
  2502. we need for this case in viewless mode.
  2503. * rendering/RenderApplet.cpp: Removed unneeded includes.
  2504. (WebCore::RenderApplet::intrinsicSize): Use widget function.
  2505. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.
  2506. * rendering/RenderApplet.h: Make more things private. Get rid of unneeded
  2507. explicit destructor.
  2508. * rendering/RenderFrame.cpp: Removed unneeded includes.
  2509. (WebCore::RenderFrame::edgeInfo): Updated to use node function so header
  2510. doesn't have to define element function.
  2511. (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget
  2512. function.
  2513. * rendering/RenderFrame.h: Removed unneeded includes. Made some things
  2514. private. Got rid of element function.
  2515. * rendering/RenderPart.cpp: Removed unneeded includes.
  2516. (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function.
  2517. (WebCore::RenderPart::setWidget): Changed to use widget function.
  2518. (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget.
  2519. This is now only called by the clearWidget function.
  2520. * rendering/RenderPart.h: Removed unneeded forward declarations.
  2521. Made more functions private. Updated deleteWidget to take widget argument.
  2522. * rendering/RenderPartObject.cpp:
  2523. (WebCore::RenderPartObject::~RenderPartObject): use frameView function
  2524. instead of getting at m_view directly.
  2525. (WebCore::RenderPartObject::updateWidget): Ditto.
  2526. (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget.
  2527. (WebCore::RenderPartObject::viewCleared): Ditto.
  2528. * rendering/RenderPartObject.h: Made some functions private.
  2529. * rendering/RenderWidget.cpp:
  2530. (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with
  2531. construction syntax instead of assignment.
  2532. (WebCore::RenderWidget::destroy): Updated for name change of m_view
  2533. to m_frameView.
  2534. (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete
  2535. the widget.
  2536. (WebCore::RenderWidget::setWidget): Use clearWidget.
  2537. (WebCore::RenderWidget::paint): Updated for name change of m_view
  2538. to m_frameView.
  2539. (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.
  2540. * rendering/RenderWidget.h: Made many functions protected, others
  2541. private and made all data members private.
  2542. * svg/animation/SMILTime.h: Removed unhelpful max and min functions. These
  2543. just do what std::max and std::min will already do automatically for this
  2544. type, so they are not helpful.
  2545. * svg/graphics/SVGImage.cpp:
  2546. (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types
  2547. that initialize to zero without anything explicit.
  2548. (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are
  2549. no longer stored.
  2550. (WebCore::SVGImage::setContainerSize): Ditto.
  2551. (WebCore::SVGImage::usesContainerSize): Ditto.
  2552. (WebCore::SVGImage::size): Ditto.
  2553. (WebCore::SVGImage::hasRelativeWidth): Ditto.
  2554. (WebCore::SVGImage::hasRelativeHeight): Ditto.
  2555. (WebCore::SVGImage::draw): Ditto.
  2556. (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto.
  2557. (WebCore::SVGImage::dataChanged): Ditto.
  2558. * svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data
  2559. members m_document, m_frame, m_frameView, and m_minSize.
  2560. 2009-06-02 Adam Langley <agl@google.com>
  2561. Reviewed by Eric Seidel.
  2562. The previous code was assuming that we'll be painting buttons on the scrollbar
  2563. which isn't true on Linux. To reproduce, resize a page with scrollbars until
  2564. they are less than two widths high.
  2565. This will need pixel test baselines to be updated in the Chromium tree.
  2566. * platform/chromium/ScrollbarThemeChromium.cpp: move this function...
  2567. * platform/chromium/ScrollbarThemeChromiumWin.cpp:
  2568. (WebCore::ScrollbarThemeChromium::trackRect): ... to here
  2569. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  2570. (WebCore::ScrollbarThemeChromium::trackRect): add an alternative which
  2571. doesn't remove the track when the scrollbar is less than two widths
  2572. high.
  2573. 2009-06-02 Mark Rowe <mrowe@apple.com>
  2574. Reviewed by Anders Carlsson.
  2575. Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.
  2576. * Configurations/Base.xcconfig:
  2577. 2009-06-02 Eric Seidel <eric@webkit.org>
  2578. Reviewed by Maciej Stachowiak.
  2579. Insert*List on an stand-alone image in a content editable region ASSERTS
  2580. ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
  2581. https://bugs.webkit.org/show_bug.cgi?id=19066
  2582. Attempt to fix this by noticing that we inserted the list inside
  2583. the selection which includes the image, and re-adjust the selection
  2584. to not include the list before trying to move the image into
  2585. the list item.
  2586. Test: editing/execCommand/list-wrapping-image-crash.html
  2587. * editing/InsertListCommand.cpp:
  2588. (WebCore::InsertListCommand::doApply):
  2589. 2009-06-02 Eric Seidel <eric@webkit.org>
  2590. Reviewed by Darin Adler.
  2591. Rename PositionIterator members in hope of further clarity
  2592. https://bugs.webkit.org/show_bug.cgi?id=24854
  2593. Rename m_parent to m_anchorNode (since although it's always the parent
  2594. of the previous m_child member, it is not always the parent of the effective position)
  2595. Rename m_child to m_nodeAfterPositionInAnchor to make clear that it's the node
  2596. directly following the position. This member is often NULL, but is always
  2597. a child of m_parent, now m_anchorNode if set.
  2598. Rename m_offset to m_offsetInAnchor (since it's interpreted relative to m_anchorNode)
  2599. * dom/PositionIterator.cpp:
  2600. (WebCore::PositionIterator::operator Position):
  2601. (WebCore::PositionIterator::increment):
  2602. (WebCore::PositionIterator::decrement):
  2603. (WebCore::PositionIterator::atStart):
  2604. (WebCore::PositionIterator::atEnd):
  2605. (WebCore::PositionIterator::atStartOfNode):
  2606. (WebCore::PositionIterator::atEndOfNode):
  2607. (WebCore::PositionIterator::isCandidate):
  2608. * dom/PositionIterator.h:
  2609. (WebCore::PositionIterator::PositionIterator):
  2610. (WebCore::PositionIterator::node):
  2611. (WebCore::PositionIterator::offsetInLeafNode):
  2612. 2009-06-02 Julien Chaffraix <jchaffraix@webkit.org>
  2613. Reviewed by Eric Seidel.
  2614. Bug 17167: Failures in fast/dom/Node/initial-values.html
  2615. This partly solve a compatibility issue with other browsers. It will also
  2616. make us more consistent while handling XHTML element.
  2617. The issue is that when we create an XHTML element inside an HTML document
  2618. (as it is the case when calling createElementNS), we default to the HTML
  2619. behaviour in nodeName. As we cannot test if an HTMLElement is an XHTML
  2620. element, our fix is to check whether it has a prefix and then default
  2621. to XML behaviour for nodeName.
  2622. * html/HTMLElement.cpp:
  2623. (WebCore::HTMLElement::nodeName): Add a prefix check before
  2624. returning the uppercase tagName (HTML behaviour).
  2625. 2009-06-02 Eric Seidel <eric@webkit.org>
  2626. Reviewed by Maciej Stachowiak.
  2627. Add a compareBoundaryPoints which takes RangeBoundaryPoints
  2628. https://bugs.webkit.org/show_bug.cgi?id=25500
  2629. I noticed the need for this function when removing compareBoundaryPoints(Position, Position)
  2630. This patch is almost entirely minus lines.
  2631. No functional changes, thus no tests.
  2632. * dom/Range.cpp:
  2633. (WebCore::Range::setStart):
  2634. (WebCore::Range::setEnd):
  2635. (WebCore::Range::compareBoundaryPoints):
  2636. (WebCore::Range::boundaryPointsValid):
  2637. * dom/Range.h:
  2638. 2009-06-02 Eric Seidel <eric@webkit.org>
  2639. Reviewed by Maciej Stachowiak.
  2640. Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
  2641. https://bugs.webkit.org/show_bug.cgi?id=25500
  2642. Darin indicated the Range should deal only with primitive DOM node/offset
  2643. pairs, and that Position (which is a more robust editing construct) should have
  2644. its own comparison functions and that Range.h should not mention Position at all.
  2645. Turns out that Position already has a comparePositions() function (which knows
  2646. how to additionally handled positions in shadow trees). So I've just changed
  2647. all callers of compareBoundaryPoints(Position, Position) to use the existing
  2648. comparePositions() function. I've also added a comparePositions which takes
  2649. VisiblePositions for convenience.
  2650. * dom/Range.cpp:
  2651. * dom/Range.h:
  2652. * editing/ApplyStyleCommand.cpp:
  2653. (WebCore::ApplyStyleCommand::updateStartEnd):
  2654. (WebCore::ApplyStyleCommand::applyBlockStyle):
  2655. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  2656. (WebCore::ApplyStyleCommand::applyInlineStyle):
  2657. (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
  2658. (WebCore::ApplyStyleCommand::removeInlineStyle):
  2659. (WebCore::ApplyStyleCommand::nodeFullySelected):
  2660. (WebCore::ApplyStyleCommand::nodeFullyUnselected):
  2661. * editing/CompositeEditCommand.cpp:
  2662. (WebCore::CompositeEditCommand::deleteInsignificantText):
  2663. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
  2664. (WebCore::CompositeEditCommand::moveParagraphs):
  2665. * editing/DeleteSelectionCommand.cpp:
  2666. (WebCore::DeleteSelectionCommand::initializeStartEnd):
  2667. (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  2668. (WebCore::DeleteSelectionCommand::mergeParagraphs):
  2669. * editing/SelectionController.cpp:
  2670. (WebCore::SelectionController::nodeWillBeRemoved):
  2671. * editing/VisibleSelection.cpp:
  2672. (WebCore::VisibleSelection::toNormalizedRange):
  2673. * editing/htmlediting.cpp:
  2674. (WebCore::comparePositions):
  2675. * editing/htmlediting.h:
  2676. * page/EventHandler.cpp:
  2677. (WebCore::EventHandler::handleMousePressEventSingleClick):
  2678. 2009-06-02 Albert J. Wong <ajwong@chromium.org>
  2679. Reviewed by Dimitri Glazkov.
  2680. https://bugs.webkit.org/show_bug.cgi?id=26122
  2681. Upstream v8_utility.h functions into V8Utilities.h. This patch has
  2682. some transitional code to make upstreaming easier. This code will
  2683. be deleted in a few days.
  2684. * bindings/v8/ScriptFunctionCall.cpp:
  2685. (WebCore::ScriptFunctionCall::construct): NewInstance -> newInstance.
  2686. * bindings/v8/V8Utilities.h:
  2687. (WebCore::AllowAllocation::AllowAllocation): Function added.
  2688. (WebCore::AllowAllocation::~AllowAllocation): Function added.
  2689. (WebCore::SafeAllocation::NewInstance): Function added.
  2690. * bindings/v8/WorkerContextExecutionProxy.cpp:
  2691. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
  2692. NewInstance -> newInstance.
  2693. (WebCore::WorkerContextExecutionProxy::toV8): NewInstance ->
  2694. newInstance.
  2695. 2009-06-02 Dan Bernstein <mitz@apple.com>
  2696. Reviewed by John Sullivan.
  2697. - fix <rdar://problem/6940747> Search field’s focus ring is outset
  2698. * rendering/RenderThemeWin.cpp:
  2699. (WebCore::RenderThemeWin::adjustSearchFieldStyle): Set the focused
  2700. search field outline offset to -2.
  2701. 2009-06-02 Sam Weinig <sam@webkit.org>
  2702. Reviewed by Alexey Proskuryakov.
  2703. Add list of unimplemented event handlers to DOMWindow.
  2704. * page/DOMWindow.idl:
  2705. 2009-06-02 Alexey Proskuryakov <ap@webkit.org>
  2706. Reviewed by Sam Weinig.
  2707. https://bugs.webkit.org/show_bug.cgi?id=26133
  2708. Adapt and import py-dom-xpath tests
  2709. Tests: fast/xpath/py-dom-xpath/abbreviations.html
  2710. fast/xpath/py-dom-xpath/axes.html
  2711. fast/xpath/py-dom-xpath/data.html
  2712. fast/xpath/py-dom-xpath/expressions.html
  2713. fast/xpath/py-dom-xpath/functions.html
  2714. fast/xpath/py-dom-xpath/nodetests.html
  2715. fast/xpath/py-dom-xpath/paths.html
  2716. fast/xpath/py-dom-xpath/predicates.html
  2717. Fix bugs found with this test suite:
  2718. - name and local-name were incorrect for processing instructions (XPath expanded-name
  2719. doesn't match DOM exactly);
  2720. - name, local-name and namespace functions should crash on attribute nodes;
  2721. - attemps to make node sets from other types were not detected as errors.
  2722. No performance impact.
  2723. * xml/XPathExpressionNode.h: Track type conversion errors that happen during evaluation.
  2724. An error won't stop evaluation, but an exception will be raised afterwards. We could also
  2725. detect conversion errors at compile time, but not if we're going to support XPath variables
  2726. (which is unnecessary for XPathEvaluator, but will be necessary if we decide to make our own
  2727. XSLT one day).
  2728. * xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Check whether a type
  2729. conversion exception occurred during evaluation, and raise an excpetion if it did.
  2730. * xml/XPathFunctions.cpp:
  2731. (WebCore::XPath::expandedNameLocalPart):
  2732. (WebCore::XPath::expandedName):
  2733. XPath name(), local-name() and namespace-uri() functions are defined in terms of expanded-name,
  2734. which doesn't match anything available via DOM exactly. Calculate the expanded name properly.
  2735. (WebCore::XPath::FunNamespaceURI::evaluate): This function could crash if used with an
  2736. attribute node, because it released what was possibly the only reference to attribute node
  2737. before using it. Changed the function to avoid such situation.
  2738. (WebCore::XPath::FunLocalName::evaluate): Ditto. Also, used the new expandedNameLocalPart()
  2739. to work properly with processing instruction nodes.
  2740. (WebCore::XPath::FunName::evaluate): Ditto (using expandedName()).
  2741. (WebCore::XPath::FunCount::evaluate): Signal an error if the argument is not a node-set
  2742. (by using toNodeSet unconditionally, which will raise an error, and return an empty set).
  2743. * xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Signal an error if the expression
  2744. evaluation result is not a node-set.
  2745. * xml/XPathPath.h: (WebCore::XPath::Filter::resultType): A Filter's result is actually
  2746. always a node-set (this is not so for FilterExpr production in the spec, but is for us,
  2747. because we don't naively map BNF productions to classes).
  2748. * xml/XPathPredicate.cpp: (WebCore::XPath::Union::evaluate): Signal an error if either side
  2749. is not a node-set.
  2750. * xml/XPathStep.cpp: Removed an unnecesary include.
  2751. * xml/XPathValue.cpp:
  2752. (WebCore::XPath::Value::toNodeSet): Signal an error if conversion fails.
  2753. (WebCore::XPath::Value::modifiableNodeSet): Ditto.
  2754. (WebCore::XPath::Value::toNumber): Don't allow inputs that don't match XPath Number production
  2755. (in particular, those using exponential notation).
  2756. 2009-06-01 Sam Weinig <sam@webkit.org>
  2757. Reviewed by Brady Eidson.
  2758. Part of https://bugs.webkit.org/show_bug.cgi?id=26100
  2759. Add missing event handler properties to the DOMWindow
  2760. Added oncontextmenu, oninput, and onmessage event handlers to
  2761. the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
  2762. and onsuspend event handlers were implemented but not added to
  2763. DOMWindow.idl.
  2764. * page/DOMWindow.cpp:
  2765. (WebCore::DOMWindow::oninput):
  2766. (WebCore::DOMWindow::setOninput):
  2767. (WebCore::DOMWindow::onmessage):
  2768. (WebCore::DOMWindow::setOnmessage):
  2769. (WebCore::DOMWindow::oncontextmenu):
  2770. (WebCore::DOMWindow::setOncontextmenu):
  2771. * page/DOMWindow.h:
  2772. * page/DOMWindow.idl:
  2773. 2009-06-01 Jeremy Orlow <jorlow@chromium.org>
  2774. Reviewed by Darin Adler. Landed by Adam Barth.
  2775. https://bugs.webkit.org/show_bug.cgi?id=26123
  2776. Remove a redundant checkEncodedString call when constructing a
  2777. KURL object from a string.
  2778. * platform/KURL.cpp:
  2779. (WebCore::KURL::KURL):
  2780. 2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
  2781. Unreviewed, build fix.
  2782. Reposition platform guard, improperly placed by http://trac.webkit.org/changeset/44340
  2783. Bad Dimitri.
  2784. * platform/KeyboardCodes.h: Repositioned the guard to avoid nested
  2785. WebCore namespace declarations.
  2786. 2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
  2787. Unreviewed, build fix.
  2788. * platform/KeyboardCodes.h: Integrated contents of platform/chromium/KeyboardCodes.h
  2789. with a stern FIXME.
  2790. * platform/chromium/KeyboardCodes.h: Removed.
  2791. 2009-06-01 Nikolas Zimmermann <zimmermann@kde.org>
  2792. Reviewed by Eric Seidel.
  2793. Fix assertion error in --filters enabled debug builds.
  2794. Instead of using RefPtr<AtomicStringImpl> as keys for the hash maps in SVGFilterBuilder, just use AtomicString objects.
  2795. * svg/graphics/filters/SVGFilterBuilder.cpp:
  2796. (WebCore::SVGFilterBuilder::SVGFilterBuilder):
  2797. (WebCore::SVGFilterBuilder::add):
  2798. (WebCore::SVGFilterBuilder::getEffectById):
  2799. * svg/graphics/filters/SVGFilterBuilder.h:
  2800. 2009-06-01 Nikolas Zimmermann <zimmermann@kde.org>
  2801. Reviewed by Eric Seidel.
  2802. Fix --filters enabled build on Mac.
  2803. Remove unnecessary 'boundingBox' parameter from finishRenderSVGContent() method.
  2804. Kill several warnings, to make build pass.
  2805. * rendering/RenderPath.cpp:
  2806. (WebCore::RenderPath::paint):
  2807. * rendering/RenderSVGContainer.cpp:
  2808. (WebCore::RenderSVGContainer::paint):
  2809. * rendering/RenderSVGImage.cpp:
  2810. (WebCore::RenderSVGImage::paint):
  2811. * rendering/RenderSVGRoot.cpp:
  2812. (WebCore::RenderSVGRoot::paint):
  2813. * rendering/SVGRenderSupport.cpp:
  2814. (WebCore::SVGRenderBase::finishRenderSVGContent):
  2815. * rendering/SVGRenderSupport.h:
  2816. * rendering/SVGRootInlineBox.cpp:
  2817. (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
  2818. * svg/SVGFEGaussianBlurElement.cpp:
  2819. (WebCore::SVGFEGaussianBlurElement::setStdDeviation):
  2820. * svg/graphics/filters/SVGFEFlood.cpp:
  2821. (WebCore::FEFlood::FEFlood):
  2822. 2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
  2823. Reviewed by Dave Hyatt.
  2824. Fix Chromium build by adding an #ifdef, restoring the code path to that
  2825. before http://trac.webkit.org/changeset/44287.
  2826. * platform/mac/ScrollbarThemeMac.mm:
  2827. (WebCore::ScrollbarThemeMac::paint): Added an #ifdef.
  2828. 2009-06-01 Dirk Schulze <krit@webkit.org>
  2829. Reviewed by Nikolas Zimmermann.
  2830. Remove last pieces of the old SVG filter system. They are not
  2831. usable with our current filter system. The new filter effects
  2832. will replace the functionality step by step.
  2833. * GNUmakefile.am:
  2834. * WebCore.pro:
  2835. * WebCore.vcproj/WebCore.vcproj:
  2836. * WebCore.xcodeproj/project.pbxproj:
  2837. * svg/graphics/cairo: Removed.
  2838. * svg/graphics/cairo/SVGResourceFilterCairo.cpp: Removed.
  2839. * svg/graphics/cg: Removed.
  2840. * svg/graphics/cg/SVGResourceFilterCg.cpp: Removed.
  2841. * svg/graphics/cg/SVGResourceFilterCg.mm: Removed.
  2842. * svg/graphics/filters/SVGFilterEffect.cpp: Removed.
  2843. * svg/graphics/filters/SVGFilterEffect.h: Removed.
  2844. * svg/graphics/filters/cg: Removed.
  2845. * svg/graphics/filters/cg/SVGFEHelpersCg.h: Removed.
  2846. * svg/graphics/filters/cg/SVGFEHelpersCg.mm: Removed.
  2847. * svg/graphics/filters/cg/SVGFilterEffectCg.mm: Removed.
  2848. * svg/graphics/filters/cg/WKArithmeticFilter.cikernel: Removed.
  2849. * svg/graphics/filters/cg/WKArithmeticFilter.h: Removed.
  2850. * svg/graphics/filters/cg/WKArithmeticFilter.m: Removed.
  2851. * svg/graphics/filters/cg/WKComponentMergeFilter.cikernel: Removed.
  2852. * svg/graphics/filters/cg/WKComponentMergeFilter.h: Removed.
  2853. * svg/graphics/filters/cg/WKComponentMergeFilter.m: Removed.
  2854. * svg/graphics/filters/cg/WKDiffuseLightingFilter.cikernel: Removed.
  2855. * svg/graphics/filters/cg/WKDiffuseLightingFilter.h: Removed.
  2856. * svg/graphics/filters/cg/WKDiffuseLightingFilter.m: Removed.
  2857. * svg/graphics/filters/cg/WKDiscreteTransferFilter.cikernel: Removed.
  2858. * svg/graphics/filters/cg/WKDiscreteTransferFilter.h: Removed.
  2859. * svg/graphics/filters/cg/WKDiscreteTransferFilter.m: Removed.
  2860. * svg/graphics/filters/cg/WKDisplacementMapFilter.cikernel: Removed.
  2861. * svg/graphics/filters/cg/WKDisplacementMapFilter.h: Removed.
  2862. * svg/graphics/filters/cg/WKDisplacementMapFilter.m: Removed.
  2863. * svg/graphics/filters/cg/WKDistantLightFilter.cikernel: Removed.
  2864. * svg/graphics/filters/cg/WKDistantLightFilter.h: Removed.
  2865. * svg/graphics/filters/cg/WKDistantLightFilter.m: Removed.
  2866. * svg/graphics/filters/cg/WKGammaTransferFilter.cikernel: Removed.
  2867. * svg/graphics/filters/cg/WKGammaTransferFilter.h: Removed.
  2868. * svg/graphics/filters/cg/WKGammaTransferFilter.m: Removed.
  2869. * svg/graphics/filters/cg/WKIdentityTransferFilter.h: Removed.
  2870. * svg/graphics/filters/cg/WKIdentityTransferFilter.m: Removed.
  2871. * svg/graphics/filters/cg/WKLinearTransferFilter.cikernel: Removed.
  2872. * svg/graphics/filters/cg/WKLinearTransferFilter.h: Removed.
  2873. * svg/graphics/filters/cg/WKLinearTransferFilter.m: Removed.
  2874. * svg/graphics/filters/cg/WKNormalMapFilter.cikernel: Removed.
  2875. * svg/graphics/filters/cg/WKNormalMapFilter.h: Removed.
  2876. * svg/graphics/filters/cg/WKNormalMapFilter.m: Removed.
  2877. * svg/graphics/filters/cg/WKPointLightFilter.cikernel: Removed.
  2878. * svg/graphics/filters/cg/WKPointLightFilter.h: Removed.
  2879. * svg/graphics/filters/cg/WKPointLightFilter.m: Removed.
  2880. * svg/graphics/filters/cg/WKSpecularLightingFilter.cikernel: Removed.
  2881. * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Removed.
  2882. * svg/graphics/filters/cg/WKSpecularLightingFilter.m: Removed.
  2883. * svg/graphics/filters/cg/WKSpotLightFilter.cikernel: Removed.
  2884. * svg/graphics/filters/cg/WKSpotLightFilter.h: Removed.
  2885. * svg/graphics/filters/cg/WKSpotLightFilter.m: Removed.
  2886. * svg/graphics/filters/cg/WKTableTransferFilter.cikernel: Removed.
  2887. * svg/graphics/filters/cg/WKTableTransferFilter.h: Removed.
  2888. * svg/graphics/filters/cg/WKTableTransferFilter.m: Removed.
  2889. * svg/graphics/mac: Removed.
  2890. * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h: Removed.
  2891. * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: Removed.
  2892. * svg/graphics/qt: Removed.
  2893. * svg/graphics/qt/SVGResourceFilterQt.cpp: Removed.
  2894. * svg/graphics/skia: Removed.
  2895. * svg/graphics/skia/SVGResourceFilterSkia.cpp: Removed.
  2896. 2009-06-01 Dmitry Titov <dimich@chromium.org>
  2897. Fix the previous checkin (ttp://trac.webkit.org/changeset/44327).
  2898. This adds a comment suggested during review.
  2899. * platform/ThreadGlobalData.cpp:
  2900. (WebCore::ThreadGlobalData::~ThreadGlobalData): Add comment clarifying the change.
  2901. 2009-06-01 Dmitry Titov <dimich@chromium.org>
  2902. Reviewed by Darin Adler.
  2903. https://bugs.webkit.org/show_bug.cgi?id=25973
  2904. Avoid calling CurrentThread() in thread-specific destructors in OSX Chromium.
  2905. Pthreads invoke thread-specific destructors after WTF::detachThread() is called and ThreadIdentifier
  2906. for the thread removed from the WTF thread map. Calling CurrentThread() in such destructor causes
  2907. the ThreadIdentifier to be re-created and inserted into the map again. Since Pthreads on OSX reuse
  2908. the pthread_t between threads, the next created thread will have the same pthread_t and cause an assert
  2909. in establishIdentifierForPthreadHandle() since the id is already in the map.
  2910. The behavior is covered by existing test LayoutTests/fast/workers/worker-terminate.html, which currently fails
  2911. on OSX Chromium and will stop failing after this change.
  2912. * platform/ThreadGlobalData.h:
  2913. * platform/ThreadGlobalData.cpp:
  2914. (WebCore::ThreadGlobalData::~ThreadGlobalData):
  2915. Store the result of "isMainThread()" in a member variable during construction of thread-specific data
  2916. to avoid calling IsMainThread() in destructor, since the latter calls CurrentThread() in OSX Chromium.
  2917. 2009-06-01 David Levin <levin@chromium.org>
  2918. Reviewed by Darin Alder and Maciej Stachowiak.
  2919. Bug 26057: StringImpl should share buffers with UString.
  2920. https://bugs.webkit.org/show_bug.cgi?id=26057
  2921. This change results in the following performance improvements:
  2922. On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
  2923. the time went from 78ms to 40ms for append (other times remained constant).
  2924. On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
  2925. the time went from 3900ms to 2600ms.
  2926. For http://dromaeo.com/?dom, the time for DomModification improved by ~6%.
  2927. Other tests in dom seemed to be faster across several runs but within the
  2928. margin of error (except DOM Attributes which was slightly ~1.5% worse).
  2929. Existing tests cover this code and there is no new functionality
  2930. that is exposed to test.
  2931. * platform/text/AtomicString.cpp:
  2932. (WebCore::AtomicString::add):
  2933. * platform/text/String.cpp:
  2934. (WebCore::String::String):
  2935. (WebCore::String::operator UString):
  2936. * platform/text/StringImpl.cpp:
  2937. (WebCore::StringImpl::StringImpl):
  2938. (WebCore::StringImpl::~StringImpl):
  2939. (WebCore::StringImpl::create): Consumes a shared buffer.
  2940. (WebCore::StringImpl::ustring): Shares the StringImpl's buffer with the UString.
  2941. (WebCore::StringImpl::sharedBuffer): Exposes the buffer that may be shared.
  2942. * platform/text/StringImpl.h:
  2943. (WebCore::StringImpl::hasTerminatingNullCharacter):
  2944. (WebCore::StringImpl::inTable):
  2945. (WebCore::StringImpl::setInTable): Converted the bools to be inside of PtrAndFlags
  2946. to avoid growing StringImpl in size.
  2947. 2009-06-01 Dimitri Glazkov <dglazkov@chromium.org>
  2948. Unreviewed, build fix.
  2949. V8 bindings follow-up to to DOMWindow-related cleanup:
  2950. http://trac.webkit.org/changeset/44215
  2951. * bindings/v8/ScriptController.cpp: Removed disconnectFrame(), relocated
  2952. its body to destructor.
  2953. * bindings/v8/ScriptController.h: Removed disconnectFrame() decl.
  2954. 2009-05-28 Pavel Feldman <pfeldman@chromium.org>
  2955. Reviewed by Timothy Hatcher.
  2956. - Add panel enabler to the resources panel.
  2957. - Add session / always options into the panel enabler.
  2958. - Make enabled status for three panels sticky (globally).
  2959. - Persist enabled status using InspectorController::Settings
  2960. - Make InspectorController produce no network-related overhead when
  2961. resources panel is not enabled.
  2962. https://bugs.webkit.org/show_bug.cgi?id=26046
  2963. * inspector/InspectorController.cpp:
  2964. (WebCore::InspectorController::InspectorController):
  2965. (WebCore::InspectorController::setWindowVisible):
  2966. (WebCore::InspectorController::populateScriptObjects):
  2967. (WebCore::InspectorController::identifierForInitialRequest):
  2968. (WebCore::InspectorController::willSendRequest):
  2969. (WebCore::InspectorController::didReceiveResponse):
  2970. (WebCore::InspectorController::didReceiveContentLength):
  2971. (WebCore::InspectorController::didFinishLoading):
  2972. (WebCore::InspectorController::didFailLoading):
  2973. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  2974. (WebCore::InspectorController::scriptImported):
  2975. (WebCore::InspectorController::enableResourceTracking):
  2976. (WebCore::InspectorController::disableResourceTracking):
  2977. (WebCore::InspectorController::startUserInitiatedProfiling):
  2978. (WebCore::InspectorController::enableProfiler):
  2979. (WebCore::InspectorController::disableProfiler):
  2980. (WebCore::InspectorController::enableDebugger):
  2981. (WebCore::InspectorController::disableDebugger):
  2982. * inspector/InspectorController.h:
  2983. (WebCore::InspectorController::Setting::Setting):
  2984. (WebCore::InspectorController::resourceTrackingEnabled):
  2985. * inspector/InspectorController.idl:
  2986. * inspector/InspectorFrontend.cpp:
  2987. (WebCore::InspectorFrontend::resourceTrackingWasEnabled):
  2988. (WebCore::InspectorFrontend::resourceTrackingWasDisabled):
  2989. * inspector/InspectorFrontend.h:
  2990. * inspector/front-end/PanelEnablerView.js:
  2991. (WebInspector.PanelEnablerView.enableOption):
  2992. (WebInspector.PanelEnablerView):
  2993. (WebInspector.PanelEnablerView.prototype._windowResized):
  2994. (WebInspector.PanelEnablerView.prototype.alwaysWasChosen):
  2995. * inspector/front-end/ProfilesPanel.js:
  2996. (WebInspector.ProfilesPanel.prototype._enableProfiling):
  2997. (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  2998. * inspector/front-end/ResourcesPanel.js:
  2999. (WebInspector.ResourcesPanel):
  3000. (WebInspector.ResourcesPanel.prototype.get statusBarItems):
  3001. (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled):
  3002. (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled):
  3003. (WebInspector.ResourcesPanel.prototype.reset):
  3004. (WebInspector.ResourcesPanel.prototype._updateSidebarWidth):
  3005. (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
  3006. (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  3007. * inspector/front-end/ScriptsPanel.js:
  3008. (WebInspector.ScriptsPanel.prototype._enableDebugging):
  3009. (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  3010. * inspector/front-end/inspector.css:
  3011. * inspector/front-end/inspector.js:
  3012. (WebInspector.resourceTrackingWasEnabled):
  3013. (WebInspector.resourceTrackingWasDisabled):
  3014. 2009-06-01 Drew Wilson <atwilson@google.com>
  3015. Reviewed by Darin Adler. Landed (and tweaked) by Adam Barth.
  3016. https://bugs.webkit.org/show_bug.cgi?id=25902
  3017. Added WorkerContext.close()
  3018. Test: fast/workers/worker-close.html
  3019. * workers/WorkerContext.cpp:
  3020. (WebCore::WorkerContext::close):
  3021. * workers/WorkerContext.h:
  3022. * workers/WorkerContext.idl:
  3023. * workers/WorkerMessagingProxy.cpp:
  3024. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
  3025. 2009-06-01 Alexey Proskuryakov <ap@webkit.org>
  3026. Reviewed by Darin Adler.
  3027. https://bugs.webkit.org/show_bug.cgi?id=12471
  3028. XPathResult not invalidated for documents retrieved via XMLHttpRequest
  3029. Test: fast/xpath/detached-subtree-invalidate-iterator.html and existing tests in dom/svg/level3/xpath.
  3030. Use DOM tree version instead of DOMSubtreeModified events to invalidate, which is more
  3031. reliable and much faster.
  3032. * xml/XPathExpression.cpp:
  3033. (WebCore::XPathExpression::evaluate):
  3034. * xml/XPathResult.cpp:
  3035. (WebCore::XPathResult::XPathResult):
  3036. (WebCore::XPathResult::~XPathResult):
  3037. (WebCore::XPathResult::invalidIteratorState):
  3038. (WebCore::XPathResult::iterateNext):
  3039. * xml/XPathResult.h:
  3040. (WebCore::XPathResult::create):
  3041. 2009-06-01 Brett Wilson <brettw@chromium.org>
  3042. Reviewed by Darin Adler. Landed by Adam Barth.
  3043. https://bugs.webkit.org/show_bug.cgi?id=25750
  3044. Test: fast/transforms/bounding-rect-zoom.html
  3045. Make getClientRects and getBoundingClientRect account for ther zoom
  3046. factor.
  3047. * dom/Element.cpp:
  3048. (WebCore::adjustFloatPointForAbsoluteZoom):
  3049. (WebCore::adjustFloatQuadForAbsoluteZoom):
  3050. (WebCore::adjustIntRectForAbsoluteZoom):
  3051. (WebCore::Element::getClientRects):
  3052. (WebCore::Element::getBoundingClientRect):
  3053. 2009-06-01 Tony Chang <tony@chromium.org>
  3054. Reviewed by Dimitri Glazkov. Landed by Adam Barth.
  3055. https://bugs.webkit.org/show_bug.cgi?id=26026
  3056. Fix an infinite loop when using the keyboard in Chromium select
  3057. popups.
  3058. Not testable since it involves sending a keyboard event to
  3059. the popup, which is not possible (eventSender sends the key
  3060. events through webview, we want to go through the webwidget).
  3061. * platform/chromium/PopupMenuChromium.cpp:
  3062. 2009-06-01 Nate Chapin <japhet@google.com>
  3063. Reviewed by Dimitri Glazkov. Landed by Adam Barth.
  3064. If a url with an anchor is being loaded, ensure that the anchor remains locked in view until the page
  3065. has finished loading compeltely or the user has manually scrolled. Refreshing an anchor url after
  3066. scrolling to a new location on the page will still result in jumping to the new location.
  3067. https://bugs.webkit.org/show_bug.cgi?id=26034
  3068. * loader/FrameLoader.cpp:
  3069. (WebCore::FrameLoader::gotoAnchor): Set anchor lock after navigating to anchor.
  3070. (WebCore::FrameLoader::completed): Release anchor lock.
  3071. * page/FrameView.cpp:
  3072. (WebCore::FrameView::FrameView): Ensure anchor lock starts unset.
  3073. (WebCore::FrameView::reset): Ensure anchor lock starts unset.
  3074. (WebCore::FrameView::layout): If anchor lock is set, force a gotoAnchor() after layout.
  3075. (WebCore::FrameView::scrollRectIntoViewRecursively): Release anchor lock if a programmatic scroll begins.
  3076. (WebCore::FrameView::setWasScrolledByUser): Release anchor lock if user manually scrolls.
  3077. (WebCore::FrameView::setScrollPosition): Release anchor lock if a programmatic scroll begins.
  3078. * page/FrameView.h:
  3079. (WebCore::FrameView::lockedToAnchor): Added.
  3080. (WebCore::FrameView::setLockedToAnchor): Added.
  3081. 2009-05-31 Dirk Schulze <krit@webkit.org>
  3082. Reviewed by Nikolas Zimmermann.
  3083. WebKit needs cross-platform filter system
  3084. [https://bugs.webkit.org/show_bug.cgi?id=19991]
  3085. A short clean-up. FilterBuilder is SVG specific. Move it
  3086. to svg/graphics/filters and rename it to SVGFilterBuilder.
  3087. * GNUmakefile.am:
  3088. * WebCore.pro:
  3089. * WebCore.xcodeproj/project.pbxproj:
  3090. * svg/FilterBuilder.cpp: Removed.
  3091. * svg/FilterBuilder.h: Removed.
  3092. * svg/SVGFilterElement.cpp:
  3093. * svg/SVGFilterPrimitiveStandardAttributes.h:
  3094. * svg/graphics/SVGResourceFilter.cpp:
  3095. (WebCore::SVGResourceFilter::SVGResourceFilter):
  3096. * svg/graphics/SVGResourceFilter.h:
  3097. (WebCore::SVGResourceFilter::builder):
  3098. * svg/graphics/filters/SVGFilterBuilder.cpp: Added.
  3099. (WebCore::SVGFilterBuilder::SVGFilterBuilder):
  3100. (WebCore::SVGFilterBuilder::add):
  3101. (WebCore::SVGFilterBuilder::getEffectById):
  3102. (WebCore::SVGFilterBuilder::clearEffects):
  3103. * svg/graphics/filters/SVGFilterBuilder.h: Added.
  3104. (WebCore::SVGFilterBuilder::lastEffect):
  3105. 2009-05-31 Alexey Proskuryakov <ap@webkit.org>
  3106. Reviewed by Darin Adler.
  3107. https://bugs.webkit.org/show_bug.cgi?id=13233
  3108. Need to implement an optimizing XPath evaluator
  3109. Avoid sorting results of hierarchical paths that are naturally sorted. On a flat data structure
  3110. with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
  3111. to 33 ms.
  3112. * xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint,
  3113. which is useful for optimization.
  3114. (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one.
  3115. (WebCore::XPath::NodeSet::operator=): Ditto.
  3116. (WebCore::XPath::NodeSet::swap): Ditto.
  3117. (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort()
  3118. was never called.
  3119. (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is
  3120. maintained by callers.
  3121. (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree.
  3122. Currently, the only way for a set to gain this flag is to be produced from a single element
  3123. set with a hierarchical location path.
  3124. * xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid
  3125. maintaining a set of unique nodes, and to avoid sorting the result.
  3126. 2009-05-31 Alexey Proskuryakov <ap@webkit.org>
  3127. Reviewed by Darin Adler.
  3128. https://bugs.webkit.org/show_bug.cgi?id=13233
  3129. Need to implement an optimizing XPath evaluator
  3130. This patch adds some infrastructure and simple optimizations. Namely,
  3131. - we now avoid building a full NodeSet just to evaluate a predicate in some cases;
  3132. - "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;
  3133. * xml/XPathExpressionNode.cpp:
  3134. (WebCore::XPath::Expression::Expression):
  3135. * xml/XPathExpressionNode.h:
  3136. (WebCore::XPath::Expression::addSubExpression):
  3137. (WebCore::XPath::Expression::isContextNodeSensitive):
  3138. (WebCore::XPath::Expression::isContextPositionSensitive):
  3139. (WebCore::XPath::Expression::isContextSizeSensitive):
  3140. (WebCore::XPath::Expression::setIsContextNodeSensitive):
  3141. (WebCore::XPath::Expression::setIsContextPositionSensitive):
  3142. (WebCore::XPath::Expression::setIsContextSizeSensitive):
  3143. XPath expression now knows its result type, and whether evaluation depends on context.
  3144. * xml/XPathFunctions.cpp:
  3145. (WebCore::XPath::FunLast::resultType):
  3146. (WebCore::XPath::FunLast::FunLast):
  3147. (WebCore::XPath::FunPosition::resultType):
  3148. (WebCore::XPath::FunPosition::FunPosition):
  3149. (WebCore::XPath::FunCount::resultType):
  3150. (WebCore::XPath::FunId::resultType):
  3151. (WebCore::XPath::FunLocalName::resultType):
  3152. (WebCore::XPath::FunLocalName::FunLocalName):
  3153. (WebCore::XPath::FunNamespaceURI::resultType):
  3154. (WebCore::XPath::FunNamespaceURI::FunNamespaceURI):
  3155. (WebCore::XPath::FunName::resultType):
  3156. (WebCore::XPath::FunName::FunName):
  3157. (WebCore::XPath::FunString::resultType):
  3158. (WebCore::XPath::FunString::FunString):
  3159. (WebCore::XPath::FunConcat::resultType):
  3160. (WebCore::XPath::FunStartsWith::resultType):
  3161. (WebCore::XPath::FunContains::resultType):
  3162. (WebCore::XPath::FunSubstringBefore::resultType):
  3163. (WebCore::XPath::FunSubstringAfter::resultType):
  3164. (WebCore::XPath::FunSubstring::resultType):
  3165. (WebCore::XPath::FunStringLength::resultType):
  3166. (WebCore::XPath::FunStringLength::FunStringLength):
  3167. (WebCore::XPath::FunNormalizeSpace::resultType):
  3168. (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace):
  3169. (WebCore::XPath::FunTranslate::resultType):
  3170. (WebCore::XPath::FunBoolean::resultType):
  3171. (WebCore::XPath::FunNot::resultType):
  3172. (WebCore::XPath::FunTrue::resultType):
  3173. (WebCore::XPath::FunFalse::resultType):
  3174. (WebCore::XPath::FunLang::resultType):
  3175. (WebCore::XPath::FunLang::FunLang):
  3176. (WebCore::XPath::FunNumber::resultType):
  3177. (WebCore::XPath::FunNumber::FunNumber):
  3178. (WebCore::XPath::FunSum::resultType):
  3179. (WebCore::XPath::FunFloor::resultType):
  3180. (WebCore::XPath::FunCeiling::resultType):
  3181. (WebCore::XPath::FunRound::resultType):
  3182. (WebCore::XPath::Function::setArguments):
  3183. Set optimization details for the expression. Normally, a function does not introduce context
  3184. node set dependency, but some use context node as default argument, or otherwise use the context.
  3185. * xml/XPathFunctions.h: Tweaked style.
  3186. * xml/XPathPath.cpp:
  3187. (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is.
  3188. (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive,
  3189. and only if the path relative.
  3190. (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations.
  3191. (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
  3192. (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.
  3193. * xml/XPathPath.h:
  3194. (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression
  3195. (useful filters return NodeSets, of course).
  3196. (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set
  3197. insensitive.
  3198. (WebCore::XPath::LocationPath::resultType): A path's result is always a node set.
  3199. (WebCore::XPath::Path::resultType): Ditto.
  3200. * xml/XPathPredicate.h:
  3201. (WebCore::XPath::Number::resultType): Return a proper result type.
  3202. (WebCore::XPath::StringExpression::resultType): Ditto.
  3203. (WebCore::XPath::Negative::resultType): Ditto.
  3204. (WebCore::XPath::NumericOp::resultType): Ditto.
  3205. (WebCore::XPath::EqTestOp::resultType): Ditto.
  3206. (WebCore::XPath::LogicalOp::resultType): Ditto.
  3207. (WebCore::XPath::Union::resultType): Ditto.
  3208. (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position
  3209. sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5].
  3210. (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.
  3211. * xml/XPathStep.h:
  3212. (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously
  3213. borrowed from XPath 2.0 to express some optimizations.
  3214. (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and
  3215. filtering it with predicates, we now try to apply predicates while enumerating an axis.
  3216. (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.
  3217. * xml/XPathStep.cpp:
  3218. (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still
  3219. possible to copy NodeTests.
  3220. (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible.
  3221. (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "//".
  3222. (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only
  3223. possible if there are no context sensitive predicates for "//".
  3224. (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate.
  3225. (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring
  3226. merged predicates.
  3227. (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position.
  3228. (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code
  3229. path.
  3230. * xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable
  3231. references are not used with XPathEvaluator, so we'll only need them if we decide to
  3232. reimplement XSLT. The type of variable reference is not known at compile time.
  3233. 2009-05-31 Sam Weinig <sam@webkit.org>
  3234. Rubber-stamped by Dan Bernstein.
  3235. Remove unused JSEventTargetBase.h
  3236. * GNUmakefile.am:
  3237. * WebCore.vcproj/WebCore.vcproj:
  3238. * WebCore.xcodeproj/project.pbxproj:
  3239. * bindings/js/JSEventTargetBase.h: Removed.
  3240. 2009-05-31 Sam Weinig <sam@webkit.org>
  3241. Reviewed by Dan Bernstein.
  3242. Part of https://bugs.webkit.org/show_bug.cgi?id=26100
  3243. Add missing event handler properties to the DOMWindow
  3244. Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
  3245. onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
  3246. onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
  3247. onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
  3248. ondragend, ondragenter, ondragleave, ondragover, ondragstart and
  3249. ondrop event handlers to the DOMWindow.
  3250. * page/DOMWindow.cpp:
  3251. (WebCore::DOMWindow::ondrag):
  3252. (WebCore::DOMWindow::setOndrag):
  3253. (WebCore::DOMWindow::ondragend):
  3254. (WebCore::DOMWindow::setOndragend):
  3255. (WebCore::DOMWindow::ondragenter):
  3256. (WebCore::DOMWindow::setOndragenter):
  3257. (WebCore::DOMWindow::ondragleave):
  3258. (WebCore::DOMWindow::setOndragleave):
  3259. (WebCore::DOMWindow::ondragover):
  3260. (WebCore::DOMWindow::setOndragover):
  3261. (WebCore::DOMWindow::ondragstart):
  3262. (WebCore::DOMWindow::setOndragstart):
  3263. (WebCore::DOMWindow::ondrop):
  3264. (WebCore::DOMWindow::setOndrop):
  3265. (WebCore::DOMWindow::oncanplay):
  3266. (WebCore::DOMWindow::setOncanplay):
  3267. (WebCore::DOMWindow::oncanplaythrough):
  3268. (WebCore::DOMWindow::setOncanplaythrough):
  3269. (WebCore::DOMWindow::ondurationchange):
  3270. (WebCore::DOMWindow::setOndurationchange):
  3271. (WebCore::DOMWindow::onemptied):
  3272. (WebCore::DOMWindow::setOnemptied):
  3273. (WebCore::DOMWindow::onended):
  3274. (WebCore::DOMWindow::setOnended):
  3275. (WebCore::DOMWindow::onloadeddata):
  3276. (WebCore::DOMWindow::setOnloadeddata):
  3277. (WebCore::DOMWindow::onloadedmetadata):
  3278. (WebCore::DOMWindow::setOnloadedmetadata):
  3279. (WebCore::DOMWindow::onpause):
  3280. (WebCore::DOMWindow::setOnpause):
  3281. (WebCore::DOMWindow::onplay):
  3282. (WebCore::DOMWindow::setOnplay):
  3283. (WebCore::DOMWindow::onplaying):
  3284. (WebCore::DOMWindow::setOnplaying):
  3285. (WebCore::DOMWindow::onratechange):
  3286. (WebCore::DOMWindow::setOnratechange):
  3287. (WebCore::DOMWindow::onseeked):
  3288. (WebCore::DOMWindow::setOnseeked):
  3289. (WebCore::DOMWindow::onseeking):
  3290. (WebCore::DOMWindow::setOnseeking):
  3291. (WebCore::DOMWindow::ontimeupdate):
  3292. (WebCore::DOMWindow::setOntimeupdate):
  3293. (WebCore::DOMWindow::onvolumechange):
  3294. (WebCore::DOMWindow::setOnvolumechange):
  3295. (WebCore::DOMWindow::onwaiting):
  3296. (WebCore::DOMWindow::setOnwaiting):
  3297. (WebCore::DOMWindow::onloadstart):
  3298. (WebCore::DOMWindow::setOnloadstart):
  3299. (WebCore::DOMWindow::onprogress):
  3300. (WebCore::DOMWindow::setOnprogress):
  3301. (WebCore::DOMWindow::onstalled):
  3302. (WebCore::DOMWindow::setOnstalled):
  3303. (WebCore::DOMWindow::onsuspend):
  3304. (WebCore::DOMWindow::setOnsuspend):
  3305. * page/DOMWindow.h:
  3306. * page/DOMWindow.idl:
  3307. 2009-05-31 Sam Weinig <sam@webkit.org>
  3308. Reviewed by Anders Carlsson.
  3309. Part of https://bugs.webkit.org/show_bug.cgi?id=26100
  3310. Add missing event handler properties to the DOMWindow
  3311. Add missing onstorage event handler to the DOMWindow.
  3312. * page/DOMWindow.cpp:
  3313. (WebCore::DOMWindow::onstorage):
  3314. (WebCore::DOMWindow::setOnstorage):
  3315. * page/DOMWindow.h:
  3316. * page/DOMWindow.idl:
  3317. 2009-05-30 Sam Weinig <sam@webkit.org>
  3318. Reviewed by Mark Rowe.
  3319. Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
  3320. Update online/offline events to match the current spec.
  3321. - Also adds window.ononline and window.onoffline event handler
  3322. properties.
  3323. * page/DOMWindow.cpp:
  3324. (WebCore::DOMWindow::onoffline):
  3325. (WebCore::DOMWindow::setOnoffline):
  3326. (WebCore::DOMWindow::ononline):
  3327. (WebCore::DOMWindow::setOnonline):
  3328. * page/DOMWindow.h:
  3329. * page/DOMWindow.idl:
  3330. * page/Page.cpp:
  3331. (WebCore::networkStateChanged):
  3332. 2009-05-31 Dirk Schulze <krit@webkit.org>
  3333. Reviewed by Nikolas Zimmermann.
  3334. WebKit needs cross-platform filter system
  3335. [https://bugs.webkit.org/show_bug.cgi?id=19991]
  3336. Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
  3337. and replace it by a platform independent code. Calculation of subRegions
  3338. is missing but needed for a first filter effect.
  3339. * GNUmakefile.am:
  3340. * WebCore.pro:
  3341. * WebCore.vcproj/WebCore.vcproj:
  3342. * WebCore.xcodeproj/project.pbxproj:
  3343. * platform/graphics/filters/Filter.h:
  3344. (WebCore::Filter::~Filter):
  3345. (WebCore::Filter::setSourceImage):
  3346. * rendering/SVGRenderSupport.cpp:
  3347. (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  3348. (WebCore::SVGRenderBase::finishRenderSVGContent):
  3349. * svg/FilterBuilder.h:
  3350. (WebCore::FilterBuilder::lastEffect):
  3351. * svg/SVGFEBlendElement.cpp:
  3352. (WebCore::SVGFEBlendElement::SVGFEBlendElement):
  3353. (WebCore::SVGFEBlendElement::build):
  3354. * svg/SVGFEBlendElement.h:
  3355. * svg/SVGFEColorMatrixElement.cpp:
  3356. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
  3357. (WebCore::SVGFEColorMatrixElement::build):
  3358. * svg/SVGFEColorMatrixElement.h:
  3359. * svg/SVGFEComponentTransferElement.cpp:
  3360. (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
  3361. (WebCore::SVGFEComponentTransferElement::build):
  3362. * svg/SVGFEComponentTransferElement.h:
  3363. * svg/SVGFECompositeElement.cpp:
  3364. (WebCore::SVGFECompositeElement::SVGFECompositeElement):
  3365. (WebCore::SVGFECompositeElement::build):
  3366. * svg/SVGFECompositeElement.h:
  3367. * svg/SVGFEDiffuseLightingElement.cpp:
  3368. (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
  3369. (WebCore::SVGFEDiffuseLightingElement::build):
  3370. * svg/SVGFEDiffuseLightingElement.h:
  3371. * svg/SVGFEDisplacementMapElement.cpp:
  3372. (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
  3373. (WebCore::SVGFEDisplacementMapElement::build):
  3374. * svg/SVGFEDisplacementMapElement.h:
  3375. * svg/SVGFEFloodElement.cpp:
  3376. (WebCore::SVGFEFloodElement::SVGFEFloodElement):
  3377. (WebCore::SVGFEFloodElement::build):
  3378. * svg/SVGFEFloodElement.h:
  3379. * svg/SVGFEGaussianBlurElement.cpp:
  3380. (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
  3381. (WebCore::SVGFEGaussianBlurElement::build):
  3382. * svg/SVGFEGaussianBlurElement.h:
  3383. * svg/SVGFEImageElement.cpp:
  3384. (WebCore::SVGFEImageElement::SVGFEImageElement):
  3385. (WebCore::SVGFEImageElement::notifyFinished):
  3386. (WebCore::SVGFEImageElement::build):
  3387. * svg/SVGFEImageElement.h:
  3388. * svg/SVGFEMergeElement.cpp:
  3389. (WebCore::SVGFEMergeElement::SVGFEMergeElement):
  3390. (WebCore::SVGFEMergeElement::build):
  3391. * svg/SVGFEMergeElement.h:
  3392. * svg/SVGFEOffsetElement.cpp:
  3393. (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
  3394. (WebCore::SVGFEOffsetElement::build):
  3395. * svg/SVGFEOffsetElement.h:
  3396. * svg/SVGFESpecularLightingElement.cpp:
  3397. (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
  3398. (WebCore::SVGFESpecularLightingElement::build):
  3399. * svg/SVGFESpecularLightingElement.h:
  3400. * svg/SVGFETileElement.cpp:
  3401. (WebCore::SVGFETileElement::SVGFETileElement):
  3402. (WebCore::SVGFETileElement::build):
  3403. * svg/SVGFETileElement.h:
  3404. * svg/SVGFETurbulenceElement.cpp:
  3405. (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
  3406. (WebCore::SVGFETurbulenceElement::build):
  3407. * svg/SVGFETurbulenceElement.h:
  3408. * svg/SVGFilterElement.cpp:
  3409. (WebCore::SVGFilterElement::canvasResource):
  3410. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  3411. (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  3412. * svg/SVGFilterPrimitiveStandardAttributes.h:
  3413. (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
  3414. * svg/graphics/SVGResourceFilter.cpp:
  3415. (WebCore::SVGResourceFilter::SVGResourceFilter):
  3416. (WebCore::SVGResourceFilter::addFilterEffect):
  3417. (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
  3418. (WebCore::SVGResourceFilter::prepareFilter):
  3419. (WebCore::SVGResourceFilter::applyFilter):
  3420. (WebCore::SVGResourceFilter::externalRepresentation):
  3421. * svg/graphics/SVGResourceFilter.h:
  3422. (WebCore::SVGResourceFilter::filterBoundingBox):
  3423. (WebCore::SVGResourceFilter::setFilterBoundingBox):
  3424. (WebCore::SVGResourceFilter::itemBoundingBox):
  3425. (WebCore::SVGResourceFilter::setItemBoundingBox):
  3426. (WebCore::SVGResourceFilter::builder):
  3427. 2009-05-31 Dirk Schulze <krit@webkit.org>
  3428. Reviewed by Nikolas Zimmermann.
  3429. WebKit needs cross-platform filter system
  3430. [https://bugs.webkit.org/show_bug.cgi?id=19991]
  3431. Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
  3432. This change helps creating test cases, once filters are activated.
  3433. * svg/SVGFEFloodElement.cpp:
  3434. (WebCore::SVGFEFloodElement::SVGFEFloodElement):
  3435. (WebCore::SVGFEFloodElement::parseMappedAttribute):
  3436. (WebCore::SVGFEFloodElement::build):
  3437. * svg/SVGFEFloodElement.h:
  3438. * svg/SVGFEFloodElement.idl:
  3439. * svg/graphics/filters/SVGFEFlood.cpp:
  3440. (WebCore::FEFlood::FEFlood):
  3441. (WebCore::FEFlood::create):
  3442. * svg/graphics/filters/SVGFEFlood.h:
  3443. 2009-05-31 Dirk Schulze <krit@webkit.org>
  3444. Reviewed by Nikolas Zimmermann.
  3445. WebKit needs cross-platform filter system
  3446. [https://bugs.webkit.org/show_bug.cgi?id=19991]
  3447. Replace all occurrences of SVGResourceFilter by Filter. This is the last
  3448. step for a SVG independent filter system. Every other part of WebCore can
  3449. use the filter system by creating a new Filter object.
  3450. * GNUmakefile.am:
  3451. * WebCore.pro:
  3452. * WebCore.xcodeproj/project.pbxproj:
  3453. * platform/graphics/filters/FEBlend.cpp:
  3454. (WebCore::FEBlend::apply):
  3455. * platform/graphics/filters/FEBlend.h:
  3456. * platform/graphics/filters/FEColorMatrix.cpp:
  3457. (WebCore::FEColorMatrix::apply):
  3458. * platform/graphics/filters/FEColorMatrix.h:
  3459. * platform/graphics/filters/FEComponentTransfer.cpp:
  3460. (WebCore::FEComponentTransfer::apply):
  3461. * platform/graphics/filters/FEComponentTransfer.h:
  3462. * platform/graphics/filters/FEComposite.cpp:
  3463. (WebCore::FEComposite::apply):
  3464. * platform/graphics/filters/FEComposite.h:
  3465. * platform/graphics/filters/Filter.h: Added.
  3466. (WebCore::Filter::setSourceImage):
  3467. (WebCore::Filter::sourceImage):
  3468. * platform/graphics/filters/FilterEffect.h:
  3469. * platform/graphics/filters/SourceAlpha.cpp:
  3470. (WebCore::SourceAlpha::apply):
  3471. * platform/graphics/filters/SourceAlpha.h:
  3472. * platform/graphics/filters/SourceGraphic.cpp:
  3473. (WebCore::SourceGraphic::apply):
  3474. * platform/graphics/filters/SourceGraphic.h:
  3475. * svg/Filter.cpp: Removed.
  3476. * svg/Filter.h: Removed.
  3477. * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  3478. (WebCore::FEConvolveMatrix::apply):
  3479. * svg/graphics/filters/SVGFEConvolveMatrix.h:
  3480. * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  3481. (WebCore::FEDiffuseLighting::apply):
  3482. * svg/graphics/filters/SVGFEDiffuseLighting.h:
  3483. * svg/graphics/filters/SVGFEDisplacementMap.cpp:
  3484. (WebCore::FEDisplacementMap::apply):
  3485. * svg/graphics/filters/SVGFEDisplacementMap.h:
  3486. * svg/graphics/filters/SVGFEFlood.cpp:
  3487. (WebCore::FEFlood::apply):
  3488. * svg/graphics/filters/SVGFEFlood.h:
  3489. * svg/graphics/filters/SVGFEGaussianBlur.cpp:
  3490. (WebCore::FEGaussianBlur::apply):
  3491. * svg/graphics/filters/SVGFEGaussianBlur.h:
  3492. * svg/graphics/filters/SVGFEImage.cpp:
  3493. (WebCore::FEImage::apply):
  3494. * svg/graphics/filters/SVGFEImage.h:
  3495. * svg/graphics/filters/SVGFEMerge.cpp:
  3496. (WebCore::FEMerge::apply):
  3497. * svg/graphics/filters/SVGFEMerge.h:
  3498. * svg/graphics/filters/SVGFEMorphology.cpp:
  3499. (WebCore::FEMorphology::apply):
  3500. * svg/graphics/filters/SVGFEMorphology.h:
  3501. * svg/graphics/filters/SVGFEOffset.cpp:
  3502. (WebCore::FEOffset::apply):
  3503. * svg/graphics/filters/SVGFEOffset.h:
  3504. * svg/graphics/filters/SVGFESpecularLighting.cpp:
  3505. (WebCore::FESpecularLighting::apply):
  3506. * svg/graphics/filters/SVGFESpecularLighting.h:
  3507. * svg/graphics/filters/SVGFETile.cpp:
  3508. (WebCore::FETile::apply):
  3509. * svg/graphics/filters/SVGFETile.h:
  3510. * svg/graphics/filters/SVGFETurbulence.cpp:
  3511. (WebCore::FETurbulence::apply):
  3512. * svg/graphics/filters/SVGFETurbulence.h:
  3513. * svg/graphics/filters/SVGFilter.cpp: Added.
  3514. (WebCore::SVGFilter::SVGFilter):
  3515. (WebCore::SVGFilter::calculateEffectSubRegion):
  3516. (WebCore::SVGFilter::create):
  3517. * svg/graphics/filters/SVGFilter.h: Added.
  3518. 2009-05-30 Kevin Ollivier <kevino@theolliviers.com>
  3519. Build fix for platforms without plugins support.
  3520. * plugins/PluginViewNone.cpp:
  3521. (WebCore::PluginView::userAgentStatic):
  3522. (WebCore::PluginView::getValueStatic):
  3523. 2009-05-30 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  3524. Reviewed by Darin Adler.
  3525. Fixes: https://bugs.webkit.org/show_bug.cgi?id=25979
  3526. Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
  3527. Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.
  3528. * platform/network/mac/ResourceHandleMac.mm:
  3529. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  3530. 2009-05-29 Sam Weinig <sam@webkit.org>
  3531. Reviewed by Anders Carlsson.
  3532. Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
  3533. Make storage events match the current spec.
  3534. - Storage event listeners are added to the window.
  3535. - Storage events are dispatched to the window.
  3536. Updated existing tests.
  3537. * dom/Document.cpp:
  3538. (WebCore::Document::dispatchWindowEvent):
  3539. * dom/Document.h:
  3540. * dom/Node.cpp:
  3541. * dom/Node.h:
  3542. * html/HTMLBodyElement.cpp:
  3543. (WebCore::HTMLBodyElement::parseMappedAttribute):
  3544. * storage/LocalStorageArea.cpp:
  3545. (WebCore::LocalStorageArea::dispatchStorageEvent):
  3546. * storage/SessionStorageArea.cpp:
  3547. (WebCore::SessionStorageArea::dispatchStorageEvent):
  3548. 2009-05-30 Darin Adler <darin@apple.com>
  3549. Reviewed by Adele Peterson.
  3550. Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element
  3551. Test: fast/forms/focus-control-to-page.html
  3552. * dom/SelectElement.h: Made destructor protected. Tweaked a bit.
  3553. * html/HTMLSelectElement.cpp: Removed unneeded includes.
  3554. (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the
  3555. result of optionToListIndex.
  3556. (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the
  3557. unused attribute, m_minwidth.
  3558. (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix.
  3559. Call through to the base class defaultEventHandler if the event hasn't
  3560. been handled yet.
  3561. * html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions
  3562. private. Removed unused minWidth function and m_minwidth data member.
  3563. 2009-05-30 Fridrich Strba <fridrich.strba@bluewin.ch>
  3564. Reviewed by Holger Freyther.
  3565. The two KeyboardCodes.h files are basically identical and the
  3566. qt one is properly #ifdef-ed for different win32 systems. Share
  3567. them between Qt and Gtk implementations.
  3568. * GNUmakefile.am:
  3569. * platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
  3570. * platform/gtk/KeyboardCodes.h: Removed.
  3571. * platform/qt/KeyboardCodes.h: Removed.
  3572. 2009-05-30 Jeremy Orlow <jorlow@chromium.org>
  3573. Reviewed by Sam Weinig.
  3574. LocalStorage and SessionStorage's implicit setters do not correctly
  3575. handle null. The custom JS bindings should convert to strings
  3576. unconditionally and not try to handle null specially.
  3577. https://bugs.webkit.org/show_bug.cgi?id=25970
  3578. Tests: storage/domstorage/localstorage/string-conversion.html
  3579. storage/domstorage/sessionstorage/string-conversion.html
  3580. * bindings/js/JSStorageCustom.cpp:
  3581. (WebCore::JSStorage::customPut):
  3582. 2009-05-30 Dan Bernstein <mitz@apple.com>
  3583. Reviewed by Darin Adler.
  3584. - fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll
  3585. bars in key window draw as inactive if the WebView is not active
  3586. Test: platform/mac/scrollbars/key-window-not-first-responder.html
  3587. * platform/mac/ScrollbarThemeMac.mm:
  3588. (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead
  3589. of the WebView's first responder state to switch between active and
  3590. inactive state.
  3591. 2009-05-30 Dan Bernstein <mitz@apple.com>
  3592. Reviewed by Simon Fraser.
  3593. - fix https://bugs.webkit.org/show_bug.cgi?id=18445
  3594. <rdar://problem/5931174> Assertion failure in CSSGradientValue::image
  3595. with -webkit-gradient as body's background
  3596. Test: fast/backgrounds/body-generated-image-propagated-to-root.html
  3597. * rendering/RenderBoxModelObject.cpp:
  3598. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this
  3599. is the root element painting a background layer propagated from the
  3600. body, and if it is, use the body's renderer as the client to
  3601. StyleImage::image().
  3602. 2009-05-30 Holger Hans Peter Freyther <zecke@selfish.org>
  3603. Unreviewed build fix for AXObjectCache.
  3604. For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
  3605. that into the #ifdef.
  3606. * accessibility/AXObjectCache.cpp:
  3607. 2009-05-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  3608. Reviewed by George Staikos.
  3609. Fixes: https://bugs.webkit.org/show_bug.cgi?id=26072
  3610. Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
  3611. the same functionality HTMLSelectElement has. The WML specific features will follow soon.
  3612. Add simple testcase covering <select> element rendering: fast/wml/select.wml
  3613. * GNUmakefile.am:
  3614. * WebCore.pro:
  3615. * WebCore.vcproj/WebCore.vcproj:
  3616. * WebCore.xcodeproj/project.pbxproj:
  3617. * dom/OptionElement.cpp:
  3618. (WebCore::OptionElement::optionIndex):
  3619. (WebCore::isOptionElement):
  3620. * dom/OptionElement.h:
  3621. * dom/OptionGroupElement.cpp:
  3622. (WebCore::isOptionGroupElement):
  3623. * dom/OptionGroupElement.h:
  3624. * dom/SelectElement.cpp:
  3625. (WebCore::SelectElement::accessKeySetSelectedIndex):
  3626. (WebCore::toSelectElement):
  3627. * dom/SelectElement.h:
  3628. * html/HTMLOptionElement.cpp:
  3629. (WebCore::HTMLOptionElement::index):
  3630. * html/HTMLSelectElement.cpp:
  3631. (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
  3632. * rendering/RenderListBox.cpp:
  3633. (WebCore::RenderListBox::paintItemForeground):
  3634. * rendering/RenderMenuList.cpp:
  3635. (WebCore::RenderMenuList::itemIsEnabled):
  3636. (WebCore::RenderMenuList::itemIsLabel):
  3637. * wml/WMLFormControlElement.cpp:
  3638. (WebCore::WMLFormControlElement::attach):
  3639. (WebCore::WMLFormControlElement::recalcStyle):
  3640. * wml/WMLFormControlElement.h:
  3641. * wml/WMLInputElement.cpp:
  3642. (WebCore::WMLInputElement::attach):
  3643. * wml/WMLOptGroupElement.cpp:
  3644. (WebCore::WMLOptGroupElement::insertBefore):
  3645. (WebCore::WMLOptGroupElement::replaceChild):
  3646. (WebCore::WMLOptGroupElement::removeChild):
  3647. (WebCore::WMLOptGroupElement::appendChild):
  3648. (WebCore::WMLOptGroupElement::removeChildren):
  3649. (WebCore::ownerSelectElement):
  3650. (WebCore::WMLOptGroupElement::accessKeyAction):
  3651. (WebCore::WMLOptGroupElement::childrenChanged):
  3652. (WebCore::WMLOptGroupElement::parseMappedAttribute):
  3653. (WebCore::WMLOptGroupElement::attach):
  3654. (WebCore::WMLOptGroupElement::detach):
  3655. (WebCore::WMLOptGroupElement::recalcSelectOptions):
  3656. * wml/WMLOptionElement.cpp:
  3657. (WebCore::ownerSelectElement):
  3658. (WebCore::WMLOptionElement::accessKeyAction):
  3659. (WebCore::WMLOptionElement::childrenChanged):
  3660. (WebCore::WMLOptionElement::parseMappedAttribute):
  3661. (WebCore::WMLOptionElement::attach):
  3662. (WebCore::WMLOptionElement::detach):
  3663. (WebCore::WMLOptionElement::insertedIntoDocument):
  3664. * wml/WMLSelectElement.cpp: Added.
  3665. (WebCore::WMLSelectElement::WMLSelectElement):
  3666. (WebCore::WMLSelectElement::~WMLSelectElement):
  3667. (WebCore::WMLSelectElement::formControlType):
  3668. (WebCore::WMLSelectElement::isKeyboardFocusable):
  3669. (WebCore::WMLSelectElement::isMouseFocusable):
  3670. (WebCore::WMLSelectElement::selectAll):
  3671. (WebCore::WMLSelectElement::recalcStyle):
  3672. (WebCore::WMLSelectElement::dispatchFocusEvent):
  3673. (WebCore::WMLSelectElement::dispatchBlurEvent):
  3674. (WebCore::WMLSelectElement::selectedIndex):
  3675. (WebCore::WMLSelectElement::setSelectedIndex):
  3676. (WebCore::WMLSelectElement::saveFormControlState):
  3677. (WebCore::WMLSelectElement::restoreFormControlState):
  3678. (WebCore::WMLSelectElement::childrenChanged):
  3679. (WebCore::WMLSelectElement::parseMappedAttribute):
  3680. (WebCore::WMLSelectElement::createRenderer):
  3681. (WebCore::WMLSelectElement::appendFormData):
  3682. (WebCore::WMLSelectElement::optionToListIndex):
  3683. (WebCore::WMLSelectElement::listToOptionIndex):
  3684. (WebCore::WMLSelectElement::reset):
  3685. (WebCore::WMLSelectElement::defaultEventHandler):
  3686. (WebCore::WMLSelectElement::accessKeyAction):
  3687. (WebCore::WMLSelectElement::setActiveSelectionAnchorIndex):
  3688. (WebCore::WMLSelectElement::setActiveSelectionEndIndex):
  3689. (WebCore::WMLSelectElement::updateListBoxSelection):
  3690. (WebCore::WMLSelectElement::listBoxOnChange):
  3691. (WebCore::WMLSelectElement::menuListOnChange):
  3692. (WebCore::WMLSelectElement::activeSelectionStartListIndex):
  3693. (WebCore::WMLSelectElement::activeSelectionEndListIndex):
  3694. (WebCore::WMLSelectElement::accessKeySetSelectedIndex):
  3695. (WebCore::WMLSelectElement::setRecalcListItems):
  3696. (WebCore::WMLSelectElement::scrollToSelection):
  3697. (WebCore::WMLSelectElement::insertedIntoTree):
  3698. * wml/WMLSelectElement.h: Added.
  3699. (WebCore::WMLSelectElement::canSelectAll):
  3700. (WebCore::WMLSelectElement::canStartSelection):
  3701. (WebCore::WMLSelectElement::size):
  3702. (WebCore::WMLSelectElement::multiple):
  3703. (WebCore::WMLSelectElement::listItems):
  3704. * wml/WMLTagNames.in:
  3705. 2009-05-29 David Levin <levin@chromium.org>
  3706. Reviewed by NOBODY (build fix for windows).
  3707. http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
  3708. that it was trying to replace. Resulting in this variable being defined twice (and
  3709. the second time incorrectly).
  3710. * platform/win/Language.cpp:
  3711. (WebCore::localeInfo):
  3712. 2009-05-29 Takeshi Yoshino <tyoshino@google.com>
  3713. Reviewed by Darin Alder.
  3714. https://bugs.webkit.org/show_bug.cgi?id=26018
  3715. Fix behavior of the Element View of the Web Inspector for double
  3716. clicking the element outline tree.
  3717. Double clicking the element outline tree should
  3718. 1) on attribute: enter attribute editing mode
  3719. 2) on text: enter text editing mode
  3720. 3) otherwise: change root node to the parent element of double clicked
  3721. element.
  3722. Now, 3) is broken. For example, clicking <html> clears the element
  3723. outline view.
  3724. rootDOMNode should be updated to this.representedObject.parentNode, not
  3725. this.parent.representedObject which is parent inside the element
  3726. outline tree itself.
  3727. * inspector/front-end/ElementsTreeOutline.js:
  3728. (WebInspector.ElementsTreeElement.prototype.ondblclick):
  3729. 2009-05-29 David Moore <davemoore@google.com>
  3730. Reviewed by Darin Alder.
  3731. https://bugs.webkit.org/show_bug.cgi?id=26001
  3732. Change many of the uses of String::adopt() to String::createUninitialized().
  3733. This allows those strings to use an inlined buffer for their characters.
  3734. * dom/StyleElement.cpp:
  3735. Loop over nodes to precompute length of string and then
  3736. write the characters into the allocated inline buffer
  3737. (WebCore::StyleElement::process):
  3738. * dom/Text.cpp:
  3739. Loop over nodes to precompute length of string and then
  3740. write the characters into the allocated inline buffer
  3741. (WebCore::Text::wholeText):
  3742. (WebCore::Text::rendererIsNeeded):
  3743. (WebCore::Text::createRenderer):
  3744. (WebCore::Text::createWithLengthLimit):
  3745. (WebCore::Text::formatForDebugger):
  3746. * platform/text/String.cpp:
  3747. (WebCore::String::append):
  3748. (WebCore::String::insert):
  3749. (WebCore::String::truncate):
  3750. (WebCore::String::remove):
  3751. * platform/text/StringBuilder.cpp:
  3752. (WebCore::StringBuilder::toString):
  3753. * platform/text/StringImpl.cpp:
  3754. (WebCore::StringImpl::lower):
  3755. (WebCore::StringImpl::upper):
  3756. (WebCore::StringImpl::secure):
  3757. (WebCore::StringImpl::foldCase):
  3758. (WebCore::StringImpl::replace):
  3759. * platform/text/TextCodecLatin1.cpp:
  3760. (WebCore::TextCodecLatin1::decode):
  3761. * platform/text/TextCodecUserDefined.cpp:
  3762. (WebCore::TextCodecUserDefined::decode):
  3763. * platform/win/Language.cpp:
  3764. (WebCore::localeInfo):
  3765. 2009-05-29 Takeshi Yoshino <tyoshino@google.com>
  3766. Reviewed by Darin Alder.
  3767. Bug 25911: Apply href in base elements to anchors shown on the source viewer
  3768. https://bugs.webkit.org/show_bug.cgi?id=25911
  3769. In rendering HTML sources, parse base elements to apply the base URI to
  3770. anchors shown on the source viewer.
  3771. This issue was originally reported to the Chromium issue tracker.
  3772. http://code.google.com/p/chromium/issues/detail?id=2418
  3773. Test: fast/frames/viewsource-link-on-href-value.html
  3774. * html/HTMLViewSourceDocument.cpp:
  3775. (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  3776. 2009-05-29 Rob Buis <rwlbuis@gmail.com>
  3777. Reviewed by David Hyatt.
  3778. https://bugs.webkit.org/show_bug.cgi?id=22429
  3779. document.styleSheets collection ignores media=presentation
  3780. Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.
  3781. Test: fast/css/sheet-collection-link.html
  3782. * html/HTMLLinkElement.cpp:
  3783. (WebCore::HTMLLinkElement::process):
  3784. 2009-05-29 Jian Li <jianli@chromium.org>
  3785. Reviewed by Dimitri Glazkov.
  3786. https://bugs.webkit.org/show_bug.cgi?id=26069
  3787. Fix a crash in custom V8 bindings code for XMLHttpRequest.
  3788. Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
  3789. * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  3790. (WebCore::CALLBACK_FUNC_DECL):
  3791. 2009-05-29 David Levin <levin@chromium.org>
  3792. Reviewed by Darin Adler.
  3793. Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
  3794. https://bugs.webkit.org/show_bug.cgi?id=26074
  3795. The constructor for SQLStatement already does a copy for this string.
  3796. * storage/SQLTransaction.cpp:
  3797. (WebCore::SQLTransaction::executeSQL):
  3798. 2009-05-29 Darin Adler <darin@apple.com>
  3799. Fix build; the new Cairo code compiled on Windows only.
  3800. * platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
  3801. and syntheticOblique functions as in the Windows version to make it
  3802. easier to use this cross-platform. Later we can make data members
  3803. private as in the Windows version.
  3804. * platform/graphics/mac/FontPlatformData.h: Ditto.
  3805. 2009-05-29 Alexander Macdonald <alexmac@adobe.com>
  3806. Reviewed by Darin Adler.
  3807. Added support for synthetic bold/oblique font rendering
  3808. on platforms that use cairo.
  3809. * platform/graphics/SimpleFontData.h:
  3810. * platform/graphics/cairo/FontCairo.cpp:
  3811. (WebCore::Font::drawGlyphs):
  3812. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  3813. (WebCore::SimpleFontData::platformInit):
  3814. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  3815. (WebCore::SimpleFontData::platformInit):
  3816. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  3817. (WebCore::SimpleFontData::platformInit):
  3818. 2009-05-29 Chris Fleizach <cfleizach@apple.com>
  3819. Reviewed by Beth Dakin.
  3820. Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
  3821. https://bugs.webkit.org/show_bug.cgi?id=26024
  3822. AX notifications are posted after a one shot timer so that notifications are not performed mid-layout.
  3823. Consolidated postNotification and postNotificationToElement into one method.
  3824. * accessibility/AXObjectCache.cpp:
  3825. (WebCore::AXObjectCache::AXObjectCache):
  3826. (WebCore::AXObjectCache::notificationPostTimerFired):
  3827. (WebCore::AXObjectCache::postNotification):
  3828. (WebCore::AXObjectCache::selectedChildrenChanged):
  3829. * accessibility/AXObjectCache.h:
  3830. (WebCore::AXObjectCache::postNotification):
  3831. (WebCore::AXObjectCache::postPlatformNotification):
  3832. * accessibility/AccessibilityRenderObject.cpp:
  3833. (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
  3834. * accessibility/chromium/AXObjectCacheChromium.cpp:
  3835. (WebCore::AXObjectCache::postPlatformNotification):
  3836. * accessibility/gtk/AXObjectCacheAtk.cpp:
  3837. (WebCore::AXObjectCache::postPlatformNotification):
  3838. * accessibility/mac/AXObjectCacheMac.mm:
  3839. (WebCore::AXObjectCache::postPlatformNotification):
  3840. * accessibility/win/AXObjectCacheWin.cpp:
  3841. (WebCore::AXObjectCache::postPlatformNotification):
  3842. * dom/Document.cpp:
  3843. (WebCore::Document::implicitClose):
  3844. * editing/Editor.cpp:
  3845. (WebCore::Editor::respondToChangedContents):
  3846. * editing/mac/SelectionControllerMac.mm:
  3847. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  3848. * page/FrameView.cpp:
  3849. (WebCore::FrameView::layout):
  3850. * rendering/RenderTextControl.cpp:
  3851. (WebCore::RenderTextControl::setInnerTextValue):
  3852. 2009-05-29 Brent Fulgham <bfulgham@webkit.org>
  3853. Reviewed by Adam Roben.
  3854. Build fix for Windows Cairo target.
  3855. https://bugs.webkit.org/show_bug.cgi?id=25972
  3856. Compiler mistakenly selects SMILTime min/max instead of STL version,
  3857. resulting in a build error. This change makes the meaning of the
  3858. min/max explicit and avoids the problem.
  3859. * html/TimeRanges.h:
  3860. (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
  3861. 2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
  3862. Reviewed by Jan Alonzo.
  3863. Make SoupMessage a member of ResourceRequest, instead of creating
  3864. it in startHttp. Implement updating of ResourceRequest from
  3865. SoupMessage, and vice versa.
  3866. * GNUmakefile.am:
  3867. * platform/network/soup/ResourceHandleSoup.cpp:
  3868. (WebCore::ResourceHandle::~ResourceHandle):
  3869. (WebCore::gotHeadersCallback):
  3870. (WebCore::ResourceHandle::startHttp):
  3871. * platform/network/soup/ResourceRequest.h:
  3872. (WebCore::ResourceRequest::ResourceRequest):
  3873. (WebCore::ResourceRequest::~ResourceRequest):
  3874. * platform/network/soup/ResourceRequestSoup.cpp: Added.
  3875. (WTF::SoupURI):
  3876. (WebCore::ResourceRequest::soupMessage):
  3877. (WebCore::ResourceRequest::ResourceRequest):
  3878. (WebCore::ResourceRequest::doUpdateResourceRequest):
  3879. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  3880. 2009-05-28 Dmitry Titov <dimich@chromium.org>
  3881. Reviewed by Dimitri Glazkov.
  3882. https://bugs.webkit.org/show_bug.cgi?id=26068
  3883. V8: Remove the remaining b8::Locker usage in worker code.
  3884. This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
  3885. since the patches for enabling timers and that bug have "crossed in the queue".
  3886. Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
  3887. * bindings/v8/ScheduledAction.cpp:
  3888. (WebCore::ScheduledAction::execute):
  3889. 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  3890. Reviewed by Xan Lopez.
  3891. Simplify the Accept-Encoding header we are sending out, for it
  3892. seems some servers do not enjoy parsing the full, explicit
  3893. version.
  3894. * platform/network/soup/ResourceHandleSoup.cpp:
  3895. (WebCore::ResourceHandle::startHttp):
  3896. 2009-05-28 Dirk Schulze <krit@webkit.org>
  3897. Reviewed by Nikolas Zimmermann.
  3898. Added a new build flag --filters. This replaces the old --svg-filters and enables
  3899. other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
  3900. This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
  3901. doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
  3902. Filters are not working yet. This patch is just a preperation. Filters are deactivated by
  3903. default.
  3904. * Configurations/FeatureDefines.xcconfig:
  3905. * DerivedSources.make:
  3906. * GNUmakefile.am:
  3907. * WebCore.pro:
  3908. * bindings/objc/DOM.mm:
  3909. (WebCore::createElementClassMap):
  3910. * dom/DOMImplementation.cpp:
  3911. (WebCore::isSVG10Feature):
  3912. (WebCore::isSVG11Feature):
  3913. * page/DOMWindow.idl:
  3914. * platform/graphics/filters/FEBlend.cpp:
  3915. * platform/graphics/filters/FEBlend.h:
  3916. * platform/graphics/filters/FEColorMatrix.cpp:
  3917. * platform/graphics/filters/FEColorMatrix.h:
  3918. * platform/graphics/filters/FEComponentTransfer.cpp:
  3919. * platform/graphics/filters/FEComponentTransfer.h:
  3920. * platform/graphics/filters/FEComposite.cpp:
  3921. * platform/graphics/filters/FEComposite.h:
  3922. * platform/graphics/filters/FilterEffect.cpp:
  3923. * platform/graphics/filters/FilterEffect.h:
  3924. * platform/graphics/filters/SourceAlpha.cpp:
  3925. * platform/graphics/filters/SourceAlpha.h:
  3926. * platform/graphics/filters/SourceGraphic.cpp:
  3927. * platform/graphics/filters/SourceGraphic.h:
  3928. * rendering/RenderSVGContainer.cpp:
  3929. (WebCore::RenderSVGContainer::selfWillPaint):
  3930. * rendering/RenderSVGModelObject.cpp:
  3931. * rendering/RenderSVGRoot.cpp:
  3932. (WebCore::RenderSVGRoot::selfWillPaint):
  3933. * rendering/SVGRenderSupport.cpp:
  3934. (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  3935. (WebCore::SVGRenderBase::finishRenderSVGContent):
  3936. (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  3937. * svg/Filter.cpp:
  3938. * svg/Filter.h:
  3939. * svg/FilterBuilder.cpp:
  3940. * svg/FilterBuilder.h:
  3941. * svg/SVGComponentTransferFunctionElement.cpp:
  3942. * svg/SVGComponentTransferFunctionElement.h:
  3943. * svg/SVGComponentTransferFunctionElement.idl:
  3944. * svg/SVGFEBlendElement.cpp:
  3945. * svg/SVGFEBlendElement.h:
  3946. * svg/SVGFEBlendElement.idl:
  3947. * svg/SVGFEColorMatrixElement.cpp:
  3948. * svg/SVGFEColorMatrixElement.h:
  3949. * svg/SVGFEColorMatrixElement.idl:
  3950. * svg/SVGFEComponentTransferElement.cpp:
  3951. * svg/SVGFEComponentTransferElement.h:
  3952. * svg/SVGFEComponentTransferElement.idl:
  3953. * svg/SVGFECompositeElement.cpp:
  3954. * svg/SVGFECompositeElement.h:
  3955. * svg/SVGFECompositeElement.idl:
  3956. * svg/SVGFEDiffuseLightingElement.cpp:
  3957. * svg/SVGFEDiffuseLightingElement.h:
  3958. * svg/SVGFEDiffuseLightingElement.idl:
  3959. * svg/SVGFEDisplacementMapElement.cpp:
  3960. * svg/SVGFEDisplacementMapElement.h:
  3961. * svg/SVGFEDisplacementMapElement.idl:
  3962. * svg/SVGFEDistantLightElement.cpp:
  3963. * svg/SVGFEDistantLightElement.h:
  3964. * svg/SVGFEDistantLightElement.idl:
  3965. * svg/SVGFEFloodElement.cpp:
  3966. * svg/SVGFEFloodElement.h:
  3967. * svg/SVGFEFloodElement.idl:
  3968. * svg/SVGFEFuncAElement.cpp:
  3969. * svg/SVGFEFuncAElement.h:
  3970. * svg/SVGFEFuncAElement.idl:
  3971. * svg/SVGFEFuncBElement.cpp:
  3972. * svg/SVGFEFuncBElement.h:
  3973. * svg/SVGFEFuncBElement.idl:
  3974. * svg/SVGFEFuncGElement.cpp:
  3975. * svg/SVGFEFuncGElement.h:
  3976. * svg/SVGFEFuncGElement.idl:
  3977. * svg/SVGFEFuncRElement.cpp:
  3978. * svg/SVGFEFuncRElement.h:
  3979. * svg/SVGFEFuncRElement.idl:
  3980. * svg/SVGFEGaussianBlurElement.cpp:
  3981. * svg/SVGFEGaussianBlurElement.h:
  3982. * svg/SVGFEGaussianBlurElement.idl:
  3983. * svg/SVGFEImageElement.cpp:
  3984. * svg/SVGFEImageElement.h:
  3985. * svg/SVGFEImageElement.idl:
  3986. * svg/SVGFELightElement.cpp:
  3987. * svg/SVGFELightElement.h:
  3988. * svg/SVGFEMergeElement.cpp:
  3989. * svg/SVGFEMergeElement.h:
  3990. * svg/SVGFEMergeElement.idl:
  3991. * svg/SVGFEMergeNodeElement.cpp:
  3992. * svg/SVGFEMergeNodeElement.h:
  3993. * svg/SVGFEMergeNodeElement.idl:
  3994. * svg/SVGFEOffsetElement.cpp:
  3995. * svg/SVGFEOffsetElement.h:
  3996. * svg/SVGFEOffsetElement.idl:
  3997. * svg/SVGFEPointLightElement.cpp:
  3998. * svg/SVGFEPointLightElement.h:
  3999. * svg/SVGFEPointLightElement.idl:
  4000. * svg/SVGFESpecularLightingElement.cpp:
  4001. * svg/SVGFESpecularLightingElement.h:
  4002. * svg/SVGFESpecularLightingElement.idl:
  4003. * svg/SVGFESpotLightElement.cpp:
  4004. * svg/SVGFESpotLightElement.h:
  4005. * svg/SVGFESpotLightElement.idl:
  4006. * svg/SVGFETileElement.cpp:
  4007. * svg/SVGFETileElement.h:
  4008. * svg/SVGFETileElement.idl:
  4009. * svg/SVGFETurbulenceElement.cpp:
  4010. * svg/SVGFETurbulenceElement.h:
  4011. * svg/SVGFETurbulenceElement.idl:
  4012. * svg/SVGFilterElement.cpp:
  4013. * svg/SVGFilterElement.h:
  4014. * svg/SVGFilterElement.idl:
  4015. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  4016. * svg/SVGFilterPrimitiveStandardAttributes.h:
  4017. * svg/graphics/SVGResourceFilter.cpp:
  4018. * svg/graphics/SVGResourceFilter.h:
  4019. * svg/graphics/cairo/SVGResourceFilterCairo.cpp:
  4020. * svg/graphics/cg/SVGResourceFilterCg.cpp:
  4021. * svg/graphics/cg/SVGResourceFilterCg.mm:
  4022. * svg/graphics/filters/SVGDistantLightSource.h:
  4023. * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  4024. * svg/graphics/filters/SVGFEConvolveMatrix.h:
  4025. * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  4026. * svg/graphics/filters/SVGFEDiffuseLighting.h:
  4027. * svg/graphics/filters/SVGFEDisplacementMap.cpp:
  4028. * svg/graphics/filters/SVGFEDisplacementMap.h:
  4029. * svg/graphics/filters/SVGFEFlood.cpp:
  4030. * svg/graphics/filters/SVGFEFlood.h:
  4031. * svg/graphics/filters/SVGFEGaussianBlur.cpp:
  4032. * svg/graphics/filters/SVGFEGaussianBlur.h:
  4033. * svg/graphics/filters/SVGFEImage.cpp:
  4034. * svg/graphics/filters/SVGFEImage.h:
  4035. * svg/graphics/filters/SVGFEMerge.cpp:
  4036. * svg/graphics/filters/SVGFEMerge.h:
  4037. * svg/graphics/filters/SVGFEMorphology.cpp:
  4038. * svg/graphics/filters/SVGFEMorphology.h:
  4039. * svg/graphics/filters/SVGFEOffset.cpp:
  4040. * svg/graphics/filters/SVGFEOffset.h:
  4041. * svg/graphics/filters/SVGFESpecularLighting.cpp:
  4042. * svg/graphics/filters/SVGFESpecularLighting.h:
  4043. * svg/graphics/filters/SVGFETile.cpp:
  4044. * svg/graphics/filters/SVGFETile.h:
  4045. * svg/graphics/filters/SVGFETurbulence.cpp:
  4046. * svg/graphics/filters/SVGFETurbulence.h:
  4047. * svg/graphics/filters/SVGFilterEffect.cpp:
  4048. * svg/graphics/filters/SVGFilterEffect.h:
  4049. * svg/graphics/filters/SVGLightSource.cpp:
  4050. * svg/graphics/filters/SVGLightSource.h:
  4051. * svg/graphics/filters/SVGPointLightSource.h:
  4052. * svg/graphics/filters/SVGSpotLightSource.h:
  4053. * svg/graphics/filters/cg/SVGFEHelpersCg.h:
  4054. * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
  4055. * svg/graphics/filters/cg/SVGFilterEffectCg.mm:
  4056. * svg/graphics/filters/cg/WKArithmeticFilter.h:
  4057. * svg/graphics/filters/cg/WKArithmeticFilter.m:
  4058. * svg/graphics/filters/cg/WKComponentMergeFilter.h:
  4059. * svg/graphics/filters/cg/WKComponentMergeFilter.m:
  4060. * svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
  4061. * svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
  4062. * svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
  4063. * svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
  4064. * svg/graphics/filters/cg/WKDisplacementMapFilter.h:
  4065. * svg/graphics/filters/cg/WKDisplacementMapFilter.m:
  4066. * svg/graphics/filters/cg/WKDistantLightFilter.h:
  4067. * svg/graphics/filters/cg/WKDistantLightFilter.m:
  4068. * svg/graphics/filters/cg/WKGammaTransferFilter.h:
  4069. * svg/graphics/filters/cg/WKGammaTransferFilter.m:
  4070. * svg/graphics/filters/cg/WKIdentityTransferFilter.h:
  4071. * svg/graphics/filters/cg/WKIdentityTransferFilter.m:
  4072. * svg/graphics/filters/cg/WKLinearTransferFilter.h:
  4073. * svg/graphics/filters/cg/WKLinearTransferFilter.m:
  4074. * svg/graphics/filters/cg/WKNormalMapFilter.h:
  4075. * svg/graphics/filters/cg/WKNormalMapFilter.m:
  4076. * svg/graphics/filters/cg/WKPointLightFilter.h:
  4077. * svg/graphics/filters/cg/WKPointLightFilter.m:
  4078. * svg/graphics/filters/cg/WKSpecularLightingFilter.h:
  4079. * svg/graphics/filters/cg/WKSpecularLightingFilter.m:
  4080. * svg/graphics/filters/cg/WKSpotLightFilter.h:
  4081. * svg/graphics/filters/cg/WKSpotLightFilter.m:
  4082. * svg/graphics/filters/cg/WKTableTransferFilter.h:
  4083. * svg/graphics/filters/cg/WKTableTransferFilter.m:
  4084. * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  4085. * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
  4086. * svg/graphics/qt/SVGResourceFilterQt.cpp:
  4087. * svg/graphics/skia/SVGResourceFilterSkia.cpp:
  4088. * svg/svgtags.in:
  4089. 2009-05-28 Brett Wilson <brettw@chromium.org>
  4090. Unreviewed, build fix.
  4091. https://bugs.webkit.org/show_bug.cgi?id=26067
  4092. Add casts for scale function to make more explicit what is happening
  4093. and fix a compiler warning.
  4094. * platform/graphics/IntSize.h:
  4095. (WebCore::IntSize::scale):
  4096. 2009-05-28 Sam Weinig <sam@webkit.org>
  4097. Reviewed by Darin Adler.
  4098. Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
  4099. are not cleared on navigation it is no longer necessary.
  4100. * bindings/js/JSDOMWindowBase.cpp:
  4101. (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
  4102. (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
  4103. * bindings/js/JSDOMWindowBase.h:
  4104. * bindings/js/JSDOMWindowCustom.cpp:
  4105. (WebCore::JSDOMWindow::showModalDialog):
  4106. 2009-05-19 Xan Lopez <xlopez@igalia.com>
  4107. Reviewed by Jan Alonzo and Gustavo Noronha.
  4108. https://bugs.webkit.org/show_bug.cgi?id=25415
  4109. [GTK][ATK] Please implement support for get_text_at_offset
  4110. Implement atk_text_get_text_{at,after,before}_offset.
  4111. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  4112. 2009-05-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  4113. Rubber-stamped by Darin Adler.
  4114. Remove unnecessary destructor from InputElementData/OptionElementData.
  4115. * dom/InputElement.cpp:
  4116. * dom/InputElement.h:
  4117. * dom/OptionElement.cpp:
  4118. * dom/OptionElement.h:
  4119. 2009-05-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  4120. Reviewed by Darin Adler.
  4121. Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
  4122. Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
  4123. in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
  4124. A follow-up patch can now easily add WMLSelectElement.
  4125. * dom/OptionElement.h:
  4126. * dom/SelectElement.cpp:
  4127. (WebCore::SelectElement::selectAll):
  4128. (WebCore::SelectElement::saveLastSelection):
  4129. (WebCore::isOptionElement):
  4130. (WebCore::isOptionGroupElement):
  4131. (WebCore::SelectElement::nextSelectableListIndex):
  4132. (WebCore::SelectElement::previousSelectableListIndex):
  4133. (WebCore::SelectElement::setActiveSelectionAnchorIndex):
  4134. (WebCore::SelectElement::setActiveSelectionEndIndex):
  4135. (WebCore::SelectElement::updateListBoxSelection):
  4136. (WebCore::SelectElement::listBoxOnChange):
  4137. (WebCore::SelectElement::menuListOnChange):
  4138. (WebCore::SelectElement::scrollToSelection):
  4139. (WebCore::SelectElement::recalcStyle):
  4140. (WebCore::SelectElement::setRecalcListItems):
  4141. (WebCore::SelectElement::recalcListItems):
  4142. (WebCore::SelectElement::selectedIndex):
  4143. (WebCore::SelectElement::setSelectedIndex):
  4144. (WebCore::SelectElement::optionToListIndex):
  4145. (WebCore::SelectElement::listToOptionIndex):
  4146. (WebCore::SelectElement::dispatchFocusEvent):
  4147. (WebCore::SelectElement::dispatchBlurEvent):
  4148. (WebCore::SelectElement::deselectItems):
  4149. (WebCore::SelectElement::saveFormControlState):
  4150. (WebCore::SelectElement::restoreFormControlState):
  4151. (WebCore::SelectElement::parseMultipleAttribute):
  4152. (WebCore::SelectElement::appendFormData):
  4153. (WebCore::SelectElement::reset):
  4154. (WebCore::SelectElement::menuListDefaultEventHandler):
  4155. (WebCore::SelectElement::listBoxDefaultEventHandler):
  4156. (WebCore::SelectElement::defaultEventHandler):
  4157. (WebCore::SelectElement::lastSelectedListIndex):
  4158. (WebCore::stripLeadingWhiteSpace):
  4159. (WebCore::SelectElement::typeAheadFind):
  4160. (WebCore::SelectElement::insertedIntoTree):
  4161. (WebCore::SelectElementData::SelectElementData):
  4162. (WebCore::SelectElementData::checkListItems):
  4163. (WebCore::SelectElementData::listItems):
  4164. * dom/SelectElement.h:
  4165. (WebCore::SelectElementData::multiple):
  4166. (WebCore::SelectElementData::setMultiple):
  4167. (WebCore::SelectElementData::size):
  4168. (WebCore::SelectElementData::setSize):
  4169. (WebCore::SelectElementData::usesMenuList):
  4170. (WebCore::SelectElementData::lastOnChangeIndex):
  4171. (WebCore::SelectElementData::setLastOnChangeIndex):
  4172. (WebCore::SelectElementData::lastOnChangeSelection):
  4173. (WebCore::SelectElementData::activeSelectionState):
  4174. (WebCore::SelectElementData::setActiveSelectionState):
  4175. (WebCore::SelectElementData::activeSelectionAnchorIndex):
  4176. (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
  4177. (WebCore::SelectElementData::activeSelectionEndIndex):
  4178. (WebCore::SelectElementData::setActiveSelectionEndIndex):
  4179. (WebCore::SelectElementData::cachedStateForActiveSelection):
  4180. (WebCore::SelectElementData::shouldRecalcListItems):
  4181. (WebCore::SelectElementData::setShouldRecalcListItems):
  4182. (WebCore::SelectElementData::rawListItems):
  4183. (WebCore::SelectElementData::repeatingChar):
  4184. (WebCore::SelectElementData::setRepeatingChar):
  4185. (WebCore::SelectElementData::lastCharTime):
  4186. (WebCore::SelectElementData::setLastCharTime):
  4187. (WebCore::SelectElementData::typedString):
  4188. (WebCore::SelectElementData::setTypedString):
  4189. * html/HTMLOptionElement.h:
  4190. * html/HTMLSelectElement.cpp:
  4191. (WebCore::HTMLSelectElement::HTMLSelectElement):
  4192. (WebCore::HTMLSelectElement::recalcStyle):
  4193. (WebCore::HTMLSelectElement::formControlType):
  4194. (WebCore::HTMLSelectElement::selectedIndex):
  4195. (WebCore::HTMLSelectElement::deselectItems):
  4196. (WebCore::HTMLSelectElement::setSelectedIndex):
  4197. (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
  4198. (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
  4199. (WebCore::HTMLSelectElement::saveFormControlState):
  4200. (WebCore::HTMLSelectElement::restoreFormControlState):
  4201. (WebCore::HTMLSelectElement::parseMappedAttribute):
  4202. (WebCore::HTMLSelectElement::canSelectAll):
  4203. (WebCore::HTMLSelectElement::selectAll):
  4204. (WebCore::HTMLSelectElement::createRenderer):
  4205. (WebCore::HTMLSelectElement::appendFormData):
  4206. (WebCore::HTMLSelectElement::optionToListIndex):
  4207. (WebCore::HTMLSelectElement::listToOptionIndex):
  4208. (WebCore::HTMLSelectElement::recalcListItems):
  4209. (WebCore::HTMLSelectElement::setRecalcListItems):
  4210. (WebCore::HTMLSelectElement::reset):
  4211. (WebCore::HTMLSelectElement::dispatchFocusEvent):
  4212. (WebCore::HTMLSelectElement::dispatchBlurEvent):
  4213. (WebCore::HTMLSelectElement::defaultEventHandler):
  4214. (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
  4215. (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
  4216. (WebCore::HTMLSelectElement::updateListBoxSelection):
  4217. (WebCore::HTMLSelectElement::menuListOnChange):
  4218. (WebCore::HTMLSelectElement::listBoxOnChange):
  4219. (WebCore::HTMLSelectElement::saveLastSelection):
  4220. (WebCore::HTMLSelectElement::setOption):
  4221. (WebCore::HTMLSelectElement::scrollToSelection):
  4222. (WebCore::HTMLSelectElement::insertedIntoTree):
  4223. * html/HTMLSelectElement.h:
  4224. (WebCore::HTMLSelectElement::size):
  4225. (WebCore::HTMLSelectElement::multiple):
  4226. (WebCore::HTMLSelectElement::listItems):
  4227. * wml/WMLOptionElement.cpp:
  4228. (WebCore::WMLOptionElement::text):
  4229. * wml/WMLOptionElement.h:
  4230. * dom/OptionElement.h:
  4231. * dom/SelectElement.cpp:
  4232. (WebCore::SelectElement::selectAll):
  4233. (WebCore::SelectElement::saveLastSelection):
  4234. (WebCore::isOptionElement):
  4235. (WebCore::isOptionGroupElement):
  4236. (WebCore::SelectElement::nextSelectableListIndex):
  4237. (WebCore::SelectElement::previousSelectableListIndex):
  4238. (WebCore::SelectElement::setActiveSelectionAnchorIndex):
  4239. (WebCore::SelectElement::setActiveSelectionEndIndex):
  4240. (WebCore::SelectElement::updateListBoxSelection):
  4241. (WebCore::SelectElement::listBoxOnChange):
  4242. (WebCore::SelectElement::menuListOnChange):
  4243. (WebCore::SelectElement::scrollToSelection):
  4244. (WebCore::SelectElement::recalcStyle):
  4245. (WebCore::SelectElement::setRecalcListItems):
  4246. (WebCore::SelectElement::recalcListItems):
  4247. (WebCore::SelectElement::selectedIndex):
  4248. (WebCore::SelectElement::setSelectedIndex):
  4249. (WebCore::SelectElement::optionToListIndex):
  4250. (WebCore::SelectElement::listToOptionIndex):
  4251. (WebCore::SelectElement::dispatchFocusEvent):
  4252. (WebCore::SelectElement::dispatchBlurEvent):
  4253. (WebCore::SelectElement::deselectItems):
  4254. (WebCore::SelectElement::saveFormControlState):
  4255. (WebCore::SelectElement::restoreFormControlState):
  4256. (WebCore::SelectElement::parseMultipleAttribute):
  4257. (WebCore::SelectElement::appendFormData):
  4258. (WebCore::SelectElement::reset):
  4259. (WebCore::SelectElement::menuListDefaultEventHandler):
  4260. (WebCore::SelectElement::listBoxDefaultEventHandler):
  4261. (WebCore::SelectElement::defaultEventHandler):
  4262. (WebCore::SelectElement::lastSelectedListIndex):
  4263. (WebCore::stripLeadingWhiteSpace):
  4264. (WebCore::SelectElement::typeAheadFind):
  4265. (WebCore::SelectElement::insertedIntoTree):
  4266. (WebCore::SelectElementData::SelectElementData):
  4267. (WebCore::SelectElementData::~SelectElementData):
  4268. (WebCore::SelectElementData::checkListItems):
  4269. (WebCore::SelectElementData::listItems):
  4270. * dom/SelectElement.h:
  4271. (WebCore::SelectElementData::multiple):
  4272. (WebCore::SelectElementData::setMultiple):
  4273. (WebCore::SelectElementData::size):
  4274. (WebCore::SelectElementData::setSize):
  4275. (WebCore::SelectElementData::usesMenuList):
  4276. (WebCore::SelectElementData::lastOnChangeIndex):
  4277. (WebCore::SelectElementData::setLastOnChangeIndex):
  4278. (WebCore::SelectElementData::lastOnChangeSelection):
  4279. (WebCore::SelectElementData::activeSelectionState):
  4280. (WebCore::SelectElementData::setActiveSelectionState):
  4281. (WebCore::SelectElementData::activeSelectionAnchorIndex):
  4282. (WebCore::SelectElementData::setActiveSelectionAnchorIndex):
  4283. (WebCore::SelectElementData::activeSelectionEndIndex):
  4284. (WebCore::SelectElementData::setActiveSelectionEndIndex):
  4285. (WebCore::SelectElementData::cachedStateForActiveSelection):
  4286. (WebCore::SelectElementData::shouldRecalcListItems):
  4287. (WebCore::SelectElementData::setShouldRecalcListItems):
  4288. (WebCore::SelectElementData::rawListItems):
  4289. (WebCore::SelectElementData::repeatingChar):
  4290. (WebCore::SelectElementData::setRepeatingChar):
  4291. (WebCore::SelectElementData::lastCharTime):
  4292. (WebCore::SelectElementData::setLastCharTime):
  4293. (WebCore::SelectElementData::typedString):
  4294. (WebCore::SelectElementData::setTypedString):
  4295. * html/HTMLOptionElement.h:
  4296. * html/HTMLSelectElement.cpp:
  4297. (WebCore::HTMLSelectElement::HTMLSelectElement):
  4298. (WebCore::HTMLSelectElement::recalcStyle):
  4299. (WebCore::HTMLSelectElement::formControlType):
  4300. (WebCore::HTMLSelectElement::selectedIndex):
  4301. (WebCore::HTMLSelectElement::deselectItems):
  4302. (WebCore::HTMLSelectElement::setSelectedIndex):
  4303. (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
  4304. (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
  4305. (WebCore::HTMLSelectElement::saveFormControlState):
  4306. (WebCore::HTMLSelectElement::restoreFormControlState):
  4307. (WebCore::HTMLSelectElement::parseMappedAttribute):
  4308. (WebCore::HTMLSelectElement::canSelectAll):
  4309. (WebCore::HTMLSelectElement::selectAll):
  4310. (WebCore::HTMLSelectElement::createRenderer):
  4311. (WebCore::HTMLSelectElement::appendFormData):
  4312. (WebCore::HTMLSelectElement::optionToListIndex):
  4313. (WebCore::HTMLSelectElement::listToOptionIndex):
  4314. (WebCore::HTMLSelectElement::recalcListItems):
  4315. (WebCore::HTMLSelectElement::setRecalcListItems):
  4316. (WebCore::HTMLSelectElement::reset):
  4317. (WebCore::HTMLSelectElement::dispatchFocusEvent):
  4318. (WebCore::HTMLSelectElement::dispatchBlurEvent):
  4319. (WebCore::HTMLSelectElement::defaultEventHandler):
  4320. (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
  4321. (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
  4322. (WebCore::HTMLSelectElement::updateListBoxSelection):
  4323. (WebCore::HTMLSelectElement::menuListOnChange):
  4324. (WebCore::HTMLSelectElement::listBoxOnChange):
  4325. (WebCore::HTMLSelectElement::saveLastSelection):
  4326. (WebCore::HTMLSelectElement::setOption):
  4327. (WebCore::HTMLSelectElement::scrollToSelection):
  4328. (WebCore::HTMLSelectElement::insertedIntoTree):
  4329. * html/HTMLSelectElement.h:
  4330. (WebCore::HTMLSelectElement::size):
  4331. (WebCore::HTMLSelectElement::multiple):
  4332. (WebCore::HTMLSelectElement::listItems):
  4333. * wml/WMLOptionElement.cpp:
  4334. (WebCore::WMLOptionElement::text):
  4335. * wml/WMLOptionElement.h:
  4336. 2009-05-28 Adam Roben <aroben@apple.com>
  4337. Don't try to use the new combobox parts on Vista in Classic mode
  4338. Fixes:
  4339. <rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
  4340. theme: drop down lists in Preferences get a line/square
  4341. <rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
  4342. down lists are black with a circle on many sites
  4343. Reviewed by Steve Falkenburg.
  4344. * rendering/RenderThemeWin.cpp:
  4345. (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox
  4346. parts when we have a theme (i.e., when we're not in Classic mode).
  4347. When we don't have a theme, fall back to the pre-r42289 code.
  4348. 2009-05-27 Peter Kasting <pkasting@google.com>
  4349. Reviewed by Simon Fraser.
  4350. https://bugs.webkit.org/show_bug.cgi?id=25659
  4351. Avoid calling frameCount() unnecessarily (which could lead to extra
  4352. GIF decoding).
  4353. * platform/graphics/BitmapImage.cpp:
  4354. (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
  4355. 2009-05-28 Simon Fraser <simon.fraser@apple.com>
  4356. Reviewed by Oliver Hunt.
  4357. https://bugs.webkit.org/show_bug.cgi?id=8736
  4358. Tests: fast/borders/border-radius-constraints.html
  4359. fast/borders/border-radius-split-inline.html
  4360. When the sum of the corner radii on a side exceed the length of the side,
  4361. reduce the radii according to CSS 3 rules.
  4362. Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
  4363. the constraints. Use that for painting borders, box-shadow, clipping replaced
  4364. elements
  4365. * platform/graphics/IntSize.h:
  4366. (WebCore::IntSize::scale):
  4367. Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
  4368. * platform/graphics/Path.cpp:
  4369. Make the QUARTER const static.
  4370. * rendering/RenderBox.cpp:
  4371. (WebCore::RenderBox::pushContentsClip):
  4372. Use getBorderRadiiForRect to fetch border radii.
  4373. * rendering/RenderBoxModelObject.cpp:
  4374. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  4375. Use getBorderRadiiForRect to fetch border radii.
  4376. (WebCore::RenderBoxModelObject::paintBorder):
  4377. Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
  4378. borders for split inlines, which used to apply the radii for each segment,
  4379. and no longer does.
  4380. (WebCore::RenderBoxModelObject::paintBoxShadow):
  4381. Use getBorderRadiiForRect to fetch border radii.
  4382. * rendering/RenderReplaced.cpp:
  4383. (WebCore::RenderReplaced::paint):
  4384. Use getBorderRadiiForRect to fetch border radii for clipping.
  4385. * rendering/RenderWidget.cpp:
  4386. (WebCore::RenderWidget::paint):
  4387. Use getBorderRadiiForRect to fetch border radii for clipping.
  4388. * rendering/style/RenderStyle.h:
  4389. * rendering/style/RenderStyle.cpp:
  4390. (WebCore::RenderStyle::getBorderRadiiForRect):
  4391. New bottleneck method to fetch corner radiil given a rect, applying the constraint
  4392. rules.
  4393. 2009-05-28 Alexey Proskuryakov <ap@webkit.org>
  4394. Reviewed by Darin Adler.
  4395. https://bugs.webkit.org/show_bug.cgi?id=26005
  4396. Optimization for XPath //* does not preserve context size
  4397. Test: fast/xpath/position.html
  4398. Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
  4399. get a performance progression on my tests.
  4400. * xml/XPathPath.h: Removed broken optimizeStepPair().
  4401. * xml/XPathPath.cpp:
  4402. (WebCore::XPath::LocationPath::evaluate): Style fix.
  4403. (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair().
  4404. (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
  4405. (WebCore::XPath::Path::Path): Style fix.
  4406. * xml/XPathStep.cpp:
  4407. (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper.
  4408. (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported
  4409. (and might never be).
  4410. (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
  4411. * xml/XPathStep.h:
  4412. (WebCore::XPath::Step::NodeTest::data):
  4413. (WebCore::XPath::Step::NodeTest::namespaceURI):
  4414. Made these data members AtomicString to avoid repeated conversions. This is the biggest
  4415. performance win here.
  4416. * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
  4417. 2009-05-28 Stephen White <senorblanco@chromium.org>
  4418. Reviewed by Dimitri Glazkov.
  4419. When creating a linear or radial gradient with a single stop
  4420. at offset 1.0, the Skia layer was allocating 3 stops, but only
  4421. filling 2, leaving one uninitialized. Only 2 stops are necessary
  4422. in this case, at offsets (0.0, 1.0).
  4423. http://bugs.webkit.org/show_bug.cgi?id=26063
  4424. Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
  4425. LayoutTests/svg/custom/gradient-stop-corner-cases.svg
  4426. LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
  4427. * platform/graphics/skia/GradientSkia.cpp:
  4428. (WebCore::totalStopsNeeded):
  4429. 2009-05-28 Yury Semikhatsky <yurys@chromium.org>
  4430. Reviewed by Timothy Hatcher.
  4431. https://bugs.webkit.org/show_bug.cgi?id=26041
  4432. Allow adding resource source to WebInspector.SourceFrame asynchronously.
  4433. Provide common implementation for InspectorController::addResourceSourceToFrame and
  4434. InspectorController::addSourceToFrame methods.
  4435. * bindings/js/JSInspectorControllerCustom.cpp:
  4436. * bindings/v8/custom/V8InspectorControllerCustom.cpp:
  4437. * inspector/InspectorController.cpp:
  4438. (WebCore::InspectorController::addResourceSourceToFrame):
  4439. * inspector/InspectorController.h:
  4440. * inspector/InspectorController.idl:
  4441. * inspector/front-end/SourceFrame.js:
  4442. (WebInspector.SourceFrame.prototype.revealLine):
  4443. (WebInspector.SourceFrame.prototype.highlightLine):
  4444. (WebInspector.SourceFrame.prototype._loaded):
  4445. (WebInspector.SourceFrame.prototype._isContentLoaded):
  4446. * inspector/front-end/SourceView.js:
  4447. (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
  4448. (WebInspector.SourceView.prototype._contentLoaded):
  4449. 2009-05-28 Holger Hans Peter Freyther <zecke@selfish.org>
  4450. Reviewed by Xan Lopez.
  4451. After r44177 we had a problem when increasing the size
  4452. of the window the scrollbars stayed and were not hidden.
  4453. This was due WebCore giving up on the Scrollbar as it became
  4454. unnecessary but the GtkAdjustment remained unchanged.
  4455. So from the point of view of the GtkScrolledWindow scrolling
  4456. was still necessary and the GtkScrollbar kept being displayed.
  4457. Solve the issue by resetting the GtkAdjustment in the
  4458. destructor of ScrollbarGtk.
  4459. * platform/gtk/ScrollbarGtk.cpp:
  4460. (ScrollbarGtk::~ScrollbarGtk):
  4461. 2009-05-28 Adam Barth <abarth@webkit.org>
  4462. Reviewed by Darin Adler.
  4463. Clean up window.open()'s use of lexical and dynamic scope.
  4464. (Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
  4465. for DOMWindow::allowPopUp.)
  4466. Test: http/tests/security/frameNavigation/context-for-window-open.html
  4467. * bindings/js/JSDOMBinding.cpp:
  4468. (WebCore::toDynamicFrame):
  4469. (WebCore::processingUserGesture):
  4470. (WebCore::completeURL):
  4471. * bindings/js/JSDOMBinding.h:
  4472. * bindings/js/JSDOMWindowCustom.cpp:
  4473. (WebCore::createWindow):
  4474. (WebCore::JSDOMWindow::open):
  4475. (WebCore::JSDOMWindow::showModalDialog):
  4476. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  4477. (WebCore::CALLBACK_FUNC_DECL):
  4478. (WebCore::createWindow):
  4479. 2009-05-27 Alexey Proskuryakov <ap@webkit.org>
  4480. Reviewed by Oliver Hunt.
  4481. https://bugs.webkit.org/show_bug.cgi?id=26056
  4482. XPath string() function can be very slow
  4483. * xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
  4484. 2009-05-27 Dan Bernstein <mitz@apple.com>
  4485. Reviewed by Sam Weinig.
  4486. - fix <rdar://problem/6927761> <isindex> placeholder text is unstylable
  4487. and initially not visible
  4488. Test: fast/forms/isindex-placeholder.html
  4489. * css/html4.css: Added a default style for <isindex> placeholder text.
  4490. * html/HTMLInputElement.cpp:
  4491. (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call
  4492. the new protected function updatePlaceholderVisibility().
  4493. * html/HTMLInputElement.h:
  4494. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this
  4495. protected function to allow HTMLIsIndexElement::parseMappedAttribute()
  4496. to invoke InputElement::updatePlaceholderVisibility().
  4497. * html/HTMLIsIndexElement.cpp:
  4498. (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call
  4499. updatePlaceholderVisibility() when parsing the placeholder attribute.
  4500. * rendering/RenderTextControlSingleLine.cpp:
  4501. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there
  4502. is no placeholder pseudo-element style, use the normal style.
  4503. 2009-05-27 Sam Weinig <sam@webkit.org>
  4504. Reviewed by Maciej Stachowiak.
  4505. More cleanup of DOMWindow related functions.
  4506. * bindings/js/JSDOMWindowBase.cpp:
  4507. (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
  4508. * bindings/js/JSDOMWindowBase.h:
  4509. * bindings/js/JSDOMWindowCustom.cpp:
  4510. (WebCore::JSDOMWindow::showModalDialog): Update Comment.
  4511. * bindings/js/JSDOMWindowShell.cpp:
  4512. * bindings/js/JSDOMWindowShell.h:
  4513. Remove JSDOMWindowShell::clear(). It was unused.
  4514. * bindings/js/ScriptController.cpp:
  4515. (WebCore::ScriptController::clearWindowShell):
  4516. 2009-05-27 Sam Weinig <sam@webkit.org>
  4517. Reviewed by David Hyatt.
  4518. Miscellaneous cleanup of DOMWindow related functions.
  4519. * bindings/js/JSDOMGlobalObject.cpp:
  4520. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
  4521. * bindings/js/JSDOMWindowBase.cpp:
  4522. (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops
  4523. checking for null frames if the build does not support profiling.
  4524. (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling
  4525. clearHelperObjectProperties(). It is clearer.
  4526. * bindings/js/JSDOMWindowBase.h:
  4527. Removed now unused clearHelperObjectProperties() function, empty disconnectFrame()
  4528. function, and the empty destructor.
  4529. * bindings/js/JSDOMWindowShell.cpp:
  4530. * bindings/js/JSDOMWindowShell.h:
  4531. Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which
  4532. is a no-op.
  4533. * page/Frame.cpp:
  4534. (WebCore::Frame::~Frame):
  4535. (WebCore::Frame::pageDestroyed):
  4536. Remove calls to JSDOMWindowShell::disconnectFrame() which only called
  4537. JSDOMWindowBase::disconnectFrame(), which is a no-op.
  4538. 2009-05-27 Dimitri Glazkov <dglazkov@chromium.org>
  4539. Unreviewed, build fix.
  4540. https://bugs.webkit.org/show_bug.cgi?id=25974
  4541. Remove extra qualifiers from the ScheduledAction decl.
  4542. * bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
  4543. 2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  4544. Unreviewed make distcheck fix. One more missing file.
  4545. * GNUmakefile.am:
  4546. 2009-05-27 Antonio Gomes <antonio.gomes@openbossa.org>
  4547. Reviewed by Simon Hausmann.
  4548. [Qt] Fixed trunk build on Linux after r44126.
  4549. * WebCore.pro:
  4550. 2009-05-27 Eric Carlson <eric.carlson@apple.com>
  4551. Reviewed by Oliver Hunt.
  4552. <rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
  4553. * platform/graphics/MediaPlayer.cpp:
  4554. (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
  4555. 2009-05-27 David Levin <levin@chromium.org>
  4556. Reviewed by Maciej Stachowiak.
  4557. Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
  4558. https://bugs.webkit.org/show_bug.cgi?id=26029
  4559. No functional changes, so no tests.
  4560. * loader/FrameLoader.cpp:
  4561. (WebCore::FrameLoader::canLoad):
  4562. * loader/FrameLoader.h:
  4563. 2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  4564. Unreviewed build fix.
  4565. Remove file that does not exist from the build.
  4566. * GNUmakefile.am:
  4567. 2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  4568. Reviewed by Darin Adler.
  4569. Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
  4570. * dom/InputElement.h:
  4571. * dom/OptionGroupElement.h:
  4572. 2009-05-27 Alexey Proskuryakov <ap@webkit.org>
  4573. Reviewed by Darin Adler.
  4574. https://bugs.webkit.org/show_bug.cgi?id=17725
  4575. XPath should be case insensitive for HTML
  4576. Test: fast/xpath/node-name-case-sensitivity.html
  4577. * xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive
  4578. for HTML elements in HTML documents.
  4579. 2009-05-27 John Sullivan <sullivan@apple.com>
  4580. fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
  4581. bookmarks (at least) over Top Sites (at least)
  4582. Reviewed by Kevin Decker
  4583. * page/DragController.cpp:
  4584. (WebCore::DragController::dragExited):
  4585. nil check m_documentUnderMouse and take the "local file" case if it's nil
  4586. 2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
  4587. Reviewed by Gustavo Noronha.
  4588. When building on window, consider Windows specific files.
  4589. * GNUmakefile.am:
  4590. 2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  4591. Reviewed by George Staikos.
  4592. Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
  4593. InputElementData is too heavy, save storing two pointers by passing them
  4594. directly to the static helper functions (the only place which needs them).
  4595. * dom/InputElement.cpp:
  4596. (WebCore::InputElement::dispatchFocusEvent):
  4597. (WebCore::InputElement::dispatchBlurEvent):
  4598. (WebCore::InputElement::updatePlaceholderVisibility):
  4599. (WebCore::InputElement::updateFocusAppearance):
  4600. (WebCore::InputElement::updateSelectionRange):
  4601. (WebCore::InputElement::aboutToUnload):
  4602. (WebCore::InputElement::setValueFromRenderer):
  4603. (WebCore::InputElement::constrainValue):
  4604. (WebCore::InputElement::handleBeforeTextInsertedEvent):
  4605. (WebCore::InputElement::parseSizeAttribute):
  4606. (WebCore::InputElement::parseMaxLengthAttribute):
  4607. (WebCore::InputElement::updateValueIfNeeded):
  4608. (WebCore::InputElement::notifyFormStateChanged):
  4609. (WebCore::InputElementData::InputElementData):
  4610. * dom/InputElement.h:
  4611. * html/HTMLInputElement.cpp:
  4612. (WebCore::HTMLInputElement::HTMLInputElement):
  4613. (WebCore::HTMLInputElement::updateFocusAppearance):
  4614. (WebCore::HTMLInputElement::aboutToUnload):
  4615. (WebCore::HTMLInputElement::dispatchFocusEvent):
  4616. (WebCore::HTMLInputElement::dispatchBlurEvent):
  4617. (WebCore::HTMLInputElement::setInputType):
  4618. (WebCore::HTMLInputElement::setSelectionRange):
  4619. (WebCore::HTMLInputElement::parseMappedAttribute):
  4620. (WebCore::HTMLInputElement::setValue):
  4621. (WebCore::HTMLInputElement::setValueFromRenderer):
  4622. (WebCore::HTMLInputElement::setFileListFromRenderer):
  4623. (WebCore::HTMLInputElement::defaultEventHandler):
  4624. (WebCore::HTMLInputElement::constrainValue):
  4625. * wml/WMLInputElement.cpp:
  4626. (WebCore::WMLInputElement::WMLInputElement):
  4627. (WebCore::WMLInputElement::dispatchFocusEvent):
  4628. (WebCore::WMLInputElement::dispatchBlurEvent):
  4629. (WebCore::WMLInputElement::updateFocusAppearance):
  4630. (WebCore::WMLInputElement::aboutToUnload):
  4631. (WebCore::WMLInputElement::setValue):
  4632. (WebCore::WMLInputElement::setValueFromRenderer):
  4633. (WebCore::WMLInputElement::parseMappedAttribute):
  4634. (WebCore::WMLInputElement::defaultEventHandler):
  4635. (WebCore::WMLInputElement::constrainValue):
  4636. 2009-05-27 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  4637. Reviewed by George Staikos.
  4638. Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
  4639. OptionElementData saves an Element pointer, which is unnessary.
  4640. Just pass it to the static function calls directly.
  4641. * dom/OptionElement.cpp:
  4642. (WebCore::OptionElement::setSelectedState):
  4643. (WebCore::OptionElement::collectOptionText):
  4644. (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
  4645. (WebCore::OptionElement::collectOptionValue):
  4646. (WebCore::OptionElementData::OptionElementData):
  4647. * dom/OptionElement.h:
  4648. * html/HTMLOptionElement.cpp:
  4649. (WebCore::HTMLOptionElement::HTMLOptionElement):
  4650. (WebCore::HTMLOptionElement::text):
  4651. (WebCore::HTMLOptionElement::value):
  4652. (WebCore::HTMLOptionElement::setSelected):
  4653. (WebCore::HTMLOptionElement::setSelectedState):
  4654. (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
  4655. * wml/WMLOptionElement.cpp:
  4656. (WebCore::WMLOptionElement::WMLOptionElement):
  4657. (WebCore::WMLOptionElement::setSelectedState):
  4658. (WebCore::WMLOptionElement::value):
  4659. (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
  4660. 2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
  4661. Reviewed by Maciej Stachowiak.
  4662. When building with MinGW, don't use the __declspec(dl{import,export})
  4663. decorations and rely on the linker to use its nifty auto-import feature.
  4664. It is extremely hard to get the decorations right with MinGW in general
  4665. and impossible in WebKit, where the resulting shared library is linking
  4666. together some static libraries.
  4667. * config.h:
  4668. 2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
  4669. Reviewed by Xan Lopez.
  4670. https://bugs.webkit.org/show_bug.cgi?id=25613
  4671. Add a WebCore::Widget that can embed GtkWidget with and
  4672. without a GdkWindow. This can be used to embed any GtkWidget.
  4673. Some bits are directly copied from the Scrollbar implementation
  4674. but can not be easily shared here.
  4675. * GNUmakefile.am:
  4676. * platform/gtk/GtkPluginWidget.cpp: Added.
  4677. (WebCore::GtkPluginWidget::GtkPluginWidget):
  4678. (WebCore::GtkPluginWidget::invalidateRect):
  4679. (WebCore::GtkPluginWidget::frameRectsChanged):
  4680. (WebCore::GtkPluginWidget::paint):
  4681. * platform/gtk/GtkPluginWidget.h: Added.
  4682. 2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
  4683. Reviewed by Gustavo Noronha.
  4684. https://bugs.webkit.org/show_bug.cgi?id=25613.
  4685. Implement Widget::setIsSelected for Gtk+ by searching
  4686. for a property of the name "webkit-widget-is-selected" and if
  4687. such property exists we are going to set it. We expect
  4688. the property to take a boolean.
  4689. * platform/gtk/WidgetGtk.cpp:
  4690. (WebCore::Widget::setIsSelected):
  4691. 2009-05-26 Sam Weinig <sam@webkit.org>
  4692. Reviewed by Brady Eidson.
  4693. Fix for <rdar://problem/6916371>
  4694. iWeb 'Announce' button does nothing after publishing to MobileMe
  4695. Add ability to force content sniffing for all urls (including file: urls)
  4696. * WebCore.base.exp:
  4697. * platform/network/ResourceHandle.cpp:
  4698. (WebCore::ResourceHandle::shouldContentSniffURL):
  4699. (WebCore::ResourceHandle::forceContentSniffing):
  4700. * platform/network/ResourceHandle.h:
  4701. 2009-05-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  4702. Reviewed by Holger Freyther.
  4703. https://bugs.webkit.org/show_bug.cgi?id=25996
  4704. [Qt] Dead-code stripping for unix
  4705. * WebCore.pro: Turn on GCC dead-code stripping flags for Unix
  4706. 2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>
  4707. Reviewed by Dave Hyatt.
  4708. https://bugs.webkit.org/show_bug.cgi?id=25646
  4709. [GTK] Send onscroll events for the main FrameView
  4710. WebKit/GTK+ is currently not sending any onscroll
  4711. events for a frame with external adjustments. This is
  4712. due the fact that the value-changed signal of the GtkAdjustment
  4713. is handled by WebCore::ScrollView directly and is not going through
  4714. the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
  4715. WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
  4716. path.
  4717. Fix the above problem by wrapping the GtkAdjustment we get
  4718. assigned from GTK+ in a ScrollbarGtk that will not have any
  4719. visual appearance. Remove code from ScrollView that knows
  4720. about adjustments and create a special case for
  4721. WebCore::ScrollView::createScrollbar that will create such
  4722. a special WebCore::ScrollbarGtk.
  4723. * platform/ScrollView.cpp: Remove adjustment code
  4724. (WebCore::ScrollView::setHasHorizontalScrollbar):
  4725. (WebCore::ScrollView::setHasVerticalScrollbar):
  4726. (WebCore::ScrollView::updateScrollbars):
  4727. (WebCore::ScrollView::wheelEvent):
  4728. * platform/ScrollView.h: Remove adjustment code
  4729. * platform/gtk/ScrollViewGtk.cpp:
  4730. (WebCore::ScrollView::platformDestroy):
  4731. (WebCore::ScrollView::createScrollbar):
  4732. (WebCore::ScrollView::setGtkAdjustments):
  4733. * platform/gtk/ScrollbarGtk.cpp:
  4734. (ScrollbarGtk::createScrollbar): Special case.
  4735. (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment
  4736. (ScrollbarGtk::~ScrollbarGtk): Disconnect signal
  4737. (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
  4738. * platform/gtk/ScrollbarGtk.h:
  4739. 2009-05-26 Cameron Zwarich <zwarich@apple.com>
  4740. Reviewed by Maciej Stachowiak.
  4741. Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
  4742. <https://bugs.webkit.org/show_bug.cgi?id=26035>
  4743. <rdar://problem/6924087>
  4744. * platform/graphics/cg/ImageSourceCG.cpp:
  4745. (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image
  4746. is JPEG, there is no image type, or m_decoder is null.
  4747. 2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
  4748. Unreviewed build fix for the JPEGImageDecoder.
  4749. Revision 44167 removed stdio.h from the included headers and
  4750. this will lead to an error that FILE is not known inside the
  4751. jpeglib.h Put back the stdio.h include.
  4752. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  4753. 2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
  4754. Reviewed by Maciej Stachowiak.
  4755. Fix the crash issue while running layout tests after enalbed XHTMLMP
  4756. https://bugs.webkit.org/show_bug.cgi?id=26017
  4757. * dom/Document.cpp:
  4758. (WebCore::Document::isXHTMLMPDocument):
  4759. 2009-05-26 Anders Carlsson <andersca@apple.com>
  4760. Reviewed by Dan Bernstein.
  4761. <rdar://problem/6901751>
  4762. REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
  4763. Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
  4764. the improved selection drawing on Tiger.
  4765. * WebCore.Tiger.exp:
  4766. * platform/graphics/cg/GraphicsContextCG.cpp:
  4767. (WebCore::GraphicsContext::fillPath):
  4768. (WebCore::GraphicsContext::strokePath):
  4769. (WebCore::GraphicsContext::fillRect):
  4770. (WebCore::GraphicsContext::clip):
  4771. (WebCore::GraphicsContext::clipOut):
  4772. (WebCore::GraphicsContext::clipOutEllipseInRect):
  4773. (WebCore::GraphicsContext::clipPath):
  4774. (WebCore::GraphicsContext::addInnerRoundedRectClip):
  4775. (WebCore::GraphicsContext::strokeRect):
  4776. * platform/mac/WebCoreSystemInterface.h:
  4777. * platform/mac/WebCoreSystemInterface.mm:
  4778. * rendering/RenderBlock.cpp:
  4779. (WebCore::RenderBlock::fillSelectionGaps):
  4780. 2009-05-26 Peter Kasting <pkasting@google.com>
  4781. Reviewed by Eric Seidel.
  4782. https://bugs.webkit.org/show_bug.cgi?id=25709 part two
  4783. Mostly cosmetic changes, mainly to get image decoders for Cairo build to
  4784. comply with WebKit style guidelines:
  4785. * Fix header guard names
  4786. * Fix initializer list wrapping
  4787. * Fix class/function "{" wrapping
  4788. * Fix wrapping of long boolean expressions
  4789. * Fix whitespace around operators
  4790. * Eliminate whitespace on otherwise-blank lines
  4791. * No {} on single-line conditional arms
  4792. * Use 0 instead of NULL
  4793. * Don't #include "config.h" in headers
  4794. Also a few non-cosmetic changes:
  4795. * Remove unneeded #ifdef protecting the contents of these files. The
  4796. platforms listed don't match who uses these files anymore (even
  4797. without considering Skia), and platforms which don't use them at all
  4798. (like CG) aren't harmed by the files, since they don't have
  4799. equivalently-named classes. It's simpler to just ditch these.
  4800. * Convert a use of Vector<>& into SharedBuffer*, since that's how the
  4801. data is really stored anyway.
  4802. * Use size() instead of m_size, for consistency with Skia code, and
  4803. future-proofing (if a particular decoder wants to specialize this).
  4804. * Move an ASSERT that was slightly more aggressive than necessary.
  4805. * Change variable names/types for clarity/accuracy and to match Skia.
  4806. * Remove unnecessary macro magic to work around a problem which no
  4807. longer exists in the third-party JPEG headers.
  4808. * Stop silencing a portability warning about setjmp (the vcproj/vsprops
  4809. are the right place for this)
  4810. * In Skia code, don't explicitly check |m_failed| before calling
  4811. isSizeAvailable(), which itself checks |m_failed|.
  4812. * platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping.
  4813. (WebCore::RGBA32Buffer::):
  4814. (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping.
  4815. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
  4816. * platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
  4817. * platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
  4818. * platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping.
  4819. (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement.
  4820. (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer.
  4821. (WebCore::GIFImageDecoderPrivate::getColorMap):
  4822. (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping.
  4823. (WebCore::GIFImageDecoder::frameCount): Add comment.
  4824. (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators.
  4825. (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer.
  4826. (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting.
  4827. (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size.
  4828. (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name.
  4829. (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
  4830. * platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
  4831. * platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef.
  4832. (GIFImageReader::read):
  4833. * platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
  4834. * platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
  4835. * platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
  4836. * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning.
  4837. (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
  4838. * platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
  4839. * platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type.
  4840. (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
  4841. (WebCore::PNGImageReader::close): Add comment, zero another member for consistency.
  4842. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
  4843. (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h.
  4844. (WebCore::PNGImageDecoder::rowAvailable):
  4845. * platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
  4846. * platform/image-decoders/skia/GIFImageDecoder.cpp:
  4847. (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
  4848. (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
  4849. * platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
  4850. * platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes.
  4851. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
  4852. * platform/image-decoders/skia/JPEGImageDecoder.cpp:
  4853. (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL.
  4854. (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
  4855. * platform/image-decoders/skia/PNGImageDecoder.cpp:
  4856. (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
  4857. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
  4858. (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
  4859. (WebCore::rowAvailable):
  4860. * platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
  4861. * platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
  4862. * platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
  4863. 2009-05-26 Jian Li <jianli@chromium.org>
  4864. Reviewed by Dimitri Glazkov.
  4865. https://bugs.webkit.org/show_bug.cgi?id=25944
  4866. Remove the uses of V8 Locker in worker execution code. No additional test is needed.
  4867. The normal WebKit layout tests should cover it. However, layout tests that start
  4868. multiple workers will fail to pass due to test shell limitation in Chromium. To cover
  4869. this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
  4870. * bindings/v8/V8WorkerContextEventListener.cpp:
  4871. (WebCore::V8WorkerContextEventListener::handleEvent):
  4872. * bindings/v8/WorkerContextExecutionProxy.cpp:
  4873. (WebCore::WorkerContextExecutionProxy::dispose):
  4874. (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
  4875. (WebCore::WorkerContextExecutionProxy::evaluate):
  4876. (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
  4877. (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
  4878. 2009-05-26 Dmitry Titov <dimich@chromium.org>
  4879. Reviewed by Dimitri Glazkov.
  4880. https://bugs.webkit.org/show_bug.cgi?id=25974
  4881. Enable timers in Chromuim workers.
  4882. * bindings/v8/ScheduledAction.cpp:
  4883. (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
  4884. * bindings/v8/ScheduledAction.h:
  4885. (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
  4886. * bindings/v8/custom/V8WorkerContextCustom.cpp:
  4887. (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer.
  4888. Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
  4889. 2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
  4890. Unreviewed, build fix.
  4891. https://bugs.webkit.org/show_bug.cgi?id=23649
  4892. Update V8 bindings to match SQLTransactionErrorCallback change.
  4893. * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  4894. (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
  4895. * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
  4896. 2009-05-26 Dirk Schulze <krit@webkit.org>
  4897. Reviewed by Nikolas Zimmermann.
  4898. Move FilterEffect to platform/graphics/filters. First step to get an
  4899. SVG independent filter system.
  4900. * GNUmakefile.am:
  4901. * WebCore.pro:
  4902. * WebCore.xcodeproj/project.pbxproj:
  4903. * platform/graphics/filters/FilterEffect.cpp: Added.
  4904. (WebCore::FilterEffect::FilterEffect):
  4905. (WebCore::FilterEffect::~FilterEffect):
  4906. (WebCore::FilterEffect::externalRepresentation):
  4907. * platform/graphics/filters/FilterEffect.h: Added.
  4908. (WebCore::FilterEffect::xBoundingBoxMode):
  4909. (WebCore::FilterEffect::setXBoundingBoxMode):
  4910. (WebCore::FilterEffect::yBoundingBoxMode):
  4911. (WebCore::FilterEffect::setYBoundingBoxMode):
  4912. (WebCore::FilterEffect::widthBoundingBoxMode):
  4913. (WebCore::FilterEffect::setWidthBoundingBoxMode):
  4914. (WebCore::FilterEffect::heightBoundingBoxMode):
  4915. (WebCore::FilterEffect::setHeightBoundingBoxMode):
  4916. (WebCore::FilterEffect::subRegion):
  4917. (WebCore::FilterEffect::setSubRegion):
  4918. (WebCore::FilterEffect::resultImage):
  4919. (WebCore::FilterEffect::setEffectBuffer):
  4920. * svg/FilterEffect.cpp: Removed.
  4921. * svg/FilterEffect.h: Removed.
  4922. 2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
  4923. Reviewed by Maciej Stachowiak.
  4924. https://bugs.webkit.org/show_bug.cgi?id=23649
  4925. Update SQLTransactionErrorCallback to not return a value per changes in
  4926. HTML5 spec.
  4927. Test: storage/transaction-error-callback.html
  4928. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  4929. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  4930. * bindings/js/JSCustomSQLTransactionErrorCallback.h:
  4931. * storage/SQLTransaction.cpp:
  4932. (WebCore::SQLTransaction::SQLTransaction):
  4933. (WebCore::SQLTransaction::postflightAndCommit):
  4934. (WebCore::SQLTransaction::handleTransactionError):
  4935. (WebCore::SQLTransaction::deliverTransactionErrorCallback):
  4936. (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  4937. * storage/SQLTransaction.h:
  4938. * storage/SQLTransactionErrorCallback.h:
  4939. 2009-05-26 David Hyatt <hyatt@apple.com>
  4940. Reviewed by Darin Adler.
  4941. Fix for https://bugs.webkit.org/show_bug.cgi?id=25969
  4942. Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
  4943. continue to show scrollbars.
  4944. Added two tests in fast/dynamic.
  4945. * platform/ScrollView.cpp:
  4946. (WebCore::ScrollView::updateScrollbars):
  4947. 2009-05-26 Chris Fleizach <cfleizach@apple.com>
  4948. Reviewed by Mark Rowe.
  4949. Bug 25801: change AccessibilityAria -> AccessibilityARIA
  4950. https://bugs.webkit.org/show_bug.cgi?id=25801
  4951. * GNUmakefile.am:
  4952. * WebCore.order:
  4953. * WebCore.pro:
  4954. * WebCore.vcproj/WebCore.vcproj:
  4955. * WebCore.xcodeproj/project.pbxproj:
  4956. * WebCoreSources.bkl:
  4957. * accessibility/AXObjectCache.cpp:
  4958. (WebCore::AXObjectCache::getOrCreate):
  4959. * accessibility/AccessibilityARIAGrid.cpp: Copied from WebCore/accessibility/AccessibilityAriaGrid.cpp.
  4960. (WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
  4961. (WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
  4962. (WebCore::AccessibilityARIAGrid::create):
  4963. (WebCore::AccessibilityARIAGrid::addChild):
  4964. (WebCore::AccessibilityARIAGrid::addChildren):
  4965. (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
  4966. * accessibility/AccessibilityARIAGrid.h: Copied from WebCore/accessibility/AccessibilityAriaGrid.h.
  4967. * accessibility/AccessibilityARIAGridCell.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridCell.cpp.
  4968. (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
  4969. (WebCore::AccessibilityARIAGridCell::~AccessibilityARIAGridCell):
  4970. (WebCore::AccessibilityARIAGridCell::create):
  4971. (WebCore::AccessibilityARIAGridCell::parentTable):
  4972. (WebCore::AccessibilityARIAGridCell::rowIndexRange):
  4973. (WebCore::AccessibilityARIAGridCell::columnIndexRange):
  4974. * accessibility/AccessibilityARIAGridCell.h: Copied from WebCore/accessibility/AccessibilityAriaGridCell.h.
  4975. * accessibility/AccessibilityARIAGridRow.cpp: Copied from WebCore/accessibility/AccessibilityAriaGridRow.cpp.
  4976. (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow):
  4977. (WebCore::AccessibilityARIAGridRow::~AccessibilityARIAGridRow):
  4978. (WebCore::AccessibilityARIAGridRow::create):
  4979. (WebCore::AccessibilityARIAGridRow::parentTable):
  4980. (WebCore::AccessibilityARIAGridRow::headerObject):
  4981. * accessibility/AccessibilityARIAGridRow.h: Copied from WebCore/accessibility/AccessibilityAriaGridRow.h.
  4982. * accessibility/AccessibilityAriaGrid.cpp: Removed.
  4983. * accessibility/AccessibilityAriaGrid.h: Removed.
  4984. * accessibility/AccessibilityAriaGridCell.cpp: Removed.
  4985. * accessibility/AccessibilityAriaGridCell.h: Removed.
  4986. * accessibility/AccessibilityAriaGridRow.cpp: Removed.
  4987. * accessibility/AccessibilityAriaGridRow.h: Removed.
  4988. 2009-05-26 Stephen White <senorblanco@chromium.org>
  4989. Reviewed by Dimitri Glazkov.
  4990. https://bugs.webkit.org/show_bug.cgi?id=26012
  4991. Fix the Skia path to normalize the given source rect when
  4992. drawing patterns, so it accepts negative width/height (as CG does).
  4993. Fixes Chromium bug http://www.crbug.com/6167.
  4994. * platform/graphics/skia/ImageSkia.cpp:
  4995. (WebCore::Image::drawPattern):
  4996. 2009-05-26 Pavel Feldman <pfeldman@chromium.org>
  4997. Reviewed by Timothy Hatcher.
  4998. Serialize calls to WebInspector. This is the first step where method
  4999. calls are being serialized to arrays (not yet JSON stringified ones) and
  5000. are being dispatched on the client. This change also allows client to override
  5001. InspectorFrontend, so that the serialized calls can be made on a given object
  5002. instead of in-process WebInspector global. This will be the main control flow
  5003. when InspectorController is decoupled from the in-process frontend.
  5004. https://bugs.webkit.org/show_bug.cgi?id=26010
  5005. * inspector/InspectorController.cpp:
  5006. (WebCore::InspectorController::scriptObjectReady):
  5007. (WebCore::InspectorController::overrideFrontendObject):
  5008. (WebCore::InspectorController::show):
  5009. (WebCore::InspectorController::populateScriptObjects):
  5010. * inspector/InspectorController.h:
  5011. * inspector/InspectorFrontend.cpp:
  5012. (WebCore::InspectorFrontend::addMessageToConsole):
  5013. (WebCore::InspectorFrontend::addResource):
  5014. (WebCore::InspectorFrontend::updateResource):
  5015. (WebCore::InspectorFrontend::removeResource):
  5016. (WebCore::InspectorFrontend::updateFocusedNode):
  5017. (WebCore::InspectorFrontend::setAttachedWindow):
  5018. (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
  5019. (WebCore::InspectorFrontend::showPanel):
  5020. (WebCore::InspectorFrontend::populateInterface):
  5021. (WebCore::InspectorFrontend::reset):
  5022. (WebCore::InspectorFrontend::debuggerWasEnabled):
  5023. (WebCore::InspectorFrontend::debuggerWasDisabled):
  5024. (WebCore::InspectorFrontend::profilerWasEnabled):
  5025. (WebCore::InspectorFrontend::profilerWasDisabled):
  5026. (WebCore::InspectorFrontend::parsedScriptSource):
  5027. (WebCore::InspectorFrontend::failedToParseScriptSource):
  5028. (WebCore::InspectorFrontend::addProfile):
  5029. (WebCore::InspectorFrontend::setRecordingProfile):
  5030. (WebCore::InspectorFrontend::pausedScript):
  5031. (WebCore::InspectorFrontend::resumedScript):
  5032. (WebCore::InspectorFrontend::addDatabase):
  5033. (WebCore::InspectorFrontend::addDOMStorage):
  5034. (WebCore::InspectorFrontend::newFunctionCall):
  5035. (WebCore::InspectorFrontend::callSimpleFunction):
  5036. * inspector/InspectorFrontend.h:
  5037. * inspector/front-end/inspector.js:
  5038. (WebInspector.dispatch):
  5039. 2009-05-25 Alexey Proskuryakov <ap@webkit.org>
  5040. Reviewed by Darin Adler.
  5041. <rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
  5042. * dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
  5043. * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
  5044. Adjust empty namespace before QNameComponentsTranslator black magic, not after.
  5045. 2009-05-25 David Levin <levin@chromium.org>
  5046. Reviewed by Maciej Stachowiak and Oliver Hunt.
  5047. Added forwarding headers.
  5048. * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  5049. * ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
  5050. 2009-05-25 Anders Carlsson <andersca@apple.com>
  5051. Reviewed by Sam Weinig.
  5052. - WebCore side of <rdar://problem/6914001>.
  5053. Add a new m_allowPopupsFromPlugin flag.
  5054. * bindings/js/ScriptController.cpp:
  5055. (WebCore::ScriptController::ScriptController):
  5056. (WebCore::ScriptController::processingUserGesture):
  5057. * bindings/js/ScriptController.h:
  5058. (WebCore::ScriptController::setAllowPopupsFromPlugin):
  5059. (WebCore::ScriptController::allowPopupsFromPlugin):
  5060. 2009-05-25 Adam Barth <abarth@webkit.org>
  5061. Reviewed by Sam Weinig.
  5062. https://bugs.webkit.org/show_bug.cgi?id=26006
  5063. Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
  5064. window.location. The correct use appears to be as follows:
  5065. 1) Use dynamicGlobalObject to find the user gesture.
  5066. 2) Use dynamicGlobalObject to complete URLs.
  5067. 3) Use lexicalGlobalObject to find the referrer.
  5068. 4) Use lexicalGlobalObject for the frame navigation checks.
  5069. 5) Use lexicalGlobalObject for the XSS checks.
  5070. Tests: http/tests/security/frameNavigation/context-for-location-assign.html
  5071. http/tests/security/frameNavigation/context-for-location-href.html
  5072. http/tests/security/frameNavigation/context-for-location.html
  5073. * bindings/js/JSDOMBinding.cpp:
  5074. (WebCore::shouldAllowNavigation):
  5075. (WebCore::toLexicalFrame):
  5076. (WebCore::processingUserGesture):
  5077. (WebCore::completeURL):
  5078. * bindings/js/JSDOMBinding.h:
  5079. * bindings/js/JSDOMWindowCustom.cpp:
  5080. (WebCore::JSDOMWindow::setLocation):
  5081. * bindings/js/JSLocationCustom.cpp:
  5082. (WebCore::navigateIfAllowed):
  5083. (WebCore::JSLocation::setHref):
  5084. (WebCore::JSLocation::replace):
  5085. (WebCore::JSLocation::reload):
  5086. (WebCore::JSLocation::assign):
  5087. (WebCore::JSLocation::toString):
  5088. (WebCore::JSLocationPrototype::customPut):
  5089. * bindings/v8/V8Utilities.cpp:
  5090. (WebCore::processingUserGesture):
  5091. (WebCore::shouldAllowNavigation):
  5092. (WebCore::completeURL):
  5093. (WebCore::navigateIfAllowed):
  5094. * bindings/v8/V8Utilities.h:
  5095. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  5096. (WebCore::V8Custom::WindowSetLocation):
  5097. * bindings/v8/custom/V8LocationCustom.cpp:
  5098. (WebCore::ACCESSOR_SETTER):
  5099. (WebCore::CALLBACK_FUNC_DECL):
  5100. 2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
  5101. Reviewed by Maciej Stachowiak.
  5102. With Windows compilers older then MSVC 2005, the functions
  5103. gmtime_s and localtime_s don't exist. The gmtime and localtime are
  5104. on Windows always thread safe. So use them in the cases where
  5105. gmtime_s and localtime_s are not present.
  5106. * loader/FTPDirectoryDocument.cpp:
  5107. * loader/FTPDirectoryParser.cpp:
  5108. 2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>
  5109. Reviewed by Simon Hausmann.
  5110. Follow up on r44120. PluginPackageMac.cpp is used
  5111. by Qt on Mac and contained a copy of the m_browserFunc
  5112. assignments and ::equal, ::hash and ::compareFileVersion.
  5113. Change it to use the ones from PluginPackage.cpp as well.
  5114. * plugins/mac/PluginPackageMac.cpp:
  5115. (WebCore::PluginPackage::load):
  5116. 2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
  5117. Reviewed by Tor Arne Vestbø.
  5118. https://bugs.webkit.org/show_bug.cgi?id=25612
  5119. Support conditionals in the tag factories, by placing
  5120. feature #ifdefs around the individual factory functions
  5121. and the registration.
  5122. Made the Audio and Video elements conditional in the tag factories
  5123. * html/HTMLTagNames.in:
  5124. * dom/make_names.pl:
  5125. 2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
  5126. Fix the Gtk build when video is disabled.
  5127. * GNUmakefile.am: Always generate and compile the IDL files for the media
  5128. elements. They contain proper feature #ifdefs.
  5129. 2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
  5130. Fix the Qt build when video is disabled.
  5131. * WebCore.pro: Always generate the IDL files for the media elements. They
  5132. contain proper ENABLE(VIDEO) #ifdefs.
  5133. 2009-05-25 Adam Barth <abarth@webkit.org>
  5134. Reviewed by Maciej Stachowiak.
  5135. https://bugs.webkit.org/show_bug.cgi?id=26004
  5136. The origin for postMessage should follow lexical scope, not dynamic
  5137. scope. Yes, this is a super-obscure corner case.
  5138. Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
  5139. * bindings/js/JSDOMWindowCustom.cpp:
  5140. (WebCore::JSDOMWindow::postMessage):
  5141. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  5142. (WebCore::CALLBACK_FUNC_DECL):
  5143. 2009-05-24 Darin Fisher <darin@chromium.org>
  5144. Reviewed by Mark Rowe.
  5145. Fix build bustage related to PassOwnPtr changes.
  5146. https://bugs.webkit.org/show_bug.cgi?id=25999
  5147. * platform/graphics/chromium/TransparencyWin.cpp:
  5148. 2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
  5149. Reviewed by Maciej Stachowiak.
  5150. https://bugs.webkit.org/show_bug.cgi?id=25988
  5151. Minor cleanup in PluginPackage::hash. Let the compiler
  5152. figure out the size of the array. Do not have it in the
  5153. definition and specially not the in the call to
  5154. StringImpl::hash.
  5155. * plugins/PluginPackage.cpp:
  5156. (WebCore::PluginPackage::hash):
  5157. 2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
  5158. Reviewed by Maciej Stachowiak.
  5159. https://bugs.webkit.org/show_bug.cgi?id=25988
  5160. Move ::hash, ::equal and ::compareFileVersion from
  5161. the duplicated copies in PluginPackageQt.cpp and
  5162. PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
  5163. this for the PluginPackageWin version. Use the new style
  5164. ENABLE() for this feature/policy and enable it in the Gtk+
  5165. and Qt buildsystem.
  5166. * GNUmakefile.am:
  5167. * WebCore.pro:
  5168. * plugins/PluginPackage.cpp:
  5169. (WebCore::PluginPackage::hash):
  5170. (WebCore::PluginPackage::equal):
  5171. (WebCore::PluginPackage::compareFileVersion):
  5172. * plugins/gtk/PluginPackageGtk.cpp:
  5173. * plugins/qt/PluginPackageQt.cpp:
  5174. 2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
  5175. Reviewed by Maciej Stachowiak.
  5176. https://bugs.webkit.org/show_bug.cgi?id=25988
  5177. So far the initialization of the browserfuncs struct
  5178. is done in PluginPackageQt, PluginPackageGtk and
  5179. PluginPackageWin there is no need for this duplication.
  5180. The PluginPackageWin version got copied to PluginPackage
  5181. * plugins/PluginPackage.cpp:
  5182. (WebCore::PluginPackage::initializeBrowserFuncs):
  5183. * plugins/PluginPackage.h:
  5184. * plugins/gtk/PluginPackageGtk.cpp:
  5185. (WebCore::PluginPackage::load):
  5186. * plugins/qt/PluginPackageQt.cpp:
  5187. (WebCore::PluginPackage::load):
  5188. * plugins/win/PluginPackageWin.cpp:
  5189. (WebCore::PluginPackage::load):
  5190. 2009-05-24 Dirk Schulze <krit@webkit.org>
  5191. Reviewed by Nikolas Zimmermann.
  5192. WebKit needs cross-platform filter system
  5193. [https://bugs.webkit.org/show_bug.cgi?id=19991]
  5194. Added standard input for filter system.
  5195. No testcases were added. Filter system is still off.
  5196. * GNUmakefile.am:
  5197. * WebCore.pro:
  5198. * WebCore.xcodeproj/project.pbxproj:
  5199. * platform/graphics/filters/SourceAlpha.cpp: Added.
  5200. (WebCore::SourceAlpha::create):
  5201. (WebCore::SourceAlpha::effectName):
  5202. (WebCore::SourceAlpha::apply):
  5203. (WebCore::SourceAlpha::dump):
  5204. * platform/graphics/filters/SourceAlpha.h: Added.
  5205. (WebCore::SourceAlpha::SourceAlpha):
  5206. * platform/graphics/filters/SourceGraphic.cpp: Added.
  5207. (WebCore::SourceGraphic::create):
  5208. (WebCore::SourceGraphic::effectName):
  5209. (WebCore::SourceGraphic::apply):
  5210. (WebCore::SourceGraphic::dump):
  5211. * platform/graphics/filters/SourceGraphic.h: Added.
  5212. (WebCore::SourceGraphic::SourceGraphic):
  5213. * svg/FilterBuilder.cpp: Added.
  5214. (WebCore::FilterBuilder::FilterBuilder):
  5215. (WebCore::FilterBuilder::add):
  5216. (WebCore::FilterBuilder::getEffectById):
  5217. (WebCore::FilterBuilder::clearEffects):
  5218. * svg/FilterBuilder.h:
  5219. 2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>
  5220. Reviewed by Maciej Stachowiak.
  5221. https://bugs.webkit.org/show_bug.cgi?id=25612
  5222. Add support conditionals in the JSC bindings generator code for attributes,
  5223. by placing feature #ifdefs around the setters/getters.
  5224. Made the audio and video element specific DOM attributes conditional
  5225. in the generated code, by moving the #ifdefs from the IDL files into
  5226. the generated code. This allows for re-using the same generated code
  5227. with or without ENABLE(VIDEO).
  5228. * page/DOMWindow.idl:
  5229. * bindings/scripts/CodeGeneratorJS.pm:
  5230. 2009-05-23 Holger Hans Peter Freyther <zecke@selfish.org>
  5231. Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
  5232. * platform/text/qt/TextCodecQt.cpp:
  5233. (WebCore::newTextCodecQt):
  5234. 2009-05-23 Dan Bernstein <mitz@apple.com>
  5235. Reviewed by Darin Adler.
  5236. - clean up ColorMac a little
  5237. * platform/graphics/mac/ColorMac.h: Whitespace change.
  5238. * platform/graphics/mac/ColorMac.mm: Removed redundant #import
  5239. statements and sorted the remaining ones.
  5240. (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls
  5241. with a single call and removed redundant casts to int.
  5242. (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats.
  5243. In one case, this avoids an intermediate conversion to float before
  5244. conversion to double on 64-bit.
  5245. (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls
  5246. with a single call.
  5247. (WebCore::focusRingColor):
  5248. (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
  5249. 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
  5250. Reviewed by Xan Lopez.
  5251. [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
  5252. https://bugs.webkit.org/show_bug.cgi?id=25900
  5253. Use ATK_ROLE_TEXT for ListMarkerRole.
  5254. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  5255. (atkRole):
  5256. 2009-05-23 David Kilzer <ddkilzer@apple.com>
  5257. Reformat WebCore::requiresContextForWordBoundary()
  5258. * platform/text/TextBoundaries.h:
  5259. (WebCore::requiresContextForWordBoundary):
  5260. 2009-05-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  5261. Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
  5262. * platform/network/ResourceHandle.cpp:
  5263. (WebCore::ResourceHandle::shouldContentSniffURL):
  5264. 2009-05-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  5265. Reviewed by Darin Adler.
  5266. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
  5267. After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
  5268. RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
  5269. This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
  5270. WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
  5271. HTMLSelectElement/WMLSelectElement.
  5272. * GNUmakefile.am:
  5273. * WebCore.pro:
  5274. * WebCore.vcproj/WebCore.vcproj:
  5275. * WebCore.xcodeproj/project.pbxproj:
  5276. * WebCoreSources.bkl:
  5277. * accessibility/AccessibilityListBox.cpp:
  5278. (WebCore::AccessibilityListBox::addChildren):
  5279. (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  5280. * accessibility/AccessibilityListBoxOption.cpp:
  5281. (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
  5282. * accessibility/AccessibilityRenderObject.cpp:
  5283. (WebCore::AccessibilityRenderObject::actionElement):
  5284. * dom/Element.h:
  5285. (WebCore::Element::isFormControlElement):
  5286. (WebCore::Element::dispatchFormControlChangeEvent):
  5287. * dom/SelectElement.cpp: Added.
  5288. (WebCore::toSelectElement):
  5289. * dom/SelectElement.h: Added.
  5290. (WebCore::SelectElement::~SelectElement):
  5291. * html/HTMLFormControlElement.cpp:
  5292. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
  5293. * html/HTMLFormControlElement.h:
  5294. * html/HTMLInputElement.cpp:
  5295. (WebCore::HTMLInputElement::setChecked):
  5296. (WebCore::HTMLInputElement::defaultEventHandler):
  5297. * html/HTMLOptionElement.cpp:
  5298. (WebCore::HTMLOptionElement::index):
  5299. * html/HTMLSelectElement.cpp:
  5300. (WebCore::HTMLSelectElement::selectedIndex):
  5301. (WebCore::HTMLSelectElement::lastSelectedListIndex):
  5302. (WebCore::HTMLSelectElement::deselectItems):
  5303. (WebCore::HTMLSelectElement::setSelectedIndex):
  5304. (WebCore::HTMLSelectElement::length):
  5305. (WebCore::HTMLSelectElement::remove):
  5306. (WebCore::HTMLSelectElement::value):
  5307. (WebCore::HTMLSelectElement::setValue):
  5308. (WebCore::HTMLSelectElement::saveFormControlState):
  5309. (WebCore::HTMLSelectElement::restoreFormControlState):
  5310. (WebCore::HTMLSelectElement::selectAll):
  5311. (WebCore::HTMLSelectElement::appendFormData):
  5312. (WebCore::HTMLSelectElement::optionToListIndex):
  5313. (WebCore::HTMLSelectElement::listToOptionIndex):
  5314. (WebCore::HTMLSelectElement::recalcListItems):
  5315. (WebCore::HTMLSelectElement::reset):
  5316. (WebCore::HTMLSelectElement::dispatchFocusEvent):
  5317. (WebCore::HTMLSelectElement::dispatchBlurEvent):
  5318. (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
  5319. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  5320. (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
  5321. (WebCore::HTMLSelectElement::updateListBoxSelection):
  5322. (WebCore::HTMLSelectElement::menuListOnChange):
  5323. (WebCore::HTMLSelectElement::listBoxOnChange):
  5324. (WebCore::HTMLSelectElement::saveLastSelection):
  5325. (WebCore::HTMLSelectElement::typeAheadFind):
  5326. (WebCore::HTMLSelectElement::nextSelectableListIndex):
  5327. (WebCore::HTMLSelectElement::previousSelectableListIndex):
  5328. (WebCore::HTMLSelectElement::setLength):
  5329. (WebCore::HTMLSelectElement::checkListItems):
  5330. * html/HTMLSelectElement.h:
  5331. (WebCore::HTMLSelectElement::size):
  5332. (WebCore::HTMLSelectElement::multiple):
  5333. (WebCore::HTMLSelectElement::listItems):
  5334. (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
  5335. * platform/network/ResourceHandle.cpp:
  5336. (WebCore::ResourceHandle::shouldContentSniffURL):
  5337. * rendering/RenderFileUploadControl.cpp:
  5338. (WebCore::RenderFileUploadControl::valueChanged):
  5339. * rendering/RenderListBox.cpp:
  5340. (WebCore::RenderListBox::RenderListBox):
  5341. (WebCore::RenderListBox::updateFromElement):
  5342. (WebCore::RenderListBox::scrollToRevealSelection):
  5343. (WebCore::RenderListBox::size):
  5344. (WebCore::RenderListBox::numItems):
  5345. (WebCore::RenderListBox::paintItemForeground):
  5346. (WebCore::RenderListBox::paintItemBackground):
  5347. (WebCore::RenderListBox::panScroll):
  5348. (WebCore::RenderListBox::autoscroll):
  5349. (WebCore::RenderListBox::stopAutoscroll):
  5350. (WebCore::RenderListBox::valueChanged):
  5351. (WebCore::RenderListBox::nodeAtPoint):
  5352. * rendering/RenderListBox.h:
  5353. * rendering/RenderMenuList.cpp:
  5354. (WebCore::RenderMenuList::RenderMenuList):
  5355. (WebCore::RenderMenuList::updateOptionsWidth):
  5356. (WebCore::RenderMenuList::updateFromElement):
  5357. (WebCore::RenderMenuList::setTextFromOption):
  5358. (WebCore::RenderMenuList::showPopup):
  5359. (WebCore::RenderMenuList::valueChanged):
  5360. (WebCore::RenderMenuList::itemText):
  5361. (WebCore::RenderMenuList::itemIsEnabled):
  5362. (WebCore::RenderMenuList::itemStyle):
  5363. (WebCore::RenderMenuList::itemBackgroundColor):
  5364. (WebCore::RenderMenuList::listSize):
  5365. (WebCore::RenderMenuList::selectedIndex):
  5366. (WebCore::RenderMenuList::itemIsSeparator):
  5367. (WebCore::RenderMenuList::itemIsLabel):
  5368. (WebCore::RenderMenuList::itemIsSelected):
  5369. (WebCore::RenderMenuList::setTextFromItem):
  5370. * rendering/RenderMenuList.h:
  5371. * rendering/RenderSlider.cpp:
  5372. (WebCore::RenderSlider::setValueForPosition):
  5373. 2009-05-23 David Kilzer <ddkilzer@apple.com>
  5374. Fix Gtk/Qt builds for PassOwnPtr
  5375. * platform/graphics/cairo/ImageCairo.cpp:
  5376. (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer>
  5377. instead of an std::auto_ptr<ImageBuffer> to store the result of
  5378. ImageBuffer::create() now that it returns a
  5379. PassOwnPtr<ImageBuffer>.
  5380. * platform/graphics/qt/PathQt.cpp:
  5381. (WebCore::Path::strokeContains): Ditto.
  5382. (WebCore::Path::strokeBoundingRect): Ditto.
  5383. 2009-05-23 David Kilzer <ddkilzer@apple.com>
  5384. Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
  5385. <https://bugs.webkit.org/show_bug.cgi?id=25495>
  5386. Reviewed by Oliver Hunt.
  5387. No test cases added since there is no change in behavior.
  5388. * WebCore.base.exp: Updated export for
  5389. HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
  5390. * dom/Node.cpp:
  5391. (WebCore::Node::childNodes): Use NodeListsNodeData::create()
  5392. instead of new NodeListsNodeData.
  5393. (WebCore::Node::registerDynamicNodeList): Ditto.
  5394. (WebCore::Node::getElementsByTagNameNS): Ditto.
  5395. (WebCore::Node::getElementsByName): Ditto.
  5396. (WebCore::Node::getElementsByClassName): Ditto.
  5397. * dom/NodeRareData.h:
  5398. (WebCore::NodeListsNodeData::create): Added. Implements
  5399. create() pattern popularized by RefCounted classes.
  5400. (WebCore::NodeListsNodeData::NodeListsNodeData): Declared
  5401. private constructor.
  5402. (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<>
  5403. instead of an auto_ptr<>.
  5404. * history/HistoryItem.cpp:
  5405. (WebCore::HistoryItem::setRedirectURLs): Ditto.
  5406. * history/HistoryItem.h:
  5407. (WebCore::HistoryItem::setRedirectURLs): Ditto.
  5408. * html/CanvasRenderingContext2D.cpp:
  5409. (WebCore::CanvasRenderingContext2D::drawTextInternal): Use
  5410. OwnPtr<> instead of auto_ptr<> for stack variable.
  5411. * html/HTMLCanvasElement.cpp:
  5412. (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use
  5413. assignment operator now that ImageBuffer::create() returns a
  5414. PassOwnPtr<>.
  5415. * loader/EmptyClients.h:
  5416. (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a
  5417. PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
  5418. * page/ChromeClient.h:
  5419. (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
  5420. * platform/graphics/GeneratedImage.cpp:
  5421. (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of
  5422. auto_ptr<> for stack variable.
  5423. * platform/graphics/ImageBuffer.h:
  5424. (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of
  5425. auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack
  5426. variable.
  5427. * platform/mac/ScrollbarThemeMac.mm:
  5428. (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of
  5429. auto_ptr<> for stack variable.
  5430. * platform/text/TextCodec.h:
  5431. (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of
  5432. auto_ptr<>.
  5433. * platform/text/TextCodecICU.cpp:
  5434. (WebCore::newTextCodecICU): Ditto.
  5435. * platform/text/TextCodecLatin1.cpp:
  5436. (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
  5437. * platform/text/TextCodecUTF16.cpp:
  5438. (WebCore::newStreamingTextDecoderUTF16LE): Ditto.
  5439. (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
  5440. * platform/text/TextCodecUserDefined.cpp:
  5441. (WebCore::newStreamingTextDecoderUserDefined): Ditto.
  5442. * platform/text/TextEncodingRegistry.cpp:
  5443. (WebCore::newTextCodec): Ditto.
  5444. * platform/text/TextEncodingRegistry.h:
  5445. (WebCore::newTextCodec): Ditto.
  5446. * platform/text/mac/TextCodecMac.cpp:
  5447. (WebCore::newTextCodecMac): Ditto.
  5448. * rendering/RenderBoxModelObject.cpp:
  5449. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
  5450. OwnPtr<> instead of auto_ptr<> for stack variable.
  5451. * svg/SVGMaskElement.cpp:
  5452. (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return
  5453. OwnPtr<> instead of auto_ptr<>.
  5454. * svg/SVGMaskElement.h:
  5455. (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<>
  5456. instead of auto_ptr<>.
  5457. * svg/SVGPatternElement.cpp:
  5458. (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead
  5459. of auto_ptr<> for stack variable.
  5460. * svg/graphics/SVGImage.cpp:
  5461. (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use
  5462. assignment operator now that ImageBuffer::create() returns a
  5463. PassOwnPtr<>.
  5464. * svg/graphics/SVGPaintServerGradient.cpp:
  5465. (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<>
  5466. instead of auto_ptr<> for stack variable.
  5467. * svg/graphics/SVGPaintServerPattern.cpp:
  5468. (WebCore::SVGPaintServerPattern::setTile): Updated to take a
  5469. PassOwnPtr<> instead of an auto_ptr<>.
  5470. (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of
  5471. auto_ptr<> for stack variable.
  5472. * svg/graphics/SVGPaintServerPattern.h:
  5473. (WebCore::SVGPaintServerPattern::setTile): Updated to take a
  5474. PassOwnPtr<> instead of an auto_ptr<>.
  5475. * svg/graphics/SVGResourceMasker.cpp:
  5476. (WebCore::SVGResourceMasker::applyMask): Updated to use
  5477. assignment operator now that SVGMaskElement::drawMaskerContent()
  5478. returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for
  5479. stack variable.
  5480. 2009-05-23 David Kilzer <ddkilzer@apple.com>
  5481. Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
  5482. <https://bugs.webkit.org/show_bug.cgi?id=25495>
  5483. Reviewed by Oliver Hunt.
  5484. * ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  5485. * ForwardingHeaders/wtf/PassOwnPtr.h: Added.
  5486. * WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and
  5487. PassOwnPtr.h.
  5488. 2009-05-23 David Kilzer <ddkilzer@apple.com>
  5489. Fix Mac builds by backing out r44093
  5490. * bindings/js/JSCustomPositionCallback.cpp:
  5491. * bindings/js/JSCustomPositionCallback.h:
  5492. * bindings/js/JSCustomPositionErrorCallback.cpp:
  5493. * bindings/js/JSCustomPositionErrorCallback.h:
  5494. * bindings/js/JSGeolocationCustom.cpp:
  5495. * page/Geolocation.cpp:
  5496. * page/Geolocation.idl:
  5497. * page/Geoposition.cpp:
  5498. * page/Geoposition.h:
  5499. * page/Geoposition.idl:
  5500. * page/Navigator.cpp:
  5501. (WebCore::Navigator::disconnectFrame):
  5502. (WebCore::Navigator::geolocation):
  5503. * page/PositionError.idl:
  5504. * platform/GeolocationService.cpp:
  5505. (WebCore::GeolocationService::create):
  5506. 2009-05-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  5507. Reviewed by Eric Seidel.
  5508. Add GEOLOCATION guards around Geolocation API code
  5509. https://bugs.webkit.org/show_bug.cgi?id=25756
  5510. * bindings/js/JSCustomPositionCallback.cpp:
  5511. * bindings/js/JSCustomPositionCallback.h:
  5512. * bindings/js/JSCustomPositionErrorCallback.cpp:
  5513. * bindings/js/JSCustomPositionErrorCallback.h:
  5514. * bindings/js/JSGeolocationCustom.cpp:
  5515. * page/Geolocation.cpp:
  5516. * page/Geolocation.idl:
  5517. * page/Geoposition.cpp:
  5518. * page/Geoposition.h:
  5519. * page/Geoposition.idl:
  5520. * page/Navigator.cpp:
  5521. (WebCore::Navigator::disconnectFrame):
  5522. (WebCore::Navigator::geolocation):
  5523. * page/PositionError.idl:
  5524. * platform/GeolocationService.cpp:
  5525. 2009-05-23 David Kilzer <ddkilzer@apple.com>
  5526. Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
  5527. In r42377, startUpdateRenderingDispatcher() was renamed to
  5528. startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
  5529. dropped. This change restores it.
  5530. * WebCore.order:
  5531. * page/animation/AnimationController.cpp:
  5532. (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
  5533. (WebCore::AnimationControllerPrivate::addEventToDispatch):
  5534. (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
  5535. (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
  5536. (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  5537. * page/animation/AnimationControllerPrivate.h:
  5538. 2009-05-23 Holger Hans Peter Freyther <zecke@selfish.org>
  5539. Unreviewed build-fix for Qt. Disable SVG Filters.
  5540. SVG Filters can not be built right now and Qt should not have
  5541. them enabled anyway as they do not carry out any filtering.
  5542. * WebCore.pro:
  5543. 2009-05-23 Dirk Schulze <krit@webkit.org>
  5544. Unreviewed build-fix for gtk. Remove source input files
  5545. for SVG filter system from the build for the moment and
  5546. add them later again.
  5547. * GNUmakefile.am:
  5548. 2009-05-23 Dirk Schulze <krit@webkit.org>
  5549. Reviewed by Eric Seidel.
  5550. WebKit needs cross-platform filter system
  5551. [https://bugs.webkit.org/show_bug.cgi?id=19991]
  5552. Preparing Filter primitves for the new filter system.
  5553. No testcases were added. SVG filters are off by default.
  5554. * GNUmakefile.am:
  5555. * platform/graphics/filters/FEBlend.cpp:
  5556. (WebCore::FEBlend::apply):
  5557. * platform/graphics/filters/FEBlend.h:
  5558. * platform/graphics/filters/FEColorMatrix.cpp:
  5559. (WebCore::FEColorMatrix::apply):
  5560. * platform/graphics/filters/FEColorMatrix.h:
  5561. * platform/graphics/filters/FEComponentTransfer.cpp:
  5562. (WebCore::FEComponentTransfer::apply):
  5563. * platform/graphics/filters/FEComponentTransfer.h:
  5564. * platform/graphics/filters/FEComposite.cpp:
  5565. (WebCore::FEComposite::apply):
  5566. * platform/graphics/filters/FEComposite.h:
  5567. * svg/Filter.h:
  5568. * svg/FilterBuilder.h:
  5569. (WebCore::FilterBuilder::lastFilter):
  5570. * svg/FilterEffect.cpp:
  5571. (WebCore::FilterEffect::FilterEffect):
  5572. * svg/FilterEffect.h:
  5573. (WebCore::FilterEffect::xBoundingBoxMode):
  5574. (WebCore::FilterEffect::setXBoundingBoxMode):
  5575. (WebCore::FilterEffect::yBoundingBoxMode):
  5576. (WebCore::FilterEffect::setYBoundingBoxMode):
  5577. (WebCore::FilterEffect::widthBoundingBoxMode):
  5578. (WebCore::FilterEffect::setWidthBoundingBoxMode):
  5579. (WebCore::FilterEffect::heightBoundingBoxMode):
  5580. (WebCore::FilterEffect::setHeightBoundingBoxMode):
  5581. (WebCore::FilterEffect::subRegion):
  5582. (WebCore::FilterEffect::setSubRegion):
  5583. (WebCore::FilterEffect::resultImage):
  5584. (WebCore::FilterEffect::setEffectBuffer):
  5585. * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  5586. (WebCore::FEConvolveMatrix::apply):
  5587. * svg/graphics/filters/SVGFEConvolveMatrix.h:
  5588. * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  5589. (WebCore::FEDiffuseLighting::apply):
  5590. * svg/graphics/filters/SVGFEDiffuseLighting.h:
  5591. * svg/graphics/filters/SVGFEDisplacementMap.cpp:
  5592. (WebCore::FEDisplacementMap::apply):
  5593. * svg/graphics/filters/SVGFEDisplacementMap.h:
  5594. * svg/graphics/filters/SVGFEFlood.cpp:
  5595. (WebCore::FEFlood::apply):
  5596. * svg/graphics/filters/SVGFEFlood.h:
  5597. * svg/graphics/filters/SVGFEGaussianBlur.cpp:
  5598. (WebCore::FEGaussianBlur::apply):
  5599. * svg/graphics/filters/SVGFEGaussianBlur.h:
  5600. * svg/graphics/filters/SVGFEImage.cpp:
  5601. (WebCore::FEImage::apply):
  5602. * svg/graphics/filters/SVGFEImage.h:
  5603. * svg/graphics/filters/SVGFEMerge.cpp:
  5604. (WebCore::FEMerge::apply):
  5605. * svg/graphics/filters/SVGFEMerge.h:
  5606. * svg/graphics/filters/SVGFEMorphology.cpp:
  5607. (WebCore::FEMorphology::apply):
  5608. * svg/graphics/filters/SVGFEMorphology.h:
  5609. * svg/graphics/filters/SVGFEOffset.cpp:
  5610. (WebCore::FEOffset::apply):
  5611. * svg/graphics/filters/SVGFEOffset.h:
  5612. * svg/graphics/filters/SVGFESpecularLighting.cpp:
  5613. (WebCore::FESpecularLighting::apply):
  5614. * svg/graphics/filters/SVGFESpecularLighting.h:
  5615. * svg/graphics/filters/SVGFETile.cpp:
  5616. (WebCore::FETile::apply):
  5617. * svg/graphics/filters/SVGFETile.h:
  5618. * svg/graphics/filters/SVGFETurbulence.cpp:
  5619. (WebCore::FETurbulence::apply):
  5620. * svg/graphics/filters/SVGFETurbulence.h:
  5621. 2009-05-22 Dirk Schulze <krit@webkit.org>
  5622. Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
  5623. * platform/graphics/cairo/ImageCairo.cpp:
  5624. (WebCore::Image::drawPattern):
  5625. 2009-05-22 Dirk Schulze <vbs85@gmx.de>
  5626. Reviewed by Eric Seidel.
  5627. Added the use of tileRect() for a correct drawing of
  5628. border-images.
  5629. Testcases for border-image are in fast/borders like
  5630. border-image-01.html and will be activated for cairo, once
  5631. gtk supports pixel tests.
  5632. https://bugs.webkit.org/show_bug.cgi?id=19652
  5633. [CAIRO] wrong drawing of border-image
  5634. * platform/graphics/cairo/ImageCairo.cpp:
  5635. (WebCore::Image::drawPattern):
  5636. 2009-05-22 Holger Hans Peter Freyther <zecke@selfish.org>
  5637. Reviewed by Maciej Stachowiak.
  5638. https://bugs.webkit.org/show_bug.cgi?id=25684
  5639. Ask the Scrollbar for the orientation.
  5640. Use Scrollbar::orientation to figure out the
  5641. direction of scrolling.
  5642. * platform/ScrollView.cpp:
  5643. (WebCore::ScrollView::valueChanged):
  5644. 2009-05-22 Darin Adler <darin@apple.com>
  5645. Reviewed by Dan Bernstein.
  5646. <rdar://problem/6916082> Incorrect handling of % as CSS value.
  5647. Test: fast/css/percent-character-as-value.html
  5648. * css/CSSGrammar.y: Make a stray % character reliably cause
  5649. CSS parsing to succeed, but the CSS value to be ignored because
  5650. of incorrect type. A type of 0 has this effect.
  5651. 2009-05-22 Brent Fulgham <bfulgham@webkit.org>
  5652. Reviewed by Adam Roben.
  5653. https://bugs.webkit.org/show_bug.cgi?id=25971
  5654. Correct a handful of build errors in the Windows Cairo variant
  5655. due to missing VIDEO support.
  5656. * WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for
  5657. the Cairo-based Windows target.
  5658. * rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls
  5659. for non-VIDEO builds.
  5660. 2009-05-22 David Kilzer <ddkilzer@apple.com>
  5661. One <limits> is enough
  5662. * html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
  5663. 2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>
  5664. <rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
  5665. plug-in
  5666. Reviewed by Steve Falkenburg.
  5667. * plugins/win/PluginPackageWin.cpp:
  5668. (WebCore::PluginPackage::determineQuirks):
  5669. Look for the VLC plug-in's new name.
  5670. 2009-05-22 Adam Barth <abarth@webkit.org>
  5671. Reviewed by Darin Fisher.
  5672. https://bugs.webkit.org/show_bug.cgi?id=25966
  5673. Remove redudant member from Chromium's ResourceRequest. We already
  5674. have this data in the cross-platform ResourceRequestBase. Also, rename
  5675. ChromiumBridge parameter to be consistant with the new name for this
  5676. piece of data.
  5677. * platform/chromium/ChromiumBridge.h:
  5678. * platform/network/chromium/ResourceRequest.h:
  5679. 2009-05-22 Kevin Watters <kevinwatters@gmail.com>
  5680. Reviewed by Kevin Ollivier.
  5681. Only account for overhang for multi-character strings.
  5682. https://bugs.webkit.org/show_bug.cgi?id=25961
  5683. * platform/wx/wxcode/win/fontprops.cpp:
  5684. (GetTextExtent):
  5685. 2009-05-22 Kevin Ollivier <kevino@theolliviers.com>
  5686. wx build fix. Switch to CURL cookies so we can benefit from API updates.
  5687. * platform/wx/TemporaryLinkStubs.cpp:
  5688. * webcore-wx.bkl:
  5689. 2009-05-22 Peter Kasting <pkasting@google.com>
  5690. Reviewed by Darin Fisher.
  5691. https://bugs.webkit.org/show_bug.cgi?id=25709 part one
  5692. Indent contents of namespaces in header files, to comply with the
  5693. style guide. No functional change.
  5694. * platform/image-decoders/ImageDecoder.h:
  5695. (WebCore::RGBA32Buffer::):
  5696. (WebCore::RGBA32Buffer::RGBA32Buffer):
  5697. (WebCore::RGBA32Buffer::clear):
  5698. (WebCore::RGBA32Buffer::bytes):
  5699. (WebCore::RGBA32Buffer::rect):
  5700. (WebCore::RGBA32Buffer::height):
  5701. (WebCore::RGBA32Buffer::status):
  5702. (WebCore::RGBA32Buffer::duration):
  5703. (WebCore::RGBA32Buffer::disposalMethod):
  5704. (WebCore::RGBA32Buffer::hasAlpha):
  5705. (WebCore::RGBA32Buffer::setRect):
  5706. (WebCore::RGBA32Buffer::ensureHeight):
  5707. (WebCore::RGBA32Buffer::setStatus):
  5708. (WebCore::RGBA32Buffer::setDuration):
  5709. (WebCore::RGBA32Buffer::setDisposalMethod):
  5710. (WebCore::RGBA32Buffer::setHasAlpha):
  5711. (WebCore::RGBA32Buffer::setRGBA):
  5712. (WebCore::ImageDecoder::m_failed):
  5713. (WebCore::ImageDecoder::~ImageDecoder):
  5714. (WebCore::ImageDecoder::setData):
  5715. (WebCore::ImageDecoder::size):
  5716. (WebCore::ImageDecoder::frameCount):
  5717. (WebCore::ImageDecoder::repetitionCount):
  5718. (WebCore::ImageDecoder::supportsAlpha):
  5719. (WebCore::ImageDecoder::failed):
  5720. (WebCore::ImageDecoder::setFailed):
  5721. (WebCore::ImageDecoder::clearFrameBufferCache):
  5722. * platform/image-decoders/bmp/BMPImageDecoder.h:
  5723. (WebCore::BMPImageDecoder::filenameExtension):
  5724. * platform/image-decoders/gif/GIFImageDecoder.h:
  5725. (WebCore::GIFImageDecoder::filenameExtension):
  5726. (WebCore::GIFImageDecoder::frameDurationAtIndex):
  5727. (WebCore::GIFImageDecoder::):
  5728. * platform/image-decoders/ico/ICOImageDecoder.h:
  5729. (WebCore::ICOImageDecoder::filenameExtension):
  5730. * platform/image-decoders/jpeg/JPEGImageDecoder.h:
  5731. (WebCore::JPEGImageDecoder::filenameExtension):
  5732. (WebCore::JPEGImageDecoder::supportsAlpha):
  5733. (WebCore::JPEGImageDecoder::reader):
  5734. (WebCore::JPEGImageDecoder::setSize):
  5735. * platform/image-decoders/png/PNGImageDecoder.h:
  5736. (WebCore::PNGImageDecoder::filenameExtension):
  5737. (WebCore::PNGImageDecoder::reader):
  5738. (WebCore::PNGImageDecoder::decodingFailed):
  5739. * platform/image-decoders/xbm/XBMImageDecoder.h:
  5740. (WebCore::XBMImageDecoder::filenameExtension):
  5741. 2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
  5742. Reviewed by Gustavo Noronha.
  5743. https://bugs.webkit.org/show_bug.cgi?id=15914
  5744. [GTK] Implement Unicode functionality using GLib
  5745. Minor changes that allow building a hybrid version of WebKit
  5746. that has WTF Unicode backend based on GLib functions while
  5747. text codecs and TextBreakIterator remain based on ICU.
  5748. Fixed some includes that were assuming a WTF ICU backend and
  5749. introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
  5750. macro.
  5751. * platform/ThreadGlobalData.cpp:
  5752. (WebCore::ThreadGlobalData::ThreadGlobalData):
  5753. (WebCore::ThreadGlobalData::~ThreadGlobalData):
  5754. * platform/ThreadGlobalData.h:
  5755. * platform/text/TextBoundariesICU.cpp:
  5756. * platform/text/TextCodecICU.h:
  5757. * platform/text/TextEncoding.cpp:
  5758. (WebCore::TextEncoding::encode):
  5759. * platform/text/TextEncodingRegistry.cpp:
  5760. (WebCore::buildBaseTextCodecMaps):
  5761. (WebCore::extendTextCodecMaps):
  5762. 2009-05-22 Adam Barth <abarth@webkit.org>
  5763. Reviewed by Maciej Stachowiak.
  5764. https://bugs.webkit.org/show_bug.cgi?id=25955
  5765. Remove the policyBaseURL parameter from setCookie. This parameter is
  5766. redundant with the document parameter.
  5767. * WebCore.base.exp:
  5768. * WebCore.order:
  5769. * dom/Document.cpp:
  5770. (WebCore::Document::setCookie):
  5771. * platform/CookieJar.h:
  5772. * platform/mac/CookieJar.mm:
  5773. (WebCore::setCookies):
  5774. * platform/network/chromium/CookieJarChromium.cpp:
  5775. (WebCore::setCookies):
  5776. * platform/network/curl/CookieJarCurl.cpp:
  5777. (WebCore::setCookies):
  5778. * platform/network/soup/CookieJarSoup.cpp:
  5779. (WebCore::setCookies):
  5780. * platform/network/win/CookieJarCFNetWin.cpp:
  5781. (WebCore::setCookies):
  5782. * platform/network/win/CookieJarWin.cpp:
  5783. (WebCore::setCookies):
  5784. * platform/qt/CookieJarQt.cpp:
  5785. (WebCore::setCookies):
  5786. 2009-05-22 Adam Barth <abarth@webkit.org>
  5787. Reviewed by Maciej Stachowiak.
  5788. https://bugs.webkit.org/show_bug.cgi?id=25955
  5789. Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
  5790. previous names were confusing and inaccurate.
  5791. * WebCore.order:
  5792. * dom/Document.cpp:
  5793. (WebCore::Document::setCookie):
  5794. * dom/Document.h:
  5795. (WebCore::Document::firstPartyForCookies):
  5796. (WebCore::Document::setFirstPartyForCookies):
  5797. * loader/FrameLoader.cpp:
  5798. (WebCore::FrameLoader::begin):
  5799. (WebCore::FrameLoader::updateFirstPartyForCookies):
  5800. (WebCore::FrameLoader::setFirstPartyForCookies):
  5801. (WebCore::FrameLoader::open):
  5802. (WebCore::FrameLoader::addExtraFieldsToRequest):
  5803. (WebCore::FrameLoader::loadResourceSynchronously):
  5804. * loader/FrameLoader.h:
  5805. * loader/MainResourceLoader.cpp:
  5806. (WebCore::MainResourceLoader::willSendRequest):
  5807. (WebCore::ResourceRequestBase::adopt):
  5808. (WebCore::ResourceRequestBase::copyData):
  5809. (WebCore::ResourceRequestBase::firstPartyForCookies):
  5810. (WebCore::ResourceRequestBase::setFirstPartyForCookies):
  5811. (WebCore::equalIgnoringHeaderFields):
  5812. * platform/network/ResourceRequestBase.h:
  5813. * platform/network/cf/ResourceRequestCFNet.cpp:
  5814. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  5815. (WebCore::ResourceRequest::doUpdateResourceRequest):
  5816. * platform/network/chromium/CookieJarChromium.cpp:
  5817. (WebCore::setCookies):
  5818. * platform/network/mac/ResourceRequestMac.mm:
  5819. (WebCore::ResourceRequest::doUpdateResourceRequest):
  5820. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  5821. * platform/network/ResourceRequestBase.cpp:
  5822. (WebCore::ResourceRequestBase::firstPartyForCookies):
  5823. (WebCore::ResourceRequestBase::setFirstPartyForCookies):
  5824. * platform/network/chromium/CookieJarChromium.cpp:
  5825. (WebCore::setCookies):
  5826. * platform/network/curl/CookieJarCurl.cpp:
  5827. (WebCore::setCookies):
  5828. * platform/network/soup/CookieJarSoup.cpp:
  5829. (WebCore::setCookies):
  5830. * platform/network/win/CookieJarCFNetWin.cpp:
  5831. (WebCore::setCookies):
  5832. * platform/network/win/CookieJarWin.cpp:
  5833. (WebCore::setCookies):
  5834. * platform/qt/CookieJarQt.cpp:
  5835. (WebCore::setCookies):
  5836. 2009-05-22 Pavel Feldman <pfeldman@chromium.org>
  5837. Fix the call to editingCancelled to be this._editingCancelled, since
  5838. editingCancelled doesn't exist and throws an exception.
  5839. <https://bugs.webkit.org/show_bug.cgi?id=24881>
  5840. Reviewed by Timothy Hatcher.
  5841. * inspector/front-end/ElementsTreeOutline.js:
  5842. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  5843. 2009-05-22 Alexey Proskuryakov <ap@webkit.org>
  5844. Reviewed by Eric Seidel.
  5845. https://bugs.webkit.org/show_bug.cgi?id=25928
  5846. Several errors detected by cppcheck
  5847. Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
  5848. should take a look at other reports.
  5849. * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there
  5850. are billions of those.
  5851. 2009-05-22 Shinichiro Hamaji <hamaji@google.com>
  5852. Reviewed by Oliver Hunt.
  5853. Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
  5854. This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
  5855. https://bugs.webkit.org/show_bug.cgi?id=25956
  5856. * platform/graphics/cg/GraphicsContextCG.cpp:
  5857. (WebCore::GraphicsContext::drawRect):
  5858. (WebCore::GraphicsContext::drawLine):
  5859. (WebCore::GraphicsContext::strokeArc):
  5860. (WebCore::GraphicsContext::drawConvexPolygon):
  5861. (WebCore::GraphicsContext::fillPath):
  5862. (WebCore::GraphicsContext::strokePath):
  5863. (WebCore::GraphicsContext::fillRect):
  5864. (WebCore::GraphicsContext::fillRoundedRect):
  5865. (WebCore::GraphicsContext::strokeRect):
  5866. * platform/graphics/skia/GraphicsContextSkia.cpp:
  5867. (WebCore::GraphicsContext::drawConvexPolygon):
  5868. (WebCore::GraphicsContext::drawEllipse):
  5869. (WebCore::GraphicsContext::fillPath):
  5870. (WebCore::GraphicsContext::fillRect):
  5871. (WebCore::GraphicsContext::strokePath):
  5872. (WebCore::GraphicsContext::strokeRect):
  5873. 2009-05-22 Xan Lopez <xlopez@igalia.com>
  5874. Unreviewed build fix.
  5875. Revert the whole thing, since we can't figure out a way to make it
  5876. work in all platforms.
  5877. * rendering/SVGInlineTextBox.cpp:
  5878. (WebCore::pathForDecoration):
  5879. * svg/SVGLength.cpp:
  5880. (WebCore::SVGLength::PercentageOfViewport):
  5881. 2009-05-22 Xan Lopez <xlopez@igalia.com>
  5882. Try to fix Windows build.
  5883. Apparently it can't tell if '1.0f' is float or double, so cast to
  5884. float.
  5885. * rendering/SVGInlineTextBox.cpp:
  5886. (WebCore::pathForDecoration):
  5887. 2009-05-22 Xan Lopez <xlopez@igalia.com>
  5888. Try to fix breakage from the previous patch.
  5889. * rendering/SVGInlineTextBox.cpp:
  5890. (WebCore::pathForDecoration):
  5891. * svg/SVGLength.cpp:
  5892. (WebCore::SVGLength::PercentageOfViewport):
  5893. 2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
  5894. Reviewed by Maciej Stachowiak.
  5895. https://bugs.webkit.org/show_bug.cgi?id=25805
  5896. In debug build, mingw win32 build has problems with powf
  5897. Change C-style calls to powf and sqrtf to C++-style calls to
  5898. overloaded pow and sqrt. This solves also a problem with mingw
  5899. compiler during the debug build.
  5900. * rendering/SVGInlineTextBox.cpp:
  5901. (WebCore::pathForDecoration):
  5902. * svg/SVGLength.cpp:
  5903. (WebCore::SVGLength::PercentageOfViewport):
  5904. 2009-05-21 Stephanie Lewis <slewis@apple.com>
  5905. Reviewed by Mark Rowe.
  5906. <rdar://problem/6913680> Update image caching options.
  5907. Disable extra ImageIO cache because we already handle caching decoded image data.
  5908. * platform/graphics/cg/ImageSourceCG.cpp:
  5909. (WebCore::imageSourceOptions):
  5910. 2009-05-21 Albert J. Wong <ajwong@chromium.org>
  5911. Reviewed by Eric Seidel.
  5912. Bug 25903: Create a default UI theme for media controls in Chromium.
  5913. https://bugs.webkit.org/show_bug.cgi?id=25903
  5914. Implement a default UI for chromium. Add a style sheet for Chromium
  5915. media controls with good defaults and implemented basic draw functions
  5916. for play/pause & mute buttons.
  5917. * css/mediaControlsChromium.css: Added.
  5918. * rendering/RenderThemeChromiumLinux.cpp:
  5919. (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
  5920. our custom media controls style sheet.
  5921. (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
  5922. buttons respecting chromium media controls color scheme.
  5923. (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
  5924. specific to play/pause button.
  5925. (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
  5926. specific to mute button.
  5927. * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
  5928. * rendering/RenderThemeChromiumWin.cpp:
  5929. (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
  5930. our custom media controls style sheet.
  5931. (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
  5932. buttons respecting chromium media controls color scheme.
  5933. (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
  5934. specific to play/pause button.
  5935. (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
  5936. to mute button.
  5937. (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
  5938. header changes.
  5939. * rendering/RenderThemeChromiumWin.h:
  5940. 2009-05-21 Kevin Watters <kevinwatters@gmail.com>
  5941. Reviewed by Kevin Ollivier.
  5942. When stripping the query from a file:// URL, do not leave a trailing question mark.
  5943. https://bugs.webkit.org/show_bug.cgi?id=25940
  5944. * platform/network/curl/ResourceHandleManager.cpp:
  5945. (WebCore::ResourceHandleManager::initializeHandle):
  5946. 2009-05-21 Kevin Watters <kevinwatters@gmail.com>
  5947. Reviewed by Kevin Ollivier.
  5948. Notify ImageObserver::didDraw to help the cache purge alive resources.
  5949. https://bugs.webkit.org/show_bug.cgi?id=25942
  5950. * platform/graphics/wx/ImageWx.cpp:
  5951. (WebCore::BitmapImage::draw):
  5952. (WebCore::BitmapImage::drawPattern):
  5953. 2009-05-21 Evan Martin <evan@chromium.org>
  5954. Reviewed by Eric Seidel.
  5955. Flesh out font fallback for Chromium's Skia port.
  5956. getLastResortFallbackFont should fall back on well-known fonts.
  5957. https://bugs.webkit.org/show_bug.cgi?id=25860
  5958. * platform/graphics/chromium/FontCacheLinux.cpp:
  5959. (WebCore::FontCache::getLastResortFallbackFont): try known font names.
  5960. 2009-05-21 Dan Bernstein <mitz@apple.com>
  5961. Reviewed by John Sullivan.
  5962. - speculative fix for <rdar://problem/6890716> crash at
  5963. FontCache::purgeInactiveFontData + 199
  5964. * platform/graphics/FontCache.cpp:
  5965. (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData
  5966. can cause releaseFontData() to be called, which modifies
  5967. gInactiveFontData. Therefore, avoid deleting SimpleFontData instances
  5968. while iterating over gInactiveFontData and delete them afterwards.
  5969. 2009-05-21 Geoffrey Garen <ggaren@apple.com>
  5970. Reviewed by Sam Weinig.
  5971. Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
  5972. Incorrect URL returned to the DOM while the user drags a file
  5973. * page/DragController.cpp:
  5974. (WebCore::DragController::dragExited):
  5975. (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
  5976. since that only looks at the text of the document's URL. Do base our
  5977. decision on the securityOrigin(), which knows more about the document's
  5978. actual origin.
  5979. 2009-05-21 Dan Bernstein <mitz@apple.com>
  5980. Rubber-stamped by Mark Rowe.
  5981. - fix https://bugs.webkit.org/show_bug.cgi?id=25947
  5982. Assertion failure in FrameLoader::transitionToCommitted on launch in
  5983. Safari with r43985
  5984. Rolled out r43979.
  5985. * platform/MIMETypeRegistry.cpp:
  5986. (WebCore::initializeSupportedNonImageMimeTypes):
  5987. (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  5988. 2009-05-21 Sam Weinig <sam@webkit.org>
  5989. Reviewed by Brady Eidson and Mark Rowe.
  5990. Fix for <rdar://problem/6901522>
  5991. REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
  5992. If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
  5993. the MIME type to be text/html.
  5994. * platform/network/mac/ResourceHandleMac.mm:
  5995. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  5996. 2009-05-21 Kevin Ollivier <kevino@theolliviers.com>
  5997. Blind windows fix after last commit.
  5998. * platform/Logging.cpp:
  5999. (WebCore::getChannelFromName):
  6000. 2009-05-21 Kevin Watters <kevinwatters@gmail.com>
  6001. Reviewed by Kevin Ollivier.
  6002. Use an environment variable to control which logs are on and off.
  6003. Also, make a generic function for translating channel name to its log.
  6004. https://bugs.webkit.org/show_bug.cgi?id=25936
  6005. * platform/Logging.cpp:
  6006. (WebCore::getChannelFromName):
  6007. * platform/Logging.h:
  6008. * platform/wx/LoggingWx.cpp:
  6009. (WebCore::InitializeLoggingChannelsIfNecessary):
  6010. 2009-05-21 David Levin <levin@chromium.org>
  6011. Reviewed by Darin Fisher.
  6012. Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
  6013. https://bugs.webkit.org/show_bug.cgi?id=25946
  6014. A very simple implementation to keep it working. A bug has been filed in the chromium db
  6015. (http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
  6016. complete.
  6017. * platform/chromium/MimeTypeRegistryChromium.cpp:
  6018. (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
  6019. 2009-05-20 Siddhartha Chattopadhyaya <sidchat@google.com>
  6020. Reviewed by Justin Garcia.
  6021. Add automatic spell correction support in WebKit
  6022. https://bugs.webkit.org/show_bug.cgi?id=24953
  6023. * editing/Editor.cpp:
  6024. (WebCore::findFirstMisspellingInRange):
  6025. (WebCore::Editor::advanceToNextMisspelling):
  6026. (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  6027. (WebCore::markAllMisspellingsInRange):
  6028. (WebCore::markMisspellingsOrBadGrammar):
  6029. (WebCore::Editor::markMisspellings):
  6030. (WebCore::Editor::markBadGrammar):
  6031. (WebCore::Editor::markMisspellingsAndBadGrammar):
  6032. * editing/Editor.h:
  6033. * loader/EmptyClients.h:
  6034. (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
  6035. * page/EditorClient.h:
  6036. 2009-05-21 Christian Dywan <christian@twotoasts.de>
  6037. Reviewed by Darin Adler.
  6038. Text files which have sub MIME types are treated as not displayable
  6039. http://bugs.webkit.org/show_bug.cgi?id=24903
  6040. * platform/MIMETypeRegistry.cpp:
  6041. (WebCore::initializeSupportedNonImageMimeTypes):
  6042. (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any
  6043. MIME type beginning with "text/" as supported and remove all "text/"
  6044. types from the list.
  6045. 2009-05-21 Alexey Proskuryakov <ap@webkit.org>
  6046. Reviewed by David Kilzer.
  6047. https://bugs.webkit.org/show_bug.cgi?id=25890
  6048. Implement Network logging channel on Mac
  6049. * platform/network/mac/ResourceHandleMac.mm:
  6050. (WebCore::ResourceHandle::~ResourceHandle):
  6051. (WebCore::ResourceHandle::start):
  6052. (WebCore::ResourceHandle::cancel):
  6053. (WebCore::ResourceHandle::setDefersLoading):
  6054. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
  6055. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
  6056. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
  6057. (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
  6058. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  6059. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
  6060. (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
  6061. (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
  6062. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
  6063. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
  6064. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
  6065. Added logging for async requests (as these are most interesting).
  6066. 2009-05-21 Eric Carlson <eric.carlson@apple.com>
  6067. Reviewed by David Kilzer.
  6068. <rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
  6069. Add a static table to map from some common file extensions to their MIME types so it
  6070. is possible to detect support even when the platform mapping is incomplete. Use the
  6071. table to lookup types not found by UTI on the OSX, and when looking for a media engine
  6072. with a generic or missing type.
  6073. * platform/MIMETypeRegistry.cpp:
  6074. (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap.
  6075. (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified
  6076. MIME type in the static mapping table if the platform specific getMIMETypeForExtension
  6077. doesn't find a match.
  6078. * platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
  6079. * platform/graphics/MediaPlayer.cpp:
  6080. (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or
  6081. "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
  6082. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  6083. (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension
  6084. to MIME type if UTI fails.
  6085. 2009-05-21 Eric Seidel <eric@webkit.org>
  6086. Reviewed by Alexey Proskuryakov.
  6087. Clean up DragController
  6088. https://bugs.webkit.org/show_bug.cgi?id=25926
  6089. I renamed m_document to m_documentUnderMouse to better document what it does
  6090. I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
  6091. long enough.
  6092. I also saw copy/paste code involving clearing the selection when moving out of
  6093. one document and into another. I moved that code into a function called
  6094. mouseMovedIntoDocument.
  6095. I also got rid of a couple needless null-checks after confirming via source
  6096. inspection they were not ever possible.
  6097. In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
  6098. I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
  6099. It's also not possible to return a document from documentAtPoint that is not
  6100. in a frame (as such a document would not be rendered).
  6101. No functional changes, thus no tests.
  6102. * page/DragController.cpp:
  6103. (WebCore::DragController::DragController):
  6104. (WebCore::DragController::dragIsMove):
  6105. (WebCore::DragController::dragExited):
  6106. (WebCore::DragController::performDrag):
  6107. (WebCore::DragController::mouseMovedIntoDocument):
  6108. (WebCore::DragController::dragEnteredOrUpdated):
  6109. (WebCore::DragController::tryDocumentDrag):
  6110. (WebCore::DragController::operationForLoad):
  6111. (WebCore::DragController::concludeEditDrag):
  6112. (WebCore::DragController::canProcessDrag):
  6113. (WebCore::DragController::tryDHTMLDrag):
  6114. (WebCore::DragController::placeDragCaret):
  6115. * page/DragController.h:
  6116. (WebCore::DragController::documentUnderMouse):
  6117. 2009-05-21 Eric Seidel <eric@webkit.org>
  6118. Reviewed by Alexey Proskuryakov.
  6119. Rename DragController::dragOperation() to sourceDragOperation() for clarity
  6120. Remove unused setDragOperation()
  6121. There are two times DragOperation is used. The source specifies
  6122. what drag operations it supports (in a mask) and the destination
  6123. picks a subset of those as DragOperations it supports if a drop were
  6124. to occur. I was confused when I first saw this accessor as to which
  6125. it meant. It turns out that this is only used when WebKit starts a
  6126. drag, and we keep it around so that we can provide this information
  6127. to other Mac OS X applications when they ask. I've renamed the method
  6128. for clarity so the next person in this code will be less confused.
  6129. No functional changes, thus no tests.
  6130. * page/DragController.h:
  6131. (WebCore::DragController::sourceDragOperation):
  6132. 2009-05-21 Dan Bernstein <mitz@apple.com>
  6133. Reviewed by Anders Carlsson.
  6134. - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
  6135. crash painting the selection on registration page of car2go.com
  6136. A bug in old versions of Core Graphics causes memory corruption to occur
  6137. when clipping under certain conditions. Make the clipping functions
  6138. fail silently under those conditions.
  6139. Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
  6140. * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
  6141. * platform/graphics/cg/GraphicsContextCG.cpp:
  6142. (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
  6143. on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
  6144. (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
  6145. (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
  6146. (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
  6147. of CGContextClip, CGContextEOClip and CGContextClipToRect.
  6148. (WebCore::GraphicsContext::strokePath): Ditto.
  6149. (WebCore::GraphicsContext::fillRect): Ditto.
  6150. (WebCore::GraphicsContext::clip): Ditto.
  6151. (WebCore::GraphicsContext::clipOut): Ditto.
  6152. (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
  6153. (WebCore::GraphicsContext::clipPath): Ditto.
  6154. (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
  6155. (WebCore::GraphicsContext::strokeRect): Ditto.
  6156. * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
  6157. * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
  6158. 2009-05-21 Xan Lopez <xlopez@igalia.com>
  6159. Unreviewed build fix.
  6160. https://bugs.webkit.org/show_bug.cgi?id=25910
  6161. WebkitGTK r43960 cannot compile
  6162. Do not include local copy of guriescape header, which was
  6163. removed. We now use the copy in glib.
  6164. * platform/gtk/FileSystemGtk.cpp:
  6165. 2009-05-20 Adam Barth <abarth@webkit.org>
  6166. Reviewed by Dimitri Glazkov.
  6167. https://bugs.webkit.org/show_bug.cgi?id=25706
  6168. It turns out the CurrentContext wasn't currect either because it gave
  6169. us the frame for the write() function itself. We actually want the
  6170. *calling* context.
  6171. * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  6172. (WebCore::CALLBACK_FUNC_DECL):
  6173. 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
  6174. Reviewed by Gustavo Noronha.
  6175. [GTK] Implement Image::loadPlatformResource.
  6176. Install the four resources we are using. For the icons
  6177. where an icon name is specified by freedeskop.org try to
  6178. map the WebCore name to that name and fallback to the
  6179. internal icon. For everything else use the internal icon
  6180. name. Remove the temporary link stub as this is not
  6181. required any more.
  6182. * GNUmakefile.am: Install the png files, set DATA_DIR again
  6183. * Resources/panIcon.png: Copied from WebKit/win/WebKit.vcproj/panIcon.png.
  6184. * platform/graphics/gtk/ImageGtk.cpp:
  6185. (WTF::GtkIconInfo): Add template specialization for GtkIconInfo
  6186. (WebCore::getIconFileNameOrFallback): Use GtkIconTheme to get the icon
  6187. (WebCore::loadResourceIntoSharedBuffer):
  6188. (WebCore::Image::loadPlatformResource): Implement
  6189. * platform/gtk/TemporaryLinkStubs.cpp: Remove link stub
  6190. 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
  6191. Reviewed by Gustavo Noronha.
  6192. https://bugs.webkit.org/show_bug.cgi?id=19357
  6193. [GTK] The Gtk+ port wants to have a themable
  6194. urlIcon too.
  6195. * loader/icon/IconDatabase.cpp:
  6196. 2009-05-20 Stephanie Lewis <slewis@apple.com>
  6197. Update the order files. <rdar://problem/6881750> Generate new order files.
  6198. * WebCore.order:
  6199. 2009-05-20 Mark Rowe <mrowe@apple.com>
  6200. Reviewed by Gavin Barraclough.
  6201. Fix some assertion failures in plug-in tests on the Windows debug build bot.
  6202. * plugins/PluginStream.cpp:
  6203. (WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
  6204. * plugins/PluginView.cpp:
  6205. (WebCore::scriptStringIfJavaScriptURL): Ditto.
  6206. 2009-05-20 Brady Eidson <beidson@apple.com>
  6207. Reviewed by Darin Adler.
  6208. More protocolInHTTPFamily() cleanup.
  6209. * xml/XMLHttpRequest.cpp:
  6210. (WebCore::XMLHttpRequest::send):
  6211. 2009-05-20 Sam Weinig <sam@webkit.org>
  6212. Reviewed by Oliver Hunt.
  6213. Fix for <rdar://problem/6905475>
  6214. Office 2008: Entourage: Crash when you switch to "My Day" view
  6215. The host function callback callObjCFallbackObject was not annotated
  6216. with JSC_HOST_CALL which meant that when it was called by the JIT, which
  6217. expects the JSC_HOST_CALL calling convention, the arguments are not in the
  6218. expected places.
  6219. * bridge/objc/objc_runtime.mm:
  6220. (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL
  6221. annotation on callObjCFallbackObject.
  6222. 2009-05-20 David Levin <levin@chromium.org>
  6223. Not Reviewed, build fix.
  6224. Need to disable this assert while the chormium code is fixed for it.
  6225. * platform/KURLGoogle.cpp:
  6226. (WebCore::KURL::protocolIs):
  6227. 2009-05-20 David Levin <levin@chromium.org>
  6228. Not Reviewed, build fix.
  6229. Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
  6230. http://trac.webkit.org/changeset/43929. Fix assert placement.
  6231. * platform/KURLGoogle.cpp:
  6232. (WebCore::KURL::protocolIs):
  6233. (WebCore::protocolIs):
  6234. 2009-05-20 Nate Chapin <japhet@google.com>
  6235. Reviewed by Dimitri Glazkov.
  6236. Upstream V8 bindings for V8DomWindow.
  6237. https://bugs.webkit.org/show_bug.cgi?id=25869
  6238. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  6239. (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp.
  6240. (WebCore::isAscii): Moved from v8_custom.cpp.
  6241. (WebCore::convertBase64): Moved from v8_custom.cpp.
  6242. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
  6243. (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp.
  6244. (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp.
  6245. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp.
  6246. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp.
  6247. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
  6248. 2009-05-21 Christian Dywan <christian@twotoasts.de>
  6249. Reviewed by Jan Alonzo.
  6250. * platform/network/soup/ResourceHandleSoup.cpp:
  6251. (WebCore::parseDataUrl): Always use Glib Base64 decoding.
  6252. 2009-05-21 Christian Dywan <christian@twotoasts.de>
  6253. Rubberstamped by Gustavo Noronha.
  6254. * platform/network/curl/ResourceHandleManager.cpp:
  6255. (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
  6256. 2009-05-20 Christian Dywan <christian@twotoasts.de>
  6257. Reviewed by Gustavo Noronha.
  6258. * GNUmakefile.am:
  6259. * platform/gtk/guriescape.c:
  6260. * platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and
  6261. g_uri_unescape_string now that we require Glib 2.16.
  6262. 2009-05-20 David Levin <levin@chromium.org>
  6263. Not Reviewed, build fix.
  6264. Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
  6265. http://trac.webkit.org/changeset/43929.
  6266. * platform/KURLGoogle.cpp:
  6267. (WebCore::protocolIsJavaScript):
  6268. (WebCore::protocolIs):
  6269. 2009-05-20 Brady Eidson <beidson@apple.com>
  6270. Rubberstamped by Sam Weinig
  6271. At all call sites that check if a KURL has either the http or https protocol,
  6272. use the KURL::protocolInHTTPFamily() accessor, instead.
  6273. * loader/FrameLoader.cpp:
  6274. (WebCore::FrameLoader::iconURL):
  6275. (WebCore::FrameLoader::didOpenURL):
  6276. (WebCore::FrameLoader::open):
  6277. * loader/appcache/ApplicationCache.cpp:
  6278. (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
  6279. * loader/loader.cpp:
  6280. (WebCore::Loader::load):
  6281. * xml/XMLHttpRequest.cpp:
  6282. (WebCore::XMLHttpRequest::send):
  6283. 2009-05-20 Brady Eidson <beidson@apple.com>
  6284. Reviewed by Darin Adler.
  6285. Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
  6286. KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
  6287. "javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
  6288. invalid, you can no longer ask it a question such as "is your protocol javascript?"
  6289. Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
  6290. navigate to them.
  6291. URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
  6292. being a high profile example) and actually represent valid javascript.
  6293. Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
  6294. as it functions on a String which doesn't have to pass KURLs parsing rules.
  6295. Test: fast/loader/javascript-url-hierarchical-execution.html
  6296. * bindings/js/JSAttrCustom.cpp:
  6297. (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
  6298. * bindings/js/JSDOMWindowCustom.cpp:
  6299. (WebCore::JSDOMWindow::setLocation): Ditto.
  6300. (WebCore::createWindow): Ditto.
  6301. (WebCore::JSDOMWindow::open): Ditto.
  6302. * bindings/js/JSElementCustom.cpp:
  6303. (WebCore::allowSettingSrcToJavascriptURL): Ditto.
  6304. * bindings/js/JSHTMLFrameElementCustom.cpp:
  6305. (WebCore::allowSettingJavascriptURL): Ditto.
  6306. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  6307. (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
  6308. * bindings/js/JSLocationCustom.cpp:
  6309. (WebCore::navigateIfAllowed): Ditto.
  6310. (WebCore::JSLocation::reload): Ditto.
  6311. * editing/markup.cpp:
  6312. (WebCore::appendQuotedURLAttributeValue): Ditto.
  6313. * html/HTMLAnchorElement.cpp:
  6314. (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
  6315. * loader/FrameLoader.cpp:
  6316. (WebCore::FrameLoader::requestFrame): Ditto.
  6317. (WebCore::FrameLoader::submitForm): Ditto.
  6318. (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
  6319. * platform/KURL.cpp:
  6320. (WebCore::KURL::init): Use protocolIsJavaScript().
  6321. (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
  6322. Such checks should go through protocolIsJavaScript() instead.
  6323. (WebCore::encodeRelativeString): Use protocolIsJavaScript().
  6324. (WebCore::protocolIsJavaScript):
  6325. * platform/KURL.h:
  6326. 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
  6327. Reviewed by Anders Carlsson.
  6328. https://bugs.webkit.org/show_bug.cgi?id=24510
  6329. Fix a bug where the browserfuncs were not properly assigned,
  6330. make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
  6331. Test: plugins/netscape-invoke-browserfuncs.html
  6332. * plugins/gtk/PluginPackageGtk.cpp:
  6333. (WebCore::PluginPackage::load): Fix assignment
  6334. * plugins/qt/PluginPackageQt.cpp:
  6335. (WebCore::PluginPackage::load): Fix assignment
  6336. 2009-05-20 Sam Weinig <sam@webkit.org>
  6337. Reviewed by Timothy Hatcher.
  6338. Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
  6339. and only exist on RenderText.
  6340. * dom/Range.cpp:
  6341. (WebCore::Range::textRects):
  6342. * inspector/InspectorController.cpp:
  6343. (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead
  6344. of absoluteQuadsForRange since no range is being specifiec.
  6345. * rendering/RenderObject.cpp:
  6346. * rendering/RenderObject.h:
  6347. * rendering/RenderText.h:
  6348. 2009-05-20 Xan Lopez <xlopez@igalia.com>
  6349. Reviewed by Gustavo Noronha.
  6350. Implement AtkObject::focus-event and
  6351. AtkObject::state-changed:focused signal emission.
  6352. Adds a new handleFocusedUIElementChangedWithRenderers, only in the
  6353. GTK port, called at the same point than
  6354. handleFocusedUIElementChanged but with two parameters, the old and
  6355. the newly focused RenderObjects. We need this, since the ATK
  6356. signals require us to pass the objects involved in the focus
  6357. change as arguments.
  6358. * accessibility/AXObjectCache.h:
  6359. * accessibility/gtk/AXObjectCacheAtk.cpp:
  6360. (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
  6361. * dom/Document.cpp:
  6362. (WebCore::Document::setFocusedNode):
  6363. 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
  6364. Reviewed by Darin Adler.
  6365. https://bugs.webkit.org/show_bug.cgi?id=25834
  6366. Make ChromeClient a interface again
  6367. With recent additions to ChromeClient.h empty defaults were
  6368. added. This is bad for porters as these changes go unnoticed
  6369. and at runtime no notImplemented warning is logged and grepping
  6370. for notImplemented will not show anything. Change this Client
  6371. to be like the other Clients again and always have pure virtuals
  6372. (but for stuff inside #ifdef PLATFORM(MAC)).
  6373. Update the various WebKit/* implementations to compile again.
  6374. * loader/EmptyClients.h: Add empty defaults
  6375. (WebCore::EmptyChromeClient::setCursor):
  6376. (WebCore::EmptyChromeClient::scrollRectIntoView):
  6377. (WebCore::EmptyChromeClient::requestGeolocationPermissionForFrame):
  6378. * page/ChromeClient.h: Make methods pure virtual
  6379. 2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  6380. Reviewed by Simon Hausmann.
  6381. Fix a bug where a non visible plugin would show it self in a
  6382. sibling frame. The problem was due to our clipping. In Qt,
  6383. if setMask is set with an empty QRegion, no clipping will
  6384. be performed, so in that case we hide the PluginContainer
  6385. Added manual test.
  6386. * plugins/qt/PluginContainerQt.cpp:
  6387. (PluginContainerQt::adjustGeometry):
  6388. * manual-tests/qt/plugin-sibling-frame-include.html
  6389. * manual-tests/qt/plugin-sibling-frame.html
  6390. 2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  6391. Reviewed by Simon Hausmann.
  6392. Do not call the parent implementation (Widget::) in show() and hide()
  6393. of the PluginViewQt, as it always changes the visible state of the
  6394. platformWidget (equal to the platformPluginWidget in the Qt port),
  6395. thus ignoring the isParentVisible() test.
  6396. * plugins/qt/PluginViewQt.cpp:
  6397. (WebCore::PluginView::show):
  6398. (WebCore::PluginView::hide):
  6399. 2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>
  6400. Reviewed by George Staikos.
  6401. https://bugs.webkit.org/show_bug.cgi?id=23452
  6402. Change the implementation of HTMLNoScriptElement to avoid the pain of
  6403. adding virtual function for XHTMLMP support
  6404. Includes changes suggested by Simon Fraser.
  6405. * dom/Node.cpp:
  6406. (WebCore::Node::styleForRenderer):
  6407. * dom/Node.h:
  6408. * html/HTMLNoScriptElement.cpp:
  6409. * html/HTMLNoScriptElement.h:
  6410. 2009-05-20 Kevin Ollivier <kevino@theolliviers.com>
  6411. CURL backend build fix. Make sure URL is always set.
  6412. * platform/network/curl/ResourceHandleManager.cpp:
  6413. (WebCore::ResourceHandleManager::downloadTimerCallback):
  6414. 2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
  6415. Reviewed by George Staikos.
  6416. Fix Qt WebKit build break in Mac OS.
  6417. * platform/FileSystem.h:
  6418. 2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  6419. Rubber-stamped by Eric Seidel.
  6420. Enable code that was commented out waiting for a way to get a
  6421. GdkPixbuf from an image, effectively enabling copying images to
  6422. the clipboard.
  6423. * platform/gtk/PasteboardGtk.cpp:
  6424. (WebCore::Pasteboard::writeImage):
  6425. 2009-05-20 Xan Lopez <xlopez@igalia.com>
  6426. Reviewed by Jan Alonzo.
  6427. https://bugs.webkit.org/show_bug.cgi?id=25414
  6428. [GTK] ROLE_PANEL should not be used for paragraphs and list items.
  6429. Implement Atk list item role for list items.
  6430. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  6431. (webkit_accessible_get_role):
  6432. 2009-05-20 Xan Lopez <xlopez@igalia.com>
  6433. Reviewed by Jan Alonzo.
  6434. https://bugs.webkit.org/show_bug.cgi?id=25414
  6435. [GTK] ROLE_PANEL should not be used for paragraphs and list items.
  6436. Implement Atk paragraph role for paragraph elements.
  6437. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  6438. (webkit_accessible_get_role):
  6439. 2009-05-20 Eric Seidel <eric@webkit.org>
  6440. Fix bug URL in ChangeLogs in r43903.
  6441. https://bugs.webkit.org/show_bug.cgi?id=25742
  6442. 2009-05-20 Takeshi Yoshino <tyoshino@google.com>
  6443. Reviewed by Eric Seidel.
  6444. Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
  6445. https://bugs.webkit.org/show_bug.cgi?id=25742
  6446. Fix RenderThemeChromiumWin::paintTextFieldInternal().
  6447. We shouldn't paint the content area of text fields when o->style() has
  6448. background image or transparent background color. paintTextFieldInternal() is
  6449. used for painting inner area of HTML option elements by Chromium.
  6450. When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
  6451. the background image rendered by RenderBoxModelObject. So, we should set
  6452. fillContentArea = false in such case.
  6453. Besides, when background-color:transparent is specified for CSS property,
  6454. o->style().backgroundColor returns black color with alpha channel == 0. But
  6455. since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
  6456. recognize alpha channel, it fills the rect with black. I made workaround to set
  6457. fillContentArea = false when alpha channel == 0 to avoid this.
  6458. And more, I'd like to fallback the color passed to ChromiumBridge to white when
  6459. o->style()->backgroundColor() is invalid.
  6460. * rendering/RenderThemeChromiumWin.cpp:
  6461. (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  6462. 2009-05-20 Shinichiro Hamaji <hamaji@google.com>
  6463. Reviewed by Eric Seidel.
  6464. https://bugs.webkit.org/show_bug.cgi?id=25417
  6465. Map CompositeCopy to Skia's kSrc_Mode composite operation.
  6466. Test: fast/canvas/canvas-composite-alpha.html
  6467. * platform/graphics/skia/SkiaUtils.cpp:
  6468. (WebCore::):
  6469. 2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
  6470. Rubber-stamped by Xan Lopez.
  6471. Remove misplaced extern "C"
  6472. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  6473. 2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
  6474. Reviewed by Xan Lopez.
  6475. [GTK] Expose password field with role of PASSWORD_TEXT
  6476. https://bugs.webkit.org/show_bug.cgi?id=25682
  6477. Check if input type is a password field and return
  6478. ATK_ROLE_PASSWORD_TEXT if it is.
  6479. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  6480. 2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  6481. Reviewed by George Staikos.
  6482. BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
  6483. <https://bugs.webkit.org/show_bug.cgi?id=25845>
  6484. * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
  6485. 2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  6486. Reviewed by George Staikos.
  6487. BUG 25843: [Qt] Remove qt-port build flag
  6488. <https://bugs.webkit.org/show_bug.cgi?id=25843>
  6489. * bridge/testbindings.pro:
  6490. 2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  6491. Reviewed by George Staikos.
  6492. https://bugs.webkit.org/show_bug.cgi?id=25824
  6493. [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
  6494. and WORKERS under the appropriate build section
  6495. * WebCore.pro:
  6496. 2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
  6497. Unreviewed Qt build fix, after r43892.
  6498. * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
  6499. 2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
  6500. Reviewed by Simon Hausmann.
  6501. https://bugs.webkit.org/show_bug.cgi?id=25856
  6502. [Qt] notify an image has been drawn, to help Cache purge alive decoded data.
  6503. * platform/graphics/qt/ImageQt.cpp:
  6504. (WebCore::Image::drawPattern):
  6505. (WebCore::BitmapImage::draw):
  6506. 2009-05-20 David Levin <levin@chromium.org>
  6507. Reviewed by NOBODY, layout tests fix.
  6508. https://bugs.webkit.org/show_bug.cgi?id=23727
  6509. This reverts commit r43888.
  6510. Once that change was checked in many of the fast/flexbox0*.html
  6511. tests (and others) started failing.
  6512. * WebCore.pro:
  6513. * css/CSSParser.cpp:
  6514. (WebCore::CSSParser::parseValue):
  6515. * css/CSSPropertyNames.in:
  6516. * css/CSSStyleSelector.cpp:
  6517. (WebCore::CSSStyleSelector::applyProperty):
  6518. * css/CSSValueKeywords.in:
  6519. * rendering/RenderMarquee.cpp:
  6520. (WebCore::RenderMarquee::updateMarqueePosition):
  6521. (WebCore::RenderMarquee::timerFired):
  6522. 2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
  6523. Reviewed by George Staikos.
  6524. Add XHTMLMP support to Webkit
  6525. Update the configure files for building XHTMLMP-enabled WebKit on different platform
  6526. https://bugs.webkit.org/show_bug.cgi?id=23452
  6527. * GNUmakefile.am:
  6528. * WebCore.pro:
  6529. * WebCore.vcproj/WebCore.vcproj:
  6530. * WebCoreSources.bkl:
  6531. 2009-05-19 Antti Koivisto <antti@apple.com>
  6532. I can't figure out how to make this not timing dependent, making it manual test instead.
  6533. * manual-tests/preload-scanner-entities.html: Added.
  6534. 2009-05-19 Brady Eidson <beidson@apple.com>
  6535. Reviewed by Antti Koivisto.
  6536. <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
  6537. This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
  6538. in QuickLooks (rdar://problem/6619630).
  6539. We need to respect the DocumentLoader's request cache policy when deciding the cache policy
  6540. for subresources, but the check (originally removed in r39304 and added back in in the same
  6541. place in r41424) needs to be tweaked and relocated a bit.
  6542. * loader/FrameLoader.cpp:
  6543. (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy(). Move checking
  6544. the DocumentLoader's request to a more appropriate place. Add code to handle the recently
  6545. added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code
  6546. cleaner in the future.
  6547. * loader/FrameLoader.h:
  6548. * loader/DocLoader.cpp:
  6549. (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
  6550. 2009-05-19 Chris Fleizach <cfleizach@apple.com>
  6551. Reviewed by Beth Dakin.
  6552. Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
  6553. https://bugs.webkit.org/show_bug.cgi?id=25872
  6554. When setting the aria-labeledby text it should stay within the element identified by the id
  6555. when searching through the sibling list.
  6556. This also removes an outdated assert in getDocumentLinks. Its possible for the document to
  6557. think an element is a link, but accessibility can treat it differently (eg. its ARIA role is different).
  6558. Test: accessibility/aria-labelledby-stay-within.html
  6559. * accessibility/AccessibilityRenderObject.cpp:
  6560. (WebCore::AccessibilityRenderObject::ariaAccessiblityName):
  6561. (WebCore::AccessibilityRenderObject::getDocumentLinks):
  6562. 2009-05-19 Antti Koivisto <antti@apple.com>
  6563. Reviewed by Darin Adler).
  6564. <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
  6565. Push characters back in correct order when entity parsing fails after 3 characters.
  6566. Test: fast/tokenizer/preload-scanner-entities.html
  6567. * html/PreloadScanner.cpp:
  6568. (WebCore::PreloadScanner::consumeEntity):
  6569. 2009-05-19 Paul Godavari <paul@chromium.org>
  6570. Reviewed by Dimitri Glazkov.
  6571. Fix a crash in Mac Chromium when displaying an HTML select element
  6572. with no items.
  6573. https://bugs.webkit.org/show_bug.cgi?id=25874
  6574. * platform/chromium/PopupMenuChromium.cpp:
  6575. (WebCore::PopupContainer::showExternal):
  6576. 2009-05-19 Nate Chapin <japhet@google.com>
  6577. Reviewed by Darin Fisher.
  6578. Upstream V8 bindings for CanvasRenderingContext2D.
  6579. https://bugs.webkit.org/show_bug.cgi?id=25858
  6580. * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
  6581. 2009-05-19 Jessie Berlin <jberlin@apple.com>
  6582. Reviewed by Mark Rowe.
  6583. Windows Build Fix.
  6584. * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
  6585. 2009-05-19 Timothy Hatcher <timothy@apple.com>
  6586. <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
  6587. loaded because willSendRequest doesn't happen immediately
  6588. Reviewed by Antti Koivisto.
  6589. * WebCore.base.exp: Export Loader::servePendingRequests().
  6590. 2009-05-19 David Levin <levin@chromium.org>
  6591. Reviewed by Dimitri Glazkov.
  6592. Bug 25859: Need to upstream ScriptController.* for v8.
  6593. https://bugs.webkit.org/show_bug.cgi?id=25859
  6594. Fixing the header file (which I accidentally made identical to the cpp file).
  6595. * bindings/v8/ScriptController.h:
  6596. 2009-05-19 Alexey Proskuryakov <ap@webkit.org>
  6597. Reviewed by Darin Adler and Brady Eidson.
  6598. <rdar://problem/6900582> REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
  6599. The problem was that Document::removeAllEventListeners() was called for a wrong document
  6600. when a CachedFrame was destroyed.
  6601. Cannot be tested automatically, because DRT doesn't have a b/f cache.
  6602. * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
  6603. unrelated window even if document's m_frame pointer is stale.
  6604. * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
  6605. 2009-05-19 Pavel Feldman <pfeldman@chromium.org>
  6606. Reviewed by Timothy Hatcher.
  6607. Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
  6608. https://bugs.webkit.org/show_bug.cgi?id=25419
  6609. * GNUmakefile.am:
  6610. * WebCore.pro:
  6611. * WebCore.vcproj/WebCore.vcproj:
  6612. * WebCore.xcodeproj/project.pbxproj:
  6613. * WebCoreSources.bkl:
  6614. * inspector/ConsoleMessage.cpp:
  6615. (WebCore::ConsoleMessage::addToConsole):
  6616. * inspector/ConsoleMessage.h:
  6617. * inspector/InspectorController.cpp:
  6618. (WebCore::InspectorController::~InspectorController):
  6619. (WebCore::InspectorController::inspect):
  6620. (WebCore::InspectorController::focusNode):
  6621. (WebCore::InspectorController::setWindowVisible):
  6622. (WebCore::InspectorController::addConsoleMessage):
  6623. (WebCore::InspectorController::setAttachedWindow):
  6624. (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
  6625. (WebCore::InspectorController::scriptObjectReady):
  6626. (WebCore::InspectorController::showPanel):
  6627. (WebCore::InspectorController::close):
  6628. (WebCore::InspectorController::populateScriptObjects):
  6629. (WebCore::InspectorController::resetScriptObjects):
  6630. (WebCore::InspectorController::pruneResources):
  6631. (WebCore::InspectorController::didCommitLoad):
  6632. (WebCore::InspectorController::didLoadResourceFromMemoryCache):
  6633. (WebCore::InspectorController::identifierForInitialRequest):
  6634. (WebCore::InspectorController::willSendRequest):
  6635. (WebCore::InspectorController::didReceiveResponse):
  6636. (WebCore::InspectorController::didReceiveContentLength):
  6637. (WebCore::InspectorController::didFinishLoading):
  6638. (WebCore::InspectorController::didFailLoading):
  6639. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  6640. (WebCore::InspectorController::scriptImported):
  6641. (WebCore::InspectorController::didOpenDatabase):
  6642. (WebCore::InspectorController::didUseDOMStorage):
  6643. (WebCore::InspectorController::addScriptProfile):
  6644. (WebCore::InspectorController::toggleRecordButton):
  6645. (WebCore::InspectorController::enableProfiler):
  6646. (WebCore::InspectorController::disableProfiler):
  6647. (WebCore::InspectorController::enableDebugger):
  6648. (WebCore::InspectorController::disableDebugger):
  6649. (WebCore::InspectorController::didParseSource):
  6650. (WebCore::InspectorController::failedToParseSource):
  6651. (WebCore::InspectorController::didPause):
  6652. (WebCore::InspectorController::didContinue):
  6653. * inspector/InspectorController.h:
  6654. * inspector/InspectorDOMStorageResource.cpp:
  6655. (WebCore::InspectorDOMStorageResource::bind):
  6656. * inspector/InspectorDOMStorageResource.h:
  6657. * inspector/InspectorDatabaseResource.cpp:
  6658. (WebCore::InspectorDatabaseResource::bind):
  6659. * inspector/InspectorDatabaseResource.h:
  6660. * inspector/InspectorFrontend.cpp: Added.
  6661. (WebCore::callSimpleFunction):
  6662. (WebCore::InspectorFrontend::InspectorFrontend):
  6663. (WebCore::InspectorFrontend::~InspectorFrontend):
  6664. (WebCore::InspectorFrontend::newJSONObject):
  6665. (WebCore::InspectorFrontend::addMessageToConsole):
  6666. (WebCore::InspectorFrontend::addResource):
  6667. (WebCore::InspectorFrontend::updateResource):
  6668. (WebCore::InspectorFrontend::removeResource):
  6669. (WebCore::InspectorFrontend::updateFocusedNode):
  6670. (WebCore::InspectorFrontend::setAttachedWindow):
  6671. (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
  6672. (WebCore::InspectorFrontend::showPanel):
  6673. (WebCore::InspectorFrontend::populateInterface):
  6674. (WebCore::InspectorFrontend::reset):
  6675. (WebCore::InspectorFrontend::debuggerWasEnabled):
  6676. (WebCore::InspectorFrontend::debuggerWasDisabled):
  6677. (WebCore::InspectorFrontend::profilerWasEnabled):
  6678. (WebCore::InspectorFrontend::profilerWasDisabled):
  6679. (WebCore::InspectorFrontend::parsedScriptSource):
  6680. (WebCore::InspectorFrontend::failedToParseScriptSource):
  6681. (WebCore::InspectorFrontend::addProfile):
  6682. (WebCore::InspectorFrontend::setRecordingProfile):
  6683. (WebCore::InspectorFrontend::pausedScript):
  6684. (WebCore::InspectorFrontend::resumedScript):
  6685. (WebCore::InspectorFrontend::addDatabase):
  6686. (WebCore::InspectorFrontend::addDOMStorage):
  6687. * inspector/InspectorFrontend.h: Added.
  6688. * inspector/InspectorResource.cpp:
  6689. (WebCore::InspectorResource::createScriptObject):
  6690. (WebCore::InspectorResource::updateScriptObject):
  6691. (WebCore::InspectorResource::releaseScriptObject):
  6692. * inspector/InspectorResource.h:
  6693. 2009-05-19 Pavel Feldman <pfeldman@chromium.org>
  6694. Reviewed by Timothy Hatcher.
  6695. Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
  6696. https://bugs.webkit.org/show_bug.cgi?id=25419
  6697. * GNUmakefile.am:
  6698. * WebCore.pro:
  6699. * WebCore.vcproj/WebCore.vcproj:
  6700. * WebCore.xcodeproj/project.pbxproj:
  6701. * WebCoreSources.bkl:
  6702. * inspector/ConsoleMessage.cpp:
  6703. (WebCore::ConsoleMessage::addToConsole):
  6704. * inspector/InspectorDOMStorageResource.cpp:
  6705. (WebCore::InspectorDOMStorageResource::bind):
  6706. * inspector/InspectorDatabaseResource.cpp:
  6707. (WebCore::InspectorDatabaseResource::bind):
  6708. * inspector/InspectorResource.cpp:
  6709. (WebCore::populateHeadersObject):
  6710. (WebCore::InspectorResource::createScriptObject):
  6711. (WebCore::InspectorResource::updateScriptObject):
  6712. * inspector/JSONObject.cpp: Added.
  6713. (WebCore::JSONObject::JSONObject):
  6714. (WebCore::JSONObject::set):
  6715. (WebCore::JSONObject::scriptObject):
  6716. (WebCore::JSONObject::createNew):
  6717. * inspector/JSONObject.h: Added.
  6718. 2009-05-19 Pavel Feldman <pfeldman@chromium.org>
  6719. Reviewed by Timothy Hatcher.
  6720. Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
  6721. https://bugs.webkit.org/show_bug.cgi?id=25419
  6722. * inspector/ConsoleMessage.cpp:
  6723. (WebCore::ConsoleMessage::addToConsole):
  6724. * inspector/InspectorController.cpp:
  6725. (WebCore::InspectorController::didReceiveResponse):
  6726. (WebCore::InspectorController::didReceiveContentLength):
  6727. (WebCore::InspectorController::didFinishLoading):
  6728. (WebCore::InspectorController::didFailLoading):
  6729. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  6730. (WebCore::InspectorController::scriptImported):
  6731. * inspector/InspectorDOMStorageResource.cpp:
  6732. (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
  6733. (WebCore::InspectorDOMStorageResource::bind):
  6734. (WebCore::InspectorDOMStorageResource::unbind):
  6735. * inspector/InspectorDOMStorageResource.h:
  6736. * inspector/InspectorDatabaseResource.cpp:
  6737. (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
  6738. (WebCore::InspectorDatabaseResource::bind):
  6739. (WebCore::InspectorDatabaseResource::unbind):
  6740. * inspector/InspectorDatabaseResource.h:
  6741. * inspector/InspectorResource.cpp:
  6742. (WebCore::InspectorResource::InspectorResource):
  6743. (WebCore::populateHeadersObject):
  6744. (WebCore::InspectorResource::createScriptObject):
  6745. (WebCore::InspectorResource::updateScriptObject):
  6746. (WebCore::InspectorResource::releaseScriptObject):
  6747. * inspector/InspectorResource.h:
  6748. * inspector/front-end/Console.js:
  6749. (WebInspector.ConsoleMessage):
  6750. * inspector/front-end/inspector.js:
  6751. (WebInspector.addResource):
  6752. (WebInspector.updateResource):
  6753. (WebInspector.removeResource):
  6754. (WebInspector.addDatabase):
  6755. (WebInspector.addDOMStorage):
  6756. (WebInspector.reset):
  6757. (WebInspector.addMessageToConsole):
  6758. 2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  6759. Reviewed by Ariya Hidayat.
  6760. The Qt port has code that disables scrolling optimizations
  6761. when the root contains native windows, such as windowed plugins.
  6762. This code broke when detaching iframes containing windowed
  6763. plugins.
  6764. Each ScrollView now knows how many native windows it and its
  6765. children contain, and when it is detached, that number is
  6766. substracted from its old parents.
  6767. * platform/ScrollView.cpp:
  6768. (WebCore::ScrollView::scrollContents):
  6769. (WebCore::ScrollView::setParent):
  6770. * platform/ScrollView.h:
  6771. * platform/qt/ScrollViewQt.cpp:
  6772. (WebCore::ScrollView::adjustWidgetsPreventingBlittingCount):
  6773. (WebCore::ScrollView::platformAddChild):
  6774. (WebCore::ScrollView::platformRemoveChild):
  6775. 2009-05-18 David Kilzer <ddkilzer@apple.com>
  6776. Tiger build fix for r43850
  6777. * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
  6778. when building on Tiger.
  6779. 2009-05-18 Eric Seidel <eric@webkit.org>
  6780. Reviewed by Darin Adler.
  6781. ClipboardMac cleanup
  6782. https://bugs.webkit.org/show_bug.cgi?id=25847
  6783. I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
  6784. No functional changes, so no tests.
  6785. * platform/mac/ClipboardMac.mm:
  6786. (WebCore::ClipboardMac::clearData):
  6787. (WebCore::absoluteURLsFromPasteboardFilenames):
  6788. Broke out logic for filenames into its own function to make the caller more readable.
  6789. (WebCore::absoluteURLsFromPasteboard):
  6790. Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
  6791. so that we can use -[NSArray componentsJoinedByString] in the caller (which is
  6792. cleaner than the manual "\n" addition before).
  6793. This also access to the full list of file urls for future callers.
  6794. (WebCore::ClipboardMac::getData):
  6795. unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
  6796. explicit check for "URL", before it was a check for != "text/uri-list" which
  6797. was much more confusing in my opinion. text/uri-list and URL are the only
  6798. two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
  6799. (WebCore::ClipboardMac::types):
  6800. I removed an extra if (!types) check, right before [types count]. In Obj-C
  6801. messaging nil will return 0 (size of a pointer), so it's safe to message nil
  6802. here and expect it to return 0.
  6803. 2009-05-18 David Levin <levin@chromium.org>
  6804. Reviewed by Darin Fisher.
  6805. Bug 25859: Need to upstream ScriptController.* for v8.
  6806. https://bugs.webkit.org/show_bug.cgi?id=25859
  6807. * bindings/v8/ScriptController.cpp: Added.
  6808. * bindings/v8/ScriptController.h: Added.
  6809. 2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
  6810. Reviewed by George Staikos.
  6811. Change ScriptElement to support XHTMLMP in a better way
  6812. https://bugs.webkit.org/show_bug.cgi?id=23452
  6813. * dom/ScriptElement.h:
  6814. * html/HTMLScriptElement.h:
  6815. * svg/SVGScriptElement.h:
  6816. (WebCore::SVGScriptElement::shouldExecuteAsJavaScript):
  6817. 2009-05-18 Kevin Ollivier <kevino@theolliviers.com>
  6818. wx build fix, finish up changes after the accessibility dir split.
  6819. * webcore-base.bkl:
  6820. 2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
  6821. Reviewed by George Staikos (and others).
  6822. Add XHTMLMP support to Webkit
  6823. https://bugs.webkit.org/show_bug.cgi?id=23452
  6824. XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
  6825. functionality. Most of the functionalities have already been implemented by Webkit.
  6826. The changes include:
  6827. 1) Adding <noscript> support
  6828. 2) Document conformance validation
  6829. 3) User Agent conformance validation
  6830. refer to the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf
  6831. Tests: fast/xhtmlmp/check-doctype-declaration.xhtml
  6832. fast/xhtmlmp/check-rootelement.xhtml
  6833. fast/xhtmlmp/noscript-in-multiscripts.xhtml
  6834. fast/xhtmlmp/noscript-nested.xhtml
  6835. fast/xhtmlmp/noscript.xhtml
  6836. * dom/DOMImplementation.cpp:
  6837. (WebCore::DOMImplementation::createDocument):
  6838. * dom/Document.cpp:
  6839. (WebCore::Document::Document):
  6840. (WebCore::Document::isXHTMLMPDocument):
  6841. * dom/Document.h:
  6842. (WebCore::Document::shouldProcessNoscriptElement):
  6843. (WebCore::Document::setShouldProcessNoscriptElement):
  6844. * dom/Node.cpp:
  6845. (WebCore::Node::createRendererIfNeeded):
  6846. * dom/Node.h:
  6847. * dom/XMLTokenizer.h:
  6848. (WebCore::XMLTokenizer::setIsXHTMLMPDocument):
  6849. (WebCore::XMLTokenizer::isXHTMLMPDocument):
  6850. * dom/XMLTokenizerLibxml2.cpp:
  6851. (WebCore::XMLTokenizer::XMLTokenizer):
  6852. (WebCore::XMLTokenizer::startElementNs):
  6853. (WebCore::XMLTokenizer::endElementNs):
  6854. (WebCore::XMLTokenizer::endDocument):
  6855. (WebCore::XMLTokenizer::internalSubset):
  6856. (WebCore::getEntityHandler):
  6857. (WebCore::externalSubsetHandler):
  6858. * dom/XMLTokenizerQt.cpp:
  6859. (WebCore::XMLTokenizer::XMLTokenizer):
  6860. (WebCore::XMLTokenizer::parse):
  6861. (WebCore::XMLTokenizer::parseStartElement):
  6862. (WebCore::XMLTokenizer::parseEndElement):
  6863. (WebCore::):
  6864. * dom/make_names.pl:
  6865. * html/HTMLElement.cpp:
  6866. (WebCore::HTMLElement::rendererIsNeeded):
  6867. * html/HTMLNoScriptElement.cpp: Added.
  6868. (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
  6869. (WebCore::HTMLNoScriptElement::~HTMLNoScriptElement):
  6870. (WebCore::HTMLNoScriptElement::checkDTD):
  6871. (WebCore::HTMLNoScriptElement::attach):
  6872. (WebCore::HTMLNoScriptElement::recalcStyle):
  6873. (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
  6874. (WebCore::HTMLNoScriptElement::styleForRenderer):
  6875. * html/HTMLNoScriptElement.h: Added.
  6876. (WebCore::HTMLNoScriptElement::rendererIsNeeded):
  6877. * html/HTMLParser.cpp:
  6878. (WebCore::HTMLParser::getNode):
  6879. (WebCore::HTMLParser::isInline):
  6880. * html/HTMLTagNames.in:
  6881. * html/HTMLTokenizer.cpp:
  6882. (WebCore::HTMLTokenizer::scriptHandler):
  6883. (WebCore::HTMLTokenizer::notifyFinished):
  6884. * loader/FrameLoader.cpp:
  6885. (WebCore::FrameLoader::addExtraFieldsToRequest):
  6886. * platform/MIMETypeRegistry.cpp:
  6887. (WebCore::initializeSupportedNonImageMimeTypes):
  6888. 2009-05-18 Mark Rowe <mrowe@apple.com>
  6889. Fix the build.
  6890. * WebCore.xcodeproj/project.pbxproj:
  6891. 2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  6892. Rubber-stamped by Gustavo Noronha.
  6893. Fixed build for the Qt port by adding the WebCore/accessibility
  6894. directory to the includepath.
  6895. * WebCore.pro:
  6896. 2009-05-18 Chris Fleizach <cfleizach@apple.com>
  6897. Bug 25776: accessibility should have its own folder in WebCore project
  6898. https://bugs.webkit.org/show_bug.cgi?id=25776
  6899. Speculative fix for windows build failure.
  6900. * WebCore.vcproj/WebCoreCommon.vsprops:
  6901. 2009-05-18 David Kilzer <ddkilzer@apple.com>
  6902. Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
  6903. <https://bugs.webkit.org/show_bug.cgi?id=20652>
  6904. Reviewed by Darin Adler.
  6905. Test: http/tests/misc/favicon-as-image.html
  6906. * inspector/front-end/inspector.js: Added
  6907. image/vnd.microsoft.icon to WebInspector.MIMETypes.
  6908. * platform/MIMETypeRegistry.cpp:
  6909. (WebCore::initializeSupportedImageMIMETypes): Added
  6910. image/vnd.microsoft.icon to list of supported image and image
  6911. resource MIME types.
  6912. 2009-05-18 Chris Fleizach <cfleizach@apple.com>
  6913. Reviewed by Sam Weinig.
  6914. Bug 25776: accessibility should have its own folder in WebCore project
  6915. https://bugs.webkit.org/show_bug.cgi?id=25776
  6916. * GNUmakefile.am:
  6917. * WebCore.pro:
  6918. * WebCore.vcproj/WebCore.vcproj:
  6919. * WebCore.xcodeproj/project.pbxproj:
  6920. * WebCoreSources.bkl:
  6921. * accessibility: Added.
  6922. * accessibility/AXObjectCache.cpp: Copied from WebCore/page/AXObjectCache.cpp.
  6923. * accessibility/AXObjectCache.h: Copied from WebCore/page/AXObjectCache.h.
  6924. * accessibility/AccessibilityAriaGrid.cpp: Copied from WebCore/page/AccessibilityAriaGrid.cpp.
  6925. * accessibility/AccessibilityAriaGrid.h: Copied from WebCore/page/AccessibilityAriaGrid.h.
  6926. * accessibility/AccessibilityAriaGridCell.cpp: Copied from WebCore/page/AccessibilityAriaGridCell.cpp.
  6927. * accessibility/AccessibilityAriaGridCell.h: Copied from WebCore/page/AccessibilityAriaGridCell.h.
  6928. * accessibility/AccessibilityAriaGridRow.cpp: Copied from WebCore/page/AccessibilityAriaGridRow.cpp.
  6929. * accessibility/AccessibilityAriaGridRow.h: Copied from WebCore/page/AccessibilityAriaGridRow.h.
  6930. * accessibility/AccessibilityImageMapLink.cpp: Copied from WebCore/page/AccessibilityImageMapLink.cpp.
  6931. * accessibility/AccessibilityImageMapLink.h: Copied from WebCore/page/AccessibilityImageMapLink.h.
  6932. * accessibility/AccessibilityList.cpp: Copied from WebCore/page/AccessibilityList.cpp.
  6933. * accessibility/AccessibilityList.h: Copied from WebCore/page/AccessibilityList.h.
  6934. * accessibility/AccessibilityListBox.cpp: Copied from WebCore/page/AccessibilityListBox.cpp.
  6935. * accessibility/AccessibilityListBox.h: Copied from WebCore/page/AccessibilityListBox.h.
  6936. * accessibility/AccessibilityListBoxOption.cpp: Copied from WebCore/page/AccessibilityListBoxOption.cpp.
  6937. * accessibility/AccessibilityListBoxOption.h: Copied from WebCore/page/AccessibilityListBoxOption.h.
  6938. * accessibility/AccessibilityObject.cpp: Copied from WebCore/page/AccessibilityObject.cpp.
  6939. * accessibility/AccessibilityObject.h: Copied from WebCore/page/AccessibilityObject.h.
  6940. * accessibility/AccessibilityRenderObject.cpp: Copied from WebCore/page/AccessibilityRenderObject.cpp.
  6941. * accessibility/AccessibilityRenderObject.h: Copied from WebCore/page/AccessibilityRenderObject.h.
  6942. * accessibility/AccessibilityTable.cpp: Copied from WebCore/page/AccessibilityTable.cpp.
  6943. * accessibility/AccessibilityTable.h: Copied from WebCore/page/AccessibilityTable.h.
  6944. * accessibility/AccessibilityTableCell.cpp: Copied from WebCore/page/AccessibilityTableCell.cpp.
  6945. * accessibility/AccessibilityTableCell.h: Copied from WebCore/page/AccessibilityTableCell.h.
  6946. * accessibility/AccessibilityTableColumn.cpp: Copied from WebCore/page/AccessibilityTableColumn.cpp.
  6947. * accessibility/AccessibilityTableColumn.h: Copied from WebCore/page/AccessibilityTableColumn.h.
  6948. * accessibility/AccessibilityTableHeaderContainer.cpp: Copied from WebCore/page/AccessibilityTableHeaderContainer.cpp.
  6949. * accessibility/AccessibilityTableHeaderContainer.h: Copied from WebCore/page/AccessibilityTableHeaderContainer.h.
  6950. * accessibility/AccessibilityTableRow.cpp: Copied from WebCore/page/AccessibilityTableRow.cpp.
  6951. * accessibility/AccessibilityTableRow.h: Copied from WebCore/page/AccessibilityTableRow.h.
  6952. * accessibility/chromium: Added.
  6953. * accessibility/chromium/AXObjectCacheChromium.cpp: Copied from WebCore/page/chromium/AXObjectCacheChromium.cpp.
  6954. * accessibility/chromium/AccessibilityObjectChromium.cpp: Copied from WebCore/page/chromium/AccessibilityObjectChromium.cpp.
  6955. * accessibility/chromium/AccessibilityObjectWrapper.h: Copied from WebCore/page/chromium/AccessibilityObjectWrapper.h.
  6956. * accessibility/gtk: Added.
  6957. * accessibility/gtk/AXObjectCacheAtk.cpp: Copied from WebCore/page/gtk/AXObjectCacheAtk.cpp.
  6958. * accessibility/gtk/AccessibilityObjectAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectAtk.cpp.
  6959. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp.
  6960. * accessibility/gtk/AccessibilityObjectWrapperAtk.h: Copied from WebCore/page/gtk/AccessibilityObjectWrapperAtk.h.
  6961. * accessibility/mac: Added.
  6962. * accessibility/mac/AXObjectCacheMac.mm: Copied from WebCore/page/mac/AXObjectCacheMac.mm.
  6963. * accessibility/mac/AccessibilityObjectMac.mm: Copied from WebCore/page/mac/AccessibilityObjectMac.mm.
  6964. * accessibility/mac/AccessibilityObjectWrapper.h: Copied from WebCore/page/mac/AccessibilityObjectWrapper.h.
  6965. * accessibility/mac/AccessibilityObjectWrapper.mm: Copied from WebCore/page/mac/AccessibilityObjectWrapper.mm.
  6966. * accessibility/qt: Added.
  6967. * accessibility/qt/AccessibilityObjectQt.cpp: Copied from WebCore/page/qt/AccessibilityObjectQt.cpp.
  6968. * accessibility/win: Added.
  6969. * accessibility/win/AXObjectCacheWin.cpp: Copied from WebCore/page/win/AXObjectCacheWin.cpp.
  6970. * accessibility/win/AccessibilityObjectWin.cpp: Copied from WebCore/page/win/AccessibilityObjectWin.cpp.
  6971. * accessibility/win/AccessibilityObjectWrapperWin.h: Copied from WebCore/page/win/AccessibilityObjectWrapperWin.h.
  6972. * accessibility/wx: Added.
  6973. * accessibility/wx/AccessibilityObjectWx.cpp: Copied from WebCore/page/wx/AccessibilityObjectWx.cpp.
  6974. * page/AXObjectCache.cpp: Removed.
  6975. * page/AXObjectCache.h: Removed.
  6976. * page/AccessibilityAriaGrid.cpp: Removed.
  6977. * page/AccessibilityAriaGrid.h: Removed.
  6978. * page/AccessibilityAriaGridCell.cpp: Removed.
  6979. * page/AccessibilityAriaGridCell.h: Removed.
  6980. * page/AccessibilityAriaGridRow.cpp: Removed.
  6981. * page/AccessibilityAriaGridRow.h: Removed.
  6982. * page/AccessibilityImageMapLink.cpp: Removed.
  6983. * page/AccessibilityImageMapLink.h: Removed.
  6984. * page/AccessibilityList.cpp: Removed.
  6985. * page/AccessibilityList.h: Removed.
  6986. * page/AccessibilityListBox.cpp: Removed.
  6987. * page/AccessibilityListBox.h: Removed.
  6988. * page/AccessibilityListBoxOption.cpp: Removed.
  6989. * page/AccessibilityListBoxOption.h: Removed.
  6990. * page/AccessibilityObject.cpp: Removed.
  6991. * page/AccessibilityObject.h: Removed.
  6992. * page/AccessibilityRenderObject.cpp: Removed.
  6993. * page/AccessibilityRenderObject.h: Removed.
  6994. * page/AccessibilityTable.cpp: Removed.
  6995. * page/AccessibilityTable.h: Removed.
  6996. * page/AccessibilityTableCell.cpp: Removed.
  6997. * page/AccessibilityTableCell.h: Removed.
  6998. * page/AccessibilityTableColumn.cpp: Removed.
  6999. * page/AccessibilityTableColumn.h: Removed.
  7000. * page/AccessibilityTableHeaderContainer.cpp: Removed.
  7001. * page/AccessibilityTableHeaderContainer.h: Removed.
  7002. * page/AccessibilityTableRow.cpp: Removed.
  7003. * page/AccessibilityTableRow.h: Removed.
  7004. * page/chromium/AXObjectCacheChromium.cpp: Removed.
  7005. * page/chromium/AccessibilityObjectChromium.cpp: Removed.
  7006. * page/chromium/AccessibilityObjectWrapper.h: Removed.
  7007. * page/gtk/AXObjectCacheAtk.cpp: Removed.
  7008. * page/gtk/AccessibilityObjectAtk.cpp: Removed.
  7009. * page/gtk/AccessibilityObjectWrapperAtk.cpp: Removed.
  7010. * page/gtk/AccessibilityObjectWrapperAtk.h: Removed.
  7011. * page/mac/AXObjectCacheMac.mm: Removed.
  7012. * page/mac/AccessibilityObjectMac.mm: Removed.
  7013. * page/mac/AccessibilityObjectWrapper.h: Removed.
  7014. * page/mac/AccessibilityObjectWrapper.mm: Removed.
  7015. * page/qt/AccessibilityObjectQt.cpp: Removed.
  7016. * page/win/AXObjectCacheWin.cpp: Removed.
  7017. * page/win/AccessibilityObjectWin.cpp: Removed.
  7018. * page/win/AccessibilityObjectWrapperWin.h: Removed.
  7019. * page/wx/AccessibilityObjectWx.cpp: Removed.
  7020. 2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  7021. Reviewed by Jan Alonzo.
  7022. https://bugs.webkit.org/show_bug.cgi?id=25854
  7023. [GTK] Should tell servers we only support identity as content encoding
  7024. Let servers know we only support identity as content
  7025. encoding. We will implement this in libsoup.
  7026. * platform/network/soup/ResourceHandleSoup.cpp:
  7027. (WebCore::ResourceHandle::startHttp):
  7028. 2009-05-18 Alexey Proskuryakov <ap@webkit.org>
  7029. Reviewed by Darin Adler.
  7030. <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
  7031. CAPTCHA failure.
  7032. The problem was that after loading and displaying a CAPTCHA image, it was loaded from
  7033. the server again due to preloading. So, the server expected the last loaded (invisible)
  7034. CAPTCHA text to be typed and posted back.
  7035. I don't know how to make tests for preloading.
  7036. * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
  7037. to preload after loading for real - and if cache policy is CachePolicyReload, that actually
  7038. results in another load from network layer.
  7039. * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
  7040. to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
  7041. 2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
  7042. Reviewed by Simon Hausmann.
  7043. Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.
  7044. https://bugs.webkit.org/show_bug.cgi?id=24551
  7045. [Qt] Reuse FontPlatformData for the same FontDescription.
  7046. This effectively prevents growing heap usage for loading every web page.
  7047. * platform/graphics/qt/FontCacheQt.cpp:
  7048. (WebCore::qHash): Necessary for FontPlatformDataCache.
  7049. (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
  7050. it exists, otherwise create a new one and insert it in the cache.
  7051. 2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
  7052. Reviewed by Ariya Hidayat.
  7053. https://bugs.webkit.org/show_bug.cgi?id=24551
  7054. [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
  7055. When creating a new instance of SimpleFontData, put it in the font list
  7056. so that it can deleted later on.
  7057. * platform/graphics/qt/FontFallbackListQt.cpp:
  7058. (WebCore::FontFallbackList::invalidate):
  7059. (WebCore::FontFallbackList::releaseFontData):
  7060. (WebCore::FontFallbackList::fontDataAt):
  7061. 2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
  7062. Reviewed by Xan Lopez.
  7063. [Gtk] Various autotools build refactoring and fixes
  7064. https://bugs.webkit.org/show_bug.cgi?id=25286
  7065. Style fixes
  7066. * GNUmakefile.am:
  7067. 2009-05-17 George Staikos <george.staikos@torchmobile.com>
  7068. Not reviewed - build fix.
  7069. Fix typo: constr -> const.
  7070. * wml/WMLInputElement.h:
  7071. (WebCore::WMLInputElement::setPlaceholder):
  7072. 2009-05-17 Darin Adler <darin@apple.com>
  7073. Fix done by Simon Fraser (reviewed by me).
  7074. <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
  7075. transitions has bad layout and overlapping garbled text when printing
  7076. * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
  7077. * page/animation/AnimationController.cpp:
  7078. (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
  7079. 2009-05-17 Darin Adler <darin@apple.com>
  7080. Reviewed by Simon Fraser.
  7081. <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
  7082. * html/HTMLSelectElement.cpp:
  7083. (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
  7084. also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
  7085. * manual-tests/select-option-in-onload.html: Added.
  7086. 2009-05-17 Simon Fraser <simon.fraser@apple.com>
  7087. Reviewed by Anders Carlsson
  7088. Rename local variables for readability.
  7089. * rendering/RenderBoxModelObject.cpp:
  7090. (WebCore::RenderBoxModelObject::paintBorder):
  7091. 2009-05-17 Darin Adler <darin@apple.com>
  7092. Reviewed by Mark Rowe.
  7093. Bug 25840: fix some warnings seen on the GTK bot
  7094. https://bugs.webkit.org/show_bug.cgi?id=25840
  7095. * platform/ScrollView.cpp:
  7096. (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
  7097. This is really just to quiet warnings. I think this code is unreachable.
  7098. Someone could put ASSERT_NOT_REACHED() in here too at some point.
  7099. * plugins/PluginStream.cpp:
  7100. (WebCore::PluginStream::startStream): Use proper printf format for int
  7101. here, %d, not %lu. This could cause a real problem when compiled 64-bit,
  7102. so it's good to fix.
  7103. * rendering/RenderTextControl.cpp:
  7104. (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
  7105. really just to quiet the warning, but still seems like a good idea.
  7106. 2009-05-17 Chris Fleizach <cfleizach@apple.com>
  7107. Reviewed by Darin Adler.
  7108. Bug 25769: Fix accessibility warnings on GTK
  7109. https://bugs.webkit.org/show_bug.cgi?id=25769
  7110. * page/AccessibilityTable.cpp:
  7111. (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
  7112. (WebCore::AccessibilityTable::rowCount): Ditto.
  7113. * page/AccessibilityTable.h: Ditto.
  7114. 2009-05-17 Kai Brüning <kai@granus.net>
  7115. Reviewed by Darin Adler.
  7116. bug 25822: DOM normalize does not remove empty text node between element nodes
  7117. https://bugs.webkit.org/show_bug.cgi?id=25822
  7118. Test: fast/dom/Node/normalize.html
  7119. * dom/Node.cpp:
  7120. (WebCore::Node::normalize): Changed to remove any empty text nodes.
  7121. 2009-05-16 Dave Moore <davemoore@google.com>
  7122. Reviewed by Darin Adler.
  7123. Allow Strings to be created with one malloc node with no copying
  7124. https://bugs.webkit.org/show_bug.cgi?id=25779
  7125. Add new methods to String and StringImpl, refactoring existing
  7126. methods in StringImpl to use new createUninitialized() method.
  7127. * platform/text/PlatformString.h:
  7128. (WebCore::String::createUninitialized):
  7129. * platform/text/StringImpl.cpp:
  7130. (WebCore::StringImpl::createUninitialized):
  7131. (WebCore::StringImpl::create):
  7132. * platform/text/StringImpl.h:
  7133. 2009-05-16 Mark Rowe <mrowe@apple.com>
  7134. Reviewed by Darin Adler.
  7135. <rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
  7136. dramatically improve animated GIF decoding performance
  7137. Recent versions of ImageIO discard previously decoded image frames if the client
  7138. application no longer holds references to them, so there's no need to throw away
  7139. the decoder unless we're explicitly asked to destroy all of the frames.
  7140. This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
  7141. from over 90% to below 3%.
  7142. * platform/graphics/cg/ImageSourceCG.cpp:
  7143. (WebCore::ImageSource::clear):
  7144. 2009-05-16 Dan Bernstein <mitz@apple.com>
  7145. Reviewed by Alexey Proskuryakov.
  7146. - fix <rdar://problem/6873305> Two distinct characters are not displayed
  7147. correctly with 2 of the font selections from the stickies widget
  7148. Test: platform/mac/editing/pasteboard/text-precomposed.html
  7149. Ensure that "text/plain" data retrieved from the clipboard is always
  7150. precomposed. This makes Clipboard::getData() and
  7151. Pasteboard::documentFragment() consistent with Pasteboard::plainText()
  7152. and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
  7153. * platform/mac/ClipboardMac.mm:
  7154. (WebCore::ClipboardMac::getData):
  7155. * platform/mac/PasteboardMac.mm:
  7156. (WebCore::Pasteboard::documentFragment):
  7157. 2009-05-16 Mark Rowe <mrowe@apple.com>
  7158. Build fix.
  7159. * css/CSSComputedStyleDeclaration.cpp:
  7160. (WebCore::valueForFamily): Declare valueForFamily as static.
  7161. 2009-05-15 Darin Adler <darin@apple.com>
  7162. Reviewed by Dan Bernstein.
  7163. <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
  7164. only the generic font, if any generic font is in the family list
  7165. Test: fast/css/getComputedStyle/computed-style-font-family.html
  7166. * css/CSSComputedStyleDeclaration.cpp:
  7167. Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
  7168. (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
  7169. (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
  7170. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
  7171. property as specified in the CSS standard. Fixed clip to return "auto" when there is no
  7172. clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
  7173. internal linkage since there was no reason for them to have external linkage.
  7174. 2009-05-15 Adam Barth <abarth@webkit.org>
  7175. Reviewed by Oliver Hunt.
  7176. https://bugs.webkit.org/show_bug.cgi?id=25741
  7177. Append instead of throwing when insertItemBefore gets an out-of-bound
  7178. index.
  7179. Test: svg/dom/svglist-insertItemBefore-appends.html
  7180. * svg/SVGList.h:
  7181. (WebCore::SVGList::insertItemBefore):
  7182. 2009-05-15 Simon Fraser <simon.fraser@apple.com>
  7183. Reviewed by Darin Adler
  7184. https://bugs.webkit.org/show_bug.cgi?id=25829
  7185. Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
  7186. Test: fast/backgrounds/background-clip-text.html
  7187. * rendering/RenderBoxModelObject.cpp:
  7188. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  7189. 2009-05-15 Dan Bernstein <mitz@apple.com>
  7190. Reviewed by Sam Weinig.
  7191. - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
  7192. arrows, I can't navigate caret between To Do items in a Note message
  7193. Test: editing/selection/move-by-line-004.html
  7194. * editing/visible_units.cpp:
  7195. (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
  7196. function.
  7197. (WebCore::previousLinePosition): When advancing to the next candidate
  7198. node, stop when leaving the closest ancestor of the original node that
  7199. is not an inline. The code, incorrectly, was trying to exit the closest
  7200. ancestor of that type which was editable, and therefore missing other
  7201. blocks in the same editable root.
  7202. (WebCore::nextLinePosition): Ditto.
  7203. 2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
  7204. Reviewed by Jan Alonzo.
  7205. Converting filename to uri by concatenating strings is broken
  7206. on Windows. So, don't do it for that platform.
  7207. * platform/network/soup/ResourceHandleSoup.cpp:
  7208. (WebCore::ResourceHandle::startGio):
  7209. 2009-05-15 Nate Chapin <japhet@google.com>
  7210. Reviewed by Dimitri Glazkov.
  7211. Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
  7212. https://bugs.webkit.org/show_bug.cgi?id=25739
  7213. * bindings/v8/V8Collection.cpp: Added.
  7214. (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
  7215. * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
  7216. * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  7217. (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
  7218. * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
  7219. (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp.
  7220. (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
  7221. 2009-05-15 David Kilzer <ddkilzer@apple.com>
  7222. <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
  7223. Reviewed by Darin Adler and Timothy Hatcher.
  7224. * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
  7225. WebCore.base.exp into the group, and added 10 other *.exp files
  7226. in WebCore.
  7227. 2009-05-15 Dimitri Glazkov <dglazkov@chromium.org>
  7228. Unreviewed, build fix.
  7229. https://bugs.webkit.org/show_bug.cgi?id=25826
  7230. Change type to only have custom getter in JCS.
  7231. * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
  7232. 2009-05-15 Antti Koivisto <antti@apple.com>
  7233. Reviewed by Dave Kilzer.
  7234. Add a settings entry to en/disable web font support
  7235. https://bugs.webkit.org/show_bug.cgi?id=25239
  7236. * css/CSSFontSelector.cpp:
  7237. (WebCore::CSSFontSelector::addFontFaceRule):
  7238. 2009-05-15 Sam Weinig <sam@webkit.org>
  7239. Reviewed by Steve Falkenburg.
  7240. Remove dead youtube site specific hack that was commented out.
  7241. * bindings/js/JSNavigatorCustom.cpp:
  7242. * page/Navigator.idl:
  7243. 2009-05-15 Sam Weinig <sam@webkit.org>
  7244. Reviewed by Beth Dakin.
  7245. Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
  7246. <rdar://problem/6884742>
  7247. REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
  7248. Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
  7249. * bindings/js/JSHTMLInputElementCustom.cpp:
  7250. (WebCore::needsGmailQuirk):
  7251. (WebCore::JSHTMLInputElement::type):
  7252. * html/HTMLInputElement.idl:
  7253. 2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
  7254. Reviewed by Eric Seidel.
  7255. https://bugs.webkit.org/show_bug.cgi?id=25810
  7256. Upstream V8 DOM Wrapper map declarations.
  7257. No behavior change, so no tests.
  7258. * bindings/v8/V8DOMMap.h:
  7259. (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
  7260. (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
  7261. (WebCore::WeakReferenceMap::get): Added.
  7262. (WebCore::WeakReferenceMap::set): Added.
  7263. (WebCore::WeakReferenceMap::forget): Added.
  7264. (WebCore::WeakReferenceMap::contains): Added.
  7265. (WebCore::WeakReferenceMap::impl): Added.
  7266. (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
  7267. 2009-05-15 Simon Fraser <simon.fraser@apple.com>
  7268. Reviewed by Dave Hyatt
  7269. https://bugs.webkit.org/show_bug.cgi?id=25773
  7270. Rename GraphicsLayer::graphicsContextsFlipped() to
  7271. GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
  7272. Clean up code around the GraphicsLayer "contents" layer that makes use of this
  7273. flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
  7274. which can then always do the flipping if necessary.
  7275. Only affects ACCELERATED_COMPOSITING builds.
  7276. * platform/graphics/GraphicsLayer.h:
  7277. (WebCore::GraphicsLayer::):
  7278. * platform/graphics/mac/GraphicsLayerCA.h:
  7279. (WebCore::GraphicsLayerCA::contentsLayer):
  7280. * platform/graphics/mac/GraphicsLayerCA.mm:
  7281. (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
  7282. (WebCore::GraphicsLayerCA::setBackgroundColor):
  7283. (WebCore::GraphicsLayerCA::clearBackgroundColor):
  7284. (WebCore::GraphicsLayerCA::setContentsToImage):
  7285. (WebCore::GraphicsLayerCA::clearContents):
  7286. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  7287. (WebCore::GraphicsLayerCA::setContentsLayer):
  7288. * rendering/RenderLayerCompositor.cpp:
  7289. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  7290. 2009-05-15 Chris Marrin <cmarrin@apple.com>
  7291. Reviewed by Simon Fraser.
  7292. https://bugs.webkit.org/show_bug.cgi?id=25765
  7293. Avoid calling setNeedsStyleRecalc() when we are
  7294. putting an animated page in the cache. This avoids
  7295. the assert and subsequent problems with a dirty
  7296. page going into the cache.
  7297. * page/animation/KeyframeAnimation.cpp:
  7298. (WebCore::KeyframeAnimation::endAnimation):
  7299. 2009-05-15 Francisco Tolmasky <francisco@280north.com>
  7300. BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
  7301. <https://bugs.webkit.org/show_bug.cgi?id=25467>
  7302. Reviewed by Adam Roben.
  7303. * inspector/JavaScriptCallFrame.cpp:
  7304. (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
  7305. * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
  7306. (WebInspector.CallStackSidebarPane.prototype.update):
  7307. 2009-05-15 Alexey Proskuryakov <ap@webkit.org>
  7308. Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
  7309. * platform/network/cf/ResourceHandleCFNet.cpp:
  7310. (WebCore::ResourceHandle::start):
  7311. * platform/network/mac/ResourceHandleMac.mm:
  7312. (WebCore::ResourceHandle::start):
  7313. Check strings with isEmpty(), not relying on any implicit conversions.
  7314. 2009-05-15 Alexey Proskuryakov <ap@webkit.org>
  7315. Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
  7316. <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
  7317. username and password (Lightwave 9.6 for Mac from Newtek site)
  7318. CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
  7319. for other protocols (including FTP) should be included as part of the URL.
  7320. * platform/network/cf/ResourceHandleCFNet.cpp:
  7321. (WebCore::ResourceHandle::start):
  7322. (WebCore::WebCoreSynchronousLoader::load):
  7323. * platform/network/mac/ResourceHandleMac.mm:
  7324. (WebCore::ResourceHandle::start):
  7325. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
  7326. Put credentials in URL for non-HTTP requests.
  7327. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
  7328. Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
  7329. headers to be received, so they cannot work with other protocols.
  7330. 2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
  7331. Reviewed by Holger Freyther.
  7332. [Qt] In the image decoder, remove the raw image data represented as QImage
  7333. once the image is converted to QPixmap and inserted in the pixmap cache.
  7334. This effectively reduces the heap usage when running on graphics system
  7335. other than raster (i.e the case where QImage != QPixmap).
  7336. * platform/graphics/qt/ImageDecoderQt.cpp:
  7337. (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
  7338. * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
  7339. 2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
  7340. Reviewed by Holger Freyther.
  7341. [Qt] Refactor alpha channel detection the image decoder.
  7342. Sets the boolean flag as soon as the image is being read.
  7343. * platform/graphics/qt/ImageDecoderQt.cpp:
  7344. (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
  7345. (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
  7346. (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
  7347. (WebCore::ImageDecoderQt::reset): Resetted the flag.
  7348. * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
  7349. 2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  7350. Reviewed by Darin Adler.
  7351. Finish support for disabling the JavaScript Debugger and Profiler
  7352. at compile time in WebCore
  7353. https://bugs.webkit.org/show_bug.cgi?id=24917
  7354. * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
  7355. * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
  7356. * inspector/JavaScriptCallFrame.cpp: Ditto.
  7357. * inspector/JavaScriptCallFrame.h: Ditto.
  7358. * inspector/JavaScriptCallFrame.idl: Ditto.
  7359. * inspector/JavaScriptDebugListener.h: Ditto.
  7360. * inspector/JavaScriptDebugServer.cpp: Ditto.
  7361. * inspector/JavaScriptDebugServer.h: Ditto.
  7362. * inspector/JavaScriptProfile.cpp: Ditto.
  7363. * inspector/JavaScriptProfile.h: Ditto.
  7364. * inspector/JavaScriptProfileNode.cpp: Ditto.
  7365. * inspector/JavaScriptProfileNode.h: Ditto.
  7366. * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
  7367. * page/Console.h: Ditto.
  7368. * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
  7369. 2009-05-15 Jungshik Shin <jshin@chromium.org>
  7370. Reviewed by Dimitri Glazkov
  7371. http://bugs.webkit.org/show_bug.cgi?id=25464
  7372. Improve the font fallback for characters belonging to 'common' scripts
  7373. in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
  7374. marks in North Indian scripts) and currency signs (e.g. Thai Baht)
  7375. rendered correctly in Chromium on Win.
  7376. Tests: fast/text/international/danda-space.html
  7377. fast/text/international/thai-baht-space.html
  7378. * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  7379. (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
  7380. (WebCore::FontMap::getScript):
  7381. (WebCore::getFallbackFamily):
  7382. 2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  7383. Reviewed by Holger Freyther.
  7384. https://bugs.webkit.org/show_bug.cgi?id=25731
  7385. [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
  7386. appropriate build section
  7387. * WebCore.pro:
  7388. 2009-05-14 Evan Martin <evan@chromium.org>
  7389. Reviewed by Eric Seidel and Darin Fisher.
  7390. Fix a font-related leak in Chromium's Skia backend found by Valgrind.
  7391. https://bugs.webkit.org/show_bug.cgi?id=25760
  7392. * platform/graphics/chromium/FontCacheLinux.cpp:
  7393. (WebCore::FontCache::getFontDataForCharacters):
  7394. Use caches instead of "new" on every call.
  7395. 2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>
  7396. Reviewed by Eric Seidel.
  7397. Initialize m_spreadMethod in the second constructor too. Not sure if
  7398. a test case can be written, so no test case.
  7399. https://bugs.webkit.org/show_bug.cgi?id=25814
  7400. No test possible: spreadMethod() is only used by SVG, doesn't seem possible to hit
  7401. this case, since several other SVG tests already should be calling
  7402. spreadMethod().
  7403. * platform/graphics/Gradient.cpp:
  7404. (WebCore::Gradient::Gradient):
  7405. 2009-05-14 Simon Fraser <simon.fraser@apple.com>
  7406. No review.
  7407. Fix Windows build after renaming MediaControlElements to MediaControlElementType.
  7408. * rendering/RenderMediaControls.cpp:
  7409. (WebCore::RenderMediaControls::paintMediaControlsPart):
  7410. * rendering/RenderMediaControls.h:
  7411. 2009-05-14 Simon Fraser <simon.fraser@apple.com>
  7412. Reviewed by Darin Adler
  7413. <rdar://problem/6739671> Movie controller’s play button does not change into a pause
  7414. button
  7415. Fix a controls repaint issue when the playing state of a video changes by
  7416. educating the MediaControlInputElements about the state they are currently
  7417. displaying, and making them repaint when that state changes. This applies
  7418. to the play/pause and mute/unmute buttons, which both have two states.
  7419. * rendering/MediaControlElements.cpp:
  7420. (WebCore::MediaControlInputElement::MediaControlInputElement):
  7421. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
  7422. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
  7423. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
  7424. Pass in and initialize the MediaControlElementType.
  7425. (WebCore::MediaControlInputElement::update):
  7426. Update the display type too
  7427. (WebCore::MediaControlInputElement::setDisplayType):
  7428. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
  7429. (WebCore::MediaControlMuteButtonElement::updateDisplayType):
  7430. Choose muted vs. unmuted display.
  7431. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
  7432. (WebCore::MediaControlPlayButtonElement::updateDisplayType):
  7433. Choose play vs. paused display.
  7434. * rendering/MediaControlElements.h:
  7435. Renamed the MediaControlElements enum to MediaControlElementType.
  7436. (WebCore::MediaControlInputElement::updateDisplayType):
  7437. Add a MediaControlElementType member variable with a setter to allow
  7438. the element to know what type it is displaying.
  7439. 2009-05-14 Dean Jackson <dino@apple.com>
  7440. Reviewed by Simon Fraser.
  7441. https://bugs.webkit.org/show_bug.cgi?id=25197
  7442. Add support for aspect-ratio and orientation
  7443. media queries.
  7444. Tests: fast/media/mq-aspect-ratio.html
  7445. fast/media/mq-orientation.html
  7446. * css/MediaFeatureNames.h:
  7447. * css/MediaQueryEvaluator.cpp:
  7448. (WebCore::orientationMediaFeatureEval):
  7449. (WebCore::aspect_ratioMediaFeatureEval):
  7450. (WebCore::min_aspect_ratioMediaFeatureEval):
  7451. (WebCore::max_aspect_ratioMediaFeatureEval):
  7452. * css/MediaQueryExp.h:
  7453. (WebCore::MediaQueryExp::isViewportDependent):
  7454. 2009-05-14 Kevin McCullough <kmccullough@apple.com>
  7455. - Resubmitting previous patch, correctly this time.
  7456. * editing/CompositeEditCommand.cpp:
  7457. (WebCore::CompositeEditCommand::splitTreeToNode):
  7458. * editing/IndentOutdentCommand.cpp:
  7459. (WebCore::IndentOutdentCommand::outdentParagraph):
  7460. 2009-05-14 Kevin McCullough <kmccullough@apple.com>
  7461. - Rolling out to fix a bug and the build
  7462. * editing/CompositeEditCommand.cpp:
  7463. (WebCore::CompositeEditCommand::splitTreeToNode):
  7464. * editing/IndentOutdentCommand.cpp:
  7465. (WebCore::IndentOutdentCommand::outdentParagraph):
  7466. 2009-05-14 Kevin McCullough <kmccullough@apple.com>
  7467. Reviewed by Dan Bernstein.
  7468. <rdar://problem/6510362> In some situations message content is messed up
  7469. when indentation is decreased
  7470. * editing/CompositeEditCommand.cpp:
  7471. (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
  7472. here served to do nothing because this function will return if the
  7473. second argument is the parent of the first. Not only does this now work
  7474. as intended, but is necessary for the rest of this fix.
  7475. * editing/IndentOutdentCommand.cpp:
  7476. (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we
  7477. are the last node in a <blockquote>, and can therefore remove the
  7478. <blockquote> we need the endOfEnclosingBlock to extend to the end of
  7479. the <blockquote> not just the next block, which could be a <div>, for
  7480. example.
  7481. - Also If a <blockquote> is removed, but it's the child of another
  7482. <blockquote> then its children are now children of the top <blockquote>.
  7483. In this case we want to split the parent <blockquote> because the next
  7484. paragraph assumes that it is the first node in its <blockquote> and if
  7485. that is not true, various bugs arise.
  7486. 2009-05-14 Brady Eidson <beidson@apple.com>
  7487. Build fix.
  7488. * platform/network/cf/ResourceHandleCFNet.cpp:
  7489. (WebCore::setDefaultMIMEType):
  7490. 2009-05-14 Brady Eidson <beidson@apple.com>
  7491. Reviewed by Adam Roben.
  7492. Fix http/tests/xmlhttprequest/cache-override.html on Windows
  7493. * platform/network/cf/ResourceHandleCFNet.cpp:
  7494. (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
  7495. (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
  7496. (WebCore::WebCoreSynchronousLoader::load): Ditto.
  7497. 2009-05-14 Paul Godavari <paul@chromium.org>
  7498. Reviewed by Dimitri Glazkov.
  7499. Bug: Mac Chromium popup menus are not positioned correctly
  7500. on scrolled pages:
  7501. https://bugs.webkit.org/show_bug.cgi?id=25772
  7502. Fix Mac Chromium popup menu placement by taking into
  7503. account any scrolling in the current window. This mirrors
  7504. the positioning done in PopupContainer::show(), which is
  7505. used on Chromium Windows and linux.
  7506. Also fixed indenting for this method.
  7507. * platform/chromium/PopupMenuChromium.cpp:
  7508. (WebCore::PopupContainer::showExternal):
  7509. 2009-05-14 Drew Wilson <atwilson@google.com>
  7510. Reviewed by Dimitri Glazkov.
  7511. https://bugs.webkit.org/show_bug.cgi?id=25774
  7512. Upstream V8MessagePortCustom.cpp from the chromium repository.
  7513. * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
  7514. (WebCore::ACCESSOR_GETTER):
  7515. (WebCore::ACCESSOR_SETTER):
  7516. (WebCore::CALLBACK_FUNC_DECL):
  7517. 2009-05-14 Simon Fraser <simon.fraser@apple.com>
  7518. Reviewed by Darin Adler
  7519. https://bugs.webkit.org/show_bug.cgi?id=25777
  7520. StyleGeneratedImage::imageSize() needs to take zooming into account for
  7521. fixed-size images (i.e. canvas) so that canvas-as-image-background
  7522. renders correctly with zooming.
  7523. Test: fast/canvas/canvas-bg-zoom.html
  7524. * rendering/style/StyleGeneratedImage.cpp:
  7525. (WebCore::StyleGeneratedImage::imageSize):
  7526. 2009-05-14 Alexey Proskuryakov <ap@webkit.org>
  7527. Reviewed by Darin Adler.
  7528. Patch originally by Darin Adler.
  7529. https://bugs.webkit.org/show_bug.cgi?id=25796
  7530. <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
  7531. Test: http/tests/security/credentials-in-referer.html
  7532. * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
  7533. SubresourceLoader::create() anyway.
  7534. 2009-05-14 Chris Fleizach <cfleizach@apple.com>
  7535. Reviewed by Darin Adler.
  7536. Bug 25797: Pages with image maps are not properly read with Voiceover
  7537. https://bugs.webkit.org/show_bug.cgi?id=25797
  7538. * page/AccessibilityImageMapLink.h:
  7539. (WebCore::AccessibilityImageMapLink::isEnabled):
  7540. 2009-05-14 Brady Eidson <beidson@apple.com>
  7541. Reviewed by Darin Adler.
  7542. <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
  7543. Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
  7544. * platform/network/ResourceHandle.cpp:
  7545. (WebCore::ResourceHandle::shouldContentSniff):
  7546. * platform/network/ResourceHandle.h:
  7547. * platform/network/cf/ResourceHandleCFNet.cpp:
  7548. (WebCore::createCFURLResponseWithDefaultMIMEType):
  7549. (WebCore::didReceiveResponse):
  7550. 2009-05-14 Eric Carlson <eric.carlson@apple.com>
  7551. Reviewed by Darin Adler.
  7552. https://bugs.webkit.org/show_bug.cgi?id=25791
  7553. Bug 25791: HTMLMediaElement: implement 'startTime' attribute
  7554. Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
  7555. value that only the media engine can know, so we just need to add the attribute
  7556. to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
  7557. the engine can make it available.
  7558. Test: media/media-startTime.html
  7559. * html/HTMLMediaElement.cpp:
  7560. (WebCore::HTMLMediaElement::startTime): New.
  7561. * html/HTMLMediaElement.h:
  7562. * html/HTMLMediaElement.idl:
  7563. * platform/graphics/MediaPlayer.cpp:
  7564. (WebCore::MediaPlayer::startTime): New.
  7565. * platform/graphics/MediaPlayer.h:
  7566. * platform/graphics/MediaPlayerPrivate.h:
  7567. (WebCore::MediaPlayerPrivateInterface::startTime): New.
  7568. 2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  7569. Reviewed by Ariya Hidayat.
  7570. Only create a QWidget wrapper for the plugin in the case it is not
  7571. in the Qt window mapper, and thus receiving events from the Qt
  7572. event system. Native Qt based plugins running in process, will
  7573. already be in the window mapper, and thus creating a wrapper,
  7574. stops them from getting events from Qt, as they are redirected
  7575. to the wrapper.
  7576. * plugins/qt/PluginContainerQt.cpp:
  7577. (PluginContainerQt::on_clientIsEmbedded):
  7578. 2009-05-14 Alexey Proskuryakov <ap@webkit.org>
  7579. Reviewed by Darin Adler.
  7580. https://bugs.webkit.org/show_bug.cgi?id=25784
  7581. Leaks seen on HTTP tests
  7582. We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
  7583. * platform/network/mac/ResourceHandleMac.mm:
  7584. (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
  7585. disabling content sniffing, matching the normal code path.
  7586. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
  7587. and m_pass before overwriting.
  7588. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
  7589. 2009-05-14 Yury Semikhatsky <yurys@chromium.org>
  7590. Reviewed by Dimitri Glazkov.
  7591. https://bugs.webkit.org/show_bug.cgi?id=25418
  7592. Remove new lines from event handler wrapper to make line numbers
  7593. in the wrapped script conside with the lines in the original script.
  7594. * bindings/v8/V8LazyEventListener.cpp:
  7595. (WebCore::V8LazyEventListener::getListenerFunction):
  7596. (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  7597. 2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
  7598. Reviewed by Alexey Proskuryakov.
  7599. Remove a JSC-specific include that is already added by including
  7600. ScriptController.
  7601. No change in behavior, so no tests.
  7602. * dom/Document.cpp: Removed JSDOMBinding include.
  7603. 2009-05-14 Alexey Proskuryakov <ap@webkit.org>
  7604. Reviewed by Brady Eidson.
  7605. <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
  7606. Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
  7607. CFString function was used, so a user-friendly name was stored in encoding fallback array.
  7608. * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
  7609. * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
  7610. 2009-05-14 Ben Murdoch <benm@google.com>
  7611. Reviewed by Darin Adler.
  7612. Add more ENABLE_DATABASE guards.
  7613. https://bugs.webkit.org/show_bug.cgi?id=25616
  7614. See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
  7615. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  7616. * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  7617. * bindings/v8/custom/V8CustomSQLStatementCallback.h:
  7618. * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  7619. * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
  7620. * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  7621. * bindings/v8/custom/V8CustomSQLTransactionCallback.h:
  7622. * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  7623. * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
  7624. * bindings/v8/custom/V8DatabaseCustom.cpp:
  7625. * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  7626. * bindings/v8/custom/V8SQLTransactionCustom.cpp:
  7627. * storage/Database.cpp:
  7628. * storage/DatabaseDetails.h:
  7629. * storage/OriginUsageRecord.cpp:
  7630. * storage/OriginUsageRecord.h:
  7631. * storage/SQLError.h:
  7632. * storage/SQLError.idl:
  7633. * storage/SQLResultSet.cpp:
  7634. * storage/SQLResultSet.h:
  7635. * storage/SQLResultSet.idl:
  7636. * storage/SQLResultSetRowList.cpp:
  7637. * storage/SQLResultSetRowList.h:
  7638. * storage/SQLResultSetRowList.idl:
  7639. * storage/SQLStatementCallback.h:
  7640. * storage/SQLStatementErrorCallback.h:
  7641. * storage/SQLTransactionCallback.h:
  7642. * storage/SQLTransactionErrorCallback.h:
  7643. 2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
  7644. Reviewed by Darin Adler.
  7645. https://bugs.webkit.org/show_bug.cgi?id=25787
  7646. Gtk was the last platform to not unregister plugins when
  7647. the plugin is stopped. Catch up with r43550.
  7648. * plugins/gtk/PluginViewGtk.cpp:
  7649. (WebCore::PluginView::stop):
  7650. 2009-05-14 Adam Roben <aroben@apple.com>
  7651. Make WebCore.vcproj's pre-build event work again
  7652. * WebCore.vcproj/WebCore.vcproj: Removed empty override of the
  7653. pre-build event that was accidentally left in when the pre-build event
  7654. was moved to WebCoreCommon.vsprops.
  7655. 2009-05-14 Darin Adler <darin@apple.com>
  7656. * manual-tests/right-click-crash.html: Added.
  7657. 2009-05-14 Mark Rowe <mrowe@apple.com>
  7658. Rubber-stamped by Darin Adler.
  7659. <rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
  7660. The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
  7661. Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
  7662. if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
  7663. * Configurations/Base.xcconfig:
  7664. 2009-05-13 Anders Carlsson <andersca@apple.com>
  7665. Fix build.
  7666. * WebCore.NPAPI.exp:
  7667. 2009-05-13 Eric Seidel <eric@webkit.org>
  7668. Reviewed by Oliver Hunt.
  7669. Fix invalid memory write seen in HTMLCanvasElement by Valgrind
  7670. https://bugs.webkit.org/show_bug.cgi?id=25759
  7671. I can't think of any way to catch this with a layout test, so no test.
  7672. * css/CSSCanvasValue.cpp:
  7673. (WebCore::CSSCanvasValue::canvasDestroyed):
  7674. * css/CSSCanvasValue.h:
  7675. * html/HTMLCanvasElement.cpp:
  7676. (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
  7677. * html/HTMLCanvasElement.h:
  7678. 2009-05-13 Dan Bernstein <mitz@apple.com>
  7679. Reviewed by Anders Carlsson.
  7680. - fix <rdar://problem/5483015> Replies in Mail are drawn first without
  7681. the user style sheet and then redrawn with the style sheet
  7682. Test: platform/mac/fast/loader/user-stylesheet-fast-path.html
  7683. * page/mac/FrameMac.mm:
  7684. (WebCore::Frame::setUserStyleSheetLocation): For data URLs with
  7685. base64-encoded UTF-8 data, just decode the style sheet here an apply
  7686. it synchronously instead of invoking an asynchronous loader.
  7687. 2009-05-13 Chris Fleizach <cfleizach@apple.com>
  7688. Bug 25755: Implement ARIA grid role
  7689. https://bugs.webkit.org/show_bug.cgi?id=25755
  7690. Fix build bustage from last checkin.
  7691. * page/AccessibilityAriaGrid.cpp:
  7692. (WebCore::AccessibilityAriaGrid::addChild):
  7693. 2009-05-13 Chris Fleizach <cfleizach@apple.com>
  7694. Reviewed by Beth Dakin.
  7695. Bug 25755: Implement ARIA grid role
  7696. https://bugs.webkit.org/show_bug.cgi?id=25755
  7697. Test: accessibility/aria-tables.html
  7698. * GNUmakefile.am:
  7699. * WebCore.pro:
  7700. * WebCore.vcproj/WebCore.vcproj:
  7701. * WebCore.xcodeproj/project.pbxproj:
  7702. * WebCoreSources.bkl:
  7703. * page/AXObjectCache.cpp:
  7704. (WebCore::AXObjectCache::nodeIsAriaType):
  7705. (WebCore::AXObjectCache::getOrCreate):
  7706. * page/AXObjectCache.h:
  7707. * page/AccessibilityAriaGrid.cpp: Added.
  7708. (WebCore::AccessibilityAriaGrid::AccessibilityAriaGrid):
  7709. (WebCore::AccessibilityAriaGrid::~AccessibilityAriaGrid):
  7710. (WebCore::AccessibilityAriaGrid::create):
  7711. (WebCore::AccessibilityAriaGrid::addChild):
  7712. (WebCore::AccessibilityAriaGrid::addChildren):
  7713. (WebCore::AccessibilityAriaGrid::cellForColumnAndRow):
  7714. * page/AccessibilityAriaGrid.h: Added.
  7715. (WebCore::AccessibilityAriaGrid::isAriaTable):
  7716. * page/AccessibilityAriaGridCell.cpp: Added.
  7717. (WebCore::AccessibilityAriaGridCell::AccessibilityAriaGridCell):
  7718. (WebCore::AccessibilityAriaGridCell::~AccessibilityAriaGridCell):
  7719. (WebCore::AccessibilityAriaGridCell::create):
  7720. (WebCore::AccessibilityAriaGridCell::parentTable):
  7721. (WebCore::AccessibilityAriaGridCell::rowIndexRange):
  7722. (WebCore::AccessibilityAriaGridCell::columnIndexRange):
  7723. * page/AccessibilityAriaGridCell.h: Added.
  7724. * page/AccessibilityAriaGridRow.cpp: Added.
  7725. (WebCore::AccessibilityAriaGridRow::AccessibilityAriaGridRow):
  7726. (WebCore::AccessibilityAriaGridRow::~AccessibilityAriaGridRow):
  7727. (WebCore::AccessibilityAriaGridRow::create):
  7728. (WebCore::AccessibilityAriaGridRow::parentTable):
  7729. (WebCore::AccessibilityAriaGridRow::headerObject):
  7730. * page/AccessibilityAriaGridRow.h: Added.
  7731. * page/AccessibilityList.cpp:
  7732. (WebCore::AccessibilityList::accessibilityIsIgnored):
  7733. * page/AccessibilityList.h:
  7734. * page/AccessibilityObject.h:
  7735. (WebCore::):
  7736. * page/AccessibilityRenderObject.cpp:
  7737. (WebCore::RoleEntry::):
  7738. * page/AccessibilityTable.cpp:
  7739. (WebCore::AccessibilityTable::AccessibilityTable):
  7740. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  7741. * page/AccessibilityTable.h:
  7742. (WebCore::AccessibilityTable::isAriaTable):
  7743. * page/AccessibilityTableCell.cpp:
  7744. (WebCore::AccessibilityTableCell::parentTable):
  7745. (WebCore::AccessibilityTableCell::isTableCell):
  7746. (WebCore::AccessibilityTableCell::titleUIElement):
  7747. * page/AccessibilityTableCell.h:
  7748. * page/AccessibilityTableColumn.cpp:
  7749. (WebCore::AccessibilityTableColumn::setParentTable):
  7750. (WebCore::AccessibilityTableColumn::headerObject):
  7751. * page/AccessibilityTableRow.cpp:
  7752. (WebCore::AccessibilityTableRow::isTableRow):
  7753. (WebCore::AccessibilityTableRow::parentTable):
  7754. * page/AccessibilityTableRow.h:
  7755. * page/mac/AccessibilityObjectWrapper.mm:
  7756. (RoleEntry::):
  7757. 2009-05-13 David Levin <levin@chromium.org>
  7758. Reviewed by Dimitri Glazkov.
  7759. Bug 25763: Need to move v8 custom binding to the custom directory.
  7760. https://bugs.webkit.org/show_bug.cgi?id=25763
  7761. No test due to no change in behavior.
  7762. * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
  7763. 2009-05-13 Nate Chapin <japhet@google.com>
  7764. Reviewed by Dimitri Glazkov.
  7765. Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
  7766. https://bugs.webkit.org/show_bug.cgi?id=25758
  7767. * bindings/v8/custom/V8ElementCustom.cpp:
  7768. (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
  7769. 2009-05-13 Jeremy Moskovich <jeremy@chromium.org>
  7770. Reviewed by Dave Hyatt.
  7771. Fix a number of bugs relating to RTL and text-overflow:ellipsis.
  7772. Also refactor the relevant code to make it a little clearer.
  7773. This CL fixes 3 fundamental issues:
  7774. - Corrects behavior if the truncated InlineTextBox's directionality is
  7775. different from the overall flow direction - bug 25135.
  7776. - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
  7777. - Full truncation on InlineBoxes in RTL flow - bug 24186
  7778. - Add tests for the above + reorder/cleanup tests for easier
  7779. interpretation of outcome.
  7780. The code for placing ellipsis has been refactored to use
  7781. left/right notation rather than a single variable whose meaning
  7782. could differ based on flow directionality.
  7783. To support differing inline directionality vs flow directionality,
  7784. different variables are now used in InlineTextBox::placeEllipsisBox to
  7785. track the two.
  7786. The drawing mode for underlines in standards mode now correctly handles
  7787. RTL truncation and relevant test where added.
  7788. https://bugs.webkit.org/show_bug.cgi?id=24186
  7789. https://bugs.webkit.org/show_bug.cgi?id=25135
  7790. https://bugs.webkit.org/show_bug.cgi?id=24206
  7791. Tests: fast/css/text-overflow-ellipsis-bidi.html
  7792. fast/css/text-overflow-ellipsis-strict.html
  7793. * rendering/InlineBox.cpp:
  7794. (WebCore::InlineBox::placeEllipsisBox):
  7795. * rendering/InlineBox.h:
  7796. * rendering/InlineFlowBox.cpp:
  7797. (WebCore::InlineFlowBox::paintTextDecorations):
  7798. (WebCore::InlineFlowBox::placeEllipsisBox):
  7799. * rendering/InlineFlowBox.h:
  7800. * rendering/InlineTextBox.cpp:
  7801. (WebCore::InlineTextBox::placeEllipsisBox):
  7802. (WebCore::InlineTextBox::paint):
  7803. * rendering/InlineTextBox.h:
  7804. * rendering/RenderFlexibleBox.cpp:
  7805. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  7806. * rendering/RootInlineBox.cpp:
  7807. (WebCore::RootInlineBox::placeEllipsis):
  7808. (WebCore::RootInlineBox::placeEllipsisBox):
  7809. * rendering/RootInlineBox.h:
  7810. * rendering/bidi.cpp:
  7811. (WebCore::RenderBlock::checkLinesForTextOverflow):
  7812. 2009-05-13 Dmitry Titov <dimich@chromium.org>
  7813. Rubber-stamped by Mark Rowe.
  7814. https://bugs.webkit.org/show_bug.cgi?id=25746
  7815. Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
  7816. * dom/XMLTokenizerLibxml2.cpp:
  7817. (WebCore::matchFunc):
  7818. (WebCore::openFunc):
  7819. (WebCore::createStringParser):
  7820. (WebCore::createMemoryParser):
  7821. * loader/icon/IconDatabase.cpp:
  7822. (WebCore::IconDatabase::open):
  7823. * platform/sql/SQLiteDatabase.cpp:
  7824. (WebCore::SQLiteDatabase::SQLiteDatabase):
  7825. (WebCore::SQLiteDatabase::close):
  7826. * storage/DatabaseThread.cpp:
  7827. (WebCore::DatabaseThread::DatabaseThread):
  7828. (WebCore::DatabaseThread::start):
  7829. (WebCore::DatabaseThread::databaseThread):
  7830. * storage/LocalStorageThread.cpp:
  7831. (WebCore::LocalStorageThread::LocalStorageThread):
  7832. (WebCore::LocalStorageThread::start):
  7833. (WebCore::LocalStorageThread::localStorageThread):
  7834. (WebCore::LocalStorageThread::scheduleImport):
  7835. (WebCore::LocalStorageThread::scheduleSync):
  7836. (WebCore::LocalStorageThread::terminate):
  7837. * workers/WorkerThread.cpp:
  7838. (WebCore::WorkerThread::WorkerThread):
  7839. (WebCore::WorkerThread::start):
  7840. 2009-05-13 David Hyatt <hyatt@apple.com>
  7841. Reviewed by Beth Dakin.
  7842. Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus
  7843. Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
  7844. (which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and
  7845. content.
  7846. Added fast/overflow/border-radius-clipping.html
  7847. * rendering/RenderBox.cpp:
  7848. (WebCore::RenderBox::pushContentsClip):
  7849. 2009-05-13 Darin Adler <darin@apple.com>
  7850. Revert the parser arena change. It was a slowdown, not a speedup.
  7851. Better luck next time (I'll break it up into pieces).
  7852. 2009-05-13 David Hyatt <hyatt@apple.com>
  7853. Reviewed by Beth Dakin and Darin Adler.
  7854. Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.
  7855. Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
  7856. to a non-self-painting layer (and vice versa).
  7857. Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
  7858. repaint properly on opacity changes, etc.
  7859. Added fast/repaint/opacity-change-on-overflow-float.html.
  7860. * rendering/RenderBox.cpp:
  7861. (WebCore::RenderBox::styleWillChange):
  7862. * rendering/RenderBoxModelObject.cpp:
  7863. (WebCore::RenderBoxModelObject::styleWillChange):
  7864. (WebCore::RenderBoxModelObject::styleDidChange):
  7865. * rendering/RenderBoxModelObject.h:
  7866. 2009-05-13 Dimitri Glazkov <dglazkov@chromium.org>
  7867. Not reviewed, build fix.
  7868. Move an include, needed by Debugger under the corresponding guard.
  7869. * inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER
  7870. guard.
  7871. 2009-05-13 David Levin <levin@chromium.org>
  7872. Reviewed by Darin Adler.
  7873. Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
  7874. https://bugs.webkit.org/show_bug.cgi?id=25394
  7875. Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html
  7876. * loader/SubresourceLoader.cpp:
  7877. (WebCore::SubresourceLoader::create):
  7878. Add another check to subresource loader to avoid doing any loads in frames
  7879. when the loaders are being stopped.
  7880. 2009-05-13 Stephan Haller <nomad@froevel.de>
  7881. Reviewed by Gustavo Noronha.
  7882. Wrong handling of file upload if no file selected
  7883. https://bugs.webkit.org/show_bug.cgi?id=25649
  7884. Fixed returned path if path is empty
  7885. * WebCore/platform/gtk/FileSystemGtk.cpp:
  7886. 2009-05-13 Dan Bernstein <mitz@apple.com>
  7887. Reviewed by Dave Hyatt.
  7888. - fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white
  7889. when loading
  7890. Tests: fast/frames/content-opacity-1.html
  7891. fast/frames/content-opacity-2.html
  7892. * page/FrameView.cpp:
  7893. (WebCore::FrameView::reset): Reset m_contentIsOpaque to false.
  7894. (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content
  7895. is not known to be opaque.
  7896. (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque
  7897. and enables or disables fast repaints accordingly.
  7898. * page/FrameView.h:
  7899. * rendering/RenderBoxModelObject.cpp:
  7900. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the
  7901. document()->haveStylesheetsLoaded() condition in determining whether the
  7902. root is opaque. This is what was causing the bug, as iframes were
  7903. considered to be opaque, and thus painted an opaque white background,
  7904. whenever they were pending a style sheet load.
  7905. Changed to call FrameView::setContentIsOpaqe() instead of
  7906. setUseSlowRepaints(), which allows the frame to go back to fast repaints
  7907. if the content becomes opaque.
  7908. Corrected the check for background color opacity: any alpha value other
  7909. than 255--not just zero--is not opaque.
  7910. 2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
  7911. Reviewed by Sam Weinig.
  7912. [Qt] Fix "lighther" composition mode.
  7913. QPainter::CompositionMode_Plus is the right match.
  7914. * platform/graphics/qt/GraphicsContextQt.cpp:
  7915. (WebCore::toQtCompositionMode):
  7916. 2009-05-13 Darin Adler <darin@apple.com>
  7917. Reviewed by Cameron Zwarich.
  7918. Bug 25674: syntax tree nodes should use arena allocation
  7919. https://bugs.webkit.org/show_bug.cgi?id=25674
  7920. * bindings/js/JSDOMBinding.h: Removed include of JSFunction.h.
  7921. We don't want the entire DOM binding to depend on that file.
  7922. * bindings/js/JSAudioConstructor.cpp: Added include of Error.h.
  7923. Before we inherited this automatically because JDDOMBinding.h
  7924. included JSFunction.h, but that was excessive.
  7925. * bindings/js/JSDOMWindowCustom.cpp: Ditto.
  7926. * bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
  7927. * bindings/js/JSImageConstructor.cpp: Ditto.
  7928. * bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
  7929. * bindings/js/JSMessageChannelConstructor.cpp: Ditto.
  7930. * bindings/js/JSOptionConstructor.cpp: Ditto.
  7931. * bindings/js/JSWorkerConstructor.cpp: Ditto.
  7932. * bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
  7933. * bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
  7934. * inspector/InspectorController.cpp: Ditto.
  7935. * inspector/JavaScriptDebugServer.cpp:
  7936. (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
  7937. Moved mose of this function into the base class in JavaScriptCore,
  7938. so the details of compilation don't have to be exposed.
  7939. 2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
  7940. Reviewed by Darin Adler.
  7941. <rdar://problem/6879145>
  7942. Generate a contextual menu item allowing autocorrections to
  7943. easily be changed back. Refrain from re-correcting items
  7944. that have already been autocorrected once.
  7945. * dom/DocumentMarker.h:
  7946. * editing/Editor.cpp:
  7947. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  7948. (WebCore::Editor::changeBackToReplacedString):
  7949. * editing/Editor.h:
  7950. * page/ContextMenuController.cpp:
  7951. (WebCore::ContextMenuController::contextMenuItemSelected):
  7952. * page/mac/WebCoreViewFactory.h:
  7953. * platform/ContextMenu.cpp:
  7954. (WebCore::ContextMenu::populate):
  7955. (WebCore::ContextMenu::checkOrEnableIfNeeded):
  7956. * platform/ContextMenuItem.h:
  7957. * platform/LocalizedStrings.h:
  7958. * platform/mac/LocalizedStringsMac.mm:
  7959. (WebCore::contextMenuItemTagChangeBack):
  7960. * rendering/HitTestResult.cpp:
  7961. (WebCore::HitTestResult::replacedString):
  7962. * rendering/HitTestResult.h:
  7963. * rendering/InlineTextBox.cpp:
  7964. (WebCore::InlineTextBox::computeRectForReplacementMarker):
  7965. (WebCore::InlineTextBox::paintDocumentMarkers):
  7966. * rendering/InlineTextBox.h:
  7967. 2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
  7968. Rubber Stamped by Oliver Hunt.
  7969. [GTK] Fix Gtk+/X11 build on OSX
  7970. Including the CoreFoundation header here and X11 headers
  7971. later will result in different definitions of Boolean. The
  7972. CoreFoundation include does not seem to be necessary here
  7973. and my mac build was successfull without it. I will remove
  7974. it for now. If the build bots disagree this will be replaced
  7975. by a #if PLATFORM(CF).
  7976. * platform/FileSystem.h:
  7977. 2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
  7978. Rubber Stamped by Gustavo Noronha.
  7979. [GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
  7980. When building Gtk+ on OSX we ended up declaring
  7981. setNPWindowIfNeeded twice. Fix that by moving
  7982. the #if PLATFORM(GTK) up and using elif instead of
  7983. else.
  7984. * plugins/PluginView.h:
  7985. 2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
  7986. Reviewed by Xan Lopez.
  7987. https://bugs.webkit.org/show_bug.cgi?id=25685
  7988. [GTK] Middle click paste form the pasteboard
  7989. The kit wants to paste from at least two different
  7990. clipboards. By introducing getCurrentTarget to the
  7991. PasteboardHelper interface we can make this decision
  7992. in the kit.
  7993. Use the new method in PasteboardGtk to get the right
  7994. GdkClipboard for the paste operation.
  7995. * platform/gtk/PasteboardGtk.cpp:
  7996. (WebCore::Pasteboard::documentFragment):
  7997. (WebCore::Pasteboard::plainText):
  7998. * platform/gtk/PasteboardHelper.h:
  7999. 2009-05-13 Eric Carlson <eric.carlson@apple.com>
  8000. Reviewed by Darin Adler.
  8001. <rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
  8002. <rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard
  8003. QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
  8004. on Tiger or Leopard.
  8005. * html/HTMLMediaElement.cpp:
  8006. (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
  8007. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  8008. (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute
  8009. when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD.
  8010. (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute
  8011. when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
  8012. 2009-05-12 Roland Steiner <rolandsteiner@google.com>
  8013. Reviewed by Eric Seidel.
  8014. Bug 25738: Skia: CSS border style not cleared for SVG object
  8015. https://bugs.webkit.org/show_bug.cgi?id=25738
  8016. If no dashing is set, this change reverts to solid stroke
  8017. (previously the code bailed and left the old setting, whatever it was)
  8018. Test case listed in above bug entry.
  8019. (Additional complications due to each platform rendering dotted lines differently -
  8020. c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)
  8021. * platform/graphics/skia/GraphicsContextSkia.cpp:
  8022. (WebCore::GraphicsContext::setLineDash):
  8023. 2009-05-11 Erik Arvidsson <arv@chromium.org>
  8024. Reviewed by Eric Seidel.
  8025. Bug 21903: Adds DOM bindings for the placeholder property of the
  8026. HTMLInputElement.
  8027. https://bugs.webkit.org/show_bug.cgi?id=21903
  8028. Test: fast/forms/placeholder-dom-property.html
  8029. * dom/InputElement.cpp:
  8030. (WebCore::InputElement::updatePlaceholderVisibility):
  8031. * dom/InputElement.h:
  8032. * html/HTMLInputElement.cpp:
  8033. (WebCore::HTMLInputElement::placeholder):
  8034. (WebCore::HTMLInputElement::setPlaceholder):
  8035. * html/HTMLInputElement.h:
  8036. * html/HTMLInputElement.idl:
  8037. * rendering/RenderTextControlSingleLine.cpp:
  8038. (WebCore::RenderTextControlSingleLine::updateFromElement):
  8039. * wml/WMLInputElement.h:
  8040. (WebCore::WMLInputElement::placeholder):
  8041. (WebCore::WMLInputElement::setPlaceholder):
  8042. 2009-05-12 Adam Barth <abarth@webkit.org>
  8043. Reviewed by Dimitri Glazkov.
  8044. https://bugs.webkit.org/show_bug.cgi?id=25706
  8045. Change V8 bindings to match JSC bindings with respect to using
  8046. the lexical or dynamic global object.
  8047. Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
  8048. http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
  8049. http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
  8050. * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  8051. (WebCore::CALLBACK_FUNC_DECL):
  8052. 2009-03-19 Oliver Hunt <oliver@apple.com>
  8053. Reviewed by Darin Adler.
  8054. <rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore
  8055. SVGList::insertItemBefore would not perform a bounds check on the
  8056. index it was provided, potentially leading to a buffer overflow.
  8057. Test: svg/dom/svglist-exception-on-out-bounds-error.html
  8058. * svg/SVGList.h:
  8059. (WebCore::SVGList::insertItemBefore):
  8060. 2009-05-12 Paul Godavari <paul@chromium.org>
  8061. Reviewed by Dimitri Glazkov.
  8062. Bug 25708: Cannot choose menu items in popups with many entries in Chromium
  8063. https://bugs.webkit.org/show_bug.cgi?id=25708
  8064. This change sets the window size for popups on Mac to include all items
  8065. in the menu. This is required for hit testing on Mac, where we use native
  8066. controls to manage the popups and don't want to artificially limit the
  8067. valid hit testing region to a limited scroll window.
  8068. * platform/chromium/PopupMenuChromium.cpp:
  8069. (WebCore::PopupListBox::layout):
  8070. 2009-05-12 Stephen White <senorblanco@chromium.org>
  8071. Reviewed by Dimitri Glazkov.
  8072. Fixes to build with latest skia: SkTypeface::Create() is now
  8073. SkTypeface::CreateFromName(); computeBounds() has been reworked
  8074. as getBounds(). The changes are placed behind an #ifdef for now,
  8075. so that we can roll back the skia version in Chromium if necessary
  8076. without having to roll back this change.
  8077. https://bugs.webkit.org/show_bug.cgi?id=25705
  8078. * platform/graphics/chromium/FontCacheLinux.cpp:
  8079. (WebCore::FontCache::createFontPlatformData):
  8080. * platform/graphics/skia/PathSkia.cpp:
  8081. (WebCore::Path::boundingRect):
  8082. (WebCore::boundingBoxForCurrentStroke):
  8083. * platform/graphics/skia/SkiaUtils.cpp:
  8084. (WebCore::SkPathContainsPoint):
  8085. 2009-05-12 Nate Chapin <japhet@google.com>
  8086. Reviewed by Dimitri Glazkov.
  8087. https://bugs.webkit.org/show_bug.cgi?id=25732
  8088. Update V8ElementCustom.cpp to match the current API of V8Proxy.
  8089. (WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().
  8090. 2009-05-12 Alexey Proskuryakov <ap@webkit.org>
  8091. Reviewed by Darin Adler.
  8092. https://bugs.webkit.org/show_bug.cgi?id=25694
  8093. HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
  8094. to the document NULL ptr
  8095. Test: fast/parser/implicit-head-in-fragment-crash.html
  8096. * html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly
  8097. create <head> when parsing a fragment.
  8098. 2009-05-12 Soren Gjesse <sgjesse@chromium.org>
  8099. Reviewed by Dimitri Glazkov.
  8100. https://bugs.webkit.org/show_bug.cgi?id=25687
  8101. Missing check for valid function in V8 bindings for toString function for event listeners.
  8102. * bindings/v8/V8LazyEventListener.cpp:
  8103. (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
  8104. 2009-05-11 Yael Aharon <yael.aharon@nokia.com>
  8105. Reviewed by Holger Freyther.
  8106. Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
  8107. Not doing that can cause assersion failure.
  8108. https://bugs.webkit.org/show_bug.cgi?id=25702
  8109. * plugins/qt/PluginViewQt.cpp:
  8110. (WebCore::PluginView::stop):
  8111. 2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  8112. Reviewed by Holger Freyther.
  8113. Bug 25714: [Qt] Decouple HTML5 Database support from the
  8114. SQLite/generic database support in the Qt port
  8115. <https://bugs.webkit.org/show_bug.cgi?id=25714>
  8116. * WebCore.pro:
  8117. 2009-05-11 Chris Fleizach <cfleizach@apple.com>
  8118. Reviewed by Beth Dakin.
  8119. Bug 25713: AX: Control Elements not identified in HTML content
  8120. https://bugs.webkit.org/show_bug.cgi?id=25713
  8121. Test: accessibility/onclick-handlers.html
  8122. * page/AccessibilityRenderObject.cpp:
  8123. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  8124. 2009-05-11 Darin Adler <darin@apple.com>
  8125. Reviewed by Dan Bernstein.
  8126. <rdar://problem/6276843> REGRESSION: TextIterator generates
  8127. an extra newline for ranges that start outside of body
  8128. * editing/TextIterator.cpp:
  8129. (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  8130. Check startPos for null, not just currPos.
  8131. 2009-05-11 Chris Fleizach <cfleizach@apple.com>
  8132. Reviewed by Darin Adler.
  8133. Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
  8134. https://bugs.webkit.org/show_bug.cgi?id=25700
  8135. Keyboard selection movement handlers need to also watch for the Cmd key when Accessibility is enabled.
  8136. Note: This code is only used when accessibility is enabled.
  8137. * page/EventHandler.cpp:
  8138. (WebCore::EventHandler::handleKeyboardSelectionMovement):
  8139. 2009-05-11 David Kilzer <ddkilzer@apple.com>
  8140. Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
  8141. <https://bugs.webkit.org/show_bug.cgi?id=25087>
  8142. Reviewed by Timothy Hatcher.
  8143. Change tests for ENABLE macros to check for both existence and
  8144. value:
  8145. - Negative: #if !defined(ENABLE_FOO) || !ENABLE_FOO
  8146. - Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
  8147. * css/CSSCharsetRule.idl:
  8148. * css/CSSPrimitiveValue.idl:
  8149. * css/RGBColor.idl:
  8150. * dom/Attr.idl:
  8151. * dom/DOMCoreException.idl:
  8152. * dom/DOMImplementation.idl:
  8153. * dom/Document.idl:
  8154. * dom/Element.idl:
  8155. * dom/Event.idl:
  8156. * dom/EventException.idl:
  8157. * dom/KeyboardEvent.idl:
  8158. * dom/MessagePort.idl:
  8159. * dom/MouseEvent.idl:
  8160. * dom/Node.idl:
  8161. * dom/ProcessingInstruction.idl:
  8162. * dom/Range.idl:
  8163. * dom/RangeException.idl:
  8164. * dom/WheelEvent.idl:
  8165. * html/CanvasPixelArray.idl:
  8166. * html/HTMLAnchorElement.idl:
  8167. * html/HTMLAppletElement.idl:
  8168. * html/HTMLAreaElement.idl:
  8169. * html/HTMLBaseFontElement.idl:
  8170. * html/HTMLCanvasElement.idl:
  8171. * html/HTMLDocument.idl:
  8172. * html/HTMLElement.idl:
  8173. * html/HTMLEmbedElement.idl:
  8174. * html/HTMLFrameElement.idl:
  8175. * html/HTMLIFrameElement.idl:
  8176. * html/HTMLImageElement.idl:
  8177. * html/HTMLInputElement.idl:
  8178. * html/HTMLLinkElement.idl:
  8179. * html/HTMLObjectElement.idl:
  8180. * html/HTMLOptionElement.idl:
  8181. * html/HTMLOptionsCollection.idl:
  8182. * html/HTMLSelectElement.idl:
  8183. * html/HTMLStyleElement.idl:
  8184. * html/ImageData.idl:
  8185. * inspector/InspectorController.idl:
  8186. * loader/appcache/DOMApplicationCache.idl:
  8187. * page/Console.idl:
  8188. * page/Coordinates.idl:
  8189. * page/DOMSelection.idl:
  8190. * page/DOMWindow.idl:
  8191. * page/Geoposition.idl:
  8192. * page/History.idl:
  8193. * page/Location.idl:
  8194. * page/Navigator.idl:
  8195. * svg/SVGElementInstance.idl:
  8196. * svg/SVGException.idl:
  8197. * workers/WorkerContext.idl:
  8198. * xml/XMLHttpRequestException.idl:
  8199. * xml/XPathException.idl:
  8200. 2009-05-11 Norbert Leser <norbert.leser@nokia.com>
  8201. Reviewed by Darin Adler.
  8202. Bug 24538: class/struct mixup in forward declarations
  8203. https://bugs.webkit.org/show_bug.cgi?id=24538
  8204. * inspector/InspectorResource.h:
  8205. * loader/CachedFont.h:
  8206. * loader/appcache/ApplicationCache.h:
  8207. * rendering/RenderBlock.h:
  8208. * rendering/RootInlineBox.h:
  8209. * rendering/SVGInlineTextBox.h:
  8210. * svg/SVGGlyphElement.h:
  8211. * svg/SVGHKernElement.h:
  8212. 2009-05-11 Norbert Leser <norbert.leser@nokia.com>
  8213. Reviewed by Darin Adler.
  8214. Bug 24539: Unresolved CSSMutableStyleDeclaration
  8215. https://bugs.webkit.org/show_bug.cgi?id=24539
  8216. The Symbian tools can't compile and link this without this include.
  8217. It's not clear why this is different from other toolsets or why it affects
  8218. only this header file, but adding the include for now.
  8219. * editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
  8220. 2009-05-11 Alice Liu <alice.liu@apple.com>
  8221. Reviewed by Dan Bernstein.
  8222. https://bugs.webkit.org/show_bug.cgi?id=25701
  8223. REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
  8224. Test: fast/forms/search-styled.html
  8225. * css/themeWin.css:
  8226. Remove the overriding of -webkit-appearance for searchfields. This will cause background
  8227. images to not be honored when styling searchfields
  8228. * rendering/RenderThemeWin.cpp:
  8229. (WebCore::RenderThemeWin::adjustSearchFieldStyle):
  8230. * rendering/RenderThemeWin.h:
  8231. Re-instate final adjustments to searchfield styling that were removed in r42020
  8232. 2009-05-11 Brady Eidson <beidson@apple.com>
  8233. Fix Windows build
  8234. * platform/network/cf/ResourceHandleCFNet.cpp:
  8235. (WebCore::createCFURLResponseWithDefaultMIMEType):
  8236. 2009-05-11 Nate Chapin <japhet@google.com>
  8237. Reviewed by Dimitri Glazkov.
  8238. https://bugs.webkit.org/show_bug.cgi?id=25626
  8239. Update V8ElementCustom.cpp to match the current API of Node.
  8240. * bindings/v8/custom/V8ElementCustom.cpp:
  8241. (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names.
  8242. (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
  8243. 2009-05-11 Brady Eidson <beidson@apple.com>
  8244. Fix Windows build
  8245. * platform/network/cf/ResourceHandleCFNet.cpp:
  8246. (WebCore::createCFURLResponseWithDefaultMIMEType):
  8247. (WebCore::WebCoreSynchronousLoader::load):
  8248. 2009-05-11 Brady Eidson <beidson@apple.com>
  8249. Fix Windows build
  8250. * platform/network/cf/ResourceHandleCFNet.cpp:
  8251. (WebCore::createCFURLResponseWithDefaultMIMEType):
  8252. 2009-05-11 Nate Chapin <japhet@google.com>
  8253. Reviewed by Dimitri Glazkov.
  8254. V8CustomBinding.cpp is missing a header file
  8255. https://bugs.webkit.org/show_bug.cgi?id=25644
  8256. * bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
  8257. 2009-05-11 Aaron Boodman <aa@chromium.org>
  8258. Reviewed by Darin Fisher.
  8259. https://bugs.webkit.org/show_bug.cgi?id=25634
  8260. Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().
  8261. Also, change instances of ScriptController::retrieveActiveFrame() to
  8262. V8::retrieveFrameForEnteredContext() for consistency.
  8263. See http://codereview.chromium.org/113085 for the corresponding Chromium change.
  8264. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  8265. (WebCore::V8Custom::WindowSetLocation):
  8266. * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  8267. (WebCore::CALLBACK_FUNC_DECL):
  8268. * bindings/v8/custom/V8LocationCustom.cpp:
  8269. (WebCore::navigateIfAllowed):
  8270. (WebCore::ACCESSOR_SETTER):
  8271. (WebCore::CALLBACK_FUNC_DECL):
  8272. 2009-05-11 Brady Eidson <beidson@apple.com>
  8273. Reviewed by Darin Adler.
  8274. <rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.
  8275. First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
  8276. Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".
  8277. * platform/MIMETypeRegistry.cpp:
  8278. (WebCore::defaultMIMEType): "application/octet-stream"
  8279. * platform/MIMETypeRegistry.h:
  8280. * platform/network/ResourceHandle.cpp:
  8281. (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which
  8282. might override it to false.
  8283. (WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
  8284. * platform/network/ResourceHandle.h:
  8285. * platform/network/cf/ResourceHandleCFNet.cpp:
  8286. (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead
  8287. of null.
  8288. (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type.
  8289. (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same
  8290. sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
  8291. * platform/network/mac/ResourceHandleMac.mm:
  8292. (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the
  8293. same sniffing policy as asynchronous loads.
  8294. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if
  8295. it hasn't been set up yet.
  8296. (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
  8297. * xml/XMLHttpRequest.cpp:
  8298. (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by
  8299. the new mechanism.
  8300. 2009-05-11 David Kilzer <ddkilzer@apple.com>
  8301. Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"
  8302. This was added in r39816 to disable dynamic entries. They are
  8303. still disabled after fixing the typo since this feature define
  8304. is never set anywhere.
  8305. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  8306. * loader/appcache/DOMApplicationCache.idl:
  8307. 2009-05-11 Dmitry Titov <dimich@chromium.org>
  8308. Reviewed by Alexey Proskuryakov and Adam Roben.
  8309. https://bugs.webkit.org/show_bug.cgi?id=25348
  8310. Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
  8311. Most of the change is in WTF.
  8312. Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
  8313. method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
  8314. is now a class rather then an integer.
  8315. Also, there is no need to initialize threadID in constructors to 0 now.
  8316. * dom/XMLTokenizerLibxml2.cpp:
  8317. (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
  8318. since now ThreadIdentifier needs construction and we avoid having global initializers.
  8319. (WebCore::matchFunc): use the new accessor function.
  8320. (WebCore::openFunc): ditto.
  8321. (WebCore::createStringParser): ditto.
  8322. (WebCore::createMemoryParser): ditto.
  8323. * loader/icon/IconDatabase.cpp:
  8324. (WebCore::IconDatabase::open):
  8325. * platform/sql/SQLiteDatabase.cpp:
  8326. (WebCore::SQLiteDatabase::SQLiteDatabase):
  8327. (WebCore::SQLiteDatabase::close):
  8328. * storage/DatabaseThread.cpp:
  8329. (WebCore::DatabaseThread::start):
  8330. (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
  8331. * storage/LocalStorageThread.cpp:
  8332. (WebCore::LocalStorageThread::start):
  8333. (WebCore::LocalStorageThread::scheduleImport):
  8334. (WebCore::LocalStorageThread::scheduleSync):
  8335. (WebCore::LocalStorageThread::terminate):
  8336. * workers/WorkerThread.cpp:
  8337. (WebCore::WorkerThread::start):
  8338. (WebCore::WorkerThread::WorkerThread):
  8339. (WebCore::WorkerThread::start):
  8340. 2009-05-11 Brady Eidson <beidson@apple.com>
  8341. Reviewed by Darin Adler.
  8342. Remove unused header that declared one function which was never defined anywhere.
  8343. * WebCore.vcproj/WebCore.vcproj:
  8344. * platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means
  8345. platform/network/cf/ResourceResponse.h)
  8346. * platform/network/cf/ResourceResponseCFNet.h: Removed.
  8347. 2009-05-11 Dimitri Glazkov <dglazkov@chromium.org>
  8348. Reviewed by Timothy Hatcher.
  8349. https://bugs.webkit.org/show_bug.cgi?id=25213
  8350. Fix assert during Inspector destruction.
  8351. * inspector/InspectorController.cpp:
  8352. (WebCore::InspectorController::inspectedPageDestroyed): Moved closing
  8353. inspector above removing InspectorController object to fix JS errors,
  8354. added clearing inspector page ptr.
  8355. 2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  8356. Reviewed by Holger Freyther.
  8357. [Qt] Make sure that public APIs are properly exported on all Qt platforms
  8358. https://bugs.webkit.org/show_bug.cgi?id=25601
  8359. * WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win
  8360. 2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
  8361. Reviewed by Holger Freyther.
  8362. https://bugs.webkit.org/show_bug.cgi?id=24284
  8363. * WebCore.pro: duplicated values removed from INCLUDEPATH
  8364. 2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  8365. Reviewed by Eric Seidel.
  8366. Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
  8367. https://bugs.webkit.org/show_bug.cgi?id=24688
  8368. * WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
  8369. * platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
  8370. 2009-05-10 Dan Bernstein <mitz@apple.com>
  8371. Reviewed by Darin Adler.
  8372. - fix a crash when deactivating a document that had adopted a <form>
  8373. element
  8374. Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html
  8375. * html/HTMLFormElement.cpp:
  8376. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the
  8377. logic here: <form> elements should be registered for document activation
  8378. callbacks if and only if autocomplete is off.
  8379. 2009-05-10 Alexey Proskuryakov <ap@webkit.org>
  8380. Reviewed by Dan Bernstein.
  8381. <rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
  8382. to view protected MobileMe video
  8383. Add a temporary workaround.
  8384. * platform/network/ResourceHandleInternal.h:
  8385. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  8386. Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when
  8387. starting a request, so we need to store this data for later use.
  8388. * platform/network/mac/ResourceHandleMac.mm:
  8389. (WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks.
  8390. (WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.
  8391. 2009-05-10 Alexey Proskuryakov <ap@webkit.org>
  8392. Reviewed by Dan Bernstein.
  8393. <rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page
  8394. * platform/network/cf/AuthenticationCF.cpp:
  8395. * platform/network/cf/AuthenticationCF.h:
  8396. (WebCore::WebCoreCredentialStorage::set):
  8397. (WebCore::WebCoreCredentialStorage::get):
  8398. * platform/network/cf/ResourceHandleCFNet.cpp:
  8399. Move WebCore credential storage to AuthenticationCF, so that WebKit could use it (macthing
  8400. an earlier Mac change).
  8401. 2009-05-10 Alexey Proskuryakov <ap@webkit.org>
  8402. Reviewed by Dan Bernstein.
  8403. Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
  8404. called at a wrong time.
  8405. No test, because we are waiting for a newer version of system frameworks to test the attribute.
  8406. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
  8407. * xml/XMLHttpRequest.h:
  8408. * xml/XMLHttpRequest.idl:
  8409. Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.
  8410. 2009-05-10 Dan Bernstein <mitz@apple.com>
  8411. Reviewed by Dave Kilzer.
  8412. - fix https://bugs.webkit.org/show_bug.cgi?id=25602
  8413. REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
  8414. on ToT
  8415. Test: fast/layers/self-painting-outline.html
  8416. * rendering/RenderLayer.cpp:
  8417. (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only
  8418. if it is a self-painting layer.
  8419. 2009-05-09 Dan Bernstein <mitz@apple.com>
  8420. Reviewed by Geoffrey Garen and Mark Rowe.
  8421. - fix https://bugs.webkit.org/show_bug.cgi?id=25666
  8422. Assertion failure in Node::setDocument()
  8423. (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
  8424. Test: fast/dom/HTMLFormElement/adopt-assertion.html
  8425. * html/HTMLFormElement.cpp:
  8426. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of
  8427. this method are required to call the base class implementation. Do it.
  8428. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
  8429. 2009-03-29 Kevin Ollivier <kevino@theolliviers.com>
  8430. Reviewed by Maciej Stachowiak.
  8431. WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), so
  8432. make sure CURL does not create empty ResourceError() objects.
  8433. https://bugs.webkit.org/show_bug.cgi?id=24927
  8434. * platform/network/curl/ResourceHandleManager.cpp:
  8435. (WebCore::ResourceHandleManager::downloadTimerCallback):
  8436. 2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
  8437. Build fix, adding missing files to make dist.
  8438. * GNUmakefile.am:
  8439. 2009-05-08 Simon Fraser <simon.fraser@apple.com>
  8440. Reviewed by Dan Bernstein
  8441. https://bugs.webkit.org/show_bug.cgi?id=25656
  8442. Reduce the inline capacity of CSSParserValueList's m_values
  8443. vector to reduce the size of CSSParserValueList from 544 to 160 bytes in 64-bit.
  8444. * css/CSSParserValues.h:
  8445. 2009-05-08 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  8446. Not reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn't been done for a while.
  8447. * WebCore.xcodeproj/project.pbxproj:
  8448. 2009-05-08 Dan Bernstein <mitz@apple.com>
  8449. Reviewed by Darin Adler.
  8450. - fix <rdar://problem/6864786> REGRESSION: Crash below
  8451. ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in
  8452. Bugzilla
  8453. Test: editing/style/apply-through-end-of-document.html
  8454. * editing/ApplyStyleCommand.cpp:
  8455. (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null
  8456. check for the case of a range extending through the end of the document,
  8457. in which pastEndNode is 0.
  8458. 2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
  8459. Reviewed by Beth Dakin.
  8460. <rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
  8461. marked as misspelled even though contraction is a word
  8462. Make sure spelling underline does not persist on words like
  8463. <doesn't>.
  8464. * editing/TypingCommand.cpp:
  8465. (WebCore::TypingCommand::typingAddedToOpenCommand):
  8466. 2009-05-08 Kevin Watters <kevinwatters@gmail.com>
  8467. Reviewed by Kevin Ollivier.
  8468. Make sure the path's refdata isn't deleted before we're done with the object.
  8469. https://bugs.webkit.org/show_bug.cgi?id=25652
  8470. * platform/graphics/wx/PathWx.cpp:
  8471. (WebCore::Path::~Path):
  8472. (WebCore::Path::Path):
  8473. (WebCore::Path::translate):
  8474. 2009-05-08 Kevin Watters <kevinwatters@gmail.com>
  8475. Reviewed by Darin Adler.
  8476. Fix for memory leak on Mac.
  8477. https://bugs.webkit.org/show_bug.cgi?id=25650
  8478. * platform/wx/wxcode/mac/carbon/fontprops.cpp:
  8479. (wxFontProperties::wxFontProperties):
  8480. 2009-05-08 Beth Dakin <bdakin@apple.com>
  8481. Reviewed by Dan Bernstein.
  8482. <rdar://problem/6857446> REGRESSION (r37591): Cannot print or
  8483. preview from maps.yandex.ru
  8484. We need to fall into the stretchesToViewHeight() quirk when we are
  8485. printing and we are the root and the root has percentage height OR
  8486. when we are the body and the root has percentage height. Otherwise
  8487. we have a height of 0 and can run into painting troubles.
  8488. * rendering/RenderBox.cpp:
  8489. (WebCore::RenderBox::calcHeight):
  8490. 2009-05-08 Douglas Davidson <ddavidso@apple.com>
  8491. Reviewed by Darin Adler.
  8492. Fixes for <rdar://problem/6852771>.
  8493. Prevent text checking replacement immediately after an apostrophe
  8494. and automatic link addition except immediately after typing.
  8495. * editing/Editor.cpp:
  8496. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  8497. 2009-05-08 Eric Carlson <eric.carlson@apple.com>
  8498. Reviewed by Darin Adler.
  8499. https://bugs.webkit.org/show_bug.cgi?id=25627
  8500. Bug 25627: HTMLMediaElement: some errors should fire on <source> elements
  8501. Update for HTML5 spec change to fire 'error' events on <source> element
  8502. when there is a failure while processing/loading a <source>.
  8503. Test: media/video-source-error.html
  8504. * html/HTMLMediaElement.cpp:
  8505. (WebCore::HTMLMediaElement::enqueueEvent): Remove white-space.
  8506. (WebCore::HTMLMediaElement::loadInternal): Call cancelPendingEventsAndCallbacks instead
  8507. of just calling m_pendingEvents.clear() as we now also need to cancel pending errors on
  8508. all <source> element.
  8509. (WebCore::HTMLMediaElement::selectMediaResource): Call isSafeToLoadURL() here instead of in
  8510. loadResource() as we need to report errors differently depending on the type of failure. Use
  8511. KURL instead of String.
  8512. (WebCore::HTMLMediaElement::loadNextSourceChild): nextSourceChild -> selectNextSourceChild.
  8513. Fail silently when there are no more <source> canditates because that is what spec mandates.
  8514. Keep url as KURL instead of converting to String.
  8515. (WebCore::HTMLMediaElement::loadResource): ASSERT that the URL is safe to load as we now
  8516. assume the safety check now done before this function. Takes KURL instead of String.
  8517. (WebCore::HTMLMediaElement::isSafeToLoadURL): New, checks to see if a url is safe to load, logs
  8518. failure if not.
  8519. (WebCore::HTMLMediaElement::noneSupported): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
  8520. (WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): New, clear all events pending on
  8521. the media and all source elements.
  8522. (WebCore::HTMLMediaElement::setNetworkState): Fire an error on the source element when the
  8523. the failure happened while processing one. Only call nonSupported() when the failure happened
  8524. while processing media element 'src' attribute.
  8525. (WebCore::HTMLMediaElement::havePotentialSourceChild): nextSourceChild -> selectNextSourceChild.
  8526. Deal with selectNextSourceChild returning a KURL instead of a String.
  8527. (WebCore::HTMLMediaElement::selectNextSourceChild): Renamed from nextSourceChild, add optional
  8528. param to control whether or not errors are fired on a source element when it will not be used.
  8529. Check safety of url here instead of waiting until loadResource(). Return a KURL instead of a
  8530. String.
  8531. (WebCore::HTMLMediaElement::initialURL): nextSourceChild -> selectNextSourceChild. Keep url as
  8532. a KURL instead of a String.
  8533. * html/HTMLMediaElement.h:
  8534. (WebCore::HTMLMediaElement::):
  8535. * html/HTMLSourceElement.cpp:
  8536. (WebCore::HTMLSourceElement::HTMLSourceElement): Initialize timer related variables.
  8537. (WebCore::HTMLSourceElement::scheduleErrorEvent): New, start one-shot timer to fire an error
  8538. event ASAP.
  8539. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): New, cancel pending error event.
  8540. (WebCore::HTMLSourceElement::errorEventTimerFired): New, fire error event if it has not been
  8541. cancelled.
  8542. * html/HTMLSourceElement.h:
  8543. * html/MediaError.h:
  8544. (WebCore::MediaError::): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
  8545. * html/MediaError.idl: Ditto
  8546. 2009-05-08 Dan Bernstein <mitz@apple.com>
  8547. Reviewed by Maciej Stachowiak.
  8548. - fix <rdar://problem/6859955> Undoing typed text after selecting all
  8549. leaves non-text areas highlighted
  8550. Test: fast/repaint/selection-clear.html
  8551. When RenderView::clearSelection() is called from
  8552. SelectionController::nodeWillBeRemoved(), selected renderers may already
  8553. be marked for layout, which means that they can no longer compute
  8554. their selection repaint info. Instead, an empty IntRect (or GapRects) is
  8555. returned, leading to incomplete repaint.
  8556. The fix is not to rely on individual renderers when clearing the
  8557. selection, but instead, cache the bounding rectangle of the selected
  8558. blocks' GapRects when setting the selection, and invalidate that
  8559. entire rectangle when clearing it.
  8560. * rendering/RenderView.cpp:
  8561. (WebCore::RenderView::setSelection): Added a parameter saying whether
  8562. the repainting of selected blocks should include both
  8563. previously-selected areas and newly-selected areas or only
  8564. newly-selected areas. The default is both. Also compute
  8565. m_cachedSelectionBounds to be the bounding rectangle of the
  8566. new selection's BlockSelectionInfos' GapRects.
  8567. (WebCore::RenderView::clearSelection): Repaint m_cachedSelectionBounds,
  8568. and tell setSelection() that it should not paint areas that were in
  8569. the old selection's BlockSelectionInfos' GapRects.
  8570. * rendering/RenderView.h:
  8571. (WebCore::RenderView::):
  8572. 2009-05-08 Alexey Proskuryakov <ap@webkit.org>
  8573. Reviewed by Maciej Stachowiak.
  8574. <rdar://problem/6868773> NPN_GetAuthenticationInfo does not work with non-permanent credentials
  8575. * WebCore.base.exp:
  8576. * platform/network/mac/AuthenticationMac.h:
  8577. (WebCore::WebCoreCredentialStorage::set):
  8578. (WebCore::WebCoreCredentialStorage::get):
  8579. * platform/network/mac/AuthenticationMac.mm:
  8580. * platform/network/mac/ResourceHandleMac.mm:
  8581. Moved WebCoreCredentialStorage to AuthenticationMac, so that it could be used from WebKit.
  8582. 2009-05-08 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
  8583. Reviewed by Simon Hausmann.
  8584. Fix the Qt build, add missing JSC_HOST_CALL macros to the runtime
  8585. call methods.
  8586. * bridge/qt/qt_runtime.h:
  8587. 2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
  8588. Reviewed by Mark Rowe.
  8589. Add missing strings to localizedStrings.js
  8590. https://bugs.webkit.org/show_bug.cgi?id=25635
  8591. Add the strings "Delete", "Key", "Refresh" and "Value".
  8592. * English.lproj/localizedStrings.js:
  8593. 2009-05-08 Robert Hogan <robert@roberthogan.net>
  8594. Reviewed, tweaked and landed by Alexey Proskuryakov.
  8595. https://bugs.webkit.org/show_bug.cgi?id=24992
  8596. [Qt] crash at http://browserspy.dk/browser.php
  8597. This cannot be easily tested in DRT, because it relies on interaction with QApplication,
  8598. but the added assertions guard against re-introducing this issue.
  8599. * loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Don't make client calls
  8600. while the frame is being constructed, because the intermediate state without a document
  8601. is something we don't want to expose.
  8602. * page/Frame.cpp:
  8603. (WebCore::Frame::setJSStatusBarText): Assert that the frame has a document, which is an
  8604. approximation of it being in a consistent state for client calls.
  8605. (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
  8606. 2009-05-07 Mark Rowe <mrowe@apple.com>
  8607. Rubber-stamped by Oliver Hunt.
  8608. Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
  8609. Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
  8610. Roll out r43366 as it removed symbols that Safari 4 Beta uses.
  8611. * dom/XMLTokenizerLibxml2.cpp:
  8612. (WebCore::matchFunc):
  8613. (WebCore::openFunc):
  8614. (WebCore::createStringParser):
  8615. (WebCore::createMemoryParser):
  8616. * loader/icon/IconDatabase.cpp:
  8617. (WebCore::IconDatabase::open):
  8618. * platform/sql/SQLiteDatabase.cpp:
  8619. (WebCore::SQLiteDatabase::SQLiteDatabase):
  8620. (WebCore::SQLiteDatabase::close):
  8621. * storage/DatabaseThread.cpp:
  8622. (WebCore::DatabaseThread::DatabaseThread):
  8623. (WebCore::DatabaseThread::start):
  8624. (WebCore::DatabaseThread::databaseThread):
  8625. * storage/LocalStorageThread.cpp:
  8626. (WebCore::LocalStorageThread::LocalStorageThread):
  8627. (WebCore::LocalStorageThread::start):
  8628. (WebCore::LocalStorageThread::localStorageThread):
  8629. (WebCore::LocalStorageThread::scheduleImport):
  8630. (WebCore::LocalStorageThread::scheduleSync):
  8631. (WebCore::LocalStorageThread::terminate):
  8632. * workers/WorkerThread.cpp:
  8633. (WebCore::WorkerThread::WorkerThread):
  8634. (WebCore::WorkerThread::start):
  8635. 2009-05-08 Xan Lopez <xlopez@igalia.com>
  8636. Reviewed by Gustavo Noronha.
  8637. Unify scrolling code via adjustments and keys. Use the WebCore
  8638. defined constants, since that's what people are most used to at
  8639. this point.
  8640. * platform/gtk/ScrollViewGtk.cpp:
  8641. (WebCore::ScrollView::platformHandleHorizontalAdjustment):
  8642. (WebCore::ScrollView::platformHandleVerticalAdjustment):
  8643. 2009-05-07 David Levin <levin@chromium.org>
  8644. Reviewed by NOBODY.
  8645. Suggested by Oliver Hunt.
  8646. Rolling back http://trac.webkit.org/changeset/43385
  8647. because we have to use mac artwork for the underline on OSX.
  8648. * platform/graphics/cg/GraphicsContextCG.cpp:
  8649. * platform/graphics/mac/GraphicsContextMac.mm:
  8650. (WebCore::createPatternColor):
  8651. (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  8652. * platform/graphics/win/GraphicsContextCGWin.cpp:
  8653. (WebCore::setCGStrokeColor):
  8654. (WebCore::spellingPatternColor):
  8655. (WebCore::grammarPatternColor):
  8656. (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  8657. 2009-05-07 John Grabowski <jrg@chromium.org>
  8658. Reviewed by Simon Fraser.
  8659. https://bugs.webkit.org/show_bug.cgi?id=25573
  8660. Unify use of CG-common routine for drawLineForMisspellingOrBadGrammar.
  8661. Cleanup for WebKit, but required for Chromium happiness.
  8662. * platform/graphics/cg/GraphicsContextCG.cpp:
  8663. (WebCore::spellingPatternColor):
  8664. (WebCore::grammarPatternColor):
  8665. (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  8666. * platform/graphics/mac/GraphicsContextMac.mm:
  8667. * platform/graphics/win/GraphicsContextCGWin.cpp:
  8668. 2009-05-07 Darin Adler <darin@apple.com>
  8669. Reviewed by Simon Fraser.
  8670. Bug 25575: Registered mutation event listener crashes HTMLMediaElement
  8671. https://bugs.webkit.org/show_bug.cgi?id=25575
  8672. Test: fast/media/video-controls-with-mutation-event-handler.html
  8673. * rendering/MediaControlElements.cpp:
  8674. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Don't call setAttribute.
  8675. * rendering/RenderMedia.cpp:
  8676. (WebCore::RenderMedia::createTimeline): Call setAttribute here.
  8677. 2009-05-07 Simon Fraser <simon.fraser@apple.com>
  8678. Rubber Stamped by Dave Hyatt
  8679. Shuffle the data members to minimize padding.
  8680. * rendering/RenderTableSection.cpp:
  8681. (WebCore::RenderTableSection::RenderTableSection):
  8682. * rendering/RenderTableSection.h:
  8683. 2009-05-07 Simon Fraser <simon.fraser@apple.com>
  8684. Rubber Stamped by Dave Hyatt
  8685. Shuffle the data members to make Events 8 bytes smaller in 64-bit.
  8686. * dom/Event.cpp:
  8687. (WebCore::Event::Event):
  8688. * dom/Event.h:
  8689. 2009-05-07 Eric Seidel <eric@webkit.org>
  8690. Reviewed by Beth Dakin.
  8691. Fix regression caused by r41469, add test case to prevent it from
  8692. happening again.
  8693. https://bugs.webkit.org/show_bug.cgi?id=25252
  8694. hasLayer() was true during removeOnlyThisLayer()/
  8695. updateLayerPositions()
  8696. which caused updateLayerPosition()'s walk up the render tree to
  8697. include offsets from the layer we were about to remove.
  8698. I'm not 100% convinced that this wasn't a bug in
  8699. updateLayerPosition() or in RenderBoxModelObject::styleDidChange,
  8700. because the layer in question is not the containing block for the
  8701. block which gets laid out wrong. But this restores the previous
  8702. behavior and adds a test. So the next time someone is in here re-
  8703. factoring, they will at least know if they break something.
  8704. Test: fast/layers/remove-only-this-layer-update.html
  8705. * rendering/RenderBoxModelObject.cpp:
  8706. (WebCore::RenderBoxModelObject::destroyLayer):
  8707. * rendering/RenderLayer.cpp:
  8708. (WebCore::RenderLayer::removeOnlyThisLayer):
  8709. * rendering/RenderObject.cpp:
  8710. (WebCore::RenderObject::destroy):
  8711. * rendering/RenderWidget.cpp:
  8712. (WebCore::RenderWidget::destroy):
  8713. 2009-05-07 Dmitry Titov <dimich@chromium.org>
  8714. Attempt to fix GTK build.
  8715. * platform/graphics/GlyphPageTreeNode.h: add #include <string.h> to ensure memcpy and memset are defined.
  8716. 2009-05-07 Oliver Hunt <oliver@apple.com>
  8717. Reviewed by Gavin Barraclough.
  8718. Improve native call performance
  8719. Add calling convention declarations where necessary, and update bindings
  8720. script to generate them as well.
  8721. * bindings/js/JSHTMLCollectionCustom.cpp:
  8722. (WebCore::callHTMLCollection):
  8723. * bindings/js/JSNodeListCustom.cpp:
  8724. (WebCore::callNodeList):
  8725. * bindings/js/JSPluginElementFunctions.cpp:
  8726. (WebCore::callPlugin):
  8727. * bindings/js/JSQuarantinedObjectWrapper.h:
  8728. * bindings/scripts/CodeGeneratorJS.pm:
  8729. * bridge/runtime_method.cpp:
  8730. (JSC::callRuntimeMethod):
  8731. * bridge/runtime_object.cpp:
  8732. (JSC::callRuntimeObject):
  8733. 2009-05-07 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  8734. Reviewed by Dave Hyatt.
  8735. Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
  8736. Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
  8737. Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
  8738. gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
  8739. The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
  8740. This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
  8741. To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
  8742. methods are renamed to clarify where they belong to. All renames are listed here:
  8743. From FormControlElement:
  8744. - isEnabled() -> isEnabledFormControl()
  8745. - isReadOnly() -> isReadOnlyFormControl()
  8746. - isTextControl() -> isTextFormControl()
  8747. - valueMatchesRenderer() -> formControlValueMatchesRenderer()
  8748. - setValueMatchesRenderer() -> setFormControlValueMatchesRenderer()
  8749. - name() -> formControlName()
  8750. - type() -> formControlType()
  8751. From FormControlElementWithState:
  8752. - saveState() -> saveFormControlState()
  8753. - restoreState() -> restoreFormControlState()
  8754. A lot of Element -> FormControlElement(WithState) casting is gone again, so it's not only a memory, but also a performance progression.
  8755. No testcases affected, no new tests needed.
  8756. * GNUmakefile.am:
  8757. * WebCore.pro:
  8758. * WebCore.vcproj/WebCore.vcproj:
  8759. * WebCore.xcodeproj/project.pbxproj:
  8760. * WebCoreSources.bkl:
  8761. * css/CSSStyleSelector.cpp:
  8762. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  8763. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  8764. * dom/Document.cpp:
  8765. (WebCore::Document::formElementsState):
  8766. * dom/Document.h:
  8767. (WebCore::Document::registerFormElementWithState):
  8768. (WebCore::Document::unregisterFormElementWithState):
  8769. * dom/Element.h:
  8770. (WebCore::Element::isFormControlElement):
  8771. (WebCore::Element::isEnabledFormControl):
  8772. (WebCore::Element::isReadOnlyFormControl):
  8773. (WebCore::Element::isTextFormControl):
  8774. (WebCore::Element::formControlValueMatchesRenderer):
  8775. (WebCore::Element::setFormControlValueMatchesRenderer):
  8776. (WebCore::Element::formControlName):
  8777. (WebCore::Element::formControlType):
  8778. (WebCore::Element::saveFormControlState):
  8779. (WebCore::Element::restoreFormControlState):
  8780. * dom/FormControlElement.cpp: Removed.
  8781. * dom/FormControlElement.h: Removed.
  8782. * dom/FormControlElementWithState.cpp: Removed.
  8783. * dom/FormControlElementWithState.h: Removed.
  8784. * dom/InputElement.cpp:
  8785. (WebCore::InputElement::setValueFromRenderer):
  8786. * html/HTMLButtonElement.cpp:
  8787. (WebCore::HTMLButtonElement::formControlType):
  8788. * html/HTMLButtonElement.h:
  8789. * html/HTMLFieldSetElement.cpp:
  8790. (WebCore::HTMLFieldSetElement::formControlType):
  8791. * html/HTMLFieldSetElement.h:
  8792. * html/HTMLFormControlElement.cpp:
  8793. (WebCore::HTMLFormControlElement::attach):
  8794. (WebCore::HTMLFormControlElement::formControlName):
  8795. (WebCore::HTMLFormControlElement::willValidate):
  8796. (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
  8797. (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
  8798. (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
  8799. (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
  8800. (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
  8801. * html/HTMLFormControlElement.h:
  8802. (WebCore::HTMLFormControlElement::isTextFormControl):
  8803. (WebCore::HTMLFormControlElement::isEnabledFormControl):
  8804. (WebCore::HTMLFormControlElement::formControlValueMatchesRenderer):
  8805. (WebCore::HTMLFormControlElement::setFormControlValueMatchesRenderer):
  8806. (WebCore::HTMLFormControlElement::isReadOnlyFormControl):
  8807. (WebCore::HTMLFormControlElement::type):
  8808. (WebCore::HTMLFormControlElement::name):
  8809. * html/HTMLInputElement.cpp:
  8810. (WebCore::HTMLInputElement::formControlName):
  8811. (WebCore::HTMLInputElement::formControlType):
  8812. (WebCore::HTMLInputElement::saveFormControlState):
  8813. (WebCore::HTMLInputElement::restoreFormControlState):
  8814. (WebCore::HTMLInputElement::parseMappedAttribute):
  8815. (WebCore::HTMLInputElement::detach):
  8816. (WebCore::HTMLInputElement::setValue):
  8817. (WebCore::HTMLInputElement::setFileListFromRenderer):
  8818. * html/HTMLInputElement.h:
  8819. (WebCore::HTMLInputElement::readOnly):
  8820. (WebCore::HTMLInputElement::isTextFormControl):
  8821. * html/HTMLKeygenElement.cpp:
  8822. (WebCore::HTMLKeygenElement::formControlType):
  8823. * html/HTMLKeygenElement.h:
  8824. * html/HTMLLegendElement.cpp:
  8825. (WebCore::HTMLLegendElement::formControlType):
  8826. * html/HTMLLegendElement.h:
  8827. * html/HTMLOptGroupElement.cpp:
  8828. (WebCore::HTMLOptGroupElement::formControlType):
  8829. * html/HTMLOptGroupElement.h:
  8830. * html/HTMLOptionElement.cpp:
  8831. (WebCore::HTMLOptionElement::formControlType):
  8832. * html/HTMLOptionElement.h:
  8833. * html/HTMLSelectElement.cpp:
  8834. (WebCore::HTMLSelectElement::formControlType):
  8835. (WebCore::HTMLSelectElement::saveFormControlState):
  8836. (WebCore::HTMLSelectElement::restoreFormControlState):
  8837. * html/HTMLSelectElement.h:
  8838. * html/HTMLTextAreaElement.cpp:
  8839. (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  8840. (WebCore::HTMLTextAreaElement::formControlType):
  8841. (WebCore::HTMLTextAreaElement::saveFormControlState):
  8842. (WebCore::HTMLTextAreaElement::restoreFormControlState):
  8843. (WebCore::HTMLTextAreaElement::updateValue):
  8844. (WebCore::HTMLTextAreaElement::setValue):
  8845. * html/HTMLTextAreaElement.h:
  8846. (WebCore::HTMLTextAreaElement::readOnly):
  8847. (WebCore::HTMLTextAreaElement::isTextFormControl):
  8848. * page/AccessibilityRenderObject.cpp:
  8849. (WebCore::AccessibilityRenderObject::isEnabled):
  8850. (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  8851. * page/DragController.cpp:
  8852. (WebCore::DragController::concludeEditDrag):
  8853. * rendering/RenderMenuList.cpp:
  8854. (WebCore::RenderMenuList::itemIsEnabled):
  8855. * rendering/RenderTextControl.cpp:
  8856. (WebCore::updateUserModifyProperty):
  8857. (WebCore::RenderTextControl::setInnerTextValue):
  8858. * rendering/RenderTextControl.h:
  8859. * rendering/RenderTextControlMultiLine.cpp:
  8860. (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  8861. * rendering/RenderTextControlSingleLine.cpp:
  8862. (WebCore::RenderTextControlSingleLine::updateFromElement):
  8863. * rendering/RenderTheme.cpp:
  8864. (WebCore::RenderTheme::isEnabled):
  8865. (WebCore::RenderTheme::isReadOnlyControl):
  8866. * rendering/RenderThemeChromiumMac.mm:
  8867. (WebCore::RenderThemeChromiumMac::adjustMenuListStyle):
  8868. * rendering/RenderThemeMac.mm:
  8869. (WebCore::RenderThemeMac::adjustMenuListStyle):
  8870. * rendering/RenderThemeSafari.cpp:
  8871. (WebCore::RenderThemeSafari::adjustMenuListStyle):
  8872. * wml/WMLFormControlElement.cpp:
  8873. * wml/WMLFormControlElement.h:
  8874. (WebCore::WMLFormControlElement::isReadOnlyFormControl):
  8875. (WebCore::WMLFormControlElement::isTextFormControl):
  8876. (WebCore::WMLFormControlElement::formControlValueMatchesRenderer):
  8877. (WebCore::WMLFormControlElement::setFormControlValueMatchesRenderer):
  8878. * wml/WMLInputElement.cpp:
  8879. (WebCore::WMLInputElement::WMLInputElement):
  8880. (WebCore::WMLInputElement::isKeyboardFocusable):
  8881. (WebCore::WMLInputElement::isMouseFocusable):
  8882. (WebCore::WMLInputElement::dispatchBlurEvent):
  8883. (WebCore::WMLInputElement::formControlType):
  8884. (WebCore::WMLInputElement::formControlName):
  8885. (WebCore::WMLInputElement::setValue):
  8886. (WebCore::WMLInputElement::saveFormControlState):
  8887. (WebCore::WMLInputElement::restoreFormControlState):
  8888. (WebCore::WMLInputElement::parseMappedAttribute):
  8889. (WebCore::WMLInputElement::detach):
  8890. (WebCore::WMLInputElement::appendFormData):
  8891. (WebCore::WMLInputElement::init):
  8892. * wml/WMLInputElement.h:
  8893. (WebCore::WMLInputElement::isTextFormControl):
  8894. * wml/WMLOptGroupElement.cpp:
  8895. (WebCore::WMLOptGroupElement::formControlType):
  8896. * wml/WMLOptGroupElement.h:
  8897. * wml/WMLOptionElement.cpp:
  8898. (WebCore::WMLOptionElement::formControlType):
  8899. * wml/WMLOptionElement.h:
  8900. 2009-05-07 Dmitry Titov <dimich@chromium.org>
  8901. Reviewed by Alexey Proskuryakov and Adam Roben.
  8902. https://bugs.webkit.org/show_bug.cgi?id=25348
  8903. Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
  8904. Most of the change is in WTF.
  8905. Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
  8906. method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
  8907. is now a class rather then an integer.
  8908. Also, there is no need to initialize threadID in constructors to 0 now.
  8909. * dom/XMLTokenizerLibxml2.cpp:
  8910. (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
  8911. since now ThreadIdentifier needs construction and we avoid having global initializers.
  8912. (WebCore::matchFunc): use the new accessor function.
  8913. (WebCore::openFunc): ditto.
  8914. (WebCore::createStringParser): ditto.
  8915. (WebCore::createMemoryParser): ditto.
  8916. * loader/icon/IconDatabase.cpp:
  8917. (WebCore::IconDatabase::open):
  8918. * platform/sql/SQLiteDatabase.cpp:
  8919. (WebCore::SQLiteDatabase::SQLiteDatabase):
  8920. (WebCore::SQLiteDatabase::close):
  8921. * storage/DatabaseThread.cpp:
  8922. (WebCore::DatabaseThread::start):
  8923. (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
  8924. * storage/LocalStorageThread.cpp:
  8925. (WebCore::LocalStorageThread::start):
  8926. (WebCore::LocalStorageThread::scheduleImport):
  8927. (WebCore::LocalStorageThread::scheduleSync):
  8928. (WebCore::LocalStorageThread::terminate):
  8929. * workers/WorkerThread.cpp:
  8930. (WebCore::WorkerThread::start):
  8931. (WebCore::WorkerThread::WorkerThread):
  8932. (WebCore::WorkerThread::start):
  8933. 2009-05-07 Simon Fraser <simon.fraser@apple.com>
  8934. Rubber Stamped by Dave Hyatt
  8935. Shuffle the data members to minimize padding.
  8936. * dom/ClassNames.h:
  8937. 2009-05-07 Simon Fraser <simon.fraser@apple.com>
  8938. Reviewed by Darin Adler
  8939. <rdar://problem/6864062> Shrink GlyphPage from 4112 to 2576 bytes in 64-bit
  8940. https://bugs.webkit.org/show_bug.cgi?id=25605
  8941. Shrink GlyphPage by splitting the array of GlyphData, which has lots
  8942. of padding, into separate Glyph and SimpleFontData* arrays.
  8943. * platform/graphics/Font.h:
  8944. glyphDataForCharacter has to return a GlyphData by value now.
  8945. * platform/graphics/FontFastPath.cpp:
  8946. (WebCore::Font::glyphDataForCharacter):
  8947. Return GlyphData by value.
  8948. * platform/graphics/GlyphPageTreeNode.cpp:
  8949. (WebCore::GlyphPageTreeNode::initializePage):
  8950. Better encapsulation of GlyphPage, using the new methods.
  8951. * platform/graphics/Font.h:
  8952. * platform/graphics/FontFastPath.cpp:
  8953. (WebCore::Font::glyphDataForCharacter):
  8954. * platform/graphics/GlyphPageTreeNode.cpp:
  8955. (WebCore::GlyphPageTreeNode::initializePage):
  8956. * platform/graphics/GlyphPageTreeNode.h:
  8957. (WebCore::GlyphData::GlyphData):
  8958. (WebCore::GlyphPage::indexForCharacter):
  8959. (WebCore::GlyphPage::glyphDataForCharacter):
  8960. (WebCore::GlyphPage::glyphDataForIndex):
  8961. (WebCore::GlyphPage::glyphAt):
  8962. (WebCore::GlyphPage::fontDataForCharacter):
  8963. (WebCore::GlyphPage::setGlyphDataForCharacter):
  8964. (WebCore::GlyphPage::setGlyphDataForIndex):
  8965. (WebCore::GlyphPage::copyFrom):
  8966. (WebCore::GlyphPage::clear):
  8967. 2009-05-07 Dimitri Glazkov <dglazkov@chromium.org>
  8968. Reviewed by Darin Fisher.
  8969. https://bugs.webkit.org/show_bug.cgi?id=25625
  8970. Implement Image/Option constructors in V8 bindings.
  8971. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  8972. (WebCore::NAMED_PROPERTY_GETTER): Removed old JS-based code.
  8973. * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Added.
  8974. * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Added.
  8975. 2009-05-07 Brady Eidson <beidson@apple.com>
  8976. I hate myself for doing this, but need to fix that ChangeLog entry.
  8977. * ChangeLog:
  8978. 2009-05-07 Brady Eidson <beidson@apple.com>
  8979. Rubberstamped by Darin Adler
  8980. * html/HTMLParser.cpp: Use the correct style of BUILDING_ON_* for WebCore.
  8981. * html/HTMLParser.h: Ditto
  8982. 2009-05-07 David Hyatt <hyatt@apple.com>
  8983. Restore intrinsic margins to all form controls on Mac and Windows. Some of this regressed in 43007
  8984. when textareas were given explicit margins. Some of it had already regressed earlier whenever intrinsic
  8985. margins were turned off in themeWin.css.
  8986. Reviewed by Beth Dakin.
  8987. * css/html4.css:
  8988. * css/themeWin.css:
  8989. 2009-05-07 Brady Eidson <beidson@apple.com>
  8990. Reviewed by Darin Adler and Alexey Proskuryakov.
  8991. <rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation
  8992. * dom/Document.cpp:
  8993. (WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.
  8994. * html/HTMLParser.cpp:
  8995. (WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it.
  8996. (WebCore::HTMLParser::bodyCreateErrorCheck): Ditto.
  8997. (WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
  8998. * html/HTMLParser.h:
  8999. (WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms
  9000. 2009-05-07 Antony Sargent <asargent@chromium.org>
  9001. Reviewed by Darin Fisher.
  9002. Fix a memory leak in V8EventListenerList::remove.
  9003. https://bugs.webkit.org/show_bug.cgi?id=25618
  9004. No new functionality so no new tests.
  9005. * bindings/v8/V8EventListenerList.cpp:
  9006. (WebCore::V8EventListenerList::remove):
  9007. 2009-05-07 Darin Fisher <darin@chromium.org>
  9008. Fix Chromium build bustage.
  9009. * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Add missing
  9010. HTMLCollection.h include.
  9011. 2009-05-07 Chris Fleizach <cfleizach@apple.com>
  9012. Reviewed by Beth Dakin.
  9013. Bug 25598: AX: if a radio button has a label and a title, the label is not exposed
  9014. https://bugs.webkit.org/show_bug.cgi?id=25598
  9015. Test: accessibility/radio-button-title-label.html
  9016. * page/AccessibilityObject.h:
  9017. (WebCore::AccessibilityObject::exposesTitleUIElement):
  9018. * page/AccessibilityRenderObject.cpp:
  9019. (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
  9020. (WebCore::AccessibilityRenderObject::titleUIElement):
  9021. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  9022. * page/AccessibilityRenderObject.h:
  9023. 2009-05-07 Darin Fisher <darin@chromium.org>
  9024. Fix Chromium build bustage.
  9025. * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  9026. (WebCore::INDEXED_PROPERTY_GETTER): ":" should be "::"
  9027. 2009-05-07 Xan Lopez <xlopez@igalia.com>
  9028. Reviewed by Gustavo Noronha.
  9029. https://bugs.webkit.org/show_bug.cgi?id=25610
  9030. [GTK] text.caretOffset is reportedly always 0
  9031. Use the right function to get the caret offset in an
  9032. element. selectionStart() would only work for text
  9033. controls (there's even an ASSERT when calculating the selected
  9034. text range). Instead just get the selection and get the offset of
  9035. the start position.
  9036. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  9037. 2009-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  9038. Reviewed by Simon Hausmann.
  9039. [Qt] Fix support for antialiased CSS border-radius
  9040. WebKit implements border-radius by drawing a double-size border,
  9041. and then letting the clip constrain the border to the right width
  9042. and position. This requires support for antialiased clipping, as
  9043. well as painting, to get a nice smooth border.
  9044. Qt only does antialiased clipping if the anti-alias flag is set
  9045. at the time of clipping, so we have to enable this in the method
  9046. addInnerRoundedRectClip(), as well as when we draw the border.
  9047. Currently the raster-engine is the only Qt paint engine to support
  9048. anti-aliased clipping, but the OpenGL and Mac paint engines could
  9049. potentially support this in the future.
  9050. * platform/graphics/qt/GraphicsContextQt.cpp:
  9051. (WebCore::GraphicsContext::strokeArc):
  9052. (WebCore::GraphicsContext::addInnerRoundedRectClip):
  9053. 2009-05-07 Adam Langley <agl@google.com>
  9054. Reviewed by Eric Seidel.
  9055. Render empty optgroup elements.
  9056. https://bugs.webkit.org/show_bug.cgi?id=24900
  9057. Currently, optgroup elements which are empty are not rendered. The
  9058. HTML specification gives no guidance on this situation.
  9059. However, the test for being empty is that they have no children, thus
  9060. this will not render:
  9061. <optgroup label="test"></optgroup>
  9062. while this /will/ render (because of the text node child):
  9063. <optgroup label="test"> </optgroup>
  9064. This patch will cause both cases to render which matches IE's and
  9065. Firefox's behaviour.
  9066. The difference only appears when opening the select element and does
  9067. not appear in the render tree. Thus, a manual layout-test is required.
  9068. * html/HTMLSelectElement.cpp:
  9069. (WebCore::HTMLSelectElement::recalcListItems):
  9070. * manual-tests/optgroup-empty-and-nested.html: Added.
  9071. 2009-05-06 Julie Parent <jparent@google.com>
  9072. Reviewed by Eric Seidel.
  9073. Bug 25608: Unused m_frame in ChromiumClipboard.
  9074. https://bugs.webkit.org/show_bug.cgi?id=25608
  9075. * platform/chromium/ClipboardChromium.h:
  9076. No tests added as this is only removing dead code, no functional changes.
  9077. 2009-05-06 Dan Bernstein <mitz@apple.com>
  9078. Reviewed by Simon Fraser and Justin Garcia.
  9079. - fix another part of <rdar://problem/6703873> Triple-click quoted line
  9080. and type Return creates an extra quoted blank line
  9081. Test: editing/inserting/6703873-2.html
  9082. * editing/BreakBlockquoteCommand.cpp:
  9083. (WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for
  9084. determining the first node that should go into the new blockquote
  9085. given the split position: if it is at the end of a container, use the
  9086. next node after the container. Otherwise, use the child at the
  9087. position's offset.
  9088. 2009-05-06 Kevin Ollivier <kevino@theolliviers.com>
  9089. wx build fix, fixes for wx trunk builds.
  9090. * platform/graphics/wx/ImageWx.cpp:
  9091. (WebCore::BitmapImage::draw):
  9092. * platform/wx/RenderThemeWx.cpp:
  9093. * platform/wx/wxcode/mac/carbon/fontprops.cpp:
  9094. (wxFontProperties::wxFontProperties):
  9095. 2009-05-06 Albert J. Wong <ajwong@chromium.org>
  9096. Reviewed by Darin Fisher.
  9097. https://bugs.webkit.org/show_bug.cgi?id=25597
  9098. Fix API drift compile errors that occurred while this was ifdef-ed out.
  9099. The two big issues were that RenderObject::element() became
  9100. RenderObject::node() and some of the wk* drawing functions had
  9101. an extra theme parameter added to the argument list.
  9102. * rendering/RenderThemeChromiumMac.mm:
  9103. (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
  9104. (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
  9105. (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
  9106. (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton):
  9107. (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton):
  9108. (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
  9109. (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
  9110. 2009-05-06 Jian Li <jianli@chromium.org>
  9111. Reviewed by Dimitri Glazkov.
  9112. https://bugs.webkit.org/show_bug.cgi?id=25385
  9113. Upstream changes to V8 bindings for supporting nested workers.
  9114. * bindings/v8/WorkerContextExecutionProxy.cpp:
  9115. (WebCore::WorkerContextExecutionProxy::ToV8Object):
  9116. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
  9117. * bindings/v8/custom/V8WorkerCustom.cpp:
  9118. (WebCore::getEventListener):
  9119. (WebCore::ACCESSOR_SETTER WorkerOnmessage):
  9120. (WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):
  9121. 2009-05-06 Dave Moore <davemoore@google.com>
  9122. Reviewed by Dimitri Glazkov.
  9123. https://bugs.webkit.org/show_bug.cgi?id=25513
  9124. The V8 bindings convert every javascript property to its associated css style
  9125. name. It then calls functions that convert that name to an id. This makes
  9126. getting or setting css styles on elements slow.
  9127. The patch fixes this by caching the results of the transformation, mapping a
  9128. javascript property name to its css property id. It then calls the already
  9129. public webkit methods that take the id in place of the string property names.
  9130. * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  9131. 2009-05-06 Nate Chapin <japhet@google.com>
  9132. Reviewed by Dimitri Glazkov.
  9133. https://bugs.webkit.org/show_bug.cgi?id=25591
  9134. Upstream V8HTMLFormElement from the Chromium repository.
  9135. * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  9136. (WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository
  9137. (WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor();
  9138. (WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository
  9139. 2009-05-06 Albert J. Wong <ajwong@chromium.org>
  9140. Reviewed by Dimitri Glazkov.
  9141. https://bugs.webkit.org/show_bug.cgi?id=25595
  9142. Upstream V8CanvasPixelArrayCustom from chromium port tree.
  9143. * bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.
  9144. 2009-05-06 Simon Fraser <simon.fraser@apple.com>
  9145. Rubber-stampted by Eric Seidel
  9146. Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
  9147. Only affects ACCELERATED_COMPOSITING builds.
  9148. * rendering/RenderObject.cpp:
  9149. (WebCore::RenderObject::adjustStyleDifference):
  9150. 2009-05-06 Simon Fraser <simon.fraser@apple.com>
  9151. Reviewed by Dan Bernstein
  9152. <rdar://problem/6862550> Reduce size of RenderText in 64-bit
  9153. Rearrange data members of RenderText so that an int comes
  9154. first, to minimize padding.
  9155. * rendering/RenderText.cpp:
  9156. (WebCore::RenderText::RenderText):
  9157. * rendering/RenderText.h:
  9158. 2009-05-06 Simon Fraser <simon.fraser@apple.com>
  9159. Reviewed by Dan Bernstein
  9160. <rdar://problem/6862823> Reduce size of RenderStyle in 64-bit
  9161. Rearrange data members of RenderStyle to minimize padding
  9162. when building for 64-bit.
  9163. * rendering/style/RenderStyle.cpp:
  9164. (WebCore::RenderStyle::RenderStyle):
  9165. * rendering/style/RenderStyle.h:
  9166. (WebCore::):
  9167. 2009-05-06 Darin Fisher <darin@chromium.org>
  9168. Reviewed by Dimitri Glazkov.
  9169. https://bugs.webkit.org/show_bug.cgi?id=25596
  9170. Fixes Chromium build bustage caused by r43317 (making
  9171. RefCountedBase::m_refCount private)
  9172. * page/chromium/AccessibilityObjectWrapper.h:
  9173. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
  9174. 2009-05-06 Hin-Chung Lam <hclam@chromium.org>
  9175. Reviewed by Darin Fisher.
  9176. https://bugs.webkit.org/show_bug.cgi?id=25593
  9177. Refactor for MediaPlayerPrivate for Chromium port. Remove
  9178. the implementation of MediaPlayerPrivateInferface from it.
  9179. * platform\graphics\chromium\MediaPlayerPrivateChromium.h:
  9180. 2009-05-06 Simon Fraser <simon.fraser@apple.com>
  9181. Reviewed by Dave Hyatt, Dan Bernstein
  9182. <rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit
  9183. Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.
  9184. * platform/graphics/FontFallbackList.cpp:
  9185. (WebCore::FontFallbackList::FontFallbackList):
  9186. * platform/graphics/FontFallbackList.h:
  9187. 2009-05-06 Simon Fraser <simon.fraser@apple.com>
  9188. Reviewed by Darin Adler, Dan Bernstein
  9189. <rdar://problem/6860068> Reduce size of InlineBox in 64-bit
  9190. Re-order the data members of InlineBox to save 8 bytes when building 64-bit.
  9191. * rendering/InlineBox.h:
  9192. (WebCore::InlineBox::InlineBox):
  9193. 2009-05-06 David Levin <levin@chromium.org>
  9194. Reviewed by Dimitri Glazkov.
  9195. https://bugs.webkit.org/show_bug.cgi?id=25588
  9196. Adding the custom v8 bindings Document.location.
  9197. * bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.
  9198. 2009-05-06 Kevin McCullough <kmccullough@apple.com>
  9199. -Clarified a comment
  9200. * editing/InsertParagraphSeparatorCommand.cpp:
  9201. (WebCore::InsertParagraphSeparatorCommand::doApply):
  9202. 2009-05-06 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  9203. Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.
  9204. * wml/WMLAElement.cpp:
  9205. * wml/WMLAccessElement.cpp:
  9206. * wml/WMLBRElement.cpp:
  9207. * wml/WMLCardElement.cpp:
  9208. * wml/WMLDoElement.cpp:
  9209. * wml/WMLElement.cpp:
  9210. * wml/WMLFieldSetElement.cpp:
  9211. * wml/WMLGoElement.cpp:
  9212. * wml/WMLImageElement.cpp:
  9213. * wml/WMLInputElement.cpp:
  9214. * wml/WMLMetaElement.cpp:
  9215. * wml/WMLOnEventElement.cpp:
  9216. * wml/WMLOptGroupElement.cpp:
  9217. * wml/WMLOptionElement.cpp:
  9218. * wml/WMLPElement.cpp:
  9219. * wml/WMLPostfieldElement.cpp:
  9220. * wml/WMLSetvarElement.cpp:
  9221. * wml/WMLTableElement.cpp:
  9222. * wml/WMLTemplateElement.cpp:
  9223. * wml/WMLTimerElement.cpp:
  9224. 2009-05-06 Xan Lopez <xlopez@igalia.com>
  9225. Reviewed by Gustavo Noronha.
  9226. https://bugs.webkit.org/show_bug.cgi?id=25526
  9227. [Gtk] Additional support is needed for caret browsing
  9228. Emit AtkText::text-selection-changed when the selection changes
  9229. and the current selection is of Range (ie, the start and end
  9230. positions are different) type. This seems to match what Gecko
  9231. does.
  9232. * editing/gtk/SelectionControllerGtk.cpp:
  9233. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  9234. 2009-05-05 Xan Lopez <xlopez@igalia.com>
  9235. Reviewed by Gustavo Noronha.
  9236. https://bugs.webkit.org/show_bug.cgi?id=25526
  9237. [Gtk] Additional support is needed for caret browsing
  9238. Emit AtkText::text-caret-moved when selection changes.
  9239. * GNUmakefile.am:
  9240. * editing/SelectionController.h:
  9241. * editing/gtk/SelectionController.cpp: Added.
  9242. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  9243. 2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
  9244. Reviewed by Gustavo Noronha.
  9245. Use mozilla cursors for the previously not implemented
  9246. cursors. The manual-tests/cursor.html is looking complete
  9247. now.
  9248. * platform/gtk/CursorGtk.cpp:
  9249. (WebCore::cellCursor):
  9250. (WebCore::noDropCursor):
  9251. (WebCore::progressCursor):
  9252. (WebCore::noneCursor):
  9253. (WebCore::notAllowedCursor):
  9254. (WebCore::grabCursor):
  9255. (WebCore::grabbingCursor):
  9256. * platform/gtk/CursorGtk.h:
  9257. 2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
  9258. Reviewed by Xan Lopez.
  9259. Properly indent the header file.
  9260. * platform/gtk/CursorGtk.h:
  9261. 2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
  9262. Reviewed by Gustavo Noronha.
  9263. Use the mozilla copyright header. Use MPL1.1/GPL2.0
  9264. and LGPL2.1 as the license compared to LGPL2.0.
  9265. * platform/gtk/CursorGtk.h:
  9266. 2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
  9267. Reviewed by Gustavo Noronha.
  9268. Move PluginView::invalidateRegion from the
  9269. TemporaryLinkStubs to PluginViewGtk.cpp and implement
  9270. it with a call to Widget::invalidate() just like
  9271. mac is doing. Optimisations would have to be window
  9272. system specific.
  9273. * platform/gtk/TemporaryLinkStubs.cpp:
  9274. * plugins/gtk/PluginViewGtk.cpp:
  9275. (WebCore::PluginView::invalidateRegion):
  9276. 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
  9277. Reviewed by Holger Freyther.
  9278. Misc fixes to InspectorClientGtk.
  9279. * GNUmakefile.am: Add localizedStrings.js to webinspector_DATA.
  9280. This prevents copious amounts "Localized string not found" errors
  9281. in the console
  9282. 2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
  9283. Reviewed by Ariya Hidayat.
  9284. Fix the Qt build on Windows.
  9285. * platform/graphics/GraphicsContext.h:
  9286. (WebCore::GraphicsContext::shouldIncludeChildWindows): Implemented dummy accessor.
  9287. 2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
  9288. Reviewed by Tor Arne Vestbø.
  9289. Tweak WebCore.pro for being able to override the generated sources dir for the
  9290. generated_files target.
  9291. * WebCore.pro:
  9292. 2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
  9293. Reviewed by Holger Freyther.
  9294. Fix the Qt/Windows build, use iface instead of interface to avoid conflict
  9295. with VS2005 headers.
  9296. * css/CSSStyleSelector.cpp:
  9297. (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
  9298. 2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>
  9299. Reviewed by Simon Hausmann.
  9300. We need to include StringExtras.h on Windows CE to access the strdup function.
  9301. * plugins/PluginStream.cpp:
  9302. 2009-05-06 Soren Gjesse <sgjesse@chromium.org>
  9303. Reviewed by Eric Seidel.
  9304. Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
  9305. https://bugs.webkit.org/show_bug.cgi?id=25544
  9306. In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
  9307. function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
  9308. use the source of an event handler to create new functions this wrapper code causes compatibility problems.
  9309. Create a specific toString function for these handlers which will return a function source compatible with the
  9310. source returned by the JSC bindings and other browsers.
  9311. Test: fast/events/event-function-toString.html
  9312. * bindings/v8/ScriptEventListener.cpp:
  9313. (WebCore::createAttributeEventListener):
  9314. * bindings/v8/V8LazyEventListener.cpp:
  9315. (WebCore::V8LazyEventListener::V8LazyEventListener):
  9316. (WebCore::V8LazyEventListener::getListenerFunction):
  9317. (WebCore::V8LazyEventListenerToString):
  9318. (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  9319. * bindings/v8/V8LazyEventListener.h:
  9320. (WebCore::V8LazyEventListener::create):
  9321. 2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  9322. Reviewed by Simon Hausmann.
  9323. Build QtWebKit as a framework on Mac
  9324. This implies both debug and release build by default, unless
  9325. one of the --debug or --release config options are passed to
  9326. the build-webkit script.
  9327. Frameworks can be disabled by passing CONFIG+=webkit_no_framework
  9328. to the build-webkit script.
  9329. To be able to build both debug and release targets in parallel
  9330. we have to use separate output directories for the generated
  9331. sources, which is not optimal, but required to avoid race conditions.
  9332. An optimization would be to only require this spit-up on Mac.
  9333. * WebCore.pro:
  9334. 2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  9335. Reviewed by Simon Hausmann.
  9336. [Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
  9337. A couple of the generators left the bison output file in the source
  9338. tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
  9339. work well when building release and debug configurations in parallel.
  9340. * WebCore.pro:
  9341. 2009-05-06 Dan Bernstein <mitz@apple.com>
  9342. Reviewed by Justin Garcia.
  9343. - fix an assertion failure in RemoveNodeCommand() when deleting a <br>
  9344. between a block and a mail blockquote
  9345. Test: editing/deleting/removeNodeCommand-assert.html
  9346. * editing/DeleteSelectionCommand.cpp:
  9347. (WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block
  9348. to prune() instead of passing m_upstreamStart.node(), because the latter
  9349. may have been removed already.
  9350. 2009-05-05 Eric Seidel <eric@webkit.org>
  9351. No review, roll out only.
  9352. Roll out r23072 since it broke layout tests
  9353. * page/AccessibilityRenderObject.cpp:
  9354. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  9355. 2009-05-05 Ben Murdoch <benm@google.com>
  9356. Reviewed by Eric Seidel.
  9357. Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
  9358. https://bugs.webkit.org/show_bug.cgi?id=24776
  9359. No functional changes, thus no tests.
  9360. * bindings/js/JSCustomSQLStatementCallback.cpp:
  9361. * bindings/js/JSCustomSQLStatementCallback.h:
  9362. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  9363. * bindings/js/JSCustomSQLStatementErrorCallback.h:
  9364. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  9365. * bindings/js/JSCustomSQLTransactionCallback.h:
  9366. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  9367. * bindings/js/JSCustomSQLTransactionErrorCallback.h:
  9368. * bindings/js/JSDatabaseCustom.cpp:
  9369. * bindings/js/JSSQLTransactionCustom.cpp:
  9370. * loader/EmptyClients.h:
  9371. * page/ChromeClient.h:
  9372. * storage/ChangeVersionWrapper.cpp:
  9373. * storage/ChangeVersionWrapper.h:
  9374. * storage/Database.cpp:
  9375. (WebCore::Database::databaseInfoTableName):
  9376. * storage/Database.h:
  9377. * storage/Database.idl:
  9378. * storage/DatabaseTask.cpp:
  9379. * storage/DatabaseTask.h:
  9380. * storage/DatabaseThread.cpp:
  9381. * storage/DatabaseThread.h:
  9382. * storage/DatabaseTracker.cpp:
  9383. * storage/DatabaseTracker.h:
  9384. * storage/DatabaseTrackerClient.h:
  9385. * storage/OriginQuotaManager.cpp:
  9386. * storage/OriginQuotaManager.h:
  9387. * storage/SQLStatement.cpp:
  9388. * storage/SQLStatement.h:
  9389. * storage/SQLTransaction.cpp:
  9390. * storage/SQLTransaction.h:
  9391. * storage/SQLTransaction.idl:
  9392. 2009-05-05 Jeremy Moskovich <jeremy@chromium.org>
  9393. Reviewed by Eric Seidel.
  9394. Add some documentation to InlineBox::x(),y().
  9395. https://bugs.webkit.org/show_bug.cgi?id=25378
  9396. * rendering/InlineBox.h:
  9397. 2009-05-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  9398. Reviewed by Eric Seidel.
  9399. Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
  9400. https://bugs.webkit.org/show_bug.cgi?id=24693
  9401. * WebCore.pro:
  9402. 2009-05-05 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
  9403. Reviewed by Eric Seidel.
  9404. Anonymous blocks should not be exposed in accessibility tree.
  9405. Part of https://bugs.webkit.org/show_bug.cgi?id=23072
  9406. Tests: accessibility/ignore-anonymous-block.html
  9407. platform/win/accessibility/document-role.html
  9408. * page/AccessibilityRenderObject.cpp:
  9409. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):Return
  9410. true for Anonymous blocks. Matching Firefox 2.0.0.14
  9411. 2009-05-05 Jungshik Shin <jshin@chromium.org>
  9412. Reviewed by Alexey Proskuryakov.
  9413. http://bugs.webkit.org/show_bug.cgi?id=25487
  9414. For euc-kr and other 8bit Korean encodings
  9415. (similar to euc-kr/windows-949), make document.charset return
  9416. EUC-KR instead of windows-949. The latter is not recognized by
  9417. Korean web servers.
  9418. Add domName method to TextEncoding to deal with cases where
  9419. our internal encoding name does not match what's widely recognized
  9420. by web servers. Currently, the only case is 'windows-949' (internal
  9421. name) vs 'EUC-KR'.
  9422. Test: fast/encoding/euckr-name.html
  9423. * dom/Document.cpp:
  9424. (WebCore::Document::encoding): Call TextEncoding.domName() instead
  9425. of TextEncoding.name().
  9426. * platform/text/TextEncoding.cpp:
  9427. (WebCore::TextEncoding::domName): For the canonical name 'windows-949',
  9428. return 'EUC-KR'. Otherwise, just return the canonical name.
  9429. * platform/text/TextEncoding.h:
  9430. 2009-05-05 Adam Langley <agl@google.com>
  9431. Reviewed by Darin Adler.
  9432. Rendering fix for <select> elements.
  9433. https://bugs.webkit.org/show_bug.cgi?id=25558
  9434. When switching a <select> element from display:none to default
  9435. display, we would fail to invalidate the parent's pref widths in some
  9436. situations:
  9437. When attaching the element, RenderMenuList::updateOptionsWidth would
  9438. call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
  9439. set. This would mark the pref widths as dirty, but not for any parent
  9440. objects.
  9441. When RenderObjectChildList::appendChildNode later calls
  9442. setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
  9443. nothing would be done because the pref widths were already dirty for.
  9444. the RenderMenuList.
  9445. * rendering/RenderMenuList.cpp:
  9446. (WebCore::RenderMenuList::updateOptionsWidth):
  9447. 2009-05-05 Antony Sargent <asargent@chromium.org>
  9448. Reviewed by Dimitri Glazkov.
  9449. Switch V8EventListenerList to use HashTable<T>.
  9450. https://bugs.webkit.org/show_bug.cgi?id=25496
  9451. This avoids some tricky issues with event listener removal in the
  9452. current implementation and has slightly better performance.
  9453. No new functionality so no new tests.
  9454. * bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
  9455. * bindings/v8/V8EventListenerList.h:
  9456. (WebCore::V8EventListenerList::size):
  9457. * bindings/v8/WorkerContextExecutionProxy.cpp:
  9458. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
  9459. 2009-05-05 Darin Fisher <darin@chromium.org>
  9460. Fixing build bustage.
  9461. Add some missing includes to fix the Chromium build.
  9462. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  9463. * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  9464. 2009-05-05 Darin Fisher <darin@chromium.org>
  9465. Reviewed by Darin Adler.
  9466. https://bugs.webkit.org/show_bug.cgi?id=25570
  9467. history.{back,forward,go} should always be dispatched asynchronously,
  9468. even when the history navigation would just result in scrolling the
  9469. page. This matches the behavior of other browsers like IE and FF.
  9470. Test: fast/history/back-forward-is-asynchronous.html
  9471. * loader/FrameLoader.cpp:
  9472. (WebCore::FrameLoader::scheduleHistoryNavigation):
  9473. 2009-05-05 Eric Seidel <eric@webkit.org>
  9474. Reviewed by Simon Fraser.
  9475. Add an ASSERT(useTransforms) to mapLocalToContainer implementations in SVG.
  9476. https://bugs.webkit.org/show_bug.cgi?id=25532
  9477. https://bugs.webkit.org/show_bug.cgi?id=25568
  9478. Adding this ASSERT exposed a bug in SVGPaintServerPattern::setup
  9479. which was causing transformed SVG text when filled/stroked with a
  9480. pattern using patternUnits=objectBoundingBox to draw incorrectly.
  9481. I fixed the incorrect drawing (by removing the broken code) and added
  9482. two test cases to test the fix:
  9483. * svg/transforms/text-with-pattern-inside-transformed-html.xhtml
  9484. * svg/transforms/text-with-pattern-with-svg-transform.svg
  9485. * rendering/RenderSVGRoot.cpp:
  9486. (WebCore::RenderSVGRoot::mapLocalToContainer):
  9487. * rendering/SVGRenderSupport.cpp:
  9488. (WebCore::SVGRenderBase::mapLocalToContainer):
  9489. * svg/graphics/SVGPaintServerPattern.cpp:
  9490. (WebCore::SVGPaintServerPattern::setup):
  9491. 2009-05-05 Greg Bolsinga <bolsinga@apple.com>
  9492. Reviewed by Sam Weinig.
  9493. https://bugs.webkit.org/show_bug.cgi?id=25554
  9494. Support HTML5 text control input types: email, number, tel, url
  9495. Test: fast/html/text-field-input-types.html
  9496. * bindings/objc/DOMHTML.mm:
  9497. (-[DOMHTMLInputElement _isTextField]): Call HTMLInputElement::isTextField directly.
  9498. * html/HTMLInputElement.cpp: Use the new types where appropriate.
  9499. (WebCore::HTMLInputElement::setInputType):
  9500. (WebCore::HTMLInputElement::type):
  9501. (WebCore::HTMLInputElement::saveState):
  9502. (WebCore::HTMLInputElement::restoreState):
  9503. (WebCore::HTMLInputElement::accessKeyAction):
  9504. (WebCore::HTMLInputElement::rendererIsNeeded):
  9505. (WebCore::HTMLInputElement::createRenderer):
  9506. (WebCore::HTMLInputElement::appendFormData):
  9507. (WebCore::HTMLInputElement::valueWithDefault):
  9508. (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
  9509. (WebCore::HTMLInputElement::defaultEventHandler):
  9510. * html/HTMLInputElement.h: Ditto.
  9511. (WebCore::HTMLInputElement::):
  9512. (WebCore::HTMLInputElement::isTextField):
  9513. 2009-04-01 miggilin <mr.diggilin@gmail.com>
  9514. Reviewed by Kevin Ollivier.
  9515. Mouse wheel scrolling and keyboard shortcut support for wx.
  9516. https://bugs.webkit.org/show_bug.cgi?id=24797
  9517. * platform/ScrollView.cpp:
  9518. (WebCore::ScrollView::wheelEvent):
  9519. * platform/wx/KeyboardEventWx.cpp:
  9520. (WebCore::windowsKeyCodeForKeyEvent):
  9521. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  9522. * platform/wx/ScrollViewWx.cpp:
  9523. (WebCore::ScrollView::platformSetScrollPosition):
  9524. 2009-05-05 Kevin Ollivier <kevino@theolliviers.com>
  9525. wx build fix for Windows, add missing include.
  9526. https://bugs.webkit.org/show_bug.cgi?id=24798
  9527. * platform/wx/wxcode/win/non-kerned-drawing.cpp:
  9528. 2009-05-05 Chris Fleizach <cfleizach@apple.com>
  9529. Reviewed by Beth Dakin.
  9530. Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
  9531. https://bugs.webkit.org/show_bug.cgi?id=25574
  9532. Enable accessibility hit-testing for image map links.
  9533. Allow image map links to return AXURLs and AXAccessKey information.
  9534. Test: platform/mac/accessibility/imagemap-hittest.html
  9535. * page/AccessibilityImageMapLink.cpp:
  9536. (WebCore::AccessibilityImageMapLink::url):
  9537. * page/AccessibilityImageMapLink.h:
  9538. * page/AccessibilityObject.h:
  9539. (WebCore::AccessibilityObject::minValueForRange):
  9540. * page/AccessibilityRenderObject.cpp:
  9541. (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
  9542. (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
  9543. (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  9544. * page/AccessibilityRenderObject.h:
  9545. * page/mac/AccessibilityObjectWrapper.mm:
  9546. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  9547. 2009-05-05 Kevin McCullough <kmccullough@apple.com>
  9548. Reviewed by Dan Bernstein.
  9549. <rdar://problem/6552129> Select a quote line and paste elsewhere, you
  9550. get that line and an extra quoted blank line
  9551. <rdar://problem/6609308> Triple-click a quoted header line, copy, paste
  9552. onto an empty line makes an extra quoted line
  9553. - When pasting a blockquote with a newline, make sure we put the newline
  9554. outside of the blockquote so that it is not quoted.
  9555. * editing/InsertParagraphSeparatorCommand.cpp:
  9556. (WebCore::InsertParagraphSeparatorCommand::doApply):
  9557. 2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>
  9558. Reviewed by Xan Lopez.
  9559. Call moz_gtk_shutdown on RenderThemeGtk destruction.
  9560. * platform/gtk/RenderThemeGtk.cpp:
  9561. (WebCore::RenderThemeGtk::~RenderThemeGtk):
  9562. * platform/gtk/RenderThemeGtk.h:
  9563. 2009-05-05 Darin Adler <darin@apple.com>
  9564. Reviewed by Steve Falkenburg.
  9565. <rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"
  9566. * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.
  9567. 2009-05-05 Peter Kasting <pkasting@google.com>
  9568. Reviewed by Brady Eidson.
  9569. Safety-check m_documentLoader before dereferencing. While it seems
  9570. unlikely this could fail (as Safari 3 shipped without this),
  9571. technically almost any call can change or reset m_documentLoader.
  9572. * loader/FrameLoader.cpp:
  9573. (WebCore::FrameLoader::receivedFirstData):
  9574. 2009-05-05 Dan Bernstein <mitz@apple.com>
  9575. - Tiger build fix
  9576. * css/CSSComputedStyleDeclaration.cpp:
  9577. (WebCore::toCSSIdentifier):
  9578. 2009-05-05 Peter Kasting <pkasting@google.com>
  9579. Reviewed by Eric Seidel.
  9580. https://bugs.webkit.org/show_bug.cgi?id=25303
  9581. No need to ref the internal buffer inside the Skia ImageDecoder.
  9582. * platform/image-decoders/skia/ImageDecoder.h:
  9583. (WebCore::RGBA32Buffer::RGBA32Buffer):
  9584. (WebCore::RGBA32Buffer::operator=):
  9585. (WebCore::RGBA32Buffer::clear):
  9586. (WebCore::RGBA32Buffer::copyBitmapData):
  9587. (WebCore::RGBA32Buffer::bitmap):
  9588. (WebCore::RGBA32Buffer::setSize):
  9589. (WebCore::RGBA32Buffer::width):
  9590. (WebCore::RGBA32Buffer::height):
  9591. (WebCore::RGBA32Buffer::hasAlpha):
  9592. (WebCore::RGBA32Buffer::setStatus):
  9593. (WebCore::RGBA32Buffer::setHasAlpha):
  9594. (WebCore::RGBA32Buffer::setRGBA):
  9595. 2009-05-05 Dan Bernstein <mitz@apple.com>
  9596. Reviewed by Darin Adler.
  9597. - fix https://bugs.webkit.org/show_bug.cgi?id=24192
  9598. <rdar://problem/5760774> Replying to a Mail message that contains
  9599. fixed width text can change the size of the text
  9600. Covered by existing tests: editing/pasteboard/5027857.html
  9601. editing/pasteboard/paste-pre-002.html
  9602. * css/CSSComputedStyleDeclaration.cpp:
  9603. (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
  9604. Added. If the font-size is keyword-based, returns the keyword value
  9605. instead of the pixel size.
  9606. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If
  9607. font-family is a generic family, return the generic family instead of
  9608. the the internal string -webkit-[serif|sans-serif|cursive|fantasy
  9609. |monospace].
  9610. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
  9611. For the font-size property, prefer a keyword value over a pixel size.
  9612. * css/CSSComputedStyleDeclaration.h:
  9613. * editing/ApplyStyleCommand.cpp:
  9614. (WebCore::StyleChange::currentlyHasStyle): For the font-size property,
  9615. call getFontSizeCSSValuePreferringKeyword().
  9616. * platform/graphics/FontDescription.h:
  9617. (WebCore::FontDescription::keywordSize): Changed the return type to
  9618. unsigned.
  9619. (WebCore::FontDescription::setKeywordSize): Changed the parameter type
  9620. to unsigned.
  9621. (WebCore::FontDescription::m_keywordSize): Changed the type of this
  9622. 4-bit field to unsigned, because it takes values as high as 8.
  9623. 2009-05-05 Oliver Hunt <oliver@apple.com>
  9624. Reviewed by Maciej Stachowiak.
  9625. Fix http/tests/misc/DOMContentLoaded-event.html
  9626. The native call performance improvement removed a few places where we
  9627. unintentionally performed a toThisObject conversion. This patch updates
  9628. the bindings codegen to not rely on this bug.
  9629. * bindings/scripts/CodeGeneratorJS.pm:
  9630. 2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
  9631. Reviewed by Xan Lopez and Gustavo Noronha.
  9632. Implement WebCore::directoryName for Gtk+.
  9633. * platform/gtk/FileSystemGtk.cpp:
  9634. (WebCore::directoryName):
  9635. 2009-05-05 Eric Seidel <eric@webkit.org>
  9636. Reviewed by Adam Roben.
  9637. Fix mappedAttributes() access without NULL check
  9638. https://bugs.webkit.org/show_bug.cgi?id=25553
  9639. SVGStyledElement::getPresentationAttribute was using mappedAttributes()
  9640. without checking for NULL.
  9641. HTMLInputElement::setInputType also doesn't NULL check, but I was not
  9642. able to get it to crash with a test case so I just added an ASSERT.
  9643. * html/HTMLInputElement.cpp:
  9644. (WebCore::HTMLInputElement::setInputType):
  9645. * svg/SVGStyledElement.cpp:
  9646. (WebCore::SVGStyledElement::getPresentationAttribute):
  9647. 2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
  9648. Reviewed by Xan Lopez.
  9649. Implement WebCore::imageTitle for Gtk+.
  9650. * platform/gtk/LocalizedStringsGtk.cpp:
  9651. (WebCore::imageTitle):
  9652. 2009-05-05 Oliver Hunt <oliver@apple.com>
  9653. Reviewed by Gavin Barraclough.
  9654. Bug 25559: Improve native function call performance
  9655. <https://bugs.webkit.org/show_bug.cgi?id=25559>
  9656. Add forwarding header necessary for compilation, and fix debugger
  9657. to correctly account for change in JSFunction behaviour.
  9658. * ForwardingHeaders/jit/JITCode.h: Added.
  9659. * inspector/JavaScriptDebugServer.cpp:
  9660. (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
  9661. 2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
  9662. Reviewed by Ariya Hidayat.
  9663. Make convertValueToQVariant more robust against null JSValues.
  9664. Don't require the caller to do the null check.
  9665. * bridge/qt/qt_runtime.cpp:
  9666. (JSC::Bindings::convertValueToQVariant):
  9667. 2009-05-05 Eric Seidel <eric@webkit.org>
  9668. No review, just a revert.
  9669. Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.
  9670. * rendering/RenderSVGRoot.cpp:
  9671. (WebCore::RenderSVGRoot::mapLocalToContainer):
  9672. * rendering/SVGRenderSupport.cpp:
  9673. (WebCore::SVGRenderBase::mapLocalToContainer):
  9674. 2009-05-04 Alexey Proskuryakov <ap@webkit.org>
  9675. Reviewed by Dave Hyatt.
  9676. <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
  9677. The problem was caused by missing <head> element - we used to create it when moving a
  9678. misplaced <style> element, but we now handle those in place. Other browsers always create
  9679. a <head> element.
  9680. There is no guarantee that a <head> element always exists - first, it can be removed with
  9681. removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
  9682. for manually created ones (e.g. ImageDocument).
  9683. Test: fast/parser/head-element-for-yahoo-player.html
  9684. * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
  9685. A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
  9686. code is removed completely.
  9687. * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
  9688. elements as children of <html>. This isn't directly related to this bug, but it was easier
  9689. to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
  9690. * html/HTMLParser.cpp:
  9691. (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
  9692. Create a <head> it a <body> is created implicitly to contain some other element.
  9693. (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
  9694. explicitly present in source.
  9695. (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
  9696. 2009-05-04 Jakub Wieczorek <faw217@gmail.com>
  9697. Reviewed by Simon Hausmann.
  9698. As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
  9699. returns the application/octet-stream mimetype when it can't associate
  9700. extension with any mimetype, it can happen that the application/octet-stream
  9701. mimetype will hit the list of supported image formats. For instance,
  9702. it is possible when QImageReader or QImageWriter support an extension
  9703. that is not in the extensions map.
  9704. Make sure that this mimetype is not treated as displayable image type.
  9705. * platform/MIMETypeRegistry.cpp:
  9706. (WebCore::initializeSupportedImageMIMETypes):
  9707. (WebCore::initializeSupportedImageMIMETypesForEncoding):
  9708. 2009-05-03 Eric Seidel <eric@webkit.org>
  9709. Reviewed by Simon Fraser.
  9710. ASSERT(useTransforms) in SVG mapLocalToContainer implementations
  9711. https://bugs.webkit.org/show_bug.cgi?id=25532
  9712. * rendering/RenderSVGRoot.cpp:
  9713. (WebCore::RenderSVGRoot::mapLocalToContainer):
  9714. * rendering/SVGRenderSupport.cpp:
  9715. (WebCore::SVGRenderBase::mapLocalToContainer):
  9716. 2009-05-03 Eric Seidel <eric@webkit.org>
  9717. Reviewed by Simon Fraser.
  9718. Remove m_absoluteBounds hack from RenderSVGText
  9719. https://bugs.webkit.org/show_bug.cgi?id=25532
  9720. No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)
  9721. * rendering/RenderSVGText.cpp:
  9722. (WebCore::RenderSVGText::layout):
  9723. * rendering/RenderSVGText.h:
  9724. 2009-05-03 Eric Seidel <eric@webkit.org>
  9725. Reviewed by Simon Fraser.
  9726. Remove the vestigial calculateLocalTransform()
  9727. https://bugs.webkit.org/show_bug.cgi?id=25532
  9728. RenderSVGContainer is now the only render which needs this
  9729. function, but it no longer returns the unused bool.
  9730. calculateLocalTransform() previously was called by the DOM before
  9731. transform updates were part of layout().
  9732. * rendering/RenderForeignObject.cpp:
  9733. (WebCore::RenderForeignObject::layout):
  9734. * rendering/RenderForeignObject.h:
  9735. (WebCore::RenderForeignObject::localTransform):
  9736. * rendering/RenderPath.cpp:
  9737. (WebCore::RenderPath::layout):
  9738. * rendering/RenderPath.h:
  9739. * rendering/RenderSVGContainer.cpp:
  9740. * rendering/RenderSVGContainer.h:
  9741. (WebCore::RenderSVGContainer::calculateLocalTransform):
  9742. * rendering/RenderSVGImage.cpp:
  9743. (WebCore::RenderSVGImage::layout):
  9744. * rendering/RenderSVGImage.h:
  9745. * rendering/RenderSVGText.cpp:
  9746. (WebCore::RenderSVGText::layout):
  9747. * rendering/RenderSVGText.h:
  9748. * rendering/RenderSVGTransformableContainer.cpp:
  9749. (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  9750. * rendering/RenderSVGTransformableContainer.h:
  9751. 2009-05-03 Eric Seidel <eric@webkit.org>
  9752. Reviewed by Simon Fraser.
  9753. Move more code into SVGRenderBase
  9754. https://bugs.webkit.org/show_bug.cgi?id=25532
  9755. clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
  9756. are now all shared via SVGRenderBase.
  9757. RenderForeignObject should also be sharing this code, but I've left it
  9758. alone for now, as changing that would likely cause test changes.
  9759. No test changes. It's possible that transformed <svg:image> elements will
  9760. now show up with better metrics in the inspector.
  9761. * rendering/RenderSVGImage.cpp:
  9762. (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
  9763. (WebCore::RenderSVGImage::computeRectForRepaint):
  9764. (WebCore::RenderSVGImage::mapLocalToContainer):
  9765. * rendering/RenderSVGImage.h:
  9766. * rendering/RenderSVGModelObject.cpp:
  9767. (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
  9768. (WebCore::RenderSVGModelObject::computeRectForRepaint):
  9769. (WebCore::RenderSVGModelObject::mapLocalToContainer):
  9770. * rendering/RenderSVGText.cpp:
  9771. (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
  9772. (WebCore::RenderSVGText::computeRectForRepaint):
  9773. (WebCore::RenderSVGText::mapLocalToContainer):
  9774. * rendering/SVGRenderSupport.cpp:
  9775. (WebCore::SVGRenderBase::clippedOverflowRectForRepaint):
  9776. (WebCore::SVGRenderBase::computeRectForRepaint):
  9777. (WebCore::SVGRenderBase::mapLocalToContainer):
  9778. * rendering/SVGRenderSupport.h:
  9779. 2009-05-03 Eric Seidel <eric@webkit.org>
  9780. Reviewed by Simon Fraser.
  9781. Add SVGRenderBase to share logic between SVG renderers
  9782. https://bugs.webkit.org/show_bug.cgi?id=25532
  9783. I've added an SVGRenderBase base class which is shared by
  9784. all of the SVG renders now. This patch is just moving code
  9785. there are no functional changes in this patch.
  9786. Currently I've left these functions in SVGRenderSupport.h
  9787. In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*
  9788. clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.
  9789. * rendering/RenderSVGBlock.h:
  9790. * rendering/RenderSVGImage.h:
  9791. * rendering/RenderSVGModelObject.h:
  9792. * rendering/RenderSVGRoot.h:
  9793. * rendering/SVGRenderSupport.cpp:
  9794. (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  9795. (WebCore::SVGRenderBase::finishRenderSVGContent):
  9796. (WebCore::clampImageBufferSizeToViewport):
  9797. (WebCore::SVGRenderBase::computeContainerBoundingBox):
  9798. (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  9799. * rendering/SVGRenderSupport.h:
  9800. * rendering/SVGRootInlineBox.cpp:
  9801. (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
  9802. (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
  9803. (WebCore::SVGRootInlineBox::paint):
  9804. * svg/SVGMaskElement.cpp:
  9805. (WebCore::SVGMaskElement::drawMaskerContent):
  9806. * svg/SVGPatternElement.cpp:
  9807. (WebCore::SVGPatternElement::buildPattern):
  9808. * svg/graphics/SVGPaintServerGradient.cpp:
  9809. (WebCore::createMaskAndSwapContextForTextGradient):
  9810. (WebCore::clipToTextMask):
  9811. 2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
  9812. Unreviewed SVG build fix.
  9813. Include MappedAttribute.h after r43187.
  9814. * svg/SVGComponentTransferFunctionElement.cpp:
  9815. * svg/SVGFEBlendElement.cpp:
  9816. * svg/SVGFEColorMatrixElement.cpp:
  9817. * svg/SVGFEComponentTransferElement.cpp:
  9818. * svg/SVGFECompositeElement.cpp:
  9819. * svg/SVGFEDiffuseLightingElement.cpp:
  9820. * svg/SVGFEDisplacementMapElement.cpp:
  9821. * svg/SVGFEGaussianBlurElement.cpp:
  9822. * svg/SVGFEImageElement.cpp:
  9823. * svg/SVGFELightElement.cpp:
  9824. * svg/SVGFEMergeNodeElement.cpp:
  9825. * svg/SVGFEOffsetElement.cpp:
  9826. * svg/SVGFESpecularLightingElement.cpp:
  9827. * svg/SVGFETileElement.cpp:
  9828. * svg/SVGFETurbulenceElement.cpp:
  9829. * svg/SVGFilterElement.cpp:
  9830. * svg/SVGFilterPrimitiveStandardAttributes.cpp:
  9831. 2009-05-04 Brady Eidson <beidson@apple.com>
  9832. Reviewed by Sam 'The Belly' Weinig
  9833. <rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only
  9834. In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
  9835. themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.
  9836. The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
  9837. the canLoad() check if a codebase was actually set on the applet tag.
  9838. * html/HTMLAppletElement.cpp:
  9839. (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
  9840. * loader/FrameLoader.cpp:
  9841. (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
  9842. 2009-05-04 Adam Roben <aroben@apple.com>
  9843. Windows build fix
  9844. * html/HTMLCollection.h:
  9845. * html/HTMLFormElement.h:
  9846. Declare CollectionCache as a struct, not a class, to match its
  9847. definition.
  9848. 2009-05-04 Chris Fleizach <cfleizach@apple.com>
  9849. Reviewed by Beth Dakin, Oliver Hunt.
  9850. Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
  9851. https://bugs.webkit.org/show_bug.cgi?id=25557
  9852. Test: accessibility/canvas.html
  9853. * page/AccessibilityRenderObject.cpp:
  9854. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  9855. (WebCore::AccessibilityRenderObject::roleValue):
  9856. 2009-05-04 Brady Eidson <beidson@apple.com>
  9857. Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.
  9858. * ChangeLog
  9859. 2009-05-04 Kai Brüning <kai@granus.net>
  9860. Reviewed by Eric Seidel.
  9861. https://bugs.webkit.org/show_bug.cgi?id=24883
  9862. 24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
  9863. Fixed test whether all the chunk has been processed to correctly count utf8 bytes.
  9864. Test: fast/innerHTML/innerHTML-nbsp.xhtml
  9865. * dom/XMLTokenizerLibxml2.cpp:
  9866. (WebCore::parseXMLDocumentFragment):
  9867. 2009-05-04 Darin Adler <darin@apple.com>
  9868. Reviewed by Eric Seidel.
  9869. Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
  9870. and NamedMappedAttrMap.h include of MappedAttribute.h
  9871. https://bugs.webkit.org/show_bug.cgi?id=24924
  9872. Make compiles faster, and debugging info smaller.
  9873. * GNUmakefile.am: Added new source files.
  9874. * WebCore.pro: Ditto.
  9875. * WebCore.scons: Ditto.
  9876. * WebCore.vcproj/WebCore.vcproj: Ditto.
  9877. * WebCore.xcodeproj/project.pbxproj: Ditto.
  9878. * WebCoreSources.bkl: Ditto.
  9879. * bindings/js/JSHTMLCollectionCustom.cpp:
  9880. (WebCore::toJS): Updated for new collection type names.
  9881. * dom/Document.cpp:
  9882. (WebCore::Document::createAttribute): Added. No longer inline.
  9883. (WebCore::Document::images): Updated for new collection type names.
  9884. (WebCore::Document::applets): Ditto.
  9885. (WebCore::Document::embeds): Ditto.
  9886. (WebCore::Document::plugins): Ditto.
  9887. (WebCore::Document::objects): Ditto.
  9888. (WebCore::Document::scripts): Ditto.
  9889. (WebCore::Document::links): Ditto.
  9890. (WebCore::Document::forms): Ditto.
  9891. (WebCore::Document::anchors): Ditto.
  9892. (WebCore::Document::all): Ditto.
  9893. (WebCore::Document::windowNamedItems): Ditto.
  9894. (WebCore::Document::documentNamedItems): Ditto.
  9895. (WebCore::Document::nameCollectionInfo): Ditto.
  9896. * dom/Document.h: Changed around includes and forward declarations.
  9897. Updated for changes to collection types.
  9898. * dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
  9899. * html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
  9900. Contains the class that used to be HTMLCollection::CollectionInfo.
  9901. * html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
  9902. Ditto.
  9903. * html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
  9904. Has the enum that used to be HTMLCollection::Type.
  9905. * html/HTMLCollection.cpp:
  9906. (WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
  9907. (WebCore::HTMLCollection::create): Ditto.
  9908. (WebCore::HTMLCollection::resetCollectionInfo): Ditto.
  9909. (WebCore::HTMLCollection::itemAfter): Ditto.
  9910. * html/HTMLCollection.h: Ditto.
  9911. * html/HTMLElement.cpp:
  9912. (WebCore::HTMLElement::children): Updated for new collection type names.
  9913. * html/HTMLFormCollection.cpp:
  9914. (WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
  9915. (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
  9916. * html/HTMLFormCollection.h: Ditto.
  9917. * html/HTMLFormElement.h: Ditto.
  9918. * html/HTMLMapElement.cpp:
  9919. (WebCore::HTMLMapElement::areas): Ditto.
  9920. * html/HTMLNameCollection.cpp:
  9921. (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
  9922. * html/HTMLNameCollection.h:
  9923. (WebCore::HTMLNameCollection::create): Ditto.
  9924. * html/HTMLSelectElement.h:
  9925. (WebCore::HTMLSelectElement::collectionInfo): Ditto.
  9926. * html/HTMLTableElement.cpp:
  9927. (WebCore::HTMLTableElement::tBodies):Ditto.
  9928. * html/HTMLTableRowElement.cpp:
  9929. (WebCore::HTMLTableRowElement::cells):Ditto.
  9930. * html/HTMLTableRowsCollection.cpp:
  9931. (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
  9932. * html/HTMLTableSectionElement.cpp:
  9933. (WebCore::HTMLTableSectionElement::rows): Ditto.
  9934. * bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
  9935. * bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
  9936. * css/CSSStyleSelector.cpp: Ditto.
  9937. * dom/Element.cpp: Ditto.
  9938. * dom/InputElement.cpp: Ditto.
  9939. * dom/NamedAttrMap.cpp: Ditto.
  9940. * dom/NamedMappedAttrMap.cpp: Ditto.
  9941. * dom/Node.cpp: Ditto.
  9942. * dom/StyledElement.cpp: Ditto.
  9943. * dom/StyledElement.h: Ditto.
  9944. * editing/ApplyStyleCommand.cpp: Ditto.
  9945. * editing/DeleteSelectionCommand.cpp: Ditto.
  9946. * editing/Editor.cpp: Ditto.
  9947. * editing/EditorCommand.cpp: Ditto.
  9948. * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
  9949. * editing/ReplaceSelectionCommand.cpp: Ditto.
  9950. * editing/markup.cpp: Ditto.
  9951. * html/CanvasRenderingContext2D.cpp: Ditto.
  9952. * html/HTMLAnchorElement.cpp: Ditto.
  9953. * html/HTMLAppletElement.cpp: Ditto.
  9954. * html/HTMLAreaElement.cpp: Ditto.
  9955. * html/HTMLBRElement.cpp: Ditto.
  9956. * html/HTMLBaseElement.cpp: Ditto.
  9957. * html/HTMLBodyElement.cpp: Ditto.
  9958. * html/HTMLButtonElement.cpp: Ditto.
  9959. * html/HTMLCanvasElement.cpp: Ditto.
  9960. * html/HTMLDivElement.cpp: Ditto.
  9961. * html/HTMLEmbedElement.cpp: Ditto.
  9962. * html/HTMLFontElement.cpp: Ditto.
  9963. * html/HTMLFormControlElement.cpp: Ditto.
  9964. * html/HTMLFormElement.cpp: Ditto.
  9965. * html/HTMLFrameElement.cpp: Ditto.
  9966. * html/HTMLFrameElementBase.cpp: Ditto.
  9967. * html/HTMLFrameSetElement.cpp: Ditto.
  9968. * html/HTMLHRElement.cpp: Ditto.
  9969. * html/HTMLIFrameElement.cpp: Ditto.
  9970. * html/HTMLImageElement.cpp: Ditto.
  9971. * html/HTMLInputElement.cpp: Ditto.
  9972. * html/HTMLIsIndexElement.cpp: Ditto.
  9973. * html/HTMLKeygenElement.cpp: Ditto.
  9974. * html/HTMLLIElement.cpp: Ditto.
  9975. * html/HTMLLinkElement.cpp: Ditto.
  9976. * html/HTMLMarqueeElement.cpp: Ditto.
  9977. * html/HTMLMetaElement.cpp: Ditto.
  9978. * html/HTMLOListElement.cpp: Ditto.
  9979. * html/HTMLObjectElement.cpp: Ditto.
  9980. * html/HTMLOptionElement.cpp: Ditto.
  9981. * html/HTMLParagraphElement.cpp: Ditto.
  9982. * html/HTMLParamElement.cpp: Ditto.
  9983. * html/HTMLPlugInElement.cpp: Ditto.
  9984. * html/HTMLPreElement.cpp: Ditto.
  9985. * html/HTMLScriptElement.cpp: Ditto.
  9986. * html/HTMLSelectElement.cpp: Ditto.
  9987. * html/HTMLStyleElement.cpp: Ditto.
  9988. * html/HTMLTableCaptionElement.cpp: Ditto.
  9989. * html/HTMLTableCellElement.cpp: Ditto.
  9990. * html/HTMLTableColElement.cpp: Ditto.
  9991. * html/HTMLTablePartElement.cpp: Ditto.
  9992. * html/HTMLTextAreaElement.cpp: Ditto.
  9993. * html/HTMLTokenizer.cpp: Ditto.
  9994. * html/HTMLUListElement.cpp: Ditto.
  9995. * html/HTMLVideoElement.cpp: Ditto.
  9996. * html/HTMLViewSourceDocument.cpp: Ditto.
  9997. * loader/ImageDocument.cpp: Ditto.
  9998. * page/Frame.cpp: Ditto.
  9999. * rendering/RenderTreeAsText.cpp: Ditto.
  10000. * svg/SVGAElement.cpp: Ditto.
  10001. * svg/SVGAnimateMotionElement.cpp: Ditto.
  10002. * svg/SVGAnimateTransformElement.cpp: Ditto.
  10003. * svg/SVGAnimationElement.cpp: Ditto.
  10004. * svg/SVGCircleElement.cpp: Ditto.
  10005. * svg/SVGClipPathElement.cpp: Ditto.
  10006. * svg/SVGCursorElement.cpp: Ditto.
  10007. * svg/SVGElement.cpp: Ditto.
  10008. * svg/SVGEllipseElement.cpp: Ditto.
  10009. * svg/SVGExternalResourcesRequired.cpp: Ditto.
  10010. * svg/SVGFitToViewBox.cpp: Ditto.
  10011. * svg/SVGFontFaceElement.cpp: Ditto.
  10012. * svg/SVGFontFaceUriElement.cpp: Ditto.
  10013. * svg/SVGForeignObjectElement.cpp: Ditto.
  10014. * svg/SVGGlyphElement.cpp: Ditto.
  10015. * svg/SVGGradientElement.cpp: Ditto.
  10016. * svg/SVGImageElement.cpp: Ditto.
  10017. * svg/SVGLangSpace.cpp: Ditto.
  10018. * svg/SVGLineElement.cpp: Ditto.
  10019. * svg/SVGLinearGradientElement.cpp: Ditto.
  10020. * svg/SVGMarkerElement.cpp: Ditto.
  10021. * svg/SVGMaskElement.cpp: Ditto.
  10022. * svg/SVGPathElement.cpp: Ditto.
  10023. * svg/SVGPatternElement.cpp: Ditto.
  10024. * svg/SVGPolyElement.cpp: Ditto.
  10025. * svg/SVGRadialGradientElement.cpp: Ditto.
  10026. * svg/SVGRectElement.cpp: Ditto.
  10027. * svg/SVGSVGElement.cpp: Ditto.
  10028. * svg/SVGScriptElement.cpp: Ditto.
  10029. * svg/SVGStopElement.cpp: Ditto.
  10030. * svg/SVGStyleElement.cpp: Ditto.
  10031. * svg/SVGStyledElement.cpp: Ditto.
  10032. * svg/SVGStyledTransformableElement.cpp: Ditto.
  10033. * svg/SVGTests.cpp: Ditto.
  10034. * svg/SVGTextContentElement.cpp: Ditto.
  10035. * svg/SVGTextElement.cpp: Ditto.
  10036. * svg/SVGTextPathElement.cpp: Ditto.
  10037. * svg/SVGTextPositioningElement.cpp: Ditto.
  10038. * svg/SVGURIReference.cpp: Ditto.
  10039. * svg/SVGUseElement.cpp: Ditto.
  10040. * svg/SVGViewElement.cpp: Ditto.
  10041. * svg/animation/SVGSMILElement.cpp: Ditto.
  10042. * xml/XPathStep.cpp: Ditto.
  10043. 2009-05-04 Pavel Feldman <pfeldman@chromium.org>
  10044. Reviewed by Timothy Hatcher.
  10045. Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
  10046. https://bugs.webkit.org/show_bug.cgi?id=25520
  10047. * inspector/front-end/inspector.js:
  10048. (WebInspector.loaded):
  10049. 2009-05-04 Brady Eidson <beidson@apple.com>
  10050. Reviewed by Darin Adler.
  10051. <rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window
  10052. DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
  10053. particularly sticky behavior.
  10054. If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
  10055. prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
  10056. from the WebArchive.
  10057. In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
  10058. loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.
  10059. When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
  10060. ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
  10061. WebResource is returned, and the client thinks the subresource doesn't exist even though it does.
  10062. This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.
  10063. * loader/DocumentLoader.cpp:
  10064. (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the
  10065. ArchiveResource.
  10066. 2009-05-04 Eric Carlson <eric.carlson@apple.com>
  10067. Reviewed by Adam Roben.
  10068. https://bugs.webkit.org/show_bug.cgi?id=25545
  10069. Bug 25545: HTMLMediaElement: display anamorphic video correctly
  10070. Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
  10071. and displayed correctly.
  10072. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  10073. (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
  10074. * platform/graphics/win/QTMovieWin.cpp:
  10075. (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't
  10076. filled beyond capacity.
  10077. 2009-05-03 Mark Rowe <mrowe@apple.com>
  10078. Reviewed by Darin Adler.
  10079. Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
  10080. Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load
  10081. Only the first plug-in in a PluginDocument can use the main resource data. For all
  10082. subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
  10083. out for the real Flash plug-in, we need to load the resource data in the same manner
  10084. as for other embedded plug-ins.
  10085. * loader/FrameLoader.cpp:
  10086. (WebCore::FrameLoader::loadPlugin):
  10087. 2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>
  10088. Rubber-stamped by Ariya Hidayat.
  10089. Update the qrc file for the Web Inspector in the Qt build
  10090. with missing files.
  10091. * inspector/front-end/WebKit.qrc:
  10092. 2009-05-03 Eric Seidel <eric@webkit.org>
  10093. Reviewed by George Staikos.
  10094. Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
  10095. https://bugs.webkit.org/show_bug.cgi?id=25532
  10096. * rendering/RenderSVGInline.cpp:
  10097. (WebCore::RenderSVGInline::absoluteRects):
  10098. (WebCore::RenderSVGInline::absoluteQuads):
  10099. * rendering/RenderSVGInline.h:
  10100. * rendering/RenderSVGTSpan.cpp:
  10101. * rendering/RenderSVGTSpan.h:
  10102. * rendering/RenderSVGTextPath.cpp:
  10103. * rendering/RenderSVGTextPath.h:
  10104. 2009-05-03 Eric Seidel <eric@webkit.org>
  10105. Reviewed by George Staikos.
  10106. Move RenderSVGText off of localToAbsolute()
  10107. https://bugs.webkit.org/show_bug.cgi?id=25532
  10108. * rendering/RenderSVGText.cpp:
  10109. (WebCore::RenderSVGText::absoluteRects):
  10110. (WebCore::RenderSVGText::absoluteQuads):
  10111. 2009-05-03 Eric Seidel <eric@webkit.org>
  10112. Reviewed by George Staikos.
  10113. Remove broken absoluteTransform() code from RenderSVGInlineText
  10114. https://bugs.webkit.org/show_bug.cgi?id=25532
  10115. This improved SVG text focus rings.
  10116. This also improved SVG.getScreenCTM() results.
  10117. SVGSVGElement::getScreenCTM was passing "true" for the second argument in
  10118. localToAbsolute, which is "fixed" it meant to pass "true" for the
  10119. third argument (useTransforms). That change alone caused no layout test changes, however
  10120. before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer
  10121. mapLocalToContainer implementations really should be shared,
  10122. but I'll do that in a later patch.
  10123. * rendering/RenderSVGInlineText.cpp:
  10124. (WebCore::RenderSVGInlineText::styleDidChange):
  10125. (WebCore::RenderSVGInlineText::absoluteQuads):
  10126. (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  10127. (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
  10128. * rendering/RenderSVGInlineText.h:
  10129. * rendering/RenderSVGRoot.cpp:
  10130. (WebCore::RenderSVGRoot::mapLocalToContainer):
  10131. * rendering/RenderSVGRoot.h:
  10132. * rendering/RenderSVGText.cpp:
  10133. (WebCore::RenderSVGText::mapLocalToContainer):
  10134. * rendering/RenderSVGText.h:
  10135. * svg/SVGSVGElement.cpp:
  10136. (WebCore::SVGSVGElement::getScreenCTM):
  10137. 2009-05-03 Eric Seidel <eric@webkit.org>
  10138. Reviewed by George Staikos.
  10139. Remove dead code from RenderPath
  10140. https://bugs.webkit.org/show_bug.cgi?id=25532
  10141. * rendering/RenderPath.cpp:
  10142. * rendering/RenderPath.h:
  10143. 2009-05-03 Eric Seidel <eric@webkit.org>
  10144. Reviewed by George Staikos.
  10145. Share layout code between RenderSVGViewportContainer and RenderSVGContainer
  10146. https://bugs.webkit.org/show_bug.cgi?id=25532
  10147. * rendering/RenderSVGContainer.cpp:
  10148. (WebCore::RenderSVGContainer::layout):
  10149. * rendering/RenderSVGContainer.h:
  10150. (WebCore::RenderSVGContainer::calcViewport):
  10151. * rendering/RenderSVGViewportContainer.cpp:
  10152. (WebCore::RenderSVGViewportContainer::applyViewportClip):
  10153. * rendering/RenderSVGViewportContainer.h:
  10154. 2009-05-03 Eric Seidel <eric@webkit.org>
  10155. Reviewed by George Staikos.
  10156. Remove redundant disableLayoutState() calls
  10157. https://bugs.webkit.org/show_bug.cgi?id=25532
  10158. * rendering/RenderForeignObject.cpp:
  10159. (WebCore::RenderForeignObject::layout):
  10160. * rendering/RenderSVGContainer.cpp:
  10161. (WebCore::RenderSVGContainer::layout):
  10162. * rendering/RenderSVGViewportContainer.cpp:
  10163. (WebCore::RenderSVGViewportContainer::layout):
  10164. 2009-05-03 Eric Seidel <eric@webkit.org>
  10165. Reviewed by George Staikos.
  10166. Simplify RenderForeignObject::paint and fix a repaint bug.
  10167. Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
  10168. https://bugs.webkit.org/show_bug.cgi?id=16939
  10169. * rendering/RenderForeignObject.cpp:
  10170. (WebCore::RenderForeignObject::paint):
  10171. 2009-05-03 Hironori Bono <hbono@chromium.org>
  10172. Reviewed by Eric Seidel.
  10173. Test: editing/spelling/spellcheck-attribute.html
  10174. Bug 14552: Add a way to disable spell checking for specific element
  10175. https://bugs.webkit.org/show_bug.cgi?id=14552
  10176. For compatibility with Firefox, this code ascends the DOM tree when an element does
  10177. not have its "spellcheck" attribute.
  10178. * editing/Editor.cpp:
  10179. (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck"
  10180. attribute of an element before calling a spell checker or a grammar checker.
  10181. * html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
  10182. 2009-05-03 Sam Weinig <sam@webkit.org>
  10183. Roll JSC API number marshaling back in one last time (I hope).
  10184. 2009-05-03 Sam Weinig <sam@webkit.org>
  10185. Roll JSC API number marshaling back out. It still breaks windows.
  10186. 2009-05-03 Sam Weinig <sam@webkit.org>
  10187. Roll JSC API number marshaling back in.
  10188. 2009-05-02 Dan Bernstein <mitz@apple.com>
  10189. Reviewed by Darin Adler.
  10190. - another fix for <rdar://problem/6617298> Typing delete on an unquoted
  10191. blank line unquotes the preceding, quoted blank line
  10192. Test: editing/deleting/type-delete-after-quote-2.html
  10193. * editing/DeleteSelectionCommand.cpp:
  10194. (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize
  10195. m_startsAtEmptyLine.
  10196. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the
  10197. selection starts at an empty line, do not prevent the merging of blocks.
  10198. This is what allows the text after the line break to be merged into the
  10199. block containing the line break. Also set m_startsAtEmptyLine to true.
  10200. (WebCore::DeleteSelectionCommand::mergeParagraphs): If
  10201. m_startsAtEmptyLine is true, create a placeholder BR to serve as the
  10202. merge destination.
  10203. * editing/DeleteSelectionCommand.h:
  10204. 2009-05-02 Geoffrey Garen <ggaren@apple.com>
  10205. Reviewed by Sam Weinig.
  10206. Simplified null-ish JSValues.
  10207. Replaced calls to noValue() with calls to JSValue() (which is what
  10208. noValue() returned). Removed noValue().
  10209. Removed "JSValue()" initialiazers, since default construction happens...
  10210. by default.
  10211. * bindings/js/JSDOMBinding.cpp:
  10212. (WebCore::setDOMException):
  10213. * bindings/js/JSDOMWindowCustom.cpp:
  10214. (WebCore::JSDOMWindow::open):
  10215. (WebCore::JSDOMWindow::showModalDialog):
  10216. * bindings/js/JSEventListener.cpp:
  10217. (WebCore::JSEventListener::handleEvent):
  10218. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  10219. (WebCore::JSJavaScriptCallFrame::evaluate):
  10220. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  10221. (WebCore::JSSQLResultSetRowList::item):
  10222. * bindings/js/ScriptController.cpp:
  10223. (WebCore::ScriptController::evaluate):
  10224. * bindings/js/ScriptValue.h:
  10225. (WebCore::ScriptValue::ScriptValue):
  10226. (WebCore::ScriptValue::hasNoValue):
  10227. * bindings/js/WorkerScriptController.cpp:
  10228. (WebCore::WorkerScriptController::evaluate):
  10229. * bridge/jni/jni_instance.cpp:
  10230. (JavaInstance::invokeMethod):
  10231. * bridge/jni/jni_runtime.cpp:
  10232. (JavaField::dispatchValueFromInstance):
  10233. (JavaField::dispatchSetValueToInstance):
  10234. * bridge/runtime.h:
  10235. (JSC::Bindings::Instance::invokeConstruct):
  10236. 2009-05-02 Antti Koivisto <antti@apple.com>
  10237. Reviewed by Dan Bernstein.
  10238. <rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)
  10239. Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().
  10240. * dom/ContainerNode.cpp:
  10241. (WebCore::ContainerNode::suspendPostAttachCallbacks):
  10242. (WebCore::ContainerNode::resumePostAttachCallbacks):
  10243. (WebCore::ContainerNode::attach):
  10244. * dom/Element.cpp:
  10245. (WebCore::Element::attach):
  10246. * loader/loader.cpp:
  10247. (WebCore::Loader::Loader):
  10248. (WebCore::Loader::servePendingRequests):
  10249. (WebCore::Loader::suspendPendingRequests):
  10250. (WebCore::Loader::resumePendingRequests):
  10251. (WebCore::Loader::Host::servePendingRequests):
  10252. * loader/loader.h:
  10253. (WebCore::Loader::isSuspendingPendingRequests):
  10254. 2009-05-02 Darin Adler <darin@apple.com>
  10255. Reviewed by Dan Bernstein.
  10256. Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
  10257. https://bugs.webkit.org/show_bug.cgi?id=25352
  10258. rdar://problem/6823239
  10259. Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
  10260. * platform/network/HTTPParsers.cpp:
  10261. (WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.
  10262. 2009-05-02 Darin Adler <darin@apple.com>
  10263. Reviewed by Brady Eidson.
  10264. Bug 25491: WebFrame leak when a subframe removes itself
  10265. https://bugs.webkit.org/show_bug.cgi?id=25491
  10266. rdar://problem/6833859
  10267. Test: fast/loading/subframe-removes-itself.html
  10268. * loader/FrameLoader.cpp:
  10269. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true,
  10270. treat load as complete, even if isLoadingInAPISense is still returning true.
  10271. 2009-05-01 Sam Weinig <sam@webkit.org>
  10272. Roll out JavaScriptCore API number marshaling.
  10273. * bindings/js/ScriptValue.cpp:
  10274. (WebCore::ScriptValue::isEqual):
  10275. * inspector/JavaScriptProfile.cpp:
  10276. (WebCore::getHeadCallback):
  10277. * inspector/JavaScriptProfileNode.cpp:
  10278. (WebCore::getChildren):
  10279. (WebCore::getParent):
  10280. (WebCore::getHead):
  10281. 2009-05-01 Sam Weinig <sam@webkit.org>
  10282. Fix build.
  10283. * workers/WorkerContext.idl:
  10284. 2009-05-01 Sam Weinig <sam@webkit.org>
  10285. Reviewed by Oliver Hunt.
  10286. Cleanup workers code a bit.
  10287. * bindings/js/JSWorkerContextBase.cpp:
  10288. (WebCore::toJS):
  10289. * bindings/js/JSWorkerContextBase.h:
  10290. * bindings/js/JSWorkerContextCustom.cpp:
  10291. (WebCore::JSWorkerContext::customGetOwnPropertySlot):
  10292. * workers/WorkerContext.h:
  10293. (WebCore::WorkerContext::toWorkerContext):
  10294. (WebCore::WorkerContext::self):
  10295. (WebCore::WorkerContext::setOnmessage):
  10296. (WebCore::WorkerContext::onmessage):
  10297. * workers/WorkerContext.idl:
  10298. 2009-05-01 Sam Weinig <sam@webkit.org>
  10299. Reviewed by Darin Adler.
  10300. A little clean up.
  10301. * loader/FrameLoader.cpp:
  10302. (WebCore::FrameLoader::createJavaAppletWidget):
  10303. 2009-05-01 Sam Weinig <sam@webkit.org>
  10304. Fix the build.
  10305. * bindings/js/ScriptValue.cpp:
  10306. (WebCore::ScriptValue::isEqual):
  10307. * inspector/JavaScriptProfile.cpp:
  10308. (WebCore::getHeadCallback):
  10309. * inspector/JavaScriptProfileNode.cpp:
  10310. (WebCore::getChildren):
  10311. (WebCore::getParent):
  10312. (WebCore::getHead):
  10313. 2009-05-01 Brady Eidson <beidson@apple.com>
  10314. Reviewed by Oliver Hunt and Sam "Jon 'The Belly' Honeycutt" Weinig
  10315. Fix <rdar://problem/6848867> Addition of DOCTYPE node breaks Tiger Mail
  10316. * bindings/objc/DOMHTML.mm:
  10317. (-[DOMHTMLDocument firstChild]): Add a Tiger Mail version of this method that skips DOCTYPE nodes.
  10318. 2009-05-01 Geoffrey Garen <ggaren@apple.com>
  10319. Rubber Stamped by Sam Weinig.
  10320. Renamed JSValuePtr => JSValue.
  10321. * bindings/js/JSAttrCustom.cpp:
  10322. (WebCore::JSAttr::setValue):
  10323. * bindings/js/JSCDATASectionCustom.cpp:
  10324. (WebCore::toJSNewlyCreated):
  10325. * bindings/js/JSCSSRuleCustom.cpp:
  10326. (WebCore::toJS):
  10327. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  10328. (WebCore::JSCSSStyleDeclaration::nameGetter):
  10329. (WebCore::JSCSSStyleDeclaration::customPut):
  10330. * bindings/js/JSCSSValueCustom.cpp:
  10331. (WebCore::toJS):
  10332. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  10333. (WebCore::toJS):
  10334. (WebCore::toHTMLCanvasStyle):
  10335. (WebCore::JSCanvasRenderingContext2D::strokeStyle):
  10336. (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
  10337. (WebCore::JSCanvasRenderingContext2D::fillStyle):
  10338. (WebCore::JSCanvasRenderingContext2D::setFillStyle):
  10339. (WebCore::JSCanvasRenderingContext2D::setFillColor):
  10340. (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
  10341. (WebCore::JSCanvasRenderingContext2D::strokeRect):
  10342. (WebCore::JSCanvasRenderingContext2D::drawImage):
  10343. (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
  10344. (WebCore::JSCanvasRenderingContext2D::setShadow):
  10345. (WebCore::JSCanvasRenderingContext2D::createPattern):
  10346. (WebCore::JSCanvasRenderingContext2D::putImageData):
  10347. (WebCore::JSCanvasRenderingContext2D::fillText):
  10348. (WebCore::JSCanvasRenderingContext2D::strokeText):
  10349. * bindings/js/JSClipboardCustom.cpp:
  10350. (WebCore::JSClipboard::types):
  10351. (WebCore::JSClipboard::clearData):
  10352. (WebCore::JSClipboard::getData):
  10353. (WebCore::JSClipboard::setData):
  10354. (WebCore::JSClipboard::setDragImage):
  10355. * bindings/js/JSConsoleCustom.cpp:
  10356. (WebCore::JSConsole::profiles):
  10357. * bindings/js/JSCoordinatesCustom.cpp:
  10358. (WebCore::JSCoordinates::altitude):
  10359. (WebCore::JSCoordinates::altitudeAccuracy):
  10360. (WebCore::JSCoordinates::heading):
  10361. (WebCore::JSCoordinates::speed):
  10362. * bindings/js/JSCustomPositionCallback.cpp:
  10363. (WebCore::JSCustomPositionCallback::handleEvent):
  10364. * bindings/js/JSCustomPositionErrorCallback.cpp:
  10365. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  10366. * bindings/js/JSCustomSQLStatementCallback.cpp:
  10367. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  10368. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  10369. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  10370. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  10371. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  10372. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  10373. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  10374. * bindings/js/JSCustomVoidCallback.cpp:
  10375. (WebCore::JSCustomVoidCallback::handleEvent):
  10376. (WebCore::toVoidCallback):
  10377. * bindings/js/JSCustomVoidCallback.h:
  10378. * bindings/js/JSCustomXPathNSResolver.cpp:
  10379. (WebCore::JSCustomXPathNSResolver::create):
  10380. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  10381. * bindings/js/JSCustomXPathNSResolver.h:
  10382. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  10383. (WebCore::JSDOMApplicationCache::hasItem):
  10384. (WebCore::JSDOMApplicationCache::add):
  10385. (WebCore::JSDOMApplicationCache::remove):
  10386. (WebCore::JSDOMApplicationCache::addEventListener):
  10387. (WebCore::JSDOMApplicationCache::removeEventListener):
  10388. * bindings/js/JSDOMBinding.cpp:
  10389. (WebCore::jsStringOrNull):
  10390. (WebCore::jsOwnedStringOrNull):
  10391. (WebCore::jsStringOrUndefined):
  10392. (WebCore::jsStringOrFalse):
  10393. (WebCore::valueToStringWithNullCheck):
  10394. (WebCore::valueToStringWithUndefinedOrNullCheck):
  10395. (WebCore::reportException):
  10396. (WebCore::reportCurrentException):
  10397. (WebCore::setDOMException):
  10398. (WebCore::objectToStringFunctionGetter):
  10399. * bindings/js/JSDOMBinding.h:
  10400. (WebCore::getDOMObjectWrapper):
  10401. (WebCore::getDOMNodeWrapper):
  10402. (WebCore::toJS):
  10403. * bindings/js/JSDOMGlobalObject.cpp:
  10404. (WebCore::JSDOMGlobalObject::findJSEventListener):
  10405. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  10406. (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
  10407. * bindings/js/JSDOMGlobalObject.h:
  10408. * bindings/js/JSDOMStringListCustom.cpp:
  10409. (WebCore::JSDOMStringList::getByIndex):
  10410. (WebCore::JSDOMStringList::item):
  10411. * bindings/js/JSDOMWindowBase.cpp:
  10412. (WebCore::JSDOMWindowBase::childFrameGetter):
  10413. (WebCore::JSDOMWindowBase::indexGetter):
  10414. (WebCore::JSDOMWindowBase::namedItemGetter):
  10415. (WebCore::JSDOMWindowBase::getOwnPropertySlot):
  10416. (WebCore::JSDOMWindowBase::put):
  10417. (WebCore::JSDOMWindowBase::setReturnValueSlot):
  10418. (WebCore::toJS):
  10419. (WebCore::toJSDOMWindow):
  10420. * bindings/js/JSDOMWindowBase.h:
  10421. * bindings/js/JSDOMWindowCustom.cpp:
  10422. (WebCore::JSDOMWindow::lookupGetter):
  10423. (WebCore::JSDOMWindow::lookupSetter):
  10424. (WebCore::JSDOMWindow::history):
  10425. (WebCore::JSDOMWindow::location):
  10426. (WebCore::JSDOMWindow::setLocation):
  10427. (WebCore::JSDOMWindow::crypto):
  10428. (WebCore::JSDOMWindow::event):
  10429. (WebCore::JSDOMWindow::image):
  10430. (WebCore::JSDOMWindow::option):
  10431. (WebCore::JSDOMWindow::audio):
  10432. (WebCore::JSDOMWindow::webKitPoint):
  10433. (WebCore::JSDOMWindow::webKitCSSMatrix):
  10434. (WebCore::JSDOMWindow::xmlHttpRequest):
  10435. (WebCore::JSDOMWindow::xsltProcessor):
  10436. (WebCore::JSDOMWindow::messageChannel):
  10437. (WebCore::JSDOMWindow::worker):
  10438. (WebCore::createWindow):
  10439. (WebCore::JSDOMWindow::open):
  10440. (WebCore::JSDOMWindow::showModalDialog):
  10441. (WebCore::JSDOMWindow::postMessage):
  10442. (WebCore::JSDOMWindow::setTimeout):
  10443. (WebCore::JSDOMWindow::setInterval):
  10444. (WebCore::JSDOMWindow::atob):
  10445. (WebCore::JSDOMWindow::btoa):
  10446. (WebCore::JSDOMWindow::addEventListener):
  10447. (WebCore::JSDOMWindow::removeEventListener):
  10448. (WebCore::toDOMWindow):
  10449. * bindings/js/JSDOMWindowCustom.h:
  10450. (WebCore::nonCachingStaticFunctionGetter):
  10451. (WebCore::JSDOMWindow::customPut):
  10452. * bindings/js/JSDOMWindowShell.cpp:
  10453. (WebCore::JSDOMWindowShell::put):
  10454. (WebCore::JSDOMWindowShell::putWithAttributes):
  10455. (WebCore::JSDOMWindowShell::lookupGetter):
  10456. (WebCore::JSDOMWindowShell::lookupSetter):
  10457. (WebCore::toJS):
  10458. * bindings/js/JSDOMWindowShell.h:
  10459. (WebCore::JSDOMWindowShell::createStructure):
  10460. * bindings/js/JSDatabaseCustom.cpp:
  10461. (WebCore::JSDatabase::changeVersion):
  10462. (WebCore::JSDatabase::transaction):
  10463. * bindings/js/JSDocumentCustom.cpp:
  10464. (WebCore::JSDocument::location):
  10465. (WebCore::JSDocument::setLocation):
  10466. (WebCore::toJS):
  10467. * bindings/js/JSElementCustom.cpp:
  10468. (WebCore::JSElement::setAttribute):
  10469. (WebCore::JSElement::setAttributeNode):
  10470. (WebCore::JSElement::setAttributeNS):
  10471. (WebCore::JSElement::setAttributeNodeNS):
  10472. (WebCore::toJSNewlyCreated):
  10473. * bindings/js/JSEventCustom.cpp:
  10474. (WebCore::JSEvent::clipboardData):
  10475. (WebCore::toJS):
  10476. * bindings/js/JSEventListener.cpp:
  10477. (WebCore::JSEventListener::handleEvent):
  10478. * bindings/js/JSEventTarget.cpp:
  10479. (WebCore::toJS):
  10480. (WebCore::toEventTarget):
  10481. * bindings/js/JSEventTarget.h:
  10482. * bindings/js/JSEventTargetBase.h:
  10483. * bindings/js/JSGeolocationCustom.cpp:
  10484. (WebCore::createPositionOptions):
  10485. (WebCore::JSGeolocation::getCurrentPosition):
  10486. (WebCore::JSGeolocation::watchPosition):
  10487. * bindings/js/JSHTMLAllCollection.h:
  10488. (WebCore::JSHTMLAllCollection::createStructure):
  10489. * bindings/js/JSHTMLAppletElementCustom.cpp:
  10490. (WebCore::JSHTMLAppletElement::customPut):
  10491. (WebCore::JSHTMLAppletElement::nameGetter):
  10492. * bindings/js/JSHTMLCollectionCustom.cpp:
  10493. (WebCore::getNamedItems):
  10494. (WebCore::callHTMLCollection):
  10495. (WebCore::JSHTMLCollection::nameGetter):
  10496. (WebCore::JSHTMLCollection::item):
  10497. (WebCore::JSHTMLCollection::namedItem):
  10498. (WebCore::toJS):
  10499. * bindings/js/JSHTMLDocumentCustom.cpp:
  10500. (WebCore::JSHTMLDocument::nameGetter):
  10501. (WebCore::JSHTMLDocument::all):
  10502. (WebCore::JSHTMLDocument::setAll):
  10503. (WebCore::JSHTMLDocument::open):
  10504. (WebCore::JSHTMLDocument::write):
  10505. (WebCore::JSHTMLDocument::writeln):
  10506. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  10507. (WebCore::JSHTMLEmbedElement::customPut):
  10508. (WebCore::JSHTMLEmbedElement::nameGetter):
  10509. * bindings/js/JSHTMLFormElementCustom.cpp:
  10510. (WebCore::JSHTMLFormElement::nameGetter):
  10511. (WebCore::JSHTMLFormElement::submit):
  10512. * bindings/js/JSHTMLFrameElementCustom.cpp:
  10513. (WebCore::JSHTMLFrameElement::setSrc):
  10514. (WebCore::JSHTMLFrameElement::setLocation):
  10515. * bindings/js/JSHTMLFrameSetElementCustom.cpp:
  10516. (WebCore::JSHTMLFrameSetElement::nameGetter):
  10517. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  10518. (WebCore::JSHTMLIFrameElement::setSrc):
  10519. * bindings/js/JSHTMLInputElementCustom.cpp:
  10520. (WebCore::JSHTMLInputElement::selectionStart):
  10521. (WebCore::JSHTMLInputElement::setSelectionStart):
  10522. (WebCore::JSHTMLInputElement::selectionEnd):
  10523. (WebCore::JSHTMLInputElement::setSelectionEnd):
  10524. (WebCore::JSHTMLInputElement::setSelectionRange):
  10525. * bindings/js/JSHTMLObjectElementCustom.cpp:
  10526. (WebCore::JSHTMLObjectElement::customPut):
  10527. (WebCore::JSHTMLObjectElement::nameGetter):
  10528. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  10529. (WebCore::JSHTMLOptionsCollection::length):
  10530. (WebCore::JSHTMLOptionsCollection::setLength):
  10531. (WebCore::JSHTMLOptionsCollection::indexSetter):
  10532. (WebCore::JSHTMLOptionsCollection::add):
  10533. (WebCore::JSHTMLOptionsCollection::remove):
  10534. * bindings/js/JSHTMLSelectElementCustom.cpp:
  10535. (WebCore::JSHTMLSelectElement::remove):
  10536. (WebCore::selectIndexSetter):
  10537. (WebCore::JSHTMLSelectElement::indexSetter):
  10538. * bindings/js/JSHTMLSelectElementCustom.h:
  10539. * bindings/js/JSHistoryCustom.cpp:
  10540. (WebCore::nonCachingStaticBackFunctionGetter):
  10541. (WebCore::nonCachingStaticForwardFunctionGetter):
  10542. (WebCore::nonCachingStaticGoFunctionGetter):
  10543. (WebCore::JSHistory::customPut):
  10544. * bindings/js/JSImageDataCustom.cpp:
  10545. (WebCore::toJS):
  10546. * bindings/js/JSInspectedObjectWrapper.cpp:
  10547. (WebCore::JSInspectedObjectWrapper::wrap):
  10548. (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
  10549. * bindings/js/JSInspectedObjectWrapper.h:
  10550. (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
  10551. * bindings/js/JSInspectorCallbackWrapper.cpp:
  10552. (WebCore::JSInspectorCallbackWrapper::wrap):
  10553. (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
  10554. * bindings/js/JSInspectorCallbackWrapper.h:
  10555. (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
  10556. * bindings/js/JSInspectorControllerCustom.cpp:
  10557. (WebCore::JSInspectorController::highlightDOMNode):
  10558. (WebCore::JSInspectorController::addResourceSourceToFrame):
  10559. (WebCore::JSInspectorController::addSourceToFrame):
  10560. (WebCore::JSInspectorController::getResourceDocumentNode):
  10561. (WebCore::JSInspectorController::search):
  10562. (WebCore::JSInspectorController::databaseTableNames):
  10563. (WebCore::JSInspectorController::inspectedWindow):
  10564. (WebCore::JSInspectorController::setting):
  10565. (WebCore::JSInspectorController::setSetting):
  10566. (WebCore::JSInspectorController::wrapCallback):
  10567. (WebCore::JSInspectorController::currentCallFrame):
  10568. (WebCore::JSInspectorController::profiles):
  10569. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  10570. (WebCore::JSJavaScriptCallFrame::evaluate):
  10571. (WebCore::JSJavaScriptCallFrame::thisObject):
  10572. (WebCore::JSJavaScriptCallFrame::type):
  10573. (WebCore::JSJavaScriptCallFrame::scopeChain):
  10574. * bindings/js/JSLazyEventListener.cpp:
  10575. (WebCore::JSLazyEventListener::parseCode):
  10576. * bindings/js/JSLocationCustom.cpp:
  10577. (WebCore::nonCachingStaticReplaceFunctionGetter):
  10578. (WebCore::nonCachingStaticReloadFunctionGetter):
  10579. (WebCore::nonCachingStaticAssignFunctionGetter):
  10580. (WebCore::JSLocation::customPut):
  10581. (WebCore::JSLocation::setHref):
  10582. (WebCore::JSLocation::setProtocol):
  10583. (WebCore::JSLocation::setHost):
  10584. (WebCore::JSLocation::setHostname):
  10585. (WebCore::JSLocation::setPort):
  10586. (WebCore::JSLocation::setPathname):
  10587. (WebCore::JSLocation::setSearch):
  10588. (WebCore::JSLocation::setHash):
  10589. (WebCore::JSLocation::replace):
  10590. (WebCore::JSLocation::reload):
  10591. (WebCore::JSLocation::assign):
  10592. (WebCore::JSLocation::toString):
  10593. (WebCore::JSLocationPrototype::customPut):
  10594. * bindings/js/JSMessagePortCustom.cpp:
  10595. (WebCore::JSMessagePort::startConversation):
  10596. (WebCore::JSMessagePort::addEventListener):
  10597. (WebCore::JSMessagePort::removeEventListener):
  10598. * bindings/js/JSMimeTypeArrayCustom.cpp:
  10599. (WebCore::JSMimeTypeArray::nameGetter):
  10600. * bindings/js/JSNamedNodeMapCustom.cpp:
  10601. (WebCore::JSNamedNodeMap::nameGetter):
  10602. * bindings/js/JSNamedNodesCollection.cpp:
  10603. (WebCore::JSNamedNodesCollection::lengthGetter):
  10604. (WebCore::JSNamedNodesCollection::indexGetter):
  10605. * bindings/js/JSNamedNodesCollection.h:
  10606. (WebCore::JSNamedNodesCollection::createStructure):
  10607. * bindings/js/JSNavigatorCustom.cpp:
  10608. (WebCore::needsYouTubeQuirk):
  10609. (WebCore::JSNavigator::appVersion):
  10610. * bindings/js/JSNodeCustom.cpp:
  10611. (WebCore::JSNode::insertBefore):
  10612. (WebCore::JSNode::replaceChild):
  10613. (WebCore::JSNode::removeChild):
  10614. (WebCore::JSNode::appendChild):
  10615. (WebCore::JSNode::addEventListener):
  10616. (WebCore::JSNode::removeEventListener):
  10617. (WebCore::createWrapper):
  10618. (WebCore::toJSNewlyCreated):
  10619. (WebCore::toJS):
  10620. * bindings/js/JSNodeFilterCondition.cpp:
  10621. (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
  10622. (WebCore::JSNodeFilterCondition::acceptNode):
  10623. * bindings/js/JSNodeFilterCondition.h:
  10624. (WebCore::JSNodeFilterCondition::create):
  10625. * bindings/js/JSNodeFilterCustom.cpp:
  10626. (WebCore::JSNodeFilter::acceptNode):
  10627. (WebCore::toNodeFilter):
  10628. * bindings/js/JSNodeIteratorCustom.cpp:
  10629. (WebCore::JSNodeIterator::nextNode):
  10630. (WebCore::JSNodeIterator::previousNode):
  10631. * bindings/js/JSNodeListCustom.cpp:
  10632. (WebCore::callNodeList):
  10633. (WebCore::JSNodeList::nameGetter):
  10634. * bindings/js/JSPluginArrayCustom.cpp:
  10635. (WebCore::JSPluginArray::nameGetter):
  10636. * bindings/js/JSPluginCustom.cpp:
  10637. (WebCore::JSPlugin::nameGetter):
  10638. * bindings/js/JSPluginElementFunctions.cpp:
  10639. (WebCore::runtimeObjectGetter):
  10640. (WebCore::runtimeObjectPropertyGetter):
  10641. (WebCore::runtimeObjectCustomPut):
  10642. (WebCore::callPlugin):
  10643. * bindings/js/JSPluginElementFunctions.h:
  10644. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  10645. (WebCore::JSQuarantinedObjectWrapper::asWrapper):
  10646. (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
  10647. (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
  10648. (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
  10649. (WebCore::JSQuarantinedObjectWrapper::put):
  10650. (WebCore::JSQuarantinedObjectWrapper::construct):
  10651. (WebCore::JSQuarantinedObjectWrapper::hasInstance):
  10652. (WebCore::JSQuarantinedObjectWrapper::call):
  10653. * bindings/js/JSQuarantinedObjectWrapper.h:
  10654. (WebCore::JSQuarantinedObjectWrapper::createStructure):
  10655. * bindings/js/JSRGBColor.cpp:
  10656. (WebCore::getJSRGBColor):
  10657. (jsRGBColorRed):
  10658. (jsRGBColorGreen):
  10659. (jsRGBColorBlue):
  10660. * bindings/js/JSRGBColor.h:
  10661. (WebCore::JSRGBColor::createStructure):
  10662. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  10663. (WebCore::JSSQLResultSetRowList::item):
  10664. * bindings/js/JSSQLTransactionCustom.cpp:
  10665. (WebCore::JSSQLTransaction::executeSql):
  10666. * bindings/js/JSSVGElementInstanceCustom.cpp:
  10667. (WebCore::JSSVGElementInstance::addEventListener):
  10668. (WebCore::JSSVGElementInstance::removeEventListener):
  10669. (WebCore::toJS):
  10670. * bindings/js/JSSVGLengthCustom.cpp:
  10671. (WebCore::JSSVGLength::value):
  10672. (WebCore::JSSVGLength::convertToSpecifiedUnits):
  10673. * bindings/js/JSSVGMatrixCustom.cpp:
  10674. (WebCore::JSSVGMatrix::inverse):
  10675. (WebCore::JSSVGMatrix::rotateFromVector):
  10676. * bindings/js/JSSVGPathSegCustom.cpp:
  10677. (WebCore::toJS):
  10678. * bindings/js/JSSVGPathSegListCustom.cpp:
  10679. (WebCore::JSSVGPathSegList::clear):
  10680. (WebCore::JSSVGPathSegList::initialize):
  10681. (WebCore::JSSVGPathSegList::getItem):
  10682. (WebCore::JSSVGPathSegList::insertItemBefore):
  10683. (WebCore::JSSVGPathSegList::replaceItem):
  10684. (WebCore::JSSVGPathSegList::removeItem):
  10685. (WebCore::JSSVGPathSegList::appendItem):
  10686. * bindings/js/JSSVGPointListCustom.cpp:
  10687. (WebCore::finishGetter):
  10688. (WebCore::finishSetter):
  10689. (WebCore::finishSetterReadOnlyResult):
  10690. (WebCore::JSSVGPointList::clear):
  10691. (WebCore::JSSVGPointList::initialize):
  10692. (WebCore::JSSVGPointList::getItem):
  10693. (WebCore::JSSVGPointList::insertItemBefore):
  10694. (WebCore::JSSVGPointList::replaceItem):
  10695. (WebCore::JSSVGPointList::removeItem):
  10696. (WebCore::JSSVGPointList::appendItem):
  10697. * bindings/js/JSSVGTransformListCustom.cpp:
  10698. (WebCore::finishGetter):
  10699. (WebCore::finishSetter):
  10700. (WebCore::finishSetterReadOnlyResult):
  10701. (WebCore::JSSVGTransformList::clear):
  10702. (WebCore::JSSVGTransformList::initialize):
  10703. (WebCore::JSSVGTransformList::getItem):
  10704. (WebCore::JSSVGTransformList::insertItemBefore):
  10705. (WebCore::JSSVGTransformList::replaceItem):
  10706. (WebCore::JSSVGTransformList::removeItem):
  10707. (WebCore::JSSVGTransformList::appendItem):
  10708. * bindings/js/JSStorageCustom.cpp:
  10709. (WebCore::JSStorage::nameGetter):
  10710. (WebCore::JSStorage::deleteProperty):
  10711. (WebCore::JSStorage::customPut):
  10712. * bindings/js/JSStyleSheetCustom.cpp:
  10713. (WebCore::toJS):
  10714. * bindings/js/JSStyleSheetListCustom.cpp:
  10715. (WebCore::JSStyleSheetList::nameGetter):
  10716. * bindings/js/JSTextCustom.cpp:
  10717. (WebCore::toJSNewlyCreated):
  10718. * bindings/js/JSTreeWalkerCustom.cpp:
  10719. (WebCore::JSTreeWalker::parentNode):
  10720. (WebCore::JSTreeWalker::firstChild):
  10721. (WebCore::JSTreeWalker::lastChild):
  10722. (WebCore::JSTreeWalker::nextSibling):
  10723. (WebCore::JSTreeWalker::previousSibling):
  10724. (WebCore::JSTreeWalker::previousNode):
  10725. (WebCore::JSTreeWalker::nextNode):
  10726. * bindings/js/JSWorkerContextCustom.cpp:
  10727. (WebCore::JSWorkerContext::self):
  10728. (WebCore::JSWorkerContext::setSelf):
  10729. (WebCore::JSWorkerContext::xmlHttpRequest):
  10730. (WebCore::JSWorkerContext::importScripts):
  10731. (WebCore::JSWorkerContext::addEventListener):
  10732. (WebCore::JSWorkerContext::removeEventListener):
  10733. (WebCore::JSWorkerContext::setTimeout):
  10734. (WebCore::JSWorkerContext::setInterval):
  10735. * bindings/js/JSWorkerCustom.cpp:
  10736. (WebCore::JSWorker::addEventListener):
  10737. (WebCore::JSWorker::removeEventListener):
  10738. * bindings/js/JSXMLHttpRequestCustom.cpp:
  10739. (WebCore::JSXMLHttpRequest::open):
  10740. (WebCore::JSXMLHttpRequest::setRequestHeader):
  10741. (WebCore::JSXMLHttpRequest::send):
  10742. (WebCore::JSXMLHttpRequest::getResponseHeader):
  10743. (WebCore::JSXMLHttpRequest::overrideMimeType):
  10744. (WebCore::JSXMLHttpRequest::addEventListener):
  10745. (WebCore::JSXMLHttpRequest::removeEventListener):
  10746. (WebCore::JSXMLHttpRequest::responseText):
  10747. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  10748. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  10749. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  10750. * bindings/js/JSXSLTProcessorCustom.cpp:
  10751. (WebCore::JSXSLTProcessor::importStylesheet):
  10752. (WebCore::JSXSLTProcessor::transformToFragment):
  10753. (WebCore::JSXSLTProcessor::transformToDocument):
  10754. (WebCore::JSXSLTProcessor::setParameter):
  10755. (WebCore::JSXSLTProcessor::getParameter):
  10756. (WebCore::JSXSLTProcessor::removeParameter):
  10757. * bindings/js/ScheduledAction.cpp:
  10758. (WebCore::ScheduledAction::create):
  10759. (WebCore::ScheduledAction::ScheduledAction):
  10760. (WebCore::ScheduledAction::executeFunctionInContext):
  10761. * bindings/js/ScheduledAction.h:
  10762. * bindings/js/ScriptCallStack.cpp:
  10763. (WebCore::ScriptCallStack::ScriptCallStack):
  10764. (WebCore::ScriptCallStack::initialize):
  10765. * bindings/js/ScriptCallStack.h:
  10766. * bindings/js/ScriptController.cpp:
  10767. (WebCore::ScriptController::jsObjectForPluginElement):
  10768. * bindings/js/ScriptFunctionCall.cpp:
  10769. (WebCore::ScriptFunctionCall::appendArgument):
  10770. (WebCore::ScriptFunctionCall::call):
  10771. (WebCore::ScriptFunctionCall::construct):
  10772. * bindings/js/ScriptFunctionCall.h:
  10773. * bindings/js/ScriptObject.cpp:
  10774. (WebCore::ScriptGlobalObject::get):
  10775. * bindings/js/ScriptValue.h:
  10776. (WebCore::ScriptValue::ScriptValue):
  10777. (WebCore::ScriptValue::jsValue):
  10778. * bindings/objc/WebScriptObject.mm:
  10779. (-[WebScriptObject callWebScriptMethod:withArguments:]):
  10780. (-[WebScriptObject evaluateWebScript:]):
  10781. (-[WebScriptObject valueForKey:]):
  10782. (-[WebScriptObject webScriptValueAtIndex:]):
  10783. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  10784. * bindings/objc/WebScriptObjectPrivate.h:
  10785. * bridge/NP_jsobject.cpp:
  10786. (_NPN_InvokeDefault):
  10787. (_NPN_Invoke):
  10788. (_NPN_Evaluate):
  10789. (_NPN_GetProperty):
  10790. (_NPN_HasMethod):
  10791. (_NPN_Construct):
  10792. * bridge/c/c_instance.cpp:
  10793. (JSC::Bindings::CInstance::invokeMethod):
  10794. (JSC::Bindings::CInstance::invokeDefaultMethod):
  10795. (JSC::Bindings::CInstance::invokeConstruct):
  10796. (JSC::Bindings::CInstance::defaultValue):
  10797. (JSC::Bindings::CInstance::stringValue):
  10798. (JSC::Bindings::CInstance::numberValue):
  10799. (JSC::Bindings::CInstance::booleanValue):
  10800. (JSC::Bindings::CInstance::valueOf):
  10801. * bridge/c/c_instance.h:
  10802. * bridge/c/c_runtime.cpp:
  10803. (JSC::Bindings::CField::valueFromInstance):
  10804. (JSC::Bindings::CField::setValueToInstance):
  10805. * bridge/c/c_runtime.h:
  10806. * bridge/c/c_utility.cpp:
  10807. (JSC::Bindings::convertValueToNPVariant):
  10808. (JSC::Bindings::convertNPVariantToValue):
  10809. * bridge/c/c_utility.h:
  10810. * bridge/jni/jni_instance.cpp:
  10811. (JavaInstance::stringValue):
  10812. (JavaInstance::numberValue):
  10813. (JavaInstance::booleanValue):
  10814. (JavaInstance::invokeMethod):
  10815. (JavaInstance::defaultValue):
  10816. (JavaInstance::valueOf):
  10817. * bridge/jni/jni_instance.h:
  10818. * bridge/jni/jni_jsobject.h:
  10819. * bridge/jni/jni_jsobject.mm:
  10820. (JavaJSObject::call):
  10821. (JavaJSObject::eval):
  10822. (JavaJSObject::getMember):
  10823. (JavaJSObject::getSlot):
  10824. (JavaJSObject::convertValueToJObject):
  10825. (JavaJSObject::convertJObjectToValue):
  10826. * bridge/jni/jni_objc.mm:
  10827. (JSC::Bindings::dispatchJNICall):
  10828. * bridge/jni/jni_runtime.cpp:
  10829. (JavaArray::convertJObjectToArray):
  10830. (JavaField::dispatchValueFromInstance):
  10831. (JavaField::valueFromInstance):
  10832. (JavaField::dispatchSetValueToInstance):
  10833. (JavaField::setValueToInstance):
  10834. (JavaArray::setValueAt):
  10835. (JavaArray::valueAt):
  10836. * bridge/jni/jni_runtime.h:
  10837. * bridge/jni/jni_utility.cpp:
  10838. (JSC::Bindings::convertArrayInstanceToJavaArray):
  10839. (JSC::Bindings::convertValueToJValue):
  10840. * bridge/jni/jni_utility.h:
  10841. * bridge/objc/WebScriptObject.h:
  10842. * bridge/objc/objc_class.h:
  10843. * bridge/objc/objc_class.mm:
  10844. (JSC::Bindings::ObjcClass::fallbackObject):
  10845. * bridge/objc/objc_instance.h:
  10846. * bridge/objc/objc_instance.mm:
  10847. (ObjcInstance::invokeMethod):
  10848. (ObjcInstance::invokeDefaultMethod):
  10849. (ObjcInstance::setValueOfUndefinedField):
  10850. (ObjcInstance::getValueOfUndefinedField):
  10851. (ObjcInstance::defaultValue):
  10852. (ObjcInstance::stringValue):
  10853. (ObjcInstance::numberValue):
  10854. (ObjcInstance::booleanValue):
  10855. (ObjcInstance::valueOf):
  10856. * bridge/objc/objc_runtime.h:
  10857. (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  10858. * bridge/objc/objc_runtime.mm:
  10859. (JSC::Bindings::ObjcField::valueFromInstance):
  10860. (JSC::Bindings::convertValueToObjcObject):
  10861. (JSC::Bindings::ObjcField::setValueToInstance):
  10862. (JSC::Bindings::ObjcArray::setValueAt):
  10863. (JSC::Bindings::ObjcArray::valueAt):
  10864. (JSC::Bindings::ObjcFallbackObjectImp::put):
  10865. (JSC::Bindings::callObjCFallbackObject):
  10866. (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
  10867. * bridge/objc/objc_utility.h:
  10868. * bridge/objc/objc_utility.mm:
  10869. (JSC::Bindings::convertValueToObjcValue):
  10870. (JSC::Bindings::convertNSStringToString):
  10871. (JSC::Bindings::convertObjcValueToValue):
  10872. * bridge/runtime.h:
  10873. (JSC::Bindings::Class::fallbackObject):
  10874. (JSC::Bindings::Instance::setValueOfUndefinedField):
  10875. (JSC::Bindings::Instance::invokeDefaultMethod):
  10876. (JSC::Bindings::Instance::invokeConstruct):
  10877. (JSC::Bindings::Instance::put):
  10878. * bridge/runtime_array.cpp:
  10879. (JSC::RuntimeArray::lengthGetter):
  10880. (JSC::RuntimeArray::indexGetter):
  10881. (JSC::RuntimeArray::put):
  10882. * bridge/runtime_array.h:
  10883. (JSC::RuntimeArray::createStructure):
  10884. * bridge/runtime_method.cpp:
  10885. (JSC::RuntimeMethod::lengthGetter):
  10886. (JSC::callRuntimeMethod):
  10887. * bridge/runtime_method.h:
  10888. (JSC::RuntimeMethod::createStructure):
  10889. * bridge/runtime_object.cpp:
  10890. (JSC::RuntimeObjectImp::fallbackObjectGetter):
  10891. (JSC::RuntimeObjectImp::fieldGetter):
  10892. (JSC::RuntimeObjectImp::methodGetter):
  10893. (JSC::RuntimeObjectImp::put):
  10894. (JSC::RuntimeObjectImp::defaultValue):
  10895. (JSC::callRuntimeObject):
  10896. (JSC::callRuntimeConstructor):
  10897. * bridge/runtime_object.h:
  10898. (JSC::RuntimeObjectImp::createStructure):
  10899. * inspector/JavaScriptCallFrame.cpp:
  10900. (WebCore::JavaScriptCallFrame::evaluate):
  10901. * inspector/JavaScriptCallFrame.h:
  10902. * inspector/JavaScriptProfile.cpp:
  10903. (WebCore::toJS):
  10904. * inspector/JavaScriptProfile.h:
  10905. * inspector/JavaScriptProfileNode.cpp:
  10906. (WebCore::toJS):
  10907. * inspector/JavaScriptProfileNode.h:
  10908. 2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>
  10909. Reviewed by Eric Seidel.
  10910. https://bugs.webkit.org/show_bug.cgi?id=25485
  10911. Only use visitedURL in Qt. This is a follow-up change to http://trac.webkit.org/changeset/43052,
  10912. which broke Chromium build.
  10913. * css/CSSStyleSelector.cpp:
  10914. (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Moved guards around to
  10915. provide separate code paths for Qt and non-Qt ports. Also restored original
  10916. order of execution.
  10917. 2009-05-01 Anders Carlsson <andersca@apple.com>
  10918. Reviewed by Adele Peterson.
  10919. <rdar://problem/6839222>
  10920. CrashTracer: Lots of crashes in Safari in hash table remove function inside DocumentLoader::removeSubresourceLoader
  10921. After calling m_client->didFail(), check if the subresource loader has reached its terminal state. If that's the case,
  10922. return early to avoid calling removeSubresourceLoader on a null document loader. I don't think this is allowed to happen
  10923. which is why I've added the ASSERT.
  10924. * loader/SubresourceLoader.cpp:
  10925. (WebCore::SubresourceLoader::didCancel):
  10926. 2009-05-01 Timothy Hatcher <timothy@apple.com>
  10927. Disallow the deletion UI for elements that have any overflow clipping.
  10928. Also disallow the UI for the body element it isn't practical to delete,
  10929. and the deletion UI would be clipped.
  10930. <rdar://problem/6840161> Deletion UI can be clipped by some
  10931. elements (with overflow: hidden)
  10932. Reviewed by Darin Adler.
  10933. * editing/DeleteButtonController.cpp:
  10934. (WebCore::isDeletableElement):
  10935. 2009-05-01 Timothy Hatcher <timothy@apple.com>
  10936. Decrease the minimum height for deleteable elements to 16px, and increase the
  10937. minimum width to 48px. This allows deleting shorter items like navigation bars.
  10938. <rdar://problem/6840735> Deletion UI does not show up for short
  10939. elements (22px or less)
  10940. Reviewed by Adele Peterson.
  10941. * editing/DeleteButtonController.cpp:
  10942. (WebCore::isDeletableElement):
  10943. 2009-05-01 Timothy Hatcher <timothy@apple.com>
  10944. Clean up the comments and logic in the code for picking a
  10945. deleteable element for the deletion UI.
  10946. Reviewed by Adele Peterson.
  10947. * editing/DeleteButtonController.cpp:
  10948. (WebCore::isDeletableElement):
  10949. 2009-05-01 Kevin McCullough <kmccullough@apple.com>
  10950. Reviewed by Adele Peterson and Darin Adler.
  10951. <rdar://problem/4815598> Stuck in double spacing mode after pasting a
  10952. paragraph with padding/margin (or table mode !)
  10953. A lot of the issues in this bug were resolved on Mail's side by using
  10954. WebKit to convert to plain text. This is the final issue, that floating
  10955. style stays on copied nodes causing them to float when they are pasted
  10956. which is not what the user intended.
  10957. * editing/markup.cpp:
  10958. (WebCore::removeExteriorStyles):
  10959. (WebCore::):
  10960. (WebCore::appendStartMarkup):
  10961. (WebCore::getStartMarkup):
  10962. (WebCore::createMarkup):
  10963. 2009-05-01 Pavel Feldman <pfeldman@chromium.org>
  10964. Reviewed by Timothy Hatcher.
  10965. Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
  10966. This is the only resource-related information that is available in InspectorController
  10967. and is missing in the FrameLoaderClient.
  10968. https://bugs.webkit.org/show_bug.cgi?id=25347
  10969. * WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
  10970. * dom/Document.cpp: Made a call to a client along with the call to the InspectorController.
  10971. (WebCore::Document::resourceRetrievedByXMLHttpRequest):
  10972. * loader/EmptyClients.h: Added stub implementation.
  10973. (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
  10974. * loader/FrameLoader.cpp: Call initiating dispatches.
  10975. (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
  10976. * loader/FrameLoader.h:
  10977. * loader/FrameLoaderClient.h:
  10978. 2009-04-30 Beth Dakin <bdakin@apple.com>
  10979. Reviewed by Oliver Hunt.
  10980. Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting
  10981. To Do's in a Mail note (excessive recursion in mouse drag tracking)
  10982. Oliver's recent change to dragging seems to have revealed a long-
  10983. time bug in passSubframeEventToSubframe where we did not set
  10984. m_sendingEventToSubview to true before calling
  10985. handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes
  10986. that and adds ASSERTions around all of the places where
  10987. m_sendingEventToSubview is set to true and then false to make sure
  10988. we are not trampling its state.
  10989. * page/mac/EventHandlerMac.mm:
  10990. (WebCore::EventHandler::eventLoopHandleMouseDragged):
  10991. (WebCore::EventHandler::eventLoopHandleMouseUp):
  10992. (WebCore::EventHandler::passSubframeEventToSubframe):
  10993. (WebCore::EventHandler::passWheelEventToWidget):
  10994. 2009-04-30 Eric Carlson <eric.carlson@apple.com>
  10995. Reviewed by Simon Fraser.
  10996. MediaDocument falls back to plug-in unnecessarily
  10997. https://bugs.webkit.org/show_bug.cgi?id=25504
  10998. <rdar://problem/6844702>
  10999. Don't allow harmless media types to cause a MediaDocument to fall
  11000. back to PluginDocument.
  11001. Test: media/video-document-types.html
  11002. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  11003. (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64,
  11004. odsm, and sdsm to allowed track types.
  11005. * platform/graphics/win/QTMovieWin.cpp:
  11006. (QTMovieWin::disableUnsupportedTracks): Ditto.
  11007. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11008. Reviewed by Eric Seidel.
  11009. Add CHROMIUM guard to unfork Document.cpp
  11010. * dom/Document.cpp:
  11011. (WebCore::Document::setFocusedNode): Added guard.
  11012. 2009-04-30 David Kilzer <ddkilzer@apple.com>
  11013. Use OwnPtr<HTMLParserQuirks> for m_parserQuirks
  11014. Reviewed by Geoff Garen.
  11015. * html/HTMLParser.cpp:
  11016. (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
  11017. * html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
  11018. 2009-04-30 David Kilzer <ddkilzer@apple.com>
  11019. Provide a mechanism to create a quirks delegate for HTMLParser
  11020. Reviewed by David Hyatt.
  11021. No tests since there is no change in behavior.
  11022. HTMLParserQuirks.h defines an abstract base class that may be
  11023. extended as needed. The ChromeClient::createHTMLParserQuirks()
  11024. factory method should be used to return an HTMLParserQuirks
  11025. subclassed object when needed.
  11026. * WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
  11027. * html/HTMLParser.cpp:
  11028. (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks
  11029. using ChromeClient::createHTMLParserQuirks().
  11030. (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if
  11031. set.
  11032. (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if
  11033. m_parserQuirks is set.
  11034. (WebCore::HTMLParser::insertNode): Call
  11035. HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set,
  11036. and return early if it returns false.
  11037. (WebCore::HTMLParser::popBlock): Call
  11038. HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and
  11039. return early if it returns false.
  11040. * html/HTMLParser.h: Added m_parserQuirks.
  11041. * html/HTMLParserQuirks.h: Added.
  11042. (WebCore::HTMLParserQuirks::HTMLParserQuirks):
  11043. (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
  11044. * loader/EmptyClients.h:
  11045. (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
  11046. * page/ChromeClient.h:
  11047. (WebCore::ChromeClient::createHTMLParserQuirks): Added.
  11048. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11049. Reviewed by Eric Seidel.
  11050. https://bugs.webkit.org/show_bug.cgi?id=25492
  11051. Add JSC guards around node wrapper cache calls. These are not used by V8.
  11052. Also, remove JSDOMBinding include, which is brought in by ScriptController.
  11053. * dom/Document.cpp:
  11054. (WebCore::Document::~Document): Added JSC guard.
  11055. * dom/Node.cpp:
  11056. (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
  11057. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11058. Reviewed by Eric Seidel.
  11059. https://bugs.webkit.org/show_bug.cgi?id=25493
  11060. Remove debugger/profiler custom method stubs, catching V8 bindings up to
  11061. http://trac.webkit.org/changeset/43072.
  11062. * bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
  11063. 2009-04-30 Simon Fraser <simon.fraser@apple.com>
  11064. Reviewed by Darin Adler
  11065. <rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines
  11066. Use transform-aware quad methods when computing the boundingBoxRect for
  11067. an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().
  11068. Test: accessibility/transformed-element.html
  11069. * page/AccessibilityRenderObject.cpp:
  11070. (WebCore::AccessibilityRenderObject::boundingBoxRect):
  11071. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11072. Unreviewed, Chromium build fix.
  11073. Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.
  11074. * bindings/v8/ScriptObject.cpp:
  11075. (WebCore::ScriptGlobalObject::get): Renamed from getObject.
  11076. (WebCore::ScriptGlobalObject::remove): Added.
  11077. * bindings/v8/ScriptObject.h: Ditto.
  11078. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11079. Unreviewed, build fix.
  11080. https://bugs.webkit.org/show_bug.cgi?id=25470
  11081. Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
  11082. * WebCore.pro: Fix copy-paste error.
  11083. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11084. Unreviewed, build fix.
  11085. https://bugs.webkit.org/show_bug.cgi?id=25470
  11086. Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
  11087. * GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
  11088. * WebCore.pro: Ditto.
  11089. 2009-04-02 Eric Seidel <eric@webkit.org>
  11090. Reviewed by Darin Adler.
  11091. Change Position to pre-compute the AnchorType and store it.
  11092. Also store a "legacy editing mode" bit on the Position.
  11093. https://bugs.webkit.org/show_bug.cgi?id=24763
  11094. The old Postion(node, offset) constructor creates legacy positions
  11095. but there are new constructors to create explicitly anchored positions
  11096. which the next patch will use.
  11097. Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
  11098. only affect legacy positions, we will be able to distinguish
  11099. between [table, 1] and [table, after] in the code correctly!
  11100. * WebCore.base.exp:
  11101. * WebCore.xcodeproj/project.pbxproj:
  11102. * dom/Position.cpp:
  11103. (WebCore::Position::Position):
  11104. (WebCore::Position::moveToPosition):
  11105. (WebCore::Position::moveToOffset):
  11106. (WebCore::Position::anchorTypeForLegacyEditingPosition):
  11107. (WebCore::Position::element):
  11108. * dom/Position.h:
  11109. (WebCore::Position::):
  11110. (WebCore::Position::Position):
  11111. (WebCore::Position::anchorType):
  11112. (WebCore::Position::deprecatedEditingOffset):
  11113. 2009-04-30 Sam Weinig <sam@webkit.org>
  11114. Reviewed by Alexey Proskuryakov.
  11115. Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
  11116. collected even if the WorkerContext is still alive.
  11117. Test: fast/workers/worker-context-gc.html
  11118. * bindings/js/JSWorkerContextCustom.cpp:
  11119. (WebCore::JSWorkerContext::mark):
  11120. * workers/WorkerContext.cpp:
  11121. (WebCore::WorkerContext::WorkerContext):
  11122. (WebCore::WorkerContext::completeURL):
  11123. (WebCore::WorkerContext::location):
  11124. * workers/WorkerContext.h:
  11125. (WebCore::WorkerContext::optionalNavigator):
  11126. (WebCore::WorkerContext::optionalLocation):
  11127. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11128. Reviewed by Timothy Hatcher.
  11129. https://bugs.webkit.org/show_bug.cgi?id=25470
  11130. Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
  11131. * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
  11132. * WebCore.vcproj/build-generated-files.sh: Ditto.
  11133. * bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
  11134. * bindings/js/JSDOMWindowBase.cpp: Ditto.
  11135. * bindings/js/JSInspectorControllerCustom.cpp: Ditto.
  11136. * inspector/InspectorController.cpp: Moved profiler/debugger methods under
  11137. ENABLE(JAVASCRIPT_DEBUGGER) flag.
  11138. * inspector/InspectorController.h: Ditto.
  11139. * inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
  11140. * page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.
  11141. 2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
  11142. Unreviewed, build fix.
  11143. https://bugs.webkit.org/show_bug.cgi?id=25275
  11144. This patch snuck in a re-definition of a local.
  11145. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  11146. (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
  11147. 2009-04-30 Sam Weinig <sam@webkit.org>
  11148. Reviewed by Mark Rowe.
  11149. Fix a leak introduced yesterday. Don't allocate a ScheduledAction
  11150. if the toString()ing throws an exception.
  11151. * bindings/js/ScheduledAction.cpp:
  11152. (WebCore::ScheduledAction::create):
  11153. 2009-04-30 Alexey Proskuryakov <ap@webkit.org>
  11154. Reviewed by Darin Adler.
  11155. https://bugs.webkit.org/show_bug.cgi?id=25379
  11156. <rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails
  11157. Test: fast/forms/multiple-selected-options-innerHTML.html
  11158. This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
  11159. For normal HTML parsing, it is called immediately after an element is inserted, but for
  11160. innerHTML, it is only called after the whole subtree is inserted into a document.
  11161. It may make sense to harmonize these cases one day, but for now, I only made the minimal
  11162. changes necessary to fix the bug.
  11163. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
  11164. * html/HTMLSelectElement.h:
  11165. Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
  11166. which one to keep selected themselves, because their logic assumes normal parsing, with
  11167. insertedIntoTree() called after each element is inserted.
  11168. 2009-04-30 Pavel Feldman <pfeldman@chromium.org>
  11169. Reviewed by Dimitri Glazkov.
  11170. https://bugs.webkit.org/show_bug.cgi?id=25342
  11171. Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
  11172. Chromium async/out-of-process version of WebInspector is currently not based on
  11173. InspectorController. The reason was that we did not want to interfere with
  11174. the unforking effort, yet wanted to experiment. So we came up with these
  11175. agents concept that basically mimic InspectorController, but separating 'agent'
  11176. nature from the 'transport'. Now that InspectorController is unforked, I am
  11177. planning to bring these concepts into the WebKit land and use what we have in
  11178. Chromium as a proof of concept / experimental playground.
  11179. * loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
  11180. (WebCore::EmptyChromeClient::addMessageToConsole): ditto
  11181. * page/ChromeClient.h: ditto
  11182. * page/Console.cpp: Used new method signature.
  11183. (WebCore::Console::addMessage): ditto
  11184. 2009-04-30 Dan Bernstein <mitz@apple.com>
  11185. Reviewed by Simon Fraser.
  11186. - fix https://bugs.webkit.org/show_bug.cgi?id=25476
  11187. <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
  11188. animation is jittery
  11189. Reverted r42987.
  11190. * platform/graphics/cg/ImageCG.cpp:
  11191. (WebCore::BitmapImage::draw):
  11192. 2009-04-30 Brady Eidson <beidson@apple.com>
  11193. Reviewed by Maciej Stachowiak
  11194. <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
  11195. https://bugs.webkit.org/show_bug.cgi?id=21193
  11196. Some websites use for attributes in script elements to specify events that the script
  11197. should be run for. One example is greekembassy.org which has the following in their <head>:
  11198. <script for=window event=onresize>
  11199. location.reload(false);
  11200. </script>
  11201. Since we don't support the full for attribute syntax, we would just blissfully ignore the
  11202. condition and execute the code unconditionally. This caused breakage on multiple real-world
  11203. sites besides greekembassy.org.
  11204. https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
  11205. support for the for attribute in scripts. In the meantime it's best to not execute them
  11206. unconditionally.
  11207. Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html
  11208. * dom/ScriptElement.cpp:
  11209. (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have
  11210. passed, only return true if there is no for attribute in the script element.
  11211. * dom/ScriptElement.h:
  11212. * html/HTMLScriptElement.cpp:
  11213. (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
  11214. * html/HTMLScriptElement.h:
  11215. * svg/SVGScriptElement.cpp:
  11216. (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other
  11217. attribute getters do for SVGScriptElement)
  11218. * svg/SVGScriptElement.h:
  11219. 2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
  11220. Reviewed by Darin Adler.
  11221. The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again
  11222. https://bugs.webkit.org/show_bug.cgi?id=20952
  11223. The QtWebKit port made the mistake of exposing a global history. This broke
  11224. with the addition of PageGroup and LinkHash. This needs to be repaired
  11225. for Qt4.5.
  11226. Add a function to LinkHash.cpp that is resolving a URL. Use this
  11227. function from within CSSStyleSelector to forward the url to the
  11228. QWebHistoryInterface API.
  11229. It is sad that there is a path within visitedLinkHash which is now
  11230. doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
  11231. and using QtWebKit types within WebCore is a layering violation as well.
  11232. PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
  11233. Qt4.6 a second version of the QWebHistoryInterface is going to be
  11234. added which will fix things up.
  11235. * css/CSSStyleSelector.cpp:
  11236. (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
  11237. * platform/LinkHash.cpp:
  11238. (WebCore::visitedURL):
  11239. (WebCore::visitedLinkHash):
  11240. * platform/LinkHash.h:
  11241. 2009-04-30 Simon Hausmann <simon.hausmann@nokia.com>
  11242. Fix the Qt build.
  11243. * platform/graphics/SimpleFontData.cpp: Don't use initCharWidths() for the Qt build.
  11244. * platform/graphics/qt/SimpleFontDataQt.cpp:
  11245. (WebCore::SimpleFontData::platformCharWidthInit): Instead initialize the average and
  11246. max char widths from QFontMetrics.
  11247. 2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
  11248. Unreview build fix after r43037.
  11249. Use MarkedArgumentBuffer instead of ArgList.
  11250. * bridge/qt/qt_runtime.cpp:
  11251. (JSC::Bindings::QtConnectionObject::execute):
  11252. 2009-04-29 Sam Weinig <sam@webkit.org>
  11253. Reviewed by Oliver Hunt.
  11254. Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
  11255. setTimeout should stringify non-string/non-function first arguments
  11256. Test: fast/dom/Window/setTimeout-string-argument.html
  11257. * bindings/js/JSDOMWindowCustom.cpp:
  11258. (WebCore::JSDOMWindow::setTimeout):
  11259. (WebCore::JSDOMWindow::setInterval):
  11260. * bindings/js/JSWorkerContextCustom.cpp:
  11261. (WebCore::JSWorkerContext::setTimeout):
  11262. (WebCore::JSWorkerContext::setInterval):
  11263. * bindings/js/ScheduledAction.cpp:
  11264. (WebCore::ScheduledAction::create):
  11265. * bindings/js/ScheduledAction.h:
  11266. 2009-04-29 Dan Bernstein <mitz@apple.com>
  11267. Reviewed by Simon Fraser.
  11268. - WebCore part of <rdar://problem/6609509> Select All and then Delete
  11269. should put Mail editing back into the same state as a new message
  11270. Test: editing/deleting/in-visibly-empty-root.html
  11271. * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
  11272. * editing/SelectionController.h:
  11273. (WebCore::SelectionController::isAll): Added. Calls through to
  11274. VisibleSelection.
  11275. * editing/TypingCommand.cpp:
  11276. (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
  11277. of the root editable element the selection is in, other than a
  11278. placeholder. Returns true iff it did anything.
  11279. (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
  11280. visible position in the root editable element, but it has children other
  11281. than a placeholder, remove those children.
  11282. * editing/TypingCommand.h:
  11283. * editing/VisiblePosition.h:
  11284. Added a StayInEditableContent enum and a FIXME.
  11285. * editing/VisibleSelection.cpp:
  11286. (WebCore::VisibleSelection::isAll): Added. Returns whether the
  11287. selection encompasses all visible positions, either in the document or
  11288. in the editable root.
  11289. * editing/VisibleSelection.h:
  11290. 2009-04-29 Sam Weinig <sam@webkit.org>
  11291. Fix style nit.
  11292. * editing/visible_units.cpp:
  11293. (WebCore::getLeafBoxesInLogicalOrder):
  11294. 2009-04-29 David Hyatt <hyatt@apple.com>
  11295. Reviewed by Dan Bernstein.
  11296. For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
  11297. trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
  11298. assertions.
  11299. Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
  11300. and not do it (which is basically what was happening before).
  11301. * page/FrameView.cpp:
  11302. (WebCore::FrameView::setContentsSize):
  11303. (WebCore::FrameView::needsLayout):
  11304. 2009-04-29 Douglas Davidson <ddavidso@apple.com>
  11305. Reviewed by Justin Garcia.
  11306. <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
  11307. Updates to the text checking code to enable text checking even if spellchecking is turned off
  11308. and fix an off-by-one error in selection handling.
  11309. * editing/Editor.cpp:
  11310. (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  11311. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  11312. (WebCore::Editor::markMisspellingsAndBadGrammar):
  11313. * editing/Editor.h:
  11314. * editing/TypingCommand.cpp:
  11315. (WebCore::TypingCommand::markMisspellingsAfterTyping):
  11316. 2009-04-29 Oliver Hunt <oliver@apple.com>
  11317. Reviewed by Gavin Barraclough.
  11318. Clean up ArgList to be a trivial type
  11319. Start using MarkedArgumentBuffer to create argument lists for function calls
  11320. * bindings/js/JSClipboardCustom.cpp:
  11321. (WebCore::JSClipboard::types):
  11322. * bindings/js/JSConsoleCustom.cpp:
  11323. (WebCore::JSConsole::profiles):
  11324. * bindings/js/JSCustomPositionCallback.cpp:
  11325. (WebCore::JSCustomPositionCallback::handleEvent):
  11326. * bindings/js/JSCustomPositionErrorCallback.cpp:
  11327. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  11328. * bindings/js/JSCustomSQLStatementCallback.cpp:
  11329. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  11330. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  11331. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  11332. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  11333. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  11334. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  11335. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  11336. * bindings/js/JSCustomVoidCallback.cpp:
  11337. (WebCore::JSCustomVoidCallback::handleEvent):
  11338. * bindings/js/JSCustomXPathNSResolver.cpp:
  11339. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  11340. * bindings/js/JSEventListener.cpp:
  11341. (WebCore::JSEventListener::handleEvent):
  11342. * bindings/js/JSInspectorControllerCustom.cpp:
  11343. (WebCore::JSInspectorController::profiles):
  11344. (WebCore::JSInspectorController::search):
  11345. (WebCore::JSInspectorController::databaseTableNames):
  11346. (WebCore::JSInspectorController::setting):
  11347. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  11348. (WebCore::JSJavaScriptCallFrame::scopeChain):
  11349. * bindings/js/JSLazyEventListener.cpp:
  11350. (WebCore::JSLazyEventListener::parseCode):
  11351. * bindings/js/JSNodeFilterCondition.cpp:
  11352. (WebCore::JSNodeFilterCondition::acceptNode):
  11353. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  11354. (WebCore::JSQuarantinedObjectWrapper::construct):
  11355. (WebCore::JSQuarantinedObjectWrapper::call):
  11356. * bindings/js/ScheduledAction.cpp:
  11357. (WebCore::ScheduledAction::ScheduledAction):
  11358. (WebCore::ScheduledAction::executeFunctionInContext):
  11359. * bindings/js/ScriptFunctionCall.h:
  11360. * bindings/objc/WebScriptObject.mm:
  11361. (getListFromNSArray):
  11362. (-[WebScriptObject callWebScriptMethod:withArguments:]):
  11363. * bridge/NP_jsobject.cpp:
  11364. (getListFromVariantArgs):
  11365. (_NPN_InvokeDefault):
  11366. (_NPN_Invoke):
  11367. (_NPN_Construct):
  11368. * bridge/jni/jni_jsobject.h:
  11369. * bridge/jni/jni_jsobject.mm:
  11370. (JavaJSObject::call):
  11371. (JavaJSObject::getListFromJArray):
  11372. 2009-04-29 Eric Seidel <eric@webkit.org>
  11373. No review, build fix only.
  11374. Fix m_offset uses added while I wasn't looking.
  11375. * editing/visible_units.cpp:
  11376. (WebCore::logicalStartPositionForLine):
  11377. (WebCore::logicalEndPositionForLine):
  11378. 2009-04-29 Xiaomei Ji <xji@chromium.org>
  11379. Reviewed by Dan Bernstein.
  11380. Fix https://bugs.webkit.org/show_bug.cgi?id=24168
  11381. RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
  11382. Test: editing/selection/home-end.html
  11383. * editing/SelectionController.cpp:
  11384. (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
  11385. to logicalEndOfLine() when granularity is LineBoundary.
  11386. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
  11387. to logicalEndOfLine() when granularity is LineBoundary
  11388. (WebCore::SelectionController::modifyExtendingBackward): Change calling
  11389. startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
  11390. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
  11391. to logicalStartOfLine() when granularity is LineBoundary.
  11392. * editing/visible_units.cpp:
  11393. (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
  11394. (WebCore::getLogicalStartBoxAndNode): Added.
  11395. (WebCore::getLogicalEndBoxAndNode): Added.
  11396. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
  11397. (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
  11398. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
  11399. (WebCore::inSameLogicalLine): Added.
  11400. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
  11401. * editing/visible_units.h:
  11402. 2009-04-29 Eric Seidel <eric@webkit.org>
  11403. Reviewed by Darin Adler.
  11404. Make m_offset private and change all callers to use deprecatedEditingOffset().
  11405. https://bugs.webkit.org/show_bug.cgi?id=25472
  11406. Per Darin's suggestion, this was just a simple search replace
  11407. of .m_offset with .deprecatedEditingOffset().
  11408. There was one change in InsertParagraphSeparatorCommand::doApply to use
  11409. Position::moveToOffset(0) instead of .m_offset = 0;
  11410. * dom/Position.cpp:
  11411. (WebCore::Position::rendersInDifferentPosition):
  11412. (WebCore::Position::leadingWhitespacePosition):
  11413. * dom/Position.h:
  11414. (WebCore::Position::deprecatedEditingOffset):
  11415. (WebCore::Position::moveToOffset):
  11416. (WebCore::operator==):
  11417. * dom/PositionIterator.h:
  11418. (WebCore::PositionIterator::PositionIterator):
  11419. * dom/Range.cpp:
  11420. (WebCore::Range::create):
  11421. (WebCore::Range::compareBoundaryPoints):
  11422. * editing/ApplyStyleCommand.cpp:
  11423. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  11424. (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
  11425. (WebCore::ApplyStyleCommand::removeInlineStyle):
  11426. (WebCore::ApplyStyleCommand::nodeFullySelected):
  11427. (WebCore::ApplyStyleCommand::nodeFullyUnselected):
  11428. (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
  11429. (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
  11430. (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
  11431. (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
  11432. (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
  11433. (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
  11434. (WebCore::ApplyStyleCommand::joinChildTextNodes):
  11435. * editing/BreakBlockquoteCommand.cpp:
  11436. (WebCore::BreakBlockquoteCommand::doApply):
  11437. * editing/CompositeEditCommand.cpp:
  11438. (WebCore::CompositeEditCommand::insertNodeAt):
  11439. (WebCore::CompositeEditCommand::positionOutsideTabSpan):
  11440. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
  11441. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
  11442. (WebCore::CompositeEditCommand::deleteInsignificantText):
  11443. (WebCore::CompositeEditCommand::moveParagraphs):
  11444. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  11445. * editing/DeleteSelectionCommand.cpp:
  11446. (WebCore::updatePositionForNodeRemoval):
  11447. (WebCore::updatePositionForTextRemoval):
  11448. (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  11449. (WebCore::DeleteSelectionCommand::fixupWhitespace):
  11450. * editing/Editor.cpp:
  11451. (WebCore::Editor::setComposition):
  11452. (WebCore::Editor::advanceToNextMisspelling):
  11453. (WebCore::Editor::getCompositionSelection):
  11454. * editing/InsertLineBreakCommand.cpp:
  11455. (WebCore::InsertLineBreakCommand::doApply):
  11456. * editing/InsertParagraphSeparatorCommand.cpp:
  11457. (WebCore::InsertParagraphSeparatorCommand::doApply):
  11458. * editing/InsertTextCommand.cpp:
  11459. (WebCore::InsertTextCommand::performTrivialReplace):
  11460. (WebCore::InsertTextCommand::input):
  11461. (WebCore::InsertTextCommand::insertTab):
  11462. * editing/MoveSelectionCommand.cpp:
  11463. (WebCore::MoveSelectionCommand::doApply):
  11464. * editing/ReplaceSelectionCommand.cpp:
  11465. (WebCore::ReplaceSelectionCommand::doApply):
  11466. * editing/SelectionController.cpp:
  11467. (WebCore::SelectionController::debugRenderer):
  11468. * editing/TextIterator.cpp:
  11469. (WebCore::TextIterator::rangeFromLocationAndLength):
  11470. * editing/TypingCommand.cpp:
  11471. (WebCore::TypingCommand::deleteKeyPressed):
  11472. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  11473. * editing/VisiblePosition.cpp:
  11474. (WebCore::VisiblePosition::characterAfter):
  11475. (WebCore::VisiblePosition::debugPosition):
  11476. (WebCore::makeRange):
  11477. (WebCore::setStart):
  11478. (WebCore::setEnd):
  11479. * editing/VisibleSelection.cpp:
  11480. (WebCore::VisibleSelection::toNormalizedRange):
  11481. (WebCore::makeSearchRange):
  11482. (WebCore::VisibleSelection::debugPosition):
  11483. (WebCore::VisibleSelection::showTreeForThis):
  11484. * editing/htmlediting.cpp:
  11485. (WebCore::comparePositions):
  11486. (WebCore::rangeCompliantEquivalent):
  11487. * editing/visible_units.cpp:
  11488. (WebCore::previousBoundary):
  11489. (WebCore::nextBoundary):
  11490. (WebCore::startPositionForLine):
  11491. (WebCore::startOfLine):
  11492. (WebCore::endPositionForLine):
  11493. (WebCore::nextLinePosition):
  11494. (WebCore::startOfParagraph):
  11495. (WebCore::endOfParagraph):
  11496. (WebCore::logicalStartPositionForLine):
  11497. (WebCore::logicalEndPositionForLine):
  11498. * page/AccessibilityObject.cpp:
  11499. (WebCore::updateAXLineStartForVisiblePosition):
  11500. * page/AccessibilityRenderObject.cpp:
  11501. (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  11502. * page/DOMSelection.cpp:
  11503. (WebCore::DOMSelection::anchorOffset):
  11504. (WebCore::DOMSelection::focusOffset):
  11505. (WebCore::DOMSelection::baseOffset):
  11506. (WebCore::DOMSelection::extentOffset):
  11507. * page/EventHandler.cpp:
  11508. (WebCore::EventHandler::handleMousePressEventSingleClick):
  11509. * page/Frame.cpp:
  11510. (WebCore::Frame::selectionLayoutChanged):
  11511. * page/mac/AccessibilityObjectWrapper.mm:
  11512. (textMarkerForVisiblePosition):
  11513. (visiblePositionForTextMarker):
  11514. * rendering/RenderTextControl.cpp:
  11515. (WebCore::RenderTextControl::indexForVisiblePosition):
  11516. * rendering/RenderTreeAsText.cpp:
  11517. (WebCore::writeSelection):
  11518. 2009-04-29 Eric Seidel <eric@webkit.org>
  11519. No review, rolling out a patch.
  11520. Revert http://trac.webkit.org/changeset/43019
  11521. New tests failed because I removed the tabs from them
  11522. when landing (since we avoid tabs in WebKit files).
  11523. I couldn't tell if the new results were correct with
  11524. spaces or not.
  11525. * editing/SelectionController.cpp:
  11526. (WebCore::SelectionController::modifyExtendingForward):
  11527. (WebCore::SelectionController::modifyMovingForward):
  11528. (WebCore::SelectionController::modifyExtendingBackward):
  11529. (WebCore::SelectionController::modifyMovingBackward):
  11530. * editing/visible_units.cpp:
  11531. * editing/visible_units.h:
  11532. 2009-04-29 David Hyatt <hyatt@apple.com>
  11533. Reviewed by Dan Bernstein.
  11534. Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
  11535. when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
  11536. flag on Mac.
  11537. FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
  11538. from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.
  11539. * page/FrameView.cpp:
  11540. (WebCore::FrameView::FrameView):
  11541. (WebCore::FrameView::setContentsSize):
  11542. (WebCore::FrameView::layout):
  11543. (WebCore::FrameView::needsLayout):
  11544. (WebCore::FrameView::setNeedsLayout):
  11545. * page/FrameView.h:
  11546. 2009-04-29 Eric Seidel <eric@webkit.org>
  11547. No review, rolling out a patch.
  11548. Revert 43020 as it caused accessibility/lists.html to fail
  11549. and no one is around to tell me if it's a progression or not.
  11550. * page/AccessibilityObject.h:
  11551. (WebCore::):
  11552. * page/AccessibilityRenderObject.cpp:
  11553. (WebCore::AccessibilityRenderObject::roleValue):
  11554. (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  11555. * page/mac/AccessibilityObjectWrapper.mm:
  11556. (RoleEntry::):
  11557. 2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
  11558. Reviewed by Jon Honeycutt.
  11559. Add a new accessibility role for list items. Part of
  11560. http://bugs.webkit.org/show_id.cgi?id=20013
  11561. Tests: platform/win/accessibility/listitem-role.html
  11562. * page/AccessibilityObject.h:
  11563. (WebCore::): Add ListItemRole to accessibilityRole enum.
  11564. * page/AccessibilityRenderObject.cpp:
  11565. (WebCore::AccessibilityRenderObject::roleValue):Return
  11566. listItemRole when rendered object is a list item.
  11567. (WebCore::AccessibilityRenderObject::canSetFocusAttribute): Return
  11568. true for ListItemRole, matching firefox.
  11569. * page/mac/AccessibilityObjectWrapper.mm:
  11570. (RoleEntry::): Map ListItemRole with NSAccessibilityGroupRole in
  11571. MAC.
  11572. 2009-04-29 Xiaomei Ji <xji@chromium.org>
  11573. Reviewed by Dan Bernstein.
  11574. Fix https://bugs.webkit.org/show_bug.cgi?id=24168
  11575. RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
  11576. Test: editing/selection/home-end.html
  11577. * editing/SelectionController.cpp:
  11578. (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
  11579. to logicalEndOfLine() when granularity is LineBoundary.
  11580. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
  11581. to logicalEndOfLine() when granularity is LineBoundary
  11582. (WebCore::SelectionController::modifyExtendingBackward): Change calling
  11583. startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
  11584. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
  11585. to logicalStartOfLine() when granularity is LineBoundary.
  11586. * editing/visible_units.cpp:
  11587. (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
  11588. (WebCore::getLogicalStartBoxAndNode): Added.
  11589. (WebCore::getLogicalEndBoxAndNode): Added.
  11590. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
  11591. (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
  11592. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
  11593. (WebCore::inSameLogicalLine): Added.
  11594. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
  11595. * editing/visible_units.h:
  11596. 2009-04-29 Mike Belshe <mike@belshe.com>
  11597. Reviewed by Eric Seidel.
  11598. Update location while page is loading.
  11599. https://bugs.webkit.org/show_bug.cgi?id=21597
  11600. Tested by:
  11601. - fast/dom/location-new-window-no-crash
  11602. - fast/dom/Window/window-open-pending-url
  11603. * page/Location.cpp:
  11604. 2009-04-29 Feng Qian <feng@chromium.org>
  11605. Reviewed by Darin Adler.
  11606. Add Android port files to WebCore/platform.
  11607. https://bugs.webkit.org/show_bug.cgi?id=23296
  11608. * platform/android: Added.
  11609. * platform/android/ClipboardAndroid.cpp: Added.
  11610. * platform/android/ClipboardAndroid.h: Added.
  11611. 2009-04-29 Feng Qian <feng@chromium.org>
  11612. Reviewed by Darin Adler.
  11613. Add Android-specific files to the WebCore/page directory.
  11614. https://bugs.webkit.org/show_bug.cgi?id=23295
  11615. * page/android: Added.
  11616. * page/android/DragControllerAndroid.cpp: Added.
  11617. * page/android/EventHandlerAndroid.cpp: Added.
  11618. * page/android/InspectorControllerAndroid.cpp: Added.
  11619. 2009-04-29 Pavel Feldman <pfeldman@chromium.org>
  11620. Reviewed by Timothy Hatcher.
  11621. Extract PageGroupLoadDeferrer from Chrome.cpp
  11622. * GNUmakefile.am: added PageGroupLoadDeferrer
  11623. * WebCore.pro: ditto
  11624. * WebCore.scons: ditto
  11625. * WebCore.vcproj/WebCore.vcproj: ditto
  11626. * WebCore.xcodeproj/project.pbxproj: ditto
  11627. * WebCoreSources.bkl: ditto
  11628. * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
  11629. * page/PageGroupLoadDeferrer.cpp: Added.
  11630. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  11631. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  11632. * page/PageGroupLoadDeferrer.h: Added.
  11633. 2009-04-24 Ojan Vafai <ojan@chromium.org>
  11634. Reviewed by Dan Bernstein.
  11635. Make textarea and text input metrics more closely match IEs.
  11636. This involves:
  11637. -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
  11638. -set textarea width to cols*avgCharWidth
  11639. -Make default CSS match IEs
  11640. -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
  11641. Those values for textarea and inputs were derived by doing a ton of manual
  11642. testing of IE's width values for various textareas and fonts. On Windows we match
  11643. IE exactly except for a couple fonts of the ~12 tested.
  11644. To get the average and max character width of a font, we do the following
  11645. for each platform:
  11646. -Win: TextMetrics expose avgCharWidth and maxCharWidth
  11647. -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
  11648. maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
  11649. -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
  11650. maxCharWidth = max of avgCharWidth and m_ascent
  11651. -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
  11652. If either one is non-positive, then calculate the value using the Linux approach.
  11653. Tests: fast/forms/text-control-intrinsic-widths.html
  11654. fast/forms/textarea-metrics.html
  11655. svg/custom/svg-fonts-in-text-controls.html
  11656. * css/html4.css:
  11657. * css/themeWin.css:
  11658. * platform/graphics/SimpleFontData.cpp:
  11659. (WebCore::SimpleFontData::SimpleFontData):
  11660. (WebCore::SimpleFontData::initCharWidths):
  11661. * platform/graphics/SimpleFontData.h:
  11662. (WebCore::SimpleFontData::maxCharWidth):
  11663. (WebCore::SimpleFontData::avgCharWidth):
  11664. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  11665. (WebCore::SimpleFontData::platformCharWidthInit):
  11666. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  11667. (WebCore::SimpleFontData::platformCharWidthInit):
  11668. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  11669. (WebCore::SimpleFontData::platformCharWidthInit):
  11670. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  11671. (WebCore::SimpleFontData::platformCharWidthInit):
  11672. * platform/graphics/mac/SimpleFontDataMac.mm:
  11673. (WebCore::SimpleFontData::platformCharWidthInit):
  11674. * platform/graphics/qt/SimpleFontDataQt.cpp:
  11675. (WebCore::SimpleFontData::platformCharWidthInit):
  11676. * platform/graphics/win/SimpleFontDataCGWin.cpp:
  11677. (WebCore::SimpleFontData::platformCharWidthInit):
  11678. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  11679. (WebCore::SimpleFontData::platformInit):
  11680. (WebCore::SimpleFontData::platformCharWidthInit):
  11681. * platform/graphics/win/SimpleFontDataWin.cpp:
  11682. (WebCore::SimpleFontData::initGDIFont):
  11683. * platform/graphics/wx/SimpleFontDataWx.cpp:
  11684. (WebCore::SimpleFontData::platformCharWidthInit):
  11685. * rendering/RenderTextControl.cpp:
  11686. (WebCore::RenderTextControl::calcPrefWidths):
  11687. * rendering/RenderTextControlMultiLine.cpp:
  11688. (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  11689. * rendering/RenderTextControlSingleLine.cpp:
  11690. (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  11691. 2009-04-29 Brady Eidson <beidson@apple.com>
  11692. Reviewed by Darin Adler.
  11693. * bindings/objc/DOMCSS.mm:
  11694. (kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore
  11695. type and not the binding type.
  11696. 2009-04-29 John Abd-El-Malek <jam@google.com>
  11697. Reviewed by Dimitri Glazkov.
  11698. Reverted my previous change to add resetChromiumPluginCache().
  11699. https://bugs.webkit.org/show_bug.cgi?id=25318
  11700. * plugins/chromium/PluginDataChromium.cpp:
  11701. 2009-04-29 Brady Eidson <beidson@apple.com>
  11702. Reviewed by Darin Adler.
  11703. <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail
  11704. Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>
  11705. Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.
  11706. * loader/DocumentLoader.cpp:
  11707. (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
  11708. 2009-04-29 Alpha Lam <hclam@chromium.org>
  11709. Reviewed by Dimitri Glazkov.
  11710. https://bugs.webkit.org/show_bug.cgi?id=25430
  11711. Provide style sheet for UI controls of media elements for Chromium port.
  11712. * rendering/RenderThemeChromiumWin.cpp:
  11713. (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
  11714. 2009-04-29 John Abd-El-Malek <jam@chromium.org>
  11715. Reviewed by Darin Adler.
  11716. Expose sudden termination to Chromium port.
  11717. https://bugs.webkit.org/show_bug.cgi?id=25457
  11718. * platform/SuddenTermination.h:
  11719. * platform/chromium/ChromiumBridge.h:
  11720. * platform/chromium/SuddenTerminationChromium.cpp: Added.
  11721. (WebCore::disableSuddenTermination):
  11722. (WebCore::enableSuddenTermination):
  11723. 2009-04-29 Sam Weinig <sam@webkit.org>
  11724. Reviewed by Dimitri Glazkov.
  11725. Remove unused EventListeners.
  11726. * page/DOMWindow.idl:
  11727. 2009-04-29 Yury Semikhatsky <yurys@chromium.org>
  11728. Reveal current execution line once SourceFrame content is loaded.
  11729. https://bugs.webkit.org/show_bug.cgi?id=25448
  11730. Reviewed by Timothy Hatcher.
  11731. * inspector/front-end/SourceFrame.js:
  11732. (WebInspector.SourceFrame.prototype._loaded):
  11733. 2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
  11734. Reviewed by Simon Fraser.
  11735. [Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
  11736. the default values of canvas attributes.
  11737. * platform/graphics/qt/ImageBufferQt.cpp:
  11738. (WebCore::ImageBufferData::ImageBufferData):
  11739. 2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
  11740. Fix the Qt build.
  11741. * bridge/qt/qt_runtime.cpp:
  11742. (JSC::Bindings::findMethodIndex): Removed exec param from at() call.
  11743. (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
  11744. 2009-04-28 Geoffrey Garen <ggaren@apple.com>
  11745. Rubber stamped by Beth Dakin.
  11746. Missed one.
  11747. * bindings/scripts/CodeGeneratorJS.pm:
  11748. 2009-04-28 Geoffrey Garen <ggaren@apple.com>
  11749. Rubber stamped by Beth Dakin.
  11750. Removed scaffolding supporting dynamically converting between 32bit and
  11751. 64bit value representations.
  11752. * bindings/js/JSAudioConstructor.cpp:
  11753. (WebCore::constructAudio):
  11754. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  11755. (WebCore::JSCanvasRenderingContext2D::setFillColor):
  11756. (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
  11757. (WebCore::JSCanvasRenderingContext2D::strokeRect):
  11758. (WebCore::JSCanvasRenderingContext2D::drawImage):
  11759. (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
  11760. (WebCore::JSCanvasRenderingContext2D::setShadow):
  11761. (WebCore::JSCanvasRenderingContext2D::createPattern):
  11762. (WebCore::JSCanvasRenderingContext2D::putImageData):
  11763. (WebCore::JSCanvasRenderingContext2D::fillText):
  11764. (WebCore::JSCanvasRenderingContext2D::strokeText):
  11765. * bindings/js/JSClipboardCustom.cpp:
  11766. (WebCore::JSClipboard::clearData):
  11767. (WebCore::JSClipboard::getData):
  11768. (WebCore::JSClipboard::setData):
  11769. (WebCore::JSClipboard::setDragImage):
  11770. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  11771. (WebCore::JSDOMApplicationCache::hasItem):
  11772. (WebCore::JSDOMApplicationCache::add):
  11773. (WebCore::JSDOMApplicationCache::remove):
  11774. (WebCore::JSDOMApplicationCache::addEventListener):
  11775. (WebCore::JSDOMApplicationCache::removeEventListener):
  11776. * bindings/js/JSDOMStringListCustom.cpp:
  11777. (WebCore::JSDOMStringList::item):
  11778. * bindings/js/JSDOMWindowCustom.cpp:
  11779. (WebCore::JSDOMWindow::open):
  11780. (WebCore::JSDOMWindow::showModalDialog):
  11781. (WebCore::JSDOMWindow::postMessage):
  11782. (WebCore::JSDOMWindow::setTimeout):
  11783. (WebCore::JSDOMWindow::setInterval):
  11784. (WebCore::JSDOMWindow::atob):
  11785. (WebCore::JSDOMWindow::btoa):
  11786. (WebCore::JSDOMWindow::addEventListener):
  11787. (WebCore::JSDOMWindow::removeEventListener):
  11788. * bindings/js/JSDatabaseCustom.cpp:
  11789. (WebCore::JSDatabase::changeVersion):
  11790. (WebCore::JSDatabase::transaction):
  11791. * bindings/js/JSElementCustom.cpp:
  11792. (WebCore::JSElement::setAttribute):
  11793. (WebCore::JSElement::setAttributeNode):
  11794. (WebCore::JSElement::setAttributeNS):
  11795. (WebCore::JSElement::setAttributeNodeNS):
  11796. * bindings/js/JSGeolocationCustom.cpp:
  11797. (WebCore::JSGeolocation::getCurrentPosition):
  11798. (WebCore::JSGeolocation::watchPosition):
  11799. * bindings/js/JSHTMLCollectionCustom.cpp:
  11800. (WebCore::callHTMLCollection):
  11801. (WebCore::JSHTMLCollection::item):
  11802. (WebCore::JSHTMLCollection::namedItem):
  11803. * bindings/js/JSHTMLDocumentCustom.cpp:
  11804. (WebCore::documentWrite):
  11805. * bindings/js/JSHTMLInputElementCustom.cpp:
  11806. (WebCore::JSHTMLInputElement::setSelectionRange):
  11807. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  11808. (WebCore::JSHTMLOptionsCollection::add):
  11809. * bindings/js/JSHTMLSelectElementCustom.cpp:
  11810. (WebCore::JSHTMLSelectElement::remove):
  11811. * bindings/js/JSImageConstructor.cpp:
  11812. (WebCore::constructImage):
  11813. * bindings/js/JSInspectorControllerCustom.cpp:
  11814. (WebCore::JSInspectorController::highlightDOMNode):
  11815. (WebCore::JSInspectorController::addResourceSourceToFrame):
  11816. (WebCore::JSInspectorController::addSourceToFrame):
  11817. (WebCore::JSInspectorController::getResourceDocumentNode):
  11818. (WebCore::JSInspectorController::search):
  11819. (WebCore::JSInspectorController::databaseTableNames):
  11820. (WebCore::JSInspectorController::setting):
  11821. (WebCore::JSInspectorController::setSetting):
  11822. (WebCore::JSInspectorController::wrapCallback):
  11823. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  11824. (WebCore::JSJavaScriptCallFrame::evaluate):
  11825. * bindings/js/JSLocationCustom.cpp:
  11826. (WebCore::JSLocation::replace):
  11827. (WebCore::JSLocation::assign):
  11828. * bindings/js/JSMessagePortCustom.cpp:
  11829. (WebCore::JSMessagePort::startConversation):
  11830. (WebCore::JSMessagePort::addEventListener):
  11831. (WebCore::JSMessagePort::removeEventListener):
  11832. * bindings/js/JSNodeCustom.cpp:
  11833. (WebCore::JSNode::insertBefore):
  11834. (WebCore::JSNode::replaceChild):
  11835. (WebCore::JSNode::removeChild):
  11836. (WebCore::JSNode::appendChild):
  11837. (WebCore::JSNode::addEventListener):
  11838. (WebCore::JSNode::removeEventListener):
  11839. * bindings/js/JSNodeFilterCustom.cpp:
  11840. (WebCore::JSNodeFilter::acceptNode):
  11841. * bindings/js/JSNodeListCustom.cpp:
  11842. (WebCore::callNodeList):
  11843. * bindings/js/JSOptionConstructor.cpp:
  11844. (WebCore::constructHTMLOptionElement):
  11845. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  11846. (WebCore::JSQuarantinedObjectWrapper::construct):
  11847. (WebCore::JSQuarantinedObjectWrapper::call):
  11848. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  11849. (WebCore::JSSQLResultSetRowList::item):
  11850. * bindings/js/JSSQLTransactionCustom.cpp:
  11851. (WebCore::JSSQLTransaction::executeSql):
  11852. * bindings/js/JSSVGElementInstanceCustom.cpp:
  11853. (WebCore::JSSVGElementInstance::addEventListener):
  11854. (WebCore::JSSVGElementInstance::removeEventListener):
  11855. * bindings/js/JSSVGLengthCustom.cpp:
  11856. (WebCore::JSSVGLength::convertToSpecifiedUnits):
  11857. * bindings/js/JSSVGMatrixCustom.cpp:
  11858. (WebCore::JSSVGMatrix::rotateFromVector):
  11859. * bindings/js/JSSVGPathSegListCustom.cpp:
  11860. (WebCore::JSSVGPathSegList::initialize):
  11861. (WebCore::JSSVGPathSegList::getItem):
  11862. (WebCore::JSSVGPathSegList::insertItemBefore):
  11863. (WebCore::JSSVGPathSegList::replaceItem):
  11864. (WebCore::JSSVGPathSegList::removeItem):
  11865. (WebCore::JSSVGPathSegList::appendItem):
  11866. * bindings/js/JSSVGPointListCustom.cpp:
  11867. (WebCore::JSSVGPointList::initialize):
  11868. (WebCore::JSSVGPointList::getItem):
  11869. (WebCore::JSSVGPointList::insertItemBefore):
  11870. (WebCore::JSSVGPointList::replaceItem):
  11871. (WebCore::JSSVGPointList::removeItem):
  11872. (WebCore::JSSVGPointList::appendItem):
  11873. * bindings/js/JSSVGTransformListCustom.cpp:
  11874. (WebCore::JSSVGTransformList::initialize):
  11875. (WebCore::JSSVGTransformList::getItem):
  11876. (WebCore::JSSVGTransformList::insertItemBefore):
  11877. (WebCore::JSSVGTransformList::replaceItem):
  11878. (WebCore::JSSVGTransformList::removeItem):
  11879. (WebCore::JSSVGTransformList::appendItem):
  11880. * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
  11881. (WebCore::constructWebKitCSSMatrix):
  11882. * bindings/js/JSWebKitPointConstructor.cpp:
  11883. (WebCore::constructWebKitPoint):
  11884. * bindings/js/JSWorkerConstructor.cpp:
  11885. (WebCore::constructWorker):
  11886. * bindings/js/JSWorkerContextCustom.cpp:
  11887. (WebCore::JSWorkerContext::importScripts):
  11888. (WebCore::JSWorkerContext::addEventListener):
  11889. (WebCore::JSWorkerContext::removeEventListener):
  11890. (WebCore::JSWorkerContext::setTimeout):
  11891. (WebCore::JSWorkerContext::setInterval):
  11892. * bindings/js/JSWorkerCustom.cpp:
  11893. (WebCore::JSWorker::addEventListener):
  11894. (WebCore::JSWorker::removeEventListener):
  11895. * bindings/js/JSXMLHttpRequestCustom.cpp:
  11896. (WebCore::JSXMLHttpRequest::open):
  11897. (WebCore::JSXMLHttpRequest::setRequestHeader):
  11898. (WebCore::JSXMLHttpRequest::send):
  11899. (WebCore::JSXMLHttpRequest::getResponseHeader):
  11900. (WebCore::JSXMLHttpRequest::overrideMimeType):
  11901. (WebCore::JSXMLHttpRequest::addEventListener):
  11902. (WebCore::JSXMLHttpRequest::removeEventListener):
  11903. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  11904. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  11905. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  11906. * bindings/js/JSXSLTProcessorCustom.cpp:
  11907. (WebCore::JSXSLTProcessor::importStylesheet):
  11908. (WebCore::JSXSLTProcessor::transformToFragment):
  11909. (WebCore::JSXSLTProcessor::transformToDocument):
  11910. (WebCore::JSXSLTProcessor::setParameter):
  11911. (WebCore::JSXSLTProcessor::getParameter):
  11912. (WebCore::JSXSLTProcessor::removeParameter):
  11913. * bindings/js/ScheduledAction.cpp:
  11914. (WebCore::ScheduledAction::create):
  11915. (WebCore::ScheduledAction::ScheduledAction):
  11916. * bindings/js/ScheduledAction.h:
  11917. * bindings/js/ScriptCallFrame.cpp:
  11918. (WebCore::ScriptCallFrame::ScriptCallFrame):
  11919. * bindings/js/ScriptCallFrame.h:
  11920. * bindings/js/ScriptCallStack.cpp:
  11921. (WebCore::ScriptCallStack::ScriptCallStack):
  11922. (WebCore::ScriptCallStack::initialize):
  11923. * bridge/c/c_instance.cpp:
  11924. (JSC::Bindings::CInstance::invokeMethod):
  11925. (JSC::Bindings::CInstance::invokeDefaultMethod):
  11926. (JSC::Bindings::CInstance::invokeConstruct):
  11927. * bridge/jni/jni_instance.cpp:
  11928. (JavaInstance::invokeMethod):
  11929. * bridge/objc/objc_instance.mm:
  11930. (ObjcInstance::invokeMethod):
  11931. (ObjcInstance::invokeDefaultMethod):
  11932. 2009-04-28 David Carson <dacarson@apple.com>
  11933. Reviewed by David Hyatt.
  11934. Restore alignment to device pixel boundaries.
  11935. https://bugs.webkit.org/show_bug.cgi?id=25458
  11936. Adjust the adjusted destination rect to be device pixel aligned.
  11937. * platform/graphics/cg/ImageCG.cpp:
  11938. (WebCore::BitmapImage::draw):
  11939. 2009-04-28 Sam Weinig <sam@webkit.org>
  11940. Reviewed by Anders Carlsson.
  11941. Move unimplemented captureEvents and releaseEvents from JSDOMWindow
  11942. to DOMWindow.
  11943. * bindings/js/JSDOMWindowCustom.cpp:
  11944. * page/DOMWindow.cpp:
  11945. (WebCore::DOMWindow::captureEvents):
  11946. (WebCore::DOMWindow::releaseEvents):
  11947. * page/DOMWindow.h:
  11948. * page/DOMWindow.idl:
  11949. 2009-04-28 Alexey Proskuryakov <ap@webkit.org>
  11950. Reviewed by Darin Adler.
  11951. https://bugs.webkit.org/show_bug.cgi?id=25420
  11952. <rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
  11953. Test: http/tests/xmlhttprequest/detaching-frame-2.html
  11954. This was caused by faulty DOMWindow::document(), which could return a new document from
  11955. the window's frame after navigation.
  11956. * bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
  11957. Removed an obsolete check that allowed access when document was null. Contrary to what a
  11958. comment said, that can happen for a window that is no longer in frame, not to one whose
  11959. document is not constructed yet.
  11960. * bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
  11961. out if context was not found. This currently happens due to a shortcoming in
  11962. DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
  11963. test will be constructed successfully, but won't be sent, because its context will be
  11964. frameless.
  11965. * page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
  11966. been replaced yet. Added FIXME comments about how this may be better fixed in the future.
  11967. * bindings/js/JSAudioConstructor.cpp:
  11968. (WebCore::JSAudioConstructor::document):
  11969. (WebCore::constructAudio):
  11970. * bindings/js/JSImageConstructor.cpp:
  11971. (WebCore::JSImageConstructor::document):
  11972. (WebCore::constructImage):
  11973. * bindings/js/JSMessageChannelConstructor.cpp:
  11974. (WebCore::JSMessageChannelConstructor::construct):
  11975. * bindings/js/JSOptionConstructor.cpp:
  11976. (WebCore::JSOptionConstructor::document):
  11977. (WebCore::constructHTMLOptionElement):
  11978. Make matching changes to other constructors that hold a reference to global object.
  11979. 2009-04-28 Kevin Ollivier <kevino@theolliviers.com>
  11980. wxMSW build fix. Switch JSCore build back to static.
  11981. * config.h:
  11982. 2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
  11983. Reviewed by Simon Fraser.
  11984. <rdar://problem/6834830>
  11985. Make sure we cover the two possible values reported by event.total that are playback engine
  11986. specific.
  11987. * media/progress-event-total-expected.txt: Match the new test.
  11988. * media/progress-event-total.html: Test the two values.
  11989. 2009-04-28 Timothy Hatcher <timothy@apple.com>
  11990. Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
  11991. collects the individual rects, making sure to only include RenderText.
  11992. <rdar://problem/6810061>
  11993. Reviewed by Sam Weinig.
  11994. * bindings/objc/DOM.mm:
  11995. (-[DOMNode textRects]): Added. Make a Range and call textRects.
  11996. (-[DOMNode lineBoxRects]): Call textRects method.
  11997. (-[DOMRange textRects]): Call Range::textRects.
  11998. (-[DOMRange lineBoxRects]): Call textRects method.
  11999. * bindings/objc/DOMPrivate.h: Add the new methods and a comment
  12000. about lineBoxRects being deprecated.
  12001. * dom/Range.cpp:
  12002. (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
  12003. (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
  12004. nodes instead of the RenderObjects to correctly account for offsets. Also
  12005. only call absoluteRectsForRange on RenderText.
  12006. * dom/Range.h: Renamed addLineBoxRects to textRects.
  12007. * page/Frame.cpp:
  12008. (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
  12009. * rendering/RenderObject.cpp:
  12010. (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
  12011. function very specific for the lineBoxRects API. These functions are still used
  12012. by the InspectorController, and this change improves what the Inspector shows.
  12013. (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
  12014. 2009-04-28 Timothy Hatcher <timothy@apple.com>
  12015. Remove the topLevel boolean argument from absolute{Rects,Quads}.
  12016. This argument was default to true and no one ever passed false.
  12017. Reviewed by Sam Weinig.
  12018. * rendering/RenderBlock.cpp:
  12019. (WebCore::RenderBlock::absoluteRects):
  12020. (WebCore::RenderBlock::absoluteQuads):
  12021. * rendering/RenderBlock.h:
  12022. * rendering/RenderBox.cpp:
  12023. (WebCore::RenderBox::absoluteRects):
  12024. (WebCore::RenderBox::absoluteQuads):
  12025. * rendering/RenderBox.h:
  12026. * rendering/RenderInline.cpp:
  12027. (WebCore::RenderInline::absoluteRects):
  12028. (WebCore::RenderInline::absoluteQuads):
  12029. * rendering/RenderInline.h:
  12030. * rendering/RenderObject.h:
  12031. (WebCore::RenderObject::absoluteRects):
  12032. (WebCore::RenderObject::absoluteQuads):
  12033. * rendering/RenderSVGHiddenContainer.cpp:
  12034. (WebCore::RenderSVGHiddenContainer::absoluteRects):
  12035. (WebCore::RenderSVGHiddenContainer::absoluteQuads):
  12036. * rendering/RenderSVGHiddenContainer.h:
  12037. * rendering/RenderSVGImage.cpp:
  12038. (WebCore::RenderSVGImage::absoluteRects):
  12039. (WebCore::RenderSVGImage::absoluteQuads):
  12040. * rendering/RenderSVGImage.h:
  12041. * rendering/RenderSVGInlineText.cpp:
  12042. (WebCore::RenderSVGInlineText::absoluteRects):
  12043. (WebCore::RenderSVGInlineText::absoluteQuads):
  12044. * rendering/RenderSVGInlineText.h:
  12045. * rendering/RenderSVGModelObject.cpp:
  12046. (WebCore::RenderSVGModelObject::absoluteRects):
  12047. (WebCore::RenderSVGModelObject::absoluteQuads):
  12048. * rendering/RenderSVGModelObject.h:
  12049. * rendering/RenderSVGTSpan.cpp:
  12050. (WebCore::RenderSVGTSpan::absoluteRects):
  12051. (WebCore::RenderSVGTSpan::absoluteQuads):
  12052. * rendering/RenderSVGTSpan.h:
  12053. * rendering/RenderSVGText.cpp:
  12054. (WebCore::RenderSVGText::absoluteRects):
  12055. (WebCore::RenderSVGText::absoluteQuads):
  12056. * rendering/RenderSVGText.h:
  12057. * rendering/RenderSVGTextPath.cpp:
  12058. (WebCore::RenderSVGTextPath::absoluteQuads):
  12059. * rendering/RenderSVGTextPath.h:
  12060. * rendering/RenderText.cpp:
  12061. (WebCore::RenderText::absoluteRects):
  12062. * rendering/RenderText.h:
  12063. * rendering/RenderView.cpp:
  12064. (WebCore::RenderView::absoluteRects):
  12065. (WebCore::RenderView::absoluteQuads):
  12066. * rendering/RenderView.h:
  12067. 2009-04-28 Eric Carlson <eric.carlson@apple.com>
  12068. Reviewed by Simon Fraser.
  12069. <rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
  12070. RenderThemeWin doesn't implement the media element controller rendering methods, so media
  12071. controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
  12072. of the code in both places, the logic is in a new class that is called from both.
  12073. * WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
  12074. * rendering/RenderMediaControls.cpp: Added.
  12075. (WebCore::determineState): Translate renderer state to ThemeControlState.
  12076. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
  12077. (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
  12078. (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
  12079. * rendering/RenderMediaControls.h: Added.
  12080. * rendering/RenderThemeSafari.cpp:
  12081. (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
  12082. called for the media slider.
  12083. (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
  12084. (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
  12085. (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
  12086. (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
  12087. (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
  12088. (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
  12089. (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
  12090. (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
  12091. * rendering/RenderThemeWin.cpp:
  12092. (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
  12093. (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
  12094. (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
  12095. (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
  12096. (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
  12097. (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
  12098. (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
  12099. (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
  12100. * rendering/RenderThemeWin.h:
  12101. 2009-04-28 Beth Dakin <bdakin@apple.com>
  12102. Reviewed by Sam Weinig.
  12103. Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
  12104. images with % height are collapsed when printing
  12105. * rendering/RenderBox.cpp:
  12106. (WebCore::RenderBox::calcHeight): Make sure we don't ignore
  12107. printing here!
  12108. 2009-04-28 Adele Peterson <adele@apple.com>
  12109. Reviewed by Darin Adler.
  12110. Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
  12111. Test: editing/deleting/type-delete-after-quote.html
  12112. When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
  12113. since it is unclear to most users that such a selection actually ends at the start of the next paragraph. However, when a user hits delete
  12114. with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it. We can tell that
  12115. we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection. So we can tell
  12116. that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
  12117. from deleting a range they selected.
  12118. * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
  12119. 2009-04-28 Xan Lopez <xlopez@igalia.com>
  12120. Unreviewed: fix distcheck build, add missing header to file list.
  12121. * GNUmakefile.am:
  12122. 2009-04-27 Eric Seidel <eric@webkit.org>
  12123. Reviewed by Sam Weinig.
  12124. Fix foreignObject transform order
  12125. https://bugs.webkit.org/show_bug.cgi?id=25433
  12126. Transforms were being applied in the wrong order.
  12127. When mapping from local to parent, first apply the viewport transform
  12128. then map from the viewport box to the parent box.
  12129. * rendering/RenderForeignObject.cpp:
  12130. (WebCore::RenderForeignObject::localToParentTransform):
  12131. 2009-04-27 Eric Seidel <eric@webkit.org>
  12132. Reviewed by Simon Fraser.
  12133. Simplify nodeAtPoint for SVG
  12134. https://bugs.webkit.org/show_bug.cgi?id=25432
  12135. Added a new nodeAtFloatPoint method which takes a FloatPoint
  12136. instead of the *super confusing* x/y tx/ty pairs that HTML uses.
  12137. Mostly this is just lots of minus-lines as the new code is *much* simpler.
  12138. I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
  12139. for the nodeAtPoint HTML/CSS int x/y version.
  12140. Eventually the rest of CSS/HTML render objects will follow suit
  12141. and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
  12142. over was well outside the scope of this change.
  12143. SVG hit testing is not actually floating point precise yet, since its still
  12144. passed in an integer x/y. Certain transform hit-test edge cases are likely fixed
  12145. by moving to FloatPoint here, but I didn't try to find one.
  12146. This should not cause functional changes for common-case hit testing, thus
  12147. no tests changed, nor should new tests be needed.
  12148. * rendering/RenderForeignObject.cpp:
  12149. (WebCore::RenderForeignObject::translationForAttributes):
  12150. (WebCore::RenderForeignObject::paint):
  12151. (WebCore::RenderForeignObject::computeRectForRepaint):
  12152. (WebCore::RenderForeignObject::localToParentTransform):
  12153. (WebCore::RenderForeignObject::layout):
  12154. (WebCore::RenderForeignObject::nodeAtFloatPoint):
  12155. * rendering/RenderForeignObject.h:
  12156. * rendering/RenderObject.cpp:
  12157. (WebCore::RenderObject::nodeAtFloatPoint):
  12158. * rendering/RenderObject.h:
  12159. * rendering/RenderPath.cpp:
  12160. (WebCore::RenderPath::nodeAtFloatPoint):
  12161. * rendering/RenderPath.h:
  12162. * rendering/RenderSVGContainer.cpp:
  12163. (WebCore::RenderSVGContainer::nodeAtFloatPoint):
  12164. * rendering/RenderSVGContainer.h:
  12165. (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
  12166. * rendering/RenderSVGHiddenContainer.cpp:
  12167. (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
  12168. * rendering/RenderSVGHiddenContainer.h:
  12169. * rendering/RenderSVGImage.cpp:
  12170. (WebCore::RenderSVGImage::paint):
  12171. (WebCore::RenderSVGImage::nodeAtFloatPoint):
  12172. * rendering/RenderSVGImage.h:
  12173. (WebCore::RenderSVGImage::localToParentTransform):
  12174. (WebCore::RenderSVGImage::localTransform):
  12175. * rendering/RenderSVGModelObject.cpp:
  12176. (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
  12177. * rendering/RenderSVGModelObject.h:
  12178. * rendering/RenderSVGRoot.cpp:
  12179. (WebCore::RenderSVGRoot::nodeAtFloatPoint):
  12180. * rendering/RenderSVGText.cpp:
  12181. (WebCore::RenderSVGText::nodeAtFloatPoint):
  12182. * rendering/RenderSVGText.h:
  12183. * rendering/RenderSVGViewportContainer.cpp:
  12184. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
  12185. * rendering/RenderSVGViewportContainer.h:
  12186. 2009-04-28 Eric Carlson <eric.carlson@apple.com>
  12187. - fix the Tiger build
  12188. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  12189. (WebCore::MediaPlayerPrivate::cacheMovieScale):
  12190. 2009-04-28 Sam Weinig <sam@webkit.org>
  12191. Reviewed by Beth Dakin.
  12192. Consolidate ScheduleAction creation into ScheduledAction::create.
  12193. Autogenerate JSWorkerContext.clearTimeout and clearInterval.
  12194. * bindings/js/JSDOMWindowCustom.cpp:
  12195. (WebCore::JSDOMWindow::setTimeout):
  12196. (WebCore::JSDOMWindow::setInterval):
  12197. * bindings/js/JSWorkerContextCustom.cpp:
  12198. (WebCore::JSWorkerContext::setTimeout):
  12199. (WebCore::JSWorkerContext::setInterval):
  12200. * bindings/js/ScheduledAction.cpp:
  12201. (WebCore::ScheduledAction::create):
  12202. (WebCore::ScheduledAction::ScheduledAction):
  12203. (WebCore::ScheduledAction::execute):
  12204. * bindings/js/ScheduledAction.h:
  12205. * workers/WorkerContext.cpp:
  12206. (WebCore::DOMWindow::setTimeout):
  12207. (WebCore::DOMWindow::clearTimeout):
  12208. (WebCore::DOMWindow::setInterval):
  12209. (WebCore::DOMWindow::clearInterval):
  12210. * workers/WorkerContext.h:
  12211. * workers/WorkerContext.idl:
  12212. 2009-04-28 Brady Eidson <beidson@apple.com>
  12213. Reviewed by Darin Adler
  12214. <rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
  12215. When moving Nodes between documents we weren't properly updating style declarations. Certain operations, such
  12216. as creating webarchives, would tickle this bug.
  12217. Tests: webarchive/adopt-attribute-styled-body-webarchive.html
  12218. webarchive/adopt-attribute-styled-node-webarchive.html
  12219. webarchive/adopt-inline-styled-node-webarchive.html
  12220. * dom/Node.cpp: Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument
  12221. calls their parent-class implementation after they've done their own work.
  12222. (WebCore::setWillMoveToNewOwnerDocumentWasCalled):
  12223. (WebCore::setDidMoveToNewOwnerDocumentWasCalled):
  12224. (WebCore::Node::setDocument):
  12225. (WebCore::Node::willMoveToNewOwnerDocument):
  12226. (WebCore::Node::didMoveToNewOwnerDocument):
  12227. * dom/StyledElement.cpp:
  12228. (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap
  12229. to update style declarations.
  12230. (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
  12231. * dom/StyledElement.h:
  12232. * html/HTMLBodyElement.cpp:
  12233. (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
  12234. * html/HTMLBodyElement.h:
  12235. 2009-04-28 Eric Carlson <eric.carlson@apple.com>
  12236. Reviewed by Darin Adler.
  12237. <rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
  12238. QTMoviePreferredTransformAttribute
  12239. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  12240. (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of
  12241. BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit
  12242. that throw an exception on QTMovieCurrentSizeAttribute but don't support
  12243. QTMoviePreferredTransformAttribute
  12244. 2009-04-28 Darin Adler <darin@apple.com>
  12245. Reviewed by Sam Weinig.
  12246. * rendering/RenderText.cpp:
  12247. (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count
  12248. churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment.
  12249. (WebCore::RenderText::setTextInternal): Ditto.
  12250. 2009-04-27 Eric Seidel <eric@webkit.org>
  12251. Reviewed by Simon Fraser.
  12252. Simplify how SVG containers paint
  12253. https://bugs.webkit.org/show_bug.cgi?id=25431
  12254. Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
  12255. Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
  12256. RenderSVGText now applies transforms at paint() time instead of during chunk draw time
  12257. this should be much more efficient.
  12258. Fixed the order in which RenderSVGViewportContainer applied
  12259. transforms and clips. We now clip to the viewport first and apply
  12260. all transforms at once. Also since the viewport logic is now only
  12261. inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
  12262. we always know we have a viewport. We now use only viewportSize instead of
  12263. viewport() since RenderSVGViewportContainers can't have x/y offsets.
  12264. We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
  12265. This allowed us to apply the transform during text paint() instead of at chunk paint
  12266. time. Previously we had to apply the transform during chunk paint time because
  12267. RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
  12268. before telling any of the inlines to draw. Now that we adjust the damage rect correctly
  12269. we pass the intersection check correctly! (This probably fixed some <text> redraw bugs
  12270. but since I still have a bunch of those to fix, I've not tried to write additional tests
  12271. to cover these potential fixes yet.)
  12272. SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
  12273. * rendering/RenderPath.cpp:
  12274. (WebCore::RenderPath::repaintRectInLocalCoordinates):
  12275. (WebCore::RenderPath::paint):
  12276. * rendering/RenderSVGContainer.cpp:
  12277. (WebCore::RenderSVGContainer::paint):
  12278. (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  12279. * rendering/RenderSVGContainer.h:
  12280. (WebCore::RenderSVGContainer::applyViewportClip):
  12281. * rendering/RenderSVGImage.cpp:
  12282. (WebCore::RenderSVGImage::layout):
  12283. (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  12284. (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
  12285. (WebCore::RenderSVGImage::computeRectForRepaint):
  12286. * rendering/RenderSVGImage.h:
  12287. * rendering/RenderSVGModelObject.cpp:
  12288. * rendering/RenderSVGModelObject.h:
  12289. * rendering/RenderSVGRoot.cpp:
  12290. (WebCore::RenderSVGRoot::layout):
  12291. (WebCore::RenderSVGRoot::selfWillPaint):
  12292. (WebCore::RenderSVGRoot::paint):
  12293. (WebCore::RenderSVGRoot::viewportSize):
  12294. (WebCore::RenderSVGRoot::calcViewport):
  12295. (WebCore::RenderSVGRoot::localToBorderBoxTransform):
  12296. (WebCore::RenderSVGRoot::parentOriginToBorderBox):
  12297. (WebCore::RenderSVGRoot::borderOriginToContentBox):
  12298. (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
  12299. (WebCore::RenderSVGRoot::localToParentTransform):
  12300. (WebCore::RenderSVGRoot::computeRectForRepaint):
  12301. (WebCore::RenderSVGRoot::nodeAtPoint):
  12302. * rendering/RenderSVGRoot.h:
  12303. * rendering/RenderSVGText.cpp:
  12304. (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
  12305. (WebCore::RenderSVGText::computeRectForRepaint):
  12306. (WebCore::RenderSVGText::paint):
  12307. (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  12308. * rendering/RenderSVGText.h:
  12309. (WebCore::RenderSVGText::localToParentTransform):
  12310. (WebCore::RenderSVGText::localTransform):
  12311. * rendering/RenderSVGViewportContainer.cpp:
  12312. (WebCore::RenderSVGViewportContainer::applyViewportClip):
  12313. * rendering/RenderSVGViewportContainer.h:
  12314. * rendering/SVGRenderSupport.cpp:
  12315. (WebCore::filterBoundingBoxForRenderer):
  12316. (WebCore::applyTransformToPaintInfo):
  12317. * rendering/SVGRenderSupport.h:
  12318. * rendering/SVGRootInlineBox.cpp:
  12319. (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
  12320. (WebCore::SVGRootInlineBox::paint):
  12321. 2009-04-28 Chris Fleizach <cfleizach@apple.com>
  12322. Reviewed by Darin Adler.
  12323. Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
  12324. https://bugs.webkit.org/show_bug.cgi?id=25453
  12325. Test: accessibility/placeholder.html
  12326. * page/AccessibilityRenderObject.cpp:
  12327. (WebCore::AccessibilityRenderObject::title):
  12328. 2009-04-28 Chris Fleizach <cfleizach@apple.com>
  12329. Reviewed by Darin Adler.
  12330. Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
  12331. https://bugs.webkit.org/show_bug.cgi?id=25452
  12332. Test: accessibility/ignore-spacer-elements.html
  12333. * page/AccessibilityRenderObject.cpp:
  12334. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  12335. 2009-04-28 Mark Rowe <mrowe@apple.com>
  12336. Reviewed by Sam Weinig.
  12337. Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
  12338. This removes the need for us to explicitly initialize all of the members, which have a tendency
  12339. to change in meaning and number between versions of libxml2.
  12340. * dom/XMLTokenizerLibxml2.cpp:
  12341. (WebCore::):
  12342. (WebCore::sharedXHTMLEntity):
  12343. (WebCore::getXHTMLEntity):
  12344. 2009-04-28 Steve Falkenburg <sfalken@apple.com>
  12345. Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.
  12346. Reviewed by Mark Rowe.
  12347. * WebCore.vcproj/QTMovieWin.vcproj:
  12348. 2009-04-28 Chris Fleizach <cfleizach@apple.com>
  12349. Reviewed by Darin Adler.
  12350. Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
  12351. https://bugs.webkit.org/show_bug.cgi?id=25449
  12352. Test: accessibility/img-aria-button-alt-tag.html
  12353. * page/AccessibilityRenderObject.cpp:
  12354. (WebCore::AccessibilityRenderObject::accessibilityDescription):
  12355. 2009-04-28 Dan Bernstein <mitz@apple.com>
  12356. Reviewed by John Sullivan.
  12357. - formatting cleanup
  12358. * rendering/RenderBox.cpp:
  12359. (WebCore::RenderBox::calcHeight): Corrected indentation and added braces
  12360. around a multi-line "else" clause.
  12361. 2009-04-28 Eric Carlson <eric.carlson@apple.com>
  12362. Reviewed by Adam Roben
  12363. <rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
  12364. https://bugs.webkit.org/show_bug.cgi?id=25094
  12365. Display movies saved with a non-identity matrix at the correct size.
  12366. * platform/graphics/win/QTMovieWin.cpp:
  12367. (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor.
  12368. (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial
  12369. size and natural size so naturalSize() accounts for non-identity movie matrix.
  12370. (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches
  12371. kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState.
  12372. (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState.
  12373. (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches
  12374. kMovieLoadStateLoaded because we do not try to draw it before that point.
  12375. (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded
  12376. because we need to get the movie's initial size in cacheMovieScale.
  12377. (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.
  12378. 2009-04-28 Sam Weinig <sam@webkit.org>
  12379. Reviewed by Dan Bernstein.
  12380. Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
  12381. clearInterval can now be autogenerated.
  12382. * bindings/js/JSDOMWindowBase.cpp:
  12383. * bindings/js/JSDOMWindowBase.h:
  12384. * bindings/js/JSDOMWindowCustom.cpp:
  12385. (WebCore::createScheduledAction):
  12386. (WebCore::JSDOMWindow::setTimeout):
  12387. (WebCore::JSDOMWindow::setInterval):
  12388. * page/DOMWindow.cpp:
  12389. (WebCore::DOMWindow::setTimeout):
  12390. (WebCore::DOMWindow::clearTimeout):
  12391. (WebCore::DOMWindow::setInterval):
  12392. (WebCore::DOMWindow::clearInterval):
  12393. * page/DOMWindow.h:
  12394. * page/DOMWindow.idl:
  12395. 2009-04-28 Kevin Watters <kevinwatters@gmail.com>
  12396. Reviewed by Kevin Ollivier.
  12397. Small optimization, don't get the widget's handle twice in one method.
  12398. https://bugs.webkit.org/show_bug.cgi?id=25446
  12399. * platform/wx/WidgetWx.cpp:
  12400. (WebCore::Widget::setFocus):
  12401. (WebCore::Widget::show):
  12402. (WebCore::Widget::hide):
  12403. (WebCore::Widget::frameRect):
  12404. (WebCore::Widget::setFrameRect):
  12405. (WebCore::Widget::invalidateRect):
  12406. (WebCore::Widget::paint):
  12407. 2009-04-28 Kevin Watters <kevinwatters@gmail.com>
  12408. Reviewed by Kevin Ollivier.
  12409. ScrollView copy and paste typo fix.
  12410. https://bugs.webkit.org/show_bug.cgi?id=25445
  12411. * platform/wx/ScrollViewWx.cpp:
  12412. (WebCore::ScrollView::platformSetScrollbarModes):
  12413. 2009-04-28 John Sullivan <sullivan@apple.com>
  12414. <rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII
  12415. Reviewed by Adam Roben
  12416. * loader/ImageDocument.cpp:
  12417. (WebCore::ImageTokenizer::finish):
  12418. decode the filename before processing it as part of the image name that's passed to the client
  12419. 2009-04-28 Maciej Stachowiak <mjs@apple.com>
  12420. Not reviewed, build fix.
  12421. - fix initialization order to match declaration order to fix release build
  12422. * page/Settings.cpp:
  12423. (WebCore::Settings::Settings):
  12424. 2009-04-28 Xan Lopez <xlopez@igalia.com>
  12425. Reviewed by Justin Garcia.
  12426. https://bugs.webkit.org/show_bug.cgi?id=16135
  12427. [GTK] Support caret browsing
  12428. Based on a patch by Alp Toker.
  12429. Implement basic support for caret browsing, active only when the
  12430. corresponding setting is enabled.
  12431. * page/EventHandler.cpp:
  12432. (WebCore::EventHandler::handleMouseReleaseEvent):
  12433. * page/FocusController.cpp:
  12434. (WebCore::FocusController::advanceFocus):
  12435. (WebCore::clearSelectionIfNeeded):
  12436. (WebCore::FocusController::setFocusedNode):
  12437. * page/Frame.cpp:
  12438. (WebCore::Frame::setFocusedNodeIfNeeded):
  12439. (WebCore::Frame::setSelectionFromNone):
  12440. (WebCore::Frame::respondToChangedSelection):
  12441. * page/Settings.cpp:
  12442. (WebCore::Settings::Settings):
  12443. * page/Settings.h:
  12444. * rendering/RenderBlock.cpp:
  12445. (WebCore::RenderBlock::paintCaret):
  12446. 2009-04-27 Eric Roman <eroman@chromium.org>
  12447. Reviewed by Darin Fisher.
  12448. Fix a compile breakage.
  12449. <https://bugs.webkit.org/show_bug.cgi?id=25384>
  12450. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  12451. (WebCore::CALLBACK_FUNC_DECL):
  12452. 2009-04-27 Eric Carlson <eric.carlson@apple.com>
  12453. Reviewed by Darin Adler.
  12454. <rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash
  12455. QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
  12456. multiplier to scale from natural size to current size when a movie is opened and use that to
  12457. return the correct value from the naturalSize() method.
  12458. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  12459. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  12460. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor.
  12461. (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale.
  12462. (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial
  12463. size and natural size so naturalSize() accounts for non-identity movie matrix.
  12464. (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches
  12465. QTMovieLoadStateLoaded for the first time.
  12466. 2009-04-27 Beth Dakin <bdakin@apple.com>
  12467. Reviewed by Dave Hyatt.
  12468. Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
  12469. The problem here is that we had a self-painting layer nested inside
  12470. a non-self-painting layer. We ended up ignoring the self-painting
  12471. layer both during painting and hit-testing. This patch corrects
  12472. that.
  12473. * rendering/RenderLayer.cpp:
  12474. (WebCore::RenderLayer::paintLayer):
  12475. (WebCore::RenderLayer::hitTestLayer):
  12476. 2009-04-27 Ada Chan <adachan@apple.com>
  12477. If it has been set to allow any HTTPS certificates for this host, set
  12478. kCFStreamSSLAllowsExpiredCertificates to true to allow expired
  12479. certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
  12480. certificate chain validation. (<rdar://problem/6382059>)
  12481. Reviewed by John Sullivan.
  12482. * platform/network/cf/ResourceHandleCFNet.cpp:
  12483. (WebCore::makeFinalRequest):
  12484. 2009-04-27 Simon Fraser <simon.fraser@apple.com>
  12485. Reviewed by Adele Peterson
  12486. <rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
  12487. Fix a 'size changed' notification thrash that caused standalone video elements
  12488. to continually resize after full page zooming, by using the movie's natual size (which is independent
  12489. of zooming), rather than its current size (which is not).
  12490. Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
  12491. disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
  12492. QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
  12493. <rdar://problem/6822344>.
  12494. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  12495. (WebCore::MediaPlayerPrivate::naturalSize):
  12496. 2009-04-27 Simon Fraser <simon.fraser@apple.com>
  12497. Reviewed by Darin Adler
  12498. <rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
  12499. load if movie had been previously viewed
  12500. Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
  12501. to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.
  12502. * html/HTMLEmbedElement.cpp:
  12503. (WebCore::HTMLEmbedElement::rendererIsNeeded):
  12504. * html/HTMLObjectElement.cpp:
  12505. (WebCore::HTMLObjectElement::rendererIsNeeded):
  12506. 2009-04-27 Sam Weinig <sam@webkit.org>
  12507. Reviewed by Geoffrey Garen.
  12508. Move more window event related code into DOMWindow.
  12509. * dom/Document.cpp:
  12510. (WebCore::Document::implicitClose):
  12511. (WebCore::Document::setWindowAttributeEventListener):
  12512. (WebCore::Document::dispatchWindowEvent):
  12513. (WebCore::Document::dispatchLoadEvent):
  12514. * dom/Document.h:
  12515. * dom/Element.cpp:
  12516. * dom/Element.h:
  12517. * dom/Node.cpp:
  12518. * dom/Node.h:
  12519. * html/HTMLBodyElement.cpp:
  12520. (WebCore::HTMLBodyElement::parseMappedAttribute):
  12521. * html/HTMLFrameSetElement.cpp:
  12522. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  12523. * loader/FrameLoader.cpp:
  12524. (WebCore::FrameLoader::stopLoading):
  12525. * page/DOMWindow.cpp:
  12526. (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
  12527. (WebCore::DOMWindow::postMessageTimerFired):
  12528. (WebCore::DOMWindow::dispatchEvent):
  12529. (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget):
  12530. (WebCore::DOMWindow::dispatchLoadEvent):
  12531. (WebCore::DOMWindow::dispatchUnloadEvent):
  12532. (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
  12533. * page/DOMWindow.h:
  12534. * page/Frame.cpp:
  12535. (WebCore::Frame::shouldClose):
  12536. * svg/SVGSVGElement.cpp:
  12537. (WebCore::SVGSVGElement::parseMappedAttribute):
  12538. 2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
  12539. Implement the editing mechanisms and add context menu items for
  12540. <rdar://problem/6724106> WebViews need to implement text checking
  12541. Reviewed by Justin Garcia.
  12542. * editing/Editor.cpp:
  12543. * editing/Editor.h:
  12544. * editing/TypingCommand.cpp:
  12545. * loader/EmptyClients.h:
  12546. * page/ContextMenuController.cpp:
  12547. * page/EditorClient.h:
  12548. * page/mac/WebCoreViewFactory.h:
  12549. * platform/ContextMenu.cpp:
  12550. * platform/ContextMenuItem.h:
  12551. * platform/LocalizedStrings.h:
  12552. * platform/mac/LocalizedStringsMac.mm:
  12553. 2009-04-27 Sam Weinig <sam@webkit.org>
  12554. Reviewed by Geoffrey Garen.
  12555. Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower
  12556. Be slightly less eager in collecting after page close/navigation by increasing
  12557. the time before collection from 0 seconds to .5 seconds.
  12558. 3% speedup on the PLT.
  12559. * bindings/js/GCController.cpp:
  12560. (WebCore::GCController::garbageCollectSoon):
  12561. 2009-04-27 David Kilzer <ddkilzer@apple.com>
  12562. Consolidate runtime application checks for Apple Mail and Safari
  12563. Reviewed by Mark Rowe and Darin Adler.
  12564. * WebCore.base.exp: Added exports.
  12565. * WebCore.xcodeproj/project.pbxproj: Added
  12566. RuntimeApplicationChecks.{h|mm} source files to the project.
  12567. * page/mac/EventHandlerMac.mm:
  12568. (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
  12569. Removed local checkedSafari and isSafari variables and switched
  12570. to use applicationIsSafari().
  12571. * platform/mac/RuntimeApplicationChecks.h: Added.
  12572. * platform/mac/RuntimeApplicationChecks.mm: Added.
  12573. (WebCore::applicationIsAppleMail): Runtime application check for
  12574. Apple Mail.
  12575. (WebCore::applicationIsSafari): Runtime application check for
  12576. Safari.
  12577. 2009-04-27 Chris Fleizach <cfleizach@apple.com>
  12578. Reviewed by Darin Adler.
  12579. Bug 25374: AX: No AXValue change sent when text is auto-inserted
  12580. https://bugs.webkit.org/show_bug.cgi?id=25374
  12581. First patch caused some regression tests to fail.
  12582. * rendering/RenderTextControl.cpp:
  12583. (WebCore::RenderTextControl::setInnerTextValue):
  12584. 2009-04-16 Xan Lopez <xlopez@igalia.com>
  12585. Reviewed by Gustavo Noronha.
  12586. https://bugs.webkit.org/show_bug.cgi?id=21546
  12587. [GTK] ATK accessibility enhancements
  12588. Based on a patch by Alp Toker.
  12589. Cover more WebCore role -> ATK role conversions.
  12590. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  12591. 2009-04-18 Xan Lopez <xlopez@igalia.com>
  12592. Reviewed by Gustavo Noronha.
  12593. https://bugs.webkit.org/show_bug.cgi?id=21546
  12594. [GTK] ATK accessibility enhancements
  12595. Do not call ATK setters in the getters, just return the
  12596. value. Among other things calling the setter will emit the notify
  12597. signal, which is wrong.
  12598. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  12599. 2009-04-16 Xan Lopez <xlopez@igalia.com>
  12600. Reviewed by Gustavo Noronha.
  12601. https://bugs.webkit.org/show_bug.cgi?id=21546
  12602. [GTK] ATK accessibility enhancements
  12603. Based on a patch by Alp Toker.
  12604. Implement AtkImage interface.
  12605. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  12606. 2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
  12607. Unreviewed debug build fix.
  12608. * platform/gtk/gtk2drawing.c:
  12609. (moz_gtk_toggle_paint):
  12610. 2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>
  12611. Build fix.
  12612. https://bugs.webkit.org/show_bug.cgi?id=25382
  12613. Remove direct reference to CallFrame.h include to pacify Win build.
  12614. * bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
  12615. * bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
  12616. 2009-04-27 Chris Fleizach <cfleizach@apple.com>
  12617. Reviewed by Beth Dakin.
  12618. Bug 25374: AX: No AXValue change sent when text is auto-inserted
  12619. https://bugs.webkit.org/show_bug.cgi?id=25374
  12620. When an input's text value is changed through the DOM, no AXValueChange notification is being sent.
  12621. * rendering/RenderTextControl.cpp:
  12622. (WebCore::RenderTextControl::setInnerTextValue):
  12623. 2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>
  12624. Reviewed by Eric Seidel.
  12625. https://bugs.webkit.org/show_bug.cgi?id=25382
  12626. Move scriptStateFromNode to ScriptState.
  12627. * bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
  12628. * bindings/js/JSDOMBinding.h: Ditto.
  12629. * bindings/js/ScriptState.cpp:
  12630. (WebCore::scriptStateFromNode): Added.
  12631. * bindings/js/ScriptState.h: Ditto.
  12632. * bindings/v8/ScriptState.cpp:
  12633. (WebCore::scriptStateFromNode): Added.
  12634. * bindings/v8/ScriptState.h: Ditto.
  12635. * dom/NodeFilter.h: Removed JSDOMBinding header include.
  12636. * dom/NodeIterator.h: Ditto.
  12637. * dom/TreeWalker.h: Ditto.
  12638. 2009-04-27 Chris Fleizach <cfleizach@apple.com>
  12639. Reviewed by Beth Dakin.
  12640. Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
  12641. https://bugs.webkit.org/show_bug.cgi?id=25428
  12642. When marking children as changed in accessibility, we cannot rely on the accessibility parent chain existing.
  12643. Instead, the render chain needs to be consulted.
  12644. * page/AccessibilityRenderObject.cpp:
  12645. (WebCore::AccessibilityRenderObject::childrenChanged):
  12646. 2009-04-27 Alexey Proskuryakov <ap@webkit.org>
  12647. Reviewed by Darin Adler.
  12648. https://bugs.webkit.org/show_bug.cgi?id=25399
  12649. <rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
  12650. beneath WebCore::Cache::evict
  12651. The crash happened because a cached resource handle was removed from a document's cached
  12652. resources map twice recursively, so a destructor was called for a value in a deleted bucket.
  12653. The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
  12654. CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
  12655. an inconsistent state.
  12656. I couldn't fully reconstruct the loading sequence to make a test.
  12657. * loader/Cache.cpp:
  12658. (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache
  12659. (it makes no sense to revalidate one that isn't).
  12660. (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource
  12661. from the cache in no way implies that documents no longer use the old version. This fixes the
  12662. crash, and also fixes many cases of resource content being unavailable in Web Inspector.
  12663. * loader/CachedResource.h:
  12664. (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache,
  12665. reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never
  12666. being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases,
  12667. switchClientsToRevalidatedResource() results in the same resource being requested again,
  12668. but we were only enforcing CachedResource invariants after calling this function.
  12669. (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
  12670. * loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed
  12671. resource is removed, not some other resource that happens to have the same URL (this used to
  12672. fail on LexisNexis search before this patch).
  12673. * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED
  12674. with notImplemented(). This method can be legally called via document.write(), and should
  12675. work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it
  12676. doesn't affect site functionality.
  12677. * loader/CachedResource.cpp:
  12678. (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate
  12679. is being revalidated - this may no longer be true, because we now reset this member in
  12680. CachedResource::setInCache().
  12681. 2009-04-27 Dan Bernstein <mitz@apple.com>
  12682. Reviewed by Sam Weinig.
  12683. - make BidiContext a RefCounted class, starting with a refcount of 1,
  12684. and share the root BidiContexts.
  12685. * platform/graphics/GraphicsContext.cpp:
  12686. (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
  12687. * platform/text/BidiContext.cpp:
  12688. (WebCore::BidiContext::create): Added. For the four "root" contexts,
  12689. returns a reference to a shared static BidiContext.
  12690. * platform/text/BidiContext.h:
  12691. (WebCore::BidiContext::BidiContext):
  12692. * platform/text/BidiResolver.h:
  12693. (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
  12694. * rendering/bidi.cpp:
  12695. (WebCore::RenderBlock::determineStartPosition): Ditto.
  12696. 2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
  12697. Rubber-stamped by Gustavo Noronha.
  12698. Build fix for r42893: change GDK_exclaim to GDK_exclam
  12699. * platform/chromium/KeyCodeConversionGtk.cpp:
  12700. (WebCore::windowsKeyCodeForKeyEvent):
  12701. * platform/gtk/KeyEventGtk.cpp:
  12702. (WebCore::windowsKeyCodeForKeyEvent):
  12703. 2009-04-27 Fumitoshi Ukai <ukai@google.com>
  12704. Reviewed by Xan Lopez.
  12705. Fix wrong key code conversion.
  12706. Missing conversion for GDK_exlaim ('!').
  12707. Parens are opposite: GDK_parenleft is open paren '('
  12708. and GDK_parenright is close paren ')'.
  12709. https://bugs.webkit.org/show_bug.cgi?id=25367
  12710. * platform/chromium/KeyCodeConversionGtk.cpp:
  12711. (WebCore::windowsKeyCodeForKeyEvent):
  12712. * platform/gtk/KeyEventGtk.cpp:
  12713. (WebCore::windowsKeyCodeForKeyEvent):
  12714. 2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
  12715. Reviewed by Gustavo Noronha.
  12716. [Gtk] gtkdrawing update
  12717. https://bugs.webkit.org/show_bug.cgi?id=25408
  12718. Update to the 25 Apr 2009 version of gtk2drawing.c and
  12719. gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)
  12720. * platform/gtk/gtk2drawing.c:
  12721. (setup_widget_prototype):
  12722. (moz_gtk_get_combo_box_entry_arrow):
  12723. (ensure_toolbar_widget):
  12724. (ensure_tree_header_cell_widget):
  12725. (moz_gtk_init):
  12726. (moz_gtk_button_get_inner_border):
  12727. (moz_gtk_toggle_paint):
  12728. (moz_gtk_caret_paint):
  12729. (moz_gtk_entry_paint):
  12730. (moz_gtk_tree_header_cell_paint):
  12731. (moz_gtk_combo_box_paint):
  12732. (moz_gtk_toolbar_separator_paint):
  12733. (moz_gtk_menu_separator_paint):
  12734. (moz_gtk_get_widget_border):
  12735. (moz_gtk_get_tab_scroll_arrow_size):
  12736. (moz_gtk_get_toolbar_separator_width):
  12737. (moz_gtk_get_menu_separator_height):
  12738. (moz_gtk_widget_paint):
  12739. (moz_gtk_shutdown):
  12740. * platform/gtk/gtkdrawing.h:
  12741. 2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>
  12742. Reviewed by Tor Arne Vestbø.
  12743. https://bugs.webkit.org/show_bug.cgi?id=18475
  12744. [Qt] Widget painting should follow the layout direction (LTR, RTL)
  12745. of the element style, not the application layout direction.
  12746. * platform/qt/RenderThemeQt.cpp:
  12747. (WebCore::RenderThemeQt::applyTheme):
  12748. 2009-04-26 Sam Weinig <sam@webkit.org>
  12749. Reviewed by Dan Bernstein.
  12750. Fix for https://bugs.webkit.org/show_bug.cgi?id=25412
  12751. The Window object should be an EventTarget
  12752. Test: fast/dom/Window/dispatchEvent.html
  12753. * bindings/js/JSEventTarget.cpp:
  12754. (WebCore::toJS): Add DOMWindow case.
  12755. (WebCore::toEventTarget): Ditto.
  12756. * dom/EventTarget.cpp:
  12757. (WebCore::EventTarget::toDOMWindow): Added.
  12758. * dom/EventTarget.h:
  12759. * page/DOMWindow.cpp:
  12760. (WebCore::DOMWindow::scriptExecutionContext): Added. Returns the document.
  12761. (WebCore::DOMWindow::dispatchEvent): Added.
  12762. * page/DOMWindow.h:
  12763. (WebCore::DOMWindow::toDOMWindow):
  12764. (WebCore::DOMWindow::refEventTarget):
  12765. (WebCore::DOMWindow::derefEventTarget):
  12766. * page/DOMWindow.idl:
  12767. 2009-04-26 Sam Weinig <sam@webkit.org>
  12768. Reviewed by Eric Seidel.
  12769. Remove scons-based build system.
  12770. * WebCore.scons: Removed.
  12771. 2009-04-26 Darin Adler <darin@apple.com>
  12772. Suggested by Darin Fisher.
  12773. Improve the fix for bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
  12774. https://bugs.webkit.org/show_bug.cgi?id=25355
  12775. rdar://problem/6823543
  12776. * loader/FrameLoader.cpp:
  12777. (WebCore::FrameLoader::loadItem): Allow shouldScroll to be true even if m_currentHistoryItem is 0.
  12778. Not sure if when this case can really arise in practice, but it's good to match the original
  12779. logic more closely.
  12780. 2009-04-25 Dirk Schulze <krit@webkit.org>
  12781. Reviewed by Oliver Hunt.
  12782. A width or height of zero for the destination or source rect of an
  12783. image causes a not invertible pattern matrix.
  12784. This crahes newer versions of Cairo and give some graphic gliches in
  12785. Canvas.
  12786. With this patch we check if there is something to draw and return if not.
  12787. * platform/graphics/cairo/ImageCairo.cpp:
  12788. (WebCore::BitmapImage::draw):
  12789. 2009-04-25 Simon Fraser <simon.fraser@apple.com>
  12790. Reviewed by Darin Adler
  12791. https://bugs.webkit.org/show_bug.cgi?id=25390
  12792. Fix point mapping and hit testing through transforms and perspective
  12793. with ENABLE_3D_RENDERING. Previously the code did the more efficient
  12794. move(), rather than getTransformFromContainer(), when the object had
  12795. no transform. However, this skipped the application of perspective
  12796. when the immediate child of the perspective element had no transform
  12797. itself.
  12798. Test: transforms/3d/point-mapping/3d-point-mapping-3.html
  12799. * rendering/RenderBox.cpp:
  12800. (WebCore::RenderBox::mapLocalToContainer):
  12801. (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  12802. * rendering/RenderLayer.cpp:
  12803. (WebCore::RenderLayer::createLocalTransformState):
  12804. Call shouldUseTransformFromContainer() to determine if we need to
  12805. go through the more expensive getTransformFromContainer() code
  12806. path.
  12807. * rendering/RenderObject.h:
  12808. * rendering/RenderObject.cpp:
  12809. (WebCore::RenderObject::shouldUseTransformFromContainer):
  12810. New method that indicates whether we need use getTransformFromContainer()
  12811. when mapping points through renderers, and hit testing.
  12812. 2009-04-25 Adele Peterson <adele@apple.com>
  12813. Reviewed by Oliver Hunt.
  12814. Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
  12815. https://bugs.webkit.org/show_bug.cgi?id=25396
  12816. Test: editing/deleting/delete-br-013.html
  12817. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
  12818. Only preserve an empty paragraph's style when moving paragraphs around if the selection is still
  12819. in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite
  12820. the previous paragraph's style during a delete of an empty paragraph.
  12821. 2009-04-25 Eric Carlson <eric.carlson@apple.com>
  12822. Reviewed by Darin Adler.
  12823. <rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
  12824. properly display non-linear media
  12825. If a media engine claims it can support the MIME type, WebCore now creates a <video>
  12826. element for document mode media files instead of an <embed> element. Because WebCore's
  12827. QuickTime backed media players do not support every kind of media the QuickTime plug-in
  12828. supports, and because it is not always possible to tell what type of media is in a file
  12829. without opening and parsing it, some types of media that used to be displayed properly
  12830. by a plug-in are no longer supported properly. To fix this, if the media engine
  12831. sees that it can not completely support a media file it now informs the media
  12832. document, which replaces the <video> element with an <embed>.
  12833. r42301 landed support for OSX. This patch modifies those changes slighly and adds support
  12834. for Windows.
  12835. * loader/MediaDocument.cpp:
  12836. (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer.
  12837. (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video>
  12838. element immediately.
  12839. (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed.
  12840. Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
  12841. * loader/MediaDocument.h:
  12842. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  12843. (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks.
  12844. (WebCore::MediaPlayerPrivate::rateChanged): Ditto.
  12845. (WebCore::MediaPlayerPrivate::timeChanged): Ditto.
  12846. (WebCore::MediaPlayerPrivate::didEnd): Ditto.
  12847. (WebCore::MediaPlayerPrivate::repaint): Ditto.
  12848. (WebCore::MediaPlayerPrivate::paint): Ditto.
  12849. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
  12850. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  12851. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks.
  12852. (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported
  12853. media type(s) or if it fails completely.
  12854. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the
  12855. media player client we won't play this movie correctly.
  12856. (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks.
  12857. (WebCore::MediaPlayerPrivate::setSize): Ditto.
  12858. (WebCore::MediaPlayerPrivate::setVisible): Ditto.
  12859. (WebCore::MediaPlayerPrivate::paint): Ditto.
  12860. (WebCore::MediaPlayerPrivate::movieEnded): Ditto.
  12861. (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto.
  12862. (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto.
  12863. (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
  12864. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  12865. * platform/graphics/win/QTMovieWin.cpp:
  12866. (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state
  12867. change callback.
  12868. (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled.
  12869. (QTMovieWin::QTMovieWin): Initialize m_disabled.
  12870. (QTMovieWin::disableUnsupportedTracks): Return total number of tracks.
  12871. (QTMovieWin::setDisabled): New, set m_disabled flag.
  12872. * platform/graphics/win/QTMovieWin.h:
  12873. 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
  12874. Reviewed by Xan Lopez.
  12875. [GTK] Error reporting
  12876. https://bugs.webkit.org/show_bug.cgi?id=18344
  12877. Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
  12878. errors and G_IO_ERROR for gio errors.
  12879. * platform/network/soup/ResourceHandleSoup.cpp:
  12880. (WebCore::finishedCallback):
  12881. (WebCore::ResourceHandle::startHttp):
  12882. (WebCore::ResourceHandle::start):
  12883. (WebCore::readCallback):
  12884. (WebCore::openCallback):
  12885. (WebCore::queryInfoCallback):
  12886. (WebCore::ResourceHandle::startGio):
  12887. 2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  12888. Reviewed by Mark Rowe.
  12889. Only set the new URL once for the request. Doing it a second time
  12890. after the call to willSendRequest was causing crashes when
  12891. redirected requests got cancelled.
  12892. * platform/network/soup/ResourceHandleSoup.cpp:
  12893. (WebCore::restartedCallback):
  12894. 2009-04-24 Kevin Ollivier <kevino@theolliviers.com>
  12895. wx build fix. Adding ScriptEventListener.cpp.
  12896. * WebCoreSources.bkl:
  12897. 2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>
  12898. Reviewed by Gustavo Noronha.
  12899. https://bugs.webkit.org/show_bug.cgi?id=17267
  12900. [GTK] Primary selection/clipboard support
  12901. Copy the link location to the primary selection as well as the
  12902. clipboard selection when using the "copy link selection" context
  12903. menu entry.
  12904. * platform/gtk/PasteboardGtk.cpp:
  12905. (WebCore::Pasteboard::writeURL):
  12906. * platform/gtk/PasteboardHelper.h:
  12907. 2009-04-24 Eric Seidel <eric@webkit.org>
  12908. Reviewed by Simon Fraser.
  12909. https://bugs.webkit.org/show_bug.cgi?id=25383
  12910. Changing SVG size via JS does not update CSS width/height
  12911. Add an ugly hack to fix CSS width/height updates from JS.
  12912. We can't easily call setAttribute when width/height changes
  12913. as that would cause infinite recursion (as we'd try to set
  12914. the animation storage from the attributes)
  12915. For now, when we get notification that JS changed width/height
  12916. we copy what parseMappedAttribute does and update the CSS values as well.
  12917. A better fix for this would be:
  12918. https://bugs.webkit.org/show_bug.cgi?id=25383
  12919. * svg/SVGSVGElement.cpp:
  12920. (WebCore::updateCSSForAttribute):
  12921. (WebCore::SVGSVGElement::svgAttributeChanged):
  12922. 2009-04-24 Kevin McCullough <kmccullough@apple.com>
  12923. Reviewed by Dan Bernstein.
  12924. We should not show the deletion UI for blockquotes in mail but they do
  12925. show now that we only check for one visible border.
  12926. * editing/DeleteButtonController.cpp:
  12927. (WebCore::isDeletableElement):
  12928. 2009-04-24 Dan Bernstein <mitz@apple.com>
  12929. - address Hyatt's review comments on the last patch
  12930. * rendering/RenderLayer.cpp:
  12931. (WebCore::performOverlapTests):
  12932. (WebCore::RenderLayer::paintLayer):
  12933. 2009-04-24 Dan Bernstein <mitz@apple.com>
  12934. Reviewed by Dave Hyatt.
  12935. - fix https://bugs.webkit.org/show_bug.cgi?id=5909
  12936. <rdar://problem/5863349> overlapping element leaves trail when
  12937. scrolling iframe
  12938. * WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
  12939. * page/FrameView.cpp:
  12940. (WebCore::FrameView::reset): Initialize m_isOverlapped.
  12941. (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped.
  12942. (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints()
  12943. so overlapping is taken into account.
  12944. (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and
  12945. enables or disables copy-on-scroll accordingly.
  12946. * page/FrameView.h:
  12947. Added setIsOverlapped() and m_isOverlapped.
  12948. * rendering/OverlapTestRequestClient.h: Added. During foreground painting,
  12949. an OverlapTestRequestClient can make a request to test if any subsequently-
  12950. painted layers overlap a rect. The test result is delivered to the
  12951. requestClient via setOverlapTestResult().
  12952. (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
  12953. * rendering/RenderLayer.cpp:
  12954. (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to
  12955. paintLayer(). When done painting, inform any remaining requestClients that
  12956. they are not overlapped.
  12957. (WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
  12958. pass it down to child and reflection layers. Inform requestClients if this
  12959. layer overlaps their requested rects.
  12960. * rendering/RenderLayer.h:
  12961. * rendering/RenderObject.h:
  12962. (WebCore::RenderObject::PaintInfo::PaintInfo): Added an
  12963. OverlapTestRequestMap member.
  12964. * rendering/RenderReplica.cpp:
  12965. (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap
  12966. to paintLayer().
  12967. * rendering/RenderWidget.cpp:
  12968. (WebCore::RenderWidget::paint): For FrameViews, request an overlap test
  12969. with the frame.
  12970. (WebCore::RenderWidget::setOverlapTestResult): Call
  12971. FrameView::setIsOverlapped() with the result of the overlap test.
  12972. * rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
  12973. 2009-04-24 David Hyatt <hyatt@apple.com>
  12974. Reviewed by Simon Fraser, Dan Bernstein.
  12975. Speed up the PLT by devirtualizing the height() function on InlineBox. virtualizing it in order to make the height() computation dynamic caused
  12976. a ~0.5% slowdown. This patch does the following to get the speed back:
  12977. (a) Devirtualizes isText and forces inline box creators to set the bit as needed. This actually resulted in simplified code, since ListMarkerBox could
  12978. then be removed.
  12979. (b) Reduces the height() call count. In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
  12980. member variable access. The call sites have been patched to cut down on extra height() calls now that it is more expensive.
  12981. (c) Devirtualize height() except on SVG boxes. For all non-SVG, the height() function on InlineBox handles the computation. For SVG boxes, a new bit has
  12982. been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.
  12983. * GNUmakefile.am:
  12984. * WebCore.pro:
  12985. * WebCore.vcproj/WebCore.vcproj:
  12986. * WebCore.xcodeproj/project.pbxproj:
  12987. * WebCoreSources.bkl:
  12988. * rendering/InlineBox.cpp:
  12989. (WebCore::InlineBox::height):
  12990. * rendering/InlineBox.h:
  12991. (WebCore::InlineBox::InlineBox):
  12992. (WebCore::InlineBox::isSVG):
  12993. (WebCore::InlineBox::setIsSVG):
  12994. (WebCore::InlineBox::isText):
  12995. (WebCore::InlineBox::setIsText):
  12996. (WebCore::InlineBox::svgBoxHeight):
  12997. * rendering/InlineFlowBox.cpp:
  12998. (WebCore::InlineFlowBox::placeBoxesVertically):
  12999. (WebCore::InlineFlowBox::paintBoxDecorations):
  13000. (WebCore::InlineFlowBox::paintMask):
  13001. * rendering/InlineFlowBox.h:
  13002. * rendering/InlineTextBox.cpp:
  13003. * rendering/InlineTextBox.h:
  13004. * rendering/ListMarkerBox.cpp: Removed.
  13005. * rendering/ListMarkerBox.h: Removed.
  13006. * rendering/RenderListMarker.cpp:
  13007. (WebCore::RenderListMarker::createInlineBox):
  13008. * rendering/RenderSVGInline.cpp:
  13009. (WebCore::RenderSVGInline::createFlowBox):
  13010. * rendering/RenderSVGInlineText.cpp:
  13011. (WebCore::RenderSVGInlineText::createTextBox):
  13012. * rendering/RenderSVGText.cpp:
  13013. (WebCore::RenderSVGText::createRootBox):
  13014. * rendering/RenderText.cpp:
  13015. (WebCore::RenderText::createInlineTextBox):
  13016. * rendering/RootInlineBox.cpp:
  13017. * rendering/RootInlineBox.h:
  13018. * rendering/SVGInlineFlowBox.h:
  13019. (WebCore::SVGInlineFlowBox::svgBoxHeight):
  13020. * rendering/SVGInlineTextBox.h:
  13021. (WebCore::SVGInlineTextBox::svgBoxHeight):
  13022. * rendering/SVGRootInlineBox.h:
  13023. (WebCore::SVGRootInlineBox::svgBoxHeight):
  13024. 2009-04-24 Dimitri Glazkov <dglazkov@chromium.org>
  13025. Reviewed by Eric Seidel.
  13026. https://bugs.webkit.org/show_bug.cgi?id=25370
  13027. Introduce ScriptEventListener to refactor away direct references to
  13028. JSLazyEventListener in WebCore code.
  13029. * GNUmakefile.am: Added ScriptEventListener to project.
  13030. * WebCore.pro: Ditto.
  13031. * WebCore.vcproj/WebCore.vcproj: Ditto.
  13032. * WebCore.xcodeproj/project.pbxproj: Ditto.
  13033. * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
  13034. * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
  13035. to ScriptEventListener.
  13036. * bindings/js/JSLazyEventListener.h: Ditto.
  13037. * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
  13038. * bindings/js/ScriptEventListener.cpp: Added.
  13039. * bindings/js/ScriptEventListener.h: Added.
  13040. * bindings/v8/ScriptEventListener.cpp: Added.
  13041. * bindings/v8/ScriptEventListener.h: Added.
  13042. * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
  13043. * html/HTMLBodyElement.cpp: Ditto.
  13044. * html/HTMLButtonElement.cpp: Ditto.
  13045. * html/HTMLElement.cpp: Ditto.
  13046. * html/HTMLFormElement.cpp: Ditto.
  13047. * html/HTMLFrameElementBase.cpp: Ditto.
  13048. * html/HTMLFrameSetElement.cpp: Ditto.
  13049. * html/HTMLImageElement.cpp: Ditto.
  13050. * html/HTMLInputElement.cpp: Ditto.
  13051. * html/HTMLObjectElement.cpp: Ditto.
  13052. * html/HTMLScriptElement.cpp: Ditto.
  13053. * html/HTMLSelectElement.cpp: Ditto.
  13054. * html/HTMLTextAreaElement.cpp: Ditto.
  13055. * svg/SVGElement.cpp: Ditto.
  13056. * svg/SVGSVGElement.cpp: Ditto.
  13057. 2009-04-24 Darin Adler <darin@apple.com>
  13058. Reviewed by Sam Weinig.
  13059. Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
  13060. https://bugs.webkit.org/show_bug.cgi?id=25355
  13061. rdar://problem/6823543
  13062. * loader/FrameLoader.cpp:
  13063. (WebCore::FrameLoader::loadItem): Added a null check.
  13064. 2009-04-24 Eric Seidel <eric@webkit.org>
  13065. Reviewed by Simon Fraser.
  13066. Fix RenderSVGImage to dump with full bounds and style information.
  13067. https://bugs.webkit.org/show_bug.cgi?id=25377
  13068. No functional changes, we're just now including more info in render tree dumps.
  13069. * rendering/RenderObject.h:
  13070. (WebCore::RenderObject::isSVGImage):
  13071. * rendering/RenderSVGImage.h:
  13072. (WebCore::RenderSVGImage::isSVGImage):
  13073. * rendering/RenderTreeAsText.cpp:
  13074. (WebCore::write):
  13075. * rendering/SVGRenderTreeAsText.cpp:
  13076. (WebCore::operator<<):
  13077. (WebCore::write):
  13078. * rendering/SVGRenderTreeAsText.h:
  13079. 2009-04-24 David Levin <levin@chromium.org>
  13080. Reviewed by NOBODY (chromium build fix).
  13081. Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).
  13082. * bindings/v8/V8AbstractEventListener.cpp:
  13083. (WebCore::V8AbstractEventListener::V8AbstractEventListener):
  13084. (WebCore::V8AbstractEventListener::invokeEventHandler):
  13085. * bindings/v8/V8AbstractEventListener.h:
  13086. * bindings/v8/V8EventListenerList.cpp:
  13087. (WebCore::V8EventListenerList::add):
  13088. (WebCore::V8EventListenerList::remove):
  13089. (WebCore::V8EventListenerList::clear):
  13090. * bindings/v8/V8LazyEventListener.h:
  13091. (WebCore::V8LazyEventListener::virtualisAttribute):
  13092. * bindings/v8/custom/V8CustomEventListener.cpp:
  13093. (WebCore::V8EventListener::V8EventListener):
  13094. * bindings/v8/custom/V8CustomEventListener.h:
  13095. (WebCore::V8EventListener::create):
  13096. (WebCore::V8EventListener::virtualisAttribute):
  13097. 2009-04-24 Nate Chapin <japhet@google.com>
  13098. Reviewed by Dimitri Glazkov.
  13099. https://bugs.webkit.org/show_bug.cgi?id=25343
  13100. Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
  13101. ignores blur.
  13102. * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
  13103. (WebCore::GraphicsContext::setPlatformShadow): Add check against
  13104. blur before clearing looper.
  13105. 2009-04-24 Eric Roman <eroman@chromium.org>
  13106. Reviewed by Darin Adler.
  13107. Initialize TextIterator::m_textLength to 0.
  13108. This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).
  13109. <https://bugs.webkit.org/show_bug.cgi?id=25335>
  13110. Test: editing/selection/doubleclick-whitespace-img-crash.html
  13111. * editing/TextIterator.cpp:
  13112. (WebCore::TextIterator::TextIterator):
  13113. 2009-04-24 Fumitoshi Ukai <ukai@google.com>
  13114. Reviewed by Dimitri Glazkov.
  13115. https://bugs.webkit.org/show_bug.cgi?id=25329
  13116. Add indexed access method in v8 binding of ClientRectList.
  13117. * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
  13118. 2009-04-24 Fumitoshi Ukai <ukai@google.com>
  13119. Reviewed by Dimitri Glazkov.
  13120. https://bugs.webkit.org/show_bug.cgi?id=25257
  13121. Use null for unspecified event listener attributes of XMLHttpRequest
  13122. and XMLHttpRequestUpload in v8 binding.
  13123. cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
  13124. An event handler attribute, unless otherwise specified, can either
  13125. have the value null or be set to a Function object.
  13126. Initially, an event handler attribute must be set to null.
  13127. Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html
  13128. * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  13129. (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
  13130. * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
  13131. (WebCore::ACCESSOR_GETTER): Ditto.
  13132. 2009-04-24 Darin Adler <darin@apple.com>
  13133. Reviewed by Adam Roben.
  13134. <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513
  13135. * bindings/js/JSDOMBinding.cpp:
  13136. (WebCore::reportException): Added a null check.
  13137. 2009-04-24 Simon Fraser <simon.fraser@apple.com>
  13138. Reviewed by Darin Adler
  13139. https://bugs.webkit.org/show_bug.cgi?id=23219
  13140. Add support for transtions and animations of background-position, -webkit-background-size,
  13141. -webkit-mask-position and -webkit-mask-size.
  13142. Tests: transitions/background-transitions.html
  13143. transitions/mask-transitions.html
  13144. * page/animation/AnimationBase.cpp:
  13145. (WebCore::blendFunc):
  13146. Add a blend func for LengthSize.
  13147. (WebCore::ensurePropertyMap):
  13148. Add wrappers for the new properties.
  13149. (WebCore::addShorthandProperties):
  13150. Add a shorthand property for CSSPropertyBackgroundPosition to map to
  13151. CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
  13152. add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
  13153. CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
  13154. CSSPropertyWebkitMaskPositionY.
  13155. * rendering/style/RenderStyle.h:
  13156. (WebCore::InheritedFlags::setBackgroundXPosition):
  13157. (WebCore::InheritedFlags::setBackgroundYPosition):
  13158. (WebCore::InheritedFlags::setBackgroundSize):
  13159. (WebCore::InheritedFlags::setMaskXPosition):
  13160. (WebCore::InheritedFlags::setMaskYPosition):
  13161. (WebCore::InheritedFlags::setMaskSize):
  13162. Add setters for the properties that can be animated now.
  13163. 2009-04-24 Adele Peterson <adele@apple.com>
  13164. Reviewed by Darin Adler.
  13165. Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
  13166. Test: editing/pasteboard/paste-blockquote-after-blockquote.html
  13167. When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
  13168. But we should only merge here if the selection start was inside a mail blockquote. This prevents against removing a
  13169. blockquote from newly pasted quoted content that was pasted into an unquoted position. If that unquoted position happens
  13170. to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.
  13171. * editing/ReplaceSelectionCommand.cpp:
  13172. (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
  13173. (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
  13174. * editing/ReplaceSelectionCommand.h:
  13175. 2009-04-23 Francisco Tolmasky <francisco@280north.com>
  13176. BUG 24604: WebKit profiler reports incorrect total times
  13177. <https://bugs.webkit.org/show_bug.cgi?id=24604>
  13178. Reviewed by Timothy Hatcher and Kevin McCullough.
  13179. Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
  13180. heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
  13181. displays flattened statistics for a particular function that ran during the profile, and each child
  13182. of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
  13183. nodes should show how much of the root nodes values came from it. For example, if you had the following to
  13184. stacks take place during the profile:
  13185. A ->calls 1 times-> B ->calls 2 times-> C
  13186. D ->calls 4 times-> C
  13187. The tree for the C root node would look like this:
  13188. C -> B -> A
  13189. -> D
  13190. The number of calls values would look like this:
  13191. C (6) -> B (2) -> A(2)
  13192. -> D (4)
  13193. What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
  13194. "4 of the total C calls came from D". Notice that the "A ->calls 2 time->" is completely ignored. This becomes
  13195. particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
  13196. is the reason that we would get things like 40000% previously with recursion.
  13197. This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
  13198. can't know exactly how many calls came from where, etc).
  13199. * English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
  13200. * inspector/JavaScriptProfile.cpp:
  13201. (WebCore::ProfileClass):
  13202. * inspector/JavaScriptProfileNode.cpp:
  13203. (WebCore::getParent):
  13204. (WebCore::getHead):
  13205. (WebCore::getCallUID):
  13206. (WebCore::ProfileNodeClass):
  13207. * inspector/front-end/BottomUpProfileDataGridTree.js: Added.
  13208. (WebInspector.BottomUpProfileDataGridTree):
  13209. (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
  13210. (WebInspector.BottomUpProfileDataGridNode):
  13211. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
  13212. (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
  13213. (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
  13214. (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
  13215. (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
  13216. * inspector/front-end/DataGrid.js:
  13217. (WebInspector.DataGrid.prototype.insertChild):
  13218. (WebInspector.DataGrid.prototype.removeChild):
  13219. (WebInspector.DataGrid.prototype.removeChildren):
  13220. (WebInspector.DataGridNode.prototype.set hasChildren):
  13221. (WebInspector.DataGridNode.prototype.get hasChildren):
  13222. * inspector/front-end/ProfileDataGridTree.js: Added.
  13223. (WebInspector.ProfileDataGridNode):
  13224. (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
  13225. (WebInspector.ProfileDataGridNode.prototype.get data):
  13226. (WebInspector.ProfileDataGridNode.prototype.createCell):
  13227. (WebInspector.ProfileDataGridNode.prototype.select):
  13228. (WebInspector.ProfileDataGridNode.prototype.deselect):
  13229. (WebInspector.ProfileDataGridNode.prototype.expand):
  13230. (WebInspector.ProfileDataGridNode.prototype.insertChild):
  13231. (WebInspector.ProfileDataGridNode.prototype.removeChild):
  13232. (WebInspector.ProfileDataGridNode.prototype.removeChildren):
  13233. (WebInspector.ProfileDataGridNode.prototype.findChild):
  13234. (WebInspector.ProfileDataGridNode.prototype.get averageTime):
  13235. (WebInspector.ProfileDataGridNode.prototype.get averagePercent):
  13236. (WebInspector.ProfileDataGridNode.prototype.get selfPercent):
  13237. (WebInspector.ProfileDataGridNode.prototype.get totalPercent):
  13238. (WebInspector.ProfileDataGridNode.prototype._save):
  13239. (WebInspector.ProfileDataGridNode.prototype._restore):
  13240. (WebInspector.ProfileDataGridNode.prototype._merge):
  13241. (WebInspector.ProfileDataGridTree):
  13242. (WebInspector.ProfileDataGridTree.prototype.get expanded):
  13243. (WebInspector.ProfileDataGridTree.prototype.appendChild):
  13244. (WebInspector.ProfileDataGridTree.prototype.insertChild):
  13245. (WebInspector.ProfileDataGridTree.prototype.removeChildren):
  13246. (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save):
  13247. (WebInspector.ProfileDataGridTree.propertyComparator.comparator):
  13248. (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator):
  13249. (WebInspector.ProfileDataGridTree.propertyComparator):
  13250. * inspector/front-end/ProfileView.js:
  13251. (WebInspector.ProfileView):
  13252. (WebInspector.ProfileView.prototype.set profile):
  13253. (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree):
  13254. (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree):
  13255. (WebInspector.ProfileView.prototype.get currentTree):
  13256. (WebInspector.ProfileView.prototype.set currentTree):
  13257. (WebInspector.ProfileView.prototype.get topDownTree):
  13258. (WebInspector.ProfileView.prototype.get bottomUpTree):
  13259. (WebInspector.ProfileView.prototype.refresh):
  13260. (WebInspector.ProfileView.prototype.refreshVisibleData):
  13261. (WebInspector.ProfileView.prototype.refreshShowAsPercents):
  13262. (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
  13263. (WebInspector.ProfileView.prototype.performSearch):
  13264. (WebInspector.ProfileView.prototype._changeView):
  13265. (WebInspector.ProfileView.prototype._focusClicked):
  13266. (WebInspector.ProfileView.prototype._excludeClicked):
  13267. (WebInspector.ProfileView.prototype._resetClicked):
  13268. (WebInspector.ProfileView.prototype._sortProfile):
  13269. * inspector/front-end/ProfilesPanel.js:
  13270. (WebInspector.ProfilesPanel.prototype.showProfile):
  13271. (WebInspector.ProfilesPanel.prototype.showView):
  13272. (WebInspector.ProfilesPanel.prototype.searchMatchFound):
  13273. * inspector/front-end/TopDownProfileDataGridTree.js: Added.
  13274. (WebInspector.TopDownProfileDataGridNode):
  13275. (WebInspector.TopDownProfileDataGridNode.prototype._populate):
  13276. (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
  13277. (WebInspector.TopDownProfileDataGridTree):
  13278. (WebInspector.TopDownProfileDataGridTree.prototype.focus):
  13279. (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
  13280. * inspector/front-end/WebKit.qrc:
  13281. * inspector/front-end/inspector.css:
  13282. * inspector/front-end/inspector.html:
  13283. 2009-04-23 Eric Seidel <eric@webkit.org>
  13284. Reviewed by Sam Weinig.
  13285. Use static functions (and a couple templates)
  13286. to further reduce the amount of copy/paste code in SVGRenderTreeAsText
  13287. No test changes, only code cleanup.
  13288. * rendering/SVGRenderTreeAsText.cpp:
  13289. (WebCore::writeNameValuePair):
  13290. (WebCore::writeNameAndQuotedValue):
  13291. (WebCore::writeIfNotEmpty):
  13292. (WebCore::writeIfNotDefault):
  13293. (WebCore::writeStyle):
  13294. (WebCore::writePositionAndStyle):
  13295. (WebCore::operator<<):
  13296. 2009-04-23 Eric Seidel <eric@webkit.org>
  13297. Reviewed by Simon Fraser.
  13298. SVGRenderTreeAsText cleanup/code sharing.
  13299. No test changes, only code cleanup.
  13300. * rendering/RenderText.cpp:
  13301. (WebCore::RenderText::firstRunOrigin):
  13302. * rendering/RenderText.h:
  13303. * rendering/SVGRenderTreeAsText.cpp:
  13304. (WebCore::writeStandardPrefix):
  13305. (WebCore::writeChildren):
  13306. (WebCore::write):
  13307. (WebCore::writeRenderResources):
  13308. 2009-04-23 Beth Dakin <bdakin@apple.com>
  13309. Reviewed by Darin Adler.
  13310. WebCore part of fix for <rdar://problem/6333461> REGRESSION
  13311. (r36864-r36869): Dragging stocks widget scrollbar drags the whole
  13312. widget
  13313. * platform/Scrollbar.h:
  13314. (WebCore::Scrollbar::isScrollbar):
  13315. * platform/Widget.h:
  13316. (WebCore::Widget::isScrollbar):
  13317. 2009-04-23 Kevin McCullough <kmccullough@apple.com>
  13318. Reviewed by Adam Roben.
  13319. <rdar://problem/6808109> "Deletion UI" is not available for many
  13320. portions of HTML content
  13321. This patch makes the deletion UI show up in some new situations:
  13322. 1) If a block's background color is different from its parent's
  13323. 2) If a block has a background image.
  13324. 3) If a block has a single visible border.
  13325. However the block must now not only be at least a minimum width and
  13326. height, but also exceed a minimum area. In practice this has led to
  13327. much better element selection.
  13328. * editing/DeleteButtonController.cpp:
  13329. (WebCore::isDeletableElement):
  13330. 2009-04-23 Kevin Ollivier <kevino@theolliviers.com>
  13331. wx build fix. Adding XMLTokenizerScope.cpp to the build.
  13332. * WebCoreSources.bkl:
  13333. 2009-04-23 Adele Peterson <adele@apple.com>
  13334. Reviewed by Darin Adler.
  13335. Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
  13336. https://bugs.webkit.org/show_bug.cgi?id=25312
  13337. I was unable to reproduce the problem, but I'm pretty sure this will fix it.
  13338. * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
  13339. Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.
  13340. 2009-04-23 Dimitri Glazkov <dglazkov@chromium.org>
  13341. Reviewed by Darin Adler.
  13342. https://bugs.webkit.org/show_bug.cgi?id=25313
  13343. Missing scroll bars in GMail.
  13344. Test: fast/overflow/overflow-y-scroll.html
  13345. * platform/ScrollView.cpp:
  13346. (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn
  13347. scroll mode.
  13348. 2009-04-23 Dan Bernstein <mitz@apple.com>
  13349. Reviewed by Justin Garcia.
  13350. - fix <rdar://problem/6081309> Mail crash when pressing down arrow in
  13351. some messages in WebCore::canHaveChildrenForEditing
  13352. Test: editing/selection/extend-by-line-anonymous-content-crash.html
  13353. * editing/visible_units.cpp:
  13354. (WebCore::previousLinePosition): Null-check node. If p is not an
  13355. editable position, then closestLeafChildForXPos() may have returned a
  13356. non-editable box, and in particular one belonging to anonymous content.
  13357. If node is 0, fall back on RenderObject::positionForPoint, which
  13358. finds the closest position in non-anonymous content.
  13359. (WebCore::nextLinePosition): Ditto.
  13360. * rendering/RenderObject.cpp:
  13361. (WebCore::RenderObject::createVisiblePosition): Fixed a typo.
  13362. 2009-04-23 Alexey Proskuryakov <ap@webkit.org>
  13363. Reviewed by Adele Peterson.
  13364. <rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
  13365. Test: http/tests/history/back-to-post.php
  13366. * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  13367. Apply a new cache policy if it changed after the platform request was first created.
  13368. While at it, also made sure to update timeout.
  13369. 2009-04-23 Zan Dobersek <zandobersek@gmail.com>
  13370. Reviewed by Gustavo Noronha.
  13371. When creating a new drawable object, collect system's
  13372. information about the best depth it can provide and use it
  13373. in a new colormap that the new drawable requires.
  13374. * platform/graphics/gtk/ImageGtk.cpp:
  13375. (WebCore::BitmapImage::getGdkPixbuf):
  13376. 2009-04-23 Zan Dobersek <zandobersek@gmail.com>
  13377. Reviewed by Gustavo Noronha.
  13378. https://bugs.webkit.org/show_bug.cgi?id=15654
  13379. GdkPixbuf support for ImageCairo
  13380. Add support for converting a Cairo surface to a GdkPixbuf.
  13381. * platform/graphics/BitmapImage.h:
  13382. * platform/graphics/Image.h:
  13383. (WebCore::Image::getGdkPixbuf):
  13384. * platform/graphics/gtk/ImageGtk.cpp:
  13385. (WebCore::BitmapImage::getGdkPixbuf):
  13386. 2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  13387. Reviewed by Simon Hausmann.
  13388. Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.
  13389. Basically, what we want is to send wheel events to the plugin *only*
  13390. when it has focus, or else send it to the parent frame.
  13391. This is a work around, and basically what we do, is to steal the
  13392. wheel events from the plugin, modify the window ID, and put the
  13393. event back into the Qt event loop.
  13394. * plugins/qt/PluginContainerQt.cpp:
  13395. (PluginClientWrapper::PluginClientWrapper):
  13396. (PluginClientWrapper::~PluginClientWrapper):
  13397. (PluginClientWrapper::x11Event):
  13398. (PluginContainerQt::PluginContainerQt):
  13399. (PluginContainerQt::~PluginContainerQt):
  13400. (PluginContainerQt::on_clientClosed):
  13401. (PluginContainerQt::on_clientIsEmbedded):
  13402. (PluginContainerQt::redirectWheelEventsToParent):
  13403. (PluginContainerQt::x11Event):
  13404. (PluginContainerQt::focusInEvent):
  13405. * plugins/qt/PluginContainerQt.h:
  13406. 2009-04-22 Brady Eidson <beidson@apple.com>
  13407. Reviewed by Maciej Stachowiak
  13408. <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
  13409. For most loads, we were consulting the navigation policy delegate twice. Once from FrameLoader before
  13410. the load started and once from MainResourceLoader in its willSendRequest callback.
  13411. In the past we tried removing MainResourceLoader's call altogether. This caused a regression where urls
  13412. that redirect to a url handled by an external application would no longer work in Safari. It probably
  13413. also broke other WebKit apps in subtle ways.
  13414. Changing MainResourceLoader to make the check only on redirects fixes both bugs. We now only call the
  13415. policy delegate once for most standard loads, but we do correctly call it a second time for redirects.
  13416. Tests: http/tests/misc/policy-delegate-called-twice.html
  13417. http/tests/misc/redirect-to-external-url.html
  13418. * loader/MainResourceLoader.cpp:
  13419. (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.
  13420. 2009-04-22 Sam Weinig <sam@webkit.org>
  13421. Reviewed by Mark Rowe.
  13422. Fix for <rdar://problem/6800695>
  13423. Add a hack to only allow navigating (via a link from a http page)
  13424. to feed: urls (same for feeds: and feedsearch:) that map to http:
  13425. or https: via their nested protocol. This includes both feed://example.com
  13426. and feed:http://example.com.
  13427. * loader/FrameLoader.cpp:
  13428. (WebCore::isFeedWithNestedProtocolInHTTPFamily):
  13429. (WebCore::FrameLoader::loadFrameRequest):
  13430. 2009-04-22 Sam Weinig <sam@webkit.org>
  13431. Reviewed by Anders Carlsson.
  13432. Autogenerate the XMLHttpRequest constructor getter/setter for the
  13433. WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
  13434. file.
  13435. * DerivedSources.make: Remove JSWorkerContextBase.lut.h
  13436. * WebCore.xcodeproj/project.pbxproj: Ditto.
  13437. * bindings/js/JSWorkerContextBase.cpp:
  13438. * bindings/js/JSWorkerContextBase.h: Remove code to support hand written
  13439. code for XMLHttpRequest constructor lookup and shadowing.
  13440. * bindings/js/JSWorkerContextCustom.cpp:
  13441. (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes.
  13442. (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of
  13443. cached constructor lookup.
  13444. * workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not
  13445. V8 specific.
  13446. 2009-04-22 Darin Adler <darin@apple.com>
  13447. * page/Navigator.idl: Touch this file to fix build since Geolocation
  13448. configuration was recently turned off.
  13449. 2009-04-22 Justin Garcia <justin.garcia@apple.com>
  13450. Reviewed by Darin Adler.
  13451. https://bugs.webkit.org/show_bug.cgi?id=25322
  13452. Can't delete empty paragraph after a block image
  13453. Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
  13454. because of some code that avoided problems that would arise from Positions that would go
  13455. bad during deletion.
  13456. We have several checks that prevent us from using bad Positions, this one in particular
  13457. was added to avoid bad Positions that result from text removal. So, I removed the check
  13458. and started correctly updating m_downstreamEnd during text removal so that it doesn't go
  13459. bad. m_upstreamStart doesn't need to be updated during text removal, since only text
  13460. after it will ever be removed.
  13461. * editing/DeleteSelectionCommand.cpp:
  13462. (WebCore::DeleteSelectionCommand::deleteTextFromNode):
  13463. (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  13464. (WebCore::DeleteSelectionCommand::mergeParagraphs):
  13465. 2009-04-22 Oliver Hunt <oliver@apple.com>
  13466. Reviewed by Darin Adler.
  13467. <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
  13468. Make mouseUp target the correct frame when the original
  13469. mousedown made the drag non-capturing.
  13470. * page/mac/EventHandlerMac.mm:
  13471. (WebCore::EventHandler::passSubframeEventToSubframe):
  13472. 2009-04-22 Oliver Hunt <oliver@apple.com>
  13473. Reviewed by Darin Adler.
  13474. <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
  13475. This is the first step of allowing drag events to match the behaviour
  13476. of mouse move events when the default action of the initial mouse down
  13477. is prevented. Remaining issue is that the final mouse up event still
  13478. targets the original root frame.
  13479. Test: fast/events/mouse-drag-from-frame-to-other-frame.html
  13480. * page/mac/EventHandlerMac.mm:
  13481. (WebCore::EventHandler::passSubframeEventToSubframe):
  13482. 2009-04-22 Simon Fraser <simon.fraser@apple.com>
  13483. Reviewed by Adele Peterson
  13484. <rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
  13485. <rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting
  13486. When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
  13487. layer backing under some circumstances. However, drawing the view via
  13488. displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
  13489. So when in the media document, we draw via displayRectIgnoringOpacity:.
  13490. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  13491. (WebCore::MediaPlayerPrivate::paint):
  13492. 2009-04-22 Timothy Hatcher <timothy@apple.com>
  13493. Fix a crash in Mail when forwarding a specific HTML email.
  13494. Caused by the fix for <rdar://problem/6512520> (r42096).
  13495. Unable to create a test case that works outside of Mail.
  13496. <rdar://problem/6796069>
  13497. Reviewed by Ada Chan.
  13498. * editing/markup.cpp:
  13499. (WebCore::createMarkup): Null check pastEnd before trying to
  13500. call Range::compareBoundaryPoints.
  13501. 2009-04-22 Sam Weinig <sam@webkit.org>
  13502. Rubber-stamped by Darin Adler.
  13503. Fix for <rdar://problem/6816957>
  13504. Turn off Geolocation by default
  13505. * Configurations/FeatureDefines.xcconfig:
  13506. 2009-04-22 Eric Seidel <eric@webkit.org>
  13507. Rubber-stamped by David Hyatt.
  13508. Change RenderSVGImage to dump as RenderSVGImage instead of RenderImage
  13509. * rendering/RenderSVGImage.h:
  13510. (WebCore::RenderSVGImage::renderName):
  13511. 2009-04-21 Timothy Hatcher <timothy@apple.com>
  13512. Fix a crash on Gmail when they remove a "before unload" event listener when
  13513. it was never added to the pending map in the first place.
  13514. <rdar://problem/6814144>
  13515. Reviewed by Darin Adler.
  13516. * page/DOMWindow.cpp:
  13517. (WebCore::allowsPendingBeforeUnloadListeners): Renamed from shouldAddPendingBeforeUnloadListener.
  13518. (WebCore::DOMWindow::addEventListener): Call allowsPendingBeforeUnloadListeners now.
  13519. (WebCore::DOMWindow::removeEventListener): Call allowsPendingBeforeUnloadListeners before
  13520. removing the before unload listener.
  13521. (WebCore::DOMWindow::clearAttributeEventListener): Ditto.
  13522. 2009-04-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
  13523. Reviewed by Ariya Hidayat.
  13524. Made windowed plugins move/resize synchronized with the painting, so
  13525. that windowed plugins are not moved before the rest of the parent
  13526. frame during scrolling.
  13527. * plugins/qt/PluginContainerQt.cpp:
  13528. (PluginContainerQt::PluginContainerQt):
  13529. (PluginContainerQt::requestGeometry):
  13530. (PluginContainerQt::adjustGeometry):
  13531. * plugins/qt/PluginContainerQt.h:
  13532. * plugins/qt/PluginViewQt.cpp:
  13533. (WebCore::PluginView::updatePluginWidget):
  13534. (WebCore::PluginView::paint):
  13535. 2009-04-22 Simon Hausmann <simon.hausmann@nokia.com>
  13536. Reviewed by Ariya Hidayat.
  13537. Fix various bugs in the X11 Qt plugin focus handling.
  13538. Notify the focus controller on activation/deactivation of the plugin and
  13539. set focus on the plugin's element when it receives the window system
  13540. focus.
  13541. * WebCore.pro: Added PluginContainerQt to the Qt build.
  13542. * plugins/PluginView.cpp:
  13543. (WebCore::PluginView::focusPluginElement): New helper function, moved from PluginViewWin.
  13544. * plugins/PluginView.h:
  13545. (WebCore::PluginView::parentFrame): Added parent frame accessor.
  13546. * plugins/qt/PluginContainerQt.cpp: Added.
  13547. (PluginContainerQt::PluginContainerQt):
  13548. (PluginContainerQt::focusInEvent): Set the focus controller active on focus in events.
  13549. (PluginContainerQt::focusOutEvent): Deactivate the focus controller when loosing the focus.
  13550. * plugins/qt/PluginContainerQt.h: Added.
  13551. * plugins/qt/PluginViewQt.cpp:
  13552. (WebCore::PluginView::init): Allocate a PluginContainerQt instead of QX11EmbedContainer.
  13553. * plugins/win/PluginViewWin.cpp:
  13554. (WebCore::PluginView::handleMouseEvent): Moved the code to set focus on the plugin element
  13555. to PluginView::focusPluginElement.
  13556. 2009-04-22 Tamas Szirbucz <szirbucz.tamas@stud.u-szeged.hu>
  13557. Reviewed by Ariya Hidayat.
  13558. https://bugs.webkit.org/show_bug.cgi?id=25023
  13559. Delete reply in QNetworkReplyHandler::abort() to avoid leak.
  13560. * platform/network/qt/QNetworkReplyHandler.cpp:
  13561. (WebCore::QNetworkReplyHandler::abort):
  13562. 2009-04-21 Jon Honeycutt <jhoneycutt@apple.com>
  13563. Allow the UI delegate to control cursor-setting.
  13564. Reviewed by Ada Chan.
  13565. * page/Chrome.cpp:
  13566. (WebCore::Chrome::setCursor):
  13567. Pass the call to the client.
  13568. * page/Chrome.h:
  13569. * page/ChromeClient.h:
  13570. (WebCore::ChromeClient::setCursor):
  13571. Stubbed; returns false.
  13572. * platform/Cursor.h:
  13573. Define PlatformCursorHandle for each platform.
  13574. * platform/win/WidgetWin.cpp:
  13575. Reordered some includes. Added an include of Page.h.
  13576. (WebCore::Widget::setCursor):
  13577. Fixed a typo in the comment about ignoreNextSetCursor. Get the Page, and
  13578. call its Chrome's setCursor() method with the passed cursor. Fall back
  13579. to SetCursor() if the Page is not available.
  13580. * plugins/win/PluginViewWin.cpp:
  13581. (WebCore::PluginView::handleMouseEvent):
  13582. Remove an unused variable. Cleaned up some whitespace.
  13583. 2009-04-21 John Abd-El-Malek <jam@google.com>
  13584. Reviewed by Dimitri Glazkov.
  13585. Add a method to purge the Chromium plugin list cache.
  13586. https://bugs.webkit.org/show_bug.cgi?id=25318
  13587. * plugins/chromium/PluginDataChromium.cpp:
  13588. (WebCore::resetChromiumPluginCache):
  13589. 2009-04-21 Mark Rowe <mrowe@apple.com>
  13590. Reviewed by Darin Adler.
  13591. Fix <https://bugs.webkit.org/show_bug.cgi?id=25164> / <rdar://problem/6786319>.
  13592. We need to ensure that XMLTokenizer sets the current DocLoader before calling in to
  13593. any libxml2 methods that may trigger a load. The presence of a DocLoader indicates
  13594. that the load was originated by WebCore's use of libxml2 and that we should enforce
  13595. the same-origin policy on it. XMLTokenizer::initializeParserContext,
  13596. XMLTokenizer::doWrite and XMLTokenizer::doEnd were three methods that were not setting
  13597. the current DocLoader when they should have.
  13598. The XMLTokenizerScope class is introduced to simplify the pattern of saving, setting and
  13599. restoring the current DocLoader and libxml2 error handlers. The DocLoader and error handlers
  13600. are saved and set when the scope is allocated, and restored to their previous values when
  13601. the scope is exited.
  13602. Test: http/tests/security/xss-DENIED-xml-external-entity.xhtml
  13603. * GNUmakefile.am:
  13604. * WebCore.pro:
  13605. * WebCore.scons:
  13606. * WebCore.vcproj/WebCore.vcproj:
  13607. * WebCore.xcodeproj/project.pbxproj:
  13608. * dom/XMLTokenizer.cpp:
  13609. * dom/XMLTokenizer.h:
  13610. * dom/XMLTokenizerLibxml2.cpp:
  13611. (WebCore::matchFunc):
  13612. (WebCore::shouldAllowExternalLoad):
  13613. (WebCore::openFunc):
  13614. (WebCore::XMLTokenizer::doWrite):
  13615. (WebCore::XMLTokenizer::initializeParserContext):
  13616. (WebCore::XMLTokenizer::doEnd):
  13617. (WebCore::xmlDocPtrForString):
  13618. * dom/XMLTokenizerScope.cpp:
  13619. (WebCore::XMLTokenizerScope::XMLTokenizerScope):
  13620. (WebCore::XMLTokenizerScope::~XMLTokenizerScope):
  13621. * dom/XMLTokenizerScope.h:
  13622. * xml/XSLStyleSheet.cpp:
  13623. (WebCore::XSLStyleSheet::parseString):
  13624. * xml/XSLTProcessor.cpp:
  13625. 2009-04-21 Sam Weinig <sam@webkit.org>
  13626. Reviewed by Dan Bernstein.
  13627. Fix for <rdar://problem/5874009>
  13628. Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
  13629. * platform/network/ResourceHandle.cpp:
  13630. (WebCore::portAllowed):
  13631. 2009-04-21 Justin Garcia <justin.garcia@apple.com>
  13632. Reviewed by Dan Bernstein.
  13633. https://bugs.webkit.org/show_bug.cgi?id=25320
  13634. Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)
  13635. * editing/CompositeEditCommand.cpp:
  13636. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If the enclosing block is the
  13637. root editable element and it contains no visible content, create a new block but don't try and move
  13638. content into it, since there's nothing for moveParagraphs to move.
  13639. 2009-04-21 Darin Adler <darin@apple.com>
  13640. Reviewed by Dan Bernstein.
  13641. Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
  13642. https://bugs.webkit.org/show_bug.cgi?id=25162
  13643. rdar://problem/6764354
  13644. * page/Settings.cpp:
  13645. (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC).
  13646. Later we may want to change this default to encompass other versions running on Mac.
  13647. * page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and
  13648. m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all
  13649. the bit fields.
  13650. * platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint.
  13651. I'm not sure the distinction here is serving us well at the moment. When converting from
  13652. global to local coordinates you want to do IntPoint - IntPoint and have the result be
  13653. another IntPoint, not an IntSize. And so on.
  13654. * rendering/RenderBlock.cpp:
  13655. (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and
  13656. separate coordinates less.
  13657. (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function.
  13658. Added separate cases to support the Mac and Windows behavior.
  13659. (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the
  13660. computation of pointInContents closer to the place it's used.
  13661. * rendering/RenderBlock.h: Updated for the new private member function.
  13662. 2009-04-17 Timothy Hatcher <timothy@apple.com>
  13663. Change pending unload and beforeunload counts to store the listeners
  13664. in a single data structure that can be quickly iterated for dispatch.
  13665. <rdar://problem/6383352&6383379&6383940>
  13666. Reviewed by Darin Adler.
  13667. * WebCore.base.exp: Change what symbols are exported.
  13668. * loader/FrameLoader.cpp:
  13669. (WebCore::FrameLoader::stopLoading): Remove count updating code
  13670. and move an if inside a block already checking m_frame->document().
  13671. * page/Chrome.cpp: Remove disableSuddenTermination/enableSuddenTermination.
  13672. * page/Chrome.h: Ditto.
  13673. * page/ChromeClient.h: Ditto.
  13674. * page/DOMWindow.cpp:
  13675. (WebCore::pendingUnloadEventListenerMap): Create a static map.
  13676. (WebCore::pendingBeforeUnloadEventListenerMap): Ditto.
  13677. (WebCore::addPendingEventListener): Add the event listener to the map.
  13678. (WebCore::removePendingEventListener): Remove the event listener from the map.
  13679. (WebCore::removePendingEventListeners): Remove all listeners for the window.
  13680. (WebCore::dispatchWindowEventToListeners): Dispatch the event to the given listeners.
  13681. (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Send the beforeunload event.
  13682. (WebCore::DOMWindow::pendingUnloadEventListeners): Return a count of pending listeners.
  13683. (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Send the unload event.
  13684. (WebCore::DOMWindow::~DOMWindow): Remove the window from both event listener maps.
  13685. (WebCore::DOMWindow::addEventListener): Call addPendingEventListener when needed.
  13686. (WebCore::DOMWindow::removeEventListener): Call removePendingEventListener when needed.
  13687. (WebCore::DOMWindow::removeAllEventListeners): Call removePendingEventListeners.
  13688. (WebCore::DOMWindow::removeInlineEventListenerForType): Call removePendingEventListener when needed.
  13689. * page/DOMWindow.h:
  13690. (WebCore::DOMWindow::frame): Changed to be const.
  13691. * page/EventHandler.cpp:
  13692. (WebCore::EventHandler::EventHandler): Remove count tracking code.
  13693. * page/EventHandler.h: Ditto.
  13694. * page/Page.cpp:
  13695. (WebCore::Page::Page): Ditto.
  13696. * page/Page.h: Ditto.
  13697. 2009-04-21 Justin Garcia <justin.garcia@apple.com>
  13698. Reviewed by Darin Adler.
  13699. https://bugs.webkit.org/show_bug.cgi?id=19644
  13700. Text copied with Select All pastes with a indent but shouldn't
  13701. <rdar://problem/6102483>
  13702. Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
  13703. To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
  13704. a div that held properties and attributes from the fully selected body. To fix the above issues,
  13705. only do this if if the body has certain properties or attributes. We'll begin adding to this list as
  13706. necessary. For now it's just background colors and images. Tested copy/paste of nytimes, wired,
  13707. arstechnica, and several others.
  13708. Massive nesting can still happen, it will just be much less common.
  13709. * editing/markup.cpp:
  13710. (WebCore::createMarkup):
  13711. 2009-04-21 Peter Kasting <pkasting@google.com>
  13712. Reviewed by David Hyatt.
  13713. https://bugs.webkit.org/show_bug.cgi?id=25250
  13714. Allow platforms to snap the scroll thumb back to the drag origin
  13715. during a drag. Implement functions for Safari/Win and Chromium/Win
  13716. to do this snapping at distances approximating the native ones.
  13717. * platform/Scrollbar.cpp:
  13718. (WebCore::Scrollbar::Scrollbar):
  13719. (WebCore::Scrollbar::setValue):
  13720. (WebCore::Scrollbar::scroll):
  13721. (WebCore::Scrollbar::moveThumb):
  13722. (WebCore::Scrollbar::setCurrentPos):
  13723. (WebCore::Scrollbar::mouseMoved):
  13724. (WebCore::Scrollbar::mouseDown):
  13725. * platform/Scrollbar.h:
  13726. * platform/ScrollbarTheme.h:
  13727. (WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
  13728. * platform/chromium/ScrollbarThemeChromium.h:
  13729. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  13730. (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
  13731. * platform/chromium/ScrollbarThemeChromiumWin.cpp:
  13732. (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
  13733. * platform/win/ScrollbarThemeWin.cpp:
  13734. (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
  13735. (WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
  13736. * platform/win/ScrollbarThemeWin.h:
  13737. 2009-04-21 Adam Roben <aroben@apple.com>
  13738. Windows build fix
  13739. * bindings/js/JSLazyEventListener.cpp:
  13740. (WebCore::eventParameterName): Remove unreachable code when SVG is
  13741. enabled.
  13742. 2009-04-21 Kevin Ollivier <kevino@theolliviers.com>
  13743. !ENABLE(SVG) build fix.
  13744. * bindings/js/JSLazyEventListener.cpp:
  13745. (WebCore::eventParameterName):
  13746. 2009-04-21 Dave Moore <davemoore@google.com>
  13747. Reviewed by Dimitri Glazkov.
  13748. https://bugs.webkit.org/show_bug.cgi?id=25309
  13749. Better use AtomicStrings when calling from the V8
  13750. bindings into WebCore code.
  13751. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  13752. * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  13753. * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  13754. * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  13755. 2009-04-21 Chris Fleizach <cfleizach@apple.com>
  13756. Reviewed by Darin Adler.
  13757. Bug 25304: AX: Safari not identifying a secure text field
  13758. https://bugs.webkit.org/show_bug.cgi?id=25304
  13759. Secure text fields need to be able to return AXTitleUIElements.
  13760. Test: accessibility/secure-textfield-title-ui.html
  13761. * page/mac/AccessibilityObjectWrapper.mm:
  13762. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  13763. 2009-04-21 Dan Bernstein <mitz@apple.com>
  13764. - fix the Tiger build
  13765. * page/mac/EventHandlerMac.mm:
  13766. (method_setImplementation):
  13767. 2009-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  13768. Reviewed by Sam Weinig.
  13769. https://bugs.webkit.org/show_bug.cgi?id=25271
  13770. Fix the build with disabled DOM storage or disabled database support.
  13771. * bindings/js/ScriptObjectQuarantine.cpp:
  13772. * bindings/js/ScriptObjectQuarantine.h:
  13773. 2009-04-21 Holger Hans Peter Freyther <zecke@selfish.org>
  13774. Unreviewed build fix.
  13775. Compile fix for r42633. const qualifier does not work
  13776. on a static method.
  13777. * dom/Document.h:
  13778. (WebCore::Document::isSVGDocument):
  13779. 2009-04-21 Dan Bernstein <mitz@apple.com>
  13780. Reviewed by Darin Adler and John Sullivan.
  13781. - fix <rdar://problem/5914146> Crash at -[NSScrollView scrollWheel:]
  13782. -[NSScrollView scrollWheel:] runs a nested event-tracking run loop
  13783. in a mode that allows WebCore timers to fire and NSURLConnection
  13784. callbacks to be dispatched, which can release the NSScrollView and
  13785. cause it to be deallocated (one example is a DOM timer callback that
  13786. removes a subframe from the document). This leads to a crash in
  13787. -scrollView:.
  13788. The fix is to replace the implementation of -[NSScrollView scrollWheel:]
  13789. with one that optionally retains the receiver for the duration of the
  13790. call.
  13791. * page/mac/EventHandlerMac.mm:
  13792. (WebCore::nsScrollViewScrollWheelShouldRetainSelf): Added.
  13793. (WebCore::setNSScrollViewScrollWheelShouldRetainSelf): Added. Replaces
  13794. the implementation of -[NSScrollView scrollWheel:] with the
  13795. self-retaining one, and sets a static boolean that tells it whether to
  13796. retain the receiver around the call to the original implementation.
  13797. (WebCore::selfRetainingNSScrollViewScrollWheel): Added. If
  13798. setNSScrollViewScrollWheelShouldRetainSelf(true) was called and this
  13799. function is executing on the main thread, it retains the NSScrollView,
  13800. invokes the original -[NSScrollView scrollWheel:], then releases the
  13801. view. Otherwise it just calls through to the original implementation.
  13802. (WebCore::EventHandler::passWheelEventToWidget): Added calls to
  13803. setNSScrollViewScrollWheelShouldRetainSelf() around the call to
  13804. -scrollWheel:.
  13805. 2009-04-21 Geoffrey Garen <ggaren@apple.com>
  13806. Reviewed by Mark Rowe.
  13807. Tiger crash fix: Put VM tags in their own header file, and fixed up the
  13808. #ifdefs so they're not used on Tiger.
  13809. * ForwardingHeaders/wtf/VMTags.h: Copied from WebCore/ForwardingHeaders/wtf/HashTraits.h.
  13810. 2009-04-21 Xan Lopez <xlopez@igalia.com>
  13811. Reviewed by Gustavo Noronha.
  13812. https://bugs.webkit.org/show_bug.cgi?id=21546
  13813. [GTK] ATK accessibility enhancements
  13814. Based on a patch by Alp Toker.
  13815. Implement AtkComponent interface.
  13816. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  13817. (core):
  13818. 2009-04-21 Xan Lopez <xlopez@igalia.com>
  13819. Reviewed by Gustavo Noronha.
  13820. https://bugs.webkit.org/show_bug.cgi?id=21546
  13821. [GTK] ATK accessibility enhancements
  13822. Only implement AtkAction interface if we actually have an action.
  13823. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  13824. 2009-04-20 Alexey Proskuryakov <ap@webkit.org>
  13825. Reviewed by Darin Adler.
  13826. https://bugs.webkit.org/show_bug.cgi?id=25290
  13827. REGRESSION(r41732): Crash when constructing XMLHttpRequest in a detached document
  13828. Test: fast/dom/xmlhttprequest-constructor-in-detached-document.html
  13829. * bindings/js/JSAudioConstructor.cpp:
  13830. (WebCore::JSAudioConstructor::JSAudioConstructor):
  13831. * bindings/js/JSAudioConstructor.h:
  13832. * bindings/js/JSDOMGlobalObject.h:
  13833. (WebCore::getDOMConstructor):
  13834. * bindings/js/JSImageConstructor.cpp:
  13835. (WebCore::JSImageConstructor::JSImageConstructor):
  13836. * bindings/js/JSImageConstructor.h:
  13837. * bindings/js/JSMessageChannelConstructor.cpp:
  13838. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  13839. * bindings/js/JSMessageChannelConstructor.h:
  13840. * bindings/js/JSOptionConstructor.cpp:
  13841. (WebCore::JSOptionConstructor::JSOptionConstructor):
  13842. * bindings/js/JSOptionConstructor.h:
  13843. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  13844. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  13845. * bindings/js/JSXMLHttpRequestConstructor.h:
  13846. Avoid accessing JSDOMGlobalObject via ScriptExecutionContext, since it may not
  13847. work during frame teardown.
  13848. 2009-04-20 Geoffrey Garen <ggaren@apple.com>
  13849. Rubber stamped by Darin Adler and Sam Weinig.
  13850. Renamed "*InlineEventListener*" => "*AttributeEventListener*", and
  13851. "isInline" => "isAttribute".
  13852. * bindings/js/JSDOMGlobalObject.cpp:
  13853. (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
  13854. * bindings/js/JSEventListener.cpp:
  13855. (WebCore::JSEventListener::JSEventListener):
  13856. (WebCore::JSEventListener::~JSEventListener):
  13857. (WebCore::JSEventListener::handleEvent):
  13858. (WebCore::JSEventListener::virtualisAttribute):
  13859. * bindings/js/JSEventListener.h:
  13860. (WebCore::JSEventListener::create):
  13861. (WebCore::JSEventListener::isAttribute):
  13862. * bindings/js/JSLazyEventListener.cpp:
  13863. (WebCore::createAttributeEventListener):
  13864. * bindings/js/JSLazyEventListener.h:
  13865. * bindings/scripts/CodeGeneratorJS.pm:
  13866. * dom/Element.cpp:
  13867. (WebCore::Element::setWindowAttributeEventListener):
  13868. * dom/Element.h:
  13869. * dom/EventListener.h:
  13870. (WebCore::EventListener::isAttribute):
  13871. (WebCore::EventListener::virtualisAttribute):
  13872. * dom/Node.cpp:
  13873. (WebCore::Node::clearAttributeEventListener):
  13874. (WebCore::Node::setAttributeEventListener):
  13875. (WebCore::Node::getAttributeEventListener):
  13876. (WebCore::Node::onabort):
  13877. (WebCore::Node::setOnabort):
  13878. (WebCore::Node::onblur):
  13879. (WebCore::Node::setOnblur):
  13880. (WebCore::Node::onchange):
  13881. (WebCore::Node::setOnchange):
  13882. (WebCore::Node::onclick):
  13883. (WebCore::Node::setOnclick):
  13884. (WebCore::Node::oncontextmenu):
  13885. (WebCore::Node::setOncontextmenu):
  13886. (WebCore::Node::ondblclick):
  13887. (WebCore::Node::setOndblclick):
  13888. (WebCore::Node::onerror):
  13889. (WebCore::Node::setOnerror):
  13890. (WebCore::Node::onfocus):
  13891. (WebCore::Node::setOnfocus):
  13892. (WebCore::Node::oninput):
  13893. (WebCore::Node::setOninput):
  13894. (WebCore::Node::onkeydown):
  13895. (WebCore::Node::setOnkeydown):
  13896. (WebCore::Node::onkeypress):
  13897. (WebCore::Node::setOnkeypress):
  13898. (WebCore::Node::onkeyup):
  13899. (WebCore::Node::setOnkeyup):
  13900. (WebCore::Node::onload):
  13901. (WebCore::Node::setOnload):
  13902. (WebCore::Node::onmousedown):
  13903. (WebCore::Node::setOnmousedown):
  13904. (WebCore::Node::onmousemove):
  13905. (WebCore::Node::setOnmousemove):
  13906. (WebCore::Node::onmouseout):
  13907. (WebCore::Node::setOnmouseout):
  13908. (WebCore::Node::onmouseover):
  13909. (WebCore::Node::setOnmouseover):
  13910. (WebCore::Node::onmouseup):
  13911. (WebCore::Node::setOnmouseup):
  13912. (WebCore::Node::onmousewheel):
  13913. (WebCore::Node::setOnmousewheel):
  13914. (WebCore::Node::onbeforecut):
  13915. (WebCore::Node::setOnbeforecut):
  13916. (WebCore::Node::oncut):
  13917. (WebCore::Node::setOncut):
  13918. (WebCore::Node::onbeforecopy):
  13919. (WebCore::Node::setOnbeforecopy):
  13920. (WebCore::Node::oncopy):
  13921. (WebCore::Node::setOncopy):
  13922. (WebCore::Node::onbeforepaste):
  13923. (WebCore::Node::setOnbeforepaste):
  13924. (WebCore::Node::onpaste):
  13925. (WebCore::Node::setOnpaste):
  13926. (WebCore::Node::ondragenter):
  13927. (WebCore::Node::setOndragenter):
  13928. (WebCore::Node::ondragover):
  13929. (WebCore::Node::setOndragover):
  13930. (WebCore::Node::ondragleave):
  13931. (WebCore::Node::setOndragleave):
  13932. (WebCore::Node::ondrop):
  13933. (WebCore::Node::setOndrop):
  13934. (WebCore::Node::ondragstart):
  13935. (WebCore::Node::setOndragstart):
  13936. (WebCore::Node::ondrag):
  13937. (WebCore::Node::setOndrag):
  13938. (WebCore::Node::ondragend):
  13939. (WebCore::Node::setOndragend):
  13940. (WebCore::Node::onreset):
  13941. (WebCore::Node::setOnreset):
  13942. (WebCore::Node::onresize):
  13943. (WebCore::Node::setOnresize):
  13944. (WebCore::Node::onscroll):
  13945. (WebCore::Node::setOnscroll):
  13946. (WebCore::Node::onsearch):
  13947. (WebCore::Node::setOnsearch):
  13948. (WebCore::Node::onselect):
  13949. (WebCore::Node::setOnselect):
  13950. (WebCore::Node::onselectstart):
  13951. (WebCore::Node::setOnselectstart):
  13952. (WebCore::Node::onsubmit):
  13953. (WebCore::Node::setOnsubmit):
  13954. (WebCore::Node::onunload):
  13955. (WebCore::Node::setOnunload):
  13956. * dom/Node.h:
  13957. * editing/ReplaceSelectionCommand.cpp:
  13958. (WebCore::ReplacementFragment::ReplacementFragment):
  13959. * html/HTMLBodyElement.cpp:
  13960. (WebCore::HTMLBodyElement::parseMappedAttribute):
  13961. * html/HTMLButtonElement.cpp:
  13962. (WebCore::HTMLButtonElement::parseMappedAttribute):
  13963. * html/HTMLElement.cpp:
  13964. (WebCore::HTMLElement::parseMappedAttribute):
  13965. * html/HTMLFormElement.cpp:
  13966. (WebCore::HTMLFormElement::parseMappedAttribute):
  13967. * html/HTMLFrameElementBase.cpp:
  13968. (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  13969. * html/HTMLFrameSetElement.cpp:
  13970. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  13971. * html/HTMLImageElement.cpp:
  13972. (WebCore::HTMLImageElement::parseMappedAttribute):
  13973. * html/HTMLInputElement.cpp:
  13974. (WebCore::HTMLInputElement::parseMappedAttribute):
  13975. * html/HTMLObjectElement.cpp:
  13976. (WebCore::HTMLObjectElement::parseMappedAttribute):
  13977. * html/HTMLScriptElement.cpp:
  13978. (WebCore::HTMLScriptElement::parseMappedAttribute):
  13979. * html/HTMLSelectElement.cpp:
  13980. (WebCore::HTMLSelectElement::parseMappedAttribute):
  13981. * html/HTMLTextAreaElement.cpp:
  13982. (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  13983. * page/AccessibilityRenderObject.cpp:
  13984. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  13985. * page/DOMWindow.cpp:
  13986. (WebCore::DOMWindow::setAttributeEventListener):
  13987. (WebCore::DOMWindow::clearAttributeEventListener):
  13988. (WebCore::DOMWindow::getAttributeEventListener):
  13989. (WebCore::DOMWindow::onabort):
  13990. (WebCore::DOMWindow::setOnabort):
  13991. (WebCore::DOMWindow::onblur):
  13992. (WebCore::DOMWindow::setOnblur):
  13993. (WebCore::DOMWindow::onchange):
  13994. (WebCore::DOMWindow::setOnchange):
  13995. (WebCore::DOMWindow::onclick):
  13996. (WebCore::DOMWindow::setOnclick):
  13997. (WebCore::DOMWindow::ondblclick):
  13998. (WebCore::DOMWindow::setOndblclick):
  13999. (WebCore::DOMWindow::onerror):
  14000. (WebCore::DOMWindow::setOnerror):
  14001. (WebCore::DOMWindow::onfocus):
  14002. (WebCore::DOMWindow::setOnfocus):
  14003. (WebCore::DOMWindow::onkeydown):
  14004. (WebCore::DOMWindow::setOnkeydown):
  14005. (WebCore::DOMWindow::onkeypress):
  14006. (WebCore::DOMWindow::setOnkeypress):
  14007. (WebCore::DOMWindow::onkeyup):
  14008. (WebCore::DOMWindow::setOnkeyup):
  14009. (WebCore::DOMWindow::onload):
  14010. (WebCore::DOMWindow::setOnload):
  14011. (WebCore::DOMWindow::onmousedown):
  14012. (WebCore::DOMWindow::setOnmousedown):
  14013. (WebCore::DOMWindow::onmousemove):
  14014. (WebCore::DOMWindow::setOnmousemove):
  14015. (WebCore::DOMWindow::onmouseout):
  14016. (WebCore::DOMWindow::setOnmouseout):
  14017. (WebCore::DOMWindow::onmouseover):
  14018. (WebCore::DOMWindow::setOnmouseover):
  14019. (WebCore::DOMWindow::onmouseup):
  14020. (WebCore::DOMWindow::setOnmouseup):
  14021. (WebCore::DOMWindow::onmousewheel):
  14022. (WebCore::DOMWindow::setOnmousewheel):
  14023. (WebCore::DOMWindow::onreset):
  14024. (WebCore::DOMWindow::setOnreset):
  14025. (WebCore::DOMWindow::onresize):
  14026. (WebCore::DOMWindow::setOnresize):
  14027. (WebCore::DOMWindow::onscroll):
  14028. (WebCore::DOMWindow::setOnscroll):
  14029. (WebCore::DOMWindow::onsearch):
  14030. (WebCore::DOMWindow::setOnsearch):
  14031. (WebCore::DOMWindow::onselect):
  14032. (WebCore::DOMWindow::setOnselect):
  14033. (WebCore::DOMWindow::onsubmit):
  14034. (WebCore::DOMWindow::setOnsubmit):
  14035. (WebCore::DOMWindow::onunload):
  14036. (WebCore::DOMWindow::setOnunload):
  14037. (WebCore::DOMWindow::onbeforeunload):
  14038. (WebCore::DOMWindow::setOnbeforeunload):
  14039. (WebCore::DOMWindow::onwebkitanimationstart):
  14040. (WebCore::DOMWindow::setOnwebkitanimationstart):
  14041. (WebCore::DOMWindow::onwebkitanimationiteration):
  14042. (WebCore::DOMWindow::setOnwebkitanimationiteration):
  14043. (WebCore::DOMWindow::onwebkitanimationend):
  14044. (WebCore::DOMWindow::setOnwebkitanimationend):
  14045. (WebCore::DOMWindow::onwebkittransitionend):
  14046. (WebCore::DOMWindow::setOnwebkittransitionend):
  14047. * page/DOMWindow.h:
  14048. * svg/SVGElement.cpp:
  14049. (WebCore::SVGElement::parseMappedAttribute):
  14050. * svg/SVGElementInstance.cpp:
  14051. (WebCore::SVGElementInstance::onabort):
  14052. (WebCore::SVGElementInstance::setOnabort):
  14053. (WebCore::SVGElementInstance::onblur):
  14054. (WebCore::SVGElementInstance::setOnblur):
  14055. (WebCore::SVGElementInstance::onchange):
  14056. (WebCore::SVGElementInstance::setOnchange):
  14057. (WebCore::SVGElementInstance::onclick):
  14058. (WebCore::SVGElementInstance::setOnclick):
  14059. (WebCore::SVGElementInstance::oncontextmenu):
  14060. (WebCore::SVGElementInstance::setOncontextmenu):
  14061. (WebCore::SVGElementInstance::ondblclick):
  14062. (WebCore::SVGElementInstance::setOndblclick):
  14063. (WebCore::SVGElementInstance::onerror):
  14064. (WebCore::SVGElementInstance::setOnerror):
  14065. (WebCore::SVGElementInstance::onfocus):
  14066. (WebCore::SVGElementInstance::setOnfocus):
  14067. (WebCore::SVGElementInstance::oninput):
  14068. (WebCore::SVGElementInstance::setOninput):
  14069. (WebCore::SVGElementInstance::onkeydown):
  14070. (WebCore::SVGElementInstance::setOnkeydown):
  14071. (WebCore::SVGElementInstance::onkeypress):
  14072. (WebCore::SVGElementInstance::setOnkeypress):
  14073. (WebCore::SVGElementInstance::onkeyup):
  14074. (WebCore::SVGElementInstance::setOnkeyup):
  14075. (WebCore::SVGElementInstance::onload):
  14076. (WebCore::SVGElementInstance::setOnload):
  14077. (WebCore::SVGElementInstance::onmousedown):
  14078. (WebCore::SVGElementInstance::setOnmousedown):
  14079. (WebCore::SVGElementInstance::onmousemove):
  14080. (WebCore::SVGElementInstance::setOnmousemove):
  14081. (WebCore::SVGElementInstance::onmouseout):
  14082. (WebCore::SVGElementInstance::setOnmouseout):
  14083. (WebCore::SVGElementInstance::onmouseover):
  14084. (WebCore::SVGElementInstance::setOnmouseover):
  14085. (WebCore::SVGElementInstance::onmouseup):
  14086. (WebCore::SVGElementInstance::setOnmouseup):
  14087. (WebCore::SVGElementInstance::onmousewheel):
  14088. (WebCore::SVGElementInstance::setOnmousewheel):
  14089. (WebCore::SVGElementInstance::onbeforecut):
  14090. (WebCore::SVGElementInstance::setOnbeforecut):
  14091. (WebCore::SVGElementInstance::oncut):
  14092. (WebCore::SVGElementInstance::setOncut):
  14093. (WebCore::SVGElementInstance::onbeforecopy):
  14094. (WebCore::SVGElementInstance::setOnbeforecopy):
  14095. (WebCore::SVGElementInstance::oncopy):
  14096. (WebCore::SVGElementInstance::setOncopy):
  14097. (WebCore::SVGElementInstance::onbeforepaste):
  14098. (WebCore::SVGElementInstance::setOnbeforepaste):
  14099. (WebCore::SVGElementInstance::onpaste):
  14100. (WebCore::SVGElementInstance::setOnpaste):
  14101. (WebCore::SVGElementInstance::ondragenter):
  14102. (WebCore::SVGElementInstance::setOndragenter):
  14103. (WebCore::SVGElementInstance::ondragover):
  14104. (WebCore::SVGElementInstance::setOndragover):
  14105. (WebCore::SVGElementInstance::ondragleave):
  14106. (WebCore::SVGElementInstance::setOndragleave):
  14107. (WebCore::SVGElementInstance::ondrop):
  14108. (WebCore::SVGElementInstance::setOndrop):
  14109. (WebCore::SVGElementInstance::ondragstart):
  14110. (WebCore::SVGElementInstance::setOndragstart):
  14111. (WebCore::SVGElementInstance::ondrag):
  14112. (WebCore::SVGElementInstance::setOndrag):
  14113. (WebCore::SVGElementInstance::ondragend):
  14114. (WebCore::SVGElementInstance::setOndragend):
  14115. (WebCore::SVGElementInstance::onreset):
  14116. (WebCore::SVGElementInstance::setOnreset):
  14117. (WebCore::SVGElementInstance::onresize):
  14118. (WebCore::SVGElementInstance::setOnresize):
  14119. (WebCore::SVGElementInstance::onscroll):
  14120. (WebCore::SVGElementInstance::setOnscroll):
  14121. (WebCore::SVGElementInstance::onsearch):
  14122. (WebCore::SVGElementInstance::setOnsearch):
  14123. (WebCore::SVGElementInstance::onselect):
  14124. (WebCore::SVGElementInstance::setOnselect):
  14125. (WebCore::SVGElementInstance::onselectstart):
  14126. (WebCore::SVGElementInstance::setOnselectstart):
  14127. (WebCore::SVGElementInstance::onsubmit):
  14128. (WebCore::SVGElementInstance::setOnsubmit):
  14129. (WebCore::SVGElementInstance::onunload):
  14130. (WebCore::SVGElementInstance::setOnunload):
  14131. * svg/SVGSVGElement.cpp:
  14132. (WebCore::SVGSVGElement::parseMappedAttribute):
  14133. 2009-04-20 Geoffrey Garen <ggaren@apple.com>
  14134. Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
  14135. Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
  14136. they broke the Tiger and Windows buildbots.
  14137. * css/html4.css:
  14138. * css/themeWin.css:
  14139. * platform/graphics/SimpleFontData.cpp:
  14140. * platform/graphics/SimpleFontData.h:
  14141. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  14142. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  14143. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  14144. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  14145. * platform/graphics/mac/SimpleFontDataMac.mm:
  14146. * platform/graphics/qt/SimpleFontDataQt.cpp:
  14147. * platform/graphics/win/SimpleFontDataCGWin.cpp:
  14148. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  14149. * platform/graphics/win/SimpleFontDataWin.cpp:
  14150. * platform/graphics/wx/SimpleFontDataWx.cpp:
  14151. * rendering/RenderTextControl.cpp:
  14152. * rendering/RenderTextControlMultiLine.cpp:
  14153. * rendering/RenderTextControlSingleLine.cpp:
  14154. 2009-04-20 Geoffrey Garen <ggaren@apple.com>
  14155. Reviewed by Adam Roben.
  14156. One last loose end, discovered using COLLECT_ON_EVERY_ALLOCATION, for
  14157. https://bugs.webkit.org/show_bug.cgi?id=21260
  14158. Unbounded memory growth when churning elements with anonymous event handler functions
  14159. * bindings/js/JSSVGElementInstanceCustom.cpp:
  14160. (WebCore::JSSVGElementInstance::mark): Don't ASSERT that an ElementInstance's
  14161. correspondingElement has a JS wrapper. If a GC falls exactly between the
  14162. allocation of the ElementInstance wrapper and the correspondingElement
  14163. wrapper, the correspondingElement won't have a wrapper at the time we
  14164. mark the ElementInstance's wrapper.
  14165. 2009-04-20 Brady Eidson <beidson@apple.com>
  14166. Rubberstamped by Mark Rowe
  14167. Clean builds are broken on case-sensitive filesystems. Let's fix, shall we?
  14168. * platform/graphics/SimpleFontData.cpp: Remove "String.h" include. Ojan probably intended to include
  14169. "PlatformString.h" which was unnecessary because it is pulled in through other headers. This wasn't a
  14170. build failure on case-insensitive file systems because those systems would find the system <string.h>, averting
  14171. the warning.
  14172. 2009-04-20 Geoffrey Garen <ggaren@apple.com>
  14173. Reviewed by Darin Adler.
  14174. Last patch for https://bugs.webkit.org/show_bug.cgi?id=21260
  14175. Unbounded memory growth when churning elements with anonymous event handler functions
  14176. Converted "lazy" event listeners to be unprotected, just like all the others.
  14177. * bindings/js/JSEventListener.cpp:
  14178. (WebCore::JSEventListener::JSEventListener):
  14179. (WebCore::JSEventListener::~JSEventListener):
  14180. (WebCore::JSEventListener::jsFunction):
  14181. (WebCore::JSEventListener::markJSFunction):
  14182. (WebCore::JSEventListener::handleEvent):
  14183. (WebCore::JSEventListener::virtualIsInline):
  14184. * bindings/js/JSEventListener.h:
  14185. (WebCore::JSEventListener::isInline): Merged JSAbstractEventListener
  14186. into JSEventListener. Now that the only difference between JSEventListener
  14187. and JSLazyEventListener is that JSLazyEventListener compiles lazily,
  14188. there's no need for an abstract base class.
  14189. * bindings/js/JSLazyEventListener.cpp: Converted JSLazyEventListener to
  14190. inherit from JSEventListener and match its un-GC-protected behavior.
  14191. (WebCore::JSLazyEventListener::JSLazyEventListener): ditto
  14192. (WebCore::JSLazyEventListener::parseCode): ditto
  14193. (WebCore::createInlineEventListener): When creating a lazy event listener,
  14194. ensure that the related node has a JS wrapper to mark the listener. Since
  14195. the parser makes these listeners, it's possible that no JS reference has
  14196. been made to the node yet.
  14197. * bindings/js/JSLazyEventListener.h: ditto
  14198. * dom/EventListener.h:
  14199. (WebCore::EventListener::clearJSFunction): Removed an usused function.
  14200. 2009-04-20 Justin Garcia <justin.garcia@apple.com>
  14201. Reviewed by Dan Bernstein.
  14202. https://bugs.webkit.org/show_bug.cgi?id=25299
  14203. Don't bound caret to root line box if it is still inside its containing block
  14204. Can't yet write tests for behavior of non-standard caret widths.
  14205. * rendering/RenderText.cpp:
  14206. (WebCore::RenderText::localCaretRect):
  14207. 2009-04-20 Steve Falkenburg <sfalken@apple.com>
  14208. Separate JavaScriptCore.dll from WebKit.dll.
  14209. Slight performance improvement or no change on benchmarks.
  14210. Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
  14211. and simplifies standalone JavaScriptCore builds.
  14212. Reviewed by Oliver Hunt.
  14213. * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
  14214. 2009-04-20 Anders Carlsson <andersca@apple.com>
  14215. Reviewed by Sam Weinig.
  14216. <rdar://problem/6722845> In the Cocoa event model, NPWindow's window field should be null
  14217. * bridge/npapi.h:
  14218. (_NPCocoaEvent::):
  14219. Add a CGContextRef member to the draw struct. Add an NPCoordinateSpace enum.
  14220. * plugins/npfunctions.h:
  14221. Add a prototype for NPN_ConvertPoint.
  14222. 2009-04-10 Ojan Vafai <ojan@chromium.org>
  14223. Reviewed by Dan Bernstein.
  14224. Make textarea and text input metrics more closely match IEs.
  14225. https://bugs.webkit.org/show_bug.cgi?id=15312
  14226. This involves:
  14227. -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
  14228. -set textarea width to cols*avgCharWidth
  14229. -Make default CSS match IEs
  14230. -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
  14231. Those values for textarea and inputs were derived by doing a ton of manual
  14232. testing of IE's width values for various textareas and fonts.
  14233. To get the average and max character width of a font, we do the following
  14234. for each platform:
  14235. -Win: TextMetrics expose avgCharWidth and maxCharWidth
  14236. -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
  14237. maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
  14238. -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
  14239. maxCharWidth = max of avgCharWidth and m_ascent
  14240. -Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
  14241. If either one is not there, then calculate the value using the Linux approach.
  14242. Linux ports could probably dig into the OS/2 table as well, but I'll leave
  14243. that up to them to implement.
  14244. Tests: fast/forms/text-control-intrinsic-widths.html
  14245. fast/forms/textarea-metrics.html
  14246. svg/custom/svg-fonts-in-text-controls.html
  14247. * css/html4.css:
  14248. * css/themeWin.css:
  14249. * platform/graphics/SimpleFontData.cpp:
  14250. (WebCore::SimpleFontData::SimpleFontData):
  14251. (WebCore::SimpleFontData::initCharWidths):
  14252. * platform/graphics/SimpleFontData.h:
  14253. (WebCore::SimpleFontData::maxCharWidth):
  14254. (WebCore::SimpleFontData::avgCharWidth):
  14255. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  14256. (WebCore::SimpleFontData::platformCharWidthInit):
  14257. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  14258. (WebCore::SimpleFontData::platformCharWidthInit):
  14259. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  14260. (WebCore::SimpleFontData::platformCharWidthInit):
  14261. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  14262. (WebCore::SimpleFontData::platformCharWidthInit):
  14263. * platform/graphics/mac/SimpleFontDataMac.mm:
  14264. (WebCore::SimpleFontData::platformCharWidthInit):
  14265. * platform/graphics/qt/SimpleFontDataQt.cpp:
  14266. (WebCore::SimpleFontData::platformCharWidthInit):
  14267. * platform/graphics/win/SimpleFontDataCGWin.cpp:
  14268. (WebCore::SimpleFontData::platformCharWidthInit):
  14269. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  14270. (WebCore::SimpleFontData::platformInit):
  14271. (WebCore::SimpleFontData::platformCharWidthInit):
  14272. * platform/graphics/win/SimpleFontDataWin.cpp:
  14273. (WebCore::SimpleFontData::initGDIFont):
  14274. * platform/graphics/wx/SimpleFontDataWx.cpp:
  14275. (WebCore::SimpleFontData::platformCharWidthInit):
  14276. * rendering/RenderTextControl.cpp:
  14277. (WebCore::RenderTextControl::calcPrefWidths):
  14278. * rendering/RenderTextControlMultiLine.cpp:
  14279. (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  14280. * rendering/RenderTextControlSingleLine.cpp:
  14281. (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  14282. 2009-04-17 Eric Seidel <eric@webkit.org>
  14283. Reviewed by Simon Fraser.
  14284. Remove m_absoluteBounds hack from SVG renderers and move outlineBoundsForRepaint into RenderSVGModelObject
  14285. https://bugs.webkit.org/show_bug.cgi?id=25276
  14286. This also exposed a buggy paint check in RenderSVGContainer::layout()
  14287. we should repaint if we are self painting OR if our kids changed, not AND.
  14288. Writing real outlineBoundsForRepaint required writing a mapLocalToContainer() function
  14289. No functional changes, thus no tests.
  14290. * rendering/RenderPath.cpp:
  14291. (WebCore::RenderPath::localToParentTransform):
  14292. (WebCore::RenderPath::layout):
  14293. * rendering/RenderPath.h:
  14294. * rendering/RenderSVGContainer.cpp:
  14295. (WebCore::RenderSVGContainer::layout):
  14296. * rendering/RenderSVGContainer.h:
  14297. * rendering/RenderSVGModelObject.cpp:
  14298. (WebCore::RenderSVGModelObject::mapLocalToContainer):
  14299. (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
  14300. * rendering/RenderSVGModelObject.h:
  14301. * rendering/RenderSVGRoot.cpp:
  14302. (WebCore::RenderSVGRoot::layout):
  14303. (WebCore::RenderSVGRoot::paint):
  14304. (WebCore::RenderSVGRoot::localToParentTransformWithoutCSSParentOffset):
  14305. (WebCore::RenderSVGRoot::localToParentTransform):
  14306. (WebCore::RenderSVGRoot::computeRectForRepaint):
  14307. * rendering/RenderSVGRoot.h:
  14308. * rendering/RenderSVGViewportContainer.cpp:
  14309. (WebCore::RenderSVGViewportContainer::layout):
  14310. 2009-04-20 Simon Fraser <simon.fraser@apple.com>
  14311. Reviewed by Eric Seidel
  14312. https://bugs.webkit.org/show_bug.cgi?id=25282
  14313. outlineBoundsForRepaint() should compute a quad relative to the
  14314. repaintContainer. This fixes the repaint issues originally fixed in
  14315. https://bugs.webkit.org/show_bug.cgi?id=12885 for elements in compositing layers.
  14316. Failure was only apparent when building with ACCELERATED_COMPOSITING enabled.
  14317. Tests: compositing/repaint/content-into-overflow.html
  14318. compositing/repaint/overflow-into-content.html
  14319. * rendering/RenderBox.cpp:
  14320. (WebCore::RenderBox::outlineBoundsForRepaint):
  14321. 2009-04-20 Sam Weinig <sam@webkit.org>
  14322. Rubber-stamped by Tim Hatcher.
  14323. Add licenses for xcconfig files.
  14324. * Configurations/Base.xcconfig:
  14325. * Configurations/DebugRelease.xcconfig:
  14326. * Configurations/FeatureDefines.xcconfig:
  14327. * Configurations/Version.xcconfig:
  14328. * Configurations/WebCore.xcconfig:
  14329. 2009-04-20 Eric Roman <eroman@chromium.org>
  14330. Reviewed by Dimitri Glazkov.
  14331. https://bugs.webkit.org/show_bug.cgi?id=25261
  14332. Implement the V8 binding for DOMWindow.event similarly to JSC, by using
  14333. the custom getter boilerplate from the IDL file.
  14334. Also, stub out DOMWindow.crypto which is defined by the idl.
  14335. * bindings/v8/V8AbstractEventListener.cpp:
  14336. (WebCore::V8AbstractEventListener::invokeEventHandler):
  14337. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  14338. (WebCore::ACCESSOR_GETTER):
  14339. 2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  14340. Reviewed by Xan Lopez.
  14341. https://bugs.webkit.org/show_bug.cgi?id=25243
  14342. Crash when data:// loads are cancelled
  14343. Properly handle cancellation of the load for data:// loads. This
  14344. fixes crashing in the followin test:
  14345. plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
  14346. * platform/network/soup/ResourceHandleSoup.cpp:
  14347. (WebCore::parseDataUrl):
  14348. 2009-04-19 Dan Bernstein <mitz@apple.com>
  14349. - maybe fix release builds
  14350. * dom/ScriptElement.cpp:
  14351. (WebCore::ScriptElementData::notifyFinished):
  14352. 2009-04-19 Dan Bernstein <mitz@apple.com>
  14353. - not fix release builds
  14354. * dom/Document.cpp:
  14355. (WebCore::Document::executeScriptSoonTimerFired):
  14356. 2009-04-19 Dan Bernstein <mitz@apple.com>
  14357. Reviewed by Mark Rowe.
  14358. - fix <rdar://problem/6734365> REGRESSION eBay "Save this search" link
  14359. does nothing the second time search results are opened
  14360. Test: fast/dom/HTMLScriptElement/nested-execution.html
  14361. Instead of executing scripts as soon as they finish loading, which may
  14362. happen synchronously during execution of another script, defer their
  14363. execution until the next run loop iteration, using a queue that is
  14364. similar to the HTML5 notion of the "list of scripts that will execute as
  14365. soon as possible", and in my testing was consistent with how Firefox
  14366. behaved.
  14367. * dom/Document.cpp:
  14368. (WebCore::Document::Document): Initialize m_executeScriptSoonTimer.
  14369. (WebCore::Document::~Document): deref() script elements in
  14370. m_scriptsToExecuteSoon.
  14371. (WebCore::Document::executeScriptSoonTimerFired): Added. Executes the
  14372. scripts in m_scriptsToExecuteSoon and deref()s them.
  14373. (WebCore::Document::executeScriptSoon): Added. Appends to
  14374. m_scriptsToExecuteSoon and ref()s the script element, which keeps the
  14375. ScriptElementData alive as well.
  14376. * dom/Document.h:
  14377. * dom/ScriptElement.cpp:
  14378. (WebCore::ScriptElementData::ScriptElementData): Initialize m_requested.
  14379. (WebCore::ScriptElementData::requestScript): Set m_requested to true, to
  14380. prevent further load requests.
  14381. (WebCore::ScriptElementData::execute): Added. Moved the code from
  14382. notifyFinished() which should not execute synchronously here, to be
  14383. called by the Document on a 0-interval timer.
  14384. (WebCore::ScriptElementData::notifyFinished): Moved the code to
  14385. dispatch events and evaluate the script, which should not execute
  14386. synchronously, out of here.
  14387. (WebCore::ScriptElementData::ignoresLoadRequest): Changed to test for
  14388. m_requested instead of m_cachedScript, because the latter is cleared
  14389. before the script is evaluated.
  14390. * dom/ScriptElement.h:
  14391. 2009-04-19 Oliver Hunt <oliver@apple.com>
  14392. Reviewed by Antti Koivisto and Darin Adler.
  14393. <rdar://problem/6127705> Excessive memory consumption on image load failure
  14394. When we fail to decode an image we clear most of the image data, but not the
  14395. input data itself, which can be backed by a CFData object that itself holds onto
  14396. a few hundred Kbs of memory. This patch merely ensures that this buffer gets
  14397. cleared.
  14398. * loader/CachedImage.cpp:
  14399. (WebCore::CachedImage::error):
  14400. 2009-04-19 Darin Adler <darin@apple.com>
  14401. Reviewed by Sam Weinig.
  14402. Add hooks so sudden termination will not cause loss of icons or local storage.
  14403. rdar://problem/5951701
  14404. * loader/icon/IconDatabase.cpp: Marked various constants static to give them
  14405. internal linkage.
  14406. (WebCore::IconDatabase::IconDatabase): Added initial value for m_syncTimer.
  14407. Removed unneeded initial value for m_defaultIconRecord. Changed assertion to
  14408. work cross-platform.
  14409. (WebCore::IconDatabase::wakeSyncThread): Added disableSuddenTermination, so
  14410. we won't terminate until the sync thread has done its thing.
  14411. (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Added disableSuddenTermination,
  14412. so we won't terminate if we have an outstanding sync timer.
  14413. (WebCore::IconDatabase::syncTimerFired): Added enableSuddenTermination, to
  14414. balance the one in scheduleOrDeferSyncTimer.
  14415. (WebCore::IconDatabase::syncThreadMainLoop): Added enableSuddenTermination, to
  14416. balance the one in wakeSyncThread.
  14417. (WebCore::IconDatabase::deleteAllPreparedStatements): Use clear() instead of set(0).
  14418. * loader/icon/IconDatabase.h: Use a Timer instead of an OwnPtr<Timer>.
  14419. * storage/LocalStorageArea.cpp:
  14420. (WebCore::LocalStorageArea::scheduleFinalSync): Added disableSuddenTermination.
  14421. (WebCore::LocalStorageArea::scheduleItemForSync): Ditto.
  14422. (WebCore::LocalStorageArea::scheduleClear): Ditto.
  14423. (WebCore::LocalStorageArea::syncTimerFired): Added a disableSuddenTermination if
  14424. we schedule a performSync callback for later and an unconditional
  14425. enableSuddenTermination to balance the ones in the schedule calls above.
  14426. (WebCore::LocalStorageArea::sync): Factored out the work of the sync function so it
  14427. can continue to use early return idiom.
  14428. (WebCore::LocalStorageArea::performSync): Added a call to enableSuddenTermination.
  14429. * storage/LocalStorageArea.h: Added declaration of the sync function.
  14430. 2009-04-19 David Kilzer <ddkilzer@apple.com>
  14431. Make FEATURE_DEFINES completely dynamic
  14432. Reviewed by Darin Adler.
  14433. Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
  14434. variables for each feature, making it possible to remove all
  14435. knowledge of FEATURE_DEFINES from build-webkit.
  14436. * Configurations/FeatureDefines.xcconfig: Extract a variable
  14437. from FEATURE_DEFINES for each feature setting.
  14438. 2009-04-18 Geoffrey Garen <ggaren@apple.com>
  14439. Reviewed by Alexey Proskuryakov.
  14440. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  14441. Unbounded memory growth when churning elements with anonymous event handler functions
  14442. Removed a little more complexity from event handler creation and destruction.
  14443. Removed the jsProtectedEventListeners, jsProtectedInlineEventListeners,
  14444. and jsInlineEventListeners maps, and all the code for managing them.
  14445. ProtectedEventListeners don't exist anymore, so they're easy to nix.
  14446. Inline EventListeners do still exist, but there's no reason to track
  14447. them in a map. The map exists to enable 'removeEventListener' to associate
  14448. a unique JSEventListener with a given JavaScript function. But the
  14449. 'removeEventListener' API only works with non-inline event listeners!
  14450. * bindings/js/JSDOMGlobalObject.cpp:
  14451. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
  14452. (WebCore::JSDOMGlobalObject::findJSEventListener):
  14453. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  14454. (WebCore::JSDOMGlobalObject::createJSInlineEventListener):
  14455. * bindings/js/JSDOMGlobalObject.h:
  14456. * bindings/js/JSEventListener.cpp:
  14457. (WebCore::JSEventListener::JSEventListener):
  14458. (WebCore::JSEventListener::clearJSFunctionInline):
  14459. * bindings/js/JSLazyEventListener.cpp:
  14460. (WebCore::JSLazyEventListener::~JSLazyEventListener):
  14461. (WebCore::JSLazyEventListener::parseCode):
  14462. * bindings/scripts/CodeGeneratorJS.pm:
  14463. 2009-04-18 Dan Bernstein <mitz@apple.com>
  14464. - try to fix the Windows build
  14465. * editing/VisiblePosition.cpp:
  14466. (WebCore::VisiblePosition::characterAfter):
  14467. 2009-04-18 Dan Bernstein <mitz@apple.com>
  14468. - revert the previous change, which was to a file that the Windows
  14469. port does not even use
  14470. * icu/unicode/utf16.h:
  14471. 2009-04-18 Dan Bernstein <mitz@apple.com>
  14472. Reviewed by Geoffrey Garen.
  14473. - try to fix the Windows build
  14474. * icu/unicode/utf16.h:
  14475. 2009-04-18 Simon Fraser <simon.fraser@apple.com>
  14476. Reviewed by Antti Koivisto.
  14477. https://bugs.webkit.org/show_bug.cgi?id=25066
  14478. When a <video> element gained a RenderLayer via opacity, reflection etc., the
  14479. layer hierarchy was not correctly updated because RenderMedia skipped a level
  14480. when asked for its children; it skipped m_controlsShadowRoot's renderer, which
  14481. actually has a layer.
  14482. Test: fast/layers/video-layer.html
  14483. * rendering/MediaControlElements.cpp:
  14484. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
  14485. Don't manually call setParent() on the renderer. It will happen later
  14486. as a result of addChild().
  14487. * rendering/RenderMedia.cpp:
  14488. (WebCore::RenderMedia::createControlsShadowRoot):
  14489. Add m_controlsShadowRoot's renderer as a child.
  14490. * rendering/RenderMedia.h:
  14491. (WebCore::RenderMedia::children):
  14492. Now maintain a RenderObjectChildList, m_children, and remove the unneeded
  14493. removeChild() method. Make the two children() methods inline.
  14494. * rendering/RenderObject.cpp:
  14495. (WebCore::RenderObject::moveLayers):
  14496. Assert if moveLayers() is called with an oldParent that is not the
  14497. layer's actual parent (which would have revealed this bug).
  14498. 2009-04-18 Geoffrey Garen <ggaren@apple.com>
  14499. Reviewed by Cameron Zwarich.
  14500. Fixed a layout test failure, caused by my last check-in
  14501. (fast/dom/script-element-gc.html).
  14502. * bindings/js/JSDOMBinding.cpp:
  14503. (WebCore::isObservableThroughDOM):
  14504. * html/HTMLScriptElement.h:
  14505. (WebCore::HTMLScriptElement::haveFiredLoadEvent): Treat script elements
  14506. just like image elements: if a script element is loading, mark its JS
  14507. wrapper, even if the element is not in the document.
  14508. 2009-04-18 Jian Li <jianli@chromium.org>
  14509. Reviewed by Dimitri Glazkov.
  14510. https://bugs.webkit.org/show_bug.cgi?id=25170
  14511. Upstream V8WorkerCustom.cpp and V8WorkerContextCustom.cpp for V8 bindings.
  14512. * bindings/v8/WorkerContextExecutionProxy.cpp:
  14513. (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
  14514. * bindings/v8/WorkerContextExecutionProxy.h:
  14515. * bindings/v8/custom/V8WorkerContextCustom.cpp: Added.
  14516. * bindings/v8/custom/V8WorkerCustom.cpp: Added.
  14517. 2009-04-18 Jian Li <jianli@chromium.org>
  14518. Reviewed by Dimitri Glazkov.
  14519. https://bugs.webkit.org/post_bug.cg://bugs.webkit.org/show_bug.cgi?id=25167
  14520. Change createHiddenXHRDependency and removeHiddenXHRDependency so that they can be used by other custom code in V8 bindings.
  14521. * bindings/v8/V8Utilities.cpp: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.cpp.
  14522. (WebCore::createHiddenDependency):
  14523. (WebCore::removeHiddenDependency):
  14524. * bindings/v8/V8Utilities.h: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.h.
  14525. * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  14526. (WebCore::ACCESSOR_SETTER):
  14527. (WebCore::CALLBACK_FUNC_DECL):
  14528. * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
  14529. (WebCore::ACCESSOR_SETTER):
  14530. (WebCore::CALLBACK_FUNC_DECL):
  14531. 2009-04-18 Drew Wilson <amw@apple.com>
  14532. <rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32
  14533. Reviewed by Dan Bernstein.
  14534. No test case since there is no change in behavior.
  14535. * editing/VisiblePosition.cpp:
  14536. (WebCore::VisiblePosition::characterAfter): Now handles surrogate
  14537. pairs correctly and returns a UChar32.
  14538. * editing/VisiblePosition.h:
  14539. (WebCore::VisiblePosition::characterBefore): Now returns a UChar32.
  14540. * editing/visible_units.cpp:
  14541. (WebCore::endOfFirstWordBoundaryContext): Renamed
  14542. firstNonComplexContextLineBreak() to this. Changed it to use the
  14543. generic requiresContextForWordBoundary() instead of
  14544. hasLineBreakingPropertyComplexContext().
  14545. (WebCore::startOfLastWordBoundaryContext): Replaces
  14546. lastNonComplexContextLineBreak(), but returns the offset of
  14547. the character after the last character that does not require
  14548. context for word breaking. Also changed to use
  14549. requiresContextForWordBoundary().
  14550. (WebCore::previousBoundary): Updated for the above changes in
  14551. names and semantics, and changed to use
  14552. requiresContextForWordBoundary().
  14553. (WebCore::nextBoundary): Ditto.
  14554. (WebCore::startWordBoundary): Ditto.
  14555. (WebCore::endWordBoundary): Ditto.
  14556. (WebCore::previousWordPositionBoundary): Ditto.
  14557. (WebCore::nextWordPositionBoundary): Ditto.
  14558. * platform/text/TextBoundaries.h:
  14559. (WebCore::requiresContextForWordBoundary): Added.
  14560. * platform/text/mac/TextBoundaries.mm:
  14561. 2009-04-18 Geoffrey Garen <ggaren@apple.com>
  14562. Reviewed by Cameron Zwarich.
  14563. Fixed <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
  14564. REGRESSION (r42569): Profiles cannot be selected in inspector profiler
  14565. EventListeners are shared; RegisteredEventListeners are not. Therefore,
  14566. when a node wrapper needs to invalidate the node's JS event listeners,
  14567. it should invalidate its RegisteredEventListeners, not its EventListeners.
  14568. Otherwise, it might invalidate an EventListener shared by another node.
  14569. * dom/RegisteredEventListener.h:
  14570. (WebCore::invalidateEventListeners): ditto
  14571. 2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
  14572. Reviewed by Mark Rowe.
  14573. <rdar://problem/6781295> video.buffered and video.seekable are not
  14574. the same. video.buffered should return only what is buffered and
  14575. not what is seekable
  14576. * WebCore.base.exp: Added wkQTMovieMaxTimeSeekable.
  14577. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  14578. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Return wkQTMovieMaxTimeSeekable.
  14579. * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeSeekable.
  14580. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  14581. 2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
  14582. Reviewed by Adele Peterson.
  14583. <rdar://problem/6747241> work around QTKit no longer reaching
  14584. QTMovieLoadStateComplete
  14585. * WebCore.base.exp: Export wkQTMovieMaxTimeLoadedChangeNotification.
  14586. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  14587. (WebCore::MediaPlayerPrivate::createQTMovie): observe QTMovieMaxTimeLoadedChangeNotification.
  14588. (WebCore::MediaPlayerPrivate::updateStates): compare duuration() with maxTimeLoaded() instead of
  14589. using QTMovieLoadStateComplete to determine if a movie are fully loaded.
  14590. * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeLoadedChangeNotification.
  14591. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  14592. 2009-04-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  14593. Reviewed by George Staikos.
  14594. Make WML work again, most regressions test were failing.
  14595. * dom/Document.cpp: Be sure to create WML elements in WML namespace. Otherwhise hasTagName() comparisions fail.
  14596. (WebCore::Document::createElement):
  14597. * wml/WMLCardElement.cpp: Add ASSERT(hasTagName(cardTag)) to catch errors like this in future.
  14598. (WebCore::WMLCardElement::WMLCardElement):
  14599. * wml/WMLTagNames.in: Wrap comment in #if 0/#endif blocks, to silence the generation script.
  14600. 2009-04-17 Justin Garcia <justin.garcia@apple.com>
  14601. Reviewed by Dan Bernstein.
  14602. https://bugs.webkit.org/show_bug.cgi?id=25277
  14603. If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box
  14604. Also added code to handle a caret wider than one pixel.
  14605. Added fast/inline/25277.html and fast/inline/25277-2.html
  14606. * rendering/RenderText.cpp:
  14607. (WebCore::RenderText::localCaretRect): Distribute a caret's width to either side of the offset,
  14608. so that a caret between two characters doesn't hang over one character more than the other.
  14609. If there is no wrapping, the caret can leave its containing block, but not its root line box.
  14610. 2009-04-17 Geoffrey Garen <ggaren@apple.com>
  14611. Reviewed by Oliver Hunt.
  14612. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  14613. Unbounded memory growth when churning elements with anonymous event handler functions
  14614. Some refactoring of "inline" event listeners.
  14615. Renames:
  14616. dispatchEventForType => dispatchEvent
  14617. setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
  14618. removeInlineEventListenerForType => clearInlineEventListener
  14619. setInlineEventListenerForType => setInlineEventListener
  14620. inlineEventListenerForType => getInlineEventListener
  14621. * bindings/js/JSLazyEventListener.cpp:
  14622. (WebCore::eventParameterName):
  14623. (WebCore::JSLazyEventListener::JSLazyEventListener):
  14624. (WebCore::createInlineEventListener):
  14625. * bindings/js/JSLazyEventListener.h: Added two helper functions for
  14626. creating "inline" event listeners. These replace Document::createEventListener,
  14627. and abstract the creation of JS event listeners for DOM attributes out
  14628. of the DOM. Removed legacy JSProtectedEventListener constructor code for
  14629. adding the event listener's function to a map, since lazy event listeners
  14630. don't have functions at construction time.
  14631. * dom/Document.cpp:
  14632. (WebCore::Document::setFocusedNode):
  14633. * dom/Document.h:
  14634. (WebCore::Document::isSVGDocument):
  14635. * dom/Element.cpp:
  14636. (WebCore::Element::setWindowInlineEventListener):
  14637. * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
  14638. mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
  14639. to Element, for simplicity.
  14640. * dom/InputElement.cpp:
  14641. (WebCore::InputElement::setValueFromRenderer):
  14642. * dom/Node.cpp:
  14643. (WebCore::Node::dispatchFocusEvent):
  14644. (WebCore::Node::dispatchBlurEvent):
  14645. (WebCore::Node::dispatchEvent):
  14646. (WebCore::Node::clearInlineEventListener):
  14647. (WebCore::Node::setInlineEventListener):
  14648. (WebCore::Node::getInlineEventListener):
  14649. (WebCore::Node::onabort):
  14650. (WebCore::Node::setOnabort):
  14651. (WebCore::Node::etc.):
  14652. * dom/Node.h: Updated for renames.
  14653. * editing/ReplaceSelectionCommand.cpp:
  14654. (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
  14655. Updated these files for renames, and to use the new createInlineEventListener
  14656. helper function:
  14657. * html/HTMLBodyElement.cpp:
  14658. (WebCore::HTMLBodyElement::parseMappedAttribute):
  14659. * html/HTMLButtonElement.cpp:
  14660. (WebCore::HTMLButtonElement::parseMappedAttribute):
  14661. * html/HTMLElement.cpp:
  14662. (WebCore::HTMLElement::parseMappedAttribute):
  14663. * html/HTMLFormControlElement.cpp:
  14664. (WebCore::HTMLFormControlElement::onChange):
  14665. * html/HTMLFormElement.cpp:
  14666. (WebCore::HTMLFormElement::prepareSubmit):
  14667. (WebCore::HTMLFormElement::reset):
  14668. (WebCore::HTMLFormElement::parseMappedAttribute):
  14669. * html/HTMLFrameElementBase.cpp:
  14670. (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  14671. * html/HTMLFrameSetElement.cpp:
  14672. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  14673. * html/HTMLImageElement.cpp:
  14674. (WebCore::HTMLImageElement::parseMappedAttribute):
  14675. * html/HTMLImageLoader.cpp:
  14676. (WebCore::HTMLImageLoader::dispatchLoadEvent):
  14677. * html/HTMLInputElement.cpp:
  14678. (WebCore::HTMLInputElement::parseMappedAttribute):
  14679. (WebCore::HTMLInputElement::onSearch):
  14680. * html/HTMLMediaElement.cpp:
  14681. (WebCore::HTMLMediaElement::loadInternal):
  14682. * html/HTMLObjectElement.cpp:
  14683. (WebCore::HTMLObjectElement::parseMappedAttribute):
  14684. * html/HTMLScriptElement.cpp:
  14685. (WebCore::HTMLScriptElement::parseMappedAttribute):
  14686. (WebCore::HTMLScriptElement::dispatchLoadEvent):
  14687. (WebCore::HTMLScriptElement::dispatchErrorEvent):
  14688. * html/HTMLSelectElement.cpp:
  14689. (WebCore::HTMLSelectElement::parseMappedAttribute):
  14690. * html/HTMLTextAreaElement.cpp:
  14691. (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  14692. * html/HTMLTokenizer.cpp:
  14693. (WebCore::HTMLTokenizer::notifyFinished):
  14694. * page/AccessibilityRenderObject.cpp:
  14695. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  14696. * page/DOMWindow.cpp:
  14697. * page/DOMWindow.h:
  14698. (WebCore::DOMWindow::eventListeners):
  14699. * page/EventHandler.cpp:
  14700. (WebCore::EventHandler::canMouseDownStartSelect):
  14701. (WebCore::EventHandler::canMouseDragExtendSelect):
  14702. (WebCore::EventHandler::sendScrollEvent):
  14703. * page/Page.cpp:
  14704. (WebCore::networkStateChanged):
  14705. * rendering/RenderListBox.cpp:
  14706. (WebCore::RenderListBox::valueChanged):
  14707. * rendering/RenderTextControl.cpp:
  14708. (WebCore::RenderTextControl::selectionChanged):
  14709. * svg/SVGElement.cpp:
  14710. (WebCore::SVGElement::parseMappedAttribute):
  14711. * svg/SVGElementInstance.cpp:
  14712. * svg/SVGImageLoader.cpp:
  14713. (WebCore::SVGImageLoader::dispatchLoadEvent):
  14714. * svg/SVGSVGElement.cpp:
  14715. (WebCore::SVGSVGElement::parseMappedAttribute):
  14716. * svg/SVGScriptElement.cpp:
  14717. (WebCore::SVGScriptElement::dispatchErrorEvent):
  14718. * wml/WMLInputElement.cpp:
  14719. (WebCore::WMLInputElement::defaultEventHandler):
  14720. 2009-04-17 David Kilzer <ddkilzer@apple.com>
  14721. Simplify FEATURE_DEFINES definition
  14722. Reviewed by Darin Adler.
  14723. This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
  14724. variables to their own FeatureDefines.xcconfig file. It also
  14725. extracts a new ENABLE_GEOLOCATION variable so that
  14726. FEATURE_DEFINES only needs to be defined once.
  14727. * Configurations/FeatureDefines.xcconfig: Added.
  14728. * Configurations/WebCore.xcconfig: Removed definition of
  14729. ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include
  14730. of FeatureDefines.xcconfig.
  14731. * WebCore.xcodeproj/project.pbxproj: Added
  14732. FeatureDefines.xcconfig file.
  14733. * bindings/scripts/CodeGeneratorObjC.pm: When creating a list of
  14734. command-line macro definitions, split on one-or-more spaces
  14735. instead of a single space since the FEATURE_DEFINES macro may
  14736. now contain more than one space between macros if some macros
  14737. aren't defined.
  14738. 2009-04-17 Brady Eidson <beidson@apple.com>
  14739. Reviewed by Mark Rowe
  14740. <rdar://problem/6786999> Tiger WebKit shouldn't try to POST on back/forward without nagging.
  14741. * platform/network/mac/ResourceHandleMac.mm:
  14742. (WebCore::ResourceHandle::willLoadFromCache):
  14743. 2009-04-17 Darin Adler <darin@apple.com>
  14744. Reviewed by Timothy Hatcher.
  14745. Added sudden termination functions that can be called without involving
  14746. the page or client.
  14747. * GNUmakefile.am: Added SuddenTermination.h.
  14748. * WebCore.vcproj/WebCore.vcproj: Ditto.
  14749. * WebCore.xcodeproj/project.pbxproj: Ditto. Also added SuddenTermination.mm.
  14750. * platform/SuddenTermination.h: Added.
  14751. * platform/mac/SuddenTermination.mm: Added.
  14752. 2009-04-17 Eric Seidel <eric@webkit.org>
  14753. Reviewed by Simon Fraser.
  14754. Move more code into RenderSVGModelObject
  14755. needsLayer() already returns false from RenderSVGModelObject
  14756. lineHeight and baselinePosition are from days of RenderPath having RenderBox parents.
  14757. I also added comments to explain how focus rings work (now that I understand)
  14758. I got rid of two more uses of m_absoluteBounds (nearly dead!)
  14759. * rendering/RenderPath.cpp:
  14760. * rendering/RenderPath.h:
  14761. * rendering/RenderSVGContainer.cpp:
  14762. (WebCore::RenderSVGContainer::paint):
  14763. (WebCore::RenderSVGContainer::addFocusRingRects):
  14764. * rendering/RenderSVGContainer.h:
  14765. * rendering/RenderSVGModelObject.cpp:
  14766. (WebCore::RenderSVGModelObject::absoluteRects):
  14767. (WebCore::RenderSVGModelObject::absoluteQuads):
  14768. * rendering/RenderSVGModelObject.h:
  14769. 2009-04-16 Peter Kasting <pkasting@google.com>
  14770. Reviewed by Adele Peterson.
  14771. https://bugs.webkit.org/show_bug.cgi?id=25238
  14772. Invalidate the hovered scrollbar part when resetting the pressed part,
  14773. since once there is no pressed part we can draw a hovered state.
  14774. * platform/Scrollbar.cpp:
  14775. (WebCore::Scrollbar::setHoveredPart):
  14776. (WebCore::Scrollbar::setPressedPart):
  14777. 2009-04-16 Darin Fisher <darin@chromium.org>
  14778. Reviewed by Darin Adler.
  14779. https://bugs.webkit.org/show_bug.cgi?id=25223
  14780. REGRESSION: Back button after form submission to the same URL fails to navigate.
  14781. Test: http/tests/navigation/post-goback-same-url.html
  14782. * loader/FrameLoader.cpp:
  14783. (WebCore::FrameLoader::loadItem): Check if the page we are leaving has
  14784. FormData.
  14785. 2009-04-17 Nikolas Zimmermann <nikolas.zimmerman@torchmobile.com>
  14786. Not reviewed. Fix WML enabled builds.
  14787. * rendering/RenderTableRow.cpp: Remove dead code, which is no longer necessary.
  14788. (WebCore::RenderTableRow::addChild):
  14789. * wml/WMLInputElement.cpp: Apply same fix HTMLInputElement received. Covert RenderObject's to RenderTextControl where needed.
  14790. (WebCore::WMLInputElement::defaultEventHandler):
  14791. 2009-04-17 Pierre d'Herbemont <pdherbemont@apple.com>
  14792. Reviewed by Simon Fraser.
  14793. https://bugs.webkit.org/show_bug.cgi?id=24849
  14794. Add support for the media element 'played' attribute.
  14795. This involves support of "normalized TimeRanges" as described by
  14796. the spec.
  14797. Test: media/video-played.html
  14798. * html/HTMLMediaElement.cpp:
  14799. (WebCore::HTMLMediaElement::HTMLMediaElement): Renamed
  14800. m_currentTimeDuringSeek->m_lastSeekTime. Added m_playing and m_playedTimeRanges.
  14801. (WebCore::HTMLMediaElement::loadInternal): Reset m_playing, m_lastSeekTime, and
  14802. m_playedTimeRanges
  14803. (WebCore::HTMLMediaElement::seek): Set current time to m_playedTimeRanges
  14804. (WebCore::HTMLMediaElement::currentTime): m_currentTimeDuringSeek -> m_lastSeekTime
  14805. (WebCore::HTMLMediaElement::played): Returns m_playedTimeRanges.
  14806. (WebCore::HTMLMediaElement::updatePlayState): Add the new played time ranges when pausing.
  14807. Set the m_playing flag.
  14808. * html/HTMLMediaElement.h:
  14809. * html/TimeRanges.cpp:
  14810. (TimeRanges::add): Merge range(s) if overlap.
  14811. * html/TimeRanges.h: Add various helpers (below).
  14812. (WebCore::TimeRanges::Range::isPointInRange): Added.
  14813. (WebCore::TimeRanges::Range::isOverlappingRange): Ditto.
  14814. (WebCore::TimeRanges::Range::unionWithOverlappingRange): Ditto.
  14815. (WebCore::TimeRanges::Range::isBeforeRange): Ditto.
  14816. 2009-04-17 Darin Adler <darin@apple.com>
  14817. Reviewed by Antti Koivisto.
  14818. Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
  14819. https://bugs.webkit.org/show_bug.cgi?id=25210
  14820. * WebCore.base.exp: Export the core and kit function overloads that are used
  14821. in WebKit. Also resorted this file.
  14822. * WebCore.xcodeproj/project.pbxproj: Re-added DOMHTMLCanvasElement.h to fix
  14823. a strange problem with the file type.
  14824. * bindings/objc/DOM.mm: Removed the many extraneous includes. Added new includes
  14825. so we can use and implement the new core and kit functions. Import DOMInternal.h
  14826. first so it can do its public/private magic.
  14827. (-[DOMNode _rootObject]): Changed to use early-return style.
  14828. (kitClass): Added. Tells the wrapper generator what kind of node class to create
  14829. to wrap DOM nodes. This has the code that used to be in the _wrapNode method.
  14830. (kit): Added. Takes an EventTarget and makes the appropriate type of wrapper,
  14831. dpending on whether it's a Node or an SVGElementInstance. This replace methods
  14832. that used to be on both of those classes.
  14833. (-[DOMNode boundingBox]): Changed to use early return, and the core function.
  14834. (-[DOMNode lineBoxRects]): Ditto.
  14835. (-[DOMNode renderedImage]): Ditto.
  14836. (-[DOMRange boundingBox]): Ditto.
  14837. (-[DOMRange lineBoxRects]): Ditto.
  14838. (-[DOMElement image]): Ditto.
  14839. (-[DOMElement _font]): Ditto.
  14840. (-[DOMElement _imageTIFFRepresentation]): Ditto.
  14841. (-[DOMElement _getURLAttribute:]): Ditto.
  14842. (-[DOMElement isFocused]): Ditto.
  14843. (kit): Hand-wrote the version of this for NodeFilter, since it's a protocol,
  14844. not a class in the binding.
  14845. (core): Ditto.
  14846. (-[DOMNodeFilter acceptNode:]): Use core.
  14847. * bindings/objc/DOMAbstractView.mm:
  14848. (-[DOMAbstractView document]): Use kit.
  14849. (-[DOMAbstractView _disconnectFrame]): Call removeDOMWrapper, which is no longer
  14850. in the WebCore namespace, since it's headed for WebKit in the future.
  14851. (core): Hand-wrote the version of this for DOMAbstractView.mm, since we store
  14852. a pointer to the Frame, not the DMWindow.
  14853. (kit): Ditto.
  14854. * bindings/objc/DOMCSS.mm:
  14855. (kitClass): Added. Tells the wrapper generator what kind of node class to create
  14856. to wrap CSS objects. This has the code that used to be in the _wrapStyleSheet,
  14857. _wrapCSSRule, and _wrapCSSValue methods.
  14858. * bindings/objc/DOMEvents.mm:
  14859. (kitClass): Added. Tells the wrapper generator what kind of node class to create
  14860. to wrap event objects. This has the code that used to be in the _wrapEvent methods.
  14861. * bindings/objc/DOMHTML.mm:
  14862. (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): Use kit and core.
  14863. (-[DOMHTMLDocument createDocumentFragmentWithText:]): Ditto.
  14864. (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
  14865. (-[DOMHTMLInputElement _rectOnScreen]): Ditto.
  14866. (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Ditto.
  14867. (-[DOMHTMLInputElement _selectedRange]): Ditto.
  14868. (-[DOMHTMLInputElement _setAutofilled:]): Ditto.
  14869. (-[DOMHTMLSelectElement _activateItemAtIndex:]): Ditto.
  14870. (-[DOMHTMLInputElement _isEdited]): Ditto.
  14871. (-[DOMHTMLTextAreaElement _isEdited]): Ditto.
  14872. (kitClass): Added. Gives HTMLOptionCollection objects an appropriate wrapper.
  14873. * bindings/objc/DOMInternal.h: Removed most of the imports. There's no reason
  14874. to have this header include all the other internal DOM headers. Removed unneeded
  14875. interfaces, including the redeclaration of _init in DOMObject, since it's already
  14876. inherited from WebScriptObject. Moved all the functions out of the WebCore
  14877. namespace since this code is destined for WebKit, which doesn't use a namespace.
  14878. Added kit and core functions for the two classes that live in this header.
  14879. * bindings/objc/DOMInternal.mm:
  14880. (-[WebScriptObject _initializeScriptDOMNodeImp]): Use core.
  14881. * bindings/objc/DOMObject.h: Made the _internal field be private instead of
  14882. protected. This also allows the "#define private public" trick to be used to
  14883. make the field accessible inside the bindings code.
  14884. * bindings/objc/DOMObject.mm:
  14885. (-[DOMObject dealloc]): Updated for namespace change.
  14886. (-[DOMObject sheet]): Use core and kit functions.
  14887. * bindings/objc/DOMRGBColor.mm:
  14888. (-[DOMRGBColor dealloc]): Updated for namespace change.
  14889. (-[DOMRGBColor red]): Use kit function.
  14890. (-[DOMRGBColor green]): Ditto.
  14891. (-[DOMRGBColor blue]): Ditto.
  14892. (-[DOMRGBColor alpha]): Ditto.
  14893. (core): Added. Replaces the _RGBColor method.
  14894. (kit): Added. Replaces the _wrapRGBColor method.
  14895. * bindings/objc/DOMSVGPathSegInternal.mm:
  14896. (kitClass): Added. Replaces the _wrapSVGPathSeg method.
  14897. * bindings/objc/DOMUtility.mm:
  14898. (JSC::createDOMWrapper): Use kit function.
  14899. (createDOMWrapper): Ditto.
  14900. * bindings/objc/DOMXPath.mm:
  14901. (core): Added. Replaces the _xpathNSResolver method.
  14902. (kit): Added. Replaces the _wrapXPathNSResolver method.
  14903. * bindings/objc/ObjCEventListener.mm:
  14904. (WebCore::ObjCEventListener::find): Changed to use early return.
  14905. (WebCore::ObjCEventListener::handleEvent): Use kit function.
  14906. * bindings/objc/ObjCNodeFilterCondition.mm:
  14907. (WebCore::ObjCNodeFilterCondition::acceptNode): Use kit function.
  14908. * bindings/objc/WebScriptObject.mm:
  14909. (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
  14910. Updated for namespace change.
  14911. * bindings/scripts/CodeGeneratorObjC.pm: Changed spelling of "license"
  14912. to U.S. spelling. Removed GetObjCTypeMaker, GetObjCTypeGetterName,
  14913. GetInternalTypeGetterSignature, and GetInternalTypeMakerSignature.
  14914. Changed includes to conform to new scheme. Generate core and kit
  14915. functions instead of methods and calls to those functions. Added a new
  14916. attribute, Polymorphic, to indicate classes that have derived subclasses.
  14917. Removed the old ObjCCustomInternalImpl attribute.
  14918. * css/CSSRule.idl: Use Polymorphic attribute, so core and kit functions
  14919. will be generated, with kit calling kitClass. This requires less hand-
  14920. written code than the old ObjCCustomInternalImpl.
  14921. * css/CSSValue.idl: Ditto.
  14922. * css/StyleSheet.idl: Ditto.
  14923. * dom/Event.idl: Ditto.
  14924. * dom/Node.idl: Ditto.
  14925. * html/HTMLCollection.idl: Ditto.
  14926. * svg/SVGPathSeg.idl: Ditto.
  14927. * editing/TextAffinity.h: Moved kit and core functions out of the
  14928. WebCore namespace since this code is destined for WebKit, which
  14929. doesn't use a namespace
  14930. * platform/mac/ClipboardMac.mm:
  14931. (WebCore::ClipboardMac::declareAndWriteDragImage): Use kit function.
  14932. * platform/mac/DragDataMac.mm:
  14933. (WebCore::DragData::asFragment): Use core function.
  14934. * platform/mac/PasteboardMac.mm:
  14935. (WebCore::Pasteboard::writeSelection): Use kit function.
  14936. * svg/SVGElementInstance.idl: Removed now-unneeded ObjCCustomInternalImpl
  14937. function. This can be generated in a standard way now.
  14938. * svg/SVGViewSpec.idl: Ditto.
  14939. 2009-04-17 Brady Eidson <beidson@apple.com>
  14940. Reviewed by Maciej Stachowiak
  14941. <rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage
  14942. If the Page is in private browsing mode when a statement is queued up, flag that
  14943. statement as read-only.
  14944. It would be better to set the read-only flag on the database thread when it actually
  14945. executes, but that would either require making Settings access a lock-protected operation
  14946. or involve a synchronous callback to the WebCore thread, neither of which seem worth it.
  14947. If it becomes an issue in practice, we can revisit this later.
  14948. Test: storage/private-browsing-readonly.html
  14949. * storage/Database.cpp:
  14950. (WebCore::Database::setAuthorizerReadOnly):
  14951. * storage/Database.h:
  14952. * storage/DatabaseAuthorizer.cpp: For all action types that would alter the database,
  14953. deny when in read-only mode.
  14954. (WebCore::DatabaseAuthorizer::reset):
  14955. (WebCore::DatabaseAuthorizer::createTable):
  14956. (WebCore::DatabaseAuthorizer::dropTable):
  14957. (WebCore::DatabaseAuthorizer::allowAlterTable):
  14958. (WebCore::DatabaseAuthorizer::createIndex):
  14959. (WebCore::DatabaseAuthorizer::dropIndex):
  14960. (WebCore::DatabaseAuthorizer::createTrigger):
  14961. (WebCore::DatabaseAuthorizer::dropTrigger):
  14962. (WebCore::DatabaseAuthorizer::createVTable):
  14963. (WebCore::DatabaseAuthorizer::dropVTable):
  14964. (WebCore::DatabaseAuthorizer::allowDelete):
  14965. (WebCore::DatabaseAuthorizer::allowInsert):
  14966. (WebCore::DatabaseAuthorizer::allowUpdate):
  14967. (WebCore::DatabaseAuthorizer::setReadOnly):
  14968. * storage/DatabaseAuthorizer.h:
  14969. * storage/SQLStatement.cpp:
  14970. (WebCore::SQLStatement::create): Add a m_readOnly flag.
  14971. (WebCore::SQLStatement::SQLStatement): Ditto.
  14972. (WebCore::SQLStatement::execute): If m_readOnly is set, tell the authorizer to change
  14973. to read-only mode.
  14974. * storage/SQLStatement.h:
  14975. * storage/SQLTransaction.cpp:
  14976. (WebCore::SQLTransaction::executeSQL): Flag the statement as read-only if the Page is
  14977. currently in private browsing mode.
  14978. 2009-04-17 Eric Seidel <eric@webkit.org>
  14979. Reviewed by Antti Koivisto.
  14980. Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
  14981. https://bugs.webkit.org/show_bug.cgi?id=25268
  14982. Lots of minus lines. Now we're sharing more sane code
  14983. (which will respect -webkit-transforms! and scroll offsets correctly)
  14984. Which means this fixes:
  14985. https://bugs.webkit.org/show_bug.cgi?id=20769 and
  14986. https://bugs.webkit.org/show_bug.cgi?id=21968 too!
  14987. We're no longer expanding the paint rect "for anti-aliasing", since
  14988. I can't find a case where that's required. If it is, repaintRectInLocalCoordinates()
  14989. should be fixed to handle those cases instead of here.
  14990. This fixes svg/custom/scroll-hit-test (now that we respect scroll offsets when repainting)
  14991. as well as improves our focus ring drawing seen in svg/custom/focus-ring
  14992. focus rings are now closer to transformed content by a couple pixels (they were needlessly outset by the antialiasing hack)
  14993. Also, it fixes the dumped rects for markers, causing a progression in svg/custom/marker-overflow-clip
  14994. * rendering/RenderPath.cpp:
  14995. (WebCore::RenderPath::repaintRectInLocalCoordinates):
  14996. (WebCore::RenderPath::setPath):
  14997. * rendering/RenderPath.h:
  14998. * rendering/RenderSVGContainer.cpp:
  14999. (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  15000. * rendering/RenderSVGContainer.h:
  15001. * rendering/RenderSVGModelObject.cpp:
  15002. (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
  15003. (WebCore::RenderSVGModelObject::computeRectForRepaint):
  15004. * rendering/RenderSVGModelObject.h:
  15005. * rendering/RenderSVGRoot.cpp:
  15006. (WebCore::RenderSVGRoot::computeRectForRepaint):
  15007. * rendering/RenderSVGRoot.h:
  15008. 2009-04-17 Chris Fleizach <cfleizach@apple.com>
  15009. Reviewed by Darin Adler.
  15010. Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
  15011. https://bugs.webkit.org/show_bug.cgi?id=25259
  15012. When a node becomes visible or hidden, accessibility needs to be told to update.
  15013. Test: accessibility/visible-elements.html
  15014. * rendering/RenderObject.cpp:
  15015. (WebCore::RenderObject::styleWillChange):
  15016. 2009-04-17 Kevin Ollivier <kevino@theolliviers.com>
  15017. wx build fix, added missing header.
  15018. * platform/graphics/wx/TransformationMatrixWx.cpp:
  15019. 2009-04-17 Simon Hausmann <simon.hausmann@nokia.com>
  15020. Unreviewed build fix.
  15021. Fix the build with enabled SVG filters
  15022. * rendering/RenderSVGModelObject.cpp: Include SVGResourceFilter.h.
  15023. 2009-04-16 Eric Roman <eroman@chromium.org>
  15024. Reviewed by Dimitri Glazkov.
  15025. https://bugs.webkit.org/show_bug.cgi?id=25196
  15026. Add a missing V8DOMMap include.
  15027. * bindings/v8/WorkerScriptController.cpp: Included V8DOMMap.h.
  15028. 2009-04-16 Dimitri Glazkov <dglazkov@chromium.org>
  15029. Reviewed by Darin Fisher.
  15030. https://bugs.webkit.org/show_bug.cgi?id=25260
  15031. Finish V8 custom bindings for InspectorController.
  15032. * bindings/v8/custom/V8InspectorControllerCustom.cpp:
  15033. (WebCore::CALLBACK_FUNC_DECL): Added.
  15034. 2009-04-16 Kevin Watters <kevinwatters@gmail.com>
  15035. Reviewed by Kevin Ollivier.
  15036. Switch to wxGraphicsBitmap when using wxGraphicsContext so that we're not doing
  15037. unnecessary conversions internally when drawing bitmaps.
  15038. https://bugs.webkit.org/show_bug.cgi?id=25248
  15039. * platform/graphics/ImageSource.h:
  15040. * platform/graphics/wx/ImageSourceWx.cpp:
  15041. (WebCore::ImageSource::createFrameAtIndex):
  15042. * platform/graphics/wx/ImageWx.cpp:
  15043. (WebCore::BitmapImage::draw):
  15044. (WebCore::BitmapImage::drawPattern):
  15045. 2009-04-16 Justin Garcia <justin.garcia@apple.com>
  15046. Reviewed by Dan Bernstein.
  15047. Performing a block style change in an editable root that contains only a br adds a newline
  15048. https://bugs.webkit.org/show_bug.cgi?id=25256
  15049. * editing/CompositeEditCommand.cpp:
  15050. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix a bad check for an root
  15051. block that didn't handle a root that contained a placeholder.
  15052. 2009-04-16 Eric Seidel <eric@webkit.org>
  15053. Reviewed by Simon Fraser.
  15054. Fix computeContainerBoundingBox to respect viewport translations
  15055. https://bugs.webkit.org/show_bug.cgi?id=25254
  15056. Previously computeContainerBoundingBox was just adding the viewportTranslation.
  15057. Which, although it has a confusing name, only contains the scale and translation
  15058. for the viewBox/preserveAspectRatio adjustment. It does not contain the
  15059. translation for the x/y offset of the viewport.
  15060. localToParentTransform() does contain this offset, so we use that instead
  15061. of the previous hacky code.
  15062. * rendering/RenderSVGContainer.h:
  15063. * rendering/RenderSVGViewportContainer.h:
  15064. * rendering/SVGRenderSupport.cpp:
  15065. (WebCore::computeContainerBoundingBox):
  15066. 2009-04-16 Eric Seidel <eric@webkit.org>
  15067. Reviewed by Simon Fraser.
  15068. Add a localToParentTransform() method which includes the
  15069. full transform between local and parent local coordinates.
  15070. https://bugs.webkit.org/show_bug.cgi?id=25226
  15071. Moved m_localTransform up into RenderSVGTransformableContainer
  15072. and added a comment to RenderSVGViewportContainer to make it more
  15073. clear that it does not have a localTransform().
  15074. This patch reveals two more failed design decisions:
  15075. 1. Use of RenderBox::absoluteTransform() to mean "absoluteTransform()
  15076. including only my localTransform()" callers are probably using it
  15077. incorrectly anyway and are just masking bugs in the confused code.
  15078. 2. computeContainerBoundingBox does not include viewport translations in
  15079. its computed bounding box, so bounding boxes will be off for parents of
  15080. inner <svg> elements. I'll fix this an updated the results in a separate change.
  15081. No functional changes, thus no tests.
  15082. * rendering/RenderObject.cpp:
  15083. (WebCore::RenderObject::localToParentTransform):
  15084. (WebCore::RenderObject::absoluteTransform):
  15085. * rendering/RenderObject.h:
  15086. * rendering/RenderSVGContainer.cpp:
  15087. (WebCore::RenderSVGContainer::layout):
  15088. * rendering/RenderSVGContainer.h:
  15089. (WebCore::RenderSVGContainer::viewportTransform):
  15090. * rendering/RenderSVGHiddenContainer.cpp:
  15091. * rendering/RenderSVGHiddenContainer.h:
  15092. (WebCore::RenderSVGHiddenContainer::absoluteTransform):
  15093. * rendering/RenderSVGRoot.cpp:
  15094. (WebCore::RenderSVGRoot::localToParentTransform):
  15095. (WebCore::RenderSVGRoot::absoluteTransform):
  15096. * rendering/RenderSVGRoot.h:
  15097. * rendering/RenderSVGTransformableContainer.cpp:
  15098. (WebCore::RenderSVGTransformableContainer::localToParentTransform):
  15099. (WebCore::RenderSVGTransformableContainer::localTransform):
  15100. * rendering/RenderSVGTransformableContainer.h:
  15101. * rendering/RenderSVGViewportContainer.cpp:
  15102. (WebCore::RenderSVGViewportContainer::localToParentTransform):
  15103. (WebCore::RenderSVGViewportContainer::absoluteTransform):
  15104. * rendering/RenderSVGViewportContainer.h:
  15105. * rendering/SVGRenderSupport.cpp:
  15106. (WebCore::computeContainerBoundingBox):
  15107. 2009-04-16 Adam Langley <agl@google.com>
  15108. Reviewed by Darin Fisher.
  15109. Fix Chromium's rendering of <option> elements inside of <optgroups>.
  15110. https://bugs.webkit.org/show_bug.cgi?id=25244
  15111. Test (will included as a manual test by https://bugs.webkit.org/show_bug.cgi?id=24900):
  15112. <select>
  15113. <optgroup label="Should be bold">
  15114. <option>Should not be bold</option>
  15115. </optgroup>
  15116. </select>
  15117. * css/themeWin.css: adding comments
  15118. * platform/chromium/PopupMenuChromium.cpp:
  15119. (WebCore::PopupListBox::getRowFont): use menuStyle() rather than the item's style
  15120. 2009-04-16 Eric Roman <eroman@chromium.org>
  15121. Reviewed by Alexey Proskuryakov.
  15122. https://bugs.webkit.org/show_bug.cgi?id=25218
  15123. Make DOMWindow::inlineEventListenerForType not have the "inline"
  15124. keyword. As this method gets used outside of DOMWindow.
  15125. * page/DOMWindow.cpp:
  15126. (WebCore::DOMWindow::inlineEventListenerForType):
  15127. 2009-04-16 Greg Bolsinga <bolsinga@apple.com>
  15128. Reviewed by Antti Koivisto.
  15129. Fix <rdar://problem/6766969>
  15130. When deferred repaints are enabled and being reset and there is a active
  15131. timer, stop the timer and do the deferred repaints immediately.
  15132. * page/FrameView.cpp:
  15133. (WebCore::FrameView::resetDeferredRepaintDelay):
  15134. 2009-04-16 Xan Lopez <xlopez@igalia.com>
  15135. Reviewed by Sam Weinig.
  15136. https://bugs.webkit.org/show_bug.cgi?id=25241
  15137. Remove superfluous NotImplemented.h includes.
  15138. * html/CanvasRenderingContext2D.cpp:
  15139. * html/CanvasStyle.cpp:
  15140. * page/AccessibilityRenderObject.cpp:
  15141. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  15142. * platform/graphics/GraphicsContext.cpp:
  15143. * platform/graphics/cairo/ImageBufferCairo.cpp:
  15144. * platform/graphics/cairo/PathCairo.cpp:
  15145. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  15146. * platform/graphics/gtk/FontGtk.cpp:
  15147. * platform/graphics/gtk/IconGtk.cpp:
  15148. * platform/graphics/qt/IconQt.cpp:
  15149. * platform/graphics/qt/ImageQt.cpp:
  15150. * platform/graphics/qt/ImageSourceQt.cpp:
  15151. * platform/graphics/skia/ImageBufferSkia.cpp:
  15152. * platform/graphics/skia/ImageSkia.cpp:
  15153. * platform/graphics/win/ColorSafari.cpp:
  15154. * platform/graphics/win/FontWin.cpp:
  15155. * platform/graphics/win/GraphicsContextCGWin.cpp:
  15156. * platform/graphics/win/GraphicsContextCairoWin.cpp:
  15157. * platform/graphics/win/SimpleFontDataCairoWin.cpp:
  15158. * platform/graphics/wx/ImageWx.cpp:
  15159. * platform/graphics/wx/TransformationMatrixWx.cpp:
  15160. * platform/gtk/PlatformScreenGtk.cpp:
  15161. * platform/gtk/PopupMenuGtk.cpp:
  15162. * platform/gtk/ScrollViewGtk.cpp:
  15163. * platform/gtk/ScrollbarGtk.cpp:
  15164. * platform/network/cf/ResourceHandleCFNet.cpp:
  15165. * platform/posix/FileSystemPOSIX.cpp:
  15166. * platform/qt/DragDataQt.cpp:
  15167. * platform/qt/FileSystemQt.cpp:
  15168. * platform/qt/Localizations.cpp:
  15169. * platform/qt/PopupMenuQt.cpp:
  15170. * platform/win/EditorWin.cpp:
  15171. * platform/win/PasteboardWin.cpp:
  15172. * platform/wx/KeyboardEventWx.cpp:
  15173. * platform/wx/PopupMenuWx.cpp:
  15174. * platform/wx/SharedTimerWx.cpp:
  15175. * plugins/gtk/PluginViewGtk.cpp:
  15176. * plugins/mac/PluginPackageMac.cpp:
  15177. * plugins/qt/PluginPackageQt.cpp:
  15178. * plugins/win/PluginViewWin.cpp:
  15179. * rendering/RenderThemeChromiumLinux.cpp:
  15180. * svg/graphics/SVGImage.cpp:
  15181. 2009-04-16 Geoffrey Garen <ggaren@apple.com>
  15182. Reviewed by Sam Weinig.
  15183. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  15184. Unbounded memory growth when churning elements with anonymous event handler functions
  15185. Some cleanup in event handling code.
  15186. * bindings/js/JSDOMGlobalObject.cpp:
  15187. * bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener
  15188. and findJSProtectedEventListener because they are now unused.
  15189. * bindings/js/JSEventListener.cpp:
  15190. * bindings/js/JSEventListener.h:
  15191. (WebCore::JSEventListener::clearGlobalObject):
  15192. * bindings/js/JSLazyEventListener.cpp:
  15193. (WebCore::JSLazyEventListener::JSLazyEventListener):
  15194. (WebCore::JSLazyEventListener::~JSLazyEventListener):
  15195. (WebCore::JSLazyEventListener::globalObject):
  15196. * bindings/js/JSLazyEventListener.h:
  15197. (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener,
  15198. and merged it with JSLazyEventListener, the only remaining event listener
  15199. that still GC-protects its function and global object.
  15200. * bindings/js/ScriptController.cpp:
  15201. (WebCore::ScriptController::ScriptController):
  15202. * bindings/js/ScriptController.h:
  15203. (WebCore::ScriptController::setEventHandlerLineNumber):
  15204. (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno =>
  15205. handlerLineNumber, because anything less would be uncivilized. Removed
  15206. createInlineEventListener because it mostly did irrelevent work, so it
  15207. just got in the way of understanding how event handler creation works.
  15208. * dom/Document.cpp:
  15209. (WebCore::Document::createEventListener):
  15210. * dom/XMLTokenizerLibxml2.cpp:
  15211. (WebCore::XMLTokenizer::startElementNs):
  15212. * html/HTMLTokenizer.cpp:
  15213. (WebCore::HTMLTokenizer::processToken): Ditto.
  15214. 2009-04-16 Beth Dakin <bdakin@apple.com>
  15215. Reviewed by Dave Hyatt.
  15216. Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website
  15217. crashes on load due to messy HTML in search form
  15218. -and corresponding-
  15219. <rdar://problem/6210633>
  15220. Before this patch, <form>s were allowed to sit inside tables
  15221. without being wrapped by anonymous table parts. There was also a
  15222. concept that such a form could be "demoted" and would not be
  15223. allowed to have any children. This patch has the HTML parser mark
  15224. form elements that have been demoted as such, and then the demoted
  15225. forms are not given renderers. I also removed the code that allowed
  15226. forms to sit in tables without anonymous table sections. So now any
  15227. forms that do manage to get a renderer inside a table will also be
  15228. wrapped with appropriate table parts.
  15229. * html/HTMLFormElement.cpp:
  15230. (WebCore::HTMLFormElement::HTMLFormElement):
  15231. (WebCore::HTMLFormElement::rendererIsNeeded):
  15232. * html/HTMLFormElement.h:
  15233. (WebCore::HTMLFormElement::setDemoted):
  15234. (WebCore::HTMLFormElement::isDemoted):
  15235. * html/HTMLParser.cpp:
  15236. (WebCore::HTMLParser::insertNode):
  15237. * rendering/RenderTable.cpp:
  15238. (WebCore::RenderTable::addChild):
  15239. * rendering/RenderTableRow.cpp:
  15240. (WebCore::RenderTableRow::addChild):
  15241. * rendering/RenderTableSection.cpp:
  15242. (WebCore::RenderTableSection::addChild):
  15243. 2009-04-16 Xiaomei Ji <xji@chromium.org>
  15244. Reviewed by Simon Fraser.
  15245. Fix https://bugs.webkit.org/show_bug.cgi?id=24527
  15246. caret does not paint the first time you focus on a 0px right padding RTL div
  15247. Test: fast/forms/caret-rtl.html
  15248. * rendering/RenderBlock.cpp:
  15249. (WebCore::RenderBlock::localCaretRect): When calculating x-axis if
  15250. alignment is alignRight, we need to subtract the caretWidth so that the
  15251. caret at IntRect(x, y, caretWidth, height) is inside the block.
  15252. 2009-04-16 Justin Garcia <justin.garcia@apple.com>
  15253. Reviewed by Simon Fraser.
  15254. https://bugs.webkit.org/show_bug.cgi?id=25228
  15255. SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)
  15256. Return the bounds of the transformed caret, not the transformed repaint rect for the caret (which is inflated).
  15257. * editing/SelectionController.cpp:
  15258. (WebCore::SelectionController::localCaretRect):
  15259. (WebCore::SelectionController::absoluteBoundsForLocalRect):
  15260. (WebCore::SelectionController::caretRepaintRect):
  15261. (WebCore::SelectionController::recomputeCaretRect):
  15262. * editing/SelectionController.h:
  15263. 2009-04-16 Pierre d'Herbemont <pdherbemont@apple.com>
  15264. Reviewed by Simon Fraser.
  15265. https://bugs.webkit.org/show_bug.cgi?id=25187
  15266. Bug 25187: <video> may not be rendered upon certain racy conditions
  15267. Always create the video renderer when the load state reaches QTMovieLoadStateLoaded and
  15268. the element is visible, not just when the movie has just been opened.
  15269. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  15270. (WebCore::MediaPlayerPrivate::updateStates): Make sure we do not make false
  15271. assumption on the state changes order. Create the renderer if none is present,
  15272. when movie is loaded instead.
  15273. 2009-04-16 Eric Seidel <eric@webkit.org>
  15274. Reviewed by Geoffrey Garen.
  15275. Add filterBoundingBox() to RenderSVGModelObject to share a tiny bit of code
  15276. RenderSVGModelObject has much more interesting code it can share,
  15277. but I'm just trying to get the commits out of my local branch and into
  15278. the repository in any order I can. :) This one was small.
  15279. This will be used by the unified RenderSVGModelObject
  15280. clippedOverflowRectForRepaint patch coming soon.
  15281. * rendering/RenderPath.cpp:
  15282. (WebCore::RenderPath::clippedOverflowRectForRepaint):
  15283. * rendering/RenderSVGContainer.cpp:
  15284. (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
  15285. * rendering/RenderSVGModelObject.cpp:
  15286. (WebCore::RenderSVGModelObject::filterBoundingBox):
  15287. * rendering/RenderSVGModelObject.h:
  15288. 2009-04-16 Geoffrey Garen <ggaren@apple.com>
  15289. Reviewed by Eric Seidel and Adam Roben.
  15290. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  15291. Unbounded memory growth when churning elements with anonymous event handler functions
  15292. Simplified some EventHandler creation code.
  15293. Removed a pile of code whose sole purpose was to allow SVG event handlers
  15294. to supply a parameter named "evt" instead of the normal "event", and
  15295. replaced it with a single parameter to JSLazyEventListener's constructor
  15296. specifying the parameter name to use.
  15297. * bindings/js/JSDOMWindowBase.h:
  15298. * bindings/js/JSLazyEventListener.cpp:
  15299. (WebCore::JSLazyEventListener::JSLazyEventListener):
  15300. (WebCore::JSLazyEventListener::parseCode):
  15301. * bindings/js/JSLazyEventListener.h:
  15302. (WebCore::JSLazyEventListener::create):
  15303. * bindings/js/ScriptController.cpp:
  15304. (WebCore::ScriptController::createInlineEventListener):
  15305. * bindings/js/ScriptController.h:
  15306. * dom/Document.cpp:
  15307. (WebCore::Document::createEventListener):
  15308. 2009-04-15 Eric Seidel <eric@webkit.org>
  15309. Reviewed by David Hyatt.
  15310. Split out objectBoundingBox and repaintRectInLocalCoordinates from relativeBBox
  15311. in preparation for simplifying (and fixing) repaint logic in the SVG rendering tree.
  15312. https://bugs.webkit.org/show_bug.cgi?id=25224
  15313. objectBoundingBox() matches the SVG 1.1 concept of a "bounding box"
  15314. repaintRectInLocalCoordinates() should return the a rect covering all painted content.
  15315. However, repaintRectInLocalCoordinates() still only returns the "stroke bounding box"
  15316. in this patch. In a future patch, repaintRectInLocalCoordinates will be fixed to return
  15317. a rect covering all painted content. In order to avoid changing several hundred layout test results, I've left
  15318. the behavior as-is for now. The returned rect is used by various repaintRectInLocalCoordinates
  15319. implementations and sometimes adjusted to include all painted content, but not always, and
  15320. the places where the adjustments are made are sometimes wrong. Again, will be fixed in
  15321. an upcoming patch.
  15322. This patch discovered a bug in Font::drawTextUsingSVGFont, which is probably causing
  15323. bounding-box relative gradients on SVGFont glyphs to not paint correctly.
  15324. I chose not to try and fix the bug in this patch and instead left a FIXME.
  15325. This patch also discovered that at least tspan.getBBox() is broken. This
  15326. along with the foreignObject.getBBox() change will be tested (and fixed) in a
  15327. later patch. https://bugs.webkit.org/show_bug.cgi?id=25225
  15328. No change in behavior (besides the above mentioned foreignObject.getBBox()), thus no tests.
  15329. * rendering/RenderForeignObject.cpp:
  15330. (WebCore::RenderForeignObject::objectBoundingBox): this is a behavior improvement for getBBox() test case coming in a later patch
  15331. (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): only really used for layout test results, might some day be used for repaint.
  15332. * rendering/RenderForeignObject.h:
  15333. * rendering/RenderObject.cpp:
  15334. (WebCore::RenderObject::objectBoundingBox): new methods, ASSERT if used but not implemented.
  15335. (WebCore::RenderObject::repaintRectInLocalCoordinates):
  15336. * rendering/RenderObject.h:
  15337. * rendering/RenderPath.cpp:
  15338. (WebCore::RenderPath::objectBoundingBox):
  15339. (WebCore::RenderPath::repaintRectInLocalCoordinates):
  15340. (WebCore::RenderPath::clippedOverflowRectForRepaint):
  15341. (WebCore::RenderPath::lineHeight):
  15342. (WebCore::RenderPath::baselinePosition):
  15343. (WebCore::RenderPath::paint):
  15344. (WebCore::RenderPath::addFocusRingRects):
  15345. * rendering/RenderPath.h:
  15346. * rendering/RenderSVGContainer.cpp:
  15347. (WebCore::RenderSVGContainer::paint):
  15348. (WebCore::RenderSVGContainer::objectBoundingBox):
  15349. (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  15350. * rendering/RenderSVGContainer.h:
  15351. * rendering/RenderSVGGradientStop.h:
  15352. (WebCore::RenderSVGGradientStop::objectBoundingBox):
  15353. (WebCore::RenderSVGGradientStop::repaintRectInLocalCoordinates):
  15354. * rendering/RenderSVGHiddenContainer.cpp:
  15355. (WebCore::RenderSVGHiddenContainer::objectBoundingBox):
  15356. (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
  15357. * rendering/RenderSVGHiddenContainer.h:
  15358. * rendering/RenderSVGImage.cpp:
  15359. (WebCore::RenderSVGImage::objectBoundingBox):
  15360. (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  15361. (WebCore::RenderSVGImage::calculateAbsoluteBounds):
  15362. (WebCore::RenderSVGImage::addFocusRingRects):
  15363. * rendering/RenderSVGImage.h:
  15364. * rendering/RenderSVGRoot.cpp:
  15365. (WebCore::RenderSVGRoot::paint):
  15366. (WebCore::RenderSVGRoot::objectBoundingBox):
  15367. (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  15368. * rendering/RenderSVGRoot.h:
  15369. * rendering/RenderSVGTSpan.h:
  15370. (WebCore::RenderSVGTSpan::objectBoundingBox):
  15371. (WebCore::RenderSVGTSpan::repaintRectInLocalCoordinates):
  15372. * rendering/RenderSVGText.cpp:
  15373. (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
  15374. (WebCore::RenderSVGText::absoluteRects):
  15375. (WebCore::RenderSVGText::absoluteQuads):
  15376. (WebCore::RenderSVGText::objectBoundingBox):
  15377. (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  15378. * rendering/RenderSVGText.h:
  15379. * rendering/RenderSVGViewportContainer.cpp:
  15380. (WebCore::RenderSVGViewportContainer::viewportTransform):
  15381. * rendering/SVGRenderSupport.cpp:
  15382. (WebCore::computeContainerBoundingBox):
  15383. * rendering/SVGRenderSupport.h:
  15384. * rendering/SVGRenderTreeAsText.cpp:
  15385. (WebCore::operator<<):
  15386. * svg/SVGFont.cpp:
  15387. (WebCore::Font::drawTextUsingSVGFont):
  15388. * svg/SVGLocatable.cpp:
  15389. (WebCore::SVGLocatable::getBBox):
  15390. * svg/SVGPatternElement.cpp:
  15391. (WebCore::SVGPatternElement::buildPattern):
  15392. * svg/graphics/SVGPaintServerGradient.cpp:
  15393. (WebCore::createMaskAndSwapContextForTextGradient):
  15394. (WebCore::clipToTextMask):
  15395. (WebCore::SVGPaintServerGradient::setup):
  15396. * svg/graphics/SVGPaintServerPattern.cpp:
  15397. (WebCore::SVGPaintServerPattern::setup):
  15398. 2009-04-16 Dan Bernstein <mitz@apple.com>
  15399. Reviewed by Darin Adler.
  15400. - fix <rdar://problem/6032139> Table cell widths calculated
  15401. incorrectly on table that uses table-layout:fixed, colspans, and a mix
  15402. of percentage and pixel widths
  15403. Test: fast/table/fixed-granular-cols.html
  15404. The incorrect widths resulted from incorrect handling of the case where
  15405. the <col> elements are more granular than the table cells.
  15406. * rendering/FixedTableLayout.cpp:
  15407. (WebCore::FixedTableLayout::calcWidthArray): When processing <col>
  15408. elements, append effective columns or split existing effective columns
  15409. as needed.
  15410. 2009-04-16 Alexey Proskuryakov <ap@webkit.org>
  15411. <rdar://problem/6795285> Infinite recursion in ResourceHandle::receivedRequestToContinueWithoutCredential
  15412. Rolled out <http://trac.webkit.org/projects/webkit/changeset/42536> - the two instances of
  15413. authentication challenge are different, after all. Added a FIXME comment about a possible
  15414. future improvement.
  15415. * platform/network/ResourceHandle.cpp:
  15416. (WebCore::ResourceHandle::clearAuthentication):
  15417. * platform/network/ResourceHandleInternal.h:
  15418. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  15419. * platform/network/cf/ResourceHandleCFNet.cpp:
  15420. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  15421. (WebCore::ResourceHandle::receivedCredential):
  15422. (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
  15423. (WebCore::ResourceHandle::receivedCancellation):
  15424. * platform/network/mac/ResourceHandleMac.mm:
  15425. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  15426. (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
  15427. (WebCore::ResourceHandle::receivedCredential):
  15428. (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
  15429. (WebCore::ResourceHandle::receivedCancellation):
  15430. 2009-04-15 Geoffrey Garen <ggaren@apple.com>
  15431. Reviewed by Sam Weinig.
  15432. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  15433. Unbounded memory growth when churning elements with anonymous event handler functions
  15434. Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
  15435. a page with breakpoints set
  15436. * bindings/js/JSEventListener.cpp:
  15437. (WebCore::JSEventListener::clearJSFunctionInline):
  15438. (WebCore::JSEventListener::markJSFunction):
  15439. * bindings/js/JSEventListener.h: Actually clear our function and global
  15440. object pointers when our client instructs us to. (Oops!) Also, mark
  15441. our global object while we still intend to use it.
  15442. * bindings/js/JSSVGElementInstanceCustom.cpp:
  15443. (WebCore::JSSVGElementInstance::mark):
  15444. (WebCore::toJS):
  15445. * bindings/scripts/CodeGeneratorJS.pm:
  15446. * svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure
  15447. that the corresponding element also has a wrapper, to keep its event
  15448. listeners alive.
  15449. 2009-04-15 Dimitri Glazkov <dglazkov@chromium.org>
  15450. Reviewed by Darin Fisher.
  15451. https://bugs.webkit.org/show_bug.cgi?id=25201
  15452. Add ScriptFunctionCall/ScriptObject for V8.
  15453. * bindings/v8/ScriptFunctionCall.cpp: Added.
  15454. * bindings/v8/ScriptFunctionCall.h: Added.
  15455. * bindings/v8/ScriptObject.cpp: Added.
  15456. * bindings/v8/ScriptObject.h: Added.
  15457. * bindings/v8/ScriptObjectQuarantine.cpp: Added.
  15458. * bindings/v8/ScriptObjectQuarantine.h: Added.
  15459. * bindings/v8/ScriptScope.cpp: Added.
  15460. * bindings/v8/ScriptScope.h: Added.
  15461. * bindings/v8/ScriptState.h:
  15462. (WebCore::ScriptState::ScriptState): Added new constructors.
  15463. (WebCore::ScriptState::frame): Added Frame ptr accessor.
  15464. * bindings/v8/ScriptString.h:
  15465. (WebCore::ScriptString::ScriptString): Added default constructor.
  15466. * bindings/v8/ScriptValue.h:
  15467. (WebCore::ScriptValue::isEqual): Added.
  15468. 2009-04-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  15469. Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.
  15470. * GNUmakefile.am:
  15471. 2009-04-15 Steve Falkenburg <sfalken@apple.com>
  15472. <rdar://problem/6785760> WebCore should use a maximum of 6 connections per host, not 4
  15473. Reviewed by Adam Roben.
  15474. * platform/network/ResourceRequestBase.cpp:
  15475. * platform/network/cf/ResourceRequestCFNet.cpp:
  15476. (WebCore::initializeMaximumHTTPConnectionCountPerHost):
  15477. 2009-04-15 Sam Weinig <sam@webkit.org>
  15478. Reviewed by Mark Rowe.
  15479. Add special casing to bindings generator so that custom functions
  15480. starting with xml or xslt conform to WebKit style guidelines.
  15481. * bindings/js/JSDOMWindowCustom.cpp:
  15482. (WebCore::JSDOMWindow::xmlHttpRequest):
  15483. (WebCore::JSDOMWindow::xsltProcessor):
  15484. * bindings/scripts/CodeGenerator.pm:
  15485. 2009-04-15 Eric Seidel <eric@webkit.org>
  15486. Reviewed by Simon Fraser.
  15487. Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
  15488. https://bugs.webkit.org/show_bug.cgi?id=25221
  15489. RenderSVGModelObject is the base rendering class for things which live
  15490. in the SVG rendering tree. Not all SVG renders are RenderSVGModelObjects yet.
  15491. More patches coming. This is just adding the class, future patches
  15492. will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.
  15493. * WebCore.pro:
  15494. * WebCore.scons:
  15495. * WebCore.vcproj/WebCore.vcproj:
  15496. * WebCore.xcodeproj/project.pbxproj:
  15497. * rendering/RenderPath.cpp:
  15498. (WebCore::RenderPath::RenderPath):
  15499. * rendering/RenderPath.h:
  15500. * rendering/RenderSVGContainer.cpp:
  15501. (WebCore::RenderSVGContainer::RenderSVGContainer):
  15502. * rendering/RenderSVGContainer.h:
  15503. * rendering/RenderSVGModelObject.cpp: Added.
  15504. (WebCore::RenderSVGModelObject::RenderSVGModelObject):
  15505. * rendering/RenderSVGModelObject.h: Added.
  15506. (WebCore::RenderSVGModelObject::requiresLayer):
  15507. * rendering/RenderTreeAsText.cpp:
  15508. * rendering/SVGRenderTreeAsText.cpp:
  15509. 2009-04-15 Eric Seidel <eric@webkit.org>
  15510. Reviewed by Simon Fraser.
  15511. Remove more dead code from RenderSVGHiddenContainer.
  15512. lineHeight and baselinePosition used to be on RenderSVGContainer
  15513. (of which this is a subclass) because RenderSVGContainer used
  15514. to be a RenderBox and always the renderer for <svg>
  15515. Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
  15516. and RenderSVGViewportContainer (when inside SVG content)
  15517. so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.
  15518. * rendering/RenderSVGHiddenContainer.cpp:
  15519. * rendering/RenderSVGHiddenContainer.h:
  15520. 2009-04-15 Eric Seidel <eric@webkit.org>
  15521. Reviewed by Simon Fraser.
  15522. Remove unneeded (broken) code from SVG renderers
  15523. https://bugs.webkit.org/show_bug.cgi?id=25214
  15524. Mostly due to my historical confusions about the render tree
  15525. and some methods not being removed after classes were split.
  15526. RenderSVGRoot is an RenderBox and should just use all the
  15527. standard RenderBox methods for inspector and repaint rects.
  15528. RenderSVGContainer is *not* a RenderBox (any more) and thus
  15529. doesn't need lineHeight or width/height or calcBounds.
  15530. RenderSVGViewportContainer had some broken code which tried
  15531. to see if the click was inside the container at all, but it
  15532. was using width/height metrics based off of the containing
  15533. block (from calcWidth) which is wrong (since its real
  15534. width/height are from its containing viewport not containing block).
  15535. * rendering/RenderSVGContainer.cpp:
  15536. (WebCore::RenderSVGContainer::RenderSVGContainer):
  15537. (WebCore::RenderSVGContainer::layout):
  15538. * rendering/RenderSVGContainer.h:
  15539. * rendering/RenderSVGRoot.cpp:
  15540. * rendering/RenderSVGRoot.h:
  15541. * rendering/RenderSVGViewportContainer.cpp:
  15542. (WebCore::RenderSVGViewportContainer::layout):
  15543. (WebCore::RenderSVGViewportContainer::nodeAtPoint):
  15544. 2009-04-15 Eric Seidel <eric@webkit.org>
  15545. Reviewed by Simon Fraser and Sam Weinig.
  15546. https://bugs.webkit.org/show_bug.cgi?id=25217
  15547. Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
  15548. Add ASSERT(element) to all these functions since they should never be passed a null element.
  15549. * svg/SVGLocatable.cpp:
  15550. (WebCore::isViewportElement):
  15551. (WebCore::SVGLocatable::nearestViewportElement):
  15552. (WebCore::SVGLocatable::farthestViewportElement):
  15553. (WebCore::SVGLocatable::getBBox):
  15554. (WebCore::SVGLocatable::getCTM):
  15555. (WebCore::SVGLocatable::getScreenCTM):
  15556. 2009-04-15 Sam Weinig <sam@webkit.org>
  15557. Reviewed by Anders Carlsson.
  15558. Remove support for the ObjCIvar extended attribute from the Objective-C
  15559. bindings generator. It is not used anymore.
  15560. * bindings/scripts/CodeGeneratorObjC.pm:
  15561. 2009-04-15 Justin Garcia <justin.garcia@apple.com>
  15562. Reviewed by Dan Bernstein.
  15563. https://bugs.webkit.org/show_bug.cgi?id=25204
  15564. Create a fast path for ReplaceSelectionCommand that merges text nodes
  15565. During simple pastes, where we're just pasting a text node into a run of text, we would split the current
  15566. text and insert the new node in between. This is slow and we hit this bug:
  15567. https://bugs.webkit.org/show_bug.cgi?id=6148
  15568. in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
  15569. This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
  15570. text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).
  15571. * editing/ReplaceSelectionCommand.cpp:
  15572. (WebCore::ReplaceSelectionCommand::doApply):
  15573. (WebCore::ReplaceSelectionCommand::performTrivialReplace):
  15574. * editing/ReplaceSelectionCommand.h:
  15575. * editing/TextIterator.cpp:
  15576. 2009-04-15 Adam Langley <agl@google.com>
  15577. Reviewed by Darin Fisher.
  15578. Move VDMX parsing into the Chromium Linux port.
  15579. https://bugs.webkit.org/show_bug.cgi?id=25116
  15580. VDMX tables are optional tables in TrueType fonts which contain the
  15581. exact pixel height of a given font at a given pel size. In order to
  15582. match Windows font metrics we have to use these numbers.
  15583. Previously, the parsing was performed in Skia. As part of the merge
  15584. with upstream Skia, an interface for getting table data from a font
  15585. has been added to Skia and we're moving the parsing into WebKit.
  15586. This does not change any layout tests.
  15587. * platform/graphics/chromium/FontPlatformDataLinux.cpp:
  15588. (WebCore::FontPlatformData::uniqueID):
  15589. * platform/graphics/chromium/FontPlatformDataLinux.h:
  15590. * platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
  15591. * platform/graphics/chromium/FontTrueTypeLinux.h: Added.
  15592. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  15593. (WebCore::SimpleFontData::platformInit):
  15594. (WebCore::SimpleFontData::platformWidthForGlyph):
  15595. 2009-04-15 Stephen White <senorblanco@chromium.org>
  15596. Reviewed by Dimitri Glazkov.
  15597. https://bugs.webkit.org/show_bug.cgi?id=25180
  15598. Restore stroked outlines to PlatformContextSkia::drawRect().
  15599. These were removed inadvertently in r41805, aka
  15600. https://bugs.webkit.org/show_bug.cgi?id=24662.
  15601. SkRect is { left, top, right, bottom }, not { left, top, width, height }.
  15602. * platform/graphics/skia/PlatformContextSkia.cpp:
  15603. (PlatformContextSkia::drawRect):
  15604. 2009-04-15 Dan Bernstein <mitz@apple.com>
  15605. Reviewed by Dave Hyatt.
  15606. - fix <rdar://problem/6777374> Generated content with display: run-in
  15607. causes a crash
  15608. Test: fast/runin/generated.html
  15609. * rendering/RenderBlock.cpp:
  15610. (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is
  15611. generated, and if so, make the RenderInline anonymous instead of passing
  15612. a 0 node to the RenderInline constructor. If the run-in itself is
  15613. generated, do move :before and :after children from the block into the
  15614. inline, as they will not be regenerated. Changed nested ifs into early
  15615. returns.
  15616. 2009-04-15 Eric Roman <eroman@chromium.org>
  15617. Reviewed by Geoffrey Garen.
  15618. https://bugs.webkit.org/show_bug.cgi?id=25192
  15619. Expose DOMWindow::removeInlineEventListenerForType and
  15620. DOMWindow::inlineEventListenerForType as public.
  15621. * page/DOMWindow.h:
  15622. 2009-04-14 Eric Roman <eroman@chromium.org>
  15623. Reviewed by Darin Adler.
  15624. https://bugs.webkit.org/show_bug.cgi?id=25198
  15625. Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
  15626. in a USE(JSC), since it doesn't compile with V8 bindings.
  15627. * dom/RegisteredEventListener.h:
  15628. 2009-04-15 Eric Roman <eroman@chromium.org>
  15629. Reviewed by Darin Adler.
  15630. https://bugs.webkit.org/show_bug.cgi?id=25194
  15631. Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
  15632. use the new name.
  15633. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  15634. 2009-04-14 Alexey Proskuryakov <ap@webkit.org>
  15635. Rubber-stamped by Darin Adler.
  15636. Don't keep platform objects for authentication challenge in ResourceHandleInternal.
  15637. We already have a copy in AuthenticationChallenge object.
  15638. * platform/network/ResourceHandle.cpp:
  15639. (WebCore::ResourceHandle::clearAuthentication):
  15640. * platform/network/ResourceHandleInternal.h:
  15641. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  15642. * platform/network/cf/ResourceHandleCFNet.cpp:
  15643. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  15644. (WebCore::ResourceHandle::receivedCredential):
  15645. (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
  15646. (WebCore::ResourceHandle::receivedCancellation):
  15647. * platform/network/mac/ResourceHandleMac.mm:
  15648. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  15649. (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
  15650. (WebCore::ResourceHandle::receivedCredential):
  15651. (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
  15652. (WebCore::ResourceHandle::receivedCancellation):
  15653. 2009-04-14 Geoffrey Garen <ggaren@apple.com>
  15654. Reviewed by Sam Weinig.
  15655. Nixed some now-defunct autogeneration code.
  15656. * bindings/scripts/CodeGeneratorJS.pm:
  15657. 2009-04-14 Eric Carlson <eric.carlson@apple.com>
  15658. Reviewed by Alexey Proskuryakov.
  15659. Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
  15660. file:/// URLs from remote in Safari
  15661. Tests: http/tests/security/local-video-poster-from-remote.html
  15662. http/tests/security/local-video-source-from-remote.html
  15663. http/tests/security/local-video-src-from-remote.html
  15664. * html/HTMLMediaElement.cpp:
  15665. (WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine unless loader->canLoad()
  15666. says it is OK.
  15667. 2009-04-14 Sam Weinig <sam@webkit.org>
  15668. Reviewed by Darin Adler.
  15669. Part of <rdar://problem/6150868>
  15670. Fix incorrect handling of content that needs to go into the head element
  15671. once the head element has been removed.
  15672. Test: fast/parser/head-content-after-head-removal.html
  15673. * html/HTMLParser.cpp:
  15674. (WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head.
  15675. (WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr.
  15676. (WebCore::HTMLParser::createHead): Ditto.
  15677. * html/HTMLParser.h: Make m_head a RefPtr.
  15678. 2009-04-14 Geoffrey Garen <ggaren@apple.com>
  15679. Used svn merge -r42529:42528 to roll out my last patch because it broke
  15680. the build.
  15681. * bindings/js/JSDOMGlobalObject.cpp:
  15682. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
  15683. (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
  15684. (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
  15685. (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
  15686. (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
  15687. * bindings/js/JSDOMGlobalObject.h:
  15688. 2009-04-14 Geoffrey Garen <ggaren@apple.com>
  15689. Reviewed by Sam Weinig.
  15690. Nixed some now-dead code related to protected event listeners.
  15691. * bindings/js/JSDOMGlobalObject.cpp:
  15692. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
  15693. * bindings/js/JSDOMGlobalObject.h:
  15694. 2009-04-14 Geoffrey Garen <ggaren@apple.com>
  15695. Reviewed by Sam Weinig.
  15696. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  15697. Unbounded memory growth when churning elements with anonymous event handler functions
  15698. Stop using protected event listeners on SVGElementInstance.
  15699. * bindings/js/JSSVGElementInstanceCustom.cpp:
  15700. (WebCore::JSSVGElementInstance::mark): Mark our event listeners, since
  15701. they're not protected anymore.
  15702. (WebCore::JSSVGElementInstance::addEventListener):
  15703. (WebCore::JSSVGElementInstance::removeEventListener): Make unprotected
  15704. event listeners, since we mark them now.
  15705. * bindings/scripts/CodeGeneratorJS.pm: Autogenerate event listener
  15706. invalidation for SVGElementInstance.
  15707. * svg/SVGElementInstance.h:
  15708. (WebCore::SVGElementInstance::eventListeners): Added an accessor, for
  15709. the sake of autogenerated code.
  15710. * svg/SVGElementInstance.idl: Removed the ProtectedEventListener attribute
  15711. from event listener properties. Added a CustomMarkFunction attribute,
  15712. since we need to mark our event listeners.
  15713. 2009-04-14 Steve Falkenburg <sfalken@apple.com>
  15714. Windows build fix.
  15715. * WebCore.vcproj/WebCore.vcproj:
  15716. 2009-04-14 Steve Falkenburg <sfalken@apple.com>
  15717. Add header guards to WebCore forwarding headers.
  15718. Speeds up WebCore debug build on Windows by 12% on my system,
  15719. since Visual Studio appears to not optimize for standard header
  15720. guards in included files.
  15721. Rubber stamped by Ada Chan.
  15722. * ForwardingHeaders/debugger/Debugger.h:
  15723. * ForwardingHeaders/debugger/DebuggerActivation.h:
  15724. * ForwardingHeaders/debugger/DebuggerCallFrame.h:
  15725. * ForwardingHeaders/interpreter/CallFrame.h:
  15726. * ForwardingHeaders/interpreter/Interpreter.h:
  15727. * ForwardingHeaders/masm/X86Assembler.h:
  15728. * ForwardingHeaders/parser/Parser.h:
  15729. * ForwardingHeaders/parser/SourceCode.h:
  15730. * ForwardingHeaders/parser/SourceProvider.h:
  15731. * ForwardingHeaders/pcre/pcre.h:
  15732. * ForwardingHeaders/profiler/Profile.h:
  15733. * ForwardingHeaders/profiler/ProfileNode.h:
  15734. * ForwardingHeaders/profiler/Profiler.h:
  15735. * ForwardingHeaders/runtime/ArgList.h:
  15736. * ForwardingHeaders/runtime/ArrayPrototype.h:
  15737. * ForwardingHeaders/runtime/BooleanObject.h:
  15738. * ForwardingHeaders/runtime/CallData.h:
  15739. * ForwardingHeaders/runtime/Collector.h:
  15740. * ForwardingHeaders/runtime/CollectorHeapIterator.h:
  15741. * ForwardingHeaders/runtime/Completion.h:
  15742. * ForwardingHeaders/runtime/ConstructData.h:
  15743. * ForwardingHeaders/runtime/DateInstance.h:
  15744. * ForwardingHeaders/runtime/Error.h:
  15745. * ForwardingHeaders/runtime/FunctionConstructor.h:
  15746. * ForwardingHeaders/runtime/FunctionPrototype.h:
  15747. * ForwardingHeaders/runtime/Identifier.h:
  15748. * ForwardingHeaders/runtime/InitializeThreading.h:
  15749. * ForwardingHeaders/runtime/InternalFunction.h:
  15750. * ForwardingHeaders/runtime/JSArray.h:
  15751. * ForwardingHeaders/runtime/JSByteArray.h:
  15752. * ForwardingHeaders/runtime/JSFunction.h:
  15753. * ForwardingHeaders/runtime/JSGlobalData.h:
  15754. * ForwardingHeaders/runtime/JSGlobalObject.h:
  15755. * ForwardingHeaders/runtime/JSLock.h:
  15756. * ForwardingHeaders/runtime/JSNumberCell.h:
  15757. * ForwardingHeaders/runtime/JSObject.h:
  15758. * ForwardingHeaders/runtime/JSString.h:
  15759. * ForwardingHeaders/runtime/JSValue.h:
  15760. * ForwardingHeaders/runtime/Lookup.h:
  15761. * ForwardingHeaders/runtime/ObjectPrototype.h:
  15762. * ForwardingHeaders/runtime/Operations.h:
  15763. * ForwardingHeaders/runtime/PropertyMap.h:
  15764. * ForwardingHeaders/runtime/PropertyNameArray.h:
  15765. * ForwardingHeaders/runtime/Protect.h:
  15766. * ForwardingHeaders/runtime/PrototypeFunction.h:
  15767. * ForwardingHeaders/runtime/StringObject.h:
  15768. * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h:
  15769. * ForwardingHeaders/runtime/StringPrototype.h:
  15770. * ForwardingHeaders/runtime/Structure.h:
  15771. * ForwardingHeaders/runtime/SymbolTable.h:
  15772. * ForwardingHeaders/runtime/UString.h:
  15773. * ForwardingHeaders/wrec/WREC.h:
  15774. * ForwardingHeaders/wtf/ASCIICType.h:
  15775. * ForwardingHeaders/wtf/AlwaysInline.h:
  15776. * ForwardingHeaders/wtf/Assertions.h:
  15777. * ForwardingHeaders/wtf/ByteArray.h:
  15778. * ForwardingHeaders/wtf/CurrentTime.h:
  15779. * ForwardingHeaders/wtf/Deque.h:
  15780. * ForwardingHeaders/wtf/DisallowCType.h:
  15781. * ForwardingHeaders/wtf/FastMalloc.h:
  15782. * ForwardingHeaders/wtf/Forward.h:
  15783. * ForwardingHeaders/wtf/GetPtr.h:
  15784. * ForwardingHeaders/wtf/HashCountedSet.h:
  15785. * ForwardingHeaders/wtf/HashFunctions.h:
  15786. * ForwardingHeaders/wtf/HashMap.h:
  15787. * ForwardingHeaders/wtf/HashSet.h:
  15788. * ForwardingHeaders/wtf/HashTable.h:
  15789. * ForwardingHeaders/wtf/HashTraits.h:
  15790. * ForwardingHeaders/wtf/ListHashSet.h:
  15791. * ForwardingHeaders/wtf/ListRefPtr.h:
  15792. * ForwardingHeaders/wtf/Locker.h:
  15793. * ForwardingHeaders/wtf/MainThread.h:
  15794. * ForwardingHeaders/wtf/MathExtras.h:
  15795. * ForwardingHeaders/wtf/MessageQueue.h:
  15796. * ForwardingHeaders/wtf/Noncopyable.h:
  15797. * ForwardingHeaders/wtf/NotFound.h:
  15798. * ForwardingHeaders/wtf/OwnArrayPtr.h:
  15799. * ForwardingHeaders/wtf/OwnPtr.h:
  15800. * ForwardingHeaders/wtf/PassRefPtr.h:
  15801. * ForwardingHeaders/wtf/Platform.h:
  15802. * ForwardingHeaders/wtf/PtrAndFlags.h:
  15803. * ForwardingHeaders/wtf/RandomNumber.h:
  15804. * ForwardingHeaders/wtf/RefCounted.h:
  15805. * ForwardingHeaders/wtf/RefCountedLeakCounter.h:
  15806. * ForwardingHeaders/wtf/RefPtr.h:
  15807. * ForwardingHeaders/wtf/RetainPtr.h:
  15808. * ForwardingHeaders/wtf/StdLibExtras.h:
  15809. * ForwardingHeaders/wtf/StringExtras.h:
  15810. * ForwardingHeaders/wtf/ThreadSpecific.h:
  15811. * ForwardingHeaders/wtf/Threading.h:
  15812. * ForwardingHeaders/wtf/TypeTraits.h:
  15813. * ForwardingHeaders/wtf/UnusedParam.h:
  15814. * ForwardingHeaders/wtf/Vector.h:
  15815. * ForwardingHeaders/wtf/VectorTraits.h:
  15816. * ForwardingHeaders/wtf/dtoa.h:
  15817. * ForwardingHeaders/wtf/unicode/Collator.h:
  15818. * ForwardingHeaders/wtf/unicode/UTF8.h:
  15819. * ForwardingHeaders/wtf/unicode/Unicode.h:
  15820. * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h:
  15821. 2009-04-14 Sam Weinig <sam@webkit.org>
  15822. Reviewed by Adele Peterson.
  15823. Use a template function to generalize the way we create non-caching
  15824. JS function getters.
  15825. * bindings/js/JSDOMWindowCustom.cpp:
  15826. * bindings/js/JSDOMWindowCustom.h:
  15827. (WebCore::nonCachingStaticFunctionGetter):
  15828. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  15829. 2009-04-14 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
  15830. Reviewed by George Staikos.
  15831. https://bugs.webkit.org/show_bug.cgi?id=25099
  15832. When creating a QNetworkRequest make sure to populate the
  15833. CacheLoadControlAttribute with the value set by the ResourceRequest::cachePolicy() so that the cache will be used as WebKit expects.
  15834. * WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:
  15835. (tst_QWebPage::requestCache):
  15836. * platform/network/qt/ResourceRequestQt.cpp:
  15837. (WebCore::ResourceRequest::toNetworkRequest):
  15838. 2009-04-14 Timothy Hatcher <timothy@apple.com>
  15839. Fix a world leak caused by opening the Web Inspector. This was
  15840. a regression caused by the InspectorController becoming refcounted.
  15841. <rdar://problem/6782944>
  15842. Reviewed by Darin Adler.
  15843. * bindings/js/ScriptObject.cpp:
  15844. (WebCore::ScriptGlobalObject::get): Renamed to better match the
  15845. other functions.
  15846. (WebCore::ScriptGlobalObject::remove): Added. Deletes the property.
  15847. * bindings/js/ScriptObject.h:
  15848. * inspector/InspectorController.cpp:
  15849. (WebCore::InspectorController::~InspectorController): Do less work
  15850. at destruction time since the object lifetime is tied to JS GC.
  15851. Assert that inspectedPageDestroyed cleared everything needed.
  15852. (WebCore::InspectorController::inspectedPageDestroyed): Do most
  15853. of the work that ~InspectorController was doing.
  15854. (WebCore::InspectorController::scriptObjectReady): Renamed getObject.
  15855. 2009-04-14 Antony Sargent <asargent@chromium.org>
  15856. Reviewed by Dimitri Glazkov.
  15857. This is some cleanup motivated by the crash in http://crbug.com/9775 , which
  15858. happens because of calling window.open inside a window.onload handler.
  15859. These changes are just part of the fix, along with some asserts to help prevent
  15860. breakage on future changes.
  15861. https://bugs.webkit.org/show_bug.cgi?id=25132
  15862. * bindings/v8/V8EventListenerList.cpp:
  15863. (WebCore::V8EventListenerList::add):
  15864. (WebCore::V8EventListenerList::remove):
  15865. (WebCore::V8EventListenerList::clear):
  15866. * bindings/v8/V8EventListenerList.h:
  15867. (WebCore::V8EventListenerList::size):
  15868. 2009-04-14 Evan Martin <evan@chromium.org>
  15869. Reviewed by Darin Adler.
  15870. https://bugs.webkit.org/show_bug.cgi?id=25142
  15871. Fix a race that can occur between flex and the perl script that parses
  15872. its output.
  15873. * css/maketokenizer: Consume all input.
  15874. 2009-04-14 Rohit Rao <rohitrao@google.com>
  15875. Reviewed by Dan Bernstein.
  15876. https://bugs.webkit.org/show_bug.cgi?id=25184
  15877. Do not change the text color for selected text in Mac Chromium.
  15878. * rendering/RenderThemeChromiumMac.h:
  15879. (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors):
  15880. Now returns false, matching the behavior of Safari on Mac.
  15881. 2009-04-14 Justin Garcia <justin.garcia@apple.com>
  15882. Reviewed by Eric Seidel.
  15883. https://bugs.webkit.org/show_bug.cgi?id=25172
  15884. Extra partial layout during the first keypress in an empty block
  15885. Determining if a placeholder needs to be removed requires the creation of a VisiblePosition
  15886. which was triggering layout before we were finished modifying the DOM for the insert operation.
  15887. Find out if we need to remove a placeholder near the start of the operation, and if we do remember
  15888. where it's located. Then, later, remove it along with all of the other DOM operations we perform.
  15889. Renamed lineBreakExistsAtPosition to lineBreakExistsAtVisiblePosition and added a lineBreakExistsAtPosition
  15890. that takes in a Position. In InsertTextCommand, we can use the latter, since we normalize manually.
  15891. removePlaceholderAt now takes in a Position that it assumes has already been checked for a placeholder.
  15892. No test added as this only effects performance.
  15893. * editing/BreakBlockquoteCommand.cpp:
  15894. (WebCore::BreakBlockquoteCommand::doApply):
  15895. * editing/CompositeEditCommand.cpp:
  15896. (WebCore::CompositeEditCommand::removePlaceholderAt):
  15897. (WebCore::CompositeEditCommand::moveParagraphs):
  15898. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  15899. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  15900. * editing/CompositeEditCommand.h:
  15901. * editing/DeleteSelectionCommand.cpp:
  15902. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  15903. (WebCore::DeleteSelectionCommand::doApply):
  15904. * editing/FormatBlockCommand.cpp:
  15905. (WebCore::FormatBlockCommand::doApply):
  15906. * editing/InsertLineBreakCommand.cpp:
  15907. (WebCore::InsertLineBreakCommand::doApply):
  15908. * editing/InsertParagraphSeparatorCommand.cpp:
  15909. (WebCore::InsertParagraphSeparatorCommand::doApply):
  15910. * editing/InsertTextCommand.cpp:
  15911. (WebCore::InsertTextCommand::input):
  15912. * editing/htmlediting.cpp:
  15913. (WebCore::lineBreakExistsAtVisiblePosition):
  15914. (WebCore::lineBreakExistsAtPosition):
  15915. * editing/htmlediting.h:
  15916. 2009-04-14 Adam Roben <aroben@apple.com>
  15917. Remove support for profile-guided optimization on Windows
  15918. Rubber-stamped by Steve Falkenburg.
  15919. * WebCore.vcproj/WebCore.vcproj: Removed the Release_PGO
  15920. configuration.
  15921. 2009-04-14 Dmitry Titov <dimich@chromium.org>
  15922. Reviewed by Dimitri Glazkov.
  15923. https://bugs.webkit.org/show_bug.cgi?id=25163
  15924. Upstream fix for releasing v8 objects on worker thread termination in Chromium.
  15925. * bindings/v8/V8DOMMap.cpp:
  15926. (WebCore::domDataList): Now uses Vector instead of HashMap.
  15927. (WebCore::domDataListMutex):
  15928. (WebCore::ThreadSpecificDOMData::ThreadSpecificDOMData): remove usage of currentThread();
  15929. (WebCore::ThreadSpecificDOMData::~ThreadSpecificDOMData): ditto.
  15930. (WebCore::NonMainThreadSpecificDOMData::~NonMainThreadSpecificDOMData): moved call to removeAllDOMObjectsInCurrentThread() to ~WorkerScriptController.
  15931. (WebCore::handleWeakObjectInOwningThread):
  15932. (WebCore::derefDelayedObjects):
  15933. (WebCore::removeAllDOMObjectsInCurrentThread): not static anymore.
  15934. * bindings/v8/V8DOMMap.h:
  15935. * bindings/v8/WorkerContextExecutionProxy.cpp:
  15936. (WebCore::WorkerContextExecutionProxy::dispose): removed code that avoided dual-dereference of WorkerContext.
  15937. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): this ref() is countered in removeAllDOMObjectsInCurrentThread(), when the WorkerContext is removed from the v8 map.
  15938. * bindings/v8/WorkerScriptController.cpp:
  15939. (WebCore::WorkerScriptController::~WorkerScriptController):
  15940. 2009-04-14 Adam Roben <aroben@apple.com>
  15941. Fix Bug 25183: Split up WebCore.vcproj's settings into vsprops files
  15942. <https://bugs.webkit.org/show_bug.cgi?id=25183>
  15943. WebCore.vcproj now uses a set of .vsprops files to store most of its
  15944. settings.
  15945. Reviewed by Darin Adler.
  15946. * WebCore.vcproj/WebCore.vcproj: Moved settings from here into the new
  15947. .vsprops files.
  15948. * WebCore.vcproj/WebCoreCFNetwork.vsprops: Added. Contains settings
  15949. for ports that build against CFNetwork.
  15950. * WebCore.vcproj/WebCoreCG.vsprops: Added. Contains settings for ports
  15951. that build against CoreGraphics.
  15952. * WebCore.vcproj/WebCoreCURL.vsprops: Added. Contains settings for
  15953. ports that build against libcurl.
  15954. * WebCore.vcproj/WebCoreCairo.vsprops: Added. Contains settings for
  15955. ports that build against Cairo.
  15956. * WebCore.vcproj/WebCoreCommon.vsprops: Added. Contains settings
  15957. shared by all ports.
  15958. * WebCore.vcproj/WebCoreMediaQT.vsprops: Added. Contains settings for
  15959. ports that use QTMovieWin to implement the MediaPlayerPrivate
  15960. interface.
  15961. * WebCore.vcproj/WebCorePthreads.vsprops: Added. Contains settings for
  15962. ports that build against pthreads.
  15963. 2009-04-14 Alexey Proskuryakov <ap@webkit.org>
  15964. Reviewed by Darin Adler.
  15965. http/tests/xmlhttprequest/basic-auth.html fails on Tiger.
  15966. Turns out that NSURLCredentialPersistenceNone doesn't work on Tiger, so we have to use
  15967. session persistence.
  15968. * platform/network/mac/ResourceHandleMac.mm:
  15969. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Route the credential through
  15970. receivedCredential(), ensuring that the Tiger-specific need to use session credentials
  15971. is honored.
  15972. (WebCore::ResourceHandle::receivedCredential): On Tiger, change PersistenceNone to
  15973. PersistenceForSession, because the former doesn't work.
  15974. 2009-04-14 Adele Peterson <adele@apple.com>
  15975. Reviewed by Darin Adler.
  15976. Fix for <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
  15977. Test: editing/inserting/6703873.html
  15978. * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  15979. If the startNode's original parent is now empty, we can remove it. Its already been cloned and copied with the startNode,
  15980. so we only need to keep it around if it actually holds some original content, otherwise it will look like an extra empty
  15981. container in the document.
  15982. 2009-04-14 Xan Lopez <xlopez@igalia.com>
  15983. Reviewed by Holger Freyther.
  15984. https://bugs.webkit.org/show_bug.cgi?id=21546
  15985. [GTK] ATK accessibility enhancements
  15986. Add a proper implementation of AtkText::get_text and
  15987. AtkText::get_character_count, which takes into account non
  15988. TextControl text. With this the 'Text' field in Accerciser's
  15989. Interface Viewer is filled correctly.
  15990. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  15991. 2009-04-14 Xan Lopez <xlopez@igalia.com>
  15992. Reviewed by Holger Freyther.
  15993. https://bugs.webkit.org/show_bug.cgi?id=21546
  15994. [GTK] ATK accessibility enhancements
  15995. Remove some dead code and g_return_if_fail from static functions.
  15996. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  15997. 2009-04-14 Xan Lopez <xlopez@igalia.com>
  15998. Reviewed by Holger Freyther.
  15999. https://bugs.webkit.org/show_bug.cgi?id=21546
  16000. [GTK] ATK accessibility enhancements
  16001. Also implement text interface for StaticTextRole, which covers
  16002. most of the text in web pages.
  16003. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  16004. 2009-04-14 Alexey Proskuryakov <ap@webkit.org>
  16005. Another Windows build fix.
  16006. * platform/network/cf/ResourceHandleCFNet.cpp:
  16007. (WebCore::WebCoreSynchronousLoader::load):
  16008. 2009-04-14 Alexey Proskuryakov <ap@webkit.org>
  16009. Windows build fix.
  16010. * platform/network/cf/ResourceHandleCFNet.cpp:
  16011. (WebCore::WebCoreSynchronousLoader::willSendRequest):
  16012. (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  16013. 2009-04-13 Alexey Proskuryakov <ap@webkit.org>
  16014. Reviewed by Sam Weinig.
  16015. <rdar://problem/6698851> Implement XMLHttpRequest withCredentials attribute
  16016. * WebCore.xcodeproj/project.pbxproj: Made ThreadableLoader.h private, as enum definitions
  16017. from it are now used in otehr private headers.
  16018. * xml/XMLHttpRequest.h:
  16019. * xml/XMLHttpRequest.idl:
  16020. Added withCredentials attribute. When it is false (default), neither credentials nor cookies
  16021. are sent with cross origin requests, When it is true, those are sent, but the server needs
  16022. to allow handling results via Access-Control-Allow-Credentials header. It was always possible
  16023. to send a cross-site request with credentials via IFRAME or IMG, so this just adds a way to
  16024. read results, as long as the server reports that it's allowed.
  16025. Having the default set to false ensures that requests won't fail unexpectedly because of
  16026. stored credentials and cookies for other resources in the target protection space.
  16027. * xml/XMLHttpRequest.cpp:
  16028. (WebCore::XMLHttpRequest::loadRequestSynchronously): Allow stored credentials for same origin
  16029. requests, and for cross origin ones that have withCredentials attribute set. Such code already
  16030. existed for cookies (but it's simpler, because we could just set a ResourceRequest flag).
  16031. (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
  16032. * platform/network/ResourceHandle.h: Added willSendRequest() - just like for other callbacks,
  16033. is is easier to have code in the class. Also, loadResourceSynchronously() now takes a
  16034. StoredCredentials option, matching async case.
  16035. * platform/network/ResourceHandleClient.h:
  16036. (WebCore::ResourceHandleClient::receivedCredential): Removed. This method could never be
  16037. called, and no client used it.
  16038. (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): Ditto.
  16039. * platform/network/ResourceHandleInternal.h:
  16040. (WebCore::ResourceHandleInternal::ResourceHandleInternal): Split username and password out
  16041. of request URL. We want to always get a callback for credentials to manage them in WebCore,
  16042. so network back-end shouldn't see them too early.
  16043. * platform/network/ResourceRequestBase.cpp:
  16044. (WebCore::ResourceRequestBase::removeCredentials):
  16045. * platform/network/ResourceRequestBase.h:
  16046. Added a removeCredentials() method that removes login and password parts from request URL.
  16047. * platform/network/mac/ResourceHandleMac.mm:
  16048. (WebCoreCredentialStorage): Added a simple storage class for per-session credentials.
  16049. (WebCore::ResourceHandle::loadResourceSynchronously): Pass allowStoredCredentials through.
  16050. (WebCore::ResourceHandle::willSendRequest): On a redirect, credentials should be replaced.
  16051. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Try credentials from the URL
  16052. and per-session credentials. Code was partially moved from Obj-C callback.
  16053. (WebCore::ResourceHandle::receivedCredential): Intercept per-session credentials and store
  16054. them in WebCore storage.
  16055. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Don't
  16056. store the redirected URL - we only needed credentials, which are now stored separately.
  16057. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Removed
  16058. code that was setting credentials from URL. First, the code is now in ResourceHandle, and
  16059. also, it wasn't actually needed in Leopard release before this patch, see <rdar://problem/5298142>.
  16060. (-[WebCoreSynchronousLoader dealloc]): Release credentials. Note that unlike ResourceHandle,
  16061. this class still needs to track URL for checking whether a redirect is allowed. This is
  16062. not a great solution, and we should unify client code to use the same checks in sync and
  16063. async cases.
  16064. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Just like in
  16065. async case, put credentials aside to ensure that network back-end asks for them.
  16066. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use credentials
  16067. from URL, or from WebCore storage.
  16068. (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Don't use stored
  16069. credentials when not allowed to.
  16070. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
  16071. Put credentials aside to ensure that network back-end asks for them.
  16072. * platform/network/cf/ResourceHandleCFNet.cpp:
  16073. (WebCore::WebCoreCredentialStorage::set):
  16074. (WebCore::WebCoreCredentialStorage::get):
  16075. (WebCore::willSendRequest):
  16076. (WebCore::ResourceHandle::start):
  16077. (WebCore::ResourceHandle::willSendRequest):
  16078. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  16079. (WebCore::ResourceHandle::receivedCredential):
  16080. (WebCore::ResourceHandle::loadResourceSynchronously):
  16081. (WebCore::WebCoreSynchronousLoader::willSendRequest):
  16082. (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  16083. (WebCore::WebCoreSynchronousLoader::shouldUseCredentialStorage):
  16084. (WebCore::WebCoreSynchronousLoader::load):
  16085. Same changes as in Mac case.
  16086. * platform/network/curl/ResourceHandleCurl.cpp:
  16087. (WebCore::ResourceHandle::loadResourceSynchronously):
  16088. * platform/network/qt/ResourceHandleQt.cpp:
  16089. (WebCore::ResourceHandle::loadResourceSynchronously):
  16090. * platform/network/soup/ResourceHandleSoup.cpp:
  16091. (WebCore::ResourceHandle::loadResourceSynchronously):
  16092. Trying not to break the build.
  16093. * dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
  16094. * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  16095. Unconditionally allow stored credentials for these, as they only support same origin loads.
  16096. * workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  16097. WorkerContext.importScripts() can be cross-origin, but sending credentials with it is no worse
  16098. than sending them with <script src=...>, so this is also unconditionally allowed.
  16099. * loader/DocumentThreadableLoader.cpp:
  16100. (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Pass through storedCredentials.
  16101. (WebCore::DocumentThreadableLoader::create): Ditto.
  16102. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Save storedCredentials and
  16103. sameOrigin flags foruse in callbacks.
  16104. (WebCore::DocumentThreadableLoader::willSendRequest): Assert that loaders aren't all confused.
  16105. (WebCore::DocumentThreadableLoader::didSendData): Ditto.
  16106. (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
  16107. (WebCore::DocumentThreadableLoader::didReceiveData): Ditto.
  16108. (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
  16109. (WebCore::DocumentThreadableLoader::didFail): Ditto.
  16110. (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Don't use credential
  16111. storage if that's not allowed by the code that invoked DocumentThreadableLoader.
  16112. (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Simulate a failure
  16113. and cancel the request if we are about to ask the user for credentials for a cross-origin
  16114. request, which is forbidden by CORS (and would have been very confusing if allowed).
  16115. (WebCore::DocumentThreadableLoader::receivedCancellation): Assert that loaders aren't all confused.
  16116. * loader/DocumentThreadableLoader.h: Updated for the new flags (storedCredentials and
  16117. sameOrigin) that affect the loader. Eventually, we need to move all CORS logic from XHR here.
  16118. * loader/ThreadableLoader.h: (StoredCredentials): Added another flag that affects loader
  16119. behavior. We should combine all of these into a structure, and use it for sync requests, too.
  16120. * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
  16121. * loader/FrameLoader.h:
  16122. * loader/ThreadableLoader.cpp:
  16123. (WebCore::ThreadableLoader::create):
  16124. (WebCore::ThreadableLoader::loadResourceSynchronously):
  16125. * loader/WorkerThreadableLoader.cpp:
  16126. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  16127. (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
  16128. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  16129. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  16130. * loader/WorkerThreadableLoader.h:
  16131. (WebCore::WorkerThreadableLoader::create):
  16132. Pass through storedCredentials.
  16133. 2009-04-13 David Hyatt <hyatt@apple.com>
  16134. Reviewed by Cameron Zwarich.
  16135. Remove an outdated comment in ScrollView.h
  16136. * platform/ScrollView.h:
  16137. 2009-04-13 Eric Carlson <eric.carlson@apple.com>
  16138. Reviewed by Mark Rowe.
  16139. https://bugs.webkit.org/show_bug.cgi?id=25177
  16140. QTTrack's -media method always return NULL in 64-bit QTKit, so
  16141. MediaPlayerPrivate::disableUnsupportedTracks should use
  16142. QTTrackMediaTypeAttribute to get a track's type.
  16143. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  16144. (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
  16145. 2009-04-13 Geoffrey Garen <ggaren@apple.com>
  16146. Reviewed by Cameron Zwarich.
  16147. More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
  16148. Unbounded memory growth when churning elements with anonymous event handler functions
  16149. Stop using protected event listeners on the window object.
  16150. * bindings/js/JSDOMWindowCustom.cpp:
  16151. (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're
  16152. no longer protected.
  16153. (WebCore::JSDOMWindow::addEventListener):
  16154. (WebCore::JSDOMWindow::removeEventListener): Create unprotected event
  16155. listeners, since we mark them now.
  16156. * bindings/js/JSEventListener.h: Made some functions public so
  16157. DOMWindow could call them.
  16158. * bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header,
  16159. so it could be shared.
  16160. * bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking
  16161. and invalidating code for the DOMWindow.
  16162. * dom/RegisteredEventListener.h:
  16163. (WebCore::markEventListeners):
  16164. (WebCore::invalidateEventListeners): Added helper functions.
  16165. * page/DOMWindow.idl: Make the window's event listener attributes not
  16166. protected.
  16167. 2009-04-13 Eric Carlson <eric.carlson@apple.com>
  16168. Reviewed by Mark Rowe.
  16169. https://bugs.webkit.org/show_bug.cgi?id=25155
  16170. OS X standalone media documents should not switch from <video> to <embed> when
  16171. QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
  16172. with a slow network connection or when a movie is not saved fast-start.
  16173. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  16174. (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's
  16175. loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
  16176. 2009-04-13 Dmitry Titov <dimich@chromium.org>
  16177. Reviewed by Darin Adler.
  16178. https://bugs.webkit.org/show_bug.cgi?id=24453
  16179. REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
  16180. the main document that timer callback makes are not flushed.
  16181. * bindings/js/ScheduledAction.cpp:
  16182. (WebCore::ScheduledAction::execute):
  16183. Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded()
  16184. since timers may affect documents other then their own.
  16185. 2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  16186. Reviewed by David Hyatt.
  16187. Check document for nullity to avoid crashing on GTK+, when
  16188. creating the WebView.
  16189. * page/FrameView.cpp:
  16190. (WebCore::FrameView::needsLayout):
  16191. 2009-04-13 Ada Chan <adachan@apple.com>
  16192. Forgot to capitalize the "US".
  16193. * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
  16194. (WebCore::currentTextBreakLocaleID):
  16195. 2009-04-13 Ada Chan <adachan@apple.com>
  16196. <rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
  16197. Revert back to the old word breaking behavior by using en_US_POSIX locale.
  16198. Reviewed by Steve Falkenburg.
  16199. * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
  16200. (WebCore::currentTextBreakLocaleID):
  16201. 2009-04-13 Darin Adler <darin@apple.com>
  16202. Reviewed by Dan Bernstein.
  16203. * platform/cf/BinaryPropertyList.cpp: Added comment.
  16204. * platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
  16205. 2009-04-13 Darin Adler <darin@apple.com>
  16206. Reviewed by Dan Bernstein.
  16207. Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
  16208. https://bugs.webkit.org/show_bug.cgi?id=25158
  16209. rdar://problem/6769693
  16210. Test: editing/selection/click-after-nested-block.html
  16211. * rendering/RenderBlock.cpp:
  16212. (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint
  16213. can share code.
  16214. (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first
  16215. child box. Changed special case for last child box to propertly handle the various
  16216. types of child box that are not hit test candidates (the same ones already handled
  16217. by the hit test loop below), adding in a loop so we find the last candidate.
  16218. 2009-04-13 David Hyatt <hyatt@apple.com>
  16219. Reviewed by Sam Weinig.
  16220. Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
  16221. it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
  16222. * WebCore.base.exp:
  16223. * page/FrameView.h:
  16224. (WebCore::FrameView::visibleContentsResized):
  16225. * platform/ScrollView.cpp:
  16226. (WebCore::ScrollView::ScrollView):
  16227. (WebCore::ScrollView::updateScrollbars):
  16228. * platform/ScrollView.h:
  16229. 2009-04-13 Adam Roben <aroben@apple.com>
  16230. Add SharedBuffer::wrapCFData
  16231. This is the CF-equivalent of wrapNSData.
  16232. Reviewed by Brady Eidson.
  16233. * platform/SharedBuffer.h:
  16234. * platform/cf/SharedBufferCF.cpp:
  16235. (WebCore::SharedBuffer::wrapCFData):
  16236. 2009-04-13 Dan Bernstein <mitz@apple.com>
  16237. - build fix
  16238. * page/EventHandler.cpp:
  16239. (WebCore::documentPointForWindowPoint):
  16240. 2009-04-13 Antti Koivisto <antti@apple.com>
  16241. Reviewed by Darin Adler.
  16242. <rdar://problem/6740294> Increase the connection count per host
  16243. Try to use six connections per host if possible.
  16244. * WebCore.base.exp:
  16245. * loader/loader.cpp:
  16246. (WebCore::Loader::Loader):
  16247. * platform/mac/WebCoreSystemInterface.h:
  16248. * platform/mac/WebCoreSystemInterface.mm:
  16249. * platform/network/ResourceRequestBase.cpp:
  16250. (WebCore::initMaximumHTTPConnectionCountPerHost):
  16251. * platform/network/ResourceRequestBase.h:
  16252. * platform/network/mac/ResourceRequestMac.mm:
  16253. (WebCore::initMaximumHTTPConnectionCountPerHost):
  16254. 2009-04-13 Justin Garcia <justin.garcia@apple.com>
  16255. Reviewed by Adele Peterson.
  16256. https://bugs.webkit.org/show_bug.cgi?id=25153
  16257. Can't place the caret into text field that scrolls the window on focus
  16258. We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
  16259. be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
  16260. coordinate) and use that any time we refetch.
  16261. * page/EventHandler.cpp:
  16262. (WebCore::documentPointForWindowPoint):
  16263. (WebCore::EventHandler::handleMousePressEvent):
  16264. (WebCore::EventHandler::prepareMouseEvent):
  16265. 2009-04-13 Sam Weinig <sam@webkit.org>
  16266. Reviewed by Geoffrey Garen.
  16267. Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
  16268. to conform to our style guidelines.
  16269. * page/DOMWindow.cpp:
  16270. (WebCore::DOMWindow::allowPopUp):
  16271. * page/Settings.h:
  16272. (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
  16273. 2009-04-13 Geoffrey Garen <ggaren@apple.com>
  16274. Mac build fix: Made another header private.
  16275. * WebCore.xcodeproj/project.pbxproj:
  16276. 2009-04-13 Jian Li <jianli@chromium.org>
  16277. Reviewed by Darin Fisher.
  16278. https://bugs.webkit.org/show_bug.cgi?id=25121
  16279. Upstream changes to handle error messages from V8 when running worker script.
  16280. * bindings/v8/WorkerContextExecutionProxy.cpp:
  16281. (WebCore::reportFatalErrorInV8):
  16282. (WebCore::handleConsoleMessage):
  16283. (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
  16284. (WebCore::WorkerContextExecutionProxy::dispose):
  16285. (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
  16286. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
  16287. (WebCore::WorkerContextExecutionProxy::evaluate):
  16288. * bindings/v8/WorkerContextExecutionProxy.h:
  16289. 2009-04-13 Geoffrey Garen <ggaren@apple.com>
  16290. Build fix: Made setInlineEventListenerForType not inline, since Document
  16291. calls it now. Made RegisteredEventListener.h a private header on Mac,
  16292. so WebKit can use it.
  16293. * page/DOMWindow.cpp:
  16294. (WebCore::DOMWindow::setInlineEventListenerForType):
  16295. 2009-04-13 Dan Bernstein <mitz@apple.com>
  16296. Reviewed by Sam Weinig.
  16297. - fix <rdar://problem/6404439> REGRESSION: Overlapping text and other
  16298. layout issues in View Sample feature of MYOB FIrstEdge v3
  16299. * page/Navigator.cpp:
  16300. (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of
  16301. JavaScript files this quirk applies to.
  16302. 2009-04-13 Sam Weinig <sam@webkit.org>
  16303. Reviewed by Oliver Hunt.
  16304. Move open and showModalDialog functions out of JSDOMWindowBase
  16305. and into JSDOMWindow by partially generating them.
  16306. This slightly changes the behavior of getting window.showModalDialog
  16307. when the embedding app does not support it to return undefined regardless
  16308. of shadowing. This should not be an issue in a practice, but will be addressed
  16309. when we add a generic way to handle runtime specialization of property
  16310. access.
  16311. * DerivedSources.make: Remove JSDOMWindowBase.lut.h
  16312. * WebCore.xcodeproj/project.pbxproj: Ditto.
  16313. * bindings/js/JSDOMWindowBase.cpp:
  16314. (WebCore::):
  16315. (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from
  16316. here to JSDOMWindow::customGetOwnPropertySlot.
  16317. (WebCore::JSDOMWindowBase::put): Remove dead code.
  16318. * bindings/js/JSDOMWindowCustom.cpp:
  16319. (WebCore::createWindow):
  16320. (WebCore::JSDOMWindow::open):
  16321. (WebCore::JSDOMWindow::showModalDialog):
  16322. * bindings/js/JSDOMWindowCustom.h:
  16323. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  16324. * page/DOMWindow.cpp:
  16325. (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase.
  16326. (WebCore::DOMWindow::allowPopUp): Ditto.
  16327. (WebCore::DOMWindow::canShowModalDialog): Ditto.
  16328. (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
  16329. * page/DOMWindow.h:
  16330. * page/DOMWindow.idl:
  16331. 2009-04-13 Geoffrey Garen <ggaren@apple.com>
  16332. Reviewed by Sam Weinig.
  16333. Moved storage for window event listeners into the window object.
  16334. * bindings/js/JSDOMWindowCustom.cpp:
  16335. (WebCore::JSDOMWindow::addEventListener):
  16336. (WebCore::JSDOMWindow::removeEventListener): Add / remove window event
  16337. listeners to / from the window object.
  16338. * dom/Document.cpp:
  16339. (WebCore::Document::removeAllEventListeners):
  16340. (WebCore::Document::clear):
  16341. (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved
  16342. a bunch of code to the DOMWindow class, and left behind a few calls through
  16343. to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
  16344. * dom/Document.h: ditto.
  16345. * dom/Node.cpp:
  16346. (WebCore::Node::dispatchGenericEvent):
  16347. (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window
  16348. object, not the document.
  16349. * dom/Node.h:
  16350. * dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector
  16351. declaration, since it's required in more places now.
  16352. * history/CachedFrame.cpp:
  16353. (WebCore::CachedFrame::clear): Updated for rename. Also, remove event
  16354. listeners before detaching and clearing the document's window pointer,
  16355. since the the document needs its window pointer in order to tell the window
  16356. to clear its event listeners.
  16357. * loader/FrameLoader.cpp:
  16358. (WebCore::FrameLoader::stopLoading):
  16359. (WebCore::FrameLoader::canCachePageContainingThisFrame):
  16360. (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and
  16361. movement of window event listeners into the window.
  16362. * loader/ImageDocument.cpp:
  16363. (WebCore::ImageDocument::createDocumentStructure): Updated for movement
  16364. of window event listeners into the window.
  16365. * page/DOMWindow.cpp:
  16366. (WebCore::DOMWindow::handleEvent):
  16367. (WebCore::DOMWindow::addEventListener):
  16368. (WebCore::DOMWindow::removeEventListener):
  16369. (WebCore::DOMWindow::removeAllEventListeners):
  16370. (WebCore::DOMWindow::hasEventListener):
  16371. (WebCore::DOMWindow::setInlineEventListenerForType):
  16372. (WebCore::DOMWindow::removeInlineEventListenerForType):
  16373. (WebCore::DOMWindow::inlineEventListenerForType):
  16374. (WebCore::DOMWindow::addPendingFrameUnloadEventCount):
  16375. (WebCore::DOMWindow::removePendingFrameUnloadEventCount):
  16376. (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount):
  16377. (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
  16378. * page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
  16379. * page/Frame.cpp:
  16380. (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
  16381. 2009-04-13 Greg Bolsinga <bolsinga@apple.com>
  16382. Reviewed by Sam Weinig.
  16383. https://bugs.webkit.org/show_bug.cgi?id=25149
  16384. The Geolocation timer needs to start after the UA has granted permission.
  16385. * bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions>
  16386. (WebCore::JSGeolocation::getCurrentPosition):
  16387. (WebCore::JSGeolocation::watchPosition):
  16388. * page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used
  16389. later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions>
  16390. where needed.
  16391. (WebCore::Geolocation::GeoNotifier::GeoNotifier):
  16392. (WebCore::Geolocation::GeoNotifier::startTimer):
  16393. (WebCore::Geolocation::getCurrentPosition):
  16394. (WebCore::Geolocation::watchPosition):
  16395. (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows
  16396. (WebCore::Geolocation::startTimer):
  16397. (WebCore::Geolocation::startTimersForOneShots):
  16398. (WebCore::Geolocation::startTimersForWatchers):
  16399. (WebCore::Geolocation::startTimers):
  16400. * page/Geolocation.h:
  16401. (WebCore::Geolocation::GeoNotifier::create):
  16402. 2009-04-13 Pamela Greene <pam@chromium.org>
  16403. Reviewed by Darin Fisher.
  16404. Fix Chromium (V8) build by renaming methods to match changes
  16405. in http://trac.webkit.org/changeset/42377.
  16406. https://bugs.webkit.org/show_bug.cgi?id=25141
  16407. * bindings/v8/ScheduledAction.cpp:
  16408. (WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()
  16409. * bindings/v8/V8AbstractEventListener.cpp:
  16410. (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
  16411. 2009-04-13 Darin Fisher <darin@chromium.org>
  16412. Reviewed by Darin Adler.
  16413. https://bugs.webkit.org/show_bug.cgi?id=25136
  16414. CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
  16415. Test: fast/frames/frame-unload-crash.html
  16416. * loader/DocumentLoader.cpp:
  16417. (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
  16418. 2009-04-13 Sam Weinig <sam@webkit.org>
  16419. Reviewed by Tim Hatcher.
  16420. Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.
  16421. * page/DOMWindow.idl:
  16422. 2009-04-13 Greg Bolsinga <bolsinga@apple.com>
  16423. Fix GTK build break.
  16424. * platform/gtk/GeolocationServiceGtk.cpp:
  16425. (WebCore::GeolocationServiceGtk::updatePosition):
  16426. 2009-04-13 David Hyatt <hyatt@apple.com>
  16427. Reviewed by Darin Adler and Dan Bernstein.
  16428. Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
  16429. the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
  16430. Schedule a style recalc if needed when an object comes out of the page cache.
  16431. * dom/Document.cpp:
  16432. (WebCore::Document::scheduleStyleRecalc):
  16433. (WebCore::Document::setInPageCache):
  16434. 2009-04-13 Timothy Hatcher <timothy@apple.com>
  16435. Correctly sort (program) scripts in the Scripts panel popup menu.
  16436. Reviewed by Ada Chan.
  16437. * inspector/front-end/ScriptsPanel.js:
  16438. (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code
  16439. and sort "(program)" options by the sourceID to maintain some order.
  16440. * inspector/front-end/utilities.js:
  16441. (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause
  16442. an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction.
  16443. Just set 'first' and break so the correct result will be returned.
  16444. 2009-04-13 Greg Bolsinga <bolsinga@apple.com>
  16445. Reviewed by Darin Adler.
  16446. https://bugs.webkit.org/show_bug.cgi?id=24770
  16447. Add custom code for Coordinates that returns null when required by the
  16448. Geolocation spec.
  16449. http://dev.w3.org/geo/api/spec-source.html#coordinates
  16450. * WebCore.xcodeproj/project.pbxproj:
  16451. * bindings/js/JSCoordinatesCustom.cpp: Added.
  16452. (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided.
  16453. (WebCore::JSCoordinates::altitudeAccuracy): Ditto
  16454. (WebCore::JSCoordinates::heading): Ditto
  16455. (WebCore::JSCoordinates::speed): Ditto
  16456. * page/Coordinates.h:
  16457. (WebCore::Coordinates::create): Add 'canProvide' parameters and values
  16458. (WebCore::Coordinates::canProvideAltitude):
  16459. (WebCore::Coordinates::canProvideAltitudeAccuracy):
  16460. (WebCore::Coordinates::canProvideHeading):
  16461. (WebCore::Coordinates::canProvideSpeed):
  16462. (WebCore::Coordinates::Coordinates):
  16463. * page/Coordinates.idl: specify custom getters
  16464. * platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided.
  16465. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
  16466. 2009-04-13 Adele Peterson <adele@apple.com>
  16467. Reviewed by Darin Adler.
  16468. Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
  16469. Test: editing/inserting/5510537.html
  16470. * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position
  16471. is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break
  16472. insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level
  16473. so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.
  16474. 2009-04-11 Darin Adler <darin@apple.com>
  16475. Reviewed by Dan Bernstein.
  16476. Fix problem when encoding history files with duplicate integer arrays near the end of the file.
  16477. This results in an assertion failure, and if assertions are turned off, corrupted output.
  16478. When writing an integer array it's important not to add an object reference to the
  16479. aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
  16480. more importantly, it's possible this instance integer array is a duplicate and won't be
  16481. written out. If so, there's no guarantee there's enough space in the aggregate buffer to
  16482. store the object references (the references will be ignored). In some cases the aggregate
  16483. buffer can then overrun the data being written; normally this is prevented by the fact that
  16484. the data being written will include a copy of the aggregate buffer.
  16485. Also removed a bit of unneeded dead code to handle the integer -1.
  16486. * platform/cf/BinaryPropertyList.cpp:
  16487. (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded
  16488. m_integerNegativeOneObjectReference, since property lists support only non-negative integers.
  16489. (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for
  16490. m_integerNegativeOneObjectReference.
  16491. (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto.
  16492. (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference):
  16493. Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling
  16494. addAggregateObjectReference.
  16495. (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new
  16496. writeIntegerWithoutAddingAggregateObjectReference function.
  16497. (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new
  16498. writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the
  16499. code to save and restore m_currentAggregateBufferByte, which is no longer needed.
  16500. 2009-04-13 Holger Hans Peter Freyther <zecke@selfish.org>
  16501. Unreviewed Qt build fix.
  16502. * platform/graphics/qt/FontQt.cpp:
  16503. (WebCore::Font::floatWidthForComplexText):
  16504. 2009-04-12 Sam Weinig <sam@webkit.org>
  16505. Reviewed by Mark Rowe.
  16506. Move the event and crypto attributes and the captureEvents and releaseEvents
  16507. functions out of JSDOMWindowBase by partially generating them.
  16508. * bindings/js/JSDOMGlobalObject.cpp:
  16509. (WebCore::JSDOMGlobalObject::currentEvent): Make const.
  16510. * bindings/js/JSDOMGlobalObject.h:
  16511. * bindings/js/JSDOMWindowBase.cpp:
  16512. * bindings/js/JSDOMWindowCustom.cpp:
  16513. (WebCore::JSDOMWindow::crypto): Not implemented.
  16514. (WebCore::JSDOMWindow::event):
  16515. (WebCore::JSDOMWindow::captureEvents): Not implemented.
  16516. (WebCore::JSDOMWindow::releaseEvents): Ditto.
  16517. * page/DOMWindow.idl:
  16518. 2009-04-12 Sam Weinig <sam@webkit.org>
  16519. Reviewed by Mark Rowe.
  16520. Move more attributes out of JSDOMWindowBase by
  16521. partially generating them.
  16522. - Expose the MessagePort constructor.
  16523. * bindings/js/JSDOMGlobalObject.h:
  16524. (WebCore::getDOMConstructor):
  16525. * bindings/js/JSDOMWindowBase.cpp:
  16526. (setJSDOMWindowBaseEvent):
  16527. * bindings/js/JSDOMWindowCustom.cpp:
  16528. (WebCore::JSDOMWindow::image):
  16529. (WebCore::JSDOMWindow::option):
  16530. (WebCore::JSDOMWindow::audio):
  16531. (WebCore::JSDOMWindow::webKitPoint):
  16532. (WebCore::JSDOMWindow::webKitCSSMatrix):
  16533. (WebCore::JSDOMWindow::xMLHttpRequest):
  16534. (WebCore::JSDOMWindow::xSLTProcessor):
  16535. (WebCore::JSDOMWindow::messageChannel):
  16536. (WebCore::JSDOMWindow::worker):
  16537. * page/DOMWindow.idl:
  16538. 2009-04-12 Timothy Hatcher <timothy@apple.com>
  16539. A resource's filename is not correct after a redirect in the Inspector.
  16540. Reviewed by Dan Bernstein.
  16541. * inspector/InspectorResource.cpp:
  16542. (WebCore::InspectorResource::updateScriptObject): Fix a typo in the
  16543. lastPathComponent property name.
  16544. 2009-04-12 Adele Peterson <adele@apple.com>
  16545. Reviewed by Darin Adler.
  16546. Test: editing/inserting/6609479-1.html
  16547. Follow-up to <rdar://problem/6609479>.
  16548. Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
  16549. was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
  16550. at the start of a paragraph.
  16551. * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):
  16552. 2009-04-11 Adele Peterson <adele@apple.com>
  16553. Reviewed by Dan Bernstein.
  16554. Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
  16555. Test: editing/inserting/6609479.html
  16556. Don't break a blockquote if pasting or inserting into a table.
  16557. * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  16558. * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
  16559. 2009-04-11 Dan Bernstein <mitz@apple.com>
  16560. Reviewed by Darin Adler.
  16561. - fix <rdar://problem/6643103> Unscaled values from body.scrollHeight
  16562. Test: fast/css/zoom-body-scroll.html
  16563. Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
  16564. setters.
  16565. * html/HTMLBodyElement.cpp:
  16566. (WebCore::adjustForZoom):
  16567. (WebCore::HTMLBodyElement::scrollLeft):
  16568. (WebCore::HTMLBodyElement::setScrollLeft):
  16569. (WebCore::HTMLBodyElement::scrollTop):
  16570. (WebCore::HTMLBodyElement::setScrollTop):
  16571. (WebCore::HTMLBodyElement::scrollHeight):
  16572. (WebCore::HTMLBodyElement::scrollWidth):
  16573. 2009-04-10 Timothy Hatcher <timothy@apple.com>
  16574. Allow page navigation and reload while stopped at a breakpoint.
  16575. <rdar://problem/6781108> Having a breakpoint active prevents page reload
  16576. Reviewed by Darin Adler.
  16577. * inspector/InspectorController.cpp:
  16578. (WebCore::InspectorController::didContinue): Call the resumedScript function.
  16579. * inspector/InspectorController.h: Added didContinue.
  16580. * inspector/JavaScriptDebugListener.h: Ditto.
  16581. * inspector/JavaScriptDebugServer.cpp:
  16582. (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
  16583. * inspector/front-end/ScriptsPanel.js:
  16584. (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
  16585. * inspector/front-end/inspector.js:
  16586. (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
  16587. * loader/FrameLoader.cpp:
  16588. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
  16589. 2009-04-10 Sam Weinig <sam@webkit.org>
  16590. Reviewed by Adele Peterson.
  16591. Remove unused include for JSLock.
  16592. * page/mac/FrameMac.mm:
  16593. 2009-04-10 Sam Weinig <sam@webkit.org>
  16594. Reviewed by Darin Adler.
  16595. Add back the keepAlive timer for after the script execution to
  16596. protect the callers of evaluate, as was part of the original intent
  16597. of timer.
  16598. * bindings/js/ScriptController.cpp:
  16599. (WebCore::ScriptController::evaluate):
  16600. * page/mac/FrameMac.mm:
  16601. 2009-04-10 Chris Marrin <cmarrin@apple.com>
  16602. Reviewed by Simon Fraser.
  16603. Fixed https://bugs.webkit.org/show_bug.cgi?id=25137
  16604. If we reload, the animation controller sticks around and has
  16605. a stale animation time. So the needed delay is computed wrong.
  16606. I added a reset of the animation timer on load.
  16607. I did not do a test case because this only happens on reload so I
  16608. couldn't make an automated test. I tried using an iframe and using
  16609. reload() but that doesn't tickle the bug.
  16610. * dom/Document.cpp:
  16611. (WebCore::Document::implicitOpen):
  16612. 2009-04-10 Grace Kloba <klobag@gmail.com>
  16613. Reviewed by Darin Adler.
  16614. Move WORKERS header files inside ENABLE(WORKERS).
  16615. So if WORKERS is not enabled and the generated files are not generated, the build is still working.
  16616. * bindings/js/JSDOMGlobalObject.cpp:
  16617. * bindings/js/JSMessageChannelConstructor.cpp:
  16618. * bindings/js/ScheduledAction.cpp:
  16619. 2009-04-10 Darin Adler <darin@apple.com>
  16620. Reviewed by Brady Eidson.
  16621. <rdar://problem/6773515> crash in push_heap inside WebCore when printing
  16622. The crash was due to manipulating a timer on a different thread than the one it was created on.
  16623. This adds some diagnostics so we'll catch that kind of mistake immediately.
  16624. * platform/Timer.cpp:
  16625. (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions.
  16626. (WebCore::TimerBase::start): Assert it's the same thread the timer was created on.
  16627. (WebCore::TimerBase::stop): Ditto.
  16628. (WebCore::TimerBase::isActive): Ditto.
  16629. (WebCore::TimerBase::setNextFireTime): Ditto.
  16630. * platform/Timer.h: Added the thread identifier data member.
  16631. 2009-04-10 Chris Marrin <cmarrin@apple.com>
  16632. Reviewed by Dan Bernstein
  16633. https://bugs.webkit.org/show_bug.cgi?id=25108
  16634. If you remove a class with a transition while that transition is running
  16635. the animation timer will continue to fire after the transition is finished.
  16636. This has no visual indication, but it does drain the processor. And in some
  16637. cases it might even cause a glitch in future animations. Unfortunately there
  16638. is no way to test this without putting in printfs.
  16639. This happens because the animation logic is never traversed after a transition
  16640. is removed, so we never get a chance to cleanup. So I added cleanup in the logic
  16641. that fires the dispatch of the last style change when the animation finishes.
  16642. Test: transitions/remove-transition-style.html
  16643. * page/animation/AnimationController.cpp:
  16644. (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  16645. * page/animation/CompositeAnimation.cpp:
  16646. (WebCore::CompositeAnimation::updateTransitions):
  16647. (WebCore::CompositeAnimation::animate):
  16648. (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  16649. * page/animation/CompositeAnimation.h:
  16650. 2009-04-10 Sam Weinig <sam@webkit.org>
  16651. Reviewed by Geoffrey Garen.
  16652. Fix for <rdar://problem/6648858>
  16653. CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241
  16654. The Frame (and therefore ScriptController) were being destroyed
  16655. during JavaScript execution causing the JSDOMWindowShell to become
  16656. null.
  16657. * bindings/js/ScriptController.cpp:
  16658. (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame
  16659. instead of the keep-alive timer, since a nested event loop used from with-in
  16660. JavaScript execution could cause the timer to fire before returning.
  16661. 2009-04-10 Dimitri Glazkov <dglazkov@chromium.org>
  16662. Reviewed by Timothy Hatcher.
  16663. https://bugs.webkit.org/show_bug.cgi?id=25133
  16664. Fix an error in InspectorController's bindings, clean up a few header
  16665. includes, make empty object construction in ScriptObject less ambiguous.
  16666. * bindings/js/JSInspectorControllerCustom.cpp:
  16667. (WebCore::JSInspectorController::setSetting): Send correct argument from
  16668. the bindings.
  16669. * bindings/js/ScriptObject.cpp:
  16670. (WebCore::ScriptObject::createNew): Added.
  16671. * bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
  16672. * inspector/ConsoleMessage.cpp: Remove unused header.
  16673. * inspector/ConsoleMessage.h: Ditto.
  16674. * inspector/InspectorResource.cpp:
  16675. (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
  16676. 2009-04-10 Chris Marrin <cmarrin@apple.com>
  16677. Reviewed by Simon Fraser.
  16678. Fixed https://bugs.webkit.org/show_bug.cgi?id=25134
  16679. This both fixes a bug where I was not sending in the right time
  16680. to continue the animation and was not recomputing current time
  16681. when coming out of suspend.
  16682. * page/animation/AnimationBase.cpp:
  16683. (WebCore::AnimationBase::updateStateMachine):
  16684. * page/animation/AnimationController.cpp:
  16685. (WebCore::AnimationControllerPrivate::suspendAnimations):
  16686. (WebCore::AnimationControllerPrivate::resumeAnimations):
  16687. 2009-04-10 Adam Roben <aroben@apple.com>
  16688. Give Windows's <select> popup menus drop shadows
  16689. Rubber-stamped by Steve Falkenburg.
  16690. No test possible.
  16691. * platform/win/PopupMenuWin.cpp:
  16692. (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
  16693. 2009-04-10 Timothy Hatcher <timothy@apple.com>
  16694. Fix a bug in the Web Inspector where it would show scripts
  16695. from previous pages when toggling the debugger off and back on.
  16696. https://bugs.webkit.org/show_bug.cgi?id=25095
  16697. rdar://problem/6769970
  16698. Reviewed by John Sullivan.
  16699. * bindings/js/ScriptCachedFrameData.cpp:
  16700. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the
  16701. debugger for the scriptController. This balances the attachDebugger
  16702. that was already in ScriptCachedFrameData::restore.
  16703. (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
  16704. * bindings/js/ScriptController.cpp:
  16705. (WebCore::ScriptController::clearWindowShell): Clear the debugger from
  16706. the current window before setting the new window.
  16707. * inspector/JavaScriptDebugServer.cpp:
  16708. (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate
  16709. source providers for code associated this as the debugger.
  16710. 2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>
  16711. Reviewed by Adele Peterson.
  16712. <rdar://problem/6646998> Avoid starting QTKitServer if possible
  16713. When possible avoid asking QTKit for the MIME types that require QTKitServer
  16714. when running 64-bit.
  16715. * WebCore.base.exp: Added new entry point.
  16716. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  16717. (WebCore::addFileTypesToCache): Add an NSArray of types to the cache.
  16718. (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache.
  16719. (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does
  16720. not start QTKitServer if it is not already running).
  16721. (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored.
  16722. (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid
  16723. starting QTKitServer if possible.
  16724. * platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
  16725. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  16726. 2009-04-10 Adam Roben <aroben@apple.com>
  16727. Turn on window animations for <select> popup menus
  16728. We turned these off back when <select> popup menus were partially
  16729. transparent. Now that they're opaque, there's no reason not to
  16730. animate them.
  16731. Reviewed by Steve Falkenburg.
  16732. No test possible.
  16733. * platform/win/PopupMenuWin.cpp:
  16734. (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the
  16735. window animation.
  16736. 2009-04-10 Dan Bernstein <mitz@apple.com>
  16737. Reviewed by Sam Weinig.
  16738. - fix a regression from r42379 which made zero-width characters affect
  16739. line height
  16740. Test: fixes fast/text/wide-zero-width-space.html
  16741. * platform/graphics/mac/FontMacATSUI.mm:
  16742. (WebCore::overrideLayoutOperation): Add to the fallback font list set
  16743. here, and only if the glyph is not zero-width...
  16744. (WebCore::ATSULayoutParameters::initialize): ...instead of doing it
  16745. here. This matches WidthIterator's behavior.
  16746. 2009-04-10 Darin Fisher <darin@chromium.org>
  16747. Fixing build bustage caused by warnings being treated as errors.
  16748. 1- A local variable was only be used inside a debug assertion, which
  16749. caused grief for the release build.
  16750. 2- Missing initializer for member 'DocumentMarker::activeMatch'
  16751. * dom/Document.cpp:
  16752. (WebCore::Document::addMarker):
  16753. (WebCore::Document::setMarkersActive):
  16754. 2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>
  16755. Reviewed by John Sullivan.
  16756. Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
  16757. (TextMatches don't have a concept of active match)
  16758. For the ports that use the DocumentMarker as highlighting for FindInPage it is
  16759. useful to have a flag that specifies which marker is active, so it can be drawn
  16760. in a different color.
  16761. This allows me to remove the hack to use the SelectionController to highlight
  16762. the active match (in the ChromiumWin port).
  16763. * dom/Document.cpp:
  16764. (WebCore::Document::setMarkersActive):
  16765. * dom/Document.h:
  16766. * dom/DocumentMarker.h:
  16767. * rendering/InlineTextBox.cpp:
  16768. (WebCore::InlineTextBox::paintTextMatchMarker):
  16769. * rendering/RenderTheme.cpp:
  16770. (WebCore::RenderTheme::platformActiveTextSearchHighlightColor):
  16771. (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
  16772. * rendering/RenderTheme.h:
  16773. * rendering/RenderThemeChromiumWin.cpp:
  16774. (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
  16775. (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
  16776. (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor):
  16777. (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
  16778. * rendering/RenderThemeChromiumWin.h:
  16779. 2009-04-10 Pamela Greene <pam@chromium.org>
  16780. Reviewed by Dimitri Glazkov.
  16781. Build fix for Chromium.
  16782. https://bugs.webkit.org/show_bug.cgi?id=12440
  16783. * page/chromium/FrameChromium.cpp:
  16784. (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
  16785. 2009-04-09 David Hyatt <hyatt@apple.com>
  16786. Reviewed by Oliver Hunt
  16787. Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order
  16788. to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
  16789. following DOM events and JavaScript timeouts. Eventually these calls will be removed.
  16790. Where the timer will really kick in and be useful is for clients that do style changes from
  16791. Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.
  16792. * dom/ContainerNode.cpp:
  16793. (WebCore::ContainerNode::insertBefore):
  16794. (WebCore::ContainerNode::replaceChild):
  16795. (WebCore::ContainerNode::removeChild):
  16796. (WebCore::ContainerNode::appendChild):
  16797. * dom/Document.cpp:
  16798. (WebCore::Document::Document):
  16799. (WebCore::Document::~Document):
  16800. (WebCore::Document::scheduleStyleRecalc):
  16801. (WebCore::Document::unscheduleStyleRecalc):
  16802. (WebCore::Document::styleRecalcTimerFired):
  16803. (WebCore::Document::updateStyleForAllDocuments):
  16804. (WebCore::Document::detach):
  16805. * dom/Document.h:
  16806. * dom/Node.cpp:
  16807. (WebCore::Node::setNeedsStyleRecalc):
  16808. (WebCore::Node::lazyAttach):
  16809. 2009-04-09 Oliver Hunt <oliver@apple.com>
  16810. Reviewed by Gavin Barraclough.
  16811. <rdar://problem/6586787> JS debugger does not work in 64-bit
  16812. Don't truncate the source id in JSCallFrame
  16813. * inspector/JavaScriptCallFrame.h:
  16814. 2009-04-09 Adam Roben <aroben@apple.com>
  16815. Start compiling HistoryPropertyList on Windows
  16816. Reviewed by Darin Adler.
  16817. * WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its
  16818. dependencies to the project. Copy headers from history/cf to
  16819. $WebKitOutputDir.
  16820. * history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that
  16821. this file will compile on Windows.
  16822. 2009-04-09 Dan Bernstein <mitz@apple.com>
  16823. Reviewed by Dave Hyatt.
  16824. - fix <rdar://problem/6166612> Text boxes' metrics should be based on
  16825. the actual fonts used in them, not just the primary font
  16826. Covered by many existing layout tests
  16827. * platform/graphics/Font.cpp:
  16828. (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the
  16829. platform supports collecting fallback fonts in its complex font path
  16830. and fallbackFonts is not null, all fallback fonts used for the text run
  16831. will be added to it.
  16832. * platform/graphics/Font.h:
  16833. (WebCore::Font::width): Ditto.
  16834. * platform/graphics/FontFastPath.cpp:
  16835. (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace
  16836. qualifier.
  16837. (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts
  16838. parameter, which is passed down to WidthIterator.
  16839. * platform/graphics/WidthIterator.cpp:
  16840. (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter
  16841. and used it to initialize the m_fallbackFonts member.
  16842. (WebCore::WidthIterator::advance): Track the fonts being used and add
  16843. any fallback fonts to the m_fallbackFonts set. Make sure to only add
  16844. non-small-caps fonts.
  16845. * platform/graphics/WidthIterator.h:
  16846. * platform/graphics/chromium/FontChromiumWin.cpp:
  16847. (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
  16848. implementation that returns false, meaning this platform's
  16849. implementation of floatWidthForComplexText() does not populate the
  16850. fallbackFonts set.
  16851. (WebCore::Font::floatWidthForComplexText): Updated for the new
  16852. prototype.
  16853. * platform/graphics/chromium/FontLinux.cpp: Ditto.
  16854. * platform/graphics/gtk/FontGtk.cpp: Ditto.
  16855. * platform/graphics/mac/CoreTextController.cpp:
  16856. (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts
  16857. parameter and used it to initialize the m_fallbackFonts member.
  16858. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add
  16859. fallback fonts to m_fallbackFonts.
  16860. * platform/graphics/mac/CoreTextController.h:
  16861. * platform/graphics/mac/FontMac.mm:
  16862. (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
  16863. implementation that returns true, indicating that the Mac
  16864. implementations of floatWidthForComplexText() populate the fallbackFonts
  16865. set.
  16866. * platform/graphics/mac/FontMacATSUI.mm:
  16867. (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a
  16868. fallbackFonts parameter and used it to initialize the m_fallbackFonts
  16869. member.
  16870. (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to
  16871. m_fallbackFonts.
  16872. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
  16873. parameter, which is passed down to ATSULayoutParameters.
  16874. * platform/graphics/mac/FontMacCoreText.cpp:
  16875. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
  16876. parameter, which is passed down to CoreTextController.
  16877. * platform/graphics/win/FontWin.cpp:
  16878. (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
  16879. implementation that returns true, indicating that the
  16880. UniscribeController-based implementations of floatWidthForComplexText()
  16881. populate the fallbackFonts set.
  16882. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
  16883. parameter, which is passed down to UniscribeController.
  16884. * platform/graphics/win/UniscribeController.cpp:
  16885. (WebCore::UniscribeController::UniscribeController): Added a
  16886. fallbackfonts parameter and used it to initialize m_fallbackFonts.
  16887. (WebCore::UniscribeController::advance): Add fallback fonts to
  16888. m_fallbackFonts.
  16889. * platform/graphics/win/UniscribeController.h:
  16890. * platform/graphics/wx/FontWx.cpp:
  16891. (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
  16892. implementation that returns false, meaning this platform's
  16893. implementation of floatWidthForComplexText() does not populate the
  16894. fallbackFonts set.
  16895. (WebCore::Font::floatWidthForComplexText): Updated for the new
  16896. prototype.
  16897. * rendering/InlineFlowBox.cpp:
  16898. (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox
  16899. with multiple fonts, compute a common baseline and line height by
  16900. considering all fonts' ascents and descents (and line spacing, if
  16901. applicable).
  16902. * rendering/InlineTextBox.cpp:
  16903. (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores
  16904. the set of fallback fonts in a vector.
  16905. (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback
  16906. fonts previously stored and removes them from storage.
  16907. * rendering/InlineTextBox.h:
  16908. * rendering/RenderText.cpp:
  16909. (WebCore::RenderText::RenderText): Initialized the
  16910. m_knownNotToUseFallbackFonts to false.
  16911. (WebCore::RenderText::styleDidChange): Reset
  16912. m_knownNotToUseFallbackFonts to false if the style difference is such that
  16913. affects layout.
  16914. (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter,
  16915. which is passed down to Font::width().
  16916. (WebCore::RenderText::trimmedPrefWidths): Updated for the change to
  16917. widthFromCache().
  16918. (WebCore::RenderText::calcPrefWidths): Made this call a private version
  16919. of calcPrefWidths() that takes a fallbackFonts parameter and set the
  16920. m_knownNotToUseFallbackFonts to true if the set comes back empty.
  16921. The private version passes the fallbackFonts set to widthFromCache().
  16922. (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to
  16923. false.
  16924. (WebCore::RenderText::createFallbackFontMetricsBox): Added.
  16925. (WebCore::RenderText::width): Added a fallbackFonts parameter, which is
  16926. passed down to calcPrefWidths(), widthFromCache() and Font::width().
  16927. Set m_knownNotToUseFallbackFonts to true when appropriate.
  16928. * rendering/RenderText.h:
  16929. * rendering/bidi.cpp:
  16930. (WebCore::RenderBlock::constructLine): Added an assertion and a continue
  16931. statement to remove one level of indentation.
  16932. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily
  16933. store the set of fallback fonts in the InlineTextBox.
  16934. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an
  16935. assertion.
  16936. 2009-04-09 David Hyatt <hyatt@apple.com>
  16937. Reviewed by Adam Roben
  16938. Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
  16939. explicitly instead.
  16940. * bindings/js/JSCustomPositionCallback.cpp:
  16941. (WebCore::JSCustomPositionCallback::handleEvent):
  16942. * bindings/js/JSCustomPositionErrorCallback.cpp:
  16943. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  16944. * bindings/js/JSCustomSQLStatementCallback.cpp:
  16945. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  16946. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  16947. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  16948. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  16949. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  16950. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  16951. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  16952. * bindings/js/JSCustomVoidCallback.cpp:
  16953. (WebCore::JSCustomVoidCallback::handleEvent):
  16954. * bindings/js/JSCustomXPathNSResolver.cpp:
  16955. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  16956. * bindings/js/JSEventListener.cpp:
  16957. (WebCore::JSAbstractEventListener::handleEvent):
  16958. * bindings/js/ScheduledAction.cpp:
  16959. (WebCore::ScheduledAction::execute):
  16960. * bindings/js/ScriptControllerMac.mm:
  16961. (WebCore::updateStyleIfNeededForBindings):
  16962. (WebCore::ScriptController::initJavaJSBindings):
  16963. * css/CSSMutableStyleDeclaration.cpp:
  16964. (WebCore::CSSMutableStyleDeclaration::removeProperty):
  16965. (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
  16966. (WebCore::CSSMutableStyleDeclaration::setProperty):
  16967. (WebCore::CSSMutableStyleDeclaration::setStringProperty):
  16968. (WebCore::CSSMutableStyleDeclaration::setImageProperty):
  16969. (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
  16970. (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
  16971. (WebCore::CSSMutableStyleDeclaration::setCssText):
  16972. (WebCore::CSSMutableStyleDeclaration::merge):
  16973. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  16974. * css/CSSMutableStyleDeclaration.h:
  16975. * css/CSSStyleSelector.cpp:
  16976. (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged):
  16977. (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
  16978. * css/CSSVariablesDeclaration.cpp:
  16979. (WebCore::CSSVariablesDeclaration::removeVariable):
  16980. (WebCore::CSSVariablesDeclaration::setVariable):
  16981. (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
  16982. * css/CSSVariablesDeclaration.h:
  16983. * dom/ContainerNode.cpp:
  16984. (WebCore::ContainerNode::insertBefore):
  16985. (WebCore::ContainerNode::replaceChild):
  16986. (WebCore::ContainerNode::removeChild):
  16987. (WebCore::ContainerNode::appendChild):
  16988. (WebCore::ContainerNode::detach):
  16989. (WebCore::ContainerNode::setFocus):
  16990. (WebCore::ContainerNode::setActive):
  16991. (WebCore::ContainerNode::setHovered):
  16992. * dom/Document.cpp:
  16993. (WebCore::Document::Document):
  16994. (WebCore::Document::~Document):
  16995. (WebCore::Document::scheduleStyleRecalc):
  16996. (WebCore::Document::unscheduleStyleRecalc):
  16997. (WebCore::Document::recalcStyle):
  16998. (WebCore::Document::updateStyleIfNeeded):
  16999. (WebCore::Document::updateStyleForAllDocuments):
  17000. (WebCore::Document::updateLayout):
  17001. (WebCore::Document::implicitClose):
  17002. (WebCore::Document::prepareMouseEvent):
  17003. (WebCore::Document::setFocusedNode):
  17004. (WebCore::Document::setCSSTarget):
  17005. * dom/Document.h:
  17006. * dom/Element.cpp:
  17007. (WebCore::Element::recalcStyle):
  17008. (WebCore::checkForSiblingStyleChanges):
  17009. * dom/InputElement.cpp:
  17010. (WebCore::InputElement::parseMaxLengthAttribute):
  17011. * dom/MouseRelatedEvent.cpp:
  17012. (WebCore::MouseRelatedEvent::receivedTarget):
  17013. * dom/Node.cpp:
  17014. (WebCore::Node::Node):
  17015. (WebCore::Node::setNeedsStyleRecalc):
  17016. (WebCore::Node::lazyAttach):
  17017. (WebCore::Node::dispatchGenericEvent):
  17018. * dom/Node.h:
  17019. (WebCore::Node::needsStyleRecalc):
  17020. (WebCore::Node::childNeedsStyleRecalc):
  17021. (WebCore::Node::setChildNeedsStyleRecalc):
  17022. * dom/OptionElement.cpp:
  17023. (WebCore::OptionElement::setSelectedState):
  17024. * dom/ScriptElement.cpp:
  17025. (WebCore::ScriptElementData::evaluateScript):
  17026. * dom/StyledElement.cpp:
  17027. (WebCore::StyledElement::attributeChanged):
  17028. (WebCore::StyledElement::classAttributeChanged):
  17029. (WebCore::StyledElement::parseMappedAttribute):
  17030. * dom/Text.cpp:
  17031. (WebCore::Text::recalcStyle):
  17032. * dom/XMLTokenizer.cpp:
  17033. (WebCore::XMLTokenizer::insertErrorMessageBlock):
  17034. * editing/DeleteButtonController.cpp:
  17035. (WebCore::DeleteButtonController::enable):
  17036. * editing/Editor.cpp:
  17037. (WebCore::Editor::setBaseWritingDirection):
  17038. * editing/SelectionController.cpp:
  17039. (WebCore::SelectionController::nodeWillBeRemoved):
  17040. (WebCore::SelectionController::layout):
  17041. (WebCore::SelectionController::focusedOrActiveStateChanged):
  17042. * html/HTMLAnchorElement.cpp:
  17043. (WebCore::HTMLAnchorElement::parseMappedAttribute):
  17044. * html/HTMLElement.cpp:
  17045. (WebCore::HTMLElement::setInnerText):
  17046. (WebCore::HTMLElement::isContentEditable):
  17047. (WebCore::HTMLElement::isContentRichlyEditable):
  17048. (WebCore::HTMLElement::contentEditable):
  17049. * html/HTMLEmbedElement.cpp:
  17050. (WebCore::HTMLEmbedElement::updateWidget):
  17051. * html/HTMLFormControlElement.cpp:
  17052. (WebCore::HTMLFormControlElement::parseMappedAttribute):
  17053. * html/HTMLFrameSetElement.cpp:
  17054. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  17055. (WebCore::HTMLFrameSetElement::recalcStyle):
  17056. * html/HTMLInputElement.cpp:
  17057. (WebCore::HTMLInputElement::parseMappedAttribute):
  17058. (WebCore::HTMLInputElement::setChecked):
  17059. (WebCore::HTMLInputElement::setIndeterminate):
  17060. (WebCore::HTMLInputElement::setValue):
  17061. (WebCore::HTMLInputElement::setAutofilled):
  17062. * html/HTMLMediaElement.cpp:
  17063. (WebCore::HTMLMediaElement::finishParsingChildren):
  17064. * html/HTMLObjectElement.cpp:
  17065. (WebCore::HTMLObjectElement::updateWidget):
  17066. (WebCore::HTMLObjectElement::finishParsingChildren):
  17067. (WebCore::HTMLObjectElement::childrenChanged):
  17068. * html/HTMLSelectElement.cpp:
  17069. (WebCore::HTMLSelectElement::recalcStyle):
  17070. (WebCore::HTMLSelectElement::restoreState):
  17071. (WebCore::HTMLSelectElement::setRecalcListItems):
  17072. (WebCore::HTMLSelectElement::reset):
  17073. (WebCore::HTMLSelectElement::typeAheadFind):
  17074. * html/HTMLTableElement.cpp:
  17075. (WebCore::setTableCellsChanged):
  17076. (WebCore::HTMLTableElement::parseMappedAttribute):
  17077. * html/HTMLTextAreaElement.cpp:
  17078. (WebCore::HTMLTextAreaElement::setValue):
  17079. * loader/FrameLoader.cpp:
  17080. (WebCore::FrameLoader::stopLoading):
  17081. (WebCore::FrameLoader::executeScript):
  17082. (WebCore::FrameLoader::gotoAnchor):
  17083. * page/DOMWindow.cpp:
  17084. (WebCore::DOMWindow::alert):
  17085. (WebCore::DOMWindow::confirm):
  17086. (WebCore::DOMWindow::prompt):
  17087. * page/EventHandler.cpp:
  17088. (WebCore::EventHandler::hoverTimerFired):
  17089. * page/FrameView.cpp:
  17090. (WebCore::FrameView::layout):
  17091. (WebCore::FrameView::needsLayout):
  17092. * page/animation/AnimationBase.cpp:
  17093. (WebCore::AnimationBase::setNeedsStyleRecalc):
  17094. (WebCore::AnimationBase::updateStateMachine):
  17095. * page/animation/AnimationBase.h:
  17096. * page/animation/AnimationController.cpp:
  17097. (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
  17098. (WebCore::AnimationControllerPrivate::clear):
  17099. (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  17100. (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  17101. (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher):
  17102. (WebCore::AnimationControllerPrivate::addEventToDispatch):
  17103. (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
  17104. (WebCore::AnimationControllerPrivate::animationTimerFired):
  17105. (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
  17106. (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  17107. (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
  17108. (WebCore::AnimationController::cancelAnimations):
  17109. * page/animation/AnimationControllerPrivate.h:
  17110. * page/animation/ImplicitAnimation.cpp:
  17111. (WebCore::ImplicitAnimation::sendTransitionEvent):
  17112. * page/animation/KeyframeAnimation.cpp:
  17113. (WebCore::KeyframeAnimation::endAnimation):
  17114. (WebCore::KeyframeAnimation::sendAnimationEvent):
  17115. * rendering/RenderObject.cpp:
  17116. (WebCore::RenderObject::updateDragState):
  17117. * rendering/RenderView.cpp:
  17118. (WebCore::RenderView::selectionBounds):
  17119. * svg/SVGAElement.cpp:
  17120. (WebCore::SVGAElement::svgAttributeChanged):
  17121. * svg/SVGAnimationElement.cpp:
  17122. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
  17123. * svg/SVGCursorElement.cpp:
  17124. (WebCore::SVGCursorElement::svgAttributeChanged):
  17125. * svg/SVGElementInstance.cpp:
  17126. (WebCore::SVGElementInstance::setNeedsUpdate):
  17127. * svg/SVGForeignObjectElement.cpp:
  17128. (WebCore::addCSSPropertyAndNotifyAttributeMap):
  17129. * svg/SVGStopElement.cpp:
  17130. (WebCore::SVGStopElement::parseMappedAttribute):
  17131. * svg/SVGStyledElement.cpp:
  17132. (WebCore::SVGStyledElement::parseMappedAttribute):
  17133. * svg/SVGUseElement.cpp:
  17134. (WebCore::SVGUseElement::svgAttributeChanged):
  17135. (WebCore::SVGUseElement::childrenChanged):
  17136. (WebCore::SVGUseElement::recalcStyle):
  17137. * svg/animation/SMILTimeContainer.cpp:
  17138. (WebCore::SMILTimeContainer::updateAnimations):
  17139. * wml/WMLAElement.cpp:
  17140. (WebCore::WMLAElement::parseMappedAttribute):
  17141. * wml/WMLInputElement.cpp:
  17142. (WebCore::WMLInputElement::setValue):
  17143. (WebCore::WMLInputElement::parseMappedAttribute):
  17144. * wml/WMLNoopElement.cpp:
  17145. (WebCore::WMLNoopElement::insertedIntoDocument):
  17146. 2009-04-09 Brett Wilson <brettw@chromium.org>
  17147. Reviewed by Darin Fisher.
  17148. When there is a shadow set but it specifies "no shadow", clear the
  17149. shadow shader. This will prevent Chromium from thinking there's a
  17150. shadow and using the Skia codepath rather than Windows.
  17151. * platform/graphics/skia/GraphicsContextSkia.cpp:
  17152. (WebCore::GraphicsContext::setPlatformShadow):
  17153. 2009-04-09 Eric Seidel <eric@webkit.org>
  17154. Reviewed by Simon Fraser.
  17155. Crash when accessing svg.viewport on a detached SVGSVGElement
  17156. https://bugs.webkit.org/show_bug.cgi?id=25105
  17157. * svg/SVGSVGElement.cpp:
  17158. (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as to what behavior we should have in this case, and I doubt anyone cares for now).
  17159. 2009-04-09 Jian Li <jianli@chromium.org>
  17160. Reviewed by Dimitri Glazkov.
  17161. https://bugs.webkit.org/show_bug.cgi?id=25084
  17162. Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext.
  17163. * bindings/v8/WorkerContextExecutionProxy.cpp:
  17164. (WebCore::WorkerContextExecutionProxy::dispose):
  17165. (WebCore::WorkerContextExecutionProxy::retrieve):
  17166. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
  17167. (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
  17168. (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
  17169. (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener):
  17170. * bindings/v8/WorkerContextExecutionProxy.h:
  17171. * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  17172. (WebCore::CALLBACK_FUNC_DECL):
  17173. * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  17174. (WebCore::getEventListener):
  17175. (WebCore::ACCESSOR_SETTER):
  17176. (WebCore::CALLBACK_FUNC_DECL):
  17177. 2009-04-09 Darin Adler <darin@apple.com>
  17178. Reviewed by Anders Carlsson and Sam Weinig.
  17179. Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
  17180. Longer term solution is to change the design so Safari doesn't read and write all of history.
  17181. This patch is step one: Do the serializing, which is done on the main thread, much faster.
  17182. * WebCore.base.exp: Added new entry points.
  17183. * WebCore.xcodeproj/project.pbxproj: Added new source files.
  17184. * history/cf: Added.
  17185. * history/cf/HistoryPropertyList.cpp: Added.
  17186. * history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also
  17187. have code for reading here too.
  17188. * platform/cf/BinaryPropertyList.cpp: Added.
  17189. * platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files.
  17190. 2009-04-09 Simon Fraser <simon.fraser@apple.com>
  17191. Reviewed by Antti Koivisto
  17192. https://bugs.webkit.org/show_bug.cgi?id=25122
  17193. If deferred repainting is active, we need to ensure that there are no repaints
  17194. pending at the end of layoutIfNeededRecursive, which is called just before
  17195. painting via -viewWillDraw.
  17196. * page/FrameView.cpp:
  17197. (WebCore::FrameView::layoutIfNeededRecursive):
  17198. 2009-04-09 John Grabowski <jrg@chromium.org>
  17199. Reviewed by Darin Fisher.
  17200. https://bugs.webkit.org/show_bug.cgi?id=25117
  17201. Fix Mac Chromium form controls.
  17202. * rendering/RenderThemeChromiumMac.mm:
  17203. When rendering native controls in Mac Chromium, use a clean NSGraphicsContext.
  17204. Properly save and restore native graphics context.
  17205. (WebCore::RenderThemeChromiumMac::paintCheckbox):
  17206. (WebCore::RenderThemeChromiumMac::paintRadio):
  17207. (WebCore::RenderThemeChromiumMac::paintMenuList):
  17208. (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton):
  17209. (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration):
  17210. (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
  17211. 2009-04-09 Drew Wilson <atwilson@google.com>
  17212. Reviewed by Alexey Proskuryakov.
  17213. https://bugs.webkit.org/show_bug.cgi?id=25030
  17214. Refactor MessagePort code to enable Chrome to use a MessagePortProxy object
  17215. instead of a real MessagePort for the entangledPort, since it could
  17216. theoretically live in a separate process.
  17217. The goal of this refactoring is to remove all assumptions that the object
  17218. representing the entangled port is actually of type MessagePort. All
  17219. operations that were previously directly modifying private MessagePort member
  17220. variables in the entangled port (i.e. entangle(), postMessage()) have been changed
  17221. to invoke functions in the MessagePortProxy interface instead which will allow
  17222. the Chrome bindings to proxy these calls to another process.
  17223. No new layout tests, as this is just a refactoring with no bug fixes
  17224. or new functionality.
  17225. * GNUmakefile.am:
  17226. * WebCore.vcproj/WebCore.vcproj:
  17227. * WebCore.xcodeproj/project.pbxproj:
  17228. * bindings/js/JSMessagePortCustom.cpp:
  17229. (WebCore::JSMessagePort::mark):
  17230. * dom/MessagePort.cpp:
  17231. (WebCore::MessagePort::clone):
  17232. (WebCore::MessagePort::postMessage):
  17233. (WebCore::MessagePort::deliverMessage):
  17234. (WebCore::MessagePort::startConversation):
  17235. (WebCore::MessagePort::close):
  17236. (WebCore::MessagePort::entangle):
  17237. (WebCore::MessagePort::unentangle):
  17238. * dom/MessagePort.h:
  17239. (WebCore::MessagePort::entangledPort):
  17240. * dom/MessagePortProxy.h: Added.
  17241. (WebCore::MessagePortProxy::~MessagePortProxy):
  17242. 2009-04-08 Sam Weinig <sam@webkit.org>
  17243. Reviewed by Geoffrey "Big Boy" Garen.
  17244. Fix for <rdar://problem/5745677> Possible to stop load during an unload event
  17245. Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
  17246. Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
  17247. fast/events/stop-load-in-unload-handler-using-window-stop.html
  17248. Don't allow calling methods that would stop the new load inside the unload
  17249. event.
  17250. * loader/FrameLoader.cpp:
  17251. (WebCore::FrameLoader::FrameLoader):
  17252. (WebCore::FrameLoader::stopLoading):
  17253. (WebCore::FrameLoader::stopAllLoaders):
  17254. * loader/FrameLoader.h:
  17255. 2009-04-09 David Kilzer <ddkilzer@apple.com>
  17256. Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
  17257. Rolled r42345 back in. The build failure was caused by an
  17258. internal script which had not been updated the same way that
  17259. build-webkit was updated.
  17260. * Configurations/WebCore.xcconfig:
  17261. * DerivedSources.make:
  17262. * bindings/objc/DOM.mm:
  17263. (WebCore::createElementClassMap):
  17264. (+[DOMNode _wrapNode:WebCore::]):
  17265. * bindings/objc/DOMCSS.mm:
  17266. (+[DOMCSSValue _wrapCSSValue:WebCore::]):
  17267. * bindings/objc/DOMEvents.mm:
  17268. (+[DOMEvent _wrapEvent:WebCore::]):
  17269. * bindings/objc/DOMInternal.h:
  17270. * bindings/objc/ExceptionHandlers.mm:
  17271. (WebCore::raiseDOMException):
  17272. * html/HTMLEmbedElement.idl:
  17273. * html/HTMLFrameElement.idl:
  17274. * html/HTMLIFrameElement.idl:
  17275. * html/HTMLObjectElement.idl:
  17276. 2009-04-09 Simon Fraser <simon.fraser@apple.com>
  17277. Reviewed by Darin Adler
  17278. https://bugs.webkit.org/show_bug.cgi?id=25109
  17279. Eliminate CompositeAnimationPrivate, which was a needless level
  17280. of abstraction. Remove the methods like addToStyleAvailableWaitList()
  17281. that simply turn around and call the animation controller.
  17282. Rename animationControllerPriv() to animationController().
  17283. Rename willNeedService() to timeToNextService().
  17284. * page/animation/AnimationBase.cpp:
  17285. (WebCore::AnimationBase::~AnimationBase):
  17286. (WebCore::AnimationBase::updateStateMachine):
  17287. (WebCore::AnimationBase::timeToNextService):
  17288. (WebCore::AnimationBase::beginAnimationUpdateTime):
  17289. * page/animation/AnimationBase.h:
  17290. * page/animation/AnimationController.cpp:
  17291. (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  17292. * page/animation/CompositeAnimation.cpp:
  17293. (WebCore::CompositeAnimation::~CompositeAnimation):
  17294. (WebCore::CompositeAnimation::clearRenderer):
  17295. (WebCore::CompositeAnimation::updateTransitions):
  17296. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  17297. (WebCore::CompositeAnimation::animate):
  17298. (WebCore::CompositeAnimation::getAnimatedStyle):
  17299. (WebCore::CompositeAnimation::setAnimating):
  17300. (WebCore::CompositeAnimation::timeToNextService):
  17301. (WebCore::CompositeAnimation::getAnimationForProperty):
  17302. (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  17303. (WebCore::CompositeAnimation::suspendAnimations):
  17304. (WebCore::CompositeAnimation::resumeAnimations):
  17305. (WebCore::CompositeAnimation::overrideImplicitAnimations):
  17306. (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
  17307. (WebCore::CompositeAnimation::isAnimatingProperty):
  17308. (WebCore::CompositeAnimation::pauseAnimationAtTime):
  17309. (WebCore::CompositeAnimation::pauseTransitionAtTime):
  17310. (WebCore::CompositeAnimation::numberOfActiveAnimations):
  17311. * page/animation/CompositeAnimation.h:
  17312. (WebCore::CompositeAnimation::animationController):
  17313. (WebCore::CompositeAnimation::isSuspended):
  17314. (WebCore::CompositeAnimation::hasAnimations):
  17315. (WebCore::CompositeAnimation::CompositeAnimation):
  17316. * page/animation/ImplicitAnimation.cpp:
  17317. (WebCore::ImplicitAnimation::sendTransitionEvent):
  17318. (WebCore::ImplicitAnimation::timeToNextService):
  17319. * page/animation/ImplicitAnimation.h:
  17320. * page/animation/KeyframeAnimation.cpp:
  17321. (WebCore::KeyframeAnimation::sendAnimationEvent):
  17322. (WebCore::KeyframeAnimation::timeToNextService):
  17323. * page/animation/KeyframeAnimation.h:
  17324. 2009-04-09 Alexey Proskuryakov <ap@webkit.org>
  17325. Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
  17326. It broke Mac build, and I don't know how to fix it.
  17327. * Configurations/WebCore.xcconfig:
  17328. * DerivedSources.make:
  17329. * bindings/objc/DOM.mm:
  17330. (WebCore::createElementClassMap):
  17331. (+[DOMNode _wrapNode:WebCore::]):
  17332. * bindings/objc/DOMCSS.mm:
  17333. (+[DOMCSSValue _wrapCSSValue:WebCore::]):
  17334. * bindings/objc/DOMEvents.mm:
  17335. (+[DOMEvent _wrapEvent:WebCore::]):
  17336. * bindings/objc/DOMInternal.h:
  17337. * bindings/objc/ExceptionHandlers.mm:
  17338. (WebCore::raiseDOMException):
  17339. * html/HTMLEmbedElement.idl:
  17340. * html/HTMLFrameElement.idl:
  17341. * html/HTMLIFrameElement.idl:
  17342. * html/HTMLObjectElement.idl:
  17343. 2009-04-09 Xan Lopez <xlopez@igalia.com>
  17344. Unreviewed build fix.
  17345. RenderView::docWidth() was made private by r42334. That commit
  17346. changes its usage for overflowWidth(), so do that here too.
  17347. * page/PrintContext.cpp:
  17348. (WebCore::PrintContext::computePageRects):
  17349. 2009-04-09 Xan Lopez <xlopez@igalia.com>
  17350. Reviewed by Holger Freyther.
  17351. https://bugs.webkit.org/show_bug.cgi?id=21546
  17352. [GTK] ATK accessibility enhancements
  17353. Based on a patch by Alp Toker.
  17354. Implement AtkObject::ref_state_set. Still quite a few states not
  17355. implemented.
  17356. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  17357. 2009-04-09 Xan Lopez <xlopez@igalia.com>
  17358. Reviewed by Holger Freyther.
  17359. https://bugs.webkit.org/show_bug.cgi?id=21546
  17360. [GTK] ATK accessibility enhancements
  17361. Based on a patch by Alp Toker.
  17362. Move fallback object creation to its own function, as it will be
  17363. used in several places.
  17364. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  17365. (fallbackObject):
  17366. 2009-04-09 Xan Lopez <xlopez@igalia.com>
  17367. Reviewed by Holger Freyther.
  17368. https://bugs.webkit.org/show_bug.cgi?id=21546
  17369. [GTK] ATK accessibility enhancements
  17370. Based on a patch by Alp Toker.
  17371. Move AccessibilityObject methods to their file.
  17372. * page/gtk/AccessibilityObjectAtk.cpp:
  17373. (WebCore::AccessibilityObject::wrapper):
  17374. (WebCore::AccessibilityObject::setWrapper):
  17375. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  17376. 2009-04-09 Xan Lopez <xlopez@igalia.com>
  17377. Reviewed by Holger Freyther.
  17378. https://bugs.webkit.org/show_bug.cgi?id=21546
  17379. [GTK] ATK accessibility enhancements
  17380. Rework accessibility type generation code, based on Mozilla a11y
  17381. implementation.
  17382. Have one base a11y type, and generate derived types that implement
  17383. only the necessary interfaces at runtime, based on the specific
  17384. object we are wrapping. This allows to save a lot of code while
  17385. covering all possible cases.
  17386. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  17387. 2009-04-09 Eric Seidel <eric@webkit.org>
  17388. Reviewed by Oliver Hunt.
  17389. Fix document.implementation.createDocument(null, "a:b") not to crash!
  17390. https://bugs.webkit.org/show_bug.cgi?id=25096
  17391. Test: fast/dom/DOMImplementation/createDocument-namespace-err.html
  17392. * dom/ContainerNode.cpp:
  17393. (WebCore::ContainerNode::addChild): add ASSERT() to give a better crash next time
  17394. * dom/DOMImplementation.cpp:
  17395. (WebCore::DOMImplementation::createDocument): check the exception code before using the result
  17396. 2009-04-08 Adam Roben <aroben@apple.com>
  17397. Make <select>s in application chrome documents match the Vista system
  17398. dialog look
  17399. Reviewed by Dave Hyatt.
  17400. * rendering/RenderThemeWin.cpp:
  17401. (WebCore::documentIsInApplicationChromeMode): Added this simple helper
  17402. function.
  17403. (WebCore::RenderThemeWin::getThemeData): In application chrome mode,
  17404. the drop down button never uses any look but the "normal" look.
  17405. (WebCore::RenderThemeWin::paintMenuList): In application chrome mode,
  17406. use the "readonly" style to match system dialogs.
  17407. 2009-04-08 Adam Roben <aroben@apple.com>
  17408. Fix <rdar://6592515> Crash closing tab with Top Sites or Cover Flow
  17409. showing after clicking "Go Back" in phishing alert
  17410. RenderButton's m_timer is not stopped when its Document enters the
  17411. page cache. When the WebView was torn down, the timer would fire after
  17412. the Frame's Page had been destroyed, leading to a crash. This patch
  17413. just makes the timer do nothing when it fires. Making the timer not
  17414. fire when in the page cache is covered by bug 25110.
  17415. Reviewed by Dave Hyatt.
  17416. No test possible.
  17417. * rendering/RenderButton.cpp:
  17418. (WebCore::RenderButton::timerFired): Do nothing when we're in the page
  17419. cache.
  17420. 2009-04-09 David Hyatt <hyatt@apple.com>
  17421. Reviewed by Adam Roben
  17422. Fix bugs where we would mistakenly turn off blitting for iframes if an external paint
  17423. caused the checks to be triggered too early in the loading process of the frame.
  17424. * rendering/RenderBoxModelObject.cpp:
  17425. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  17426. 2009-04-08 Simon Fraser <simon.fraser@apple.com>
  17427. Reviewed by Cameron Zwarich
  17428. https://bugs.webkit.org/show_bug.cgi?id=25106
  17429. Fix signature of virtual function on AnimationBase so that it matches
  17430. those in the derived classes, by removing unused parameter.
  17431. * page/animation/AnimationBase.h:
  17432. (WebCore::AnimationBase::endAnimation):
  17433. 2009-04-08 David Kilzer <ddkilzer@apple.com>
  17434. <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
  17435. Reviewed by Darin Adler and Maciej Stachowiak.
  17436. Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
  17437. that SVG DOM Objective-C bindings may be optionally disabled.
  17438. * Configurations/WebCore.xcconfig: Added
  17439. ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in
  17440. FEATURE_DEFINES and EXCLUDED_SOURCE_FILE_NAMES. When SVG DOM
  17441. Objective-C bindings are disabled, two generated header files no
  17442. longer exist and none of the generated DOMSVG*.mm files should
  17443. be compiled.
  17444. * DerivedSources.make: All of the WebCore.SVG*.exp files contain
  17445. SVG DOM Objective-C bindings classes, so exclude them unless
  17446. ENABLE_SVG_DOM_OBJC_BINDINGS is set.
  17447. * bindings/objc/DOM.mm: Switched from using ENABLE(SVG) to using
  17448. ENABLE(SVG_DOM_OBJC_BINDINGS).
  17449. (WebCore::createElementClassMap):
  17450. (+[DOMNode _wrapNode:WebCore::]):
  17451. * bindings/objc/DOMCSS.mm: Ditto.
  17452. (+[DOMCSSValue _wrapCSSValue:WebCore::]):
  17453. * bindings/objc/DOMEvents.mm: Ditto.
  17454. (+[DOMEvent _wrapEvent:WebCore::]):
  17455. * bindings/objc/DOMInternal.h: Ditto.
  17456. * bindings/objc/ExceptionHandlers.mm: Added use of
  17457. ENABLE(SVG_DOM_OBJC_BINDINGS).
  17458. (WebCore::raiseDOMException):
  17459. * html/HTMLEmbedElement.idl: Excluded -getSVGDocument method
  17460. in generated Objective-C DOM classes if SVG DOM Objective-C
  17461. bindings are disabled.
  17462. * html/HTMLFrameElement.idl: Ditto.
  17463. * html/HTMLIFrameElement.idl: Ditto.
  17464. * html/HTMLObjectElement.idl: Ditto.
  17465. 2009-04-08 Dan Bernstein <mitz@apple.com>
  17466. Reviewed by Sam Weinig.
  17467. - limit the workaround for <rdar://problem/5781372> to Mac OS X versions
  17468. that need it
  17469. * platform/mac/WebFontCache.mm:
  17470. (fixUpWeight): Changed this function to be a no-op post-Leopard.
  17471. 2009-04-08 Dan Bernstein <mitz@apple.com>
  17472. Reviewed by Dave Hyatt.
  17473. - fix <rdar://problem/6771547> Appending to a RenderText causes all its
  17474. lines to be dirtied
  17475. Test: fast/repaint/text-append-dirty-lines.html
  17476. * rendering/RenderText.cpp:
  17477. (WebCore::RenderText::setTextWithOffset): If no text boxes intersected
  17478. with or came after the new text, dirty the last root box, since the new
  17479. text may begin there. Having at least one dirty line prevents the
  17480. incorrect dirtying of all lines later during layoutInlineChildren().
  17481. 2009-04-08 Darin Fisher <darin@chromium.org>
  17482. Reviewed by Eric Seidel.
  17483. https://bugs.webkit.org/show_bug.cgi?id=25100
  17484. Fixes a Chromium-specific crash in WebCore::ImageBuffer::context that
  17485. occurs when rendering semi-transparent RTL text.
  17486. Test: fast/text/complex-text-opacity.html
  17487. * platform/graphics/chromium/FontChromiumWin.cpp: Handle RTL when computing text bounds.
  17488. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
  17489. 2009-04-08 David Hyatt <hyatt@apple.com>
  17490. Reviewed by Beth Dakin
  17491. Fix a porting error in my previous patch. A != was supposed to be an ==.
  17492. * platform/ScrollView.cpp:
  17493. (WebCore::ScrollView::updateScrollbars):
  17494. 2009-04-08 David Hyatt <hyatt@apple.com>
  17495. Reviewed by Adam Roben and Darin Adler
  17496. Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, repaints inconsistent for
  17497. fixed positioned elements.
  17498. Rewrite the updateScrollers method to be more correct in its results.
  17499. Test: fast/block/positioning/fixed-positioning-scrollbar-bug.html
  17500. * dom/Document.cpp:
  17501. (WebCore::Document::recalcStyle):
  17502. (WebCore::Document::implicitClose):
  17503. * page/FrameView.cpp:
  17504. (WebCore::FrameView::createScrollbar):
  17505. (WebCore::FrameView::layout):
  17506. (WebCore::FrameView::adjustPageHeight):
  17507. * page/FrameView.h:
  17508. * page/win/FrameWin.cpp:
  17509. (WebCore::computePageRectsForFrame):
  17510. * platform/ScrollView.cpp:
  17511. (WebCore::ScrollView::ScrollView):
  17512. (WebCore::ScrollView::updateScrollbars):
  17513. * platform/ScrollView.h:
  17514. * rendering/RenderView.cpp:
  17515. (WebCore::RenderView::layout):
  17516. (WebCore::RenderView::docHeight):
  17517. (WebCore::RenderView::docWidth):
  17518. * rendering/RenderView.h:
  17519. 2009-04-08 Sam Weinig <sam@webkit.org>
  17520. Reviewed by Anders Carlsson.
  17521. Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
  17522. Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
  17523. http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
  17524. http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
  17525. http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
  17526. http/tests/security/XFrameOptions/x-frame-options-deny.html
  17527. http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
  17528. http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
  17529. * dom/Document.cpp:
  17530. (WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank
  17531. if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
  17532. * loader/FrameLoader.cpp:
  17533. (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse
  17534. the X-FRAME-OPTIONS parameter.
  17535. * loader/FrameLoader.h:
  17536. * loader/MainResourceLoader.cpp:
  17537. (WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and
  17538. a X-FRAME-OPTIONS header and its parameter dictate that we should.
  17539. 2009-04-08 Adam Roben <aroben@apple.com>
  17540. Fix http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html on Windows
  17541. Reviewed by Sam Weinig.
  17542. * platform/network/cf/ResourceHandleCFNet.cpp:
  17543. (WebCore::ResourceHandle::loadResourceSynchronously): Mimic the
  17544. ResourceHandleMac code by propagating the CFError's error code for
  17545. kCFErrorDomainCFNetwork errors to the ResourceResponse.
  17546. 2009-04-08 Anders Carlsson <andersca@apple.com>
  17547. Try to fix the PPC build.
  17548. * plugins/npfunctions.h:
  17549. 2009-04-08 Darin Adler <darin@apple.com>
  17550. Reviewed by Sam Weinig.
  17551. <rdar://problem/5908616> tokenizer resizer should handle edge cases consistently
  17552. * html/HTMLTokenizer.cpp:
  17553. (WebCore::HTMLTokenizer::enlargeBuffer): Handle edge cases the same way as a failed fastMalloc.
  17554. (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto.
  17555. 2009-04-08 David Hyatt <hyatt@apple.com>
  17556. Reviewed by Darin Adler
  17557. Make sure that cloneNode works with SVG attributes that require synchronization. This fixes
  17558. issues with <use> element shadow tree cloning where the clones can end up not obtaining the
  17559. correct attribute values.
  17560. A subsequent patch of mine will expose this problem and cause it to be covered by existing
  17561. layout tests, so no test is required at this time for this problem.
  17562. * dom/Element.cpp:
  17563. (WebCore::Element::cloneElementWithoutChildren):
  17564. 2009-04-08 Dimitri Glazkov <dglazkov@chromium.org>
  17565. Reviewed by Timothy Hatcher.
  17566. https://bugs.webkit.org/show_bug.cgi?id=25093
  17567. REGRESSION: some scripts are showing in the Inspector with only "true"
  17568. as the source.
  17569. * inspector/InspectorController.cpp:
  17570. (WebCore::InspectorController::didParseSource): Fixed conversion issue.
  17571. (WebCore::InspectorController::failedToParseSource): Ditto.
  17572. 2009-04-08 Adam Barth <abarth@webkit.org>
  17573. Reviewed by Alexey Proskuryakov.
  17574. https://bugs.webkit.org/show_bug.cgi?id=24904
  17575. Verify the MIME type of stylesheets (in standards mode) by looking
  17576. at the Content-Type header directly. This bypasses any content
  17577. sniffing that might be confusing the issue.
  17578. Test: http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html
  17579. * loader/CachedCSSStyleSheet.cpp:
  17580. (WebCore::CachedCSSStyleSheet::canUseSheet):
  17581. 2009-04-08 Eric Carlson <eric.carlson@apple.com>
  17582. Reviewed by Simon Fraser.
  17583. https://bugs.webkit.org/show_bug.cgi?id=25041
  17584. <rdar://problem/6697754>
  17585. Bug 25041: HTMLMediaElement: OSX autoplay broken by r41907
  17586. OSX media player should set readyState to HAVE_ENOUGH_DATA when the movie's load state
  17587. reaches QTMovieLoadStatePlaythroughOK, not when the entire file has been downloaded,
  17588. so autoplay can begin when it should.
  17589. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  17590. (WebCore::MediaPlayerPrivate::updateStates): Set readState to
  17591. HAVE_ENOUGH_DATA when QTMovie load state reaches QTMovieLoadStatePlaythroughOK.
  17592. (WebCore::MediaPlayerPrivate::paint): Add braces missed in r42203.
  17593. 2009-04-08 Alexey Proskuryakov <ap@webkit.org>
  17594. Reviewed by David Kilzer. Based on a patch by Grace Kloba.
  17595. https://bugs.webkit.org/show_bug.cgi?id=24656
  17596. cacheControlContainsNoCache() in ResourceResponseBase.h is wrong
  17597. * platform/network/ResourceResponseBase.cpp:
  17598. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Removed misused code for
  17599. parsing directive values, fixing parsing of directives that we care about.
  17600. * platform/network/ResourceResponseBase.h:
  17601. (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Fixed a copy/paste mistake,
  17602. m_cacheControlContainsMustRevalidate was returned instead of m_cacheControlContainsNoCache.
  17603. 2009-04-08 Adam Roben <aroben@apple.com>
  17604. Make text fields match the system look on Vista
  17605. Reviewed by Dave Hyatt.
  17606. * rendering/RenderThemeWin.cpp:
  17607. (WebCore::RenderThemeWin::getThemeData): Use the new-to-Vista
  17608. EP_EDITBORDER_NOSCROLL part for text fields.
  17609. 2009-04-07 Alexey Proskuryakov <ap@webkit.org>
  17610. Reviewed by Maciej Stachowiak.
  17611. https://bugs.webkit.org/show_bug.cgi?id=24957
  17612. REGRESSION: Google calendar widget no longer shows upcoming events
  17613. Test: http/tests/xmlhttprequest/authorization-header.html
  17614. * xml/XMLHttpRequest.cpp:
  17615. (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from
  17616. the list of forbidden headers.
  17617. 2009-04-07 miggilin <mr.diggilin@gmail.com>
  17618. Reviewed by Kevin Ollivier.
  17619. Remove no longer needed debug warning and Windows-specific codepaths
  17620. (as we now use the Safari/Win port's timer there)
  17621. https://bugs.webkit.org/show_bug.cgi?id=25070
  17622. * platform/wx/SharedTimerWx.cpp:
  17623. (WebCore::setSharedTimerFireTime):
  17624. 2009-04-07 Adam Roben <aroben@apple.com>
  17625. Fix many <video> regression tests on Windows
  17626. Reviewed by Dave Hyatt.
  17627. * platform/graphics/win/QTMovieWin.cpp:
  17628. (QTMovieWin::getNaturalSize): Call GetMovieNaturalBoundsRect, which
  17629. returns the movie's natural bounds (duh), rather than GetMovieBox,
  17630. which returns the movie's current displayed size/position.
  17631. 2009-04-07 Brady Eidson <beidson@apple.com>
  17632. Reviewed by Darin Adler and Sam Weinig
  17633. <rdar://problem/5968249> "Private Browsing" doesn't affect HTML 5 LocalStorage
  17634. The expected behavior for persistent storage when private browsing mode is undefined by the spec.
  17635. For now we're going with a "read-only when in private browsing" policy until we can get feedback
  17636. and/or get the behavior specified in the spec.
  17637. Note that I purposefully made the change to restrict SessionStorage to read-only, also, with the
  17638. understanding that the spec allows for SessionStorage to persist across relaunches, even though
  17639. our implementation currently doesn't do this.
  17640. * dom/DOMCoreException.idl: Add some new ExceptionCodes defined in HTML5, one of which is needed
  17641. for LocalStorage changes (QUOTA_EXCEEDED_ERR)
  17642. * dom/ExceptionCode.cpp:
  17643. * dom/ExceptionCode.h:
  17644. * storage/StorageArea.cpp:
  17645. (WebCore::StorageArea::internalSetItem): If private browsing is enabled, throw the QUOTA_EXCEEDED_ERR
  17646. exception as the spec allows.
  17647. (WebCore::StorageArea::internalRemoveItem): If private browsing is enabled, silently fail to remove
  17648. the item.
  17649. (WebCore::StorageArea::internalClear): If private browsing is enabled, silently fail to clear the area.
  17650. 2009-04-07 Dean Jackson <dino@apple.com>
  17651. Reviewed by Simon Fraser.
  17652. <rdar://problem/6148255>
  17653. Standalone media documents can not always handle everything
  17654. using a <video> element. In these cases switch to an <embed>
  17655. element that uses the QuickTime plugin, in the hope that it
  17656. will have more luck. Typical media types that trigger this
  17657. are streamed media and QTVR.
  17658. Equivalent Windows fix to come once reviewed. Note also that
  17659. this area of code needs a cleanup:
  17660. https://bugs.webkit.org/show_bug.cgi?id=25085
  17661. * html/HTMLMediaElement.cpp:
  17662. (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks):
  17663. * html/HTMLMediaElement.h:
  17664. * loader/MediaDocument.cpp:
  17665. (WebCore::MediaDocument::mediaElementSawUnsupportedTracks):
  17666. (WebCore::MediaDocument::replaceVideoWithEmbed):
  17667. * loader/MediaDocument.h:
  17668. - removes the <video> element and puts in an <embed>
  17669. * platform/graphics/MediaPlayer.h:
  17670. (WebCore::MediaPlayerClient::mediaPlayerSawUnsupportedTracks):
  17671. - new internal method for flagging a problem
  17672. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  17673. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  17674. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
  17675. (WebCore::MediaPlayerPrivate::updateStates):
  17676. - looks for the types of content we don't handle
  17677. (WebCore::MediaPlayerPrivate::rateChanged):
  17678. (WebCore::MediaPlayerPrivate::sizeChanged):
  17679. (WebCore::MediaPlayerPrivate::timeChanged):
  17680. (WebCore::MediaPlayerPrivate::didEnd):
  17681. (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
  17682. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks):
  17683. - inform the MediaClient that we have a potential problem
  17684. 2009-04-07 Dan Bernstein <mitz@apple.com>
  17685. Reviewed by Darin Adler.
  17686. - fix <rdar://problem/6767428> Resurrect
  17687. +[WebFontCache fontWithFamily:traits:size:] for clients that call it
  17688. directly
  17689. WebFontCache is a class in the WebCore framework and is not WebKit API,
  17690. but apparently (perhaps mistakenly) some clients call this private
  17691. interface.
  17692. This change resurrects the interface and gives it reasonable behavior
  17693. (however, note that WebCore will not call the old interface, so hacks that
  17694. override it will have no effect on WebKit clients).
  17695. * platform/mac/WebFontCache.h:
  17696. * platform/mac/WebFontCache.mm:
  17697. (+[WebFontCache fontWithFamily:traits:size:]): Added. Call through to
  17698. +fontWithFamily:traits:weight:size:.
  17699. 2009-04-07 David Hyatt <hyatt@apple.com>
  17700. Reviewed by Adam Roben
  17701. Fix ScrollView's algorithm that determines whether or not to show scrollbars. There was a bug
  17702. with the method mainly because RenderView will size itself to the viewport's size, making it
  17703. impossible to really know the document's "true" size.
  17704. In order to solve this problem ScrollView now has a minimumContentsSize method. This method
  17705. returns the document size excluding the RenderView from the calculation. This width/height
  17706. is now cached on RenderView in m_docWidth/m_docHeight member variables.
  17707. * WebCore.base.exp:
  17708. * page/FrameView.cpp:
  17709. (WebCore::FrameView::adjustPageHeight):
  17710. (WebCore::FrameView::minimumContentsSize):
  17711. * page/FrameView.h:
  17712. * platform/ScrollView.cpp:
  17713. (WebCore::ScrollView::updateScrollbars):
  17714. * platform/ScrollView.h:
  17715. (WebCore::ScrollView::minimumContentsSize):
  17716. * rendering/RenderView.cpp:
  17717. (WebCore::RenderView::layout):
  17718. (WebCore::RenderView::calcDocHeight):
  17719. (WebCore::RenderView::calcDocWidth):
  17720. * rendering/RenderView.h:
  17721. (WebCore::RenderView::docWidth):
  17722. (WebCore::RenderView::docHeight):
  17723. 2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
  17724. Build fix, not reviewed.
  17725. * WebCore.xcodeproj/project.pbxproj: Made ScriptObject.h private.
  17726. 2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
  17727. Reviewed by Timothy Hatcher.
  17728. https://bugs.webkit.org/show_bug.cgi?id=25063
  17729. Refactor InspectorController to use ScriptObject/State.
  17730. * GNUmakefile.am: Added ScriptState.cpp.
  17731. * WebCore.pro: Ditto.
  17732. * WebCore.vcproj/WebCore.vcproj: Ditto.
  17733. * WebCore.xcodeproj/project.pbxproj: Ditto.
  17734. * WebCoreSources.bkl: Ditto.
  17735. * bindings/js/JSInspectorControllerCustom.cpp:
  17736. (WebCore::JSInspectorController::addSourceToFrame): Fixed argument index typo.
  17737. * bindings/js/ScriptFunctionCall.cpp:
  17738. (WebCore::ScriptFunctionCall::call): Added reportExceptions parameter.
  17739. (WebCore::ScriptFunctionCall::construct): Ditto.
  17740. * bindings/js/ScriptFunctionCall.h: Ditto.
  17741. * bindings/js/ScriptObject.cpp:
  17742. (WebCore::handleException): Added exception-reporting heloper.
  17743. (WebCore::ScriptObject::set): Changed to use handleException.
  17744. (WebCore::ScriptGlobalObject::set): Ditto,
  17745. * bindings/js/ScriptObject.cpp: Added ScriptGlobalObject.
  17746. (WebCore::ScriptGlobalObject::set): Added.
  17747. (WebCore::ScriptGlobalObject::getObject): Added.
  17748. * bindings/js/ScriptObject.h: Added ScriptGlobalObject decls.
  17749. (WebCore::ScriptGlobalObject::ScriptGlobalObject): Added.
  17750. * bindings/js/ScriptState.cpp: Added.
  17751. * bindings/js/ScriptState.h: Added scriptStateFromPage decl.
  17752. * inspector/ConsoleMessage.cpp:
  17753. (WebCore::ConsoleMessage::addToConsole): Changed to not report exceptions
  17754. to avoid re-entrancy.
  17755. * inspector/InspectorController.cpp: Refactored to use ScriptState/Object.
  17756. * inspector/InspectorController.h: Ditto.
  17757. 2009-04-07 Adam Langley <agl@google.com>
  17758. Reviewed by Darin Fisher.
  17759. https://bugs.webkit.org/show_bug.cgi?id=25083
  17760. Skia was previously calculating the leading value incorrectly, leading
  17761. us to add fHeight to get the height of a line of text. Now that Skia
  17762. is calculating fLeading correctly, we can remove fHeight.
  17763. This doesn't affect any layout tests.
  17764. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  17765. (WebCore::SimpleFontData::platformInit):
  17766. 2009-04-07 Brian Weinstein <bweinstein@gmail.com>
  17767. Reviewed by Darin Adler.
  17768. https://bugs.webkit.org/show_bug.cgi?id=24851
  17769. This fix removes the status code from the status message in a ResourceResponse, which allows a few more tests in http to pass.
  17770. * platform/network/cf/ResourceResponseCFNet.cpp:
  17771. (WebCore::ResourceResponse::platformLazyInit):
  17772. 2009-04-07 Adam Langley <agl@google.com>
  17773. Reviewed by Darin Fisher.
  17774. https://bugs.webkit.org/show_bug.cgi?id=25081
  17775. Skia is changing from reporting the XRange to reporting the XMin and
  17776. XMax. Obviously these are equivalent, but other users of the metrics
  17777. need the two numbers to be separate.
  17778. This doesn't affect any layout tests.
  17779. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  17780. (WebCore::SimpleFontData::platformInit):
  17781. 2009-04-07 Adam Roben <aroben@apple.com>
  17782. Make the look of <select>s match the system look on Vista
  17783. Reviewed by Dave Hyatt.
  17784. * rendering/RenderThemeWin.cpp: Added new constants.
  17785. (WebCore::RenderThemeWin::getThemeData): On Vista, use the
  17786. CP_DROPDOWNBUTTONRIGHT part for drop down buttons.
  17787. (WebCore::RenderThemeWin::paintMenuList): On Vista, use the CP_BORDER
  17788. part to draw the border of <select>s.
  17789. (WebCore::RenderThemeWin::paintMenuListButton): On Vista, outset the
  17790. drop down button to make its border coincide with the <select>'s
  17791. border.
  17792. 2009-04-07 Adam Roben <aroben@apple.com>
  17793. Move isRunningOnVistaOrLater to a shared location
  17794. Rubber-stamped in advance by Dave Hyatt.
  17795. * WebCore.vcproj/WebCore.vcproj: Added SystemInfo.{cpp,h}, and let VS
  17796. have its way with the rest of the file.
  17797. * platform/win/ScrollbarThemeWin.cpp: Moved isRunningOnVistaOrLater
  17798. from here...
  17799. * platform/win/SystemInfo.cpp: Added.
  17800. (WebCore::isRunningOnVistaOrLater): ...to here.
  17801. * platform/win/SystemInfo.h: Added.
  17802. 2009-04-07 Paul Godavari <paul@chromium.org>
  17803. Reviewed by Darin Fisher.
  17804. https://bugs.webkit.org/show_bug.cgi?id=24692
  17805. Enable PopupMenuChromium to handle HTML select popups using native
  17806. cocoa controls on the Mac, all other platforms are unchanged.
  17807. We also split out the storage container for the popup menu items
  17808. so that ChromeClientChromium can access them for forwarding to
  17809. the embedding host (Chromium.app or test_shell).
  17810. * page/chromium/ChromeClientChromium.h:
  17811. * platform/chromium/PopupMenuChromium.cpp:
  17812. (WebCore::PopupListBox::items):
  17813. (WebCore::PopupContainer::PopupContainer):
  17814. (WebCore::PopupContainer::~PopupContainer):
  17815. (WebCore::PopupContainer::showPopup):
  17816. (WebCore::PopupContainer::showExternal):
  17817. (WebCore::PopupContainer::menuItemHeight):
  17818. (WebCore::popupData):
  17819. (WebCore::PopupListBox::pointToRowIndex):
  17820. (WebCore::PopupListBox::getRowBounds):
  17821. (WebCore::PopupListBox::isSelectableItem):
  17822. (WebCore::PopupListBox::updateFromElement):
  17823. (WebCore::PopupListBox::layout):
  17824. (WebCore::PopupListBox::clear):
  17825. (WebCore::PopupMenu::show):
  17826. * platform/chromium/PopupMenuChromium.h:
  17827. (WebCore::PopupItem::):
  17828. (WebCore::PopupItem::PopupItem):
  17829. 2009-04-07 Geoffrey Garen <ggaren@apple.com>
  17830. Reviewed by Oliver Hunt.
  17831. Added some double-checking to event handler marking. Now, when the
  17832. wrapper that's responsible for marking an event handler's JavaScript
  17833. function gets collected, it clears the event handler's JavaScript function
  17834. so we won't dereference it after it's collected.
  17835. In theory, we would never dereference a JavaScript event handler after
  17836. its node's wrapper was collected anyway, but it's nice to be safe.
  17837. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  17838. (WebCore::JSDOMApplicationCache::mark):
  17839. * bindings/js/JSEventListener.cpp:
  17840. (WebCore::JSEventListener::JSEventListener):
  17841. (WebCore::JSEventListener::jsFunction):
  17842. (WebCore::JSEventListener::invalidateJSFunction):
  17843. (WebCore::JSEventListener::markJSFunction):
  17844. * bindings/js/JSEventListener.h:
  17845. * bindings/js/JSMessagePortCustom.cpp:
  17846. (WebCore::JSMessagePort::mark):
  17847. * bindings/js/JSNodeCustom.cpp:
  17848. (WebCore::markEventListeners):
  17849. * bindings/js/JSWorkerContextCustom.cpp:
  17850. (WebCore::JSWorkerContext::mark):
  17851. * bindings/js/JSWorkerCustom.cpp:
  17852. (WebCore::JSWorker::mark):
  17853. * bindings/js/JSXMLHttpRequestCustom.cpp:
  17854. (WebCore::JSXMLHttpRequest::mark):
  17855. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  17856. (WebCore::JSXMLHttpRequestUpload::mark):
  17857. * bindings/scripts/CodeGeneratorJS.pm:
  17858. * dom/EventListener.h:
  17859. (WebCore::EventListener::invalidateJSFunction):
  17860. (WebCore::EventListener::markJSFunction):
  17861. (WebCore::markIfNotNull):
  17862. 2009-04-07 David Levin <levin@chromium.org>
  17863. Build fix.
  17864. r44280 undid the change in r42268 that made CookieJar.h private.
  17865. This redoes the change.
  17866. * WebCore.xcodeproj/project.pbxproj:
  17867. 2009-04-07 Jian Li <jianli@chromium.org>
  17868. Reviewed by Darin Fisher.
  17869. Upstream changes to WorkerContextExecutionProxy for enabling V8 preemption.
  17870. https://bugs.webkit.org/show_bug.cgi?id=25034
  17871. * bindings/v8/WorkerContextExecutionProxy.cpp:
  17872. (WebCore::WorkerContextExecutionProxy::evaluate):
  17873. 2009-04-07 Dan Bernstein <mitz@apple.com>
  17874. Reviewed by Darin Adler.
  17875. - fix <rdar://problem/6764359> Thai word selection misbehaves for the
  17876. last sentence in the document
  17877. Test: editing/selection/thai-word-at-document-end.html
  17878. * editing/visible_units.cpp:
  17879. - Added a BoundarySearchContextAvailability enum used to indicate
  17880. whether the caller to a boundary search function may be able to provide
  17881. additional text in the search direction and call again.
  17882. - Added a named type for the boundary search function signature. Changed
  17883. the signature to take a context availability parameter and a boolean
  17884. out parameter indicating whether more context is needed to perform
  17885. the search.
  17886. (WebCore::previousBoundary): If the beginning of the range was reached
  17887. but the last search wanted more context, perform the search again, this
  17888. time indicating that there is no earlier text.
  17889. (WebCore::nextBoundary): Similarly, in the other direction.
  17890. (WebCore::startWordBoundary): Check whether more context may be available
  17891. and ask for more context if needed.
  17892. (WebCore::endWordBoundary): Ditto.
  17893. (WebCore::previousWordPositionBoundary): Ditto.
  17894. (WebCore::nextWordPositionBoundary): Ditto.
  17895. (WebCore::startSentenceBoundary): Updated signature.
  17896. (WebCore::endSentenceBoundary): Ditto.
  17897. (WebCore::previousSentencePositionBoundary): Ditto.
  17898. (WebCore::nextSentencePositionBoundary): Ditto.
  17899. 2009-04-07 Geoffrey Garen <ggaren@apple.com>
  17900. Rubber stamped by Sam Weinig.
  17901. A little renaming:
  17902. function => jsFunction
  17903. listener => jsFunction
  17904. * bindings/js/JSEventListener.cpp:
  17905. (WebCore::JSAbstractEventListener::handleEvent):
  17906. (WebCore::JSEventListener::JSEventListener):
  17907. (WebCore::JSEventListener::~JSEventListener):
  17908. (WebCore::JSEventListener::jsFunction):
  17909. (WebCore::JSEventListener::mark):
  17910. (WebCore::JSProtectedEventListener::JSProtectedEventListener):
  17911. (WebCore::JSProtectedEventListener::~JSProtectedEventListener):
  17912. (WebCore::JSProtectedEventListener::jsFunction):
  17913. * bindings/js/JSEventListener.h:
  17914. (WebCore::JSProtectedEventListener::create):
  17915. * bindings/js/JSLazyEventListener.cpp:
  17916. (WebCore::JSLazyEventListener::jsFunction):
  17917. (WebCore::JSLazyEventListener::parseCode):
  17918. * dom/EventListener.h:
  17919. (WebCore::EventListener::jsFunction):
  17920. 2009-04-07 Brady Eidson <beidson@apple.com>
  17921. Reviewed by Darin Adler
  17922. While working on <rdar://problem/5968249>, noticed some glaring problems with LocalStorage.
  17923. * page/DOMWindow.cpp:
  17924. (WebCore::DOMWindow::localStorage): Return the cached m_localStorage object if it exists to
  17925. avoid creating multiple representations for the same underlying StorageArea.
  17926. * page/DOMWindow.h:
  17927. (WebCore::DOMWindow::optionalLocalStorage): Return m_localStorage, not m_sessionStorage.
  17928. 2009-04-07 Darin Adler <darin@apple.com>
  17929. Roll out incorrect build fix.
  17930. * WebCore.NPAPI.exp: Reverted.
  17931. 2009-04-07 Darin Adler <darin@apple.com>
  17932. Another build fix.
  17933. * WebCore.NPAPI.exp: Added new functions.
  17934. 2009-04-07 Anders Carlsson <andersca@apple.com>
  17935. Another build fix.
  17936. * plugins/npfunctions.h:
  17937. 2009-04-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  17938. Unreviewed build fix. Fix non-Mac builds.
  17939. * bridge/npapi.h:
  17940. 2009-04-07 Simon Fraser <simon.fraser@apple.com>
  17941. Reviewed by Dan Bernstein
  17942. https://bugs.webkit.org/show_bug.cgi?id=25082
  17943. Clean up repaint logic when RenderLayers become and stop being composited.
  17944. * rendering/RenderLayer.h:
  17945. * rendering/RenderLayer.cpp:
  17946. (WebCore::RenderLayer::rendererContentChanged):
  17947. (WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
  17948. New compositing-only method that repaints a layer and all its non-composited descendants.
  17949. Takes a repaintContainer for performance; all the repaints necessarily share the same
  17950. repaintContainer.
  17951. * rendering/RenderLayerCompositor.h:
  17952. * rendering/RenderLayerCompositor.cpp:
  17953. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  17954. Rather than use calculateCompositedBounds() to compute the repaint rect (which gave
  17955. the wrong answer when the composited layer tree was in flux), use the new
  17956. repaintOnCompositingChange() method.
  17957. (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
  17958. Call repaintIncludingNonCompositingDescendants(), and if necessary make sure
  17959. that the view/layer drawing synchronization happens.
  17960. (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  17961. Do a repaintOnCompositingChange() when a layer is going to be composited. This is
  17962. a good place because we haven't started to change the compositing tree.
  17963. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  17964. After we've finished updating all the descendant layers, we can do a repaint for
  17965. layers that ceased compositing.
  17966. 2009-04-07 Simon Fraser <simon.fraser@apple.com>
  17967. Reviewed by Dave Hyatt
  17968. https://bugs.webkit.org/show_bug.cgi?id=25069
  17969. Clean up the accelerated compositing code that determines the format of
  17970. the GraphicsLayer hierarchy, being more explicit about which parts have
  17971. to happen before and after descendant layers have been updated. Also remove
  17972. some unhelpful caching of state.
  17973. * dom/Document.cpp:
  17974. (WebCore::Document::recalcStyle):
  17975. Only call updateCompositingLayers() if we know we're not going to be
  17976. doing a layout soon.
  17977. * platform/graphics/mac/GraphicsLayerCA.mm:
  17978. (WebCore::GraphicsLayerCA::setDrawsContent):
  17979. Toggling drawsContent from false to true should do a setNeedsDisplay().
  17980. * rendering/RenderLayer.cpp:
  17981. (WebCore::RenderLayer::styleChanged):
  17982. updateLayerCompositingState() no longer updates the layer geometry, so
  17983. do that here if we're not going to rebuild layers anyway.
  17984. Also, updateLayerCompositingState() no longer does a setContentsNeedDisplay,
  17985. so do that if the style change indicates that a repaint is required.
  17986. * rendering/RenderLayerBacking.h:
  17987. * rendering/RenderLayerBacking.cpp:
  17988. (WebCore::RenderLayerBacking::RenderLayerBacking):
  17989. (WebCore::RenderLayerBacking::updateAfterLayout):
  17990. The 'drawing optimizations' logic has been rolled into updateGraphicsLayerConfiguration()
  17991. and updateGraphicsLayerGeometry().
  17992. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
  17993. Group that code that decides what GraphicsLayers are needed into this method,
  17994. which deals with clipping layers and 'direct compositing': images that can be
  17995. rendered via the compositor.
  17996. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  17997. Call setDrawsContent() if updateGraphicsLayerConfiguration() didn't already
  17998. figure it out for image layers.
  17999. (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
  18000. Remove the m_simpleCompositingLayerStatusDirty cache indicator, since we just
  18001. computed it every time anyway.
  18002. * rendering/RenderLayerCompositor.h:
  18003. * rendering/RenderLayerCompositor.cpp:
  18004. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  18005. updateGraphicsLayers() was renamed to updateGraphicsLayerConfiguration(),
  18006. which calls clippedByAncestor() etc. itself rather than having everything passed in.
  18007. Repaints are taken care of by styleChanged() and setDrawsContent().
  18008. (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  18009. !layer->isComposited() && layer->transform() is a synonym for paintsWithTransform().
  18010. (WebCore::RenderLayerCompositor::setCompositingParent):
  18011. No need to call updateGraphicsLayerGeometry() here, because we're going to
  18012. rebuild layers anyway.
  18013. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  18014. Add comments, and test layerBacking instead of layer->isComposited().
  18015. 2009-04-07 Anders Carlsson <andersca@apple.com>
  18016. Fix build.
  18017. * WebCore.base.exp:
  18018. 2009-04-07 Anders Carlsson <andersca@apple.com>
  18019. Reviewed by Sam Weinig.
  18020. <rdar://problem/6667001> NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()
  18021. * WebCore.base.exp:
  18022. Add symbols needed by WebKit.
  18023. * WebCore.xcodeproj/project.pbxproj:
  18024. Make CookieJar a private header.
  18025. * bridge/npapi.h:
  18026. Add function definitions.
  18027. * plugins/npfunctions.h:
  18028. Fix the NPN_SetValueForURLProcPtr signature.
  18029. 2009-04-07 Adam Roben <aroben@apple.com>
  18030. Fix <rdar://6520933> REGRESSION (3.2.1-ToT): Scroll bar disappears in
  18031. WebView and Bookmarks view after switching theme or turning on High
  18032. Contrast mode
  18033. Reviewed by Dave Hyatt.
  18034. * platform/win/ScrollbarThemeWin.cpp:
  18035. (WebCore::ScrollbarThemeWin::themeChanged): Null out scrollbarTheme
  18036. after closing it so that we'll re-open the theme next time we paint.
  18037. 2009-04-07 Adam Roben <aroben@apple.com>
  18038. Small cleanup/correctness fix in ScrollbarThemeWin
  18039. Reviewed by Dave Hyatt.
  18040. * platform/win/ScrollbarThemeWin.cpp: Removed the now-unused
  18041. haveTheme boolean.
  18042. (WebCore::checkAndInitScrollbarTheme): Check IsThemeActive() before
  18043. calling OpenThemeData. This seems to be what MSDN recommends.
  18044. (WebCore::ScrollbarThemeWin::themeChanged): Null-check scrollbarTheme
  18045. before closing it, rather than indirectly null-checking it via
  18046. checking haveTheme.
  18047. 2009-04-07 Dan Bernstein <mitz@apple.com>
  18048. Reviewed by John Sullivan.
  18049. - when -webkit-line-break: after-white-space is specified but the text
  18050. does not auto-wrap, do not shrink the trailing space to fit in the
  18051. available width
  18052. Test: fast/text/whitespace/nowrap-line-break-after-white-space.html
  18053. - when shrinking such trailing space, do not shrink below zero
  18054. Covered by existing tests
  18055. * rendering/bidi.cpp:
  18056. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  18057. (WebCore::RenderBlock::layoutInlineChildren):
  18058. 2009-04-07 Eric Seidel <eric@webkit.org>
  18059. Reviewed by Darin Adler.
  18060. Move RangeBoundaryPoint off of Position, per Darin's suggestion
  18061. https://bugs.webkit.org/show_bug.cgi?id=24966
  18062. Rename setToChild to setToBeforeChild (since that's what the method does)
  18063. * dom/Position.h:
  18064. (WebCore::Position::offsetInContainerNode):
  18065. * dom/Range.cpp:
  18066. (WebCore::Range::insertNode):
  18067. (WebCore::Range::selectNodeContents):
  18068. (WebCore::boundaryNodeWillBeRemoved):
  18069. * dom/Range.h:
  18070. (WebCore::Range::startPosition):
  18071. (WebCore::Range::endPosition):
  18072. * dom/RangeBoundaryPoint.h:
  18073. (WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
  18074. (WebCore::RangeBoundaryPoint::container):
  18075. (WebCore::RangeBoundaryPoint::childBefore):
  18076. (WebCore::RangeBoundaryPoint::position):
  18077. (WebCore::RangeBoundaryPoint::offset):
  18078. (WebCore::RangeBoundaryPoint::clear):
  18079. (WebCore::RangeBoundaryPoint::set):
  18080. (WebCore::RangeBoundaryPoint::setOffset):
  18081. (WebCore::RangeBoundaryPoint::setToBeforeChild):
  18082. (WebCore::RangeBoundaryPoint::setToStartOfNode):
  18083. (WebCore::RangeBoundaryPoint::setToEndOfNode):
  18084. (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
  18085. (WebCore::RangeBoundaryPoint::invalidateOffset):
  18086. 2009-04-07 Eric Seidel <eric@webkit.org>
  18087. Reviewed by Darin Adler.
  18088. Add containerNode(), computeOffsetInContainerNode(),
  18089. computeNodeBeforePosition() and computeNodeAfterPosition().
  18090. https://bugs.webkit.org/show_bug.cgi?id=24763
  18091. These functions will replace uses of rangeCompliantPosition()
  18092. in future patches.
  18093. No changes in behavior, thus no tests.
  18094. * dom/Position.cpp:
  18095. (WebCore::Position::containerNode):
  18096. (WebCore::Position::computeOffsetInContainerNode):
  18097. (WebCore::Position::computeNodeBeforePosition):
  18098. (WebCore::Position::computeNodeAfterPosition):
  18099. (WebCore::Position::anchorType):
  18100. * dom/Position.h:
  18101. (WebCore::Position::):
  18102. 2009-04-06 Sam Weinig <sam@webkit.org>
  18103. Reviewed by Mark Rowe.
  18104. Bottleneck dispatching mutation events in a new dispatchMutationEvent
  18105. function.
  18106. * dom/CharacterData.cpp:
  18107. (WebCore::CharacterData::dispatchModifiedEvent):
  18108. * dom/ContainerNode.cpp:
  18109. (WebCore::dispatchChildInsertionEvents):
  18110. (WebCore::dispatchChildRemovalEvents):
  18111. * dom/Node.cpp:
  18112. (WebCore::Node::dispatchSubtreeModifiedEvent):
  18113. (WebCore::Node::dispatchMutationEvent):
  18114. * dom/Node.h:
  18115. 2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>
  18116. Reviewed by Darin Fisher.
  18117. https://bugs.webkit.org/show_bug.cgi?id=25059
  18118. Remove references to dominantScript, getGenericFontForScript.
  18119. * platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references
  18120. to getGenericFontForScript.
  18121. (WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.
  18122. * platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
  18123. * rendering/RenderThemeChromiumLinux.cpp:
  18124. (WebCore::defaultGUIFont): Removed Document* arg.
  18125. (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
  18126. * rendering/RenderThemeChromiumLinux.h: Ditto.
  18127. * rendering/RenderThemeChromiumMac.h: Ditto.
  18128. * rendering/RenderThemeChromiumMac.mm: Ditto.
  18129. (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
  18130. * rendering/RenderThemeChromiumWin.cpp:
  18131. (WebCore::defaultGUIFont): Ditto.
  18132. (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
  18133. * rendering/RenderThemeChromiumWin.h: Ditto.
  18134. 2009-04-06 Geoffrey Garen <ggaren@apple.com>
  18135. Reviewed by Darin Adler.
  18136. Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
  18137. Unbounded memory growth when churning elements with anonymous event handler functions
  18138. The problem was that a protected event listener's scope chain would end
  18139. up with a reference to the Node protecting it, causing a cycle. The
  18140. solution is to stop protecting event listeners and rely on marking instead.
  18141. This patch converts most Node event listeners to use marking instead of
  18142. GC protection.
  18143. * bindings/js/JSDOMBinding.cpp:
  18144. (WebCore::isObservableThroughDOM):
  18145. (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node
  18146. needs marking, and added a case for marking the node in order to mark its
  18147. event listeners.
  18148. * bindings/js/JSNodeCustom.cpp:
  18149. (WebCore::markEventListeners):
  18150. (WebCore::JSNode::addEventListener):
  18151. (WebCore::JSNode::removeEventListener):
  18152. (WebCore::JSNode::mark): Added code to mark a Node's event listeners when
  18153. marking the Node. Changed code using protected event listeners to use event
  18154. listeners.
  18155. * dom/Node.idl: Changed code using protected event listeners to use event
  18156. listeners.
  18157. 2009-04-06 Sam Weinig <sam@webkit.org>
  18158. Reviewed by Darin Adler.
  18159. Remove unchecked bool return values for some dispatch event functions.
  18160. * dom/Node.cpp:
  18161. (WebCore::Node::dispatchSubtreeModifiedEvent):
  18162. (WebCore::Node::dispatchUIEvent):
  18163. (WebCore::Node::dispatchWebKitAnimationEvent):
  18164. (WebCore::Node::dispatchWebKitTransitionEvent):
  18165. (WebCore::Node::dispatchProgressEvent):
  18166. * dom/Node.h:
  18167. 2009-04-06 Darin Fisher <darin@chromium.org>
  18168. Reviewed by Dimitri Glazkov.
  18169. https://bugs.webkit.org/show_bug.cgi?id=25058
  18170. Fix chromium build bustage caused by r42216
  18171. * bindings/scripts/CodeGeneratorJS.pm:
  18172. * page/DOMWindow.idl:
  18173. 2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  18174. Rubber-stamped by Sam Weinig.
  18175. https://bugs.webkit.org/show_bug.cgi?id=20575
  18176. No localization in WebKitGtk
  18177. * platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h,
  18178. since there are not translatable strings.
  18179. * platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header
  18180. that is specific for libraries.
  18181. 2009-04-06 Mike Belshe <mike@belshe.com>
  18182. Reviewed by Dimitri Glazkov.
  18183. https://bugs.webkit.org/show_bug.cgi?id=24978
  18184. Use custom implementations of a few Node methods so that
  18185. we don't over-aggressively create JS wrappers here.
  18186. * bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
  18187. * dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.
  18188. 2009-04-06 Dave Moore <davemoore@google.com>
  18189. Reviewed by Dimitri Glazkov.
  18190. https://bugs.webkit.org/show_bug.cgi?id=25031
  18191. Make the V8 element collections check for named properties *before*
  18192. checking if there are any elements with the same name. Otherwise
  18193. it is both incorrect and slow.
  18194. Test: fast/dom/HTMLSelectElement/length-not-overridden.html
  18195. Both of these interceptors were attempting to find an element in the
  18196. collection that had a name or id of the property name before checking
  18197. for a JS property with that name.
  18198. * bindings/v8/V8Collection.h:
  18199. (WebCore::collectionNamedPropertyGetter):
  18200. (WebCore::nodeCollectionNamedPropertyGetter):
  18201. 2009-04-06 Simon Fraser <simon.fraser@apple.com>
  18202. Reviewed by Darin Adler
  18203. https://bugs.webkit.org/show_bug.cgi?id=25052
  18204. Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
  18205. because we need to call it at the end of rebuildCompositingLayerTree() once
  18206. we've determined which descendant layers are composited, otherwise
  18207. calculateCompositedBounds() can give the wrong answer.
  18208. Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
  18209. call that explicitly from styleChanged(), if we know a layer update is not pending,
  18210. and similarly from updateAfterLayout().
  18211. Test: compositing/overflow/overflow-positioning.html
  18212. * rendering/RenderLayer.cpp:
  18213. (WebCore::RenderLayer::styleChanged):
  18214. * rendering/RenderLayerBacking.cpp:
  18215. (WebCore::RenderLayerBacking::updateAfterLayout):
  18216. (WebCore::RenderLayerBacking::updateGraphicsLayers):
  18217. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  18218. * rendering/RenderLayerCompositor.cpp:
  18219. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  18220. 2009-04-06 Mike Belshe <mike@belshe.com>
  18221. Reviewed by Alexey Proskuryakov.
  18222. Add accessors to AtomicString which take String/const char* arguments
  18223. so that we don't accidentally thrash the AtomicString table.
  18224. https://bugs.webkit.org/show_bug.cgi?id=24979
  18225. * platform/text/AtomicString.h:
  18226. 2009-04-03 Holger Hans Peter Freyther <zecke@selfish.org>
  18227. Reviewed by Simon Hausmann.
  18228. Make col and row work in WebCore/manual-tests/cursor.html. The issue
  18229. was spotted in the WebKit inspector.
  18230. * platform/gtk/CursorGtk.cpp:
  18231. (WebCore::columnResizeCursor):
  18232. (WebCore::rowResizeCursor):
  18233. 2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  18234. Reviewed by Simon Hausmann.
  18235. [Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
  18236. * plugins/mac/PluginViewMac.cpp:
  18237. (WebCore::PluginView::show):
  18238. (WebCore::PluginView::hide):
  18239. (WebCore::PluginView::setParentVisible):
  18240. 2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
  18241. Reviewed by Tor Arne Vestbø.
  18242. Add new files to the Qt build.
  18243. Export helper function from the Qt JSC binding, needed in WebKit/qt.
  18244. * WebCore.pro: Add new files.
  18245. * bridge/qt/qt_runtime.h: Declare convertQVariantToValue.
  18246. 2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
  18247. Reviewed by Tor Arne Vestbø.
  18248. Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.
  18249. Internally the function name is stored as a WebCore::String and the Qt port wants to use this
  18250. constructor programmatically where the function name is also a WebCore::String.
  18251. * bindings/js/ScriptFunctionCall.cpp:
  18252. (WebCore::ScriptFunctionCall::ScriptFunctionCall):
  18253. * bindings/js/ScriptFunctionCall.h:
  18254. 2009-04-06 Mike Belshe <mike@belshe.com>
  18255. Reviewed by Eric Seidel.
  18256. HTMLCanvasElement crash when ImageBuffer creation fails.
  18257. https://bugs.webkit.org/show_bug.cgi?id=23212
  18258. Check for NULL before using the ImageBuffer as we might
  18259. be low on memory and creation may have failed.
  18260. Test case creation blocked by:
  18261. https://bugs.webkit.org/show_bug.cgi?id=25055
  18262. * html/HTMLCanvasElement.cpp:
  18263. (WebCore::HTMLCanvasElement::createImageBuffer):
  18264. 2009-04-05 Geoffrey Garen <ggaren@apple.com>
  18265. [Originally] Reviewed by Sam Weinig.
  18266. Rolled back in r42214 with crashes fixed.
  18267. [Removed irrelevant ExecState* parameter from event handler registration code.]
  18268. [No change in behavior.]
  18269. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  18270. (WebCore::JSDOMApplicationCache::addEventListener):
  18271. (WebCore::JSDOMApplicationCache::removeEventListener):
  18272. * bindings/js/JSDOMGlobalObject.cpp:
  18273. (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
  18274. (WebCore::JSDOMGlobalObject::findJSEventListener):
  18275. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  18276. * bindings/js/JSDOMGlobalObject.h:
  18277. * bindings/js/JSDOMWindowCustom.cpp:
  18278. (WebCore::JSDOMWindow::addEventListener):
  18279. * bindings/js/JSMessagePortCustom.cpp:
  18280. (WebCore::JSMessagePort::addEventListener):
  18281. (WebCore::JSMessagePort::removeEventListener):
  18282. * bindings/js/JSNodeCustom.cpp:
  18283. (WebCore::JSNode::addEventListener):
  18284. * bindings/js/JSSVGElementInstanceCustom.cpp:
  18285. (WebCore::JSSVGElementInstance::addEventListener):
  18286. * bindings/js/JSWorkerContextCustom.cpp:
  18287. (WebCore::JSWorkerContext::addEventListener):
  18288. (WebCore::JSWorkerContext::removeEventListener):
  18289. * bindings/js/JSWorkerCustom.cpp:
  18290. (WebCore::JSWorker::addEventListener):
  18291. (WebCore::JSWorker::removeEventListener):
  18292. * bindings/js/JSXMLHttpRequestCustom.cpp:
  18293. (WebCore::JSXMLHttpRequest::addEventListener):
  18294. (WebCore::JSXMLHttpRequest::removeEventListener):
  18295. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  18296. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  18297. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  18298. * bindings/scripts/CodeGeneratorJS.pm:
  18299. 2009-04-05 Erik L. Bunce <elbunce@xendom.com>
  18300. Reviewed by Simon Hausmann.
  18301. https://bugs.webkit.org/show_bug.cgi?id=25050
  18302. Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
  18303. * platform/qt/DragDataQt.cpp:
  18304. (WebCore::DragData::asURL):
  18305. 2009-04-05 Simon Hausmann <hausmann@webkit.org>
  18306. Fix the Qt build.
  18307. * bridge/qt/qt_runtime.h:
  18308. (JSC::Bindings::QtRuntimeMethod::createPrototype): Take the JSGlobalObject
  18309. as second argument.
  18310. 2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
  18311. Build fixes for wxMac/Tiger.
  18312. * platform/wx/wxcode/mac/carbon/fontprops.cpp:
  18313. (wxFontProperties::wxFontProperties):
  18314. * rendering/break_lines.cpp:
  18315. (WebCore::nextBreakablePosition):
  18316. * webcore-wx.bkl:
  18317. 2009-04-04 Simon Fraser <simon.fraser@apple.com>
  18318. Reviewed by Cameron Zwarich
  18319. https://bugs.webkit.org/show_bug.cgi?id=24648
  18320. Ensure that mapPoint(const IntPoint&) calls the FloatPoint
  18321. version to avoid infinite recursion.
  18322. No test because mapPoint(const IntPoint&) isn't ever called
  18323. on Mac, so I can't reproduce.
  18324. * platform/graphics/transforms/TransformationMatrix.h:
  18325. (WebCore::TransformationMatrix::mapPoint):
  18326. 2009-04-04 Dan Bernstein <mitz@apple.com>
  18327. Reviewed by Mark Rowe.
  18328. - fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place
  18329. the insertion point inside a Thai character
  18330. Test: fast/text/international/thai-offsetForPosition-inside-character.html
  18331. * platform/graphics/mac/CoreTextController.cpp:
  18332. (WebCore::CoreTextController::offsetForPosition): Changed to use
  18333. cursorMovementIterator instead of characterBreakIterator, allowing this
  18334. function to return a valid cursor position even if it is not at
  18335. a character boundary.
  18336. 2009-04-04 Dan Bernstein <mitz@apple.com>
  18337. Reviewed by Mark Rowe.
  18338. - fix an assertion failure when clicking at the beginning of a
  18339. glyph cluster at the beginning of a text run
  18340. Test: fast/text/offsetForPosition-cluster-at-zero.html
  18341. * platform/graphics/mac/CoreTextController.cpp:
  18342. (WebCore::CoreTextController::offsetForPosition): Corrected the bound
  18343. check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less
  18344. than -1.
  18345. 2009-04-03 Brian Weinstein <bweinstein@gmail.com>
  18346. Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
  18347. when the names are given.
  18348. https://bugs.webkit.org/show_bug.cgi?id=25044
  18349. Reviewed by Timothy Hatcher.
  18350. * inspector/front-end/StylesSidebarPane.js:
  18351. (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
  18352. 2009-04-03 Sam Weinig <sam@webkit.org>
  18353. Reviewed by Darin Adler.
  18354. <rdar://problem/6330929>
  18355. https://bugs.webkit.org/show_bug.cgi?id=21456
  18356. Don't update the document pointer for all inactive windows on navigations.
  18357. This change causes us to differ slightly from Firefox when accessing the
  18358. document from within a closure tied to a navigated context, but as all
  18359. browsers differ on this edge case, I don't foresee compatibility issues.
  18360. Test: http/tests/security/cross-frame-access-document-direct.html
  18361. * bindings/js/JSDOMWindowBase.cpp:
  18362. (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  18363. * bindings/js/ScriptController.cpp:
  18364. (WebCore::ScriptController::clearWindowShell):
  18365. (WebCore::ScriptController::initScript):
  18366. (WebCore::ScriptController::updateDocument):
  18367. * bindings/js/ScriptController.h:
  18368. 2009-04-03 Chris Marrin <cmarrin@apple.com>
  18369. Reviewed by Simon Fraser.
  18370. Test: transitions/bad-transition-shorthand-crash.html
  18371. Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.
  18372. We were starting transitions with 0 duration and delay, which is
  18373. useless. With accelerated compositing on, this went through a code
  18374. path that tried to use m_toStyle, which never got set because the
  18375. transitions was short circuited before it had a chance to. So I
  18376. both protect against using that null pointer and avoid starting
  18377. the transition in the first place.
  18378. * page/animation/CompositeAnimation.cpp:
  18379. (WebCore::CompositeAnimationPrivate::updateTransitions):
  18380. * page/animation/ImplicitAnimation.cpp:
  18381. (WebCore::ImplicitAnimation::blendPropertyValueInStyle):
  18382. 2009-04-03 Timothy Hatcher <timothy@apple.com>
  18383. Fixes a bug where you could not type any more in the Web Inspector's
  18384. search field after the first match is selected in the Resources panel.
  18385. https://bugs.webkit.org/show_bug.cgi?id=23982
  18386. rdar://problem/6592367
  18387. Reviewed by Darin Adler.
  18388. * inspector/front-end/SourceView.js:
  18389. (WebInspector.SourceView.prototype._jumpToSearchResult): Use the
  18390. window object of the frame to set the selection, not the main window.
  18391. 2009-04-03 Sam Weinig <sam@webkit.org>
  18392. Reviewed by Anders Carlsson.
  18393. Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
  18394. <rdar://problem/6346030>
  18395. Don't allow overriding the return value of window.location.
  18396. Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html
  18397. fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
  18398. fast/dom/Window/Location/location-override-toString-on-proto.html
  18399. fast/dom/Window/Location/location-override-toString-using-defineGetter.html
  18400. fast/dom/Window/Location/location-override-toString-using-with.html
  18401. fast/dom/Window/Location/location-override-toString.html
  18402. fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
  18403. fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
  18404. fast/dom/Window/Location/location-override-valueOf-on-proto.html
  18405. fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
  18406. fast/dom/Window/Location/location-override-valueOf-using-with.html
  18407. fast/dom/Window/Location/location-override-valueOf.html
  18408. fast/dom/Window/Location/window-override-location-using-defineGetter.html
  18409. fast/dom/Window/Location/window-override-window-using-defineGetter.html
  18410. fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
  18411. fast/dom/Window/Location/window-shadow-location-using-string.html
  18412. fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html
  18413. * bindings/js/JSDOMWindowCustom.cpp:
  18414. (WebCore::JSDOMWindow::defineGetter):
  18415. * bindings/js/JSLocationCustom.cpp:
  18416. (WebCore::JSLocation::customPut):
  18417. (WebCore::JSLocation::defineGetter):
  18418. (WebCore::JSLocationPrototype::customPut):
  18419. (WebCore::JSLocationPrototype::defineGetter):
  18420. * bindings/scripts/CodeGeneratorJS.pm:
  18421. * page/Location.idl:
  18422. 2009-04-03 Geoffrey Garen <ggaren@apple.com>
  18423. Rolled out r42214 since it seems to have caused crashes on the buildbot.
  18424. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  18425. (WebCore::JSDOMApplicationCache::addEventListener):
  18426. (WebCore::JSDOMApplicationCache::removeEventListener):
  18427. * bindings/js/JSDOMGlobalObject.cpp:
  18428. (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
  18429. (WebCore::JSDOMGlobalObject::findJSEventListener):
  18430. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  18431. * bindings/js/JSDOMGlobalObject.h:
  18432. * bindings/js/JSDOMWindowCustom.cpp:
  18433. (WebCore::JSDOMWindow::addEventListener):
  18434. * bindings/js/JSMessagePortCustom.cpp:
  18435. (WebCore::JSMessagePort::addEventListener):
  18436. (WebCore::JSMessagePort::removeEventListener):
  18437. * bindings/js/JSNodeCustom.cpp:
  18438. (WebCore::JSNode::addEventListener):
  18439. (WebCore::JSNode::removeEventListener):
  18440. * bindings/js/JSSVGElementInstanceCustom.cpp:
  18441. (WebCore::JSSVGElementInstance::addEventListener):
  18442. * bindings/js/JSWorkerContextCustom.cpp:
  18443. (WebCore::JSWorkerContext::addEventListener):
  18444. (WebCore::JSWorkerContext::removeEventListener):
  18445. * bindings/js/JSWorkerCustom.cpp:
  18446. (WebCore::JSWorker::addEventListener):
  18447. (WebCore::JSWorker::removeEventListener):
  18448. * bindings/js/JSXMLHttpRequestCustom.cpp:
  18449. (WebCore::JSXMLHttpRequest::addEventListener):
  18450. (WebCore::JSXMLHttpRequest::removeEventListener):
  18451. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  18452. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  18453. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  18454. * bindings/scripts/CodeGeneratorJS.pm:
  18455. 2009-04-03 Sam Weinig <sam@webkit.org>
  18456. Reviewed by Oliver Hunt.
  18457. Fix for <rdar://problem/6476356>
  18458. https://bugs.webkit.org/show_bug.cgi?id=23148
  18459. - Use the window object the Location and History objects are directly associated with
  18460. instead of the lexical global object to pick the object prototype to serve as the
  18461. base of the their respective prototype chains.
  18462. - Re-factor as necessary to allow passing the correct global object to the createPrototype
  18463. functions.
  18464. Tests: http/tests/security/cross-frame-access-history-prototype.html
  18465. http/tests/security/cross-frame-access-location-prototype.html
  18466. * bindings/js/JSAudioConstructor.cpp:
  18467. (WebCore::JSAudioConstructor::JSAudioConstructor):
  18468. * bindings/js/JSDOMBinding.cpp:
  18469. (WebCore::getCachedDOMStructure):
  18470. (WebCore::cacheDOMStructure):
  18471. * bindings/js/JSDOMBinding.h:
  18472. (WebCore::getDOMStructure):
  18473. (WebCore::getDOMPrototype):
  18474. * bindings/js/JSDOMWindowCustom.cpp:
  18475. (WebCore::JSDOMWindow::history):
  18476. (WebCore::JSDOMWindow::location):
  18477. * bindings/js/JSDocumentCustom.cpp:
  18478. (WebCore::JSDocument::location):
  18479. * bindings/js/JSImageConstructor.cpp:
  18480. (WebCore::JSImageConstructor::JSImageConstructor):
  18481. * bindings/js/JSMessageChannelConstructor.cpp:
  18482. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  18483. * bindings/js/JSNamedNodesCollection.h:
  18484. (WebCore::JSNamedNodesCollection::createPrototype):
  18485. * bindings/js/JSOptionConstructor.cpp:
  18486. (WebCore::JSOptionConstructor::JSOptionConstructor):
  18487. * bindings/js/JSRGBColor.h:
  18488. (WebCore::JSRGBColor::createPrototype):
  18489. * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
  18490. (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  18491. * bindings/js/JSWebKitPointConstructor.cpp:
  18492. (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  18493. * bindings/js/JSWorkerConstructor.cpp:
  18494. (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  18495. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  18496. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  18497. * bindings/js/JSXSLTProcessorConstructor.cpp:
  18498. (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  18499. * bindings/scripts/CodeGeneratorJS.pm:
  18500. * bridge/objc/objc_runtime.h:
  18501. (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
  18502. * bridge/runtime_array.h:
  18503. (JSC::RuntimeArray::createPrototype):
  18504. * bridge/runtime_method.h:
  18505. (JSC::RuntimeMethod::createPrototype):
  18506. * bridge/runtime_object.h:
  18507. (JSC::RuntimeObjectImp::createPrototype):
  18508. * page/DOMWindow.idl:
  18509. 2009-04-03 Jian Li <jianli@chromium.org>
  18510. Reviewed by Darin Fisher.
  18511. https://bugs.webkit.org/show_bug.cgi?id=25009
  18512. Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.
  18513. * bindings/v8/WorkerContextExecutionProxy.cpp:
  18514. (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
  18515. (WebCore::WorkerContextExecutionProxy::dispose):
  18516. (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
  18517. (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
  18518. * bindings/v8/WorkerContextExecutionProxy.h:
  18519. 2009-04-03 Geoffrey Garen <ggaren@apple.com>
  18520. Reviewed by Sam Weinig.
  18521. Removed irrelevant ExecState* parameter from event handler registration code.
  18522. No change in behavior.
  18523. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  18524. (WebCore::JSDOMApplicationCache::addEventListener):
  18525. (WebCore::JSDOMApplicationCache::removeEventListener):
  18526. * bindings/js/JSDOMGlobalObject.cpp:
  18527. (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
  18528. (WebCore::JSDOMGlobalObject::findJSEventListener):
  18529. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  18530. * bindings/js/JSDOMGlobalObject.h:
  18531. * bindings/js/JSDOMWindowCustom.cpp:
  18532. (WebCore::JSDOMWindow::addEventListener):
  18533. * bindings/js/JSMessagePortCustom.cpp:
  18534. (WebCore::JSMessagePort::addEventListener):
  18535. (WebCore::JSMessagePort::removeEventListener):
  18536. * bindings/js/JSNodeCustom.cpp:
  18537. (WebCore::JSNode::addEventListener):
  18538. (WebCore::JSNode::removeEventListener):
  18539. * bindings/js/JSSVGElementInstanceCustom.cpp:
  18540. (WebCore::JSSVGElementInstance::addEventListener):
  18541. * bindings/js/JSWorkerContextCustom.cpp:
  18542. (WebCore::JSWorkerContext::addEventListener):
  18543. (WebCore::JSWorkerContext::removeEventListener):
  18544. * bindings/js/JSWorkerCustom.cpp:
  18545. (WebCore::JSWorker::addEventListener):
  18546. (WebCore::JSWorker::removeEventListener):
  18547. * bindings/js/JSXMLHttpRequestCustom.cpp:
  18548. (WebCore::JSXMLHttpRequest::addEventListener):
  18549. (WebCore::JSXMLHttpRequest::removeEventListener):
  18550. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  18551. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  18552. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  18553. * bindings/scripts/CodeGeneratorJS.pm:
  18554. 2009-04-03 Dan Bernstein <mitz@apple.com>
  18555. Reviewed by Simon Fraser.
  18556. - fix <rdar://problem/6634771> Under full-page zoom, cannot scroll
  18557. MobileMe contact list
  18558. Test: fast/css/zoom-in-length-round-trip.html
  18559. * dom/Element.cpp:
  18560. (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure
  18561. that the returned value is equal to the original unscaled value.
  18562. (WebCore::adjustForAbsoluteZoom): Ditto.
  18563. 2009-04-03 Chris Marrin <cmarrin@apple.com>
  18564. Reviewed by David Hyatt.
  18565. Fixed https://bugs.webkit.org/show_bug.cgi?id=24941
  18566. This fix essentially does a -viewWillDraw call for layout. It adds
  18567. a CFRunLoopObserver which performs layout just before drawing on the
  18568. Mac platform. This makes sure layout is complete before rendering and
  18569. avoids a flash.
  18570. * page/ChromeClient.h:
  18571. (WebCore::ChromeClient::scheduleViewUpdate):
  18572. * rendering/RenderLayerCompositor.cpp:
  18573. (WebCore::RenderLayerCompositor::setCompositingLayersNeedUpdate):
  18574. (WebCore::RenderLayerCompositor::scheduleViewUpdate):
  18575. * rendering/RenderLayerCompositor.h:
  18576. 2009-04-02 Simon Fraser <simon.fraser@apple.com>
  18577. Reviewed by Dan Bernstein
  18578. https://bugs.webkit.org/show_bug.cgi?id=24648
  18579. Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.
  18580. * platform/graphics/transforms/TransformationMatrix.cpp:
  18581. (WebCore::TransformationMatrix::mapPoint):
  18582. (WebCore::TransformationMatrix::mapRect):
  18583. (WebCore::TransformationMatrix::mapQuad):
  18584. * platform/graphics/transforms/TransformationMatrix.h:
  18585. (WebCore::TransformationMatrix::mapPoint):
  18586. 2009-04-02 Simon Fraser <simon.fraser@apple.com>
  18587. Reviewed by Dan Bernstein
  18588. https://bugs.webkit.org/show_bug.cgi?id=25018
  18589. Add containsPoint() and containsQuad() methods to FloatQuad.
  18590. * platform/graphics/FloatQuad.cpp:
  18591. (WebCore::dot):
  18592. (WebCore::isPointInTriangle):
  18593. (WebCore::FloatQuad::containsPoint):
  18594. (WebCore::FloatQuad::containsQuad):
  18595. * platform/graphics/FloatQuad.h:
  18596. 2009-04-03 Kevin Decker <kdecker@apple.com>
  18597. Reviewed by Darin.
  18598. * loader/ProgressTracker.cpp: Included DocumentLoader.h
  18599. (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to
  18600. documents that use WebCore's layout system.
  18601. 2009-04-03 Eric Carlson <eric.carlson@apple.com>
  18602. Reviewed by Simon Fraser.
  18603. https://bugs.webkit.org/show_bug.cgi?id=25029
  18604. <rdar://problem/6336092> REGRESSION: movie does not resize correctly
  18605. Test: media/video-size-intrinsic-scale.html
  18606. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  18607. (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead
  18608. of QTMovieNaturalSizeAttribute so we return the correct size for movies saved
  18609. with a non-default matrix.
  18610. (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView
  18611. because [QTMovieView setFrame] also resizes the movie itself, and as
  18612. the renderer calls setSize immediately when a movie reports a size change
  18613. (QTMovieSizeDidChangeNotification) we can get into a feedback loop
  18614. observing the size change and resetting the size, and this can cause
  18615. QuickTime to miss correctly setting a movie's size when the media size
  18616. changes after opening (as happens with an rtsp movie once the server sends
  18617. the track sizes). Instead, remember the size passed to paint() and
  18618. resize the view when it changes.
  18619. (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.
  18620. * platform/graphics/win/QTMovieWin.cpp:
  18621. (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect
  18622. so we return the correct size for movies saved with non-default matrix.
  18623. 2009-04-03 Darin Fisher <darin@chromium.org>
  18624. Reviewed by Darin Adler.
  18625. Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
  18626. https://bugs.webkit.org/show_bug.cgi?id=25028
  18627. * loader/FrameLoader.h:
  18628. (WebCore::FrameLoader::policyDocumentLoader):
  18629. 2009-04-02 Michael Nordman <michaeln@google.com>
  18630. Reviewed by Alexey Proskuryakov.
  18631. Use long long, not int64, when working in webcore (sorry).
  18632. https://bugs.webkit.org/show_bug.cgi?id=25011
  18633. No change in functionality, so no tests.
  18634. * platform/network/chromium/ResourceResponse.h:
  18635. (WebCore::ResourceResponse::getAppCacheID):
  18636. (WebCore::ResourceResponse::setAppCacheID):
  18637. 2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  18638. Reviewed by Holger Freyther.
  18639. Remove pre-processor checks for GTK+ >= 2.10, since we now require
  18640. at least that version.
  18641. * platform/graphics/gtk/FontPlatformDataGtk.cpp:
  18642. (WebCore::FontPlatformData::FontPlatformData):
  18643. * platform/gtk/ContextMenuItemGtk.cpp:
  18644. (WebCore::gtkStockIDFromContextMenuAction):
  18645. * platform/gtk/KeyEventGtk.cpp:
  18646. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  18647. * platform/gtk/LocalizedStringsGtk.cpp:
  18648. (WebCore::contextMenuItemTagSelectAll):
  18649. * platform/gtk/MouseEventGtk.cpp:
  18650. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  18651. * platform/gtk/PasteboardGtk.cpp:
  18652. (WebCore::Pasteboard::writeSelection):
  18653. (WebCore::Pasteboard::documentFragment):
  18654. * platform/gtk/WheelEventGtk.cpp:
  18655. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  18656. 2009-04-02 Simon Fraser <simon.fraser@apple.com>
  18657. Reviewed by Dan Bernstein
  18658. https://bugs.webkit.org/show_bug.cgi?id=25021
  18659. Fix repainting an element with a reflection and transform after layout.
  18660. Telling the reflection to repaint directly is wrong, because, with
  18661. LayoutState enabled, it only takes the reflection's transform into account,
  18662. not that of the element. We can fix this, and keep the benefits of LayoutState,
  18663. by computing the reflected repaint rect, and repainting that using the original
  18664. renderer.
  18665. Test: fast/repaint/reflection-repaint-test.html
  18666. * rendering/RenderBlock.cpp:
  18667. (WebCore::RenderBlock::layoutBlock):
  18668. 2009-04-02 Simon Fraser <simon.fraser@apple.com>
  18669. Reviewed by Dan Bernstein
  18670. https://bugs.webkit.org/show_bug.cgi?id=23307
  18671. When repainting during layout (when LayoutState is enabled), we need
  18672. to apply the transform to the dirty rect, before applying x(), y() and
  18673. the offset storted in the LayoutState.
  18674. Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
  18675. since LayoutState is always root-relative.
  18676. Test: fast/repaint/transform-layout-repaint.html
  18677. * rendering/RenderBox.cpp:
  18678. (WebCore::RenderBox::mapLocalToContainer):
  18679. (WebCore::RenderBox::computeRectForRepaint):
  18680. 2009-04-02 Mark Rowe <mrowe@apple.com>
  18681. Fix the Mac build after r42191.
  18682. * WebCore.base.exp:
  18683. 2009-04-02 Mark Rowe <mrowe@apple.com>
  18684. Fix Windows build after r42190.
  18685. * page/EventHandler.cpp:
  18686. (WebCore::EventHandler::keyEvent): Update to use the new name of the constant.
  18687. 2009-04-02 Darin Adler <darin@apple.com>
  18688. Reviewed by Brady Eidson.
  18689. <rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/
  18690. Test: http/tests/navigation/onload-navigation-iframe-2.html
  18691. * html/HTMLFrameElement.cpp:
  18692. (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
  18693. * html/HTMLFrameElement.h: Ditto.
  18694. * html/HTMLFrameElementBase.cpp:
  18695. (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
  18696. * html/HTMLFrameElementBase.h: Ditto.
  18697. * html/HTMLFrameOwnerElement.cpp:
  18698. (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
  18699. * html/HTMLFrameOwnerElement.h: Ditto.
  18700. * html/HTMLIFrameElement.cpp:
  18701. (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
  18702. * html/HTMLIFrameElement.h: Ditto.
  18703. * html/HTMLPlugInElement.cpp:
  18704. (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.
  18705. * loader/FrameLoader.cpp:
  18706. (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag.
  18707. The original change that introduced this, http://trac.webkit.org/changeset/25410, does
  18708. not make it clear why this check was needed. And it seems it is not needed.
  18709. 2009-04-02 Adele Peterson <adele@apple.com>
  18710. Reviewed by Darin Adler.
  18711. Add a way to get a list of focusable nodes.
  18712. * dom/Document.cpp:
  18713. (WebCore::Document::setFocusedNode):
  18714. (WebCore::Document::getFocusableNodes):
  18715. * dom/Document.h:
  18716. 2009-04-02 Darin Adler <darin@apple.com>
  18717. Reviewed by Sam Weinig.
  18718. <rdar://problem/6654255> crash due to null FrameView in EventHandler
  18719. Lots of code was added to EventHandler that used view() and page() without
  18720. null checking, but both of those can become null due to the frame lifetime.
  18721. * page/EventHandler.cpp:
  18722. (WebCore::EventHandler::handleMousePressEventSingleClick):
  18723. (WebCore::EventHandler::eventMayStartDrag):
  18724. (WebCore::EventHandler::handleAutoscroll):
  18725. (WebCore::EventHandler::autoscrollTimerFired):
  18726. (WebCore::EventHandler::setPanScrollCursor):
  18727. (WebCore::EventHandler::allowDHTMLDrag):
  18728. (WebCore::EventHandler::hitTestResultAtPoint):
  18729. (WebCore::EventHandler::stopAutoscrollTimer):
  18730. (WebCore::EventHandler::selectCursor):
  18731. (WebCore::EventHandler::handleMousePressEvent):
  18732. (WebCore::EventHandler::handleMouseMoveEvent):
  18733. (WebCore::EventHandler::dispatchDragEvent):
  18734. (WebCore::EventHandler::prepareMouseEvent):
  18735. (WebCore::EventHandler::dispatchMouseEvent):
  18736. (WebCore::EventHandler::handleWheelEvent):
  18737. (WebCore::EventHandler::hoverTimerFired):
  18738. (WebCore::EventHandler::keyEvent):
  18739. (WebCore::EventHandler::dragHysteresisExceeded):
  18740. (WebCore::EventHandler::shouldDragAutoNode):
  18741. (WebCore::EventHandler::handleDrag):
  18742. (WebCore::EventHandler::handleTextInputEvent):
  18743. (WebCore::EventHandler::addPendingFrameUnloadEventCount):
  18744. (WebCore::EventHandler::removePendingFrameUnloadEventCount):
  18745. (WebCore::EventHandler::clearPendingFrameUnloadEventCount):
  18746. (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount):
  18747. (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount):
  18748. (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount):
  18749. Added null checks for view() and page(). Made minor code cleanups.
  18750. 2009-04-02 David Hyatt <hyatt@apple.com>
  18751. Reviewed by Oliver Hunt.
  18752. Fix regression in <object> layout test. Make sure that even though a 404 image loads, that <object>
  18753. still considers it an error for the purposes of firing onerror.
  18754. * html/HTMLImageLoader.cpp:
  18755. (WebCore::HTMLImageLoader::dispatchLoadEvent):
  18756. 2009-04-02 Dimitri Glazkov <dglazkov@chromium.org>
  18757. Reviewed by Timothy Hatcher.
  18758. https://bugs.webkit.org/show_bug.cgi?id=25010
  18759. Refactor InspectorController to replace all JS function invocations with
  18760. ScriptFunctionCall.
  18761. * bindings/js/ScriptFunctionCall.cpp:
  18762. (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,
  18763. and JSValuePtr methods.
  18764. (WebCore::ScriptFunctionCall::call): Added simplified, exception-eating
  18765. method.
  18766. * bindings/js/ScriptFunctionCall.h: Decls for above.
  18767. * bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow.
  18768. (WebCore::getQuarantinedScriptObject):
  18769. * bindings/js/ScriptObjectQuarantine.h: Decls for above.
  18770. * inspector/InspectorController.cpp:
  18771. (WebCore::callSimpleFunction): Made into a static.
  18772. (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall.
  18773. (WebCore::InspectorController::toggleRecordButton): Ditto.
  18774. (WebCore::InspectorController::startGroup): Ditto.
  18775. (WebCore::InspectorController::setAttachedWindow): Ditto.
  18776. (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto.
  18777. (WebCore::InspectorController::addScriptProfile): Ditto.
  18778. (WebCore::InspectorController::didParseSource): Ditto.
  18779. (WebCore::InspectorController::failedToParseSource): Ditto.
  18780. (WebCore::InspectorController::didPause): Ditto.
  18781. * inspector/InspectorController.h: Removed callFunction and callSimpleFunction
  18782. decls.
  18783. 2009-04-02 Jian Li <jianli@chromium.org>
  18784. Reviewed by Darin Fisher.
  18785. Upstream changes to V8WorkerContextEventListener for V8 bindings.
  18786. https://bugs.webkit.org/show_bug.cgi?id=25007
  18787. * bindings/v8/V8ObjectEventListener.h:
  18788. * bindings/v8/V8WorkerContextEventListener.cpp:
  18789. 2009-04-02 Jian Li <jianli@chromium.org>
  18790. Reviewed by Darin Fisher.
  18791. Upstream V8WorkerContextObjectEventListener for V8 bindings.
  18792. https://bugs.webkit.org/show_bug.cgi?id=25005
  18793. * bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
  18794. * bindings/v8/V8WorkerContextObjectEventListener.h: Added.
  18795. 2009-04-02 Jian Li <jianli@chromium.org>
  18796. Reviewed by Darin Fisher.
  18797. Upstream V8EventListenerList for V8 bindings.
  18798. https://bugs.webkit.org/show_bug.cgi?id=25004
  18799. * bindings/v8/V8EventListenerList.cpp: Added.
  18800. * bindings/v8/V8EventListenerList.h: Added.
  18801. 2009-04-02 Michael Nordman <michaeln@google.com>
  18802. Reviewed by Darin Fisher.
  18803. Chromium's ResourceRequest and ResourceResponse structs need some new data members.
  18804. https://bugs.webkit.org/show_bug.cgi?id=24897
  18805. These fields are needed to facilitate Chromium's implementation of the HTML5
  18806. ApplicationCache feature. We need to know what frame (or context) is doing the
  18807. requesting, and from what cache the resulting resource was retrieved.
  18808. No change in functionality, so no tests.
  18809. * platform/network/chromium/ResourceRequest.h:
  18810. (WebCore::ResourceRequest::ResourceRequest):
  18811. (WebCore::ResourceRequest::appCacheContextID):
  18812. (WebCore::ResourceRequest::setAppCacheContextID):
  18813. * platform/network/chromium/ResourceResponse.h:
  18814. (WebCore::ResourceResponse::ResourceResponse):
  18815. (WebCore::ResourceResponse::getAppCacheID):
  18816. (WebCore::ResourceResponse::setAppCacheID):
  18817. 2009-04-02 David Hyatt <hyatt@apple.com>
  18818. Reviewed by Darin Adler
  18819. Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.
  18820. Make sure images just ignore HTTP error codes and keep loading anyway. Only <object> checks http error codes and falls back. Everyone
  18821. else just ignores it and displays the image anyway.
  18822. Added http/tests/misc/image-error.html
  18823. * html/HTMLImageLoader.cpp:
  18824. (WebCore::HTMLImageLoader::notifyFinished):
  18825. * loader/CachedImage.cpp:
  18826. (WebCore::CachedImage::CachedImage):
  18827. * loader/CachedImage.h:
  18828. (WebCore::CachedImage::httpStatusCodeError):
  18829. (WebCore::CachedImage::httpStatusCodeErrorOccurred):
  18830. * loader/CachedResource.h:
  18831. (WebCore::CachedResource::httpStatusCodeError):
  18832. * loader/loader.cpp:
  18833. (WebCore::Loader::Host::didReceiveData):
  18834. 2009-04-02 Jian Li <jianli@chromium.org>
  18835. Reviewed by Dimitri Glazkov.
  18836. Add XHR constructor in WorkerContext.idl for V8 bindings.
  18837. https://bugs.webkit.org/show_bug.cgi?id=24962
  18838. * workers/WorkerContext.idl:
  18839. 2009-04-02 Ben Murdoch <benm@google.com>
  18840. Fix Bug 19743: Release build fails on 32-bit Windows
  18841. <https://bugs.webkit.org/show_bug.cgi?id=19743>
  18842. Combines all the HTML element cpp files into one to help reduce the
  18843. size of WebCore.lib so we can build in release mode on 32bit Windows.
  18844. Reviewed by Adam Roben.
  18845. * WebCore.vcproj/WebCore.vcproj: Excluded all the separate
  18846. HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp
  18847. to the build.
  18848. * html/HTMLElementsAllInOne.cpp: Added.
  18849. 2009-04-02 Simon Fraser <simon.fraser@apple.com>
  18850. Reviewed by Darin Adler
  18851. https://bugs.webkit.org/show_bug.cgi?id=24999
  18852. Optimize hit testing with transforms.
  18853. * rendering/RenderBox.cpp:
  18854. (WebCore::RenderBox::mapLocalToContainer):
  18855. (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  18856. getTransformFromContainer() change to return the matrix by reference.
  18857. * rendering/RenderLayer.cpp:
  18858. (WebCore::RenderLayer::update3DTransformedDescendantStatus):
  18859. The method failed to set m_3DTransformedDescendantStatusDirty to false,
  18860. so did the work every time.
  18861. (WebCore::RenderLayer::createLocalTransformState):
  18862. Only call the expensive getTransformFromContainer() if there is a transform,
  18863. otherwise we just have a translation.
  18864. * rendering/RenderObject.cpp:
  18865. (WebCore::RenderObject::getTransformFromContainer):
  18866. * rendering/RenderObject.h:
  18867. Change transformFromContainer() to getTransformFromContainer(), and return
  18868. the matrix by reference to reduce copying.
  18869. New enum values for arguments for readability.
  18870. * rendering/TransformState.cpp:
  18871. (WebCore::TransformState::move):
  18872. (WebCore::TransformState::applyTransform):
  18873. (WebCore::HitTestingTransformState::translate):
  18874. New method that adds a translation to the accumulated matrix, optionally
  18875. without flattening. Cheaper than applyTransform().
  18876. (WebCore::HitTestingTransformState::applyTransform):
  18877. (WebCore::HitTestingTransformState::flatten):
  18878. (WebCore::HitTestingTransformState::flattenWithTransform):
  18879. Add flattenWithTransform(), which is a helper that allows us to
  18880. avoid doing the inverse() twice.
  18881. * rendering/TransformState.h:
  18882. (WebCore::TransformState::):
  18883. (WebCore::TransformState::move):
  18884. (WebCore::HitTestingTransformState::):
  18885. New method on HitTestingTransformState that adds a translation to the
  18886. accumulated matrix, optionally without flattening. Cheaper than applyTransform().
  18887. New enum values for arguments for readability.
  18888. 2009-04-02 Simon Fraser <simon.fraser@apple.com>
  18889. Reviewed by Dan Bernstein
  18890. https://bugs.webkit.org/show_bug.cgi?id=24648
  18891. Optimize common code paths in TransformationMatrix.
  18892. * platform/graphics/transforms/TransformationMatrix.cpp:
  18893. (WebCore::TransformationMatrix::translate):
  18894. (WebCore::TransformationMatrix::translate3d):
  18895. Optimize to avoid matrix copy.
  18896. (WebCore::TransformationMatrix::isInvertible):
  18897. Test for identity and translation matrices before computing
  18898. the determinant.
  18899. (WebCore::TransformationMatrix::inverse):
  18900. Optimize for identity matrix and translations.
  18901. * platform/graphics/transforms/TransformationMatrix.h:
  18902. (WebCore::TransformationMatrix::isIdentityOrTranslation):
  18903. Utility method.
  18904. 2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  18905. Reviewed by Alexey Proskuryakov.
  18906. https://bugs.webkit.org/show_bug.cgi?id=24930
  18907. [Gtk] ISO files content is displayed inside the webview instead of being downloaded
  18908. Also sniff content of types declared as text/plain. This is
  18909. justified by the fact that it is common to have Apache HTTP
  18910. servers configured to send text/plain as Content-Type by default.
  18911. * platform/network/soup/ResourceHandleSoup.cpp:
  18912. (WebCore::gotHeadersCallback):
  18913. 2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  18914. Reviewed by Alexey Proskuryakov.
  18915. Protect the handle when notifying the client that the response was
  18916. received also in gotChunkCallback, or we crash in didReceiveData
  18917. when the load is cancelled in didReceiveResponse.
  18918. * platform/network/soup/ResourceHandleSoup.cpp:
  18919. (WebCore::gotChunkCallback):
  18920. 2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  18921. Reviewed by Alexey Proskuryakov.
  18922. https://bugs.webkit.org/show_bug.cgi?id=25001
  18923. Crash when content type parameters have no value
  18924. Handle the case where a Content-Type header parameter has no
  18925. value (i.e. no = character), to work-around a bug in libsoup.
  18926. * platform/network/soup/ResourceHandleSoup.cpp:
  18927. (WebCore::fillResponseFromMessage):
  18928. 2009-04-02 Yael Aharon <yael.aharon@nokia.com>
  18929. Reviewed by Simon Hausmann.
  18930. https://bugs.webkit.org/show_bug.cgi?id=24490
  18931. Enable web workers in Qt.
  18932. * WebCore.pro:
  18933. 2009-04-01 Alexey Proskuryakov <ap@webkit.org>
  18934. Reviewed by Darin Adler. Based on work of Julien Chaffraix.
  18935. https://bugs.webkit.org/show_bug.cgi?id=22475
  18936. REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore
  18937. https://bugs.webkit.org/show_bug.cgi?id=24886
  18938. XHR requests opened when offline never return
  18939. Tests: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
  18940. http/tests/xmlhttprequest/state-after-network-error.html
  18941. * xml/XMLHttpRequest.cpp:
  18942. (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this
  18943. wasn't an error.
  18944. (WebCore::XMLHttpRequest::abort): Fixed formatting.
  18945. (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange.
  18946. The comment saying that this doesn't match Firefox was added in r33559 without explanation
  18947. or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state
  18948. to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt
  18949. that any code depends on this, so I went with the spec here.
  18950. 2009-04-01 Steve Falkenburg <sfalken@apple.com>
  18951. https://bugs.webkit.org/show_bug.cgi?id=24997
  18952. Race conditions in icon database threading code
  18953. m_syncThreadRunning set was mistakenly eliminated in r27717.
  18954. This reintroduces it.
  18955. Reviewed by Oliver Hunt.
  18956. * loader/icon/IconDatabase.cpp:
  18957. (WebCore::IconDatabase::open): Set m_syncThreadRunning.
  18958. 2009-04-01 Antti Koivisto <antti@apple.com>
  18959. Reviewed by Darin Adler.
  18960. <rdar://problem/6748609> Use ActiveDOMObject to suspend marquees
  18961. Make marquees ActiveDOMObjects, get rid of the special suspension code.
  18962. * html/HTMLMarqueeElement.cpp:
  18963. (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
  18964. (WebCore::HTMLMarqueeElement::canSuspend):
  18965. (WebCore::HTMLMarqueeElement::suspend):
  18966. (WebCore::HTMLMarqueeElement::resume):
  18967. * html/HTMLMarqueeElement.h:
  18968. * page/Frame.cpp:
  18969. (WebCore::Frame::clearTimers):
  18970. * rendering/RenderLayer.cpp:
  18971. * rendering/RenderLayer.h:
  18972. (WebCore::RenderLayer::marquee):
  18973. 2009-04-01 Dean Jackson <dino@apple.com>
  18974. Reviewed by Darin Adler
  18975. Make constant values static in previous commit, as suggested
  18976. by Darin.
  18977. * rendering/RenderVideo.cpp:
  18978. 2009-04-01 Dean Jackson <dino@apple.com>
  18979. Reviewed by Simon Fraser
  18980. https://bugs.webkit.org/show_bug.cgi?id=24993
  18981. Standalone media should have a smaller instrinsic
  18982. height.
  18983. * rendering/RenderVideo.cpp:
  18984. (WebCore::RenderVideo::RenderVideo):
  18985. 2009-04-01 Darin Adler <darin@apple.com>
  18986. Reviewed by Geoff Garen.
  18987. Bug 22378: Crash submitting a form when parsing an XHTML document
  18988. https://bugs.webkit.org/show_bug.cgi?id=22378
  18989. rdar://problem/6388377
  18990. Tests: fast/loader/submit-form-while-parsing-1.xhtml
  18991. fast/loader/submit-form-while-parsing-2.html
  18992. * WebCore.base.exp: Updated.
  18993. * history/HistoryItem.cpp:
  18994. (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children.
  18995. Used uncheckedAppend because we reserveInitialCapacity.
  18996. (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children.
  18997. Added an assertion that this is only used to add items that don't have
  18998. duplicate frame names.
  18999. (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item
  19000. if any, preserving the isTargetItem flag.
  19001. (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName
  19002. for consistency with the other functions here that all call the frame name the
  19003. "target". Also updated for rename of m_subItems to m_children.
  19004. (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem.
  19005. Removed unneeded size check.
  19006. (WebCore::HistoryItem::targetItem): Changed to always return the top item
  19007. if no item has the isTargetItem flag set. The old version would instead return
  19008. 0 in some cases, but return the top item if it had no children.
  19009. (WebCore::HistoryItem::children): Renamed m_subItems to m_children.
  19010. (WebCore::HistoryItem::hasChildren): Ditto.
  19011. (WebCore::HistoryItem::showTreeWithIndent): Ditto.
  19012. * history/HistoryItem.h: Name changes.
  19013. * html/HTMLFormElement.cpp:
  19014. (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of
  19015. attaching "recorded form values" and "form about to be submitted" to the frame
  19016. loader. Parameter work fine for this; there's no need to store state on the
  19017. FrameLoader.
  19018. * loader/FormState.cpp:
  19019. (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map.
  19020. (WebCore::FormState::create): Ditto.
  19021. * loader/FormState.h: Update to use a vector that we adopt instead of hash map
  19022. that we copy for auto-fill text field values.
  19023. * loader/FrameLoader.cpp:
  19024. (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for
  19025. form submissions and turned the "wasDuringLoad" state into a separate boolean
  19026. instead of using a special redirection type to track it.
  19027. (WebCore::FrameLoader::createWindow): Updated for name and argument change of
  19028. loadFrameRequest.
  19029. (WebCore::FrameLoader::urlSelected): Ditto.
  19030. (WebCore::FrameLoader::submitForm): Removed the "deferred form submission"
  19031. machinery, replacing it with the "scheduled redirection" mechanism, shared
  19032. with other kinds of redirection and navigation. Moved frame targeting here
  19033. so we can schedule the redirection on the right frame. Moved the multiple
  19034. form submission protection here. Moved the code to implement the rule that
  19035. m_navigationDuringLoad was used for here too.
  19036. (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead
  19037. of the locationChangeDuringLoad type to detect location change during a load.
  19038. (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function,
  19039. submitFormAgain.
  19040. (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading
  19041. out of this function into scheduleRedirection, so it can be shared with the
  19042. new scheduleFormSubmission function.
  19043. (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as
  19044. scheduleLocationChange, but with the arguments for a form submission.
  19045. (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the
  19046. duringLoad flag.
  19047. (WebCore::FrameLoader::isLocationChange): Added case for formSubmission
  19048. and removed case for locationChangeDuringLoad.
  19049. (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded
  19050. completeURL call and just use KURL constructor to match the other cases.
  19051. (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up
  19052. the m_navigationDuringLoad, which is no longer needed. The new version of
  19053. this is in the submitForm function and sets the lockHistory boolean.
  19054. (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load
  19055. in here that used to be in scheduleLocationChange.
  19056. (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission
  19057. and removed case for locationChangeDuringLoad.
  19058. (WebCore::FrameLoader::stopRedirectionTimer): Ditto.
  19059. (WebCore::FrameLoader::completed): Removed call to now-obsolete function,
  19060. submitFormAgain.
  19061. (WebCore::FrameLoader::loadFrameRequest): Renamed from
  19062. loadFrameRequestWithFormAndValues. Replaced form element and form values
  19063. argument with a single FormState argument. Changed frame targeting code
  19064. to use the source frame in the case of a form submission to better match
  19065. the actual target frame.
  19066. (WebCore::FrameLoader::loadURL): Don't search for existing frames in the
  19067. form submission case since we already did that in the submitForm function.
  19068. (WebCore::FrameLoader::clientRedirected): Changed to work with the
  19069. m_isExecutingJavaScriptFormAction data member directly instead of taking
  19070. it as a function parameter.
  19071. (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames
  19072. in the form submission case since we already did that in the submitForm
  19073. function.
  19074. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment
  19075. in here that was misplaced elsewhere in the file.
  19076. (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early
  19077. return idiom.
  19078. (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes.
  19079. (WebCore::FrameLoader::childFramesMatchItem): Ditto.
  19080. (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the
  19081. m_navigationDuringLoad logic; that's now handled by setting lockHistory
  19082. to true in the submitForm function.
  19083. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
  19084. Use the new setChildItem function so we don't get multiple items for the
  19085. same frame name in the history item tree in the back/forward list.
  19086. * loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to
  19087. loadFrameRequest and made it take a form state object instead of the
  19088. form element and form values. Removed the unused functions
  19089. loadEmptyDocumentSynchronously, provisionalDocumentLoader,
  19090. notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the
  19091. submitForm function to take a form state argument. Eliminated the
  19092. clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue
  19093. functions, which are replaced by the form state arguments to submitForm
  19094. and loadFrameRequest. Removed the isJavaScriptFormAction argument from
  19095. the clientRedirected function; instead it looks at a data member directly.
  19096. Eliminated the submitFormAgain and overload of the submitForm function;
  19097. these are now subsumed into the remaining submitForm function and the
  19098. scheduleFormSubmission function. Removed unused and obsolete data
  19099. members m_navigationDuringLoad, m_deferredFormSubmission,
  19100. m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.
  19101. * page/ContextMenuController.cpp:
  19102. (WebCore::ContextMenuController::contextMenuItemSelected):
  19103. Updated for name and argument change of loadFrameRequest.
  19104. * page/Frame.cpp:
  19105. (WebCore::Frame::~Frame): Removed call to the now-unneeded
  19106. clearRecordedFormValues function.
  19107. 2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
  19108. Unreviewed, fixing previous commit.
  19109. https://bugs.webkit.org/show_bug.cgi?id=24994
  19110. Revert V8DOMMap.cpp change which accidentally snuck into the previous
  19111. commit.
  19112. * bindings/v8/V8DOMMap.cpp: Revert change in previous commit.
  19113. 2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
  19114. Reviewed by Darin Fisher.
  19115. https://bugs.webkit.org/show_bug.cgi?id=24994
  19116. Fix miscellaneous merge/upstreaming divergencies in Chromium port.
  19117. * bindings/v8/V8Collection.h: Added an include.
  19118. * platform/KURLGoogle.cpp:
  19119. (WebCore::KURL::baseAsString): Added to match KURL.cpp.
  19120. * platform/chromium/ClipboardChromium.cpp: Added an include.
  19121. 2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
  19122. Reviewed by Timothy Hatcher.
  19123. https://bugs.webkit.org/show_bug.cgi?id=24989
  19124. Refactor InspectorResource to use ScriptObject/FunctionCall.
  19125. * bindings/js/JSInspectorControllerCustom.cpp:
  19126. (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use
  19127. a more appropriate type conversion.
  19128. (WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to
  19129. accommodate for InspectorResource refactoring.
  19130. * bindings/js/ScriptFunctionCall.cpp:
  19131. (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match
  19132. existing jsNumber call signature.
  19133. * bindings/js/ScriptFunctionCall.h: Declaration for above.
  19134. * bindings/js/ScriptObject.cpp:
  19135. (WebCore::createEmptyObject): Added.
  19136. (WebCore::ScriptObject::ScriptObject):
  19137. (WebCore::ScriptObject::set): Added a bunch of property setters.
  19138. * bindings/js/ScriptObject.h: Declarations for above.
  19139. * inspector/InspectorController.cpp: Moved all InspectorResource-managing code
  19140. to InspectorResource.cpp
  19141. (WebCore::InspectorController::populateScriptObjects): Changed to use
  19142. refactored InspectorResource.
  19143. (WebCore::InspectorController::resetScriptObjects): Ditto.
  19144. (WebCore::InspectorController::pruneResources): Ditto.
  19145. (WebCore::InspectorController::didCommitLoad): Ditto.
  19146. (WebCore::InspectorController::addResource): Ditto.
  19147. (WebCore::InspectorController::removeResource): Ditto.
  19148. (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
  19149. (WebCore::InspectorController::identifierForInitialRequest): Ditto.
  19150. (WebCore::InspectorController::willSendRequest): Ditto.
  19151. (WebCore::InspectorController::didReceiveResponse): Ditto.
  19152. (WebCore::InspectorController::didReceiveContentLength): Ditto.
  19153. (WebCore::InspectorController::didFinishLoading): Ditto.
  19154. (WebCore::InspectorController::didFailLoading): Ditto,
  19155. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
  19156. (WebCore::InspectorController::scriptImported): Ditto.
  19157. * inspector/InspectorController.h: Removed InspectorResource-managing code decls
  19158. and tweaked some signatures to use ScriptString and long long for identifier.
  19159. * inspector/InspectorController.idl: Changed to use long long for identifier.
  19160. * inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall.
  19161. (WebCore::InspectorResource::InspectorResource): Ditto.
  19162. (WebCore::InspectorResource::~InspectorResource): Ditto.
  19163. (WebCore::InspectorResource::createCached): Added.
  19164. (WebCore::InspectorResource::updateRequest): Added.
  19165. (WebCore::InspectorResource::updateResponse): Added.
  19166. (WebCore::createHeadersObject): Added.
  19167. (WebCore::InspectorResource::createScriptObject): Added.
  19168. (WebCore::InspectorResource::updateScriptObject): Added.
  19169. (WebCore::InspectorResource::releaseScriptObject): Added.
  19170. (WebCore::InspectorResource::type): Tweaked to use ScriptString.
  19171. (WebCore::InspectorResource::setXMLHttpResponseText): Added.
  19172. (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString.
  19173. (WebCore::InspectorResource::startTiming): Added.
  19174. (WebCore::InspectorResource::markResponseReceivedTime): Added.
  19175. (WebCore::InspectorResource::endTiming): Added.
  19176. (WebCore::InspectorResource::markFailed): Added.
  19177. (WebCore::InspectorResource::addLength): Added.
  19178. * inspector/InspectorResource.h: Added decls for newly refactored-in methods.
  19179. (WebCore::InspectorResource::create): Added.
  19180. (WebCore::InspectorResource::isSameLoader): Added.
  19181. (WebCore::InspectorResource::markMainResource): Added.
  19182. (WebCore::InspectorResource::identifier): Added.
  19183. (WebCore::InspectorResource::requestURL): Added.
  19184. (WebCore::InspectorResource::frame): Added.
  19185. (WebCore::InspectorResource::mimeType): Added.
  19186. (WebCore::InspectorResource::Changes::Changes): Added new class to track
  19187. resource changes.
  19188. (WebCore::InspectorResource::Changes::hasChange): Added.
  19189. (WebCore::InspectorResource::Changes::set): Added.
  19190. (WebCore::InspectorResource::Changes::clear): Added.
  19191. (WebCore::InspectorResource::Changes::setAll): Added.
  19192. (WebCore::InspectorResource::Changes::clearAll): Added.
  19193. 2009-04-01 Tony Chang <tony@chromium.org>
  19194. Reviewed by Darin Fisher.
  19195. Ensure the right click doesn't deselect text under it. This was
  19196. happening in the Chromium and GTK+ ports because they don't select
  19197. the text under the cursor on right click.
  19198. This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737
  19199. https://bugs.webkit.org/show_bug.cgi?id=24946
  19200. Test: fast/events/context-no-deselect.html
  19201. * page/EventHandler.cpp:
  19202. (WebCore::EventHandler::handleMouseReleaseEvent):
  19203. 2009-04-01 Simon Fraser <simon.fraser@apple.com>
  19204. Reviewed by Dave Hyatt
  19205. https://bugs.webkit.org/show_bug.cgi?id=24991
  19206. Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
  19207. when getting the transform.
  19208. * rendering/RenderObject.cpp:
  19209. (WebCore::RenderObject::transformFromContainer):
  19210. 2009-03-31 Darin Adler <darin@apple.com>
  19211. Rolled out that last change until I can investigate the regression test failures it seems
  19212. to have caused.
  19213. * dom/PositionIterator.cpp:
  19214. (WebCore::PositionIterator::decrement):
  19215. * dom/PositionIterator.h:
  19216. (WebCore::PositionIterator::PositionIterator):
  19217. 2009-03-31 Darin Adler <darin@apple.com>
  19218. Reviewed by Eric Seidel.
  19219. Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
  19220. https://bugs.webkit.org/show_bug.cgi?id=24621
  19221. * dom/PositionIterator.cpp:
  19222. (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we
  19223. don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward
  19224. iterator, but also should never arise because of the fix below.
  19225. * dom/PositionIterator.h:
  19226. (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when
  19227. the passed-in node has no children. Like the change above, this is consistent with the rest
  19228. of the class, although in the long run I think it's a bit strange to treat a <p> element
  19229. with no children differently than a <p> element with children.
  19230. 2009-03-31 Eric Carlson <eric.carlson@apple.com>
  19231. Reviewed by Simon Fraser.
  19232. https://bugs.webkit.org/show_bug.cgi?id=24965
  19233. Bug 24965: HTMLMediaElement: network state changes can be missed
  19234. * html/HTMLMediaElement.cpp:
  19235. (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the
  19236. state changes, even when no event needs to be fired.
  19237. 2009-03-31 Eric Carlson <eric.carlson@apple.com>
  19238. Reviewed by Darin Adler.
  19239. https://bugs.webkit.org/show_bug.cgi?id=24964
  19240. Bug 24964: HTMLMediaElement: 'waiting' event may fire twice
  19241. * html/HTMLMediaElement.cpp:
  19242. (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state
  19243. drops below HAVE_FUTURE_DATA.
  19244. 2009-03-31 Eric Carlson <eric.carlson@apple.com>
  19245. Reviewed by Darin Adler.
  19246. https://bugs.webkit.org/show_bug.cgi?id=24846
  19247. Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute
  19248. Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
  19249. the author recommends downloading the entire resource optimistically, so the
  19250. attribute is made available to the media engine to use if it is able.
  19251. Test: media/video-dom-autobuffer.html
  19252. * html/HTMLAttributeNames.in: Add autobuffer.
  19253. * html/HTMLMediaElement.cpp:
  19254. (WebCore::HTMLMediaElement::parseMappedAttribute): New.
  19255. (WebCore::HTMLMediaElement::autobuffer): Ditto.
  19256. (WebCore::HTMLMediaElement::setAutobuffer): Ditto.
  19257. * html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.
  19258. * html/HTMLMediaElement.idl: Add autobuffer.
  19259. * platform/graphics/MediaPlayer.cpp:
  19260. (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer.
  19261. (WebCore::MediaPlayer::autobuffer): New.
  19262. (WebCore::MediaPlayer::setAutobuffer): Ditto.
  19263. * platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer
  19264. * platform/graphics/MediaPlayerPrivate.h:
  19265. (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.
  19266. 2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>
  19267. Reviewed by Dimitri Glazkov.
  19268. https://bugs.webkit.org/show_bug.cgi?id=24550
  19269. Check return value of vasprintf. This should keep gcc 4.3.3
  19270. happy rather than have it complain about attribute warn_unused_result.
  19271. * dom/XMLTokenizerLibxml2.cpp:
  19272. (WebCore::XMLTokenizer::error):
  19273. 2009-03-31 Dean Jackson <dino@apple.com>
  19274. Style guide violation!
  19275. * loader/MediaDocument.cpp:
  19276. (WebCore::MediaDocument::defaultEventHandler):
  19277. 2009-03-31 Dean Jackson <dino@apple.com>
  19278. Fix Tiger build.
  19279. * loader/MediaDocument.cpp:
  19280. (WebCore::MediaDocument::defaultEventHandler):
  19281. 2009-03-31 Jian Li <jianli@chromium.org>
  19282. Reviewed by Darin Fisher.
  19283. Upstream V8DOMMap for v8 bindings.
  19284. https://bugs.webkit.org/show_bug.cgi?id=24951
  19285. * bindings/v8/V8DOMMap.cpp: Added.
  19286. * bindings/v8/V8DOMMap.h: Added.
  19287. 2009-03-31 Dean Jackson <dino@apple.com>
  19288. Reviewed by Simon Fraser.
  19289. https://bugs.webkit.org/show_bug.cgi?id=24955
  19290. Spacebar didn't play/pause in standalone MediaDocument
  19291. * loader/MediaDocument.cpp:
  19292. (WebCore::MediaDocument::defaultEventHandler):
  19293. 2009-03-31 Alpha Lam <hclam@chromium.org>
  19294. Reviewed by Eric Seidel.
  19295. https://bugs.webkit.org/show_bug.cgi?id=24901
  19296. Added the following methods to MediaPlayerPrivate for Chromium port.
  19297. void sizeChanged();
  19298. void rateChanged();
  19299. void durationChanged();
  19300. The above changes are to reflect changes in MediaPlayer.cpp.
  19301. More details can be found in the original changeset.
  19302. http://trac.webkit.org/changeset/41907
  19303. * platform/graphics/chromium/MediaPlayerPrivateChromium.h:
  19304. 2009-03-31 Rafael Weinstein <rafaelw@chromium.org>
  19305. Reviewed by Eric Seidel.
  19306. https://bugs.webkit.org/show_bug.cgi?id=24947
  19307. Special-case drawing text-shadow on win32, to let GDI draw in cases
  19308. when both fill & shadow color are opaque and the shadow has no blur.
  19309. * platform/graphics/chromium/FontChromiumWin.cpp:
  19310. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
  19311. (WebCore::Font::drawComplexText):
  19312. * platform/graphics/skia/SkiaFontWin.cpp:
  19313. (WebCore::windowsCanHandleDrawTextShadow):
  19314. (WebCore::windowsCanHandleTextDrawing):
  19315. * platform/graphics/skia/SkiaFontWin.h:
  19316. 2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
  19317. Reviewed by Darin Fisher.
  19318. r42055 removed some functions in FrameLoader used by Chrome,
  19319. this CL backs out some of those changes to unbreak the Chrome build.
  19320. https://bugs.webkit.org/show_bug.cgi?id=24949
  19321. * WebCore.base.exp:
  19322. * loader/FrameLoader.cpp:
  19323. * loader/FrameLoader.h:
  19324. 2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
  19325. Reviewed by Darin Adler.
  19326. Build fixes for Chromium.
  19327. https://bugs.webkit.org/show_bug.cgi?id=24945
  19328. * dom/Document.h:
  19329. * platform/chromium/ClipboardChromium.cpp:
  19330. (WebCore::imageToMarkup):
  19331. 2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>
  19332. Fix the Qt build.
  19333. * dom/XMLTokenizerQt.cpp:
  19334. (WebCore::XMLTokenizer::XMLTokenizer): Use NamedNodeMap instead of NamedAttrMap.
  19335. 2009-03-30 Steve Falkenburg <sfalken@apple.com>
  19336. Don't create CFDataRef with a fixed size.
  19337. Fixes synchronous XMLHTTPRequests on Windows.
  19338. Reviewed by Ada Chan.
  19339. * platform/network/cf/ResourceHandleCFNet.cpp:
  19340. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  19341. 2009-03-30 Darin Adler <darin@apple.com>
  19342. Reviewed by Sam Weinig.
  19343. Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
  19344. https://bugs.webkit.org/show_bug.cgi?id=24594
  19345. rdar://problem/6682110
  19346. Test: fast/loader/reload-policy-delegate.html
  19347. * loader/FrameLoader.cpp:
  19348. (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's
  19349. the policy loader and can use m_policyLoadType rather than letting it get set inside
  19350. checkNavigationPolicy.
  19351. 2009-03-30 Timothy Hatcher <timothy@apple.com>
  19352. <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
  19353. in Finder (painting without up to date layout)
  19354. Reviewed by Dan Bernstein.
  19355. * page/FrameView.cpp:
  19356. (WebCore::FrameView::paintContents): Add an early return when
  19357. painting is attempted when layout is needed.
  19358. 2009-03-30 Greg Bolsinga <bolsinga@apple.com>
  19359. Reviewed by Simon Fraser.
  19360. https://bugs.webkit.org/show_bug.cgi?id=24938
  19361. Sort alphabetically.
  19362. * css/CSSComputedStyleDeclaration.cpp:
  19363. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  19364. 2009-03-30 Greg Bolsinga <bolsinga@apple.com>
  19365. Reviewed by Simon Fraser.
  19366. https://bugs.webkit.org/show_bug.cgi?id=24938
  19367. Build fixes for building --3d-rendering and --no-svg
  19368. * rendering/RenderLayerBacking.cpp:
  19369. 2009-03-30 Greg Bolsinga <bolsinga@apple.com>
  19370. Reviewed by Simon Fraser.
  19371. https://bugs.webkit.org/show_bug.cgi?id=24938
  19372. Build fixes when building --no-svg
  19373. * css/CSSComputedStyleDeclaration.cpp:
  19374. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
  19375. * css/CSSCursorImageValue.cpp:
  19376. (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
  19377. * css/CSSParser.cpp:
  19378. (WebCore::CSSParser::parseValue): Add missing CSS properties
  19379. * css/CSSStyleSelector.cpp:
  19380. (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
  19381. * dom/Node.cpp:
  19382. (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
  19383. * platform/graphics/Font.cpp:
  19384. (WebCore::Font::floatWidth): Handle unused param
  19385. * platform/graphics/SimpleFontData.cpp:
  19386. (WebCore::SimpleFontData::SimpleFontData): Handle unused param
  19387. 2009-03-30 Darin Adler <darin@apple.com>
  19388. Reviewed by Adam Roben.
  19389. Bug 24916: REGRESSION: NavigationAction policy dispatch broken
  19390. https://bugs.webkit.org/show_bug.cgi?id=24916
  19391. * loader/FrameLoader.cpp:
  19392. (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr
  19393. is not used twice. This also optimizes the case where a frame name is specified,
  19394. but it's the name of the frame being loaded. Also called release in all the final
  19395. uses of FormState.
  19396. 2009-03-30 Darin Adler <darin@apple.com>
  19397. Reviewed by Adam Roben.
  19398. Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
  19399. https://bugs.webkit.org/show_bug.cgi?id=24937
  19400. Also should fix the Windows COM bindings build.
  19401. * bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
  19402. * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  19403. * dom/NamedAttrMap.h: Renamed class from NamedAttrMap to
  19404. NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap
  19405. functions all public and non-virtual. Removed virtualLength.
  19406. * dom/NamedNodeMap.h: Replaced file with just an include
  19407. of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap
  19408. files and remove this file.
  19409. * bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
  19410. * dom/Attr.h: Ditto.
  19411. * dom/Attribute.h: Ditto.
  19412. * dom/Document.cpp:
  19413. (WebCore::Document::importNode): Ditto.
  19414. * dom/Element.cpp:
  19415. (WebCore::Element::attributes): Ditto.
  19416. (WebCore::Element::setAttributeMap): Ditto.
  19417. (WebCore::Element::createAttributeMap): Ditto.
  19418. (WebCore::Element::insertedIntoDocument): Ditto.
  19419. (WebCore::Element::removedFromDocument): Ditto.
  19420. (WebCore::Element::openTagStartToString): Ditto.
  19421. (WebCore::Element::removeAttributeNode): Ditto.
  19422. (WebCore::Element::getAttributeNode): Ditto.
  19423. (WebCore::Element::getAttributeNodeNS): Ditto.
  19424. (WebCore::Element::hasAttribute): Ditto.
  19425. (WebCore::Element::hasAttributeNS): Ditto.
  19426. (WebCore::Element::normalizeAttributes): Ditto.
  19427. * dom/Element.h: Ditto.
  19428. * dom/NamedAttrMap.cpp:
  19429. (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto.
  19430. (WebCore::NamedNodeMap::~NamedNodeMap): Ditto.
  19431. (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto.
  19432. (WebCore::NamedNodeMap::getNamedItem): Ditto.
  19433. (WebCore::NamedNodeMap::getNamedItemNS): Ditto.
  19434. (WebCore::NamedNodeMap::removeNamedItem): Ditto.
  19435. (WebCore::NamedNodeMap::removeNamedItemNS): Ditto.
  19436. (WebCore::NamedNodeMap::setNamedItem): Ditto.
  19437. (WebCore::NamedNodeMap::item): Ditto.
  19438. (WebCore::NamedNodeMap::getAttributeItem): Ditto.
  19439. (WebCore::NamedNodeMap::clearAttributes): Ditto.
  19440. (WebCore::NamedNodeMap::detachFromElement): Ditto.
  19441. (WebCore::NamedNodeMap::setAttributes): Ditto.
  19442. (WebCore::NamedNodeMap::addAttribute): Ditto.
  19443. (WebCore::NamedNodeMap::removeAttribute): Ditto.
  19444. (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
  19445. * dom/NamedMappedAttrMap.cpp:
  19446. (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
  19447. * dom/NamedMappedAttrMap.h:
  19448. (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
  19449. * dom/Node.cpp:
  19450. (WebCore::Node::dumpStatistics): Ditto.
  19451. (WebCore::Node::isEqualNode): Ditto.
  19452. (WebCore::Node::isDefaultNamespace): Ditto.
  19453. (WebCore::Node::lookupNamespaceURI): Ditto.
  19454. (WebCore::Node::lookupNamespacePrefix): Ditto.
  19455. (WebCore::Node::compareDocumentPosition): Ditto.
  19456. * dom/Node.h: Ditto.
  19457. * dom/XMLTokenizerLibxml2.cpp:
  19458. (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
  19459. * editing/ApplyStyleCommand.cpp:
  19460. (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto.
  19461. (WebCore::isEmptyFontTag): Ditto.
  19462. (WebCore::areIdenticalElements): Ditto.
  19463. * editing/markup.cpp:
  19464. (WebCore::appendStartMarkup): Ditto.
  19465. (WebCore::completeURLs): Ditto.
  19466. * html/HTMLParser.cpp:
  19467. (WebCore::HTMLParser::handleError): Ditto.
  19468. * rendering/RenderPartObject.cpp:
  19469. (WebCore::RenderPartObject::updateWidget): Ditto.
  19470. * svg/SVGAnimatedProperty.h:
  19471. (WebCore::synchronizeProperty): Ditto.
  19472. * xml/XPathFunctions.cpp:
  19473. (WebCore::XPath::FunLang::evaluate): Ditto.
  19474. * xml/XPathStep.cpp:
  19475. (WebCore::XPath::Step::nodesInAxis): Ditto.
  19476. 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  19477. Reviewed by Holger Freyther.
  19478. https://bugs.webkit.org/show_bug.cgi?id=24750
  19479. [GTK] requests download instead of displaying page
  19480. Use soup facilities to append parameters to the content type, to
  19481. make that more robust;
  19482. * platform/network/soup/ResourceHandleSoup.cpp:
  19483. (WebCore::fillResponseFromMessage):
  19484. 2009-03-30 David Kilzer <ddkilzer@apple.com>
  19485. <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig
  19486. Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.
  19487. * Configurations/Base.xcconfig: Moved Production definition of
  19488. SECTORDER_FLAGS to here from Xcode project file.
  19489. * Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS
  19490. in Base.xcconfig to the empty string since it is not used for
  19491. Debug and Release configurations.
  19492. * WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.
  19493. 2009-03-30 Adam Roben <aroben@apple.com>
  19494. Windows build fix after recent Node.idl changes
  19495. * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources
  19496. of classes that derive from Node to rebuild.
  19497. 2009-03-30 Adam Roben <aroben@apple.com>
  19498. Windows build fix
  19499. * svg/graphics/SVGImage.cpp: Added a missing #include.
  19500. 2009-03-30 Mads Ager <ager@chromium.org>
  19501. Reviewed by Darin Adler.
  19502. https://bugs.webkit.org/show_bug.cgi?id=24879
  19503. Add frame accessor to Screen, Console, and BarInfo objects. Add type
  19504. accessor to BarInfo objects.
  19505. In the V8 JavaScript bindings, we need access to the frame and
  19506. type for already created Screen, Console, and BarInfo objects in
  19507. order to keep their wrappers alive across GCs.
  19508. * page/BarInfo.cpp:
  19509. (WebCore::BarInfo::frame): Added.
  19510. (WebCore::BarInfo::type): Added.
  19511. * page/BarInfo.h:
  19512. * page/Console.cpp:
  19513. (WebCore::Console::frame): Added.
  19514. * page/Console.h:
  19515. * page/Screen.cpp:
  19516. (WebCore::Screen::frame): Added.
  19517. * page/Screen.h:
  19518. 2009-03-29 Darin Adler <darin@apple.com>
  19519. Requested by Antti Koivisto.
  19520. * loader/DocumentLoader.cpp:
  19521. (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added
  19522. a better comment.
  19523. 2009-03-29 Darin Adler <darin@apple.com>
  19524. Reviewed by Dan Bernstein.
  19525. Bug 23445: Copying certain hidden text causes a crash
  19526. https://bugs.webkit.org/show_bug.cgi?id=23445
  19527. rdar://problem/6512520
  19528. Test: editing/pasteboard/copy-display-none.html
  19529. * editing/markup.cpp:
  19530. (WebCore::createMarkup): Added a check for the case where adjusting the start node moves
  19531. the start of the selection past the end of the range entirely. If we try to iterate we'll
  19532. never hit the end of the range and will probably crash iterating the rest of the document.
  19533. 2009-03-29 Darin Adler <darin@apple.com>
  19534. Reviewed by Dan Bernstein.
  19535. Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
  19536. https://bugs.webkit.org/show_bug.cgi?id=24672
  19537. rdar://problem/6574263
  19538. I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
  19539. but there is an Apple-internal website I was able to use to reproduce and fix.
  19540. * loader/CachedResource.h: Made makePurgeable public.
  19541. * loader/DocumentLoader.cpp:
  19542. (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable
  19543. so we can get its data if it hasn't yet been purged.
  19544. 2009-03-29 Darin Adler <darin@apple.com>
  19545. Fix build again.
  19546. * loader/EmptyClients.h: Fix typo in name of FormState.h.
  19547. 2009-03-29 Darin Adler <darin@apple.com>
  19548. Try to fix the release build.
  19549. * history/CachedPage.cpp: Make include unconditional, not debug-only.
  19550. 2009-03-29 Greg Bolsinga <bolsinga@apple.com>
  19551. Undo that last build fix, since it turned out the file wasn't deleted.
  19552. * WebCore.xcodeproj/project.pbxproj:
  19553. 2009-03-29 Greg Bolsinga <bolsinga@apple.com>
  19554. Fix build break by removing references to deleted header files.
  19555. * WebCore.xcodeproj/project.pbxproj:
  19556. 2009-03-29 Darin Adler <darin@apple.com>
  19557. Try to fix the Windows build.
  19558. * loader/EmptyClients.h: Added include of FormState.h.
  19559. * loader/MainResourceLoader.cpp: Ditto.
  19560. 2009-03-29 Dmitry Titov <dimich@chromium.org>
  19561. Reviewed by Darin Adler.
  19562. https://bugs.webkit.org/show_bug.cgi?id=24926
  19563. Fix Chromium build break.
  19564. * bindings/v8/custom/V8DOMWindowCustom.cpp:
  19565. (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
  19566. 2009-03-29 Darin Adler <darin@apple.com>
  19567. Another attempt to fix the Qt build.
  19568. * WebCore.pro: Added CheckedRadioButtons.cpp.
  19569. 2009-03-29 Darin Adler <darin@apple.com>
  19570. Reviewed by Cameron Zwarich.
  19571. Bug 24921: remove include of HTMLFormElement.h from Document.h
  19572. https://bugs.webkit.org/show_bug.cgi?id=24921
  19573. * GNUmakefile.am: Added CheckedRadioButtons source files.
  19574. * WebCore.scons: Ditto.
  19575. * WebCore.vcproj/WebCore.vcproj: Ditto.
  19576. * WebCore.xcodeproj/project.pbxproj: Ditto.
  19577. * WebCoreSources.bkl: Ditto.
  19578. * bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
  19579. * dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp.
  19580. Removed all the code except for CheckedRadioButtons, and moved that out to be
  19581. a namespace-level class instead of a member of HTMLFormElement.
  19582. * dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h.
  19583. Removed all the code except for CheckedRadioButtons, and moved that out to be
  19584. a namespace-level class instead of a member of HTMLFormElement.
  19585. * dom/Document.h: Removed unneeded includes, including HTMLFormElement.h.
  19586. Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons
  19587. class to use a namespace-level class instead of a member of HTMLFormElement.
  19588. * dom/Node.idl: Changed the type of parentElement from Node to Element for
  19589. two reasons. 1) Node was incorrect, since parentElement returns an Element.
  19590. 2) The bindings won't compile any more unless they know parentElement's
  19591. return value is an Element due to include changes.
  19592. * html/HTMLFormElement.cpp: Moved definitions of the functions in the
  19593. CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
  19594. * html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons
  19595. class to the new CheckedRadioButtons.h.
  19596. * html/HTMLInputElement.cpp:
  19597. (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons
  19598. class to use a namespace-level class instead of a member of HTMLFormElement.
  19599. * page/Chrome.cpp:
  19600. (WebCore::Chrome::createWindow): Tweaked formatting.
  19601. * css/CSSGrammar.y: Added newly-needed include.
  19602. * dom/Range.cpp: Ditto.
  19603. * editing/BreakBlockquoteCommand.cpp: Ditto.
  19604. * editing/CompositeEditCommand.cpp: Ditto.
  19605. * editing/InsertLineBreakCommand.cpp: Ditto.
  19606. * editing/ModifySelectionListLevel.cpp: Ditto.
  19607. * editing/RemoveFormatCommand.cpp: Ditto.
  19608. * editing/TextIterator.cpp: Ditto.
  19609. * editing/VisiblePosition.cpp: Ditto.
  19610. * loader/DocLoader.cpp: Ditto.
  19611. * page/AccessibilityRenderObject.cpp: Ditto.
  19612. * page/Page.cpp: Ditto.
  19613. * rendering/RenderBlock.cpp: Ditto.
  19614. * rendering/RenderLayer.cpp: Ditto.
  19615. * rendering/RenderObject.h: Ditto.
  19616. * storage/LocalStorageArea.cpp: Ditto.
  19617. * storage/SessionStorageArea.cpp: Ditto.
  19618. 2009-03-29 Darin Adler <darin@apple.com>
  19619. Reviewed by Dan Bernstein.
  19620. <rdar://problem/6015407> attr parsing should allow only identifiers
  19621. Test: fast/css/attr-parsing.html
  19622. * css/CSSParser.cpp:
  19623. (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out
  19624. identifiers that start with "-".
  19625. * css/CSSPrimitiveValue.cpp:
  19626. (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test
  19627. case works. This has the pleasant side effect of fixing a bug too.
  19628. 2009-03-29 Alexey Proskuryakov <ap@webkit.org>
  19629. <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
  19630. Forgot to save the file after applying changes for review comments.
  19631. * platform/network/cf/ResourceHandleCFNet.cpp:
  19632. (WebCore::willSendRequest):
  19633. (WebCore::didReceiveResponse):
  19634. (WebCore::didReceiveData):
  19635. (WebCore::didSendBodyData):
  19636. (WebCore::didFinishLoading):
  19637. (WebCore::didFail):
  19638. (WebCore::willCacheResponse):
  19639. (WebCore::didReceiveChallenge):
  19640. (WebCore::WebCoreSynchronousLoader::willSendRequest):
  19641. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  19642. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  19643. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  19644. (WebCore::WebCoreSynchronousLoader::didFail):
  19645. (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  19646. 2009-03-28 Alexey Proskuryakov <ap@webkit.org>
  19647. Reviewed by Darin Adler.
  19648. <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
  19649. Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
  19650. * platform/network/cf/ResourceHandleCFNet.cpp:
  19651. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  19652. (WebCore::ResourceHandle::loadResourceSynchronously):
  19653. (WebCore::WebCoreSynchronousLoader::willSendRequest):
  19654. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  19655. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  19656. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  19657. (WebCore::WebCoreSynchronousLoader::didFail):
  19658. (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  19659. (WebCore::WebCoreSynchronousLoader::load):
  19660. Match Mac behavior more closely - we shouldn't rely on underlying library handling of
  19661. synchronous requests.
  19662. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest):
  19663. -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest
  19664. delegate method for a redirect.
  19665. * platform/network/mac/ResourceHandleMac.mm:
  19666. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
  19667. Match async behavior more closely.
  19668. 2009-03-28 Darin Adler <darin@apple.com>
  19669. Reviewed by Mark Rowe.
  19670. Bug 24914: empty-string assertion crash when running storage tests
  19671. https://bugs.webkit.org/show_bug.cgi?id=24914
  19672. * storage/Database.cpp:
  19673. (WebCore::Database::performOpenAndVerify): Don't store empty version strings
  19674. in the map, since empty strings are per-thread.
  19675. 2009-03-28 Dmitry Titov <dimich@chromium.org>
  19676. Reviewed by Dimitri Glazkov.
  19677. https://bugs.webkit.org/show_bug.cgi?id=24910
  19678. Fixes for Chromium build.
  19679. * bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
  19680. * bindings/v8/custom/V8CustomEventListener.h: ditto.
  19681. * dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
  19682. 2009-03-28 Dimitri Glazkov <dglazkov@chromium.org>
  19683. Not reviewed, correcting landing error.
  19684. https://bugs.webkit.org/show_bug.cgi?id=24812
  19685. Custom bindings should be in v8/custom, not v8.
  19686. * bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
  19687. * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
  19688. 2009-03-28 Mike Belshe <mike@belshe.com>
  19689. Reviewed by Dimitri Glazkov.
  19690. https://bugs.webkit.org/show_bug.cgi?id=24616
  19691. Add V8 custom bindings for DOMWindow.
  19692. * bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
  19693. 2009-03-28 Mike Belshe <mike@belshe.com>
  19694. Reviewed by Dimitri Glazkov.
  19695. https://bugs.webkit.org/show_bug.cgi?id=24812
  19696. Add V8 custom bindings for HTMLDocument.
  19697. * bindings/v8/V8HTMLDocumentCustom.cpp: Added.
  19698. 2009-03-27 Mark Rowe <mrowe@apple.com>
  19699. Reviewed by Sam Weinig.
  19700. Fix two SVG test failures in 64-bit.
  19701. getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
  19702. This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings. In 32-bit this was
  19703. identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.
  19704. The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
  19705. but requires an exception be thrown when a negative value is passed. This results in the JS bindings handling the
  19706. check for a negative value and lets the implementation treat the arguments purely as unsigned values.
  19707. * svg/SVGTextContentElement.cpp:
  19708. (WebCore::SVGTextContentElement::getNumberOfChars):
  19709. (WebCore::SVGTextContentElement::getSubStringLength):
  19710. (WebCore::SVGTextContentElement::getStartPositionOfChar):
  19711. (WebCore::SVGTextContentElement::getEndPositionOfChar):
  19712. (WebCore::SVGTextContentElement::getExtentOfChar):
  19713. (WebCore::SVGTextContentElement::getRotationOfChar):
  19714. (WebCore::SVGTextContentElement::getCharNumAtPosition):
  19715. (WebCore::SVGTextContentElement::selectSubString):
  19716. * svg/SVGTextContentElement.h:
  19717. * svg/SVGTextContentElement.idl:
  19718. 2009-03-27 Darin Adler <darin@apple.com>
  19719. Reviewed by Sam Weinig.
  19720. Get mailto code out of FrameLoader.
  19721. * html/HTMLFormElement.cpp:
  19722. (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto
  19723. logic so HTMLFormElement::submit isn't full of ugly bits. This includes the
  19724. part of the logic that involves transformeing the URL that was previously
  19725. inside FrameLoader.
  19726. (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and
  19727. also release the data for slightly less refcount churn.
  19728. * loader/FrameLoader.cpp:
  19729. (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto,
  19730. since HTMLFormElement now properly prepares both the URL and the form data.
  19731. 2009-03-27 Dan Bernstein <mitz@apple.com>
  19732. Reviewed by Mark Rowe.
  19733. - fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup
  19734. * platform/graphics/chromium/FontCustomPlatformData.cpp:
  19735. (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
  19736. (WebCore::createFontCustomPlatformData): Ditto.
  19737. * platform/graphics/opentype/OpenTypeUtilities.cpp:
  19738. (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to
  19739. the size of an EOTPrefix.
  19740. (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in
  19741. the prefix.
  19742. (WebCore::EOTHeader::appendBigEndianString): Changed the static
  19743. appendBigEndianStringToEOTHeader() into this member function.
  19744. (WebCore::EOTHeader::appendPaddingShort): Added.
  19745. (WebCore::getEOTHeader): Changed to use EOTHeader.
  19746. * platform/graphics/opentype/OpenTypeUtilities.h:
  19747. (WebCore::EOTHeader::size):
  19748. (WebCore::EOTHeader::data):
  19749. (WebCore::EOTHeader::prefix):
  19750. * platform/graphics/win/FontCustomPlatformData.cpp:
  19751. (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
  19752. (WebCore::createFontCustomPlatformData): Ditto.
  19753. 2009-03-27 Darin Adler <darin@apple.com>
  19754. Reviewed by Sam Weinig.
  19755. To prepare for work on a form loading fix, remove some unused functions,
  19756. consolidate some functions, and make many more functions private in
  19757. FrameLoader.
  19758. * WebCore.base.exp: Remove some unused entry points, update another.
  19759. * dom/Document.cpp:
  19760. (WebCore::Document::detach): Clear m_frame directly instead of using
  19761. clearFramePointer.
  19762. * dom/Document.h: Ditto.
  19763. * loader/FrameLoader.cpp:
  19764. (WebCore::FrameLoader::urlSelected): Consolidate the two functions
  19765. of this name into a single function. Also changed the event argument
  19766. to be PassRefPtr<Event>.
  19767. (WebCore::FrameLoader::submitForm): Changed the event argument to
  19768. be PassRefPtr<Event>.
  19769. (WebCore::FrameLoader::scheduleLocationChange): Call completeURL
  19770. explicitly so we can remove the version of changeLocation that does
  19771. completeURL for us.
  19772. (WebCore::FrameLoader::redirectionTimerFired): Ditto.
  19773. (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem
  19774. directly so we don't need a setProvisionalHistoryItem function.
  19775. (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at
  19776. m_quickRedirectComing directly so we don't need a isQuickRedirectComing
  19777. function.
  19778. (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto.
  19779. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the
  19780. event argument to be PassRefPtr<Event>.
  19781. (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData
  19782. function here because this is the only caller. If we want to make the
  19783. resulting function smaller we should refactor some other way. Also
  19784. streamlined the user-chosen encoding logic, but did not change what it does.
  19785. (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument
  19786. to be PassRefPtr<Event>.
  19787. (WebCore::FrameLoader::loadPostRequest): Ditto.
  19788. (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from
  19789. the didNotOpenURL function here, since this was the only caller.
  19790. * loader/FrameLoader.h: Removed include of FormState.h and used a forward
  19791. declaration instead. Removed unneeded forward declation of Element.
  19792. Moved many functions into the private section, and removed some other
  19793. unused or uneeded functions.
  19794. 2009-03-27 Xiaomei Ji <xji@chromium.org>
  19795. Reviewed by Dan Bernstein.
  19796. Fix https://bugs.webkit.org/show_bug.cgi?id=24303
  19797. Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.
  19798. Test: editing/selection/extend-selection.html
  19799. * editing/SelectionController.cpp:
  19800. (WebCore::SelectionController::directionOfEnclosingBlock): Added
  19801. (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly
  19802. implemented for character and word granularity, all other granularities
  19803. are treated as "forward".
  19804. (WebCore::SelectionController::modifyExtendingForward): Renamed
  19805. modifyExtendingRightForward() to this.
  19806. (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly
  19807. implemented for character and word granularity, all other granularities
  19808. are treated as "backward".
  19809. (WebCore::SelectionController::modifyExtendingBackward): Renamed
  19810. modifyExtendingLeftBackward() to this.
  19811. (WebCore::SelectionController::modify): Change to call either the
  19812. left/right or backward/forward methods depending on the 'dir' argument
  19813. for extends.
  19814. * editing/SelectionController.h:
  19815. 2009-03-27 John Abd-El-Malek <jam@google.com>
  19816. Reviewed by Eric Seidel.
  19817. https://bugs.webkit.org/show_bug.cgi?id=24836
  19818. Fix navigator.plugins.refresh(false) in Chromium.
  19819. * plugins/chromium/PluginDataChromium.cpp:
  19820. (WebCore::PluginData::refresh):
  19821. 2009-03-27 Timothy Hatcher <timothy@apple.com>
  19822. Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
  19823. virtual to fix the broken layout tests from my last commit.
  19824. Reviewed by Mark Rowe.
  19825. * dom/Element.cpp:
  19826. (WebCore::Element::scrollLeft):
  19827. (WebCore::Element::scrollTop):
  19828. (WebCore::Element::scrollWidth):
  19829. (WebCore::Element::scrollHeight):
  19830. * dom/Element.h:
  19831. * html/HTMLBodyElement.h:
  19832. 2009-03-27 Mark Rowe <mrowe@apple.com>
  19833. Reviewed by Sam Weinig.
  19834. Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
  19835. Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2)
  19836. * html/HTMLSelectElement.cpp:
  19837. (WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
  19838. items after each node is removed, leading to O(N^2) behaviour. By inlining the batch removal in to setLength we can avoid
  19839. this gratuitous recalcuation.
  19840. 2009-03-27 Dirk Schulze <krit@webkit.org>
  19841. Reviewed by Eric Seidel.
  19842. We don't support images for GtkCursors yet. We need a placeholder to avoid crashes.
  19843. I took crosshair to have a common behavior with firefox.
  19844. [GTK] SVG - Crash on setting the cursor icon
  19845. https://bugs.webkit.org/show_bug.cgi?id=24565
  19846. * platform/gtk/CursorGtk.cpp:
  19847. (WebCore::Cursor::Cursor):
  19848. 2009-03-27 Timothy Hatcher <timothy@apple.com>
  19849. Remove redundant attributes and functions from IDL files that have the
  19850. same attributes and functions defined in the super class.
  19851. Reviewed by Simon Fraser.
  19852. * WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
  19853. * bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
  19854. * html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth
  19855. and scrollHeight.
  19856. * html/HTMLElement.idl: Remove blur and focus.
  19857. 2009-03-27 Adam Roben <aroben@apple.com>
  19858. Don't include substitute data URLs in global history redirect chains
  19859. <rdar://6690169>
  19860. Reviewed by Darin Adler.
  19861. This might be testable if:
  19862. - support were added to DRT for providing substitute data on failed
  19863. loads
  19864. - support were added to DRT for dumping redirect chains
  19865. I tried doing the above and was still unable to make a test.
  19866. * loader/FrameLoader.cpp:
  19867. (WebCore::FrameLoader::updateHistoryForStandardLoad):
  19868. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
  19869. Call updateGlobalHistoryRedirectLinks only if the load succeeded
  19870. (i.e., there is no unreachableURL). Previous the FrameLoaderClient
  19871. implementations were unconditionally calling
  19872. updateGlobalHistoryRedirectLinks from within updateGlobalHistory.
  19873. 2009-03-27 Peter Kasting <pkasting@google.com>
  19874. Reviewed by Eric Seidel.
  19875. https://bugs.webkit.org/show_bug.cgi?id=24861
  19876. Chromium port did not render decorations for <input type="search">.
  19877. This copies RenderThemeWin.*.
  19878. * css/themeChromiumWin.css: Removed.
  19879. * rendering/RenderThemeChromiumLinux.cpp:
  19880. (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
  19881. (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle):
  19882. (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton):
  19883. (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle):
  19884. (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle):
  19885. (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration):
  19886. (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle):
  19887. (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
  19888. * rendering/RenderThemeChromiumLinux.h:
  19889. (WebCore::RenderThemeChromiumLinux::paintSearchField):
  19890. * rendering/RenderThemeChromiumWin.cpp:
  19891. (WebCore::):
  19892. (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
  19893. (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle):
  19894. (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton):
  19895. (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle):
  19896. (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle):
  19897. (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration):
  19898. (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle):
  19899. (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
  19900. * rendering/RenderThemeChromiumWin.h:
  19901. (WebCore::RenderThemeChromiumWin::paintSearchField):
  19902. 2009-03-27 David Hyatt <hyatt@apple.com>
  19903. Reviewed by Simon Fraser
  19904. If an object has a self-painting layer, don't count it as part of a block's visual overflow.
  19905. This fix has only been made for block-level children. The inline-level case is still broken
  19906. (and covered by an existing bug).
  19907. Added fast/block/positioning/negative-rel-position.html
  19908. * rendering/InlineFlowBox.cpp:
  19909. (WebCore::InlineFlowBox::placeBoxesVertically):
  19910. * rendering/RenderBlock.cpp:
  19911. (WebCore::RenderBlock::layoutBlockChildren):
  19912. (WebCore::RenderBlock::lowestPosition):
  19913. (WebCore::RenderBlock::rightmostPosition):
  19914. (WebCore::RenderBlock::leftmostPosition):
  19915. 2009-03-27 Anders Carlsson <andersca@apple.com>
  19916. Reviewed by Darin Adler.
  19917. <rdar://problem/6642221>
  19918. REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed
  19919. Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.
  19920. I've filed <rdar://problem/6731022> against the Movies widget.
  19921. * html/HTMLObjectElement.cpp:
  19922. (WebCore::HTMLObjectElement::rendererIsNeeded):
  19923. 2009-03-25 Timothy Hatcher <timothy@apple.com>
  19924. Expose new DOM methods as public Objective-C API.
  19925. <rdar://problem/5837350> Expose new DOM classes and methods
  19926. as public API (match the additions to the JavaScript DOM)
  19927. Reviewed by Mark Rowe and Darin Adler.
  19928. * WebCore.xcodeproj/project.pbxproj:
  19929. * bindings/objc/DOMHTML.h:
  19930. * bindings/objc/DOMPrivate.h:
  19931. * bindings/objc/PublicDOMInterfaces.h:
  19932. 2009-03-27 Zack Rusin <zack@kde.org>
  19933. Reviewed by Simon Hausmann.
  19934. https://bugs.webkit.org/show_bug.cgi?id=24280
  19935. Fix propagation of fill rules when rendering paths in the Qt build.
  19936. * platform/graphics/qt/GraphicsContextQt.cpp:
  19937. (WebCore::toQtFillRule):
  19938. (WebCore::GraphicsContext::fillPath):
  19939. (WebCore::GraphicsContext::strokePath):
  19940. 2009-03-27 Zack Rusin <zack@kde.org>
  19941. Reviewed by Tor Arne Vestbø.
  19942. https://bugs.webkit.org/show_bug.cgi?id=24275
  19943. Fix text field theming in the Qt build with the KDE 4 Oxygen
  19944. style by adjusting the size vertically and horizontally to
  19945. set padding on the element equal to the width of the style painted border.
  19946. * platform/qt/RenderThemeQt.cpp:
  19947. (WebCore::RenderThemeQt::RenderThemeQt):
  19948. (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
  19949. (WebCore::RenderThemeQt::adjustTextFieldStyle):
  19950. (WebCore::RenderThemeQt::paintTextField):
  19951. * platform/qt/RenderThemeQt.h:
  19952. 2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  19953. Reviewed by Simon Hausmann.
  19954. https://bugs.webkit.org/show_bug.cgi?id=24852
  19955. Build fix for GNU mode RVCT compilation
  19956. * html/PreloadScanner.cpp:
  19957. 2009-03-27 Erik L. Bunce <elbunce@xendom.com>
  19958. Reviewed by Simon Hausmann.
  19959. https://bugs.webkit.org/show_bug.cgi?id=24868
  19960. Make text of the writing direction items more user friendly.
  19961. * platform/qt/Localizations.cpp:
  19962. (WebCore::contextMenuItemTagLeftToRight):
  19963. (WebCore::contextMenuItemTagRightToLeft):
  19964. 2009-03-27 Erik L. Bunce <elbunce@xendom.com>
  19965. Reviewed by Simon Hausmann.
  19966. https://bugs.webkit.org/show_bug.cgi?id=24274
  19967. Fixed the Qt 4.4 Mac build with netscape plugins enabled.
  19968. * plugins/mac/PluginViewMac.cpp:
  19969. 2009-03-26 Mark Rowe <mrowe@apple.com>
  19970. Try and fix the Qt build.
  19971. * platform/text/TextEncodingDetectorNone.cpp:
  19972. (WebCore::detectTextEncoding):
  19973. 2009-03-26 Eric Carlson <eric.carlson@apple.com>
  19974. Reviewed by Simon Fraser.
  19975. https://bugs.webkit.org/show_bug.cgi?id=24874
  19976. 24874: HTMLMediaElement: 'duration' defaults to NaN, deal with it
  19977. The 'duration' attribute is NaN when no media is available, so the
  19978. media element should take care when comparing with duration().
  19979. * html/HTMLMediaElement.cpp:
  19980. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Don't compare with duration when
  19981. it is NaN.
  19982. (WebCore::HTMLMediaElement::endedPlayback): Ditto.
  19983. 2009-03-26 Mark Rowe <mrowe@apple.com>
  19984. Fix the build.
  19985. * platform/text/TextEncodingDetectorICU.cpp:
  19986. * platform/text/TextEncodingDetectorNone.cpp:
  19987. 2009-03-26 Jungshik Shin <jshin@chromium.org>
  19988. Reviewed by Cameron Zwarich.
  19989. 1. Fix the crash in setHintEncoding
  19990. 2. Fix build failures on Tiger and Qt.
  19991. UnusedParam.h was not included by TextEncodingDetector{None,ICU}.cpp
  19992. in the patch landed in r42023
  19993. for http://bugs.webkit.org/show_bug.cgi?id=16482
  19994. * loader/TextResourceDecoder.h:
  19995. (WebCore::TextResourceDecoder::setHintEncoding):
  19996. * platform/text/TextEncodingDetectorICU.cpp:
  19997. * platform/text/TextEncodingDetectorNone.cpp:
  19998. 2009-03-26 Simon Fraser <simon.fraser@apple.com>
  19999. Build fix when ACCELERATED_COMPOSITING is turned on.
  20000. * rendering/RenderLayerBacking.cpp:
  20001. (WebCore::RenderLayerBacking::canUseDirectCompositing):
  20002. 2009-03-26 Eric Seidel <eric@webkit.org>
  20003. No additional review, committing previously reviewed files for build fix only.
  20004. Add files I missed when commiting Jungshik's patch in r42022.
  20005. https://bugs.webkit.org/show_bug.cgi?id=16482
  20006. * icu/unicode/ucsdet.h: Added.
  20007. * platform/text/TextEncodingDetector.h: Added.
  20008. * platform/text/TextEncodingDetectorICU.cpp: Added.
  20009. (WebCore::detectTextEncoding):
  20010. * platform/text/TextEncodingDetectorNone.cpp: Added.
  20011. (WebCore::detectTextEncoding):
  20012. 2009-03-26 Jungshik Shin <jshin@chromium.org>
  20013. Reviewed by Alexey Proskuryakov.
  20014. Add an encoding detector 'hook' to TextResourceDecoder.
  20015. - add |usesEncodingDetector| to Settings. It's off by default.
  20016. - add a new encoding source type |EncodingFromParent|
  20017. to distinguish cases when the encoding is inherited from
  20018. the parent frame from cases when it's actually auto-detected.
  20019. - add TextEncodingDetector* to platform/text. Currently,
  20020. the only implementation uses ICU. Stub is added for
  20021. ports that do not use ICU and a build on Tiger. Mac OS
  20022. Tiger comes with ICU 3.2 that does not support encoding detector.
  20023. - add ucsdet.h to icu/unicode for ports using ICU.
  20024. Layout tests will be added once bug 20534 is fixed and a WebPreference
  20025. can be controlled in test_shell. With UsesEncodingDetector off, there
  20026. is no change to test.
  20027. http://bugs.webkit.org/show_bug.cgi?id=16482
  20028. * WebCore.vcproj/WebCore.vcproj:
  20029. * WebCore.xcodeproj/project.pbxproj:
  20030. * WebCore/GNUmakefile.am
  20031. * WebCore/WebCore.pro
  20032. * WebCore/WebCore.scons
  20033. * WebCore/WebCoreSources.bkl
  20034. * WebCore.base.exp
  20035. * icu/unicode/ucsdet.h
  20036. * loader/FrameLoader.cpp:
  20037. (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
  20038. * loader/TextResourceDecoder.cpp:
  20039. (WebCore::TextResourceDecoder::TextResourceDecoder):
  20040. (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame
  20041. (WebCore::TextResourceDecoder::checkForHeadCharset): ditto
  20042. (WebCore::TextResourceDecoder::shouldAutoDetect):
  20043. (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true.
  20044. (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
  20045. * loader/TextResourceDecoder.h:
  20046. (WebCore::TextResourceDecoder::):
  20047. (WebCore::TextResourceDecoder::create):
  20048. (WebCore::TextResourceDecoder::setHintEncoding):
  20049. (WebCore::TextResourceDecoder::source):
  20050. * page/Settings.cpp: add m_usesEncodingDetector
  20051. (WebCore::Settings::Settings):
  20052. (WebCore::Settings::setUsesEncodingDetector):
  20053. * page/Settings.h:
  20054. (WebCore::Settings::usesEncodingDetector):
  20055. * platform/text/TextEncodingDetector.h: Added.
  20056. * platform/text/TextEncodingDetectorICU.cpp: Added.
  20057. (WebCore::detectTextEncoding):
  20058. * platform/text/TextEncodingDetectorNone.cpp: Added.
  20059. (WebCore::detectTextEncoding):
  20060. 2009-03-26 Darin Adler <darin@apple.com>
  20061. Reviewed by Geoff Garen.
  20062. Removed code that casts EventListener down to derived classes
  20063. without type checking. A crash could happen if you added event
  20064. listeners with Objective-C and then manipulated the class with
  20065. JavaScript.
  20066. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  20067. (WebCore::JSDOMApplicationCache::mark): Removed all the casts
  20068. and used the markIfNotNull function and mark functions on
  20069. EventListener instead.
  20070. * bindings/js/JSMessagePortCustom.cpp:
  20071. (WebCore::JSMessagePort::mark): Ditto.
  20072. * bindings/js/JSWorkerContextCustom.cpp:
  20073. (WebCore::JSWorkerContext::mark): Ditto.
  20074. * bindings/js/JSWorkerCustom.cpp:
  20075. (WebCore::JSWorker::mark): Ditto.
  20076. * bindings/js/JSXMLHttpRequestCustom.cpp:
  20077. (WebCore::JSXMLHttpRequest::mark): Ditto.
  20078. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  20079. (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
  20080. * bindings/js/JSEventListener.cpp:
  20081. (WebCore::JSAbstractEventListener::handleEvent): Used function,
  20082. the new name for what used to be called listenerObj.
  20083. (WebCore::JSAbstractEventListener::virtualIsInline): Renamed since
  20084. this doesn't need to be virtual for callers who have a pointer to
  20085. this class, not the base class.
  20086. (WebCore::JSEventListener::function): Renamed from listenerObj.
  20087. (WebCore::JSProtectedEventListener::function): Ditto.
  20088. * bindings/js/JSEventListener.h: Removed unneeded forward class
  20089. declarations. Made all virtual functions private since there's no
  20090. need to call any of them on a particular derived class, only on
  20091. EventListener. Explicitly declare JSEventListener::mark as virtual
  20092. since it's now overriding a function in the EventListener base class.
  20093. Made JSProtectedEventListener::m_globalObject protected so the
  20094. JSLazyEventListener derived class can use it directly instead of using
  20095. a virtual function to get the pointer.
  20096. * bindings/js/JSLazyEventListener.cpp:
  20097. (WebCore::JSLazyEventListener::parseCode): Use m_globalObject instead
  20098. of globalObject since the latter is a virtual function and there's no
  20099. need to pay virtual function overhead.
  20100. (WebCore::JSLazyEventListener::function): Renamed from listenerObj.
  20101. * bindings/js/JSLazyEventListener.h: Moved forward declaration of the
  20102. Node class here from JSEventListener.h.
  20103. * bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded cast to
  20104. JSEventListener when getting the script object from a listener.
  20105. * dom/EventListener.h: Added virtual function and mark functions
  20106. so we can extract the JavaScript function object or mark a JavaScript
  20107. event listener in a type safe manner.
  20108. 2009-03-26 Peter Kasting <pkasting@google.com>
  20109. Reviewed by Adele Peterson.
  20110. https://bugs.webkit.org/show_bug.cgi?id=24859
  20111. Use CSS file instead of code to adjust search field styling.
  20112. * css/themeWin.css:
  20113. * rendering/RenderThemeWin.cpp:
  20114. * rendering/RenderThemeWin.h:
  20115. 2009-03-26 Darin Adler <darin@apple.com>
  20116. Reviewed by Geoff Garen.
  20117. Split JSLazyEventListener out into its own separate source file.
  20118. We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
  20119. so leave those in the same file with JSEventListener.
  20120. * GNUmakefile.am: Added JSLazyEventListener.
  20121. * WebCore.pro: Ditto.
  20122. * WebCore.scons: Ditto.
  20123. * WebCore.vcproj/WebCore.vcproj: Ditto.
  20124. * WebCore.xcodeproj/project.pbxproj: Ditto.
  20125. * WebCoreSources.bkl: Ditto.
  20126. * bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part.
  20127. Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since
  20128. JSAbstractEventListener is not derived from JSCell.
  20129. * bindings/js/JSEventListener.h: Removed the JSLazyEventListener part
  20130. and the now-unneeded include of PlatformString.h.
  20131. * bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp.
  20132. Kept only the JSLazyEventListener part.
  20133. (WebCore::eventParameterName): Made this have internal linkage by adding "static".
  20134. Also moved the default case out of the switch statement so we will get a warning
  20135. if we omit any cases in the future.
  20136. * bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h.
  20137. Kept only the JSLazyEventListener part.
  20138. * bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the
  20139. remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.
  20140. 2009-03-26 Darin Adler <darin@apple.com>
  20141. Reviewed by Geoff Garen.
  20142. Renamed JSUnprotectedEventListener to JSEventListener.
  20143. And related renames.
  20144. Soon Geoff will make all JavaScript event listeners use mark instead
  20145. of protect, so there's no need to emphasize "unprotected".
  20146. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  20147. (WebCore::JSDOMApplicationCache::mark):
  20148. (WebCore::JSDOMApplicationCache::addEventListener):
  20149. (WebCore::JSDOMApplicationCache::removeEventListener):
  20150. * bindings/js/JSDOMGlobalObject.cpp:
  20151. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
  20152. (WebCore::JSDOMGlobalObject::findJSEventListener):
  20153. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  20154. (WebCore::JSDOMGlobalObject::jsEventListeners):
  20155. (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
  20156. * bindings/js/JSDOMGlobalObject.h:
  20157. * bindings/js/JSDOMWindowBase.h:
  20158. * bindings/js/JSEventListener.cpp:
  20159. (WebCore::JSEventListener::JSEventListener):
  20160. (WebCore::JSEventListener::~JSEventListener):
  20161. (WebCore::JSEventListener::listenerObj):
  20162. (WebCore::JSEventListener::globalObject):
  20163. (WebCore::JSEventListener::clearGlobalObject):
  20164. (WebCore::JSEventListener::mark):
  20165. * bindings/js/JSEventListener.h:
  20166. (WebCore::JSEventListener::create):
  20167. * bindings/js/JSMessagePortCustom.cpp:
  20168. (WebCore::JSMessagePort::mark):
  20169. (WebCore::JSMessagePort::addEventListener):
  20170. (WebCore::JSMessagePort::removeEventListener):
  20171. * bindings/js/JSWorkerContextCustom.cpp:
  20172. (WebCore::JSWorkerContext::mark):
  20173. (WebCore::JSWorkerContext::addEventListener):
  20174. (WebCore::JSWorkerContext::removeEventListener):
  20175. * bindings/js/JSWorkerCustom.cpp:
  20176. (WebCore::JSWorker::mark):
  20177. (WebCore::JSWorker::addEventListener):
  20178. (WebCore::JSWorker::removeEventListener):
  20179. * bindings/js/JSXMLHttpRequestCustom.cpp:
  20180. (WebCore::JSXMLHttpRequest::mark):
  20181. (WebCore::JSXMLHttpRequest::addEventListener):
  20182. (WebCore::JSXMLHttpRequest::removeEventListener):
  20183. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  20184. (WebCore::JSXMLHttpRequestUpload::mark):
  20185. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  20186. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  20187. * bindings/scripts/CodeGeneratorJS.pm:
  20188. All just renaming.
  20189. 2009-03-26 Darin Adler <darin@apple.com>
  20190. Reviewed by Geoff Garen.
  20191. Renamed JSEventListener to JSProtectedEventListener.
  20192. And related renames.
  20193. Soon Geoff will make all JavaScript event listeners use mark instead
  20194. of protect, and so this class will be be obsolete. We will rename
  20195. JSUnrpotectedEventListener to JSEventListener in the next check-in,
  20196. since that one will remain.
  20197. * bindings/js/JSDOMGlobalObject.cpp:
  20198. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
  20199. (WebCore::JSDOMGlobalObject::findJSProtectedEventListener):
  20200. (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener):
  20201. (WebCore::JSDOMGlobalObject::jsProtectedEventListeners):
  20202. (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
  20203. * bindings/js/JSDOMGlobalObject.h:
  20204. * bindings/js/JSDOMWindowBase.h:
  20205. * bindings/js/JSDOMWindowCustom.cpp:
  20206. (WebCore::JSDOMWindow::addEventListener):
  20207. (WebCore::JSDOMWindow::removeEventListener):
  20208. * bindings/js/JSEventListener.cpp:
  20209. (WebCore::JSProtectedEventListener::JSProtectedEventListener):
  20210. (WebCore::JSProtectedEventListener::~JSProtectedEventListener):
  20211. (WebCore::JSProtectedEventListener::listenerObj):
  20212. (WebCore::JSProtectedEventListener::globalObject):
  20213. (WebCore::JSProtectedEventListener::clearGlobalObject):
  20214. (WebCore::JSLazyEventListener::JSLazyEventListener):
  20215. (WebCore::JSLazyEventListener::parseCode):
  20216. * bindings/js/JSEventListener.h:
  20217. (WebCore::JSProtectedEventListener::create):
  20218. * bindings/js/JSNodeCustom.cpp:
  20219. (WebCore::JSNode::addEventListener):
  20220. (WebCore::JSNode::removeEventListener):
  20221. * bindings/js/JSSVGElementInstanceCustom.cpp:
  20222. (WebCore::JSSVGElementInstance::addEventListener):
  20223. (WebCore::JSSVGElementInstance::removeEventListener):
  20224. * bindings/scripts/CodeGeneratorJS.pm:
  20225. All just renaming.
  20226. 2009-03-26 Dan Bernstein <mitz@apple.com>
  20227. Reviewed by Anders Carlsson.
  20228. - fix <rdar://problem/6725042> BidiResolver::createBidiRunsForLine can
  20229. create runs extending beyond the end
  20230. No test because Safari does not use this version of
  20231. createBidiRunsForLine() with the end iterator not pointing to the end
  20232. of the text run.
  20233. * platform/text/BidiResolver.h:
  20234. (WebCore::BidiResolver::appendRun): Cap the end of the run at the end
  20235. of the line and set the reachedEndOfLine flag. This mirrors the logic
  20236. in the specialized version of appendRun() in bidi.cpp, which is why the
  20237. problem did not show up in HTML. Also avoid creating empty runs.
  20238. 2009-03-26 Simon Fraser <simon.fraser@apple.com>
  20239. Reviewed by Dave Hyatt
  20240. https://bugs.webkit.org/show_bug.cgi?id=24864
  20241. Change the terminology from "inner content layer" to "direct compositing"
  20242. for cases where we can push an image directly over to the compositing system,
  20243. without having to draw it.
  20244. Clean up much of the code which looks at style to determine if this is possible,
  20245. and fix some bugs when backgrounds change dynamically.
  20246. * rendering/RenderLayerBacking.cpp:
  20247. (WebCore::hasBorderOutlineOrShadow):
  20248. (WebCore::hasBoxDecorations):
  20249. (WebCore::hasBoxDecorationsWithBackgroundImage):
  20250. (WebCore::RenderLayerBacking::canBeSimpleContainerCompositingLayer):
  20251. (WebCore::RenderLayerBacking::canUseDirectCompositing):
  20252. (WebCore::RenderLayerBacking::detectDrawingOptimizations):
  20253. (WebCore::RenderLayerBacking::rendererContentChanged):
  20254. (WebCore::RenderLayerBacking::updateImageContents):
  20255. * rendering/RenderLayerBacking.h:
  20256. 2009-03-26 Simon Fraser <simon.fraser@apple.com>
  20257. Reviewed by Dave Hyatt
  20258. https://bugs.webkit.org/show_bug.cgi?id=23914
  20259. Tests: compositing/overflow/ancestor-overflow.html
  20260. compositing/overflow/parent-overflow.html
  20261. * rendering/RenderLayer.cpp:
  20262. (WebCore::RenderLayer::calculateClipRects):
  20263. * rendering/RenderLayer.h:
  20264. (WebCore::ClipRects::infiniteRect):
  20265. New static method that returns a large rect that is used by the clipping
  20266. logic.
  20267. * rendering/RenderLayerBacking.cpp:
  20268. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  20269. Use parentClipRects(), rather than calculateRects(), to compute the overflow
  20270. rect that we'll use to create a masking layer for composited clipping.
  20271. * rendering/RenderLayerCompositor.cpp:
  20272. (WebCore::RenderLayerCompositor::clippedByAncestor):
  20273. Use parentClipRects() to see whether there's a layer between us and our
  20274. compositing ancestor which applies clipping.
  20275. (WebCore::RenderLayerCompositor::clipsCompositingDescendants):
  20276. A layer which imposes clipping to its children doesn't have to be a stacking
  20277. context; it might be a normal flow layer; in either case, we can rely on the
  20278. hasCompositingDescendant() bit.
  20279. 2009-03-26 Steve Falkenburg <sfalken@apple.com>
  20280. https://bugs.webkit.org/show_bug.cgi?id=24837
  20281. Escape key should dismiss select menu
  20282. Reviewed by Adam Roben.
  20283. * platform/win/PopupMenuWin.cpp:
  20284. (WebCore::PopupWndProc):
  20285. 2009-03-26 Kevin Ollivier <kevino@theolliviers.com>
  20286. Reviewed by Alexey Proskuryakov.
  20287. Make sure the script uses LF line endings even on Windows.
  20288. https://bugs.webkit.org/show_bug.cgi?id=24805
  20289. * WebCore/make-generated-sources.sh: Change svn:eol-style to LF
  20290. 2009-03-26 Eli Fidler <eli.fidler@torchmobile.com>
  20291. Reviewed by George Staikos.
  20292. Remove warnings all over the place by making operator precedence
  20293. explicit in cases like x && y || z. No functional change.
  20294. * css/CSSFontSelector.cpp:
  20295. (WebCore::CSSFontSelector::addFontFaceRule):
  20296. * css/CSSParser.cpp:
  20297. (WebCore::CSSParser::parseValue):
  20298. (WebCore::CSSParser::parseShadow):
  20299. * dom/Document.cpp:
  20300. (WebCore::Document::shouldScheduleLayout):
  20301. * dom/Node.cpp:
  20302. (WebCore::Node::isBlockFlowOrBlockTable):
  20303. * dom/Node.h:
  20304. (WebCore::Node::document):
  20305. * dom/Position.cpp:
  20306. (WebCore::Position::next):
  20307. (WebCore::Position::upstream):
  20308. (WebCore::Position::downstream):
  20309. (WebCore::Position::getInlineBoxAndOffset):
  20310. * dom/PositionIterator.cpp:
  20311. (WebCore::PositionIterator::atStart):
  20312. * dom/Range.cpp:
  20313. (WebCore::Range::intersectsNode):
  20314. * editing/Editor.cpp:
  20315. (WebCore::Editor::setBaseWritingDirection):
  20316. * editing/InsertParagraphSeparatorCommand.cpp:
  20317. (WebCore::InsertParagraphSeparatorCommand::doApply):
  20318. * editing/ReplaceSelectionCommand.cpp:
  20319. (WebCore::ReplaceSelectionCommand::doApply):
  20320. * editing/TextIterator.cpp:
  20321. (WebCore::TextIterator::advance):
  20322. (WebCore::SimplifiedBackwardsTextIterator::advance):
  20323. * editing/VisiblePosition.cpp:
  20324. (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
  20325. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
  20326. (WebCore::VisiblePosition::canonicalPosition):
  20327. * editing/htmlediting.cpp:
  20328. (WebCore::isMailBlockquote):
  20329. (WebCore::lineBreakExistsAtPosition):
  20330. * html/HTMLSelectElement.cpp:
  20331. (WebCore::HTMLSelectElement::parseMappedAttribute):
  20332. * loader/FTPDirectoryDocument.cpp:
  20333. (WebCore::processFileDateString):
  20334. * loader/ImageLoader.cpp:
  20335. (WebCore::ImageLoader::updateFromElement):
  20336. * loader/TextResourceDecoder.cpp:
  20337. (WebCore::TextResourceDecoder::checkForHeadCharset):
  20338. * page/AccessibilityObject.cpp:
  20339. (WebCore::updateAXLineStartForVisiblePosition):
  20340. * page/EventHandler.cpp:
  20341. (WebCore::EventHandler::sendContextMenuEvent):
  20342. * page/animation/AnimationBase.cpp:
  20343. (WebCore::PropertyWrapperGetter::equals):
  20344. (WebCore::PropertyWrapperShadow::equals):
  20345. * platform/ContextMenu.cpp:
  20346. (WebCore::ContextMenu::populate):
  20347. * platform/ScrollView.cpp:
  20348. (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
  20349. * platform/text/Base64.cpp:
  20350. (WebCore::base64Encode):
  20351. * platform/text/BidiResolver.h:
  20352. (WebCore::::raiseExplicitEmbeddingLevel):
  20353. (WebCore::::createBidiRunsForLine):
  20354. * rendering/InlineTextBox.cpp:
  20355. (WebCore::InlineTextBox::placeEllipsisBox):
  20356. * rendering/RenderBlock.cpp:
  20357. (WebCore::RenderBlock::addChild):
  20358. (WebCore::RenderBlock::repaintOverhangingFloats):
  20359. (WebCore::RenderBlock::fillInlineSelectionGaps):
  20360. (WebCore::RenderBlock::positionForPoint):
  20361. (WebCore::RenderBlock::calcInlinePrefWidths):
  20362. (WebCore::RenderBlock::hasLineIfEmpty):
  20363. * rendering/RenderBox.cpp:
  20364. (WebCore::RenderBox::imageChanged):
  20365. (WebCore::RenderBox::localCaretRect):
  20366. (WebCore::RenderBox::positionForPoint):
  20367. (WebCore::RenderBox::shrinkToAvoidFloats):
  20368. * rendering/RenderObject.h:
  20369. (WebCore::objectIsRelayoutBoundary):
  20370. * rendering/RenderTableCell.cpp:
  20371. (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
  20372. * rendering/RenderText.cpp:
  20373. (WebCore::RenderText::calcPrefWidths):
  20374. * rendering/bidi.cpp:
  20375. (WebCore::RenderBlock::determineStartPosition):
  20376. (WebCore::textWidth):
  20377. * rendering/style/RenderStyle.cpp:
  20378. (WebCore::RenderStyle::diff):
  20379. * rendering/style/StyleInheritedData.cpp:
  20380. (WebCore::cursorDataEquivalent):
  20381. * rendering/style/StyleRareInheritedData.cpp:
  20382. (WebCore::StyleRareInheritedData::shadowDataEquivalent):
  20383. * rendering/style/StyleRareNonInheritedData.cpp:
  20384. (WebCore::StyleRareNonInheritedData::shadowDataEquivalent):
  20385. (WebCore::StyleRareNonInheritedData::animationDataEquivalent):
  20386. (WebCore::StyleRareNonInheritedData::transitionDataEquivalent):
  20387. 2009-03-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
  20388. Reviewed by Holger Freyther.
  20389. https://bugs.webkit.org/show_bug.cgi?id=24804
  20390. [GTK] 401 responses cause rogue content to be loaded
  20391. Our soup code handles 401 responses itself, so we should not feed
  20392. the headers and data of those responses to the loader.
  20393. * platform/network/soup/ResourceHandleSoup.cpp:
  20394. (WebCore::gotHeadersCallback):
  20395. (WebCore::gotChunkCallback):
  20396. 2009-03-25 Geoffrey Garen <ggaren@apple.com>
  20397. Reviewed by Oliver Hunt and Darin Adler.
  20398. Fixed <rdar://problem/6603167> Crash in WebKit!JSC::JSGlobalObject::resetPrototype
  20399. during Stress test (#3 & #7 WER crashes for Safari 4 Beta)
  20400. The problem was that allocation of the global object would, for just a
  20401. moment, leave the global object's prototype unprotected from GC. This
  20402. bug doesn't apply to non-global DOM objects because their prototypes are
  20403. cached and marked by the global object.
  20404. No test case because the crashing condition is hard to deterministically
  20405. produce in a normal build, and in a Windows Release build with
  20406. COLLECT_ON_EVERY_ALLOCATION set to 1, existing tests crash/hang.
  20407. * bindings/js/JSDOMWindowShell.cpp:
  20408. (WebCore::JSDOMWindowShell::setWindow):
  20409. * bindings/js/WorkerScriptController.cpp:
  20410. (WebCore::WorkerScriptController::initScript): Protect the global object's
  20411. prototype from GC during construction, since the global object does not
  20412. yet point to it, and therefore won't mark it.
  20413. 2009-03-25 Dean Jackson <dino@apple.com>
  20414. Reviewed by Simon Fraser
  20415. https://bugs.webkit.org/show_bug.cgi?id=23361
  20416. When using hardware compositing, some images can be directly
  20417. rendered by the hardware - no need to draw them into a separate
  20418. context, therefore saving memory.
  20419. Only images with certain style properties can be directly
  20420. composited - basically anything that is not a simple image requires
  20421. the usual rendering path (eg. if the image has borders).
  20422. Test: compositing/direct-image-compositing.html
  20423. * manual-tests/resources/simple_image.png: Added.
  20424. * manual-tests/simple-image-compositing.html: Added.
  20425. * platform/graphics/Image.h:
  20426. (WebCore::Image::startAnimation):
  20427. - move this to public
  20428. * rendering/RenderImage.cpp:
  20429. (WebCore::RenderImage::imageChanged):
  20430. - poke compositing layer if image has changed
  20431. (WebCore::RenderImage::notifyFinished):
  20432. - let the compositing layer know that it can render the image
  20433. * rendering/RenderImage.h:
  20434. * rendering/RenderLayer.cpp:
  20435. (WebCore::RenderLayer::rendererContentChanged):
  20436. * rendering/RenderLayer.h:
  20437. * rendering/RenderLayerBacking.cpp:
  20438. (WebCore::RenderLayerBacking::canUseInnerContentLayer):
  20439. (WebCore::RenderLayerBacking::detectDrawingOptimizations):
  20440. (WebCore::RenderLayerBacking::rendererContentChanged):
  20441. * rendering/RenderLayerBacking.h:
  20442. - code to hook up direct compositing of images where
  20443. possible
  20444. 2009-03-25 David Levin <levin@chromium.org>
  20445. Reviewed by Dimitri Glazkov.
  20446. Chromium build fix. Fix #include in V8NodeFilterCondition.cpp due to the
  20447. rename of V8NodeFilter to V8NodeFilterCondition.
  20448. * bindings/v8/V8NodeFilterCondition.cpp:
  20449. 2009-03-25 Simon Fraser <simon.fraser@apple.com>
  20450. Reviewed by Darin Adler
  20451. https://bugs.webkit.org/show_bug.cgi?id=24817
  20452. When the slider range is zero, avoid a divide by zero, which caused the
  20453. thumb to be positioned off in the weeds, which broke painting.
  20454. Test: media/video-empty-source.html
  20455. * rendering/RenderSlider.cpp:
  20456. (WebCore::SliderRange::proportionFromValue):
  20457. (WebCore::SliderRange::valueFromProportion):
  20458. (WebCore::sliderPosition):
  20459. (WebCore::RenderSlider::setValueForPosition):
  20460. 2009-03-24 Eric Seidel <eric@webkit.org>
  20461. Reviewed by Darin Adler.
  20462. Remove dead code and style cleanup
  20463. https://bugs.webkit.org/show_bug.cgi?id=24684
  20464. * html/CanvasStyle.cpp:
  20465. (WebCore::CanvasStyle::CanvasStyle):
  20466. Coverty was annoyed that we didn't initialize all of our members. I agree, but I didn't
  20467. want to paste all 8 members each time, so I just cleaned up the existing constructors and left them.
  20468. * page/FocusController.cpp:
  20469. (WebCore::FocusController::setFocusedNode):
  20470. "node" was checked just above and is already known to be non-null
  20471. * rendering/RenderLayer.cpp:
  20472. (WebCore::RenderLayer::insertOnlyThisLayer):
  20473. We were already using parentLayer w/o a NULL check above, so just add an explicit ASSERT and use it w/o NULL check
  20474. (WebCore::RenderLayer::resize):
  20475. element is already ASSERTed above, no need to null check it here
  20476. * rendering/RenderTableSection.cpp:
  20477. (WebCore::RenderTableSection::addCell):
  20478. currentCell.cell was just assigned to the value "cell" which is known to be non-null, no need to null check again.
  20479. 2009-03-24 Eric Seidel <eric@webkit.org>
  20480. Reviewed by Darin Adler.
  20481. Move ASSERT(foo) to before where foo-> is used
  20482. https://bugs.webkit.org/show_bug.cgi?id=24684
  20483. * platform/chromium/PasteboardChromium.cpp:
  20484. (WebCore::Pasteboard::writeImage):
  20485. Move ASSERTs to the top of the function, code was using "node" before ASSERT(node), once I moved
  20486. ASSERT(node) to the top of the function it made sense to move the rest of them there too.
  20487. * rendering/SVGRenderSupport.cpp:
  20488. (WebCore::prepareToRenderSVGContent):
  20489. move ASSERT(object) to *before* we use "object" :)
  20490. 2009-03-24 Eric Seidel <eric@webkit.org>
  20491. Reviewed by Simon Fraser.
  20492. Make TextTokenizer ASSERT that the buffer was freed
  20493. https://bugs.webkit.org/show_bug.cgi?id=24684
  20494. * loader/TextDocument.cpp:
  20495. (WebCore::TextTokenizer::TextTokenizer):
  20496. (WebCore::TextTokenizer::~TextTokenizer):
  20497. (WebCore::TextTokenizer::finish):
  20498. Make it clear by adding a ~TextTokenizer that finish() will always be called and the memory never leaked.
  20499. 2009-03-24 Eric Seidel <eric@webkit.org>
  20500. Reviewed by Darin Adler.
  20501. Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
  20502. https://bugs.webkit.org/show_bug.cgi?id=24684
  20503. I don't have a test case where we were taking the wrong path here
  20504. However, adding an ASSERT(lBreak.obj) before this usage caused
  20505. multiple bidi tests to fail, so lBreak.obj can be null here.
  20506. * rendering/bidi.cpp:
  20507. (WebCore::RenderBlock::findNextLineBreak):
  20508. lBreak.obj can be null, so we can't call ->isBR() on it unconditionally.
  20509. 2009-03-24 Eric Seidel <eric@webkit.org>
  20510. Reviewed by Simon Fraser.
  20511. Style cleanup and dead code removal in dom, editing
  20512. https://bugs.webkit.org/show_bug.cgi?id=24684
  20513. * dom/ContainerNode.cpp:
  20514. (WebCore::ContainerNode::getUpperLeftCorner):
  20515. (WebCore::ContainerNode::getLowerRightCorner):
  20516. (WebCore::ContainerNode::getRect):
  20517. Coverty was (rightly) confused as to what the hell "o" was being used for
  20518. and whether or not it would ever be NULL. I added some ASSERTS so that people (and machines)
  20519. would be less confused about the logic in getUpperLeftCorner/getLowerRightCorner
  20520. * dom/Document.cpp:
  20521. (WebCore::Document::recalcStyle):
  20522. Remove dead code, this block already checked that change == Force
  20523. * editing/ApplyStyleCommand.cpp:
  20524. (WebCore::ApplyStyleCommand::removeInlineStyle):
  20525. Coverty correctly identified that traversePreviousNodePostOrder can return NULL, thus
  20526. prev will be null, and we don't really explicitly handle it (like we probably should)
  20527. It's OK though, because we end up creating a null position object, which may not have
  20528. been what we intended, but we certainly don't crash.
  20529. * editing/InsertParagraphSeparatorCommand.cpp:
  20530. (WebCore::InsertParagraphSeparatorCommand::doApply):
  20531. Remove dead code, insertionPosition.node() is already checked to be non-null above.
  20532. * editing/markup.cpp:
  20533. (WebCore::appendStartMarkup):
  20534. removed dead code, annotate is already known to be true at this point in the file
  20535. !annotate was checked above, and break; was called.
  20536. 2009-03-24 Eric Seidel <eric@webkit.org>
  20537. Reviewed by Simon Fraser.
  20538. CSS dead code removal and cleanup from Coverty errors
  20539. https://bugs.webkit.org/show_bug.cgi?id=24684
  20540. * css/CSSStyleSelector.cpp:
  20541. (WebCore::CSSStyleSelector::applyProperty):
  20542. Every other place in the code we check settings() for NULL, so I made these places
  20543. check too, even though we should never be resolving style against a document which has
  20544. no frame (which I believe is the only time settings() can be null)
  20545. * css/CSSStyleSheet.cpp:
  20546. (WebCore::CSSStyleSheet::styleSheetChanged):
  20547. Removing dead code, "root" can never be null here.
  20548. * css/SVGCSSStyleSelector.cpp:
  20549. (WebCore::colorFromSVGColorCSSValue):
  20550. (WebCore::CSSStyleSelector::applySVGProperty):
  20551. Extra returns in the old macros caused dead code. Removing the old macros and use modern
  20552. ones instead. :)
  20553. Extra null checks to value were not needed. Added an ASSERT at the top of the function
  20554. to make it clear that value will never be NULL.
  20555. Added colorFromSVGColorCSSValue to clean up the code a little.
  20556. 2009-03-24 Eric Seidel <eric@webkit.org>
  20557. Reviewed by Simon Fraser.
  20558. Font fallback cleanup and added ASSERT for GlyphPageTreeNode
  20559. https://bugs.webkit.org/show_bug.cgi?id=24684
  20560. * css/CSSFontSelector.cpp:
  20561. (WebCore::compareFontFaces):
  20562. Coverty was concerned that it was possible to index off the end of weightFallbackRuleSets
  20563. I can't read the code well enough to tell, so I tried to make the code clearer
  20564. and added an ASSERT.
  20565. * platform/graphics/GlyphPageTreeNode.cpp:
  20566. (WebCore::GlyphPageTreeNode::initializePage):
  20567. Coverty believes we can crash here due to j being larger than GlyphPage::size. I think to is already
  20568. known to be < GlyphPage::size due to the min() statement above, but not being sure I added an ASSERT.
  20569. 2009-03-24 Eric Seidel <eric@webkit.org>
  20570. Reviewed by Simon Fraser.
  20571. Coverty inspired fixes in Animations/Transforms
  20572. https://bugs.webkit.org/show_bug.cgi?id=24684
  20573. * page/animation/AnimationBase.h:
  20574. Fix animate() signatures to match so that the virtual methods actually override one another. :)
  20575. * page/animation/AnimationController.cpp:
  20576. (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
  20577. Attempt to fix this method, prevAnimation was never set to anything but NULL,
  20578. as far as I can tell the author originally intended to update it at the end
  20579. of the loop, which is what I changed this code to do.
  20580. * page/animation/ImplicitAnimation.cpp:
  20581. (WebCore::ImplicitAnimation::animate):
  20582. Make method signature match AnimationBase::animate
  20583. * page/animation/ImplicitAnimation.h:
  20584. * page/animation/KeyframeAnimation.cpp:
  20585. (WebCore::KeyframeAnimation::animate):
  20586. Make method signature match AnimationBase::animate
  20587. * page/animation/KeyframeAnimation.h:
  20588. * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  20589. (WebCore::PerspectiveTransformOperation::blend):
  20590. if (blendToIdentity) already returned above.
  20591. * platform/graphics/transforms/RotateTransformOperation.cpp:
  20592. (WebCore::RotateTransformOperation::blend):
  20593. if (blendToIdentity) already returned above.
  20594. 2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
  20595. Reviewed by George Staikos.
  20596. Fix compiler warnings regarding assignments in if statements.
  20597. * html/HTMLFormElement.cpp:
  20598. (WebCore::HTMLFormElement::createFormData):
  20599. * plugins/PluginPackage.cpp:
  20600. (WebCore::PluginPackage::compare):
  20601. 2009-03-25 Dan Bernstein <mitz@apple.com>
  20602. Reviewed by Dave Hyatt.
  20603. - fix <rdar://problem/6472150> repro crash in
  20604. RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using
  20605. menus
  20606. Test: fast/inline/continuation-positioned-reparenting.html
  20607. * rendering/RenderInline.cpp:
  20608. (WebCore::RenderInline::splitFlow): When repurposing the existing
  20609. container as the "pre" block, clear its positioned objects list, because
  20610. positioned descendants may end up in a different block after the split.
  20611. 2009-03-24 Simon Fraser <simon.fraser@apple.com>
  20612. Reviewed by Dave Hyatt
  20613. https://bugs.webkit.org/show_bug.cgi?id=24784
  20614. Length values in transform operations need to take zoom into account.
  20615. Test: fast/transforms/transforms-with-zoom.html
  20616. * css/CSSStyleSelector.cpp:
  20617. (WebCore::CSSStyleSelector::createTransformOperations):
  20618. 2009-03-25 David Hyatt <hyatt@apple.com>
  20619. Reviewed by Simon Fraser.
  20620. https://bugs.webkit.org/show_bug.cgi?id=24809, background-clip/origin don't use the correct
  20621. values. Add support for the new values (while preserving the old values for backwards
  20622. compatibility).
  20623. Changed some existing test cases to use the new values.
  20624. * css/CSSParser.cpp:
  20625. (WebCore::CSSParser::parseFillProperty):
  20626. * css/CSSPrimitiveValueMappings.h:
  20627. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  20628. (WebCore::CSSPrimitiveValue::operator EFillBox):
  20629. * css/CSSValueKeywords.in:
  20630. 2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
  20631. Reviewed by Dimitri Glazkov.
  20632. Fix complex text opacity on the Chromium Windows port.
  20633. https://bugs.webkit.org/show_bug.cgi?id=24757
  20634. Test: fast/text/complex-text-opacity.html
  20635. * platform/graphics/chromium/FontChromiumWin.cpp:
  20636. (WebCore::):
  20637. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
  20638. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
  20639. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
  20640. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  20641. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
  20642. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
  20643. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
  20644. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
  20645. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
  20646. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
  20647. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
  20648. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
  20649. (WebCore::Font::drawGlyphs):
  20650. (WebCore::Font::drawComplexText):
  20651. 2009-03-25 David Hyatt <hyatt@apple.com>
  20652. Reviewed by Eric Seidel
  20653. Fix for bug 23198, border images should not clip to border radii. The border-image should just ignore
  20654. the border-radius, since the assumption is that any desired rounding will be built into the border-image
  20655. itself.
  20656. Note that I do not agree with this change, but I am matching the spec.
  20657. Added fast/borders/border-image-border-radius.html
  20658. * rendering/RenderBoxModelObject.cpp:
  20659. (WebCore::RenderBoxModelObject::paintNinePieceImage):
  20660. 2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
  20661. Reviewed by Holger Freyther.
  20662. https://bugs.webkit.org/show_bug.cgi?id=24750
  20663. [GTK] requests download instead of displaying page
  20664. Fix the Content-Type headers we get from soup, so that we set a
  20665. proper media type on the ResourceResponse.
  20666. * platform/network/soup/ResourceHandleSoup.cpp:
  20667. (WebCore::fillResponseFromMessage):
  20668. 2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
  20669. Reviewed by Holger Freyther.
  20670. https://bugs.webkit.org/show_bug.cgi?id=24600
  20671. [GTK] responses with status code >= 400 should not be given special treatment
  20672. Do not special case requests that have HTTP responses >=
  20673. 400. Redirects are handled automatically by libsoup, but the rest
  20674. of the responses should be treated like any other.
  20675. * platform/network/soup/ResourceHandleSoup.cpp:
  20676. (WebCore::):
  20677. (WebCore::gotHeadersCallback):
  20678. (WebCore::gotChunkCallback):
  20679. (WebCore::finishedCallback):
  20680. 2009-03-25 Darin Adler <darin@apple.com>
  20681. Reviewed by John Sullivan.
  20682. Tidy up LegacyWebArchive a bit. And don't include favicons in web archives when
  20683. they are being used only for selections, not an entire document.
  20684. * WebCore.base.exp: Remove exported function that's not used in WebKit.
  20685. * loader/archive/cf/LegacyWebArchive.cpp:
  20686. (WebCore::LegacyWebArchive::createPropertyListRepresentation): Made a static member
  20687. function so it can share private things with other member functions. Added some FIXME
  20688. comments to a branch of code I think is dead. Changed boolean argument into a named
  20689. one. Renamed to match other similar functions.
  20690. (WebCore::LegacyWebArchive::createResourceResponseFromPropertyListData): Ditto.
  20691. (WebCore::LegacyWebArchive::createResource): Ditto.
  20692. (WebCore::LegacyWebArchive::create): Merged the create and init functions.
  20693. (WebCore::LegacyWebArchive::rawDataRepresentation): Added some assertions because
  20694. we should never fail to write (we can fail to read).
  20695. (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Made a static
  20696. member function as above.
  20697. (WebCore::LegacyWebArchive::createFromSelection): Ditto.
  20698. (WebCore::LegacyWebArchive::create): Iterate the vector with indices rather than
  20699. iterators. Only include the favicon if the first node is the document since we don't
  20700. want to include the favicon when copying and pasting.
  20701. * loader/archive/cf/LegacyWebArchive.h: Made one of the create functions private.
  20702. Made the Mac-specific functions be static member functions. Made other helpers be
  20703. static member functions. Removed the nit function.
  20704. * loader/archive/cf/LegacyWebArchiveMac.mm:
  20705. (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Updated
  20706. comment and made this a static member function.
  20707. (WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto. Also made
  20708. it so we only type cast in one place.
  20709. 2009-03-25 Darin Adler <darin@apple.com>
  20710. Reviewed by David Hyatt.
  20711. Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
  20712. https://bugs.webkit.org/show_bug.cgi?id=24740
  20713. rdar://problem/6679873
  20714. Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
  20715. https://bugs.webkit.org/show_bug.cgi?id=12104
  20716. Test: media/video-display-none-crash.html
  20717. The problem here was that RenderSlider was trying to position its thumb in a way that
  20718. requires it to call updateLayout inside rendering code. The right way to position a
  20719. child renderer is to do layout, so I had to write a layout function. And then fix a few
  20720. other small problems shown by the same test case.
  20721. * rendering/RenderSlider.cpp: Made defaultTrackLength have internal linkage.
  20722. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML
  20723. prefix for public DOM classes, not elements used as implementation details.
  20724. Made SliderThumbElement function members private and got rid of unneeded default
  20725. argument value for shadowParent.
  20726. (WebCore::SliderRange::SliderRange): Added. Parses precision, max, and min attributes.
  20727. (WebCore::SliderRange::clampValue): Added. Does standard clamping based on the above.
  20728. (WebCore::SliderRange::valueFromElement): Added. Reads the value from the element in
  20729. a way that clamps to the range.
  20730. (WebCore::sliderPosition): Added. Computes the slider position: a double.
  20731. (WebCore::SliderThumbElement::SliderThumbElement): Removed unneeded explicit
  20732. initialization of m_initialClickPoint.
  20733. (WebCore::SliderThumbElement::defaultEventHandler): Call setValueForPosition instead
  20734. of calling setCurrentPosition and valueChanged.
  20735. (WebCore::RenderSlider::RenderSlider): Remove unneeded explicit initialization of m_thumb.
  20736. (WebCore::RenderSlider::styleDidChange): Remove unneeded second argument to createThumbStyle.
  20737. (WebCore::RenderSlider::createThumbStyle): Remove unneeded second argument. Get rid of code
  20738. setting the position to relative and setting the left and top. We now handle positioning
  20739. in a custom layout function.
  20740. (WebCore::RenderSlider::layout): Rewrote to handle positioning of the thumb as layout.
  20741. (WebCore::RenderSlider::updateFromElement): Added code to immediately update the value
  20742. in the element if it's out of range. This clamping used to be done as a side effect of
  20743. setPositionFromValue. Also, this has nothing to do with the renderer, so at some point
  20744. it could be moved into HTMLInputElement. Removed call to setPositionFromValue
  20745. and instead just rely on the call to setNeedsLayout. Fix the setNeedsLayout call to be
  20746. a normal setNeedsLayout(true), not a setNeedsLayout(true, false), because we do want
  20747. this to be propagated to the parent -- it's not called during layout.
  20748. (WebCore::RenderSlider::setValueForPosition): Refactor to use the new SliderRange
  20749. class. Also don't call setCurrentPosition; instead just call setNeedsLayout.
  20750. (WebCore::RenderSlider::currentPosition): Use the actual position of the renderer rather
  20751. than the style to find the position; that means this needs to be done after layout is done.
  20752. Also removed unneeded runtime checks and replaced them with assertions, after checking
  20753. all callers to see they already guarantee this.
  20754. (WebCore::RenderSlider::trackSize): Removed unneeded runtime checks and replaced them
  20755. with assertions, after checking all callers to see they already guarantee this.
  20756. (WebCore::RenderSlider::inDragMode): Added a null check for m_thumb so this won't
  20757. crash if called early on a brand new RenderSlider.
  20758. * rendering/RenderSlider.h: Made all functions private except for forwardEvent and inDragMode.
  20759. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML
  20760. prefix for public DOM classes, not elements used as implementation details. Made the
  20761. mouseEventIsInThumb function non-virtual. Removed the return value and argument from
  20762. setPositionFromValue. Removed valueChanged and setCurrentPosition. Removed the oldStyle
  20763. argument to createThumbStyle (see above). Made SliderThumbElement a friend so it can use some
  20764. private member functions.
  20765. 2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
  20766. Reviewed by George Staikos.
  20767. Fix ambiguous else cases by adding braces to nested if()s with elses.
  20768. * loader/MainResourceLoader.cpp:
  20769. (WebCore::MainResourceLoader::continueAfterContentPolicy):
  20770. * page/EventHandler.cpp:
  20771. (WebCore::EventHandler::updateDragAndDrop):
  20772. * rendering/RenderListMarker.cpp:
  20773. (WebCore::toArmenianUnder10000):
  20774. * rendering/TextControlInnerElements.cpp:
  20775. (WebCore::TextControlInnerTextElement::defaultEventHandler):
  20776. 2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
  20777. Reviewed by George Staikos.
  20778. Move variable into proper platform block to quiet warning.
  20779. * html/CanvasRenderingContext2D.cpp:
  20780. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  20781. 2009-03-24 Eric Carlson <eric.carlson@apple.com>
  20782. Reviewed by Antti Koivisto.
  20783. Fix for <rdar://problem/6719375> Deal with QTKit loadstate changes when playing streaming movies
  20784. * WebCore/html/HTMLMediaElement.cpp:
  20785. (WebCore::HTMLMediaElement::setNetworkState): Deal with media engine reviving after having
  20786. network state of NETWORK_NO_SOURCE.
  20787. * WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  20788. (WebCore::MediaPlayerPrivate::updateStates): Reset m_readyState at each state change since
  20789. some types of movies currently cause QTKit's load state to bounce around. QTMovieLoadStatePlaythroughOK
  20790. corresponds to HaveFutureData, not HaveEnoughData.
  20791. 2009-03-24 Adele Peterson <adele@apple.com>
  20792. Reviewed by Darin Adler.
  20793. Fix for https://bugs.webkit.org/show_bug.cgi?id=24707
  20794. <rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
  20795. * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
  20796. After breaking out of an empty mail blockquote, we still want continue with the deletion
  20797. so actual content will get deleted, and not just the quote style.
  20798. 2009-03-24 Darin Adler <darin@apple.com>
  20799. Reviewed by Brady Eidson.
  20800. <rdar://problem/6624662> REGRESSION (r39904): can't save certain web pages as web archive (ones without favicons!)
  20801. * loader/archive/cf/LegacyWebArchive.cpp:
  20802. (WebCore::LegacyWebArchive::create): Added a null check.
  20803. 2009-03-24 Adam Langley <agl@google.com>
  20804. Reviewed by Darin Fisher.
  20805. https://bugs.webkit.org/show_bug.cgi?id=24685
  20806. The Skia drawLine function takes subpixel values and attempts to draw
  20807. a line with subpixel precision. This is complex and slow for drawing
  20808. scrollbars which use only vertical and horizontal lines.
  20809. This changes the Chromium Linux scrollbar code to use drawIRect.
  20810. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  20811. (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
  20812. (WebCore::drawVertLine):
  20813. (WebCore::drawHorizLine):
  20814. (WebCore::drawBox):
  20815. (WebCore::ScrollbarThemeChromium::paintTrackPiece):
  20816. (WebCore::ScrollbarThemeChromium::paintThumb):
  20817. 2009-03-24 David Kilzer <ddkilzer@apple.com>
  20818. Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly
  20819. <https://bugs.webkit.org/show_bug.cgi?id=23310>
  20820. Reviewed by Darin Adler.
  20821. Test: fast/frames/iframe-no-src-set-location.html
  20822. * dom/Document.cpp:
  20823. (WebCore::Document::completeURL): If m_baseURL is empty or is
  20824. about:blank and we have a parent document, use the parent
  20825. document's URL for the base when completing a new URL.
  20826. 2009-03-24 Simon Fraser <simon.fraser@apple.com>
  20827. Reviewed by Dave Hyatt
  20828. https://bugs.webkit.org/show_bug.cgi?id=24659
  20829. When hit-testing 3d-transformed layers, it doesn't make sense to project the hitTestRect
  20830. into the coordinate space of the layer, and doing so can result in pathalogical quads
  20831. that break hit testing. In that case, simply use the same bounds as used for painting,
  20832. which are the composited bounds for this layer.
  20833. Test: transforms/3d/hit-testing/rotated-hit-test.html
  20834. * rendering/RenderLayer.cpp:
  20835. (WebCore::RenderLayer::hitTestLayer):
  20836. 2009-03-24 Simon Fraser <simon.fraser@apple.com>
  20837. Reviewed by Dave Hyatt
  20838. https://bugs.webkit.org/show_bug.cgi?id=24436
  20839. When compositing is enabled, painting and hit testing end up using different
  20840. clipping roots, because, for painting, every composited layer is a clipping root,
  20841. but for hit testing only layers with transforms are. To fix this, we use
  20842. temporary clip rects for hit testing, if the page is in compositing mode.
  20843. * rendering/RenderLayer.cpp:
  20844. (WebCore::RenderLayer::paintLayer):
  20845. (WebCore::RenderLayer::hitTestLayer):
  20846. (WebCore::RenderLayer::parentClipRects):
  20847. (WebCore::RenderLayer::calculateRects):
  20848. * rendering/RenderLayer.h:
  20849. 2009-03-24 Simon Fraser <simon.fraser@apple.com>
  20850. Reviewed by Dan Bernstein
  20851. https://bugs.webkit.org/show_bug.cgi?id=24782
  20852. Fix regression with CSS clip rects with non-length values, by reverting to
  20853. the original code, but passing the zoom multiplier through convertToLength().
  20854. Also make stylistic change in createTransformOperations(), renaming 'inStyle'
  20855. to 'style.
  20856. Tested by existing tests.
  20857. * css/CSSStyleSelector.cpp:
  20858. (WebCore::convertToLength):
  20859. (WebCore::CSSStyleSelector::applyProperty):
  20860. (WebCore::CSSStyleSelector::createTransformOperations):
  20861. 2009-03-24 David Hyatt <hyatt@apple.com>
  20862. Reviewed by Simon Fraser
  20863. https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents
  20864. to a border-radius.
  20865. This patch makes non-self-painting overflow layers and control clips work with border-radius. RenderLayers
  20866. that should be clipped by overflow ancestors with border-radius are still broken.
  20867. Added fast/clip/overflow-border-radius-clip.html
  20868. * rendering/RenderBox.cpp:
  20869. (WebCore::RenderBox::pushContentsClip):
  20870. 2009-03-24 David Hyatt <hyatt@apple.com>
  20871. Reviewed by Simon Fraser
  20872. https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents.
  20873. This first patch makes overflow:hidden properly clip the foreground contents of overflow:hidden replaced elements. Common
  20874. replaced elements now default to overflow:hidden in the UA stylesheet (this is what the spec specifically recommends be
  20875. done).
  20876. Added fast/replaced/border-radius-clip.html
  20877. * css/html4.css:
  20878. * rendering/RenderReplaced.cpp:
  20879. (WebCore::RenderReplaced::paint):
  20880. * rendering/RenderWidget.cpp:
  20881. (WebCore::RenderWidget::paint):
  20882. 2009-03-24 Adele Peterson <adele@apple.com>
  20883. RS by Mark Rowe.
  20884. Only build these Mail quirks checks in on the Mac.
  20885. * dom/Document.cpp: (WebCore::disableRangeMutation):
  20886. * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
  20887. 2009-03-24 Brent Fulgham <bfulgham@webkit.org>
  20888. Build fix, no review.
  20889. Remove ResourceLoaderCFNet.cpp from build list for Cairo Releas
  20890. and Debug targets.
  20891. * WebCore.vcproj/WebCore.vcproj:
  20892. 2009-03-24 Eric Carlson <eric.carlson@apple.com>
  20893. Fix layout tests broken by r41907.
  20894. * html/HTMLMediaElement.cpp:
  20895. (WebCore::HTMLMediaElement::setReadyState): Don't set "was playing" based on the new ready state
  20896. 2009-03-24 Dmitry Titov <dimich@chromium.org>
  20897. Reviewed by Dimitri Glazkov.
  20898. https://bugs.webkit.org/show_bug.cgi?id=24689
  20899. Fix Chromium compilation errors.
  20900. * bindings/v8/WorkerContextExecutionProxy.cpp:
  20901. (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener):
  20902. (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
  20903. 2009-03-24 Yury Semikhatsky <yurys@chromium.org>
  20904. Reviewed by Darin Adler.
  20905. https://bugs.webkit.org/show_bug.cgi?id=24759
  20906. Add missing methods Element.prototype.removeMatchingStyleClasses and
  20907. Node.prototype.enclosingNodeOrSelfWithNodeNameInArray to SourceFrame content
  20908. iframe. These methods are called by Element.prototype.removeStyleClass and
  20909. Node.prototype.enclosingNodeOrSelfWithNodeName.
  20910. * inspector/front-end/SourceFrame.js:
  20911. (WebInspector.SourceFrame.prototype._loaded):
  20912. 2009-03-24 Mark Mentovai <mark@chromium.org>
  20913. Reviewed by Mark Rowe.
  20914. https://bugs.webkit.org/show_bug.cgi?id=24653
  20915. WebKit should be buildable without prefix header injection.
  20916. Adds missing #includes and forward declarations as needed.
  20917. * editing/SmartReplaceCF.cpp:
  20918. * platform/graphics/mac/ColorMac.mm:
  20919. * platform/graphics/mac/FontCacheMac.mm:
  20920. * platform/graphics/mac/FontCustomPlatformData.h:
  20921. * platform/graphics/mac/FontMac.mm:
  20922. * platform/graphics/mac/FontMacATSUI.mm:
  20923. * platform/graphics/mac/FontPlatformData.h:
  20924. * platform/graphics/mac/FontPlatformDataMac.mm:
  20925. * platform/graphics/mac/GraphicsContextMac.mm:
  20926. * platform/graphics/mac/SimpleFontDataMac.mm:
  20927. * platform/mac/FoundationExtras.h:
  20928. * platform/mac/LocalCurrentGraphicsContext.h:
  20929. * platform/mac/WebCoreSystemInterface.h:
  20930. * platform/mac/WebCoreSystemInterface.mm:
  20931. * platform/mac/WebCoreTextRenderer.h:
  20932. * platform/mac/WebCoreTextRenderer.mm:
  20933. * platform/mac/WebFontCache.h:
  20934. * platform/mac/WebFontCache.mm:
  20935. * platform/text/PlatformString.h:
  20936. * platform/text/mac/ShapeArabic.c:
  20937. * platform/text/mac/StringMac.mm:
  20938. * rendering/RenderThemeChromiumMac.h:
  20939. 2009-03-24 Dan Bernstein <mitz@apple.com>
  20940. Reviewed by Darin Adler.
  20941. - fix <rdar://problem/6107874> by capping the nesting depth of
  20942. "block-level" elements generated by the parser
  20943. Test: fast/parser/block-nesting-cap.html
  20944. * html/HTMLParser.cpp:
  20945. (WebCore::HTMLParser::HTMLParser):
  20946. (WebCore::HTMLParser::insertNode):
  20947. (WebCore::HTMLParser::pushBlock):
  20948. (WebCore::HTMLParser::popOneBlockCommon):
  20949. (WebCore::HTMLParser::freeBlock):
  20950. * html/HTMLParser.h:
  20951. 2009-03-23 Greg Bolsinga <bolsinga@apple.com>
  20952. Reviewed by David Kilzer.
  20953. https://bugs.webkit.org/show_bug.cgi?id=24771
  20954. DOMTimeStamps are based upon 1970.
  20955. * platform/mac/GeolocationServiceMac.mm:
  20956. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
  20957. 2009-03-23 Eric Seidel <eric@webkit.org>
  20958. Build fix, no review.
  20959. * rendering/RenderObject.cpp:
  20960. (WebCore::RenderObject::createVisiblePosition): change .container to .isNotNull()
  20961. 2009-03-23 Eric Seidel <eric@webkit.org>
  20962. Reviewed by Darin Adler.
  20963. Rename Position::container to m_anchorNode and make it private
  20964. https://bugs.webkit.org/show_bug.cgi?id=24760
  20965. More code cleanup for Position.
  20966. Change all uses of m_container to node()
  20967. Eventually most uses of node() should change to anchorNode() to designate
  20968. that it's the node the Position is anchored to, but not necessarily the
  20969. container of the position (it could be the before/after neighbor).
  20970. Remove any code which sets m_container, and change it to use a new
  20971. Position::moveToPosition function which takes a node and offset.
  20972. It never makes sense to change the node and leave the offset.
  20973. * dom/Position.h:
  20974. (WebCore::Position::Position):
  20975. (WebCore::Position::clear):
  20976. (WebCore::Position::anchorNode):
  20977. (WebCore::Position::node):
  20978. (WebCore::Position::moveToPosition):
  20979. (WebCore::Position::moveToOffset):
  20980. (WebCore::Position::isNull):
  20981. (WebCore::Position::isNotNull):
  20982. (WebCore::operator==):
  20983. * dom/Range.cpp:
  20984. (WebCore::Range::create):
  20985. (WebCore::Range::compareBoundaryPoints):
  20986. * dom/RangeBoundaryPoint.h:
  20987. (WebCore::RangeBoundaryPoint::container):
  20988. (WebCore::RangeBoundaryPoint::set):
  20989. (WebCore::RangeBoundaryPoint::setOffset):
  20990. (WebCore::RangeBoundaryPoint::setToChild):
  20991. (WebCore::RangeBoundaryPoint::setToStart):
  20992. (WebCore::RangeBoundaryPoint::setToEnd):
  20993. 2009-03-17 Eric Seidel <eric@webkit.org>
  20994. Reviewed by David Hyatt.
  20995. document.write() should be able to make a document strict mode
  20996. https://bugs.webkit.org/show_bug.cgi?id=24336
  20997. Remove an implicit write of "<html>" on the first document.write call
  20998. this was added as part of a KDE import http://trac.webkit.org/changeset/798
  20999. with no layout test or explanation. I can't think of any reason why
  21000. an implicit <html> write is necessary (or correct), so I'm removing it and
  21001. adding a test for the correct behavior. The parser will add any necessary
  21002. HTMLHTMLElements during the write() anyway.
  21003. Our behavior is now tested by fast/dom/Document/document-write-doctype
  21004. and matches IE, FF fails this new test. Mozilla bug filed:
  21005. https://bugzilla.mozilla.org/show_bug.cgi?id=483908
  21006. * dom/Document.cpp:
  21007. (WebCore::Document::write):
  21008. 2009-03-23 Sam Weinig <sam@webkit.org>
  21009. Reviewed by Dan Bernstein.
  21010. Fix for <rdar://problem/6140966>
  21011. Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
  21012. * WebCore.base.exp:
  21013. * WebCore.xcodeproj/project.pbxproj:
  21014. * loader/CrossOriginPreflightResultCache.cpp:
  21015. (WebCore::CrossOriginPreflightResultCache::empty):
  21016. * loader/CrossOriginPreflightResultCache.h:
  21017. 2009-03-23 Darin Adler <darin@apple.com>
  21018. Reviewed by Adele Peterson.
  21019. Bug 24726: hit testing doesn't work right when the click is on anonymous content
  21020. https://bugs.webkit.org/show_bug.cgi?id=24726
  21021. rdar://problem/6696992
  21022. Test: editing/selection/hit-test-anonymous.html
  21023. * rendering/RenderBR.cpp:
  21024. (WebCore::RenderBR::positionForPoint): Call createVisiblePosition instead of
  21025. creating a VisiblePosition directly. It will handle finding non-anonymous
  21026. content nearby if node() is 0.
  21027. * rendering/RenderBlock.cpp:
  21028. (WebCore::positionForPointRespectingEditingBoundaries): Ditto.
  21029. (WebCore::positionForPointWithInlineChildren): Ditto.
  21030. (WebCore::RenderBlock::positionForPoint): Ditto.
  21031. * rendering/RenderBox.cpp:
  21032. (WebCore::RenderBox::positionForPoint): Ditto.
  21033. * rendering/RenderObject.cpp:
  21034. (WebCore::RenderObject::positionForPoint): Ditto.
  21035. (WebCore::RenderObject::createVisiblePosition): Added.
  21036. * rendering/RenderObject.h: Added createVisiblePosition.
  21037. * rendering/RenderReplaced.cpp:
  21038. (WebCore::RenderReplaced::positionForPoint): Call createVisiblePosition.
  21039. * rendering/RenderSVGInlineText.cpp:
  21040. (WebCore::RenderSVGInlineText::positionForPoint): Ditto.
  21041. * rendering/RenderText.cpp:
  21042. (WebCore::RenderText::positionForPoint): Ditto.
  21043. 2009-03-23 Adele Peterson <adele@apple.com>
  21044. Reviewed by Darin Adler & Dave Hyatt.
  21045. Fix for <rdar://problem/6621310> REGRESSION(35185): Apple Travel HTML emails missing some style after Safari 4 upgrade
  21046. Leopard Mail doesn't expect <style> to be in the body. This change reverts back to the old behavior of
  21047. moving <style> to <head> for that version of Mail.
  21048. * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
  21049. 2009-03-23 Adele Peterson <adele@apple.com>
  21050. Reviewed by Mark Rowe & Dave Hyatt.
  21051. Merge some of the individual Mail quirks into two settings that we can check for future quirks.
  21052. * WebCore.base.exp:
  21053. * dom/Document.cpp:
  21054. (WebCore::disableRangeMutation):
  21055. (WebCore::Document::nodeChildrenChanged):
  21056. (WebCore::Document::nodeWillBeRemoved):
  21057. (WebCore::Document::textInserted):
  21058. (WebCore::Document::textRemoved):
  21059. (WebCore::Document::textNodesMerged):
  21060. (WebCore::Document::textNodeSplit):
  21061. * page/Settings.cpp:
  21062. (WebCore::Settings::Settings):
  21063. (WebCore::Settings::setNeedsLeopardMailQuirks):
  21064. (WebCore::Settings::setNeedsTigerMailQuirks):
  21065. * page/Settings.h:
  21066. (WebCore::Settings::needsLeopardMailQuirks):
  21067. (WebCore::Settings::needsTigerMailQuirks):
  21068. 2009-03-23 Ada Chan <adachan@apple.com>
  21069. https://bugs.webkit.org/show_bug.cgi?id=24762
  21070. Support text-indent in <option> elements on windows platform.
  21071. Reviewed by Adele Peterson.
  21072. * css/themeWin.css:
  21073. * platform/PopupMenuStyle.h: We don't honor font specified on <option> elements right now. Make this
  21074. explicit via windows themed default stylesheet.
  21075. (WebCore::PopupMenuStyle::PopupMenuStyle): Also store text-indent and text-direction.
  21076. (WebCore::PopupMenuStyle::textIndent):
  21077. (WebCore::PopupMenuStyle::textDirection):
  21078. * platform/win/PopupMenuWin.cpp:
  21079. (WebCore::PopupMenu::paint): Adjust the text's x-coordinate if text-indent is supported for options and
  21080. text-indent is specified with LTR direction.
  21081. * rendering/RenderMenuList.cpp:
  21082. (WebCore::RenderMenuList::updateOptionsWidth): Take text-indent into account if theme supports text-indent for options.
  21083. (WebCore::RenderMenuList::itemStyle): Use new PopupMenuStyle constructor on windows.
  21084. (WebCore::RenderMenuList::menuStyle): Ditto.
  21085. * rendering/RenderTextControlSingleLine.cpp:
  21086. (WebCore::RenderTextControlSingleLine::menuStyle): Ditto.
  21087. * rendering/RenderTheme.h:
  21088. (WebCore::RenderTheme::popupOptionSupportsTextIndent): Added. Default is false since we are only supporting it in windows for now.
  21089. * rendering/RenderThemeWin.h:
  21090. (WebCore::RenderThemeWin::popupOptionSupportsTextIndent): Returns true for windows.
  21091. 2009-03-23 Sam Weinig <sam@webkit.org>
  21092. Reviewed by Anders Carlsson.
  21093. Fix for https://bugs.webkit.org/show_bug.cgi?id=24699
  21094. REGRESSION: Java Applets broken
  21095. <rdar://problem/6707494>
  21096. Fix loading Java applets without a codeBase. Only pass the base (up to the
  21097. the last path component) of the baseURL to the plug-in.
  21098. * html/HTMLAppletElement.cpp:
  21099. (WebCore::HTMLAppletElement::createRenderer):
  21100. * platform/KURL.cpp:
  21101. (WebCore::KURL::baseAsString):
  21102. * platform/KURL.h:
  21103. 2009-03-23 Darin Adler <darin@apple.com>
  21104. Reviewed by Sam Weinig.
  21105. * platform/KURL.h: Removed now-incorrect comments.
  21106. None of the parts include the separator characters any more, now that
  21107. query doesn't include the "?", so the comments explaining which do and do
  21108. not are no-longer helpful.
  21109. 2009-03-23 David Levin <levin@chromium.org>
  21110. Reviewed by Dimitri Glazkov.
  21111. https://bugs.webkit.org/show_bug.cgi?id=24764
  21112. Renamed files V8NodeFilter -> V8NodeFilterCondition to reflect
  21113. class names. Also fixed some headers that got mangled in search/replace
  21114. operations.
  21115. No change in behavior, so no test.
  21116. * bindings/v8/V8NodeFilter.h: Removed.
  21117. * bindings/v8/V8NodeFilterCondition.cpp: Renamed from WebCore/bindings/v8/V8NodeFilter.cpp.
  21118. * bindings/v8/V8NodeFilterCondition.h: Added.
  21119. * bindings/v8/custom/V8ClipboardCustom.cpp:
  21120. * bindings/v8/custom/V8DocumentCustom.cpp:
  21121. * bindings/v8/custom/V8ElementCustom.cpp:
  21122. * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  21123. * bindings/v8/custom/V8NavigatorCustom.cpp:
  21124. 2009-03-23 Darin Fisher <darin@chromium.org>
  21125. Reviewed by Antti Koivisto.
  21126. https://bugs.webkit.org/show_bug.cgi?id=24741
  21127. Adds a unique across-browser-sessions identifier to FormData, which may
  21128. be used by ResourceHandle as a secondary cache key to enable cached
  21129. form submissions.
  21130. At issue: two otherwise identical form submissions may result in
  21131. completely independent responses, which may each be appropriate to
  21132. store and reuse from cache.
  21133. * html/HTMLFormElement.cpp: Added call to FormData::setIdentifier so that
  21134. we only enable cached form submissions for those generated by HTML. This
  21135. way we do not bother with POSTs generated by XMLHttpRequest.
  21136. (WebCore::generateFormDataIdentifier):
  21137. (WebCore::HTMLFormElement::createFormData):
  21138. * platform/network/FormData.cpp: Initialize m_identifier to 0, which means
  21139. the unspecified identifier. So by default there is no identifier and
  21140. nothing changes.
  21141. (WebCore::FormData::FormData):
  21142. * platform/network/FormData.h: Added m_identifier with setter and getter.
  21143. (WebCore::FormData::setIdentifier):
  21144. (WebCore::FormData::identifier):
  21145. 2009-03-23 Simon Fraser <simon.fraser@apple.com>
  21146. Reviewed by Antti Koivisto
  21147. https://bugs.webkit.org/show_bug.cgi?id=24733
  21148. Fix media controller with full-page zoom. Previously, the media controller
  21149. shadow nodes never saw style changes on the RenderMedia, so did not respond
  21150. to zooming at all. Now, we update the style on the shadow renderers
  21151. whenever RenderMedia gets a style change. Also fix the video thumb in
  21152. the theme to be scaled properly.
  21153. Test: media/video-controls-zoomed.html
  21154. * rendering/MediaControlElements.cpp:
  21155. (WebCore::MediaControlShadowRootElement::updateStyle):
  21156. (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
  21157. (WebCore::MediaTextDisplayElement::updateStyle):
  21158. (WebCore::MediaControlInputElement::MediaControlInputElement):
  21159. (WebCore::MediaControlInputElement::updateStyle):
  21160. * rendering/MediaControlElements.h:
  21161. * rendering/RenderMedia.cpp:
  21162. (WebCore::RenderMedia::styleDidChange):
  21163. * rendering/RenderMedia.h:
  21164. * rendering/RenderThemeMac.mm:
  21165. (WebCore::RenderThemeMac::adjustSliderThumbSize):
  21166. 2009-03-23 Mike Belshe <mike@belshe.com>
  21167. Reviewed by Darin Adler.
  21168. https://bugs.webkit.org/show_bug.cgi?id=24739
  21169. Rework StringImpl::create methods to try to allocate a single buffer
  21170. rather than allocating both the StringImpl class and a separate data
  21171. buffer.
  21172. * platform/text/StringImpl.cpp:
  21173. * platform/text/StringImpl.h:
  21174. 2009-03-23 Darin Adler <darin@apple.com>
  21175. Reviewed by Antti Koivisto.
  21176. Based on a patch by Nico Weber <nicolasweber@gmx.de>
  21177. Bug 24755: LayoutTests/http/tests/misc/url-in-utf16le.html regression
  21178. https://bugs.webkit.org/show_bug.cgi?id=24755
  21179. * platform/text/TextEncoding.cpp:
  21180. (WebCore::TextEncoding::isUTF7Encoding): Added. Checks if the current encoding
  21181. is UTF7 without loading extended codecs.
  21182. (WebCore::TextEncoding::encodingForFormSubmission): Use isUTF7Encoding() instead
  21183. of comparing with UTF7Encoding(). Eliminate the explicit check of
  21184. noExtendedTextEncodingNameUsed() because that's now handled by the functions
  21185. that this function calls instead.
  21186. * platform/text/TextEncoding.h: Added isUTF7Encoding function.
  21187. Also tweaked formatting a bit.
  21188. 2009-03-20 Peter Kasting <pkasting@google.com>
  21189. Reviewed by Darin Fisher.
  21190. https://bugs.webkit.org/show_bug.cgi?id=24720
  21191. RenderThemeChromium should draw something for Slider parts instead of
  21192. dropping them on the floor.
  21193. * platform/chromium/ChromiumBridge.h:
  21194. * rendering/RenderThemeChromiumWin.cpp:
  21195. (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
  21196. (WebCore::RenderThemeChromiumWin::paintSliderTrack):
  21197. (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
  21198. (WebCore::RenderThemeChromiumWin::getThemeData):
  21199. * rendering/RenderThemeChromiumWin.h:
  21200. (WebCore::RenderThemeChromiumWin::paintSliderThumb):
  21201. 2009-03-23 Glen Murphy <glen@chromium.org>
  21202. Reviewed by Darin Fisher.
  21203. https://bugs.webkit.org/show_bug.cgi?id=24657
  21204. Fix Skia drawing of highly scaled bitmaps; the conversion to
  21205. IntRect produced visible layout test failures in highly scaled
  21206. coordinate systems.
  21207. Test: svg/custom/image-small-width-height.svg
  21208. * WebCore\platform\graphics\skia\ImageSkia.cpp:
  21209. 2009-03-23 David Kilzer <ddkilzer@apple.com>
  21210. Provide JavaScript exception information after slow script timeout
  21211. Reviewed by Oliver Hunt.
  21212. * bindings/js/ScriptController.cpp:
  21213. (WebCore::ScriptController::evaluate): Changed to report
  21214. exceptions for the Interrupted completion type as well.
  21215. 2009-03-23 Simon Fraser <simon.fraser@apple.com>
  21216. Reviewed by Darin Adler
  21217. https://bugs.webkit.org/show_bug.cgi?id=24736
  21218. Fix three mostly-unrelated problems with full-page zoom:
  21219. * dom/Document.cpp:
  21220. (WebCore::Document::elementFromPoint):
  21221. Document::elementFromPoint() needs to take full-page zoom into account.
  21222. * dom/MouseRelatedEvent.cpp:
  21223. (WebCore::MouseRelatedEvent::receivedTarget):
  21224. Take full-page zoom into account when computing offsetX/offsetY.
  21225. * html/HTMLSelectElement.cpp:
  21226. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  21227. Don't use offsetX/offsetY when hit testing list boxes; offsets were broken
  21228. with full-page zoom, and using pageX/pageY is easier because we don't
  21229. have to worry about the event target, and we already have a point in
  21230. absolute coordinates.
  21231. Tests: fast/forms/listbox-hit-test-zoomed.html
  21232. fast/forms/search-zoomed.html
  21233. fast/forms/slider-zoomed.html
  21234. 2009-03-23 Simon Fraser <simon.fraser@apple.com>
  21235. Reviewed by Dan Bernstein
  21236. https://bugs.webkit.org/show_bug.cgi?id=24753
  21237. The rect for CSS 'clip' needs to have zooming applied to it.
  21238. Test: fast/css/clip-zooming.html
  21239. * css/CSSStyleSelector.cpp:
  21240. (WebCore::CSSStyleSelector::applyProperty):
  21241. 2009-03-23 Eric Carlson <eric.carlson@apple.com>
  21242. Reviewed by Adam Roben.
  21243. <rdar://problem/6704282>
  21244. https://bugs.webkit.org/show_bug.cgi?id=24719
  21245. QTMovieWinTimer logic inversion
  21246. Fix logic inversion in the Win32 timer used by QTMovieWin that caused it to always
  21247. use SetTimer, even when the intervals was below USER_TIMER_MINIMUM. A side effect of
  21248. this was that a movie timer would sometimes be blocked for significant amounts of time
  21249. because WM_TIMER messages are not processed when the thread's message queue has any
  21250. higher priority messages, and WebCore/Win's timer uses PostMessage for low interval
  21251. timers. Also change SetTimer call to use HWND and custom message instead of
  21252. timer function since the timer already has an HWND for processing PostMessage.
  21253. Not possible to make a test for this because it is so timing dependant.
  21254. * platform/graphics/win/QTMovieWinTimer.cpp:
  21255. (TimerWindowWndProc):
  21256. (setSharedTimerFireDelay):
  21257. 2009-03-23 Eric Carlson <eric.carlson@apple.com>
  21258. Reviewed by Adele Peterson.
  21259. https://bugs.webkit.org/show_bug.cgi?id=24588
  21260. Update media element implementation to current HTML5 spec
  21261. New tests:
  21262. media/media-constants.html
  21263. media/video-seek-no-src-exception.html
  21264. media/video-source-add-src.html
  21265. media/video-src-invalid-remove.html
  21266. media/video-src-plus-source.html
  21267. media/video-timeupdate-during-playback.html
  21268. * dom/EventNames.h: Remove obsolute events, add new ones.
  21269. * html/HTMLMediaElement.cpp:
  21270. (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member vars.
  21271. (WebCore::HTMLMediaElement::attributeChanged): Trigger load() only when we don't
  21272. have a source.
  21273. (WebCore::HTMLMediaElement::removedFromDocument): Deal with state name changes.
  21274. (WebCore::HTMLMediaElement::scheduleProgressEvent): New, create a progress event and
  21275. add it to the event queue to be dispatch when the timer fires.
  21276. (WebCore::HTMLMediaElement::scheduleEvent): New, create a generic event and add
  21277. it to the event queue to be dispatch when the timer fires.
  21278. (WebCore::HTMLMediaElement::enqueueEvent): Add an event to the queue and ticke the
  21279. asynch event timer.
  21280. (WebCore::HTMLMediaElement::asyncEventTimerFired): Dispatch all pending events.
  21281. (WebCore::HTMLMediaElement::loadTimerFired): Either trigger the initial load or
  21282. try to load the next <source> url.
  21283. (WebCore::HTMLMediaElement::load): Minor style change.
  21284. (WebCore::HTMLMediaElement::loadInternal): The first part of the spec load algorithm, cleanup
  21285. the current load (if any) and set up state for a new load.
  21286. (WebCore::HTMLMediaElement::selectMediaResource): Deal with no 'src' or <source>, post 'loadstart'
  21287. event, and initiate load from 'src' if present.
  21288. (WebCore::HTMLMediaElement::loadNextSourceChild): Initiate load from next <source> url, or trigger
  21289. noneSupported() if no more to consider.
  21290. (WebCore::HTMLMediaElement::loadResource): Instantiate a new MediaPlayer and ask it to load a url.
  21291. (WebCore::HTMLMediaElement::startProgressEventTimer): Start the repeating progress event timer.
  21292. (WebCore::HTMLMediaElement::noneSupported): Post error event and set up state when no valid
  21293. media url was found.
  21294. (WebCore::HTMLMediaElement::mediaEngineError): Post error event and set up state when no valid
  21295. media engine failed with a decode error or a network error.
  21296. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
  21297. (WebCore::HTMLMediaElement::setNetworkState): Updated for new spec network states.
  21298. (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
  21299. (WebCore::HTMLMediaElement::setReadyState): Updated for new spec ready state.
  21300. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if the network is not active.
  21301. (WebCore::HTMLMediaElement::seek): Return INVALID_STATE_ERR exception if state is too low or
  21302. if player hasn't been set up yet. This is necessary becase load() is async. Clear the flag
  21303. we use to guard against sending 'ended' more than once.
  21304. (WebCore::HTMLMediaElement::duration): Don't bother calling media engine before it has metadata.
  21305. (WebCore::HTMLMediaElement::setDefaultPlaybackRate): Remove exception param, 0 is no longer an
  21306. invalid rate.
  21307. (WebCore::HTMLMediaElement::setPlaybackRate): Remove exception param, 0 is no longer an
  21308. invalid rate. Cache rate being set so we can use it later if media engine isn't ready now.
  21309. (WebCore::HTMLMediaElement::play): Remove exception param, play() before load() now just
  21310. starts loading asynchronously.
  21311. (WebCore::HTMLMediaElement::playInternal): Remove exception param. Fire 'waiting' or 'playing'
  21312. event depending on current state.
  21313. (WebCore::HTMLMediaElement::pause): Remove exception param, pause() before load() now just
  21314. starts loading asynchronously.
  21315. (WebCore::HTMLMediaElement::pauseInternal): Remove exception param.
  21316. (WebCore::HTMLMediaElement::setVolume): dispatchEventAsync -> scheduleEvent
  21317. (WebCore::HTMLMediaElement::setMuted): dispatchEventAsync -> scheduleEvent
  21318. (WebCore::HTMLMediaElement::togglePlayState): Remove exception param.
  21319. (WebCore::HTMLMediaElement::beginScrubbing): pause() doesn't take an exception param.
  21320. (WebCore::HTMLMediaElement::startPlaybackProgressTimer): New, starts timer that fires 4 times per
  21321. second when the movie is playing to timeupdate so we can post 'timeupdate' events.
  21322. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Timer proc.
  21323. (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Bottleneck around scheduling a 'timeupdate'
  21324. event because we both fire them them when the spec says we should and when the media engine
  21325. says that time has jumped, but we don't want to fire more than one at a given movie time. We also
  21326. use this bottleneck to keep track of the last time one was posted so we won't fire too often
  21327. during playback.
  21328. (WebCore::HTMLMediaElement::canPlay): readyState now tracks whether or not we have metadata.
  21329. (WebCore::HTMLMediaElement::havePotentialSourceChild): New, checks to see if there are a <source>
  21330. element with a 'src' attribute that we have not tried to load yet.
  21331. (WebCore::HTMLMediaElement::nextSourceChild): New, returns the url and content type of the next
  21332. <source> element that we haven't tried to load.
  21333. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Schedule 'seeked' event when seeking completes.
  21334. Set a flag when we post the 'ended' event, clear it when time changed and we aren't at the end since
  21335. some media engines call this proc more than once when playback reaches the end and stops, but we
  21336. don't want to post 'ended' more than once.
  21337. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): New, added so media engine can inform
  21338. when the movie duration changes and we can post 'durationchanged' event.
  21339. (WebCore::HTMLMediaElement::mediaPlayerRateChanged): New, added so media engine can inform when
  21340. the rate changed and we can updated our cached rate. This is useful because we only want to know
  21341. post periodic 'timeupdate' events when the movie is actually playing, and because we want to know
  21342. the actual playback rate when it differs from what we tried to set.
  21343. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): New, added so media engine can inform when
  21344. a movie's intrinsic size changes and we can inform the renderer.
  21345. (WebCore::HTMLMediaElement::potentiallyPlaying): Renamed from activelyPlaying since the spec now
  21346. uses "actively playing" for this concept. Update logic for new state names and un-comment calls
  21347. to stoppedDueToErrors() and pausedForUserInteraction() since the spec says those condiditons
  21348. are part of the answer.
  21349. (WebCore::HTMLMediaElement::endedPlayback): Update logic for new state names.
  21350. (WebCore::HTMLMediaElement::stoppedDueToErrors): New, spec says this logic should be part of
  21351. the determination of "potentially playing".
  21352. (WebCore::HTMLMediaElement::pausedForUserInteraction): New, placeholder for when (if) user
  21353. agent supports this spec concept.
  21354. (WebCore::HTMLMediaElement::updatePlayState): Stop timer used to fire periodic 'timeupdate'
  21355. events when we pauses the movie. Set the media engine rate before calling play() in case it
  21356. wasn't set up when the rate was changed.
  21357. (WebCore::HTMLMediaElement::stopPeriodicTimers): New, stop the progress event and 'timeupate'
  21358. event timers.
  21359. (WebCore::HTMLMediaElement::userCancelledLoad): New, logic pulled out of documentWillBecomeInactive
  21360. and updated for the current spec.
  21361. (WebCore::HTMLMediaElement::documentWillBecomeInactive): Moved some logic to userCancelledLoad.
  21362. (WebCore::HTMLMediaElement::documentDidBecomeActive): Update comments.
  21363. (WebCore::HTMLMediaElement::initialURL): Update for refactoring of code that determines the
  21364. initial url.
  21365. * html/HTMLMediaElement.h: Change ReadyState and NetworkState enums to match names in the spec,
  21366. update for changes in .cpp.
  21367. (WebCore::HTMLMediaElement::):
  21368. * html/HTMLMediaElement.idl: Update ready state and network state constants for spec changes.
  21369. defaultPlaybackRate, playbackRate, play(), and pause() no longer raise exceptions.
  21370. * html/HTMLSourceElement.cpp:
  21371. (WebCore::HTMLSourceElement::insertedIntoDocument): Update for network state name changes.
  21372. * html/HTMLVideoElement.cpp:
  21373. (WebCore::HTMLVideoElement::updatePosterImage): Update for ready state name changes.
  21374. * html/MediaError.h:
  21375. (WebCore::MediaError::): add MEDIA_ERR_NONE_SUPPORTED.
  21376. * html/MediaError.idl: add MEDIA_ERR_NONE_SUPPORTED.
  21377. * loader/MediaDocument.cpp:
  21378. (WebCore::MediaDocument::defaultEventHandler): play() and pause() don't take an exception.
  21379. * platform/graphics/MediaPlayer.cpp:
  21380. (WebCore::NullMediaPlayerPrivate::readyState): Update for newtork state name changes.
  21381. (WebCore::MediaPlayer::sizeChanged): New, so engine can report intrinsic size changes.
  21382. (WebCore::MediaPlayer::rateChanged): New, so engine can report rate changes.
  21383. (WebCore::MediaPlayer::durationChanged): New, so engine can report duration changes.
  21384. * platform/graphics/MediaPlayer.h: Update NetworkState and ReadyState enum names to match spec
  21385. states.
  21386. (WebCore::MediaPlayerClient::mediaPlayerDurationChanged): New.
  21387. (WebCore::MediaPlayerClient::mediaPlayerRateChanged): New.
  21388. (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): New.
  21389. (WebCore::MediaPlayer::):
  21390. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  21391. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes.
  21392. (WebCore::MediaPlayerPrivate::load): Ditto.
  21393. (WebCore::MediaPlayerPrivate::updateStates): Ditto.
  21394. (WebCore::MediaPlayerPrivate::loadingFailed): Ditto.
  21395. * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Update for network/ready state name changes.
  21396. Remove endPointTimer, it is no longer necessary. Add m_enabledTrackCount and m_duration.
  21397. (WebCore::MediaPlayerPrivate::metaDataAvailable):
  21398. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  21399. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer or m_endTime. Initialize
  21400. m_enabledTrackCount and m_duration. Update for network/ready state name changes.
  21401. (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes.
  21402. (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer.
  21403. (WebCore::MediaPlayerPrivate::pause): Ditto.
  21404. (WebCore::MediaPlayerPrivate::currentTime): No more m_endTime.
  21405. (WebCore::MediaPlayerPrivate::seek): Ditto.
  21406. (WebCore::MediaPlayerPrivate::doSeek): Ditto, plus don't call setRate(0) when the rate is
  21407. already zero.
  21408. (WebCore::MediaPlayerPrivate::setEndTime): No more m_endTime.
  21409. (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes. Return
  21410. different errors depending on what causes a failure. Watch for and report duration changes.
  21411. (WebCore::MediaPlayerPrivate::rateChanged): Report rate changes.
  21412. (WebCore::MediaPlayerPrivate::sizeChanged): Report size changes.
  21413. (WebCore::MediaPlayerPrivate::didEnd): No more endpoint timer.
  21414. (WebCore::MediaPlayerPrivate::setVisible): Update for network/ready state name changes.
  21415. (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): Don't return number of unsupported
  21416. tracks, store in m_enabledTrackCount so we can use it to help determine causes of failure.
  21417. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  21418. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes.
  21419. (WebCore::MediaPlayerPrivate::load): Ditto.
  21420. (WebCore::MediaPlayerPrivate::duration): Ditto.
  21421. (WebCore::MediaPlayerPrivate::updateStates): Ditto.
  21422. (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
  21423. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  21424. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer. Update for
  21425. network/ready state name changes.
  21426. (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes. No more
  21427. m_endPointTimer.
  21428. (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer.
  21429. (WebCore::MediaPlayerPrivate::pause): Ditto.
  21430. (WebCore::MediaPlayerPrivate::setEndTime): Ditto.
  21431. (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes.
  21432. (WebCore::MediaPlayerPrivate::didEnd): No more m_endPointTimer.
  21433. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  21434. * rendering/MediaControlElements.cpp:
  21435. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Update for network/ready state
  21436. name changes.
  21437. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
  21438. 2009-03-22 Kevin Ollivier <kevino@theolliviers.com>
  21439. wxGTK build fix. Add missing header.
  21440. * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
  21441. 2009-03-22 Simon Fraser <simon.fraser@apple.com>
  21442. Reviewed by Dan Bernstein
  21443. https://bugs.webkit.org/show_bug.cgi?id=24665
  21444. Image-map code in RenderImage could result in RenderImage::nodeAtPoint()
  21445. setting HitTestResult::innerNode(), but returning false, which violates
  21446. hit testing rules. Use a temporary HitTestResult so that we only fill in
  21447. result when we know we've hit.
  21448. * rendering/RenderImage.cpp:
  21449. (WebCore::RenderImage::nodeAtPoint):
  21450. 2009-03-22 Simon Fraser <simon.fraser@apple.com>
  21451. Reviewed by Dan Bernstein
  21452. https://bugs.webkit.org/show_bug.cgi?id=24743
  21453. Fix hit testing regression from r41840. We need to pass the temporary
  21454. HitTestResult when testing sublayers, then only copy to 'result' when
  21455. the layer is known to have been hit.
  21456. Test: fast/layers/zindex-hit-test.html
  21457. * rendering/RenderLayer.cpp:
  21458. (WebCore::RenderLayer::hitTestLayer):
  21459. 2009-03-20 Simon Fraser <simon.fraser@apple.com>
  21460. Reviewed by Darin Adler
  21461. https://bugs.webkit.org/show_bug.cgi?id=24733
  21462. Fix hit testing on video controls after full page zoom by fixing wider issue
  21463. with event->pageX(), pageY() with zooming. pageX and pageY are "fixed" to be
  21464. invariant under zooming (for JavaScript), so we keep an actual page point around
  21465. in MouseEvent::absoluteLocation() to avoid the need to factor in zooming everywhere.
  21466. * dom/MouseRelatedEvent.cpp:
  21467. (WebCore::MouseRelatedEvent::initCoordinates):
  21468. (WebCore::MouseRelatedEvent::computePageLocation):
  21469. * dom/MouseRelatedEvent.h:
  21470. (WebCore::MouseRelatedEvent::absoluteLocation):
  21471. (WebCore::MouseRelatedEvent::setAbsoluteLocation):
  21472. Member var, and getter and setter for absoluteLocation.
  21473. New method, computePageLocation(), to compute the actual page point,
  21474. and call it when creating and initting mouse-related events.
  21475. * dom/Node.cpp:
  21476. (WebCore::Node::dispatchMouseEvent):
  21477. (WebCore::Node::dispatchWheelEvent):
  21478. Keep non-adjusted pageX and pageY around, and call setAbsoluteLocation()
  21479. on the event to replace a potentially rounded point.
  21480. * html/HTMLInputElement.cpp:
  21481. (WebCore::HTMLInputElement::defaultEventHandler):
  21482. Clean up slider handling code.
  21483. * html/HTMLSelectElement.cpp:
  21484. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  21485. Add FIXME comment for use of offsetX/offsetY.
  21486. * page/ContextMenuController.cpp:
  21487. (WebCore::ContextMenuController::handleContextMenuEvent):
  21488. Use absoluteLocation() when hit testing for context menus.
  21489. * rendering/RenderFrameSet.cpp:
  21490. (WebCore::RenderFrameSet::userResize):
  21491. Use absoluteLocation() when resizing frames.
  21492. * rendering/RenderMedia.cpp:
  21493. (WebCore::RenderMedia::forwardEvent):
  21494. Use absoluteLocation() when hit testing media controls.
  21495. * rendering/RenderSlider.cpp:
  21496. (WebCore::HTMLSliderThumbElement::defaultEventHandler):
  21497. (WebCore::RenderSlider::mouseEventIsInThumb):
  21498. Use absoluteLocation() when handling slider events.
  21499. (WebCore::RenderSlider::forwardEvent):
  21500. Factor some code out of HTMLInputElement::defaultEventHandler().
  21501. * rendering/RenderTextControlSingleLine.cpp:
  21502. (WebCore::RenderTextControlSingleLine::forwardEvent):
  21503. Use absoluteLocation() when hit testing search field buttons, which fixees
  21504. bugs in the search field with zooming.
  21505. 2009-03-21 David Levin <levin@chromium.org>
  21506. Reviewed by Dimitri Glazkov.
  21507. https://bugs.webkit.org/show_bug.cgi?id=24727
  21508. Add V8XMLHttpRequest*.
  21509. * bindings/v8/V8XMLHttpRequestUtilities.cpp: Added.
  21510. * bindings/v8/V8XMLHttpRequestUtilities.h: Added.
  21511. * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Added.
  21512. * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Added.
  21513. * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Added.
  21514. 2009-03-21 David Levin <levin@chromium.org>
  21515. Reviewed by Dimitri Glazkov.
  21516. https://bugs.webkit.org/show_bug.cgi?id=24725
  21517. Add V8NodeFilter.
  21518. * bindings/v8/V8NodeFilter.cpp: Added.
  21519. * bindings/v8/V8NodeFilter.h: Added.
  21520. 2009-03-21 Dan Bernstein <mitz@apple.com>
  21521. Rubber-stamped by Kevin Decker
  21522. - remove some redundant #include statements
  21523. * bindings/js/JSDOMWindowBase.cpp:
  21524. 2009-03-20 Dan Bernstein <mitz@apple.com>
  21525. Reviewed by Mark Rowe.
  21526. - fix <rdar://problem/6574185> REGRESSION (3.2.2-TOT): hang in text drawing code
  21527. * platform/graphics/win/FontCGWin.cpp:
  21528. (WebCore::drawGDIGlyphs): Changed glyph stroking to fill and stroke each
  21529. glyph as a separate path, instead of all glyphs as a single path. This
  21530. matches what CGContextShowGlyphsWithAdvances() does, and has comparable
  21531. performance.
  21532. 2009-03-20 Dean Jackson <dino@apple.com>
  21533. Reviewed by Simon Fraser
  21534. Build fix for ENABLE(3D_RENDERING)
  21535. * rendering/RenderObject.h:
  21536. (WebCore::makeMatrixRenderable):
  21537. 2009-03-20 Dave Moore <davemoore@google.com>
  21538. Reviewed by Dimitri Glazkov.
  21539. https://bugs.webkit.org/show_bug.cgi?id=24705
  21540. A bug in the V8 bindings is preventing chromium from setting the href on the
  21541. location object...any attempt throws a security error, not just for javascript
  21542. protocol
  21543. * page/Location.idl:
  21544. 2009-03-20 Craig Schlenter <craig.schlenter@gmail.com>
  21545. Reviewed by Dimitri Glazkov.
  21546. https://bugs.webkit.org/show_bug.cgi?id=24608
  21547. Include stdio.h needed for printf on gcc 4.4.0
  21548. * platform/KURLGoogle.cpp:
  21549. 2009-03-20 Mike Belshe <mike@belshe.com>
  21550. Reviewed by Darin Fisher.
  21551. https://bugs.webkit.org/show_bug.cgi?id=24577
  21552. Don't let comments at the end of an event handler
  21553. break the event handler.
  21554. No change in behavior, so no test.
  21555. * bindings/v8/V8LazyEventListener.cpp:
  21556. (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  21557. 2009-03-20 Norbert Leser <norbert.leser@nokia.com>
  21558. Reviewed by Darin Adler.
  21559. https://bugs.webkit.org/show_bug.cgi?id=24535
  21560. Fixes missing line terminator character (;) after macro call.
  21561. It is common practice to add the trailing ";" where macros are substituted
  21562. and not where they are defined with #define.
  21563. This change is consistent with other macro declarations across webkit,
  21564. and it also solves compilation failure with symbian compilers.
  21565. No change in behavior, so no test.
  21566. * bindings/js/JSDOMWindowShell.cpp:
  21567. * bindings/js/JSEventListener.cpp:
  21568. * bindings/js/JSImageConstructor.cpp:
  21569. * bindings/js/JSInspectedObjectWrapper.cpp:
  21570. * bindings/js/JSInspectorCallbackWrapper.cpp:
  21571. * bindings/js/JSNamedNodesCollection.cpp:
  21572. * bindings/js/JSNodeFilterCondition.cpp:
  21573. * bindings/js/JSOptionConstructor.cpp:
  21574. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  21575. * bindings/js/JSRGBColor.cpp:
  21576. * bindings/js/JSWorkerContextBase.cpp:
  21577. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  21578. * bindings/js/JSXSLTProcessorConstructor.cpp:
  21579. * bindings/scripts/CodeGeneratorJS.pm:
  21580. 2009-03-20 Mike Belshe <mike@belshe.com>
  21581. Reviewed by Dimitri Glazkov and Dave Hyatt.
  21582. https://bugs.webkit.org/show_bug.cgi?id=24324
  21583. Make the minimum timer configurable for different platforms.
  21584. * page/DOMTimer.cpp:
  21585. (WebCore::DOMTimer::DOMTimer):
  21586. (WebCore::DOMTimer::fired):
  21587. * page/DOMTimer.h:
  21588. (WebCore::DOMTimer::minTimerInterval):
  21589. (WebCore::DOMTimer::setMinTimerInterval):
  21590. 2009-03-20 Dean McNamee <deanm@chromium.org>
  21591. Reviewed by Darin Adler.
  21592. https://bugs.webkit.org/show_bug.cgi?id=22834
  21593. Make sure to consistently match new/delete and fastMalloc/fastFree.
  21594. * css/CSSSelectorList.cpp:
  21595. (WebCore::CSSSelectorList::adoptSelectorVector):
  21596. (WebCore::CSSSelectorList::deleteSelectors):
  21597. 2009-03-20 Dan Bernstein <mitz@apple.com>
  21598. Reviewed by Dave Hyatt.
  21599. - fix https://bugs.webkit.org/show_bug.cgi?id=23739
  21600. <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load
  21601. * rendering/RenderBlock.cpp:
  21602. (WebCore::RenderBlock::percentHeightDescendants): Added this accessor.
  21603. * rendering/RenderBlock.h:
  21604. * rendering/RenderTableSection.cpp:
  21605. (WebCore::RenderTableSection::layoutRows): Extended the check for
  21606. children that flex to include other descendants with percent height
  21607. which is relative to the cell.
  21608. 2009-03-20 Dmitry Titov <dimich@chromium.org>
  21609. Reviewed by Alexey Proskuryakov.
  21610. https://bugs.webkit.org/show_bug.cgi?id=24706
  21611. Remove ScriptExecutionContext::encoding() since Workers do not need it.
  21612. WorkerContext::encoding() is simply removed, while Document::encoding()
  21613. made non-virtual and private. Workers use UTF-8 now except when instructed
  21614. otherwise by http header. Also updated test.
  21615. * dom/Document.h: Made encoding() non-virtual and private.
  21616. * dom/ScriptExecutionContext.h: removed encoding().
  21617. * workers/Worker.cpp:
  21618. (WebCore::Worker::Worker):
  21619. (WebCore::Worker::notifyFinished):
  21620. * workers/WorkerContext.cpp: removed encoding() implementation.
  21621. (WebCore::WorkerContext::WorkerContext):
  21622. (WebCore::WorkerContext::completeURL):
  21623. * workers/WorkerContext.h: removed encoding()
  21624. (WebCore::WorkerContext::create):
  21625. * workers/WorkerContextProxy.h:
  21626. * workers/WorkerImportScriptsClient.cpp:
  21627. (WebCore::WorkerImportScriptsClient::didReceiveData):
  21628. * workers/WorkerMessagingProxy.cpp:
  21629. (WebCore::WorkerMessagingProxy::startWorkerContext):
  21630. * workers/WorkerMessagingProxy.h:
  21631. * workers/WorkerThread.cpp:
  21632. (WebCore::WorkerThreadStartupData::create):
  21633. (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
  21634. (WebCore::WorkerThread::create):
  21635. (WebCore::WorkerThread::WorkerThread):
  21636. (WebCore::WorkerThread::workerThread):
  21637. * workers/WorkerThread.h:
  21638. In all these, removed storing encoding and 'inheriting' it from the parent.
  21639. Instead, they are all using UTF-8 now.
  21640. 2009-03-20 Timothy Hatcher <timothy@apple.com>
  21641. Change how threading exceptions are checked so they are reported
  21642. by what round they were added. That way WebKit can decided the
  21643. behavior per-round based on linked-on-or-after checks.
  21644. <rdar://problem/6626741&6648478&6635474&6674079>
  21645. Reviewed by Darin Adler.
  21646. * WebCore.base.exp: Export the new symbols.
  21647. * bindings/objc/DOMAbstractView.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
  21648. * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  21649. * platform/ThreadCheck.h:
  21650. * platform/mac/ThreadCheck.mm:
  21651. (WebCore::readThreadViolationBehaviorFromUserDefaults): Refactor how the default is read.
  21652. (WebCore::setDefaultThreadViolationBehavior): Take a round argument.
  21653. (WebCore::reportThreadViolation): Ditto.
  21654. (WebCoreReportThreadViolation): Ditto.
  21655. 2009-03-20 Geoffrey Garen <ggaren@apple.com>
  21656. Reviewed by Sam Weinig.
  21657. Fixed up an out-of-date comment.
  21658. * bindings/js/JSDOMWindowCustom.h:
  21659. (WebCore::JSDOMWindow::customPut):
  21660. 2009-03-20 Beth Dakin <bdakin@apple.com>
  21661. Reviewed by Dave Hyatt.
  21662. Fix for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
  21663. (r35318): A press release at pfizer.com does not display correctly
  21664. - and corresponding -
  21665. <rdar://problem/6680073>
  21666. * rendering/RenderObject.cpp:
  21667. (WebCore::RenderObject::invalidateContainerPrefWidths):
  21668. * rendering/RenderObject.h:
  21669. (WebCore::RenderObject::markContainingBlocksForLayout):
  21670. 2009-03-20 Eric Seidel <eric@webkit.org>
  21671. Reviewed by Justin Garcia.
  21672. maxDeepOffset is confusing and should be removed
  21673. https://bugs.webkit.org/show_bug.cgi?id=24586
  21674. Abstract some hard-to-read (but shared) logic into a new renderedAsNonInlineTableOrHR function.
  21675. Add first/lastDeepEditingPositionForNode Position creation functions
  21676. and deploy them to places we used to call maxDeepOffset.
  21677. Rename Position::atStart and atEnd to atStartOfTree atEndOfTree
  21678. Add a new Position::atFirst/atLastEditingPositionForNode() and use these
  21679. to replace a few more callers for maxDeepOffset()
  21680. Rename maxDeepOffset to lastEditingOffsetForNode (so that we mere mortals have some clue what it does)
  21681. "Editing positions" are confusing because they have one
  21682. of two behaviors, depending on if the container node is ignored
  21683. by editing (if editingIgnoresContent(node) returns true) or not.
  21684. Positions referring to nodes ignored by editing are
  21685. neighbor-relative (they are before or after the node) where as
  21686. positions reffering to other nodes are container-relative
  21687. (they are between two child nodes of the container, identified
  21688. by the offset() member). I will be fixing this confusion in
  21689. future patches. These renames hopefully make the current behavior clearer.
  21690. * dom/Position.cpp:
  21691. (WebCore::Position::previous):
  21692. (WebCore::Position::next):
  21693. (WebCore::Position::atFirstEditingPositionForNode):
  21694. (WebCore::Position::atLastEditingPositionForNode):
  21695. (WebCore::Position::atStartOfTree):
  21696. (WebCore::Position::atEndOfTree):
  21697. (WebCore::Position::previousCharacterPosition):
  21698. (WebCore::Position::nextCharacterPosition):
  21699. (WebCore::Position::upstream):
  21700. (WebCore::Position::isCandidate):
  21701. (WebCore::firstDeepEditingPositionForNode):
  21702. (WebCore::lastDeepEditingPositionForNode):
  21703. * dom/Position.h:
  21704. * dom/PositionIterator.cpp:
  21705. (WebCore::PositionIterator::operator Position):
  21706. (WebCore::PositionIterator::increment):
  21707. (WebCore::PositionIterator::decrement):
  21708. (WebCore::PositionIterator::atEnd):
  21709. (WebCore::PositionIterator::atEndOfNode):
  21710. * editing/CompositeEditCommand.cpp:
  21711. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  21712. * editing/DeleteSelectionCommand.cpp:
  21713. (WebCore::isTableCellEmpty):
  21714. (WebCore::DeleteSelectionCommand::removeNode):
  21715. (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  21716. * editing/Editor.cpp:
  21717. (WebCore::Editor::advanceToNextMisspelling):
  21718. * editing/InsertLineBreakCommand.cpp:
  21719. (WebCore::InsertLineBreakCommand::doApply):
  21720. * editing/InsertListCommand.cpp:
  21721. (WebCore::InsertListCommand::doApply):
  21722. * editing/ReplaceSelectionCommand.cpp:
  21723. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
  21724. * editing/TypingCommand.cpp:
  21725. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  21726. * editing/VisiblePosition.cpp:
  21727. (WebCore::VisiblePosition::previous):
  21728. (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
  21729. (WebCore::VisiblePosition::left):
  21730. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
  21731. (WebCore::VisiblePosition::right):
  21732. * editing/VisibleSelection.cpp:
  21733. (WebCore::VisibleSelection::selectionFromContentsOfNode):
  21734. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  21735. * editing/htmlediting.cpp:
  21736. (WebCore::nextVisuallyDistinctCandidate):
  21737. (WebCore::previousVisuallyDistinctCandidate):
  21738. (WebCore::firstEditablePositionAfterPositionInRoot):
  21739. (WebCore::lastEditablePositionBeforePositionInRoot):
  21740. (WebCore::lastOffsetForEditing):
  21741. (WebCore::isFirstPositionAfterTable):
  21742. (WebCore::isLastPositionBeforeTable):
  21743. (WebCore::positionBeforeNode):
  21744. (WebCore::positionAfterNode):
  21745. (WebCore::enclosingEmptyListItem):
  21746. (WebCore::caretMaxOffset):
  21747. * editing/htmlediting.h:
  21748. * editing/visible_units.cpp:
  21749. (WebCore::renderedAsNonInlineTableOrHR):
  21750. (WebCore::startOfParagraph):
  21751. (WebCore::endOfParagraph):
  21752. (WebCore::startOfEditableContent):
  21753. (WebCore::endOfEditableContent):
  21754. * page/AccessibilityObject.cpp:
  21755. (WebCore::endOfStyleRange):
  21756. * page/AccessibilityRenderObject.cpp:
  21757. (WebCore::AccessibilityRenderObject::visiblePositionRange):
  21758. * rendering/RenderBox.cpp:
  21759. (WebCore::RenderBox::positionForPoint):
  21760. 2009-03-20 Dmitry Titov <dimich@chromium.org>
  21761. Reviewed by Dimitri Glazkov.
  21762. https://bugs.webkit.org/show_bug.cgi?id=24689
  21763. Add (upstream) V8 bindings for Workers. Mostly style cleaning.
  21764. * bindings/v8/WorkerContextExecutionProxy.cpp: Added.
  21765. * bindings/v8/WorkerContextExecutionProxy.h: Added.
  21766. * bindings/v8/WorkerScriptController.cpp: Added.
  21767. * bindings/v8/WorkerScriptController.h: Added.
  21768. * bindings/v8/V8Index.h: Added. This is just a wrapper for v8_index.h, like V8Proxy.h
  21769. * bindings/v8/V8Proxy.h: Added domObjectMap() function that wraps GetDOMObjectMap().
  21770. * bindings/v8/V8WorkerContextEventListener.cpp:
  21771. (WebCore::V8WorkerContextEventListener::callListenerFunction): TrackEvent() renamed trackEvent()
  21772. 2009-03-20 Stephen White <senorblanco@chromium.org>
  21773. Reviewed by Eric Seidel.
  21774. Fix for LayoutTests/fast/canvas/canvas-text-alignment.html
  21775. on chromium/skia. The problem was that the gradient matrix
  21776. for text was being applied twice. Fixed by reverting some of
  21777. https://bugs.webkit.org/show_bug.cgi?id=23957, so that skiaDrawText
  21778. is no longer responsible for measuring the text and scaling up
  21779. the gradient matrix. Instead, the text bounding box is passed
  21780. in from SVGPaintServerGradient. I didn't make this change for CG,
  21781. since it uses a different method (the gradient is drawn using the
  21782. text as a pre-rendered mask).
  21783. https://bugs.webkit.org/show_bug.cgi?id=24687
  21784. * platform/graphics/skia/SkiaFontWin.cpp:
  21785. (WebCore::skiaDrawText):
  21786. * svg/graphics/SVGPaintServerGradient.cpp:
  21787. (WebCore::SVGPaintServerGradient::setup):
  21788. 2009-03-20 Xan Lopez <xlopez@igalia.com>
  21789. Rubber-stamped by Holger Freyther.
  21790. There seems to be some rounding error in cairo (or in how we use
  21791. cairo) with some fonts, like DejaVu Sans Mono, which makes cairo
  21792. report a height smaller than ascent + descent, which is wrong and
  21793. confuses WebCore's layout system. Workaround this while we figure
  21794. out what's going on.
  21795. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  21796. (WebCore::SimpleFontData::platformInit):
  21797. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  21798. (WebCore::SimpleFontData::platformInit):
  21799. 2009-03-19 Alexey Proskuryakov <ap@webkit.org>
  21800. Reviewed by Darin Adler.
  21801. https://bugs.webkit.org/show_bug.cgi?id=24122
  21802. <rdar://problem/6674179>
  21803. REGRESSION: DOM Range extractContents/deleteContents failures seen on Moxiecode tests
  21804. Test: fast/dom/Range/deleted-range-endpoints.html
  21805. * dom/Range.cpp: (WebCore::Range::processContents): Set the final range in accordance
  21806. to the specification.
  21807. 2009-03-19 Anders Carlsson <andersca@apple.com>
  21808. Reviewed by Dan Bernstein.
  21809. <rdar://problem/6682554> Flash content not being rendered (Shockwave Flash 10.0 r22)
  21810. If calling updateWidget for some reason resulted in another widget being added to m_widgetUpdateSet, then
  21811. that object would never be updated.
  21812. * page/FrameView.cpp:
  21813. (WebCore::FrameView::updateWidgets):
  21814. Factor the widget updating code out into this method. Return true if the update set is empty.
  21815. (WebCore::FrameView::performPostLayoutTasks):
  21816. Loop over the update set multiple times until all widgets have been updated or until we reach the cap.
  21817. * page/FrameView.h:
  21818. 2009-03-18 Timothy Hatcher <timothy@apple.com>
  21819. Make the defered data loading timer honor the Page's scheduled runloop pairs.
  21820. Introduces a new RunLoopTimer class that has an API mimicking Timer but
  21821. allows it to be scheduled with one or more SchedulePairs.
  21822. <rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers
  21823. Reviewed by Darin Adler.
  21824. * WebCore.xcodeproj/project.pbxproj: Adds the new RunLoopTimer.{cpp,h} files.
  21825. * loader/MainResourceLoader.cpp:
  21826. (WebCore::MainResourceLoader::handleDataLoadNow): Use the MainResourceLoaderTimer typedef.
  21827. (WebCore::MainResourceLoader::startDataLoadTimer): Added. Start the timer and on
  21828. Mac platforms also schedule with the Page's SchedulePairs.
  21829. (WebCore::MainResourceLoader::handleDataLoadSoon): Call startDataLoadTimer().
  21830. (WebCore::MainResourceLoader::setDefersLoading): Ditto.
  21831. * loader/MainResourceLoader.h:
  21832. * platform/cf/RunLoopTimerCF.cpp: Added.
  21833. (WebCore::RunLoopTimerBase::~RunLoopTimerBase):
  21834. (WebCore::timerFired):
  21835. (WebCore::RunLoopTimerBase::start):
  21836. (WebCore::RunLoopTimerBase::schedule):
  21837. (WebCore::RunLoopTimerBase::stop):
  21838. (WebCore::RunLoopTimerBase::isActive):
  21839. * platform/RunLoopTimer.h: Added.
  21840. (WebCore::RunLoopTimerBase::RunLoopTimerBase):
  21841. (WebCore::RunLoopTimerBase::startRepeating):
  21842. (WebCore::RunLoopTimerBase::startOneShot):
  21843. (WebCore::RunLoopTimer::RunLoopTimer):
  21844. (WebCore::RunLoopTimer::fired):
  21845. 2009-03-19 Dimitri Glazkov <dglazkov@chromium.org>
  21846. Reviewed by Darin Fisher.
  21847. https://bugs.webkit.org/show_bug.cgi?id=24702
  21848. Upstream miscellaneous bindings changes.
  21849. * bindings/v8/ScheduledAction.cpp:
  21850. (WebCore::ScheduledAction::execute): Changed to call lower-case evaluate.
  21851. * bindings/v8/ScriptCallStack.h: Added an extra include.
  21852. 2009-03-19 Simon Fraser <simon.fraser@apple.com>
  21853. Reviewed by Dave Hyatt
  21854. https://bugs.webkit.org/show_bug.cgi?id=24686
  21855. When hit testing a RenderLayer whose parent lives in a preserves-3D hierarchy,
  21856. we need to compare the computed z-offset with the depth-test z-offset before
  21857. deciding that such a RenderLayer was hit. This fixes an issue, tested by the
  21858. 3d-point-mapping-overlapping.html test, where the child of a transformed element
  21859. is found by hit testing, even when some other element with greater Z overlaps
  21860. them both.
  21861. Improved the code by adding a utility method, isHitCandidate(), which computes and tests
  21862. z-depth when necessary.
  21863. Tests: transforms/3d/point-mapping/3d-point-mapping-coplanar.html
  21864. transforms/3d/point-mapping/3d-point-mapping-overlapping.html
  21865. * rendering/RenderLayer.cpp:
  21866. (WebCore::isHitCandidate):
  21867. (WebCore::RenderLayer::hitTestLayer):
  21868. 2009-03-19 Jeremy Moskovich <jeremy@chromium.org>
  21869. Reviewed by Dimitri Glazkov.
  21870. https://bugs.webkit.org/show_bug.cgi?id=24456
  21871. Split ColorChromium.cpp into Mac & Windows variants.
  21872. Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
  21873. ultimately need to take a different approach. For now, createCGColor()
  21874. is copied from ColorMac.mm.
  21875. No observable change in behavior, so no test.
  21876. * platform/graphics/chromium/ColorChromium.cpp:
  21877. (WebCore::focusRingColor):
  21878. * platform/graphics/chromium/ColorChromiumMac.mm: Added.
  21879. 2009-03-19 Pavel Feldman <pfeldman@chromium.org>
  21880. Reviewed by Dimitri Glazkov.
  21881. https://bugs.webkit.org/show_bug.cgi?id=24675
  21882. Unforking frontend: add custom InspectorController methods
  21883. implementation.
  21884. * bindings/v8/custom/V8InspectorControllerCustom.cpp: Added.
  21885. 2009-03-19 Jay Campan <jcampan@google.com>
  21886. Reviewed by Dimitri Glazkov.
  21887. https://bugs.webkit.org/show_bug.cgi?id=24625
  21888. Adding an accessor to the currently selected index in the PopupMenuChromium.
  21889. This is required for implementing the deletion of an autocomplete entry in Chromium.
  21890. * platform/chromium/PopupMenuChromium.cpp:
  21891. (WebCore::PopupContainer::selectedIndex):
  21892. * platform/chromium/PopupMenuChromium.h:
  21893. 2009-03-19 Evan Stade <estade@chromium.org>
  21894. Reviewed by Dimitri Glazkov.
  21895. https://bugs.webkit.org/show_bug.cgi?id=24526
  21896. Improve windows skia text stroking.
  21897. Test: LayoutTests/svg/custom/struct-use-09-b.svg
  21898. * platform/graphics/skia/SkiaFontWin.cpp: Close the path representing
  21899. each font glyph polygon, rather than only closing the path once per
  21900. letter. This fixes stroking for letters with multiple polygons, such
  21901. as 'A' or 'D'.
  21902. (WebCore::getPathForGlyph):
  21903. (WebCore::skiaDrawText):
  21904. 2009-03-19 Simon Hausmann <simon.hausmann@nokia.com>
  21905. Reviewed by Tor Arne Vestbø.
  21906. Fixed support for doing calls from JavaScript into NPAPI Plugins for the Qt port on Windows.
  21907. Removed dead code for distinguishing between Widget and PluginView in the Qt port.
  21908. * bindings/js/ScriptControllerQt.cpp:
  21909. (WebCore::ScriptController::createScriptInstanceForWidget): Removed incorrect isNPAPI check.
  21910. * plugins/PluginView.cpp:
  21911. (WebCore::PluginView::PluginView): Removed m_isNPAPIPlugin variable.
  21912. * plugins/PluginView.h: Removed setter/getter.
  21913. * plugins/mac/PluginViewMac.cpp:
  21914. (WebCore::PluginView::init): Removed call to setIsNPAPIPlugin.
  21915. * plugins/qt/PluginViewQt.cpp:
  21916. (WebCore::PluginView::init): Ditto.
  21917. 2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  21918. Reviewed by Oliver Hunt.
  21919. Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
  21920. <https://bugs.webkit.org/show_bug.cgi?id=24596>
  21921. <rdar://problem/6686493>
  21922. JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
  21923. JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
  21924. set twice, once to the value that is illegal to access, and then to undefined
  21925. This causes an assertion failure in property access caching code.
  21926. The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().
  21927. * bindings/js/JSDOMWindowCustom.h:
  21928. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  21929. 2009-03-18 Alexey Proskuryakov <ap@webkit.org>
  21930. Reviewed by Sam Weinig.
  21931. https://bugs.webkit.org/show_bug.cgi?id=24676
  21932. Simple cross-origin requests shouldn't dispatch upload progress events
  21933. Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html
  21934. * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment
  21935. explaining the somewhat unexpected behavior of this function.
  21936. * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
  21937. * xml/XMLHttpRequestUpload.h:
  21938. Report whether there are any event listeners registered.
  21939. * xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.
  21940. * xml/XMLHttpRequest.cpp:
  21941. (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag.
  21942. (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto.
  21943. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto.
  21944. (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be
  21945. non-empty for POST requests.
  21946. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag.
  21947. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto.
  21948. (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed.
  21949. (WebCore::XMLHttpRequest::networkError): Ditto.
  21950. (WebCore::XMLHttpRequest::abortError): Ditto.
  21951. (WebCore::XMLHttpRequest::didSendData): Ditto.
  21952. 2009-03-18 Marc-Antoine Ruel <maruel@chromium.org>
  21953. Reviewed by Darin Fisher.
  21954. https://bugs.webkit.org/show_bug.cgi?id=24398
  21955. Fix a crash when loading a svg file in Chromium's test_shell and
  21956. then reloading the page.
  21957. * history/BackForwardListChromium.cpp:
  21958. (WebCore::BackForwardList::BackForwardList):
  21959. (WebCore::BackForwardList::close):
  21960. 2009-03-18 Eric Carlson <eric.carlson@apple.com>
  21961. Reviewed by Simon Fraser.
  21962. Fix for <rdar://problem/6685235>
  21963. <video> element poster cannot be set dynamically if not originally set up in HTML
  21964. Allocate the media engine immediately so the plug-in proxy is available for
  21965. scripting right away.
  21966. * platform/graphics/MediaPlayer.cpp:
  21967. (WebCore::MediaPlayer::MediaPlayer):
  21968. 2009-03-18 Beth Dakin <bdakin@apple.com>
  21969. Reviewed by Dave Hyatt.
  21970. Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
  21971. Popup menu appears at the wrong location on page at http://
  21972. www.signonsandiego.com/
  21973. This was a regression from http://trac.webkit.org/changeset/40769,
  21974. which changed the base class of RenderInline to
  21975. RenderBoxModelObject rather than RenderBox.
  21976. * rendering/RenderObject.cpp:
  21977. (WebCore::RenderObject::offsetParent): offsetParent should return a
  21978. RenderBoxModelObject rather than just a RenderBox, which is more
  21979. restrictive.
  21980. 2009-03-18 Anders Carlsson <andersca@apple.com>
  21981. Reviewed by Darin Adler.
  21982. <rdar://problem/6504776>
  21983. CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...
  21984. Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.
  21985. * loader/NetscapePlugInStreamLoader.cpp:
  21986. (WebCore::NetscapePlugInStreamLoader::didCancel):
  21987. 2009-03-18 David Levin <levin@chromium.org>
  21988. Reviewed by Dimitri Glazkov.
  21989. https://bugs.webkit.org/show_bug.cgi?id=24664
  21990. Upstreaming v8 collection.h
  21991. No change in behavior, so no test.
  21992. * bindings/v8/V8Collection.h: Added.
  21993. 2009-03-18 Sam Weinig <sam@webkit.org>
  21994. Reviewed by Simon Fraser.
  21995. Fix for https://bugs.webkit.org/show_bug.cgi?id=23966
  21996. REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
  21997. <rdar://problem/6589657>
  21998. Match the CSSOM spec for getClientRects and getBoundingClientRect by
  21999. returning a 0x0 rect at the correct top/left position for empty inline
  22000. boxes.
  22001. * rendering/RenderInline.cpp:
  22002. (WebCore::RenderInline::absoluteRects):
  22003. (WebCore::RenderInline::absoluteQuads):
  22004. 2009-03-18 David Levin <levin@chromium.org>
  22005. Reviewed by Eric Seidel.
  22006. Match the changes done for windows in the bug
  22007. https://bugs.webkit.org/show_bug.cgi?id=24530.
  22008. No change in behavior, so no test.
  22009. * rendering/RenderThemeChromiumLinux.cpp:
  22010. (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
  22011. 2009-03-18 Dirk Schulze <krit@webkit.org>
  22012. Reviewed by Holger Freyther.
  22013. Added support for SVG's stroked texts to Qt.
  22014. [Qt] SVGs stroked text support missing
  22015. https://bugs.webkit.org/show_bug.cgi?id=24262
  22016. * platform/graphics/qt/FontQt.cpp:
  22017. (WebCore::Font::drawComplexText):
  22018. 2009-03-18 Mark Rowe <mrowe@apple.com>
  22019. Reviewed by Alexey Proskuryakov.
  22020. Fix fast/encoding/char-decoding.html with recent ICU.
  22021. * platform/text/TextCodecICU.cpp:
  22022. (WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
  22023. as newer versions of ICU use GB18030 as the canonical name.
  22024. 2009-03-17 David Levin <levin@chromium.org>
  22025. Reviewed by Dimitri Glazkov.
  22026. https://bugs.webkit.org/show_bug.cgi?id=24662
  22027. Chromium build fixes.
  22028. Bug https://bugs.webkit.org/show_bug.cgi?id=24663 tracks
  22029. the invalid implementation of ScriptCallStack.
  22030. No change in behavior, so no test.
  22031. * bindings/v8/ScriptCallStack.h:
  22032. (WebCore::ScriptCallStack::state):
  22033. * platform/graphics/skia/PlatformContextSkia.cpp:
  22034. (PlatformContextSkia::drawRect):
  22035. 2009-03-17 David Carson <dacarson@apple.com>
  22036. Reviewed by David Hyatt.
  22037. Add anchor elements to the simple style sheet so that applications that
  22038. are using WebKit just for simple text and links will also take advantage
  22039. of the fast path.
  22040. * css/CSSStyleSelector.cpp:
  22041. (WebCore::elementCanUseSimpleDefaultStyle):
  22042. 2009-03-17 Darin Adler <darin@apple.com>
  22043. Reviewed by Adele Peterson.
  22044. <rdar://problem/6687005> Need support for new move-left/right selectors.
  22045. * editing/EditorCommand.cpp:
  22046. (WebCore::executeMoveToLeftEndOfLine): Added.
  22047. (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added.
  22048. (WebCore::executeMoveToRightEndOfLine): Added.
  22049. (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added.
  22050. Added command entries for the functions above.
  22051. 2009-03-17 Ojan Vafai <ojan@chromium.org>
  22052. Reviewed by Adele Peterson.
  22053. Put the padding inside scrollbars on textareas.
  22054. https://bugs.webkit.org/show_bug.cgi?id=24370
  22055. Put the padding inside the scrollbars on textareas. This is done by moving the
  22056. overflow from the shadowNode to the RenderTextControlMultiline. As a result,
  22057. all of the scroll handing methods that RenderTextControl overrides can be moved
  22058. down into RenderTextControlSingleLine since RenderTextControlMultiline can now
  22059. just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
  22060. no longer need a custom layout method since the shadowNode can now just size
  22061. like a regular DIV.
  22062. * css/CSSStyleSelector.cpp:
  22063. (WebCore::CSSStyleSelector::adjustRenderStyle):
  22064. * rendering/RenderTextControl.cpp:
  22065. (WebCore::RenderTextControl::styleDidChange):
  22066. (WebCore::RenderTextControl::selection):
  22067. (WebCore::RenderTextControl::calcHeight):
  22068. (WebCore::RenderTextControl::hitInnerTextElement):
  22069. * rendering/RenderTextControl.h:
  22070. * rendering/RenderTextControlMultiLine.cpp:
  22071. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  22072. (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  22073. * rendering/RenderTextControlMultiLine.h:
  22074. * rendering/RenderTextControlSingleLine.cpp:
  22075. (WebCore::RenderTextControlSingleLine::styleDidChange):
  22076. (WebCore::RenderTextControlSingleLine::autoscroll):
  22077. (WebCore::RenderTextControlSingleLine::scrollWidth):
  22078. (WebCore::RenderTextControlSingleLine::scrollHeight):
  22079. (WebCore::RenderTextControlSingleLine::scrollLeft):
  22080. (WebCore::RenderTextControlSingleLine::scrollTop):
  22081. (WebCore::RenderTextControlSingleLine::setScrollLeft):
  22082. (WebCore::RenderTextControlSingleLine::setScrollTop):
  22083. (WebCore::RenderTextControlSingleLine::scroll):
  22084. * rendering/RenderTextControlSingleLine.h:
  22085. * rendering/TextControlInnerElements.cpp:
  22086. (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
  22087. (WebCore::RenderTextControlInnerBlock::positionForPoint):
  22088. (WebCore::TextControlInnerTextElement::createRenderer):
  22089. 2009-03-17 Darin Adler <darin@apple.com>
  22090. Reviewed by David Hyatt.
  22091. Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
  22092. https://bugs.webkit.org/show_bug.cgi?id=24517
  22093. * editing/DeleteButtonController.cpp:
  22094. (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since
  22095. determining whether to display the delete button involves style and updateRendering
  22096. also updates style (should probably be named updateStyle, in fact). Not needed to fix
  22097. this bug, but would have prevented the crash that led to this bug in the first place.
  22098. * editing/EditCommand.cpp:
  22099. (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have
  22100. delete button controllers.
  22101. * editing/Editor.cpp:
  22102. (WebCore::Editor::rangeForPoint): Ditto.
  22103. * editing/markup.cpp:
  22104. (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup
  22105. doesn't depend on renderers at all when the convertBlocksToInlines boolean is false.
  22106. This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the
  22107. createMarkup function that's called by innerHTML.
  22108. (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member
  22109. function. Added a feature where the accumulator will skip a node. Moved arguments
  22110. that don't change during recursion into an object. This function still is a bit
  22111. inefficient, since it creates a new HashMap at every level as it recurses, but for now
  22112. I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly
  22113. for consistency and clarity.
  22114. (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets.
  22115. Instead of calling disable/enable on the delete button controller's container element,
  22116. pass it in to the markup accumulator as a node to skip.
  22117. 2009-03-17 Scott Violet <sky@google.com>
  22118. Reviewed by Eric Seidel.
  22119. https://bugs.webkit.org/show_bug.cgi?id=24651
  22120. Skia does not always render text fill/stroke pattern/gradient/color correctly
  22121. Changes Skia's font rendering to only render gradient/pattern if current
  22122. color space indicates the gradient/pattern should be used.
  22123. This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .
  22124. * platform/graphics/GraphicsContext.cpp:
  22125. (WebCore::GraphicsContext::strokeColorSpace):
  22126. (WebCore::GraphicsContext::fillColorSpace):
  22127. * platform/graphics/GraphicsContext.h:
  22128. (WebCore::):
  22129. * platform/graphics/GraphicsContextPrivate.h:
  22130. * platform/graphics/skia/SkiaFontWin.cpp:
  22131. (WebCore::paintSkiaText):
  22132. 2009-03-17 Adele Peterson <adele@apple.com>
  22133. Reviewed by Darin Adler.
  22134. Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
  22135. <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
  22136. Test: editing/inserting/6633727.html
  22137. This changes does a few things:
  22138. 1) Renames pos to insertionPosition.
  22139. 2) Eliminates "startNode". It doesn't work well to consider the node separately from the insertionPosition.
  22140. The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
  22141. 3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
  22142. representation of the insertionPosition, so all ancestor nodes are correctly included.
  22143. * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  22144. 2009-03-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  22145. Reviewed by Kevin Ollivier.
  22146. https://bugs.webkit.org/show_bug.cgi?id=24115
  22147. Introduce platform independent stubs for plugins.
  22148. * plugins/PluginDataNone.cpp: Copied from WebCore/plugins/wx/PluginDataWx.cpp.
  22149. * plugins/PluginPackageNone.cpp: Copied from WebCore/plugins/wx/PluginPackageWx.cpp.
  22150. * plugins/PluginViewNone.cpp: Copied from WebCore/plugins/wx/PluginViewWx.cpp.
  22151. * plugins/wx/PluginDataWx.cpp: Removed.
  22152. * plugins/wx/PluginPackageWx.cpp: Removed.
  22153. * plugins/wx/PluginViewWx.cpp: Removed.
  22154. * webcore-wx.bkl:
  22155. 2009-03-17 Darin Adler <darin@apple.com>
  22156. Earlier version reviewed by Adele Peterson.
  22157. Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
  22158. or push an <input type=button> or <button> causes the page to scroll down.
  22159. Would be best to add a regression test for Windows eventually; tested that this has
  22160. no effect on the Mac OS X platform.
  22161. * html/HTMLInputElement.cpp:
  22162. (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting.
  22163. Use the code that calls the base class's defaultEventHandler early only in the cases
  22164. where it's needed: keydown and keypress events in text fields. In other cases, do the
  22165. more typical thing and call the default handler only at the end of the function.
  22166. This function already had code to make sure the keypress event for space never gets
  22167. through, but it was running too late since the scrolling code was moved into the
  22168. base class default event handler.
  22169. 2009-03-17 Simon Fraser <simon.fraser@apple.com>
  22170. Reviewed by Dave Hyatt
  22171. https://bugs.webkit.org/show_bug.cgi?id=24632
  22172. Fix repaint issues when composited layers come and go (only applies
  22173. when ACCELERATED_COMPOSITING is turned on).
  22174. * rendering/RenderLayer.cpp:
  22175. (WebCore::RenderLayer::RenderLayer):
  22176. * rendering/RenderLayer.h:
  22177. (WebCore::RenderLayer::mustOverlayCompositedLayers):
  22178. (WebCore::RenderLayer::setMustOverlayCompositedLayers):
  22179. * rendering/RenderLayerBacking.cpp:
  22180. (WebCore::RenderLayerBacking::RenderLayerBacking):
  22181. * rendering/RenderLayerBacking.h:
  22182. Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
  22183. to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
  22184. when setting this flag.
  22185. * rendering/RenderLayerCompositor.cpp:
  22186. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  22187. When a RenderLayer flips into or out of compositing mode, compute a repaint
  22188. rect relative to the containerForRepaint, and repaint it.
  22189. (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  22190. Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().
  22191. (WebCore::RenderLayerCompositor::needsToBeComposited):
  22192. (WebCore::RenderLayerCompositor::requiresCompositingLayer):
  22193. (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
  22194. (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
  22195. * rendering/RenderLayerCompositor.h:
  22196. Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
  22197. and make it a class static method to match requiresCompositingForAnimation(). Both
  22198. now take RenderObjects, rathern than RenderLayers.
  22199. * rendering/style/RenderStyle.h:
  22200. (WebCore::InheritedFlags::hasTransformRelatedProperty):
  22201. Minor tidyup using convenience methods added in an earlier commit.
  22202. 2009-03-17 Simon Fraser <simon.fraser@apple.com>
  22203. Reviewed by Darin Adler
  22204. https://bugs.webkit.org/show_bug.cgi?id=24396
  22205. * config.h:
  22206. Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some
  22207. comments to make the #ifdefs more readable.
  22208. * css/CSSComputedStyleDeclaration.cpp:
  22209. (WebCore::computedTransform):
  22210. Add a comment to mention that we don't flatten the matrix.
  22211. * css/MediaQueryEvaluator.cpp:
  22212. (WebCore::transform_3dMediaFeatureEval):
  22213. Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering
  22214. is supported.
  22215. * platform/graphics/mac/GraphicsLayerCA.mm:
  22216. (WebCore::GraphicsLayerCA::animateTransform):
  22217. No need for the #ifdef here. If we don't support 3d, we will have already flattened
  22218. the matrix.
  22219. * platform/graphics/transforms/TransformationMatrix.cpp:
  22220. (WebCore::TransformationMatrix::makeAffine):
  22221. * platform/graphics/transforms/TransformationMatrix.h:
  22222. New method to convert the matrix to an affine matrix by throwing a way the non-affine
  22223. parts.
  22224. * rendering/RenderLayer.cpp:
  22225. (WebCore::RenderLayer::updateTransform):
  22226. (WebCore::RenderLayer::currentTransform):
  22227. * rendering/RenderLayerBacking.cpp:
  22228. (WebCore::RenderLayerBacking::updateLayerTransform):
  22229. If 3d rendering is not supported, convert the matrix to an affine matrix
  22230. which can be rendered, and used for hit testing.
  22231. * rendering/RenderLayerCompositor.cpp:
  22232. Change the name of the exported symbol that webkitdirs.pm uses to know if
  22233. 3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff.
  22234. * rendering/RenderObject.cpp:
  22235. (WebCore::RenderObject::transformFromContainer):
  22236. Only take perspective into account if 3d rendering is supported.
  22237. * rendering/RenderObject.h:
  22238. (WebCore::makeMatrixRenderable):
  22239. Utility method that flattens a matrix if 3d rendering is not supported.
  22240. 2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
  22241. wx build fix. Fix typo after mouse wheel changes.
  22242. * platform/wx/MouseWheelEventWx.cpp:
  22243. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  22244. 2009-03-17 Darin Adler <darin@apple.com>
  22245. * inspector/ConsoleMessage.cpp:
  22246. (WebCore::ConsoleMessage::isEqual): Fix build, remove stray parenthesis.
  22247. 2009-03-17 Darin Adler <darin@apple.com>
  22248. Fix crash seen right away when running run-webkit-tests.
  22249. * inspector/ConsoleMessage.cpp:
  22250. (WebCore::ConsoleMessage::isEqual): Restore assertion to its behavior pre-refactoring.
  22251. Also tweaked formatting a bit.
  22252. 2009-03-17 Alexey Proskuryakov <ap@webkit.org>
  22253. Reviewed by Darin Adler.
  22254. HTMLSelectElement::add() doesn't look at exception code returned from insertBefore(), so
  22255. it doesn't need to zero it out before calling.
  22256. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): Removed "ec = 0" line.
  22257. 2009-03-17 Dan Bernstein <mitz@apple.com>
  22258. Reviewed by Adam Roben.
  22259. - WebCore part of adding a mechanism for controlling the caching of
  22260. responses through WebFrameLoaderClient
  22261. Mac already has such a mechanism, and this adds one for CFNetwork ports.
  22262. * WebCore.vcproj/WebCore.vcproj: Added EmptyClients.h
  22263. and ResourceLoaderCFNet.cpp.
  22264. * loader/EmptyClients.h:
  22265. (WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Added an
  22266. implementation that always returns true.
  22267. * loader/FrameLoaderClient.h: Declared shouldCacheResponse().
  22268. * loader/ResourceLoader.h: Ditto.
  22269. * loader/cf/ResourceLoaderCFNet.cpp: Added.
  22270. (WebCore::ResourceLoader::shouldCacheResponse): Added. Calls through to
  22271. FrameLoaderClient::shouldCacheResponse().
  22272. * platform/network/ResourceHandleClient.h:
  22273. (WebCore::ResourceHandleClient::shouldCacheResponse): Added an
  22274. implementation that always returns true.
  22275. * platform/network/cf/ResourceHandleCFNet.cpp:
  22276. (WebCore::willCacheResponse): Added a call to
  22277. ResourceHandleClient::shouldCacheResponse(). If the client returns
  22278. false, return 0, which will prevent CFNetwork from caching the response.
  22279. 2009-03-17 Alexey Proskuryakov <ap@webkit.org>
  22280. Reviewed by Darin Adler.
  22281. https://bugs.webkit.org/show_bug.cgi?id=13287
  22282. Cannot change SELECT to a dynamically created option
  22283. Tests: fast/forms/add-and-remove-option.html
  22284. fast/forms/add-remove-option-modification-event.html
  22285. fast/forms/add-selected-option.html
  22286. fast/forms/select-cache-desynchronization.html
  22287. * dom/ContainerNode.cpp:
  22288. (WebCore::dispatchChildInsertionEvents): Increment DOM tree version. This will happen when
  22289. dispatching DOMSubtreeModified again, but the version should be incremented for event
  22290. listeners to have an up to date view of the DOM.
  22291. (WebCore::dispatchChildRemovalEvents): Ditto.
  22292. * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoTree):
  22293. Make sure that the select element knows about its new selected option.
  22294. * html/HTMLOptionElement.h: Use insertedIntoTree() instead of insertedIntoDocument(),
  22295. because DOM also needs to be updated for forms that are not in document yet. Similar
  22296. problems exist for node removing, but removedFromTree() is called at a wrong time, so
  22297. those problems cannot be fixed without deeper refactoring.
  22298. * html/HTMLSelectElement.cpp:
  22299. (WebCore::HTMLSelectElement::setRecalcListItems): Reset m_activeSelectionAnchorIndex - it
  22300. doesn't make sense to keep the anchor after programmatically changing the selection, and
  22301. keeping it was causing a failure in fast/forms/listbox-selection.html.
  22302. * html/HTMLSelectElement.h: Removed overrides for ContainerNode methods that only called
  22303. base class versions.
  22304. 2009-03-17 Steve Falkenburg <sfalken@apple.com>
  22305. <rdar://problem/6690324> Accessing FTP sites reads unallocated memory, can result in garbled entries or crashes
  22306. Reviewed by Darin Adler.
  22307. * loader/FTPDirectoryDocument.cpp:
  22308. (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Assign CString to a local while we hold pointers into it.
  22309. 2009-03-16 David Hyatt <hyatt@apple.com>
  22310. <rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/
  22311. Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
  22312. layers that don't paint themselves. This is done by adding a new enclosingSelfPaintingLayer method
  22313. so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
  22314. themselves.
  22315. Reviewed by Darin Adler.
  22316. Added fast/block/float/overlapping-floats-with-overflow-hidden.html
  22317. * WebCore.base.exp:
  22318. * rendering/RenderBlock.cpp:
  22319. (WebCore::RenderBlock::addOverhangingFloats):
  22320. * rendering/RenderObject.cpp:
  22321. (WebCore::RenderObject::enclosingSelfPaintingLayer):
  22322. * rendering/RenderObject.h:
  22323. 2009-03-17 Xan Lopez <xlopez@igalia.com>
  22324. Reviewed by Holger Freyther.
  22325. https://bugs.webkit.org/show_bug.cgi?id=24592
  22326. [GTK] Crash in FcPatternHash
  22327. Style fixes.
  22328. * platform/graphics/gtk/FontPlatformDataGtk.cpp:
  22329. (WebCore::FontPlatformData::operator=):
  22330. * platform/graphics/gtk/FontPlatformDataPango.cpp:
  22331. 2009-03-17 Xan Lopez <xlopez@igalia.com>
  22332. Reviewed by Holger Freyther.
  22333. https://bugs.webkit.org/show_bug.cgi?id=24592
  22334. [GTK] Crash in FcPatternHash
  22335. Sanitize memory management in pango fonts.
  22336. Release memory allocated by FontPlatformDataPango in its own
  22337. destructor instead of doing it from other classes, and add copy
  22338. constructor and '=' operator to be able to track referenced
  22339. objects properly.
  22340. * platform/graphics/gtk/FontPlatformDataPango.cpp:
  22341. (WebCore::FontPlatformData::~FontPlatformData):
  22342. (WebCore::FontPlatformData::operator=):
  22343. (WebCore::FontPlatformData::FontPlatformData):
  22344. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  22345. 2009-03-17 Darin Adler <darin@apple.com>
  22346. Reviewed by Alexey Proskuryakov.
  22347. Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
  22348. seen with inspector, which uses adoptNode
  22349. https://bugs.webkit.org/show_bug.cgi?id=24624
  22350. rdar://problem/6422850
  22351. Test: fast/dom/HTMLImageElement/image-load-cross-document.html
  22352. * dom/Document.cpp:
  22353. (WebCore::Document::Document): Removed m_imageLoadEventTimer.
  22354. (WebCore::Document::detach): Removed m_imageLoadEventDispatchSoonList and
  22355. m_imageLoadEventDispatchingList.
  22356. (WebCore::Document::implicitClose): Called ImageLoader::dispatchPendingLoadEvents
  22357. instead of dispatchImageLoadEventsNow.
  22358. * dom/Document.h: Removed ImageLoader, dispatchImageLoadEventSoon,
  22359. dispatchImageLoadEventsNow, removeImage, m_imageLoadEventDispatchSoonList,
  22360. m_imageLoadEventDispatchingList, m_imageLoadEventTimer, and imageLoadEventTimerFired.
  22361. * loader/ImageLoader.cpp:
  22362. (WebCore::loadEventSender): Added. Returns the single global ImageLoadEventSender
  22363. object used privately as the target of the load event timer.
  22364. (WebCore::ImageLoader::~ImageLoader): Call ImageLoadEventSender::cancelLoadEvent
  22365. rather than Document::removeImage.
  22366. (WebCore::ImageLoader::setImage): Use m_element directly, not element().
  22367. (WebCore::ImageLoader::updateFromElement): Ditto. Also name the local variable
  22368. document instead of doc.
  22369. (WebCore::ImageLoader::notifyFinished): Call ImageLoadEventSender::dispatchLoadEventSoon
  22370. rather than Document::dispatchImageLoadEventSoon.
  22371. (WebCore::ImageLoader::dispatchPendingLoadEvent): Added. Handles the common logic
  22372. about when load events can be dispatched so that dispatchLoadEvent only has to
  22373. have the specific part for each derived class. This includes a check that the
  22374. document is attached, which used to be handled by having documents empty out the
  22375. image load event vectors in the detach function.
  22376. (WebCore::ImageLoader::dispatchPendingLoadEvents): Added. Calls the appropriate
  22377. function on the ImageLoadEventSender, which avoids the need to have that class be
  22378. public in the ImageLoader header.
  22379. (WebCore::ImageLoadEventSender::ImageLoadEventSender): Added. Has the code that
  22380. was previously in the Document constructor.
  22381. (WebCore::ImageLoadEventSender::dispatchLoadEventSoon): Added. Has the code that
  22382. was previously in Document::dispatchImageLoadEventSoon.
  22383. (WebCore::ImageLoadEventSender::cancelLoadEvent): Added. Has the code that was
  22384. previously in Document::removeImage.
  22385. (WebCore::ImageLoadEventSender::dispatchPendingLoadEvents): Added. Has the code
  22386. that was previously in Document::dispatchImageLoadEventsNow.
  22387. (WebCore::ImageLoadEventSender::timerFired): Added. Calls dispatchPendingLoadEvents.
  22388. * loader/ImageLoader.h: Improved comments. Made the virtual functions private
  22389. or protected rather than public. Added static dispatchPendingLoadEvents function
  22390. for use by Document and private dispatchPendingLoadEvent function for use by
  22391. ImageLoadEventSender. Made setLoadingImage private and eliminated
  22392. setHaveFiredLoadEvent since that can all be done inside the class without any
  22393. member functions.
  22394. * html/HTMLImageLoader.cpp:
  22395. (WebCore::HTMLImageLoader::dispatchLoadEvent): Removed logic to check whether a
  22396. load event already fired and whether image() is 0. These are now both base class
  22397. responsibilities.
  22398. * svg/SVGImageLoader.cpp:
  22399. (WebCore::SVGImageLoader::dispatchLoadEvent): Ditto.
  22400. * wml/WMLImageLoader.cpp:
  22401. (WebCore::WMLImageLoader::dispatchLoadEvent): Ditto.
  22402. 2009-03-17 Dimitri Glazkov <dglazkov@chromium.org>
  22403. Reviewed by Timothy Hatcher.
  22404. https://bugs.webkit.org/show_bug.cgi?id=24623
  22405. Refactor ConsoleMessage to use ScriptFuncitonCall and eliminate JSC
  22406. dependencies.
  22407. * bindings/js/ScriptFunctionCall.cpp:
  22408. (WebCore::ScriptFunctionCall::appendArgument): Added uint and ScriptString-taking methods.
  22409. * bindings/js/ScriptFunctionCall.h:
  22410. * bindings/js/ScriptObjectQuarantine.cpp:
  22411. (WebCore::quarantineValue): Added generic ScriptValue quarantine helper.
  22412. * bindings/js/ScriptObjectQuarantine.h:
  22413. * bindings/js/ScriptValue.cpp:
  22414. (WebCore::ScriptValue::isEqual): Added.
  22415. * bindings/js/ScriptValue.h:
  22416. * inspector/ConsoleMessage.cpp:
  22417. (WebCore::ConsoleMessage::ConsoleMessage):
  22418. (WebCore::ConsoleMessage::addToConsole): Added.
  22419. (WebCore::ConsoleMessage::isEqual): Changed to use ScriptValue::isEqual.
  22420. * inspector/ConsoleMessage.h:
  22421. (WebCore::ConsoleMessage::incrementCount): Added.
  22422. * inspector/InspectorController.cpp:
  22423. (WebCore::InspectorController::addConsoleMessage): Changed to use ConsoleMessage::addToConsole.
  22424. (WebCore::InspectorController::populateScriptObjects): Ditto.
  22425. * inspector/InspectorController.h:
  22426. 2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
  22427. Reviewed by Mark Rowe.
  22428. Get BUILDING_ON_* defines from Platform.h.
  22429. https://bugs.webkit.org/show_bug.cgi?id=24630
  22430. * WebCorePrefix.h:
  22431. 2009-03-16 Xan Lopez <xlopez@igalia.com>
  22432. Reviewed by Holger Freyther.
  22433. https://bugs.webkit.org/show_bug.cgi?id=24592
  22434. [GTK] Crash in FcPatternHash
  22435. Sanitize memory management in gtk fonts.
  22436. Release memory allocated by FontPlatformDataGtk in its own
  22437. destructor instead of doing it from other classes, and add copy
  22438. constructor and '=' operator to be able to track referenced
  22439. objects properly.
  22440. * platform/graphics/gtk/FontPlatformData.h:
  22441. * platform/graphics/gtk/FontPlatformDataGtk.cpp:
  22442. (WebCore::FontPlatformData::operator=):
  22443. (WebCore::FontPlatformData::FontPlatformData):
  22444. (WebCore::FontPlatformData::~FontPlatformData):
  22445. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  22446. (WebCore::SimpleFontData::platformDestroy):
  22447. 2009-03-17 Ariya Hidayat <ariya.hidayat@nokia.com>
  22448. Build fix for Qt < 4.5.
  22449. As reported by Yael Aharon <yael.aharon@nokia.com>
  22450. * platform/graphics/qt/GraphicsContextQt.cpp:
  22451. (WebCore::GraphicsContext::drawLine):
  22452. 2009-03-17 Alexey Proskuryakov <ap@webkit.org>
  22453. Reviewed by Sam Weinig.
  22454. https://bugs.webkit.org/show_bug.cgi?id=24614
  22455. Access control checks are different in cached and uncached cases
  22456. Test: http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html
  22457. * loader/CrossOriginAccessControl.cpp:
  22458. (WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Factored out simple method
  22459. check for use in both cached and uncached cases. In cached case, an old definition that
  22460. omitted HEAD was still used.
  22461. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Check that content type has an
  22462. allowed value. This is needed in all call sites. Also changed to compare MIME type, not
  22463. content type.
  22464. (WebCore::isSimpleCrossOriginAccessRequest): Use the above methods.
  22465. * loader/CrossOriginAccessControl.h: Expose isOnAccessControlSimpleRequestMethodWhitelist.
  22466. * loader/CrossOriginPreflightResultCache.cpp:
  22467. (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
  22468. (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
  22469. Use the new checks for simple method and header.
  22470. 2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
  22471. Reviewed by Mark Rowe.
  22472. https://bugs.webkit.org/show_bug.cgi?id=24638
  22473. [GTK] HTML5 media tags do not work
  22474. Add a repaint-requested signal to the video sink, and use it to
  22475. call MediaPlayerPrivate::repaint, so that the video actually
  22476. plays.
  22477. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  22478. (WebCore::mediaPlayerPrivateRepaintCallback):
  22479. (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  22480. * platform/graphics/gtk/VideoSinkGStreamer.cpp:
  22481. (webkit_video_sink_idle_func):
  22482. (webkit_video_sink_render):
  22483. (webkit_video_sink_class_init):
  22484. 2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
  22485. Reviewed by Holger Freyther.
  22486. https://bugs.webkit.org/show_bug.cgi?id=24638
  22487. [GTK] HTML5 media tags do not work
  22488. Work-around the fact that gst_element_query_duration returns true even
  22489. though it is unable to figure out the duration when in stream (push)
  22490. mode.
  22491. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  22492. (WebCore::MediaPlayerPrivate::duration):
  22493. 2009-03-16 Darin Adler <darin@apple.com>
  22494. Reviewed by Kevin Decker.
  22495. <rdar://problem/6642742> Top Sites malfunction when switching text zoom mode
  22496. * page/Frame.cpp:
  22497. (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is
  22498. currently showing a non-HTML view.
  22499. 2009-03-16 Darin Adler <darin@apple.com>
  22500. Reviewed by Adele Peterson.
  22501. Bug 24629: moving forward or backward a paragraph fails at edge of document
  22502. https://bugs.webkit.org/show_bug.cgi?id=24629
  22503. rdar://problem/6544413
  22504. Test: editing/selection/move-paragraph-document-edges.html
  22505. * editing/visible_units.cpp:
  22506. (WebCore::previousParagraphPosition): Use the last result from
  22507. previousLinePosition rather than going all the way back to what was originally
  22508. passed in when we hit exception cases like null or not moving. This correctly
  22509. inherits the behavior of previousLinePosition when we are in a paragraph at the
  22510. edge of a document.
  22511. (WebCore::nextParagraphPosition): Ditto.
  22512. 2009-03-16 Darin Adler <darin@apple.com>
  22513. Reviewed by Adele Peterson.
  22514. Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
  22515. https://bugs.webkit.org/show_bug.cgi?id=24619
  22516. * rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
  22517. * rendering/RenderView.h: Ditto.
  22518. 2009-03-16 Peter Kasting <pkasting@google.com>
  22519. Reviewed by David Hyatt.
  22520. https://bugs.webkit.org/show_bug.cgi?id=24368
  22521. DOM scroll events should be based off the actual number of wheel
  22522. ticks, not off the number of lines scrolled. This matches IE.
  22523. * dom/Node.cpp:
  22524. (WebCore::Node::dispatchWheelEvent):
  22525. * dom/WheelEvent.cpp:
  22526. (WebCore::WheelEvent::WheelEvent):
  22527. * dom/WheelEvent.h:
  22528. (WebCore::WheelEvent::create):
  22529. * platform/PlatformWheelEvent.h:
  22530. (WebCore::PlatformWheelEvent::wheelTicksX):
  22531. (WebCore::PlatformWheelEvent::wheelTicksY):
  22532. * platform/gtk/WheelEventGtk.cpp:
  22533. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  22534. * platform/mac/WheelEventMac.mm:
  22535. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  22536. * platform/qt/WheelEventQt.cpp:
  22537. * platform/win/WheelEventWin.cpp:
  22538. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  22539. * platform/wx/MouseWheelEventWx.cpp:
  22540. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  22541. 2009-03-16 Simon Fraser <simon.fraser@apple.com>
  22542. Reviewed by Eric Seidel
  22543. Clean up a few issues in the Animation code:
  22544. * page/animation/AnimationBase.cpp:
  22545. (WebCore::AnimationBase::updateStateMachine):
  22546. Whitespace
  22547. (WebCore::AnimationBase::willNeedService):
  22548. Don't round to float, use std::max
  22549. * page/animation/AnimationController.cpp:
  22550. (WebCore::AnimationControllerPrivate::startTimeResponse):
  22551. Fix erroneously copied line to null out m_lastResponseWaiter.
  22552. 2009-03-12 David Hyatt <hyatt@apple.com>
  22553. Reviewed by Eric Seidel
  22554. https://bugs.webkit.org/show_bug.cgi?id=13632
  22555. Overflow scrolling needs to account for the bottom/right padding on the object itself as well
  22556. as for bottom/right margins on children.
  22557. Existing tests cover this.
  22558. * rendering/RenderBlock.cpp:
  22559. (WebCore::RenderBlock::lowestPosition):
  22560. (WebCore::RenderBlock::rightmostPosition):
  22561. 2009-03-16 Sam Weinig <sam@webkit.org>
  22562. Reviewed by Anders Carlsson.
  22563. Fix for <rdar://problem/6320555>
  22564. Add an upper limit for setting HTMLSelectElement.length.
  22565. Test: fast/forms/select-max-length.html
  22566. * html/HTMLSelectElement.cpp:
  22567. (WebCore::HTMLSelectElement::setOption):
  22568. (WebCore::HTMLSelectElement::setLength):
  22569. 2009-03-16 Eric Carlson <eric.carlson@apple.com>
  22570. Reviewed by Simon Fraser.
  22571. <rdar://problem/6686721> Media document crash in 64-bit WebKit
  22572. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  22573. (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when
  22574. rendering inline with old versions of QuickTime, so don't look for it when we are in a
  22575. media document.
  22576. 2009-03-16 Dimitri Glazkov <dglazkov@chromium.org>
  22577. Reviewed by Timothy Hatcher.
  22578. https://bugs.webkit.org/show_bug.cgi?id=24590
  22579. Refactor InspectorDOMStorageResource to use ScriptFunctionCall.
  22580. * bindings/js/ScriptFunctionCall.cpp:
  22581. (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
  22582. * bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
  22583. * bindings/js/ScriptObjectQuarantine.cpp:
  22584. (WebCore::getQuarantinedScriptObject): Added Storage helper.
  22585. * bindings/js/ScriptObjectQuarantine.h: Ditto.
  22586. * inspector/InspectorController.cpp:
  22587. (WebCore::InspectorController::populateScriptObjects): Changed to use bind method.
  22588. (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method.
  22589. (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
  22590. * inspector/InspectorController.h: Removed add/remove methods for DOM storage.
  22591. * inspector/InspectorDOMStorageResource.cpp:
  22592. (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
  22593. (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added.
  22594. (WebCore::InspectorDOMStorageResource::bind): Added.
  22595. (WebCore::InspectorDOMStorageResource::unbind): Added.
  22596. * inspector/InspectorDOMStorageResource.h:
  22597. 2009-03-16 Mike Belshe <mike@belse.com>
  22598. Reviewed by Dimitri Glazkov.
  22599. https://bugs.webkit.org/show_bug.cgi?id=24580
  22600. Fix query() to match KURL behavior, this time with the code that
  22601. compiles.
  22602. * platform/KURLGoogle.cpp:
  22603. (WebCore::KURL::query): Fix copy/paste mistake.
  22604. 2009-03-16 Alexey Proskuryakov <ap@webkit.org>
  22605. Reviewed by Darin Adler.
  22606. https://bugs.webkit.org/show_bug.cgi?id=21752
  22607. REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it
  22608. Test: fast/dom/Window/window-early-properties-xhr.html
  22609. For some transitions, the Window object is not replaced, but Document is. When this happened,
  22610. window.document property was updated, but references to Document kept in cached constructors
  22611. were not.
  22612. * bindings/js/JSAudioConstructor.cpp:
  22613. (WebCore::JSAudioConstructor::JSAudioConstructor):
  22614. (WebCore::JSAudioConstructor::document):
  22615. (WebCore::JSAudioConstructor::mark):
  22616. * bindings/js/JSAudioConstructor.h:
  22617. * bindings/js/JSImageConstructor.cpp:
  22618. (WebCore::JSImageConstructor::JSImageConstructor):
  22619. (WebCore::JSImageConstructor::document):
  22620. (WebCore::JSImageConstructor::mark):
  22621. * bindings/js/JSImageConstructor.h:
  22622. * bindings/js/JSMessageChannelConstructor.cpp:
  22623. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  22624. (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
  22625. (WebCore::JSMessageChannelConstructor::mark):
  22626. * bindings/js/JSMessageChannelConstructor.h:
  22627. * bindings/js/JSOptionConstructor.cpp:
  22628. (WebCore::JSOptionConstructor::JSOptionConstructor):
  22629. (WebCore::JSOptionConstructor::document):
  22630. (WebCore::JSOptionConstructor::mark):
  22631. * bindings/js/JSOptionConstructor.h:
  22632. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  22633. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  22634. (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
  22635. (WebCore::JSXMLHttpRequestConstructor::mark):
  22636. * bindings/js/JSXMLHttpRequestConstructor.h:
  22637. Changed cached constructors to keep a reference to Window, not Document.
  22638. 2009-03-15 Alexey Proskuryakov <ap@webkit.org>
  22639. Reviewed by Darin Adler.
  22640. https://bugs.webkit.org/show_bug.cgi?id=24549
  22641. Impose a limit on Access-Control-Max-Age value
  22642. * loader/CrossOriginPreflightResultCache.cpp:
  22643. (WebCore::CrossOriginPreflightResultCacheItem::parse):
  22644. 2009-03-15 Greg Bolsinga <bolsinga@apple.com>
  22645. Reviewed by David Kilzer.
  22646. <rdar://problem/6668875> Normalize Geolocation results
  22647. * platform/mac/GeolocationServiceMac.mm:
  22648. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
  22649. 2009-03-15 Greg Bolsinga <bolsinga@apple.com>
  22650. Reviewed by David Kilzer.
  22651. Update ::toString format as suggested by Darin Adler.
  22652. * page/Geoposition.cpp:
  22653. (WebCore::Geoposition::toString):
  22654. 2009-03-15 David Kilzer <ddkilzer@apple.com>
  22655. <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
  22656. Reviewed by Darin Adler.
  22657. Yet another case where we would trigger extended encoding loading needlessly.
  22658. * platform/text/TextEncoding.cpp:
  22659. (WebCore::TextEncoding::encodingForFormSubmission):
  22660. 2009-03-15 Simon Fraser <simon.fraser@apple.com>
  22661. Build fix: no review.
  22662. * rendering/style/ContentData.h:
  22663. 2009-03-15 David Kilzer <ddkilzer@apple.com>
  22664. Bug 24542: Improve ContentData encapsulation
  22665. <https://bugs.webkit.org/show_bug.cgi?id=24542>
  22666. Reviewed by Simon Fraser.
  22667. No tests since there is no change in behavior.
  22668. * rendering/RenderObject.cpp:
  22669. (WebCore::RenderObject::createObject): Used getter methods
  22670. instead of data members on ContentData class. Used isImage()
  22671. convenience method.
  22672. * rendering/RenderObjectChildList.cpp:
  22673. (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
  22674. * rendering/style/ContentData.cpp:
  22675. (WebCore::ContentData::clear): Extracted code into
  22676. deleteContent() method.
  22677. (WebCore::ContentData::dataEquivalent): Added. Extracted code
  22678. from StyleRareNonInheritedData::contentDataEquivalent().
  22679. (WebCore::ContentData::deleteContent): Added. Used by setter
  22680. methods.
  22681. * rendering/style/ContentData.h: Made m_type, m_content and
  22682. m_next private.
  22683. (WebCore::ContentData::isCounter): Added.
  22684. (WebCore::ContentData::isImage): Added.
  22685. (WebCore::ContentData::isNone): Added.
  22686. (WebCore::ContentData::isText): Added.
  22687. (WebCore::ContentData::type): Added.
  22688. (WebCore::ContentData::dataEquivalent): Added.
  22689. (WebCore::ContentData::image): Added.
  22690. (WebCore::ContentData::setImage): Added.
  22691. (WebCore::ContentData::text): Added.
  22692. (WebCore::ContentData::setText): Added.
  22693. (WebCore::ContentData::counter): Added.
  22694. (WebCore::ContentData::setCounter): Added.
  22695. (WebCore::ContentData::next): Added.
  22696. (WebCore::ContentData::setNext): Added.
  22697. * rendering/style/CounterContent.h:
  22698. (WebCore::operator!=): Removed.
  22699. (WebCore::operator==): Renamed operator!=() and reversed its
  22700. logic after extracting code from
  22701. StyleRareNonInheritedData::contentDataEquivalent() to create
  22702. ContentData::dataEquivalent().
  22703. * rendering/style/RenderStyle.cpp:
  22704. (WebCore::RenderStyle::setContent): Used new getters and setters
  22705. on ContentData class. Changed first argument from a StringImpl*
  22706. to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
  22707. * rendering/style/RenderStyle.h:
  22708. (WebCore::RenderStyle::setContent): Updated declaration.
  22709. * rendering/style/StyleRareNonInheritedData.cpp:
  22710. (WebCore::StyleRareNonInheritedData::contentDataEquivalent):
  22711. Extracted most logic in while() loop into
  22712. ContentData::dataEquivalent().
  22713. 2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
  22714. Reviewed by Anders Carlsson.
  22715. https://bugs.webkit.org/show_bug.cgi?id=24602
  22716. [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
  22717. Reintroduce the URI into the soup message after having set it in
  22718. the KURL, on redirects, to make sure it is properly encoded. This
  22719. fixes bad request problems when servers give bad URIs on their
  22720. response's Location header.
  22721. * platform/network/soup/ResourceHandleSoup.cpp:
  22722. (WebCore::restartedCallback):
  22723. 2009-03-15 Alexey Proskuryakov <ap@webkit.org>
  22724. Reviewed by Darin Adler.
  22725. https://bugs.webkit.org/show_bug.cgi?id=19737
  22726. No cursor and paste not enabled right clicking text field/area
  22727. Test: fast/events/right-click-focus.html
  22728. * page/EventHandler.cpp:
  22729. (WebCore::EventHandler::handleMousePressEventSingleClick):
  22730. (WebCore::EventHandler::handleMousePressEvent):
  22731. Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
  22732. 2009-03-15 Alexey Proskuryakov <ap@webkit.org>
  22733. Reviewed by Adele Peterson.
  22734. https://bugs.webkit.org/show_bug.cgi?id=23949
  22735. HTMLSelectElement is in inconsistent state when handling mutation events
  22736. Test: fast/forms/mutation-event-recalc.html
  22737. * dom/ContainerNode.cpp:
  22738. (WebCore::ContainerNode::insertBefore):
  22739. (WebCore::ContainerNode::appendChild):
  22740. Call childrenChanged() before dispatching modification events, not after.
  22741. * html/HTMLOptGroupElement.cpp:
  22742. (WebCore::HTMLOptGroupElement::insertBefore):
  22743. (WebCore::HTMLOptGroupElement::replaceChild):
  22744. (WebCore::HTMLOptGroupElement::removeChild):
  22745. (WebCore::HTMLOptGroupElement::appendChild):
  22746. (WebCore::HTMLOptGroupElement::removeChildren):
  22747. * html/HTMLSelectElement.cpp:
  22748. (WebCore::HTMLSelectElement::add):
  22749. (WebCore::HTMLSelectElement::remove):
  22750. (WebCore::HTMLSelectElement::insertBefore):
  22751. (WebCore::HTMLSelectElement::replaceChild):
  22752. (WebCore::HTMLSelectElement::removeChild):
  22753. (WebCore::HTMLSelectElement::appendChild):
  22754. (WebCore::HTMLSelectElement::removeChildren):
  22755. Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events
  22756. were already dispatched.
  22757. 2009-03-14 Greg Bolsinga <bolsinga@apple.com>
  22758. <rdar://problem/6683465>
  22759. Geolocation has to be able to handle NULL Frames.
  22760. Reviewed by Mark Rowe
  22761. 2009-03-14 Greg Bolsinga <bolsinga@apple.com>
  22762. Reviewed by David Kilzer.
  22763. Geoposition::toString was missing the Coordinates after the update.
  22764. * page/Geoposition.cpp:
  22765. (WebCore::Geoposition::toString):
  22766. 2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
  22767. Reviewed by Mark Rowe.
  22768. [Gtk] Build fix - pass a Coordinate to Geoposition::create
  22769. https://bugs.webkit.org/show_bug.cgi?id=24603
  22770. Gtk build fix per r41650
  22771. https://bugs.webkit.org/show_bug.cgi?id=24506
  22772. Geolocation in Safari differs from the spec, no Coordinates attribute on Position
  22773. Pass a Coordinate to Geoposition::create.
  22774. * platform/gtk/GeolocationServiceGtk.cpp:
  22775. (WebCore::GeolocationServiceGtk::updatePosition):
  22776. 2009-03-14 Alexey Proskuryakov <ap@webkit.org>
  22777. Reviewed by Darin Adler.
  22778. https://bugs.webkit.org/show_bug.cgi?id=24545
  22779. Make cross-site XHR simple request definition match current spec draft
  22780. Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html
  22781. http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html
  22782. * loader/CrossOriginAccessControl.cpp:
  22783. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language.
  22784. (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those
  22785. that could be sent via form submission.
  22786. 2009-03-14 Alexey Proskuryakov <ap@webkit.org>
  22787. Reviewed by Darin Adler.
  22788. https://bugs.webkit.org/show_bug.cgi?id=15172
  22789. object fallback - empty string for first argument of setAttributeNS does not work like null
  22790. https://bugs.webkit.org/show_bug.cgi?id=24548
  22791. createElementNS("", name) should create an element in null namespace
  22792. Tests: fast/dom/createElementNS-empty-namespace.html
  22793. fast/dom/setAttributeNS-empty-namespace.html
  22794. * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
  22795. Convert empty namespaces to null.
  22796. 2009-03-13 Mark Rowe <mrowe@apple.com>
  22797. Rubber-stamped by Dan Bernstein.
  22798. Take advantage of the ability of recent versions of Xcode to easily switch the active
  22799. architecture.
  22800. * Configurations/DebugRelease.xcconfig:
  22801. 2009-03-13 John Abd-El-Malek <jam@google.com>
  22802. Reviewed by Darin Fisher.
  22803. https://bugs.webkit.org/show_bug.cgi?id=24593
  22804. Added requestorID so we can track the request to its WebView without using frame (which was removed).
  22805. * platform/network/chromium/ResourceRequest.h:
  22806. (WebCore::ResourceRequest::ResourceRequest):
  22807. (WebCore::ResourceRequest::requestorID):
  22808. (WebCore::ResourceRequest::setRequestorID):
  22809. (WebCore::ResourceRequest::setTargetType):
  22810. (WebCore::ResourceRequest::policyURL):
  22811. (WebCore::ResourceRequest::setPolicyURL):
  22812. (WebCore::ResourceRequest::requestorPid):
  22813. (WebCore::ResourceRequest::setRequestorPid):
  22814. 2009-03-13 Mike Belshe <mike@belshe.com>
  22815. Reviewed by Dimitri Glazkov.
  22816. https://bugs.webkit.org/show_bug.cgi?id=24561
  22817. Add custom V8 bindings for HTMLElementCanvas, Location.
  22818. * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
  22819. * bindings/v8/custom/V8LocationCustom.cpp: Added.
  22820. 2009-03-13 Stephen White <senorblanco@chromium.org>
  22821. Reviewed by Eric Seidel.
  22822. https://bugs.webkit.org/show_bug.cgi?id=24584
  22823. Fix transparent text rendering on Chromium. FontChromiumWin
  22824. was calling beginTransparencyLayer()/endTransparencyLayer(), with
  22825. a TransparencyWin inside to do GDI ClearType rendering over an
  22826. opaque background. TransparencyWin does its special sauce
  22827. in the destructor, but it was being called too late to be used
  22828. correctly in the layer. Put the special sauce into a new function,
  22829. composite(), and call that explicitly instead.
  22830. * platform/graphics/chromium/FontChromiumWin.cpp:
  22831. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  22832. * platform/graphics/chromium/TransparencyWin.cpp:
  22833. (WebCore::TransparencyWin::~TransparencyWin):
  22834. (WebCore::TransparencyWin::composite):
  22835. (WebCore::TransparencyWin::init):
  22836. * platform/graphics/chromium/TransparencyWin.h:
  22837. * rendering/RenderThemeChromiumWin.cpp:
  22838. (WebCore::):
  22839. 2009-03-13 Mike Belshe <mike@belshe.com>
  22840. Reviewed by Dimitri Glazkov.
  22841. https://bugs.webkit.org/show_bug.cgi?id=24562
  22842. Add custom implementation for getCSSCanvasContext to V8 bindings.
  22843. * bindings/v8/custom/V8DocumentCustom.cpp: Added new method.
  22844. 2009-03-13 Mike Belshe <mike@belse.com>
  22845. Reviewed by Dimitri Glazkov.
  22846. https://bugs.webkit.org/show_bug.cgi?id=24580
  22847. Fix query() to match KURL behavior.
  22848. * platform/KURLGoogle.cpp:
  22849. (WebCore::KURL::query): remove extra logic around question mark.
  22850. 2009-03-13 Chris Fleizach <cfleizach@apple.com>
  22851. Reviewed by Beth Dakin.
  22852. Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
  22853. https://bugs.webkit.org/show_bug.cgi?id=24474
  22854. Test: platform/mac-snowleopard/accessibility/table-multi-bodies.html
  22855. * page/AccessibilityTable.cpp:
  22856. (WebCore::AccessibilityTable::cellForColumnAndRow):
  22857. 2009-03-13 Jian Li <jianli@chromium.org>
  22858. Reviewed by Dimitri Glazkov.
  22859. https://bugs.webkit.org/show_bug.cgi?id=24589
  22860. Upstream changes to V8 event listeners (Chromium r11133) in order to
  22861. fix worker functionality break in Chromium.
  22862. * bindings/v8/V8AbstractEventListener.cpp:
  22863. (WebCore::V8AbstractEventListener::invokeEventHandler):
  22864. (WebCore::V8AbstractEventListener::handleEvent):
  22865. * bindings/v8/V8AbstractEventListener.h:
  22866. * bindings/v8/V8WorkerContextEventListener.cpp:
  22867. (WebCore::V8WorkerContextEventListener::handleEvent):
  22868. 2009-03-13 Dimitri Glazkov <dglazkov@chromium.org>
  22869. Reviewed by Timothy Hatcher.
  22870. https://bugs.webkit.org/show_bug.cgi?id=24524
  22871. Introduce ScriptObject and ScriptFunctionCall abstractions.
  22872. * GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
  22873. * WebCore.pro: Ditto.
  22874. * WebCore.vcproj/WebCore.vcproj: Ditto.
  22875. * WebCore.xcodeproj/project.pbxproj: Ditto.
  22876. * WebCoreSources.bkl: Ditto.
  22877. * bindings/js/ScriptFunctionCall.cpp: Added.
  22878. * bindings/js/ScriptFunctionCall.h: Added.
  22879. * bindings/js/ScriptObject.cpp: Added.
  22880. * bindings/js/ScriptObject.h: Added.
  22881. * bindings/js/ScriptObjectQuarantine.cpp: Added.
  22882. * bindings/js/ScriptObjectQuarantine.h: Added.
  22883. * inspector/InspectorController.cpp:
  22884. (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind.
  22885. (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind.
  22886. (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
  22887. * inspector/InspectorController.h: Removed addScriptDatabaseResource and
  22888. removeScriptDatabaseResource declarations.
  22889. * inspector/InspectorDatabaseResource.cpp:
  22890. (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
  22891. (WebCore::InspectorDatabaseResource::bind): Added.
  22892. (WebCore::InspectorDatabaseResource::unbind): Added.
  22893. * inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
  22894. 2009-03-13 Peter Kasting <pkasting@google.com>
  22895. Reviewed by Eric Seidel.
  22896. https://bugs.webkit.org/show_bug.cgi?id=24467
  22897. Make Skia drawRect() and stroke behavior match CG.
  22898. This makes drawRect() ignore the stroke width (like CG does), and
  22899. adds a warning comment about that to the appropriate header.
  22900. It also eliminates some hacky code in Skia's stroke preparation,
  22901. which tried to adjust odd-width strokes to fall on pixel boundaries.
  22902. Not only did this not match CG, it wouldn't necessarily work right,
  22903. because there could be other transforms (e.g. full-page zoom) that
  22904. would affect the stroke before it reached the device pixel level.
  22905. * platform/graphics/GraphicsContext.h:
  22906. * platform/graphics/skia/GraphicsContextSkia.cpp:
  22907. (WebCore::GraphicsContext::drawRect):
  22908. (WebCore::GraphicsContext::fillRect):
  22909. * platform/graphics/skia/PlatformContextSkia.cpp:
  22910. (PlatformContextSkia::drawRect):
  22911. (PlatformContextSkia::setupPaintForStroking):
  22912. 2009-03-13 Jian Li <jianli@chromium.org>
  22913. Reviewed by Dimitri Glazkov.
  22914. https://bugs.webkit.org/show_bug.cgi?id=24583
  22915. Need to change scope of constructor and destructor of V8ObjectEventListener from private
  22916. to protected so that they could be used in its derived class V8WorkerContextEventListener.
  22917. * bindings/v8/V8ObjectEventListener.h:
  22918. 2009-03-13 David Levin <levin@chromium.org>
  22919. Reviewed by Dimitri Glazkov.
  22920. https://bugs.webkit.org/show_bug.cgi?id=24579
  22921. Many V8*Event* files are misplaced.
  22922. This code is infrastructure for supporting the bindings and thus should
  22923. be in the bindings/v8 directory.
  22924. * bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
  22925. * bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
  22926. * bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
  22927. * bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
  22928. * bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
  22929. * bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
  22930. * bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
  22931. * bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.
  22932. 2009-03-13 Adele Peterson <adele@apple.com>
  22933. Reviewed by Justin Garcia.
  22934. Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content
  22935. Test: editing/pasteboard/5089327.html
  22936. Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.
  22937. * editing/ReplaceSelectionCommand.cpp:
  22938. (WebCore::handleStyleSpansBeforeInsertion):
  22939. (WebCore::ReplaceSelectionCommand::handleStyleSpans):
  22940. 2009-03-13 Greg Bolsinga <bolsinga@apple.com>
  22941. Reviewed by Simon Fraser.
  22942. Update Geolocation perimission dialogs to be asynchronous.
  22943. https://bugs.webkit.org/show_bug.cgi?id=24505
  22944. Geolocation now requests permission from the Chrome asynchronously.
  22945. The Chrome is passed the Geolocation object, and the Chrome sets the permission
  22946. on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
  22947. of SecurityOrigins with geolocation permission. This is so that the GeolocationService
  22948. can inform the Chrome of its request, and the Chrome is also free to implement its
  22949. own policy.
  22950. * WebCore.base.exp:
  22951. * WebCore.xcodeproj/project.pbxproj:
  22952. * page/Chrome.cpp:
  22953. (WebCore::Chrome::requestGeolocationPermissionForFrame):
  22954. * page/Chrome.h:
  22955. * page/ChromeClient.h:
  22956. (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
  22957. * page/Geolocation.cpp:
  22958. (WebCore::Geolocation::Geolocation):
  22959. (WebCore::Geolocation::getCurrentPosition):
  22960. (WebCore::Geolocation::watchPosition):
  22961. (WebCore::Geolocation::setIsAllowed):
  22962. (WebCore::Geolocation::displayChallengeIfNecessary):
  22963. (WebCore::Geolocation::geolocationServicePositionChanged):
  22964. * page/Geolocation.h:
  22965. (WebCore::Geolocation::isAllowed):
  22966. (WebCore::Geolocation::setShouldClearCache):
  22967. (WebCore::Geolocation::shouldClearCache):
  22968. (WebCore::Geolocation::):
  22969. 2009-03-13 Anders Carlsson <andersca@apple.com>
  22970. Reviewed by Dan Bernstein.
  22971. <rdar://problem/6610666> Revise the Cocoa event model text API
  22972. Add a NPCocoaEventTextInput event type. Remove the text input variables.
  22973. * bridge/npapi.h:
  22974. (_NPCocoaEvent::):
  22975. 2009-03-13 Kevin Decker <kdecker@apple.com>
  22976. Reviewed by Anders.
  22977. <rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed
  22978. The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
  22979. over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
  22980. for x-oleobject.
  22981. * rendering/RenderPartObject.cpp:
  22982. (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.
  22983. 2009-03-13 Jian Li <jianli@chromium.org>
  22984. Reviewed by Dimitri Glazkov.
  22985. https://bugs.webkit.org/show_bug.cgi?id=24559
  22986. Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.
  22987. * bindings/v8/custom/V8LazyEventListener.cpp:
  22988. (WebCore::V8LazyEventListener::getListenerFunction):
  22989. (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  22990. 2009-03-13 Jian Li <jianli@chromium.org>
  22991. Reviewed by Dimitri Glazkov.
  22992. https://bugs.webkit.org/show_bug.cgi?id=24557
  22993. This is to support running multiple workers in a single worker process in chromium.
  22994. * bindings/v8/custom/V8WorkerContextEventListener.cpp:
  22995. (WebCore::V8WorkerContextEventListener::handleEvent):
  22996. Add locker to v8 event listener of worker context.
  22997. 2009-03-13 Alexey Proskuryakov <ap@webkit.org>
  22998. Reviewed by Sam Weinig.
  22999. https://bugs.webkit.org/show_bug.cgi?id=24575
  23000. XHR response is incorrect after a network error.
  23001. Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html
  23002. http/tests/xmlhttprequest/cross-site-denied-response-sync.html
  23003. http/tests/xmlhttprequest/cross-site-denied-response.html
  23004. * xml/XMLHttpRequest.cpp:
  23005. (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request.
  23006. (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note
  23007. that since internalAbort() can drop GC protection, it is not safe to use the object after
  23008. this call.
  23009. (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and
  23010. return early if it was. This can happen during sync requests, as the loader does not know
  23011. that it was aborted, and just synthesizes all callbacks.
  23012. 2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
  23013. Reviewed by Alexey Proskuryakov.
  23014. https://bugs.webkit.org/show_bug.cgi?id=3547
  23015. XMLHttpRequest.statusText returns always "OK"
  23016. Covered by existing tests (which now pass on all platforms but Mac).
  23017. * xml/XMLHttpRequest.cpp:
  23018. (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up
  23019. to each platform to correctly set the status text or set it to "OK" to retain current
  23020. behavior.
  23021. 2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
  23022. Reviewed by Alexey Proskuryakov.
  23023. https://bugs.webkit.org/show_bug.cgi?id=24349
  23024. [QT] HTTP status text is never set
  23025. Set HTTP status text to the reason phrase attribute of QNetworkReply.
  23026. * platform/network/qt/QNetworkReplyHandler.cpp:
  23027. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  23028. 2009-03-12 Simon Fraser <simon.fraser@apple.com>
  23029. Reviewed by Mark Rowe
  23030. <rdar://problem/6622300>: Reproducible crash on
  23031. <http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>
  23032. Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
  23033. deleted from under itself. The sheetLoaded() notification can allow scripts
  23034. to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
  23035. which can cause the last ref to the CSSStyleSheet to be released.
  23036. * css/CSSStyleSheet.cpp:
  23037. (WebCore::CSSStyleSheet::checkLoaded):
  23038. 2009-03-12 Kevin Ollivier <kevino@theolliviers.com>
  23039. wx build fix. Allow make-generated-sources.sh to pass args down to DerivedSources.make
  23040. * make-generated-sources.sh:
  23041. 2009-03-12 Adam Treat <adam.treat@torchmobile.com>
  23042. Reviewed by Oliver Hunt.
  23043. https://bugs.webkit.org/show_bug.cgi?id=24498
  23044. Fix the Qt port to use the same algorithm for drawing dashed and dotted
  23045. borders as the other ports. This makes the Qt port pixel-for-pixel perfect
  23046. compared to border drawing with Apple's canonical mac port and much closer
  23047. to konqueror and firefox behavior.
  23048. * platform/graphics/qt/GraphicsContextQt.cpp:
  23049. (WebCore::GraphicsContext::drawLine):
  23050. 2009-02-26 Eric Seidel <eric@webkit.org>
  23051. Reviewed by Justin Garcia.
  23052. Clean up DOMSelection to use some helper functions
  23053. making the code smaller, and less error-prone.
  23054. https://bugs.webkit.org/show_bug.cgi?id=19221
  23055. I tried moving DOMSelection off of rangeCompliantEquivalent
  23056. but failed. VisibleSelection holds positions like (table, 1) to mean
  23057. "after the table".
  23058. * page/DOMSelection.cpp:
  23059. (WebCore::DOMSelection::visibleSelection):
  23060. (WebCore::anchorPosition):
  23061. (WebCore::focusPosition):
  23062. (WebCore::basePosition):
  23063. (WebCore::extentPosition):
  23064. (WebCore::DOMSelection::anchorNode):
  23065. (WebCore::DOMSelection::anchorOffset):
  23066. (WebCore::DOMSelection::focusNode):
  23067. (WebCore::DOMSelection::focusOffset):
  23068. (WebCore::DOMSelection::baseNode):
  23069. (WebCore::DOMSelection::baseOffset):
  23070. (WebCore::DOMSelection::extentNode):
  23071. (WebCore::DOMSelection::extentOffset):
  23072. * page/DOMSelection.h:
  23073. 2009-03-12 Dmitry Titov <dimich@chromium.org>
  23074. Reviewed by Dimitri Glazkov.
  23075. https://bugs.webkit.org/show_bug.cgi?id=24563
  23076. Change ResourceRequest to be a struct rather then a class to match other declarations.
  23077. * platform/network/chromium/ResourceRequest.h:
  23078. 2009-03-12 David Levin <levin@chromium.org>
  23079. Reviewed by Darin Fisher.
  23080. Bug 24530: width100percent-searchfield.html should be fixed for chromium.
  23081. <https://bugs.webkit.org/show_bug.cgi?id=24530>
  23082. Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html
  23083. * css/themeChromiumWin.css: Added.
  23084. Overrides the changes to start supporting input[type="search"] on Windows (since
  23085. Chromium doesn't do anything special for this).
  23086. * rendering/RenderThemeChromiumWin.cpp:
  23087. (WebCore::supportsFocus):
  23088. (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
  23089. (WebCore::RenderThemeChromiumWin::determineState):
  23090. (WebCore::RenderThemeChromiumWin::getThemeData):
  23091. 2009-03-12 Greg Bolsinga <bolsinga@apple.com>
  23092. Reviewed by Antti Koivisto.
  23093. https://bugs.webkit.org/show_bug.cgi?id=24506
  23094. Geolocation in Safari differs from the spec, no Coordinates attribute on Position
  23095. Get up to date.
  23096. * DerivedSources.make:
  23097. * GNUmakefile.am:
  23098. * WebCore.pro:
  23099. * WebCore.scons:
  23100. * WebCore.vcproj/WebCore.vcproj:
  23101. * WebCore.xcodeproj/project.pbxproj:
  23102. * WebCoreSources.bkl:
  23103. * bindings/js/JSGeolocationCustom.cpp:
  23104. (WebCore::createPositionOptions):
  23105. * page/Coordinates.cpp: Added.
  23106. (WebCore::Coordinates::toString):
  23107. * page/Coordinates.h: Added.
  23108. (WebCore::Coordinates::create):
  23109. (WebCore::Coordinates::latitude):
  23110. (WebCore::Coordinates::longitude):
  23111. (WebCore::Coordinates::altitude):
  23112. (WebCore::Coordinates::accuracy):
  23113. (WebCore::Coordinates::altitudeAccuracy):
  23114. (WebCore::Coordinates::heading):
  23115. (WebCore::Coordinates::speed):
  23116. (WebCore::Coordinates::Coordinates):
  23117. * page/Coordinates.idl: Added.
  23118. * page/Geoposition.cpp:
  23119. (WebCore::Geoposition::toString):
  23120. * page/Geoposition.h:
  23121. (WebCore::Geoposition::create):
  23122. (WebCore::Geoposition::coords):
  23123. (WebCore::Geoposition::Geoposition):
  23124. * page/Geoposition.idl:
  23125. * page/PositionOptions.h:
  23126. (WebCore::PositionOptions::create):
  23127. (WebCore::PositionOptions::maximumAge):
  23128. (WebCore::PositionOptions::setMaximumAge):
  23129. (WebCore::PositionOptions::PositionOptions):
  23130. * platform/mac/GeolocationServiceMac.mm:
  23131. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
  23132. 2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
  23133. Reviewed by Darin Fisher.
  23134. https://bugs.webkit.org/show_bug.cgi?id=24496
  23135. Fix console logging of non-string values by coercing the argument to
  23136. a string, for V8 bindings.
  23137. Test: fast/js/console-non-string-values.html
  23138. * bindings/v8/ScriptValue.cpp: Added toString method.
  23139. (WebCore::ScriptValue::toString):
  23140. * bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes
  23141. and toString declaration.
  23142. 2009-03-12 Darin Fisher <darin@chromium.org>
  23143. Reviewed by Dimitri Glazkov.
  23144. Eliminate ChromiumBridge::uiResourceProtocol
  23145. https://bugs.webkit.org/show_bug.cgi?id=24558
  23146. * platform/chromium/ChromiumBridge.h:
  23147. 2009-03-12 Greg Bolsinga <bolsinga@apple.com>
  23148. Reviewed by Simon Fraser.
  23149. Missing breaks in switch statement
  23150. https://bugs.webkit.org/show_bug.cgi?id=24556
  23151. * platform/mac/GeolocationServiceMac.mm:
  23152. (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
  23153. 2009-03-12 Darin Fisher <darin@chromium.org>
  23154. Reviewed by Dimitri Glazkov.
  23155. https://bugs.webkit.org/show_bug.cgi?id=24554
  23156. Remove some unused functions from ChromiumBridge.
  23157. * platform/chromium/ChromiumBridge.h:
  23158. 2009-03-02 Eric Seidel <eric@webkit.org>
  23159. Reviewed by Darin Fisher and Justin Garcia.
  23160. Safari crashes during drag and drop in Google presentations
  23161. due to mutation event handlers removing DOM content during insertNode
  23162. https://bugs.webkit.org/show_bug.cgi?id=22634
  23163. Added a bunch of "null" checks to make sure nodes are still
  23164. in the document before we operate on them. This is an
  23165. inelegant solution, but it's the best we have for now.
  23166. Test: editing/selection/crash-on-drag-with-mutation-events.html
  23167. * editing/CompositeEditCommand.cpp:
  23168. (WebCore::CompositeEditCommand::insertNodeAt):
  23169. * editing/ReplaceSelectionCommand.cpp:
  23170. (WebCore::ReplaceSelectionCommand::doApply):
  23171. 2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
  23172. Reviewed by Adam Treat.
  23173. https://bugs.webkit.org/show_bug.cgi?id=24525
  23174. REGRESSION: Inspector window doesn't close when inspected page is
  23175. destroyed. This is a revert of r41158, which became unnecessary when
  23176. InspectorController became ref-counted in r41462.
  23177. * inspector/InspectorController.cpp:
  23178. (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage
  23179. after calling close().
  23180. (WebCore::InspectorController::stopUserInitiatedProfiling): Remove
  23181. m_inspectedPage check guard around profile logic.
  23182. 2009-03-12 Peter Kasting <pkasting@google.com>
  23183. Reviewed by Darin Fisher.
  23184. https://bugs.webkit.org/show_bug.cgi?id=24502
  23185. Make horizontal scrolling on Windows always go the correct direction.
  23186. * platform/PlatformWheelEvent.h:
  23187. * platform/win/WheelEventWin.cpp:
  23188. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  23189. 2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
  23190. Reviewed by Simon Fraser.
  23191. https://bugs.webkit.org/show_bug.cgi?id=24496
  23192. Fix console logging of non-string values by coercing the argument to
  23193. a string.
  23194. Test: fast/js/console-non-string-values.html
  23195. * bindings/js/ScriptValue.cpp: Removed PlatformString include.
  23196. * bindings/js/ScriptValue.h: Added toString method.
  23197. (WebCore::ScriptValue::toString):
  23198. * page/Console.cpp:
  23199. (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use
  23200. ScriptValue::toString.
  23201. (WebCore::Console::addMessage): added extra ScriptState argument to callsite.
  23202. (WebCore::Console::count): Ditto.
  23203. 2009-03-12 Simon Fraser <simon.fraser@apple.com>
  23204. Reviewed by Adele Peterson.
  23205. https://bugs.webkit.org/show_bug.cgi?id=24508
  23206. Fix updating of text field with placeholder text when value is set
  23207. by ensuring that updatePlaceholderVisibility() is called after
  23208. the value has been updated, not before.
  23209. Test: fast/forms/placeholder-set-value.html
  23210. * html/HTMLInputElement.cpp:
  23211. (WebCore::HTMLInputElement::setValue):
  23212. 2009-03-12 Simon Fraser <simon.fraser@apple.com>
  23213. Reviewed by Dave Hyatt
  23214. https://bugs.webkit.org/show_bug.cgi?id=24552
  23215. Hit testing involving normal flow, self-painting layers (e.g. reflections)
  23216. was broken because it was not null-testing the result of hitTestLayer(),
  23217. so bailing early with a nil hit layer.
  23218. Test: fast/layers/normal-flow-hit-test.html
  23219. * rendering/RenderLayer.cpp:
  23220. (WebCore::RenderLayer::hitTestLayer):
  23221. 2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
  23222. Reviewed by Cameron Zwarich.
  23223. Removed zero-sized files, left over from improperly applied patch.
  23224. * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
  23225. * platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.
  23226. 2009-03-12 Adam Treat <adam.treat@torchmobile.com>
  23227. Reviewed by George Staikos.
  23228. Do not ignore alpha color in optimization. Hard to believe, but there
  23229. are websites that fill the entire page with a tiled image consisting of
  23230. nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>
  23231. * platform/graphics/qt/ImageQt.cpp:
  23232. (WebCore::BitmapImage::checkForSolidColor):
  23233. 2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>
  23234. Reviewed by Darin Adler.
  23235. Bug 24110: cloneNode should call cloneElement and not the reverse
  23236. - Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren.
  23237. Now cloneNode calls one of the 2 previous methods.
  23238. - Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.
  23239. - Moved cloneNode to the Element private section so that WebCore callers cannot use it.
  23240. - Removed Element::cloneNode usage through WebCore.
  23241. * dom/Element.cpp:
  23242. (WebCore::Element::cloneNode): Moved to Element's private section and it
  23243. now calls the two next methods.
  23244. (WebCore::Element::cloneElementWithChildren): Added.
  23245. (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement
  23246. to avoid ambiguity.
  23247. * dom/Element.h:
  23248. * editing/ApplyStyleCommand.cpp:
  23249. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement
  23250. to call to cloneElementWithoutChildren.
  23251. * editing/BreakBlockquoteCommand.cpp:
  23252. (WebCore::BreakBlockquoteCommand::doApply): Ditto.
  23253. * editing/IndentOutdentCommand.cpp:
  23254. (WebCore::IndentOutdentCommand::indentRegion): Ditto.
  23255. * editing/InsertParagraphSeparatorCommand.cpp:
  23256. (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
  23257. * editing/ModifySelectionListLevel.cpp:
  23258. (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
  23259. * editing/SplitElementCommand.cpp:
  23260. (WebCore::SplitElementCommand::doApply): Ditto.
  23261. * editing/markup.cpp:
  23262. (WebCore::createFragmentFromText): Ditto.
  23263. * svg/SVGUseElement.cpp:
  23264. (WebCore::SVGUseElement::buildShadowTree): Ditto.
  23265. (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
  23266. 2009-03-12 Dirk Schulze <krit@webkit.org>
  23267. Reviewed by Oliver Hunt.
  23268. Fixed a crash on the 1x1 pixel check for background image in gtk.
  23269. We need to load the image first and need to be sure that the image
  23270. is not null before checking the type.
  23271. * platform/graphics/cairo/ImageCairo.cpp:
  23272. (WebCore::BitmapImage::checkForSolidColor):
  23273. 2009-03-12 Xan Lopez <xlopez@igalia.com>
  23274. Reviewed by Alexey Proskuryakov.
  23275. https://bugs.webkit.org/show_bug.cgi?id=24544
  23276. Rename setUrl to setURL
  23277. Use proper case for setUrl method, rename it to setURL.
  23278. * platform/network/ResourceResponseBase.cpp:
  23279. (WebCore::ResourceResponseBase::adopt):
  23280. * platform/network/ResourceResponseBase.h:
  23281. * platform/network/curl/ResourceHandleManager.cpp:
  23282. (WebCore::writeCallback):
  23283. (WebCore::headerCallback):
  23284. * platform/network/soup/ResourceHandleSoup.cpp:
  23285. (WebCore::fillResponseFromMessage):
  23286. (WebCore::queryInfoCallback):
  23287. 2009-03-12 Xan Lopez <xlopez@igalia.com>
  23288. Reviewed by Alexey Proskuryakov.
  23289. https://bugs.webkit.org/show_bug.cgi?id=24519
  23290. [GTK] Use two argument KURL ctor in ResourceHandleSoup
  23291. Use two argument KURL ctor, the single argument ctor expects its
  23292. input to be the output of a previous KURL::parse call, which is
  23293. not the case here.
  23294. * platform/network/soup/ResourceHandleSoup.cpp:
  23295. (WebCore::fillResponseFromMessage):
  23296. (WebCore::queryInfoCallback):
  23297. 2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>
  23298. Fix for <rdar://6418681>
  23299. https://bugs.webkit.org/show_bug.cgi?id=22644
  23300. Reviewed by Steve Falkenburg.
  23301. * plugins/win/PluginPackageWin.cpp:
  23302. (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA
  23303. Client plug-in to the blacklist; it requires a Mozilla-based browser.
  23304. 2009-03-12 Oliver Hunt <oliver@apple.com>
  23305. Reviewed by NOBODY (build fix).
  23306. build fix.
  23307. * html/CanvasRenderingContext2D.h:
  23308. 2009-03-11 Oliver Hunt <oliver@apple.com>
  23309. Reviewed by Adele Peterson.
  23310. <rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4
  23311. A number of dashboard widgets rely on canvas failing silently when given invalid
  23312. colors for gradient stops, but both the spec and firefox throw exceptions here.
  23313. So we work around this by creating a dashboard quirk that will only suppress the
  23314. exception in dashboard compatibility mode.
  23315. Test: fast/canvas/canvas-gradient-addStop-error.html
  23316. * html/CanvasGradient.cpp:
  23317. (WebCore::CanvasGradient::CanvasGradient):
  23318. (WebCore::CanvasGradient::addColorStop):
  23319. * html/CanvasGradient.h:
  23320. (WebCore::CanvasGradient::setDashboardCompatibilityMode):
  23321. * html/CanvasRenderingContext2D.cpp:
  23322. (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
  23323. (WebCore::CanvasRenderingContext2D::createLinearGradient):
  23324. (WebCore::CanvasRenderingContext2D::createRadialGradient):
  23325. * html/CanvasRenderingContext2D.h:
  23326. 2009-03-11 David Kilzer <ddkilzer@apple.com>
  23327. Clarify comments regarding order of FEATURE_DEFINES
  23328. Rubber-stamped by Mark Rowe.
  23329. * Configurations/WebCore.xcconfig: Added warning about the
  23330. consequences when FEATURE_DEFINES are not kept in sync.
  23331. 2009-03-11 Gustavo Noronha Silva <gns@gnome.org>
  23332. Reviewed by Holger Freyther.
  23333. https://bugs.webkit.org/show_bug.cgi?id=24515
  23334. [GTK] soup backend should use GMappedFile instead of mmap directly
  23335. Rewrite mmap code used to upload files to use GMappedFile, so that
  23336. it is platform-independent.
  23337. * platform/network/soup/ResourceHandleSoup.cpp:
  23338. (WebCore::ResourceHandle::startHttp):
  23339. 2009-03-11 Dan Bernstein <mitz@apple.com>
  23340. Reviewed by Darin Adler.
  23341. - WebCore part of fixing <rdar://problem/3919124> Thai text selection
  23342. in Safari is incorrect
  23343. Test: platform/mac/editing/selection/word-thai.html
  23344. Tested on Mac, but should work on all ICU platforms (or more precisely
  23345. on all platforms that implement
  23346. WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).
  23347. * editing/TextIterator.cpp:
  23348. (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
  23349. Added.
  23350. (WebCore::BackwardsCharacterIterator::range): Added.
  23351. (WebCore::BackwardsCharacterIterator::advance): Added.
  23352. * editing/TextIterator.h: Added BackwardsCharacterIterator with the
  23353. minimal functionality required for this patch.
  23354. (WebCore::BackwardsCharacterIterator::atEnd): Added.
  23355. * editing/visible_units.cpp:
  23356. (WebCore::firstNonComplexContextLineBreak): Added this helper function
  23357. that returns the index of the first character in the string whose
  23358. Unicode line breaking property value is not SA ("Complex Context"), or
  23359. the length of the string if there is no such character.
  23360. (WebCore::lastNonComplexContextLineBreak): Added this helper function
  23361. that returns the index of the last character in the string whose
  23362. Unicode line breaking property value is not SA ("Complex Context"), or
  23363. -1 if there is no such character.
  23364. (WebCore::previousBoundary): Changed the signature of the search
  23365. function to include an offset parameter. Renamed the 'exception' local
  23366. variable to 'ec' and changed its type to ExceptionCode. Extend the
  23367. string forwards until the first character with Unicode line breaking
  23368. property value other than SA. This gives the boundary search function
  23369. enough context in the forward direction. Changed to use a
  23370. BackwardsCharacterIterator for translating the backwards offset into
  23371. a position.
  23372. (WebCore::nextBoundary): Changed the signature of the search
  23373. function to include an offset parameter. Extend the string backwards
  23374. until the first character with Unicode line breaking property value
  23375. other than SA. This gives the boundary search function enough context in
  23376. the backwards direction. Restricted the workaround for <rdar://5192593>
  23377. only to the line break case, because it was causing an extra character
  23378. to be selected following a word that ended with a combining mark.
  23379. (WebCore::startWordBoundary): Added an offset parameter. Check that
  23380. going backwards from the given offset, there is a character with Unicode
  23381. line breaking property value other than SA, and otherwise return 0 to
  23382. request more context.
  23383. (WebCore::endWordBoundary): Similar, but in reverse.
  23384. (WebCore::previousWordPositionBoundary): Similar.
  23385. (WebCore::nextWordPositionBoundary): Similar.
  23386. (WebCore::startSentenceBoundary): Updated for the new search function
  23387. signature.
  23388. (WebCore::endSentenceBoundary): Ditto.
  23389. (WebCore::previousSentencePositionBoundary): Ditto.
  23390. (WebCore::nextSentencePositionBoundary): Ditto.
  23391. 2009-03-11 Darin Adler <darin@apple.com>
  23392. Reviewed by Mark Rowe.
  23393. Don't use "::" in thread names because it is ugly!
  23394. * loader/icon/IconDatabase.cpp:
  23395. (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
  23396. * platform/network/cf/ResourceHandleCFNet.cpp:
  23397. (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make
  23398. it clear this is a WebCore-created thread.
  23399. * storage/DatabaseThread.cpp:
  23400. (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
  23401. * storage/LocalStorageThread.cpp:
  23402. (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
  23403. * workers/WorkerThread.cpp:
  23404. (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".
  23405. 2009-03-11 Mark Rowe <mrowe@apple.com>
  23406. Rubber-stamped by Darin Adler.
  23407. <rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex
  23408. * platform/mac/PlatformScreenMac.mm:
  23409. (WebCore::screenIsMonochrome): Return false.
  23410. 2009-03-11 Beth Dakin <bdakin@apple.com>
  23411. Reviewed by Dan Bernstein.
  23412. Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
  23413. top value on position:relative child not calculated correctly if
  23414. parent has percentage height
  23415. - and corresponding -
  23416. <rdar://problem/6172925>
  23417. * rendering/RenderBoxModelObject.cpp:
  23418. (WebCore::RenderBoxModelObject::relativePositionOffsetY):
  23419. 2009-03-11 Jian Li <jianli@chromium.org>
  23420. Reviewed by Dimitri Glazkov.
  23421. Implement ScriptValue::hasNoValue for V8.
  23422. https://bugs.webkit.org/show_bug.cgi?id=24507
  23423. * bindings/v8/ScriptValue.h:
  23424. (WebCore::ScriptValue::hasNoValue):
  23425. 2009-03-11 David Levin <levin@chromium.org>
  23426. Reviewed by Dimitri Glazkov.
  23427. Bug 24459: Add v8 bindings for event.
  23428. <https://bugs.webkit.org/show_bug.cgi?id=24459>
  23429. Adding custom event bindings.
  23430. * bindings/v8/custom/V8AbstractEventListener.cpp: Added.
  23431. * bindings/v8/custom/V8AbstractEventListener.h: Added.
  23432. * bindings/v8/custom/V8AttrCustom.cpp:
  23433. Fixed messed up copyright header.
  23434. * bindings/v8/custom/V8CustomEventListener.cpp: Added.
  23435. * bindings/v8/custom/V8CustomEventListener.h:
  23436. Replaced forwarding header with the real implementation.
  23437. * bindings/v8/custom/V8ElementCustom.cpp:
  23438. * bindings/v8/custom/V8LazyEventListener.cpp: Added.
  23439. * bindings/v8/custom/V8LazyEventListener.h: Added.
  23440. * bindings/v8/custom/V8ObjectEventListener.cpp: Added.
  23441. * bindings/v8/custom/V8ObjectEventListener.h: Added.
  23442. * bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
  23443. * bindings/v8/custom/V8WorkerContextEventListener.h: Added.
  23444. 2009-03-11 Darin Fisher <darin@chromium.org>
  23445. Reviewed by Dimitri Glazkov.
  23446. https://bugs.webkit.org/show_bug.cgi?id=24521
  23447. Add some missing includes for the non-JSC build.
  23448. * platform/text/PlatformString.h: added OwnPtr.h
  23449. * xml/XMLHttpRequest.cpp: added SecurityOrigin.h
  23450. 2009-03-11 Simon Fraser <simon.fraser@apple.com>
  23451. Reviewed by Darin Adler
  23452. https://bugs.webkit.org/show_bug.cgi?id=24531
  23453. Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
  23454. returns a null style if it has a valid renderer, which could happen if a
  23455. CompositeAnimation existed, but wasn't running any animations or transitions.
  23456. * page/animation/AnimationController.cpp:
  23457. (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
  23458. 2009-03-11 Simon Fraser <simon.fraser@apple.com>
  23459. Fix Scons build. Patch from Alexander Guy.
  23460. * WebCore.scons:
  23461. 2009-03-11 Simon Fraser <simon.fraser@apple.com>
  23462. Reviewed by Dan Bernstein
  23463. https://bugs.webkit.org/show_bug.cgi?id=23093
  23464. When the cancel button in the search field is shown or hidden,
  23465. we need to explicitly setStyle() on the cancel button's renderer,
  23466. to ensure that repaint happens. Changing the style without telling
  23467. the renderer won't work.
  23468. Test: fast/repaint/search-field-cancel.html
  23469. * rendering/RenderTextControlSingleLine.cpp:
  23470. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  23471. (WebCore::RenderTextControlSingleLine::updateFromElement):
  23472. (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
  23473. (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
  23474. (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
  23475. * rendering/RenderTextControlSingleLine.h:
  23476. 2009-03-11 Hironori Bono <hbono@chromium.org>
  23477. Reviewed by Alexey Proskuryakov.
  23478. https://bugs.webkit.org/show_bug.cgi?id=15790
  23479. Ligatures aren't accounted for when manipulating VisiblePositions
  23480. Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
  23481. Indic ligature which uses a virama sign.
  23482. Test: editing/deleting/skip-virama-001.html
  23483. * platform/text/TextBreakIteratorICU.cpp:
  23484. (WebCore::cursorMovementIterator):
  23485. 2009-03-11 Alexey Proskuryakov <ap@webkit.org>
  23486. Reviewed by George Staikos.
  23487. https://bugs.webkit.org/show_bug.cgi?id=24513
  23488. REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)
  23489. Fixes existing tests on Tiger.
  23490. * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
  23491. Use characterBreakIterator on Tiger (like we used to do).
  23492. 2009-03-11 Alexey Proskuryakov <ap@webkit.org>
  23493. Reviewed by Oliver Hunt.
  23494. <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
  23495. * platform/network/mac/ResourceRequestMac.mm:
  23496. (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name
  23497. in instancesRespondToSelector.
  23498. 2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
  23499. Reviewed by Holger Freyther.
  23500. [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
  23501. https://bugs.webkit.org/show_bug.cgi?id=2260
  23502. Add missing stdio.h include to get the build going
  23503. * plugins/gtk/PluginPackageGtk.cpp:
  23504. 2009-03-10 Justin Garcia <justin.garcia@apple.com>
  23505. Reviewed by Ken Kocienda.
  23506. * dom/Range.cpp:
  23507. (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects
  23508. would include rects for the divs contents. Set the correct RenderObject to stop at.
  23509. 2009-03-10 Alexey Proskuryakov <ap@webkit.org>
  23510. Reviewed by Sam Weinig.
  23511. <rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR
  23512. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect
  23513. comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and
  23514. there are security concerns with exposing them for cross-origin requests, so it's not clear
  23515. if we want to change anything here.
  23516. 2009-03-10 Simon Fraser <simon.fraser@apple.com>
  23517. Reviewed by Darin Adler
  23518. https://bugs.webkit.org/show_bug.cgi?id=24503
  23519. Fix hit testing of absolutely positioned single line text controls by
  23520. ensuring that we set result.innerNode() correctly. If the hit node is
  23521. a descendant of the inner text element or if it is the <input> itself,
  23522. then we say we hit the innerTextElement.
  23523. Rename hitInnerTextBlock() to hitInnerTextElement() to match the
  23524. 'innerTextElement' terminology used elsewhere.
  23525. Assert that if renderer()->hitTest() returns false, no-one set
  23526. result.innerNode().
  23527. Test: fast/forms/search-abs-pos-cancel-button.html
  23528. * rendering/RenderLayer.cpp:
  23529. (WebCore::RenderLayer::hitTestContents):
  23530. * rendering/RenderTextControl.cpp:
  23531. (WebCore::RenderTextControl::hitInnerTextElement):
  23532. * rendering/RenderTextControl.h:
  23533. * rendering/RenderTextControlMultiLine.cpp:
  23534. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  23535. * rendering/RenderTextControlSingleLine.cpp:
  23536. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  23537. 2009-03-10 Antti Koivisto <antti@apple.com>
  23538. Reviewed by Mark Rowe.
  23539. <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
  23540. Another case where we would trigger extended encoding loading needlessly.
  23541. * platform/text/TextEncoding.cpp:
  23542. (WebCore::TextEncoding::isNonByteBasedEncoding):
  23543. 2009-03-10 Beth Dakin <bdakin@apple.com>
  23544. Reviewed by Darin Adler.
  23545. Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
  23546. scroll bar appears for long line of text with NOWRAP set
  23547. This is a regression from http://trac.webkit.org/changeset/32226
  23548. I talked with Dan about the original change, and we decided that
  23549. the best fix was to remove his small potential-optimization that
  23550. only created a separate line box for whitespace under certain
  23551. circumstances. This new code will always create a separate line
  23552. box.
  23553. * rendering/bidi.cpp:
  23554. (WebCore::RenderBlock::layoutInlineChildren):
  23555. 2009-03-10 Sam Weinig <sam@webkit.org>
  23556. Reviewed by Geoffrey Garen.
  23557. Fix for <rdar://problem/6166844>
  23558. https://bugs.webkit.org/show_bug.cgi?id=24495
  23559. Use same rule for loading java applets as we do for images.
  23560. * html/HTMLAppletElement.cpp:
  23561. (WebCore::HTMLAppletElement::createRenderer):
  23562. * loader/FrameLoader.cpp:
  23563. (WebCore::FrameLoader::createJavaAppletWidget):
  23564. 2009-03-10 Justin Garcia <justin.garcia@apple.com>
  23565. Reviewed by David Kilzer.
  23566. Get rid of revealCaret and use revealSelection instead.
  23567. * WebCore.base.exp:
  23568. * editing/SelectionController.cpp:
  23569. (WebCore::SelectionController::setSelection):
  23570. * page/Frame.cpp:
  23571. (WebCore::Frame::revealSelection):
  23572. * page/Frame.h:
  23573. 2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  23574. Reviewed by Geoff Garen.
  23575. Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
  23576. <https://bugs.webkit.org/show_bug.cgi?id=23736>
  23577. <rdar://problem/6560278>
  23578. Before replacing the document, FrameLoader::executeIfJavaScriptURL()
  23579. should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().
  23580. * loader/FrameLoader.cpp:
  23581. (WebCore::FrameLoader::executeIfJavaScriptURL):
  23582. 2009-03-10 Darin Adler <darin@apple.com>
  23583. Reviewed by Alexey Proskuryakov.
  23584. Bug 24494: crash when deleting at end of document and merging paragraphs
  23585. https://bugs.webkit.org/show_bug.cgi?id=24494
  23586. rdar://problem/6571537
  23587. Test: editing/deleting/merge-at-end-of-document.html
  23588. * dom/Range.cpp:
  23589. (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to
  23590. use && in assertions since we'd like to know which condition is failing.
  23591. * editing/ApplyStyleCommand.cpp:
  23592. (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before
  23593. calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the
  23594. function doesn't know which value to return.
  23595. 2009-03-10 Dirk Schulze <krit@webkit.org>
  23596. Reviewed by Eric Seidel. Math checked by Oliver Hunt.
  23597. Implement the Cairo version of the checkForSolidColor() method. This halfes the
  23598. time to draw on 1x1 px background images.
  23599. I added two new calls to Color for the pixel manipulation on cairo_surface's.
  23600. They are neede to premultiply/unpremultiply the colors of the surface.
  23601. [CAIRO] Introduce single-pixel image optimizations
  23602. https://bugs.webkit.org/show_bug.cgi?id=17284
  23603. * platform/graphics/Color.cpp:
  23604. (WebCore::colorFromPremultipliedARGB):
  23605. (WebCore::premultipliedARGBFromColor):
  23606. * platform/graphics/Color.h:
  23607. * platform/graphics/cairo/ImageBufferCairo.cpp:
  23608. (WebCore::ImageBuffer::getImageData):
  23609. (WebCore::ImageBuffer::putImageData):
  23610. * platform/graphics/cairo/ImageCairo.cpp:
  23611. (WebCore::BitmapImage::checkForSolidColor):
  23612. 2009-03-06 Darin Fisher <darin@chromium.org>
  23613. Reviewed by Sam Weinig.
  23614. https://bugs.webkit.org/show_bug.cgi?id=24437
  23615. Add support for registering noAccess URL schemes:
  23616. 1- Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
  23617. that list upon construction (similar to how isLocal is implemented).
  23618. 2- Make InspectorController call grantUniversalAccess on its Document's
  23619. SecurityOrigin at the time when windowScriptObjectAvailable is called.
  23620. This enables content such as the inspector to be loaded from a custom (non-file)
  23621. URL, which is how Chromium loads the inspector. It also allows other URL schemes
  23622. to be treated like data: URLs, which Chromium utilizes for its various HTML-based
  23623. UI panels.
  23624. * inspector/InspectorController.cpp:
  23625. (WebCore::InspectorController::windowScriptObjectAvailable):
  23626. * loader/FrameLoader.cpp:
  23627. (WebCore::localSchemes):
  23628. (WebCore::noAccessSchemes):
  23629. (WebCore::FrameLoader::loadItem):
  23630. * loader/FrameLoader.h:
  23631. * page/SecurityOrigin.cpp:
  23632. (WebCore::SecurityOrigin::SecurityOrigin):
  23633. (WebCore::SecurityOrigin::isLocal):
  23634. 2009-03-10 Xan Lopez <xlopez@igalia.com>
  23635. Build fix, no review
  23636. * page/mac/AccessibilityObjectWrapper.mm:
  23637. (textMarkerForVisiblePosition):
  23638. (visiblePositionForTextMarker):
  23639. 2009-03-10 Xan Lopez <xlopez@igalia.com>
  23640. Reviewed by Darin Adler.
  23641. https://bugs.webkit.org/show_bug.cgi?id=24491
  23642. Rename posOffset to m_offset, get rid of accessor
  23643. As suggested in dom/Position.h, this patch gets rid of the
  23644. 'offset()' accessor and renames posOffset to m_offset. I've used
  23645. m_offset instead of offset to follow the style guide lines, since
  23646. Position is still a class and not a structure. If the long term
  23647. plan is still to make it a structure it would be pretty easy to
  23648. just s/m_offset/offset/ globally when that is achieved.
  23649. * dom/Position.cpp:
  23650. (WebCore::Position::previous):
  23651. (WebCore::Position::next):
  23652. (WebCore::Position::atStart):
  23653. (WebCore::Position::atEnd):
  23654. (WebCore::Position::renderedOffset):
  23655. (WebCore::Position::isCandidate):
  23656. (WebCore::Position::inRenderedText):
  23657. (WebCore::Position::isRenderedCharacter):
  23658. (WebCore::Position::rendersInDifferentPosition):
  23659. (WebCore::Position::leadingWhitespacePosition):
  23660. (WebCore::Position::debugPosition):
  23661. (WebCore::Position::formatForDebugger):
  23662. * dom/Position.h:
  23663. (WebCore::Position::Position):
  23664. * dom/PositionIterator.h:
  23665. (WebCore::PositionIterator::PositionIterator):
  23666. * dom/Range.cpp:
  23667. * dom/RangeBoundaryPoint.h:
  23668. (WebCore::RangeBoundaryPoint::position):
  23669. (WebCore::RangeBoundaryPoint::set):
  23670. (WebCore::RangeBoundaryPoint::setOffset):
  23671. (WebCore::RangeBoundaryPoint::setToChild):
  23672. (WebCore::RangeBoundaryPoint::setToStart):
  23673. (WebCore::RangeBoundaryPoint::setToEnd):
  23674. (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
  23675. * editing/ApplyStyleCommand.cpp:
  23676. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  23677. (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
  23678. (WebCore::ApplyStyleCommand::removeInlineStyle):
  23679. (WebCore::ApplyStyleCommand::nodeFullySelected):
  23680. (WebCore::ApplyStyleCommand::nodeFullyUnselected):
  23681. (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
  23682. (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
  23683. (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
  23684. (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
  23685. (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
  23686. (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
  23687. (WebCore::ApplyStyleCommand::joinChildTextNodes):
  23688. * editing/BreakBlockquoteCommand.cpp:
  23689. (WebCore::BreakBlockquoteCommand::doApply):
  23690. * editing/CompositeEditCommand.cpp:
  23691. (WebCore::CompositeEditCommand::insertNodeAt):
  23692. (WebCore::CompositeEditCommand::positionOutsideTabSpan):
  23693. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
  23694. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
  23695. (WebCore::CompositeEditCommand::deleteInsignificantText):
  23696. (WebCore::CompositeEditCommand::removePlaceholderAt):
  23697. (WebCore::CompositeEditCommand::moveParagraphs):
  23698. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  23699. * editing/DeleteSelectionCommand.cpp:
  23700. (WebCore::updatePositionForNodeRemoval):
  23701. (WebCore::updatePositionForTextRemoval):
  23702. (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  23703. (WebCore::DeleteSelectionCommand::fixupWhitespace):
  23704. * editing/Editor.cpp:
  23705. (WebCore::Editor::setComposition):
  23706. (WebCore::Editor::advanceToNextMisspelling):
  23707. (WebCore::Editor::getCompositionSelection):
  23708. * editing/InsertLineBreakCommand.cpp:
  23709. (WebCore::InsertLineBreakCommand::doApply):
  23710. * editing/InsertParagraphSeparatorCommand.cpp:
  23711. (WebCore::InsertParagraphSeparatorCommand::doApply):
  23712. * editing/InsertTextCommand.cpp:
  23713. (WebCore::InsertTextCommand::performTrivialReplace):
  23714. (WebCore::InsertTextCommand::input):
  23715. (WebCore::InsertTextCommand::insertTab):
  23716. * editing/MoveSelectionCommand.cpp:
  23717. (WebCore::MoveSelectionCommand::doApply):
  23718. * editing/ReplaceSelectionCommand.cpp:
  23719. (WebCore::ReplaceSelectionCommand::doApply):
  23720. * editing/SelectionController.cpp:
  23721. (WebCore::SelectionController::debugRenderer):
  23722. * editing/TextIterator.cpp:
  23723. (WebCore::TextIterator::rangeFromLocationAndLength):
  23724. * editing/TypingCommand.cpp:
  23725. (WebCore::TypingCommand::deleteKeyPressed):
  23726. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  23727. * editing/VisiblePosition.cpp:
  23728. (WebCore::VisiblePosition::characterAfter):
  23729. (WebCore::VisiblePosition::debugPosition):
  23730. (WebCore::makeRange):
  23731. (WebCore::setStart):
  23732. (WebCore::setEnd):
  23733. * editing/VisibleSelection.cpp:
  23734. (WebCore::VisibleSelection::toNormalizedRange):
  23735. (WebCore::makeSearchRange):
  23736. (WebCore::VisibleSelection::debugPosition):
  23737. (WebCore::VisibleSelection::showTreeForThis):
  23738. * editing/htmlediting.cpp:
  23739. (WebCore::comparePositions):
  23740. (WebCore::rangeCompliantEquivalent):
  23741. (WebCore::isFirstPositionAfterTable):
  23742. (WebCore::isLastPositionBeforeTable):
  23743. * editing/visible_units.cpp:
  23744. (WebCore::previousBoundary):
  23745. (WebCore::nextBoundary):
  23746. (WebCore::startPositionForLine):
  23747. (WebCore::startOfLine):
  23748. (WebCore::endPositionForLine):
  23749. (WebCore::nextLinePosition):
  23750. (WebCore::startOfParagraph):
  23751. (WebCore::endOfParagraph):
  23752. * page/AccessibilityObject.cpp:
  23753. (WebCore::updateAXLineStartForVisiblePosition):
  23754. * page/AccessibilityRenderObject.cpp:
  23755. (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  23756. * page/DOMSelection.cpp:
  23757. (WebCore::DOMSelection::anchorOffset):
  23758. (WebCore::DOMSelection::baseOffset):
  23759. (WebCore::DOMSelection::focusOffset):
  23760. (WebCore::DOMSelection::extentOffset):
  23761. * page/EventHandler.cpp:
  23762. (WebCore::EventHandler::handleMousePressEventSingleClick):
  23763. * page/Frame.cpp:
  23764. (WebCore::Frame::selectionLayoutChanged):
  23765. * rendering/RenderTextControl.cpp:
  23766. (WebCore::RenderTextControl::indexForVisiblePosition):
  23767. * rendering/RenderTreeAsText.cpp:
  23768. (WebCore::writeSelection):
  23769. 2009-03-10 Darin Adler <darin@apple.com>
  23770. Reviewed by Dan Bernstein.
  23771. Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
  23772. https://bugs.webkit.org/show_bug.cgi?id=23564
  23773. rdar://problem/6537238
  23774. Test: fast/dom/HTMLElement/innerHTML-selection-crash.html
  23775. * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
  23776. call to the one of the two overloads of this function that wasn't calling it. This fixes
  23777. this crash and other possible crashes inside innerHTML.
  23778. 2009-03-10 Alexey Proskuryakov <ap@webkit.org>
  23779. Reviewed by Darin Adler.
  23780. https://bugs.webkit.org/show_bug.cgi?id=24285
  23781. Text resource loading checks for BOM twice
  23782. This removes TextDecoder class, since its only purpose was to check for BOM, which is
  23783. already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
  23784. BOM checked, but I didn't find any cases where it would significantly change behavior.
  23785. * GNUmakefile.am:
  23786. * WebCore.pro:
  23787. * WebCore.scons:
  23788. * WebCore.vcproj/WebCore.vcproj:
  23789. * WebCore.xcodeproj/project.pbxproj:
  23790. * WebCoreSources.bkl:
  23791. Remove TextDecoder.{h,cpp}.
  23792. * platform/text/TextDecoder.cpp: Removed.
  23793. * platform/text/TextDecoder.h: Removed.
  23794. * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
  23795. TextCodec separately.
  23796. * loader/TextResourceDecoder.cpp:
  23797. (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
  23798. (WebCore::TextResourceDecoder::setEncoding): Ditto.
  23799. (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
  23800. even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
  23801. BOM again. Made this function return the detected BOM length.
  23802. (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
  23803. a text resource.
  23804. (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
  23805. resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
  23806. * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
  23807. Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
  23808. checks for BOM, which was a counter-intuitive feature.
  23809. * loader/CachedScript.cpp:
  23810. (WebCore::CachedScript::CachedScript):
  23811. (WebCore::CachedScript::setEncoding):
  23812. (WebCore::CachedScript::encoding):
  23813. (WebCore::CachedScript::script):
  23814. * loader/CachedScript.h:
  23815. * loader/appcache/ManifestParser.cpp:
  23816. (WebCore::parseManifest):
  23817. Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
  23818. A side effect of this is that these resources will now be subject to encoding auto-detection.
  23819. * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  23820. * page/Page.cpp: (WebCore::Page::userStyleSheet):
  23821. Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
  23822. re-usable (for repeated decoding of the same resource).
  23823. * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
  23824. 2009-03-10 Alexey Proskuryakov <ap@webkit.org>
  23825. Reviewed by Darin Adler.
  23826. https://bugs.webkit.org/show_bug.cgi?id=24488
  23827. An assertion failure when updating an offline application cache after emptying caches
  23828. Emptying appcache cannot be performed automatically, so no test.
  23829. * loader/appcache/ApplicationCacheGroup.cpp:
  23830. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
  23831. storage, even if the application wasn't updated server side.
  23832. 2009-03-10 Oliver Hunt <oliver@apple.com>
  23833. Reviewed by Alexey Proskuryakov.
  23834. <rdar://problem/6425807> Implement WorkerUtils.importScripts()
  23835. <https://bugs.webkit.org/show_bug.cgi?id=22721>
  23836. Implement importScripts, currently uses a series of synchronous loads
  23837. to fetch the scripts, but this is simpler than a synchronous load of
  23838. multiple loads in parallel. In future we'll want to switch to parallel
  23839. loading, but this will do for now.
  23840. Test: http/tests/workers/worker-importScripts.html
  23841. * GNUmakefile.am:
  23842. * WebCore.vcproj/WebCore.vcproj:
  23843. * WebCore.xcodeproj/project.pbxproj:
  23844. * bindings/js/JSWorkerContextCustom.cpp:
  23845. (WebCore::JSWorkerContext::importScripts):
  23846. * bindings/js/ScriptValue.h:
  23847. (WebCore::ScriptValue::hasNoValue):
  23848. * bindings/js/WorkerScriptController.cpp:
  23849. (WebCore::WorkerScriptController::evaluate):
  23850. (WebCore::WorkerScriptController::setException):
  23851. * bindings/js/WorkerScriptController.h:
  23852. * dom/Document.cpp:
  23853. (WebCore::Document::scriptImported):
  23854. * dom/Document.h:
  23855. * dom/ScriptExecutionContext.h:
  23856. * inspector/InspectorController.cpp:
  23857. (WebCore::InspectorController::scriptImported):
  23858. * inspector/InspectorController.h:
  23859. * inspector/InspectorResource.cpp:
  23860. (WebCore::InspectorResource::setScriptProperties):
  23861. * inspector/InspectorResource.h:
  23862. * workers/WorkerContext.cpp:
  23863. (WebCore::WorkerContext::scriptImported):
  23864. (WebCore::WorkerContext::importScripts):
  23865. * workers/WorkerContext.h:
  23866. * workers/WorkerContext.idl:
  23867. * workers/WorkerImportScriptsClient.cpp: Added.
  23868. (WebCore::WorkerImportScriptsClient::didReceiveResponse):
  23869. (WebCore::WorkerImportScriptsClient::didReceiveData):
  23870. (WebCore::WorkerImportScriptsClient::didFinishLoading):
  23871. (WebCore::WorkerImportScriptsClient::didFail):
  23872. (WebCore::WorkerImportScriptsClient::didFailRedirectCheck):
  23873. (WebCore::WorkerImportScriptsClient::didReceiveAuthenticationCancellation):
  23874. * workers/WorkerImportScriptsClient.h: Added.
  23875. (WebCore::WorkerImportScriptsClient::WorkerImportScriptsClient):
  23876. (WebCore::WorkerImportScriptsClient::script):
  23877. (WebCore::WorkerImportScriptsClient::failed):
  23878. 2009-03-10 Alexey Proskuryakov <ap@webkit.org>
  23879. Reviewed by Darin Adler.
  23880. https://bugs.webkit.org/show_bug.cgi?id=24462
  23881. Move cross-origin access control code out of XMLHttpRequest
  23882. Step 1: move preflight result cache and access control helper functions.
  23883. No change in behavior, so no test.
  23884. * GNUmakefile.am:
  23885. * WebCore.pro:
  23886. * WebCore.scons:
  23887. * WebCore.vcproj/WebCore.vcproj:
  23888. * WebCore.xcodeproj/project.pbxproj:
  23889. * WebCoreSources.bkl:
  23890. * loader/CrossOriginAccessControl.cpp: Added.
  23891. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
  23892. (WebCore::isSimpleCrossOriginAccessRequest):
  23893. (WebCore::createAllowedCrossOriginResponseHeadersSet):
  23894. (WebCore::isOnAccessControlResponseHeaderWhitelist):
  23895. (WebCore::passesAccessControlCheck):
  23896. * loader/CrossOriginAccessControl.h: Added.
  23897. * loader/CrossOriginPreflightResultCache.cpp: Added.
  23898. (WebCore::parseAccessControlMaxAge):
  23899. (WebCore::addToAccessControlAllowList):
  23900. (WebCore::parseAccessControlAllowList):
  23901. (WebCore::CrossOriginPreflightResultCacheItem::parse):
  23902. (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
  23903. (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
  23904. (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
  23905. (WebCore::CrossOriginPreflightResultCache::shared):
  23906. (WebCore::CrossOriginPreflightResultCache::appendEntry):
  23907. (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
  23908. * loader/CrossOriginPreflightResultCache.h: Added.
  23909. (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
  23910. (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
  23911. * xml/XMLHttpRequest.cpp:
  23912. (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
  23913. (WebCore::XMLHttpRequest::createRequest):
  23914. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
  23915. (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
  23916. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
  23917. (WebCore::XMLHttpRequest::didReceiveResponse):
  23918. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  23919. * xml/XMLHttpRequest.h:
  23920. 2009-03-10 Alexey Proskuryakov <ap@webkit.org>
  23921. Reviewed by Darin Adler.
  23922. https://bugs.webkit.org/show_bug.cgi?id=19797
  23923. Bring the list of forbidden headers in sync with XMLHttpRequest spec draft
  23924. Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.
  23925. * xml/XMLHttpRequest.cpp:
  23926. (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from
  23927. XMLHttpRequest 2 draft.
  23928. 2009-03-10 Dan Bernstein <mitz@apple.com>
  23929. Reviewed by Adele Peterson.
  23930. - fix https://bugs.webkit.org/show_bug.cgi?id=23975
  23931. <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted
  23932. * rendering/RenderLayer.cpp:
  23933. (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical
  23934. scrollbar rect calculation.
  23935. 2009-03-09 Simon Fraser <simon.fraser@apple.com>
  23936. Reviewed by Dan Bernstein, Oliver Hunt
  23937. https://bugs.webkit.org/show_bug.cgi?id=24475
  23938. When repainting replaced elements, need to union the selection
  23939. and overflow rects because either may extend outside the other.
  23940. Test: fast/repaint/transform-replaced-shadows.html
  23941. * rendering/RenderReplaced.cpp:
  23942. (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
  23943. 2009-03-09 Stephanie Lewis <slewis@apple.com>
  23944. Fix build.
  23945. * editing/Editor.cpp:
  23946. (WebCore::Editor::advanceToNextMisspelling):
  23947. (WebCore::markAllMisspellingsAndBadGrammarInRanges):
  23948. 2009-03-09 Kim Christensen <kimworking@gmail.com>
  23949. Reviewed by Darin Fisher.
  23950. https://bugs.webkit.org/show_bug.cgi?id=24276
  23951. Dropdown / select boxes do not consider the windows task bar in Chromium.
  23952. * platform/chromium/PopupMenuChromium.cpp:
  23953. (WebCore::PopupContainer::showPopup):
  23954. 2009-03-09 Dan Bernstein <mitz@apple.com>
  23955. Reviewed by Adele Peterson and Dave Hyatt.
  23956. - fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
  23957. misaligned edit fields
  23958. Test: fast/forms/legend-display-none.html
  23959. * css/CSSStyleSelector.cpp:
  23960. (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display
  23961. property of legend elements to 'block' unless it is 'none'.
  23962. * css/html4.css: Do not force the display property of legend elements to
  23963. 'block' using CSS, because that prevents style rules from setting it to
  23964. 'none'.
  23965. 2009-03-09 Alpha Lam <hclam@chromium.org>
  23966. Reviewed by Dave Hyatt.
  23967. https://bugs.webkit.org/show_bug.cgi?id=23024
  23968. Fix an incorrect criteria in the if statement that leaves references to
  23969. deleted floating objects in RenderBlock.
  23970. Test: fast/block/float/crash-on-absolute-positioning.html
  23971. * rendering/RenderBlock.cpp:
  23972. (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  23973. 2009-03-09 Mike Belshe <mike@belshe.com>
  23974. Reviewed by Eric Seidel.
  23975. Unify JSC/V8 idl file.
  23976. https://bugs.webkit.org/show_bug.cgi?id=24424
  23977. * page/Location.idl:
  23978. 2009-03-09 Mike Belshe <mike@belshe.com>
  23979. Reviewed by Eric Seidel.
  23980. Unify JSC/V8 for History.idl.
  23981. * page/History.idl:
  23982. 2009-03-09 Mike Belshe <mike@belshe.com>
  23983. Reviewed by Eric Seidel.
  23984. Unify JSC/V8 implementations of DOMWindow.idl.
  23985. * page/DOMWindow.idl:
  23986. 2009-03-09 Simon Fraser <simon.fraser@apple.com>
  23987. Reviewed by Dave Hyatt
  23988. https://bugs.webkit.org/show_bug.cgi?id=24163
  23989. Implement mapping of FloatQuads through 3D transforms.
  23990. Removed the redundant localToContainerQuad() methods, which can now
  23991. shared code with the old mapLocalToAbsolutePoint(), which was
  23992. renamed to mapLocalToContainer(). This can now convert a point,
  23993. and optionally a FloatQuad, which are carried along in the TransformState.
  23994. Optimized TransformState to reduce to simple FloatPoint.move()
  23995. if there are no transforms, and to heap-allocate a transform only if
  23996. necessary to accumulate transforms (when using preserve-3d).
  23997. Tested by 3d point mapping tests, and the inspector highlight (which now shows
  23998. the correct quads for 3d-transformed elements).
  23999. * platform/graphics/transforms/TransformationMatrix.cpp:
  24000. (WebCore::TransformationMatrix::projectQuad):
  24001. (WebCore::TransformationMatrix::translateRight):
  24002. (WebCore::TransformationMatrix::translateRight3d):
  24003. * platform/graphics/transforms/TransformationMatrix.h:
  24004. * rendering/RenderBox.cpp:
  24005. (WebCore::RenderBox::mapLocalToContainer):
  24006. (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  24007. * rendering/RenderBox.h:
  24008. * rendering/RenderObject.cpp:
  24009. (WebCore::RenderObject::localToAbsolute):
  24010. (WebCore::RenderObject::absoluteToLocal):
  24011. (WebCore::RenderObject::mapLocalToContainer):
  24012. (WebCore::RenderObject::localToContainerQuad):
  24013. * rendering/RenderObject.h:
  24014. * rendering/RenderTableCell.cpp:
  24015. (WebCore::RenderTableCell::mapLocalToContainer):
  24016. * rendering/RenderTableCell.h:
  24017. * rendering/RenderView.cpp:
  24018. (WebCore::RenderView::mapLocalToContainer):
  24019. * rendering/RenderView.h:
  24020. * rendering/TransformState.cpp:
  24021. (WebCore::TransformState::move):
  24022. (WebCore::TransformState::applyTransform):
  24023. (WebCore::TransformState::flatten):
  24024. (WebCore::TransformState::mappedPoint):
  24025. (WebCore::TransformState::mappedQuad):
  24026. (WebCore::TransformState::flattenWithTransform):
  24027. (WebCore::HitTestingTransformState::mappedQuad):
  24028. * rendering/TransformState.h:
  24029. (WebCore::TransformState::TransformState):
  24030. (WebCore::TransformState::move):
  24031. (WebCore::TransformState::lastPlanarPoint):
  24032. (WebCore::TransformState::lastPlanarQuad):
  24033. * rendering/style/RenderStyle.h:
  24034. (WebCore::InheritedFlags::preserves3D):
  24035. 2009-03-09 Simon Fraser <simon.fraser@apple.com>
  24036. Reviewed by Dave Hyatt
  24037. https://bugs.webkit.org/show_bug.cgi?id=24433
  24038. During hit testing with transforms, if a layer has backface-visibility: hidden,
  24039. we need to check for it whether or not the layer has a transform, because it
  24040. might be an ancestor that is transformed.
  24041. Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html
  24042. * rendering/RenderLayer.cpp:
  24043. (WebCore::RenderLayer::hitTestLayer):
  24044. 2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  24045. Reviewed by George Staikos.
  24046. https://bugs.webkit.org/show_bug.cgi?id=24353
  24047. Allow to overrule default build options for Qt build.
  24048. * WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
  24049. 2009-03-09 Adam Treat <adam.treat@torchmobile.com>
  24050. Reviewed by George Staikos.
  24051. https://bugs.webkit.org/show_bug.cgi?id=24463
  24052. WebCore::qstring is detaching and copying twice for every single
  24053. WebCore::TextRun that is processed and drawn. This elevates this method
  24054. to one of the top-ten most expensive methods in all of QtWebKit according
  24055. to profiling. This changes the method so that QString only detaches
  24056. when absolutely necessary.
  24057. * platform/graphics/qt/FontQt.cpp:
  24058. (WebCore::qstring):
  24059. (WebCore::fixSpacing):
  24060. (WebCore::Font::drawComplexText):
  24061. (WebCore::Font::floatWidthForComplexText):
  24062. (WebCore::Font::offsetForPositionForComplexText):
  24063. (WebCore::Font::selectionRectForComplexText):
  24064. 2009-03-08 Mark Rowe <mrowe@apple.com>
  24065. Reviewed by Oliver Hunt.
  24066. Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
  24067. Frame.h no longer needs to include it. This cuts the size of the symbols
  24068. for a debug build by around 3%.
  24069. * dom/Element.cpp:
  24070. (WebCore::Element::scrollIntoView):
  24071. (WebCore::Element::scrollIntoViewIfNeeded):
  24072. * editing/Editor.cpp:
  24073. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  24074. (WebCore::Editor::revealSelectionAfterEditingOperation):
  24075. * editing/SelectionController.cpp:
  24076. (WebCore::SelectionController::setSelection):
  24077. * loader/FrameLoader.cpp:
  24078. (WebCore::FrameLoader::gotoAnchor):
  24079. * page/ContextMenuController.cpp:
  24080. (WebCore::ContextMenuController::contextMenuItemSelected):
  24081. * page/Frame.cpp:
  24082. (WebCore::Frame::revealSelection):
  24083. (WebCore::Frame::revealCaret):
  24084. * page/Frame.h:
  24085. * rendering/RenderLayer.cpp:
  24086. (WebCore::RenderLayer::getRectToExpose):
  24087. (WebCore::RenderLayer::autoscroll):
  24088. * rendering/RenderLayer.h:
  24089. * rendering/ScrollBehavior.cpp: Added.
  24090. (WebCore::):
  24091. * rendering/ScrollBehavior.h: Added.
  24092. (WebCore::):
  24093. (WebCore::ScrollAlignment::getVisibleBehavior):
  24094. (WebCore::ScrollAlignment::getPartialBehavior):
  24095. (WebCore::ScrollAlignment::getHiddenBehavior):
  24096. Add the new files to the build systems:
  24097. * GNUmakefile.am:
  24098. * WebCore.base.exp:
  24099. * WebCore.pro:
  24100. * WebCore.scons:
  24101. * WebCore.vcproj/WebCore.vcproj:
  24102. * WebCore.xcodeproj/project.pbxproj:
  24103. * WebCoreSources.bkl:
  24104. Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
  24105. * dom/Clipboard.cpp:
  24106. * editing/EditorCommand.cpp:
  24107. * editing/InsertLineBreakCommand.cpp:
  24108. * editing/TypingCommand.cpp:
  24109. * html/HTMLFormControlElement.cpp:
  24110. * loader/archive/cf/LegacyWebArchive.cpp:
  24111. * loader/icon/IconLoader.cpp:
  24112. * page/animation/AnimationController.cpp:
  24113. * rendering/RenderSlider.cpp:
  24114. * rendering/RenderTextControl.cpp:
  24115. 2009-03-08 Mark Rowe <mrowe@apple.com>
  24116. Reviewed Dan Bernstein.
  24117. Push the include of Frame.h out of RenderView.h and down to those files
  24118. that need it. This cuts the size of symbols for RenderFoo object files
  24119. by around 15% in a debug build.
  24120. * bindings/objc/DOM.mm:
  24121. * rendering/RenderFileUploadControl.cpp:
  24122. * rendering/RenderInline.cpp:
  24123. * rendering/RenderObject.cpp:
  24124. * rendering/RenderReplaced.cpp:
  24125. * rendering/RenderText.cpp:
  24126. * rendering/RenderView.cpp:
  24127. (WebCore::RenderView::zoomFactor):
  24128. * rendering/RenderView.h:
  24129. 2009-03-08 Mark Rowe <mrowe@apple.com>
  24130. Rubber-stamped by Dan Bernstein.
  24131. Remove some unnecessary or redundant includes from files related to the JS bindings.
  24132. This cuts the size of the symbols for a debug build by around 3%.
  24133. * bindings/js/JSCustomPositionCallback.cpp:
  24134. * bindings/js/JSCustomPositionErrorCallback.cpp:
  24135. * bindings/js/JSCustomSQLStatementCallback.cpp:
  24136. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  24137. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  24138. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  24139. * bindings/js/JSCustomVoidCallback.cpp:
  24140. * bindings/js/JSCustomXPathNSResolver.cpp:
  24141. * bindings/js/JSDocumentCustom.cpp:
  24142. * bindings/js/JSPluginElementFunctions.cpp:
  24143. * bindings/js/JSSVGPODTypeWrapper.h:
  24144. 2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  24145. Reviewed by Oliver Hunt.
  24146. Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
  24147. and provisionalHistoryItem() from FrameLoader.
  24148. * WebCore.base.exp:
  24149. * WebCore.order:
  24150. * loader/FrameLoader.cpp:
  24151. (WebCore::FrameLoader::frameLoadCompleted):
  24152. (WebCore::FrameLoader::loadItem):
  24153. * loader/FrameLoader.h:
  24154. 2009-03-08 Gustavo Noronha Silva <gns@gnome.org>
  24155. Reviewed by Holger Freyther.
  24156. Implement proper logging for the GTK+ port, inspired by the one in
  24157. Qt. We use the WEBKIT_DEBUG environment variable which was already
  24158. being used to decide whether to setup a logger for soup or not.
  24159. * platform/gtk/LoggingGtk.cpp:
  24160. (WebCore::getChannelFromName):
  24161. (WebCore::InitializeLoggingChannelsIfNecessary):
  24162. * platform/network/soup/ResourceHandleSoup.cpp:
  24163. (WebCore::ensureSessionIsInitialized):
  24164. 2009-03-07 Dan Bernstein <mitz@apple.com>
  24165. Reviewed by Mark Rowe.
  24166. - WebCore part of removing build-time and run-time support for legacy
  24167. versions of CFNetwork and Core Graphics
  24168. * platform/graphics/win/FontCGWin.cpp:
  24169. (WebCore::Font::drawGlyphs):
  24170. * platform/graphics/win/FontCustomPlatformData.cpp:
  24171. (WebCore::FontCustomPlatformData::fontPlatformData):
  24172. * platform/graphics/win/FontPlatformDataCGWin.cpp:
  24173. (WebCore::FontPlatformData::platformDataInit):
  24174. * platform/network/cf/FormDataStreamCFNet.cpp:
  24175. (WebCore::setHTTPBody):
  24176. (WebCore::httpBodyFromRequest):
  24177. * platform/network/cf/ResourceHandleCFNet.cpp:
  24178. (WebCore::didSendBodyData):
  24179. (WebCore::shouldUseCredentialStorageCallback):
  24180. (WebCore::ResourceHandle::start):
  24181. * platform/network/win/CookieJarCFNetWin.cpp:
  24182. (WebCore::filterCookies):
  24183. 2009-03-07 Adele Peterson <adele@apple.com>
  24184. Reviewed by Dan Bernstein.
  24185. Fix for https://bugs.webkit.org/show_bug.cgi?id=24444
  24186. No multiple JS property for <input type="file" multiple />
  24187. * html/HTMLInputElement.cpp:
  24188. (WebCore::HTMLInputElement::multiple):
  24189. (WebCore::HTMLInputElement::setMultiple):
  24190. * html/HTMLInputElement.h:
  24191. * html/HTMLInputElement.idl:
  24192. 2009-03-07 Xan Lopez <xan@gnome.org>
  24193. Reviewed by Holger Freyther.
  24194. https://bugs.webkit.org/show_bug.cgi?id=24358
  24195. [GTK] Scrollbars not clipped correctly
  24196. ScrollView scrollbars in subframes are *not* native, so take that
  24197. into account again.
  24198. * platform/gtk/ScrollbarGtk.cpp:
  24199. (ScrollbarGtk::getLocationInParentWindow):
  24200. (ScrollbarGtk::frameRectsChanged):
  24201. (ScrollbarGtk::paint):
  24202. * platform/gtk/ScrollbarGtk.h:
  24203. 2009-03-06 Peter Kasting <pkasting@google.com>
  24204. Reviewed by Darin Fisher.
  24205. https://bugs.webkit.org/show_bug.cgi?id=24405
  24206. Horizontal scrolling on Windows was reversed from Mac (and intuition).
  24207. * platform/gtk/WheelEventGtk.cpp:
  24208. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24209. * platform/win/WheelEventWin.cpp:
  24210. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24211. 2009-03-06 Peter Kasting <pkasting@google.com>
  24212. Reviewed by Sam Weinig.
  24213. Convert some C-style casts to static_cast<>()s.
  24214. * platform/gtk/WheelEventGtk.cpp:
  24215. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24216. * platform/mac/WheelEventMac.mm:
  24217. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24218. * platform/win/WheelEventWin.cpp:
  24219. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24220. * platform/wx/MouseWheelEventWx.cpp:
  24221. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24222. 2009-03-06 Adele Peterson <adele@apple.com>
  24223. Reviewed by Oliver Hunt.
  24224. Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)
  24225. I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.
  24226. * page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element.
  24227. That is no longer true, so we should return the document element for a truly empty document.
  24228. 2009-03-06 Jay Campan <jcampan@google.com>
  24229. Reviewed by Darin Fisher.
  24230. https://bugs.webkit.org/show_bug.cgi?id=24306
  24231. Adding a flag to ResourceRequestBase to indicate whether or not upload
  24232. progress notifications are needed for a resource. This is useful to
  24233. avoid sending these notifications when there are no consumers
  24234. (especially in the Chromium case where IPC is involved).
  24235. * platform/network/ResourceRequestBase.h:
  24236. (WebCore::ResourceRequestBase::reportUploadProgress):
  24237. (WebCore::ResourceRequestBase::setReportUploadProgress):
  24238. (WebCore::ResourceRequestBase::ResourceRequestBase):
  24239. * xml/XMLHttpRequest.cpp:
  24240. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  24241. 2009-03-06 Dmitry Titov <dimich@chromium.org>
  24242. Reviewed by Alexey Proskuryakov.
  24243. https://bugs.webkit.org/show_bug.cgi?id=24150
  24244. Add virtual ScriptExecutionContext::encoding()
  24245. Test: http/tests/workers/text-encoding.html
  24246. * dom/Document.cpp:
  24247. (WebCore::Document::encoding):
  24248. * dom/Document.h:
  24249. (WebCore::Document::inputEncoding):
  24250. (WebCore::Document::charset):
  24251. (WebCore::Document::characterSet):
  24252. Add new virtual method and route DOM synonym functions on Document through it.
  24253. * dom/ScriptExecutionContext.h:
  24254. * workers/Worker.cpp:
  24255. (WebCore::Worker::Worker):
  24256. (WebCore::Worker::notifyFinished):
  24257. * workers/WorkerContext.cpp:
  24258. (WebCore::WorkerContext::WorkerContext):
  24259. (WebCore::WorkerContext::encoding):
  24260. (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
  24261. * workers/WorkerContext.h:
  24262. (WebCore::WorkerContext::create):
  24263. * workers/WorkerContextProxy.h:
  24264. * workers/WorkerMessagingProxy.cpp:
  24265. (WebCore::WorkerMessagingProxy::startWorkerContext):
  24266. * workers/WorkerMessagingProxy.h:
  24267. * workers/WorkerThread.cpp:
  24268. (WebCore::WorkerThreadStartupData::create):
  24269. (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
  24270. (WebCore::WorkerThread::create):
  24271. (WebCore::WorkerThread::WorkerThread):
  24272. (WebCore::WorkerThread::workerThread):
  24273. * workers/WorkerThread.h:
  24274. All of the above route the 'encoding' parameter of parent context to the new
  24275. instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy
  24276. through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.
  24277. 2009-03-06 Peter Kasting <pkasting@google.com>
  24278. Build bustage fix.
  24279. * dom/Node.cpp:
  24280. (WebCore::Node::dispatchWheelEvent):
  24281. 2009-03-06 Eric Carlson <eric.carlson@apple.com>
  24282. Reviewed by Antti Koivisto.
  24283. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  24284. (WebCore::MediaPlayerPrivate::createQTMovieView): Delay callback while setting up movieview.
  24285. 2009-03-06 Douglas R. Davidson <ddavidso@apple.com>
  24286. Reviewed by Justin Garcia.
  24287. https://bugs.webkit.org/show_bug.cgi?id=24108
  24288. Update spelling and grammar checking to use the new combined text
  24289. checking (with automatic language identification) on Snow Leopard.
  24290. Tested manually in Mail and Safari; automated tests to come later.
  24291. * editing/Editor.cpp:
  24292. (WebCore::findFirstMisspellingOrBadGrammarInRange):
  24293. (WebCore::Editor::advanceToNextMisspelling):
  24294. (WebCore::guessesForMisspelledOrUngrammaticalRange):
  24295. (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
  24296. (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  24297. (WebCore::markAllMisspellingsAndBadGrammarInRanges):
  24298. (WebCore::Editor::markMisspellingsAndBadGrammar):
  24299. * editing/Editor.h:
  24300. * loader/EmptyClients.h:
  24301. (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
  24302. * page/EditorClient.h:
  24303. * page/Frame.cpp:
  24304. (WebCore::Frame::respondToChangedSelection):
  24305. * platform/ContextMenu.cpp:
  24306. (WebCore::ContextMenu::populate):
  24307. 2009-03-06 Peter Kasting <pkasting@google.com>
  24308. Reviewed by Darin Fisher.
  24309. https://bugs.webkit.org/show_bug.cgi?id=24407
  24310. Windows scroll amount was too small, and wheel scroll distance
  24311. conversion code was overly complex.
  24312. * page/EventHandler.cpp:
  24313. (WebCore::scrollAndAcceptEvent):
  24314. * platform/PlatformWheelEvent.h:
  24315. (WebCore::):
  24316. * platform/ScrollView.cpp:
  24317. (WebCore::ScrollView::wheelEvent):
  24318. * platform/Scrollbar.h:
  24319. * platform/gtk/WheelEventGtk.cpp:
  24320. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24321. * platform/mac/WheelEventMac.mm:
  24322. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24323. * platform/qt/WheelEventQt.cpp:
  24324. * platform/win/WheelEventWin.cpp:
  24325. (WebCore::horizontalScrollChars):
  24326. (WebCore::verticalScrollLines):
  24327. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24328. * platform/wx/MouseWheelEventWx.cpp:
  24329. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  24330. 2009-03-06 Dimitri Glazkov <dglazkov@chromium.org>
  24331. Reviewed by Adam Roben.
  24332. Generate valid bindings with HTML5 database support disabled.
  24333. * inspector/InspectorController.idl: Added feature guard around
  24334. databaseTableNames definition.
  24335. 2009-03-04 Xan Lopez <xan@gnome.org>
  24336. Reviewed by Holger Freyther.
  24337. https://bugs.webkit.org/show_bug.cgi?id=24358
  24338. [GTK] Scrollbars not clipped correctly
  24339. Do not take into account the case of being a ScrollView scrollbar,
  24340. since those are native in our case.
  24341. * platform/gtk/ScrollbarGtk.cpp:
  24342. (ScrollbarGtk::frameRectsChanged):
  24343. 2009-03-04 Xan Lopez <xan@gnome.org>
  24344. Reviewed by Holger Freyther.
  24345. https://bugs.webkit.org/show_bug.cgi?id=24358
  24346. [GTK] Scrollbars not clipped correctly
  24347. Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
  24348. specific and it's our only Widget anyway.
  24349. * platform/gtk/ScrollbarGtk.cpp:
  24350. (ScrollbarGtk::paint):
  24351. * platform/gtk/ScrollbarGtk.h:
  24352. * platform/gtk/WidgetGtk.cpp:
  24353. 2009-03-04 Xan Lopez <xan@gnome.org>
  24354. Reviewed by Holger Freyther.
  24355. https://bugs.webkit.org/show_bug.cgi?id=24358
  24356. [GTK] Scrollbars not clipped correctly
  24357. Use correct clip rectangle and apply coordinate translation needed
  24358. for non-ScrollView scrollbars.
  24359. We were ignoring the clip rectangle passed as parameter, which is
  24360. wrong in the case of non coalesced expose events. This, in turn,
  24361. uncovers the fact that we were not applying coordinate translation
  24362. to our position.
  24363. * platform/gtk/WidgetGtk.cpp:
  24364. (WebCore::Widget::paint):
  24365. 2009-03-06 Eric Carlson <eric.carlson@apple.com>
  24366. Build fix, no review
  24367. * platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
  24368. 2009-03-06 Eric Carlson <eric.carlson@apple.com>
  24369. Reviewed by Simon Fraser.
  24370. https://bugs.webkit.org/show_bug.cgi?id=22790
  24371. Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
  24372. Replace media engine setRect with setSize since they don't use about the
  24373. position anyway.
  24374. * platform/graphics/MediaPlayer.cpp:
  24375. (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect.
  24376. (WebCore::MediaPlayer::setSize): Ditto.
  24377. * platform/graphics/MediaPlayer.h:
  24378. (WebCore::MediaPlayer::size): Changed from rect().
  24379. * platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
  24380. * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
  24381. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  24382. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect
  24383. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  24384. (WebCore::MediaPlayerPrivate::paint): update comment
  24385. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
  24386. * platform/graphics/mac/MediaPlayerPrivateQTKit.h: m_rect
  24387. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  24388. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect.
  24389. (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize.
  24390. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  24391. (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so
  24392. the movie is drawn in the correct location.
  24393. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  24394. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  24395. * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  24396. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  24397. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  24398. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  24399. * rendering/RenderVideo.cpp:
  24400. (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
  24401. 2009-03-06 Darin Adler <darin@apple.com>
  24402. Reviewed by Darin Fisher.
  24403. Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
  24404. https://bugs.webkit.org/show_bug.cgi?id=24422
  24405. rdar://problem/6402208
  24406. Test: fast/dom/location-new-window-no-crash.html
  24407. The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
  24408. to add some checks for empty URLs. We could also put the empty URL checks at some
  24409. other bottleneck level and add more assertions over time. I tried adding a few more
  24410. assertions to functions like loadURL and hit them while running the regression tests,
  24411. so it's probably going to be a bit tricky to clean this up throughout the loader.
  24412. * loader/FrameLoader.cpp:
  24413. (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct
  24414. immutable by making all its members const. Added assertions about the arguments,
  24415. including that the URL is not empty. Initialized one uninitialized member in one of
  24416. the constructors.
  24417. (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this
  24418. a no-op if passed an empty URL.
  24419. (WebCore::FrameLoader::scheduleLocationChange): Ditto.
  24420. (WebCore::FrameLoader::scheduleRefresh): Ditto.
  24421. 2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
  24422. Reviewed by Holger Freyther.
  24423. https://bugs.webkit.org/show_bug.cgi?id=24423
  24424. Use new soup_message_body_set_accumulate API in soup backend
  24425. Disable accumulating chunks for request_body on file uploads,
  24426. using the new soup API.
  24427. * platform/network/soup/ResourceHandleSoup.cpp:
  24428. (WebCore::ResourceHandle::startHttp):
  24429. 2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
  24430. Reviewed by Holger Freyther.
  24431. Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
  24432. the new soup_message_body_set_accumulate API in soup.
  24433. * platform/network/soup/ResourceHandleSoup.cpp:
  24434. (WebCore::gotHeadersCallback):
  24435. (WebCore::ResourceHandle::startHttp):
  24436. 2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
  24437. Reviewed by Holger Freyther.
  24438. https://bugs.webkit.org/show_bug.cgi?id=24051
  24439. Soup backend needs content sniffing capabilities
  24440. Perform content sniffing when using soup, so that we have a chance
  24441. of figuring out the Content-Type of the file if it's not sent by
  24442. the server.
  24443. * platform/network/ResourceHandleInternal.h:
  24444. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  24445. * platform/network/soup/ResourceHandleSoup.cpp:
  24446. (WebCore::gotHeadersCallback):
  24447. (WebCore::gotChunkCallback):
  24448. 2009-03-06 Hironori Bono <hbono@chromium.org>
  24449. Reviewed by Alexey Proskuryakov.
  24450. https://bugs.webkit.org/show_bug.cgi?id=24342
  24451. Cannot insert a Thai character after a Thai prepend character when using ICU 4.0
  24452. This change creates a new break iterator "cursorMovementIterator" for
  24453. moving cursors and use it when moving an input cursor.
  24454. In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
  24455. based on the one of ICU 3.8.
  24456. On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
  24457. just calls the characterBreakIterator() function.
  24458. Test: editing/inserting/insert-thai-characters-001.html
  24459. * platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
  24460. * platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU.
  24461. (WebCore::setUpIteratorWithRules): Ditto.
  24462. (WebCore::cursorMovementIterator): Ditto.
  24463. * platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt.
  24464. (WebCore::cursorMovementIterator): Ditto.
  24465. * rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor.
  24466. (WebCore::RenderText::previousOffset): Ditto.
  24467. (WebCore::RenderText::nextOffset): Ditto.
  24468. 2009-03-05 Alexey Proskuryakov <ap@webkit.org>
  24469. Reviewed by Oliver Hunt.
  24470. <rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
  24471. Characters (a compatibility issue with widgets).
  24472. Test: http/tests/xmlhttprequest/broken-xml-encoding.html
  24473. Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
  24474. responses.
  24475. * loader/TextResourceDecoder.cpp:
  24476. (WebCore::TextResourceDecoder::TextResourceDecoder):
  24477. (WebCore::TextResourceDecoder::decode):
  24478. (WebCore::TextResourceDecoder::flush):
  24479. * loader/TextResourceDecoder.h:
  24480. (WebCore::TextResourceDecoder::useLenientXMLDecoding):
  24481. Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
  24482. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML
  24483. decoding errors. This behavior is now limited to other kinds of XML content.
  24484. 2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>
  24485. Bug 24382: request to add SH4 platform
  24486. <https://bugs.webkit.org/show_bug.cgi?id=24382>
  24487. Reviewed by David Kilzer.
  24488. * platform/text/AtomicString.cpp:
  24489. (WebCore::equal): Aligned memory access on SH4 platform.
  24490. 2009-03-05 Jeremy Moskovich <jeremy@chromium.org>
  24491. Reviewed by Simon Fraser.
  24492. Fix for https://bugs.webkit.org/show_bug.cgi?id=24215
  24493. Gears expects an object tag with display:none to instantiate the plugin,
  24494. so we add a workaround to make this work and fix Gears on WebKit trunk.
  24495. * html/HTMLObjectElement.cpp:
  24496. (WebCore::HTMLObjectElement::rendererIsNeeded):
  24497. 2009-03-05 Avi Drissman <avi@chromium.org>
  24498. Reviewed by Darin Fisher.
  24499. Need to have Chromium Mac match Safari Mac's accesskey handling
  24500. https://bugs.webkit.org/show_bug.cgi?id=24404
  24501. * page/chromium/EventHandlerChromium.cpp:
  24502. (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
  24503. 2009-03-05 Simon Fraser <simon.fraser@apple.com>
  24504. Reviewed by Dave Hyatt
  24505. https://bugs.webkit.org/show_bug.cgi?id=24412
  24506. Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
  24507. but no transform. We need to make localTransformState if we see preserve-3d.
  24508. Also need to call update3DTransformedDescendantStatus() before we test
  24509. m_has3DTransformedDescendant.
  24510. Test: transforms/3d/hit-testing/hit-preserves-3d.html
  24511. * rendering/RenderLayer.cpp:
  24512. (WebCore::RenderLayer::hitTestLayer):
  24513. 2009-03-05 Eric Seidel <eric@webkit.org>
  24514. Reviewed by David Hyatt.
  24515. Changes to RenderLayer destruction to hopefully help catch an elusive crasher
  24516. https://bugs.webkit.org/show_bug.cgi?id=24409
  24517. Added a new RenderBoxModelObject::destroyLayer() call which is
  24518. now the only way which RenderLayers should ever be destroyed.
  24519. This ensures that the pointer to the layer is cleared in the
  24520. RenderObject after destruction, allowing us to ASSERT in the
  24521. RenderBoxModelObject destructor.
  24522. * rendering/RenderBox.cpp:
  24523. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  24524. * rendering/RenderBoxModelObject.cpp:
  24525. (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
  24526. (WebCore::RenderBoxModelObject::destroyLayer):
  24527. (WebCore::RenderBoxModelObject::destroy):
  24528. (WebCore::RenderBoxModelObject::styleDidChange):
  24529. * rendering/RenderBoxModelObject.h:
  24530. * rendering/RenderLayer.cpp:
  24531. (WebCore::RenderLayer::stackingContext):
  24532. (WebCore::RenderLayer::destroy):
  24533. (WebCore::RenderLayer::removeOnlyThisLayer):
  24534. * rendering/RenderLayer.h:
  24535. * rendering/RenderObject.cpp:
  24536. (WebCore::RenderObject::destroy):
  24537. * rendering/RenderWidget.cpp:
  24538. (WebCore::RenderWidget::destroy):
  24539. 2009-03-05 Eric Seidel <eric@webkit.org>
  24540. Reviewed by David Hyatt.
  24541. Remove old, unused IE 5.5 scrollbar-* CSS properties.
  24542. Sort the unimplemented getComputedStyle properties so it's
  24543. easier to see which ones actually need implementation.
  24544. * css/CSSComputedStyleDeclaration.cpp:
  24545. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  24546. * css/CSSParser.cpp:
  24547. (WebCore::CSSParser::parseValue):
  24548. * css/CSSPropertyNames.in:
  24549. * css/CSSStyleSelector.cpp:
  24550. (WebCore::CSSStyleSelector::applyProperty):
  24551. 2009-03-05 Justin Garcia <justin.garcia@apple.com>
  24552. Reviewed by Darin Adler.
  24553. WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
  24554. within the document without changing its position in the DOM. For example, pressing return in (caret marked by ^):
  24555. <div contentEditable="true"><div>^Hello</div></div>
  24556. Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
  24557. for example).
  24558. Changes to layout tests demonstrate fix.
  24559. * editing/EditCommand.cpp:
  24560. (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand. The TypingCommand knows whether or
  24561. not it did work that needs to be applied.
  24562. * editing/Editor.cpp:
  24563. (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
  24564. (WebCore::Editor::unappliedEditing): Ditto.
  24565. (WebCore::Editor::reappliedEditing): Ditto.
  24566. (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here. Also call out to
  24567. EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
  24568. even if they did not change it's position in the DOM. Any TypingCommand that gets this far changed it's position
  24569. in the document.
  24570. * editing/Editor.h:
  24571. * editing/TypingCommand.cpp:
  24572. (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
  24573. (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing. We won't get this far if we don't need to.
  24574. (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
  24575. adding to the killring and responding to a change in selections if the delete was a no-op.
  24576. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  24577. * editing/TypingCommand.h:
  24578. 2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
  24579. Reviewed by Adam Roben.
  24580. Eliminate a ref-counting leak in InspectorController.
  24581. * inspector/InspectorController.h: Made constructor private, added static create method.
  24582. * page/Page.cpp:
  24583. (WebCore::Page::Page): Change initializer to use static create method.
  24584. 2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
  24585. Reviewed by Timothy Hatcher.
  24586. https://bugs.webkit.org/show_bug.cgi?id=24355
  24587. Add InspectorController.idl and convert InspectorController.cpp to use
  24588. JSC bindings.
  24589. * DerivedSources.make: Added InspectorController.idl
  24590. * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
  24591. * bindings/js/JSInspectorControllerCustom.cpp: Added.
  24592. * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
  24593. * inspector/InspectorController.cpp: Removed hand-rolled bindings.
  24594. * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
  24595. * inspector/InspectorController.idl: Added.
  24596. * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
  24597. 2009-03-05 Eric Carlson <eric.carlson@apple.com>
  24598. Reviewed by Simon Fraser.
  24599. https://bugs.webkit.org/show_bug.cgi?id=24400
  24600. Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
  24601. media element attributes
  24602. Test: media/video-loop.html
  24603. * html/HTMLMediaElement.cpp:
  24604. (WebCore::HTMLMediaElement::HTMLMediaElement):
  24605. (WebCore::HTMLMediaElement::loadInternal):
  24606. (WebCore::HTMLMediaElement::setNetworkState):
  24607. (WebCore::HTMLMediaElement::seek):
  24608. (WebCore::HTMLMediaElement::playInternal):
  24609. (WebCore::HTMLMediaElement::loop):
  24610. (WebCore::HTMLMediaElement::setLoop):
  24611. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
  24612. (WebCore::HTMLMediaElement::endedPlayback):
  24613. (WebCore::HTMLMediaElement::updatePlayState):
  24614. * html/HTMLMediaElement.h:
  24615. * html/HTMLMediaElement.idl:
  24616. 2009-03-05 Steve Falkenburg <sfalken@apple.com>
  24617. <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached
  24618. Reviewed by Ada Chan.
  24619. * platform/network/cf/ResourceHandleCFNet.cpp:
  24620. (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
  24621. 2009-03-05 David Hyatt <hyatt@apple.com>
  24622. Reviewed by Eric Seidel
  24623. https://bugs.webkit.org/show_bug.cgi?id=24248
  24624. Make sure painting of overflow controls checks that visibility:visible is set on the block before
  24625. painting. Pixel tests caught this regression.
  24626. Make sure resizer painting pushes a clip of the corner rect. It was relying on the clip layers happened
  24627. to do to their bounds (which had nothing to do with overflow).
  24628. * rendering/RenderBlock.cpp:
  24629. (WebCore::RenderBlock::paint):
  24630. * rendering/RenderLayer.cpp:
  24631. (WebCore::RenderLayer::paintResizer):
  24632. 2009-03-05 Yong Li <yong.li@torchmobile.com>
  24633. Reviewed by Simon Fraser.
  24634. https://bugs.webkit.org/show_bug.cgi?id=24386
  24635. A faster implementation of extractMIMETypeFromMediaType.
  24636. * platform/network/HTTPParsers.cpp:
  24637. (WebCore::extractMIMETypeFromMediaType):
  24638. 2009-03-05 Yong Li <yong.li@torchmobile.com>
  24639. Reviewed by Antti Koivisto.
  24640. https://bugs.webkit.org/show_bug.cgi?id=24392
  24641. Do not get the current time for unless we're doing PRELOAD_DEBUG as this
  24642. can be unnecessarily expensive.
  24643. * html/PreloadScanner.cpp:
  24644. (WebCore::PreloadScanner::write):
  24645. 2009-03-04 Simon Fraser <simon.fraser@apple.com>
  24646. Reviewed by Dave Hyatt
  24647. https://bugs.webkit.org/show_bug.cgi?id=24327
  24648. When mapping points and hit testing through transforms, work
  24649. correctly when acclerated animations of transforms are running.
  24650. Tested by LayoutTests/animations/animation-hit-test-transform.html,
  24651. which only failed when ACCELERATED_COMPOSITING was turned on.
  24652. * rendering/RenderLayer.cpp:
  24653. (WebCore::RenderLayer::currentTransform):
  24654. * rendering/RenderLayer.h:
  24655. * rendering/RenderObject.cpp:
  24656. (WebCore::RenderObject::transformFromContainer):
  24657. 2009-03-05 Mike Belshe <mike@belshe.com>
  24658. Reviewed by Darin Fisher.
  24659. https://bugs.webkit.org/show_bug.cgi?id=24391
  24660. Frame.cpp uses JSC specific includes
  24661. * page/Frame.cpp:
  24662. 2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
  24663. Reviewed by Alexey Proskuryakov.
  24664. https://bugs.webkit.org/show_bug.cgi?id=24389
  24665. WebKitGTK+ crashes when cancelling plugin loads
  24666. Remove bogus calls to the client's didFinishLoading method from
  24667. our ResourceHandle::cancel implementation. Calling
  24668. didFinishLoading here is mostly inoffensive for most loads, but
  24669. causes crashes when plugin loads are cancelled.
  24670. * platform/network/soup/ResourceHandleSoup.cpp:
  24671. (WebCore::ResourceHandle::cancel):
  24672. 2009-03-05 Steve Falkenburg <sfalken@apple.com>
  24673. Windows build fix.
  24674. * WebCore.vcproj/QTMovieWin.vcproj:
  24675. 2009-03-05 Adam Treat <adam.treat@torchmobile.com>
  24676. Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method
  24677. ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
  24678. protected by an #if and uses HTMLPlugInElement so it must be included.
  24679. * bindings/js/ScriptController.cpp:
  24680. 2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
  24681. GTK Build fix.
  24682. * inspector/ConsoleMessage.h: Use proper header.
  24683. 2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
  24684. Reviewed by Timothy Hatcher.
  24685. https://bugs.webkit.org/show_bug.cgi?id=24376
  24686. Split InspectorController.cpp file into separate classes.
  24687. * GNUmakefile.am: Modified to include new files.
  24688. * WebCore.pro: Ditto.
  24689. * WebCore.scons: Ditto.
  24690. * WebCore.vcproj/WebCore.vcproj: Ditto.
  24691. * WebCore.xcodeproj/project.pbxproj: Ditto.
  24692. * WebCoreSources.bkl: Ditto.
  24693. * inspector/ConsoleMessage.cpp: Added.
  24694. * inspector/ConsoleMessage.h: Added.
  24695. * inspector/InspectorController.cpp:
  24696. * inspector/InspectorDOMStorageResource.cpp: Added.
  24697. * inspector/InspectorDOMStorageResource.h: Added.
  24698. * inspector/InspectorDatabaseResource.cpp: Added.
  24699. * inspector/InspectorDatabaseResource.h: Added.
  24700. * inspector/InspectorResource.cpp: Added.
  24701. * inspector/InspectorResource.h: Added.
  24702. 2009-03-05 Eric Carlson <eric.carlson@apple.com>
  24703. Reviewed by Darin Adler
  24704. https://bugs.webkit.org/show_bug.cgi?id=24387
  24705. Remove media element bufferingRate attribute. No test necessary as there
  24706. were none for this attribute.
  24707. * html/HTMLMediaElement.cpp:
  24708. (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate.
  24709. (WebCore::HTMLMediaElement::loadInternal): Ditto.
  24710. (WebCore::HTMLMediaElement::setNetworkState): Ditto.
  24711. (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
  24712. * html/HTMLMediaElement.h: Remove m_bufferingRate.
  24713. * html/HTMLMediaElement.idl: Ditto.
  24714. 2009-03-05 Xan Lopez <xan@gnome.org>
  24715. Reviewed by Mark Rowe.
  24716. https://bugs.webkit.org/show_bug.cgi?id=24377
  24717. [GTK] Comply better with coding style guidelines in ResourceHandleSoup
  24718. Use C++ booleans, 0 instead of NULL, prefix boolean variables with
  24719. 'is', do not use 'else if' if the previous if had a return, delete
  24720. trailing whitespace, etc.
  24721. * platform/network/ResourceHandleInternal.h:
  24722. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  24723. * platform/network/soup/ResourceHandleSoup.cpp:
  24724. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  24725. (WebCore::fillResponseFromMessage):
  24726. (WebCore::restartedCallback):
  24727. (WebCore::finishedCallback):
  24728. (WebCore::parseDataUrl):
  24729. (WebCore::ensureSessionIsInitialized):
  24730. (WebCore::ResourceHandle::startHttp):
  24731. (WebCore::reportUnknownProtocolError):
  24732. (WebCore::ResourceHandle::start):
  24733. (WebCore::cleanupGioOperation):
  24734. (WebCore::closeCallback):
  24735. (WebCore::readCallback):
  24736. (WebCore::openCallback):
  24737. (WebCore::queryInfoCallback):
  24738. (WebCore::ResourceHandle::startGio):
  24739. 2009-03-04 Simon Fraser <simon.fraser@apple.com>
  24740. Reviewed by Eric Seidel
  24741. https://bugs.webkit.org/show_bug.cgi?id=24328
  24742. If an element has backface-visibility: hidden, hit testing should not
  24743. hit the back sides of elements. Test for that by inverting the accumulated
  24744. transform and looking at the z vector.
  24745. Tested by transforms/3d/hit-testing/backface-hit-test.html
  24746. * rendering/RenderLayer.cpp:
  24747. (WebCore::RenderLayer::hitTestLayer):
  24748. 2009-03-04 Adam Langley <agl@google.com>
  24749. Reviewed by Darin Fisher.
  24750. r41362 mistakenly added functions "RenderThemeWin::" into
  24751. RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
  24752. them to void return types. This patch switches them back to ints.
  24753. https://bugs.webkit.org/show_bug.cgi?id=24360
  24754. * rendering/RenderThemeChromiumLinux.cpp:
  24755. (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
  24756. (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
  24757. (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
  24758. (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
  24759. 2009-03-04 Adam Langley <agl@google.com>
  24760. Reviewed by Darin Fisher.
  24761. Chromium Linux: change some metrics to better match Windows after
  24762. r41416. Aesthetically this may be worse, but web-compat is king.
  24763. Also, the previous code had an off by one error when drawing
  24764. scrollbars which caused the scrollbar to overflow it's bounds by 1px
  24765. at the right and bottom edges.
  24766. https://bugs.webkit.org/show_bug.cgi?id=24369
  24767. * rendering/RenderThemeChromiumLinux.cpp:
  24768. (WebCore::):
  24769. (WebCore::RenderThemeChromiumLinux::systemFont):
  24770. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  24771. (WebCore::ScrollbarThemeChromium::paintTrackPiece):
  24772. 2009-03-04 Eric Seidel <eric@webkit.org>
  24773. Reviewed by Adam Roben.
  24774. Add an ASSERT to better demonstrate the cause of the crash in
  24775. https://bugs.webkit.org/show_bug.cgi?id=23736
  24776. * loader/DocLoader.cpp:
  24777. (WebCore::DocLoader::~DocLoader):
  24778. 2009-03-04 David Levin <levin@chromium.org>
  24779. Reviewed by Alexey Proskuryakov.
  24780. Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
  24781. <https://bugs.webkit.org/show_bug.cgi?id=24337>
  24782. Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
  24783. http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
  24784. * loader/mac/ResourceLoaderMac.mm:
  24785. (WebCore::ResourceLoader::willCacheResponse):
  24786. An identifier is only asssigned if resource load callbacks are done. So don't send
  24787. willCacheResponse which uses identifier if resource load callbacks aren't being sent.
  24788. 2009-03-04 David Levin <levin@chromium.org>
  24789. Reviewed by Alexey Proskuryakov.
  24790. Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
  24791. <https://bugs.webkit.org/show_bug.cgi?id=24330>
  24792. Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
  24793. * dom/ExceptionCode.cpp:
  24794. (WebCore::xmlHttpRequestExceptionNames):
  24795. Added missing ABORT_ERR whose absence caused an assert.
  24796. * loader/WorkerThreadableLoader.cpp:
  24797. (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
  24798. (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
  24799. Add more logic to handle the termination case for sync xhr.
  24800. 2009-03-04 Eric Carlson <eric.carlson@apple.com>
  24801. Reviewed by Antti Koivisto.
  24802. https://bugs.webkit.org/show_bug.cgi?id=24364
  24803. Add support for HTMLMediaElement canPlayType method. Make
  24804. MediaPlayer::supportsType take a ContentType instead of a
  24805. separate mime type and codecs parameter.
  24806. Test: media/video-can-play-type.html
  24807. * dom/DOMImplementation.cpp:
  24808. (WebCore::DOMImplementation::createDocument):
  24809. * html/HTMLMediaElement.cpp:
  24810. (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
  24811. (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
  24812. (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
  24813. (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
  24814. * html/HTMLMediaElement.h: Add prototype.
  24815. * html/HTMLMediaElement.idl: Ditto.
  24816. * platform/graphics/MediaPlayer.cpp:
  24817. (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
  24818. (WebCore::MediaPlayer::supportsType): Ditto.
  24819. * platform/graphics/MediaPlayer.h:
  24820. 2009-03-04 Antti Koivisto <antti@apple.com>
  24821. Reviewed by Dave Hyatt.
  24822. https://bugs.webkit.org/show_bug.cgi?id=24359
  24823. Repaint throttling mechanism
  24824. Excessive repainting can slow down page loadind. This implements a timer
  24825. based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
  24826. enabled by default.
  24827. * loader/FrameLoader.cpp:
  24828. (WebCore::FrameLoader::checkCompleted):
  24829. * page/EventHandler.cpp:
  24830. (WebCore::EventHandler::dispatchDragEvent):
  24831. (WebCore::EventHandler::dispatchMouseEvent):
  24832. (WebCore::EventHandler::keyEvent):
  24833. (WebCore::EventHandler::handleTextInputEvent):
  24834. * page/FrameView.cpp:
  24835. (WebCore::FrameView::FrameView):
  24836. (WebCore::FrameView::reset):
  24837. (WebCore::FrameView::repaintContentRectangle):
  24838. (WebCore::FrameView::beginDeferredRepaints):
  24839. (WebCore::FrameView::endDeferredRepaints):
  24840. (WebCore::FrameView::checkStopDelayingDeferredRepaints):
  24841. (WebCore::FrameView::doDeferredRepaints):
  24842. (WebCore::FrameView::updateDeferredRepaintDelay):
  24843. (WebCore::FrameView::resetDeferredRepaintDelay):
  24844. (WebCore::FrameView::adjustedDeferredRepaintDelay):
  24845. (WebCore::FrameView::deferredRepaintTimerFired):
  24846. (WebCore::FrameView::paintContents):
  24847. * page/FrameView.h:
  24848. 2009-03-04 Sam Weinig <sam@webkit.org>
  24849. Rubber-stamped by Antti Koivisto.
  24850. Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
  24851. * dom/Document.cpp:
  24852. (WebCore::Document::Document):
  24853. * dom/Document.h:
  24854. (WebCore::Document::haveStylesheetsLoaded):
  24855. * html/HTMLTokenizer.cpp:
  24856. (WebCore::HTMLTokenizer::scriptHandler):
  24857. * loader/Cache.cpp:
  24858. (WebCore::Cache::requestResource):
  24859. * loader/CachedCSSStyleSheet.cpp:
  24860. (WebCore::CachedCSSStyleSheet::checkNotify):
  24861. * loader/DocLoader.h:
  24862. * loader/FrameLoader.cpp:
  24863. (WebCore::FrameLoader::FrameLoader):
  24864. (WebCore::FrameLoader::requestFrame):
  24865. (WebCore::FrameLoader::stopLoading):
  24866. (WebCore::FrameLoader::begin):
  24867. (WebCore::FrameLoader::write):
  24868. (WebCore::FrameLoader::endIfNotLoadingMainResource):
  24869. (WebCore::FrameLoader::checkCompleted):
  24870. (WebCore::FrameLoader::requestObject):
  24871. (WebCore::FrameLoader::loadItem):
  24872. * loader/FrameLoader.h:
  24873. 2009-03-02 Xan Lopez <xan@gnome.org>
  24874. Reviewed by Mark Rowe.
  24875. https://bugs.webkit.org/show_bug.cgi?id=24287
  24876. [GTK] Move auth dialog feature to WebKit/
  24877. Remove WebKitSoupAuthDialog files from build and stop using it.
  24878. * GNUmakefile.am:
  24879. * platform/network/soup/ResourceHandleSoup.cpp:
  24880. (WebCore::ensureSessionIsInitialized):
  24881. * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
  24882. * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
  24883. 2009-03-04 Simon Fraser <simon.fraser@apple.com>
  24884. Reviewed by Dave Hyatt
  24885. https://bugs.webkit.org/show_bug.cgi?id=24361
  24886. Reinstate code that sets result.innerNode when hitTest() returns true,
  24887. but never filled in the innerNode. Fixes hit testing of generated content.
  24888. Test: fast/css-generated-content/hit-test-generated-content.html
  24889. * rendering/RenderLayer.cpp:
  24890. (WebCore::RenderLayer::hitTestContents):
  24891. 2009-03-04 Adam Barth <abath@webkit.org>
  24892. Reviewed by Alexey Proskuryakov.
  24893. https://bugs.webkit.org/show_bug.cgi?id=24356
  24894. Fix WebKit style for allowUniversalAccessFromFileURLs.
  24895. * WebCore.base.exp:
  24896. * dom/Document.cpp:
  24897. (WebCore::Document::initSecurityContext):
  24898. * page/Settings.cpp:
  24899. (WebCore::Settings::Settings):
  24900. (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
  24901. * page/Settings.h:
  24902. (WebCore::Settings::allowUniversalAccessFromFileURLs):
  24903. 2009-03-04 Brady Eidson <beidson@apple.com>
  24904. Reviewed by Darin Adler
  24905. <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
  24906. I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
  24907. consolidated some of the various decision making pieces of the Cache into the new method
  24908. FrameLoader::cachePolicy().
  24909. Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
  24910. is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
  24911. same URL for this image every time and expects it to be reloaded with each new card.
  24912. The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
  24913. is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.
  24914. * loader/FrameLoader.cpp:
  24915. (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
  24916. condition for returning CachePolicyReload.
  24917. 2009-03-04 Timothy Hatcher <timothy@apple.com>
  24918. * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
  24919. "LOCAL STORAGE" and "SESSION STORAGE".
  24920. 2009-03-04 Timothy Hatcher <timothy@apple.com>
  24921. Fix a regression where the Web Inspector console would not animate
  24922. in or out correctly.
  24923. Reviewed by Anders Carlsson.
  24924. * inspector/front-end/inspector.css: Move a z-index to a child element
  24925. to get the correct stacking order during the animation.
  24926. 2009-03-03 David Hyatt <hyatt@apple.com>
  24927. https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
  24928. Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
  24929. the final position against the y position estimate until after the clear has happened. This gets rid
  24930. of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
  24931. Reviewed by Dan Bernstein
  24932. Added fast/block/float/nested-clearance.html
  24933. * rendering/RenderBlock.cpp:
  24934. (WebCore::RenderBlock::collapseMargins):
  24935. (WebCore::RenderBlock::clearFloatsIfNeeded):
  24936. (WebCore::RenderBlock::estimateVerticalPosition):
  24937. (WebCore::RenderBlock::layoutBlockChildren):
  24938. (WebCore::RenderBlock::getClearDelta):
  24939. * rendering/RenderBlock.h:
  24940. 2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
  24941. Reviewed by Simon Hausmann.
  24942. Improvement to 3d transformations rendering in QtWebKit. QTransform is used
  24943. instead of QMatrix. This allows perspective transformations since QTransform is
  24944. a true 3x3 matrix.
  24945. * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
  24946. (WebCore::GraphicsContext::getCTM):
  24947. (WebCore::GraphicsContext::restorePlatformState):
  24948. (WebCore::GraphicsContext::fillPath):
  24949. (WebCore::GraphicsContext::strokePath):
  24950. (WebCore::GraphicsContext::fillRect):
  24951. (WebCore::GraphicsContext::translate):
  24952. (WebCore::GraphicsContext::rotate):
  24953. (WebCore::GraphicsContext::scale):
  24954. (WebCore::GraphicsContext::concatCTM):
  24955. * platform/graphics/qt/ImageQt.cpp:
  24956. (WebCore::Image::drawPattern):
  24957. * platform/graphics/qt/PathQt.cpp:
  24958. (WebCore::Path::translate):
  24959. (WebCore::Path::transform):
  24960. * platform/graphics/qt/PatternQt.cpp:
  24961. (WebCore::Pattern::createPlatformPattern):
  24962. * platform/graphics/qt/TransformationMatrixQt.cpp:
  24963. (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
  24964. to QMatrix with one to QTransform.
  24965. * platform/graphics/transforms/TransformationMatrix.h:
  24966. * platform/graphics/qt/FontQt.cpp:
  24967. 2009-02-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  24968. Reviewed by Simon Hausmann.
  24969. https://bugs.webkit.org/show_bug.cgi?id=24151
  24970. Fix Qt/S60 build break
  24971. * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
  24972. * platform/qt/FileSystemQt.cpp: Ditto
  24973. (WebCore::unloadModule):
  24974. 2009-03-03 Mike Belshe <mike@belshe.com>
  24975. Reviewed by Alexey Proskuryakov.
  24976. https://bugs.webkit.org/show_bug.cgi?id=21939
  24977. Uninitialized ExceptionCode in DOMWindow::postMessage
  24978. * dom/MessagePort.cpp:
  24979. (WebCore::MessagePort::postMessage):
  24980. 2009-03-03 David Kilzer <ddkilzer@apple.com>
  24981. <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
  24982. Reviewed by Mark Rowe.
  24983. The fix is to add INSTALLHDRS_COPY_PHASE = YES and
  24984. INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
  24985. sure various build phase scripts work with the installhdrs build
  24986. phase.
  24987. * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
  24988. based on PLATFORM_NAME to work around the missing definition on
  24989. Tiger.
  24990. * Configurations/WebCore.xcconfig: Added
  24991. JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
  24992. the "Generate Derived Sources" script. Added
  24993. INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
  24994. * WebCore.xcodeproj/project.pbxproj:
  24995. - Added shell code to prevent running "Check For Global
  24996. Initializers", "Check For Exit Time Destructors" and "Check
  24997. For Weak VTables" scripts during the installhdrs build phase.
  24998. - Made "Generate Derived Sources" work for the installhdrs build
  24999. phase. Also simplified setting of CREATE_HASH_TABLE by using
  25000. JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
  25001. 2009-03-02 Adam Langley <agl@google.com>
  25002. Reviewed by Darin Fisher.
  25003. Chromium Linux: Switch to using Skia to render widgets.
  25004. In order to sandbox the Chromium renderer on Linux we need to remove
  25005. the X connection. GTK cannot render without an X connection so, for
  25006. now, we render widgets ourselves.
  25007. Previously didn't use anti-alias fonts in order to match Windows font
  25008. rendering exactly. This was helpful when bootstrapping our layout
  25009. tests. Now, however, we are ready to enable it.
  25010. https://bugs.webkit.org/show_bug.cgi?id=24244
  25011. * platform/chromium/ScrollbarThemeChromium.cpp:
  25012. (WebCore::ScrollbarThemeChromium::buttonSize):
  25013. * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  25014. (WebCore::ScrollbarThemeChromium::scrollbarThickness):
  25015. (WebCore::ScrollbarThemeChromium::paintTrackPiece):
  25016. (WebCore::ScrollbarThemeChromium::paintButton):
  25017. (WebCore::ScrollbarThemeChromium::paintThumb):
  25018. * platform/graphics/chromium/FontPlatformDataLinux.cpp:
  25019. (WebCore::FontPlatformData::setupPaint):
  25020. * platform/graphics/skia/PlatformContextSkia.cpp:
  25021. (PlatformContextSkia::PlatformContextSkia):
  25022. (PlatformContextSkia::~PlatformContextSkia):
  25023. * platform/graphics/skia/PlatformContextSkia.h:
  25024. * rendering/RenderThemeChromiumGtk.cpp: Removed.
  25025. * rendering/RenderThemeChromiumGtk.h: Removed.
  25026. * rendering/RenderThemeChromiumLinux.cpp: Added.
  25027. * rendering/RenderThemeChromiumLinux.h: Added.
  25028. 2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  25029. Reviewed by Darin Fisher.
  25030. https://bugs.webkit.org/show_bug.cgi?id=24261
  25031. Fix return types.
  25032. Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
  25033. * bindings/v8/V8Binding.h:
  25034. (WebCore::toInt32): change return type to int
  25035. (WebCore::toFloat): change return type to float.
  25036. 2009-03-03 Anders Carlsson <andersca@apple.com>
  25037. Reviewed by John Sullivan.
  25038. https://bugs.webkit.org/show_bug.cgi?id=22884
  25039. <rdar://problem/6449783>
  25040. modified layout test crashes Safari
  25041. Null check NPStream before dereferencing it.
  25042. * plugins/PluginView.cpp:
  25043. (WebCore::PluginView::destroyStream):
  25044. 2009-03-03 Eric Carlson <eric.carlson@apple.com>
  25045. Reviewed by Simon Fraser.
  25046. Fix for <rdar://problem/6641045>
  25047. Don't call QTKit to get movie properties until movie metadata has been loaded.
  25048. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  25049. (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
  25050. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  25051. (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
  25052. (WebCore::MediaPlayerPrivate::play): Ditto.
  25053. (WebCore::MediaPlayerPrivate::pause): Ditto.
  25054. (WebCore::MediaPlayerPrivate::duration): Ditto.
  25055. (WebCore::MediaPlayerPrivate::currentTime): Ditto.
  25056. (WebCore::MediaPlayerPrivate::seek): Ditto.
  25057. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
  25058. (WebCore::MediaPlayerPrivate::paused): Ditto.
  25059. (WebCore::MediaPlayerPrivate::seeking): Ditto.
  25060. (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
  25061. (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
  25062. (WebCore::MediaPlayerPrivate::setVolume): Ditto.
  25063. (WebCore::MediaPlayerPrivate::setRate): Ditto.
  25064. (WebCore::MediaPlayerPrivate::dataRate): Ditto.
  25065. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
  25066. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
  25067. 2009-03-03 Kevin McCullough <kmccullough@apple.com>
  25068. - Spelling fix.
  25069. * page/Console.cpp:
  25070. (WebCore::Console::profile):
  25071. 2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  25072. Reviewed by Darin Fisher.
  25073. https://bugs.webkit.org/show_bug.cgi?id=23657
  25074. Remove Database API callback IDLs from the project.
  25075. They were removed in r40633.
  25076. * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
  25077. 2009-03-03 Kevin McCullough <kmccullough@apple.com>
  25078. Reviewed by Oliver Hunt.
  25079. <rdar://problem/6639110> console.profile() doesn't work without a title
  25080. * page/Console.cpp:
  25081. (WebCore::Console::profile): If there is no title assume this is a user
  25082. initiated profile and give it the next incremented title name.
  25083. 2009-03-03 Timothy Hatcher <timothy@apple.com>
  25084. Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
  25085. the console code and refactored things to have fewer code paths and duplication.
  25086. rdar://problem/6367127
  25087. https://bugs.webkit.org/show_bug.cgi?id=24329
  25088. Reviewed by Kevin McCullough.
  25089. Test: manual-tests/inspector/console-dir.html
  25090. * bindings/js/JSInspectedObjectWrapper.cpp:
  25091. (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
  25092. to fix an ASSERT about using a wrapper from the wrong ExecState.
  25093. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  25094. (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
  25095. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
  25096. * inspector/front-end/Console.js:
  25097. (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
  25098. When forceObjectFormat is true, the only formatter used is _formatobject.
  25099. (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
  25100. (WebInspector.Console.prototype._formatstring): Ditto.
  25101. (WebInspector.Console.prototype._formatregexp): Ditto.
  25102. (WebInspector.Console.prototype._formatarray): Ditto.
  25103. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
  25104. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
  25105. (WebInspector.Console.prototype._formaterror): Remove the inline argument.
  25106. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
  25107. simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
  25108. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
  25109. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
  25110. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
  25111. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
  25112. * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
  25113. * inspector/front-end/utilities.js:
  25114. (Object.type): Return "node" for Node objects.
  25115. (Object.describe): Handle the "node" type.
  25116. * page/Console.cpp:
  25117. (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
  25118. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
  25119. * page/Console.h:
  25120. (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
  25121. 2009-03-03 Scott Violet <sky@google.com>
  25122. Reviewed by Eric Seidel.
  25123. https://bugs.webkit.org/show_bug.cgi?id=24325
  25124. Crash on replacing document contents during drop.
  25125. Makes sure a node is in the document during a move before using it.
  25126. Test: fast/events/crash-on-mutate-during-drop.html
  25127. * editing/MoveSelectionCommand.cpp:
  25128. (WebCore::MoveSelectionCommand::doApply):
  25129. 2009-03-03 Jungshik Shin <jshin@chromium.org>
  25130. Reviewed by Eric Seidel.
  25131. https://bugs.webkit.org/show_bug.cgi?id=23028
  25132. Enable dynamic web font support to Chromium on Windows.
  25133. Files that were omitted by mistake in the latest patch
  25134. that was landed.
  25135. * loader/CachedFont.cpp:
  25136. (WebCore::CachedFont::~CachedFont):
  25137. (WebCore::CachedFont::ensureCustomFontData):
  25138. (WebCore::CachedFont::platformDataFromCustomData):
  25139. (WebCore::CachedFont::allClientsRemoved):
  25140. * platform/graphics/chromium/FontCustomPlatformData.cpp:
  25141. (WebCore::EOTStream::EOTStream):
  25142. (WebCore::createFontCustomPlatformData):
  25143. * platform/graphics/win/FontCustomPlatformData.cpp:
  25144. (WebCore::EOTStream::EOTStream):
  25145. (WebCore::createFontCustomPlatformData):
  25146. 2009-03-03 Gustavo Noronha Silva <gns@gnome.org>
  25147. Reviewed by Alexey Proskuryakov.
  25148. https://bugs.webkit.org/show_bug.cgi?id=16826
  25149. [Gtk] Implement WebKitDownload
  25150. Make the Soup backend able to handle requests without a frame,
  25151. since we may have such things now that we support downloads.
  25152. * platform/network/ResourceHandleInternal.h:
  25153. * platform/network/soup/ResourceHandleSoup.cpp:
  25154. (WebCore::ResourceHandle::start):
  25155. 2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  25156. Reviewed by Eric Seidel.
  25157. https://bugs.webkit.org/show_bug.cgi?id=24331
  25158. Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
  25159. * bindings/v8/custom/V8AttrCustom.cpp: Added.
  25160. * bindings/v8/custom/V8CustomBinding.cpp: Added.
  25161. * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
  25162. * bindings/v8/custom/V8ElementCustom.cpp: Added.
  25163. * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
  25164. * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
  25165. 2009-03-03 Brady Eidson <beidson@apple.com>
  25166. Reviewed by Darin Adler
  25167. <rdar://problem/6616664> - Quick looks of various file types is broken
  25168. In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
  25169. for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
  25170. overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
  25171. Partially reverted behavior to always set the mainDocumentURL in situations when we would've
  25172. before that patch.
  25173. * loader/FrameLoader.cpp:
  25174. (WebCore::FrameLoader::addExtraFieldsToRequest):
  25175. * platform/network/ResourceRequestBase.cpp:
  25176. (WebCore::ResourceRequestBase::setMainDocumentURL):
  25177. 2009-03-03 Chris Marrin <cmarrin@apple.com>
  25178. Reviewed by Simon Fraser.
  25179. https://bugs.webkit.org/show_bug.cgi?id=24256
  25180. Added a WebCoreForceSoftwareAnimation flag.
  25181. * platform/graphics/mac/GraphicsLayerCA.mm:
  25182. (WebCore::forceSoftwareAnimation):
  25183. (WebCore::GraphicsLayerCA::setOpacity):
  25184. (WebCore::GraphicsLayerCA::animateTransform):
  25185. (WebCore::GraphicsLayerCA::animateFloat):
  25186. 2009-03-02 Chris Marrin <cmarrin@apple.com>
  25187. Reviewed by Sam Weinig.
  25188. https://bugs.webkit.org/show_bug.cgi?id=24257
  25189. Added prototype properties for several classes with constructors that
  25190. were missing them, including the one mentioned in the bug.
  25191. Test: fast/dom/Window/custom-constructors.html
  25192. * bindings/js/JSAudioConstructor.cpp:
  25193. (WebCore::JSAudioConstructor::JSAudioConstructor):
  25194. * bindings/js/JSDOMWindowBase.cpp:
  25195. (jsDOMWindowBaseWebKitCSSMatrix):
  25196. * bindings/js/JSImageConstructor.cpp:
  25197. (WebCore::JSImageConstructor::JSImageConstructor):
  25198. * bindings/js/JSOptionConstructor.cpp:
  25199. (WebCore::JSOptionConstructor::JSOptionConstructor):
  25200. * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
  25201. (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  25202. * bindings/js/JSWebKitCSSMatrixConstructor.h:
  25203. * bindings/js/JSWebKitPointConstructor.cpp:
  25204. (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  25205. * bindings/js/JSWorkerConstructor.cpp:
  25206. (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  25207. 2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
  25208. Reviewed by Darin Fisher.
  25209. https://bugs.webkit.org/show_bug.cgi?id=24321
  25210. Add V8 bindings headers.
  25211. * bindings/v8/V8Binding.h: Added.
  25212. * bindings/v8/V8Proxy.h: Added.
  25213. * bindings/v8/custom/V8CustomBinding.h: Added.
  25214. * bindings/v8/custom/V8CustomEventListener.h: Added.
  25215. 2009-03-03 Jungshik Shin <jshin@chromium.org>
  25216. Reviewed by Eric Seidel.
  25217. https://bugs.webkit.org/show_bug.cgi?id=23803
  25218. Fix an 'off-by-1' error in ChromiumWin's font fallback.
  25219. * platform/graphics/chromium/FontCacheChromiumWin.cpp:
  25220. (WebCore::FontCache::getFontDataForCharacters):
  25221. 2009-03-03 Jungshik Shin <jshin@chromium.org>
  25222. Reviewed by Eric Seidel.
  25223. http://bugs.webkit.org/show_bug.cgi?id=23028
  25224. Enable dynamic web font support to Chromium on Windows: Part 1
  25225. - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
  25226. from platform/graphics/win because both Windows port and Chromium Windows
  25227. port will use them.
  25228. - Adjust WebCore.vcproj accordingly.
  25229. * WebCore.vcproj/WebCore.vcproj:
  25230. * platform/graphics/opentype: Added.
  25231. * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
  25232. * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
  25233. * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
  25234. * platform/graphics/win/OpenTypeUtilities.h: Removed.
  25235. 2009-03-03 Simon Fraser <simon.fraser@apple.com>
  25236. Reviewed by Dave Hyatt
  25237. https://bugs.webkit.org/show_bug.cgi?id=24312
  25238. Take 3D transforms into account when hit testing:
  25239. 1. Maintain a bit on each RenderLayer that is set when the layer
  25240. has 3d descendants, so that we know when to fall into the slow
  25241. hit testing path.
  25242. 2. Make a ref-counted HitTestingTransformState, which is used to store
  25243. an accumulated transform, and the hit test point, and hitTestRect
  25244. in the plane of the ancestor non-3d ('flattening') layer.
  25245. It's ref-counted so we can heap allocate it (to avoid stack bloat),
  25246. and avoid copying when hitTestLayer calls itself after applying the transform.
  25247. 3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
  25248. 3D transforms, or to do deep depth-testing when traversing a preserves-3d
  25249. hierarchy. When hit, layers compute a z-offset from the ancestor flattening
  25250. layer, which allows for correct depth testing.
  25251. The existing early-return codepath is unaffected when there are no 3d transforms
  25252. and no preserve-3d.
  25253. * rendering/RenderLayer.cpp:
  25254. (WebCore::RenderLayer::RenderLayer):
  25255. (WebCore::RenderLayer::updateTransform):
  25256. (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
  25257. (WebCore::RenderLayer::update3DTransformedDescendantStatus):
  25258. (WebCore::RenderLayer::hitTest):
  25259. (WebCore::computeZOffset):
  25260. (WebCore::RenderLayer::createLocalTransformState):
  25261. (WebCore::RenderLayer::hitTestLayer):
  25262. (WebCore::RenderLayer::hitTestContents):
  25263. * rendering/RenderLayer.h:
  25264. (WebCore::RenderLayer::preserves3D):
  25265. (WebCore::RenderLayer::has3DTransform):
  25266. (WebCore::RenderLayer::setHas3DTransformedDescendant):
  25267. (WebCore::RenderLayer::has3DTransformedDescendant):
  25268. * rendering/RenderLayerBacking.cpp:
  25269. * rendering/TransformState.cpp:
  25270. (WebCore::TransformState::flatten):
  25271. (WebCore::TransformState::mappedPoint):
  25272. (WebCore::HitTestingTransformState::move):
  25273. (WebCore::HitTestingTransformState::applyTransform):
  25274. (WebCore::HitTestingTransformState::flatten):
  25275. (WebCore::HitTestingTransformState::mappedPoint):
  25276. (WebCore::HitTestingTransformState::mappedQuad):
  25277. * rendering/TransformState.h:
  25278. (WebCore::TransformState::TransformState):
  25279. (WebCore::HitTestingTransformState::create):
  25280. (WebCore::HitTestingTransformState::move):
  25281. (WebCore::HitTestingTransformState::HitTestingTransformState):
  25282. 2009-03-03 Brett Wilson <brettw@chromium.org>
  25283. Fix uninitialized memory reads in the Chromium Windows transparency
  25284. code that were identified by Purify,
  25285. Reviewed by Darin Fisher.
  25286. * platform/graphics/chromium/TransparencyWin.cpp:
  25287. (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
  25288. (WebCore::TransparencyWin::initializeNewContext):
  25289. 2009-03-03 Simon Fraser <simon.fraser@apple.com>
  25290. Reviewed by Dave Hyatt
  25291. https://bugs.webkit.org/show_bug.cgi?id=24312
  25292. Factor the code that compute a transform relative to the container
  25293. into RenderObject::transformFromContainer().
  25294. * rendering/RenderBox.cpp:
  25295. (WebCore::RenderBox::mapLocalToAbsolutePoint):
  25296. (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  25297. * rendering/RenderObject.cpp:
  25298. (WebCore::RenderObject::transformFromContainer):
  25299. * rendering/RenderObject.h:
  25300. 2009-03-03 Simon Fraser <simon.fraser@apple.com>
  25301. Reviewed by Dave Hyatt
  25302. https://bugs.webkit.org/show_bug.cgi?id=24317
  25303. Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
  25304. the superclass found a node, otherwise we set the innerNode of the
  25305. HitTestResult, but don't actually report that we found a hit.
  25306. * rendering/RenderTextControlMultiLine.cpp:
  25307. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  25308. 2009-03-03 Onne Gorter <onne.gorter@avinity.net>
  25309. Reviewed by Anders Carlsson.
  25310. https://bugs.webkit.org/show_bug.cgi?id=23707
  25311. resizing plugins does not work, because the plugin never gets informed
  25312. Make gtk plugins resize correctly, by sending them the setwindow event
  25313. correctly. Also ensure that all plugin eventing is done with correct
  25314. locking/calling. Mostly copied from mac implementation.
  25315. manual test: manual-tests/gtk/plugin-resize-scroll.html
  25316. * plugins/PluginView.h:
  25317. * plugins/gtk/PluginViewGtk.cpp:
  25318. (WebCore::PluginView::dispatchNPEvent):
  25319. ensure locking/calling for NPEvents
  25320. (WebCore::PluginView::updatePluginWidget):
  25321. if something changed, let setNPWindowIfNeeded handle it
  25322. (WebCore::PluginView::paint):
  25323. (WebCore::PluginView::handleKeyboardEvent):
  25324. (WebCore::PluginView::handleMouseEvent):
  25325. ensure calling conventions
  25326. (WebCore::PluginView::setNPWindowRect):
  25327. just pass control to setNPWindowIfNeeded
  25328. (WebCore::PluginView::setNPWindowIfNeeded):
  25329. event the plugin correctly of new window
  25330. (WebCore::PluginView::init):
  25331. init through the new setup
  25332. 2009-03-03 Mike Belshe <mike@belshe.com>
  25333. Reviewed by Darin Fisher.
  25334. https://bugs.webkit.org/show_bug.cgi?id=24311
  25335. Make IDL returning DOMObject use [V8Custom]
  25336. * dom/Document.idl:
  25337. * html/HTMLCanvasElement.idl:
  25338. 2009-03-02 Simon Fraser <simon.fraser@apple.com>
  25339. Reviewed by Adele Peterson
  25340. https://bugs.webkit.org/show_bug.cgi?id=24313
  25341. If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
  25342. HitTestResult, then it had better well return |true|. And m_innerBlock
  25343. could never have been set as the hit node by the superclass, because
  25344. the superclass knows nothing about m_innerBlock.
  25345. Test: fast/forms/input-hit-test-border.html
  25346. * rendering/RenderTextControlSingleLine.cpp:
  25347. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  25348. 2009-03-02 Sam Weinig <sam@webkit.org>
  25349. Reviewed by Mark Rowe.
  25350. Enable Geolocation (except on Tiger and Leopard).
  25351. * Configurations/WebCore.xcconfig:
  25352. 2009-03-02 Ojan Vafai <ojan@chromium.org>
  25353. Reviewed by Adele Peterson.
  25354. Fix https://bugs.webkit.org/show_bug.cgi?id=24307
  25355. Null out m_highlightedNode on hideHighlight().
  25356. Ran WebCore/manual-tests/inspector/highlight-nodes.html.
  25357. * inspector/InspectorController.cpp:
  25358. (WebCore::InspectorController::hideHighlight):
  25359. 2009-03-02 Sam Weinig <sam@webkit.org>
  25360. Reviewed by Geoffrey Garen.
  25361. Fix for <rdar://problem/6507404> Add Geolocation support.
  25362. This is not yet turned on for any Mac platform.
  25363. * WebCore.xcodeproj/project.pbxproj:
  25364. * page/Chrome.cpp:
  25365. (WebCore::Chrome::shouldAllowGeolocationForFrame):
  25366. * page/Chrome.h:
  25367. * page/ChromeClient.h:
  25368. (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
  25369. * page/Geolocation.cpp:
  25370. (WebCore::Geolocation::Geolocation):
  25371. (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
  25372. will not be alive at this point.
  25373. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
  25374. return a PERMISSION_DENIED if not.
  25375. (WebCore::Geolocation::watchPosition): Ditto.
  25376. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
  25377. to allow geolocation and cache the result.
  25378. * page/Geolocation.h:
  25379. (WebCore::Geolocation::):
  25380. * platform/GeolocationService.cpp:
  25381. * platform/GeolocationService.h:
  25382. (WebCore::GeolocationService::~GeolocationService):
  25383. (WebCore::GeolocationService::stopUpdating):
  25384. * platform/mac/GeolocationServiceMac.h: Added.
  25385. (WebCore::GeolocationServiceMac::lastPosition):
  25386. (WebCore::GeolocationServiceMac::lastError):
  25387. * platform/mac/GeolocationServiceMac.mm: Added.
  25388. (WebCore::GeolocationService::create):
  25389. (WebCore::GeolocationServiceMac::GeolocationServiceMac):
  25390. (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
  25391. (WebCore::GeolocationServiceMac::startUpdating):
  25392. (WebCore::GeolocationServiceMac::stopUpdating):
  25393. (WebCore::GeolocationServiceMac::suspend):
  25394. (WebCore::GeolocationServiceMac::resume):
  25395. (WebCore::GeolocationServiceMac::positionChanged):
  25396. (WebCore::GeolocationServiceMac::errorOccurred):
  25397. (-[WebCoreCoreLocationObserver initWithCallback:]):
  25398. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
  25399. (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
  25400. 2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
  25401. Build fixes for wxWidgets Mac trunk build.
  25402. * platform/wx/wxcode/mac/carbon/fontprops.cpp:
  25403. (wxFontProperties::wxFontProperties):
  25404. (GetTextExtent):
  25405. * webcore-wx.bkl:
  25406. 2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
  25407. wxGTK missing header build fix.
  25408. * platform/wx/wxcode/gtk/fontprops.cpp:
  25409. 2009-03-02 Dan Bernstein <mitz@apple.com>
  25410. Reviewed by Adam Roben.
  25411. - fix https://bugs.webkit.org/show_bug.cgi?id=21811
  25412. REGRESSION: Windows Build Not Selecting Proper Font
  25413. * platform/graphics/win/FontCacheWin.cpp:
  25414. (WebCore::createGDIFont): Added back code to verify that the created
  25415. HFONT has the requested face name.
  25416. 2009-03-02 Timothy Hatcher <timothy@apple.com>
  25417. Fixes a regression caused by splitting the input and output of console commands.
  25418. https://bugs.webkit.org/show_bug.cgi?id=24293
  25419. Reviewed by Kevin McCullough.
  25420. * inspector/front-end/Console.js:
  25421. (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
  25422. normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
  25423. 2009-03-02 Timothy Hatcher <timothy@apple.com>
  25424. Make exception messages and logged Error objects display consistently.
  25425. https://bugs.webkit.org/show_bug.cgi?id=18983
  25426. Reviewed by Adam Roben.
  25427. * English.lproj/localizedStrings.js: Remove a string for line numbers.
  25428. * inspector/front-end/Console.js:
  25429. (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
  25430. boolean to the ConsoleCommandResult constructor and don't pass level.
  25431. (WebInspector.Console.prototype._formatnode): Fix a className typo.
  25432. (WebInspector.Console.prototype._formaterror): Add an error-message
  25433. classed span around the message to show in red and remove the
  25434. console-message-url class from the link so it doesn't float right.
  25435. Instead enclose the link in parentheses and use displayNameForURL
  25436. to shorten the URL in the link.
  25437. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
  25438. how line numbers are shown since link underlining a string with
  25439. parentheses looks bad.
  25440. (WebInspector.ConsoleCommandResult): Take an exception boolean flag
  25441. instead of a level and get line and URL based on that flag.
  25442. * inspector/front-end/inspector.css: Tweaks to the styles.
  25443. 2009-03-02 Ojan Vafai <ojan@chromium.org>
  25444. Reviewed by Adele Peterson.
  25445. Bug 24048: extra windows button padding doesn't apply when there's no appearance
  25446. <https://bugs.webkit.org/show_bug.cgi?id=24048>
  25447. Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
  25448. No tests added as existing tests already cover this behavior.
  25449. * rendering/RenderButton.cpp:
  25450. (WebCore::RenderButton::setupInnerStyle):
  25451. * rendering/RenderTheme.cpp:
  25452. * rendering/RenderTheme.h:
  25453. (WebCore::RenderTheme::buttonInternalPaddingLeft):
  25454. (WebCore::RenderTheme::buttonInternalPaddingRight):
  25455. (WebCore::RenderTheme::buttonInternalPaddingTop):
  25456. * rendering/RenderThemeChromiumGtk.cpp:
  25457. (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
  25458. (WebCore::RenderThemeWin::buttonInternalPaddingRight):
  25459. (WebCore::RenderThemeWin::buttonInternalPaddingTop):
  25460. (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  25461. * rendering/RenderThemeChromiumGtk.h:
  25462. * rendering/RenderThemeChromiumWin.cpp:
  25463. (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
  25464. (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
  25465. (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
  25466. (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
  25467. * rendering/RenderThemeChromiumWin.h:
  25468. * rendering/RenderThemeWin.cpp:
  25469. (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
  25470. (WebCore::RenderThemeWin::buttonInternalPaddingRight):
  25471. (WebCore::RenderThemeWin::buttonInternalPaddingTop):
  25472. (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  25473. * rendering/RenderThemeWin.h:
  25474. 2009-03-02 Adam Treat <adam.treat@torchmobile.com>
  25475. Build fix for Qt port. Remove unnecessary assert.
  25476. * platform/graphics/qt/ImageBufferQt.cpp:
  25477. (WebCore::ImageBuffer::putImageData):
  25478. 2009-03-02 Adam Treat <adam.treat@torchmobile.com>
  25479. Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
  25480. https://bugs.webkit.org/show_bug.cgi?id=24227
  25481. Ensure that the checkForSolidColor() optimization is correctly triggered
  25482. for all cases of drawPattern. Currently, the optimization was not triggered
  25483. when the check had not been previously performed via a request for the
  25484. image's NativeImagePtr.
  25485. Implement the Qt version of the checkForSolidColor() method. Combined with
  25486. the bug fix this reduces the time it takes to draw a repeating background
  25487. of a 1x1 image from ~50msecs to ~0msecs on my machine.
  25488. * platform/graphics/BitmapImage.cpp:
  25489. (WebCore::BitmapImage::BitmapImage):
  25490. * platform/graphics/BitmapImage.h:
  25491. (WebCore::BitmapImage::mayFillWithSolidColor):
  25492. * platform/graphics/Image.h:
  25493. (WebCore::Image::mayFillWithSolidColor):
  25494. * platform/graphics/cairo/ImageCairo.cpp:
  25495. (WebCore::BitmapImage::BitmapImage):
  25496. (WebCore::BitmapImage::checkForSolidColor):
  25497. * platform/graphics/cg/ImageCG.cpp:
  25498. (WebCore::BitmapImage::BitmapImage):
  25499. (WebCore::BitmapImage::checkForSolidColor):
  25500. * platform/graphics/qt/ImageQt.cpp:
  25501. (WebCore::BitmapImage::checkForSolidColor):
  25502. * platform/graphics/skia/ImageSkia.cpp:
  25503. (WebCore::BitmapImage::checkForSolidColor):
  25504. * platform/graphics/wx/ImageWx.cpp:
  25505. (WebCore::BitmapImage::checkForSolidColor):
  25506. 2009-03-02 Gustavo Noronha Silva <gns@gnome.org>
  25507. Unreviewed build fix; adding missing files to EXTRA_DIST, so that
  25508. they show up in the tarball.
  25509. * GNUmakefile.am:
  25510. 2009-03-02 Dirk Schulze <krit@webkit.org>
  25511. Reviewed by Holger Freyther.
  25512. Added putImageData to Qt. Discussed with Ariya Hidayat.
  25513. [Qt] lacks putImageData support in Canvas
  25514. https://bugs.webkit.org/show_bug.cgi?id=22186
  25515. * platform/graphics/qt/ImageBufferQt.cpp:
  25516. (WebCore::ImageBuffer::putImageData):
  25517. 2009-03-02 Timothy Hatcher <timothy@apple.com>
  25518. Show exception messages again when evaluating bad expressions in the
  25519. Web Inspector's console.
  25520. https://bugs.webkit.org/show_bug.cgi?id=19890
  25521. Reviewed by Oliver Hunt.
  25522. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  25523. (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
  25524. Fix the order in which the exception is set and cleared now that the
  25525. exception is stored in the shared GlobalData, not per ExecState.
  25526. 2009-02-28 Timothy Hatcher <timothy@apple.com>
  25527. Make input in the Web Inspector console print before any output
  25528. that might be added by the called function.
  25529. https://bugs.webkit.org/show_bug.cgi?id=19931
  25530. Reviewed by Oliver Hunt.
  25531. * inspector/front-end/Console.js:
  25532. (WebInspector.Console.prototype._enterKeyPressed): Add the command
  25533. message before evaluating the result. Associate the originating
  25534. command to the result, so if they are adjacent there is no divider.
  25535. (WebInspector.ConsoleCommand): No longer take a result.
  25536. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
  25537. code removed since it isn't used now.
  25538. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
  25539. (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
  25540. Call the ConsoleMessage toMessageElement and add a style class.
  25541. * inspector/front-end/inspector.css: Add a new style class for
  25542. adjacent results to hide the divider. Also tweak the position of
  25543. the disclosure triangle for objects to not use the left margin.
  25544. 2009-03-01 Chris Fleizach <cfleizach@apple.com>
  25545. Reviewed by Oliver Hunt.
  25546. Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
  25547. <https://bugs.webkit.org/show_bug.cgi?id=24282>
  25548. When fetching an array of elements with a range, attachment views need to be returned
  25549. instead of the actual attachment.
  25550. * page/mac/AccessibilityObjectWrapper.mm:
  25551. (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
  25552. (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
  25553. 2009-03-01 Ojan Vafai <ojan@chromium.org>
  25554. Reviewed by Eric Seidel.
  25555. Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
  25556. <https://bugs.webkit.org/show_bug.cgi?id=24251>
  25557. Make RenderObject::positionForCoordinate non-virtual and
  25558. RenderObject::positionForPoint virtual in preparation for
  25559. removing positionFor* from RenderObject/RenderText.
  25560. * page/Frame.cpp:
  25561. (WebCore::Frame::visiblePositionForPoint):
  25562. * rendering/RenderBR.cpp:
  25563. (WebCore::RenderBR::positionForPoint):
  25564. * rendering/RenderBR.h:
  25565. * rendering/RenderBlock.cpp:
  25566. (WebCore::RenderBlock::positionForPoint):
  25567. * rendering/RenderBlock.h:
  25568. * rendering/RenderBox.cpp:
  25569. (WebCore::RenderBox::positionForPoint):
  25570. * rendering/RenderBox.h:
  25571. * rendering/RenderInline.cpp:
  25572. (WebCore::RenderInline::positionForPoint):
  25573. * rendering/RenderInline.h:
  25574. * rendering/RenderObject.cpp:
  25575. (WebCore::RenderObject::positionForCoordinates):
  25576. (WebCore::RenderObject::positionForPoint):
  25577. * rendering/RenderObject.h:
  25578. * rendering/RenderReplaced.cpp:
  25579. (WebCore::RenderReplaced::positionForPoint):
  25580. * rendering/RenderReplaced.h:
  25581. * rendering/RenderSVGInlineText.cpp:
  25582. (WebCore::RenderSVGInlineText::positionForPoint):
  25583. * rendering/RenderSVGInlineText.h:
  25584. * rendering/RenderText.cpp:
  25585. (WebCore::RenderText::positionForPoint):
  25586. * rendering/RenderText.h:
  25587. 2009-03-01 Larry Ewing <lewing@novell.com>
  25588. Reviewed by Alexey Proskuryakov.
  25589. https://bugs.webkit.org/show_bug.cgi?id=24080
  25590. NPN_GetValue casting to the wrong type and writing outside bounds
  25591. Make sure to cast the value to the correct type so that only
  25592. memory owned by the value is written to.
  25593. * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
  25594. * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
  25595. * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic):
  25596. (PluginView::getValue):
  25597. 2009-03-01 Jeremy Moskovich <jeremy@chromium.org>
  25598. Reviewed by Simon Fraser.
  25599. https://bugs.webkit.org/show_bug.cgi?id=24197 and
  25600. https://bugs.webkit.org/show_bug.cgi?id=23512
  25601. The Windows version of cgColor() is conditionally compiled using
  25602. !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
  25603. can use the OS X version instead of the Windows version.
  25604. Also rename cgColor() -> createCGColor()
  25605. No observable change in behavior, so no test.
  25606. * platform/graphics/Color.h:
  25607. * platform/graphics/cg/ColorCG.cpp:
  25608. (WebCore::createCGColor):
  25609. * platform/graphics/cg/GraphicsContextCG.cpp:
  25610. (WebCore::GraphicsContext::setPlatformShadow):
  25611. * platform/graphics/mac/ColorMac.mm:
  25612. (WebCore::createCGColor):
  25613. * platform/graphics/mac/GraphicsContextMac.mm:
  25614. (WebCore::GraphicsContext::drawFocusRing):
  25615. * platform/graphics/mac/GraphicsLayerCA.mm:
  25616. (WebCore::setLayerBorderColor):
  25617. (WebCore::setLayerBackgroundColor):
  25618. (WebCore::GraphicsLayerCA::setBackgroundColor):
  25619. * platform/graphics/win/GraphicsContextCGWin.cpp:
  25620. (WebCore::GraphicsContext::drawFocusRing):
  25621. * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
  25622. (WebCore::ciColor):
  25623. 2009-03-01 David Levin <levin@chromium.org>
  25624. Reviewed by Alexey Proskuryakov.
  25625. Bug 24271: XMLHttpRequest needs js bindings for Workers.
  25626. <https://bugs.webkit.org/show_bug.cgi?id=24271>
  25627. Tests: http/tests/xmlhttprequest/workers/methods-async.html
  25628. http/tests/xmlhttprequest/workers/methods.html
  25629. * bindings/js/JSWorkerContextBase.cpp:
  25630. (WebCore::JSWorkerContextBase::getOwnPropertySlot):
  25631. (jsWorkerContextBaseXMLHttpRequest):
  25632. (setJSWorkerContextBaseXMLHttpRequest):
  25633. Expose XMLHttpRequest to Workers.
  25634. * bindings/js/JSWorkerContextBase.h:
  25635. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  25636. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  25637. (WebCore::constructXMLHttpRequest):
  25638. (WebCore::JSXMLHttpRequestConstructor::mark):
  25639. Removed the dependencies on Document.
  25640. * bindings/js/JSXMLHttpRequestConstructor.h:
  25641. (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
  25642. * dom/EventException.idl:
  25643. * dom/EventListener.idl:
  25644. Change to have the NoStaticTables attribute since they are used from XHR.
  25645. * loader/WorkerThreadableLoader.cpp:
  25646. (WebCore::workerContextDidFinishLoading):
  25647. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  25648. Fixed identifier to be unsigned long.
  25649. * loader/WorkerThreadableLoader.h:
  25650. * workers/WorkerThread.cpp:
  25651. (WebCore::WorkerThread::workerThread):
  25652. Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
  25653. * xml/XMLHttpRequestUpload.cpp:
  25654. * xml/XMLHttpRequest.idl:
  25655. * xml/XMLHttpRequestException.idl:
  25656. * xml/XMLHttpRequestProgressEvent.idl:
  25657. * xml/XMLHttpRequestUpload.idl:
  25658. Change to have the NoStaticTables attribute since they are used from XHR.
  25659. 2009-03-01 Horia Olaru <olaru@adobe.com>
  25660. Adding manual debugger test cases for bug.
  25661. https://bugs.webkit.org/show_bug.cgi?id=21073
  25662. Reviewed by Kevin McCullough.
  25663. * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
  25664. * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
  25665. * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
  25666. * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
  25667. * manual-tests/inspector/resources/loop-statements.js: Added.
  25668. 2009-03-01 Dan Bernstein <mitz@apple.com>
  25669. Reviewed by Darin Adler.
  25670. - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
  25671. Test: fast/events/scroll-during-zoom-change.html
  25672. * dom/Document.cpp:
  25673. (WebCore::Document::recalcStyle): Pause scheduled events during style
  25674. reclaculation. Changes to the zoom property result in scroll events
  25675. being generated during style recalc, and those events need to be
  25676. deferred until the render tree is consistent.
  25677. * page/FrameView.cpp:
  25678. (WebCore::FrameView::layout): Changed to account for a case in which the
  25679. post-layout tasks trigger a nested layout, which reactivates the
  25680. post-layout task timer.
  25681. 2009-03-01 Ross Boucher <rboucher@gmail.com>
  25682. Alphabetically sort scripts in the Script's panel file popup menu.
  25683. https://bugs.webkit.org/show_bug.cgi?id=23395
  25684. Reviewed by Timothy Hatcher.
  25685. * inspector/front-end/ScriptsPanel.js:
  25686. (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  25687. * inspector/front-end/utilities.js:
  25688. (insertionIndexForObjectInListSortedByFunction):
  25689. (indexOfObjectInListSortedByFunction):
  25690. 2009-03-01 Yael Aharon <yael.aharon@nokia.com>
  25691. Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
  25692. when creating databases, localStorage or sessionStorage. Changing document.domain
  25693. should have no affect on databases, localStorage and sessionStorage in Web Inspector.
  25694. https://bugs.webkit.org/show_bug.cgi?id=23844
  25695. Reviewed by Timothy Hatcher.
  25696. * inspector/InspectorController.cpp:
  25697. (WebCore::InspectorController::addDOMStorageScriptResource):
  25698. (WebCore::InspectorController::didUseDOMStorage):
  25699. * storage/Database.cpp:
  25700. (WebCore::Database::openDatabase):
  25701. 2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
  25702. Reviewed by Holger Freyther.
  25703. Avoid leaking errors when reporting GIO errors.
  25704. * platform/network/soup/ResourceHandleSoup.cpp:
  25705. (WebCore::readCallback):
  25706. (WebCore::openCallback):
  25707. (WebCore::queryInfoCallback):
  25708. 2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
  25709. Reviewed by Holger Freyther.
  25710. Fixes crash when the GIO backend is given the URI for a directory.
  25711. * platform/network/soup/ResourceHandleSoup.cpp:
  25712. (WebCore::networkErrorForFile):
  25713. 2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
  25714. Reviewed by Darin Fisher.
  25715. https://bugs.webkit.org/show_bug.cgi?id=24261
  25716. Fix V8 custom binding scrubbing error.
  25717. Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
  25718. Test: traversal/exception-forwarding.html
  25719. TesT: traversal/stay-within-root.html
  25720. * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  25721. * bindings/v8/custom/V8NodeIteratorCustom.cpp:
  25722. (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
  25723. * bindings/v8/custom/V8TreeWalkerCustom.cpp:
  25724. (WebCore::toV8): Ditto.
  25725. 2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
  25726. Reviewed by Darin Fisher.
  25727. https://bugs.webkit.org/show_bug.cgi?id=24261
  25728. Fix V8 custom binding scrubbing error.
  25729. Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
  25730. * WebCore.xcodeproj/project.pbxproj:
  25731. * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  25732. (WebCore::cssPropertyName): Remove dubious checks, left over from
  25733. incomplete conversion of parameter from pointer to pass-by-ref.
  25734. (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
  25735. (WebCore::NAMED_PROPERTY_SETTER): Ditto.
  25736. 2009-02-28 Xan Lopez <xan@gnome.org>
  25737. Reviewed by Holger Freyther.
  25738. https://bugs.webkit.org/show_bug.cgi?id=24263
  25739. [GTK] ref ResourceHandle until we are finished with it
  25740. Add a ref to the ResourceHandle in startHttp so we can keep it
  25741. alive untill all callbacks have been executed, and unref it when
  25742. soup tells us it's done with the SoupMessage (in
  25743. finishedCallback). Fixes a number of crashes when calling
  25744. didReceiveData whould crash because of the handle dying.
  25745. * platform/network/soup/ResourceHandleSoup.cpp:
  25746. (WebCore::finishedCallback):
  25747. (WebCore::ResourceHandle::startHttp):
  25748. 2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>
  25749. Reviewed by Alexey Proskuryakov.
  25750. https://bugs.webkit.org/show_bug.cgi?id=24226
  25751. [SOUP] HTTP status text is never set
  25752. Set HTTP status text to SoupMessage reason_phrase.
  25753. * platform/network/soup/ResourceHandleSoup.cpp:
  25754. (WebCore::fillResponseFromMessage):
  25755. 2009-02-28 Dan Bernstein <mitz@apple.com>
  25756. - fix malformed project file
  25757. * WebCore.xcodeproj/project.pbxproj:
  25758. 2009-02-28 Dan Bernstein <mitz@apple.com>
  25759. Reviewed by Oliver Hunt.
  25760. - fix https://bugs.webkit.org/show_bug.cgi?id=23848
  25761. <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
  25762. Test: fast/layers/inline-dirty-z-order-lists.html
  25763. * rendering/RenderBox.cpp:
  25764. (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
  25765. layer's and its stacking context's z-order lists when the layer's
  25766. z-index or visibility change from here...
  25767. * rendering/RenderBoxModelObject.cpp:
  25768. (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
  25769. it will apply to RenderInline too.
  25770. 2009-02-27 Alexey Proskuryakov <ap@webkit.org>
  25771. Reviewed by David Hyatt.
  25772. Don't include TextResourceDecoder.h in Document.h
  25773. This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
  25774. when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
  25775. * dom/Document.cpp:
  25776. (WebCore::Document::displayStringModifiedByEncoding):
  25777. (WebCore::Document::displayBufferModifiedByEncoding):
  25778. * dom/Document.h:
  25779. * WebCore.base.exp:
  25780. 2009-02-27 Matt Pennig <pennig@apple.com>
  25781. Reviewed by David Hyatt.
  25782. Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
  25783. "Fixed elements have 0 as an offsetLeft property"
  25784. Code also brings offsetLeft/Top in full conformance with the spec.
  25785. Added two tests, one for fixed-position elements, and one for <html>.
  25786. Tests: fast/dom/Element/fixed-position-offset-parent.html
  25787. fast/dom/Element/offsetLeft-offsetTop-html.html
  25788. * rendering/RenderBoxModelObject.cpp:
  25789. (WebCore::RenderBoxModelObject::offsetLeft):
  25790. (WebCore::RenderBoxModelObject::offsetTop):
  25791. 2009-02-27 Dean Jackson <dino@apple.com>
  25792. Reviewed by Simon Fraser.
  25793. renderer()->hasTransform() returns true for elements
  25794. with perspective, but no transform, so test for transform
  25795. when hit testing. This fixes ASSERT from
  25796. https://bugs.webkit.org/show_bug.cgi?id=24252
  25797. Test: transforms/no_transform_hit_testing.html
  25798. * rendering/RenderLayer.cpp:
  25799. (WebCore::RenderLayer::hitTestLayer):
  25800. 2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
  25801. Reviewed by Darin Fisher.
  25802. Fix scrubbing error -- a reversed condition.
  25803. * bindings/v8/ScriptValue.h:
  25804. (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
  25805. 2009-02-27 Jian Li <jianli@chromium.org>
  25806. Reviewed by Alexey Proskuryakov.
  25807. Add confirmMessageFromWorkerObject to WorkerObjectProxy.
  25808. https://bugs.webkit.org/show_bug.cgi?id=24152
  25809. * workers/WorkerMessagingProxy.cpp:
  25810. (WebCore::MessageWorkerContextTask::performTask):
  25811. (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
  25812. * workers/WorkerMessagingProxy.h:
  25813. * workers/WorkerObjectProxy.h:
  25814. 2009-02-27 Anders Carlsson <andersca@apple.com>
  25815. Reviewed by David Hyatt.
  25816. Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
  25817. because it leads to assertion failures in the Mac port.
  25818. * platform/graphics/BitmapImage.cpp:
  25819. (WebCore::BitmapImage::BitmapImage):
  25820. * platform/graphics/BitmapImage.h:
  25821. (WebCore::BitmapImage::mayFillWithSolidColor):
  25822. * platform/graphics/Image.h:
  25823. (WebCore::Image::mayFillWithSolidColor):
  25824. * platform/graphics/cairo/ImageCairo.cpp:
  25825. (WebCore::BitmapImage::BitmapImage):
  25826. * platform/graphics/cg/ImageCG.cpp:
  25827. (WebCore::BitmapImage::BitmapImage):
  25828. (WebCore::BitmapImage::checkForSolidColor):
  25829. * platform/graphics/qt/ImageQt.cpp:
  25830. (WebCore::BitmapImage::checkForSolidColor):
  25831. * platform/graphics/skia/ImageSkia.cpp:
  25832. (WebCore::BitmapImage::checkForSolidColor):
  25833. * platform/graphics/wx/ImageWx.cpp:
  25834. (WebCore::BitmapImage::checkForSolidColor):
  25835. 2009-02-27 Adam Barth <abarth@webkit.org>
  25836. Reviewed by Eric Seidel.
  25837. https://bugs.webkit.org/show_bug.cgi?id=20249
  25838. Add a preference to allow universal access from local URLs to mitigate
  25839. some attacks. Some clients still want to allow this access, so we
  25840. expose this as a preference.
  25841. * WebCore.base.exp:
  25842. * dom/Document.cpp:
  25843. (WebCore::Document::initSecurityContext):
  25844. * page/SecurityOrigin.cpp:
  25845. (WebCore::SecurityOrigin::SecurityOrigin):
  25846. * page/Settings.cpp:
  25847. (WebCore::Settings::Settings):
  25848. (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
  25849. * page/Settings.h:
  25850. (WebCore::Settings::allowUniversalAccessFromFileUrls):
  25851. 2009-02-27 Adam Treat <adam.treat@torchmobile.com>
  25852. Reviewed by Eric Seidel.
  25853. https://bugs.webkit.org/show_bug.cgi?id=24229
  25854. If an image has no alpha channel there is no reason to use SourceOver.
  25855. * platform/graphics/qt/ImageQt.cpp:
  25856. (WebCore::Image::drawPattern):
  25857. (WebCore::BitmapImage::draw):
  25858. 2009-02-27 Adam Treat <adam.treat@torchmobile.com>
  25859. Reviewed by Eric Seidel and Simon Fraser.
  25860. https://bugs.webkit.org/show_bug.cgi?id=24227
  25861. Ensure that the checkForSolidColor() optimization is correctly triggered
  25862. for all cases of drawPattern. Currently, the optimization was not triggered
  25863. when the check had not been previously performed via a request for the
  25864. image's NativeImagePtr.
  25865. Implement the Qt version of the checkForSolidColor() method. Combined with
  25866. the bug fix this reduces the time it takes to draw a repeating background
  25867. of a 1x1 image from ~50msecs to ~0msecs on my machine.
  25868. * platform/graphics/BitmapImage.cpp:
  25869. (WebCore::BitmapImage::BitmapImage):
  25870. * platform/graphics/BitmapImage.h:
  25871. (WebCore::BitmapImage::mayFillWithSolidColor):
  25872. * platform/graphics/Image.h:
  25873. (WebCore::Image::mayFillWithSolidColor):
  25874. * platform/graphics/cairo/ImageCairo.cpp:
  25875. (WebCore::BitmapImage::BitmapImage):
  25876. * platform/graphics/cg/ImageCG.cpp:
  25877. (WebCore::BitmapImage::BitmapImage):
  25878. (WebCore::BitmapImage::checkForSolidColor):
  25879. * platform/graphics/qt/ImageQt.cpp:
  25880. (WebCore::BitmapImage::checkForSolidColor):
  25881. * platform/graphics/skia/ImageSkia.cpp:
  25882. (WebCore::BitmapImage::checkForSolidColor):
  25883. * platform/graphics/wx/ImageWx.cpp:
  25884. (WebCore::BitmapImage::checkForSolidColor):
  25885. 2009-02-27 Dirk Schulze <krit@webkit.org>
  25886. Reviewed by Zack Rusin.
  25887. Added support for gradients and pattern on Fonts for Qt.
  25888. [Qt] gradients and patterns for FontQt
  25889. https://bugs.webkit.org/show_bug.cgi?id=24243
  25890. * platform/graphics/qt/FontQt.cpp:
  25891. (WebCore::Font::drawComplexText):
  25892. 2009-02-27 Jian Li <jianli@chromium.org>
  25893. Reviewed by Alexey Proskuryakov.
  25894. WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
  25895. https://bugs.webkit.org/show_bug.cgi?id=24113
  25896. * workers/WorkerMessagingProxy.cpp:
  25897. 2009-02-27 Yael Aharon <yael.aharon@nokia.com>
  25898. Added a refresh button to storage views.
  25899. https://bugs.webkit.org/show_bug.cgi?id=24040
  25900. Reviewed by Timothy Hatcher.
  25901. * inspector/front-end/DOMStorageItemsView.js:
  25902. (WebInspector.DOMStorageItemsView):
  25903. (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
  25904. (WebInspector.DOMStorageItemsView.prototype.update):
  25905. (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
  25906. * inspector/front-end/DatabaseTableView.js:
  25907. (WebInspector.DatabaseTableView):
  25908. (WebInspector.DatabaseTableView.prototype.get statusBarItems):
  25909. (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
  25910. * inspector/front-end/DatabasesPanel.js:
  25911. (WebInspector.DatabasesPanel):
  25912. (WebInspector.DatabasesPanel.prototype.get statusBarItems):
  25913. (WebInspector.DatabasesPanel.prototype.reset):
  25914. (WebInspector.DatabasesPanel.prototype.showDatabase):
  25915. (WebInspector.DatabasesPanel.prototype.showDOMStorage):
  25916. (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  25917. * inspector/front-end/inspector.css:
  25918. 2009-02-27 Yael Aharon <yael.aharon@nokia.com>
  25919. Added support for editing/deleting localStorage and sessionStorage items
  25920. directly from Web Inspector.
  25921. https://bugs.webkit.org/show_bug.cgi?id=23866.
  25922. Reviewed by Timothy Hatcher.
  25923. * WebCore.vcproj/WebCore.vcproj:
  25924. * inspector/front-end/DOMStorageDataGrid.js: Added.
  25925. (WebInspector.DOMStorageDataGrid):
  25926. (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
  25927. (WebInspector.DOMStorageDataGrid.prototype._startEditing):
  25928. (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
  25929. (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
  25930. (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
  25931. * inspector/front-end/DOMStorageItemsView.js:
  25932. (WebInspector.DOMStorageItemsView):
  25933. (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
  25934. (WebInspector.DOMStorageItemsView.prototype.hide):
  25935. (WebInspector.DOMStorageItemsView.prototype.update):
  25936. (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
  25937. * inspector/front-end/DatabasesPanel.js:
  25938. (WebInspector.DatabasesPanel):
  25939. (WebInspector.DatabasesPanel.prototype.get statusBarItems):
  25940. (WebInspector.DatabasesPanel.prototype.reset):
  25941. (WebInspector.DatabasesPanel.prototype.showDOMStorage):
  25942. (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
  25943. (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  25944. * inspector/front-end/WebKit.qrc:
  25945. * inspector/front-end/inspector.css:
  25946. * inspector/front-end/inspector.html:
  25947. 2009-02-26 Brett Wilson <brettw@chromium.org>
  25948. Fix Windows transparency for the Chromium port. Implement a helper
  25949. class for handling transparency on Windows. It allows semitransparent
  25950. ClearType and semitransparent form controls by making new layers in the
  25951. background.
  25952. It also replaces the "ThemeHelper" which allows better
  25953. scaling and transforms on Windows form controls. In addition to the
  25954. functionality that the ThemeHelper did, but additionally handles the
  25955. antialiasing properly so that the form controls aren't composited on a
  25956. white square.
  25957. https://bugs.webkit.org/show_bug.cgi?id=24101
  25958. Reviewed by Eric Seidel.
  25959. * platform/graphics/chromium/FontChromiumWin.cpp:
  25960. (WebCore::):
  25961. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
  25962. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
  25963. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  25964. (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
  25965. (WebCore::Font::drawGlyphs):
  25966. * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
  25967. * platform/graphics/chromium/ThemeHelperChromiumWin.h:
  25968. * platform/graphics/chromium/TransparencyWin.cpp: Added.
  25969. (WebCore::):
  25970. (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
  25971. (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
  25972. (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
  25973. (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
  25974. (WebCore::TransparencyWin::TransparencyWin):
  25975. (WebCore::TransparencyWin::~TransparencyWin):
  25976. (WebCore::TransparencyWin::init):
  25977. (WebCore::TransparencyWin::computeLayerSize):
  25978. (WebCore::TransparencyWin::setupLayer):
  25979. (WebCore::TransparencyWin::setupLayerForNoLayer):
  25980. (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
  25981. (WebCore::TransparencyWin::setupLayerForTextComposite):
  25982. (WebCore::TransparencyWin::setupLayerForWhiteLayer):
  25983. (WebCore::TransparencyWin::setupTransform):
  25984. (WebCore::TransparencyWin::setupTransformForKeepTransform):
  25985. (WebCore::TransparencyWin::setupTransformForUntransform):
  25986. (WebCore::TransparencyWin::setupTransformForScaleTransform):
  25987. (WebCore::TransparencyWin::setTextCompositeColor):
  25988. (WebCore::TransparencyWin::initializeNewContext):
  25989. (WebCore::TransparencyWin::compositeOpaqueComposite):
  25990. (WebCore::TransparencyWin::compositeTextComposite):
  25991. (WebCore::TransparencyWin::makeLayerOpaque):
  25992. * platform/graphics/chromium/TransparencyWin.h: Added.
  25993. (WebCore::TransparencyWin::):
  25994. (WebCore::TransparencyWin::context):
  25995. (WebCore::TransparencyWin::platformContext):
  25996. (WebCore::TransparencyWin::drawRect):
  25997. * platform/graphics/skia/GraphicsContextSkia.cpp:
  25998. (WebCore::GraphicsContext::endTransparencyLayer):
  25999. * platform/graphics/skia/ImageSkia.cpp:
  26000. (WebCore::paintSkBitmap):
  26001. * rendering/RenderThemeChromiumWin.cpp:
  26002. (WebCore::):
  26003. (WebCore::RenderThemeChromiumWin::paintButton):
  26004. (WebCore::RenderThemeChromiumWin::paintMenuList):
  26005. (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  26006. 2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
  26007. Reviewed by Eric Seidel.
  26008. https://bugs.webkit.org/show_bug.cgi?id=24211
  26009. Add ScheduledAction for V8.
  26010. * bindings/v8/ScheduledAction.cpp: Added.
  26011. (WebCore::ScheduledAction::ScheduledAction):
  26012. (WebCore::ScheduledAction::~ScheduledAction):
  26013. (WebCore::ScheduledAction::execute):
  26014. * bindings/v8/ScheduledAction.h: Added.
  26015. (WebCore::ScheduledAction::ScheduledAction):
  26016. 2009-02-27 Zack Rusin <zack@kde.org>
  26017. Reviewed by Nikolas Zimmermann.
  26018. Qt: be more reasonable about scrolled lines
  26019. cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
  26020. match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
  26021. irritating. so lets scroll vertically by the Qt set number of lines * Qt default
  26022. single step scroll
  26023. * platform/qt/WheelEventQt.cpp:
  26024. 2009-02-27 Xan Lopez <xan@gnome.org>
  26025. Rubber-stamped by Alexey Proskuryakov.
  26026. https://bugs.webkit.org/show_bug.cgi?id=24222
  26027. [GTK] Remove checks for old glib versions
  26028. libsoup, which is a hard dependency, needs at least glib 2.15.3,
  26029. so remove all glib checks for versions older than that.
  26030. * platform/gtk/ContextMenuGtk.cpp:
  26031. (WebCore::ContextMenu::ContextMenu):
  26032. * platform/gtk/ContextMenuItemGtk.cpp:
  26033. (WebCore::ContextMenuItem::setSubMenu):
  26034. * platform/gtk/PopupMenuGtk.cpp:
  26035. (WebCore::PopupMenu::show):
  26036. * platform/gtk/WidgetGtk.cpp:
  26037. (WebCore::Widget::retainPlatformWidget):
  26038. * platform/network/soup/ResourceHandleSoup.cpp:
  26039. 2009-02-26 Dirk Schulze <krit@webkit.org>
  26040. Reviewed by Oliver Hunt.
  26041. Added support for Gradients and Patterns on filled or stroked Fonts
  26042. in Cairo. I also added support for globalAlpha on FontCairo.
  26043. [CAIRO] SVG/Canvas fonts miss gradients/pattern support
  26044. https://bugs.webkit.org/show_bug.cgi?id=18617
  26045. * html/CanvasRenderingContext2D.cpp:
  26046. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  26047. * platform/graphics/cairo/FontCairo.cpp:
  26048. (WebCore::Font::drawGlyphs):
  26049. 2009-02-26 Stephen White <senorblanco@chromium.org>
  26050. Reviewed by Eric Seidel.
  26051. https://bugs.webkit.org/show_bug.cgi?id=23957
  26052. Fix for SVG gradient and pattern text for Chromium/skia.
  26053. Added accessors for the fill and stroke gradients to
  26054. GraphicsContext. Changed the paintSkiaText function to take a
  26055. GraphicsContext, so we can check for gradients/patterns.
  26056. Changed the skiaDrawText function to set the SkPaint shader
  26057. correctly, and to scale up the gradient shader matrix to
  26058. encompass the entire text string. Also offset each glyph
  26059. separately, rather than transforming the canvas, so that the
  26060. gradient/pattern stays fixed relative to the text origin.
  26061. * platform/graphics/GraphicsContext.cpp:
  26062. (WebCore::GraphicsContext::getFillGradient):
  26063. (WebCore::GraphicsContext::getStrokeGradient):
  26064. (WebCore::GraphicsContext::getFillPattern):
  26065. (WebCore::GraphicsContext::getStrokePattern):
  26066. * platform/graphics/GraphicsContext.h:
  26067. * platform/graphics/chromium/FontChromiumWin.cpp:
  26068. (WebCore::Font::drawGlyphs):
  26069. * platform/graphics/chromium/UniscribeHelper.cpp:
  26070. (WebCore::UniscribeHelper::draw):
  26071. * platform/graphics/skia/SkiaFontWin.cpp:
  26072. (WebCore::windowsCanHandleTextDrawing):
  26073. (WebCore::skiaDrawText):
  26074. (WebCore::paintSkiaText):
  26075. * platform/graphics/skia/SkiaFontWin.h:
  26076. 2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
  26077. Reviewed by Eric Seidel.
  26078. https://bugs.webkit.org/show_bug.cgi?id=24208
  26079. Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
  26080. * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
  26081. (WebCore::ACCESSOR_GETTER):
  26082. (WebCore::CALLBACK_FUNC_DECL):
  26083. * bindings/v8/custom/V8DocumentCustom.cpp: Added.
  26084. (WebCore::CALLBACK_FUNC_DECL):
  26085. * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
  26086. (WebCore::ACCESSOR_GETTER):
  26087. * bindings/v8/custom/V8NodeCustom.cpp: Added.
  26088. (WebCore::CALLBACK_FUNC_DECL):
  26089. 2009-02-26 Gustavo Noronha Silva <gns@gnome.org>
  26090. Unreviewed build fix for building with GNOME Keyring enabled.
  26091. * platform/network/soup/webkit-soup-auth-dialog.c:
  26092. (show_auth_dialog):
  26093. 2009-02-26 Xan Lopez <xan@gnome.org>
  26094. Reviewed by Holger Freyther.
  26095. https://bugs.webkit.org/show_bug.cgi?id=16947
  26096. [GTK] Missing HTTP Auth challenge
  26097. Add HTTP authentication dialog with optional GNOME Keyring
  26098. storage.
  26099. * GNUmakefile.am:
  26100. * platform/network/ResourceHandleInternal.h:
  26101. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  26102. * platform/network/soup/ResourceHandleSoup.cpp:
  26103. (WebCore::currentToplevelCallback):
  26104. (WebCore::ResourceHandle::startHttp):
  26105. (WebCore::ResourceHandle::start):
  26106. * platform/network/soup/webkit-soup-auth-dialog.c: Added.
  26107. (webkit_soup_auth_dialog_class_init):
  26108. (webkit_soup_auth_dialog_init):
  26109. (webkit_soup_auth_dialog_session_feature_init):
  26110. (free_authData):
  26111. (set_password_callback):
  26112. (response_callback):
  26113. (show_auth_dialog):
  26114. (find_password_callback):
  26115. (session_authenticate):
  26116. (attach):
  26117. * platform/network/soup/webkit-soup-auth-dialog.h: Added.
  26118. 2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
  26119. Reviewed by Dave Hyatt.
  26120. After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
  26121. svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
  26122. started failing because Ojan's new code was now *correctly* calling through to
  26123. SVG asking for the closest text offset in the last line box, instead of
  26124. just returning the offset at the end of the last line box when clicking below a box.
  26125. But! The SVG code was wrong, in that it returned the character offset of the last
  26126. character when you asked for a character offset after the end of the box, instead
  26127. it should return the offset *after* the last character. This patch fixes
  26128. that behavior by reordering the last two clauses in svgCharacterHitsPosition.
  26129. The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
  26130. to document what's wrong. I've also cleaned up the code a bit so it's clearer
  26131. what it is doing (which also makes more obvious what's wrong with it).
  26132. * rendering/RenderSVGInlineText.cpp:
  26133. (WebCore::RenderSVGInlineText::positionForCoordinates):
  26134. * rendering/SVGInlineTextBox.cpp:
  26135. (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
  26136. (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
  26137. (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
  26138. (WebCore::SVGInlineTextBox::closestCharacterToPosition):
  26139. (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
  26140. 2009-02-26 Darin Fisher <darin@chromium.org>
  26141. Reviewed by Eric Seidel.
  26142. Minor cleanup of ChromiumBridge:
  26143. Removing unused matchesMIMEType method and s/Javascript/JavaScript/
  26144. * platform/chromium/ChromiumBridge.h:
  26145. * platform/chromium/MimeTypeRegistryChromium.cpp:
  26146. (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
  26147. (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
  26148. (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  26149. 2009-02-26 David Hyatt <hyatt@apple.com>
  26150. Reviewed by Sam Weinig
  26151. Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
  26152. the line-height below the descent.
  26153. Added fast/inline/vertical-align-text-bottom.html
  26154. * rendering/RenderBoxModelObject.cpp:
  26155. (WebCore::RenderBoxModelObject::verticalPosition):
  26156. 2009-02-26 Dirk Schulze <krit@webkit.org>
  26157. Reviewed by Eric Seidel.
  26158. Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
  26159. ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
  26160. just to implement this three methods to support SVG Masking now.
  26161. Make SVG Masking platform aware
  26162. https://bugs.webkit.org/show_bug.cgi?id=19243
  26163. * GNUmakefile.am:
  26164. * WebCore.pro:
  26165. * WebCore.vcproj/WebCore.vcproj:
  26166. * WebCore.xcodeproj/project.pbxproj:
  26167. * svg/graphics/SVGResourceMasker.cpp:
  26168. (WebCore::SVGResourceMasker::applyMask):
  26169. * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
  26170. * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
  26171. * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
  26172. * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
  26173. * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
  26174. 2009-02-26 Yong Li <yong.li@torchmobile.com>
  26175. Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
  26176. Test: http/tests/misc/slow-preload-cancel.html
  26177. https://bugs.webkit.org/show_bug.cgi?id=24133
  26178. Clear all pending preloads in the DocLoader object when we decide to
  26179. cancel its all requests.
  26180. * loader/DocLoader.cpp:
  26181. (WebCore::DocLoader::clearPendingPreloads):
  26182. * loader/DocLoader.h:
  26183. * loader/loader.cpp:
  26184. (WebCore::Loader::cancelRequests):
  26185. 2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>
  26186. Reviewed by Eric Seidel.
  26187. https://bugs.webkit.org/show_bug.cgi?id=24182
  26188. Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
  26189. * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
  26190. (WebCore::CALLBACK_FUNC_DECL):
  26191. * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
  26192. (WebCore::toV8):
  26193. (WebCore::CALLBACK_FUNC_DECL):
  26194. * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
  26195. (WebCore::toV8):
  26196. (WebCore::CALLBACK_FUNC_DECL):
  26197. 2009-02-26 Alexey Proskuryakov <ap@webkit.org>
  26198. Reviewed by Darin Adler.
  26199. https://bugs.webkit.org/show_bug.cgi?id=23500
  26200. KURL::parse() incorrectly compares its result to original string
  26201. * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
  26202. 2009-02-26 Ojan Vafai <ojan@chromium.org>
  26203. Reviewed by Kevin McCullough.
  26204. Manual test for inspector node highlighting.
  26205. * manual-tests/inspector/highlight-nodes.html: Added.
  26206. 2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>
  26207. Reviewed by Darin Fisher.
  26208. https://bugs.webkit.org/show_bug.cgi?id=23973
  26209. ScrollView::scrollContents can be invoked during view shutdown. In
  26210. this scenario the FrameView::hostWindow method can return NULL, which
  26211. indicates that the frame/page is being destroyed. This causes a crash
  26212. when we try to dereference a NULL hostWindow pointer. Fix is to add a
  26213. NULL check for this.
  26214. * platform/ScrollView.cpp:
  26215. (WebCore::ScrollView::scrollContents):
  26216. 2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>
  26217. Reviewed by Dave Hyatt.
  26218. https://bugs.webkit.org/show_bug.cgi?id=24003
  26219. Fix a crash caused by unsafe type conversion.
  26220. Test: fast/block/positioning/absolute-in-inline-rtl-4.html
  26221. * rendering/RenderBox.cpp:
  26222. (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  26223. 2009-02-26 Ojan Vafai <ojan@chromium.org>
  26224. Reviewed by Adam Roben.
  26225. https://bugs.webkit.org/show_bug.cgi?id=24202
  26226. Have drawNodeHighlight clip instead of clearing. This makes it work for
  26227. both Safari and Chromium since Chromium draws the inspector highlighting
  26228. in the same buffer as the page.
  26229. * inspector/InspectorController.cpp:
  26230. (WebCore::quadToPath):
  26231. (WebCore::drawOutlinedQuad):
  26232. (WebCore::drawOutlinedQuadWithClip):
  26233. (WebCore::drawHighlightForBox):
  26234. 2009-02-26 David Hyatt <hyatt@apple.com>
  26235. Reviewed by Dan Bernstein & Darin Adler
  26236. Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
  26237. Added fast/inline/inline-continuation-borders.html
  26238. * rendering/InlineFlowBox.cpp:
  26239. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  26240. 2009-02-26 Simon Fraser <simon.fraser@apple.com>
  26241. Build fix, no review.
  26242. Try to fix the wx build after r41218.
  26243. * WebCoreSources.bkl:
  26244. 2009-02-26 Alexey Proskuryakov <ap@webkit.org>
  26245. Reviewed by Darin Adler.
  26246. https://bugs.webkit.org/show_bug.cgi?id=19527
  26247. ASSERTION FAILED: containerA && containerB
  26248. Test: fast/dom/Range/bug-19527.html
  26249. * dom/Range.cpp:
  26250. (WebCore::Range::isPointInRange):
  26251. (WebCore::Range::comparePoint):
  26252. Bring the behavior in line with current Firefox, making it impossible for these methods
  26253. to pass a null container to compareBoundaryPoints().
  26254. 2009-02-26 Jonathon Jongsma <jonathon@quotidian.org>
  26255. Reviewed by Holger Freyther.
  26256. https://bugs.webkit.org/show_bug.cgi?id=20358
  26257. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  26258. (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
  26259. should set the computed size rather than the specified size, otherwise
  26260. the caps just get rendered normal size.
  26261. 2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>
  26262. Reviewed by George Staikos.
  26263. https://bugs.webkit.org/show_bug.cgi?id=24062
  26264. QNetworkCookieJar expects the url and not the policy url. Sending the
  26265. policy url will cause QNetworkCookieJar to behave incorrectly. One
  26266. example would be a cookie that does not have a path or domain.
  26267. QNetworkCookieJar will use the url it is given to fill in default values.
  26268. This allows setting cookies on the url of the main frame from an iFrame
  26269. when the cookie should be set on the url of the iFrame.
  26270. Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
  26271. * platform/qt/CookieJarQt.cpp:
  26272. (WebCore::setCookies):
  26273. 2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>
  26274. Reviewed by George Staikos.
  26275. make WebKit/Qt compile with SVG disabled
  26276. * WebCore.pro:
  26277. * platform/graphics/qt/FontPlatformDataQt.cpp:
  26278. 2009-02-25 Gustavo Noronha Silva <gns@gnome.org>
  26279. Unreviewed build fix. Add WebCore/workers to the list of paths
  26280. searched by the bindings generator perl script.
  26281. * GNUmakefile.am:
  26282. 2009-02-25 Sam Weinig <sam@webkit.org>
  26283. Reviewed by Geoffrey Garen.
  26284. Add canvas to the list of RenderObjects that can mark a page as
  26285. visually not empty.
  26286. * rendering/RenderHTMLCanvas.cpp:
  26287. (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
  26288. 2009-02-25 Eric Carlson <eric.carlson@apple.com>
  26289. Reviewed by Dave Hyatt.
  26290. * rendering/RenderBox.cpp:
  26291. (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
  26292. as RenderMedia with controls always has a layer.
  26293. 2009-02-25 Dan Bernstein <mitz@apple.com>
  26294. Reviewed by Simon Fraser.
  26295. - fix https://bugs.webkit.org/show_bug.cgi?id=24130
  26296. <rdar://problem/6618196> Paint very slow when horizontally resizing
  26297. Test: fast/gradients/background-clipped.html
  26298. * rendering/RenderBoxModelObject.cpp:
  26299. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
  26300. destination rectangle passed to drawTiledImage() with the dirty
  26301. rectangle. This makes it more likely for the destination rect to be
  26302. contained in a single tile rect, which results in a faster code path
  26303. being taken down the road (just drawing a single tile instead of
  26304. tiling).
  26305. 2009-02-25 Ojan Vafai <ojan@chromium.org>
  26306. Reviewed by Eric Seidel.
  26307. Fix test regressions from positionForCoordinates patch.
  26308. https://bugs.webkit.org/show_bug.cgi?id=24148
  26309. * rendering/RenderBlock.cpp:
  26310. (WebCore::positionForPointWithInlineChildren):
  26311. Remove ASSERT that placeholder text codepath is hitting.
  26312. 2009-02-25 Chris Fleizach <cfleizach@apple.com>
  26313. Reviewed by Beth Dakin.
  26314. Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
  26315. https://bugs.webkit.org/show_bug.cgi?id=24143
  26316. When an AX object is marked dirty, do not create AX elements while going up the parent chain.
  26317. Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
  26318. Make sure the AXObjectWrapper's have an object before calling them
  26319. In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
  26320. Test: platform/mac-snowleopard/accessibility/table-updating.html
  26321. * WebCore.base.exp:
  26322. * page/AXObjectCache.cpp:
  26323. (WebCore::AXObjectCache::~AXObjectCache):
  26324. (WebCore::AXObjectCache::get):
  26325. (WebCore::AXObjectCache::getOrCreate):
  26326. (WebCore::AXObjectCache::removeAXID):
  26327. (WebCore::AXObjectCache::handleActiveDescendantChanged):
  26328. (WebCore::AXObjectCache::handleAriaRoleChanged):
  26329. * page/AXObjectCache.h:
  26330. * page/AccessibilityImageMapLink.cpp:
  26331. (WebCore::AccessibilityImageMapLink::parentObject):
  26332. * page/AccessibilityListBox.cpp:
  26333. (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
  26334. (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  26335. * page/AccessibilityListBoxOption.cpp:
  26336. (WebCore::AccessibilityListBoxOption::elementRect):
  26337. (WebCore::AccessibilityListBoxOption::parentObject):
  26338. * page/AccessibilityObject.cpp:
  26339. (WebCore::AccessibilityObject::detach):
  26340. (WebCore::AccessibilityObject::parentObjectIfExists):
  26341. (WebCore::replacedNodeNeedsCharacter):
  26342. (WebCore::AccessibilityObject::accessibilityObjectForPosition):
  26343. * page/AccessibilityObject.h:
  26344. * page/AccessibilityRenderObject.cpp:
  26345. (WebCore::AccessibilityRenderObject::firstChild):
  26346. (WebCore::AccessibilityRenderObject::lastChild):
  26347. (WebCore::AccessibilityRenderObject::previousSibling):
  26348. (WebCore::AccessibilityRenderObject::nextSibling):
  26349. (WebCore::AccessibilityRenderObject::parentObjectIfExists):
  26350. (WebCore::AccessibilityRenderObject::parentObject):
  26351. (WebCore::AccessibilityRenderObject::isAttachment):
  26352. (WebCore::AccessibilityRenderObject::headingLevel):
  26353. (WebCore::AccessibilityRenderObject::anchorElement):
  26354. (WebCore::AccessibilityRenderObject::menuForMenuButton):
  26355. (WebCore::AccessibilityRenderObject::menuButtonForMenu):
  26356. (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
  26357. (WebCore::AccessibilityRenderObject::internalLinkElement):
  26358. (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
  26359. (WebCore::AccessibilityRenderObject::titleUIElement):
  26360. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  26361. (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
  26362. (WebCore::AccessibilityRenderObject::getDocumentLinks):
  26363. (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  26364. (WebCore::AccessibilityRenderObject::focusedUIElement):
  26365. (WebCore::AccessibilityRenderObject::activeDescendant):
  26366. (WebCore::AccessibilityRenderObject::observableObject):
  26367. (WebCore::AccessibilityRenderObject::childrenChanged):
  26368. (WebCore::AccessibilityRenderObject::addChildren):
  26369. * page/AccessibilityRenderObject.h:
  26370. (WebCore::AccessibilityRenderObject::setRenderObject):
  26371. * page/AccessibilityTable.cpp:
  26372. (WebCore::AccessibilityTable::addChildren):
  26373. (WebCore::AccessibilityTable::headerContainer):
  26374. (WebCore::AccessibilityTable::cellForColumnAndRow):
  26375. * page/AccessibilityTableCell.cpp:
  26376. (WebCore::AccessibilityTableCell::isTableCell):
  26377. (WebCore::AccessibilityTableCell::titleUIElement):
  26378. * page/AccessibilityTableColumn.cpp:
  26379. (WebCore::AccessibilityTableColumn::headerObjectForSection):
  26380. * page/AccessibilityTableRow.cpp:
  26381. (WebCore::AccessibilityTableRow::isTableRow):
  26382. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  26383. * page/mac/AXObjectCacheMac.mm:
  26384. (WebCore::AXObjectCache::postNotification):
  26385. (WebCore::AXObjectCache::postNotificationToElement):
  26386. * page/mac/AccessibilityObjectWrapper.mm:
  26387. (textMarkerForVisiblePosition):
  26388. (AXLinkElementForNode):
  26389. (nsStringForReplacedNode):
  26390. (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
  26391. (-[AccessibilityObjectWrapper accessibilityActionNames]):
  26392. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  26393. (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
  26394. (-[AccessibilityObjectWrapper accessibilityHitTest:]):
  26395. (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
  26396. (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
  26397. (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
  26398. (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
  26399. (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
  26400. (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
  26401. (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
  26402. (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
  26403. (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
  26404. (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
  26405. 2009-02-25 Beth Dakin <bdakin@apple.com>
  26406. Reviewed by Geoff Garen.
  26407. Re-working of <rdar://problem/6487249> repro crash in
  26408. WebCore::CSSParser::parseFillImage copying entire contents of this
  26409. page
  26410. -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
  26411. Fixes a bunch of layout test failures I caused!
  26412. * css/CSSParser.cpp:
  26413. (WebCore::CSSParser::parseValue):
  26414. (WebCore::CSSParser::parseContent):
  26415. (WebCore::CSSParser::parseFillImage):
  26416. (WebCore::CSSParser::parseFontFaceSrc):
  26417. (WebCore::CSSParser::parseBorderImage):
  26418. 2009-02-25 Dimitri Glazkov <dglazkov@chromium.org>
  26419. Reviewed by Eric Seidel.
  26420. https://bugs.webkit.org/show_bug.cgi?id=24174
  26421. Add more V8 custom bindings.
  26422. * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
  26423. (WebCore::hasCSSPropertyNamePrefix):
  26424. (WebCore::cssPropertyName):
  26425. (WebCore::NAMED_PROPERTY_GETTER):
  26426. (WebCore::NAMED_PROPERTY_SETTER):
  26427. * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
  26428. (WebCore::INDEXED_PROPERTY_GETTER):
  26429. (WebCore::CALLBACK_FUNC_DECL):
  26430. * bindings/v8/custom/V8EventCustom.cpp: Added.
  26431. (WebCore::ACCESSOR_SETTER):
  26432. (WebCore::ACCESSOR_GETTER):
  26433. * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
  26434. (WebCore::NAMED_PROPERTY_DELETER):
  26435. (WebCore::NAMED_PROPERTY_SETTER):
  26436. (WebCore::NAMED_PROPERTY_GETTER):
  26437. * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
  26438. (WebCore::NAMED_PROPERTY_GETTER):
  26439. * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
  26440. (WebCore::INDEXED_PROPERTY_GETTER):
  26441. (WebCore::NAMED_PROPERTY_GETTER):
  26442. * bindings/v8/custom/V8NodeListCustom.cpp: Added.
  26443. (WebCore::NAMED_PROPERTY_GETTER):
  26444. * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
  26445. (WebCore::NAMED_PROPERTY_GETTER):
  26446. 2009-02-25 Scott Violet <sky@google.com>
  26447. Reviewed by Dave Hyatt.
  26448. https://bugs.webkit.org/show_bug.cgi?id=24171
  26449. Provides a RenderTheme method for getting the scroll bar size and
  26450. changes RenderListBox to use it. RenderTheme returns a size of regular,
  26451. and Mac's override to return small. Changes ScrollbarThemeChromium to
  26452. use the scrollbarsize of the scrollbar when getting the size
  26453. instead of passing in no-args.
  26454. * platform/chromium/ScrollbarThemeChromium.cpp:
  26455. (WebCore::ScrollbarThemeChromium::trackRect):
  26456. (WebCore::ScrollbarThemeChromium::buttonSize):
  26457. * rendering/RenderListBox.cpp:
  26458. (WebCore::RenderListBox::createScrollbar):
  26459. * rendering/RenderTheme.h:
  26460. (WebCore::RenderTheme::scrollbarControlSizeForPart):
  26461. * rendering/RenderThemeChromiumMac.h:
  26462. (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
  26463. * rendering/RenderThemeMac.h:
  26464. (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
  26465. 2009-02-25 Beth Dakin <bdakin@apple.com>
  26466. Reviewed by Darin Adler.
  26467. Fix for <rdar://problem/6487249> repro crash in
  26468. WebCore::CSSParser::parseFillImage copying entire contents of this
  26469. page
  26470. -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
  26471. * css/CSSParser.cpp:
  26472. (WebCore::CSSParser::parseValue): Null-check m_styleSheet
  26473. 2009-02-25 Adam Treat <adam.treat@torchmobile.com>
  26474. Fix the Qt build.
  26475. * WebCore.pro:
  26476. 2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>
  26477. Gtk build fix. Not reviewed.
  26478. Add files to the build per r41218.
  26479. Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
  26480. * GNUmakefile.am:
  26481. * page/DOMWindow.cpp:
  26482. 2009-02-25 Zan Dobersek <zandobersek@gmail.com>
  26483. Reviewed by Alexey Proskuryakov.
  26484. https://bugs.webkit.org/show_bug.cgi?id=24043
  26485. When faced with URLs with unsupported protocol on Gtk port,
  26486. report the error through an idle function and return true, so
  26487. a proper resource handle is created.
  26488. * platform/network/soup/ResourceHandleSoup.cpp:
  26489. (WebCore::reportUnknownProtocolError):
  26490. (WebCore::ResourceHandle::start):
  26491. 2009-02-25 Steve Falkenburg <sfalken@apple.com>
  26492. Windows build fix.
  26493. Use struct to forward declare ResourceRequest.
  26494. * history/HistoryItem.h:
  26495. * inspector/InspectorController.h:
  26496. * loader/DocumentThreadableLoader.h:
  26497. * loader/FrameLoaderClient.h:
  26498. * loader/MainResourceLoader.h:
  26499. * loader/SubresourceLoader.h:
  26500. * loader/SubresourceLoaderClient.h:
  26501. * loader/ThreadableLoader.h:
  26502. * loader/WorkerThreadableLoader.h:
  26503. * platform/CrossThreadCopier.h:
  26504. * platform/network/ResourceHandle.h:
  26505. * platform/network/ResourceHandleClient.h:
  26506. * platform/network/ResourceRequestBase.h:
  26507. * platform/network/cf/ResourceRequestCFNet.h:
  26508. * xml/XMLHttpRequest.h:
  26509. 2009-02-25 Steve Falkenburg <sfalken@apple.com>
  26510. Partial Windows build fix.
  26511. * DerivedSources.cpp:
  26512. * WebCore.vcproj/WebCore.vcproj:
  26513. 2009-02-25 Dirk Schulze <krit@webkit.org>
  26514. Reviewed by Oliver Hunt.
  26515. Ported arcTo to Qt. Qt has no native support for arcTo. This changes
  26516. calculate the behavior of arcTo and draws it with lineTo and arc.
  26517. [QT] implement Canvas arcTo
  26518. https://bugs.webkit.org/show_bug.cgi?id=23873
  26519. * platform/graphics/qt/PathQt.cpp:
  26520. (WebCore::Path::addArcTo):
  26521. 2009-02-25 Simon Fraser <simon.fraser@apple.com>
  26522. Reviewed by Dan Bernstein
  26523. Remove idl files from Resources, and sort.
  26524. * WebCore.xcodeproj/project.pbxproj:
  26525. 2009-02-25 Chris Marrin <cmarrin@apple.com>
  26526. Reviewed by Simon Fraser.
  26527. https://bugs.webkit.org/show_bug.cgi?id=23943
  26528. Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
  26529. the window object. Also added WebKitPoint object, which is passed in and out
  26530. of these functions.
  26531. Test: fast/dom/Window/webkitConvertPoint.html
  26532. * DerivedSources.make:
  26533. * WebCore.pro:
  26534. * WebCore.vcproj/WebCore.vcproj:
  26535. * WebCore.xcodeproj/project.pbxproj:
  26536. * WebCoreSources.bkl:
  26537. * bindings/js/JSDOMWindowBase.cpp:
  26538. (jsDOMWindowBaseWebKitPoint):
  26539. (setJSDOMWindowBaseWebKitPoint):
  26540. * bindings/js/JSWebKitPointConstructor.cpp: Added.
  26541. (WebCore::):
  26542. (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  26543. (WebCore::constructWebKitPoint):
  26544. (WebCore::JSWebKitPointConstructor::getConstructData):
  26545. * bindings/js/JSWebKitPointConstructor.h: Added.
  26546. (WebCore::JSWebKitPointConstructor::classInfo):
  26547. * dom/Node.cpp:
  26548. (WebCore::Node::convertToPage):
  26549. (WebCore::Node::convertFromPage):
  26550. * dom/Node.h:
  26551. * page/DOMWindow.cpp:
  26552. (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
  26553. (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
  26554. * page/DOMWindow.h:
  26555. * page/DOMWindow.idl:
  26556. * page/WebKitPoint.h: Added.
  26557. (WebCore::WebKitPoint::create):
  26558. (WebCore::WebKitPoint::x):
  26559. (WebCore::WebKitPoint::y):
  26560. (WebCore::WebKitPoint::setX):
  26561. (WebCore::WebKitPoint::setY):
  26562. (WebCore::WebKitPoint::WebKitPoint):
  26563. * page/WebKitPoint.idl: Added.
  26564. 2009-02-25 Jian Li <jianli@chromium.org>
  26565. Reviewed by Alexey Proskuryakov.
  26566. Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
  26567. https://bugs.webkit.org/show_bug.cgi?id=24145
  26568. * platform/CrossThreadCopier.cpp:
  26569. * platform/CrossThreadCopier.h:
  26570. 2009-02-25 David Levin <levin@chromium.org>
  26571. Reviewed by Alexey Proskuryakov.
  26572. Bug 23688: ThreadableLoader needs a sync implementation for Workers.
  26573. <https://bugs.webkit.org/show_bug.cgi?id=23688>
  26574. No observable change in behavior, so no test.
  26575. * loader/ThreadableLoader.cpp:
  26576. (WebCore::ThreadableLoader::loadResourceSynchronously):
  26577. * loader/ThreadableLoaderClientWrapper.h:
  26578. (WebCore::ThreadableLoaderClientWrapper::clearClient):
  26579. (WebCore::ThreadableLoaderClientWrapper::done):
  26580. (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
  26581. (WebCore::ThreadableLoaderClientWrapper::didFail):
  26582. (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
  26583. (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
  26584. Expose whether the loader is done (based on what callbacks were done).
  26585. * loader/WorkerThreadableLoader.cpp:
  26586. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  26587. (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
  26588. Each loader is given its own mode so that only its callbacks get through the run loop.
  26589. The xhr spec says that the readystatechange events are synchronous, so in the case of a
  26590. nested sync xhr no readystatechange events should be fired for the outer xhr.
  26591. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  26592. * loader/WorkerThreadableLoader.h:
  26593. (WebCore::WorkerThreadableLoader::create):
  26594. (WebCore::WorkerThreadableLoader::done):
  26595. * workers/WorkerRunLoop.cpp:
  26596. (WebCore::WorkerRunLoop::WorkerRunLoop):
  26597. * workers/WorkerRunLoop.h:
  26598. (WebCore::WorkerRunLoop::createUniqueId):
  26599. Simple method to create a uniqueId on demand with respect to the run loop.
  26600. * workers/WorkerThread.h:
  26601. 2009-02-25 David Levin <levin@chromium.org>
  26602. Reviewed by Alexey Proskuryakov.
  26603. Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
  26604. <https://bugs.webkit.org/show_bug.cgi?id=24089>
  26605. Make threadable loader callbacks to happen during the sync load call.
  26606. Changes the behavior of sync xhr for insecure redirects in two ways:
  26607. + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
  26608. + Throws a network exception which is what other browsers do and what the spec
  26609. says to do (http://www.w3.org/TR/XMLHttpRequest/).
  26610. * loader/DocumentThreadableLoader.cpp:
  26611. (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
  26612. * loader/DocumentThreadableLoader.h:
  26613. * loader/ThreadableLoader.cpp:
  26614. (WebCore::ThreadableLoader::loadResourceSynchronously):
  26615. * loader/ThreadableLoader.h:
  26616. * xml/XMLHttpRequest.cpp:
  26617. (WebCore::XMLHttpRequest::XMLHttpRequest):
  26618. (WebCore::XMLHttpRequest::loadRequestSynchronously):
  26619. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  26620. (WebCore::XMLHttpRequest::didFail):
  26621. (WebCore::XMLHttpRequest::didFailRedirectCheck):
  26622. * xml/XMLHttpRequest.h:
  26623. 2009-02-24 Chris Marrin <cmarrin@apple.com>
  26624. Reviewed by David Hyatt.
  26625. https://bugs.webkit.org/show_bug.cgi?id=23368
  26626. Added logic to correctly hit test accelerated layers.
  26627. Tests: animations/animation-hit-test-transform.html
  26628. animations/animation-hit-test.html
  26629. transitions/transition-hit-test-transform.html
  26630. transitions/transition-hit-test.html
  26631. * page/animation/KeyframeAnimation.cpp:
  26632. (WebCore::KeyframeAnimation::animate):
  26633. * rendering/RenderLayer.cpp:
  26634. (WebCore::RenderLayer::hitTestLayer):
  26635. (WebCore::RenderLayer::updateClipRects):
  26636. * rendering/RenderLayerBacking.cpp:
  26637. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  26638. 2009-02-25 Alexey Proskuryakov <ap@webkit.org>
  26639. Reviewed by Darin Adler.
  26640. https://bugs.webkit.org/show_bug.cgi?id=24067
  26641. REGRESSION: Crash in WebCore::Document::initSecurityContext
  26642. The crash started to happen when we removed a check for frame->document() being null.
  26643. However, the original document shouldn't be null here, because it is needed to alias
  26644. security origins. So, this patch fixes the crash by correcting security origin behavior.
  26645. Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
  26646. This tests for not crashing, and for inheriting the domain from the document being replaced.
  26647. Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
  26648. domain to remove a prefix from.
  26649. * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
  26650. clearing the frame, so that Document::initSecurityContext() could access the old one.
  26651. 2009-02-25 Jay Campan <jcampan@google.com>
  26652. Reviewed by Darin Fisher.
  26653. https://bugs.webkit.org/show_bug.cgi?id=24066
  26654. Items in drop-downs were not painted correctly. Makes sure the
  26655. PopupListBox invalidates in the coordinates of the window as this is
  26656. FramelessScrollView::invalidateRect paints to.
  26657. * platform/chromium/PopupMenuChromium.cpp:
  26658. (WebCore::PopupListBox::invalidateRow):
  26659. 2009-02-24 Simon Fraser <simon.fraser@apple.com>
  26660. Reviewed by Anders Carlsson
  26661. https://bugs.webkit.org/show_bug.cgi?id=15081
  26662. Make display:none work for applet, emebed and object elements
  26663. by calling rendererIsNeeded() on superclasses.
  26664. Tests: fast/replaced/applet-display-none.html
  26665. fast/replaced/embed-display-none.html
  26666. fast/replaced/object-display-none.html
  26667. * html/HTMLAppletElement.cpp:
  26668. (WebCore::HTMLAppletElement::rendererIsNeeded):
  26669. * html/HTMLElement.cpp:
  26670. (WebCore::HTMLElement::rendererIsNeeded):
  26671. * html/HTMLEmbedElement.cpp:
  26672. (WebCore::HTMLEmbedElement::rendererIsNeeded):
  26673. * html/HTMLObjectElement.cpp:
  26674. (WebCore::HTMLObjectElement::rendererIsNeeded):
  26675. 2009-02-24 Simon Fraser <simon.fraser@apple.com>
  26676. Reviewed by Dave Hyatt
  26677. https://bugs.webkit.org/show_bug.cgi?id=24137
  26678. Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
  26679. taking perspective and transform-style: preserve-3d into account.
  26680. In order to support transform-style: preserve-3d, which keeps elements in a
  26681. 3d space, we have to carry along an accumulated matrix in TransformState.
  26682. We also need to apply the perspective from the parent, if any, with the
  26683. appropriate origin.
  26684. * GNUmakefile.am:
  26685. * WebCore.base.exp:
  26686. * WebCore.pro:
  26687. * WebCore.scons:
  26688. * WebCore.vcproj/WebCore.vcproj:
  26689. * WebCore.xcodeproj/project.pbxproj:
  26690. * WebCoreSources.bkl:
  26691. * css/CSSComputedStyleDeclaration.cpp:
  26692. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  26693. * platform/graphics/transforms/TransformationMatrix.cpp:
  26694. (WebCore::TransformationMatrix::translate):
  26695. (WebCore::TransformationMatrix::translate3d):
  26696. (WebCore::TransformationMatrix::translateRight3d):
  26697. * platform/graphics/transforms/TransformationMatrix.h:
  26698. * rendering/RenderBox.cpp:
  26699. (WebCore::RenderBox::mapLocalToAbsolutePoint):
  26700. (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  26701. * rendering/RenderBox.h:
  26702. * rendering/RenderLayer.cpp:
  26703. (WebCore::RenderLayer::updateTransform):
  26704. (WebCore::RenderLayer::perspectiveTransform):
  26705. (WebCore::RenderLayer::perspectiveOrigin):
  26706. * rendering/RenderLayer.h:
  26707. * rendering/RenderLayerBacking.cpp:
  26708. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  26709. * rendering/RenderLayerCompositor.cpp:
  26710. (WebCore::requiresCompositingLayerForTransform):
  26711. (WebCore::RenderLayerCompositor::layerHas3DContent):
  26712. * rendering/RenderObject.cpp:
  26713. (WebCore::RenderObject::localToAbsolute):
  26714. (WebCore::RenderObject::absoluteToLocal):
  26715. (WebCore::RenderObject::mapLocalToAbsolutePoint):
  26716. (WebCore::RenderObject::mapAbsoluteToLocalPoint):
  26717. * rendering/RenderObject.h:
  26718. * rendering/RenderTableCell.cpp:
  26719. (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
  26720. (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
  26721. * rendering/RenderTableCell.h:
  26722. * rendering/RenderView.cpp:
  26723. (WebCore::RenderView::mapLocalToAbsolutePoint):
  26724. (WebCore::RenderView::mapAbsoluteToLocalPoint):
  26725. * rendering/RenderView.h:
  26726. * rendering/TransformState.cpp: Added.
  26727. (WebCore::TransformState::move):
  26728. (WebCore::TransformState::applyTransform):
  26729. (WebCore::TransformState::flatten):
  26730. * rendering/TransformState.h: Added.
  26731. (WebCore::TransformState::):
  26732. (WebCore::TransformState::TransformState):
  26733. (WebCore::TransformState::move):
  26734. * rendering/style/RenderStyle.h:
  26735. (WebCore::InheritedFlags::hasPerspective):
  26736. 2009-02-24 Sam Weinig <sam@webkit.org>
  26737. Reviewed by David Hyatt.
  26738. Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
  26739. Regression (r40837): JavaScript image popup doesn't work
  26740. Make the getClientRects and getBoundingClientRect methods return rects
  26741. relative to the viewport.
  26742. Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
  26743. * dom/Element.cpp:
  26744. (WebCore::Element::getClientRects):
  26745. (WebCore::Element::getBoundingClientRect):
  26746. 2009-02-24 Ojan Vafai <ojan@chromium.org>
  26747. Reviewed by Eric Seidel.
  26748. SVG pages don't have a body or an html element!
  26749. Don't return early if there is no body.
  26750. * editing/VisiblePosition.cpp:
  26751. (WebCore::VisiblePosition::canonicalPosition):
  26752. 2009-02-23 David Hyatt <hyatt@apple.com>
  26753. Reviewed by Eric Seidel
  26754. https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
  26755. This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
  26756. layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
  26757. reflections or masks).
  26758. If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
  26759. The only difference is that the clip has to be pushed and popped when painting the object's children.
  26760. The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
  26761. the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
  26762. use the new functions.
  26763. Hit testing has also been patched to check the overflow clip rect first before recurring into children.
  26764. Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
  26765. yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.
  26766. Masks are now treated like normal flow layers (just like reflections).
  26767. A couple of test cases have been added to fast/overflow to test the stacking order.
  26768. * rendering/InlineFlowBox.cpp:
  26769. (WebCore::InlineFlowBox::nodeAtPoint):
  26770. (WebCore::InlineFlowBox::paint):
  26771. * rendering/RenderBlock.cpp:
  26772. (WebCore::RenderBlock::repaintOverhangingFloats):
  26773. (WebCore::RenderBlock::paint):
  26774. (WebCore::RenderBlock::paintChildren):
  26775. (WebCore::RenderBlock::paintObject):
  26776. (WebCore::RenderBlock::paintFloats):
  26777. (WebCore::RenderBlock::insertFloatingObject):
  26778. (WebCore::RenderBlock::floatRect):
  26779. (WebCore::RenderBlock::lowestPosition):
  26780. (WebCore::RenderBlock::rightmostPosition):
  26781. (WebCore::RenderBlock::leftmostPosition):
  26782. (WebCore::RenderBlock::addOverhangingFloats):
  26783. (WebCore::RenderBlock::nodeAtPoint):
  26784. (WebCore::RenderBlock::hitTestContents):
  26785. * rendering/RenderBox.cpp:
  26786. (WebCore::RenderBox::nodeAtPoint):
  26787. (WebCore::RenderBox::pushContentsClip):
  26788. (WebCore::RenderBox::popContentsClip):
  26789. * rendering/RenderBox.h:
  26790. (WebCore::RenderBox::paintObject):
  26791. * rendering/RenderBoxModelObject.cpp:
  26792. (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
  26793. * rendering/RenderBoxModelObject.h:
  26794. * rendering/RenderLayer.cpp:
  26795. (WebCore::RenderLayer::paintLayer):
  26796. (WebCore::RenderLayer::hitTestLayer):
  26797. (WebCore::RenderLayer::shouldBeNormalFlowOnly):
  26798. (WebCore::RenderLayer::isSelfPaintingLayer):
  26799. * rendering/RenderLayer.h:
  26800. * rendering/RenderTable.cpp:
  26801. (WebCore::RenderTable::paint):
  26802. (WebCore::RenderTable::paintObject):
  26803. (WebCore::RenderTable::nodeAtPoint):
  26804. * rendering/RenderTable.h:
  26805. * rendering/RenderTableCell.cpp:
  26806. (WebCore::RenderTableCell::paint):
  26807. * rendering/RenderTableRow.cpp:
  26808. (WebCore::RenderTableRow::nodeAtPoint):
  26809. (WebCore::RenderTableRow::paint):
  26810. * rendering/RenderTableRow.h:
  26811. * rendering/RenderTableSection.cpp:
  26812. (WebCore::RenderTableSection::paint):
  26813. (WebCore::RenderTableSection::paintObject):
  26814. (WebCore::RenderTableSection::nodeAtPoint):
  26815. * rendering/RenderTableSection.h:
  26816. * rendering/RenderTreeAsText.cpp:
  26817. (WebCore::write):
  26818. (WebCore::writeLayers):
  26819. 2009-02-24 David Levin <levin@chromium.org>
  26820. Reviewed by NOBODY (build fix).
  26821. Attempted build fix for wx-mac.
  26822. * WebCoreSources.bkl:
  26823. 2009-02-24 David Levin <levin@chromium.org>
  26824. Reviewed by NOBODY (build fix).
  26825. Attempted build fixes for qt-linux and wx-mac.
  26826. * WebCore.pro:
  26827. * webcore-base.bkl:
  26828. 2009-02-24 Ojan Vafai <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
  26829. Reviewed by Sam Weinig.
  26830. Fix null pointer error. If the node is the Document, then ownerDocument()
  26831. returns null, document() does not.
  26832. * editing/VisiblePosition.cpp:
  26833. (WebCore::VisiblePosition::canonicalPosition):
  26834. 2009-02-24 Jian Li <jianli@chromium.org>
  26835. Reviewed by NOBODY (attempted build fixes).
  26836. Fix build break for Windows and Linux.
  26837. * GNUmakefile.am:
  26838. * WebCore.vcproj/WebCore.vcproj:
  26839. 2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  26840. Reviewed by Eric Seidel.
  26841. https://bugs.webkit.org/show_bug.cgi?id=24131
  26842. Fix-up COM/RefCounted dichotomy in Chromium port.
  26843. * page/chromium/AccessibilityObjectWrapper.h:
  26844. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
  26845. explicit setting of recount.
  26846. 2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  26847. Reviewed by Eric Seidel.
  26848. https://bugs.webkit.org/show_bug.cgi?id=24141
  26849. Add clarity to V8 interceptor helper function.
  26850. * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  26851. (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
  26852. (WebCore::NAMED_PROPERTY_SETTER): Ditto.
  26853. (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
  26854. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
  26855. 2009-02-24 Simon Fraser <simon.fraser@apple.com>
  26856. Reviewed by Eric Seidel
  26857. Minor numeric cleanup: convert float literals to doubles.
  26858. * platform/graphics/transforms/RotateTransformOperation.cpp:
  26859. (WebCore::RotateTransformOperation::blend):
  26860. 2009-02-24 Mark Mentovai <mark@chromium.org>
  26861. Reviewed by Eric Seidel.
  26862. https://bugs.webkit.org/show_bug.cgi?id=24139
  26863. Add missing include.
  26864. * bindings/v8/ScriptInstance.h:
  26865. 2009-02-24 Jian Li <jianli@chromium.org>
  26866. Reviewed by Alexey Proskuryakov.
  26867. Move worker related files from dom directory to worker directory under WebCore.
  26868. https://bugs.webkit.org/show_bug.cgi?id=24123
  26869. * DerivedSources.make:
  26870. * GNUmakefile.am:
  26871. * WebCore.pro:
  26872. * WebCore.scons:
  26873. * WebCore.vcproj/MigrateIDLAndScripts:
  26874. * WebCore.vcproj/WebCore.vcproj:
  26875. * WebCore.xcodeproj/project.pbxproj:
  26876. * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
  26877. * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
  26878. * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
  26879. * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
  26880. * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
  26881. * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
  26882. * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
  26883. * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
  26884. * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
  26885. * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
  26886. * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
  26887. * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
  26888. * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
  26889. * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
  26890. * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
  26891. * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
  26892. * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
  26893. * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
  26894. * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
  26895. * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
  26896. 2009-02-05 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
  26897. Reviewed by Dave Hyatt.
  26898. Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
  26899. around divs inside editable regions.
  26900. https://bugs.webkit.org/show_bug.cgi?id=23605
  26901. Fix clicks outside editable regions from focusing the editable region.
  26902. https://bugs.webkit.org/show_bug.cgi?id=23607
  26903. Removed editing/selection/contenteditable-click-outside.html as it's
  26904. not as useful as our new tests.
  26905. Clean up RenderBlock::positionForCoordinates to remove dead code,
  26906. duplicate code, and generally make it more readable.
  26907. Tests: editing/selection/click-in-margins-inside-editable-div.html
  26908. editing/selection/click-in-padding-with-multiple-line-boxes.html
  26909. editing/selection/click-outside-editable-div.html
  26910. * editing/VisiblePosition.cpp:
  26911. (WebCore::VisiblePosition::canonicalPosition):
  26912. * rendering/RenderBlock.cpp:
  26913. (WebCore::positionForPointRespectingEditingBoundaries):
  26914. (WebCore::positionForPointWithInlineChildren):
  26915. (WebCore::RenderBlock::positionForCoordinates):
  26916. (WebCore::RenderBlock::updateFirstLetter):
  26917. 2009-02-24 Sam Weinig <sam@webkit.org>
  26918. Reviewed by Geoffrey Garen.
  26919. Related to <rdar://problem/6590295>
  26920. Allow disabling javascript: urls.
  26921. * WebCore.base.exp:
  26922. * html/HTMLAnchorElement.cpp:
  26923. (WebCore::HTMLAnchorElement::parseMappedAttribute):
  26924. * loader/FrameLoader.cpp:
  26925. (WebCore::FrameLoader::executeIfJavaScriptURL):
  26926. * page/Page.cpp:
  26927. (WebCore::Page::Page):
  26928. (WebCore::Page::setJavaScriptURLsAreAllowed):
  26929. (WebCore::Page::javaScriptURLsAreAllowed):
  26930. * page/Page.h:
  26931. 2009-02-24 Simon Fraser <simon.fraser@apple.com>
  26932. Fix build when ACCELERATED_COMPOSITING is turned on
  26933. (overflowList() -> normalFlowList()).
  26934. * rendering/RenderLayerBacking.cpp:
  26935. (WebCore::RenderLayerBacking::hasNonCompositingContent):
  26936. (WebCore::RenderLayerBacking::paintIntoLayer):
  26937. * rendering/RenderLayerCompositor.cpp:
  26938. (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  26939. (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  26940. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  26941. (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
  26942. (WebCore::RenderLayerCompositor::layerHas3DContent):
  26943. 2009-02-24 Simon Fraser <simon.fraser@apple.com>
  26944. Reviewed by Darin Adler
  26945. https://bugs.webkit.org/show_bug.cgi?id=24135
  26946. Round the FloatPoint returned by absoluteToLocal(), rather than
  26947. truncating it.
  26948. * dom/MouseRelatedEvent.cpp:
  26949. (WebCore::MouseRelatedEvent::receivedTarget):
  26950. 2009-02-24 Beth Dakin <bdakin@apple.com>
  26951. Reviewed by Sam Weinig.
  26952. Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
  26953. Ordered list item marker misaligned when line height is not 1.2
  26954. -and corresponding <rdar://problem/6602506>
  26955. This is a regression from http://trac.webkit.org/changeset/40880
  26956. where createInlineBox was taken off of RenderObject and moved to
  26957. RenderBox. The problem was that the RenderBox version still needs
  26958. to be virtual because there is still an existing implementation in
  26959. RenderListMarker.
  26960. * rendering/RenderBox.h:
  26961. * rendering/RenderListMarker.cpp:
  26962. (WebCore::RenderListMarker::createInlineBox):
  26963. * rendering/RenderListMarker.h:
  26964. 2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
  26965. Reviewed by Eric Seidel.
  26966. https://bugs.webkit.org/show_bug.cgi?id=24128
  26967. Upstream more V8 custom bindings: constructors, XSLTProcessor.
  26968. * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
  26969. (WebCore::CALLBACK_FUNC_DECL):
  26970. * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
  26971. (WebCore::CALLBACK_FUNC_DECL):
  26972. * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
  26973. (WebCore::CALLBACK_FUNC_DECL):
  26974. * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
  26975. (WebCore::CALLBACK_FUNC_DECL):
  26976. * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
  26977. (WebCore::CALLBACK_FUNC_DECL):
  26978. * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
  26979. (WebCore::CALLBACK_FUNC_DECL):
  26980. 2009-02-24 David Levin <levin@chromium.org>
  26981. Reviewed by Alexey Proskuryakov.
  26982. Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
  26983. <https://bugs.webkit.org/show_bug.cgi?id=24090>
  26984. No observable change in behavior, so no test.
  26985. * dom/WorkerMessagingProxy.cpp:
  26986. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
  26987. (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
  26988. Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
  26989. (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
  26990. * dom/WorkerMessagingProxy.h:
  26991. * loader/ThreadableLoader.cpp:
  26992. (WebCore::ThreadableLoader::create):
  26993. * loader/WorkerThreadableLoader.cpp:
  26994. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  26995. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  26996. (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
  26997. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
  26998. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
  26999. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  27000. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
  27001. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
  27002. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
  27003. Changed these methods to post task using a mode.
  27004. * loader/WorkerThreadableLoader.h:
  27005. (WebCore::WorkerThreadableLoader::create):
  27006. 2009-02-24 Alexey Proskuryakov <ap@webkit.org>
  27007. Reviewed by Darin Adler.
  27008. https://bugs.webkit.org/show_bug.cgi?id=24091
  27009. <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
  27010. Test: http/tests/appcache/access-via-redirect.php
  27011. * loader/appcache/ApplicationCacheGroup.cpp:
  27012. (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
  27013. not the original one.
  27014. 2009-02-24 Jian Li <jianli@chromium.org>
  27015. Reviewed by Alexey Proskuryakov.
  27016. Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
  27017. https://bugs.webkit.org/show_bug.cgi?id=24112
  27018. * bindings/js/WorkerScriptController.cpp:
  27019. * dom/WorkerContext.cpp:
  27020. 2009-02-23 Antti Koivisto <antti@apple.com>
  27021. Reviewed by Oliver Hunt.
  27022. <rdar://problem/6613796> Extended text codecs registered on webview creation
  27023. Comparing a text encoding with string "GBK" ended up constructing
  27024. TextEncoding("GBK") which in turn initialized all extended
  27025. text codecs.
  27026. * platform/text/TextCodecICU.cpp:
  27027. (WebCore::TextCodecICU::decode):
  27028. 2009-02-23 Sam Weinig <sam@webkit.org>
  27029. Fix Qt build.
  27030. * bridge/qt/qt_runtime.cpp:
  27031. (JSC::Bindings::valueRealType):
  27032. 2009-02-23 Julien Chaffraix <jchaffraix@webkit.org>
  27033. Reviewed by Darin Adler.
  27034. Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
  27035. The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
  27036. element created with createElement could have a wrong nodeName (createElement sets the string as the
  27037. localName without checking for a prefix).
  27038. The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
  27039. and will always succeed.
  27040. Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
  27041. to ensure that).
  27042. Test: fast/dom/cloneNode.html
  27043. * dom/Element.cpp:
  27044. (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
  27045. always return an element.
  27046. * html/HTMLElement.cpp:
  27047. * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
  27048. 2009-02-23 Dimitri Glazkov <dglazkov@chromium.org>
  27049. Reviewed by Eric Seidel.
  27050. https://bugs.webkit.org/show_bug.cgi?id=24109
  27051. Upstream V8 Script abstractions, all except ScriptController.
  27052. * bindings/v8/ScriptCachedFrameData.h: Added.
  27053. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
  27054. (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
  27055. (WebCore::ScriptCachedFrameData::restore):
  27056. (WebCore::ScriptCachedFrameData::clear):
  27057. (WebCore::ScriptCachedFrameData::domWindow):
  27058. * bindings/v8/ScriptCallFrame.cpp: Added.
  27059. (WebCore::ScriptCallFrame::ScriptCallFrame):
  27060. (WebCore::ScriptCallFrame::~ScriptCallFrame):
  27061. (WebCore::ScriptCallFrame::argumentAt):
  27062. * bindings/v8/ScriptCallFrame.h: Added.
  27063. (WebCore::ScriptCallFrame::functionName):
  27064. (WebCore::ScriptCallFrame::sourceURL):
  27065. (WebCore::ScriptCallFrame::lineNumber):
  27066. (WebCore::ScriptCallFrame::argumentCount):
  27067. * bindings/v8/ScriptCallStack.cpp: Added.
  27068. (WebCore::ScriptCallStack::ScriptCallStack):
  27069. (WebCore::ScriptCallStack::~ScriptCallStack):
  27070. (WebCore::ScriptCallStack::at):
  27071. * bindings/v8/ScriptCallStack.h: Added.
  27072. (WebCore::ScriptCallStack::size):
  27073. * bindings/v8/ScriptInstance.cpp: Added.
  27074. (WebCore::V8ScriptInstance::V8ScriptInstance):
  27075. (WebCore::V8ScriptInstance::~V8ScriptInstance):
  27076. (WebCore::V8ScriptInstance::instance):
  27077. (WebCore::V8ScriptInstance::clear):
  27078. (WebCore::V8ScriptInstance::set):
  27079. * bindings/v8/ScriptInstance.h: Added.
  27080. (WebCore::V8ScriptInstance::create):
  27081. * bindings/v8/ScriptSourceCode.h: Added.
  27082. (WebCore::ScriptSourceCode::ScriptSourceCode):
  27083. (WebCore::ScriptSourceCode::isEmpty):
  27084. (WebCore::ScriptSourceCode::source):
  27085. (WebCore::ScriptSourceCode::url):
  27086. (WebCore::ScriptSourceCode::startLine):
  27087. * bindings/v8/ScriptState.h: Added.
  27088. (WebCore::ScriptState::hadException):
  27089. (WebCore::ScriptState::setException):
  27090. (WebCore::ScriptState::exception):
  27091. * bindings/v8/ScriptString.h: Added.
  27092. (WebCore::ScriptString::ScriptString):
  27093. (WebCore::ScriptString::operator String):
  27094. (WebCore::ScriptString::isNull):
  27095. (WebCore::ScriptString::size):
  27096. (WebCore::ScriptString::operator=):
  27097. (WebCore::ScriptString::operator+=):
  27098. * bindings/v8/ScriptValue.cpp: Added.
  27099. (WebCore::ScriptValue::getString):
  27100. * bindings/v8/ScriptValue.h: Added.
  27101. (WebCore::ScriptValue::ScriptValue):
  27102. (WebCore::ScriptValue::operator=):
  27103. (WebCore::ScriptValue::operator==):
  27104. (WebCore::ScriptValue::operator!=):
  27105. (WebCore::ScriptValue::isNull):
  27106. (WebCore::ScriptValue::isUndefined):
  27107. (WebCore::ScriptValue::clear):
  27108. (WebCore::ScriptValue::~ScriptValue):
  27109. (WebCore::ScriptValue::v8Value):
  27110. 2009-02-23 Adam Treat <adam.treat@torchmobile.com>
  27111. Reviewed by Timothy Hatcher.
  27112. https://bugs.webkit.org/show_bug.cgi?id=24106
  27113. The Qt port is crashing on exit because the tear down procedure involves
  27114. the WebCore::InspectorController trying to access the JS execution context
  27115. for a page that is being deleted. This patch amends the inspector so
  27116. that it does not try and access the execution context of the WebCore::Page
  27117. in the midst of deletion.
  27118. * inspector/InspectorController.cpp:
  27119. (WebCore::InspectorController::inspectedPageDestroyed):
  27120. (WebCore::InspectorController::stopUserInitiatedProfiling):
  27121. 2009-02-23 David Levin <levin@chromium.org>
  27122. Reviewed by Alexey Proskuryakov.
  27123. Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
  27124. <https://bugs.webkit.org/show_bug.cgi?id=24088>
  27125. No observable change in behavior, so no test.
  27126. * loader/DocumentThreadableLoader.cpp:
  27127. (WebCore::DocumentThreadableLoader::create):
  27128. * loader/ThreadableLoaderClient.h:
  27129. (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
  27130. * loader/ThreadableLoaderClientWrapper.h:
  27131. (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
  27132. * loader/WorkerThreadableLoader.cpp:
  27133. (WebCore::workerContextDidFailRedirectCheck):
  27134. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
  27135. * loader/WorkerThreadableLoader.h:
  27136. * xml/XMLHttpRequest.cpp:
  27137. (WebCore::XMLHttpRequest::didFinishLoading):
  27138. * xml/XMLHttpRequest.h:
  27139. 2009-02-23 David Levin <levin@chromium.org>
  27140. Reviewed by Alexey Proskuryakov.
  27141. Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
  27142. <https://bugs.webkit.org/show_bug.cgi?id=24047>
  27143. Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
  27144. using only MessageQueue::waitForMessageFilteredWithTimeout instead
  27145. of three different MessageQueue methods.
  27146. No observable change in behavior, so no test.
  27147. * dom/WorkerRunLoop.cpp:
  27148. (WebCore::ModePredicate::operator()):
  27149. Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
  27150. (WebCore::WorkerRunLoop::runInMode):
  27151. * dom/WorkerRunLoop.h:
  27152. 2009-02-23 David Hyatt <hyatt@apple.com>
  27153. In preparation for making layers for multicol objects (so that they can properly split child layers
  27154. into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
  27155. of RenderLayer to use the term "normal flow" instead.
  27156. Reviewed by Cameron Zwarich
  27157. * rendering/RenderLayer.cpp:
  27158. (WebCore::RenderLayer::RenderLayer):
  27159. (WebCore::RenderLayer::~RenderLayer):
  27160. (WebCore::RenderLayer::setHasVisibleContent):
  27161. (WebCore::RenderLayer::enclosingCompositingLayer):
  27162. (WebCore::RenderLayer::addChild):
  27163. (WebCore::RenderLayer::removeChild):
  27164. (WebCore::RenderLayer::paintLayer):
  27165. (WebCore::RenderLayer::hitTestLayer):
  27166. (WebCore::RenderLayer::dirtyNormalFlowList):
  27167. (WebCore::RenderLayer::updateNormalFlowList):
  27168. (WebCore::RenderLayer::collectLayers):
  27169. (WebCore::RenderLayer::updateLayerListsIfNeeded):
  27170. (WebCore::RenderLayer::shouldBeNormalFlowOnly):
  27171. (WebCore::RenderLayer::styleChanged):
  27172. * rendering/RenderLayer.h:
  27173. (WebCore::RenderLayer::isNormalFlowOnly):
  27174. (WebCore::RenderLayer::normalFlowList):
  27175. * rendering/RenderTreeAsText.cpp:
  27176. (WebCore::writeLayers):
  27177. 2009-02-23 David Hyatt <hyatt@apple.com>
  27178. Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
  27179. after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
  27180. column rules (rather than ending up above the background of the box but behind the column rules).
  27181. Reviewed by Eric Seidel
  27182. Added fast/multicol/column-rules-stacking.html
  27183. * rendering/RenderBlock.cpp:
  27184. (WebCore::RenderBlock::paintColumnRules):
  27185. (WebCore::RenderBlock::paintColumnContents):
  27186. (WebCore::RenderBlock::paintObject):
  27187. * rendering/RenderBlock.h:
  27188. 2009-02-23 Adam Treat <adam.treat@torchmobile.com>
  27189. Reviewed by David Hyatt.
  27190. No testcases have been added or modified since this patch should not result in
  27191. a behavior change for ports that have layout tests enabled.
  27192. Currently, the implementation of GraphicsContext::drawLineForText amongst
  27193. the various ports differ in that some of them are honoring the context's
  27194. strokeStyle when drawing a text-decoration and some of them are not.
  27195. For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
  27196. but the Cairo implementation does and has an explicit workaround that
  27197. sets the strokeStyle() temporarily.
  27198. This patch fixes so that all ports are consistent by explicitly making sure
  27199. to set the GraphicsContext strokeStyle to SolidStroke whenever
  27200. painting the text-decoration of an InlineFlowBox or InlineTextBox as these
  27201. should always use a solid stroke.
  27202. This patch addresses these bugs:
  27203. https://bugs.webkit.org/show_bug.cgi?id=19364
  27204. https://bugs.webkit.org/show_bug.cgi?id=15659
  27205. * rendering/InlineFlowBox.cpp:
  27206. (WebCore::InlineFlowBox::paintTextDecorations):
  27207. * rendering/InlineTextBox.cpp:
  27208. (WebCore::InlineTextBox::paintDecoration):
  27209. 2009-02-23 Scott Violet <sky@google.com>
  27210. Reviewed by Eric Seidel.
  27211. https://bugs.webkit.org/show_bug.cgi?id=24098
  27212. Bugs in ClipboardChromium
  27213. Fixes the following bugs in ClipboardChromium:
  27214. * It's possible for the extension to be empty, resulting in a bad file
  27215. name, for example, 'foo.' or just '.'.
  27216. * We weren't restricting the size of the file to MAX_PATH.
  27217. * We weren't removing characters that are invalid for file system names.
  27218. * platform/chromium/ClipboardChromium.cpp:
  27219. (WebCore::writeImageToDataObject):
  27220. * platform/chromium/ClipboardChromium.h:
  27221. * platform/chromium/ClipboardChromiumLinux.cpp: Added.
  27222. (WebCore::ClipboardChromium::validateFileName):
  27223. * platform/chromium/ClipboardChromiumMac.cpp: Added.
  27224. (WebCore::ClipboardChromium::validateFileName):
  27225. * platform/chromium/ClipboardChromiumWin.cpp: Added.
  27226. (WebCore::isInvalidFileCharacter):
  27227. (WebCore::ClipboardChromium::validateFileName):
  27228. 2009-02-23 Thiago Macieira <thiago.macieira@nokia.com>
  27229. Reviewed by Simon Hausmann.
  27230. Fix the Copyright notices in a few files
  27231. * platform/qt/RenderThemeQt.h:
  27232. 2009-02-23 Xan Lopez <xan@gnome.org>
  27233. Reviewed by Alexey Proskuryakov.
  27234. https://bugs.webkit.org/show_bug.cgi?id=22624
  27235. [SOUP][GTK] Need API to get SoupSession from WebKit.
  27236. Allow to retrieve the Soup session and modify the code to take
  27237. into account users changing features on it.
  27238. * platform/network/ResourceHandle.h:
  27239. * platform/network/soup/CookieJarSoup.cpp:
  27240. (WebCore::defaultCookieJar):
  27241. (WebCore::setDefaultCookieJar):
  27242. * platform/network/soup/CookieJarSoup.h:
  27243. * platform/network/soup/ResourceHandleSoup.cpp:
  27244. (WebCore::createSoupSession):
  27245. (WebCore::ensureSessionIsInitialized):
  27246. (WebCore::ResourceHandle::startHttp):
  27247. (WebCore::ResourceHandle::cancel):
  27248. (WebCore::ResourceHandle::defaultSession):
  27249. 2009-02-23 Xan Lopez <xan@gnome.org>
  27250. Reviewed by Alexey Proskuryakov.
  27251. https://bugs.webkit.org/show_bug.cgi?id=22624
  27252. [SOUP][GTK] Need API to get SoupSession from WebKit.
  27253. Remove CURL support.
  27254. * GNUmakefile.am:
  27255. 2009-02-23 Alexey Proskuryakov <ap@webkit.org>
  27256. Reviewed by Mark Rowe.
  27257. Test: fast/dom/empty-hash-and-search.html
  27258. https://bugs.webkit.org/show_bug.cgi?id=21147
  27259. hash property returns incorrect value for links w/o hash
  27260. Make hash() and search() behavior for empty and missing parts match IE and Firefox.
  27261. * platform/KURL.cpp:
  27262. (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
  27263. (WebCore::KURL::prettyURL): Append the query with the question mark.
  27264. * page/Location.cpp:
  27265. (WebCore::Location::search): Return an empty string if query is empty or missing.
  27266. (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
  27267. * dom/WorkerLocation.cpp:
  27268. (WebCore::WorkerLocation::search):
  27269. (WebCore::WorkerLocation::hash):
  27270. Match document.location fixes above.
  27271. * html/HTMLAnchorElement.cpp:
  27272. (WebCore::HTMLAnchorElement::hash):
  27273. (WebCore::HTMLAnchorElement::search):
  27274. Return an empty string for empty and missing parts.
  27275. 2009-02-23 Alexey Proskuryakov <ap@webkit.org>
  27276. Reviewed by Darin Adler.
  27277. https://bugs.webkit.org/show_bug.cgi?id=20184
  27278. SELECT with no name generates invalid query string
  27279. Test: fast/forms/select-no-name.html
  27280. * html/HTMLSelectElement.cpp:
  27281. (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
  27282. 2009-02-23 Alexey Proskuryakov <ap@webkit.org>
  27283. Apply review comments for the previous check-in (forgot to save the file, oops).
  27284. * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
  27285. 2009-02-23 Alexey Proskuryakov <ap@webkit.org>
  27286. Reviewed by Darin Adler.
  27287. https://bugs.webkit.org/show_bug.cgi?id=15707
  27288. Crash when manipulating document from within an iframe onload function
  27289. Test: fast/dom/onload-open.html
  27290. * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
  27291. the current node, because anything can happen when dispatching events.
  27292. 2009-02-23 Alexey Proskuryakov <ap@webkit.org>
  27293. Reviewed by Darin Adler.
  27294. https://bugs.webkit.org/show_bug.cgi?id=18970
  27295. Numerically named input fields cause document.forms loop problems
  27296. Test: fast/forms/numeric-input-name.html
  27297. * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
  27298. latter overrides properties.
  27299. 2009-02-23 Alexey Proskuryakov <ap@webkit.org>
  27300. Reviewed by Sam Weinig.
  27301. https://bugs.webkit.org/show_bug.cgi?id=24059
  27302. Tokenizer::write() return value is never used
  27303. * dom/Tokenizer.h:
  27304. * dom/XMLTokenizer.cpp:
  27305. (WebCore::XMLTokenizer::write):
  27306. * dom/XMLTokenizer.h:
  27307. * html/HTMLTokenizer.cpp:
  27308. (WebCore::HTMLTokenizer::write):
  27309. * html/HTMLTokenizer.h:
  27310. * loader/FTPDirectoryDocument.cpp:
  27311. (WebCore::FTPDirectoryTokenizer::write):
  27312. * loader/ImageDocument.cpp:
  27313. (WebCore::ImageTokenizer::write):
  27314. * loader/MediaDocument.cpp:
  27315. (WebCore::MediaTokenizer::write):
  27316. * loader/PluginDocument.cpp:
  27317. (WebCore::PluginTokenizer::write):
  27318. * loader/TextDocument.cpp:
  27319. (WebCore::TextTokenizer::write):
  27320. Made write() return void, not bool.
  27321. 2009-02-20 Geoffrey Garen <ggaren@apple.com>
  27322. Reviewed by Sam Weinig.
  27323. Updated for JavaScriptCore changes to timeout checking.
  27324. * bindings/js/JSCustomPositionCallback.cpp:
  27325. (WebCore::JSCustomPositionCallback::handleEvent):
  27326. * bindings/js/JSCustomPositionErrorCallback.cpp:
  27327. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  27328. * bindings/js/JSCustomSQLStatementCallback.cpp:
  27329. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  27330. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  27331. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  27332. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  27333. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  27334. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  27335. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  27336. * bindings/js/JSCustomVoidCallback.cpp:
  27337. (WebCore::JSCustomVoidCallback::handleEvent):
  27338. * bindings/js/JSCustomXPathNSResolver.cpp:
  27339. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  27340. * bindings/js/JSDOMWindowBase.cpp:
  27341. (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  27342. (WebCore::JSDOMWindowBase::commonJSGlobalData):
  27343. * bindings/js/JSEventListener.cpp:
  27344. (WebCore::JSAbstractEventListener::handleEvent):
  27345. * bindings/js/ScheduledAction.cpp:
  27346. (WebCore::ScheduledAction::executeFunctionInContext):
  27347. * bindings/js/ScriptController.cpp:
  27348. (WebCore::ScriptController::evaluate):
  27349. * bindings/js/WorkerScriptController.cpp:
  27350. (WebCore::WorkerScriptController::evaluate):
  27351. (WebCore::WorkerScriptController::forbidExecution):
  27352. * bindings/objc/WebScriptObject.mm:
  27353. (-[WebScriptObject callWebScriptMethod:withArguments:]):
  27354. (-[WebScriptObject evaluateWebScript:]):
  27355. * bridge/NP_jsobject.cpp:
  27356. (_NPN_InvokeDefault):
  27357. (_NPN_Invoke):
  27358. (_NPN_Evaluate):
  27359. (_NPN_Construct):
  27360. * bridge/jni/jni_jsobject.mm:
  27361. (JavaJSObject::call):
  27362. (JavaJSObject::eval):
  27363. 2009-02-21 Hironori Bono <hbono@chromium.org>
  27364. Reviewed by Alexey Proskuryakov.
  27365. https://bugs.webkit.org/show_bug.cgi?id=23786
  27366. [Chromium] line-break characters in a complex text are treated as zero-width spaces
  27367. This change prevents the UniscribeHelper class from treating the line-break characters
  27368. as whitespaces.
  27369. Tests: fast/text/international/bidi-linebreak-001.html
  27370. fast/text/international/bidi-linebreak-002.html
  27371. fast/text/international/bidi-linebreak-003.html
  27372. * platform/graphics/chromium/UniscribeHelper.cpp:
  27373. (WebCore::UniscribeHelper::adjustSpaceAdvances):
  27374. Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
  27375. the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
  27376. so does when Chromium renders a simple text.
  27377. 2009-02-20 Julien Chaffraix <jchaffraix@webkit.org>
  27378. Reviewed by Alexey Proskuryakov.
  27379. Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
  27380. Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
  27381. or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
  27382. unneeded.
  27383. It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
  27384. enables us to use some generated QualifiedName.
  27385. * bindings/js/JSOptionConstructor.cpp:
  27386. (WebCore::constructHTMLOptionElement):
  27387. * dom/Document.cpp:
  27388. (WebCore::Document::setTitle):
  27389. * dom/XMLTokenizer.cpp:
  27390. (WebCore::createXHTMLParserErrorHeader):
  27391. (WebCore::XMLTokenizer::insertErrorMessageBlock):
  27392. * editing/CompositeEditCommand.cpp:
  27393. (WebCore::createBlockPlaceholderElement):
  27394. * editing/htmlediting.cpp:
  27395. (WebCore::createTabSpanElement):
  27396. * html/HTMLSelectElement.cpp:
  27397. (WebCore::HTMLSelectElement::setLength):
  27398. * loader/FTPDirectoryDocument.cpp:
  27399. (WebCore::FTPDirectoryTokenizer::appendEntry):
  27400. (WebCore::FTPDirectoryTokenizer::createTDForFilename):
  27401. (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
  27402. (WebCore::FTPDirectoryTokenizer::createBasicDocument):
  27403. * loader/ImageDocument.cpp:
  27404. (WebCore::ImageDocument::createDocumentStructure):
  27405. * loader/MediaDocument.cpp:
  27406. (WebCore::MediaTokenizer::createDocumentStructure):
  27407. * loader/PluginDocument.cpp:
  27408. (WebCore::PluginTokenizer::createDocumentStructure):
  27409. * loader/TextDocument.cpp:
  27410. (WebCore::TextTokenizer::write):
  27411. * page/Frame.cpp:
  27412. (WebCore::Frame::selectionComputedStyle):
  27413. (WebCore::Frame::styleForSelectionStart):
  27414. Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
  27415. * xml/XPathFunctions.cpp:
  27416. (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
  27417. * page/DragController.cpp:
  27418. (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
  27419. 2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
  27420. Reviewed by Eric Seidel.
  27421. https://bugs.webkit.org/show_bug.cgi?id=24060
  27422. Fix up to accommodate for CanvasPixelArray return.
  27423. * platform/graphics/skia/ImageBufferSkia.cpp:
  27424. (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
  27425. (WebCore::ImageBuffer::putImageData): Ditto.
  27426. 2009-02-20 Eric Carlson <eric.carlson@apple.com>
  27427. Simon Fraser
  27428. https://bugs.webkit.org/show_bug.cgi?id=24042
  27429. Bug 24042: MediaPlayer should cache plug-in proxy
  27430. The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
  27431. MediaPlayer will always have created the private media player object before
  27432. the plug-in is instantiated and calls back with the proxy object. This is not
  27433. true on all platforms because of threading latency, so MediaPlayer should
  27434. cache the plug-in proxy so it can pass it to the media engine at a later time.
  27435. * platform/graphics/MediaPlayer.cpp:
  27436. (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
  27437. (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
  27438. (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
  27439. (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
  27440. (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
  27441. (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
  27442. * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
  27443. 2009-02-20 Eric Carlson <eric.carlson@apple.com>
  27444. Simon Fraser.
  27445. https://bugs.webkit.org/show_bug.cgi?id=24063
  27446. Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
  27447. * html/HTMLMediaElement.cpp:
  27448. (WebCore::HTMLMediaElement::HTMLMediaElement): Rename m_loadRestrictions to m_Restrictions.
  27449. Initialize m_internalCall.
  27450. (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
  27451. (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
  27452. (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
  27453. (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
  27454. (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
  27455. (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
  27456. (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
  27457. (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
  27458. (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
  27459. (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
  27460. * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
  27461. add RequireUserGestureRateChangeRestriction.
  27462. 2009-02-20 Darin Fisher <darin@chromium.org>
  27463. Fix build bustage in FileSystemWin.cpp.
  27464. Need to return CString() instead of 0 since there are now two CString
  27465. constructors that take a pointer type.
  27466. * platform/win/FileSystemWin.cpp:
  27467. (WebCore::openTemporaryFile):
  27468. 2009-02-20 Dimitri Glazkov <dglazkov@chromium.org>
  27469. Reviewed by Sam Weinig.
  27470. https://bugs.webkit.org/show_bug.cgi?id=23999
  27471. Change license headers to accurately reflect code history.
  27472. * platform/ContentType.cpp:
  27473. * platform/ContentType.h:
  27474. 2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>
  27475. Reviewed by Antti Koivisto.
  27476. https://bugs.webkit.org/show_bug.cgi?id=23999
  27477. Split off MIME type parsing into its own class.
  27478. * GNUmakefile.am: Added ContentType sources.
  27479. * WebCore.pro: Ditto.
  27480. * WebCore.scons: Ditto.
  27481. * WebCore.vcproj/WebCore.vcproj: Ditto.
  27482. * WebCore.xcodeproj/project.pbxproj: Ditto.
  27483. * WebCoreSources.bkl: Ditto.
  27484. * html/HTMLMediaElement.cpp: Changed to use ContentType.
  27485. (WebCore::HTMLMediaElement::selectMediaURL):
  27486. * platform/ContentType.cpp: Added.
  27487. (WebCore::ContentType::ContentType):
  27488. (WebCore::ContentType::parameter):
  27489. (WebCore::ContentType::type):
  27490. * platform/ContentType.h: Added.
  27491. (WebCore::ContentType::raw):
  27492. * platform/MIMETypeRegistry.cpp:
  27493. * platform/MIMETypeRegistry.h:
  27494. * platform/graphics/MediaPlayer.cpp:
  27495. (WebCore::MediaPlayer::load):
  27496. * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
  27497. * rendering/style/RenderStyleConstants.h: Ditto.
  27498. (WebCore::):
  27499. 2009-02-20 Holger Hans Peter Freyther <zecke@selfish.org>
  27500. Unreviewed build fix.
  27501. Use CString() instead of 0.
  27502. * platform/gtk/FileSystemGtk.cpp:
  27503. (WebCore::openTemporaryFile):
  27504. * platform/qt/FileSystemQt.cpp:
  27505. (WebCore::openTemporaryFile):
  27506. 2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
  27507. Reviewed by Holger Freyther.
  27508. When dealing with local files, use a path instead of an URI. GFile
  27509. has problems decoding URIs with percent signs on them.
  27510. * platform/network/soup/ResourceHandleSoup.cpp:
  27511. (WebCore::ResourceHandle::startGio):
  27512. 2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
  27513. Reviewed by Holger Freyther.
  27514. Protect the ResourceHandle instance from being destroyed by
  27515. didReceiveData inside the GIO readCallback call, so that
  27516. cancelling caused by scripts is handled correctly.
  27517. * platform/network/soup/ResourceHandleSoup.cpp:
  27518. (WebCore::readCallback):
  27519. 2009-02-20 David Kilzer <ddkilzer@apple.com>
  27520. Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors
  27521. Reviewed by Sam Weinig.
  27522. * loader/icon/IconDatabaseNone.cpp:
  27523. (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL().
  27524. (WebCore::IconDatabase::open): Commented out unused parameter.
  27525. (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto.
  27526. (WebCore::IconDatabase::iconForPageURL): Ditto.
  27527. (WebCore::IconDatabase::iconURLForPageURL): Ditto.
  27528. (WebCore::IconDatabase::defaultIcon): Ditto.
  27529. (WebCore::IconDatabase::retainIconForPageURL): Ditto.
  27530. (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
  27531. (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
  27532. (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
  27533. (WebCore::IconDatabase::setEnabled): Ditto.
  27534. (WebCore::IconDatabase::pageURLMappingCount): Added stub.
  27535. (WebCore::IconDatabase::retainedPageURLCount): Ditto.
  27536. (WebCore::IconDatabase::iconRecordCount): Ditto.
  27537. (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
  27538. 2009-02-20 David Kilzer <ddkilzer@apple.com>
  27539. Add comment to generated code when shadowing a built-in object
  27540. Reviewed by Sam Weinig.
  27541. * bindings/scripts/CodeGeneratorJS.pm: Added comment to
  27542. generated code output.
  27543. 2009-02-20 Avi Drissman <avi@chromium.org>
  27544. Reviewed by Eric Seidel.
  27545. https://bugs.webkit.org/show_bug.cgi?id=24036
  27546. Keyboard events need disambiguation on the Linux platform too.
  27547. * platform/chromium/PlatformKeyboardEventChromium.cpp:
  27548. (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
  27549. 2009-02-19 Darin Fisher <darin@chromium.org>
  27550. Reviewed by Eric Seidel.
  27551. https://bugs.webkit.org/show_bug.cgi?id=24046
  27552. Several improvements to CString:
  27553. 1- Make it possible to initialize a CString from a CStringBuffer
  27554. 2- Make it possible to get a CStringBuffer from a CString
  27555. 3- Change CStringBuffer::data() to return a const pointer to ward off mutation
  27556. 4- Remove unused releaseBuffer() methods.
  27557. 5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.
  27558. * platform/text/CString.cpp:
  27559. (WebCore::CString::init):
  27560. (WebCore::CString::mutableData):
  27561. (WebCore::CString::newUninitialized):
  27562. (WebCore::CString::copyBufferIfNeeded):
  27563. * platform/text/CString.h:
  27564. (WebCore::CStringBuffer::data):
  27565. (WebCore::CStringBuffer::length):
  27566. (WebCore::CStringBuffer::create):
  27567. (WebCore::CStringBuffer::mutableData):
  27568. (WebCore::CString::CString):
  27569. (WebCore::CString::buffer):
  27570. 2009-02-19 Dmitry Titov <dimich@chromium.org>
  27571. Reviewed by Alexey Proskuryakov.
  27572. https://bugs.webkit.org/show_bug.cgi?id=24017
  27573. Remove some usage of Document in Worker.
  27574. * dom/WorkerContext.h:
  27575. (WebCore::WorkerContext::userAgent):
  27576. * dom/Document.cpp:
  27577. (WebCore::Document::userAgent):
  27578. * dom/Document.h:
  27579. * dom/ScriptExecutionContext.h:
  27580. Added virtual ScriptExecutionContext::userAgent(const KURL&).
  27581. Document implementation uses FrameLoader::userAgent and
  27582. WorkerContext receives the string on creation and stores it in a member.
  27583. * dom/Worker.cpp:
  27584. (WebCore::Worker::Worker):
  27585. (WebCore::Worker::notifyFinished):
  27586. * dom/Worker.h:
  27587. (WebCore::Worker::create):
  27588. Instead of Document the Worker constructor now gets a ScriptExecutionContext.
  27589. Start using some methods on SEC (like completeURL() and userAgent()).
  27590. For others, explicitly case to Document and add a FIXME.
  27591. Remove Worker::document() too.
  27592. 2009-02-20 Gustavo Noronha Silva <gns@gnome.org>
  27593. Rubber-stamped by Holger Freyther.
  27594. Do not set httpStatus to SOUP_STATUS_OK when serving local files
  27595. to match other ports' behavior, fixing xmlhttprequest test
  27596. regressions.
  27597. * platform/network/soup/ResourceHandleSoup.cpp:
  27598. (WebCore::queryInfoCallback):
  27599. 2009-02-19 Dan Bernstein <mitz@apple.com>
  27600. Reviewed by Sam Weinig.
  27601. - WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
  27602. Do not send loader callbacks during CSS styling
  27603. Undo the iChat-specific quirk added in
  27604. <http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
  27605. cache client callbacks during attach() and recalcStyle().
  27606. * WebCore.base.exp: Removed
  27607. Settings::setNeedsIChatMemoryCacheCallsQuirk().
  27608. * dom/ContainerNode.cpp:
  27609. (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory
  27610. cache client callbacks and remember to enable them afterwards if needed.
  27611. (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory
  27612. cache client callbacks if they were disabled in
  27613. suspendPostAttachCallbacks().
  27614. (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and
  27615. resumePostAttachCallbacks().
  27616. * dom/ContainerNode.h: Made suspendPostAttachCallbacks()
  27617. and resumePostAttachCallbacks() non-static.
  27618. * dom/Document.cpp:
  27619. (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific
  27620. workaround.
  27621. * page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and
  27622. related code.
  27623. (WebCore::Settings::Settings):
  27624. * page/Settings.h:
  27625. 2009-02-19 Holger Hans Peter Freyther <zecke@selfish.org>
  27626. Unreviewed build fix.
  27627. Build fix after r41092. Make the memoryUsage method
  27628. public. It will be shadowed by cf/mac and for curl/soup/qt
  27629. the implementation from ResourceResponseBase will be used.
  27630. * platform/network/ResourceResponseBase.h:
  27631. (WebCore::ResourceResponseBase::memoryUsage):
  27632. 2009-02-19 Beth Dakin <bdakin@apple.com>
  27633. Reviewed by Dave Hyatt.
  27634. Fix for <rdar://problem/6077775> Should be able to specify
  27635. inactive ::selection color
  27636. This patch makes the ::selction pseudo-element work with
  27637. the :window-inactive pseudo type. This was, a user can specify a
  27638. different ::selection style when a window is inactive.
  27639. * css/CSSStyleSelector.cpp:
  27640. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  27641. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  27642. * rendering/RenderObject.cpp:
  27643. (WebCore::RenderObject::selectionBackgroundColor):
  27644. (WebCore::RenderObject::selectionForegroundColor):
  27645. 2009-02-19 Sam Weinig <sam@webkit.org>
  27646. Reviewed by Beth Dakin.
  27647. Patch for https://bugs.webkit.org/show_bug.cgi?id=24044
  27648. Update querySelector/querySelectorAll to match the latest spec
  27649. Update querySelector and querySelectorAll to match the latest version
  27650. of the Selectors API spec. We now stringify null and undefined to "null"
  27651. and "undefined" respectively instead of to "".
  27652. Test: fast/dom/SelectorAPI/undefined-null-stringify.html
  27653. * dom/Document.idl:
  27654. * dom/DocumentFragment.idl:
  27655. * dom/Element.idl:
  27656. 2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
  27657. Reviewed by Geoffrey Garen.
  27658. https://bugs.webkit.org/show_bug.cgi?id=23732
  27659. Rework CachedResource overhead accounting to allow platforms to diverge
  27660. in numbers.
  27661. * loader/CachedResource.cpp:
  27662. (WebCore::CachedResource::overheadSize): Changed to ask ResourceResponse
  27663. for its size and to use actual URL size.
  27664. * platform/network/ResourceResponseBase.h:
  27665. (WebCore::ResourceResponseBase::size): Added default size method.
  27666. * platform/network/cf/ResourceResponse.h:
  27667. (WebCore::ResourceResponse::size): Added Win/CF size method
  27668. * platform/network/mac/ResourceResponse.h:
  27669. (WebCore::ResourceResponse::size): Added Mac size method.
  27670. 2009-02-19 Anders Carlsson <andersca@apple.com>
  27671. Reviewed by Kevin Decker.
  27672. - Fix for <rdar://problem/6604968>
  27673. On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
  27674. after the call to -[NSView displayRectIgnoringOpacity:inContext:].
  27675. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  27676. (WebCore::MediaPlayerPrivate::paint):
  27677. 2009-02-19 David Hyatt <hyatt@apple.com>
  27678. Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
  27679. also consider reflections to be part of their visual overflow. This had already been done for blocks
  27680. and lines, but it wasn't being done yet for replaced elements.
  27681. Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
  27682. transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
  27683. layer it pushed until we're done painting the real object (rather than the reflection).
  27684. Reviewed by Dan Bernstein
  27685. Added fast/reflections/reflection-masks-opacity.html
  27686. * rendering/RenderLayer.cpp:
  27687. (WebCore::RenderLayer::paintLayer):
  27688. * rendering/RenderPartObject.cpp:
  27689. (WebCore::RenderPartObject::layout):
  27690. * rendering/RenderReplaced.cpp:
  27691. (WebCore::RenderReplaced::layout):
  27692. (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect):
  27693. * rendering/RenderReplaced.h:
  27694. 2009-02-19 David Levin <levin@chromium.org>
  27695. Reviewed by Alexey Proskuryakov.
  27696. Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode.
  27697. <https://bugs.webkit.org/show_bug.cgi?id=23980>
  27698. WorkerRunLoop has the ability to run in a mode which filters the tasks to be run.
  27699. * When WorkerRunLoop::runInMode is called, only task for that mode will run.
  27700. * When WorkerRunLoop::run is called (or the default mode is used), then all tasks
  27701. will run regardless of their posted mode.
  27702. Here's a demonstration of the api:
  27703. RefPtr<NameResolution> nameResolution = NameResolution::create(workerRunLoop);
  27704. // Internally nameResolution will do workerRunLoop.postTaskForMode(task, "MyCoolMode")
  27705. // for any tasks that need to be run during this loop.
  27706. nameResolution->setTaskMode("MyCoolMode");
  27707. nameResolution->start();
  27708. while (!nameResolution->done()) {
  27709. // Only tasks which are posted for "MyCoolMode" will run.
  27710. workerRunLoop.runInMode(context, "MyCoolMode");
  27711. }
  27712. No observable change in behavior, so no test.
  27713. * dom/WorkerRunLoop.cpp:
  27714. (WebCore::ModePredicate::ModePredicate):
  27715. (WebCore::ModePredicate::operator()):
  27716. (WebCore::WorkerRunLoop::WorkerRunLoop):
  27717. (WebCore::WorkerRunLoop::~WorkerRunLoop):
  27718. (WebCore::WorkerRunLoop::setSharedTimer):
  27719. (WebCore::WorkerRunLoop::resetSharedTimer):
  27720. (WebCore::WorkerRunLoop::run):
  27721. (WebCore::WorkerRunLoop::runInMode):
  27722. (WebCore::WorkerRunLoop::postTask):
  27723. (WebCore::WorkerRunLoop::postTaskForMode):
  27724. * dom/WorkerRunLoop.h:
  27725. (WebCore::WorkerRunLoop::Task::create):
  27726. (WebCore::WorkerRunLoop::Task::mode):
  27727. (WebCore::WorkerRunLoop::Task::performTask):
  27728. (WebCore::WorkerRunLoop::Task::Task):
  27729. 2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
  27730. Reviewed by Eric Seidel.
  27731. https://bugs.webkit.org/show_bug.cgi?id=24034
  27732. Fix up Selection->VisibleSelection change.
  27733. * page/chromium/EventHandlerChromium.cpp:
  27734. (WebCore::EventHandler::passMousePressEventToSubframe): Renamed Selection
  27735. to VisibleSelection.
  27736. 2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
  27737. Reviewed by Eric Seidel.
  27738. https://bugs.webkit.org/show_bug.cgi?id=24041
  27739. Correct Skia type conversion issues, fix Chromium Linux build.
  27740. * platform/graphics/chromium/FontLinux.cpp:
  27741. (WebCore::Font::drawGlyphs): changed parameters to RGBA32, not WebCore::Color.
  27742. 2009-02-19 Jungshik Shin <jshin@chromium.org>
  27743. Reviewed by Eric Seidel.
  27744. https://bugs.webkit.org/show_bug.cgi?id=20531
  27745. Chromium-part follow-up to the patch landed in r40636
  27746. for bug 20531.
  27747. Remove a static member function alternateFamilyName
  27748. from Chromium's Win/Linux ports of FontCache. In r40636,
  27749. alternateFamilyName was customized using #ifdef PLATFORM(WIN_OS).
  27750. So, there's no more need for the static member function per
  27751. platform.
  27752. * platform/graphics/chromium/FontCacheChromiumWin.cpp:
  27753. * platform/graphics/chromium/FontCacheLinux.cpp:
  27754. 2009-02-19 Simon Fraser <simon.fraser@apple.com>
  27755. Reviewed by Adele Peterson.
  27756. Call documentWillBecomeInactive() from Document::detach to ensure that
  27757. media elements are shut down, because they may be kept alive by references
  27758. from JS past document teardown.
  27759. documentWillBecomeInactive() calls renderView()->willMoveOffscreen(), so no
  27760. need to do that in detach() as well.
  27761. We no longer need to call documentWillBecomeInactive() from ~Page() (which
  27762. was added for <https://bugs.webkit.org/show_bug.cgi?id=21116>), since this
  27763. supersedes that change.
  27764. * dom/Document.cpp:
  27765. (WebCore::Document::detach):
  27766. * page/Page.cpp:
  27767. (WebCore::Page::~Page):
  27768. 2009-02-19 Dimitri Glazkov <dglazkov@chromium.org>
  27769. Reviewed by Eric Seidel.
  27770. https://bugs.webkit.org/show_bug.cgi?id=24028
  27771. Fix up Skia path changes.
  27772. * platform/graphics/skia/GraphicsContextSkia.cpp:
  27773. (WebCore::GraphicsContext::strokePath): Removed illegal indirection.
  27774. * platform/graphics/skia/PathSkia.cpp:
  27775. (WebCore::boundingBoxForCurrentStroke): Changed call name.
  27776. 2009-02-19 Gustavo Noronha Silva <gns@gnome.org>
  27777. Reviewed by Alexey Proskuryakov.
  27778. Ignore ports on local URLs. This fixes a regression in
  27779. fast/loader/file-URL-with-port-number.html
  27780. * platform/network/soup/ResourceHandleSoup.cpp:
  27781. (WebCore::ResourceHandle::startGio):
  27782. 2009-02-19 Gustavo Noronha Silva <gns@gnome.org>
  27783. Reviewed by Alexey Proskuryakov.
  27784. https://bugs.webkit.org/show_bug.cgi?id=24011
  27785. KURL's setPort doesn't unset port if 0 is given
  27786. Make setPort remove port if 0 is given to it, as promised by the
  27787. comment in KURL's header.
  27788. * platform/KURL.cpp:
  27789. (WebCore::KURL::setPort):
  27790. 2009-02-18 Dan Bernstein <mitz@apple.com>
  27791. Reviewed by Brady Eidson.
  27792. - WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
  27793. The crash results from re-entry into
  27794. CSSMutableStyleDeclaration::setCssText, which in turn is caused by
  27795. the first style change causing a cached image to load from the memory
  27796. cache, causing load delegate dispatch, and iChat's delegate method
  27797. calling back into WebKit.
  27798. The workaround is to use defer delegate callbacks for memory cache. In
  27799. this case, deferring callbacks during image load event dispatch was
  27800. found to be sufficient.
  27801. The crash is a regression. See also the discussion in
  27802. <https://bugs.webkit.org/show_bug.cgi?id=22521>.
  27803. * WebCore.base.exp: Added
  27804. Settings::setNeedsIChatMemoryCacheCallsQuirk().
  27805. * dom/Document.cpp:
  27806. (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is
  27807. enabled, defer memory cache callbacks during image load event dispatch.
  27808. * page/Settings.cpp:
  27809. (WebCore::Settings::Settings): Initialize
  27810. m_needsIChatMemoryCacheCallsQuirk.
  27811. (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this
  27812. setter.
  27813. * page/Settings.h:
  27814. (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.
  27815. 2009-02-18 Adam Roben <aroben@apple.com>
  27816. Export WebCore::handCursor and Cursor.h
  27817. Reviewed by John Sullivan.
  27818. * WebCore.base.exp: Added WebCore::handCursor.
  27819. * WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.
  27820. 2009-02-18 Ojan Vafai <ojan@chromium.org>
  27821. Reviewed by Alexey Proskuryakov.
  27822. https://bugs.webkit.org/show_bug.cgi?id=23992
  27823. REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do
  27824. Unable to reduce to a layout test.
  27825. * page/Frame.cpp:
  27826. (WebCore::Frame::contentRenderer):
  27827. 2009-02-18 Evan Stade <estade@chromium.org>
  27828. Reviewed by Eric Seidel.
  27829. https://bugs.webkit.org/show_bug.cgi?id=23861
  27830. Stroke font outlines on chromium linux
  27831. TEST=LayoutTests/svg/custom/pointer-events-text.svg
  27832. * platform/graphics/chromium/FontLinux.cpp:
  27833. (WebCore::Font::drawGlyphs):
  27834. 2009-02-18 Evan Stade <estade@chromium.org>
  27835. Reviewed by Eric Seidel.
  27836. https://bugs.webkit.org/show_bug.cgi?id=23860
  27837. Resync some graphics/skia files with their chromium counterparts
  27838. This comes from chromium patches <http://codereview.chromium.org/17633>
  27839. and <http://codereview.chromium.org/17454>
  27840. * platform/graphics/skia/GraphicsContextSkia.cpp:
  27841. (WebCore::GraphicsContext::clipPath):
  27842. (WebCore::GraphicsContext::fillPath):
  27843. * platform/graphics/skia/PlatformContextSkia.cpp:
  27844. (PlatformContextSkia::addPath):
  27845. (PlatformContextSkia::currentPath):
  27846. * platform/graphics/skia/PlatformContextSkia.h:
  27847. 2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
  27848. Unreviewed.
  27849. Build fix after r41060.
  27850. * GNUmakefile.am:
  27851. 2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>
  27852. Reviewed by Eric Seidel.
  27853. https://bugs.webkit.org/show_bug.cgi?id=24005
  27854. Add an include to fix Chromium build.
  27855. * page/animation/AnimationController.cpp: Add UnusedParam.h include.
  27856. 2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
  27857. Reviewed by Holger Freyther.
  27858. Fix symbols.filter location, and add other missing files to the
  27859. autotools build, so that make dist works.
  27860. * GNUmakefile.am:
  27861. 2009-02-18 Zan Dobersek <zandobersek@gmail.com>
  27862. Rubber-stamped by Holger Hans Peter Freyther.
  27863. Allow POST method for local requests.
  27864. * platform/network/soup/ResourceHandleSoup.cpp:
  27865. (WebCore::ResourceHandle::startGio):
  27866. 2009-02-18 Gustavo Noronha Silva <gns@gnome.org>
  27867. Reviewed by Holger Hans Peter Freyther.
  27868. Use KURL in startGio instead of passing a string with the URL, so
  27869. that we can handle removing refs and queries more elegantly. This
  27870. is fixing more regressions that came from the curl->soup switch.
  27871. Original work by Zan Dobersek.
  27872. * platform/network/ResourceHandle.h:
  27873. * platform/network/soup/ResourceHandleSoup.cpp:
  27874. (WebCore::ResourceHandle::start):
  27875. (WebCore::ResourceHandle::startGio):
  27876. 2009-02-18 Holger Hans Peter Freyther <zecke@selfish.org>
  27877. Reviewed by Alexey Proskuryakov.
  27878. Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp
  27879. The implementation is needed to have synchronous loading, e.g. for
  27880. JavaScript interaction. This is fixing various regressions that
  27881. came from the curl->soup switch.
  27882. * platform/network/soup/ResourceHandleSoup.cpp:
  27883. (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
  27884. (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
  27885. (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
  27886. (WebCore::WebCoreSynchronousLoader::didReceiveData):
  27887. (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  27888. (WebCore::WebCoreSynchronousLoader::didFail):
  27889. (WebCore::WebCoreSynchronousLoader::run):
  27890. (WebCore::ResourceHandle::loadResourceSynchronously):
  27891. 2009-02-18 Xan Lopez <xan@gnome.org>
  27892. Reviewed by Mark Rowe.
  27893. https://bugs.webkit.org/show_bug.cgi?id=23989
  27894. Based on a patch by Bo Yang <techrazy.yang@gmail.com>
  27895. Make the cursor cache global, that's all we really need and
  27896. otherwise we can miss cursor transitions in some situations (see
  27897. the bug for one testcase). Also remove some now useless code.
  27898. * platform/Widget.h:
  27899. * platform/gtk/WidgetGtk.cpp:
  27900. (WebCore::Widget::Widget):
  27901. (WebCore::Widget::~Widget):
  27902. (WebCore::Widget::setCursor):
  27903. 2009-02-17 Adam Roben <aroben@apple.com>
  27904. Windows build fix
  27905. * loader/FrameLoader.cpp:
  27906. (WebCore::toPlugInElement): Don't rely on #if being processed before
  27907. ASSERT.
  27908. 2009-02-17 David Levin <levin@chromium.org>
  27909. Reviewed by Alexey Proskuryakov.
  27910. Bug 23977: Unnecessary timer related headers in files.
  27911. <https://bugs.webkit.org/show_bug.cgi?id=23977>
  27912. No observable change in behavior, so no test.
  27913. * dom/Document.cpp:
  27914. * dom/WorkerRunLoop.cpp:
  27915. * dom/WorkerRunLoop.h:
  27916. 2009-02-17 Peter Abrahamsen <rainhead@gmail.com>
  27917. Reviewed by Sam Weinig.
  27918. https://bugs.webkit.org/show_bug.cgi?id=23958
  27919. <rdar://problem/6587815>
  27920. Updated XMLHttpRequest with new header names from the latest Access
  27921. Control draft: http://www.w3.org/TR/access-control/
  27922. - Access-Control-Origin becomes Access-Control-Allow-Origin
  27923. - Access-Control-Credentials becomes Access-Control-Allow-Credentials
  27924. * xml/XMLHttpRequest.cpp:
  27925. (WebCore::XMLHttpRequest::accessControlCheck):
  27926. 2009-02-17 Kevin Ollivier <kevino@theolliviers.com>
  27927. wx build fix. Add missing constructor used for empty values.
  27928. * platform/graphics/wx/FontPlatformData.h:
  27929. (WebCore::FontPlatformData::FontPlatformData):
  27930. 2009-02-17 Antti Koivisto <antti@apple.com>
  27931. Reviewed by Dave Kilzer.
  27932. <rdar://problem/6592446> dynamically updating page doesn't seem to draw when updated
  27933. Need update after callback.
  27934. * bindings/js/JSCustomPositionCallback.cpp:
  27935. (WebCore::JSCustomPositionCallback::handleEvent):
  27936. * bindings/js/JSCustomPositionErrorCallback.cpp:
  27937. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  27938. 2009-02-17 Eric Carlson <eric.carlson@apple.com>
  27939. Reviewed by Antti Koivisto.
  27940. https://bugs.webkit.org/show_bug.cgi?id=23917
  27941. Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
  27942. element.
  27943. * DerivedSources.make: add media element proxy exports to .exp file when feature is defined.
  27944. * WebCore.VideoProxy.exp: New, define the informal protocol exported by a media element proxy.
  27945. * WebCore.xcodeproj/project.pbxproj: Add MediaPlayerProxy.h.
  27946. * html/HTMLMediaElement.cpp:
  27947. (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_needWidgetUpdate.
  27948. (WebCore::HTMLMediaElement::attributeChanged): Don't detach+attach when PLUGIN_PROXY_FOR_VIDEO, the
  27949. proxy plug-in handles the poster frame.
  27950. (WebCore::HTMLMediaElement::rendererIsNeeded): New logic for PLUGIN_PROXY_FOR_VIDEO.
  27951. (WebCore::HTMLMediaElement::createRenderer): Create RenderPartObject when PLUGIN_PROXY_FOR_VIDEO.
  27952. (WebCore::HTMLMediaElement::attach): Set m_needWidgetUpdate when PLUGIN_PROXY_FOR_VIDEO
  27953. (WebCore::HTMLMediaElement::load): Don't reallocate MediaPlayer when PLUGIN_PROXY_FOR_VIDEO, we keep the
  27954. same plug-in for the life of the element.
  27955. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): update m_networkState when media player
  27956. network state changes to EMPTY, otherwise we can get out of sync with engine.
  27957. (WebCore::HTMLMediaElement::defaultEventHandler): pass event to widget when PLUGIN_PROXY_FOR_VIDEO
  27958. (WebCore::HTMLMediaElement::deliverNotification): New, deliver notification from proxy plug-in to
  27959. media player.
  27960. (WebCore::HTMLMediaElement::setMediaPlayerProxy): New, pass proxy object to media player.
  27961. (WebCore::HTMLMediaElement::initialURL): New, return the url from the "src" attr or the appropriate
  27962. <source> element to be used as the initial url for the proxy.
  27963. (WebCore::HTMLMediaElement::finishParsingChildren): New, allocate MediaPlayer and update widget.
  27964. * html/HTMLMediaElement.h: Declare new methods for proxy, add m_needWidgetUpdate.
  27965. (WebCore::HTMLMediaElement::setNeedWidgetUpdate):
  27966. * html/HTMLVideoElement.cpp:
  27967. (WebCore::HTMLVideoElement::attach): Poster image is handled by proxy when PLUGIN_PROXY_FOR_VIDEO.
  27968. (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
  27969. * html/HTMLVideoElement.h:
  27970. * loader/FrameLoader.cpp:
  27971. (WebCore::toPlugInElement): Allow cast if element is <video> or <audio>
  27972. * platform/graphics/MediaPlayer.cpp:
  27973. (WebCore::MediaPlayer::MediaPlayer): Remove white space.
  27974. (WebCore::MediaPlayer::setPoster): New, forward call to private player.
  27975. (WebCore::MediaPlayer::deliverNotification): Ditto.
  27976. (WebCore::MediaPlayer::setMediaPlayerProxy): Ditto.
  27977. * platform/graphics/MediaPlayer.h:
  27978. (WebCore::MediaPlayer::mediaPlayerClient):
  27979. * platform/graphics/mac/MediaPlayerProxy.h: New, defines media player proxy interface.
  27980. * rendering/RenderPart.cpp:
  27981. (WebCore::RenderPart::RenderPart): Change constructor to take Element* instead of Node* as a
  27982. non-element node doesn't need a renderer
  27983. * rendering/RenderPart.h: Ditto.
  27984. * rendering/RenderPartObject.cpp:
  27985. (WebCore::RenderPartObject::RenderPartObject): Ditto.
  27986. (WebCore::RenderPartObject::updateWidget): Package params for proxy plug-in when element is
  27987. <video> or <audio>.
  27988. * rendering/RenderPartObject.h:
  27989. 2009-02-17 David Hyatt <hyatt@apple.com>
  27990. Reviewed by Eric Seidel
  27991. Fix for https://bugs.webkit.org/show_bug.cgi?id=23985
  27992. Don't allow legends to be anything but display:block.
  27993. Added fast/forms/inline-ignored-on-legend.html
  27994. * GNUmakefile.am:
  27995. * WebCore.pro:
  27996. * WebCore.vcproj/WebCore.vcproj:
  27997. * WebCore.xcodeproj/project.pbxproj:
  27998. * WebCoreSources.bkl:
  27999. * css/html4.css:
  28000. * html/HTMLLegendElement.cpp:
  28001. * html/HTMLLegendElement.h:
  28002. * rendering/RenderLegend.cpp: Removed.
  28003. * rendering/RenderLegend.h: Removed.
  28004. * wml/WMLInsertedLegendElement.cpp:
  28005. * wml/WMLInsertedLegendElement.h:
  28006. 2009-02-13 Brett Wilson <brettw@dhcp-172-22-71-167.mtv.corp.google.com>
  28007. Reviewed by Simon Fraser.
  28008. https://bugs.webkit.org/attachment.cgi?id=27666
  28009. Fix Chromium build build: forgotten include in RenderObject, sync
  28010. RenderTheme to the recent changes in RenderObject.
  28011. * rendering/RenderObject.cpp:
  28012. * rendering/RenderThemeChromiumMac.mm:
  28013. (WebCore::RenderThemeChromiumMac::updatePressedState):
  28014. 2009-02-17 Gustavo Noronha Silva <gns@gnome.org>
  28015. Reviewed by Darin Adler.
  28016. https://bugs.webkit.org/show_bug.cgi?id=22966
  28017. crash when destroying a webview that opened a page containing <script>
  28018. tags
  28019. Fix m_group being set to 0 instead of to m_singlePageGroup when
  28020. GroupName is set to empty
  28021. * page/Page.cpp:
  28022. (WebCore::Page::setGroupName):
  28023. 2009-02-16 Beth Dakin <bdakin@apple.com>
  28024. Reviewed by Sam Weinig.
  28025. Fix for <rdar://problem/6386623>
  28026. I made m_numParsedProperties and m_maxParsedProperties unsigned
  28027. instead of int, and then added an early return from addPropery() if
  28028. m_maxParsedProperties exceeds the max value.
  28029. * css/CSSParser.cpp:
  28030. (WebCore::CSSParser::addProperty):
  28031. (WebCore::CSSParser::rollbackLastProperties):
  28032. (WebCore::CSSParser::clearProperties):
  28033. (WebCore::CSSParser::createFontFaceRule):
  28034. (WebCore::CSSParser::deleteFontFaceOnlyValues):
  28035. * css/CSSParser.h:
  28036. 2009-02-16 Justin Garcia <justin.garcia@apple.com>
  28037. Reviewed by Mark Rowe.
  28038. https://bugs.webkit.org/show_bug.cgi?id=16309
  28039. HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
  28040. When we originally implemented this command, MSDN documentation said that IE set the
  28041. id attribute of inserted lists to the third argument to execCommand, but IE doesn't
  28042. do this nor do any other browsers.
  28043. * editing/EditorCommand.cpp:
  28044. (WebCore::executeInsertOrderedList):
  28045. (WebCore::executeInsertUnorderedList):
  28046. * editing/IndentOutdentCommand.cpp:
  28047. (WebCore::IndentOutdentCommand::outdentParagraph):
  28048. * editing/InsertListCommand.cpp:
  28049. (WebCore::InsertListCommand::insertList):
  28050. (WebCore::InsertListCommand::InsertListCommand):
  28051. (WebCore::InsertListCommand::doApply):
  28052. * editing/InsertListCommand.h:
  28053. (WebCore::InsertListCommand::create):
  28054. 2009-02-16 Dan Bernstein <mitz@apple.com>
  28055. Reviewed by Geoffrey Garen.
  28056. - fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
  28057. Test: platform/mac/fast/events/pointer-events-dashboard.html
  28058. * css/CSSStyleSelector.cpp:
  28059. (WebCore::CSSStyleSelector::applyProperty): Do not apply the
  28060. pointer-events property in Dashboard backwards compatibility mode,
  28061. in order to work around misuse of that property by the Stocks widget.
  28062. 2009-02-16 Justin Garcia <justin.garcia@apple.com>
  28063. Reviewed by Eric Seidel.
  28064. https://bugs.webkit.org/show_bug.cgi?id=15381
  28065. execCommand justify modifies the contentEditable node
  28066. * editing/CompositeEditCommand.cpp:
  28067. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just
  28068. the body element, but any root editable element.
  28069. 2009-02-16 Chris Fleizach <cfleizach@apple.com>
  28070. Reviewed by Adele Peterson.
  28071. Bug 23979: AX: alt tag not returned for <input type="image">
  28072. https://bugs.webkit.org/show_bug.cgi?id=23979
  28073. Test: accessibility/input-image-alt.html
  28074. * page/AccessibilityRenderObject.cpp:
  28075. (WebCore::AccessibilityRenderObject::accessibilityDescription):
  28076. 2009-02-16 Kevin Watters <kevinwatters@gmail.com>
  28077. Reviewed by Kevin Ollivier.
  28078. The ref data is not properly set unless we use the CreateMatrix function.
  28079. https://bugs.webkit.org/show_bug.cgi?id=23978
  28080. * platform/graphics/wx/TransformationMatrixWx.cpp:
  28081. (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
  28082. 2009-02-16 Dan Bernstein <mitz@apple.com>
  28083. Reviewed by John Sullivan.
  28084. - fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
  28085. * platform/graphics/FontCache.cpp:
  28086. (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the
  28087. FontPlatformData(float, bool, bool) constructor.
  28088. * platform/graphics/mac/FontCacheMac.mm:
  28089. (WebCore::FontCache::createFontPlatformData): Changed to pass a valid
  28090. NSFont to the FontPlatformData constructor, instead of implicitly
  28091. passing 0 and then calling setFont().
  28092. * platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter
  28093. of the constructor mandatory.
  28094. 2009-02-15 David Kilzer <ddkilzer@apple.com>
  28095. Move duplicate caretWidth constants to RenderObject.h
  28096. Reviewed by Dan Bernstein.
  28097. No test since no change in behavior.
  28098. * rendering/RenderBlock.cpp:
  28099. (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
  28100. * rendering/RenderBox.cpp:
  28101. (WebCore::RenderBox::localCaretRect): Ditto.
  28102. * rendering/RenderObject.h: Added caretWidth definition.
  28103. * rendering/RenderText.cpp:
  28104. (WebCore::RenderText::localCaretRect): Removed caretWidth.
  28105. 2009-02-13 Dimitri Glazkov <dglazkov@chromium.org>
  28106. Reviewed by Eric Seidel.
  28107. https://bugs.webkit.org/show_bug.cgi?id=23955
  28108. V8HTMLPlugInCustom returns undefined, which fools interceptors.
  28109. * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  28110. (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value.
  28111. (WebCore::NAMED_PROPERTY_SETTER): Ditto.
  28112. (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
  28113. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
  28114. 2009-02-13 Dimitri Glazkov <dglazkov@chromium.org>
  28115. Reviewed by Eric Seidel.
  28116. https://bugs.webkit.org/show_bug.cgi?id=23954
  28117. Add V8 custom bindings for CanvasRenderingContext2D.
  28118. * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Added.
  28119. (WebCore::toV8):
  28120. (WebCore::toCanvasStyle):
  28121. (WebCore::ACCESSOR_GETTER):
  28122. (WebCore::ACCESSOR_SETTER):
  28123. 2009-02-13 Anders Carlsson <andersca@apple.com>
  28124. Reviewed by Darin Adler and Dan Bernstein.
  28125. <rdar://problem/6583187>
  28126. * page/NavigatorBase.cpp:
  28127. Handle PPC64 and X86_64 as well.
  28128. 2009-02-13 Darin Adler <darin@apple.com>
  28129. Reviewed by Mark Rowe.
  28130. Fix broken tokenizer regression test that reflected a lifetime bug
  28131. in the document.write optimization. The test failure was trivial to
  28132. reproduce in COLLECT_ON_EVERY_ALLOCATION mode.
  28133. * bindings/js/JSHTMLDocumentCustom.cpp:
  28134. (WebCore::documentWrite): Convert strings to String rather than passing
  28135. the pointer and length to SegmentedString. The optimization is thus
  28136. mostly gone. However, there are two ways to bring it back: 1) Apply
  28137. the patch that makes UString and String share the same buffers.
  28138. 2) Add a UString feature to SegmentedString; simple to do but might
  28139. risk slowing down normal document parsing.
  28140. 2009-02-13 Adam Treat <adam.treat@torchmobile.com>
  28141. Caught by Darin Adler.
  28142. No reason to check m_tokenizer twice for 0 in a row.
  28143. * dom/Document.cpp:
  28144. (WebCore::Document::write):
  28145. 2009-02-13 Lyon Chen <lyon.chen@torchmobile.com>
  28146. Reviewed by Dave Hyatt.
  28147. Take into account y() + height() when calculating getLowerRightCorner.
  28148. * dom/ContainerNode.cpp:
  28149. (WebCore::ContainerNode::getLowerRightCorner):
  28150. 2009-02-13 Antti Koivisto <antti@apple.com>
  28151. Reviewed by Dave Hyatt.
  28152. Most of this code was in RenderBox, restore the copyright lines.
  28153. * rendering/RenderBoxModelObject.cpp:
  28154. * rendering/RenderBoxModelObject.h:
  28155. 2009-02-13 David Hyatt <hyatt@apple.com>
  28156. Get rid of printBoxDecorations, since it is dead code.
  28157. Reviewed by Dan Bernstein
  28158. * rendering/RenderObject.h:
  28159. 2009-02-13 Adam Treat <adam.treat@torchmobile.com>
  28160. Reviewed by Darin Adler.
  28161. https://bugs.webkit.org/show_bug.cgi?id=23952
  28162. Add Document::write overload which takes a SegmentedString since this
  28163. is what the tokenizer expects anyway. Modified JSHTMLDocument so it once
  28164. again calls Document::write instead of injecting the string directly into
  28165. the tokenizer. This ensures that all document.write's are funneled through
  28166. one method again, but should still be just as fast for JSHTMLDocumentCustom.
  28167. * bindings/js/JSHTMLDocumentCustom.cpp:
  28168. (WebCore::documentWrite):
  28169. * dom/Document.cpp:
  28170. (WebCore::Document::write):
  28171. * dom/Document.h:
  28172. 2009-02-13 David Hyatt <hyatt@apple.com>
  28173. Reviewed by Simon Fraser
  28174. Remove updateWidgetPosition on RenderObject. Change RenderView's set of widgets
  28175. to have a tighter type: RenderWidget instead of RenderObject. Devirtualize
  28176. updateWidgetPosition, since all RenderWidgets (except for applets) are now
  28177. RenderParts also.
  28178. * rendering/RenderObject.cpp:
  28179. * rendering/RenderObject.h:
  28180. * rendering/RenderPart.cpp:
  28181. * rendering/RenderPart.h:
  28182. * rendering/RenderView.cpp:
  28183. (WebCore::RenderView::updateWidgetPositions):
  28184. (WebCore::RenderView::addWidget):
  28185. (WebCore::RenderView::removeWidget):
  28186. * rendering/RenderView.h:
  28187. * rendering/RenderWidget.cpp:
  28188. (WebCore::RenderWidget::updateWidgetPosition):
  28189. * rendering/RenderWidget.h:
  28190. 2009-02-13 David Hyatt <hyatt@apple.com>
  28191. Reviewed by Eric Seidel
  28192. Remove isEditable() on RenderObject. It is dead code.
  28193. * rendering/RenderObject.cpp:
  28194. * rendering/RenderObject.h:
  28195. 2009-02-13 David Hyatt <hyatt@apple.com>
  28196. Reviewed by Eric Seidel
  28197. Add isTextControl() to RenderObject. Patch call sites thats asked isTextField() || isTextArea() to just use
  28198. isTextControl() instead.
  28199. Add a toRenderTextControl converter for doing checked casting to RenderTextControls.
  28200. * dom/Document.cpp:
  28201. (WebCore::Document::setFocusedNode):
  28202. * dom/InputElement.cpp:
  28203. (WebCore::InputElement::updateSelectionRange):
  28204. * editing/ReplaceSelectionCommand.cpp:
  28205. (WebCore::ReplacementFragment::ReplacementFragment):
  28206. * editing/TextIterator.cpp:
  28207. (WebCore::TextIterator::handleReplacedElement):
  28208. * html/HTMLInputElement.cpp:
  28209. (WebCore::HTMLInputElement::selectionStart):
  28210. (WebCore::HTMLInputElement::selectionEnd):
  28211. (WebCore::HTMLInputElement::setSelectionStart):
  28212. (WebCore::HTMLInputElement::setSelectionEnd):
  28213. (WebCore::HTMLInputElement::select):
  28214. (WebCore::HTMLInputElement::defaultEventHandler):
  28215. (WebCore::HTMLInputElement::selection):
  28216. * html/HTMLTextAreaElement.cpp:
  28217. (WebCore::HTMLTextAreaElement::selectionStart):
  28218. (WebCore::HTMLTextAreaElement::selectionEnd):
  28219. (WebCore::HTMLTextAreaElement::setSelectionStart):
  28220. (WebCore::HTMLTextAreaElement::setSelectionEnd):
  28221. (WebCore::HTMLTextAreaElement::select):
  28222. (WebCore::HTMLTextAreaElement::setSelectionRange):
  28223. (WebCore::HTMLTextAreaElement::appendFormData):
  28224. (WebCore::HTMLTextAreaElement::updateValue):
  28225. (WebCore::HTMLTextAreaElement::selection):
  28226. * page/AccessibilityRenderObject.cpp:
  28227. (WebCore::AccessibilityRenderObject::isNativeTextControl):
  28228. (WebCore::AccessibilityRenderObject::text):
  28229. (WebCore::AccessibilityRenderObject::selectedText):
  28230. (WebCore::AccessibilityRenderObject::selectedTextRange):
  28231. (WebCore::AccessibilityRenderObject::setSelectedTextRange):
  28232. (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
  28233. (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  28234. (WebCore::AccessibilityRenderObject::observableObject):
  28235. * page/Frame.cpp:
  28236. (WebCore::Frame::notifyRendererOfSelectionChange):
  28237. * rendering/RenderObject.h:
  28238. (WebCore::RenderObject::isTextControl):
  28239. (WebCore::objectIsRelayoutBoundary):
  28240. * rendering/RenderTextControl.h:
  28241. (WebCore::RenderTextControl::isTextControl):
  28242. (WebCore::toRenderTextControl):
  28243. * rendering/TextControlInnerElements.cpp:
  28244. (WebCore::TextControlInnerTextElement::defaultEventHandler):
  28245. * wml/WMLInputElement.cpp:
  28246. (WebCore::WMLInputElement::select):
  28247. (WebCore::WMLInputElement::defaultEventHandler):
  28248. (WebCore::WMLInputElement::isConformedToInputMask):
  28249. 2009-02-13 David Hyatt <hyatt@apple.com>
  28250. Get rid of isEdited/setEdited on RenderObject. Devirtualize isEdited/setEdited on RenderTextControl.
  28251. Callers were already asking if the renderer was a text field (or a text area), so it was especially
  28252. pointless to waste a second virtual function call after making one just to determine the object type.
  28253. Reviewed by Simon Fraser
  28254. * dom/Document.cpp:
  28255. (WebCore::Document::setFocusedNode):
  28256. * html/HTMLInputElement.cpp:
  28257. (WebCore::HTMLInputElement::defaultEventHandler):
  28258. * rendering/RenderObject.h:
  28259. * rendering/RenderTextControl.h:
  28260. (WebCore::RenderTextControl::isEdited):
  28261. (WebCore::RenderTextControl::setEdited):
  28262. 2009-02-13 Scott Violet <sky@google.com>
  28263. Reviewed by Eric Seidel.
  28264. https://bugs.webkit.org/show_bug.cgi?id=23934
  28265. Skia platform doesn't render text decoration shadows.
  28266. Makes Skia render text decoration shadows correctly. We weren't
  28267. preparing the SkPaint correctly and didn't have a couple of checks
  28268. CG has. Additionally makes the fillColor/strokeColor methods
  28269. consistent.
  28270. This behavior is covered by existing layout tests (see bug for list).
  28271. * platform/graphics/chromium/FontChromiumWin.cpp:
  28272. (WebCore::Font::drawGlyphs):
  28273. (WebCore::Font::drawComplexText):
  28274. * platform/graphics/skia/GraphicsContextSkia.cpp:
  28275. (WebCore::GraphicsContext::drawLineForText):
  28276. * platform/graphics/skia/PlatformContextSkia.cpp:
  28277. (PlatformContextSkia::effectiveFillColor):
  28278. (PlatformContextSkia::effectiveStrokeColor):
  28279. * platform/graphics/skia/PlatformContextSkia.h:
  28280. 2009-02-12 Darin Fisher <darin@chromium.org>
  28281. Reviewed by Eric Seidel.
  28282. https://bugs.webkit.org/show_bug.cgi?id=23944
  28283. KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
  28284. * platform/KURL.h:
  28285. * platform/KURLGoogle.cpp:
  28286. (WebCore::KURLGooglePrivate::setUtf8):
  28287. (WebCore::KURLGooglePrivate::setAscii):
  28288. (WebCore::KURLGooglePrivate::init):
  28289. (WebCore::KURLGooglePrivate::replaceComponents):
  28290. (WebCore::KURL::KURL):
  28291. * platform/KURLGooglePrivate.h:
  28292. 2009-02-13 David Hyatt <hyatt@apple.com>
  28293. Remove leftmost/rightmost/lowestPosition from RenderObject. They only need to be called on boxes.
  28294. Reviewed by Dan Bernstein
  28295. * rendering/RenderBlock.cpp:
  28296. (WebCore::RenderBlock::lowestPosition):
  28297. (WebCore::RenderBlock::rightmostPosition):
  28298. (WebCore::RenderBlock::leftmostPosition):
  28299. * rendering/RenderLayer.cpp:
  28300. (WebCore::RenderLayer::computeScrollDimensions):
  28301. * rendering/RenderMedia.cpp:
  28302. (WebCore::RenderMedia::lowestPosition):
  28303. (WebCore::RenderMedia::rightmostPosition):
  28304. (WebCore::RenderMedia::leftmostPosition):
  28305. * rendering/RenderObject.h:
  28306. * rendering/RenderTableSection.cpp:
  28307. (WebCore::RenderTableSection::lowestPosition):
  28308. (WebCore::RenderTableSection::rightmostPosition):
  28309. (WebCore::RenderTableSection::leftmostPosition):
  28310. 2009-02-12 Simon Fraser <simon.fraser@apple.com>
  28311. Fix build with ACCELERATED_COMPOSITING turned on.
  28312. toRenderBox()->x() asserts for a layer on an inline; use
  28313. m_owningLayer->renderBoxX() instead.
  28314. * rendering/RenderLayerBacking.cpp:
  28315. (WebCore::RenderLayerBacking::paintIntoLayer):
  28316. 2009-02-12 Darin Adler <darin@apple.com>
  28317. Reviewed by Oliver Hunt.
  28318. Speed up document.write a bit.
  28319. * bindings/js/JSHTMLDocumentCustom.cpp:
  28320. (WebCore::documentWrite): Added. Uses SegmentedString to avoid conversion from
  28321. UString to String and to avoid appending strings. Also added code to handle
  28322. newlines efficiently.
  28323. (WebCore::JSHTMLDocument::write): Changed to use documentWrite.
  28324. (WebCore::JSHTMLDocument::writeln): Ditto.
  28325. * dom/Document.cpp:
  28326. (WebCore::Document::prepareToWrite): Added. Refactored the initialization part
  28327. of write into a separate function for use in the JavaScript binding.
  28328. (WebCore::Document::write): Changed to call prepareToWrite.
  28329. * dom/Document.h: Added declaration for prepareToWrite.
  28330. 2009-02-13 Prasanth Ullattil <pullatti@trolltech.com>
  28331. Reviewed by Simon Hausmann.
  28332. Fixes crash in the Qt port on Windows with comboboxes
  28333. The focusWidget in the input context is not reset properly.
  28334. The QApplication::setFocusWidget() wont reset the IC if the reason is
  28335. PopupFocusReason, this is not ideal. For the time being we are going
  28336. to do this from webkit itself.
  28337. * platform/qt/QWebPopup.cpp:
  28338. (WebCore::QWebPopup::hidePopup):
  28339. 2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
  28340. wx build fix, typo while tweaking last patch for commit.
  28341. * platform/wx/wxcode/gtk/fontprops.cpp:
  28342. (GetTextExtent):
  28343. 2009-02-12 miggilin <mr.diggilin@gmail.com>
  28344. Reviewed by Kevin Ollivier.
  28345. Use Cairo/PANGO to fix text measurements and implement proper
  28346. non-kerned text drawing on wxGTK.
  28347. https://bugs.webkit.org/show_bug.cgi?id=17727
  28348. * platform/graphics/GlyphBuffer.h:
  28349. * platform/graphics/wx/FontPlatformDataWx.cpp:
  28350. (WebCore::fontWeightToWxFontWeight):
  28351. * platform/graphics/wx/SimpleFontDataWx.cpp:
  28352. (WebCore::SimpleFontData::platformWidthForGlyph):
  28353. * platform/wx/wxcode/fontprops.h:
  28354. * platform/wx/wxcode/gtk/fontprops.cpp:
  28355. (wxFontProperties::wxFontProperties):
  28356. (GetTextExtent):
  28357. * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
  28358. (WebCore::pangoFontMap):
  28359. (WebCore::createPangoFontForFont):
  28360. (WebCore::createScaledFontForFont):
  28361. (WebCore::pango_font_get_glyph):
  28362. (WebCore::drawTextWithSpacing):
  28363. * platform/wx/wxcode/non-kerned-drawing.h:
  28364. 2009-02-12 Chris Marrin <cmarrin@apple.com>
  28365. Reviewed by Simon Fraser
  28366. https://bugs.webkit.org/show_bug.cgi?id=23942
  28367. Hook up 3D CSS transforms to the accelerated compositor backend.
  28368. Not enabled by default.
  28369. * page/animation/AnimationBase.cpp:
  28370. (WebCore::blendFunc):
  28371. (WebCore::ensurePropertyMap):
  28372. * page/animation/CompositeAnimation.cpp:
  28373. (WebCore::CompositeAnimationPrivate::updateTransitions):
  28374. * page/animation/ImplicitAnimation.cpp:
  28375. (WebCore::ImplicitAnimation::willNeedService):
  28376. * page/animation/KeyframeAnimation.cpp:
  28377. (WebCore::KeyframeAnimation::willNeedService):
  28378. * platform/graphics/GraphicsLayer.cpp:
  28379. (WebCore::GraphicsLayer::TransformValueList::makeFunctionList):
  28380. (WebCore::GraphicsLayer::dumpProperties):
  28381. * platform/graphics/mac/GraphicsLayerCA.mm:
  28382. (WebCore::copyTransform):
  28383. (WebCore::getValueFunctionNameForTransformOperation):
  28384. (WebCore::GraphicsLayerCA::animateTransform):
  28385. * rendering/RenderBox.cpp:
  28386. (WebCore::RenderBox::updateBoxModelInfoFromStyle):
  28387. * rendering/RenderLayer.cpp:
  28388. (WebCore::RenderLayer::updateTransform):
  28389. (WebCore::RenderLayer::hasTransformStyle3D):
  28390. (WebCore::RenderLayer::hasPerspective):
  28391. (WebCore::RenderLayer::perspectiveTransform):
  28392. * rendering/RenderLayer.h:
  28393. * rendering/RenderLayerBacking.cpp:
  28394. (WebCore::RenderLayerBacking::updateGraphicsLayers):
  28395. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  28396. (WebCore::RenderLayerBacking::computeTransformOrigin):
  28397. (WebCore::RenderLayerBacking::computePerspectiveOrigin):
  28398. * rendering/RenderLayerBacking.h:
  28399. * rendering/RenderLayerCompositor.cpp:
  28400. (WebCore::RenderLayerCompositor::has3DContent):
  28401. (WebCore::requiresCompositingLayerForTransform):
  28402. (WebCore::RenderLayerCompositor::requiresCompositingLayer):
  28403. (WebCore::RenderLayerCompositor::layerHas3DContent):
  28404. * rendering/RenderLayerCompositor.h:
  28405. 2009-02-12 David Hyatt <hyatt@apple.com>
  28406. Reviewed by Eric Seidel
  28407. Get rid of containingBlockHeight(), since it had only one implementation (despite being virtual) and just returned
  28408. containingBlock()->availableHeight(). The latter reads better anyway. Rename containingBlockWidth() to
  28409. containingBlockWidthForContent() and move it to RenderBoxModelObject.
  28410. * rendering/RenderBlock.cpp:
  28411. (WebCore::RenderBlock::localCaretRect):
  28412. * rendering/RenderBox.cpp:
  28413. (WebCore::RenderBox::containingBlockWidthForContent):
  28414. (WebCore::RenderBox::calcWidth):
  28415. (WebCore::RenderBox::calcReplacedWidthUsing):
  28416. * rendering/RenderBox.h:
  28417. * rendering/RenderBoxModelObject.cpp:
  28418. (WebCore::RenderBoxModelObject::relativePositionOffsetX):
  28419. (WebCore::RenderBoxModelObject::relativePositionOffsetY):
  28420. (WebCore::RenderBoxModelObject::containingBlockWidthForContent):
  28421. * rendering/RenderBoxModelObject.h:
  28422. * rendering/RenderInline.cpp:
  28423. (WebCore::RenderInline::marginLeft):
  28424. (WebCore::RenderInline::marginRight):
  28425. * rendering/RenderObject.cpp:
  28426. * rendering/RenderObject.h:
  28427. * rendering/RenderSVGContainer.cpp:
  28428. (WebCore::RenderSVGContainer::calcReplacedWidth):
  28429. 2009-02-12 Simon Fraser <simon.fraser@apple.com>
  28430. Fix non-Mac builds by adding Matrix3DTransformOperation.* and
  28431. PerspectiveTransformOperation.*. Cleaned out some cruft in
  28432. the WebCore.vcproj fle.
  28433. * GNUmakefile.am:
  28434. * WebCore.pro:
  28435. * WebCore.scons:
  28436. * WebCore.vcproj/WebCore.vcproj:
  28437. 2009-02-12 David Smith <catfish.man@gmail.com>
  28438. Reviewed by Dave Hyatt.
  28439. Fix https://bugs.webkit.org/show_bug.cgi?id=23935
  28440. Nested :not() and non-simple selectors in :not() should be invalid
  28441. * css/CSSGrammar.y: Reject nested :not()
  28442. * css/CSSStyleSelector.cpp:
  28443. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ASSERT() rather than checking, since the parser enforces it now
  28444. 2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
  28445. wx build fixes.
  28446. * WebCoreSources.bkl:
  28447. 2009-02-12 Simon Fraser <simon.fraser@apple.com>
  28448. Fix build with ACCELERATED_COMPOSITING turned on.
  28449. Need to cast toRenderBox() in order to call overflowClipRect().
  28450. * rendering/RenderLayerBacking.cpp:
  28451. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  28452. 2009-02-12 Oliver Hunt <oliver@apple.com>
  28453. Reviewed by NOBODY (Build fix).
  28454. Fix windows build.
  28455. * css/CSSParser.h:
  28456. 2009-02-12 David Hyatt <hyatt@apple.com>
  28457. Rename getOverflowClipRect and getClipRect to overflowClipRect and clipRect. Move them to RenderBox, since these methods
  28458. only apply to boxes. Devirtualize clipRect, since it was not subclassed. Move controlClip stuff to RenderBox also.
  28459. Reviewed by Simon Fraser
  28460. * editing/Editor.cpp:
  28461. (WebCore::Editor::insideVisibleArea):
  28462. * rendering/RenderBox.cpp:
  28463. (WebCore::RenderBox::overflowClipRect):
  28464. (WebCore::RenderBox::clipRect):
  28465. * rendering/RenderBox.h:
  28466. (WebCore::RenderBox::hasControlClip):
  28467. (WebCore::RenderBox::controlClipRect):
  28468. * rendering/RenderForeignObject.cpp:
  28469. (WebCore::RenderForeignObject::paint):
  28470. * rendering/RenderLayer.cpp:
  28471. (WebCore::RenderLayer::calculateClipRects):
  28472. (WebCore::RenderLayer::calculateRects):
  28473. * rendering/RenderLayerBacking.cpp:
  28474. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  28475. * rendering/RenderObject.h:
  28476. (WebCore::RenderObject::hasClip):
  28477. (WebCore::RenderObject::hasOverflowClip):
  28478. * rendering/RenderTable.cpp:
  28479. (WebCore::RenderTable::overflowClipRect):
  28480. * rendering/RenderTable.h:
  28481. 2009-02-12 Simon Fraser <simon.fraser@apple.com>
  28482. Fix build with ACCELERATED_COMPOSITING turned on (simple copy/paste error)
  28483. * platform/graphics/mac/GraphicsLayerCA.mm:
  28484. (WebCore::GraphicsLayerCA::setBasicAnimation):
  28485. 2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
  28486. Not reviewed.
  28487. Release build fix when VIDEO is disabled (it should also
  28488. help the builds with WORKERS or XSLT disabled).
  28489. * bindings/js/JSDOMWindowBase.cpp:
  28490. (jsDOMWindowBaseAudio): Added an UNUSED_PARAM for exec and slot when
  28491. VIDEO is disabled.
  28492. (jsDOMWindowBaseWorker): Ditto for WORKERS.
  28493. (jsDOMWindowBaseXSLTProcessor): Ditto for XSLT.
  28494. 2009-02-12 Eric Carlson <eric.carlson@apple.com>
  28495. Reviewed by Simon Fraser.
  28496. https://bugs.webkit.org/show_bug.cgi?id=23923
  28497. Implement mediaPlayerVolumeChanged so a media engine can report autonomous volume changes.
  28498. Supporting this requires that we know when we are processing a media engine callback so
  28499. we don't turn around and tell the media player to change the volume when it is reporting
  28500. a volume change.
  28501. * html/HTMLMediaElement.cpp:
  28502. (WebCore::HTMLMediaElement::HTMLMediaElement): initialize m_processingMediaPlayerCallback
  28503. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): call begin/endProcessingMediaPlayerCallback
  28504. (WebCore::HTMLMediaElement::setNetworkState): logic split out of mediaPlayerNetworkStateChanged
  28505. to make it easier to maintain m_processingMediaPlayerCallback.
  28506. (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): call begin/endProcessingMediaPlayerCallback
  28507. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
  28508. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Ditto.
  28509. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): New
  28510. (WebCore::HTMLMediaElement::updateVolume): Don't change media engine volume if we are processing
  28511. a callback from the engine.
  28512. * html/HTMLMediaElement.h:
  28513. (WebCore::HTMLMediaElement::processingMediaPlayerCallback): New, return true if (m_processingMediaPlayerCallback>0)
  28514. (WebCore::HTMLMediaElement::beginProcessingMediaPlayerCallback): New, increment m_processingMediaPlayerCallback
  28515. (WebCore::HTMLMediaElement::endProcessingMediaPlayerCallback): New, decrement m_processingMediaPlayerCallback
  28516. 2009-02-12 Eric Carlson <eric.carlson@apple.com>
  28517. Reviewed by Simon Fraser.
  28518. Support MPEG content on Mac and Windows.
  28519. <rdar://problem/5917509>
  28520. https://bugs.webkit.org/show_bug.cgi?id=23495
  28521. Test: media/audio-mpeg-supported.html
  28522. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  28523. (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
  28524. * platform/graphics/win/QTMovieWin.cpp:
  28525. (QTMovieWin::disableUnsupportedTracks):
  28526. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: fix typo added in r40925
  28527. 2009-02-12 David Hyatt <hyatt@apple.com>
  28528. Reviewed by Sam Weinig
  28529. Move containsFloats, hasOverhangingFloats, shrinkToAvoidFloats and avoidsFloats down to
  28530. RenderBox, since these methods only apply to boxes.
  28531. * rendering/RenderBlock.cpp:
  28532. (WebCore::RenderBlock::collapseMargins):
  28533. (WebCore::RenderBlock::clearFloatsIfNeeded):
  28534. (WebCore::RenderBlock::layoutBlockChildren):
  28535. (WebCore::RenderBlock::clearFloats):
  28536. (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  28537. (WebCore::RenderBlock::calcBlockPrefWidths):
  28538. * rendering/RenderBlock.h:
  28539. (WebCore::RenderBlock::containsFloats):
  28540. (WebCore::RenderBlock::hasOverhangingFloats):
  28541. * rendering/RenderBox.cpp:
  28542. (WebCore::RenderBox::shrinkToAvoidFloats):
  28543. (WebCore::RenderBox::avoidsFloats):
  28544. * rendering/RenderBox.h:
  28545. * rendering/RenderObject.cpp:
  28546. * rendering/RenderObject.h:
  28547. (WebCore::RenderObject::isFloatingOrPositioned):
  28548. * rendering/RenderView.h:
  28549. 2009-02-12 Chris Marrin <cmarrin@apple.com>
  28550. Reviewed by Dave Hyatt
  28551. https://bugs.webkit.org/show_bug.cgi?id=23908
  28552. Added parsing of 3d transform functions and properties
  28553. (perspective, perspective-origin, transform-style-3d,
  28554. and backface-visibility).
  28555. Test: transforms/3d/cssmatrix-3d-interface.xhtml
  28556. * css/CSSComputedStyleDeclaration.cpp:
  28557. (WebCore::):
  28558. (WebCore::computedTransform):
  28559. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  28560. * css/CSSMutableStyleDeclaration.cpp:
  28561. (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  28562. * css/CSSParser.cpp:
  28563. (WebCore::CSSParser::parseValue):
  28564. (WebCore::CSSParser::parseFillProperty):
  28565. (WebCore::CSSParser::parseTransformOriginShorthand):
  28566. (WebCore::TransformOperationInfo::TransformOperationInfo):
  28567. (WebCore::CSSParser::parseTransform):
  28568. (WebCore::CSSParser::parseTransformOrigin):
  28569. (WebCore::CSSParser::parsePerspectiveOrigin):
  28570. * css/CSSParser.h:
  28571. * css/CSSPrimitiveValue.h:
  28572. (WebCore::CSSPrimitiveValue::isUnitTypeLength):
  28573. * css/CSSPropertyNames.in:
  28574. * css/CSSStyleSelector.cpp:
  28575. (WebCore::CSSStyleSelector::adjustRenderStyle):
  28576. (WebCore::convertToLength):
  28577. (WebCore::CSSStyleSelector::applyProperty):
  28578. (WebCore::CSSStyleSelector::mapFillSize):
  28579. (WebCore::CSSStyleSelector::mapFillXPosition):
  28580. (WebCore::CSSStyleSelector::mapFillYPosition):
  28581. (WebCore::getTransformOperationType):
  28582. (WebCore::CSSStyleSelector::createTransformOperations):
  28583. * css/CSSValueKeywords.in:
  28584. * css/WebKitCSSTransformValue.cpp:
  28585. (WebCore::WebKitCSSTransformValue::cssText):
  28586. * css/WebKitCSSTransformValue.h:
  28587. (WebCore::WebKitCSSTransformValue::):
  28588. * css/WebKitCSSTransformValue.idl:
  28589. * platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  28590. * platform/graphics/transforms/Matrix3DTransformOperation.h:
  28591. * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  28592. * platform/graphics/transforms/PerspectiveTransformOperation.h:
  28593. * platform/graphics/transforms/RotateTransformOperation.cpp:
  28594. (WebCore::RotateTransformOperation::blend):
  28595. * platform/graphics/transforms/RotateTransformOperation.h:
  28596. (WebCore::RotateTransformOperation::RotateTransformOperation):
  28597. * platform/graphics/transforms/ScaleTransformOperation.h:
  28598. (WebCore::ScaleTransformOperation::ScaleTransformOperation):
  28599. * platform/graphics/transforms/TransformOperation.h:
  28600. (WebCore::TransformOperation::is3DOperation):
  28601. * platform/graphics/transforms/TransformOperations.h:
  28602. (WebCore::TransformOperations::has3DOperation):
  28603. * platform/graphics/transforms/TranslateTransformOperation.h:
  28604. (WebCore::TranslateTransformOperation::TranslateTransformOperation):
  28605. 2009-02-12 Kevin Ollivier <kevino@theolliviers.com>
  28606. wx build fix.
  28607. * webcore-base.bkl:
  28608. 2009-02-12 Brady Eidson <beidson@apple.com>
  28609. Reviewed by Darin Adler
  28610. Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.
  28611. * platform/mac/SharedBufferMac.mm: Change to use RefPtr<> instead of ref()/deref().
  28612. (-[WebCoreSharedBufferData dealloc]):
  28613. (-[WebCoreSharedBufferData finalize]):
  28614. (-[WebCoreSharedBufferData initWithSharedBuffer:]):
  28615. 2009-02-12 David Hyatt <hyatt@apple.com>
  28616. Remove calcWidth from RenderObject. Nobody ever called it on RenderObjects.
  28617. Reviewed by Sam Weinig
  28618. * rendering/RenderObject.h:
  28619. 2009-02-12 David Hyatt <hyatt@apple.com>
  28620. Reviewed by Mark Rowe
  28621. Fix for regression where form controls would paint yellow highlights. The containsComposition check needs to
  28622. null check node() now.
  28623. * rendering/InlineTextBox.cpp:
  28624. (WebCore::InlineTextBox::paint):
  28625. 2009-02-12 Simon Fraser <simon.fraser@apple.com>
  28626. Build fix
  28627. Change Animation::setDirection() to take the new enum value, and fix
  28628. the single caller.
  28629. Fix build error in MediaPlayerPrivateQTKit.h.
  28630. * css/CSSStyleSelector.cpp:
  28631. (WebCore::CSSStyleSelector::mapAnimationDirection):
  28632. * platform/animation/Animation.h:
  28633. (WebCore::Animation::setDirection):
  28634. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  28635. 2009-02-12 David Hyatt <hyatt@apple.com>
  28636. Reviewed by Simon Fraser
  28637. Remove the overrideSize methods from RenderObject. Devirtualize all of the accessors on RenderBox.
  28638. * rendering/RenderBox.h:
  28639. * rendering/RenderObject.h:
  28640. 2009-02-12 Eric Carlson <eric.carlson@apple.com>
  28641. Darin Adler, Antti Koivisto, Holger Hans Peter Freyther
  28642. Bug 23797: A platform should be able to use more than one media engine for <video> and <audio>
  28643. https://bugs.webkit.org/show_bug.cgi?id=23797
  28644. * WebCore.xcodeproj/project.pbxproj: add MediaPlayerPrivate.h
  28645. * html/HTMLMediaElement.cpp:
  28646. (WebCore::HTMLMediaElement::load): selectMediaURL now also returns a MIME type, pass it to
  28647. MediaPlayer::load so it can choose the right media engine
  28648. (WebCore::HTMLMediaElement::selectMediaURL): renamed from pickMedia. use MIMETypeRegistry
  28649. functions to strip params from the url and extract the codecs parameter. call
  28650. MediaPlayer::supportsType to see if we can open the file since only a media engine can
  28651. answer questions about supported type+codecs.
  28652. * html/HTMLMediaElement.h:
  28653. * platform/MIMETypeRegistry.cpp:
  28654. (WebCore::MIMETypeRegistry::getParameterFromMIMEType): New, find and return a MIME type parameter
  28655. (WebCore::MIMETypeRegistry::stripParametersFromMIMEType): New, strip all parameters from a MIME type
  28656. * platform/MIMETypeRegistry.h:
  28657. * platform/graphics/MediaPlayer.cpp:
  28658. (WebCore::NullMediaPlayerPrivate::NullMediaPlayerPrivate):
  28659. (WebCore::NullMediaPlayerPrivate::load):
  28660. (WebCore::NullMediaPlayerPrivate::cancelLoad):
  28661. (WebCore::NullMediaPlayerPrivate::play):
  28662. (WebCore::NullMediaPlayerPrivate::pause):
  28663. (WebCore::NullMediaPlayerPrivate::naturalSize):
  28664. (WebCore::NullMediaPlayerPrivate::hasVideo):
  28665. (WebCore::NullMediaPlayerPrivate::setVisible):
  28666. (WebCore::NullMediaPlayerPrivate::duration):
  28667. (WebCore::NullMediaPlayerPrivate::currentTime):
  28668. (WebCore::NullMediaPlayerPrivate::seek):
  28669. (WebCore::NullMediaPlayerPrivate::seeking):
  28670. (WebCore::NullMediaPlayerPrivate::setEndTime):
  28671. (WebCore::NullMediaPlayerPrivate::setRate):
  28672. (WebCore::NullMediaPlayerPrivate::paused):
  28673. (WebCore::NullMediaPlayerPrivate::setVolume):
  28674. (WebCore::NullMediaPlayerPrivate::networkState):
  28675. (WebCore::NullMediaPlayerPrivate::readyState):
  28676. (WebCore::NullMediaPlayerPrivate::maxTimeSeekable):
  28677. (WebCore::NullMediaPlayerPrivate::maxTimeBuffered):
  28678. (WebCore::NullMediaPlayerPrivate::dataRate):
  28679. (WebCore::NullMediaPlayerPrivate::totalBytesKnown):
  28680. (WebCore::NullMediaPlayerPrivate::totalBytes):
  28681. (WebCore::NullMediaPlayerPrivate::bytesLoaded):
  28682. (WebCore::NullMediaPlayerPrivate::setRect):
  28683. (WebCore::NullMediaPlayerPrivate::paint):
  28684. (WebCore::createNullMediaPlayer):
  28685. Do nothing media player so MediaPlayer doesn't have to NULL check before calling current engine.
  28686. (WebCore::MediaPlayerFactory::MediaPlayerFactory): New, factory constructor.
  28687. (WebCore::installedMediaEngines): New, returns vector of all installed engines.
  28688. (WebCore::addMediaEngine): New, add a media engine to the cache.
  28689. (WebCore::chooseBestEngineForTypeAndCodecs): New, return an engine that might support a MIME type.
  28690. (WebCore::MediaPlayer::MediaPlayer): create NULL media player so we have a default. Initialize m_currentMediaEngine.
  28691. (WebCore::MediaPlayer::~MediaPlayer): don't need to delete m_private, it is now an OwnPtr.
  28692. (WebCore::MediaPlayer::load): Take MIME type as well as url, since we need it to find the right
  28693. media engine. If no MIME type is provided, try to devine one from the url. Choose a media engine
  28694. based on the MIME type and codecs parameter.
  28695. (WebCore::MediaPlayer::currentTime): Remove excess white space.
  28696. (WebCore::MediaPlayer::supportsType): Take codecs param as well as MIME type. Return enum so we can
  28697. indicate "maybe" condition.
  28698. (WebCore::MediaPlayer::getSupportedTypes): Build up list of MIME types by consulting all engines.
  28699. (WebCore::MediaPlayer::isAvailable): return true if any media engine is installed.
  28700. * platform/graphics/MediaPlayer.h:
  28701. (WebCore::MediaPlayer::):
  28702. (WebCore::MediaPlayer::frameView): accessor function.
  28703. * platform/graphics/MediaPlayerPrivate.h: New, declares abstract interface for media engines.
  28704. (WebCore::MediaPlayerPrivateInterface::~MediaPlayerPrivateInterface):
  28705. (WebCore::MediaPlayerPrivateInterface::totalBytesKnown):
  28706. * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Add support for engine factory
  28707. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  28708. (WebCore::MediaPlayerPrivate::create): New, media engine factory function
  28709. (WebCore::MediaPlayerPrivate::registerMediaEngine): Register engine with MediaPlayer factory
  28710. (WebCore::MediaPlayerPrivate::load): URL is a const String.
  28711. (WebCore::MediaPlayerPrivate::duration): Declare const.
  28712. (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
  28713. (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
  28714. (WebCore::MediaPlayerPrivate::networkState): Ditto.
  28715. (WebCore::MediaPlayerPrivate::readyState): Ditto.
  28716. (WebCore::MediaPlayerPrivate::maxTimeBuffered): Ditto.
  28717. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto.
  28718. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
  28719. (WebCore::MediaPlayerPrivate::bytesLoaded): Ditto.
  28720. (WebCore::MediaPlayerPrivate::totalBytesKnown): Ditto.
  28721. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
  28722. (WebCore::MediaPlayerPrivate::supportsType): Return MediaPlayer::SupportsType enum instead of bool.
  28723. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  28724. (WebCore::MediaPlayerPrivate::isAvailable):
  28725. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  28726. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  28727. (WebCore::MediaPlayerPrivateQTKit::create): New, media engine factory function
  28728. (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register engine with MediaPlayer factory
  28729. (WebCore::MediaPlayerPrivate::createQTMovieView): don't access MediaPlayer->m_frameView directly,
  28730. use accessor function.
  28731. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Ditto.
  28732. (WebCore::MediaPlayerPrivate::paint): Ditto.
  28733. (WebCore::mimeTypeCache): New.
  28734. (WebCore::MediaPlayerPrivate::getSupportedTypes): New, media engine factory function.
  28735. (WebCore::MediaPlayerPrivate::supportsType): return MediaPlayer::SupportsType enum instead of bool
  28736. (-[WebCoreMovieObserver initWithCallback:]): fix formatting
  28737. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  28738. (WebCore::MediaPlayerPrivate::create):
  28739. (WebCore::MediaPlayerPrivate::registerMediaEngine):
  28740. (WebCore::MediaPlayerPrivate::supportsType):
  28741. (WebCore::MediaPlayerPrivate::load): URL is a const String.
  28742. * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  28743. (WebCore::MediaPlayerPrivate::isAvailable):
  28744. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  28745. (WebCore::MediaPlayerPrivate::create): New, media engine factory function
  28746. (WebCore::MediaPlayerPrivate::registerMediaEngine): New, register engine with MediaPlayer factory
  28747. (WebCore::MediaPlayerPrivate::load): URL is a const String.
  28748. (WebCore::MediaPlayerPrivate::paint): don't access MediaPlayer->m_frameView directly,
  28749. use accessor function.
  28750. (WebCore::mimeTypeCache): New.
  28751. (WebCore::MediaPlayerPrivateQTWin::getSupportedTypes): New, media engine factory function.
  28752. (WebCore::MediaPlayerPrivateQTWin::supportsType): return MediaPlayer::SupportsType enum instead of bool
  28753. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  28754. 2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
  28755. Reviewed by Darin Adler.
  28756. Test: fast/dom/prefixed-image-tag.xhtml
  28757. Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
  28758. Instead we now directly propage the QualifiedName inside the generated Factory.
  28759. Test: fast/dom/prefixed-image-tag.xhtml
  28760. * dom/Document.cpp:
  28761. (WebCore::Document::createElement): Removed the setPrefix work-around
  28762. and replaced it with an ASSERT to catch mistakes inside the Factory code.
  28763. Remove the unneeded ExceptionCode argument.
  28764. (WebCore::Document::createElementNS): Removed ExceptionCode argument.
  28765. * dom/Document.h: Updated the signature.
  28766. * dom/XMLTokenizerLibxml2.cpp:
  28767. (WebCore::XMLTokenizer::startElementNs): Removed ExceptionCode argument.
  28768. * dom/XMLTokenizerQt.cpp: Ditto.
  28769. (WebCore::XMLTokenizer::parseStartElement): Ditto.
  28770. * dom/make_names.pl: Implemented the QualifiedName propogation logic
  28771. in the Factory.
  28772. 2009-02-12 Simon Fraser <simon.fraser@apple.com>
  28773. Reviewed by Dave Hyatt
  28774. https://bugs.webkit.org/show_bug.cgi?id=23188
  28775. Define enum values for Animation::direction(), and one for
  28776. IterationCountInfinite to make the code more self-documenting.
  28777. Order the member vars of Animation to optimize packing.
  28778. * css/CSSComputedStyleDeclaration.cpp:
  28779. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  28780. * platform/animation/Animation.cpp:
  28781. (WebCore::Animation::Animation):
  28782. (WebCore::Animation::operator=):
  28783. (WebCore::Animation::animationsMatch):
  28784. * platform/animation/Animation.h:
  28785. (WebCore::Animation::):
  28786. (WebCore::Animation::direction):
  28787. (WebCore::Animation::initialAnimationDirection):
  28788. * platform/graphics/mac/GraphicsLayerCA.mm:
  28789. (WebCore::GraphicsLayerCA::setBasicAnimation):
  28790. (WebCore::GraphicsLayerCA::setKeyframeAnimation):
  28791. 2009-02-12 Christian Dywan <christian@twotoasts.de>
  28792. Reviewed by Holger Freyther.
  28793. * platform/network/soup/ResourceHandleSoup.cpp:
  28794. (WebCore::ResourceHandle::startHttp): Don't use O_CLOEXEC for now.
  28795. 2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
  28796. Reviewed by Darin Adler.
  28797. Bug 23826: Potential bug with before/after rule while moving element from one document to another
  28798. Moved the document before/after toggle from the constructor to insertedIntoDocument.
  28799. Test: fast/css-generated-content/beforeAfter-interdocument.html
  28800. * html/HTMLQuoteElement.cpp:
  28801. (WebCore::HTMLQuoteElement::HTMLQuoteElement):
  28802. (WebCore::HTMLQuoteElement::insertedIntoDocument):
  28803. * html/HTMLQuoteElement.h:
  28804. 2009-02-12 David Hyatt <hyatt@apple.com>
  28805. Reviewed by Simon Fraser
  28806. Fix for https://bugs.webkit.org/show_bug.cgi?id=23912
  28807. I have no idea why this broke. As far as I can tell the old code never should have worked in
  28808. the first place. Add code to handleWheelEvent that will find an enclosing renderer for a node
  28809. in order to attempt a wheel scroll.
  28810. * page/EventHandler.cpp:
  28811. (WebCore::EventHandler::handleWheelEvent):
  28812. 2009-02-12 David Hyatt <hyatt@apple.com>
  28813. Move the functions that paint borders, box shadows and border images into RenderBoxModelObject. drawBorder and drawBorderArc, because they are used
  28814. for outlines as well as borders, need to stay in RenderObject. Rename them to drawLineForBoxSide and drawArcForBoxSide in order to reflect their
  28815. more generic use. Rename the BorderSide struct to BoxSide, since the concept of "side" is just a rectangle concept and not a border concept.
  28816. Reviewed by Simon Fraser
  28817. * rendering/InlineFlowBox.cpp:
  28818. (WebCore::InlineFlowBox::paintFillLayer):
  28819. (WebCore::InlineFlowBox::paintBoxShadow):
  28820. (WebCore::InlineFlowBox::paintBoxDecorations):
  28821. (WebCore::InlineFlowBox::paintMask):
  28822. * rendering/RenderBlock.cpp:
  28823. (WebCore::RenderBlock::paintColumns):
  28824. * rendering/RenderBoxModelObject.cpp:
  28825. (WebCore::RenderBoxModelObject::paintNinePieceImage):
  28826. (WebCore::RenderBoxModelObject::paintBorder):
  28827. (WebCore::RenderBoxModelObject::paintBoxShadow):
  28828. * rendering/RenderBoxModelObject.h:
  28829. * rendering/RenderFieldset.cpp:
  28830. (WebCore::RenderFieldset::paintBorderMinusLegend):
  28831. * rendering/RenderInline.cpp:
  28832. (WebCore::RenderInline::paintOutlineForLine):
  28833. * rendering/RenderObject.cpp:
  28834. (WebCore::RenderObject::drawLineForBoxSide):
  28835. (WebCore::RenderObject::drawArcForBoxSide):
  28836. (WebCore::RenderObject::paintOutline):
  28837. * rendering/RenderObject.h:
  28838. (WebCore::):
  28839. (WebCore::RenderObject::hasBoxDecorations):
  28840. * rendering/RenderTableCell.cpp:
  28841. (WebCore::CollapsedBorders::addBorder):
  28842. (WebCore::RenderTableCell::paintCollapsedBorder):
  28843. 2009-02-12 Eric Carlson <eric.carlson@apple.com>
  28844. Reviewed by Simon Fraser
  28845. Bug 18322: video element should have ui when scripting is disabled
  28846. https://bugs.webkit.org/show_bug.cgi?id=18322
  28847. * html/HTMLMediaElement.cpp:
  28848. (WebCore::HTMLMediaElement::controls): always return 'true' when JavaScript is disabled.
  28849. * manual-tests/media-controls-when-javascript-disabled.html: Added.
  28850. 2009-02-12 Dimitri Glazkov <dglazkov@chromium.org>
  28851. Reviewed by Eric Seidel.
  28852. https://bugs.webkit.org/show_bug.cgi?id=23906
  28853. Add custom V8 bindings for HTMLPlugInElement.
  28854. * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: Added.
  28855. (WebCore::NAMED_PROPERTY_GETTER):
  28856. (WebCore::NAMED_PROPERTY_SETTER):
  28857. (WebCore::CALLBACK_FUNC_DECL):
  28858. (WebCore::INDEXED_PROPERTY_GETTER):
  28859. (WebCore::INDEXED_PROPERTY_SETTER):
  28860. 2009-02-12 Gustavo Noronha Silva <gns@gnome.org>
  28861. Reviewed by Mark Rowe.
  28862. [GTK] Soup backend must handle upload of multiple files
  28863. https://bugs.webkit.org/show_bug.cgi?id=18343
  28864. * platform/network/soup/ResourceHandleSoup.cpp:
  28865. (WebCore::):
  28866. (WebCore::freeFileMapping):
  28867. (WebCore::ResourceHandle::startHttp): Support multipart request bodies
  28868. mmap'ing files to be uploaded.
  28869. 2009-02-12 Adam Treat <adam.treat@torchmobile.com>
  28870. Fix the Qt build following r40871 which changed RenderObject::element()
  28871. into RenderObject::node().
  28872. * platform/qt/RenderThemeQt.cpp:
  28873. (WebCore::RenderThemeQt::getMediaElementFromRenderObject):
  28874. (WebCore::RenderThemeQt::getMediaControlForegroundColor):
  28875. 2009-02-12 Alexey Proskuryakov <ap@webkit.org>
  28876. Build fix.
  28877. * platform/graphics/transforms/RotateTransformOperation.cpp: Include <algorithm>.
  28878. 2009-02-12 Jian Li <jianli@chromium.org>
  28879. Reviewed by Alexey Proskuryakov.
  28880. Change worker code to use different proxy class pointers.
  28881. https://bugs.webkit.org/show_bug.cgi?id=23859
  28882. This is a step towards using separate proxies in multi-process implementation.
  28883. * bindings/js/WorkerScriptController.cpp:
  28884. (WebCore::WorkerScriptController::evaluate):
  28885. * dom/Worker.cpp:
  28886. (WebCore::Worker::Worker):
  28887. (WebCore::Worker::~Worker):
  28888. (WebCore::Worker::postMessage):
  28889. (WebCore::Worker::terminate):
  28890. (WebCore::Worker::hasPendingActivity):
  28891. (WebCore::Worker::notifyFinished):
  28892. (WebCore::Worker::dispatchMessage):
  28893. * dom/Worker.h:
  28894. * dom/WorkerContext.cpp:
  28895. (WebCore::WorkerContext::~WorkerContext):
  28896. (WebCore::WorkerContext::reportException):
  28897. (WebCore::WorkerContext::addMessage):
  28898. (WebCore::WorkerContext::postMessage):
  28899. (WebCore::WorkerContext::dispatchMessage):
  28900. * dom/WorkerContext.h:
  28901. * dom/WorkerContextProxy.h:
  28902. * dom/WorkerMessagingProxy.cpp:
  28903. (WebCore::MessageWorkerContextTask::performTask):
  28904. (WebCore::MessageWorkerTask::performTask):
  28905. (WebCore::WorkerContextProxy::create):
  28906. (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
  28907. (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
  28908. (WebCore::WorkerMessagingProxy::startWorkerContext):
  28909. (WebCore::postConsoleMessageTask):
  28910. (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  28911. (WebCore::WorkerMessagingProxy::workerThreadCreated):
  28912. * dom/WorkerMessagingProxy.h:
  28913. * dom/WorkerObjectProxy.h:
  28914. * dom/WorkerThread.cpp:
  28915. (WebCore::WorkerThread::create):
  28916. (WebCore::WorkerThread::WorkerThread):
  28917. (WebCore::WorkerThread::workerThread):
  28918. * dom/WorkerThread.h:
  28919. (WebCore::WorkerThread::workerObjectProxy):
  28920. * loader/WorkerThreadableLoader.cpp:
  28921. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  28922. 2009-02-12 David Levin <levin@chromium.org>
  28923. Reviewed by Alexey Proskuryakov.
  28924. Bug 23688: ThreadableLoader needs a sync implementation for Workers.
  28925. <https://bugs.webkit.org/show_bug.cgi?id=23688>
  28926. Add ResourceError to ThreadableLoaderClient.
  28927. No observable change in behavior, so no test.
  28928. * loader/DocumentThreadableLoader.cpp:
  28929. (WebCore::DocumentThreadableLoader::create):
  28930. (WebCore::DocumentThreadableLoader::willSendRequest):
  28931. (WebCore::DocumentThreadableLoader::didFail):
  28932. * loader/ThreadableLoaderClient.h:
  28933. (WebCore::ThreadableLoaderClient::didFail):
  28934. (WebCore::ThreadableLoaderClient::didFailWillSendRequestCheck):
  28935. * loader/ThreadableLoaderClientWrapper.h:
  28936. (WebCore::ThreadableLoaderClientWrapper::didFail):
  28937. * loader/WorkerThreadableLoader.cpp:
  28938. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  28939. (WebCore::workerContextDidFail):
  28940. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
  28941. * loader/WorkerThreadableLoader.h:
  28942. * xml/XMLHttpRequest.cpp:
  28943. (WebCore::XMLHttpRequest::didFail):
  28944. (WebCore::XMLHttpRequest::didFailWillSendRequestCheck):
  28945. * xml/XMLHttpRequest.h:
  28946. 2009-02-11 Simon Fraser <simon.fraser@apple.com>
  28947. Reviewed by Dave Hyatt
  28948. Fix the build on Leopard with ACCELERATED_COMPOSITING turned on.
  28949. * WebCore.xcodeproj/project.pbxproj:
  28950. FloatPoint3D needs to be a private header, since it's included by GraphicsLayer.h
  28951. * platform/graphics/mac/GraphicsLayerCA.mm:
  28952. (WebCore::getTransformFunctionValue):
  28953. (WebCore::caValueFunctionSupported):
  28954. (WebCore::GraphicsLayerCA::setAnchorPoint):
  28955. (WebCore::GraphicsLayerCA::setPreserves3D):
  28956. (WebCore::GraphicsLayerCA::setContentsToImage):
  28957. (WebCore::GraphicsLayerCA::setBasicAnimation):
  28958. (WebCore::GraphicsLayerCA::setKeyframeAnimation):
  28959. * rendering/RenderLayer.h:
  28960. (WebCore::RenderLayer::isRootLayer):
  28961. Fix isRootLayer to return true for the renderView's layer, not the root
  28962. renderer's layer.
  28963. 2009-02-11 Adele Peterson <adele@apple.com>
  28964. Reviewed by Oliver Hunt.
  28965. Fix for https://bugs.webkit.org/show_bug.cgi?id=23910
  28966. <rdar://problem/6160546> REGRESSION: In Full page mode, movie controller hides when I drag the knob if movie is playing
  28967. * rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent):
  28968. When we get a mouseOut event, consider the mouse as still within the RenderMedia if the relatedTarget is a descendant.
  28969. 2009-02-11 David Hyatt <hyatt@apple.com>
  28970. Remove all of the inline box wrapper functions from RenderObject, since they only apply to RenderBox. Devirtualize the functions.
  28971. Patch all of the call sites to convert to a RenderBox.
  28972. Reviewed by Simon Fraser
  28973. * dom/Position.cpp:
  28974. (WebCore::nextRenderedEditable):
  28975. (WebCore::previousRenderedEditable):
  28976. (WebCore::Position::getInlineBoxAndOffset):
  28977. * rendering/InlineBox.cpp:
  28978. (WebCore::InlineBox::deleteLine):
  28979. (WebCore::InlineBox::extractLine):
  28980. (WebCore::InlineBox::attachLine):
  28981. * rendering/RenderLineBoxList.cpp:
  28982. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  28983. * rendering/RenderObject.cpp:
  28984. * rendering/RenderObject.h:
  28985. * rendering/RenderObjectChildList.cpp:
  28986. (WebCore::RenderObjectChildList::removeChildNode):
  28987. * rendering/RenderTextControl.cpp:
  28988. (WebCore::RenderTextControl::textWithHardLineBreaks):
  28989. 2009-02-11 David Hyatt <hyatt@apple.com>
  28990. Eliminate createInlineBox and dirtyLineBoxes from RenderObject. These functions have been devirtualized.
  28991. The single call site now calls a helper function that just bit checks and casts before calling the correct
  28992. type. RenderBlock's dirtyLineBoxes function was dead code (caused by the RenderFlow deletion), so it has
  28993. just been removed.
  28994. Reviewed by Eric Seidel
  28995. * rendering/RenderBR.cpp:
  28996. * rendering/RenderBR.h:
  28997. * rendering/RenderBlock.cpp:
  28998. (WebCore::RenderBlock::createRootInlineBox):
  28999. * rendering/RenderBlock.h:
  29000. * rendering/RenderBox.cpp:
  29001. (WebCore::RenderBox::createInlineBox):
  29002. * rendering/RenderBox.h:
  29003. * rendering/RenderCounter.cpp:
  29004. * rendering/RenderCounter.h:
  29005. * rendering/RenderInline.cpp:
  29006. (WebCore::RenderInline::createInlineFlowBox):
  29007. * rendering/RenderInline.h:
  29008. * rendering/RenderObject.cpp:
  29009. * rendering/RenderObject.h:
  29010. * rendering/RenderSVGInlineText.cpp:
  29011. (WebCore::RenderSVGInlineText::createTextBox):
  29012. * rendering/RenderSVGInlineText.h:
  29013. (WebCore::RenderSVGInlineText::isSVGText):
  29014. * rendering/RenderText.cpp:
  29015. (WebCore::RenderText::createTextBox):
  29016. (WebCore::RenderText::createInlineTextBox):
  29017. * rendering/RenderText.h:
  29018. * rendering/bidi.cpp:
  29019. (WebCore::createInlineBoxForRenderer):
  29020. (WebCore::RenderBlock::createLineBoxes):
  29021. (WebCore::RenderBlock::constructLine):
  29022. (WebCore::RenderBlock::layoutInlineChildren):
  29023. 2009-02-11 Chris Marrin <cmarrin@apple.com>
  29024. Reviewed by Dave Hyatt.
  29025. https://bugs.webkit.org/show_bug.cgi?id=23905
  29026. Adds support for 3D CSS properties (transform-style-3d, perspective,
  29027. perspective-origin, and backface-visibility) to RenderStyle and friends
  29028. * platform/graphics/transforms/TransformOperation.h
  29029. * rendering/style/RenderStyle.cpp:
  29030. (WebCore::RenderStyle::diff):
  29031. (WebCore::RenderStyle::applyTransform):
  29032. * rendering/style/RenderStyle.h:
  29033. (WebCore::InheritedFlags::transformOriginZ):
  29034. (WebCore::InheritedFlags::hasTransformRelatedProperty):
  29035. (WebCore::InheritedFlags::transformStyle3D):
  29036. (WebCore::InheritedFlags::backfaceVisibility):
  29037. (WebCore::InheritedFlags::perspective):
  29038. (WebCore::InheritedFlags::perspectiveOriginX):
  29039. (WebCore::InheritedFlags::perspectiveOriginY):
  29040. (WebCore::InheritedFlags::setTransformOriginZ):
  29041. (WebCore::InheritedFlags::setTransformStyle3D):
  29042. (WebCore::InheritedFlags::setBackfaceVisibility):
  29043. (WebCore::InheritedFlags::setPerspective):
  29044. (WebCore::InheritedFlags::setPerspectiveOriginX):
  29045. (WebCore::InheritedFlags::setPerspectiveOriginY):
  29046. (WebCore::InheritedFlags::initialTransformOriginZ):
  29047. (WebCore::InheritedFlags::initialTransformStyle3D):
  29048. (WebCore::InheritedFlags::initialBackfaceVisibility):
  29049. (WebCore::InheritedFlags::initialPerspective):
  29050. (WebCore::InheritedFlags::initialPerspectiveOriginX):
  29051. (WebCore::InheritedFlags::initialPerspectiveOriginY):
  29052. * rendering/style/RenderStyleConstants.h:
  29053. (WebCore::):
  29054. * rendering/style/StyleRareNonInheritedData.cpp:
  29055. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  29056. (WebCore::StyleRareNonInheritedData::operator==):
  29057. * rendering/style/StyleRareNonInheritedData.h:
  29058. * rendering/style/StyleTransformData.cpp:
  29059. (WebCore::StyleTransformData::StyleTransformData):
  29060. (WebCore::StyleTransformData::operator==):
  29061. * rendering/style/StyleTransformData.h:
  29062. 2009-02-11 Simon Fraser <simon.fraser@apple.com>
  29063. No review.
  29064. Fix ACCELERATED_COMPOSITING build.
  29065. * rendering/RenderLayerBacking.cpp:
  29066. (WebCore::RenderLayerBacking::createGraphicsLayer):
  29067. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  29068. * rendering/RenderLayerCompositor.cpp:
  29069. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  29070. 2009-02-11 Simon Fraser <simon.fraser@apple.com>
  29071. Reviewed by Dave Hyatt
  29072. https://bugs.webkit.org/show_bug.cgi?id=23862
  29073. Add a bit on RenderStyle that gets set when running accelerated
  29074. transitions of transform or opacity. These ensure that styles
  29075. compare as different during the transition, so that interruption
  29076. can be detected reliably.
  29077. * page/animation/ImplicitAnimation.cpp:
  29078. (WebCore::ImplicitAnimation::animate):
  29079. * rendering/style/RenderStyle.h:
  29080. (WebCore::InheritedFlags::isRunningAcceleratedAnimation):
  29081. (WebCore::InheritedFlags::setIsRunningAcceleratedAnimation):
  29082. * rendering/style/StyleRareNonInheritedData.cpp:
  29083. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
  29084. (WebCore::StyleRareNonInheritedData::operator==):
  29085. * rendering/style/StyleRareNonInheritedData.h:
  29086. 2009-02-11 David Hyatt <hyatt@apple.com>
  29087. Eliminate the virtual position() function from RenderObject. Rename the position() overrides
  29088. in RenderText and RenderBox to positionLineBox and devirtualize them.
  29089. Patch the one call site to just check for isText() and isBox() and call the methods directly.
  29090. Remove some unnecessary overrides of position() on table sections and rows.
  29091. Reviewed by Simon Fraser
  29092. * rendering/RenderBox.cpp:
  29093. (WebCore::RenderBox::positionLineBox):
  29094. * rendering/RenderBox.h:
  29095. * rendering/RenderObject.h:
  29096. * rendering/RenderSVGRoot.cpp:
  29097. * rendering/RenderSVGRoot.h:
  29098. * rendering/RenderTableRow.h:
  29099. (WebCore::RenderTableRow::lineHeight):
  29100. * rendering/RenderTableSection.h:
  29101. (WebCore::RenderTableSection::lineHeight):
  29102. * rendering/RenderText.cpp:
  29103. (WebCore::RenderText::positionLineBox):
  29104. * rendering/RenderText.h:
  29105. * rendering/bidi.cpp:
  29106. (WebCore::RenderBlock::computeVerticalPositionsForLine):
  29107. 2009-02-11 Dimitri Glazkov <dglazkov@chromium.org>
  29108. Reviewed by Eric Seidel.
  29109. https://bugs.webkit.org/show_bug.cgi?id=23901
  29110. Add HTML options/collections V8 custom bindings.
  29111. * bindings/v8/custom/V8HTMLCollectionCustom.cpp: Added.
  29112. (WebCore::getNamedItems):
  29113. (WebCore::getItem):
  29114. (WebCore::NAMED_PROPERTY_GETTER):
  29115. (WebCore::CALLBACK_FUNC_DECL):
  29116. * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Added.
  29117. (WebCore::NAMED_PROPERTY_GETTER):
  29118. * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  29119. (WebCore::ACCESSOR_GETTER):
  29120. (WebCore::ACCESSOR_SETTER):
  29121. (WebCore::CALLBACK_FUNC_DECL):
  29122. * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  29123. (WebCore::CALLBACK_FUNC_DECL):
  29124. (WebCore::ACCESSOR_SETTER):
  29125. * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Added.
  29126. (WebCore::CALLBACK_FUNC_DECL):
  29127. (WebCore::removeElement):
  29128. * bindings/v8/custom/V8HTMLSelectElementCustom.h: Added.
  29129. * bindings/v8/custom/V8NamedNodesCollection.cpp: Added.
  29130. (WebCore::V8NamedNodesCollection::item):
  29131. (WebCore::V8NamedNodesCollection::itemWithName):
  29132. * bindings/v8/custom/V8NamedNodesCollection.h: Added.
  29133. (WebCore::V8NamedNodesCollection::V8NamedNodesCollection):
  29134. (WebCore::V8NamedNodesCollection::length):
  29135. 2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
  29136. Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
  29137. This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.
  29138. Reviewed by Timothy Hatcher.
  29139. * inspector/InspectorClient.h:
  29140. * inspector/InspectorController.cpp:
  29141. (WebCore::hiddenPanels):
  29142. (WebCore::InspectorController::hiddenPanels):
  29143. (WebCore::InspectorController::windowScriptObjectAvailable):
  29144. * inspector/InspectorController.h:
  29145. * inspector/front-end/inspector.js:
  29146. (WebInspector.loaded):
  29147. * loader/EmptyClients.h:
  29148. (WebCore::EmptyInspectorClient::hiddenPanels):
  29149. 2009-02-11 David Hyatt <hyatt@apple.com>
  29150. Combine RenderObject::element() and RenderObject::node() into a single function.
  29151. node() now has the "anonymous bit" checking behavior of element() and will
  29152. return 0 for anonymous content. This patch switches all callers of element()
  29153. to node() and patches old callers of node() to deal with situations where they
  29154. did not expect node() to be 0. A bunch of node() calls were calling stuff on
  29155. Document that they clearly didn't intend, so overall this is a nice improvement.
  29156. Reviewed by Sam Weinig
  29157. * dom/ContainerNode.cpp:
  29158. (WebCore::ContainerNode::getUpperLeftCorner):
  29159. * dom/Element.cpp:
  29160. (WebCore::Element::offsetParent):
  29161. * dom/Position.cpp:
  29162. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
  29163. * editing/ModifySelectionListLevel.cpp:
  29164. (WebCore::getStartEndListChildren):
  29165. (WebCore::IncreaseSelectionListLevelCommand::doApply):
  29166. (WebCore::DecreaseSelectionListLevelCommand::doApply):
  29167. * editing/TextIterator.cpp:
  29168. (WebCore::TextIterator::advance):
  29169. * editing/VisiblePosition.cpp:
  29170. (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
  29171. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
  29172. * editing/visible_units.cpp:
  29173. (WebCore::startPositionForLine):
  29174. (WebCore::endPositionForLine):
  29175. * page/AXObjectCache.cpp:
  29176. (WebCore::AXObjectCache::get):
  29177. * page/AccessibilityList.cpp:
  29178. (WebCore::AccessibilityList::isUnorderedList):
  29179. (WebCore::AccessibilityList::isOrderedList):
  29180. (WebCore::AccessibilityList::isDefinitionList):
  29181. * page/AccessibilityListBox.cpp:
  29182. (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  29183. * page/AccessibilityRenderObject.cpp:
  29184. (WebCore::AccessibilityRenderObject::isPasswordField):
  29185. (WebCore::AccessibilityRenderObject::isFileUploadButton):
  29186. (WebCore::AccessibilityRenderObject::isInputImage):
  29187. (WebCore::AccessibilityRenderObject::isMultiSelect):
  29188. (WebCore::AccessibilityRenderObject::isControl):
  29189. (WebCore::AccessibilityRenderObject::getAttribute):
  29190. (WebCore::AccessibilityRenderObject::anchorElement):
  29191. (WebCore::AccessibilityRenderObject::actionElement):
  29192. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  29193. (WebCore::AccessibilityRenderObject::helpText):
  29194. (WebCore::AccessibilityRenderObject::textUnderElement):
  29195. (WebCore::AccessibilityRenderObject::hasIntValue):
  29196. (WebCore::AccessibilityRenderObject::intValue):
  29197. (WebCore::AccessibilityRenderObject::labelElementContainer):
  29198. (WebCore::AccessibilityRenderObject::title):
  29199. (WebCore::AccessibilityRenderObject::accessibilityDescription):
  29200. (WebCore::AccessibilityRenderObject::boundingBoxRect):
  29201. (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
  29202. (WebCore::AccessibilityRenderObject::titleUIElement):
  29203. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  29204. (WebCore::AccessibilityRenderObject::text):
  29205. (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
  29206. (WebCore::AccessibilityRenderObject::accessKey):
  29207. (WebCore::AccessibilityRenderObject::setSelectedTextRange):
  29208. (WebCore::AccessibilityRenderObject::url):
  29209. (WebCore::AccessibilityRenderObject::isFocused):
  29210. (WebCore::AccessibilityRenderObject::setFocused):
  29211. (WebCore::AccessibilityRenderObject::setValue):
  29212. (WebCore::AccessibilityRenderObject::isEnabled):
  29213. (WebCore::AccessibilityRenderObject::visiblePositionRange):
  29214. (WebCore::AccessibilityRenderObject::index):
  29215. (WebCore::AccessibilityRenderObject::activeDescendant):
  29216. (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
  29217. (WebCore::AccessibilityRenderObject::observableObject):
  29218. (WebCore::AccessibilityRenderObject::roleValue):
  29219. (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  29220. (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
  29221. * page/AccessibilityTable.cpp:
  29222. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  29223. (WebCore::AccessibilityTable::title):
  29224. * page/AccessibilityTableCell.cpp:
  29225. (WebCore::AccessibilityTableCell::titleUIElement):
  29226. * page/AccessibilityTableColumn.cpp:
  29227. (WebCore::AccessibilityTableColumn::headerObjectForSection):
  29228. * page/AccessibilityTableRow.cpp:
  29229. (WebCore::AccessibilityTableRow::headerObject):
  29230. * page/EventHandler.cpp:
  29231. (WebCore::EventHandler::dispatchMouseEvent):
  29232. (WebCore::EventHandler::canMouseDownStartSelect):
  29233. (WebCore::EventHandler::canMouseDragExtendSelect):
  29234. (WebCore::EventHandler::shouldDragAutoNode):
  29235. * page/Frame.cpp:
  29236. (WebCore::Frame::searchForLabelsAboveCell):
  29237. (WebCore::Frame::setFocusedNodeIfNeeded):
  29238. * page/FrameView.cpp:
  29239. (WebCore::FrameView::updateOverflowStatus):
  29240. * page/animation/AnimationBase.cpp:
  29241. (WebCore::AnimationBase::updateStateMachine):
  29242. * page/animation/AnimationController.cpp:
  29243. (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  29244. (WebCore::AnimationController::cancelAnimations):
  29245. (WebCore::AnimationController::updateAnimations):
  29246. * page/animation/KeyframeAnimation.cpp:
  29247. (WebCore::KeyframeAnimation::KeyframeAnimation):
  29248. (WebCore::KeyframeAnimation::endAnimation):
  29249. * page/mac/AccessibilityObjectWrapper.mm:
  29250. (blockquoteLevel):
  29251. (AXAttributeStringSetHeadingLevel):
  29252. * page/mac/FrameMac.mm:
  29253. (WebCore::Frame::searchForNSLabelsAboveCell):
  29254. * rendering/InlineFlowBox.cpp:
  29255. (WebCore::InlineFlowBox::verticallyAlignBoxes):
  29256. (WebCore::InlineFlowBox::paint):
  29257. (WebCore::shouldDrawTextDecoration):
  29258. * rendering/InlineTextBox.cpp:
  29259. (WebCore::InlineTextBox::paintDocumentMarkers):
  29260. * rendering/RenderBR.cpp:
  29261. (WebCore::RenderBR::positionForCoordinates):
  29262. * rendering/RenderBlock.cpp:
  29263. (WebCore::RenderBlock::layoutBlock):
  29264. (WebCore::RenderBlock::handleRunInChild):
  29265. (WebCore::RenderBlock::paintObject):
  29266. (WebCore::RenderBlock::isSelectionRoot):
  29267. (WebCore::RenderBlock::rightmostPosition):
  29268. (WebCore::RenderBlock::positionForBox):
  29269. (WebCore::RenderBlock::positionForRenderer):
  29270. (WebCore::RenderBlock::positionForCoordinates):
  29271. (WebCore::RenderBlock::hasLineIfEmpty):
  29272. (WebCore::RenderBlock::updateFirstLetter):
  29273. (WebCore::RenderBlock::updateHitTestResult):
  29274. (WebCore::RenderBlock::addFocusRingRects):
  29275. * rendering/RenderBox.cpp:
  29276. (WebCore::RenderBox::styleWillChange):
  29277. (WebCore::RenderBox::updateBoxModelInfoFromStyle):
  29278. (WebCore::RenderBox::paintRootBoxDecorations):
  29279. (WebCore::RenderBox::positionForCoordinates):
  29280. * rendering/RenderButton.cpp:
  29281. (WebCore::RenderButton::updateFromElement):
  29282. (WebCore::RenderButton::canHaveChildren):
  29283. * rendering/RenderCounter.cpp:
  29284. (WebCore::planCounter):
  29285. * rendering/RenderFieldset.cpp:
  29286. (WebCore::RenderFieldset::findLegend):
  29287. * rendering/RenderFlexibleBox.cpp:
  29288. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  29289. * rendering/RenderForeignObject.cpp:
  29290. (WebCore::RenderForeignObject::translationForAttributes):
  29291. (WebCore::RenderForeignObject::calculateLocalTransform):
  29292. * rendering/RenderFrame.h:
  29293. (WebCore::RenderFrame::element):
  29294. * rendering/RenderImage.cpp:
  29295. (WebCore::RenderImage::paintReplaced):
  29296. (WebCore::RenderImage::imageMap):
  29297. (WebCore::RenderImage::nodeAtPoint):
  29298. (WebCore::RenderImage::updateAltText):
  29299. * rendering/RenderInline.cpp:
  29300. (WebCore::RenderInline::cloneInline):
  29301. (WebCore::RenderInline::updateHitTestResult):
  29302. * rendering/RenderLayer.cpp:
  29303. (WebCore::RenderLayer::isTransparent):
  29304. (WebCore::RenderLayer::scrollToOffset):
  29305. (WebCore::RenderLayer::resize):
  29306. (WebCore::RenderLayer::createScrollbar):
  29307. (WebCore::RenderLayer::updateOverflowStatus):
  29308. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  29309. (WebCore::RenderLayer::enclosingElement):
  29310. (WebCore::RenderLayer::updateHoverActiveState):
  29311. (WebCore::RenderLayer::updateScrollCornerStyle):
  29312. (WebCore::RenderLayer::updateResizerStyle):
  29313. * rendering/RenderLayer.h:
  29314. (WebCore::RenderLayer::isRootLayer):
  29315. * rendering/RenderListItem.cpp:
  29316. (WebCore::getParentOfFirstLineBox):
  29317. * rendering/RenderMarquee.cpp:
  29318. (WebCore::RenderMarquee::marqueeSpeed):
  29319. * rendering/RenderObject.cpp:
  29320. (WebCore::RenderObject::RenderObject):
  29321. (WebCore::RenderObject::isBody):
  29322. (WebCore::RenderObject::isHR):
  29323. (WebCore::RenderObject::isHTMLMarquee):
  29324. (WebCore::RenderObject::isEditable):
  29325. (WebCore::RenderObject::addPDFURLRect):
  29326. (WebCore::RenderObject::showTreeForThis):
  29327. (WebCore::RenderObject::draggableNode):
  29328. (WebCore::RenderObject::hasOutlineAnnotation):
  29329. (WebCore::RenderObject::positionForCoordinates):
  29330. (WebCore::RenderObject::updateDragState):
  29331. (WebCore::RenderObject::updateHitTestResult):
  29332. (WebCore::RenderObject::getUncachedPseudoStyle):
  29333. (WebCore::RenderObject::getTextDecorationColors):
  29334. (WebCore::RenderObject::caretMaxOffset):
  29335. (WebCore::RenderObject::offsetParent):
  29336. * rendering/RenderObject.h:
  29337. (WebCore::RenderObject::isRoot):
  29338. (WebCore::RenderObject::isInlineContinuation):
  29339. (WebCore::RenderObject::node):
  29340. (WebCore::RenderObject::setNode):
  29341. * rendering/RenderObjectChildList.cpp:
  29342. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
  29343. * rendering/RenderPart.cpp:
  29344. (WebCore::RenderPart::updateWidgetPosition):
  29345. * rendering/RenderPartObject.cpp:
  29346. (WebCore::RenderPartObject::updateWidget):
  29347. (WebCore::RenderPartObject::viewCleared):
  29348. * rendering/RenderPath.cpp:
  29349. (WebCore::RenderPath::calculateLocalTransform):
  29350. (WebCore::RenderPath::layout):
  29351. (WebCore::RenderPath::paint):
  29352. (WebCore::RenderPath::drawMarkersIfNeeded):
  29353. * rendering/RenderReplaced.cpp:
  29354. (WebCore::RenderReplaced::positionForCoordinates):
  29355. (WebCore::RenderReplaced::isSelected):
  29356. * rendering/RenderSVGGradientStop.cpp:
  29357. (WebCore::RenderSVGGradientStop::gradientElement):
  29358. * rendering/RenderSVGImage.cpp:
  29359. (WebCore::RenderSVGImage::calculateLocalTransform):
  29360. * rendering/RenderSVGInlineText.cpp:
  29361. (WebCore::RenderSVGInlineText::positionForCoordinates):
  29362. * rendering/RenderSVGRoot.cpp:
  29363. (WebCore::RenderSVGRoot::layout):
  29364. (WebCore::RenderSVGRoot::applyContentTransforms):
  29365. (WebCore::RenderSVGRoot::paint):
  29366. (WebCore::RenderSVGRoot::calcViewport):
  29367. (WebCore::RenderSVGRoot::absoluteTransform):
  29368. * rendering/RenderSVGText.cpp:
  29369. (WebCore::RenderSVGText::calculateLocalTransform):
  29370. (WebCore::RenderSVGText::layout):
  29371. * rendering/RenderSVGTextPath.cpp:
  29372. (WebCore::RenderSVGTextPath::layoutPath):
  29373. (WebCore::RenderSVGTextPath::startOffset):
  29374. (WebCore::RenderSVGTextPath::exactAlignment):
  29375. (WebCore::RenderSVGTextPath::stretchMethod):
  29376. * rendering/RenderSVGTransformableContainer.cpp:
  29377. (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  29378. * rendering/RenderSVGViewportContainer.cpp:
  29379. (WebCore::RenderSVGViewportContainer::calcViewport):
  29380. (WebCore::RenderSVGViewportContainer::viewportTransform):
  29381. (WebCore::RenderSVGViewportContainer::nodeAtPoint):
  29382. * rendering/RenderTable.cpp:
  29383. (WebCore::RenderTable::addChild):
  29384. * rendering/RenderTableCell.cpp:
  29385. (WebCore::RenderTableCell::updateFromElement):
  29386. (WebCore::RenderTableCell::calcPrefWidths):
  29387. * rendering/RenderTableCol.cpp:
  29388. (WebCore::RenderTableCol::updateFromElement):
  29389. * rendering/RenderTableRow.cpp:
  29390. (WebCore::RenderTableRow::addChild):
  29391. * rendering/RenderTableSection.cpp:
  29392. (WebCore::RenderTableSection::addChild):
  29393. * rendering/RenderText.cpp:
  29394. (WebCore::RenderText::originalText):
  29395. (WebCore::RenderText::positionForCoordinates):
  29396. * rendering/RenderTextControlMultiLine.cpp:
  29397. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  29398. * rendering/RenderTextControlSingleLine.cpp:
  29399. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  29400. * rendering/RenderTextFragment.cpp:
  29401. (WebCore::RenderTextFragment::originalText):
  29402. (WebCore::RenderTextFragment::previousCharacter):
  29403. * rendering/RenderTheme.cpp:
  29404. (WebCore::RenderTheme::isActive):
  29405. (WebCore::RenderTheme::isChecked):
  29406. (WebCore::RenderTheme::isIndeterminate):
  29407. (WebCore::RenderTheme::isEnabled):
  29408. (WebCore::RenderTheme::isFocused):
  29409. (WebCore::RenderTheme::isPressed):
  29410. (WebCore::RenderTheme::isReadOnlyControl):
  29411. (WebCore::RenderTheme::isHovered):
  29412. * rendering/RenderThemeMac.mm:
  29413. (WebCore::RenderThemeMac::updatePressedState):
  29414. (WebCore::RenderThemeMac::paintMediaFullscreenButton):
  29415. (WebCore::RenderThemeMac::paintMediaMuteButton):
  29416. (WebCore::RenderThemeMac::paintMediaPlayButton):
  29417. (WebCore::RenderThemeMac::paintMediaSeekBackButton):
  29418. (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
  29419. (WebCore::RenderThemeMac::paintMediaSliderTrack):
  29420. (WebCore::RenderThemeMac::paintMediaSliderThumb):
  29421. (WebCore::RenderThemeMac::paintMediaTimelineContainer):
  29422. (WebCore::RenderThemeMac::paintMediaCurrentTime):
  29423. (WebCore::RenderThemeMac::paintMediaTimeRemaining):
  29424. * rendering/RenderThemeSafari.cpp:
  29425. (WebCore::RenderThemeSafari::paintMediaMuteButton):
  29426. (WebCore::RenderThemeSafari::paintMediaPlayButton):
  29427. (WebCore::RenderThemeSafari::paintMediaSliderTrack):
  29428. * rendering/RenderTreeAsText.cpp:
  29429. (WebCore::operator<<):
  29430. (WebCore::writeSelection):
  29431. * rendering/RenderWidget.cpp:
  29432. (WebCore::RenderWidget::setWidgetGeometry):
  29433. (WebCore::RenderWidget::updateWidgetPosition):
  29434. (WebCore::RenderWidget::nodeAtPoint):
  29435. * rendering/RootInlineBox.cpp:
  29436. (WebCore::isEditableLeaf):
  29437. * rendering/SVGRenderSupport.cpp:
  29438. (WebCore::prepareToRenderSVGContent):
  29439. * rendering/SVGRenderTreeAsText.cpp:
  29440. (WebCore::write):
  29441. * rendering/SVGRootInlineBox.cpp:
  29442. (WebCore::SVGRootInlineBox::buildLayoutInformation):
  29443. (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  29444. (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  29445. (WebCore::SVGRootInlineBox::buildTextChunks):
  29446. * rendering/style/SVGRenderStyle.cpp:
  29447. (WebCore::SVGRenderStyle::cssPrimitiveToLength):
  29448. * svg/SVGFont.cpp:
  29449. (WebCore::SVGTextRunWalker::walk):
  29450. (WebCore::floatWidthOfSubStringUsingSVGFont):
  29451. (WebCore::Font::drawTextUsingSVGFont):
  29452. * svg/SVGTextContentElement.cpp:
  29453. (WebCore::findInlineTextBoxInTextChunks):
  29454. * svg/graphics/SVGPaintServer.cpp:
  29455. (WebCore::SVGPaintServer::fillPaintServer):
  29456. (WebCore::SVGPaintServer::strokePaintServer):
  29457. 2009-02-11 Brady Eidson <beidson@apple.com>
  29458. Reviewed by Darin Adler
  29459. <rdar://problem/3541409> - Further FrameLoader and page cache cleanup
  29460. * history/CachedFrame.cpp:
  29461. (WebCore::CachedFrame::restore): Moved updatePlatformScriptObjects() here.
  29462. * loader/FrameLoader.cpp:
  29463. (WebCore::FrameLoader::commitProvisionalLoad): Rolled opened() into this method. This method was
  29464. the only caller and - in the future - will benefit from doing parts of opened()'s work differently.
  29465. (WebCore::FrameLoader::open): Split off per-frame logic into open(CachedFrame&) method.
  29466. (WebCore::FrameLoader::closeAndRemoveChild): Added. Do the non-tree related cleanup that
  29467. FrameTree::removeChild() used to do.
  29468. (WebCore::FrameLoader::detachFromParent): Call ::closeAndRemoveChild() instead.
  29469. (WebCore::FrameLoader::cachePageForHistoryItem): Perform the "can cache page" check here.
  29470. * loader/FrameLoader.h:
  29471. * page/FrameTree.cpp:
  29472. (WebCore::FrameTree::removeChild): Just remove the Frame from the tree. Closing it and other
  29473. cleanup is the responsibility of the FrameLoader.
  29474. * page/FrameTree.h:
  29475. (WebCore::FrameTree::detachFromParent): Added to just clear a Frame's parent pointer
  29476. 2009-02-11 Scott Violet <sky@google.com>
  29477. Reviewed by Eric Seidel.
  29478. https://bugs.webkit.org/show_bug.cgi?id=23882
  29479. GraphicsContextSkia draws round rects as solid rects
  29480. Fixes two bugs in Skia's GraphicsContext::fillRoundedRect:
  29481. . fillRoundedRect had an extra call to fillRect, resulting in always
  29482. drawing a solid rectangle.
  29483. . if the total radius along a given axis is greater than the size of
  29484. the axis to draw, a solid rect should be drawn.
  29485. The layout tests LayoutTests/fast/css/shadow-multiple.html and
  29486. LayoutTests/fast/box-shadow/basic-shadows.html cover this.
  29487. * platform/graphics/skia/GraphicsContextSkia.cpp:
  29488. (WebCore::GraphicsContext::fillRoundedRect):
  29489. 2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
  29490. Reviewed by Eric Seidel.
  29491. Bug 23536: Auto-generate HTMLElementFactory
  29492. Remove the HTMLElementFactory files. Farewell.
  29493. * html/HTMLElementFactory.cpp: Removed.
  29494. * html/HTMLElementFactory.h: Removed.
  29495. 2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
  29496. Reviewed by Eric Seidel.
  29497. Bug 23536: Auto-generate HTMLElementFactory
  29498. Make the platform auto-generate the HTMLElementFactory.
  29499. * DerivedSources.make:
  29500. * GNUmakefile.am:
  29501. * WebCore.pro:
  29502. * WebCore.scons:
  29503. * WebCore.vcproj/WebCore.vcproj:
  29504. * WebCore.xcodeproj/project.pbxproj:
  29505. * WebCoreSources.bkl:
  29506. * webcore-base.bkl:
  29507. 2009-02-11 Sam Weinig <sam@webkit.org>
  29508. Reviewed by David Hyatt.
  29509. Remove unneeded ASSERTS.
  29510. * rendering/RenderBox.h:
  29511. (WebCore::RenderBox::width):
  29512. (WebCore::RenderBox::height):
  29513. (WebCore::RenderBox::size):
  29514. (WebCore::RenderBox::frameRect):
  29515. 2009-02-11 Simon Fraser <simon.fraser@apple.com>
  29516. Reviewed by Dave Hyatt
  29517. Add function to RenderStyle to ask whether a background image has been specified.
  29518. * rendering/style/RenderStyle.h:
  29519. (WebCore::InheritedFlags::hasBackgroundImage):
  29520. 2009-02-11 Simon Fraser <simon.fraser@apple.com>
  29521. Reviewed by Dave Hyatt
  29522. https://bugs.webkit.org/show_bug.cgi?id=23548
  29523. When opacity or transform change on an object which has a compositing layer,
  29524. avoid repainting the layer.
  29525. Added a new StyleDifference value, StyleDifferenceRecompositeLayer, which indicates
  29526. that the only thing styleChanged() has to do is to update composited properties of
  29527. the layer. RenderStyle::diff() now has an out param for a bitmask of "context sensitive"
  29528. properties, currently for opacity and transform. When one of these changes, we need
  29529. to see if we have a compositing layer before we decide whether to layout/repaint,
  29530. or just update the composited layer, via adjustStyleDifference().
  29531. * rendering/RenderObject.cpp:
  29532. (WebCore::RenderObject::adjustStyleDifference):
  29533. (WebCore::RenderObject::setStyle):
  29534. (WebCore::RenderObject::styleDidChange):
  29535. * rendering/RenderObject.h:
  29536. * rendering/style/RenderStyle.cpp:
  29537. (WebCore::RenderStyle::diff):
  29538. * rendering/style/RenderStyle.h:
  29539. * rendering/style/RenderStyleConstants.h:
  29540. (WebCore::):
  29541. 2009-02-11 Alexey Proskuryakov <ap@webkit.org>
  29542. Reviewed by Darin Adler.
  29543. <rdar://problem/6562920> Pasted text should be normalized to NFC
  29544. Testing requires putting non-HTML content in pasteboard, so it cannot be done with WebKit alone.
  29545. * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::plainText): Route the text through
  29546. -[NSString precomposedStringWithCanonicalMapping].
  29547. 2009-02-10 Chris Marrin <cmarrin@apple.com>
  29548. Reviewed by Simon Fraser.
  29549. https://bugs.webkit.org/show_bug.cgi?id=23883
  29550. Added new TransformOperation subclasses and methods to existing ones
  29551. to support 3D.
  29552. * WebCore.xcodeproj/project.pbxproj:
  29553. * platform/graphics/transforms/IdentityTransformOperation.h:
  29554. (WebCore::IdentityTransformOperation::isAffine):
  29555. * platform/graphics/transforms/Matrix3DTransformOperation.cpp: Added.
  29556. (WebCore::Matrix3DTransformOperation::blend):
  29557. * platform/graphics/transforms/Matrix3DTransformOperation.h: Added.
  29558. (WebCore::Matrix3DTransformOperation::create):
  29559. (WebCore::Matrix3DTransformOperation::isIdentity):
  29560. (WebCore::Matrix3DTransformOperation::isAffine):
  29561. (WebCore::Matrix3DTransformOperation::getOperationType):
  29562. (WebCore::Matrix3DTransformOperation::isSameType):
  29563. (WebCore::Matrix3DTransformOperation::operator==):
  29564. (WebCore::Matrix3DTransformOperation::apply):
  29565. (WebCore::Matrix3DTransformOperation::Matrix3DTransformOperation):
  29566. * platform/graphics/transforms/MatrixTransformOperation.h:
  29567. (WebCore::MatrixTransformOperation::isAffine):
  29568. (WebCore::MatrixTransformOperation::apply):
  29569. * platform/graphics/transforms/PerspectiveTransformOperation.cpp: Added.
  29570. (WebCore::PerspectiveTransformOperation::blend):
  29571. * platform/graphics/transforms/PerspectiveTransformOperation.h: Added.
  29572. (WebCore::PerspectiveTransformOperation::create):
  29573. (WebCore::PerspectiveTransformOperation::isIdentity):
  29574. (WebCore::PerspectiveTransformOperation::isAffine):
  29575. (WebCore::PerspectiveTransformOperation::getOperationType):
  29576. (WebCore::PerspectiveTransformOperation::isSameType):
  29577. (WebCore::PerspectiveTransformOperation::operator==):
  29578. (WebCore::PerspectiveTransformOperation::apply):
  29579. (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation):
  29580. * platform/graphics/transforms/RotateTransformOperation.cpp:
  29581. (WebCore::RotateTransformOperation::blend):
  29582. * platform/graphics/transforms/RotateTransformOperation.h:
  29583. (WebCore::RotateTransformOperation::create):
  29584. (WebCore::RotateTransformOperation::angle):
  29585. (WebCore::RotateTransformOperation::isAffine):
  29586. (WebCore::RotateTransformOperation::operator==):
  29587. (WebCore::RotateTransformOperation::apply):
  29588. (WebCore::RotateTransformOperation::RotateTransformOperation):
  29589. * platform/graphics/transforms/ScaleTransformOperation.cpp:
  29590. (WebCore::ScaleTransformOperation::blend):
  29591. * platform/graphics/transforms/ScaleTransformOperation.h:
  29592. (WebCore::ScaleTransformOperation::create):
  29593. (WebCore::ScaleTransformOperation::z):
  29594. (WebCore::ScaleTransformOperation::isIdentity):
  29595. (WebCore::ScaleTransformOperation::isAffine):
  29596. (WebCore::ScaleTransformOperation::operator==):
  29597. (WebCore::ScaleTransformOperation::apply):
  29598. (WebCore::ScaleTransformOperation::ScaleTransformOperation):
  29599. * platform/graphics/transforms/SkewTransformOperation.h:
  29600. (WebCore::SkewTransformOperation::isAffine):
  29601. * platform/graphics/transforms/TransformOperation.h:
  29602. (WebCore::TransformOperation::):
  29603. (WebCore::TransformOperation::is3DOperation):
  29604. * platform/graphics/transforms/TransformOperations.h:
  29605. (WebCore::TransformOperations::isAffine):
  29606. (WebCore::TransformOperations::has3DOperation):
  29607. * platform/graphics/transforms/TranslateTransformOperation.cpp:
  29608. (WebCore::TranslateTransformOperation::blend):
  29609. * platform/graphics/transforms/TranslateTransformOperation.h:
  29610. (WebCore::TranslateTransformOperation::create):
  29611. (WebCore::TranslateTransformOperation::z):
  29612. (WebCore::TranslateTransformOperation::isIdentity):
  29613. (WebCore::TranslateTransformOperation::isAffine):
  29614. (WebCore::TranslateTransformOperation::operator==):
  29615. (WebCore::TranslateTransformOperation::apply):
  29616. (WebCore::TranslateTransformOperation::TranslateTransformOperation):
  29617. 2009-02-11 David Hyatt <hyatt@apple.com>
  29618. Move createAnonymousBlock() to RenderBlock. Since anonymous blocks are always parented to some other block,
  29619. we can move this function to RenderBlock. Fix a couple of call sites as a result of this restriction.
  29620. Reviewed by Simon Fraser
  29621. * rendering/RenderBlock.cpp:
  29622. (WebCore::RenderBlock::createAnonymousBlock):
  29623. * rendering/RenderBlock.h:
  29624. * rendering/RenderInline.cpp:
  29625. (WebCore::RenderInline::childBecameNonInline):
  29626. * rendering/RenderObject.cpp:
  29627. (WebCore::RenderObject::handleDynamicFloatPositionChange):
  29628. * rendering/RenderObject.h:
  29629. 2009-02-11 David Hyatt <hyatt@apple.com>
  29630. https://bugs.webkit.org/show_bug.cgi?id=23895
  29631. Remove two complete nonsense lines that I accidentally added from a cut and paste error. This
  29632. restores the original logic.
  29633. Reviewed by Simon Fraser
  29634. * rendering/RenderBox.cpp:
  29635. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  29636. 2009-02-11 David Hyatt <hyatt@apple.com>
  29637. Rename getBaselineOfFirstLineBox to firstLineBoxBaseline. Rename getBaselineOfLastLineBox to
  29638. lastLineBoxBaseline. Remove the functions from RenderObject and add them to RenderBox instead.
  29639. Reviewed by Eric Seidel
  29640. * rendering/RenderBlock.cpp:
  29641. (WebCore::RenderBlock::baselinePosition):
  29642. (WebCore::RenderBlock::firstLineBoxBaseline):
  29643. (WebCore::RenderBlock::lastLineBoxBaseline):
  29644. * rendering/RenderBlock.h:
  29645. * rendering/RenderBox.h:
  29646. (WebCore::RenderBox::firstLineBoxBaseline):
  29647. (WebCore::RenderBox::lastLineBoxBaseline):
  29648. * rendering/RenderFlexibleBox.cpp:
  29649. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  29650. * rendering/RenderObject.h:
  29651. * rendering/RenderTable.cpp:
  29652. (WebCore::RenderTable::firstLineBoxBaseline):
  29653. * rendering/RenderTable.h:
  29654. * rendering/RenderTableCell.cpp:
  29655. (WebCore::RenderTableCell::baselinePosition):
  29656. * rendering/RenderTableSection.cpp:
  29657. (WebCore::RenderTableSection::firstLineBoxBaseline):
  29658. * rendering/RenderTableSection.h:
  29659. 2009-02-11 Eric Carlson <eric.carlson@apple.com>
  29660. Reviewed by Simon Fraser
  29661. https://bugs.webkit.org/show_bug.cgi?id=23877
  29662. Allow port to disable progress events from <video> and <audio> elements
  29663. * html/HTMLMediaElement.cpp: Initialize m_sendProgressEvents.
  29664. (WebCore::HTMLMediaElement::HTMLMediaElement): Don't post progress events if m_sendProgressEvents is false.
  29665. (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Ditto.
  29666. (WebCore::HTMLMediaElement::load): Ditto.
  29667. * html/HTMLMediaElement.h: Add m_sendProgressEvents
  29668. 2009-02-11 Adam Roben <aroben@apple.com>
  29669. Windows build fix
  29670. * DerivedSources.cpp: Removed SVGElementFactory.cpp, since including
  29671. it leads to ambiguities for symbols like "aTag", which exist in both
  29672. the HTMLNames and SVGNames namespaces.
  29673. * WebCore.vcproj/WebCore.vcproj: Added SVGElementFactory.cpp to the
  29674. project directly. VS also decided to reformat this file a little bit.
  29675. 2009-02-10 Julien Chaffraix <jchaffraix@webkit.org>
  29676. Reviewed by Eric Seidel.
  29677. Bug 23536: Auto-generate HTMLElementFactory
  29678. Those are the last auto-generation bits needed to have a working generated HTMLElementFactory:
  29679. - Added a new option mapToTagName that enables a tag to use another's options and tagName (<image>
  29680. uses imgTag for example) and wired the code generation to be consistent with the current factory.
  29681. - Disabled dashboard compatibility check for HTMLElementFactory as it would make at least one test case fail.
  29682. - Pass the QualifiedName down to the Element constructor for shared constructors to make the generated code as
  29683. close as possible to the current one. We will pass the QualifiedName for all Element in a forthcoming patch.
  29684. * dom/make_names.pl: Did all the above points and tweaked the code generation to match the current HTMLElementFactory
  29685. as closely as possible.
  29686. * html/HTMLElementFactory.cpp:
  29687. (WebCore::quoteConstructor):
  29688. * html/HTMLQuoteElement.cpp:
  29689. (WebCore::HTMLQuoteElement::HTMLQuoteElement): Moved setUsesBeforeAfterRules to HTMLQuoteElement' constructor because some
  29690. part of the code creates elements without using the HTMLElementFactory. Also added a FIXME as it is not the right place.
  29691. * html/HTMLTagNames.in: Corrected <image> parameters.
  29692. 2009-02-10 David Hyatt <hyatt@apple.com>
  29693. Fix for pixel test regression in fast/text. Make sure not to add in
  29694. the borderTop and paddingTop of the block to the baseline when painting
  29695. strict mode text decorations.
  29696. Reviewed by Mark Rowe
  29697. * rendering/InlineFlowBox.cpp:
  29698. (WebCore::InlineFlowBox::paintTextDecorations):
  29699. * rendering/InlineFlowBox.h:
  29700. 2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
  29701. Windows build fix after r40837.
  29702. Not reviewed.
  29703. * DerivedSources.cpp:
  29704. 2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
  29705. <rdar://6349412> REGRESSION(r37204): Page is not repainted during and
  29706. after pan scrolling
  29707. Reviewed by Steve Falkenburg.
  29708. * platform/ScrollView.cpp:
  29709. (WebCore::ScrollView::scrollContents): Don't repaint the pan scroll
  29710. icon rect immediately; we will paint after the view has been scrolled.
  29711. 2009-02-10 Oliver Hunt <oliver@apple.com>
  29712. Reviewed by Adele Peterson.
  29713. <rdar://problem/6156755> onMouseOver events do not fire properly for cross frame drag and drop
  29714. This problem was caused by incorrectly ignoring whether or not the
  29715. default behaviour of the mousedown event was suppressed. If a
  29716. mousedown handler in a frame prevents default handling then the
  29717. subsequent mousemove events fired for the drag should not be
  29718. captured by that frame, should the mouse move out of its bounds.
  29719. Test: fast/events/mouse-drag-from-frame.html
  29720. * page/EventHandler.cpp:
  29721. (WebCore::EventHandler::EventHandler):
  29722. (WebCore::EventHandler::clear):
  29723. (WebCore::EventHandler::handleMouseReleaseEvent):
  29724. Reset new m_capturesDragging flag
  29725. (WebCore::EventHandler::handleMousePressEvent):
  29726. Respect the m_capturesDragging flag when we propagate
  29727. a mousedown event to a subframe.
  29728. * page/EventHandler.h:
  29729. (WebCore::EventHandler::capturesDragging):
  29730. 2009-02-10 Kevin Ollivier <kevino@theolliviers.com>
  29731. wx build fixes for recent changes to TransformationMatrix and DOMElement.
  29732. * WebCoreSources.bkl:
  29733. * dom/Element.cpp:
  29734. * platform/graphics/transforms/TransformationMatrix.h:
  29735. * platform/graphics/wx/TransformationMatrixWx.cpp:
  29736. (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
  29737. 2009-02-10 David Hyatt <hyatt@apple.com>
  29738. Some renames on line boxes. xPos()/yPos() -> x()/y(). setXPos()/setYPos() -> setX()/setY(). m_object/object() -> m_renderer/renderer(). textObject() -> textRenderer().
  29739. Reviewed by Sam Weinig
  29740. * dom/Position.cpp:
  29741. (WebCore::Position::upstream):
  29742. (WebCore::Position::downstream):
  29743. * editing/VisiblePosition.cpp:
  29744. (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
  29745. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
  29746. (WebCore::VisiblePosition::localCaretRect):
  29747. * editing/visible_units.cpp:
  29748. (WebCore::startPositionForLine):
  29749. (WebCore::endPositionForLine):
  29750. (WebCore::previousLinePosition):
  29751. (WebCore::nextLinePosition):
  29752. * rendering/EllipsisBox.cpp:
  29753. (WebCore::EllipsisBox::paint):
  29754. (WebCore::EllipsisBox::nodeAtPoint):
  29755. * rendering/InlineBox.cpp:
  29756. (WebCore::InlineBox::showTreeForThis):
  29757. (WebCore::InlineBox::height):
  29758. (WebCore::InlineBox::caretMinOffset):
  29759. (WebCore::InlineBox::caretMaxOffset):
  29760. (WebCore::InlineBox::deleteLine):
  29761. (WebCore::InlineBox::extractLine):
  29762. (WebCore::InlineBox::attachLine):
  29763. (WebCore::InlineBox::adjustPosition):
  29764. (WebCore::InlineBox::paint):
  29765. (WebCore::InlineBox::nodeAtPoint):
  29766. (WebCore::InlineBox::selectionState):
  29767. (WebCore::InlineBox::canAccommodateEllipsis):
  29768. * rendering/InlineBox.h:
  29769. (WebCore::InlineBox::InlineBox):
  29770. (WebCore::InlineBox::renderer):
  29771. (WebCore::InlineBox::setX):
  29772. (WebCore::InlineBox::x):
  29773. (WebCore::InlineBox::setY):
  29774. (WebCore::InlineBox::y):
  29775. (WebCore::InlineBox::topOverflow):
  29776. (WebCore::InlineBox::bottomOverflow):
  29777. (WebCore::InlineBox::leftOverflow):
  29778. (WebCore::InlineBox::rightOverflow):
  29779. (WebCore::InlineBox::visibleToHitTesting):
  29780. (WebCore::InlineBox::boxModelObject):
  29781. * rendering/InlineFlowBox.cpp:
  29782. (WebCore::InlineFlowBox::height):
  29783. (WebCore::InlineFlowBox::addToLine):
  29784. (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
  29785. (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
  29786. (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
  29787. (WebCore::InlineFlowBox::rendererLineBoxes):
  29788. (WebCore::InlineFlowBox::onEndChain):
  29789. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  29790. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  29791. (WebCore::InlineFlowBox::verticallyAlignBoxes):
  29792. (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
  29793. (WebCore::verticalPositionForBox):
  29794. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  29795. (WebCore::InlineFlowBox::placeBoxesVertically):
  29796. (WebCore::InlineFlowBox::nodeAtPoint):
  29797. (WebCore::InlineFlowBox::paint):
  29798. (WebCore::InlineFlowBox::paintFillLayer):
  29799. (WebCore::InlineFlowBox::paintBoxShadow):
  29800. (WebCore::InlineFlowBox::paintBoxDecorations):
  29801. (WebCore::InlineFlowBox::paintMask):
  29802. (WebCore::InlineFlowBox::paintTextDecorations):
  29803. * rendering/InlineFlowBox.h:
  29804. (WebCore::InlineFlowBox::borderLeft):
  29805. (WebCore::InlineFlowBox::borderRight):
  29806. (WebCore::InlineFlowBox::borderTop):
  29807. (WebCore::InlineFlowBox::borderBottom):
  29808. (WebCore::InlineFlowBox::baseline):
  29809. * rendering/InlineTextBox.cpp:
  29810. (WebCore::InlineTextBox::height):
  29811. (WebCore::InlineTextBox::selectionState):
  29812. (WebCore::InlineTextBox::selectionRect):
  29813. (WebCore::InlineTextBox::deleteLine):
  29814. (WebCore::InlineTextBox::extractLine):
  29815. (WebCore::InlineTextBox::attachLine):
  29816. (WebCore::InlineTextBox::placeEllipsisBox):
  29817. (WebCore::InlineTextBox::isLineBreak):
  29818. (WebCore::InlineTextBox::nodeAtPoint):
  29819. (WebCore::InlineTextBox::paint):
  29820. (WebCore::InlineTextBox::selectionStartEnd):
  29821. (WebCore::InlineTextBox::paintSelection):
  29822. (WebCore::InlineTextBox::paintCompositionBackground):
  29823. (WebCore::InlineTextBox::paintCustomHighlight):
  29824. (WebCore::InlineTextBox::paintDecoration):
  29825. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  29826. (WebCore::InlineTextBox::paintTextMatchMarker):
  29827. (WebCore::InlineTextBox::paintDocumentMarkers):
  29828. (WebCore::InlineTextBox::paintCompositionUnderline):
  29829. (WebCore::InlineTextBox::textPos):
  29830. (WebCore::InlineTextBox::offsetForPosition):
  29831. (WebCore::InlineTextBox::positionForOffset):
  29832. * rendering/InlineTextBox.h:
  29833. (WebCore::InlineTextBox::textRenderer):
  29834. * rendering/ListMarkerBox.cpp:
  29835. (WebCore::ListMarkerBox::isText):
  29836. * rendering/RenderBlock.cpp:
  29837. (WebCore::RenderBlock::paintEllipsisBoxes):
  29838. (WebCore::RenderBlock::lowestPosition):
  29839. (WebCore::RenderBlock::rightmostPosition):
  29840. (WebCore::RenderBlock::leftmostPosition):
  29841. (WebCore::RenderBlock::positionForBox):
  29842. (WebCore::RenderBlock::positionForCoordinates):
  29843. (WebCore::RenderBlock::getBaselineOfFirstLineBox):
  29844. (WebCore::RenderBlock::getBaselineOfLastLineBox):
  29845. (WebCore::RenderBlock::adjustForBorderFit):
  29846. (WebCore::RenderBlock::addFocusRingRects):
  29847. * rendering/RenderBox.cpp:
  29848. (WebCore::RenderBox::paintCustomHighlight):
  29849. (WebCore::RenderBox::position):
  29850. (WebCore::RenderBox::containingBlockWidthForPositioned):
  29851. (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  29852. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  29853. * rendering/RenderBoxModelObject.cpp:
  29854. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  29855. * rendering/RenderFlexibleBox.cpp:
  29856. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  29857. * rendering/RenderInline.cpp:
  29858. (WebCore::RenderInline::absoluteRects):
  29859. (WebCore::RenderInline::absoluteQuads):
  29860. (WebCore::RenderInline::offsetLeft):
  29861. (WebCore::RenderInline::offsetTop):
  29862. (WebCore::RenderInline::linesBoundingBox):
  29863. (WebCore::RenderInline::relativePositionedInlineOffset):
  29864. (WebCore::RenderInline::addFocusRingRects):
  29865. (WebCore::RenderInline::paintOutline):
  29866. * rendering/RenderLayer.cpp:
  29867. (WebCore::RenderLayer::localBoundingBox):
  29868. * rendering/RenderSVGTSpan.cpp:
  29869. (WebCore::RenderSVGTSpan::absoluteRects):
  29870. (WebCore::RenderSVGTSpan::absoluteQuads):
  29871. * rendering/RenderSVGText.cpp:
  29872. (WebCore::RenderSVGText::absoluteRects):
  29873. (WebCore::RenderSVGText::absoluteQuads):
  29874. (WebCore::RenderSVGText::relativeBBox):
  29875. * rendering/RenderSVGTextPath.cpp:
  29876. (WebCore::RenderSVGTextPath::absoluteRects):
  29877. (WebCore::RenderSVGTextPath::absoluteQuads):
  29878. * rendering/RenderText.cpp:
  29879. (WebCore::RenderText::absoluteRects):
  29880. (WebCore::RenderText::absoluteRectsForRange):
  29881. (WebCore::RenderText::absoluteQuads):
  29882. (WebCore::RenderText::absoluteQuadsForRange):
  29883. (WebCore::RenderText::localCaretRect):
  29884. (WebCore::RenderText::linesBoundingBox):
  29885. * rendering/RootInlineBox.cpp:
  29886. (WebCore::RootInlineBox::height):
  29887. (WebCore::RootInlineBox::clearTruncation):
  29888. (WebCore::RootInlineBox::placeEllipsis):
  29889. (WebCore::RootInlineBox::paintEllipsisBox):
  29890. (WebCore::RootInlineBox::addHighlightOverflow):
  29891. (WebCore::RootInlineBox::paintCustomHighlight):
  29892. (WebCore::RootInlineBox::paint):
  29893. (WebCore::RootInlineBox::nodeAtPoint):
  29894. (WebCore::RootInlineBox::childRemoved):
  29895. (WebCore::RootInlineBox::fillLineSelectionGap):
  29896. (WebCore::RootInlineBox::block):
  29897. (WebCore::isEditableLeaf):
  29898. (WebCore::RootInlineBox::closestLeafChildForXPos):
  29899. (WebCore::RootInlineBox::setVerticalOverflowPositions):
  29900. * rendering/RootInlineBox.h:
  29901. (WebCore::RootInlineBox::bottomOverflow):
  29902. (WebCore::RootInlineBox::floats):
  29903. (WebCore::RootInlineBox::setHorizontalOverflowPositions):
  29904. (WebCore::RootInlineBox::setVerticalSelectionPositions):
  29905. * rendering/SVGCharacterLayoutInfo.cpp:
  29906. (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
  29907. * rendering/SVGInlineTextBox.cpp:
  29908. (WebCore::SVGInlineTextBox::calculateGlyphWidth):
  29909. (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
  29910. (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback):
  29911. (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
  29912. (WebCore::SVGInlineTextBox::nodeAtPoint):
  29913. (WebCore::SVGInlineTextBox::paintCharacters):
  29914. (WebCore::SVGInlineTextBox::paintSelection):
  29915. (WebCore::SVGInlineTextBox::paintDecoration):
  29916. * rendering/SVGRenderTreeAsText.cpp:
  29917. (WebCore::writeSVGInlineTextBox):
  29918. * rendering/SVGRootInlineBox.cpp:
  29919. (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
  29920. (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
  29921. (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
  29922. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
  29923. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
  29924. (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
  29925. (WebCore::SVGRootInlineBox::paint):
  29926. (WebCore::cummulatedWidthOfInlineBoxCharacterRange):
  29927. (WebCore::cummulatedHeightOfInlineBoxCharacterRange):
  29928. (WebCore::svgTextRunForInlineTextBox):
  29929. (WebCore::cummulatedWidthOrHeightOfTextChunk):
  29930. (WebCore::applyTextAnchorToTextChunk):
  29931. (WebCore::SVGRootInlineBox::buildLayoutInformation):
  29932. (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  29933. (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  29934. (WebCore::SVGRootInlineBox::buildTextChunks):
  29935. * rendering/bidi.cpp:
  29936. (WebCore::RenderBlock::constructLine):
  29937. (WebCore::RenderBlock::computeVerticalPositionsForLine):
  29938. (WebCore::RenderBlock::layoutInlineChildren):
  29939. (WebCore::RenderBlock::checkLinesForTextOverflow):
  29940. * svg/SVGTextContentElement.cpp:
  29941. (WebCore::cumulativeCharacterRangeLength):
  29942. (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
  29943. (WebCore::findInlineTextBoxInTextChunks):
  29944. 2009-02-10 Simon Fraser <simon.fraser@apple.com>
  29945. Reviewed by Dave Hyatt
  29946. Clean up "fallbackAnimating" logic in AnimationBase. This flag indicates
  29947. that animation of an accelerated property must run in software for some reason.
  29948. Also remove use of private headers in GraphicsLayerCA related to a case
  29949. where we may have to fall back on software animation of transform.
  29950. * page/animation/AnimationBase.cpp:
  29951. (WebCore::AnimationBase::blendProperties):
  29952. * page/animation/AnimationBase.h:
  29953. * page/animation/ImplicitAnimation.cpp:
  29954. (WebCore::ImplicitAnimation::animate):
  29955. * page/animation/KeyframeAnimation.cpp:
  29956. (WebCore::KeyframeAnimation::animate):
  29957. * platform/graphics/mac/GraphicsLayerCA.h:
  29958. * platform/graphics/mac/GraphicsLayerCA.mm:
  29959. (WebCore::getValueFunctionNameForTransformOperation):
  29960. (WebCore::caValueFunctionSupported):
  29961. (WebCore::GraphicsLayerCA::setBackgroundColor):
  29962. (WebCore::GraphicsLayerCA::setOpacity):
  29963. (WebCore::GraphicsLayerCA::animateTransform):
  29964. (WebCore::GraphicsLayerCA::animateFloat):
  29965. (WebCore::GraphicsLayerCA::setBasicAnimation):
  29966. (WebCore::GraphicsLayerCA::setKeyframeAnimation):
  29967. 2009-02-10 Simon Fraser <simon.fraser@apple.com>
  29968. Reviewed by Dave Hyatt
  29969. Move enclosingCompositingLayer() from RenderObject to RenderLayer, since it
  29970. relates to the RenderLayer z-order/overflow structure, rather than the render tree
  29971. parent chain. Add a convenience method, ancestorCompositingLayer(), which finds
  29972. the enclosing layer excluding self.
  29973. Fix enclosingCompositingLayer() to correctly look at stacking context and overflow
  29974. lists.
  29975. Check for documentBeingDestroyed() in a few places to avoid work on document
  29976. teardown.
  29977. * rendering/RenderLayer.cpp:
  29978. (WebCore::RenderLayer::enclosingCompositingLayer):
  29979. (WebCore::RenderLayer::setParent):
  29980. (WebCore::RenderLayer::dirtyZOrderLists):
  29981. (WebCore::RenderLayer::dirtyOverflowList):
  29982. * rendering/RenderLayer.h:
  29983. (WebCore::RenderLayer::ancestorCompositingLayer):
  29984. * rendering/RenderLayerBacking.cpp:
  29985. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  29986. * rendering/RenderLayerCompositor.cpp:
  29987. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  29988. (WebCore::RenderLayerCompositor::calculateCompositedBounds):
  29989. (WebCore::RenderLayerCompositor::layerWillBeRemoved):
  29990. (WebCore::RenderLayerCompositor::clippedByAncestor):
  29991. * rendering/RenderLayerCompositor.h:
  29992. * rendering/RenderObject.cpp:
  29993. (WebCore::RenderObject::containerForRepaint):
  29994. * rendering/RenderObject.h:
  29995. 2009-02-10 David Hyatt <hyatt@apple.com>
  29996. Rename xPos() and yPos() on RenderLayer to x() and y() to match RenderBox. Rename setPos to setLocation.
  29997. Reviewed by Simon Fraser
  29998. * dom/MouseRelatedEvent.cpp:
  29999. (WebCore::MouseRelatedEvent::receivedTarget):
  30000. * rendering/RenderLayer.cpp:
  30001. (WebCore::RenderLayer::updateLayerPosition):
  30002. (WebCore::RenderLayer::convertToLayerCoords):
  30003. * rendering/RenderLayer.h:
  30004. (WebCore::RenderLayer::x):
  30005. (WebCore::RenderLayer::y):
  30006. (WebCore::RenderLayer::setLocation):
  30007. * rendering/RenderTreeAsText.cpp:
  30008. (WebCore::write):
  30009. (WebCore::externalRepresentation):
  30010. 2009-02-10 Darin Fisher <darin@chromium.org>
  30011. Reviewed by Eric Seidel.
  30012. https://bugs.webkit.org/show_bug.cgi?id=23879
  30013. Add missing PLATFORM(SKIA) changes to TransformationMatrix.h
  30014. * platform/graphics/transforms/TransformationMatrix.h:
  30015. 2009-02-10 Sam Weinig <sam@webkit.org>
  30016. Reviewed by David Hyatt.
  30017. Fix for https://bugs.webkit.org/show_bug.cgi?id=15897
  30018. Please implement getBoundingClientRect and getClientRects
  30019. <rdar://problem/6139669>
  30020. Cursory implementation of Element.getBoundingClientRect and
  30021. Element.getClientRects. Adds necessary infrastructure classes
  30022. ClientRect and ClientRectList.
  30023. Tests: fast/dom/getBoundingClientRect.html
  30024. fast/dom/getClientRects.html
  30025. * DerivedSources.make:
  30026. * GNUmakefile.am:
  30027. * WebCore.pro:
  30028. * WebCore.vcproj/WebCore.vcproj:
  30029. * WebCore.xcodeproj/project.pbxproj:
  30030. * WebCoreSources.bkl:
  30031. * dom/ClientRect.cpp: Added.
  30032. (WebCore::ClientRect::ClientRect):
  30033. * dom/ClientRect.h: Added.
  30034. (WebCore::ClientRect::create):
  30035. (WebCore::ClientRect::top):
  30036. (WebCore::ClientRect::right):
  30037. (WebCore::ClientRect::bottom):
  30038. (WebCore::ClientRect::left):
  30039. (WebCore::ClientRect::width):
  30040. (WebCore::ClientRect::height):
  30041. * dom/ClientRect.idl: Added.
  30042. * dom/ClientRectList.cpp: Added.
  30043. (WebCore::ClientRectList::ClientRectList):
  30044. (WebCore::ClientRectList::~ClientRectList):
  30045. (WebCore::ClientRectList::length):
  30046. (WebCore::ClientRectList::item):
  30047. * dom/ClientRectList.h: Added.
  30048. (WebCore::ClientRectList::create):
  30049. * dom/ClientRectList.idl: Added.
  30050. * dom/Element.cpp:
  30051. (WebCore::Element::getClientRects):
  30052. (WebCore::Element::getBoundingClientRect):
  30053. * dom/Element.h:
  30054. * dom/Element.idl:
  30055. * page/DOMWindow.idl:
  30056. * rendering/RenderInline.cpp:
  30057. (WebCore::RenderInline::absoluteRects):
  30058. (WebCore::RenderInline::absoluteQuads):
  30059. 2009-02-10 David Hyatt <hyatt@apple.com>
  30060. Get rid of capsLockStateMayHaveChanged on RenderObject. It is only implemented by one class (text fields),
  30061. so devirtualize and just query at the single call site.
  30062. Reviewed by Eric Seidel
  30063. * page/EventHandler.cpp:
  30064. (WebCore::EventHandler::capsLockStateMayHaveChanged):
  30065. * rendering/RenderObject.h:
  30066. * rendering/RenderTextControlSingleLine.h:
  30067. 2009-02-10 David Hyatt <hyatt@apple.com>
  30068. Shrink the size of all RenderObjects (except for RenderInlines) by 4 bytes. This patch moves the cached vertical position member to RenderInlines,
  30069. since they were the only objects being queried across multiple lines.
  30070. Reviewed by Sam Weinig
  30071. * rendering/InlineFlowBox.cpp:
  30072. (WebCore::verticalPositionForBox):
  30073. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  30074. * rendering/RenderBoxModelObject.cpp:
  30075. (WebCore::RenderBoxModelObject::verticalPosition):
  30076. * rendering/RenderBoxModelObject.h:
  30077. * rendering/RenderInline.cpp:
  30078. (WebCore::RenderInline::RenderInline):
  30079. (WebCore::RenderInline::verticalPositionFromCache):
  30080. * rendering/RenderInline.h:
  30081. (WebCore::RenderInline::invalidateVerticalPosition):
  30082. * rendering/RenderObject.cpp:
  30083. (WebCore::RenderObject::RenderObject):
  30084. * rendering/RenderObject.h:
  30085. * rendering/RenderText.cpp:
  30086. * rendering/RenderText.h:
  30087. * rendering/bidi.cpp:
  30088. (WebCore::RenderBlock::layoutInlineChildren):
  30089. 2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
  30090. Reviewed by Mark Rowe.
  30091. https://bugs.webkit.org/show_bug.cgi?id=23868
  30092. Fix code style issues: removed 80-col wrapping, incorrect include style, if statement body on same line.
  30093. * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  30094. * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  30095. 2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
  30096. Reviewed by Eric Seidel.
  30097. https://bugs.webkit.org/show_bug.cgi?id=23868
  30098. Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings.
  30099. * bindings/v8/custom/V8HTMLInputElementCustom.cpp: Added.
  30100. (WebCore::ACCESSOR_GETTER):
  30101. (WebCore::ACCESSOR_SETTER):
  30102. (WebCore::CALLBACK_FUNC_DECL):
  30103. * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Added.
  30104. (WebCore::ACCESSOR_GETTER):
  30105. (WebCore::ACCESSOR_SETTER):
  30106. 2009-02-10 Adam Roben <aroben@apple.com>
  30107. Fix Bug 23871: Assertion failure beneath WebCore::openFunc when
  30108. running http/tests/security/xss-DENIED-xsl-document-redirect.xml
  30109. <https://bugs.webkit.org/show_bug.cgi?id=23871>
  30110. Reviewed by Alexey Proskuryakov.
  30111. Covered by existing tests.
  30112. * dom/XMLTokenizerLibxml2.cpp:
  30113. (WebCore::openFunc): Use the two-parameter KURL constructor so that
  30114. the string will be parsed. libxml2 gives us a UTF-8-encoded string
  30115. that needs to be parsed.
  30116. 2009-02-10 David Hyatt <hyatt@apple.com>
  30117. Shrink the size of all replaced elements (images, form controls, plugins) by 4 bytes by packing the
  30118. overflow boolean into the RenderObject base class.
  30119. Reviewed by Sam Weinig
  30120. * rendering/RenderObject.cpp:
  30121. (WebCore::RenderObject::RenderObject):
  30122. * rendering/RenderObject.h:
  30123. (WebCore::RenderObject::replacedHasOverflow):
  30124. (WebCore::RenderObject::setReplacedHasOverflow):
  30125. * rendering/RenderReplaced.cpp:
  30126. (WebCore::RenderReplaced::RenderReplaced):
  30127. (WebCore::RenderReplaced::~RenderReplaced):
  30128. (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
  30129. (WebCore::RenderReplaced::overflowHeight):
  30130. (WebCore::RenderReplaced::overflowWidth):
  30131. (WebCore::RenderReplaced::overflowLeft):
  30132. (WebCore::RenderReplaced::overflowTop):
  30133. (WebCore::RenderReplaced::overflowRect):
  30134. * rendering/RenderReplaced.h:
  30135. 2009-02-10 Eric Carlson <eric.carlson@apple.com>
  30136. Reviewed by Simon Fraser.
  30137. https://bugs.webkit.org/show_bug.cgi?id=23870
  30138. Make it possible for a port to require a user gesture for an <audio> or <video> element
  30139. to load a url.
  30140. * html/HTMLMediaElement.cpp:
  30141. (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_loadRestrictions.
  30142. (WebCore::HTMLMediaElement::attributeChanged): Only one attribute can change so put an "else" between tests.
  30143. (WebCore::HTMLMediaElement::load): Return INVALID_STATE_ERR if RequireUserGestureLoadRestriction is set
  30144. and we are not preocessing a user gesture.
  30145. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): Remove unnecessary white space.
  30146. (WebCore::HTMLMediaElement::play): Ditto.
  30147. (WebCore::HTMLMediaElement::endScrubbing): Remove unnecessary braces added in r40789.
  30148. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Cache currentTime() in a local instead of calling it
  30149. multiple times.
  30150. (WebCore::HTMLMediaElement::processingUserGesture): New.
  30151. * html/HTMLMediaElement.h:
  30152. (WebCore::HTMLMediaElement::): Define LoadRestrictions, add m_loadRestrictions.
  30153. 2009-02-10 Holger Hans Peter Freyther <zecke@selfish.org>
  30154. Reviewed by Sam Weinig.
  30155. Remove the SVG checks from FloatPoint3D as it is used
  30156. by TransformationMatrix.
  30157. * platform/graphics/FloatPoint3D.cpp:
  30158. * platform/graphics/FloatPoint3D.h:
  30159. 2009-02-10 David Hyatt <hyatt@apple.com>
  30160. Remove the m_baseline member variable from all line boxes, since it can easily be computed when needed and did not need to be cached.
  30161. Reviewed by Sam Weinig
  30162. * rendering/EllipsisBox.cpp:
  30163. (WebCore::EllipsisBox::paint):
  30164. (WebCore::EllipsisBox::nodeAtPoint):
  30165. * rendering/EllipsisBox.h:
  30166. (WebCore::EllipsisBox::EllipsisBox):
  30167. * rendering/InlineBox.h:
  30168. (WebCore::InlineBox::InlineBox):
  30169. * rendering/InlineFlowBox.cpp:
  30170. (WebCore::InlineFlowBox::verticallyAlignBoxes):
  30171. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  30172. (WebCore::InlineFlowBox::placeBoxesVertically):
  30173. (WebCore::InlineFlowBox::paintTextDecorations):
  30174. * rendering/InlineFlowBox.h:
  30175. (WebCore::InlineFlowBox::marginBorderPaddingLeft):
  30176. (WebCore::InlineFlowBox::marginBorderPaddingRight):
  30177. (WebCore::InlineFlowBox::marginLeft):
  30178. (WebCore::InlineFlowBox::marginRight):
  30179. (WebCore::InlineFlowBox::borderLeft):
  30180. (WebCore::InlineFlowBox::borderRight):
  30181. (WebCore::InlineFlowBox::borderTop):
  30182. (WebCore::InlineFlowBox::borderBottom):
  30183. (WebCore::InlineFlowBox::paddingLeft):
  30184. (WebCore::InlineFlowBox::paddingRight):
  30185. (WebCore::InlineFlowBox::paddingTop):
  30186. (WebCore::InlineFlowBox::paddingBottom):
  30187. (WebCore::InlineFlowBox::includeLeftEdge):
  30188. (WebCore::InlineFlowBox::includeRightEdge):
  30189. (WebCore::InlineFlowBox::baseline):
  30190. * rendering/InlineTextBox.cpp:
  30191. (WebCore::InlineTextBox::paint):
  30192. (WebCore::InlineTextBox::paintDecoration):
  30193. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  30194. (WebCore::InlineTextBox::paintCompositionUnderline):
  30195. * rendering/RenderBlock.cpp:
  30196. (WebCore::RenderBlock::getBaselineOfFirstLineBox):
  30197. (WebCore::RenderBlock::getBaselineOfLastLineBox):
  30198. * rendering/RenderTableCell.cpp:
  30199. (WebCore::RenderTableCell::baselinePosition):
  30200. * rendering/RootInlineBox.cpp:
  30201. (WebCore::RootInlineBox::placeEllipsis):
  30202. * rendering/SVGInlineTextBox.cpp:
  30203. (WebCore::SVGInlineTextBox::paintDecoration):
  30204. * rendering/SVGRootInlineBox.cpp:
  30205. (WebCore::applyTextAnchorToTextChunk):
  30206. (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  30207. 2009-02-10 Alexey Proskuryakov <ap@webkit.org>
  30208. Reviewed by Darin Adler.
  30209. https://bugs.webkit.org/show_bug.cgi?id=23867
  30210. Eliminate obsolete frame->document() checks
  30211. * page/FrameView.cpp: (WebCore::FrameView::paintContents): Apparently due to a typo
  30212. (document vs. !document), fillWithRed was always set to false, and other branches were
  30213. never taken. Removing the check for document restores debug-only red color filling.
  30214. * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Only call dispatchWindowObjectAvailable()
  30215. after a document is created. A client can do anything in its delegate method, so we'd need
  30216. to have frame->document() checks otherwise. DumpRenderTree uses this delegate to add its
  30217. custom property, and it was crashing due to null document in JSDOMWindowBase::getOwnPropertySlot().
  30218. * bindings/js/JSDOMWindowBase.cpp:
  30219. (WebCore::JSDOMWindowBase::getOwnPropertySlot):
  30220. * bindings/js/JSDOMWindowCustom.cpp:
  30221. (WebCore::JSDOMWindow::addEventListener):
  30222. (WebCore::JSDOMWindow::removeEventListener):
  30223. * bindings/js/JSNavigatorCustom.cpp:
  30224. (WebCore::needsYouTubeQuirk):
  30225. * bindings/js/ScheduledAction.cpp:
  30226. (WebCore::ScheduledAction::execute):
  30227. * bindings/js/ScriptControllerMac.mm:
  30228. (WebCore::updateRenderingForBindings):
  30229. * dom/Document.cpp:
  30230. (WebCore::Document::initSecurityContext):
  30231. * editing/Editor.cpp:
  30232. (WebCore::Editor::deleteWithDirection):
  30233. (WebCore::Editor::dispatchCPPEvent):
  30234. (WebCore::Editor::applyStyle):
  30235. (WebCore::Editor::applyParagraphStyle):
  30236. * editing/EditorCommand.cpp:
  30237. (WebCore::Editor::Command::execute):
  30238. (WebCore::Editor::Command::isEnabled):
  30239. (WebCore::Editor::Command::state):
  30240. (WebCore::Editor::Command::value):
  30241. * editing/SelectionController.cpp:
  30242. (WebCore::SelectionController::recomputeCaretRect):
  30243. (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
  30244. (WebCore::SelectionController::selectAll):
  30245. (WebCore::SelectionController::setFocused):
  30246. * inspector/InspectorController.cpp:
  30247. (WebCore::getResourceDocumentNode):
  30248. * inspector/JavaScriptDebugServer.cpp:
  30249. (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  30250. * loader/DocumentLoader.cpp:
  30251. (WebCore::canonicalizedTitle):
  30252. (WebCore::DocumentLoader::stopLoading):
  30253. (WebCore::DocumentLoader::isLoadingInAPISense):
  30254. (WebCore::DocumentLoader::subresource):
  30255. (WebCore::DocumentLoader::getSubresources):
  30256. * loader/FrameLoader.cpp:
  30257. (WebCore::FrameLoader::urlSelected):
  30258. (WebCore::FrameLoader::stop):
  30259. (WebCore::FrameLoader::iconURL):
  30260. (WebCore::FrameLoader::executeIfJavaScriptURL):
  30261. (WebCore::FrameLoader::clear):
  30262. (WebCore::FrameLoader::endIfNotLoadingMainResource):
  30263. (WebCore::FrameLoader::restoreDocumentState):
  30264. (WebCore::FrameLoader::gotoAnchor):
  30265. (WebCore::FrameLoader::loadDone):
  30266. (WebCore::FrameLoader::checkCompleted):
  30267. (WebCore::FrameLoader::checkCallImplicitClose):
  30268. (WebCore::FrameLoader::scheduleRefresh):
  30269. (WebCore::FrameLoader::outgoingOrigin):
  30270. (WebCore::FrameLoader::canCachePageContainingThisFrame):
  30271. (WebCore::FrameLoader::logCanCacheFrameDecision):
  30272. (WebCore::FrameLoader::updatePolicyBaseURL):
  30273. (WebCore::FrameLoader::setPolicyBaseURL):
  30274. (WebCore::FrameLoader::frameDetached):
  30275. (WebCore::FrameLoader::shouldScrollToAnchor):
  30276. (WebCore::FrameLoader::saveDocumentState):
  30277. * loader/archive/cf/LegacyWebArchive.cpp:
  30278. (WebCore::LegacyWebArchive::create):
  30279. * loader/icon/IconFetcher.cpp:
  30280. (WebCore::IconFetcher::create):
  30281. * loader/icon/IconLoader.cpp:
  30282. (WebCore::IconLoader::startLoading):
  30283. * page/AccessibilityRenderObject.cpp:
  30284. (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  30285. * page/Chrome.cpp:
  30286. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  30287. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  30288. * page/DOMWindow.cpp:
  30289. (WebCore::DOMWindow::sessionStorage):
  30290. (WebCore::DOMWindow::alert):
  30291. (WebCore::DOMWindow::confirm):
  30292. (WebCore::DOMWindow::prompt):
  30293. (WebCore::DOMWindow::scrollX):
  30294. (WebCore::DOMWindow::scrollY):
  30295. (WebCore::DOMWindow::getMatchedCSSRules):
  30296. (WebCore::DOMWindow::openDatabase):
  30297. (WebCore::DOMWindow::scrollBy):
  30298. (WebCore::DOMWindow::scrollTo):
  30299. * page/EventHandler.cpp:
  30300. (WebCore::EventHandler::allowDHTMLDrag):
  30301. (WebCore::EventHandler::scrollOverflow):
  30302. (WebCore::EventHandler::handleMousePressEvent):
  30303. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  30304. (WebCore::EventHandler::handleMouseMoveEvent):
  30305. (WebCore::EventHandler::handleMouseReleaseEvent):
  30306. (WebCore::EventHandler::updateDragAndDrop):
  30307. (WebCore::EventHandler::handleWheelEvent):
  30308. (WebCore::EventHandler::sendContextMenuEvent):
  30309. (WebCore::EventHandler::capsLockStateMayHaveChanged):
  30310. (WebCore::EventHandler::sendResizeEvent):
  30311. (WebCore::EventHandler::sendScrollEvent):
  30312. * page/FocusController.cpp:
  30313. (WebCore::deepFocusableNode):
  30314. (WebCore::FocusController::advanceFocus):
  30315. * page/Frame.cpp:
  30316. (WebCore::Frame::setFocusedNodeIfNeeded):
  30317. (WebCore::Frame::shouldApplyTextZoom):
  30318. (WebCore::Frame::shouldApplyPageZoom):
  30319. (WebCore::Frame::setZoomFactor):
  30320. (WebCore::Frame::setPrinting):
  30321. (WebCore::Frame::reapplyStyles):
  30322. (WebCore::Frame::isContentEditable):
  30323. (WebCore::Frame::computeAndSetTypingStyle):
  30324. (WebCore::Frame::selectionComputedStyle):
  30325. (WebCore::Frame::applyEditingStyleToBodyElement):
  30326. (WebCore::Frame::removeEditingStyleFromBodyElement):
  30327. (WebCore::Frame::contentRenderer):
  30328. (WebCore::Frame::styleForSelectionStart):
  30329. (WebCore::Frame::setSelectionFromNone):
  30330. (WebCore::Frame::findString):
  30331. (WebCore::Frame::markAllMatchesForText):
  30332. (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
  30333. (WebCore::Frame::documentTypeString):
  30334. (WebCore::Frame::shouldClose):
  30335. (WebCore::Frame::respondToChangedSelection):
  30336. * page/FrameView.cpp:
  30337. (WebCore::FrameView::~FrameView):
  30338. (WebCore::FrameView::createScrollbar):
  30339. (WebCore::FrameView::layout):
  30340. (WebCore::FrameView::layoutTimerFired):
  30341. (WebCore::FrameView::scheduleRelayout):
  30342. (WebCore::FrameView::needsLayout):
  30343. (WebCore::FrameView::unscheduleRelayout):
  30344. (WebCore::FrameView::windowClipRect):
  30345. * page/Geolocation.cpp:
  30346. (WebCore::Geolocation::disconnectFrame):
  30347. * page/Page.cpp:
  30348. (WebCore::networkStateChanged):
  30349. (WebCore::Page::~Page):
  30350. (WebCore::Page::unmarkAllTextMatches):
  30351. (WebCore::Page::setMediaVolume):
  30352. * page/animation/AnimationController.cpp:
  30353. (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
  30354. * page/mac/EventHandlerMac.mm:
  30355. (WebCore::EventHandler::currentKeyboardEvent):
  30356. (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
  30357. * page/mac/FrameMac.mm:
  30358. (WebCore::Frame::dashboardRegionsDictionary):
  30359. (WebCore::Frame::setUserStyleSheetLocation):
  30360. (WebCore::Frame::setUserStyleSheet):
  30361. * storage/LocalStorageArea.cpp:
  30362. (WebCore::LocalStorageArea::dispatchStorageEvent):
  30363. * storage/SessionStorageArea.cpp:
  30364. (WebCore::SessionStorageArea::dispatchStorageEvent):
  30365. * svg/graphics/SVGImage.cpp:
  30366. (WebCore::SVGImage::setContainerSize):
  30367. (WebCore::SVGImage::usesContainerSize):
  30368. (WebCore::SVGImage::size):
  30369. (WebCore::SVGImage::hasRelativeWidth):
  30370. (WebCore::SVGImage::hasRelativeHeight):
  30371. Removed frame->document() checks.
  30372. 2009-02-10 Adam Treat <adam.treat@torchmobile.com>
  30373. Reviewed by George Staikos.
  30374. Attempt to fix the Qt build after r40791.
  30375. * rendering/RenderSVGRoot.cpp:
  30376. 2009-02-10 Adam Treat <adam.treat@torchmobile.com>
  30377. Reviewed by George Staikos.
  30378. Minor code cleanup.
  30379. * dom/ContainerNode.cpp:
  30380. (WebCore::ContainerNode::replaceChild):
  30381. 2009-02-10 Adam Treat <adam.treat@torchmobile.com>
  30382. Fix Qt build following r40793.
  30383. * editing/qt/EditorQt.cpp:
  30384. 2009-02-10 Feng Qian <feng@chromium.org>
  30385. Reviewed by Alexey Proskuryakov.
  30386. Fix crashes when accessing navigator object of a deleted frame.
  30387. https://bugs.webkit.org/show_bug.cgi?id=23626
  30388. A layout test is added: fast/dom/navigator-detached-no-crash.html
  30389. * page/Navigator.cpp:
  30390. (WebCore::Navigator::cookieEnabled):
  30391. (WebCore::Navigator::javaEnabled):
  30392. 2009-02-10 Sverrir Berg <sverrir@chromium.org>
  30393. Reviewed by Eric Seidel.
  30394. https://bugs.webkit.org/show_bug.cgi?id=23630
  30395. Add complex font rendering using Skia instead of Windows ScriptTextOut.
  30396. This adds support for enhanced webkit styles when drawing complex
  30397. glyphs.
  30398. * platform/graphics/chromium/FontChromiumWin.cpp:
  30399. (WebCore::Font::drawGlyphs):
  30400. (WebCore::Font::drawComplexText):
  30401. * platform/graphics/chromium/UniscribeHelper.cpp:
  30402. (WebCore::containsMissingGlyphs):
  30403. (WebCore::UniscribeHelper::draw):
  30404. (WebCore::UniscribeHelper::shape):
  30405. * platform/graphics/chromium/UniscribeHelper.h:
  30406. * platform/graphics/skia/SkiaFontWin.cpp:
  30407. (WebCore::windowsCanHandleTextDrawing):
  30408. (WebCore::skiaDrawText):
  30409. (WebCore::paintSkiaText):
  30410. * platform/graphics/skia/SkiaFontWin.h:
  30411. 2009-02-10 Darin Fisher <darin@chromium.org>
  30412. Revert r40797 as requested by Sam Weinig.
  30413. https://bugs.webkit.org/show_bug.cgi?id=23809
  30414. * bindings/scripts/CodeGeneratorJS.pm:
  30415. * dom/Document.idl:
  30416. * html/HTMLCanvasElement.idl:
  30417. 2009-02-09 Darin Fisher <darin@chromium.org>
  30418. Reviewed by Eric Seidel.
  30419. https://bugs.webkit.org/show_bug.cgi?id=23855
  30420. Fix TransformationMatrixSkia.cpp and GraphicsContextSkia.cpp bustage
  30421. * platform/graphics/skia/GraphicsContextSkia.cpp:
  30422. (WebCore::GraphicsContext::getCTM):
  30423. * platform/graphics/skia/TransformationMatrixSkia.cpp:
  30424. (WebCore::TransformationMatrix::operator SkMatrix):
  30425. 2009-02-09 Dan Bernstein <mitz@apple.com>
  30426. Reviewed by Dave Hyatt.
  30427. - fix <rdar://problem/6568942> REGRESSION: Font rendering in Wikipedia input field is incorrect (default GDI text mode)
  30428. * platform/graphics/win/SimpleFontDataWin.cpp:
  30429. (WebCore::SimpleFontData::widthForGDIGlyph): Make sure that the DC is
  30430. in the advanced graphics mode before calling GetCharWidthI(), because
  30431. otherwise that function returns incorrect results for the default UI
  30432. font at a certain size.
  30433. 2009-02-09 Chris Marrin <cmarrin@apple.com>
  30434. Reviewed by Simon Fraser
  30435. https://bugs.webkit.org/show_bug.cgi?id=23689
  30436. Added 3D functions to WebKitCSSMatrix. This depends on the 3D functions
  30437. added to TransformationMatrix in https://bugs.webkit.org/show_bug.cgi?id=6868
  30438. Test: transforms/3d/cssmatrix-3d-interface.xhtml
  30439. * css/WebKitCSSMatrix.cpp:
  30440. * css/WebKitCSSMatrix.h:
  30441. * css/WebKitCSSMatrix.idl:
  30442. 2009-02-09 Mark Rowe <mrowe@apple.com>
  30443. Reviewed by Darin Adler.
  30444. Fix <https://bugs.webkit.org/show_bug.cgi?id=23858>
  30445. Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
  30446. * html/HTMLSelectElement.cpp:
  30447. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't store the renderer in a local variable
  30448. as it can be invalidated by any of the calls to focus() within the function. Instead, retrieve it and
  30449. null-check it when it is needed.
  30450. 2009-02-09 David Hyatt <hyatt@apple.com>
  30451. Remove the m_height member from InlineBox. This shaves 4 bytes off of all inline boxes. Unfortunately SVG
  30452. sets heights that are independent of the renderer or of the font, and so all SVG boxes have to retain m_height
  30453. member variables.
  30454. height() on InlineBox is now a virtual function that does a dynamic computation (including shrinking boxes
  30455. with no text children). For SVG boxes there is also a non-virtual setHeight function for updating the
  30456. m_height member variable like before.
  30457. Reviewed by Darin Adler
  30458. * rendering/EllipsisBox.cpp:
  30459. (WebCore::EllipsisBox::nodeAtPoint):
  30460. * rendering/EllipsisBox.h:
  30461. (WebCore::EllipsisBox::EllipsisBox):
  30462. * rendering/InlineBox.cpp:
  30463. (WebCore::InlineBox::height):
  30464. (WebCore::InlineBox::root):
  30465. * rendering/InlineBox.h:
  30466. (WebCore::InlineBox::InlineBox):
  30467. (WebCore::InlineBox::isInlineFlowBox):
  30468. (WebCore::InlineBox::isRootInlineBox):
  30469. (WebCore::InlineBox::topOverflow):
  30470. (WebCore::InlineBox::bottomOverflow):
  30471. (WebCore::InlineBox::leftOverflow):
  30472. (WebCore::InlineBox::rightOverflow):
  30473. * rendering/InlineFlowBox.cpp:
  30474. (WebCore::InlineFlowBox::height):
  30475. (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
  30476. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  30477. (WebCore::InlineFlowBox::placeBoxesVertically):
  30478. (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  30479. (WebCore::InlineFlowBox::nodeAtPoint):
  30480. * rendering/InlineFlowBox.h:
  30481. (WebCore::InlineFlowBox::isInlineFlowBox):
  30482. * rendering/InlineTextBox.cpp:
  30483. (WebCore::InlineTextBox::height):
  30484. (WebCore::InlineTextBox::nodeAtPoint):
  30485. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  30486. (WebCore::InlineTextBox::paintCompositionUnderline):
  30487. * rendering/InlineTextBox.h:
  30488. * rendering/RootInlineBox.cpp:
  30489. (WebCore::RootInlineBox::height):
  30490. (WebCore::RootInlineBox::placeEllipsis):
  30491. (WebCore::RootInlineBox::setVerticalOverflowPositions):
  30492. * rendering/RootInlineBox.h:
  30493. (WebCore::RootInlineBox::isRootInlineBox):
  30494. (WebCore::RootInlineBox::topOverflow):
  30495. (WebCore::RootInlineBox::bottomOverflow):
  30496. (WebCore::RootInlineBox::leftOverflow):
  30497. (WebCore::RootInlineBox::rightOverflow):
  30498. (WebCore::RootInlineBox::selectionBottom):
  30499. (WebCore::RootInlineBox::Overflow::Overflow):
  30500. (WebCore::RootInlineBox::setVerticalSelectionPositions):
  30501. * rendering/SVGInlineFlowBox.h:
  30502. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  30503. (WebCore::SVGInlineFlowBox::height):
  30504. (WebCore::SVGInlineFlowBox::setHeight):
  30505. * rendering/SVGInlineTextBox.cpp:
  30506. (WebCore::SVGInlineTextBox::SVGInlineTextBox):
  30507. * rendering/SVGInlineTextBox.h:
  30508. (WebCore::SVGInlineTextBox::height):
  30509. (WebCore::SVGInlineTextBox::setHeight):
  30510. * rendering/SVGRootInlineBox.cpp:
  30511. (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  30512. * rendering/SVGRootInlineBox.h:
  30513. (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  30514. (WebCore::SVGRootInlineBox::height):
  30515. (WebCore::SVGRootInlineBox::setHeight):
  30516. 2009-02-09 Eric Seidel <eric@webkit.org>
  30517. Reviewed by Sam Weinig.
  30518. Document our Selection DOM extensions
  30519. (in preparation for re-writing Selection to work with ranges)
  30520. * page/DOMSelection.cpp:
  30521. (WebCore::DOMSelection::type):
  30522. * page/DOMSelection.h:
  30523. * page/DOMSelection.idl:
  30524. 2009-02-09 Eric Seidel <eric@webkit.org>
  30525. Attempt to fix wx build
  30526. * WebCoreSources.bkl: change Selection to VisibleSelection
  30527. 2009-02-06 Darin Fisher <darin@chromium.org>
  30528. Reviewed by Eric Seidel.
  30529. https://bugs.webkit.org/show_bug.cgi?id=23809
  30530. Return CanvasRenderingContext2D instead of DOMObject in IDL to avoid V8 #ifdefs
  30531. * bindings/scripts/CodeGeneratorJS.pm:
  30532. * dom/Document.idl:
  30533. * html/HTMLCanvasElement.idl:
  30534. 2009-02-09 Dirk Schulze <krit@webkit.org>
  30535. Reviewed by Eric Seidel.
  30536. Transform the gradient instead of the context for most platforms and
  30537. transform the context after CGContextReplacePathWithStrokedPath for CG.
  30538. REGRESSION: SVG gradient transformation/BoundingBox can cause ugly stroke thickness
  30539. https://bugs.webkit.org/show_bug.cgi?id=23547
  30540. * platform/graphics/Gradient.h:
  30541. (WebCore::Gradient::setGradientSpaceTransform):
  30542. (WebCore::Gradient::gradientSpaceTransform):
  30543. * platform/graphics/cairo/GradientCairo.cpp:
  30544. (WebCore::Gradient::platformGradient):
  30545. * platform/graphics/cg/GraphicsContextCG.cpp:
  30546. (WebCore::GraphicsContext::fillPath):
  30547. (WebCore::GraphicsContext::strokePath):
  30548. (WebCore::GraphicsContext::fillRect):
  30549. * platform/graphics/qt/GraphicsContextQt.cpp:
  30550. (WebCore::GraphicsContext::fillPath):
  30551. (WebCore::GraphicsContext::strokePath):
  30552. (WebCore::GraphicsContext::fillRect):
  30553. * platform/graphics/skia/GradientSkia.cpp:
  30554. (WebCore::Gradient::platformGradient):
  30555. * svg/graphics/SVGPaintServerGradient.cpp:
  30556. (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
  30557. (WebCore::clipToTextMask):
  30558. (WebCore::SVGPaintServerGradient::setup):
  30559. (WebCore::SVGPaintServerGradient::teardown):
  30560. 2009-02-09 Sam Weinig <sam@webkit.org>
  30561. Reviewed by David Hyatt.
  30562. Fix the highlight when inspecting inline elements.
  30563. * inspector/InspectorController.cpp:
  30564. (WebCore::drawHighlightForBox):
  30565. (WebCore::drawHighlightForLineBoxes):
  30566. (WebCore::InspectorController::drawNodeHighlight):
  30567. 2009-02-09 Eric Seidel <eric@webkit.org>
  30568. Fix the gtk build by adding VisibleSelection and removing Selection.
  30569. * GNUmakefile.am:
  30570. 2009-02-09 Eric Seidel <eric@webkit.org>
  30571. Reviewed by Dave Hyatt.
  30572. Rename Selection to VisibleSelection to allow us to separate
  30573. the selections the user works with from the ones used by
  30574. the JS editing APIs.
  30575. https://bugs.webkit.org/show_bug.cgi?id=23852
  30576. No functional changes, thus no tests.
  30577. * WebCore.base.exp:
  30578. * WebCore.pro:
  30579. * WebCore.scons:
  30580. * WebCore.vcproj/WebCore.vcproj:
  30581. * WebCore.xcodeproj/project.pbxproj:
  30582. * dom/Element.cpp:
  30583. (WebCore::Element::updateFocusAppearance):
  30584. * editing/ApplyStyleCommand.cpp:
  30585. (WebCore::ApplyStyleCommand::updateStartEnd):
  30586. (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
  30587. * editing/BreakBlockquoteCommand.cpp:
  30588. (WebCore::BreakBlockquoteCommand::doApply):
  30589. * editing/CompositeEditCommand.cpp:
  30590. (WebCore::CompositeEditCommand::inputText):
  30591. (WebCore::CompositeEditCommand::deleteSelection):
  30592. (WebCore::CompositeEditCommand::rebalanceWhitespace):
  30593. (WebCore::CompositeEditCommand::pushAnchorElementDown):
  30594. (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
  30595. (WebCore::CompositeEditCommand::moveParagraphs):
  30596. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
  30597. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  30598. * editing/CompositeEditCommand.h:
  30599. * editing/CreateLinkCommand.cpp:
  30600. (WebCore::CreateLinkCommand::doApply):
  30601. * editing/DeleteButtonController.cpp:
  30602. (WebCore::enclosingDeletableElement):
  30603. (WebCore::DeleteButtonController::respondToChangedSelection):
  30604. * editing/DeleteButtonController.h:
  30605. * editing/DeleteSelectionCommand.cpp:
  30606. (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
  30607. (WebCore::DeleteSelectionCommand::clearTransientState):
  30608. (WebCore::DeleteSelectionCommand::doApply):
  30609. * editing/DeleteSelectionCommand.h:
  30610. (WebCore::DeleteSelectionCommand::create):
  30611. * editing/EditCommand.cpp:
  30612. (WebCore::EditCommand::setStartingSelection):
  30613. (WebCore::EditCommand::setEndingSelection):
  30614. * editing/EditCommand.h:
  30615. (WebCore::EditCommand::startingSelection):
  30616. (WebCore::EditCommand::endingSelection):
  30617. * editing/Editor.cpp:
  30618. (WebCore::Editor::selectionForCommand):
  30619. (WebCore::Editor::respondToChangedSelection):
  30620. (WebCore::Editor::respondToChangedContents):
  30621. (WebCore::Editor::applyStyle):
  30622. (WebCore::Editor::applyParagraphStyle):
  30623. (WebCore::Editor::appliedEditing):
  30624. (WebCore::Editor::unappliedEditing):
  30625. (WebCore::Editor::reappliedEditing):
  30626. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  30627. (WebCore::Editor::selectComposition):
  30628. (WebCore::Editor::confirmComposition):
  30629. (WebCore::Editor::advanceToNextMisspelling):
  30630. (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  30631. (WebCore::markMisspellingsOrBadGrammar):
  30632. (WebCore::Editor::markMisspellings):
  30633. (WebCore::Editor::markBadGrammar):
  30634. (WebCore::Editor::rangeForPoint):
  30635. (WebCore::Editor::transpose):
  30636. * editing/Editor.h:
  30637. * editing/EditorCommand.cpp:
  30638. (WebCore::expandSelectionToGranularity):
  30639. (WebCore::executeSwapWithMark):
  30640. (WebCore::enabledVisibleSelection):
  30641. (WebCore::enabledVisibleSelectionAndMark):
  30642. (WebCore::enableCaretInEditableText):
  30643. * editing/FormatBlockCommand.cpp:
  30644. (WebCore::FormatBlockCommand::modifyRange):
  30645. (WebCore::FormatBlockCommand::doApply):
  30646. * editing/IndentOutdentCommand.cpp:
  30647. (WebCore::IndentOutdentCommand::indentRegion):
  30648. (WebCore::IndentOutdentCommand::outdentRegion):
  30649. (WebCore::IndentOutdentCommand::doApply):
  30650. * editing/InsertLineBreakCommand.cpp:
  30651. (WebCore::InsertLineBreakCommand::doApply):
  30652. * editing/InsertListCommand.cpp:
  30653. (WebCore::InsertListCommand::modifyRange):
  30654. (WebCore::InsertListCommand::doApply):
  30655. * editing/InsertParagraphSeparatorCommand.cpp:
  30656. (WebCore::InsertParagraphSeparatorCommand::doApply):
  30657. * editing/InsertTextCommand.cpp:
  30658. (WebCore::InsertTextCommand::performTrivialReplace):
  30659. (WebCore::InsertTextCommand::input):
  30660. * editing/ModifySelectionListLevel.cpp:
  30661. (WebCore::getStartEndListChildren):
  30662. (WebCore::canIncreaseListLevel):
  30663. (WebCore::canDecreaseListLevel):
  30664. * editing/MoveSelectionCommand.cpp:
  30665. (WebCore::MoveSelectionCommand::doApply):
  30666. * editing/RemoveFormatCommand.cpp:
  30667. * editing/ReplaceSelectionCommand.cpp:
  30668. (WebCore::ReplacementFragment::ReplacementFragment):
  30669. (WebCore::ReplaceSelectionCommand::doApply):
  30670. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
  30671. * editing/Selection.cpp: Removed.
  30672. * editing/Selection.h: Removed.
  30673. * editing/SelectionController.cpp:
  30674. (WebCore::SelectionController::moveTo):
  30675. (WebCore::SelectionController::setSelection):
  30676. (WebCore::SelectionController::nodeWillBeRemoved):
  30677. (WebCore::SelectionController::clear):
  30678. (WebCore::SelectionController::setBase):
  30679. (WebCore::SelectionController::setExtent):
  30680. (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
  30681. (WebCore::SelectionController::selectAll):
  30682. (WebCore::SelectionController::setSelectedRange):
  30683. * editing/SelectionController.h:
  30684. (WebCore::SelectionController::selection):
  30685. (WebCore::SelectionController::selectionType):
  30686. * editing/TypingCommand.cpp:
  30687. (WebCore::TypingCommand::insertText):
  30688. (WebCore::TypingCommand::deleteKeyPressed):
  30689. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  30690. * editing/TypingCommand.h:
  30691. * editing/VisiblePosition.cpp:
  30692. (WebCore::VisiblePosition::honorEditableBoundaryAtOrBefore):
  30693. (WebCore::VisiblePosition::honorEditableBoundaryAtOrAfter):
  30694. * editing/VisibleSelection.cpp: Added.
  30695. (WebCore::VisibleSelection::VisibleSelection):
  30696. (WebCore::VisibleSelection::selectionFromContentsOfNode):
  30697. (WebCore::VisibleSelection::setBase):
  30698. (WebCore::VisibleSelection::setExtent):
  30699. (WebCore::VisibleSelection::firstRange):
  30700. (WebCore::VisibleSelection::toNormalizedRange):
  30701. (WebCore::VisibleSelection::expandUsingGranularity):
  30702. (WebCore::makeSearchRange):
  30703. (WebCore::VisibleSelection::appendTrailingWhitespace):
  30704. (WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):
  30705. (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
  30706. (WebCore::VisibleSelection::updateSelectionType):
  30707. (WebCore::VisibleSelection::validate):
  30708. (WebCore::VisibleSelection::setWithoutValidation):
  30709. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  30710. (WebCore::VisibleSelection::isContentEditable):
  30711. (WebCore::VisibleSelection::isContentRichlyEditable):
  30712. (WebCore::VisibleSelection::rootEditableElement):
  30713. (WebCore::VisibleSelection::shadowTreeRootNode):
  30714. (WebCore::VisibleSelection::debugPosition):
  30715. (WebCore::VisibleSelection::formatForDebugger):
  30716. (WebCore::VisibleSelection::showTreeForThis):
  30717. (showTree):
  30718. * editing/VisibleSelection.h: Added.
  30719. (WebCore::VisibleSelection::):
  30720. (WebCore::VisibleSelection::selectionType):
  30721. (WebCore::VisibleSelection::setAffinity):
  30722. (WebCore::VisibleSelection::affinity):
  30723. (WebCore::VisibleSelection::base):
  30724. (WebCore::VisibleSelection::extent):
  30725. (WebCore::VisibleSelection::start):
  30726. (WebCore::VisibleSelection::end):
  30727. (WebCore::VisibleSelection::visibleStart):
  30728. (WebCore::VisibleSelection::visibleEnd):
  30729. (WebCore::VisibleSelection::isNone):
  30730. (WebCore::VisibleSelection::isCaret):
  30731. (WebCore::VisibleSelection::isRange):
  30732. (WebCore::VisibleSelection::isCaretOrRange):
  30733. (WebCore::VisibleSelection::isBaseFirst):
  30734. (WebCore::VisibleSelection::granularity):
  30735. (WebCore::operator==):
  30736. (WebCore::operator!=):
  30737. * editing/htmlediting.cpp:
  30738. (WebCore::selectionForParagraphIteration):
  30739. (WebCore::avoidIntersectionWithNode):
  30740. * editing/htmlediting.h:
  30741. * editing/markup.cpp:
  30742. (WebCore::createMarkup):
  30743. * html/HTMLInputElement.cpp:
  30744. (WebCore::HTMLInputElement::selection):
  30745. * html/HTMLInputElement.h:
  30746. * html/HTMLTextAreaElement.cpp:
  30747. (WebCore::HTMLTextAreaElement::selection):
  30748. * html/HTMLTextAreaElement.h:
  30749. * page/AccessibilityObject.cpp:
  30750. (WebCore::AccessibilityObject::selection):
  30751. (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):
  30752. * page/AccessibilityObject.h:
  30753. * page/AccessibilityRenderObject.cpp:
  30754. (WebCore::AccessibilityRenderObject::selection):
  30755. (WebCore::AccessibilityRenderObject::setSelectedTextRange):
  30756. (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  30757. (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
  30758. (WebCore::AccessibilityRenderObject::doAXRangeForLine):
  30759. * page/AccessibilityRenderObject.h:
  30760. * page/DOMSelection.cpp:
  30761. (WebCore::DOMSelection::anchorNode):
  30762. (WebCore::DOMSelection::anchorOffset):
  30763. (WebCore::DOMSelection::focusNode):
  30764. (WebCore::DOMSelection::focusOffset):
  30765. (WebCore::DOMSelection::collapseToEnd):
  30766. (WebCore::DOMSelection::collapseToStart):
  30767. (WebCore::DOMSelection::getRangeAt):
  30768. (WebCore::DOMSelection::addRange):
  30769. * page/DOMSelection.h:
  30770. * page/DragController.cpp:
  30771. (WebCore::DragController::tryDocumentDrag):
  30772. (WebCore::setSelectionToDragCaret):
  30773. (WebCore::DragController::concludeEditDrag):
  30774. (WebCore::prepareClipboardForImageDrag):
  30775. (WebCore::DragController::startDrag):
  30776. (WebCore::DragController::placeDragCaret):
  30777. * page/EditorClient.h:
  30778. * page/EventHandler.cpp:
  30779. (WebCore::EventHandler::selectClosestWordFromMouseEvent):
  30780. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
  30781. (WebCore::EventHandler::handleMousePressEventTripleClick):
  30782. (WebCore::EventHandler::handleMousePressEventSingleClick):
  30783. (WebCore::EventHandler::updateSelectionForMouseDrag):
  30784. (WebCore::EventHandler::handleMouseReleaseEvent):
  30785. * page/Frame.cpp:
  30786. (WebCore::Frame::mark):
  30787. (WebCore::Frame::setMark):
  30788. (WebCore::Frame::selectionLayoutChanged):
  30789. (WebCore::Frame::shouldChangeSelection):
  30790. (WebCore::Frame::shouldDeleteSelection):
  30791. (WebCore::Frame::revealSelection):
  30792. (WebCore::Frame::setSelectionFromNone):
  30793. (WebCore::Frame::findString):
  30794. (WebCore::Frame::respondToChangedSelection):
  30795. * page/Frame.h:
  30796. * page/Page.cpp:
  30797. (WebCore::Page::selection):
  30798. * page/Page.h:
  30799. * page/mac/AccessibilityObjectWrapper.mm:
  30800. (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
  30801. * rendering/RenderBlock.cpp:
  30802. (WebCore::RenderBlock::fillInlineSelectionGaps):
  30803. * rendering/RenderTextControl.cpp:
  30804. (WebCore::RenderTextControl::setSelectionRange):
  30805. (WebCore::RenderTextControl::selection):
  30806. * rendering/RenderTextControl.h:
  30807. * rendering/RenderTreeAsText.cpp:
  30808. (WebCore::writeSelection):
  30809. * rendering/RootInlineBox.cpp:
  30810. (WebCore::RootInlineBox::fillLineSelectionGap):
  30811. * svg/SVGTextContentElement.cpp:
  30812. (WebCore::SVGTextContentElement::selectSubString):
  30813. 2009-02-09 Dimitri Glazkov <dglazkov@chromium.org>
  30814. Reviewed by Dave Hyatt.
  30815. https://bugs.webkit.org/show_bug.cgi?id=23806
  30816. Fix a regression crash where an empty src value and a "text/html" type
  30817. on an EMBED element did not finish ResourceRequest initialization due to
  30818. an early return.
  30819. Test: fast/loader/empty-embed-src-attribute.html
  30820. * loader/FrameLoader.cpp:
  30821. (WebCore::FrameLoader::addExtraFieldsToRequest):
  30822. 2009-02-09 Rob Buis <rwlbuis@gmail.com>
  30823. Reviewed by Eric Seidel.
  30824. https://bugs.webkit.org/show_bug.cgi?id=23816
  30825. Clean up RenderSVGRoot.cpp
  30826. Clean up RenderSVGRoot.cpp.
  30827. * rendering/RenderSVGRoot.cpp:
  30828. (WebCore::RenderSVGRoot::paint):
  30829. (WebCore::RenderSVGRoot::calcViewport):
  30830. 2009-02-09 Eric Carlson <eric.carlson@apple.com>
  30831. Reviewed by Antti Koivisto
  30832. https://bugs.webkit.org/show_bug.cgi?id=23737
  30833. Make it possible to control media element playback without knowing so many
  30834. internal implementation details.
  30835. * html/HTMLMediaElement.cpp:
  30836. (WebCore::HTMLMediaElement::togglePlayState): New, toggle between playing and paused state.
  30837. (WebCore::HTMLMediaElement::beginScrubbing): New, pause as necessary for scrubbing mode.
  30838. (WebCore::HTMLMediaElement::endScrubbing): New, resume playback if paused for scrubbing mode.
  30839. * html/HTMLMediaElement.h:
  30840. (WebCore::HTMLMediaElement::hasVideo): New, added so clients don't need to access MediaPlayer directly.
  30841. * html/HTMLVideoElement.h:
  30842. (WebCore::HTMLVideoElement::hasVideo): New.
  30843. * rendering/MediaControlElements.cpp:
  30844. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Use new media element
  30845. togglePlayState method.
  30846. (WebCore::MediaControlTimelineElement::defaultEventHandler): Tell media element when scrubbing
  30847. begins and ends so it can deal with pausing logic. Don't call setCurrentTime unless the time
  30848. will change.
  30849. * rendering/RenderMedia.cpp:
  30850. (WebCore::RenderMedia::updateControls): Ask media element if it is able to play instead of including
  30851. internal logic here.
  30852. (WebCore::RenderMedia::updateControlVisibility): Ditto.
  30853. 2009-02-09 Eric Carlson <eric.carlson@apple.com>
  30854. Reviewed by Antti Koivisto
  30855. Change RenderPart and RenderPartObject constructors to take a Node*
  30856. instead of a HTMLFrameOwnerElement* since that is all then need.
  30857. * rendering/RenderPart.cpp:
  30858. (WebCore::RenderPart::RenderPart): take Node* instead of HTMLFrameOwnerElement*
  30859. * rendering/RenderPart.h:
  30860. * rendering/RenderPartObject.cpp:
  30861. (WebCore::RenderPartObject::RenderPartObject): take Node* instead of HTMLFrameOwnerElement*
  30862. * rendering/RenderPartObject.h:
  30863. 2009-02-09 Dan Bernstein <mitz@apple.com>
  30864. - fix -Wmissing-prototypes builds
  30865. * editing/ReplaceSelectionCommand.cpp:
  30866. (WebCore::isHeaderElement): Marked this function static.
  30867. (WebCore::haveSameTagName): Ditto.
  30868. * editing/markup.cpp:
  30869. (WebCore::isSpecialAncestorBlock): Ditto.
  30870. * platform/graphics/transforms/TransformationMatrix.cpp:
  30871. (WebCore::makeMapBetweenRects): Removed unused function.
  30872. * platform/graphics/transforms/TransformationMatrix.h: Removed unused
  30873. declaration of private member makeMapBetweenRects().
  30874. 2009-02-09 Adam Treat <adam.treat@torchmobile.com>
  30875. Reviewed by Sam Weinig.
  30876. https://bugs.webkit.org/show_bug.cgi?id=23850
  30877. Code cleanup of HTMLParser class which was using a mix of m_* and bare
  30878. class member variable names which helps to obfuscate the code. Also
  30879. changed a few of the static helper functions to take a const pointer type
  30880. as they should not be modifying the node.
  30881. * html/HTMLParser.cpp:
  30882. (WebCore::HTMLParser::HTMLParser):
  30883. (WebCore::HTMLParser::~HTMLParser):
  30884. (WebCore::HTMLParser::reset):
  30885. (WebCore::HTMLParser::setCurrent):
  30886. (WebCore::HTMLParser::parseToken):
  30887. (WebCore::HTMLParser::parseDoctypeToken):
  30888. (WebCore::isTableSection):
  30889. (WebCore::isTablePart):
  30890. (WebCore::isTableRelated):
  30891. (WebCore::HTMLParser::insertNode):
  30892. (WebCore::HTMLParser::handleError):
  30893. (WebCore::HTMLParser::textCreateErrorCheck):
  30894. (WebCore::HTMLParser::commentCreateErrorCheck):
  30895. (WebCore::HTMLParser::headCreateErrorCheck):
  30896. (WebCore::HTMLParser::bodyCreateErrorCheck):
  30897. (WebCore::HTMLParser::framesetCreateErrorCheck):
  30898. (WebCore::HTMLParser::formCreateErrorCheck):
  30899. (WebCore::HTMLParser::isindexCreateErrorCheck):
  30900. (WebCore::HTMLParser::noscriptCreateErrorCheck):
  30901. (WebCore::HTMLParser::pCloserStrictCreateErrorCheck):
  30902. (WebCore::HTMLParser::mapCreateErrorCheck):
  30903. (WebCore::HTMLParser::getNode):
  30904. (WebCore::HTMLParser::allowNestedRedundantTag):
  30905. (WebCore::HTMLParser::processCloseTag):
  30906. (WebCore::HTMLParser::isInline):
  30907. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  30908. (WebCore::HTMLParser::reopenResidualStyleTags):
  30909. (WebCore::HTMLParser::pushBlock):
  30910. (WebCore::HTMLParser::popBlock):
  30911. (WebCore::HTMLParser::popOneBlockCommon):
  30912. (WebCore::HTMLParser::popOneBlock):
  30913. (WebCore::HTMLParser::moveOneBlockToStack):
  30914. (WebCore::HTMLParser::checkIfHasPElementInScope):
  30915. (WebCore::HTMLParser::popInlineBlocks):
  30916. (WebCore::HTMLParser::freeBlock):
  30917. (WebCore::HTMLParser::createHead):
  30918. (WebCore::HTMLParser::handleIsindex):
  30919. (WebCore::HTMLParser::startBody):
  30920. (WebCore::HTMLParser::finished):
  30921. (WebCore::HTMLParser::reportErrorToConsole):
  30922. * html/HTMLParser.h:
  30923. 2009-02-09 Alexey Proskuryakov <ap@webkit.org>
  30924. Applying review comment on a second location.
  30925. * rendering/RenderText.cpp: (WebCore::RenderText::nextOffset):
  30926. Use "ifdef BUILDING_ON_TIGER".
  30927. 2009-02-09 Alexey Proskuryakov <ap@webkit.org>
  30928. Reviewed by Darin Adler.
  30929. https://bugs.webkit.org/show_bug.cgi?id=23845
  30930. editing/deleting/backward-deletion.html fails on Tiger
  30931. * rendering/RenderText.cpp:
  30932. (WebCore::RenderText::previousOffset):
  30933. (WebCore::RenderText::nextOffset):
  30934. Work around a bug in older ICU versions by hardcoding narrow voiced marks.
  30935. 2009-02-09 Adam Roben <aroben@apple.com>
  30936. Windows build fix
  30937. * WebCore.vcproj/WebCore.vcproj: Fix the XML syntax.
  30938. 2009-02-09 Jian Li <jianli@chromium.org>
  30939. Reviewed by Alexey Proskuryakov.
  30940. Make WorkerMessagingProxy derive from two base proxy classes.
  30941. https://bugs.webkit.org/show_bug.cgi?id=23777
  30942. * bindings/js/WorkerScriptController.cpp:
  30943. (WebCore::WorkerScriptController::evaluate):
  30944. * dom/Worker.cpp:
  30945. (WebCore::Worker::terminate):
  30946. (WebCore::Worker::hasPendingActivity):
  30947. * dom/WorkerContext.cpp:
  30948. (WebCore::WorkerContext::reportException):
  30949. * dom/WorkerMessagingProxy.cpp:
  30950. (WebCore::WorkerThreadActivityReportTask::performTask):
  30951. (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
  30952. (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
  30953. (WebCore::WorkerMessagingProxy::terminateWorkerContext):
  30954. (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
  30955. (WebCore::WorkerMessagingProxy::reportPendingActivity):
  30956. (WebCore::WorkerMessagingProxy::reportPendingActivityInternal):
  30957. (WebCore::WorkerMessagingProxy::hasPendingActivity):
  30958. * dom/WorkerMessagingProxy.h:
  30959. 2009-02-09 Jian Li <jianli@chromium.org>
  30960. Reviewed by Alexey Proskuryakov.
  30961. Introduce 2 base classes to split WorkerMessagingProxy.
  30962. https://bugs.webkit.org/show_bug.cgi?id=23776
  30963. * GNUmakefile.am:
  30964. * WebCore.vcproj/WebCore.vcproj:
  30965. * WebCore.xcodeproj/project.pbxproj:
  30966. * dom/WorkerContextProxy.h: Added.
  30967. (WebCore::WorkerContextProxy::~WorkerContextProxy):
  30968. * dom/WorkerObjectProxy.h: Added.
  30969. (WebCore::WorkerObjectProxy::~WorkerObjectProxy):
  30970. 2009-02-08 David Hyatt <hyatt@apple.com>
  30971. Fix for https://bugs.webkit.org/show_bug.cgi?id=23839
  30972. Make sure that generated content is properly handled when content is moved from a block run-in
  30973. to an inline run-in.
  30974. Reviewed by Sam Weinig
  30975. Added fast/runin/002.html
  30976. * rendering/RenderBlock.cpp:
  30977. (WebCore::RenderBlock::handleRunInChild):
  30978. 2009-02-08 David Hyatt <hyatt@apple.com>
  30979. Fix for https://bugs.webkit.org/show_bug.cgi?id=23832, crash when inspecting an image using the
  30980. Web inspector.
  30981. Reviewed by Mark Rowe
  30982. * rendering/RenderObject.cpp:
  30983. (WebCore::RenderObject::absoluteRectsForRange):
  30984. (WebCore::RenderObject::absoluteQuadsForRange):
  30985. 2009-02-08 Dirk Schulze <krit@webkit.org>
  30986. Unreviewed Qt build fix.
  30987. TransformationMatrix changes in r40761 broke QT build.
  30988. * platform/graphics/qt/GraphicsContextQt.cpp:
  30989. (WebCore::GraphicsContext::getCTM):
  30990. (WebCore::GraphicsContext::scale):
  30991. 2009-02-08 Dirk Schulze <krit@webkit.org>
  30992. Reviewed by Holger Freyther.
  30993. This is a follow up of the last commit. It cleans up TransformationMatrix.h
  30994. and convert to a series of #elif.
  30995. * platform/graphics/transforms/TransformationMatrix.h:
  30996. 2009-02-08 Gustavo Noronha Silva <gns@gnome.org>
  30997. Reviewed by Simon Fraser.
  30998. [CAIRO] build broken by TransformationMatrix rework
  30999. https://bugs.webkit.org/show_bug.cgi?id=23831
  31000. Fixed cairo build after the TransformationMatrix rework done in
  31001. revision 40761.
  31002. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  31003. (WebCore::GraphicsContext::getCTM):
  31004. (WebCore::GraphicsContext::concatCTM):
  31005. * platform/graphics/cairo/TransformationMatrixCairo.cpp:
  31006. (WebCore::TransformationMatrix::operator cairo_matrix_t):
  31007. * platform/graphics/transforms/TransformationMatrix.h:
  31008. 2009-02-07 David Hyatt <hyatt@apple.com>
  31009. Shrink the size of all InlineTextBoxes and all InlineBoxes (for images and replaced elements) by four bytes.
  31010. Change the overflow variable on InlineFlowBoxes into a short and move the bits for InlineFlowBoxes out of the
  31011. base InlineBox class. Since the number of bits in the base class was 35, shoving the 3 bits for InlineFlowBoxes
  31012. back down into that class (into the 16 bits exposed by making the overflow variable into a short), all text
  31013. boxes and image boxes shrink by 4 bytes.
  31014. Reviewed by Anders
  31015. * rendering/InlineBox.h:
  31016. (WebCore::InlineBox::InlineBox):
  31017. * rendering/InlineFlowBox.cpp:
  31018. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  31019. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  31020. (WebCore::InlineFlowBox::placeBoxesVertically):
  31021. * rendering/InlineFlowBox.h:
  31022. (WebCore::InlineFlowBox::InlineFlowBox):
  31023. (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
  31024. (WebCore::InlineFlowBox::hasTextChildren):
  31025. 2009-02-07 Dean Jackson <dino@apple.com>
  31026. Attempted build fix for Qt. Not reviewed.
  31027. TransformationMatrix changes in r40761 broke non-Apple builds.
  31028. * platform/graphics/qt/TransformationMatrixQt.cpp:
  31029. (WebCore::TransformationMatrix::operator QMatrix):
  31030. * platform/graphics/transforms/TransformationMatrix.h:
  31031. 2009-02-07 David Hyatt <hyatt@apple.com>
  31032. This patch changes the base class of RenderInline from RenderBox to RenderBoxModelObject. This shift
  31033. in base class knocks 32 bytes off the size of every RenderInline. All of the necessary functions
  31034. for both RenderInline and RenderBox have either been pulled up into RenderBoxModelObject for sharing
  31035. or split into two functions (one in each derived class).
  31036. Reviewed by Anders and Antti
  31037. * dom/Element.cpp:
  31038. (WebCore::Element::offsetLeft):
  31039. (WebCore::Element::offsetTop):
  31040. (WebCore::Element::offsetWidth):
  31041. (WebCore::Element::offsetHeight):
  31042. (WebCore::Element::offsetParent):
  31043. (WebCore::Element::clientWidth):
  31044. (WebCore::Element::clientHeight):
  31045. (WebCore::Element::scrollWidth):
  31046. (WebCore::Element::scrollHeight):
  31047. * dom/Node.cpp:
  31048. (WebCore::Node::renderBox):
  31049. (WebCore::Node::renderBoxModelObject):
  31050. * dom/Node.h:
  31051. * html/HTMLAnchorElement.cpp:
  31052. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  31053. * rendering/InlineBox.h:
  31054. (WebCore::InlineBox::boxModelObject):
  31055. * rendering/InlineFlowBox.cpp:
  31056. (WebCore::InlineFlowBox::marginLeft):
  31057. (WebCore::InlineFlowBox::marginRight):
  31058. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  31059. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  31060. (WebCore::InlineFlowBox::placeBoxesVertically):
  31061. (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  31062. * rendering/InlineFlowBox.h:
  31063. (WebCore::InlineFlowBox::borderLeft):
  31064. (WebCore::InlineFlowBox::borderRight):
  31065. (WebCore::InlineFlowBox::paddingLeft):
  31066. (WebCore::InlineFlowBox::paddingRight):
  31067. * rendering/RenderBlock.cpp:
  31068. (WebCore::getBorderPaddingMargin):
  31069. (WebCore::RenderBlock::calcInlinePrefWidths):
  31070. * rendering/RenderBox.cpp:
  31071. (WebCore::RenderBox::imageChanged):
  31072. (WebCore::RenderBox::calcReplacedWidthUsing):
  31073. (WebCore::RenderBox::calcReplacedHeightUsing):
  31074. (WebCore::RenderBox::containingBlockWidthForPositioned):
  31075. (WebCore::RenderBox::containingBlockHeightForPositioned):
  31076. (WebCore::RenderBox::calcAbsoluteHorizontal):
  31077. (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  31078. (WebCore::RenderBox::calcAbsoluteVertical):
  31079. (WebCore::RenderBox::calcAbsoluteVerticalValues):
  31080. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  31081. (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  31082. (WebCore::RenderBox::positionForCoordinates):
  31083. * rendering/RenderBox.h:
  31084. (WebCore::RenderBox::borderBoundingBox):
  31085. (WebCore::RenderBox::offsetHeight):
  31086. (WebCore::RenderBox::marginTop):
  31087. (WebCore::RenderBox::marginBottom):
  31088. (WebCore::RenderBox::marginLeft):
  31089. (WebCore::RenderBox::marginRight):
  31090. * rendering/RenderBoxModelObject.cpp:
  31091. (WebCore::RenderBoxModelObject::offsetLeft):
  31092. (WebCore::RenderBoxModelObject::offsetTop):
  31093. (WebCore::RenderBoxModelObject::paddingTop):
  31094. (WebCore::RenderBoxModelObject::paddingBottom):
  31095. (WebCore::RenderBoxModelObject::paddingLeft):
  31096. (WebCore::RenderBoxModelObject::paddingRight):
  31097. (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  31098. (WebCore::RenderBoxModelObject::calculateBackgroundSize):
  31099. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  31100. * rendering/RenderBoxModelObject.h:
  31101. (WebCore::RenderBoxModelObject::borderTop):
  31102. (WebCore::RenderBoxModelObject::borderBottom):
  31103. (WebCore::RenderBoxModelObject::borderLeft):
  31104. (WebCore::RenderBoxModelObject::borderRight):
  31105. (WebCore::RenderBoxModelObject::hasHorizontalBordersPaddingOrMargin):
  31106. (WebCore::RenderBoxModelObject::hasHorizontalBordersOrPadding):
  31107. (WebCore::RenderBoxModelObject::childBecameNonInline):
  31108. (WebCore::RenderBoxModelObject::isBoxModelObject):
  31109. * rendering/RenderInline.cpp:
  31110. (WebCore::RenderInline::RenderInline):
  31111. (WebCore::RenderInline::destroy):
  31112. (WebCore::RenderInline::styleDidChange):
  31113. (WebCore::nextContinuation):
  31114. (WebCore::RenderInline::continuationBefore):
  31115. (WebCore::RenderInline::addChildIgnoringContinuation):
  31116. (WebCore::RenderInline::splitInlines):
  31117. (WebCore::RenderInline::splitFlow):
  31118. (WebCore::RenderInline::addChildToContinuation):
  31119. (WebCore::RenderInline::absoluteRects):
  31120. (WebCore::RenderInline::offsetLeft):
  31121. (WebCore::RenderInline::offsetTop):
  31122. (WebCore::RenderInline::marginLeft):
  31123. (WebCore::RenderInline::marginRight):
  31124. (WebCore::RenderInline::positionForCoordinates):
  31125. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  31126. (WebCore::RenderInline::rectWithOutlineForRepaint):
  31127. (WebCore::RenderInline::computeRectForRepaint):
  31128. (WebCore::RenderInline::updateDragState):
  31129. (WebCore::RenderInline::childBecameNonInline):
  31130. (WebCore::RenderInline::updateHitTestResult):
  31131. (WebCore::RenderInline::imageChanged):
  31132. (WebCore::RenderInline::addFocusRingRects):
  31133. * rendering/RenderInline.h:
  31134. (WebCore::RenderInline::marginTop):
  31135. (WebCore::RenderInline::marginBottom):
  31136. (WebCore::RenderInline::continuation):
  31137. (WebCore::RenderInline::setContinuation):
  31138. * rendering/RenderLineBoxList.cpp:
  31139. (WebCore::RenderLineBoxList::paint):
  31140. (WebCore::RenderLineBoxList::hitTest):
  31141. * rendering/RenderLineBoxList.h:
  31142. * rendering/RenderObject.cpp:
  31143. (WebCore::addLayers):
  31144. (WebCore::RenderObject::removeLayers):
  31145. (WebCore::RenderObject::moveLayers):
  31146. (WebCore::RenderObject::findNextLayer):
  31147. (WebCore::RenderObject::enclosingLayer):
  31148. (WebCore::RenderObject::enclosingCompositingLayer):
  31149. (WebCore::RenderObject::setLayerNeedsFullRepaint):
  31150. (WebCore::RenderObject::handleDynamicFloatPositionChange):
  31151. (WebCore::RenderObject::destroy):
  31152. (WebCore::RenderObject::offsetParent):
  31153. * rendering/RenderObject.h:
  31154. (WebCore::RenderObject::isInlineContinuation):
  31155. * rendering/RenderSVGTSpan.cpp:
  31156. (WebCore::RenderSVGTSpan::absoluteRects):
  31157. (WebCore::RenderSVGTSpan::absoluteQuads):
  31158. * rendering/RenderSVGTextPath.cpp:
  31159. (WebCore::RenderSVGTextPath::absoluteRects):
  31160. (WebCore::RenderSVGTextPath::absoluteQuads):
  31161. * rendering/RenderTreeAsText.cpp:
  31162. (WebCore::operator<<):
  31163. * rendering/RenderView.cpp:
  31164. (WebCore::RenderView::setBestTruncatedAt):
  31165. * rendering/RenderView.h:
  31166. * rendering/bidi.cpp:
  31167. (WebCore::getBorderPaddingMargin):
  31168. (WebCore::inlineWidth):
  31169. (WebCore::RenderBlock::layoutInlineChildren):
  31170. (WebCore::inlineFlowRequiresLineBox):
  31171. (WebCore::requiresLineBox):
  31172. (WebCore::RenderBlock::findNextLineBreak):
  31173. * wml/WMLAElement.cpp:
  31174. (WebCore::WMLAElement::isKeyboardFocusable):
  31175. 2009-02-07 Yael Aharon <yael.aharon@nokia.com>
  31176. Reviewed by Timothy Hatcher <timothy@hatcher.name>
  31177. Partial fix for <https://bugs.webkit.org/show_bug.cgi?id=21051>
  31178. Include localStorage and sessionStorage in DatabasesPanel.
  31179. * WebCore.vcproj/WebCore.vcproj:
  31180. * inspector/InspectorController.cpp:
  31181. (WebCore::InspectorDOMStorageResource::create):
  31182. (WebCore::InspectorDOMStorageResource::setScriptObject):
  31183. (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
  31184. (WebCore::InspectorController::populateScriptObjects):
  31185. (WebCore::InspectorController::addDOMStorageScriptResource):
  31186. (WebCore::InspectorController::removeDOMStorageScriptResource):
  31187. (WebCore::InspectorController::resetScriptObjects):
  31188. (WebCore::InspectorController::didCommitLoad):
  31189. (WebCore::InspectorController::didUseDOMStorage):
  31190. * inspector/InspectorController.h:
  31191. * inspector/front-end/DOMStorage.js: Added.
  31192. (WebInspector.DOMStorage):
  31193. (WebInspector.DOMStorage.prototype.get domStorage):
  31194. (WebInspector.DOMStorage.prototype.set domStorage):
  31195. (WebInspector.DOMStorage.prototype.get domain):
  31196. (WebInspector.DOMStorage.prototype.set domain):
  31197. (WebInspector.DOMStorage.prototype.get isLocalStorage):
  31198. (WebInspector.DOMStorage.prototype.set isLocalStorage):
  31199. * inspector/front-end/DOMStorageItemsView.js: Added.
  31200. (WebInspector.DOMStorageItemsView):
  31201. (WebInspector.DOMStorageItemsView.prototype.show):
  31202. (WebInspector.DOMStorageItemsView.prototype.update):
  31203. * inspector/front-end/DatabaseQueryView.js:
  31204. (WebInspector.DatabaseQueryView):
  31205. * inspector/front-end/DatabaseTableView.js:
  31206. (WebInspector.DatabaseTableView):
  31207. (WebInspector.DatabaseTableView.prototype._queryFinished):
  31208. (WebInspector.DatabaseTableView.prototype._queryError):
  31209. * inspector/front-end/DatabasesPanel.js:
  31210. (WebInspector.DatabasesPanel):
  31211. (WebInspector.DatabasesPanel.prototype.reset):
  31212. (WebInspector.DatabasesPanel.prototype.addDatabase):
  31213. (WebInspector.DatabasesPanel.prototype.addDOMStorage):
  31214. (WebInspector.DatabasesPanel.prototype.showDatabase):
  31215. (WebInspector.DatabasesPanel.prototype.showDOMStorage):
  31216. (WebInspector.DatabasesPanel.prototype.closeVisibleView):
  31217. (WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
  31218. (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
  31219. (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  31220. (WebInspector.DOMStorageSidebarTreeElement):
  31221. (WebInspector.DOMStorageSidebarTreeElement.prototype.onselect):
  31222. (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
  31223. (WebInspector.DOMStorageSidebarTreeElement.prototype.set mainTitle):
  31224. (WebInspector.DOMStorageSidebarTreeElement.prototype.get subtitle):
  31225. (WebInspector.DOMStorageSidebarTreeElement.prototype.set subtitle):
  31226. * inspector/front-end/Images/domStorage.png: Added.
  31227. * inspector/front-end/WebKit.qrc:
  31228. * inspector/front-end/inspector.css:
  31229. * inspector/front-end/inspector.html:
  31230. * inspector/front-end/inspector.js:
  31231. (WebInspector.addDOMStorage):
  31232. * page/DOMWindow.cpp:
  31233. (WebCore::DOMWindow::sessionStorage):
  31234. (WebCore::DOMWindow::localStorage):
  31235. 2009-02-07 Feng Qian <feng@chromium.org>
  31236. Reviewed by Eric Seidel <eric@webkit.org>
  31237. Put #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor.
  31238. https://bugs.webkit.org/show_bug.cgi?id=23574
  31239. * page/EventHandler.cpp:
  31240. * page/EventHandler.h:
  31241. 2009-02-07 Zalan Bujtas <zbujtas@gmail.com>
  31242. Reviewed by Rob Buis <rwlbuis@gmail.com>
  31243. https://bugs.webkit.org/show_bug.cgi?id=23788
  31244. call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject.
  31245. * rendering/bidi.cpp:
  31246. (WebCore::RenderBlock::skipLeadingWhitespace):
  31247. 2009-02-07 Rob Buis <rwlbuis@gmail.com>
  31248. Reviewed by Darin.
  31249. https://bugs.webkit.org/show_bug.cgi?id=3248
  31250. Bug 3248: Mouse events on OPTION element seem to be ignored
  31251. Support mouse events on options in a select when it forms a list box.
  31252. Test: fast/forms/option-mouseevents.html
  31253. * html/HTMLSelectElement.cpp: Convert to coords relative to the list box.
  31254. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  31255. * rendering/RenderListBox.cpp: Handle hit testing for option elements.
  31256. (WebCore::RenderListBox::nodeAtPoint):
  31257. * rendering/RenderListBox.h:
  31258. 2009-02-07 Adam Treat <adam.treat@torchmobile.com>
  31259. Prospective build fix for all non-Apple platforms.
  31260. * platform/graphics/transforms/TransformationMatrix.h:
  31261. 2009-02-06 Chris Marrin <cmarrin@apple.com>
  31262. Reviewed by Simon Fraser.
  31263. https://bugs.webkit.org/show_bug.cgi?id=6868
  31264. I have not only made TransformationMatrix platform independent
  31265. but I've also added 3D methods, which will be used when I update
  31266. WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
  31267. I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
  31268. the math as doubles rather than floats. This makes a TransformationMatrix
  31269. go from 24 bytes to 128 bytes, but I don't think this class is used enough to
  31270. make this overhead will be significant.
  31271. The change from floats to doubles has caused some differences in rounding and
  31272. display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
  31273. so I've had to change some LayoutTest results in the SVG tests.
  31274. * platform/graphics/FloatPoint.cpp:
  31275. (WebCore::FloatPoint::matrixTransform):
  31276. * platform/graphics/cg/GraphicsContextCG.cpp:
  31277. (WebCore::GraphicsContext::getCTM):
  31278. * platform/graphics/cg/TransformationMatrixCG.cpp:
  31279. (WebCore::TransformationMatrix::operator CGAffineTransform):
  31280. * platform/graphics/transforms/TransformationMatrix.cpp:
  31281. (WebCore::determinant2x2):
  31282. (WebCore::determinant3x3):
  31283. (WebCore::determinant4x4):
  31284. (WebCore::adjoint):
  31285. (WebCore::inverse):
  31286. (WebCore::transposeMatrix4):
  31287. (WebCore::v4MulPointByMatrix):
  31288. (WebCore::v3Length):
  31289. (WebCore::v3Scale):
  31290. (WebCore::v3Dot):
  31291. (WebCore::v3Combine):
  31292. (WebCore::v3Cross):
  31293. (WebCore::decompose):
  31294. (WebCore::slerp):
  31295. (WebCore::TransformationMatrix::scale):
  31296. (WebCore::TransformationMatrix::rotateFromVector):
  31297. (WebCore::TransformationMatrix::flipX):
  31298. (WebCore::TransformationMatrix::flipY):
  31299. (WebCore::makeMapBetweenRects):
  31300. (WebCore::TransformationMatrix::projectPoint):
  31301. (WebCore::TransformationMatrix::mapPoint):
  31302. (WebCore::TransformationMatrix::mapRect):
  31303. (WebCore::TransformationMatrix::mapQuad):
  31304. (WebCore::TransformationMatrix::scale3d):
  31305. (WebCore::TransformationMatrix::rotate3d):
  31306. (WebCore::TransformationMatrix::translate):
  31307. (WebCore::TransformationMatrix::translate3d):
  31308. (WebCore::TransformationMatrix::skew):
  31309. (WebCore::TransformationMatrix::applyPerspective):
  31310. (WebCore::TransformationMatrix::multLeft):
  31311. (WebCore::TransformationMatrix::multVecMatrix):
  31312. (WebCore::TransformationMatrix::isInvertible):
  31313. (WebCore::TransformationMatrix::inverse):
  31314. (WebCore::blendFloat):
  31315. (WebCore::TransformationMatrix::blend):
  31316. (WebCore::TransformationMatrix::decompose):
  31317. (WebCore::TransformationMatrix::recompose):
  31318. * platform/graphics/transforms/TransformationMatrix.h:
  31319. (WebCore::TransformationMatrix::TransformationMatrix):
  31320. (WebCore::TransformationMatrix::setMatrix):
  31321. (WebCore::TransformationMatrix::operator =):
  31322. (WebCore::TransformationMatrix::makeIdentity):
  31323. (WebCore::TransformationMatrix::isIdentity):
  31324. (WebCore::TransformationMatrix::map):
  31325. (WebCore::TransformationMatrix::m11):
  31326. (WebCore::TransformationMatrix::setM11):
  31327. (WebCore::TransformationMatrix::m12):
  31328. (WebCore::TransformationMatrix::setM12):
  31329. (WebCore::TransformationMatrix::m13):
  31330. (WebCore::TransformationMatrix::setM13):
  31331. (WebCore::TransformationMatrix::m14):
  31332. (WebCore::TransformationMatrix::setM14):
  31333. (WebCore::TransformationMatrix::m21):
  31334. (WebCore::TransformationMatrix::setM21):
  31335. (WebCore::TransformationMatrix::m22):
  31336. (WebCore::TransformationMatrix::setM22):
  31337. (WebCore::TransformationMatrix::m23):
  31338. (WebCore::TransformationMatrix::setM23):
  31339. (WebCore::TransformationMatrix::m24):
  31340. (WebCore::TransformationMatrix::setM24):
  31341. (WebCore::TransformationMatrix::m31):
  31342. (WebCore::TransformationMatrix::setM31):
  31343. (WebCore::TransformationMatrix::m32):
  31344. (WebCore::TransformationMatrix::setM32):
  31345. (WebCore::TransformationMatrix::m33):
  31346. (WebCore::TransformationMatrix::setM33):
  31347. (WebCore::TransformationMatrix::m34):
  31348. (WebCore::TransformationMatrix::setM34):
  31349. (WebCore::TransformationMatrix::m41):
  31350. (WebCore::TransformationMatrix::setM41):
  31351. (WebCore::TransformationMatrix::m42):
  31352. (WebCore::TransformationMatrix::setM42):
  31353. (WebCore::TransformationMatrix::m43):
  31354. (WebCore::TransformationMatrix::setM43):
  31355. (WebCore::TransformationMatrix::m44):
  31356. (WebCore::TransformationMatrix::setM44):
  31357. (WebCore::TransformationMatrix::a):
  31358. (WebCore::TransformationMatrix::setA):
  31359. (WebCore::TransformationMatrix::b):
  31360. (WebCore::TransformationMatrix::setB):
  31361. (WebCore::TransformationMatrix::c):
  31362. (WebCore::TransformationMatrix::setC):
  31363. (WebCore::TransformationMatrix::d):
  31364. (WebCore::TransformationMatrix::setD):
  31365. (WebCore::TransformationMatrix::e):
  31366. (WebCore::TransformationMatrix::setE):
  31367. (WebCore::TransformationMatrix::f):
  31368. (WebCore::TransformationMatrix::setF):
  31369. (WebCore::TransformationMatrix::multiply):
  31370. (WebCore::TransformationMatrix::rotate):
  31371. (WebCore::TransformationMatrix::skewX):
  31372. (WebCore::TransformationMatrix::skewY):
  31373. (WebCore::TransformationMatrix::hasPerspective):
  31374. (WebCore::TransformationMatrix::):
  31375. (WebCore::TransformationMatrix::isAffine):
  31376. (WebCore::TransformationMatrix::operator==):
  31377. (WebCore::TransformationMatrix::operator*=):
  31378. (WebCore::TransformationMatrix::operator*):
  31379. * rendering/RenderForeignObject.cpp:
  31380. (WebCore::RenderForeignObject::nodeAtPoint):
  31381. * rendering/RenderLayer.cpp:
  31382. (WebCore::RenderLayer::updateTransform):
  31383. * rendering/RenderPath.cpp:
  31384. (WebCore::RenderPath::mapAbsolutePointToLocal):
  31385. * rendering/RenderSVGImage.cpp:
  31386. (WebCore::RenderSVGImage::nodeAtPoint):
  31387. * rendering/RenderSVGRoot.cpp:
  31388. (WebCore::RenderSVGRoot::nodeAtPoint):
  31389. * rendering/RenderSVGText.cpp:
  31390. (WebCore::RenderSVGText::nodeAtPoint):
  31391. * rendering/RenderSVGViewportContainer.cpp:
  31392. (WebCore::RenderSVGViewportContainer::nodeAtPoint):
  31393. * svg/SVGAnimateMotionElement.cpp:
  31394. (WebCore::SVGAnimateMotionElement::resetToBaseValue):
  31395. (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
  31396. * svg/SVGSVGElement.cpp:
  31397. (WebCore::SVGSVGElement::viewport):
  31398. * svg/SVGTransform.cpp:
  31399. (SVGTransform::setTranslate):
  31400. (SVGTransform::setScale):
  31401. (SVGTransform::setRotate):
  31402. (SVGTransform::setSkewX):
  31403. (SVGTransform::setSkewY):
  31404. * svg/graphics/SVGResourceMarker.cpp:
  31405. (WebCore::SVGResourceMarker::draw):
  31406. 2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>
  31407. Reviewed by Tor Arne Vestbø.
  31408. For the Qt port implement Image::drawPattern via
  31409. BitmapImage::drawPatterns' implementation and implement
  31410. Gradient::fill.
  31411. This partially fixes rendering of generated gradient content.
  31412. * platform/graphics/BitmapImage.h: Remove the drawPattern
  31413. implementation for the Qt port in BitmapImage, it's been moved to
  31414. Image::drawPattern.
  31415. * platform/graphics/qt/GradientQt.cpp:
  31416. (WebCore::Gradient::fill): Implement using a simple fillRect.
  31417. * platform/graphics/qt/ImageQt.cpp:
  31418. (WebCore::Image::drawPattern): Moved implementation from
  31419. BitmapImage::drawPattern.
  31420. 2009-02-06 Eric Seidel <eric@webkit.org>
  31421. Reviewed by Justin Garcia.
  31422. DOMSelection.getRangeAt() returns a different range than the selection
  31423. https://bugs.webkit.org/show_bug.cgi?id=23601
  31424. Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range
  31425. Test: fast/dom/Selection/getRangeAt.html
  31426. * WebCore.base.exp:
  31427. * dom/InputElement.cpp:
  31428. (WebCore::InputElement::handleBeforeTextInsertedEvent):
  31429. * editing/DeleteButtonController.cpp:
  31430. (WebCore::enclosingDeletableElement):
  31431. * editing/Editor.cpp:
  31432. (WebCore::Editor::selectedRange):
  31433. (WebCore::Editor::fontForSelection):
  31434. (WebCore::Editor::applyStyleToSelection):
  31435. (WebCore::Editor::applyParagraphStyleToSelection):
  31436. (WebCore::Editor::insertTextWithoutSendingTextEvent):
  31437. (WebCore::Editor::insertLineBreak):
  31438. (WebCore::Editor::insertParagraphSeparator):
  31439. (WebCore::Editor::ignoreSpelling):
  31440. (WebCore::Editor::isSelectionUngrammatical):
  31441. (WebCore::Editor::guessesForUngrammaticalSelection):
  31442. (WebCore::markMisspellingsOrBadGrammar):
  31443. (WebCore::Editor::rangeForPoint):
  31444. * editing/EditorCommand.cpp:
  31445. (WebCore::expandSelectionToGranularity):
  31446. (WebCore::executeDeleteToMark):
  31447. (WebCore::executeSelectToMark):
  31448. * editing/RemoveFormatCommand.cpp:
  31449. (WebCore::RemoveFormatCommand::doApply):
  31450. * editing/ReplaceSelectionCommand.cpp:
  31451. (WebCore::ReplacementFragment::ReplacementFragment):
  31452. * editing/Selection.cpp:
  31453. (WebCore::Selection::firstRange):
  31454. (WebCore::Selection::toNormalizedRange):
  31455. * editing/Selection.h:
  31456. * editing/SelectionController.h:
  31457. (WebCore::SelectionController::toNormalizedRange):
  31458. * editing/TypingCommand.cpp:
  31459. (WebCore::TypingCommand::deleteKeyPressed):
  31460. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  31461. * editing/markup.cpp:
  31462. (WebCore::createMarkup):
  31463. * loader/archive/cf/LegacyWebArchive.cpp:
  31464. (WebCore::LegacyWebArchive::createFromSelection):
  31465. * page/AccessibilityRenderObject.cpp:
  31466. (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
  31467. * page/ContextMenuController.cpp:
  31468. (WebCore::ContextMenuController::contextMenuItemSelected):
  31469. * page/DOMSelection.cpp:
  31470. (WebCore::DOMSelection::getRangeAt):
  31471. (WebCore::DOMSelection::addRange):
  31472. (WebCore::DOMSelection::deleteFromDocument):
  31473. (WebCore::DOMSelection::containsNode):
  31474. (WebCore::DOMSelection::toString):
  31475. * page/DragController.cpp:
  31476. (WebCore::setSelectionToDragCaret):
  31477. (WebCore::DragController::concludeEditDrag):
  31478. (WebCore::DragController::startDrag):
  31479. * page/EventHandler.cpp:
  31480. (WebCore::EventHandler::dispatchMouseEvent):
  31481. * page/Frame.cpp:
  31482. (WebCore::Frame::selectedText):
  31483. (WebCore::Frame::shouldChangeSelection):
  31484. (WebCore::Frame::shouldDeleteSelection):
  31485. (WebCore::Frame::selectionComputedStyle):
  31486. (WebCore::Frame::selectionTextRects):
  31487. (WebCore::Frame::findString):
  31488. (WebCore::Frame::respondToChangedSelection):
  31489. * platform/ContextMenu.cpp:
  31490. (WebCore::selectionContainsPossibleWord):
  31491. 2009-02-06 Brady Eidson <beidson@apple.com>
  31492. Reviewed by Dan Bernstein
  31493. <rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
  31494. before ::didReceiveResponse().
  31495. No layout test, as we don't have a concrete way to reproduce these conditions. To that effect, I've added an ASSERT
  31496. to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
  31497. this case and can come up with something more reproducible.
  31498. * loader/MainResourceLoader.cpp:
  31499. (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response. This is much
  31500. like the FrameLoader::init() response that is used for initial document creation.
  31501. 2009-02-06 Geoffrey Garen <ggaren@apple.com>
  31502. Build fix.
  31503. * WebCore.base.exp:
  31504. 2009-02-06 Xan Lopez <xan@gnome.org>
  31505. Reviewed by Holger Freyther.
  31506. https://bugs.webkit.org/show_bug.cgi?id=23621
  31507. Do not use m_scrollOffset to check if we are setting the same
  31508. value than we already have.
  31509. m_scrollOffset starts at 0 for ScrollView, so when opening a new
  31510. page and scrolling to 0 (the usual case) the check will fail and
  31511. we won't update the adjustment value, resulting in a possibly
  31512. mispositioned scrollbar. Use the adjustment value directly
  31513. instead, which is what we are updating anyway.
  31514. * platform/gtk/ScrollViewGtk.cpp:
  31515. (WebCore::ScrollView::platformHandleHorizontalAdjustment):
  31516. (WebCore::ScrollView::platformHandleVerticalAdjustment):
  31517. 2009-02-06 Justin Garcia <justin.garcia@apple.com>
  31518. Reviewed by Oliver Hunt.
  31519. https://bugs.webkit.org/show_bug.cgi?id=23800
  31520. Header elements are not always preserved during paste
  31521. At paste time, don't merge out of header elements. At copy time, be sure to include
  31522. headers in the list of special common ancestor blocks, so that copying a paragraph or less
  31523. of content inside a header will include the header element in the copied markup.
  31524. * editing/ReplaceSelectionCommand.cpp:
  31525. (WebCore::areSameHeaderElements):
  31526. (WebCore::ReplaceSelectionCommand::shouldMerge):
  31527. * editing/markup.cpp:
  31528. (WebCore::isSpecialAncestorBlock):
  31529. (WebCore::createMarkup):
  31530. 2009-02-06 Geoffrey Garen <ggaren@apple.com>
  31531. Reviewed by Sam Weinig.
  31532. Part III of <rdar://problem/6552272>.
  31533. Make redirect data available to WebKit. (I tried having WebKit track this
  31534. data for itself, but that went wrong -- it's just too hard to figure
  31535. out the weird corners of the WebCore loader from within another framework.)
  31536. * loader/DocumentLoader.cpp:
  31537. (WebCore::DocumentLoader::DocumentLoader):
  31538. * loader/DocumentLoader.h: Store a flag indicating whether we created
  31539. a global history entry. If we didn't, then we know that the next redirect
  31540. should not link to us, since we're not in history.
  31541. (WebCore::DocumentLoader::clientRedirectSourceForHistory):
  31542. (WebCore::DocumentLoader::clientRedirectDestinationForHistory):
  31543. (WebCore::DocumentLoader::setClientRedirectSourceForHistory):
  31544. (WebCore::DocumentLoader::serverRedirectSourceForHistory):
  31545. (WebCore::DocumentLoader::serverRedirectDestinationForHistory):
  31546. (WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
  31547. (WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
  31548. to help WebKit wade through the muck of WebCore history.
  31549. * loader/EmptyClients.h:
  31550. (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed
  31551. this client function to say what it does, instead of when it's called.
  31552. * loader/FrameLoader.cpp:
  31553. (WebCore::FrameLoader::load):
  31554. (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect,
  31555. store a link to the previous history URL in the new DocumentLoader, so
  31556. it can update WebKit with that link when the load commits.
  31557. (WebCore::FrameLoader::updateHistory*): Use our new flags and names,
  31558. described above.
  31559. * loader/FrameLoader.h:
  31560. (WebCore::FrameLoader::documentLoader):
  31561. (WebCore::FrameLoader::policyDocumentLoader):
  31562. (WebCore::FrameLoader::provisionalDocumentLoader):
  31563. (WebCore::FrameLoader::state): Inlined a few trivial functions because
  31564. performance mistakes give me the itches.
  31565. * loader/FrameLoaderClient.h: Renamed this client function to say what
  31566. it does, instead of when it's called.
  31567. 2009-02-06 Eric Seidel <eric@webkit.org>
  31568. Reviewed by Justin Garcia.
  31569. Minor refactoring and cleanup to Selection code
  31570. https://bugs.webkit.org/show_bug.cgi?id=23774
  31571. No functional changes, thus no tests.
  31572. * editing/Editor.cpp:
  31573. (WebCore::Editor::applyStyle):
  31574. (WebCore::Editor::applyParagraphStyle):
  31575. * editing/Selection.cpp:
  31576. (WebCore::Selection::Selection):
  31577. (WebCore::Selection::setBaseAndExtentToDeepEquivalents):
  31578. (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity):
  31579. (WebCore::Selection::updateSelectionType):
  31580. (WebCore::Selection::validate):
  31581. (WebCore::Selection::setWithoutValidation):
  31582. (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
  31583. * editing/Selection.h:
  31584. (WebCore::Selection::):
  31585. (WebCore::Selection::selectionType):
  31586. (WebCore::Selection::extent):
  31587. (WebCore::Selection::isNone):
  31588. (WebCore::Selection::isCaret):
  31589. (WebCore::Selection::isRange):
  31590. (WebCore::Selection::isCaretOrRange):
  31591. * editing/SelectionController.h:
  31592. (WebCore::SelectionController::selectionType):
  31593. * editing/TypingCommand.cpp:
  31594. (WebCore::TypingCommand::deleteKeyPressed):
  31595. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  31596. * page/Frame.cpp:
  31597. (WebCore::Frame::revealSelection):
  31598. 2009-02-06 Dimitri Glazkov <dglazkov@chromium.org>
  31599. Reviewed by Eric Seidel.
  31600. https://bugs.webkit.org/show_bug.cgi?id=23801
  31601. Add custom V8 bindings for SVG.
  31602. * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added.
  31603. (WebCore::CALLBACK_FUNC_DECL):
  31604. * bindings/v8/custom/V8SVGLengthCustom.cpp: Added.
  31605. (WebCore::ACCESSOR_GETTER):
  31606. (WebCore::CALLBACK_FUNC_DECL):
  31607. * bindings/v8/custom/V8SVGMatrixCustom.cpp: Added.
  31608. (WebCore::CALLBACK_FUNC_DECL):
  31609. 2009-02-06 David Levin <levin@chromium.org>
  31610. Reviewed by Eric Seidel.
  31611. Bug 23792: unused param is used in RenderLayer.cpp but not #include'd
  31612. <https://bugs.webkit.org/show_bug.cgi?id=23792>
  31613. Add include file for UnusedParam which is used in this file.
  31614. * rendering/RenderLayer.cpp:
  31615. 2009-02-06 David Levin <levin@chromium.org>
  31616. Reviewed by Eric Seidel.
  31617. <https://bugs.webkit.org/show_bug.cgi?id=23741>
  31618. Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
  31619. <https://bugs.webkit.org/show_bug.cgi?id=23798>
  31620. Add protocolInHTTPFamily() to the KURLGoogle implementation.
  31621. This is another chromium build fix to mirror r40553.
  31622. While in this file, I did some style fixes and consistency fixes:
  31623. + fixed many_occurences_of_underscoring_naming
  31624. + usages of NULL
  31625. + comparisons to 0
  31626. + changed the copyright remove an extraneous , and capitalize the (C)
  31627. which was suggested for other files that I've submitted.
  31628. No observable change in behavior, so no test.
  31629. * platform/KURL.h:
  31630. (WebCore::KURL::protocolInHTTPFamily):
  31631. * platform/KURLGoogle.cpp:
  31632. (WebCore::KURLCharsetConverter::ConvertFromUTF16):
  31633. (WebCore::lowerCaseEqualsASCII):
  31634. (WebCore::KURLGooglePrivate::KURLGooglePrivate):
  31635. (WebCore::KURLGooglePrivate::setUtf8):
  31636. (WebCore::KURLGooglePrivate::setAscii):
  31637. (WebCore::KURLGooglePrivate::init):
  31638. (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily):
  31639. (WebCore::KURLGooglePrivate::copyTo):
  31640. (WebCore::KURLGooglePrivate::replaceComponents):
  31641. (WebCore::KURL::KURL):
  31642. (WebCore::KURL::createCFURL):
  31643. (WebCore::KURL::isEmpty):
  31644. (WebCore::KURL::protocolInHTTPFamily):
  31645. (WebCore::KURL::query):
  31646. (WebCore::decodeURLEscapeSequences):
  31647. (WebCore::KURL::protocolIs):
  31648. (WebCore::encodeWithURLEscapeSequences):
  31649. (WebCore::KURL::invalidate):
  31650. (WebCore::equalIgnoringRef):
  31651. * platform/KURLGooglePrivate.h:
  31652. 2009-02-06 David Kilzer <ddkilzer@apple.com>
  31653. Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer
  31654. Reviewed by Darin Adler.
  31655. * rendering/style/RenderStyle.cpp:
  31656. (WebCore::RenderStyle::contentDataEquivalent): Moved method to
  31657. WebCore::StyleRareNonInheritedData class.
  31658. * rendering/style/RenderStyle.h:
  31659. (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration
  31660. with inline method that calls contentDataEquivalent() on
  31661. WebCore::StyleRareNonInheritedData instead.
  31662. * rendering/style/StyleRareNonInheritedData.cpp:
  31663. (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix!
  31664. Replaced pointer comparison of ContentData objects with call to
  31665. StyleRareNonInheritedData::contentDataEquivalent().
  31666. (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
  31667. * rendering/style/StyleRareNonInheritedData.h:
  31668. (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added
  31669. declaration.
  31670. 2009-02-06 Simon Fraser <simon.fraser@apple.com>
  31671. Reviewed by Eric Seidel
  31672. Factor code that checks whether the object is rooted in
  31673. repaint() and repaintRectangle() into a common isRooted()
  31674. method.
  31675. * rendering/RenderObject.cpp:
  31676. (WebCore::RenderObject::repaint):
  31677. (WebCore::RenderObject::repaintRectangle):
  31678. (WebCore::RenderObject::isRooted):
  31679. * rendering/RenderObject.h:
  31680. 2009-02-06 Simon Fraser <simon.fraser@apple.com>
  31681. Reviewed by Eric Seidel
  31682. Expose an isRootLayer() method on RenderLayer that works whether the
  31683. layer is rooted or not, and use that in a few places in the
  31684. accelerated compositing code.
  31685. * rendering/RenderLayer.h:
  31686. (WebCore::RenderLayer::isRootLayer):
  31687. * rendering/RenderLayerBacking.cpp:
  31688. (WebCore::RenderLayerBacking::paintingGoesToWindow):
  31689. * rendering/RenderLayerCompositor.cpp:
  31690. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  31691. (WebCore::RenderLayerCompositor::requiresCompositingLayer):
  31692. 2009-02-06 Dan Bernstein <mitz@apple.com>
  31693. Reviewed by Darin Adler.
  31694. - fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache
  31695. Most platforms do not retrieve the small caps font from the FontCache,
  31696. but cross-platform code in ~SimpleFontData() assumes the the small caps
  31697. font data did come from the cache and therefore calls releaseFontData()
  31698. on it.
  31699. * platform/graphics/SimpleFontData.cpp:
  31700. (WebCore::SimpleFontData::~SimpleFontData): Reordered to call
  31701. platformDestroy() before releasing the small caps font and pruning the
  31702. glyph page tree. This allows platformDestroy() to reset
  31703. m_smallCapsFontData to 0 if it was not obtained from the cache.
  31704. * platform/graphics/chromium/SimpleFontDataLinux.cpp:
  31705. (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to
  31706. 0 after deleting it.
  31707. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  31708. (WebCore::SimpleFontData::platformDestroy): Ditto.
  31709. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  31710. (WebCore::SimpleFontData::platformDestroy): Ditto.
  31711. * platform/graphics/win/SimpleFontDataWin.cpp:
  31712. (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
  31713. * platform/graphics/wx/SimpleFontDataWx.cpp:
  31714. (WebCore::SimpleFontData::platformDestroy): Ditto.
  31715. 2009-02-06 Simon Fraser <simon.fraser@apple.com>
  31716. Reviewed by Eric Seidel
  31717. Make RenderStyle::transitionForProperty() const.
  31718. * rendering/style/RenderStyle.cpp:
  31719. (WebCore::RenderStyle::transitionForProperty):
  31720. * rendering/style/RenderStyle.h:
  31721. 2009-02-06 Simon Fraser <simon.fraser@apple.com>
  31722. Fix build when ACCELERATED_COMPOSITING is turned on.
  31723. Remove font smoothing changes that will be committed
  31724. separately.
  31725. * platform/graphics/mac/WebLayer.mm:
  31726. (WebCore::if):
  31727. 2009-02-06 Anders Carlsson <andersca@apple.com>
  31728. Build fix.
  31729. * bridge/npapi.h:
  31730. 2009-02-06 Darin Fisher <darin@chromium.org>
  31731. Reviewed by Eric Seidel.
  31732. https://bugs.webkit.org/show_bug.cgi?id=23790
  31733. Custom -> JSCCustom in SVGPointList.idl
  31734. * svg/SVGPointList.idl:
  31735. 2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>
  31736. Reviewed by Eric Seidel.
  31737. https://bugs.webkit.org/show_bug.cgi?id=23309
  31738. Fix whitespace indent errors. The rest of the original patch has already
  31739. landed.
  31740. * platform/graphics/cairo/ImageSourceCairo.cpp:
  31741. (WebCore::ImageSource::clear):
  31742. * platform/graphics/cg/ImageSourceCG.cpp:
  31743. (WebCore::ImageSource::clear):
  31744. * platform/graphics/qt/ImageSourceQt.cpp:
  31745. (WebCore::ImageSource::clear):
  31746. * platform/graphics/wx/ImageSourceWx.cpp:
  31747. (WebCore::ImageSource::clear):
  31748. 2009-02-06 Dirk Schulze <krit@webkit.org>
  31749. Reviewed by Simon Hausmann.
  31750. Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
  31751. the context transparent.
  31752. [QT] clearRect fill's a given rect with white
  31753. https://bugs.webkit.org/show_bug.cgi?id=23728
  31754. * platform/graphics/qt/GraphicsContextQt.cpp:
  31755. (WebCore::GraphicsContext::clearRect):
  31756. 2009-02-06 Simon Fraser <simon.fraser@apple.com>
  31757. Reviewed by Dave Hyatt
  31758. https://bugs.webkit.org/show_bug.cgi?id=23781
  31759. When the document is attached and detached, and when it becomes active/inactive
  31760. (e.g. coming out or going into the page cache) we need to call
  31761. RenderView::didMoveOnscreen()/willMoveOffscreen() to hook and unhook the composited
  31762. layers.
  31763. Also, if Document::recalcStyle() does not do a layout, it needs to
  31764. update the compositing layers.
  31765. * dom/Document.cpp:
  31766. (WebCore::Document::updateRendering):
  31767. (WebCore::Document::updateLayout):
  31768. (WebCore::Document::attach):
  31769. (WebCore::Document::detach):
  31770. (WebCore::Document::documentWillBecomeInactive):
  31771. (WebCore::Document::documentDidBecomeActive):
  31772. 2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>
  31773. Reviewed by Tor Arne Vestbø.
  31774. Added support for different ownership models for wrapped QObjects in
  31775. the JavaScript environment.
  31776. * bindings/js/ScriptControllerQt.cpp:
  31777. (WebCore::ScriptController::createScriptInstanceForWidget): Specify
  31778. QtOwnership for scriptable widgets.
  31779. * bridge/npruntime_internal.h: Add "NormalState" to the list of
  31780. undef'ed macros as an included Qt header uses "NormalState" as value
  31781. in an enum.
  31782. * bridge/qt/qt_instance.cpp:
  31783. (JSC::Bindings::QtInstance::QtInstance): Save and initialize ownership
  31784. member.
  31785. (JSC::Bindings::QtInstance::~QtInstance): Respect
  31786. QScriptEngine::ValueOwnership policy with regards to wrapped m_object.
  31787. (JSC::Bindings::QtInstance::getQtInstance): Pass the ownership down to
  31788. the instance.
  31789. * bridge/qt/qt_instance.h:
  31790. (JSC::Bindings::QtInstance::create): Ditto.
  31791. * bridge/qt/qt_runtime.cpp:
  31792. (JSC::Bindings::convertQVariantToValue): Use QtOwnership for
  31793. automatically wrapped QObjects.
  31794. (JSC::Bindings::QtConnectionObject::execute): Ditto.
  31795. 2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
  31796. Reviewed by Dan Bernstein and Geoff Garen.
  31797. - WebCore code to track per-day and per-week visit counts in history
  31798. The basic idea is as follows: we track daily visits for up to 13
  31799. days, and weekly visits for up to 5 weeks past the end of the
  31800. current daily visits. As soon as the number of daily counts goes
  31801. over 13, we squish them down into weeks, and then prune the excess weeks.
  31802. * history/HistoryItem.cpp:
  31803. (WebCore::HistoryItem::HistoryItem): Remove bogus whitespace.
  31804. (WebCore::timeToDay): Helper function: convert time to days from the epoch.
  31805. (WebCore::HistoryItem::padDailyCountsForNewVisit): Insert 0 counts if
  31806. a site is visited after a span of days.
  31807. (WebCore::HistoryItem::collapseDailyVisitsToWeekly): Core day/week upgrade
  31808. algorithm as described above.
  31809. (WebCore::HistoryItem::recordVisitAtTime): Use above helpers to record all
  31810. info about a visit to this history item.
  31811. (WebCore::HistoryItem::setLastVisitedTime): Updated.
  31812. (WebCore::HistoryItem::visited): Updated.
  31813. (WebCore::HistoryItem::recordInitialVisit): New function to
  31814. handle recording data about the very first visit, replacing the
  31815. prior practice of explicitly setting visit count to 1.
  31816. (WebCore::HistoryItem::adoptVisitCounts): Take ownership of
  31817. daily and weekly visit count vectors.
  31818. (WebCore::HistoryItem::mergeAutoCompleteHints): Added a comment
  31819. noting that this function doesn't work properly now (though
  31820. this shouldn't matter much in practice.)
  31821. * history/HistoryItem.h:
  31822. (WebCore::HistoryItem::dailyVisitCounts): Accessor for daily counts.
  31823. (WebCore::HistoryItem::weeklyVisitCounts): Ditto for weekly counts.
  31824. * WebCore.base.exp: Add new symbols and sort.
  31825. 2009-02-05 Alexey Proskuryakov <ap@webkit.org>
  31826. Reviewed by Darin Adler.
  31827. <rdar://problem/6438271> Improve backspace handling of accented characters
  31828. Test: platform/mac/editing/deleting/backward-delete.html
  31829. This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
  31830. because the current behavior matches their standards (tested on Windows, assumed elsewhere).
  31831. * dom/Position.cpp:
  31832. (WebCore::Position::previous):
  31833. (WebCore::Position::next):
  31834. (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
  31835. * dom/Position.h:
  31836. Added a new option for previous(), used to move to a next position for backward deletion.
  31837. Renamed EUsingComposedCharacters to PositionMoveType.
  31838. * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
  31839. Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check
  31840. surrounding this code a little.
  31841. * editing/htmlediting.cpp:
  31842. (WebCore::nextVisuallyDistinctCandidate):
  31843. (WebCore::previousVisuallyDistinctCandidate):
  31844. Adjusted for renamed enum values.
  31845. * rendering/RenderObject.cpp:
  31846. * rendering/RenderObject.h:
  31847. * rendering/RenderText.h:
  31848. Added previousOffsetForBackwardDeletion().
  31849. * rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion):
  31850. On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
  31851. 2009-02-05 Adam Roben <aroben@apple.com>
  31852. Fix a crash in RenderWidget::destroy when navigating away from a page
  31853. with an <iframe>
  31854. This was a regression caused by r40679
  31855. Reviewed by Dave Hyatt.
  31856. Tested by many many tests.
  31857. * rendering/RenderWidget.cpp:
  31858. (WebCore::RenderWidget::destroy): Only deref the RenderWidget after we
  31859. finish accessing its members.
  31860. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31861. Reviewed by Anders Carlsson
  31862. getAnimatedStyleForRenderer() should not create a new
  31863. CompositeAnimation if the object isn't already animating, and
  31864. it should just fall back to returning renderer->style().
  31865. * page/animation/AnimationController.cpp:
  31866. (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
  31867. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31868. Fix build when ACCELERATED_COMPOSITING is turned on.
  31869. Give RenderLayerBacking some love after the great
  31870. RenderBoxModelObject split.
  31871. * rendering/RenderLayerBacking.cpp:
  31872. (WebCore::RenderLayerBacking::updateLayerTransform):
  31873. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  31874. (WebCore::RenderLayerBacking::contentsBox):
  31875. (WebCore::RenderLayerBacking::paintIntoLayer):
  31876. (WebCore::RenderLayerBacking::startAnimation):
  31877. (WebCore::RenderLayerBacking::startTransition):
  31878. * rendering/RenderLayerBacking.h:
  31879. (WebCore::RenderLayerBacking::renderer):
  31880. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31881. Fix build when ACCELERATED_COMPOSITING is turned on.
  31882. writeIndent() needs to be static to avoid warnings on some OSes,
  31883. and remove unused CAToTransform3D() method.
  31884. * platform/graphics/GraphicsLayer.cpp:
  31885. (WebCore::writeIndent):
  31886. * platform/graphics/mac/GraphicsLayerCA.mm:
  31887. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31888. Reviewed by Anders Carlsson
  31889. Add some methods to the TransformOperation classes that are required
  31890. by GraphicsLayer when ACCELERATED_COMPOSITING is turned on.
  31891. * platform/graphics/transforms/MatrixTransformOperation.h:
  31892. (WebCore::MatrixTransformOperation::create):
  31893. (WebCore::MatrixTransformOperation::MatrixTransformOperation):
  31894. * platform/graphics/transforms/ScaleTransformOperation.h:
  31895. (WebCore::ScaleTransformOperation::x):
  31896. (WebCore::ScaleTransformOperation::y):
  31897. * platform/graphics/transforms/TranslateTransformOperation.h:
  31898. (WebCore::TranslateTransformOperation::x):
  31899. (WebCore::TranslateTransformOperation::y):
  31900. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31901. Minor clenaup: fix brace style in CompositeAnimationPrivate::updateTransitions(),
  31902. and correct a usage of UNUSED_PARAM().
  31903. * page/animation/CompositeAnimation.cpp:
  31904. (WebCore::CompositeAnimationPrivate::updateTransitions):
  31905. * page/animation/ImplicitAnimation.cpp:
  31906. (WebCore::ImplicitAnimation::startAnimation):
  31907. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31908. Fix build when ACCELERATED_COMPOSITING is turned on.
  31909. animationOfPropertyIsAccelerated() needs to be public because
  31910. it is called from AnimationController.
  31911. * page/animation/AnimationBase.h:
  31912. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  31913. Reviewed by Anders Carlsson
  31914. Fix mis-typed enum value which is hidden inside #ifdefs so didn't break
  31915. the build.
  31916. * page/FrameView.cpp:
  31917. (WebCore::FrameView::updateCompositingLayers):
  31918. 2009-02-05 Sam Weinig <sam@webkit.org>
  31919. Reviewed by Geoffrey Garen.
  31920. Fix missing checked toRenderBlock casts.
  31921. * rendering/RenderBlock.cpp:
  31922. (WebCore::RenderBlock::clearFloats):
  31923. * rendering/RenderBox.cpp:
  31924. (WebCore::RenderBox::availableHeightUsing):
  31925. 2009-02-05 Sam Weinig <sam@webkit.org>
  31926. Patch from Darin Adler.
  31927. Reviewed by Sam Weinig.
  31928. Fix case where we were casting to RenderView.
  31929. No test case possible.
  31930. * editing/mac/SelectionControllerMac.mm:
  31931. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  31932. 2009-02-05 Aaron Boodman <aa@chromium.org>
  31933. Reviewed by Dave Hyatt.
  31934. https://bugs.webkit.org/show_bug.cgi?id=23708
  31935. Adds documentElementAvailable() callback to FrameLoaderClient.
  31936. * dom/XMLTokenizerLibxml2.cpp:
  31937. (WebCore::XMLTokenizer::startElementNs):
  31938. Add call to dispatchDocumentElementAvailable()
  31939. * dom/XMLTokenizerQt.cpp:
  31940. (WebCore::XMLTokenizer::parseStartElement):
  31941. Ditto.
  31942. * html/HTMLParser.cpp:
  31943. (WebCore::HTMLParser::insertNode):
  31944. Ditto.
  31945. * loader/EmptyClients.h:
  31946. (WebCore::EmptyFrameLoaderClient::documentElementAvailable):
  31947. Stub out documentElementAvailable().
  31948. * loader/FrameLoader.cpp:
  31949. documentElementAvailable() callback plumbing.
  31950. * loader/FrameLoader.h:
  31951. Ditto.
  31952. * loader/FrameLoaderClient.h:
  31953. Add new documentElementAvailable() callback.
  31954. 2009-02-05 Scott Violet <sky@google.com>
  31955. Reviewed by Eric Seidel.
  31956. https://bugs.webkit.org/show_bug.cgi?id=23766
  31957. CanvasRenderingContext2D::setShadow needs else for other platforms.
  31958. Implements the CMYK variant of CanvasRenderingContext2D::setShadow for
  31959. other platforms using the CMYK color constructor.
  31960. * html/CanvasRenderingContext2D.cpp:
  31961. (WebCore::CanvasRenderingContext2D::setShadow):
  31962. 2009-02-05 Scott Violet <sky@google.com>
  31963. Reviewed by Eric Seidel.
  31964. https://bugs.webkit.org/show_bug.cgi?id=23687
  31965. Wires up Skia'a ImageBuffer::toDataURL to support pngs.
  31966. This helps Chromium pass a couple of layout tests.
  31967. * platform/graphics/skia/ImageBufferSkia.cpp:
  31968. (WebCore::ImageBuffer::toDataURL):
  31969. * platform/image-encoders: Added.
  31970. * platform/image-encoders/skia: Added.
  31971. * platform/image-encoders/skia/PNGImageEncoder.cpp: Added.
  31972. (WebCore::):
  31973. (WebCore::PngEncoderState::EncoderWriteCallback):
  31974. (WebCore::PngEncoderState::ConvertBGRAtoRGB):
  31975. (WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer):
  31976. (WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer):
  31977. (WebCore::PNGImageEncoder::encode):
  31978. * platform/image-encoders/skia/PNGImageEncoder.h: Added.
  31979. 2009-02-05 Sam Weinig <sam@webkit.org>
  31980. Reviewed by Darin Adler.
  31981. Fix missing checked cast.
  31982. * rendering/RenderObject.cpp:
  31983. (WebCore::RenderObject::containingBlock):
  31984. 2009-02-05 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  31985. Not reviewed. Fix WML enabled builds.
  31986. FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.
  31987. * wml/WMLGoElement.cpp:
  31988. (WebCore::WMLGoElement::executeTask):
  31989. 2009-02-05 Scott Violet <sky@google.com>
  31990. Reviewed by Eric Seidel.
  31991. https://bugs.webkit.org/show_bug.cgi?id=23625
  31992. Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer
  31993. Fixes three bugs in PlatformContextSkia:
  31994. * When a new layer was started clipped to an image we used the
  31995. assignment operator to copy the SkBitmap. If the SkBitmap owns it's
  31996. pixels, this is not the right thing to do. Instead we need to create
  31997. a copy of the image.
  31998. * State holds an SkBitmap by value. State's copy constructor does a
  31999. memcpy. This is confusing and subtle, I've converted to use a member
  32000. initializer list which I think is clearer and less error prone.
  32001. * When creating a new layer there is no need to copy the clip image.
  32002. * platform/graphics/skia/PlatformContextSkia.cpp:
  32003. (PlatformContextSkia::State::State):
  32004. (PlatformContextSkia::save):
  32005. (PlatformContextSkia::beginLayerClippedToImage):
  32006. 2009-02-05 Scott Violet <sky@google.com>
  32007. Reviewed by George Staikos.
  32008. https://bugs.webkit.org/show_bug.cgi?id=23462
  32009. Changes call from setFillColor to setStrokeColor.
  32010. * html/CanvasStyle.cpp:
  32011. (WebCore::CanvasStyle::applyStrokeColor):
  32012. 2009-02-05 David Hyatt <hyatt@apple.com>
  32013. Fix crash on svg custom stop test. A virtual function didn't get patched properly.
  32014. Reviewed by Sam Weinig
  32015. * rendering/RenderObject.cpp:
  32016. (WebCore::RenderObject::clippedOverflowRectForRepaint):
  32017. * rendering/RenderSVGGradientStop.h:
  32018. (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
  32019. 2009-02-05 Simon Fraser <simon.fraser@apple.com>
  32020. Reviewed by Dave Hyatt
  32021. https://bugs.webkit.org/show_bug.cgi?id=23765
  32022. Add toRenderBoxModelObject() so that we can cast objects that
  32023. can have layers.
  32024. Fix getComputedStyle to return the current value of style
  32025. properties that are undergoing accelerated animations, by
  32026. asking the AnimationController if the property has accelerated
  32027. animations, and, if so, asking it to generate an appropriate
  32028. style.
  32029. Tightened up some type safety (CSSPropertyID), and code clarity
  32030. (replace bool with enum).
  32031. * WebCore.xcodeproj/project.pbxproj:
  32032. * css/CSSComputedStyleDeclaration.cpp:
  32033. (WebCore::hasCompositedLayer):
  32034. (WebCore::computedTransform):
  32035. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  32036. * page/animation/AnimationController.cpp:
  32037. (WebCore::AnimationControllerPrivate::isAnimatingPropertyOnRenderer):
  32038. (WebCore::AnimationController::isAnimatingPropertyOnRenderer):
  32039. (WebCore::AnimationController::supportsAcceleratedAnimationOfProperty):
  32040. * page/animation/AnimationController.h:
  32041. * page/animation/AnimationControllerPrivate.h:
  32042. * page/animation/ImplicitAnimation.cpp:
  32043. (WebCore::ImplicitAnimation::startAnimation):
  32044. (WebCore::ImplicitAnimation::endAnimation):
  32045. * page/animation/KeyframeAnimation.cpp:
  32046. (WebCore::KeyframeAnimation::startAnimation):
  32047. (WebCore::KeyframeAnimation::endAnimation):
  32048. * rendering/RenderBoxModelObject.h:
  32049. (WebCore::RenderBoxModelObject::isBoxModelObject):
  32050. (WebCore::toRenderBoxModelObject):
  32051. * rendering/RenderLayerBacking.cpp:
  32052. (WebCore::RenderLayerBacking::updateLayerTransform):
  32053. * rendering/RenderObject.h:
  32054. (WebCore::RenderObject::isBoxModelObject):
  32055. * rendering/style/RenderStyle.cpp:
  32056. (WebCore::RenderStyle::applyTransform):
  32057. * rendering/style/RenderStyle.h:
  32058. (WebCore::InheritedFlags::):
  32059. 2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
  32060. Reviewed by Eric Seidel.
  32061. https://bugs.webkit.org/show_bug.cgi?id=23767
  32062. Add custom V8 bindings for HTML5 database.
  32063. * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added.
  32064. (WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
  32065. (WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback):
  32066. (WebCore::V8CustomSQLStatementCallback::handleEvent):
  32067. * bindings/v8/custom/V8CustomSQLStatementCallback.h: Added.
  32068. (WebCore::V8CustomSQLStatementCallback::create):
  32069. * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added.
  32070. (WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
  32071. (WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback):
  32072. (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  32073. * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added.
  32074. (WebCore::V8CustomSQLStatementErrorCallback::create):
  32075. * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added.
  32076. (WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
  32077. (WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback):
  32078. (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  32079. * bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added.
  32080. (WebCore::V8CustomSQLTransactionCallback::create):
  32081. * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added.
  32082. (WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
  32083. (WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback):
  32084. (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  32085. * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added.
  32086. (WebCore::V8CustomSQLTransactionErrorCallback::create):
  32087. * bindings/v8/custom/V8CustomVoidCallback.cpp: Added.
  32088. (WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
  32089. (WebCore::V8CustomVoidCallback::~V8CustomVoidCallback):
  32090. (WebCore::V8CustomVoidCallback::handleEvent):
  32091. (WebCore::invokeCallback):
  32092. * bindings/v8/custom/V8CustomVoidCallback.h: Added.
  32093. (WebCore::V8CustomVoidCallback::create):
  32094. * bindings/v8/custom/V8DatabaseCustom.cpp: Added.
  32095. (WebCore::CALLBACK_FUNC_DECL):
  32096. * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added.
  32097. (WebCore::CALLBACK_FUNC_DECL):
  32098. * bindings/v8/custom/V8SQLTransactionCustom.cpp: Added.
  32099. (WebCore::CALLBACK_FUNC_DECL):
  32100. 2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
  32101. Reviewed by Eric Seidel.
  32102. https://bugs.webkit.org/show_bug.cgi?id=23747
  32103. Add Chromium threading-related files.
  32104. * platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.
  32105. 2009-02-05 Sam Weinig <sam@webkit.org>
  32106. Reviewed by Adam Roben.
  32107. Add toRenderButton methods for casting RenderObjects to RenderButtons. The methods will assert if the object
  32108. is not a RenderButton. Also add a toRenderButton method that takes a RenderButton but returns void and that
  32109. is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderButton.
  32110. * rendering/RenderButton.h:
  32111. (WebCore::RenderButton::isRenderButton):
  32112. (WebCore::toRenderButton):
  32113. * rendering/RenderFileUploadControl.cpp:
  32114. (WebCore::RenderFileUploadControl::paintObject):
  32115. * rendering/RenderObject.h:
  32116. (WebCore::RenderObject::isRenderButton):
  32117. 2009-02-05 David Hyatt <hyatt@apple.com>
  32118. Move the m_layer member variable of RenderBox up into RenderBoxModelObject. Refactor styleDidChange'
  32119. of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
  32120. In order to set the various RenderObject bits properly prior to the test for whether a layer is
  32121. required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
  32122. for setting all of the bits.
  32123. Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree. Move hasStaticX/Y to
  32124. RenderStyle, and just use the corresponding layer() methods for the
  32125. staticX/Y getters/setters.
  32126. Reviewed by Sam Weinig
  32127. * rendering/RenderBlock.cpp:
  32128. (WebCore::RenderBlock::layoutBlock):
  32129. (WebCore::RenderBlock::adjustPositionedBlock):
  32130. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  32131. (WebCore::RenderBlock::layoutPositionedObjects):
  32132. (WebCore::RenderBlock::paintObject):
  32133. (WebCore::RenderBlock::nodeAtPoint):
  32134. (WebCore::RenderBlock::offsetForContents):
  32135. (WebCore::RenderBlock::calcPrefWidths):
  32136. (WebCore::RenderBlock::baselinePosition):
  32137. * rendering/RenderBox.cpp:
  32138. (WebCore::RenderBox::RenderBox):
  32139. (WebCore::RenderBox::destroy):
  32140. (WebCore::RenderBox::styleWillChange):
  32141. (WebCore::RenderBox::styleDidChange):
  32142. (WebCore::RenderBox::updateBoxModelInfoFromStyle):
  32143. (WebCore::RenderBox::scrollWidth):
  32144. (WebCore::RenderBox::scrollHeight):
  32145. (WebCore::RenderBox::scrollLeft):
  32146. (WebCore::RenderBox::scrollTop):
  32147. (WebCore::RenderBox::setScrollLeft):
  32148. (WebCore::RenderBox::setScrollTop):
  32149. (WebCore::RenderBox::getOverflowClipRect):
  32150. (WebCore::RenderBox::localToAbsolute):
  32151. (WebCore::RenderBox::absoluteToLocal):
  32152. (WebCore::RenderBox::localToContainerQuad):
  32153. (WebCore::RenderBox::position):
  32154. (WebCore::RenderBox::computeRectForRepaint):
  32155. (WebCore::RenderBox::calcAbsoluteHorizontal):
  32156. (WebCore::RenderBox::calcAbsoluteVertical):
  32157. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  32158. (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  32159. * rendering/RenderBox.h:
  32160. * rendering/RenderBoxModelObject.cpp:
  32161. (WebCore::RenderBoxModelObject::RenderBoxModelObject):
  32162. (WebCore::RenderBoxModelObject::destroy):
  32163. (WebCore::RenderBoxModelObject::styleWillChange):
  32164. (WebCore::RenderBoxModelObject::styleDidChange):
  32165. (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
  32166. * rendering/RenderBoxModelObject.h:
  32167. (WebCore::RenderBoxModelObject::layer):
  32168. (WebCore::RenderBoxModelObject::requiresLayer):
  32169. * rendering/RenderFlexibleBox.cpp:
  32170. (WebCore::RenderFlexibleBox::layoutBlock):
  32171. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  32172. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  32173. * rendering/RenderInline.cpp:
  32174. (WebCore::RenderInline::updateBoxModelInfoFromStyle):
  32175. (WebCore::RenderInline::styleDidChange):
  32176. (WebCore::RenderInline::relativePositionedInlineOffset):
  32177. * rendering/RenderInline.h:
  32178. * rendering/RenderLayer.cpp:
  32179. (WebCore::RenderLayer::setStaticY):
  32180. (WebCore::RenderLayer::updateLayerPosition):
  32181. * rendering/RenderLayer.h:
  32182. * rendering/RenderObject.cpp:
  32183. (WebCore::RenderObject::setStyle):
  32184. (WebCore::RenderObject::styleDidChange):
  32185. * rendering/RenderObject.h:
  32186. (WebCore::RenderObject::markContainingBlocksForLayout):
  32187. * rendering/RenderTableRow.cpp:
  32188. (WebCore::RenderTableRow::paint):
  32189. * rendering/RenderWidget.cpp:
  32190. (WebCore::RenderWidget::destroy):
  32191. * rendering/bidi.cpp:
  32192. (WebCore::appendRunsForObject):
  32193. (WebCore::RenderBlock::layoutInlineChildren):
  32194. (WebCore::RenderBlock::skipTrailingWhitespace):
  32195. (WebCore::RenderBlock::skipLeadingWhitespace):
  32196. (WebCore::RenderBlock::findNextLineBreak):
  32197. * rendering/style/RenderStyle.h:
  32198. (WebCore::InheritedFlags::hasStaticX):
  32199. (WebCore::InheritedFlags::hasStaticY):
  32200. 2009-02-05 Sam Weinig <sam@webkit.org>
  32201. Fix the windows build.
  32202. * bindings/scripts/CodeGeneratorCOM.pm:
  32203. * dom/Node.idl:
  32204. 2009-02-05 Anders Carlsson <andersca@apple.com>
  32205. Reviewed by Kevin Decker.
  32206. Update to match Gecko.
  32207. * bridge/npapi.h:
  32208. * plugins/npfunctions.h:
  32209. 2009-02-05 Sam Weinig <sam@webkit.org>
  32210. Reviewed by Darin Adler.
  32211. Finish merging EventTargetNode up into Node.
  32212. This also fixes a small recently introduced issue where EventListeners
  32213. would not be removed from the document if they were attached to comment
  32214. nodes outside of the documentElement.
  32215. * GNUmakefile.am:
  32216. * WebCore.pro:
  32217. * WebCore.scons:
  32218. * WebCore.vcproj/WebCore.vcproj:
  32219. * WebCore.xcodeproj/project.pbxproj:
  32220. * WebCoreSources.bkl:
  32221. * bindings/js/JSEventTargetNodeCustom.cpp: Removed.
  32222. * bindings/js/JSNodeCustom.cpp:
  32223. (WebCore::JSNode::addEventListener):
  32224. (WebCore::JSNode::removeEventListener):
  32225. (WebCore::JSNode::pushEventHandlerScope):
  32226. * bindings/scripts/CodeGenerator.pm:
  32227. * dom/CharacterData.cpp:
  32228. (WebCore::CharacterData::CharacterData):
  32229. (WebCore::CharacterData::rendererIsNeeded):
  32230. * dom/CharacterData.h:
  32231. * dom/ContainerNode.cpp:
  32232. (WebCore::ContainerNode::willRemove):
  32233. (WebCore::ContainerNode::attach):
  32234. (WebCore::ContainerNode::detach):
  32235. (WebCore::ContainerNode::insertedIntoDocument):
  32236. (WebCore::ContainerNode::removedFromDocument):
  32237. (WebCore::ContainerNode::setFocus):
  32238. (WebCore::ContainerNode::setActive):
  32239. (WebCore::ContainerNode::setHovered):
  32240. (WebCore::dispatchChildInsertionEvents):
  32241. (WebCore::dispatchChildRemovalEvents):
  32242. * dom/ContainerNode.h:
  32243. (WebCore::ContainerNode::ContainerNode):
  32244. * dom/Document.cpp:
  32245. (WebCore::Document::removeAllEventListenersFromAllNodes):
  32246. (WebCore::Document::removeAllDisconnectedNodeEventListeners):
  32247. (WebCore::Document::setFocusedNode):
  32248. * dom/EventTargetNode.cpp: Removed.
  32249. * dom/EventTargetNode.h: Removed.
  32250. * dom/Node.cpp:
  32251. (WebCore::Node::scriptExecutionContext):
  32252. (WebCore::Node::eventListeners):
  32253. (WebCore::Node::insertedIntoDocument):
  32254. (WebCore::Node::removedFromDocument):
  32255. (WebCore::Node::willMoveToNewOwnerDocument):
  32256. (WebCore::Node::didMoveToNewOwnerDocument):
  32257. (WebCore::updateSVGElementInstancesAfterEventListenerChange):
  32258. (WebCore::Node::addEventListener):
  32259. (WebCore::Node::removeEventListener):
  32260. (WebCore::Node::removeAllEventListenersSlowCase):
  32261. (WebCore::Node::handleLocalEvents):
  32262. (WebCore::eventTargetAsSVGElementInstance):
  32263. (WebCore::eventTargetRespectingSVGTargetRules):
  32264. (WebCore::Node::dispatchEvent):
  32265. (WebCore::Node::dispatchGenericEvent):
  32266. (WebCore::Node::dispatchSubtreeModifiedEvent):
  32267. (WebCore::Node::dispatchWindowEvent):
  32268. (WebCore::Node::dispatchUIEvent):
  32269. (WebCore::Node::dispatchKeyEvent):
  32270. (WebCore::Node::dispatchMouseEvent):
  32271. (WebCore::Node::dispatchSimulatedMouseEvent):
  32272. (WebCore::Node::dispatchSimulatedClick):
  32273. (WebCore::Node::dispatchWheelEvent):
  32274. (WebCore::Node::dispatchWebKitAnimationEvent):
  32275. (WebCore::Node::dispatchWebKitTransitionEvent):
  32276. (WebCore::Node::dispatchFocusEvent):
  32277. (WebCore::Node::dispatchBlurEvent):
  32278. (WebCore::Node::dispatchEventForType):
  32279. (WebCore::Node::dispatchProgressEvent):
  32280. (WebCore::Node::dispatchStorageEvent):
  32281. (WebCore::Node::removeInlineEventListenerForType):
  32282. (WebCore::Node::setInlineEventListenerForType):
  32283. (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
  32284. (WebCore::Node::inlineEventListenerForType):
  32285. (WebCore::Node::disabled):
  32286. (WebCore::Node::defaultEventHandler):
  32287. (WebCore::Node::onabort):
  32288. (WebCore::Node::setOnabort):
  32289. (WebCore::Node::onblur):
  32290. (WebCore::Node::setOnblur):
  32291. (WebCore::Node::onchange):
  32292. (WebCore::Node::setOnchange):
  32293. (WebCore::Node::onclick):
  32294. (WebCore::Node::setOnclick):
  32295. (WebCore::Node::oncontextmenu):
  32296. (WebCore::Node::setOncontextmenu):
  32297. (WebCore::Node::ondblclick):
  32298. (WebCore::Node::setOndblclick):
  32299. (WebCore::Node::onerror):
  32300. (WebCore::Node::setOnerror):
  32301. (WebCore::Node::onfocus):
  32302. (WebCore::Node::setOnfocus):
  32303. (WebCore::Node::oninput):
  32304. (WebCore::Node::setOninput):
  32305. (WebCore::Node::onkeydown):
  32306. (WebCore::Node::setOnkeydown):
  32307. (WebCore::Node::onkeypress):
  32308. (WebCore::Node::setOnkeypress):
  32309. (WebCore::Node::onkeyup):
  32310. (WebCore::Node::setOnkeyup):
  32311. (WebCore::Node::onload):
  32312. (WebCore::Node::setOnload):
  32313. (WebCore::Node::onmousedown):
  32314. (WebCore::Node::setOnmousedown):
  32315. (WebCore::Node::onmousemove):
  32316. (WebCore::Node::setOnmousemove):
  32317. (WebCore::Node::onmouseout):
  32318. (WebCore::Node::setOnmouseout):
  32319. (WebCore::Node::onmouseover):
  32320. (WebCore::Node::setOnmouseover):
  32321. (WebCore::Node::onmouseup):
  32322. (WebCore::Node::setOnmouseup):
  32323. (WebCore::Node::onmousewheel):
  32324. (WebCore::Node::setOnmousewheel):
  32325. (WebCore::Node::onbeforecut):
  32326. (WebCore::Node::setOnbeforecut):
  32327. (WebCore::Node::oncut):
  32328. (WebCore::Node::setOncut):
  32329. (WebCore::Node::onbeforecopy):
  32330. (WebCore::Node::setOnbeforecopy):
  32331. (WebCore::Node::oncopy):
  32332. (WebCore::Node::setOncopy):
  32333. (WebCore::Node::onbeforepaste):
  32334. (WebCore::Node::setOnbeforepaste):
  32335. (WebCore::Node::onpaste):
  32336. (WebCore::Node::setOnpaste):
  32337. (WebCore::Node::ondragenter):
  32338. (WebCore::Node::setOndragenter):
  32339. (WebCore::Node::ondragover):
  32340. (WebCore::Node::setOndragover):
  32341. (WebCore::Node::ondragleave):
  32342. (WebCore::Node::setOndragleave):
  32343. (WebCore::Node::ondrop):
  32344. (WebCore::Node::setOndrop):
  32345. (WebCore::Node::ondragstart):
  32346. (WebCore::Node::setOndragstart):
  32347. (WebCore::Node::ondrag):
  32348. (WebCore::Node::setOndrag):
  32349. (WebCore::Node::ondragend):
  32350. (WebCore::Node::setOndragend):
  32351. (WebCore::Node::onreset):
  32352. (WebCore::Node::setOnreset):
  32353. (WebCore::Node::onresize):
  32354. (WebCore::Node::setOnresize):
  32355. (WebCore::Node::onscroll):
  32356. (WebCore::Node::setOnscroll):
  32357. (WebCore::Node::onsearch):
  32358. (WebCore::Node::setOnsearch):
  32359. (WebCore::Node::onselect):
  32360. (WebCore::Node::setOnselect):
  32361. (WebCore::Node::onselectstart):
  32362. (WebCore::Node::setOnselectstart):
  32363. (WebCore::Node::onsubmit):
  32364. (WebCore::Node::setOnsubmit):
  32365. (WebCore::Node::onunload):
  32366. (WebCore::Node::setOnunload):
  32367. * dom/Node.h:
  32368. * editing/Editor.cpp:
  32369. (WebCore::Editor::dispatchCPPEvent):
  32370. * html/HTMLFormElement.cpp:
  32371. (WebCore::HTMLFormElement::handleLocalEvents):
  32372. * html/HTMLInputElement.cpp:
  32373. (WebCore::HTMLInputElement::defaultEventHandler):
  32374. * html/HTMLTokenizer.cpp:
  32375. (WebCore::HTMLTokenizer::notifyFinished):
  32376. * loader/MediaDocument.cpp:
  32377. (WebCore::MediaDocument::defaultEventHandler):
  32378. * page/AccessibilityRenderObject.cpp:
  32379. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  32380. * page/EventHandler.cpp:
  32381. (WebCore::EventHandler::dispatchDragEvent):
  32382. (WebCore::EventHandler::updateMouseEventTargetNode):
  32383. (WebCore::EventHandler::dispatchMouseEvent):
  32384. (WebCore::EventHandler::handleWheelEvent):
  32385. (WebCore::EventHandler::canMouseDownStartSelect):
  32386. (WebCore::EventHandler::canMouseDragExtendSelect):
  32387. (WebCore::eventTargetNodeForDocument):
  32388. (WebCore::EventHandler::keyEvent):
  32389. * page/FrameView.cpp:
  32390. (WebCore::FrameView::scheduleEvent):
  32391. (WebCore::FrameView::updateOverflowStatus):
  32392. * page/FrameView.h:
  32393. * page/Page.cpp:
  32394. (WebCore::networkStateChanged):
  32395. * rendering/RenderLayer.cpp:
  32396. (WebCore::RenderLayer::scrollToOffset):
  32397. (WebCore::RenderLayer::updateOverflowStatus):
  32398. * rendering/RenderListBox.cpp:
  32399. (WebCore::RenderListBox::valueChanged):
  32400. * rendering/RenderMedia.h:
  32401. * rendering/RenderTextControl.cpp:
  32402. (WebCore::RenderTextControl::selectionChanged):
  32403. * svg/SVGElementInstance.h:
  32404. (WebCore::SVGElementInstance::toNode):
  32405. * xml/XPathExpression.cpp:
  32406. (WebCore::XPathExpression::evaluate):
  32407. * xml/XPathResult.cpp:
  32408. (WebCore::XPathResult::XPathResult):
  32409. 2009-02-05 Adam Treat <adam.treat@torchmobile.com>
  32410. Fix the Qt build now that EventTargetNode.idl was removed in r40672.
  32411. * WebCore.pro:
  32412. 2009-02-05 Scott Violet <sky@google.com>
  32413. Reviewed by Sam Weinig.
  32414. Bug 23462: Add RGB -> CMYK conversion algorithm
  32415. <https://bugs.webkit.org/show_bug.cgi?id=23462>
  32416. Adds an RGB -> CMYK converter. This isn't perfect, but better than
  32417. nothing.
  32418. * html/CanvasStyle.cpp:
  32419. (WebCore::CanvasStyle::applyStrokeColor):
  32420. (WebCore::CanvasStyle::applyFillColor):
  32421. (WebCore::CanvasStyle::cmykToRGB):
  32422. * html/CanvasStyle.h:
  32423. 2009-02-04 Sam Weinig <sam@webkit.org>
  32424. Reviewed by Darin Adler.
  32425. First stage of merging EventTargetNode up into Node. The intent of this change
  32426. is to both simplify the inheritance hierarchy (at the same time making it more
  32427. closely match the spec which states that all Nodes are EventTargets) and save
  32428. 4 bytes per Node that the polymorphic multiple-inheritance was costing us.
  32429. This does the bare minimum to get things compiling, the next patch will clean
  32430. * DerivedSources.make:
  32431. * WebCore.base.exp:
  32432. * WebCore.xcodeproj/project.pbxproj:
  32433. * bindings/js/JSDocumentCustom.cpp:
  32434. (WebCore::JSDocument::mark):
  32435. * bindings/js/JSEventListener.cpp:
  32436. (WebCore::JSLazyEventListener::parseCode):
  32437. * bindings/js/JSEventTarget.cpp:
  32438. (WebCore::toEventTarget):
  32439. * bindings/js/JSEventTarget.h:
  32440. * bindings/js/JSEventTargetNodeCustom.cpp:
  32441. (WebCore::JSNode::addEventListener):
  32442. (WebCore::JSNode::removeEventListener):
  32443. (WebCore::JSNode::pushEventHandlerScope):
  32444. * bindings/js/JSStyleSheetCustom.cpp:
  32445. * bindings/scripts/CodeGeneratorJS.pm:
  32446. * bindings/scripts/CodeGeneratorObjC.pm:
  32447. * dom/Attr.idl:
  32448. * dom/CharacterData.h:
  32449. * dom/CharacterData.idl:
  32450. * dom/Document.idl:
  32451. * dom/DocumentFragment.idl:
  32452. * dom/Element.idl:
  32453. * dom/EventTarget.cpp:
  32454. (WebCore::EventTarget::toNode):
  32455. * dom/EventTarget.h:
  32456. * dom/EventTarget.idl:
  32457. * dom/EventTargetNode.cpp:
  32458. (WebCore::Node::scriptExecutionContext):
  32459. (WebCore::Node::eventListeners):
  32460. (WebCore::Node::insertedIntoDocument):
  32461. (WebCore::Node::removedFromDocument):
  32462. (WebCore::Node::willMoveToNewOwnerDocument):
  32463. (WebCore::Node::didMoveToNewOwnerDocument):
  32464. (WebCore::Node::addEventListener):
  32465. (WebCore::Node::removeEventListener):
  32466. (WebCore::Node::removeAllEventListenersSlowCase):
  32467. (WebCore::Node::handleLocalEvents):
  32468. (WebCore::Node::dispatchEvent):
  32469. (WebCore::Node::dispatchGenericEvent):
  32470. (WebCore::Node::dispatchSubtreeModifiedEvent):
  32471. (WebCore::Node::dispatchWindowEvent):
  32472. (WebCore::Node::dispatchUIEvent):
  32473. (WebCore::Node::dispatchKeyEvent):
  32474. (WebCore::Node::dispatchMouseEvent):
  32475. (WebCore::Node::dispatchSimulatedMouseEvent):
  32476. (WebCore::Node::dispatchSimulatedClick):
  32477. (WebCore::Node::dispatchWheelEvent):
  32478. (WebCore::Node::dispatchWebKitAnimationEvent):
  32479. (WebCore::Node::dispatchWebKitTransitionEvent):
  32480. (WebCore::Node::dispatchFocusEvent):
  32481. (WebCore::Node::dispatchBlurEvent):
  32482. (WebCore::Node::dispatchEventForType):
  32483. (WebCore::Node::dispatchProgressEvent):
  32484. (WebCore::Node::dispatchStorageEvent):
  32485. (WebCore::Node::removeInlineEventListenerForType):
  32486. (WebCore::Node::setInlineEventListenerForType):
  32487. (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
  32488. (WebCore::Node::inlineEventListenerForType):
  32489. (WebCore::Node::disabled):
  32490. (WebCore::Node::defaultEventHandler):
  32491. (WebCore::Node::onabort):
  32492. (WebCore::Node::setOnabort):
  32493. (WebCore::Node::onblur):
  32494. (WebCore::Node::setOnblur):
  32495. (WebCore::Node::onchange):
  32496. (WebCore::Node::setOnchange):
  32497. (WebCore::Node::onclick):
  32498. (WebCore::Node::setOnclick):
  32499. (WebCore::Node::oncontextmenu):
  32500. (WebCore::Node::setOncontextmenu):
  32501. (WebCore::Node::ondblclick):
  32502. (WebCore::Node::setOndblclick):
  32503. (WebCore::Node::onerror):
  32504. (WebCore::Node::setOnerror):
  32505. (WebCore::Node::onfocus):
  32506. (WebCore::Node::setOnfocus):
  32507. (WebCore::Node::oninput):
  32508. (WebCore::Node::setOninput):
  32509. (WebCore::Node::onkeydown):
  32510. (WebCore::Node::setOnkeydown):
  32511. (WebCore::Node::onkeypress):
  32512. (WebCore::Node::setOnkeypress):
  32513. (WebCore::Node::onkeyup):
  32514. (WebCore::Node::setOnkeyup):
  32515. (WebCore::Node::onload):
  32516. (WebCore::Node::setOnload):
  32517. (WebCore::Node::onmousedown):
  32518. (WebCore::Node::setOnmousedown):
  32519. (WebCore::Node::onmousemove):
  32520. (WebCore::Node::setOnmousemove):
  32521. (WebCore::Node::onmouseout):
  32522. (WebCore::Node::setOnmouseout):
  32523. (WebCore::Node::onmouseover):
  32524. (WebCore::Node::setOnmouseover):
  32525. (WebCore::Node::onmouseup):
  32526. (WebCore::Node::setOnmouseup):
  32527. (WebCore::Node::onmousewheel):
  32528. (WebCore::Node::setOnmousewheel):
  32529. (WebCore::Node::onbeforecut):
  32530. (WebCore::Node::setOnbeforecut):
  32531. (WebCore::Node::oncut):
  32532. (WebCore::Node::setOncut):
  32533. (WebCore::Node::onbeforecopy):
  32534. (WebCore::Node::setOnbeforecopy):
  32535. (WebCore::Node::oncopy):
  32536. (WebCore::Node::setOncopy):
  32537. (WebCore::Node::onbeforepaste):
  32538. (WebCore::Node::setOnbeforepaste):
  32539. (WebCore::Node::onpaste):
  32540. (WebCore::Node::setOnpaste):
  32541. (WebCore::Node::ondragenter):
  32542. (WebCore::Node::setOndragenter):
  32543. (WebCore::Node::ondragover):
  32544. (WebCore::Node::setOndragover):
  32545. (WebCore::Node::ondragleave):
  32546. (WebCore::Node::setOndragleave):
  32547. (WebCore::Node::ondrop):
  32548. (WebCore::Node::setOndrop):
  32549. (WebCore::Node::ondragstart):
  32550. (WebCore::Node::setOndragstart):
  32551. (WebCore::Node::ondrag):
  32552. (WebCore::Node::setOndrag):
  32553. (WebCore::Node::ondragend):
  32554. (WebCore::Node::setOndragend):
  32555. (WebCore::Node::onreset):
  32556. (WebCore::Node::setOnreset):
  32557. (WebCore::Node::onresize):
  32558. (WebCore::Node::setOnresize):
  32559. (WebCore::Node::onscroll):
  32560. (WebCore::Node::setOnscroll):
  32561. (WebCore::Node::onsearch):
  32562. (WebCore::Node::setOnsearch):
  32563. (WebCore::Node::onselect):
  32564. (WebCore::Node::setOnselect):
  32565. (WebCore::Node::onselectstart):
  32566. (WebCore::Node::setOnselectstart):
  32567. (WebCore::Node::onsubmit):
  32568. (WebCore::Node::setOnsubmit):
  32569. (WebCore::Node::onunload):
  32570. (WebCore::Node::setOnunload):
  32571. * dom/EventTargetNode.h:
  32572. (WebCore::toEventTargetNode):
  32573. (WebCore::EventTargetNodeCast):
  32574. * dom/EventTargetNode.idl: Removed.
  32575. * dom/MouseEvent.cpp:
  32576. (WebCore::MouseEvent::MouseEvent):
  32577. (WebCore::MouseEvent::initMouseEvent):
  32578. (WebCore::MouseEvent::toElement):
  32579. (WebCore::MouseEvent::fromElement):
  32580. * dom/MouseEvent.h:
  32581. (WebCore::MouseEvent::create):
  32582. (WebCore::MouseEvent::relatedTarget):
  32583. * dom/Node.cpp:
  32584. (WebCore::Node::~Node):
  32585. * dom/Node.h:
  32586. (WebCore::Node::isEventTargetNode):
  32587. (WebCore::Node::toNode):
  32588. (WebCore::Node::removeAllEventListeners):
  32589. (WebCore::Node::refEventTarget):
  32590. (WebCore::Node::derefEventTarget):
  32591. * dom/Node.idl:
  32592. * page/EventHandler.h:
  32593. * page/FrameView.h:
  32594. * xml/XPathResult.h:
  32595. (WebCore::XPathResult::create):
  32596. 2009-02-04 David Hyatt <hyatt@apple.com>
  32597. Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*. The
  32598. container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.
  32599. All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
  32600. or an inline flow. x()/y()/width()/height() can't be queried on an inline flow, nor can many other
  32601. properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
  32602. under the right conditions.
  32603. There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines. Since y was always
  32604. 0, this subtraction wasn't necessary. It has been removed.
  32605. Reviewed by Adam Roben
  32606. * page/animation/AnimationBase.cpp:
  32607. * rendering/RenderBR.h:
  32608. (WebCore::RenderBR::selectionRectForRepaint):
  32609. * rendering/RenderBlock.cpp:
  32610. (WebCore::RenderBlock::selectionGapRectsForRepaint):
  32611. (WebCore::RenderBlock::rectWithOutlineForRepaint):
  32612. * rendering/RenderBlock.h:
  32613. (WebCore::RenderBlock::selectionRectForRepaint):
  32614. * rendering/RenderBox.cpp:
  32615. (WebCore::RenderBox::outlineBoundsForRepaint):
  32616. (WebCore::RenderBox::localToContainerQuad):
  32617. (WebCore::RenderBox::clippedOverflowRectForRepaint):
  32618. (WebCore::RenderBox::computeRectForRepaint):
  32619. * rendering/RenderBox.h:
  32620. * rendering/RenderBoxModelObject.cpp:
  32621. (WebCore::RenderBoxModelObject::relativePositionOffsetX):
  32622. (WebCore::RenderBoxModelObject::relativePositionOffsetY):
  32623. * rendering/RenderBoxModelObject.h:
  32624. (WebCore::RenderBoxModelObject::relativePositionOffset):
  32625. * rendering/RenderForeignObject.cpp:
  32626. (WebCore::RenderForeignObject::computeRectForRepaint):
  32627. * rendering/RenderForeignObject.h:
  32628. * rendering/RenderInline.cpp:
  32629. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  32630. (WebCore::RenderInline::rectWithOutlineForRepaint):
  32631. * rendering/RenderInline.h:
  32632. * rendering/RenderLayer.cpp:
  32633. (WebCore::RenderLayer::RenderLayer):
  32634. (WebCore::RenderLayer::updateLayerPositions):
  32635. (WebCore::RenderLayer::updateTransform):
  32636. (WebCore::RenderLayer::setHasVisibleContent):
  32637. (WebCore::RenderLayer::updateLayerPosition):
  32638. (WebCore::RenderLayer::scrollToOffset):
  32639. (WebCore::RenderLayer::scrollRectToVisible):
  32640. (WebCore::resizerCornerRect):
  32641. (WebCore::RenderLayer::scrollbarCornerPresent):
  32642. (WebCore::RenderLayer::invalidateScrollbarRect):
  32643. (WebCore::RenderLayer::positionOverflowControls):
  32644. (WebCore::RenderLayer::computeScrollDimensions):
  32645. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  32646. (WebCore::RenderLayer::paintScrollCorner):
  32647. (WebCore::RenderLayer::paintResizer):
  32648. (WebCore::RenderLayer::isPointInResizeControl):
  32649. (WebCore::RenderLayer::hitTestOverflowControls):
  32650. (WebCore::RenderLayer::paintLayer):
  32651. (WebCore::RenderLayer::hitTestLayer):
  32652. (WebCore::RenderLayer::localBoundingBox):
  32653. * rendering/RenderLayer.h:
  32654. (WebCore::RenderLayer::renderer):
  32655. (WebCore::RenderLayer::renderBox):
  32656. (WebCore::RenderLayer::renderBoxX):
  32657. (WebCore::RenderLayer::renderBoxY):
  32658. * rendering/RenderListMarker.cpp:
  32659. (WebCore::RenderListMarker::selectionRectForRepaint):
  32660. * rendering/RenderListMarker.h:
  32661. * rendering/RenderMarquee.cpp:
  32662. (WebCore::RenderMarquee::computePosition):
  32663. (WebCore::RenderMarquee::timerFired):
  32664. * rendering/RenderObject.cpp:
  32665. (WebCore::RenderObject::containerForRepaint):
  32666. (WebCore::RenderObject::repaintUsingContainer):
  32667. (WebCore::RenderObject::repaint):
  32668. (WebCore::RenderObject::repaintRectangle):
  32669. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  32670. (WebCore::RenderObject::rectWithOutlineForRepaint):
  32671. (WebCore::RenderObject::clippedOverflowRectForRepaint):
  32672. (WebCore::RenderObject::computeRectForRepaint):
  32673. (WebCore::RenderObject::localToContainerQuad):
  32674. * rendering/RenderObject.h:
  32675. (WebCore::RenderObject::selectionRectForRepaint):
  32676. (WebCore::RenderObject::outlineBoundsForRepaint):
  32677. * rendering/RenderPath.cpp:
  32678. (WebCore::RenderPath::clippedOverflowRectForRepaint):
  32679. (WebCore::RenderPath::outlineBoundsForRepaint):
  32680. * rendering/RenderPath.h:
  32681. * rendering/RenderReplaced.cpp:
  32682. (WebCore::RenderReplaced::selectionRectForRepaint):
  32683. (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
  32684. * rendering/RenderReplaced.h:
  32685. * rendering/RenderSVGContainer.cpp:
  32686. (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
  32687. (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
  32688. * rendering/RenderSVGContainer.h:
  32689. * rendering/RenderSVGHiddenContainer.cpp:
  32690. (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
  32691. * rendering/RenderSVGHiddenContainer.h:
  32692. * rendering/RenderSVGImage.cpp:
  32693. (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
  32694. * rendering/RenderSVGImage.h:
  32695. * rendering/RenderSVGInlineText.cpp:
  32696. (WebCore::RenderSVGInlineText::selectionRectForRepaint):
  32697. (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  32698. * rendering/RenderSVGInlineText.h:
  32699. * rendering/RenderSVGRoot.cpp:
  32700. (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
  32701. * rendering/RenderSVGRoot.h:
  32702. * rendering/RenderSVGText.cpp:
  32703. (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
  32704. * rendering/RenderSVGText.h:
  32705. * rendering/RenderSelectionInfo.h:
  32706. (WebCore::RenderSelectionInfoBase::repaintContainer):
  32707. * rendering/RenderTableCell.cpp:
  32708. (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
  32709. (WebCore::RenderTableCell::computeRectForRepaint):
  32710. (WebCore::RenderTableCell::localToContainerQuad):
  32711. * rendering/RenderTableCell.h:
  32712. * rendering/RenderTableCol.cpp:
  32713. (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
  32714. * rendering/RenderTableCol.h:
  32715. * rendering/RenderTableRow.cpp:
  32716. (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
  32717. * rendering/RenderTableRow.h:
  32718. * rendering/RenderText.cpp:
  32719. (WebCore::RenderText::clippedOverflowRectForRepaint):
  32720. (WebCore::RenderText::selectionRectForRepaint):
  32721. * rendering/RenderText.h:
  32722. * rendering/RenderTreeAsText.cpp:
  32723. (WebCore::write):
  32724. * rendering/RenderView.cpp:
  32725. (WebCore::RenderView::localToContainerQuad):
  32726. (WebCore::RenderView::computeRectForRepaint):
  32727. * rendering/RenderView.h:
  32728. 2009-02-05 Alexey Proskuryakov <ap@webkit.org>
  32729. Build fix.
  32730. * page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.
  32731. 2009-02-05 Yael Aharon <yael.aharon@nokia.com>
  32732. Reviewed by Alexey Proskuryakov.
  32733. Landed by Simon Hausmann.
  32734. https://bugs.webkit.org/show_bug.cgi?id=23733
  32735. Use a 2 arguments constructor for KURL to avoid ASSERT failure.
  32736. * page/SecurityOrigin.cpp:
  32737. (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
  32738. 2009-02-04 Feng Qian <feng@chromium.org>
  32739. Reviewed by Darin Adler.
  32740. Add Android-specific files to WebCore/editing directory.
  32741. https://bugs.webkit.org/show_bug.cgi?id=23294
  32742. * editing/android: Added.
  32743. * editing/android/EditorAndroid.cpp: Added.
  32744. (WebCore::Editor::newGeneralClipboard):
  32745. 2009-02-04 Dean Jackson <dino@apple.com>
  32746. Reviewed by Darin Adler.
  32747. Remove -webkit-animation-play-state
  32748. The AnimationController still has the code to execute the property, but
  32749. it is no longer parsed or recorded.
  32750. https://bugs.webkit.org/show_bug.cgi?id=22907
  32751. * css/CSSComputedStyleDeclaration.cpp:
  32752. (WebCore::):
  32753. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  32754. * css/CSSParser.cpp:
  32755. (WebCore::CSSParser::parseValue):
  32756. (WebCore::CSSParser::parseAnimationProperty):
  32757. * css/CSSParser.h:
  32758. * css/CSSPropertyNames.in:
  32759. * css/CSSStyleSelector.cpp:
  32760. (WebCore::CSSStyleSelector::applyProperty):
  32761. * css/CSSStyleSelector.h:
  32762. * platform/animation/Animation.h:
  32763. * rendering/style/RenderStyleConstants.h:
  32764. 2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
  32765. Reviewed by Darin Adler.
  32766. Make sure we don't load on removing the media element from the document
  32767. https://bugs.webkit.org/show_bug.cgi?id=22105
  32768. Test: media/remove-from-document-no-load.html
  32769. * html/HTMLMediaElement.cpp:
  32770. (WebCore::HTMLMediaElement::removedFromDocument):
  32771. 2009-02-04 David Hyatt <hyatt@apple.com>
  32772. Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
  32773. now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
  32774. derived from RenderBox for now.
  32775. Reviewed by Sam Weinig
  32776. * WebCore.xcodeproj/project.pbxproj:
  32777. * rendering/RenderBox.cpp:
  32778. (WebCore::RenderBox::RenderBox):
  32779. (WebCore::RenderBox::destroy):
  32780. (WebCore::RenderBox::styleWillChange):
  32781. (WebCore::RenderBox::styleDidChange):
  32782. (WebCore::RenderBox::computeRectForRepaint):
  32783. * rendering/RenderBox.h:
  32784. * rendering/RenderBoxModelObject.cpp: Added.
  32785. (WebCore::RenderBoxModelObject::RenderBoxModelObject):
  32786. (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
  32787. * rendering/RenderBoxModelObject.h: Added.
  32788. * rendering/RenderObject.h:
  32789. 2009-02-04 Chris Marrin <cmarrin@apple.com>
  32790. Reviewed by Dave Hyatt
  32791. Added accelerated animation support to AnimationController and friends. The primary
  32792. changes are:
  32793. * accelerated animations get their start time from the compositing engine, so we
  32794. wait for a callback (notifyAnimationStarted()) in order to get the start time.
  32795. * if software and accelerated animations start in the same cycle, they all need
  32796. to use the same start time, which is that of the accelerated animations.
  32797. Added AnimationControllerPrivate to preserve the encapsulation under
  32798. AnimationController.
  32799. * GNUmakefile.am:
  32800. * WebCore.vcproj/WebCore.vcproj:
  32801. * WebCore.xcodeproj/project.pbxproj:
  32802. * page/animation/AnimationBase.cpp:
  32803. (WebCore::PropertyWrapperBase::animationIsAccelerated):
  32804. (WebCore::PropertyWrapperAcceleratedOpacity::PropertyWrapperAcceleratedOpacity):
  32805. (WebCore::PropertyWrapperAcceleratedOpacity::animationIsAccelerated):
  32806. (WebCore::PropertyWrapperAcceleratedOpacity::blend):
  32807. (WebCore::PropertyWrapperAcceleratedTransform::PropertyWrapperAcceleratedTransform):
  32808. (WebCore::PropertyWrapperAcceleratedTransform::animationIsAccelerated):
  32809. (WebCore::PropertyWrapperAcceleratedTransform::blend):
  32810. (WebCore::ensurePropertyMap):
  32811. (WebCore::AnimationBase::AnimationBase):
  32812. (WebCore::AnimationBase::~AnimationBase):
  32813. (WebCore::AnimationBase::blendProperties):
  32814. (WebCore::AnimationBase::animationOfPropertyIsAccelerated):
  32815. (WebCore::AnimationBase::updateStateMachine):
  32816. (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
  32817. (WebCore::AnimationBase::willNeedService):
  32818. (WebCore::AnimationBase::getTimeToNextEvent):
  32819. (WebCore::AnimationBase::goIntoEndingOrLoopingState):
  32820. (WebCore::AnimationBase::beginAnimationUpdateTime):
  32821. * page/animation/AnimationBase.h:
  32822. (WebCore::AnimationBase::onAnimationStartResponse):
  32823. (WebCore::AnimationBase::getAnimatedStyle):
  32824. (WebCore::AnimationBase::isAnimatingProperty):
  32825. (WebCore::AnimationBase::endAnimation):
  32826. (WebCore::AnimationBase::isFallbackAnimating):
  32827. * page/animation/AnimationController.cpp:
  32828. (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
  32829. (WebCore::AnimationControllerPrivate::accessCompositeAnimation):
  32830. (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
  32831. (WebCore::AnimationControllerPrivate::animationTimerFired):
  32832. (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
  32833. (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  32834. (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  32835. (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
  32836. (WebCore::AnimationControllerPrivate::styleAvailable):
  32837. (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
  32838. (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
  32839. (WebCore::AnimationControllerPrivate::startTimeResponse):
  32840. (WebCore::AnimationController::getAnimatedStyleForRenderer):
  32841. (WebCore::AnimationController::notifyAnimationStarted):
  32842. (WebCore::AnimationController::endAnimationUpdate):
  32843. * page/animation/AnimationController.h:
  32844. * page/animation/AnimationControllerPrivate.h: Added.
  32845. (WebCore::AnimationControllerPrivate::hasAnimations):
  32846. (WebCore::AnimationControllerPrivate::setBeginAnimationUpdateTime):
  32847. (WebCore::AnimationControllerPrivate::endAnimationUpdate):
  32848. (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
  32849. * page/animation/CompositeAnimation.cpp:
  32850. (WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
  32851. (WebCore::CompositeAnimationPrivate::animationControllerPriv):
  32852. (WebCore::CompositeAnimationPrivate::updateTransitions):
  32853. (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
  32854. (WebCore::CompositeAnimationPrivate::animate):
  32855. (WebCore::CompositeAnimationPrivate::getAnimatedStyle):
  32856. (WebCore::CompositeAnimationPrivate::addToStartTimeResponseWaitList):
  32857. (WebCore::CompositeAnimationPrivate::removeFromStartTimeResponseWaitList):
  32858. (WebCore::CompositeAnimation::CompositeAnimation):
  32859. (WebCore::CompositeAnimation::animationControllerPriv):
  32860. (WebCore::CompositeAnimation::getAnimatedStyle):
  32861. (WebCore::CompositeAnimation::addToStartTimeResponseWaitList):
  32862. (WebCore::CompositeAnimation::removeFromStartTimeResponseWaitList):
  32863. * page/animation/CompositeAnimation.h:
  32864. (WebCore::CompositeAnimation::create):
  32865. * page/animation/ImplicitAnimation.cpp:
  32866. (WebCore::ImplicitAnimation::shouldSendEventForListener):
  32867. (WebCore::ImplicitAnimation::animate):
  32868. (WebCore::ImplicitAnimation::getAnimatedStyle):
  32869. (WebCore::ImplicitAnimation::startAnimation):
  32870. (WebCore::ImplicitAnimation::endAnimation):
  32871. (WebCore::ImplicitAnimation::sendTransitionEvent):
  32872. (WebCore::ImplicitAnimation::willNeedService):
  32873. * page/animation/ImplicitAnimation.h:
  32874. * page/animation/KeyframeAnimation.cpp:
  32875. (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
  32876. (WebCore::KeyframeAnimation::animate):
  32877. (WebCore::KeyframeAnimation::getAnimatedStyle):
  32878. (WebCore::KeyframeAnimation::startAnimation):
  32879. (WebCore::KeyframeAnimation::endAnimation):
  32880. (WebCore::KeyframeAnimation::shouldSendEventForListener):
  32881. (WebCore::KeyframeAnimation::sendAnimationEvent):
  32882. (WebCore::KeyframeAnimation::willNeedService):
  32883. * page/animation/KeyframeAnimation.h:
  32884. * platform/graphics/GraphicsLayerClient.h:
  32885. * platform/graphics/mac/GraphicsLayerCA.mm:
  32886. (-[WebAnimationDelegate animationDidStart:]):
  32887. * rendering/RenderLayerBacking.h:
  32888. 2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
  32889. Not reviewed, build fix.
  32890. Remove duplicate definition of msSans in FontCache::alternateFamilyName.
  32891. * platform/graphics/FontCache.cpp:
  32892. (WebCore::alternateFamilyName):
  32893. 2009-02-04 Eric Seidel <eric@webkit.org>
  32894. Reviewed by George Staikos.
  32895. Reverse the meaning of the if check so that Android
  32896. (dpad devices) do not scroll on focus and normal platforms do
  32897. http://trac.webkit.org/changeset/40647
  32898. This was caught by George Staikos, and I wrote the patch.
  32899. * dom/Element.cpp:
  32900. (WebCore::Element::updateFocusAppearance):
  32901. 2009-02-04 David Hyatt <hyatt@apple.com>
  32902. Eliminate RenderContainer.
  32903. Reviewed by Sam and Anders
  32904. * GNUmakefile.am:
  32905. * WebCore.pro:
  32906. * WebCore.vcproj/WebCore.vcproj:
  32907. * WebCore.xcodeproj/project.pbxproj:
  32908. * WebCoreSources.bkl:
  32909. * rendering/RenderBlock.cpp:
  32910. (WebCore::RenderBlock::RenderBlock):
  32911. (WebCore::RenderBlock::destroy):
  32912. (WebCore::RenderBlock::styleWillChange):
  32913. (WebCore::RenderBlock::styleDidChange):
  32914. (WebCore::RenderBlock::addChild):
  32915. (WebCore::RenderBlock::dirtyLineBoxes):
  32916. (WebCore::RenderBlock::createInlineBox):
  32917. (WebCore::RenderBlock::removeChild):
  32918. (WebCore::RenderBlock::setSelectionState):
  32919. (WebCore::RenderBlock::avoidsFloats):
  32920. (WebCore::RenderBlock::positionForCoordinates):
  32921. (WebCore::RenderBlock::calcInlinePrefWidths):
  32922. (WebCore::RenderBlock::baselinePosition):
  32923. (WebCore::RenderBlock::getBaselineOfFirstLineBox):
  32924. (WebCore::RenderBlock::getBaselineOfLastLineBox):
  32925. (WebCore::RenderBlock::rectWithOutlineForRepaint):
  32926. (WebCore::RenderBlock::hoverAncestor):
  32927. (WebCore::RenderBlock::updateDragState):
  32928. (WebCore::RenderBlock::localCaretRect):
  32929. * rendering/RenderBlock.h:
  32930. (WebCore::RenderBlock::virtualChildren):
  32931. (WebCore::RenderBlock::children):
  32932. * rendering/RenderContainer.cpp: Removed.
  32933. * rendering/RenderContainer.h: Removed.
  32934. * rendering/RenderFrameSet.cpp:
  32935. (WebCore::RenderFrameSet::RenderFrameSet):
  32936. (WebCore::RenderFrameSet::nodeAtPoint):
  32937. (WebCore::RenderFrameSet::layout):
  32938. * rendering/RenderFrameSet.h:
  32939. (WebCore::RenderFrameSet::virtualChildren):
  32940. (WebCore::RenderFrameSet::children):
  32941. * rendering/RenderInline.cpp:
  32942. (WebCore::RenderInline::RenderInline):
  32943. (WebCore::RenderInline::destroy):
  32944. (WebCore::RenderInline::styleDidChange):
  32945. (WebCore::nextContinuation):
  32946. (WebCore::RenderInline::continuationBefore):
  32947. (WebCore::RenderInline::addChildIgnoringContinuation):
  32948. (WebCore::RenderInline::splitInlines):
  32949. (WebCore::RenderInline::splitFlow):
  32950. (WebCore::RenderInline::addChildToContinuation):
  32951. (WebCore::RenderInline::offsetLeft):
  32952. (WebCore::RenderInline::offsetTop):
  32953. (WebCore::RenderInline::positionForCoordinates):
  32954. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  32955. (WebCore::RenderInline::rectWithOutlineForRepaint):
  32956. (WebCore::RenderInline::updateDragState):
  32957. (WebCore::RenderInline::childBecameNonInline):
  32958. * rendering/RenderInline.h:
  32959. (WebCore::RenderInline::virtualChildren):
  32960. (WebCore::RenderInline::children):
  32961. (WebCore::RenderInline::continuation):
  32962. (WebCore::RenderInline::setContinuation):
  32963. * rendering/RenderLineBoxList.h:
  32964. * rendering/RenderObject.h:
  32965. * rendering/RenderObjectChildList.h:
  32966. * rendering/RenderSVGInlineText.cpp:
  32967. (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  32968. * rendering/RenderSVGRoot.cpp:
  32969. (WebCore::RenderSVGRoot::RenderSVGRoot):
  32970. (WebCore::RenderSVGRoot::applyContentTransforms):
  32971. (WebCore::RenderSVGRoot::paint):
  32972. (WebCore::RenderSVGRoot::absoluteTransform):
  32973. (WebCore::RenderSVGRoot::nodeAtPoint):
  32974. (WebCore::RenderSVGRoot::position):
  32975. * rendering/RenderSVGRoot.h:
  32976. (WebCore::RenderSVGRoot::virtualChildren):
  32977. (WebCore::RenderSVGRoot::children):
  32978. * rendering/RenderSVGText.cpp:
  32979. (WebCore::RenderSVGText::absoluteRects):
  32980. (WebCore::RenderSVGText::absoluteQuads):
  32981. * rendering/RenderTable.cpp:
  32982. (WebCore::RenderTable::addChild):
  32983. (WebCore::RenderTable::removeChild):
  32984. * rendering/RenderTableCol.cpp:
  32985. (WebCore::RenderTableCol::RenderTableCol):
  32986. * rendering/RenderTableCol.h:
  32987. (WebCore::RenderTableCol::virtualChildren):
  32988. (WebCore::RenderTableCol::children):
  32989. * rendering/RenderTableRow.cpp:
  32990. (WebCore::RenderTableRow::RenderTableRow):
  32991. (WebCore::RenderTableRow::destroy):
  32992. (WebCore::RenderTableRow::styleWillChange):
  32993. (WebCore::RenderTableRow::addChild):
  32994. * rendering/RenderTableRow.h:
  32995. (WebCore::RenderTableRow::virtualChildren):
  32996. (WebCore::RenderTableRow::children):
  32997. * rendering/RenderTableSection.cpp:
  32998. (WebCore::RenderTableSection::RenderTableSection):
  32999. (WebCore::RenderTableSection::destroy):
  33000. (WebCore::RenderTableSection::addChild):
  33001. (WebCore::RenderTableSection::removeChild):
  33002. (WebCore::RenderTableSection::lowestPosition):
  33003. (WebCore::RenderTableSection::rightmostPosition):
  33004. (WebCore::RenderTableSection::leftmostPosition):
  33005. * rendering/RenderTableSection.h:
  33006. (WebCore::RenderTableSection::virtualChildren):
  33007. (WebCore::RenderTableSection::children):
  33008. 2009-02-04 Mads Adger <mad@chromium.org>
  33009. Reviewed by Antti Koivisto.
  33010. Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
  33011. https://bugs.webkit.org/show_bug.cgi?id=23180
  33012. Added a protector for the document potentially holding on the last reference to the loader we are interating with.
  33013. * loader/loader.cpp:
  33014. (WebCore::Loader::Host::didFinishLoading):
  33015. (WebCore::Loader::Host::didFail):
  33016. 2009-02-04 Cary Clark <caryclark@google.com>
  33017. Reviewed by Darin Adler.
  33018. https://bugs.webkit.org/show_bug.cgi?id=23163
  33019. Don't scroll to show current focus on devices that use
  33020. directional pads for navigation.
  33021. * dom/Element.cpp:
  33022. (WebCore::Element::updateFocusAppearance):
  33023. 2009-02-04 Cary Clark <caryclark@google.com>
  33024. Reviewed by Darin Adler.
  33025. Change RenderBlock::columnGap() access permissions from protected to
  33026. public. ANDROID creates an array of focus rectangles for navigation
  33027. with a trackball or directional pad, and needs access to the column gap
  33028. to implement this logic.
  33029. Android has no testing harness @ webkit.org, thus no tests.
  33030. * rendering/RenderBlock.h:
  33031. 2009-02-04 Cary Clark <caryclark@google.com>
  33032. Reviewed by Darin Adler and Eric Seidel.
  33033. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22917
  33034. Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
  33035. platform to select all when focusing on a textarea. This matches
  33036. the user interface guidelines other applications on the platform.
  33037. * html/HTMLTextAreaElement.cpp:
  33038. (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  33039. 2009-02-04 Beth Dakin <bdakin@apple.com>
  33040. Reviewed by Dave Hyatt.
  33041. Fix for <rdar://problem/6386112> Some inline-elements are not
  33042. becoming proper dashboard-regions
  33043. RenderInline needs its own implementation of addDashboardRegions
  33044. because otherwise all of the coordinate calculations are
  33045. inaccurate.
  33046. * rendering/RenderInline.cpp:
  33047. (WebCore::RenderInline::addDashboardRegions):
  33048. * rendering/RenderInline.h:
  33049. * rendering/RenderObject.h:
  33050. 2009-02-04 David Hyatt <hyatt@apple.com>
  33051. Move addChild/removeChild from RenderContainer to RenderObject.
  33052. Reviewed by Sam Weinig
  33053. * rendering/RenderContainer.cpp:
  33054. * rendering/RenderContainer.h:
  33055. * rendering/RenderObject.cpp:
  33056. (WebCore::updateListMarkerNumbers):
  33057. (WebCore::RenderObject::addChild):
  33058. (WebCore::RenderObject::removeChild):
  33059. * rendering/RenderObject.h:
  33060. (WebCore::RenderObject::addChildIgnoringContinuation):
  33061. * rendering/RenderSVGContainer.cpp:
  33062. * rendering/RenderSVGContainer.h:
  33063. 2009-02-04 Brady Eidson <beidson@apple.com>
  33064. Reviewed by Sam Weinig
  33065. <rdar://problem/3541409> - Further HistoryItem / BF cache cleanup
  33066. * history/CachedFrame.cpp:
  33067. (WebCore::CachedFrame::CachedFrame):
  33068. (WebCore::CachedFrame::restore):
  33069. * history/CachedFrame.h:
  33070. * history/CachedPage.cpp:
  33071. (WebCore::CachedPage::restore):
  33072. * history/CachedPage.h:
  33073. (WebCore::CachedPage::mainFrameView):
  33074. * history/HistoryItem.cpp:
  33075. (WebCore::HistoryItem::HistoryItem):
  33076. (WebCore::HistoryItem::~HistoryItem):
  33077. * history/HistoryItem.h:
  33078. (WebCore::HistoryItem::isInPageCache):
  33079. * loader/FrameLoader.cpp:
  33080. (WebCore::FrameLoader::open):
  33081. 2009-02-04 Peter Kasting <pkasting@google.com>
  33082. Reviewed by David Hyatt.
  33083. https://bugs.webkit.org/show_bug.cgi?id=23743
  33084. Fix memory corruption with open-source GIF decoders.
  33085. * platform/image-decoders/ImageDecoder.h:
  33086. (WebCore::RGBA32Buffer::clear):
  33087. * platform/image-decoders/gif/GIFImageDecoder.cpp:
  33088. (WebCore::GIFImageDecoder::clearFrameBufferCache):
  33089. * platform/image-decoders/skia/GIFImageDecoder.cpp:
  33090. (WebCore::GIFImageDecoder::clearFrameBufferCache):
  33091. (WebCore::GIFImageDecoder::initFrameBuffer):
  33092. * platform/image-decoders/skia/ImageDecoder.h:
  33093. (WebCore::RGBA32Buffer::clear):
  33094. 2009-02-04 Simon Fraser <simon.fraser@apple.com>
  33095. Reviewed by Dave Hyatt
  33096. https://bugs.webkit.org/show_bug.cgi?id=23360
  33097. When using accelerated compositing, make repaints use the correct
  33098. repaint container. Hook up the RenderLayerCompositor in RenderView,
  33099. and add to RenderView a method that repaints both the view
  33100. contents, and any intersecting composited layers.
  33101. Make enclosingCompositingLayer() a method on RenderObject, and update
  33102. the compositor to use that. Add a helper method on the compositor to
  33103. get the non-self compositing ancestor: ancestorCompositingLayer().
  33104. Call repaintRectangleInViewAndCompositedLayers() in places that don't do
  33105. container-relative repainting: selection redraw on focus change, caret,
  33106. and widget updates.
  33107. Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
  33108. would get cleared for partial updates, thus preventing subsequent full updates.
  33109. Fix a bug in RenderLayer::ensureBacking() that made new backing every time.
  33110. * WebCore.xcodeproj/project.pbxproj:
  33111. * editing/SelectionController.cpp:
  33112. (WebCore::SelectionController::recomputeCaretRect):
  33113. (WebCore::SelectionController::invalidateCaretRect):
  33114. (WebCore::SelectionController::focusedOrActiveStateChanged):
  33115. * rendering/RenderInline.cpp:
  33116. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  33117. * rendering/RenderLayer.cpp:
  33118. (WebCore::RenderLayer::RenderLayer):
  33119. (WebCore::RenderLayer::compositor):
  33120. (WebCore::RenderLayer::updateLayerPositions):
  33121. (WebCore::RenderLayer::removeChild):
  33122. (WebCore::RenderLayer::ensureBacking):
  33123. * rendering/RenderLayer.h:
  33124. (WebCore::RenderLayer::backing):
  33125. * rendering/RenderLayerBacking.cpp:
  33126. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  33127. (WebCore::RenderLayerBacking::paintIntoLayer):
  33128. (WebCore::RenderLayerBacking::notifyTransitionStarted):
  33129. (WebCore::RenderLayerBacking::notifyAnimationStarted):
  33130. * rendering/RenderLayerCompositor.cpp:
  33131. (WebCore::RenderLayerCompositor::updateCompositingLayers):
  33132. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  33133. (WebCore::RenderLayerCompositor::layerWillBeRemoved):
  33134. (WebCore::RenderLayerCompositor::ancestorCompositingLayer):
  33135. (WebCore::RenderLayerCompositor::clippedByAncestor):
  33136. * rendering/RenderLayerCompositor.h:
  33137. * rendering/RenderObject.cpp:
  33138. (WebCore::RenderObject::enclosingCompositingLayer):
  33139. (WebCore::RenderObject::containingBlockWidth):
  33140. (WebCore::RenderObject::containingBlockHeight):
  33141. (WebCore::RenderObject::containerForRepaint):
  33142. (WebCore::RenderObject::repaintUsingContainer):
  33143. * rendering/RenderObject.h:
  33144. * rendering/RenderView.cpp:
  33145. (WebCore::RenderView::shouldRepaint):
  33146. (WebCore::RenderView::repaintViewRectangle):
  33147. (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
  33148. (WebCore::RenderView::setMaximalOutlineSize):
  33149. (WebCore::RenderView::usesCompositing):
  33150. (WebCore::RenderView::compositor):
  33151. (WebCore::RenderView::didMoveOnscreen):
  33152. (WebCore::RenderView::willMoveOffscreen):
  33153. * rendering/RenderView.h:
  33154. * rendering/RenderWidget.cpp:
  33155. (WebCore::RenderWidget::updateWidgetPosition):
  33156. 2009-02-04 Sam Weinig <sam@webkit.org>
  33157. Reviewed by David Hyatt.
  33158. Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
  33159. is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
  33160. is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.
  33161. * html/HTMLAnchorElement.cpp:
  33162. (WebCore::HTMLAnchorElement::defaultEventHandler):
  33163. * html/HTMLEmbedElement.cpp:
  33164. (WebCore::HTMLEmbedElement::attach):
  33165. * html/HTMLImageElement.cpp:
  33166. (WebCore::HTMLImageElement::parseMappedAttribute):
  33167. (WebCore::HTMLImageElement::attach):
  33168. * html/HTMLInputElement.cpp:
  33169. (WebCore::HTMLInputElement::parseMappedAttribute):
  33170. (WebCore::HTMLInputElement::attach):
  33171. * html/HTMLObjectElement.cpp:
  33172. (WebCore::HTMLObjectElement::attach):
  33173. * html/HTMLVideoElement.cpp:
  33174. (WebCore::HTMLVideoElement::attach):
  33175. * loader/ImageLoader.cpp:
  33176. (WebCore::ImageLoader::setImage):
  33177. (WebCore::ImageLoader::updateFromElement):
  33178. (WebCore::ImageLoader::notifyFinished):
  33179. * page/AccessibilityRenderObject.cpp:
  33180. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  33181. (WebCore::AccessibilityRenderObject::addChildren):
  33182. * page/DragController.cpp:
  33183. (WebCore::getCachedImage):
  33184. (WebCore::getImage):
  33185. * platform/mac/PasteboardMac.mm:
  33186. (WebCore::Pasteboard::writeImage):
  33187. * rendering/RenderImage.h:
  33188. (WebCore::toRenderImage):
  33189. * wml/WMLImageElement.cpp:
  33190. (WebCore::WMLImageElement::parseMappedAttribute):
  33191. (WebCore::WMLImageElement::attach):
  33192. 2009-02-04 Jungshik Shin <jshin@chromium.org>
  33193. Reviewed by Eric Seidel and Dave Hyatt.
  33194. https://bugs.webkit.org/show_bug.cgi?id=20531
  33195. Make alternateFamilyName customized for Windows and Chromium.
  33196. * platform/graphics/FontCache.cpp:
  33197. (WebCore::alternateFamilyName):
  33198. 2009-02-04 Jungshik Shin <jshin@chromium.org>
  33199. Reviewed by Eric Seidel.
  33200. This comes from Chromium patch (http://codereview.chromium.org/17624).
  33201. Add m_disableFontFallback to UniscriberHelper class and set it
  33202. to true when filling up glyph pages for non-BMP code points.
  33203. When it's set true, UniscriberHelper does not do its own font
  33204. fallback. Neither does it do glyph placement. Font fallback
  33205. will be taken care of in the simple script font path and glyph
  33206. placement is not necessary for simple scripts.
  33207. Layout test is missing at the moment due to the lack of freely
  33208. distributable font covering a non-BMP code page. A test page
  33209. is available at http://i18nl10n.com/webkit/nonbmp2.html
  33210. See also https://bugs.webkit.org/show_bug.cgi?id=23602
  33211. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  33212. (WebCore::fillNonBMPGlyphs):
  33213. * platform/graphics/chromium/UniscribeHelper.cpp:
  33214. (WebCore::UniscribeHelper::UniscribeHelper):
  33215. (WebCore::UniscribeHelper::shape):
  33216. (WebCore::UniscribeHelper::fillShapes):
  33217. * platform/graphics/chromium/UniscribeHelper.h:
  33218. (WebCore::UniscribeHelper::setDisableFontFallback):
  33219. 2009-02-04 Sam Weinig <sam@webkit.org>
  33220. Reviewed by David Hyatt.
  33221. Remove some unnecessary #includes of RenderStyle.h
  33222. * css/CSSPrimitiveValueMappings.h:
  33223. * css/SVGCSSComputedStyleDeclaration.cpp:
  33224. * dom/Node.h:
  33225. * rendering/PointerEventsHitRules.h:
  33226. * rendering/RenderImageGeneratedContent.h:
  33227. * rendering/RenderMarquee.h:
  33228. * rendering/RenderScrollbar.h:
  33229. 2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
  33230. Reviewed by Sam Weinig.
  33231. https://bugs.webkit.org/show_bug.cgi?id=23657
  33232. Clean up WebCore/storage IDLs.
  33233. * storage/SQLError.idl: Changed to match spec.
  33234. * storage/SQLResultSet.idl: Changed to match spec.
  33235. * storage/SQLStatementCallback.idl: Removed.
  33236. * storage/SQLStatementErrorCallback.idl: Removed.
  33237. * storage/SQLTransactionCallback.idl: Removed.
  33238. * storage/SQLTransactionErrorCallback.idl: Removed.
  33239. 2009-02-04 David Hyatt <hyatt@apple.com>
  33240. Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.
  33241. Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
  33242. during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
  33243. paint.
  33244. The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
  33245. sure to do only a local setNeedsLayout inside that function.
  33246. Reviewed by Beth Dakin
  33247. * rendering/RenderLayer.cpp:
  33248. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  33249. * rendering/RenderObject.cpp:
  33250. (WebCore::RenderObject::RenderObject):
  33251. * rendering/RenderObject.h:
  33252. (WebCore::RenderObject::isSetNeedsLayoutForbidden):
  33253. (WebCore::RenderObject::setNeedsLayoutIsForbidden):
  33254. (WebCore::RenderObject::setNeedsLayout):
  33255. (WebCore::RenderObject::setChildNeedsLayout):
  33256. (WebCore::RenderObject::markContainingBlocksForLayout):
  33257. * rendering/RenderTable.cpp:
  33258. (WebCore::RenderTable::layout):
  33259. * rendering/RenderTableSection.cpp:
  33260. (WebCore::RenderTableSection::calcRowHeight):
  33261. (WebCore::RenderTableSection::layoutRows):
  33262. 2009-02-04 Sam Weinig <sam@webkit.org>
  33263. Reviewed by David Hyatt.
  33264. Rename RenderStyle::Diff to StyleDifference and move it to
  33265. RenderStyleConstants.h.
  33266. * rendering/RenderBR.cpp:
  33267. (WebCore::RenderBR::styleDidChange):
  33268. * rendering/RenderBR.h:
  33269. * rendering/RenderBlock.cpp:
  33270. (WebCore::RenderBlock::styleWillChange):
  33271. (WebCore::RenderBlock::styleDidChange):
  33272. * rendering/RenderBlock.h:
  33273. * rendering/RenderBox.cpp:
  33274. (WebCore::RenderBox::styleWillChange):
  33275. (WebCore::RenderBox::styleDidChange):
  33276. * rendering/RenderBox.h:
  33277. * rendering/RenderButton.cpp:
  33278. (WebCore::RenderButton::styleWillChange):
  33279. (WebCore::RenderButton::styleDidChange):
  33280. * rendering/RenderButton.h:
  33281. * rendering/RenderFieldset.cpp:
  33282. (WebCore::RenderFieldset::styleDidChange):
  33283. * rendering/RenderFieldset.h:
  33284. * rendering/RenderFileUploadControl.cpp:
  33285. (WebCore::RenderFileUploadControl::styleDidChange):
  33286. * rendering/RenderFileUploadControl.h:
  33287. * rendering/RenderInline.cpp:
  33288. (WebCore::RenderInline::styleDidChange):
  33289. * rendering/RenderInline.h:
  33290. * rendering/RenderLayer.cpp:
  33291. (WebCore::RenderLayer::styleChanged):
  33292. * rendering/RenderLayer.h:
  33293. * rendering/RenderLayerCompositor.cpp:
  33294. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  33295. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  33296. * rendering/RenderLayerCompositor.h:
  33297. * rendering/RenderListBox.cpp:
  33298. (WebCore::RenderListBox::styleDidChange):
  33299. * rendering/RenderListBox.h:
  33300. * rendering/RenderListItem.cpp:
  33301. (WebCore::RenderListItem::styleDidChange):
  33302. * rendering/RenderListItem.h:
  33303. * rendering/RenderListMarker.cpp:
  33304. (WebCore::RenderListMarker::styleWillChange):
  33305. (WebCore::RenderListMarker::styleDidChange):
  33306. * rendering/RenderListMarker.h:
  33307. * rendering/RenderMenuList.cpp:
  33308. (WebCore::RenderMenuList::styleDidChange):
  33309. * rendering/RenderMenuList.h:
  33310. * rendering/RenderObject.cpp:
  33311. (WebCore::RenderObject::setStyle):
  33312. (WebCore::RenderObject::styleWillChange):
  33313. (WebCore::RenderObject::styleDidChange):
  33314. * rendering/RenderObject.h:
  33315. * rendering/RenderReplaced.cpp:
  33316. (WebCore::RenderReplaced::styleDidChange):
  33317. * rendering/RenderReplaced.h:
  33318. * rendering/RenderSVGGradientStop.cpp:
  33319. (WebCore::RenderSVGGradientStop::styleDidChange):
  33320. * rendering/RenderSVGGradientStop.h:
  33321. * rendering/RenderSVGInlineText.cpp:
  33322. (WebCore::RenderSVGInlineText::styleDidChange):
  33323. * rendering/RenderSVGInlineText.h:
  33324. * rendering/RenderScrollbarPart.cpp:
  33325. (WebCore::RenderScrollbarPart::styleWillChange):
  33326. (WebCore::RenderScrollbarPart::styleDidChange):
  33327. * rendering/RenderScrollbarPart.h:
  33328. * rendering/RenderSlider.cpp:
  33329. (WebCore::RenderSlider::styleDidChange):
  33330. * rendering/RenderSlider.h:
  33331. * rendering/RenderTable.cpp:
  33332. (WebCore::RenderTable::styleDidChange):
  33333. * rendering/RenderTable.h:
  33334. * rendering/RenderTableCell.cpp:
  33335. (WebCore::RenderTableCell::styleWillChange):
  33336. (WebCore::RenderTableCell::styleDidChange):
  33337. * rendering/RenderTableCell.h:
  33338. * rendering/RenderTableRow.cpp:
  33339. (WebCore::RenderTableRow::styleWillChange):
  33340. * rendering/RenderTableRow.h:
  33341. * rendering/RenderText.cpp:
  33342. (WebCore::RenderText::styleDidChange):
  33343. * rendering/RenderText.h:
  33344. (WebCore::RenderText::styleWillChange):
  33345. * rendering/RenderTextControl.cpp:
  33346. (WebCore::RenderTextControl::styleDidChange):
  33347. * rendering/RenderTextControl.h:
  33348. * rendering/RenderTextControlSingleLine.cpp:
  33349. (WebCore::RenderTextControlSingleLine::styleDidChange):
  33350. * rendering/RenderTextControlSingleLine.h:
  33351. * rendering/RenderWidget.cpp:
  33352. (WebCore::RenderWidget::styleDidChange):
  33353. * rendering/RenderWidget.h:
  33354. * rendering/style/RenderStyle.cpp:
  33355. (WebCore::RenderStyle::diff):
  33356. (WebCore::RenderStyle::setClip):
  33357. * rendering/style/RenderStyle.h:
  33358. * rendering/style/RenderStyleConstants.h:
  33359. (WebCore::):
  33360. 2009-02-03 Sam Weinig <sam@webkit.org>
  33361. Reviewed by David Hyatt.
  33362. Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h
  33363. * css/CSSStyleSelector.cpp:
  33364. (WebCore::CSSStyleSelector::matchRulesForList):
  33365. (WebCore::CSSStyleSelector::initForStyleResolve):
  33366. (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
  33367. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  33368. (WebCore::CSSStyleSelector::styleForElement):
  33369. (WebCore::CSSStyleSelector::pseudoStyleForElement):
  33370. (WebCore::CSSStyleSelector::checkSelector):
  33371. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  33372. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  33373. (WebCore::CSSStyleSelector::applyProperty):
  33374. * css/CSSStyleSelector.h:
  33375. * dom/Node.cpp:
  33376. (WebCore::Node::diff):
  33377. * page/FrameView.cpp:
  33378. (WebCore::FrameView::createScrollbar):
  33379. * rendering/InlineTextBox.cpp:
  33380. (WebCore::InlineTextBox::paint):
  33381. * rendering/MediaControlElements.cpp:
  33382. (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
  33383. (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement):
  33384. (WebCore::MediaControlInputElement::MediaControlInputElement):
  33385. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
  33386. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
  33387. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
  33388. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
  33389. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
  33390. * rendering/MediaControlElements.h:
  33391. * rendering/RenderBlock.cpp:
  33392. (WebCore::RenderBlock::styleDidChange):
  33393. (WebCore::RenderBlock::updateBeforeAfterContent):
  33394. (WebCore::RenderBlock::firstLineBlock):
  33395. (WebCore::RenderBlock::updateFirstLetter):
  33396. * rendering/RenderBlock.h:
  33397. * rendering/RenderBox.cpp:
  33398. (WebCore::RenderBox::isAfterContent):
  33399. * rendering/RenderButton.cpp:
  33400. (WebCore::RenderButton::updateBeforeAfterContent):
  33401. * rendering/RenderButton.h:
  33402. * rendering/RenderFileUploadControl.cpp:
  33403. (WebCore::RenderFileUploadControl::createButtonStyle):
  33404. * rendering/RenderInline.cpp:
  33405. (WebCore::RenderInline::styleDidChange):
  33406. (WebCore::isAfterContent):
  33407. (WebCore::RenderInline::addChildIgnoringContinuation):
  33408. (WebCore::RenderInline::splitInlines):
  33409. * rendering/RenderLayer.cpp:
  33410. (WebCore::RenderLayer::createScrollbar):
  33411. (WebCore::RenderLayer::updateScrollCornerStyle):
  33412. (WebCore::RenderLayer::updateResizerStyle):
  33413. * rendering/RenderListBox.cpp:
  33414. (WebCore::RenderListBox::createScrollbar):
  33415. * rendering/RenderMedia.cpp:
  33416. (WebCore::RenderMedia::createPanel):
  33417. (WebCore::RenderMedia::createTimelineContainer):
  33418. * rendering/RenderMenuList.cpp:
  33419. (WebCore::RenderMenuList::createScrollbar):
  33420. * rendering/RenderObject.cpp:
  33421. (WebCore::RenderObject::selectionBackgroundColor):
  33422. (WebCore::RenderObject::selectionForegroundColor):
  33423. (WebCore::RenderObject::firstLineStyleSlowCase):
  33424. (WebCore::RenderObject::getCachedPseudoStyle):
  33425. (WebCore::RenderObject::getUncachedPseudoStyle):
  33426. * rendering/RenderObject.h:
  33427. (WebCore::RenderObject::isAnonymousBlock):
  33428. * rendering/RenderObjectChildList.cpp:
  33429. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
  33430. (WebCore::beforeAfterContainer):
  33431. (WebCore::RenderObjectChildList::invalidateCounters):
  33432. (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  33433. * rendering/RenderObjectChildList.h:
  33434. * rendering/RenderScrollbar.cpp:
  33435. (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
  33436. (WebCore::pseudoForScrollbarPart):
  33437. * rendering/RenderScrollbar.h:
  33438. * rendering/RenderSlider.cpp:
  33439. (WebCore::RenderSlider::createThumbStyle):
  33440. * rendering/RenderTextControlSingleLine.cpp:
  33441. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  33442. (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
  33443. (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
  33444. (WebCore::RenderTextControlSingleLine::createScrollbar):
  33445. * rendering/style/RenderStyle.cpp:
  33446. (WebCore::pseudoBit):
  33447. * rendering/style/RenderStyle.h:
  33448. (WebCore::):
  33449. * rendering/style/RenderStyleConstants.h:
  33450. (WebCore::):
  33451. 2009-02-04 David Kilzer <ddkilzer@apple.com>
  33452. CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
  33453. <rdar://problem/6509514>
  33454. Reviewed by Mark Rowe.
  33455. * loader/archive/cf/LegacyWebArchive.cpp:
  33456. (WebCore::LegacyWebArchive::create): Fix it correctly this time.
  33457. Check for the value returned from WebCore::IconDatabase::iconForPageURL(),
  33458. not WebCore::Image::data().
  33459. 2009-02-04 David Hyatt <hyatt@apple.com>
  33460. Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.
  33461. Reviewed by Adam Roben
  33462. * rendering/RenderBox.cpp:
  33463. (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
  33464. (WebCore::RenderBox::styleWillChange):
  33465. * rendering/RenderBox.h:
  33466. * rendering/RenderContainer.cpp:
  33467. (WebCore::RenderContainer::removeChild):
  33468. * rendering/RenderObject.cpp:
  33469. (WebCore::RenderObject::styleWillChange):
  33470. * rendering/RenderObject.h:
  33471. * rendering/RenderSVGContainer.cpp:
  33472. (WebCore::RenderSVGContainer::removeChild):
  33473. 2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
  33474. Reviewed by Dave Hyatt.
  33475. https://bugs.webkit.org/show_bug.cgi?id=23471
  33476. Fix text-overflow:ellipsis; for RTL case.
  33477. Test: fast/css/text-overflow-ellipses.html
  33478. * rendering/InlineTextBox.cpp:
  33479. (WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement.
  33480. (WebCore::InlineTextBox::paintDecoration): Correctly draw decorations
  33481. for rtl truncation.
  33482. 2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
  33483. Reviewed by Darin Adler.
  33484. https://bugs.webkit.org/show_bug.cgi?id=23700
  33485. Upstream local changes to due to unforking of SimpleFontData
  33486. (corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).
  33487. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  33488. (WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
  33489. 2009-02-04 David Hyatt <hyatt@apple.com>
  33490. <rdar://problem/6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook
  33491. Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
  33492. because, like, they point to a lot of stuff... like ... everything...
  33493. Reviewed by Darin Adler
  33494. * dom/Document.cpp:
  33495. (WebCore::Document::removeAllEventListenersFromAllNodes):
  33496. 2009-02-04 Darin Fisher <darin@chromium.org>
  33497. Reviewed by Darin Adler.
  33498. https://bugs.webkit.org/show_bug.cgi?id=23731
  33499. Add JSCCustom and V8Custom as extended IDL attributes
  33500. This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.
  33501. * bindings/scripts/CodeGeneratorJS.pm:
  33502. * dom/Document.idl:
  33503. * dom/Node.idl:
  33504. * svg/SVGPathSegList.idl:
  33505. * svg/SVGPointList.idl:
  33506. * svg/SVGTransformList.idl:
  33507. 2009-02-04 Dan Bernstein <mitz@apple.com>
  33508. - build fix
  33509. * rendering/RenderImageGeneratedContent.h:
  33510. 2009-02-04 miggilin <mr.diggilin@gmail.com>
  33511. Reviewed by Kevin Ollivier.
  33512. Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
  33513. with assigning to uninitialized HashTable buckets.
  33514. https://bugs.webkit.org/show_bug.cgi?id=23669
  33515. * platform/graphics/SimpleFontData.h:
  33516. (WebCore::SimpleFontData::getWxFont):
  33517. * platform/graphics/wx/FontPlatformData.h:
  33518. (WebCore::):
  33519. (WebCore::FontPlatformData::FontPlatformData):
  33520. (WebCore::FontPlatformData::font):
  33521. (WebCore::FontPlatformData::operator==):
  33522. * platform/graphics/wx/FontPlatformDataWx.cpp:
  33523. (WebCore::FontPlatformData::FontPlatformData):
  33524. (WebCore::FontPlatformData::computeHash):
  33525. (WebCore::FontPlatformData::~FontPlatformData):
  33526. * platform/graphics/wx/SimpleFontDataWx.cpp:
  33527. (WebCore::SimpleFontData::platformInit):
  33528. (WebCore::SimpleFontData::determinePitch):
  33529. (WebCore::SimpleFontData::platformWidthForGlyph):
  33530. * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
  33531. (WebCore::drawTextWithSpacing):
  33532. 2009-02-04 David Hyatt <hyatt@apple.com>
  33533. Fix a crash in generated content when a generated image with an already-cached background image gets
  33534. created. It's not completely clear how to reproduce this crash.
  33535. Reviewed by Adam Roben
  33536. * rendering/RenderImageGeneratedContent.h:
  33537. (WebCore::RenderImageGeneratedContent::imagePtr):
  33538. 2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>
  33539. Unreviewed Qt build fix.
  33540. Changed ASSERT(image) to ASSERT(!image.isNull()).
  33541. * platform/graphics/qt/ImageBufferQt.cpp:
  33542. (WebCore::ImageBuffer::getImageData):
  33543. 2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>
  33544. Reviewed by Simon Hausmann.
  33545. Fix implementation of PluginViewMac::invalidateRect to update only the
  33546. specified rect, not the entire browser window.
  33547. * plugins/mac/PluginViewMac.cpp:
  33548. (WebCore::PluginView::invalidateRect):
  33549. 2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
  33550. Rubber stamped by Mark Rowe.
  33551. FramePrivate was removed in r40024 remove the forward
  33552. declaration as well.
  33553. * page/Frame.h:
  33554. 2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
  33555. Reviewed by Sam Weinig.
  33556. https://bugs.webkit.org/show_bug.cgi?id=23426
  33557. Make isFrameSet virtual and by default return false. Reimplement
  33558. it in HTMLDocument.
  33559. * dom/Document.cpp:
  33560. * dom/Document.h:
  33561. (WebCore::Document::isFrameSet):
  33562. * html/HTMLDocument.cpp:
  33563. (WebCore::HTMLDocument::isFrameSet):
  33564. * html/HTMLDocument.h:
  33565. 2009-02-03 Oliver Hunt <oliver@apple.com>
  33566. Reviewed by John Sullivan.
  33567. <rdar://problem/6554092> Slow script dialog starts coming up over and over again
  33568. Work around <rdar://problem/6554067> by consuming any exceptions that are
  33569. thrown by _web_localizedDescription
  33570. * platform/network/mac/ResourceErrorMac.mm:
  33571. (WebCore::ResourceError::platformLazyInit):
  33572. 2009-02-03 David Hyatt <hyatt@apple.com>
  33573. Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
  33574. versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
  33575. functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
  33576. availableWidth/Height.
  33577. Reviewed by Mark Rowe
  33578. * dom/Element.cpp:
  33579. (WebCore::Element::clientWidth):
  33580. (WebCore::Element::clientHeight):
  33581. (WebCore::Element::scrollWidth):
  33582. (WebCore::Element::scrollHeight):
  33583. * rendering/RenderBox.cpp:
  33584. (WebCore::RenderBox::clientWidth):
  33585. (WebCore::RenderBox::clientHeight):
  33586. (WebCore::RenderBox::scrollWidth):
  33587. (WebCore::RenderBox::scrollHeight):
  33588. 2009-02-03 Brad Garcia <bgarcia@google.com>
  33589. Reviewed by Eric Seidel.
  33590. https://bugs.webkit.org/show_bug.cgi?id=20443
  33591. Remove call to canResize when trying to determine if pointer
  33592. is within a frame.
  33593. Also removed the implementation of canResize as it is no longer used.
  33594. Test: fast/frames/frame-dead-region.html
  33595. * rendering/RenderFrameSet.cpp:
  33596. (WebCore::RenderFrameSet::nodeAtPoint):
  33597. * rendering/RenderFrameSet.h:
  33598. 2009-02-03 David Hyatt <hyatt@apple.com>
  33599. Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
  33600. This is a small gain on the PLT.
  33601. Reviewed by Mark Rowe
  33602. * rendering/bidi.cpp:
  33603. (WebCore::inlineWidth):
  33604. (WebCore::bidiNext):
  33605. 2009-02-03 Simon Fraser <simon.fraser@apple.com>
  33606. Reviewed by Dave Hyatt
  33607. https://bugs.webkit.org/show_bug.cgi?id=23628
  33608. Fix selection repainting to do container-relative repaints. RenderView now
  33609. repaints the selection using the containerForRepaint() for each RenderSelectionInfo.
  33610. selectionRect() is now a wrapper for selectionRectForRepaint() with no container.
  33611. Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
  33612. of RenderBlock.h and move them into RenderSelectionInfo.h, with some
  33613. sharing and refactoring.
  33614. RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.
  33615. * GNUmakefile.am:
  33616. * WebCore.vcproj/WebCore.vcproj:
  33617. * WebCore.xcodeproj/project.pbxproj:
  33618. * rendering/RenderBR.h:
  33619. (WebCore::RenderBR::selectionRectForRepaint):
  33620. * rendering/RenderBlock.cpp:
  33621. (WebCore::RenderBlock::selectionGapRectsForRepaint):
  33622. * rendering/RenderBlock.h:
  33623. (WebCore::RenderBlock::selectionRectForRepaint):
  33624. * rendering/RenderListMarker.cpp:
  33625. (WebCore::RenderListMarker::paint):
  33626. (WebCore::RenderListMarker::selectionRectForRepaint):
  33627. * rendering/RenderListMarker.h:
  33628. * rendering/RenderObject.h:
  33629. (WebCore::RenderObject::selectionRect):
  33630. (WebCore::RenderObject::selectionRectForRepaint):
  33631. * rendering/RenderReplaced.cpp:
  33632. (WebCore::RenderReplaced::selectionRectForRepaint):
  33633. * rendering/RenderReplaced.h:
  33634. * rendering/RenderSVGInlineText.cpp:
  33635. (WebCore::RenderSVGInlineText::absoluteRects):
  33636. (WebCore::RenderSVGInlineText::absoluteQuads):
  33637. (WebCore::RenderSVGInlineText::selectionRectForRepaint):
  33638. (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  33639. * rendering/RenderSVGInlineText.h:
  33640. * rendering/RenderSelectionInfo.h: Added.
  33641. (WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
  33642. (WebCore::RenderSelectionInfoBase::object):
  33643. (WebCore::RenderSelectionInfoBase::repaintContainer):
  33644. (WebCore::RenderSelectionInfoBase::state):
  33645. (WebCore::RenderSelectionInfo::RenderSelectionInfo):
  33646. (WebCore::RenderSelectionInfo::repaint):
  33647. (WebCore::RenderSelectionInfo::rect):
  33648. (WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
  33649. (WebCore::RenderBlockSelectionInfo::repaint):
  33650. (WebCore::RenderBlockSelectionInfo::block):
  33651. (WebCore::RenderBlockSelectionInfo::rects):
  33652. * rendering/RenderText.cpp:
  33653. (WebCore::RenderText::selectionRectForRepaint):
  33654. * rendering/RenderText.h:
  33655. * rendering/RenderView.cpp:
  33656. (WebCore::RenderView::selectionBounds):
  33657. (WebCore::RenderView::setSelection):
  33658. * rendering/RenderView.h:
  33659. * rendering/RenderWidget.cpp:
  33660. (WebCore::RenderWidget::paint):
  33661. 2009-02-03 David Hyatt <hyatt@apple.com>
  33662. Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.
  33663. Reviewed by Darin Adler & Sam Weinig
  33664. * css/CSSMutableStyleDeclaration.cpp:
  33665. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  33666. * css/CSSMutableStyleDeclaration.h:
  33667. 2009-02-03 Justin Garcia <justin.garcia@apple.com>
  33668. Reviewed by Darin Adler.
  33669. https://bugs.webkit.org/show_bug.cgi?id=13490
  33670. Implement execCommand("styleWithCSS", ...)
  33671. Determine whether or not to use HTML formatting tags for styling on the new
  33672. boolean on Editor instead of whether or not the document is quirks mode.
  33673. * editing/ApplyStyleCommand.cpp:
  33674. (WebCore::StyleChange::StyleChange):
  33675. (WebCore::StyleChange::init):
  33676. (WebCore::ApplyStyleCommand::applyBlockStyle):
  33677. (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
  33678. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  33679. * editing/Editor.cpp:
  33680. (WebCore::Editor::Editor):
  33681. (WebCore::Editor::clear):
  33682. * editing/Editor.h:
  33683. (WebCore::Editor::setShouldStyleWithCSS):
  33684. (WebCore::Editor::shouldStyleWithCSS):
  33685. * editing/EditorCommand.cpp:
  33686. (WebCore::executeStyleWithCSS):
  33687. (WebCore::stateStyleWithCSS):
  33688. (WebCore::CommandEntry::):
  33689. 2009-02-03 Dirk Schulze <krit@webkit.org>
  33690. Reviewed by Sam Weinig.
  33691. This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
  33692. * platform/graphics/qt/ImageBufferQt.cpp:
  33693. (WebCore::ImageBuffer::getImageData):
  33694. 2009-02-03 Anders Carlsson <andersca@apple.com>
  33695. Reviewed by Kevin Decker.
  33696. - Fix for <rdar://problem/6549743>
  33697. On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
  33698. after the call to -[NSView displayRectIgnoringOpacity:inContext:].
  33699. * platform/mac/WidgetMac.mm:
  33700. (WebCore::Widget::paint):
  33701. 2009-02-03 David Hyatt <hyatt@apple.com>
  33702. Back this change out since it is causing layout tests to crash. There is something subtle going on
  33703. here.
  33704. Reviewed by Darin Adler
  33705. * css/CSSMutableStyleDeclaration.cpp:
  33706. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  33707. * css/CSSMutableStyleDeclaration.h:
  33708. 2009-02-03 David Hyatt <hyatt@apple.com>
  33709. Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.
  33710. Reviewed by Sam Weinig
  33711. * css/CSSMutableStyleDeclaration.cpp:
  33712. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  33713. * css/CSSMutableStyleDeclaration.h:
  33714. 2009-02-03 David Hyatt <hyatt@apple.com>
  33715. Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
  33716. as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
  33717. Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.
  33718. Reviewed by Darin Adler
  33719. * loader/FrameLoader.cpp:
  33720. (WebCore::FrameLoader::addExtraFieldsToRequest):
  33721. * platform/KURL.cpp:
  33722. (WebCore::KURL::invalidate):
  33723. (WebCore::KURL::KURL):
  33724. * platform/KURL.h:
  33725. (WebCore::KURL::isHTTPOrHTTPS):
  33726. * platform/network/ResourceRequestBase.cpp:
  33727. (WebCore::ResourceRequestBase::setCachePolicy):
  33728. (WebCore::ResourceRequestBase::setTimeoutInterval):
  33729. (WebCore::ResourceRequestBase::setMainDocumentURL):
  33730. (WebCore::ResourceRequestBase::setHTTPMethod):
  33731. (WebCore::ResourceRequestBase::setHTTPHeaderField):
  33732. (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
  33733. (WebCore::ResourceRequestBase::setHTTPBody):
  33734. (WebCore::ResourceRequestBase::setAllowHTTPCookies):
  33735. 2009-02-03 Xan Lopez <xan@gnome.org>
  33736. Reviewed by Holger Freyther.
  33737. https://bugs.webkit.org/show_bug.cgi?id=23711
  33738. Add manual test for floating divs with scrollbars.
  33739. * manual-tests/gtk/floatingdiv.html: Added.
  33740. 2009-02-03 Xan Lopez <xan@gnome.org>
  33741. Reviewed by Holger Freyther.
  33742. https://bugs.webkit.org/show_bug.cgi?id=23711
  33743. There's no need to hold an extra ref to the scrollbar, calling
  33744. setPlatformWidget takes ownership of it.
  33745. Also do not disconnect the signals when destroying the widget,
  33746. it's superfluous.
  33747. * platform/gtk/ScrollbarGtk.cpp:
  33748. (ScrollbarGtk::ScrollbarGtk):
  33749. * platform/gtk/ScrollbarGtk.h:
  33750. 2009-02-03 Xan Lopez <xan@gnome.org>
  33751. Reviewed by Holger Freyther.
  33752. https://bugs.webkit.org/show_bug.cgi?id=23711
  33753. Declare scrollBar as GtkWidget* to avoid needless
  33754. casting.
  33755. * platform/gtk/ScrollbarGtk.cpp:
  33756. (ScrollbarGtk::ScrollbarGtk):
  33757. (ScrollbarGtk::~ScrollbarGtk):
  33758. 2009-02-03 Xan Lopez <xan@gnome.org>
  33759. Reviewed by Holger Freyther.
  33760. https://bugs.webkit.org/show_bug.cgi?id=23711
  33761. Properly calculate the scrollbar location for their
  33762. usage in RenderLayout.
  33763. * platform/gtk/ScrollbarGtk.cpp:
  33764. (ScrollbarGtk::frameRectsChanged):
  33765. 2009-02-03 David Hyatt <hyatt@apple.com>
  33766. Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
  33767. of these methods up to RenderObject.
  33768. Reviewed by Beth Dakin
  33769. * bindings/objc/DOM.mm:
  33770. (-[DOMNode lineBoxRects]):
  33771. * dom/Range.cpp:
  33772. (WebCore::Range::addLineBoxRects):
  33773. * inspector/InspectorController.cpp:
  33774. (WebCore::InspectorController::drawNodeHighlight):
  33775. * rendering/RenderContainer.cpp:
  33776. * rendering/RenderContainer.h:
  33777. * rendering/RenderObject.cpp:
  33778. (WebCore::RenderObject::absoluteRectsForRange):
  33779. (WebCore::RenderObject::absoluteQuadsForRange):
  33780. * rendering/RenderObject.h:
  33781. * rendering/RenderText.cpp:
  33782. (WebCore::RenderText::absoluteRectsForRange):
  33783. (WebCore::RenderText::absoluteQuadsForRange):
  33784. * rendering/RenderText.h:
  33785. 2009-02-03 Dirk Schulze <krit@webkit.org>
  33786. Reviewed by Sam Weinig and Oliver Hunt.
  33787. Added getImageData() support for QtWebKit.
  33788. [QT] lacks getImageData / putImageData support in Canvas
  33789. https://bugs.webkit.org/show_bug.cgi?id=22186
  33790. * platform/graphics/qt/ImageBufferQt.cpp:
  33791. (WebCore::ImageBuffer::getImageData):
  33792. 2009-02-03 Eric Roman <eroman@chromium.org>
  33793. Reviewed by Holger Freyther.
  33794. Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.
  33795. * page/chromium/FrameChromium.cpp:
  33796. (WebCore::computePageRectsForFrame):
  33797. 2009-02-02 Simon Fraser <simon.fraser@apple.com>
  33798. Reviewed by Dave Hyatt
  33799. https://bugs.webkit.org/show_bug.cgi?id=23358
  33800. Hook accelerated compositing into RenderLayer.
  33801. * rendering/RenderLayer.cpp:
  33802. (WebCore::RenderLayer::RenderLayer):
  33803. (WebCore::RenderLayer::~RenderLayer):
  33804. Init and clean up backing and the hasCompositingDescendant bit.
  33805. (WebCore::RenderLayer::compositor):
  33806. Shortcut to get to the RenderLayerCompositor.
  33807. (WebCore::RenderLayer::updateLayerPositions):
  33808. We need to let full repaints propagate to all compositing layers, and
  33809. update the backing after layout here.
  33810. (WebCore::RenderLayer::transparentAncestor):
  33811. (WebCore::transparencyClipBox):
  33812. (WebCore::RenderLayer::beginTransparencyLayers):
  33813. Account for the fact that opacity may be rendered via the compositing
  33814. layer sometimes.
  33815. (WebCore::RenderLayer::addChild):
  33816. (WebCore::RenderLayer::removeChild):
  33817. (WebCore::RenderLayer::removeOnlyThisLayer):
  33818. Tell the compositor when the RenderLayer hierarchy changes.
  33819. (WebCore::RenderLayer::scrollToOffset):
  33820. Update layer geometry after scrolling.
  33821. (WebCore::RenderLayer::paintLayer):
  33822. We short-circuit painting on composited layers, because these layers
  33823. are painted on a callback from the compositing system.
  33824. (WebCore::RenderLayer::hitTestLayer):
  33825. Only apply transforms if we are rendering them in software.
  33826. (WebCore::RenderLayer::localBoundingBox):
  33827. (WebCore::RenderLayer::boundingBox):
  33828. (WebCore::RenderLayer::absoluteBoundingBox):
  33829. Refactor bounding box code that we can compute local, and ancestor-relative
  33830. bounding box, as well as absolute.
  33831. (WebCore::RenderLayer::ensureBacking):
  33832. (WebCore::RenderLayer::clearBacking):
  33833. RenderLayerBacking creation and destruction.
  33834. (WebCore::RenderLayer::setParent):
  33835. Tell the compositor when the RenderLayer hierarchy changes.
  33836. (WebCore::RenderLayer::dirtyZOrderLists):
  33837. (WebCore::RenderLayer::dirtyStackingContextZOrderLists):
  33838. (WebCore::RenderLayer::dirtyOverflowList):
  33839. When the z-order and overflow lists change, we need to tell the
  33840. compositor that the composited layers need to be rejiggered soon.
  33841. (WebCore::RenderLayer::updateZOrderLists):
  33842. Whitespace cleanup.
  33843. (WebCore::RenderLayer::setBackingNeedsRepaint):
  33844. (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
  33845. Dirty composited layer contents for painting.
  33846. (WebCore::RenderLayer::styleChanged):
  33847. Update the layer backing after style changes.
  33848. * rendering/RenderLayer.h:
  33849. (WebCore::RenderLayer::isComposited):
  33850. (WebCore::RenderLayer::backing):
  33851. Accessors for testing and getting the backing for this RenderLayer.
  33852. (WebCore::RenderLayer::paintsWithTransparency):
  33853. (WebCore::RenderLayer::paintsWithTransform):
  33854. Transform and opacity can be applied via the compositing layer, or rendered
  33855. in software. These methods tell us if we need to account for them in the
  33856. non-compositing path.
  33857. (WebCore::RenderLayer::hasCompositingDescendant):
  33858. (WebCore::RenderLayer::setHasCompositingDescendant):
  33859. Maintain a bit to tell if this layer has composited descendants.
  33860. 2009-02-03 Simon Fraser <simon.fraser@apple.com>
  33861. Reviewed by Dave Hyatt
  33862. https://bugs.webkit.org/show_bug.cgi?id=23365
  33863. Hook up accelerated compositing layers the native
  33864. view system on Mac.
  33865. * WebCore.base.exp:
  33866. Export new Page methods.
  33867. * page/ChromeClient.h:
  33868. (WebCore::ChromeClient::attachRootGraphicsLayer):
  33869. (WebCore::ChromeClient::setNeedsOneShotDrawingSynchronization):
  33870. New methods for attaching/detaching the root GraphicsLayer, and
  33871. synchronizing layer changes with window drawing.
  33872. * page/FrameView.h:
  33873. * page/FrameView.cpp:
  33874. (WebCore::FrameView::updateCompositingLayers):
  33875. (WebCore::FrameView::setNeedsOneShotDrawingSynchronization):
  33876. (WebCore::FrameView::didMoveOnscreen):
  33877. (WebCore::FrameView::willMoveOffscreen):
  33878. New methods to update the compositing layer hierarchy,
  33879. and pass-throughs to the RenderLayerCompositor.
  33880. (WebCore::FrameView::layout):
  33881. Update compositing layers after layout() and updateLayerPositions().
  33882. * page/Page.cpp:
  33883. (WebCore::Page::didMoveOnscreen):
  33884. (WebCore::Page::willMoveOffscreen):
  33885. * page/Page.h:
  33886. New methods to allow the native view system to tell the Page when it
  33887. starts to be presented on-screen, and when it will be hidden.
  33888. * rendering/RenderLayerCompositor.h:
  33889. * rendering/RenderLayerCompositor.cpp:
  33890. (WebCore::RenderLayerCompositor::updateLayerCompositingState):
  33891. (WebCore::RenderLayerCompositor::didMoveOnscreen):
  33892. (WebCore::RenderLayerCompositor::willMoveOffscreen):
  33893. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  33894. Rename 'attached' methods to 'moveOnscreen/moveOffscreen' to match
  33895. the calls through from Page, FrameView.
  33896. (WebCore::RenderLayerCompositor::layerWillBeRemoved):
  33897. Dont' try to repaint or update layers if the document is being torn
  33898. down.
  33899. * rendering/RenderView.cpp:
  33900. (WebCore::RenderView::didMoveOnscreen):
  33901. (WebCore::RenderView::willMoveOffscreen):
  33902. * rendering/RenderView.h:
  33903. New methods.
  33904. 2009-02-03 Dirk Schulze <krit@webkit.org>
  33905. Reviewed by Holger Hans Peter Freyther.
  33906. Fixed getImageData and putImageData and respect pre-
  33907. multiplied colors.
  33908. Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
  33909. https://bugs.webkit.org/show_bug.cgi?id=21575
  33910. * platform/graphics/cairo/ImageBufferCairo.cpp:
  33911. (WebCore::ImageBuffer::getImageData):
  33912. (WebCore::ImageBuffer::putImageData):
  33913. 2009-02-03 Dan Bernstein <mitz@apple.com>
  33914. Reviewed by Brady Eidson.
  33915. - fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
  33916. Test: fast/history/window-open.html
  33917. * bindings/js/JSDOMWindowBase.cpp:
  33918. (WebCore::createWindow): Pass the missing lockBackForwardList parameter
  33919. to FrameLoader::changeLocation().
  33920. 2009-02-03 Adam Treat <adam.treat@torchmobile.com>
  33921. Fix the Qt build after r40536.
  33922. * bridge/qt/qt_runtime.cpp:
  33923. (JSC::Bindings::convertQVariantToValue):
  33924. 2009-02-03 Dan Bernstein <mitz@apple.com>
  33925. - fix -Wmissing-prototypes builds
  33926. * loader/WorkerThreadableLoader.cpp:
  33927. (WebCore::workerContextDidSendData): Marked this function static.
  33928. (WebCore::workerContextDidReceiveResponse): Ditto.
  33929. (WebCore::workerContextDidReceiveData): Ditto.
  33930. (WebCore::workerContextDidFinishLoading): Ditto.
  33931. (WebCore::workerContextDidFail): Ditto.
  33932. (WebCore::workerContextDidGetCancelled): Ditto.
  33933. (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
  33934. 2009-02-03 David Kilzer <ddkilzer@apple.com>
  33935. CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
  33936. <rdar://problem/6509514>
  33937. Reviewed by Adam Roben.
  33938. * loader/archive/cf/LegacyWebArchive.cpp:
  33939. (WebCore::LegacyWebArchive::create): Null check the value returned
  33940. from WebCore::IconDatabase::iconForPageURL().
  33941. 2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
  33942. Reviewed by Tor Arne Vestbø.
  33943. Fix conversion of QByteArray to JavaScript and back. Instead of
  33944. converting it to a String (data loss!) we now map it to JSByteArray.
  33945. * bridge/qt/qt_runtime.cpp:
  33946. (JSC::Bindings::):
  33947. (JSC::Bindings::valueRealType): Added JSByteArray as converstion type.
  33948. (JSC::Bindings::convertValueToQVariant): Convert from JSByteArray to
  33949. QVariant(QByteArray).
  33950. (JSC::Bindings::convertQVariantToValue): Convert from
  33951. QVariant::ByteArray to jsByteArray.
  33952. 2009-02-03 Alexey Proskuryakov <ap@webkit.org>
  33953. Build fix.
  33954. * GNUmakefile.am: Removed WorkerTask.{h,cpp}.
  33955. 2009-02-03 Dmitry Titov <dimich@chromium.org>
  33956. Reviewed by Alexey Proskuryakov.
  33957. https://bugs.webkit.org/show_bug.cgi?id=22718
  33958. Implement WindowTimers interface in Workers.
  33959. This patch moves timeoutID from Document to ScriptExecutionContext
  33960. and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
  33961. Also added a test for those methods.
  33962. Test: fast/workers/worker-timeout.html
  33963. * bindings/js/JSWorkerContextCustom.cpp:
  33964. (WebCore::setTimeoutOrInterval):
  33965. Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.
  33966. (WebCore::JSWorkerContext::setTimeout):
  33967. (WebCore::JSWorkerContext::clearTimeout):
  33968. (WebCore::JSWorkerContext::setInterval):
  33969. (WebCore::JSWorkerContext::clearInterval):
  33970. Added methods exposed to JS.
  33971. * dom/Document.cpp:
  33972. * dom/Document.h:
  33973. * dom/ScriptExecutionContext.cpp:
  33974. (WebCore::ScriptExecutionContext::addTimeout):
  33975. (WebCore::ScriptExecutionContext::removeTimeout):
  33976. (WebCore::ScriptExecutionContext::findTimeout):
  33977. * dom/ScriptExecutionContext.h:
  33978. The timerID map moves from Document to ScriptExecutionContext,
  33979. to be available to Document and to WorkerContext.
  33980. * dom/WorkerContext.cpp:
  33981. (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout.
  33982. (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
  33983. * dom/WorkerContext.h:
  33984. * page/DOMTimer.cpp:
  33985. (WebCore::DOMTimer::DOMTimer):
  33986. (WebCore::DOMTimer::~DOMTimer):
  33987. (WebCore::DOMTimer::removeById):
  33988. Code change here reflects move of timeoutID map to the ScriptExecutionContext.
  33989. Some checks and casts are no longer needed.
  33990. 2009-02-03 Dmitry Titov <dimich@chromium.org>
  33991. Reviewed by Alexey Proskuryakov.
  33992. https://bugs.webkit.org/show_bug.cgi?id=23560
  33993. Implement SharedTimer for Workers.
  33994. * dom/WorkerRunLoop.cpp:
  33995. Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads.
  33996. (WebCore::WorkerSharedTimer::WorkerSharedTimer):
  33997. (WebCore::WorkerSharedTimer::setFiredFunction):
  33998. (WebCore::WorkerSharedTimer::setFireTime):
  33999. (WebCore::WorkerSharedTimer::stop):
  34000. (WebCore::WorkerSharedTimer::isActive):
  34001. (WebCore::WorkerSharedTimer::fireTime):
  34002. (WebCore::WorkerSharedTimer::fire):
  34003. (WebCore::WorkerRunLoop::WorkerRunLoop):
  34004. Initializes a WorkerSharedTimer instance.
  34005. (WebCore::WorkerRunLoop::~WorkerRunLoop):
  34006. The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer.
  34007. (WebCore::WorkerRunLoop::run):
  34008. Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
  34009. * dom/WorkerRunLoop.h:
  34010. Add member of type OwnPtr<WorkerSharedTimer>
  34011. 2009-02-03 Steve Falkenburg <sfalken@apple.com>
  34012. Build fix.
  34013. * WebCore.vcproj/WebCore.vcproj:
  34014. 2009-02-03 Alexey Proskuryakov <ap@webkit.org>
  34015. Windows build fix.
  34016. * dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where
  34017. appropriate.
  34018. 2009-02-02 David Levin <levin@chromium.org>
  34019. Reviewed by Alexey Proskuryakov.
  34020. Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
  34021. <https://bugs.webkit.org/show_bug.cgi?id=23636>
  34022. Enable the async portion of ThreadableLoader for workers.
  34023. No observable change in behavior, so no test.
  34024. * GNUmakefile.am:
  34025. * WebCore.pro:
  34026. * WebCore.scons:
  34027. * WebCore.vcproj/WebCore.vcproj:
  34028. * WebCore.xcodeproj/project.pbxproj:
  34029. * WebCoreSources.bkl:
  34030. * dom/CrossThreadCopier.h:
  34031. * dom/GenericWorkerTask.h:
  34032. * dom/WorkerThread.cpp:
  34033. * loader/ThreadableLoader.cpp:
  34034. (WebCore::ThreadableLoader::create):
  34035. * loader/ThreadableLoaderClient.h:
  34036. (WebCore::ThreadableLoaderClient::didFinishLoading):
  34037. * loader/ThreadableLoaderClientWrapper.h: Added.
  34038. (WebCore::ThreadableLoaderClientWrapper::create):
  34039. (WebCore::ThreadableLoaderClientWrapper::clearClient):
  34040. (WebCore::ThreadableLoaderClientWrapper::didSendData):
  34041. (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
  34042. (WebCore::ThreadableLoaderClientWrapper::didReceiveData):
  34043. (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
  34044. (WebCore::ThreadableLoaderClientWrapper::didFail):
  34045. (WebCore::ThreadableLoaderClientWrapper::didGetCancelled):
  34046. (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
  34047. (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
  34048. * loader/WorkerThreadableLoader.cpp: Added.
  34049. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
  34050. (WebCore::WorkerThreadableLoader::~WorkerThreadableLoader):
  34051. (WebCore::WorkerThreadableLoader::cancel):
  34052. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
  34053. (WebCore::WorkerThreadableLoader::MainThreadBridge::~MainThreadBridge):
  34054. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  34055. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy):
  34056. (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
  34057. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCancel):
  34058. (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
  34059. (WebCore::WorkerThreadableLoader::MainThreadBridge::clearClientWrapper):
  34060. (WebCore::workerContextDidSendData):
  34061. (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
  34062. (WebCore::workerContextDidReceiveResponse):
  34063. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
  34064. (WebCore::workerContextDidReceiveData):
  34065. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
  34066. (WebCore::workerContextDidFinishLoading):
  34067. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  34068. (WebCore::workerContextDidFail):
  34069. (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
  34070. (WebCore::workerContextDidGetCancelled):
  34071. (WebCore::WorkerThreadableLoader::MainThreadBridge::didGetCancelled):
  34072. (WebCore::workerContextDidReceiveAuthenticationCancellation):
  34073. (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
  34074. * loader/WorkerThreadableLoader.h: Added.
  34075. (WebCore::WorkerThreadableLoader::create):
  34076. (WebCore::WorkerThreadableLoader::refThreadableLoader):
  34077. (WebCore::WorkerThreadableLoader::derefThreadableLoader):
  34078. 2009-02-02 David Levin <levin@chromium.org>
  34079. Reviewed by Alexey Proskuryakov.
  34080. Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
  34081. <https://bugs.webkit.org/show_bug.cgi?id=23636>
  34082. No observable change in behavior, so no test.
  34083. * WebCore.xcodeproj/project.pbxproj:
  34084. * dom/Worker.cpp:
  34085. * dom/Worker.h:
  34086. * dom/WorkerContext.cpp:
  34087. (WebCore::WorkerContext::addMessage):
  34088. (WebCore::WorkerContext::postTask):
  34089. (WebCore::WorkerContext::postTaskToWorkerObject):
  34090. * dom/WorkerContext.h:
  34091. * dom/WorkerMessagingProxy.cpp:
  34092. (WebCore::MessageWorkerContextTask::performTask):
  34093. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
  34094. (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
  34095. Expose postTaskToWorkerContext for use by the worker object thread.
  34096. (WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
  34097. Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
  34098. with postMessageToWorkerObject.
  34099. * dom/WorkerMessagingProxy.h:
  34100. * dom/WorkerRunLoop.cpp:
  34101. (WebCore::WorkerRunLoop::run):
  34102. (WebCore::WorkerRunLoop::postTask):
  34103. * dom/WorkerRunLoop.h:
  34104. * dom/WorkerTask.cpp: Removed.
  34105. * dom/WorkerTask.h: Removed.
  34106. Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.
  34107. The resulted in the class going away along with an adapter that made
  34108. a ScriptExecutionContext::Task look like a WorkerTask.
  34109. * dom/WorkerThread.cpp:
  34110. * dom/WorkerThread.h:
  34111. 2009-02-02 David Levin <levin@chromium.org>
  34112. Reviewed by Alexey Proskuryakov.
  34113. Bug 23618: Templated worker tasks should be more error proof to use.
  34114. <https://bugs.webkit.org/show_bug.cgi?id=23618>
  34115. Add the generic worker tasks templates needed for the WorkerThreadableLoader.
  34116. No observable change in behavior, so no test.
  34117. * GNUmakefile.am:
  34118. * WebCore.pro:
  34119. * WebCore.scons:
  34120. * WebCore.vcproj/WebCore.vcproj:
  34121. * WebCore.xcodeproj/project.pbxproj:
  34122. * WebCoreSources.bkl:
  34123. * dom/CrossThreadCopier.cpp: Added.
  34124. * dom/CrossThreadCopier.h: Added.
  34125. (WebCore::CrossThreadCopierPassThrough::copy):
  34126. * dom/GenericWorkerTask.h:
  34127. Stop doing the WorkerMessagingProxy::askedToTerminate call automatically
  34128. in performTask because was not obvious that it would be done and not always needed.
  34129. (WebCore::GenericWorkerTask1::create):
  34130. (WebCore::GenericWorkerTask1::GenericWorkerTask1):
  34131. (WebCore::GenericWorkerTask1::performTask):
  34132. (WebCore::GenericWorkerTask2::create):
  34133. (WebCore::GenericWorkerTask2::GenericWorkerTask2):
  34134. (WebCore::GenericWorkerTask2::performTask):
  34135. (WebCore::GenericWorkerTask3::create):
  34136. (WebCore::GenericWorkerTask3::GenericWorkerTask3):
  34137. (WebCore::GenericWorkerTask3::performTask):
  34138. (WebCore::GenericWorkerTask4::create):
  34139. (WebCore::GenericWorkerTask4::GenericWorkerTask4):
  34140. (WebCore::GenericWorkerTask4::performTask):
  34141. (WebCore::GenericWorkerTask5::create):
  34142. (WebCore::GenericWorkerTask5::GenericWorkerTask5):
  34143. (WebCore::GenericWorkerTask5::performTask):
  34144. (WebCore::GenericWorkerTask6::create):
  34145. (WebCore::GenericWorkerTask6::GenericWorkerTask6):
  34146. (WebCore::GenericWorkerTask6::performTask):
  34147. (WebCore::GenericWorkerTask7::create):
  34148. (WebCore::GenericWorkerTask7::GenericWorkerTask7):
  34149. (WebCore::GenericWorkerTask7::performTask):
  34150. (WebCore::createCallbackTask):
  34151. * dom/WorkerContext.cpp:
  34152. (WebCore::addMessageTask):
  34153. (WebCore::WorkerContext::addMessage):
  34154. * dom/WorkerMessagingProxy.h:
  34155. (WebCore::WorkerMessagingProxy::askedToTerminate):
  34156. 2009-02-02 Sam Weinig <sam@webkit.org>
  34157. Reviewed by David "The Barnabas Jones" Hyatt.
  34158. Move removeChildNode, appendChildNode and insertChildNode from
  34159. RenderContainer into RenderObjectChildList. Make moveChildNode
  34160. static in RenderBlock, as that was the only user.
  34161. * rendering/RenderBlock.cpp:
  34162. (WebCore::moveChild):
  34163. (WebCore::RenderBlock::makeChildrenNonInline):
  34164. (WebCore::RenderBlock::removeChild):
  34165. (WebCore::RenderBlock::handleRunInChild):
  34166. * rendering/RenderContainer.cpp:
  34167. (WebCore::RenderContainer::addChild):
  34168. (WebCore::RenderContainer::removeChild):
  34169. * rendering/RenderContainer.h:
  34170. * rendering/RenderInline.cpp:
  34171. (WebCore::RenderInline::splitInlines):
  34172. (WebCore::RenderInline::splitFlow):
  34173. (WebCore::RenderInline::childBecameNonInline):
  34174. * rendering/RenderObject.cpp:
  34175. (WebCore::RenderObject::handleDynamicFloatPositionChange):
  34176. * rendering/RenderObject.h:
  34177. (WebCore::RenderObject::createsAnonymousWrapper):
  34178. * rendering/RenderObjectChildList.cpp:
  34179. (WebCore::updateListMarkerNumbers):
  34180. (WebCore::RenderObjectChildList::removeChildNode):
  34181. (WebCore::RenderObjectChildList::appendChildNode):
  34182. (WebCore::RenderObjectChildList::insertChildNode):
  34183. * rendering/RenderObjectChildList.h:
  34184. * rendering/RenderSVGContainer.cpp:
  34185. (WebCore::RenderSVGContainer::addChild):
  34186. (WebCore::RenderSVGContainer::removeChild):
  34187. * rendering/RenderSVGContainer.h:
  34188. * rendering/RenderTable.cpp:
  34189. (WebCore::RenderTable::removeChild):
  34190. * rendering/RenderTable.h:
  34191. * rendering/RenderTableSection.cpp:
  34192. (WebCore::RenderTableSection::removeChild):
  34193. * rendering/RenderTableSection.h:
  34194. 2009-02-02 Alexey Proskuryakov <ap@webkit.org>
  34195. Reviewed by Darin Alder.
  34196. https://bugs.webkit.org/show_bug.cgi?id=23697
  34197. Leaks seen on Worker tests
  34198. * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
  34199. Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed()
  34200. is called.
  34201. 2009-02-02 David Hyatt <hyatt@apple.com>
  34202. Move positionForCoordinates up from RenderContainer into RenderBox.
  34203. Reviewed by Sam Weinig
  34204. * rendering/RenderBox.cpp:
  34205. (WebCore::RenderBox::positionForCoordinates):
  34206. * rendering/RenderBox.h:
  34207. * rendering/RenderContainer.cpp:
  34208. * rendering/RenderContainer.h:
  34209. 2009-02-02 Hiroaki Nakamura <hnakamur@gmail.com>
  34210. Reviewed by Adam Roben.
  34211. Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
  34212. Modify pre-build step to properly handle the errorlevel
  34213. shell command.
  34214. * WebCore.vcproj/WebCore.vcproj: Change errorlevel handling
  34215. for all targets so prefast is only enabled in builds
  34216. where /analyze is available.
  34217. 2009-02-02 David Hyatt <hyatt@apple.com>
  34218. Refactor the handling of before/after content and generated content. Move most of the functions from
  34219. RenderContainer into RenderObjectChildList.
  34220. Reviewed by Sam Weinig
  34221. * rendering/RenderBlock.cpp:
  34222. (WebCore::RenderBlock::updateBeforeAfterContent):
  34223. * rendering/RenderBlock.h:
  34224. * rendering/RenderBox.cpp:
  34225. (WebCore::RenderBox::isAfterContent):
  34226. * rendering/RenderBox.h:
  34227. * rendering/RenderButton.cpp:
  34228. (WebCore::RenderButton::updateBeforeAfterContent):
  34229. * rendering/RenderContainer.cpp:
  34230. * rendering/RenderContainer.h:
  34231. * rendering/RenderCounter.cpp:
  34232. (WebCore::destroyCounterNodeChildren):
  34233. * rendering/RenderInline.cpp:
  34234. (WebCore::RenderInline::styleDidChange):
  34235. (WebCore::RenderInline::addChildIgnoringContinuation):
  34236. (WebCore::RenderInline::splitInlines):
  34237. * rendering/RenderObject.h:
  34238. * rendering/RenderObjectChildList.cpp:
  34239. (WebCore::beforeAfterContainer):
  34240. (WebCore::findBeforeAfterParent):
  34241. (WebCore::invalidateCountersInContainer):
  34242. (WebCore::RenderObjectChildList::invalidateCounters):
  34243. (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  34244. * rendering/RenderObjectChildList.h:
  34245. 2009-02-02 Dmitry Titov <dimich@chromium.org>
  34246. Reviewed by Darin Adler.
  34247. https://bugs.webkit.org/show_bug.cgi?id=23661
  34248. Fix Chromium build.
  34249. * history/HistoryItem.h: need to include <wtf/OwnPtr.h>
  34250. * rendering/RenderThemeChromiumMac.mm:
  34251. (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
  34252. 2009-02-02 Geoffrey Garen <ggaren@apple.com>
  34253. Build fix.
  34254. * plugins/PluginView.cpp:
  34255. (WebCore::PluginView::performRequest):
  34256. 2009-02-02 Geoffrey Garen <ggaren@apple.com>
  34257. Build fix.
  34258. * WebCore.base.exp:
  34259. 2009-02-02 Geoffrey Garen <ggaren@apple.com>
  34260. Reviewed by Sam Weinig.
  34261. Track redirects in global history.
  34262. * WebCore.base.exp: Renamed some exports.
  34263. * bindings/js/JSDOMWindowBase.cpp:
  34264. (WebCore::createWindow):
  34265. (windowProtoFuncOpen):
  34266. * bindings/js/JSDOMWindowCustom.cpp:
  34267. (WebCore::JSDOMWindow::setLocation):
  34268. * bindings/js/JSDocumentCustom.cpp:
  34269. (WebCore::JSDocument::setLocation):
  34270. * bindings/js/JSHTMLFormElementCustom.cpp:
  34271. (WebCore::JSHTMLFormElement::submit):
  34272. * bindings/js/JSLocationCustom.cpp:
  34273. (WebCore::JSLocation::setHref):
  34274. (WebCore::JSLocation::setProtocol):
  34275. (WebCore::JSLocation::setHost):
  34276. (WebCore::JSLocation::setHostname):
  34277. (WebCore::JSLocation::setPort):
  34278. (WebCore::JSLocation::setPathname):
  34279. (WebCore::JSLocation::setSearch):
  34280. (WebCore::JSLocation::setHash):
  34281. (WebCore::JSLocation::assign): Treat any navigation that is not initiated
  34282. by the user as a redirect from the perspective of global history.
  34283. * history/HistoryItem.cpp:
  34284. (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect
  34285. chain.
  34286. * loader/DocumentLoader.cpp:
  34287. (WebCore::DocumentLoader::DocumentLoader):
  34288. * loader/DocumentLoader.h:
  34289. (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect):
  34290. (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect):
  34291. (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly,
  34292. added yet another way to track redirect state during loading, since none
  34293. of the others did what I wanted, and I didn't want to cause behavior
  34294. changes in existing code.
  34295. * loader/EmptyClients.h:
  34296. (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
  34297. Stubbed out a client function to keep things building.
  34298. * loader/FrameLoader.cpp:
  34299. (WebCore::isBackForwardLoadType):
  34300. (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect =>
  34301. FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all
  34302. the other meanings of "redirect" in the loading code.
  34303. (WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
  34304. redirect as a redirect from the perspective of global history.
  34305. (WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
  34306. parameter.
  34307. (WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
  34308. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
  34309. (WebCore::FrameLoader::loadURL):
  34310. (WebCore::FrameLoader::load): Updated for rename and extra parameter.
  34311. (WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
  34312. in the DocumentLoader, so it's accessible to WebKit's global history code.
  34313. (WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
  34314. only has meaning to global history, and m_quickRedirectComing pertains
  34315. to other kinds of history.
  34316. (WebCore::FrameLoader::loadPostRequest):
  34317. (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
  34318. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
  34319. (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
  34320. (WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
  34321. (WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
  34322. navigations even if they don't create new history items, so we can track
  34323. the redirect in the existing history item.
  34324. * loader/FrameLoader.h: See above.
  34325. * loader/FrameLoaderClient.h: New client interface used by
  34326. FrameLoader::updateHistory* to record a redirect even if it doesn't create
  34327. a new history item of its own.
  34328. * loader/FrameLoaderTypes.h: See above.
  34329. (WebCore::):
  34330. * page/DragController.cpp:
  34331. (WebCore::DragController::performDrag):
  34332. * svg/graphics/SVGImage.cpp:
  34333. (WebCore::SVGImage::dataChanged): Updated for extra parameter.
  34334. 2009-02-02 David Hyatt <hyatt@apple.com>
  34335. Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
  34336. Remove RenderSVGContainer's implementation, since it was never called.
  34337. Reviewed by Beth Dakin
  34338. * rendering/RenderBox.cpp:
  34339. (WebCore::RenderBox::minPrefWidth):
  34340. * rendering/RenderBox.h:
  34341. (WebCore::RenderBox::calcPrefWidths):
  34342. * rendering/RenderContainer.h:
  34343. (WebCore::RenderContainer::moveChildNode):
  34344. * rendering/RenderSVGContainer.h:
  34345. 2009-02-02 Anders Carlsson <andersca@apple.com>
  34346. Reviewed by Sam Weinig.
  34347. Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.
  34348. * WebCore.LP64.exp:
  34349. * bindings/js/ScriptController.cpp:
  34350. (WebCore::ScriptController::createScriptObjectForPluginElement):
  34351. (WebCore::ScriptController::jsObjectForPluginElement):
  34352. * bindings/js/ScriptController.h:
  34353. 2009-02-02 Darin Fisher <darin@chromium.org>
  34354. Reviewed by Eric Seidel (and Ojan Vafai).
  34355. https://bugs.webkit.org/show_bug.cgi?id=23696
  34356. Select element doesn't show new value when focus is switched in
  34357. onchange event.
  34358. Fix PopupMenuChromium to hide itself before calling valueChanged. This
  34359. better matches the behavior of the other ports.
  34360. * platform/chromium/PopupMenuChromium.cpp:
  34361. (WebCore::PopupListBox::create):
  34362. (WebCore::PopupContainer::PopupContainer):
  34363. (WebCore::PopupContainer::showPopup):
  34364. (WebCore::PopupContainer::hidePopup):
  34365. (WebCore::PopupListBox::abandon):
  34366. (WebCore::PopupListBox::acceptIndex):
  34367. (WebCore::PopupMenu::show):
  34368. (WebCore::PopupMenu::hide):
  34369. 2009-02-02 David Hyatt <hyatt@apple.com>
  34370. Make sure scrollWidth/Height just return 0 for inline flows.
  34371. Reviewed by Beth Dakin
  34372. * rendering/RenderBox.cpp:
  34373. (WebCore::RenderBox::scrollWidth):
  34374. (WebCore::RenderBox::scrollHeight):
  34375. 2009-02-02 Darin Adler <darin@apple.com>
  34376. Reviewed by Dave Hyatt.
  34377. Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
  34378. https://bugs.webkit.org/show_bug.cgi?id=23676
  34379. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  34380. (WebCore::cssPropertyName):
  34381. * css/CSSMutableStyleDeclaration.cpp:
  34382. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  34383. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  34384. * css/CSSPrimitiveValue.cpp:
  34385. (WebCore::CSSPrimitiveValue::cssText):
  34386. * css/CSSStyleDeclaration.cpp:
  34387. (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
  34388. * css/CSSStyleSelector.cpp:
  34389. (WebCore::CSSStyleSelector::sortMatchedRules):
  34390. * dom/Document.cpp:
  34391. (WebCore::Document::formElementsState):
  34392. * dom/NamedAttrMap.h:
  34393. (WebCore::NamedAttrMap::reserveInitialCapacity):
  34394. * editing/TextIterator.cpp:
  34395. (WebCore::CharacterIterator::string):
  34396. (WebCore::SearchBuffer::SearchBuffer):
  34397. (WebCore::plainTextToMallocAllocatedBuffer):
  34398. * editing/markup.cpp:
  34399. (WebCore::joinMarkups):
  34400. * history/HistoryItem.cpp:
  34401. (WebCore::HistoryItem::HistoryItem):
  34402. * html/HTMLTokenizer.cpp:
  34403. (WebCore::Token::addAttribute):
  34404. * loader/appcache/DOMApplicationCache.cpp:
  34405. (WebCore::DOMApplicationCache::items):
  34406. * page/SecurityOrigin.cpp:
  34407. (WebCore::SecurityOrigin::toString):
  34408. * page/mac/AccessibilityObjectWrapper.mm:
  34409. (convertToVector):
  34410. * platform/graphics/FontCache.cpp:
  34411. (WebCore::FontCache::purgeInactiveFontData):
  34412. (WebCore::FontCache::invalidate):
  34413. * platform/network/FormData.cpp:
  34414. (WebCore::FormData::deepCopy):
  34415. * platform/network/HTTPHeaderMap.cpp:
  34416. (WebCore::HTTPHeaderMap::copyData):
  34417. * platform/network/ResourceRequestBase.cpp:
  34418. (WebCore::ResourceRequestBase::copyData):
  34419. * platform/network/mac/FormDataStreamMac.mm:
  34420. (WebCore::formCreate):
  34421. * xml/XPathNodeSet.cpp:
  34422. (WebCore::XPath::NodeSet::sort):
  34423. Use reserveInitialCapacity instead of of reserveCapacity in all these call sites,
  34424. which are working on new vectors that are guaranteed not to be empty.
  34425. 2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>
  34426. Build fix after r40486.
  34427. Rubber-stamped by Ada Chan.
  34428. * dom/Document.h: Changed HitTestRequest to a class from a struct.
  34429. * page/EventHandler.h: Ditto.
  34430. * rendering/EllipsisBox.h: Ditto.
  34431. * rendering/InlineBox.h: Ditto.
  34432. * rendering/InlineFlowBox.h: Ditto.
  34433. * rendering/RenderLayer.h: Ditto.
  34434. 2009-02-02 Darin Adler <darin@apple.com>
  34435. Reviewed by Anders Carlsson.
  34436. Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
  34437. https://bugs.webkit.org/show_bug.cgi?id=23694
  34438. * dom/ContainerNode.cpp:
  34439. (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode.
  34440. (WebCore::ContainerNode::removedFromDocument): Ditto.
  34441. * dom/EventTargetNode.cpp:
  34442. (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node.
  34443. (WebCore::EventTargetNode::removedFromDocument): Ditto.
  34444. * dom/Node.cpp:
  34445. (WebCore::Node::insertedIntoDocument): Updated comment.
  34446. (WebCore::Node::removedFromDocument): Ditto.
  34447. 2009-02-02 Anders Carlsson <andersca@apple.com>
  34448. Reviewed by Dan Bernstein.
  34449. More plug-in cleanup.
  34450. * WebCore.NPAPI.exp:
  34451. Add new symbols.
  34452. * bindings/objc/DOM.mm:
  34453. * bindings/objc/DOMPrivate.h:
  34454. Remove methods that WebKit doesn't use anymore.
  34455. 2009-02-02 Jay Campan <jcampan@chromium.org>
  34456. Reviewed by Eric Seidel.
  34457. Clean up PopupMenuChromium a little.
  34458. https://bugs.webkit.org/show_bug.cgi?id=23653
  34459. No functional changes, only code cleanup, thus no tests.
  34460. * platform/chromium/PopupMenuChromium.cpp:
  34461. (WebCore::):
  34462. (WebCore::PopupListBox::PopupListBox):
  34463. (WebCore::PopupContainer::create):
  34464. (WebCore::PopupContainer::PopupContainer):
  34465. (WebCore::PopupContainer::showPopup):
  34466. (WebCore::PopupListBox::handleKeyEvent):
  34467. (WebCore::PopupListBox::isSelectableItem):
  34468. (WebCore::PopupListBox::selectNextRow):
  34469. (WebCore::PopupListBox::selectPreviousRow):
  34470. (WebCore::PopupMenu::show):
  34471. * platform/chromium/PopupMenuChromium.h:
  34472. 2009-02-02 Anders Carlsson <andersca@apple.com>
  34473. Reviewed by Dan Bernstein.
  34474. Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.
  34475. * WebCore.xcodeproj/project.pbxproj:
  34476. * loader/EmptyClients.h:
  34477. (WebCore::EmptyFrameLoaderClient::createPlugin):
  34478. (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
  34479. * loader/FrameLoader.cpp:
  34480. (WebCore::toPlugInElement):
  34481. (WebCore::FrameLoader::loadPlugin):
  34482. (WebCore::FrameLoader::loadItem):
  34483. * loader/FrameLoader.h:
  34484. * loader/FrameLoaderClient.h:
  34485. 2009-02-02 Genevieve Mak <gen@staikos.net>
  34486. Reviewed by George Staikos.
  34487. https://bugs.webkit.org/show_bug.cgi?id=23508
  34488. Returns Blank Page for all "about" protocols
  34489. * loader/MainResourceLoader.cpp:
  34490. Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
  34491. url or about:blank only (for now, exclusively for Torch Mobile platform).
  34492. 2009-02-02 Brent Fulgham <bfulgham@webkit.org>
  34493. Reviewed by George Staikos.
  34494. Fixes https://bugs.webkit.org/show_bug.cgi?id=23691.
  34495. Correct build break caused by @r40366 by moving the
  34496. common code implmentations from GraphicsContextCGWin.cpp
  34497. into the base Windows class (GraphicsContextWin.cpp). Also
  34498. move inTransparencyLayer since it is identical in both
  34499. children.
  34500. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  34501. Added member m_shouldIncludeChildWindows to Windows version,
  34502. similar to GraphicsContextPlatformPrivateCG.h.
  34503. * platform/graphics/win/GraphicsContextCGWin.cpp: Remove the
  34504. implementations of shouldIncludeChildWindows,
  34505. setShouldIncludeChildWindows, and inTransparencyLayer.
  34506. * platform/graphics/win/GraphicsContextCairoWin.cpp: Remove
  34507. the implementation of inTransparencyLayer.
  34508. * platform/graphics/win/GraphicsContextWin.cpp: Move common code
  34509. from GraphicsContextCGWin.cpp and GraphicsContextCairoWin.cpp.
  34510. (WebCore::GraphicsContext::inTransparencyLayer):
  34511. (WebCore::GraphicsContext::setShouldIncludeChildWindows):
  34512. (WebCore::GraphicsContext::shouldIncludeChildWindows):
  34513. 2009-02-02 Darin Adler <darin@apple.com>
  34514. Try to fix Wx build, and maybe Chromium build too.
  34515. * WebCore.scons: Added IdentifierRep.cpp.
  34516. * WebCoreSources.bkl: Ditto.
  34517. 2009-02-02 Darin Adler <darin@apple.com>
  34518. Try to fix Wx build.
  34519. * html/HTMLAreaElement.cpp: Added missing include of "Path.h".
  34520. 2009-02-02 Adam Treat <adam.treat@torchmobile.com>
  34521. Reviewed by Nikolas Zimmermann.
  34522. https://bugs.webkit.org/show_bug.cgi?id=23587
  34523. Refactor HitTestRequest to eliminate all the ugly boolean arguments and
  34524. use an enum bitflag instead. Cleanup all the code that constructs the
  34525. various HitTestRequests to make the code more readable.
  34526. * dom/Document.cpp:
  34527. (WebCore::Document::elementFromPoint):
  34528. (WebCore::Document::prepareMouseEvent):
  34529. * editing/SelectionController.cpp:
  34530. (WebCore::SelectionController::contains):
  34531. * page/AccessibilityRenderObject.cpp:
  34532. (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  34533. (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  34534. * page/EventHandler.cpp:
  34535. (WebCore::EventHandler::eventMayStartDrag):
  34536. (WebCore::EventHandler::updateSelectionForMouseDrag):
  34537. (WebCore::EventHandler::hitTestResultAtPoint):
  34538. (WebCore::EventHandler::handleMousePressEvent):
  34539. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  34540. (WebCore::EventHandler::handleMouseMoveEvent):
  34541. (WebCore::EventHandler::handleMouseReleaseEvent):
  34542. (WebCore::EventHandler::updateDragAndDrop):
  34543. (WebCore::EventHandler::handleWheelEvent):
  34544. (WebCore::EventHandler::sendContextMenuEvent):
  34545. (WebCore::EventHandler::hoverTimerFired):
  34546. (WebCore::EventHandler::handleDrag):
  34547. * page/EventHandler.h:
  34548. * rendering/HitTestRequest.h:
  34549. (WebCore::HitTestRequest::):
  34550. (WebCore::HitTestRequest::HitTestRequest):
  34551. (WebCore::HitTestRequest::readOnly):
  34552. (WebCore::HitTestRequest::active):
  34553. (WebCore::HitTestRequest::mouseMove):
  34554. (WebCore::HitTestRequest::mouseUp):
  34555. (WebCore::HitTestRequest::ignoreClipping):
  34556. * rendering/RenderFrameSet.cpp:
  34557. (WebCore::RenderFrameSet::nodeAtPoint):
  34558. * rendering/RenderLayer.cpp:
  34559. (WebCore::RenderLayer::hitTest):
  34560. (WebCore::RenderLayer::hitTestLayer):
  34561. (WebCore::RenderLayer::updateHoverActiveState):
  34562. 2009-02-02 George Staikos <george.staikos@torchmobile.com>
  34563. Reviewed by Niko Zimmermann.
  34564. Fix WML build by including the inlined renderStyle().
  34565. * wml/WMLOptGroupElement.cpp:
  34566. * wml/WMLOptionElement.cpp:
  34567. 2009-02-02 Darin Adler <darin@apple.com>
  34568. Reviewed by Niko Zimmermann.
  34569. Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
  34570. https://bugs.webkit.org/show_bug.cgi?id=23686
  34571. rdar://problem/6547971
  34572. Also fix other XPath tests that are crashing.
  34573. * xml/XPathFunctions.cpp:
  34574. (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
  34575. * xml/XPathStep.cpp:
  34576. (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we
  34577. need to make Attr nodes here. Yuck!
  34578. 2009-02-02 Yichao Yin <yichao.yin@torchmobile.com.cn>
  34579. Reviewed by Niko Zimmermann.
  34580. Test: wml/input-format.html
  34581. * wml/WMLInputElement.cpp:
  34582. (WebCore::WMLInputElement::WMLInputElement):
  34583. (WebCore::formatCodes):
  34584. (WebCore::WMLInputElement::dispatchBlurEvent):
  34585. (WebCore::WMLInputElement::parseMappedAttribute):
  34586. (WebCore::WMLInputElement::attach):
  34587. (WebCore::WMLInputElement::defaultEventHandler):
  34588. (WebCore::WMLInputElement::init):
  34589. (WebCore::WMLInputElement::validateInputMask):
  34590. (WebCore::WMLInputElement::isConformedToInputMask):
  34591. (WebCore::WMLInputElement::cursorPositionToMaskIndex):
  34592. * wml/WMLInputElement.h:
  34593. 2009-02-02 Brent Fulgham <bfulgham@webkit.org>
  34594. Build fix only, no review.
  34595. Fixes https://bugs.webkit.org/show_bug.cgi?id=23685.
  34596. Correct build break caused by @r40473.
  34597. * page/win/FrameWin.cpp: Correct access for adjustPageHeight.
  34598. (WebCore::computePageRectsForFrame):
  34599. 2009-02-02 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  34600. Not reviewed. Fix WML enabled builds.
  34601. FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.
  34602. * wml/WMLAElement.cpp:
  34603. (WebCore::WMLAElement::defaultEventHandler):
  34604. 2009-02-02 Alexey Proskuryakov <ap@webkit.org>
  34605. Reviewed by Darin Adler.
  34606. <rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server
  34607. Not easily testable.
  34608. * loader/appcache/ApplicationCacheGroup.cpp:
  34609. (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource
  34610. handle in a manner that is closer to what CachedResource does. We now make conditional
  34611. requests for better performance, and set max-age to ensure that stale responses are not used.
  34612. (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method.
  34613. (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource
  34614. is 304, take it from the newest cache.
  34615. (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL.
  34616. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for
  34617. the manifest if the response code was 304 - it won't be needed.
  34618. (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that
  34619. m_manifestResource is not null with a check.
  34620. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as
  34621. an indication that the response was 304.
  34622. (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
  34623. * loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
  34624. 2009-02-01 Darin Adler <darin@apple.com>
  34625. Reviewed by Dave Hyatt.
  34626. Bug 23674: Speed up some things based on profiling the page load test
  34627. https://bugs.webkit.org/show_bug.cgi?id=23674
  34628. * css/CSSStyleSelector.cpp:
  34629. (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead
  34630. of the old name, getCSSTarget.
  34631. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  34632. * dom/ContainerNode.cpp:
  34633. (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than
  34634. calling through to EventTargetNode::insertedIntoDocument.
  34635. (WebCore::ContainerNode::removedFromDocument): Ditto.
  34636. (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit.
  34637. (WebCore::ContainerNode::removedFromTree): Ditto.
  34638. * dom/ContainerNode.h: Moved the constructor definition here and made it inline.
  34639. * dom/Document.cpp:
  34640. (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and
  34641. its contents only to avoid the document type node. This allows us to remove the virtual
  34642. function call to isEventTargetNode from the loop.
  34643. (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
  34644. * dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed
  34645. getCSSTarget to cssTarget.
  34646. * dom/EventTargetNode.cpp:
  34647. (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the
  34648. rare data check into an assertion.
  34649. * dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline.
  34650. Also moved the constructor definition here and made it inline. And added toEventTargetNode,
  34651. matching the design of the render tree checked casts. Later we can migrate all callers
  34652. from EventTargetNodeCast to toEventTargetNode.
  34653. * dom/NamedAttrMap.cpp:
  34654. (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from
  34655. clearAttributes, so we could use this loop in cases where we're not clearing the attributes.
  34656. (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of
  34657. clearAttributes here.
  34658. (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here.
  34659. (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of
  34660. clearAttributes. We don't need to clear the attributes array just because the element is
  34661. going away, so don't.
  34662. (WebCore::NamedAttrMap::virtualLength): Added.
  34663. * dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private.
  34664. These are all unnecessarily inefficient for use outside the DOM. Changed length to be a
  34665. non-virtual function. This was a fairly hot function.
  34666. * dom/NamedMappedAttrMap.cpp:
  34667. (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the
  34668. m_element data member is private.
  34669. * dom/NamedMappedAttrMap.h: Made a few functions private. Made the
  34670. hasMappedAttributes function non-virtual.
  34671. * dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual
  34672. function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
  34673. * dom/Node.cpp:
  34674. (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's
  34675. only non-empty in subclasses of ContainerNode.
  34676. (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS
  34677. target has to be an Element, this can be moved down to ContainerNode (or it could be
  34678. moved down to Element for that matter).
  34679. * dom/QualifiedName.cpp:
  34680. (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
  34681. * dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and
  34682. setPrefix function definitions into the header and made them inline.
  34683. * html/HTMLAreaElement.cpp:
  34684. (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now
  34685. an OwnPtr.
  34686. (WebCore::HTMLAreaElement::accessKey): Use AtomicString.
  34687. (WebCore::HTMLAreaElement::setAccessKey): Ditto.
  34688. (WebCore::HTMLAreaElement::alt): Ditto.
  34689. (WebCore::HTMLAreaElement::setAlt): Ditto.
  34690. (WebCore::HTMLAreaElement::coords): Ditto.
  34691. (WebCore::HTMLAreaElement::setCoords): Ditto.
  34692. (WebCore::HTMLAreaElement::setHref): Ditto.
  34693. (WebCore::HTMLAreaElement::shape): Ditto.
  34694. (WebCore::HTMLAreaElement::setShape): Ditto.
  34695. (WebCore::HTMLAreaElement::setTarget): Ditto.
  34696. * html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations.
  34697. Change the region data member to be an OwnPtr<Path> instead of a Path to optimize
  34698. the common case where an area element is parsed but never hit-tested. This could
  34699. also have been done by changing the Path class's null case to be more efficient,
  34700. but this seems fine.
  34701. * html/HTMLViewSourceDocument.cpp:
  34702. (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead
  34703. of insertAttribute.
  34704. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto.
  34705. (WebCore::HTMLViewSourceDocument::addLine): Ditto.
  34706. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
  34707. * loader/FrameLoader.cpp:
  34708. (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead
  34709. of its old name getCSSTarget.
  34710. * platform/graphics/GlyphWidthMap.cpp:
  34711. (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
  34712. * platform/graphics/GlyphWidthMap.h: Made most of this class inline.
  34713. Changed m_pages to use OwnPtr.
  34714. * platform/text/PlatformString.h: Remove include no longer needed since
  34715. StringImpl.h includes it.
  34716. * platform/text/StringImpl.cpp:
  34717. (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored
  34718. from createStrippingNullCharacters.
  34719. * platform/text/StringImpl.h: Moved the definition of
  34720. createStrippingNullCharacters here and made it inline.
  34721. * rendering/RenderObject.cpp:
  34722. (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from
  34723. firstLineStyle.
  34724. * rendering/RenderObject.h: Moved the definition of the firstLineStyle
  34725. function here and made it inline. Moved the definition of the
  34726. documentBeingDestroyed function here and made it inline.
  34727. * svg/SVGSVGElement.cpp:
  34728. (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of
  34729. getNamedItem here since it accomplishes the same thing but is more efficient.
  34730. (WebCore::SVGSVGElement::getScreenCTM): Ditto.
  34731. * svg/SVGStyledElement.cpp:
  34732. (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
  34733. * xml/XPathFunctions.cpp:
  34734. (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of
  34735. getNamedItemNS.
  34736. * xml/XPathStep.cpp:
  34737. (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
  34738. 2009-02-02 Holger Hans Peter Freyther <zecke@selfish.org>
  34739. Reviewed by Darin Adler.
  34740. Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
  34741. https://bugs.webkit.org/show_bug.cgi?id=23428
  34742. FrameView::forceLayout could be killed but the comment might
  34743. contain a value over the the plain FrameView::layout...
  34744. Adjust the WebCore/WebKit consumers of these methods.
  34745. * WebCore.base.exp:
  34746. * page/Frame.cpp:
  34747. (WebCore::Frame::setPrinting):
  34748. * page/Frame.h:
  34749. * page/FrameView.cpp:
  34750. (WebCore::FrameView::forceLayout):
  34751. (WebCore::FrameView::forceLayoutWithPageWidthRange):
  34752. (WebCore::FrameView::adjustPageHeight):
  34753. * page/FrameView.h:
  34754. * page/PrintContext.cpp:
  34755. (WebCore::PrintContext::computePageRects):
  34756. 2009-02-01 Dan Bernstein <mitz@apple.com>
  34757. Reviewed by John Sullivan.
  34758. - fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il
  34759. Fixes http/tests/navigation/multiple-back-forward-entries.html
  34760. r40432 added a parameter to FrameLoader::scheduleLocationChange() and
  34761. failed to update all call sites.
  34762. * bindings/js/JSDOMWindowBase.cpp:
  34763. (WebCore::createWindow): Pass the lockBackForwardHistory parameter,
  34764. giving it the same value as the lockHistory parameter.
  34765. (windowProtoFuncOpen): Ditto.
  34766. * bindings/js/JSDOMWindowCustom.cpp:
  34767. (WebCore::JSDOMWindow::setLocation): Ditto.
  34768. * bindings/js/JSDocumentCustom.cpp:
  34769. (WebCore::JSDocument::setLocation): Ditto.
  34770. * loader/FrameLoader.cpp:
  34771. (WebCore::FrameLoader::requestFrame): Ditto.
  34772. 2009-01-31 Dan Bernstein <mitz@apple.com>
  34773. Reviewed by Oliver Hunt.
  34774. - fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()
  34775. On the PLT, this results in 0.36x the number of virtual function calls
  34776. to RenderText::width() and 0.69x the number of calls to
  34777. Font::isFixedPitch(), but makes 1.0004x the number of calls to
  34778. Font::width().
  34779. * rendering/RenderText.cpp:
  34780. (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len'
  34781. with an assertion.
  34782. * rendering/bidi.cpp:
  34783. (WebCore::textWidth): Added this inlined helper function which calls
  34784. Font::width() directly in the non-fixed-pitch, non-full-range case, and
  34785. otherwise calls RenderText::width().
  34786. (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has
  34787. fixed pitch (in which case RenderText::width() will be called in order
  34788. to take advantage of the widthFromCache() optimization for fixed-pitch
  34789. fonts). Replaced all calls to RenderText::width() with calls to the
  34790. textWidth() helper function.
  34791. 2009-01-31 David Hyatt <hyatt@apple.com>
  34792. Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
  34793. and setNeedsPositionedMovementLayout.
  34794. Reviewed by Dan Bernstein
  34795. * rendering/RenderObject.cpp:
  34796. (WebCore::RenderObject::setLayerNeedsFullRepaint):
  34797. * rendering/RenderObject.h:
  34798. (WebCore::RenderObject::setNeedsLayout):
  34799. (WebCore::RenderObject::setChildNeedsLayout):
  34800. (WebCore::RenderObject::setNeedsPositionedMovementLayout):
  34801. (WebCore::objectIsRelayoutBoundary):
  34802. (WebCore::RenderObject::markContainingBlocksForLayout):
  34803. 2009-01-31 Darin Adler <darin@apple.com>
  34804. Fix Mac build.
  34805. * loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here.
  34806. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely
  34807. deleted and I don't want to bring it back just to fix the build.
  34808. * loader/FrameLoaderClient.h: Rearrange virtual functions and corrected
  34809. a possibly-confusing comment.
  34810. 2009-01-31 Adam Treat <adam.treat@torchmobile.com>
  34811. Reviewed by David Hyatt.
  34812. https://bugs.webkit.org/show_bug.cgi?id=23664
  34813. Remove unused dead code from RenderTable class. The dead code includes
  34814. two enums and the associated member variables as well as one getter function.
  34815. * rendering/RenderTable.cpp:
  34816. (WebCore::RenderTable::RenderTable):
  34817. * rendering/RenderTable.h:
  34818. 2009-01-31 David Hyatt <hyatt@apple.com>
  34819. More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
  34820. Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
  34821. RenderObjectChildList.
  34822. Reviewed by Sam Weinig
  34823. * WebCore.xcodeproj/project.pbxproj:
  34824. * rendering/RenderBlock.cpp:
  34825. (WebCore::RenderBlock::destroy):
  34826. (WebCore::RenderBlock::addChild):
  34827. (WebCore::RenderBlock::removeLeftoverAnonymousBlock):
  34828. (WebCore::RenderBlock::layoutPositionedObjects):
  34829. (WebCore::RenderBlock::childBecameNonInline):
  34830. * rendering/RenderBlock.h:
  34831. * rendering/RenderBox.cpp:
  34832. (WebCore::RenderBox::layout):
  34833. * rendering/RenderBox.h:
  34834. (WebCore::RenderBox::firstChildBox):
  34835. (WebCore::RenderBox::lastChildBox):
  34836. * rendering/RenderContainer.cpp:
  34837. (WebCore::RenderContainer::addChild):
  34838. (WebCore::RenderContainer::removeChildNode):
  34839. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  34840. (WebCore::RenderContainer::appendChildNode):
  34841. (WebCore::RenderContainer::insertChildNode):
  34842. (WebCore::RenderContainer::positionForCoordinates):
  34843. (WebCore::RenderContainer::addLineBoxRects):
  34844. (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
  34845. * rendering/RenderContainer.h:
  34846. (WebCore::RenderContainer::virtualChildren):
  34847. (WebCore::RenderContainer::children):
  34848. * rendering/RenderInline.cpp:
  34849. (WebCore::RenderInline::destroy):
  34850. * rendering/RenderInline.h:
  34851. (WebCore::RenderInline::layout):
  34852. * rendering/RenderMedia.cpp:
  34853. (WebCore::RenderMedia::destroy):
  34854. (WebCore::RenderMedia::children):
  34855. * rendering/RenderMedia.h:
  34856. (WebCore::RenderMedia::virtualChildren):
  34857. * rendering/RenderObject.cpp:
  34858. (WebCore::RenderObject::destroy):
  34859. (WebCore::RenderObject::layout):
  34860. * rendering/RenderObject.h:
  34861. (WebCore::RenderObject::firstChild):
  34862. (WebCore::RenderObject::lastChild):
  34863. (WebCore::RenderObject::virtualChildren):
  34864. (WebCore::RenderObject::canHaveChildren):
  34865. * rendering/RenderObjectChildList.cpp: Added.
  34866. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
  34867. * rendering/RenderObjectChildList.h:
  34868. * rendering/RenderReplaced.h:
  34869. (WebCore::RenderReplaced::canHaveChildren):
  34870. * rendering/RenderSVGContainer.cpp:
  34871. (WebCore::RenderSVGContainer::RenderSVGContainer):
  34872. (WebCore::RenderSVGContainer::destroy):
  34873. (WebCore::RenderSVGContainer::removeChildNode):
  34874. (WebCore::RenderSVGContainer::appendChildNode):
  34875. (WebCore::RenderSVGContainer::insertChildNode):
  34876. * rendering/RenderSVGContainer.h:
  34877. (WebCore::RenderSVGContainer::virtualChildren):
  34878. (WebCore::RenderSVGContainer::children):
  34879. 2009-01-31 David Hyatt <hyatt@apple.com>
  34880. Fix for https://bugs.webkit.org/show_bug.cgi?id=11363
  34881. Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
  34882. With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
  34883. layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
  34884. be properly ignored.
  34885. Reviewed by Oliver Hunt
  34886. * editing/DeleteButtonController.cpp:
  34887. (WebCore::DeleteButtonController::createDeletionUI):
  34888. * rendering/RenderTable.cpp:
  34889. (WebCore::RenderTable::addChild):
  34890. (WebCore::RenderTable::layout):
  34891. * rendering/RenderTableSection.cpp:
  34892. (WebCore::RenderTableSection::layout):
  34893. * rendering/RenderTableSection.h:
  34894. 2009-01-31 Adam Treat <adam.treat@torchmobile.com>
  34895. Reviewed by Darin Adler.
  34896. https://bugs.webkit.org/show_bug.cgi?id=23663
  34897. Add a void toRenderBox() method which catches unnecessary casts at compile
  34898. time and also fix the four cases where this was happening.
  34899. * rendering/RenderBlock.cpp:
  34900. (WebCore::RenderBlock::determineHorizontalPosition):
  34901. * rendering/RenderBox.h:
  34902. * rendering/RenderFlexibleBox.cpp:
  34903. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  34904. * rendering/RenderInline.cpp:
  34905. (WebCore::RenderInline::updateHitTestResult):
  34906. * rendering/RenderLayer.cpp:
  34907. (WebCore::RenderLayer::updateLayerPosition):
  34908. 2009-01-30 Adam Barth <abarth@webkit.org>
  34909. Reviewed by Sam Weinig.
  34910. Add a pref to disable web security.
  34911. * WebCore.base.exp:
  34912. * dom/Document.cpp:
  34913. (WebCore::Document::initSecurityContext):
  34914. * page/SecurityOrigin.cpp:
  34915. (WebCore::SecurityOrigin::SecurityOrigin):
  34916. (WebCore::SecurityOrigin::canAccess):
  34917. (WebCore::SecurityOrigin::canRequest):
  34918. (WebCore::SecurityOrigin::grantUniversalAccess):
  34919. * page/SecurityOrigin.h:
  34920. * page/Settings.cpp:
  34921. (WebCore::Settings::Settings):
  34922. (WebCore::Settings::setWebSecurityEnabled):
  34923. * page/Settings.h:
  34924. (WebCore::Settings::isWebSecurityEnabled):
  34925. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  34926. Build fix.
  34927. Move the inline virtual destructor after a non-inline virtual
  34928. function so that the symbol for the vtable is not marked as a
  34929. weakly exported symbol.
  34930. This trick was previously used at revision 36122 in JSObject.h
  34931. * loader/FrameLoaderClient.h:
  34932. (WebCore::FrameLoaderClient::~FrameLoaderClient):
  34933. 2009-01-30 Oliver Hunt <oliver@apple.com>
  34934. Reviewed by Stephanie Lewis
  34935. Inline SimpleFontData::widthForGlyph for a minor page load improvement.
  34936. * platform/graphics/SimpleFontData.cpp:
  34937. * platform/graphics/SimpleFontData.h:
  34938. (WebCore::SimpleFontData::widthForGlyph):
  34939. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  34940. Build fix for WX and maybe even Windows.
  34941. * WebCore.vcproj/WebCore.vcproj:
  34942. * WebCoreSources.bkl:
  34943. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  34944. Reviewed by Darin Adler.
  34945. Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler
  34946. Carry out the move and catch up in two call sites.
  34947. * WebCore.base.exp:
  34948. * page/EventHandler.cpp:
  34949. (WebCore::EventHandler::sendResizeEvent):
  34950. (WebCore::EventHandler::sendScrollEvent):
  34951. * page/EventHandler.h:
  34952. * page/Frame.cpp:
  34953. * page/Frame.h:
  34954. * page/FrameView.cpp:
  34955. (WebCore::FrameView::performPostLayoutTasks):
  34956. (WebCore::FrameView::valueChanged):
  34957. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  34958. Reviewed by Darin Adler.
  34959. Move Frame::isFrameSet to Document::isFrameSet
  34960. Changed the FrameLoader callsite. I assume that as this
  34961. point m_frame.document() might return a null pointer. Change
  34962. the condition to either not having a document or not having a
  34963. frame set. This should be semantically equivalent to the
  34964. old code.
  34965. Make Document::body() const to be able to call it from within
  34966. Document::isFrameSet. Leave the isHTMLDocument() check as this
  34967. is a stronger condition than simply having a HTMLElement in the
  34968. DOM.
  34969. * WebCore.base.exp:
  34970. * dom/Document.cpp:
  34971. (WebCore::Document::isFrameSet):
  34972. (WebCore::Document::body):
  34973. * dom/Document.h:
  34974. * loader/FrameLoader.cpp:
  34975. (WebCore::FrameLoader::shouldScrollToAnchor):
  34976. * loader/archive/cf/LegacyWebArchive.cpp:
  34977. (WebCore::LegacyWebArchive::createFromSelection):
  34978. * page/Frame.cpp:
  34979. * page/Frame.h:
  34980. 2009-01-30 Aurelian Maga <aurelianmaga@yahoo.com>
  34981. Reviewed by Holger Freyther.
  34982. [GTK] Logic fixes and build fixes
  34983. https://bugs.webkit.org/show_bug.cgi?id=22022
  34984. Catch up with the internal GeoLocation API and fix the logic of
  34985. the previous version.
  34986. * platform/gtk/GeolocationServiceGtk.cpp:
  34987. (WebCore::GeolocationServiceGtk::startUpdating):
  34988. (WebCore::GeolocationServiceGtk::updateLocationInformation):
  34989. (WebCore::GeolocationServiceGtk::position_changed):
  34990. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  34991. Reviewed by Nikolas Zimmermann.
  34992. [GTK] Implement GeolocationService using the Geoclue library
  34993. https://bugs.webkit.org/show_bug.cgi?id=22022
  34994. Untested implementation of the GeolocationService using the geoclue
  34995. library. Velocity handling is completely missing and the accuracy
  34996. handling might be wrong.
  34997. * platform/gtk/GeolocationServiceGtk.cpp:
  34998. (WTF::GeoclueAccuracy):
  34999. (WebCore::GeolocationServiceGtk::GeolocationServiceGtk):
  35000. (WebCore::GeolocationServiceGtk::~GeolocationServiceGtk):
  35001. (WebCore::GeolocationServiceGtk::startUpdating):
  35002. (WebCore::GeolocationServiceGtk::stopUpdating):
  35003. (WebCore::GeolocationServiceGtk::suspend):
  35004. (WebCore::GeolocationServiceGtk::resume):
  35005. (WebCore::GeolocationServiceGtk::lastPosition):
  35006. (WebCore::GeolocationServiceGtk::lastError):
  35007. (WebCore::GeolocationServiceGtk::updateLocationInformation):
  35008. (WebCore::GeolocationServiceGtk::updatePosition):
  35009. (WebCore::GeolocationServiceGtk::position_changed):
  35010. (WebCore::GeolocationServiceGtk::setError):
  35011. * platform/gtk/GeolocationServiceGtk.h:
  35012. 2009-01-30 Mark Rowe <mrowe@apple.com>
  35013. Build fix. Declare preferredSize as static.
  35014. * platform/text/cf/StringImplCF.cpp:
  35015. (WebCore::StringWrapperCFAllocator::preferredSize):
  35016. 2009-01-30 Darin Adler <darin@apple.com>
  35017. Reviewed by Mark Rowe.
  35018. Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
  35019. https://bugs.webkit.org/show_bug.cgi?id=23622
  35020. * platform/text/cf/StringImplCF.cpp:
  35021. (WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator.
  35022. (WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator.
  35023. (WebCore::StringWrapperCFAllocator::release): Ditto.
  35024. (WebCore::StringWrapperCFAllocator::copyDescription): Ditto.
  35025. (WebCore::StringWrapperCFAllocator::allocate): Ditto.
  35026. (WebCore::StringWrapperCFAllocator::reallocate): Ditto.
  35027. (WebCore::StringWrapperCFAllocator::deallocate): Ditto.
  35028. (WebCore::StringWrapperCFAllocator::preferredSize): Ditto.
  35029. (WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but
  35030. returns 0 if garbage collection is enabled.
  35031. (WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.
  35032. * platform/text/mac/StringImplMac.mm:
  35033. (WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging,
  35034. rather than using NSString directly. This lets NSString benefit from the above.
  35035. 2009-01-30 Darin Adler <darin@apple.com>
  35036. * page/Frame.cpp:
  35037. (WebCore::Frame::createView): Fix debug build by removing get() from assert.
  35038. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  35039. Reviewed by Simon Hausmann.
  35040. https://bugs.webkit.org/show_bug.cgi?id=22056
  35041. Kill FrameLoaderClient.cpp, move the code over to Frame::createView
  35042. FrameLoaderClient is supposed to be an interface, move the
  35043. to be shared code to Frame which is a controller and is
  35044. allowed to create a FrameView.
  35045. * GNUmakefile.am:
  35046. * WebCore.base.exp:
  35047. * WebCore.pro:
  35048. * WebCore.xcodeproj/project.pbxproj:
  35049. * loader/FrameLoaderClient.cpp: Removed.
  35050. * loader/FrameLoaderClient.h:
  35051. (WebCore::FrameLoaderClient::~FrameLoaderClient):
  35052. * page/Frame.cpp:
  35053. (WebCore::Frame::createView):
  35054. * page/Frame.h:
  35055. 2009-01-30 Simon Fraser <simon.fraser@apple.com>
  35056. Reviewed by Dave Hyatt
  35057. https://bugs.webkit.org/show_bug.cgi?id=23357
  35058. New files to support accelerated compositing at the RenderLayer
  35059. level.
  35060. * WebCore.xcodeproj/project.pbxproj:
  35061. New files added to project, and run through the sort script.
  35062. * rendering/RenderLayerBacking.cpp: Added.
  35063. * rendering/RenderLayerBacking.h: Added.
  35064. New object to store compositing-related data for a single
  35065. RenderLayer.
  35066. * rendering/RenderLayerCompositor.cpp: Added.
  35067. * rendering/RenderLayerCompositor.h: Added.
  35068. Per-RenderView controller object for compositing hierarchy
  35069. maintenance.
  35070. 2009-01-30 Simon Fraser <simon.fraser@apple.com>
  35071. Reviewed by Dave Hyatt
  35072. https://bugs.webkit.org/show_bug.cgi?id=23356
  35073. Add new files related to accelerated compositing:
  35074. * WebCore.xcodeproj/project.pbxproj:
  35075. Add the files to the project. Also add ColorCG.cpp, for the
  35076. Color(CGColorRef) constructor.
  35077. * platform/graphics/GraphicsLayer.cpp: Added.
  35078. * platform/graphics/GraphicsLayer.h: Added.
  35079. GraphicsLayer is a platform abstraction for a hardware-backed
  35080. layer.
  35081. * platform/graphics/GraphicsLayerClient.h: Added.
  35082. Client of GraphicsLayer, allowing GraphicsLayer to call out
  35083. to WebCore code.
  35084. * platform/graphics/mac/GraphicsLayerCA.h: Added.
  35085. * platform/graphics/mac/GraphicsLayerCA.mm: Added.
  35086. Mac Core Animation implementation of GraphicsLayer.
  35087. * platform/graphics/mac/WebLayer.h: Added.
  35088. * platform/graphics/mac/WebLayer.mm: Added.
  35089. * platform/graphics/mac/WebTiledLayer.h: Added.
  35090. * platform/graphics/mac/WebTiledLayer.mm: Added.
  35091. Subclasses of CALayer and CATiledLayer -- helpers for the
  35092. GraphicsLayerCA implementation.
  35093. 2009-01-30 Geoffrey Garen <ggaren@apple.com>
  35094. Reviewed by Sam Weinig.
  35095. Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
  35096. preparation for setting them differently during a redirect.
  35097. * WebCore.base.exp:
  35098. * bindings/js/JSHTMLFormElementCustom.cpp:
  35099. (WebCore::JSHTMLFormElement::submit):
  35100. * bindings/js/JSLocationCustom.cpp:
  35101. (WebCore::navigateIfAllowed):
  35102. (WebCore::JSLocation::setHref):
  35103. (WebCore::JSLocation::setProtocol):
  35104. (WebCore::JSLocation::setHost):
  35105. (WebCore::JSLocation::setHostname):
  35106. (WebCore::JSLocation::setPort):
  35107. (WebCore::JSLocation::setPathname):
  35108. (WebCore::JSLocation::setSearch):
  35109. (WebCore::JSLocation::setHash):
  35110. (WebCore::JSLocation::replace):
  35111. (WebCore::JSLocation::assign):
  35112. * html/HTMLAnchorElement.cpp:
  35113. (WebCore::HTMLAnchorElement::defaultEventHandler):
  35114. * html/HTMLFormElement.cpp:
  35115. (WebCore::HTMLFormElement::submit):
  35116. * html/HTMLFormElement.h:
  35117. * loader/FrameLoader.cpp:
  35118. (WebCore::FormSubmission::FormSubmission):
  35119. (WebCore::ScheduledRedirection::ScheduledRedirection):
  35120. (WebCore::isBackForwardLoadType):
  35121. (WebCore::FrameLoader::createWindow):
  35122. (WebCore::FrameLoader::changeLocation):
  35123. (WebCore::FrameLoader::urlSelected):
  35124. (WebCore::FrameLoader::submitFormAgain):
  35125. (WebCore::FrameLoader::submitForm):
  35126. (WebCore::FrameLoader::restoreDocumentState):
  35127. (WebCore::FrameLoader::scheduleHTTPRedirection):
  35128. (WebCore::FrameLoader::scheduleLocationChange):
  35129. (WebCore::FrameLoader::scheduleRefresh):
  35130. (WebCore::FrameLoader::redirectionTimerFired):
  35131. (WebCore::FrameLoader::loadURLIntoChildFrame):
  35132. (WebCore::FrameLoader::startRedirectionTimer):
  35133. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
  35134. (WebCore::FrameLoader::transitionToCommitted):
  35135. (WebCore::FrameLoader::clientRedirected):
  35136. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
  35137. (WebCore::FrameLoader::loadItem):
  35138. * loader/FrameLoader.h:
  35139. * loader/FrameLoaderTypes.h:
  35140. (WebCore::):
  35141. * page/ContextMenuController.cpp:
  35142. (WebCore::ContextMenuController::contextMenuItemSelected):
  35143. * svg/SVGAElement.cpp:
  35144. (WebCore::SVGAElement::defaultEventHandler):
  35145. 2009-01-30 Sam Weinig <sam@webkit.org>
  35146. Reviewed by Dan Bernstein.
  35147. Fix for <rdar://problem/6545095>
  35148. ASSERTION FAILED: RenderBlock.h:519: !o || o->isRenderBlock()
  35149. Test: fast/block/float/crash-replaced-display-block.html
  35150. * rendering/RenderBlock.cpp:
  35151. (WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into
  35152. isRenderBlock if-statement.
  35153. 2009-01-30 Chris Fleizach <cfleizach@apple.com>
  35154. Reviewed by Oliver Hunt.
  35155. Bug 23656: AX hierarchy for iFrames is incorrect
  35156. https://bugs.webkit.org/show_bug.cgi?id=23656
  35157. The AX hierarchy when an iFrame was present was incorrect. A different scroll area was
  35158. returned when going down compared to when going up.
  35159. * page/mac/AccessibilityObjectWrapper.mm:
  35160. (convertToNSArray):
  35161. 2009-01-30 Adam Treat <adam.treat@torchmobile.com>
  35162. Fix Qt build to include new class IdentifierRep introduced in revision 40412.
  35163. * WebCore.pro:
  35164. 2009-01-30 Anders Carlsson <andersca@apple.com>
  35165. Reviewed by Sam Weinig.
  35166. Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.
  35167. * WebCore.LP64.exp:
  35168. * WebCore.xcodeproj/project.pbxproj:
  35169. 2009-01-30 Sam Weinig <sam@webkit.org>
  35170. Commit files I forgot to in the previous commit.
  35171. * page/AccessibilityRenderObject.cpp:
  35172. (WebCore::AccessibilityRenderObject::layoutCount):
  35173. * page/Frame.cpp:
  35174. (WebCore::Frame::contentRenderer):
  35175. (WebCore::Frame::forceLayoutWithPageWidthRange):
  35176. * page/FrameView.cpp:
  35177. (WebCore::FrameView::layout):
  35178. * rendering/RenderBlock.cpp:
  35179. (WebCore::RenderBlock::nodeAtPoint):
  35180. * rendering/RenderObject.cpp:
  35181. (WebCore::RenderObject::repaintUsingContainer):
  35182. (WebCore::RenderObject::repaint):
  35183. (WebCore::RenderObject::repaintRectangle):
  35184. (WebCore::RenderObject::view):
  35185. (WebCore::RenderObject::scheduleRelayout):
  35186. (WebCore::RenderObject::maximalOutlineSize):
  35187. * rendering/SVGRenderSupport.cpp:
  35188. (WebCore::clampImageBufferSizeToViewport):
  35189. * svg/SVGLength.cpp:
  35190. (WebCore::SVGLength::PercentageOfViewport):
  35191. 2009-01-30 Geoffrey Garen <ggaren@apple.com>
  35192. Reviewed by Darin Adler.
  35193. More scaffolding for redirect tracking. No behavior change yet.
  35194. * bindings/js/JSHTMLFormElementCustom.cpp:
  35195. (WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for
  35196. redirect checking in a form submission through JS. (Currently, we
  35197. just specify "no redirect.")
  35198. * bindings/js/ScriptController.h:
  35199. * bindings/js/ScriptController.cpp:
  35200. (WebCore::ScriptController::processingUserGesture):
  35201. (WebCore::ScriptController::processingUserGestureEvent):
  35202. (WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored
  35203. user gesture check to make it more clear.
  35204. (WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
  35205. for checking if there's a user gesture in any frame on the page (a more
  35206. relaxed rule than our popup blocking rule, which requires the user
  35207. gesture to occur in the frame that's executing JavaScript.)
  35208. * html/HTMLFormElement.h:
  35209. * html/HTMLFormElement.cpp:
  35210. (WebCore::HTMLFormElement::submit): Added scaffolding necessary for
  35211. redirect checking in a form submission through the DOM. (Currently, we
  35212. just specify "no redirect.")
  35213. * html/HTMLFormElement.idl: Made submit custom so it can participate
  35214. in redirect checking.
  35215. * loader/FrameLoader.h:
  35216. * loader/FrameLoader.cpp:
  35217. (WebCore::FormSubmission::FormSubmission): Clarified some names, and
  35218. added a "lockHistory" parameter to form submissions, to match other
  35219. navigations.
  35220. (WebCore::FrameLoader::submitFormAgain):
  35221. (WebCore::FrameLoader::submitForm): Use the lockHistory parameter.
  35222. (WebCore::FrameLoader::userGestureHint): Refactored this function for
  35223. clarity, and added a FIXME for a change I was too scared to make myself.
  35224. (Really, we should just get rid of this function.)
  35225. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
  35226. to pass a FrameLoadType to form posts, too, so they can participate in
  35227. redirect tracking.
  35228. (WebCore::FrameLoader::loadPostRequest):
  35229. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
  35230. (WebCore::FrameLoader::loadItem): Use the lockHistory parameter.
  35231. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  35232. Reviewed by Mark Rowe.
  35233. [Gtk+] Use AccessibilityObject::stringValue for the AtkObject name
  35234. https://bugs.webkit.org/show_bug.cgi?id=21546
  35235. The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
  35236. states that: "AtkObjects whose text content is simple, unattributed, and very
  35237. brief may expose that content via atk_object_get_name instead"
  35238. As we are currently not able to always provide a AtkTextInterface
  35239. implementation this will make the whole content available to accerciser,
  35240. and other tools.
  35241. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  35242. 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
  35243. Unreviewed build fix.
  35244. Include string.h for strdup.
  35245. * bridge/IdentifierRep.h:
  35246. 2009-01-30 Sam Weinig <sam@webkit.org>
  35247. Reviewed by Dan Bernstein.
  35248. Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
  35249. is not a RenderView.
  35250. * dom/Document.cpp:
  35251. (WebCore::Document::renderView):
  35252. * editing/SelectionController.cpp:
  35253. (WebCore::SelectionController::nodeWillBeRemoved):
  35254. (WebCore::SelectionController::recomputeCaretRect):
  35255. (WebCore::SelectionController::invalidateCaretRect):
  35256. (WebCore::SelectionController::focusedOrActiveStateChanged):
  35257. * editing/mac/SelectionControllerMac.mm:
  35258. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  35259. * rendering/RenderBox.cpp:
  35260. (WebCore::RenderBox::styleDidChange):
  35261. (WebCore::RenderBox::repaintLayerRectsForImage):
  35262. (WebCore::RenderBox::availableHeightUsing):
  35263. * rendering/RenderView.h:
  35264. (WebCore::toRenderView):
  35265. 2009-01-30 Simon Fraser <simon.fraser@apple.com>
  35266. Reviewed by Dave Hyatt
  35267. https://bugs.webkit.org/show_bug.cgi?id=23360
  35268. Really use the container-relative repaint rect methods
  35269. for repaint during layout
  35270. * rendering/RenderObject.h:
  35271. (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
  35272. 2009-01-30 Anders Carlsson <andersca@apple.com>
  35273. Reviewed by Darin Adler.
  35274. Get rid of PrivateIdentifier and use IdentifierRep instead.
  35275. * bridge/NP_jsobject.cpp:
  35276. (_NPN_Invoke):
  35277. (_NPN_GetProperty):
  35278. (_NPN_SetProperty):
  35279. (_NPN_RemoveProperty):
  35280. (_NPN_HasProperty):
  35281. (_NPN_HasMethod):
  35282. * bridge/c/c_instance.cpp:
  35283. (JSC::Bindings::CInstance::getPropertyNames):
  35284. * bridge/c/c_utility.cpp:
  35285. (JSC::Bindings::convertNPStringToUTF16):
  35286. * bridge/c/c_utility.h:
  35287. * bridge/npruntime.cpp:
  35288. (_NPN_GetStringIdentifier):
  35289. (_NPN_GetStringIdentifiers):
  35290. (_NPN_GetIntIdentifier):
  35291. (_NPN_IdentifierIsString):
  35292. (_NPN_UTF8FromIdentifier):
  35293. (_NPN_IntFromIdentifier):
  35294. 2009-01-30 Anders Carlsson <andersca@apple.com>
  35295. Reviewed by Sam Weinig and Darin Adler.
  35296. Make IdentifierRep a real class, add necessary class methods.
  35297. * bridge/IdentifierRep.cpp:
  35298. (WebCore::identifierSet):
  35299. Returns a set of all identifiers.
  35300. (WebCore::IdentifierRep::isValid):
  35301. Return whether an identifier is valid, meaning that it's present in the
  35302. set of identifiers.
  35303. * bridge/IdentifierRep.h:
  35304. (WebCore::IdentifierRep::isString):
  35305. (WebCore::IdentifierRep::number):
  35306. (WebCore::IdentifierRep::string):
  35307. (WebCore::IdentifierRep::IdentifierRep):
  35308. (WebCore::IdentifierRep::):
  35309. 2009-01-30 Anders Carlsson <andersca@apple.com>
  35310. Reviewed by Sam Weinig.
  35311. Add IdentifierRep which will be used by both plug-in implementations.
  35312. * GNUmakefile.am:
  35313. * WebCore.vcproj/WebCore.vcproj:
  35314. * WebCore.xcodeproj/project.pbxproj:
  35315. * bridge/IdentifierRep.cpp: Added.
  35316. (WebCore::IdentifierRep::IdentifierRep):
  35317. (WebCore::IdentifierRep::):
  35318. (WebCore::intIdentifierMap):
  35319. (WebCore::identifierRep):
  35320. (WebCore::stringIdentifierMap):
  35321. * bridge/IdentifierRep.h: Added.
  35322. * bridge/c/c_utility.h:
  35323. * platform/text/PlatformString.h:
  35324. * platform/text/String.cpp:
  35325. (WebCore::String::fromUTF8WithLatin1Fallback):
  35326. 2009-01-30 Sam Weinig <sam@webkit.org>
  35327. Reviewed by David Hyatt.
  35328. Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
  35329. is not a RenderInline.
  35330. * rendering/InlineFlowBox.cpp:
  35331. (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
  35332. (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
  35333. (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
  35334. (WebCore::InlineFlowBox::rendererLineBoxes):
  35335. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  35336. (WebCore::InlineFlowBox::paint):
  35337. * rendering/LayoutState.cpp:
  35338. (WebCore::LayoutState::LayoutState):
  35339. * rendering/RenderBlock.cpp:
  35340. (WebCore::RenderBlock::paintObject):
  35341. (WebCore::RenderBlock::addFocusRingRects):
  35342. * rendering/RenderBox.cpp:
  35343. (WebCore::RenderBox::offsetFromContainer):
  35344. (WebCore::RenderBox::computeRectForRepaint):
  35345. (WebCore::RenderBox::containingBlockWidthForPositioned):
  35346. (WebCore::RenderBox::containingBlockHeightForPositioned):
  35347. (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  35348. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  35349. * rendering/RenderContainer.cpp:
  35350. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  35351. * rendering/RenderInline.cpp:
  35352. (WebCore::RenderInline::inlineContinuation):
  35353. (WebCore::nextContinuation):
  35354. (WebCore::RenderInline::splitInlines):
  35355. * rendering/RenderInline.h:
  35356. (WebCore::toRenderInline):
  35357. * rendering/RenderLayer.cpp:
  35358. (WebCore::RenderLayer::updateLayerPosition):
  35359. (WebCore::RenderLayer::boundingBox):
  35360. * rendering/RenderLineBoxList.cpp:
  35361. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  35362. * rendering/RenderText.h:
  35363. * rendering/RenderTreeAsText.cpp:
  35364. (WebCore::operator<<):
  35365. * rendering/bidi.cpp:
  35366. (WebCore::RenderBlock::createLineBoxes):
  35367. (WebCore::RenderBlock::layoutInlineChildren):
  35368. 2009-01-30 Darin Fisher <darin@chromium.org>
  35369. Reviewed by Eric Seidel.
  35370. https://bugs.webkit.org/show_bug.cgi?id=23647
  35371. Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports
  35372. * platform/graphics/skia/ImageSourceSkia.cpp:
  35373. (WebCore::ImageSource::clear):
  35374. 2009-01-30 David Hyatt <hyatt@apple.com>
  35375. Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
  35376. is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
  35377. is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.
  35378. Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
  35379. patch with a containsFloats() check.
  35380. Reviewed by Darin Adler
  35381. * dom/PositionIterator.cpp:
  35382. (WebCore::PositionIterator::isCandidate):
  35383. * editing/CompositeEditCommand.cpp:
  35384. (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  35385. * editing/Editor.cpp:
  35386. (WebCore::Editor::hasBidiSelection):
  35387. * page/AccessibilityRenderObject.cpp:
  35388. (WebCore::AccessibilityRenderObject::anchorElement):
  35389. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  35390. * rendering/RenderBlock.cpp:
  35391. (WebCore::RenderBlock::styleWillChange):
  35392. (WebCore::RenderBlock::removeChild):
  35393. (WebCore::RenderBlock::layoutBlock):
  35394. (WebCore::RenderBlock::collapseMargins):
  35395. (WebCore::RenderBlock::clearFloatsIfNeeded):
  35396. (WebCore::RenderBlock::layoutBlockChildren):
  35397. (WebCore::RenderBlock::fillBlockSelectionGaps):
  35398. (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  35399. (WebCore::RenderBlock::firstLineBlock):
  35400. (WebCore::getLineAtIndex):
  35401. (WebCore::getHeightForLineCount):
  35402. (WebCore::RenderBlock::lineCount):
  35403. (WebCore::RenderBlock::adjustForBorderFit):
  35404. (WebCore::RenderBlock::clearTruncation):
  35405. * rendering/RenderBlock.h:
  35406. (WebCore::toRenderBlock):
  35407. * rendering/RenderBox.cpp:
  35408. (WebCore::RenderBox::offsetFromContainer):
  35409. (WebCore::RenderBox::computeRectForRepaint):
  35410. (WebCore::RenderBox::calcReplacedHeightUsing):
  35411. * rendering/RenderFlexibleBox.cpp:
  35412. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  35413. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  35414. * rendering/RenderInline.cpp:
  35415. (WebCore::RenderInline::inlineContinuation):
  35416. (WebCore::nextContinuation):
  35417. (WebCore::RenderInline::positionForCoordinates):
  35418. * rendering/RenderLayer.cpp:
  35419. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  35420. * rendering/RenderListItem.cpp:
  35421. (WebCore::getParentOfFirstLineBox):
  35422. (WebCore::RenderListItem::positionListMarker):
  35423. * rendering/RenderObject.cpp:
  35424. (WebCore::RenderObject::containingBlock):
  35425. (WebCore::RenderObject::computeRectForRepaint):
  35426. (WebCore::RenderObject::removeFromObjectLists):
  35427. (WebCore::RenderObject::getTextDecorationColors):
  35428. * rendering/RenderTable.cpp:
  35429. (WebCore::RenderTable::addChild):
  35430. (WebCore::RenderTable::recalcSections):
  35431. * rendering/RenderTextControl.cpp:
  35432. (WebCore::RenderTextControl::styleDidChange):
  35433. * rendering/RenderTextControlSingleLine.cpp:
  35434. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  35435. * rendering/RootInlineBox.cpp:
  35436. (WebCore::RootInlineBox::block):
  35437. * rendering/bidi.cpp:
  35438. (WebCore::RenderBlock::createLineBoxes):
  35439. 2009-01-30 Brady Eidson <beidson@apple.com>
  35440. Reviewed by Sam Weinig
  35441. - Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of
  35442. relying on some outside force.
  35443. - Clear the previous history item inside FrameLoader instead of relying on multiple
  35444. FrameLoaderClients to do it.
  35445. * history/CachedFrame.cpp:
  35446. (WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here.
  35447. (WebCore::CachedFrame::restore): Resume those DOM objects here.
  35448. * history/CachedFrame.h:
  35449. (WebCore::CachedFrame::domWindow):
  35450. * loader/FrameLoader.cpp:
  35451. (WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the
  35452. suspending of active DOM objects.
  35453. (WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects.
  35454. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead
  35455. of performing a client call by itself.
  35456. (WebCore::FrameLoader::frameLoadCompleted):
  35457. 2009-01-30 Alexey Proskuryakov <ap@webkit.org>
  35458. Reviewed by Darin Adler.
  35459. <rdar://problem/6448823> Application Cache is kept after a private browsing session
  35460. * loader/appcache/ApplicationCacheGroup.cpp:
  35461. (WebCore::ApplicationCacheGroup::selectCache):
  35462. (WebCore::ApplicationCacheGroup::update):
  35463. Cache update will not be started if private browsing is enabled. Existing cache version
  35464. from disk database will be used.
  35465. * loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call
  35466. it when refusing to update from selectCache().
  35467. * loader/appcache/ApplicationCache.cpp:
  35468. (WebCore::ApplicationCache::addDynamicEntry):
  35469. (WebCore::ApplicationCache::removeDynamicEntry):
  35470. Added reminders about private browsing to unimplemented methods.
  35471. 2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  35472. Reviewed by Simon Hausmann.
  35473. Bug 23580: GNU mode RVCT compilation support
  35474. <https://bugs.webkit.org/show_bug.cgi?id=23580>
  35475. * html/PreloadScanner.cpp: Use COMPILER(GCC) instead of __GNUC__.
  35476. 2009-01-30 David Levin <levin@chromium.org>
  35477. Reviewed by Alexey Proskuryakov.
  35478. Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
  35479. <https://bugs.webkit.org/show_bug.cgi?id=23616>
  35480. Added forwarding header.
  35481. * ForwardingHeaders/wtf/TypeTraits.h: Added.
  35482. 2009-01-30 David Levin <levin@chromium.org>
  35483. Reviewed by Alexey Proskuryakov.
  35484. Bug 23599: ResourceError needs to be copyable for use in another thread.
  35485. <https://bugs.webkit.org/show_bug.cgi?id=23599>
  35486. Add ResourceErrorBase::copy method. (Not yet used.)
  35487. * platform/network/ResourceErrorBase.cpp:
  35488. (WebCore::ResourceErrorBase::copy):
  35489. * platform/network/ResourceErrorBase.h:
  35490. 2009-01-29 Stephanie Lewis <slewis@apple.com>
  35491. RS by Oliver Hunt.
  35492. Update the order files.
  35493. * WebCore.order:
  35494. 2009-01-29 Dmitry Titov <dimich@chromium.org>
  35495. Reviewed by Darin Adler.
  35496. https://bugs.webkit.org/show_bug.cgi?id=23488
  35497. Make TimerBase thread-aware (for Workers).
  35498. Added new class ThreadTimers - it keeps a heap of all timers for a thread (previously kept in a static global).
  35499. Pointer to instance of ThreadTimers is stored in GlobalThreadData.
  35500. Most static methods of TimerBase went to ThreadTimers.
  35501. The TimerBase functionality did not change (it maintains the timer heap which computes the nearest firing).
  35502. Added new abstract class SharedTimer, so worker threads can provide their own implementation (will be implemented on WorkerRunLoop).
  35503. * GNUmakefile.am:
  35504. * WebCore.pro:
  35505. * WebCore.scons:
  35506. * WebCore.vcproj/WebCore.vcproj:
  35507. * WebCore.xcodeproj/project.pbxproj:
  35508. * WebCoreSources.bkl:
  35509. Added new ThreadTimers.cpp to build files.
  35510. * platform/SharedTimer.h:
  35511. (WebCore::SharedTimer::~SharedTimer):
  35512. (WebCore::MainThreadSharedTimer::setFiredFunction):
  35513. (WebCore::MainThreadSharedTimer::setFireTime):
  35514. (WebCore::MainThreadSharedTimer::stop):
  35515. Added abstract SharedTimer and MainThreadSharedTimer which redirects to the existing port-supplied functions.
  35516. * platform/ThreadGlobalData.cpp:
  35517. (WebCore::ThreadGlobalData::ThreadGlobalData):
  35518. (WebCore::ThreadGlobalData::~ThreadGlobalData):
  35519. * platform/ThreadGlobalData.h:
  35520. (WebCore::ThreadGlobalData::threadTimers):
  35521. Added ThreadTimers to ThreadGlobalData.
  35522. * platform/ThreadTimers.cpp: Added.
  35523. (WebCore::mainThreadSharedTimer):
  35524. Static getter for a MainThreadSharedTimer singleton.
  35525. (WebCore::ThreadTimers::ThreadTimers):
  35526. (WebCore::ThreadTimers::setSharedTimer):
  35527. (WebCore::ThreadTimers::updateSharedTimer):
  35528. (WebCore::ThreadTimers::collectFiringTimers):
  35529. (WebCore::ThreadTimers::fireTimers):
  35530. (WebCore::ThreadTimers::sharedTimerFired):
  35531. (WebCore::ThreadTimers::sharedTimerFiredInternal):
  35532. (WebCore::ThreadTimers::fireTimersInNestedEventLoop):
  35533. ThreadTimers implementation. Most of the code is moved from previous static functions on TimerBase.
  35534. Need a new class so each thread may get ts own copy of the timer heap.
  35535. * platform/ThreadTimers.h: Added.
  35536. (WebCore::ThreadTimers::timerHeap):
  35537. (WebCore::ThreadTimers::timersReadyToFire):
  35538. * platform/Timer.cpp:
  35539. (WebCore::timerHeap):
  35540. (WebCore::timersReadyToFire):
  35541. (WebCore::TimerHeapElement::TimerHeapElement):
  35542. (WebCore::TimerHeapElement::checkConsistency):
  35543. (WebCore::TimerHeapElement::operator=):
  35544. (WebCore::TimerHeapIterator::checkConsistency):
  35545. (WebCore::TimerBase::TimerBase):
  35546. (WebCore::TimerBase::~TimerBase):
  35547. (WebCore::TimerBase::isActive):
  35548. (WebCore::TimerBase::checkHeapIndex):
  35549. (WebCore::TimerBase::heapDelete):
  35550. (WebCore::TimerBase::heapDeleteMin):
  35551. (WebCore::TimerBase::heapInsert):
  35552. (WebCore::TimerBase::heapPopMin):
  35553. (WebCore::TimerBase::setNextFireTime):
  35554. (WebCore::TimerBase::fireTimersInNestedEventLoop):
  35555. Now instead of static timer heap these use accessor functions that pull thread-specific heap instance.
  35556. * platform/Timer.h:
  35557. static methods moved to ThreadTimers.
  35558. 2009-01-29 David Hyatt <hyatt@apple.com>
  35559. Beginning of work to eliminate RenderContainer and make containership "pluggable" into any spot in the render tree. The first step is to create
  35560. the new object that will handle children: RenderObjectChildList and move RenderContainer's member variables into it. Subsequent patches will begin
  35561. moving RenderContainer's functionality into RenderObjectChildList.
  35562. Reviewed by Eric Seidel
  35563. * WebCore.xcodeproj/project.pbxproj:
  35564. * rendering/RenderContainer.cpp:
  35565. (WebCore::RenderContainer::RenderContainer):
  35566. (WebCore::RenderContainer::destroyLeftoverChildren):
  35567. (WebCore::RenderContainer::addChild):
  35568. (WebCore::RenderContainer::removeChildNode):
  35569. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  35570. (WebCore::RenderContainer::appendChildNode):
  35571. (WebCore::RenderContainer::insertChildNode):
  35572. (WebCore::RenderContainer::layout):
  35573. (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
  35574. (WebCore::RenderContainer::positionForCoordinates):
  35575. (WebCore::RenderContainer::addLineBoxRects):
  35576. (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
  35577. * rendering/RenderContainer.h:
  35578. (WebCore::RenderContainer::firstChild):
  35579. (WebCore::RenderContainer::lastChild):
  35580. (WebCore::RenderContainer::firstChildBox):
  35581. (WebCore::RenderContainer::lastChildBox):
  35582. * rendering/RenderObjectChildList.h: Added.
  35583. (WebCore::RenderObjectChildList::RenderObjectChildList):
  35584. (WebCore::RenderObjectChildList::firstChild):
  35585. (WebCore::RenderObjectChildList::lastChild):
  35586. (WebCore::RenderObjectChildList::setFirstChild):
  35587. (WebCore::RenderObjectChildList::setLastChild):
  35588. 2009-01-29 Jungshik Shin <jshin@chromium.org>
  35589. Reviewed by Alexey Proskuryakov.
  35590. http://bugs.webkit.org/show_bug.cgi?id=23598
  35591. Replace smart-quotes in UTF-8 with ASCII double-quotes to avoid
  35592. the compilation error on CJK Windows
  35593. * wml/WMLTableElement.cpp:
  35594. (WebCore::WMLTableElement::parseMappedAttribute):
  35595. 2009-01-29 Darin Fisher <darin@chromium.org>
  35596. Reviewed by Eric Seidel.
  35597. https://bugs.webkit.org/show_bug.cgi?id=23627
  35598. Fix the PLATFORM(SKIA) build.
  35599. * svg/graphics/SVGPaintServer.cpp:
  35600. (WebCore::SVGPaintServer::teardown):
  35601. 2009-01-29 Scott Violet <sky@google.com>
  35602. Reviewed by Eric Seidel.
  35603. https://bugs.webkit.org/show_bug.cgi?id=23625
  35604. Skia platform doesn't render text to a canvas or support clipping to an image buffer
  35605. Fixes two bugs in Skia rendering to a canvas:
  35606. . Text was not rendered at all. This is because we never properly
  35607. fixed up the alpha values. The fix is to create a layer when
  35608. rendering text to a layer.
  35609. . We were not honoring clipping to an image buffer.
  35610. * platform/graphics/chromium/FontChromiumWin.cpp:
  35611. (WebCore::Font::drawGlyphs):
  35612. * platform/graphics/skia/GraphicsContextSkia.cpp:
  35613. (WebCore::GraphicsContext::clipToImageBuffer):
  35614. * platform/graphics/skia/ImageBufferSkia.cpp:
  35615. (WebCore::ImageBuffer::ImageBuffer):
  35616. * platform/graphics/skia/PlatformContextSkia.cpp:
  35617. (PlatformContextSkia::PlatformContextSkia):
  35618. (PlatformContextSkia::setDrawingToImageBuffer):
  35619. (PlatformContextSkia::isDrawingToImageBuffer):
  35620. (PlatformContextSkia::beginLayerClippedToImage):
  35621. (PlatformContextSkia::restore):
  35622. (PlatformContextSkia::applyClipFromImage):
  35623. * platform/graphics/skia/PlatformContextSkia.h:
  35624. 2009-01-29 Sam Weinig <sam@webkit.org>
  35625. Reviewed by Mark Rowe.
  35626. First step in tracking the urls a HistoryItem was redirected through.
  35627. * WebCore.base.exp:
  35628. * history/HistoryItem.cpp:
  35629. (WebCore::HistoryItem::HistoryItem):
  35630. (WebCore::HistoryItem::addRedirectURL):
  35631. (WebCore::HistoryItem::redirectURLs):
  35632. (WebCore::HistoryItem::setRedirectURLs):
  35633. * history/HistoryItem.h:
  35634. 2009-01-29 Dirk Schulze <krit@webkit.org>
  35635. Reviewed by Nikolas Zimmermann, Eric Seidel.
  35636. Just transform the pattern directly instead of transforming the context fixes this
  35637. problem. Texts or strokes are no longer affected by transformations.
  35638. SVG pattern transformation/BoundingBox can cause ugly stroke thickness or text positions
  35639. https://bugs.webkit.org/show_bug.cgi?id=23472
  35640. Test: svg/custom/pattern-with-transformation.svg
  35641. * platform/graphics/Pattern.h:
  35642. (WebCore::Pattern::setPatternSpaceTransform):
  35643. * platform/graphics/cairo/PatternCairo.cpp:
  35644. (WebCore::Pattern::createPlatformPattern):
  35645. * platform/graphics/cg/PatternCG.cpp:
  35646. (WebCore::Pattern::createPlatformPattern):
  35647. * platform/graphics/qt/PatternQt.cpp:
  35648. (WebCore::Pattern::createPlatformPattern):
  35649. * svg/graphics/SVGPaintServerPattern.cpp:
  35650. (WebCore::SVGPaintServerPattern::setup):
  35651. 2009-01-29 David Hyatt <hyatt@apple.com>
  35652. Move the line box list member out of RenderFlow and down into RenderBlock and RenderInline. Eliminate RenderFlow from the tree.
  35653. Reviewed by Sam Weinig
  35654. * GNUmakefile.am:
  35655. * WebCore.pro:
  35656. * WebCore.vcproj/WebCore.vcproj:
  35657. * WebCore.xcodeproj/project.pbxproj:
  35658. * WebCoreSources.bkl:
  35659. * html/HTMLAnchorElement.cpp:
  35660. * rendering/InlineFlowBox.cpp:
  35661. (WebCore::InlineFlowBox::rendererLineBoxes):
  35662. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  35663. * rendering/InlineFlowBox.h:
  35664. * rendering/LayoutState.cpp:
  35665. (WebCore::LayoutState::LayoutState):
  35666. * rendering/RenderBlock.cpp:
  35667. (WebCore::RenderBlock::RenderBlock):
  35668. (WebCore::RenderBlock::destroy):
  35669. (WebCore::RenderBlock::styleWillChange):
  35670. (WebCore::RenderBlock::styleDidChange):
  35671. (WebCore::RenderBlock::dirtyLineBoxes):
  35672. (WebCore::RenderBlock::removeChild):
  35673. (WebCore::RenderBlock::setSelectionState):
  35674. (WebCore::RenderBlock::avoidsFloats):
  35675. (WebCore::RenderBlock::positionForCoordinates):
  35676. (WebCore::RenderBlock::calcInlinePrefWidths):
  35677. (WebCore::RenderBlock::baselinePosition):
  35678. (WebCore::RenderBlock::getBaselineOfFirstLineBox):
  35679. (WebCore::RenderBlock::getBaselineOfLastLineBox):
  35680. (WebCore::RenderBlock::rectWithOutlineForRepaint):
  35681. (WebCore::RenderBlock::hoverAncestor):
  35682. (WebCore::RenderBlock::updateDragState):
  35683. * rendering/RenderBlock.h:
  35684. (WebCore::RenderBlock::lineBoxes):
  35685. (WebCore::RenderBlock::firstLineBox):
  35686. (WebCore::RenderBlock::lastLineBox):
  35687. * rendering/RenderBox.cpp:
  35688. (WebCore::RenderBox::offsetFromContainer):
  35689. (WebCore::RenderBox::computeRectForRepaint):
  35690. (WebCore::RenderBox::containingBlockWidthForPositioned):
  35691. (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  35692. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  35693. * rendering/RenderBox.h:
  35694. * rendering/RenderFlow.cpp: Removed.
  35695. * rendering/RenderFlow.h: Removed.
  35696. * rendering/RenderInline.cpp:
  35697. (WebCore::RenderInline::RenderInline):
  35698. (WebCore::RenderInline::destroy):
  35699. (WebCore::RenderInline::styleDidChange):
  35700. (WebCore::RenderInline::addChildIgnoringContinuation):
  35701. (WebCore::RenderInline::cloneInline):
  35702. (WebCore::RenderInline::splitInlines):
  35703. (WebCore::RenderInline::offsetLeft):
  35704. (WebCore::RenderInline::offsetTop):
  35705. (WebCore::RenderInline::positionForCoordinates):
  35706. (WebCore::RenderInline::rectWithOutlineForRepaint):
  35707. (WebCore::RenderInline::updateDragState):
  35708. (WebCore::RenderInline::relativePositionedInlineOffset):
  35709. * rendering/RenderInline.h:
  35710. (WebCore::RenderInline::lineBoxes):
  35711. (WebCore::RenderInline::firstLineBox):
  35712. (WebCore::RenderInline::lastLineBox):
  35713. * rendering/RenderLayer.cpp:
  35714. (WebCore::RenderLayer::updateLayerPosition):
  35715. * rendering/RenderLineBoxList.cpp:
  35716. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  35717. * rendering/RootInlineBox.cpp:
  35718. (WebCore::RootInlineBox::rendererLineBoxes):
  35719. * rendering/RootInlineBox.h:
  35720. * rendering/bidi.cpp:
  35721. (WebCore::RenderBlock::createLineBoxes):
  35722. * wml/WMLAElement.cpp:
  35723. 2009-01-29 Geoffrey Garen <ggaren@apple.com>
  35724. Reviewed by Oliver Hunt.
  35725. Cleaned up some naming in ScheduledRedirection.
  35726. * loader/FrameLoader.cpp:
  35727. (WebCore::ScheduledRedirection::ScheduledRedirection):
  35728. 2009-01-29 Anders Carlsson <andersca@apple.com>
  35729. Reviewed by Dan Bernstein.
  35730. Update to use new API.
  35731. * platform/graphics/mac/FontCustomPlatformData.cpp:
  35732. (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
  35733. (WebCore::createFontCustomPlatformData):
  35734. 2009-01-29 Alexey Proskuryakov <ap@webkit.org>
  35735. Reviewed by Nikolas Zimmermann.
  35736. https://bugs.webkit.org/show_bug.cgi?id=23619
  35737. ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG image load
  35738. is cancelled
  35739. Covered by existing tests (as a random crash).
  35740. * loader/EmptyClients.h:
  35741. (WebCore::EmptyFrameLoaderClient::cancelledError):
  35742. (WebCore::EmptyFrameLoaderClient::blockedError):
  35743. (WebCore::EmptyFrameLoaderClient::cannotShowURLError):
  35744. (WebCore::EmptyFrameLoaderClient::interruptForPolicyChangeError):
  35745. (WebCore::EmptyFrameLoaderClient::cannotShowMIMETypeError):
  35746. (WebCore::EmptyFrameLoaderClient::fileDoesNotExistError):
  35747. (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
  35748. Create non-null errors.
  35749. 2009-01-29 Geoffrey Garen <ggaren@apple.com>
  35750. Reviewed by Oliver Hunt.
  35751. Removed an unused case of "lockHistory" to help make the other cases
  35752. clearer.
  35753. * page/FrameLoadRequest.h:
  35754. (WebCore::FrameLoadRequest::FrameLoadRequest):
  35755. 2009-01-29 David Hyatt <hyatt@apple.com>
  35756. Move all of the contination insertion code from RenderFlow to RenderInline. addChildToFlow is renamed to addChildIgnoringContinuation, and it has been moved to
  35757. RenderContainer so that it can still be called on either blocks or inlines. The base class implementation in RenderContainer is what RenderBlock uses. RenderInline
  35758. subclasses it to do all the work it used to do in addChildToFlow.
  35759. RenderBlock's old addChildToFlow can just become addChild. This simplification is possible because addChild was actually never being called on anonymous
  35760. block continuations.
  35761. The code dealing with anonymous table parts in the old addChildWithContinuation method can now be removed as a result with no harmful side effects. Falling through to the
  35762. base class and ignoring a block continuation makes the right thing happen.
  35763. addChildWithContinuation moved to RenderInline and has been renamed to addChildToContinuation.
  35764. Reviewed by Eric Seidel
  35765. * rendering/RenderBlock.cpp:
  35766. (WebCore::RenderBlock::addChild):
  35767. * rendering/RenderBlock.h:
  35768. * rendering/RenderContainer.h:
  35769. (WebCore::RenderContainer::addChildIgnoringContinuation):
  35770. * rendering/RenderFlow.cpp:
  35771. * rendering/RenderFlow.h:
  35772. * rendering/RenderInline.cpp:
  35773. (WebCore::RenderInline::styleDidChange):
  35774. (WebCore::RenderInline::addChild):
  35775. (WebCore::nextContinuation):
  35776. (WebCore::RenderInline::continuationBefore):
  35777. (WebCore::RenderInline::addChildIgnoringContinuation):
  35778. (WebCore::RenderInline::splitInlines):
  35779. (WebCore::RenderInline::splitFlow):
  35780. (WebCore::RenderInline::addChildToContinuation):
  35781. (WebCore::RenderInline::childBecameNonInline):
  35782. * rendering/RenderInline.h:
  35783. (WebCore::RenderInline::continuation):
  35784. (WebCore::RenderInline::setContinuation):
  35785. 2009-01-29 Brady Eidson <beidson@apple.com>
  35786. Reviewed by Oliver Hunt
  35787. <rdar://problem/6337157> hyundaiusa.com closes window or tab during load
  35788. Test: fast/loader/subframe-self-close.html
  35789. * page/DOMWindow.cpp:
  35790. (WebCore::DOMWindow::close): Only allow mainframes to close the window.
  35791. 2009-01-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  35792. Reviewed by David Hyatt.
  35793. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23539
  35794. Remove several virtual functions from Node & Element related to form control / input elements,
  35795. that shouldn't reside there, but move to approriate locations, in the new form control /
  35796. input element abstract base classes.
  35797. Remove the isControl() method from Node, as it's redundant - isFormControlElement() provides the same information.
  35798. Move isEnabled( / isReadOnlyControl() / isTextControl() from Node to FormControlElement.
  35799. Move isAutofilled() / isChecked() / isIndeterminate() from Node to InputElement.
  35800. Move isInputTypeHidden() / isPasswordField() from Element to InputElement.
  35801. Querying these methods requires using the toInputElement/toFormControlElement casting helper functions
  35802. to cast Element pointers to InputElement/FormControlElement pointers.
  35803. * css/CSSStyleSelector.cpp:
  35804. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  35805. (WebCore::CSSStyleSelector::adjustRenderStyle):
  35806. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  35807. * dom/Element.h:
  35808. (WebCore::Element::isFormControlElementWithState):
  35809. * dom/FormControlElement.h:
  35810. * dom/InputElement.h:
  35811. * dom/Node.h:
  35812. * editing/TextIterator.cpp:
  35813. (WebCore::TextIterator::advance):
  35814. * html/HTMLFormControlElement.cpp:
  35815. (WebCore::HTMLFormControlElement::attach):
  35816. * html/HTMLFormControlElement.h:
  35817. (WebCore::HTMLFormControlElement::isTextControl):
  35818. * html/HTMLFormElement.cpp:
  35819. (WebCore::HTMLFormElement::CheckedRadioButtons::removeButton):
  35820. * html/HTMLInputElement.h:
  35821. (WebCore::HTMLInputElement::isAutofilled):
  35822. * page/AccessibilityRenderObject.cpp:
  35823. (WebCore::AccessibilityRenderObject::isPasswordField):
  35824. (WebCore::AccessibilityRenderObject::isIndeterminate):
  35825. (WebCore::AccessibilityRenderObject::isChecked):
  35826. (WebCore::AccessibilityRenderObject::isControl):
  35827. (WebCore::AccessibilityRenderObject::isEnabled):
  35828. (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  35829. * page/mac/AccessibilityObjectWrapper.mm:
  35830. (textMarkerForVisiblePosition):
  35831. * platform/ContextMenu.cpp:
  35832. (WebCore::ContextMenu::populate):
  35833. * rendering/RenderLayer.cpp:
  35834. (WebCore::RenderLayer::resize):
  35835. * rendering/RenderMenuList.cpp:
  35836. (WebCore::RenderMenuList::itemIsEnabled):
  35837. * rendering/RenderTextControl.cpp:
  35838. (WebCore::updateUserModifyProperty):
  35839. (WebCore::RenderTextControl::adjustInnerTextStyle):
  35840. (WebCore::RenderTextControl::updateFromElement):
  35841. * rendering/RenderTheme.cpp:
  35842. (WebCore::RenderTheme::isChecked):
  35843. (WebCore::RenderTheme::isIndeterminate):
  35844. (WebCore::RenderTheme::isEnabled):
  35845. (WebCore::RenderTheme::isReadOnlyControl):
  35846. * rendering/RenderThemeMac.mm:
  35847. (WebCore::RenderThemeMac::adjustMenuListStyle):
  35848. * wml/WMLFormControlElement.cpp:
  35849. (WebCore::WMLFormControlElement::isFocusable):
  35850. * wml/WMLFormControlElement.h:
  35851. (WebCore::WMLFormControlElement::isEnabled):
  35852. (WebCore::WMLFormControlElement::isReadOnlyControl):
  35853. (WebCore::WMLFormControlElement::isTextControl):
  35854. * wml/WMLInputElement.cpp:
  35855. (WebCore::WMLInputElement::isKeyboardFocusable):
  35856. (WebCore::WMLInputElement::isMouseFocusable):
  35857. * wml/WMLInputElement.h:
  35858. (WebCore::WMLInputElement::isAutofilled):
  35859. 2009-01-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  35860. Not reviewed. Fix WML build - apply same fix as HTMLAnchorElement received.
  35861. * wml/WMLAElement.cpp:
  35862. (WebCore::WMLAElement::isKeyboardFocusable):
  35863. 2009-01-29 Alexey Proskuryakov <ap@webkit.org>
  35864. Reviewed by Anders Carlsson.
  35865. https://bugs.webkit.org/show_bug.cgi?id=23620
  35866. Crash in appcache/resource-redirect.html on Tiger
  35867. There was a bug in the test case - it didn't send a Location header, and on Tiger, this
  35868. resulted in a failure callback being sent. It turned out that proper redirects weren't
  35869. caught at all.
  35870. Tests: http/tests/appcache/manifest-redirect-2.html
  35871. http/tests/appcache/resource-redirect-2.html
  35872. * loader/appcache/ApplicationCacheGroup.cpp:
  35873. (WebCore::ApplicationCacheGroup::didFail): Fixed this function to not crash if
  35874. didReceiveResponse() wasn't called for this request.
  35875. (WebCore::ApplicationCacheGroup::didReceiveResponse): Fixed to check for redirects correctly.
  35876. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Ditto.
  35877. 2009-01-29 David Hyatt <hyatt@apple.com>
  35878. Move dirtyLinesFromChangedChild into RenderLineBoxList so that it can be shared by RenderBlock and RenderInline.
  35879. Reviewed by Sam Weinig
  35880. * rendering/RenderBlock.h:
  35881. (WebCore::RenderBlock::dirtyLinesFromChangedChild):
  35882. * rendering/RenderFlow.cpp:
  35883. * rendering/RenderFlow.h:
  35884. * rendering/RenderInline.h:
  35885. (WebCore::RenderInline::dirtyLinesFromChangedChild):
  35886. * rendering/RenderLineBoxList.cpp:
  35887. (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  35888. * rendering/RenderLineBoxList.h:
  35889. 2009-01-29 Adam Roben <aroben@apple.com>
  35890. Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
  35891. receives a WM_PRINTCLIENT message
  35892. <https://bugs.webkit.org/show_bug.cgi?id=23623>
  35893. <rdar://problem/6513921>
  35894. <rdar://problem/6536874>
  35895. Flash doesn't seem to respond to WM_PRINTCLIENT, so we change
  35896. WM_PRINTCLIENT messages into WM_PAINT messages and hook into the
  35897. BeginPaint/EndPaint APIs to return the HDC we received from
  35898. WM_PRINTCLIENT. This causes the plugin to paint into the
  35899. WM_PRINTCLIENT HDC via its normal WM_PAINT handler. This technique
  35900. came from <http://www.fengyuan.com/article/wmprint.html>.
  35901. No test possible.
  35902. Reviewed by Darin Adler.
  35903. * platform/graphics/GraphicsContext.h: Added
  35904. [set]ShouldIncludeChildWindows on Windows.
  35905. * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Added
  35906. m_shouldIncludeChildWindows.
  35907. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  35908. Initialize the new member.
  35909. * platform/graphics/win/GraphicsContextCGWin.cpp:
  35910. (WebCore::GraphicsContext::setShouldIncludeChildWindows):
  35911. (WebCore::GraphicsContext::shouldIncludeChildWindows):
  35912. Added simple setter and getter.
  35913. * plugins/PluginView.cpp:
  35914. (WebCore::PluginView::PluginView): Initialize the new member.
  35915. * plugins/PluginView.h: Added m_wmPrintHDC and various functions
  35916. required for making WM_PRINTCLIENT work.
  35917. * plugins/win/PluginViewWin.cpp:
  35918. (WebCore::PluginView::hookedBeginPaint):
  35919. (WebCore::PluginView::hookedEndPaint):
  35920. (WebCore::hook):
  35921. (WebCore::setUpOffscreenPaintingHooks):
  35922. Added. Code was modified from code available on fengyuan.com.
  35923. (WebCore::PluginView::wndProc): Turn WM_PRINTCLIENT messages into
  35924. WM_PAINT messages and save off the HDC that we're supposed to paint
  35925. into.
  35926. (WebCore::PluginView::paintWindowedPluginIntoContext): Added. Gets an
  35927. HDC from the GraphicsContext, translates it into client coordinates,
  35928. gets the plugin to draw into the HDC by sending a WM_PRINTCLIENT
  35929. message, and returns the HDC to the GraphicsContext.
  35930. (WebCore::PluginView::paint): If we're trying to paint a windowed
  35931. plugin into the GraphicsContext, call paintWindowedPluginIntoContext.
  35932. (WebCore::PluginView::init): Call setUpOffscreenPaintingHooks to make
  35933. our WM_PRINTCLIENT trick work.
  35934. 2009-01-29 David Hyatt <hyatt@apple.com>
  35935. Move RenderFlow::destroy down into RenderBlock and RenderInline.
  35936. Reviewed by Anders Carlsson
  35937. * rendering/RenderBlock.cpp:
  35938. (WebCore::RenderBlock::destroy):
  35939. * rendering/RenderFlow.cpp:
  35940. * rendering/RenderFlow.h:
  35941. * rendering/RenderInline.cpp:
  35942. (WebCore::RenderInline::destroy):
  35943. 2009-01-29 David Kilzer <ddkilzer@apple.com>
  35944. Remove semi-colons from the end of ObjC method implementations
  35945. Rubber-stamped by Adam Roben.
  35946. $ find WebCore -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
  35947. * bridge/testbindings.mm:
  35948. 2009-01-29 Adam Treat <adam.treat@torchmobile.com>
  35949. Reviewed by Alexey Proskuryakov.
  35950. https://bugs.webkit.org/show_bug.cgi?id=23609
  35951. Use the two-arg constructor for implicit QUrl->KURL conversion as the
  35952. single argument ctors assume that KURL::parse has already been called
  35953. and assert if the parse results in a different string. This was causing
  35954. an assert for QUrl's with no path and without a trailing slash.
  35955. * platform/qt/KURLQt.cpp:
  35956. (WebCore::KURL::KURL):
  35957. 2009-01-29 Alexey Proskuryakov <ap@webkit.org>
  35958. Rubber-stamped by Darin Adler.
  35959. Renamed ApplicationCacheResource::Implicit to Master, because that's the word HTML5 uses,
  35960. and it describes the meaning better.
  35961. * loader/appcache/ApplicationCache.cpp:
  35962. * loader/appcache/ApplicationCacheGroup.cpp:
  35963. * loader/appcache/ApplicationCacheResource.cpp:
  35964. * loader/appcache/ApplicationCacheResource.h:
  35965. 2009-01-29 Alexey Proskuryakov <ap@webkit.org>
  35966. Release build fix.
  35967. * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
  35968. Got rid of a variable that wasn't used in release builds.
  35969. 2009-01-29 David Hyatt <hyatt@apple.com>
  35970. Get rid of createAnonymousFlow. It was only called in one spot, so just inline the code.
  35971. Reviewed by Oliver Hunt
  35972. * rendering/RenderBlock.cpp:
  35973. (WebCore::RenderBlock::updateFirstLetter):
  35974. * rendering/RenderFlow.cpp:
  35975. * rendering/RenderFlow.h:
  35976. 2009-01-29 Alexey Proskuryakov <ap@webkit.org>
  35977. Reviewed by Anders Carlsson.
  35978. https://bugs.webkit.org/show_bug.cgi?id=23476
  35979. HTTP redirect should make application cache updating fail
  35980. Tests: http/tests/appcache/manifest-redirect.html
  35981. http/tests/appcache/resource-redirect.html
  35982. * loader/appcache/ApplicationCacheGroup.cpp:
  35983. (WebCore::ApplicationCacheGroup::didReceiveResponse):
  35984. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
  35985. Fail if response code isn't 2xx.
  35986. 2009-01-29 Alexey Proskuryakov <ap@webkit.org>
  35987. Reviewed by Anders Carlsson.
  35988. https://bugs.webkit.org/show_bug.cgi?id=23592
  35989. Update appcache manifest signature parsing
  35990. Test: http/tests/appcache/wrong-signature-2.html
  35991. * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Allow comments on signature
  35992. line. Removed code that replaced nulls with 0xFFFD characters, because there is no such
  35993. requirement in the spec.
  35994. 2009-01-28 Alexey Proskuryakov <ap@webkit.org>
  35995. Reviewed by Anders Carlsson.
  35996. https://bugs.webkit.org/show_bug.cgi?id=23584
  35997. Update application cache code for the latest round of spec changes
  35998. The changes mostly affect the update process - events are sent at a different
  35999. time, and caches are associated with documents earlier.
  36000. * loader/DocumentLoader.cpp:
  36001. (WebCore::DocumentLoader::mainReceivedError): Changed an always passing test to an assertion.
  36002. (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Caches are now associated
  36003. with DocumentLoader before being complete, but they only affect loading after being completed.
  36004. (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Ditto.
  36005. * loader/appcache/ApplicationCache.cpp:
  36006. (WebCore::ApplicationCache::setGroup): Allow setting the group to the same one, to simplify
  36007. ApplicationCacheGroup code.
  36008. (WebCore::ApplicationCache::isComplete): A new method that tells whether the cache is
  36009. complete, as defined in HTML5.
  36010. * loader/appcache/ApplicationCache.h: Added isComplete().
  36011. * loader/appcache/ApplicationCacheGroup.h:
  36012. (WebCore::ApplicationCacheUpdateOption): Per HTML5, cache updating should work differently
  36013. when invoked with or without a browsing context (Frame). A Frame is currently always needed
  36014. for updating in WebKit, so a new argument to update() tells whether we should pretend that
  36015. there isn't one.
  36016. (WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): A helper for ApplicationCache::isComplete().
  36017. (WebCore::ApplicationCacheGroup::CompletionType): Cache update algorithm now waits for
  36018. ne main resources to finish loading in more cases. A member variable of this type is used to
  36019. distinguish between different cases when waiting.
  36020. (WebCore::ApplicationCacheGroup::m_cacheCandidates): The new algorithm doesn't track cache
  36021. candidates. Caches are associated with documents much earlier, but the ones whose main resources
  36022. have not been loaded from a cache are being tracked in a pending master entry list.
  36023. * loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::update):
  36024. An explicit call to update() invokes the algorithm without a browsing context.
  36025. * loader/appcache/ApplicationCacheGroup.cpp:
  36026. (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
  36027. (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
  36028. (WebCore::ApplicationCacheGroup::selectCache):
  36029. (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
  36030. (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
  36031. (WebCore::ApplicationCacheGroup::failedLoadingMainResource):
  36032. (WebCore::ApplicationCacheGroup::stopLoading):
  36033. (WebCore::ApplicationCacheGroup::disassociateDocumentLoader):
  36034. (WebCore::ApplicationCacheGroup::cacheDestroyed):
  36035. (WebCore::ApplicationCacheGroup::setNewestCache):
  36036. (WebCore::ApplicationCacheGroup::update):
  36037. (WebCore::ApplicationCacheGroup::didReceiveResponse):
  36038. (WebCore::ApplicationCacheGroup::didFinishLoading):
  36039. (WebCore::ApplicationCacheGroup::didFail):
  36040. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
  36041. (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
  36042. (WebCore::ApplicationCacheGroup::manifestNotFound):
  36043. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
  36044. (WebCore::ApplicationCacheGroup::startLoadingEntry):
  36045. (WebCore::ApplicationCacheGroup::deliverDelayedMainResources):
  36046. (WebCore::ApplicationCacheGroup::addEntry):
  36047. (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache):
  36048. (WebCore::CallCacheListenerTask::create):
  36049. (WebCore::CallCacheListenerTask::performTask):
  36050. (WebCore::CallCacheListenerTask::CallCacheListenerTask):
  36051. (WebCore::ApplicationCacheGroup::postListenerTask):
  36052. Rewrote the update algorithm.
  36053. 2009-01-28 Geoffrey Garen <ggaren@apple.com>
  36054. Reviewed by Sam Weinig.
  36055. Merged FrameLoadTypeReloadAllowingStaleData with FrameLoadTypeReload.
  36056. Technically, selecting View->Text Encoding->[Non-Default Encoding] on
  36057. a page with frames may now be slightly slower than it used to be. Oh well.
  36058. * loader/FrameLoader.cpp:
  36059. (WebCore::isBackForwardLoadType):
  36060. (WebCore::FrameLoader::restoreDocumentState): Subbed in FrameLoadTypeReload.
  36061. (WebCore::FrameLoader::loadURLIntoChildFrame): No need to account for
  36062. non-back-forward navigations anymore.
  36063. (WebCore::FrameLoader::canCachePage):
  36064. (WebCore::FrameLoader::logCanCachePageDecision):
  36065. (WebCore::FrameLoader::reloadWithOverrideEncoding):
  36066. (WebCore::FrameLoader::transitionToCommitted):
  36067. (WebCore::FrameLoader::loadItem): Subbed in FrameLoadTypeReload.
  36068. * loader/FrameLoader.h: Renamed reloadAllowingStaleData => reloadWithOverrideEncoding,
  36069. since that's what it actually does.
  36070. 2009-01-28 David Hyatt <hyatt@apple.com>
  36071. Move hit testing and painting of lines from RenderFlow into RenderLineBoxList.
  36072. Reviewed by Oliver Hunt
  36073. * rendering/RenderBlock.cpp:
  36074. (WebCore::RenderBlock::paintContents):
  36075. (WebCore::RenderBlock::hitTestContents):
  36076. * rendering/RenderFlow.cpp:
  36077. * rendering/RenderFlow.h:
  36078. * rendering/RenderInline.cpp:
  36079. (WebCore::RenderInline::paint):
  36080. (WebCore::RenderInline::nodeAtPoint):
  36081. * rendering/RenderLineBoxList.cpp:
  36082. (WebCore::RenderLineBoxList::paint):
  36083. (WebCore::RenderLineBoxList::hitTest):
  36084. * rendering/RenderLineBoxList.h:
  36085. 2009-01-28 David Hyatt <hyatt@apple.com>
  36086. Fix SVG pixel test regressions. I wish I could say that I understand this fix, but I don't. For
  36087. some reason the original code returned 0 for RenderSVGInlineText::yPos() and somehow my literal
  36088. replacement of yPos() with the body of that method changed the results. I am completely baffled,
  36089. but all SVG pixel tests pass again when I just take the code out.
  36090. Reviewed by Oliver Hunt
  36091. * rendering/RenderSVGInlineText.cpp:
  36092. (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
  36093. 2009-01-28 David Hyatt <hyatt@apple.com>
  36094. Move dirtyLineBoxes from RenderFlow to RenderInline and RenderBlock.
  36095. Reviewed by Oliver Hunt
  36096. * rendering/RenderBlock.cpp:
  36097. (WebCore::RenderBlock::dirtyLineBoxes):
  36098. * rendering/RenderBlock.h:
  36099. * rendering/RenderFlow.cpp:
  36100. * rendering/RenderFlow.h:
  36101. * rendering/RenderInline.cpp:
  36102. (WebCore::RenderInline::dirtyLineBoxes):
  36103. * rendering/RenderInline.h:
  36104. * rendering/RenderLineBoxList.cpp:
  36105. (WebCore::RenderLineBoxList::dirtyLineBoxes):
  36106. * rendering/RenderLineBoxList.h:
  36107. 2009-01-28 David Hyatt <hyatt@apple.com>
  36108. Back out my change to scrollWidth/Height from an earlier checkin since it broke stuff. The current
  36109. behavior is not correct, but this will need to be investigated before being changed again.
  36110. * rendering/RenderBox.cpp:
  36111. (WebCore::RenderBox::scrollWidth):
  36112. (WebCore::RenderBox::scrollHeight):
  36113. 2009-01-28 David Hyatt <hyatt@apple.com>
  36114. Move paintOutline and paintOutlineWithLine from RenderFlow to RenderInline, since they only apply to inlines. Tighten up all of the code that
  36115. called paintOutline to use RenderInline as the type instead of RenderFlow.
  36116. Reviewed by cpst
  36117. * rendering/InlineFlowBox.cpp:
  36118. (WebCore::InlineFlowBox::paint):
  36119. * rendering/RenderBlock.cpp:
  36120. (WebCore::RenderBlock::paintObject):
  36121. (WebCore::RenderBlock::addContinuationWithOutline):
  36122. (WebCore::RenderBlock::paintContinuationOutlines):
  36123. * rendering/RenderFlow.cpp:
  36124. (WebCore::RenderFlow::paintLines):
  36125. * rendering/RenderFlow.h:
  36126. * rendering/RenderInline.cpp:
  36127. (WebCore::RenderInline::paintOutline):
  36128. (WebCore::RenderInline::paintOutlineForLine):
  36129. * rendering/RenderInline.h:
  36130. * rendering/RenderObject.cpp:
  36131. (WebCore::RenderObject::paintOutline):
  36132. * rendering/RenderObject.h:
  36133. (WebCore::RenderObject::PaintInfo::PaintInfo):
  36134. 2009-01-28 Darin Fisher <darin@chromium.org>
  36135. Reviewed by Eric Seidel.
  36136. https://bugs.webkit.org/show_bug.cgi?id=23596
  36137. XMLHttpRequest.cpp no longer compiles without USE(JSC)
  36138. * xml/XMLHttpRequest.cpp:
  36139. 2009-01-28 Darin Fisher <darin@chromium.org>
  36140. Reviewed by Darin Adler.
  36141. https://bugs.webkit.org/show_bug.cgi?id=23597
  36142. Make it possible to compile Database.cpp when USE(JSC) is not defined
  36143. * storage/Database.cpp:
  36144. (WebCore::Database::Database):
  36145. 2009-01-28 Dan Bernstein <mitz@apple.com>
  36146. Reviewed by Darin Adler.
  36147. - fix <rdar://problem/6077047> REGRESSION (r34544): Custom icon does not
  36148. appear in address field on first visit to any site
  36149. * loader/icon/IconLoader.cpp:
  36150. (WebCore::IconLoader::finishLoading): Changed to set the icon data only
  36151. after establishing a mapping from the page URL(s) to the icon. Doing
  36152. things the other way around resulted in the data not being cached
  36153. in the icon-URL to IconRecord map (because there was no interested page
  36154. at the time) and subsequently having to be fetched asynchronously from
  36155. the database when the page-to-icon mapping was established.
  36156. 2009-01-28 David Hyatt <hyatt@apple.com>
  36157. Move addFocusRingRects from RenderFlow down into RenderBlock and RenderInline.
  36158. Reviewed by Oliver Hunt
  36159. * rendering/RenderBlock.cpp:
  36160. (WebCore::RenderBlock::addFocusRingRects):
  36161. * rendering/RenderBlock.h:
  36162. * rendering/RenderFlow.cpp:
  36163. * rendering/RenderFlow.h:
  36164. * rendering/RenderInline.cpp:
  36165. (WebCore::RenderInline::addFocusRingRects):
  36166. * rendering/RenderInline.h:
  36167. 2009-01-28 David Hyatt <hyatt@apple.com>
  36168. Move localCaretRect from RenderFlow into RenderBlock, since it only applied to blocks anyway and
  36169. was misplaced from the start.
  36170. Reviewed by Antti Koivisto.
  36171. * rendering/RenderBlock.cpp:
  36172. (WebCore::RenderBlock::localCaretRect):
  36173. * rendering/RenderBlock.h:
  36174. * rendering/RenderFlow.cpp:
  36175. * rendering/RenderFlow.h:
  36176. 2009-01-28 Sam Weinig <sam@webkit.org>
  36177. Reviewed by Geoff Garen.
  36178. Add forwarding header.
  36179. * ForwardingHeaders/debugger/DebuggerActivation.h: Added.
  36180. 2009-01-28 David Hyatt <hyatt@apple.com>
  36181. Move createInlineBox out of RenderFlow and down into RenderInline and RenderBlock.
  36182. Reviewed by Beth Dakin
  36183. * rendering/RenderBlock.cpp:
  36184. (WebCore::RenderBlock::createInlineBox):
  36185. * rendering/RenderBlock.h:
  36186. * rendering/RenderFlow.cpp:
  36187. * rendering/RenderFlow.h:
  36188. * rendering/RenderInline.cpp:
  36189. (WebCore::RenderInline::createInlineBox):
  36190. * rendering/RenderInline.h:
  36191. * rendering/bidi.cpp:
  36192. 2009-01-28 David Hyatt <hyatt@apple.com>
  36193. Move calcMargins from RenderFlow to RenderInline, since it was only ever called on RenderInlines.
  36194. Reviewed by Oliver Hunt
  36195. * rendering/RenderFlow.cpp:
  36196. * rendering/RenderFlow.h:
  36197. * rendering/RenderInline.h:
  36198. (WebCore::RenderInline::calcMargins):
  36199. * rendering/bidi.cpp:
  36200. (WebCore::RenderBlock::layoutInlineChildren):
  36201. 2009-01-28 David Hyatt <hyatt@apple.com>
  36202. Refactor the first and last line box member variables from RenderFlow. Encapsulate them into a new class called RenderLineBoxList that manages all modifications to
  36203. the list. This change will make it easier to give RenderInline and RenderBlock separate versions of the line box list without having to duplicate very much code.
  36204. Reviewed by Oliver Hunt
  36205. * GNUmakefile.am:
  36206. * WebCore.pro:
  36207. * WebCore.vcproj/WebCore.vcproj:
  36208. * WebCore.xcodeproj/project.pbxproj:
  36209. * WebCoreSources.bkl:
  36210. * rendering/InlineFlowBox.cpp:
  36211. (WebCore::InlineFlowBox::deleteLine):
  36212. (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
  36213. (WebCore::InlineFlowBox::extractLine):
  36214. (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
  36215. (WebCore::InlineFlowBox::attachLine):
  36216. (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
  36217. * rendering/InlineFlowBox.h:
  36218. * rendering/RenderBlock.cpp:
  36219. (WebCore::RenderBlock::deleteLineBoxTree):
  36220. * rendering/RenderFlow.cpp:
  36221. (WebCore::RenderFlow::destroy):
  36222. (WebCore::RenderFlow::dirtyLineBoxes):
  36223. (WebCore::RenderFlow::createInlineBox):
  36224. * rendering/RenderFlow.h:
  36225. (WebCore::RenderFlow::RenderFlow):
  36226. (WebCore::RenderFlow::lineBoxes):
  36227. (WebCore::RenderFlow::firstLineBox):
  36228. (WebCore::RenderFlow::lastLineBox):
  36229. * rendering/RenderLineBoxList.cpp: Added.
  36230. (WebCore::RenderLineBoxList::~RenderLineBoxList):
  36231. (WebCore::RenderLineBoxList::appendLineBox):
  36232. (WebCore::RenderLineBoxList::deleteLineBoxTree):
  36233. (WebCore::RenderLineBoxList::extractLineBox):
  36234. (WebCore::RenderLineBoxList::attachLineBox):
  36235. (WebCore::RenderLineBoxList::removeLineBox):
  36236. (WebCore::RenderLineBoxList::deleteLineBoxes):
  36237. (WebCore::RenderLineBoxList::checkConsistency):
  36238. * rendering/RenderLineBoxList.h: Added.
  36239. (WebCore::RenderLineBoxList::RenderLineBoxList):
  36240. (WebCore::RenderLineBoxList::firstLineBox):
  36241. (WebCore::RenderLineBoxList::lastLineBox):
  36242. (WebCore::RenderLineBoxList::checkConsistency):
  36243. * rendering/RenderSVGInline.cpp:
  36244. (WebCore::RenderSVGInline::createInlineBox):
  36245. * rendering/RenderSVGText.cpp:
  36246. (WebCore::RenderSVGText::createInlineBox):
  36247. * rendering/RootInlineBox.cpp:
  36248. (WebCore::RootInlineBox::removeLineBoxFromRenderObject):
  36249. (WebCore::RootInlineBox::extractLineBoxFromRenderObject):
  36250. (WebCore::RootInlineBox::attachLineBoxToRenderObject):
  36251. * rendering/RootInlineBox.h:
  36252. * rendering/bidi.cpp:
  36253. (WebCore::RenderBlock::layoutInlineChildren):
  36254. 2009-01-28 David Kilzer <ddkilzer@apple.com>
  36255. Clean up FontPlatformData constructor
  36256. Reviewed by David Hyatt.
  36257. * platform/graphics/mac/FontPlatformData.h: Updated copyright.
  36258. (WebCore::FontPlatformData::FontPlatformData): Provide readable
  36259. names for constructor arguments and reformat member variables.
  36260. * platform/graphics/mac/FontPlatformDataMac.mm: Updated copyright.
  36261. (WebCore::FontPlatformData::FontPlatformData): Provide readable
  36262. names for constructor arguments and reformat member variables.
  36263. 2009-01-28 Tony Chang <tony@chromium.org>
  36264. Reviewed by David Hyatt.
  36265. https://bugs.webkit.org/show_bug.cgi?id=23593
  36266. Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
  36267. This is a follow up for hyatt's RenderBox changes.
  36268. * rendering/RenderThemeChromiumMac.mm:
  36269. (WebCore::RenderThemeChromiumMac::baselinePosition):
  36270. * rendering/RenderThemeChromiumWin.cpp:
  36271. (WebCore::RenderThemeChromiumWin::paintMenuList):
  36272. 2009-01-28 Simon Fraser <simon.fraser@apple.com>
  36273. Reviewed by Dave Hyatt
  36274. https://bugs.webkit.org/show_bug.cgi?id=23582
  36275. Fix assertions when inline elements have both opacity (or something
  36276. else that creates a RenderLayer), and transform by ensuring that
  36277. setHasTransform() is only called for non-inline or replaced elements.
  36278. We also have to ensure that RenderReplicas will get transforms applied
  36279. to them by lying about them being replaced.
  36280. Tests: fast/transforms/transform-on-inline.html
  36281. fast/transforms/transform-table-row.html
  36282. * rendering/RenderBox.cpp:
  36283. (WebCore::RenderBox::styleDidChange):
  36284. * rendering/RenderReplica.cpp:
  36285. (WebCore::RenderReplica::RenderReplica):
  36286. * rendering/RenderTableRow.h:
  36287. (WebCore::RenderTableRow::requiresLayer):
  36288. 2009-01-28 Hironori Bono <hbono@chromium.org>
  36289. Reviewed by Justin Garcia.
  36290. https://bugs.webkit.org/show_bug.cgi?id=18835
  36291. Spelling underlines disappear when they shouldn't
  36292. The WebCore::InsertLineBreakCommand::doApply() function splits a text node
  36293. without copying existing markers. To fix this bug, change code which
  36294. manually splits a text node into a CompositeEditCommand::splitTextNode() call.
  36295. Test: editing/spelling/spelling-linebreak.html
  36296. * editing/InsertLineBreakCommand.cpp:
  36297. (WebCore::InsertLineBreakCommand::doApply):
  36298. 2009-01-28 David Hyatt <hyatt@apple.com>
  36299. Move the m_lineHeight member variable out of RenderFlow and down into RenderBlock and RenderInline. Shift the line height computation into RenderStyle so
  36300. that it isn't repeated in three places.
  36301. Reviewed by Sam Weinig
  36302. * rendering/RenderBlock.cpp:
  36303. (WebCore::RenderBlock::RenderBlock):
  36304. (WebCore::RenderBlock::lineHeight):
  36305. * rendering/RenderBlock.h:
  36306. * rendering/RenderFlow.cpp:
  36307. * rendering/RenderFlow.h:
  36308. (WebCore::RenderFlow::RenderFlow):
  36309. * rendering/RenderInline.cpp:
  36310. (WebCore::RenderInline::RenderInline):
  36311. (WebCore::RenderInline::lineHeight):
  36312. * rendering/RenderInline.h:
  36313. * rendering/RenderObject.cpp:
  36314. (WebCore::RenderObject::lineHeight):
  36315. * rendering/style/RenderStyle.h:
  36316. (WebCore::InheritedFlags::computedLineHeight):
  36317. 2009-01-28 Zachary Kuznia <zork@chromiuum.org>
  36318. Reviewed by Sam Weinig.
  36319. https://bugs.webkit.org/show_bug.cgi?id=22070
  36320. Add an option to allow scripts to close windows.
  36321. * page/Settings.cpp:
  36322. (WebCore::Settings::Settings):
  36323. (WebCore::Settings::setAllowScriptsToCloseWindows):
  36324. * page/Settings.h:
  36325. (WebCore::Settings::allowScriptsToCloseWindows):
  36326. 2009-01-28 Adam Langley <agl@google.com>
  36327. Reviewed by Sam Weinig.
  36328. https://bugs.webkit.org/show_bug.cgi?id=23573
  36329. Make PlatformWidget on chromium an intptr_t to match changes made in Chromium
  36330. * platform/chromium/PlatformWidget.h:
  36331. 2009-01-28 David Hyatt <hyatt@apple.com>
  36332. Fix for
  36333. <rdar://problem/6531287> REGRESSION: CrashTracer: [USER] 12 crashes in Safari at com.apple.WebCore • WebCore::RenderBlock::removeFloatingObject + 59
  36334. My tightening up of markAllDescendantsWithFloatsForLayout exposed a buggy check in that code that could
  36335. lead to a bad cast.
  36336. * rendering/RenderBlock.cpp:
  36337. (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  36338. 2009-01-27 David Hyatt <hyatt@apple.com>
  36339. https://bugs.webkit.org/show_bug.cgi?id=23576
  36340. Work towards eliminating RenderFlow from the tree.
  36341. Move the m_continuation variable down from RenderFlow into RenderInline and RenderBlock. Since a block can only have an inline continuation following it, the type
  36342. of the member and methods reflect this (inlineContinuation() and m_inlineContinuation). Since an inline can have either a block or an inline continuation following it,
  36343. a base class of RenderBox* is used for the type of object returned (in anticipation of the removal of RenderFlow).
  36344. Since moving the continuation variable down into the subclasses increased the size of RenderInline and RenderBlock by 4 bytes, this patch also moves all of the bitfield
  36345. members of RenderFlow up to RenderObject. Since they fit within the available bits on RenderObject, this patch actually results in a net savings of 4 bytes on RenderInlines
  36346. and RenderBlocks!
  36347. One bitfield member was eliminated rather than moved: m_firstLine. This was really more of a state variable used during line layout only, so I removed it as a member
  36348. and just passed firstLine down to various methods as needed. Doing so uncovered some potential bugs where the first line state was not being respected when querying for
  36349. line offsets.
  36350. Continuations have been completely hidden from all files except for RenderFlow, RenderBlock and RenderInline. All of the code that referenced continuations directly
  36351. from base classes has been refactored to use virtual methods on RenderBlock and RenderInline instead.
  36352. RenderFlow still has a common addChildWithContinuation method that is used by both blocks and inlines. Since refactoring that method will be pretty tricky, I've held
  36353. off on that for a later patch.
  36354. Reviewed by Oliver Hunt
  36355. * html/HTMLAnchorElement.cpp:
  36356. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  36357. * page/AccessibilityRenderObject.cpp:
  36358. (WebCore::AccessibilityRenderObject::anchorElement):
  36359. (WebCore::AccessibilityRenderObject::boundingBoxRect):
  36360. * rendering/InlineFlowBox.cpp:
  36361. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  36362. (WebCore::InlineFlowBox::paint):
  36363. * rendering/RenderBlock.cpp:
  36364. (WebCore::RenderBlock::RenderBlock):
  36365. (WebCore::RenderBlock::~RenderBlock):
  36366. (WebCore::RenderBlock::destroy):
  36367. (WebCore::RenderBlock::addChildToFlow):
  36368. (WebCore::RenderBlock::makeChildrenNonInline):
  36369. (WebCore::RenderBlock::removeChild):
  36370. (WebCore::RenderBlock::layoutBlock):
  36371. (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
  36372. (WebCore::RenderBlock::collapseMargins):
  36373. (WebCore::RenderBlock::determineHorizontalPosition):
  36374. (WebCore::RenderBlock::setCollapsedBottomMargin):
  36375. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  36376. (WebCore::RenderBlock::paintObject):
  36377. (WebCore::RenderBlock::addContinuationWithOutline):
  36378. (WebCore::RenderBlock::setSelectionState):
  36379. (WebCore::RenderBlock::shouldPaintSelectionGaps):
  36380. (WebCore::RenderBlock::fillSelectionGaps):
  36381. (WebCore::RenderBlock::leftSelectionOffset):
  36382. (WebCore::RenderBlock::rightSelectionOffset):
  36383. (WebCore::RenderBlock::leftOffset):
  36384. (WebCore::RenderBlock::leftRelOffset):
  36385. (WebCore::RenderBlock::rightOffset):
  36386. (WebCore::RenderBlock::rightRelOffset):
  36387. (WebCore::RenderBlock::lineWidth):
  36388. (WebCore::RenderBlock::lowestPosition):
  36389. (WebCore::RenderBlock::rightmostPosition):
  36390. (WebCore::RenderBlock::leftmostPosition):
  36391. (WebCore::RenderBlock::getClearDelta):
  36392. (WebCore::RenderBlock::nodeAtPoint):
  36393. (WebCore::RenderBlock::offsetForContents):
  36394. (WebCore::RenderBlock::availableWidth):
  36395. (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
  36396. (WebCore::RenderBlock::desiredColumnWidth):
  36397. (WebCore::RenderBlock::desiredColumnCount):
  36398. (WebCore::RenderBlock::columnRects):
  36399. (WebCore::RenderBlock::layoutColumns):
  36400. (WebCore::RenderBlock::adjustPointToColumnContents):
  36401. (WebCore::RenderBlock::adjustRectForColumns):
  36402. (WebCore::RenderBlock::absoluteRects):
  36403. (WebCore::RenderBlock::absoluteQuads):
  36404. (WebCore::RenderBlock::rectWithOutlineForRepaint):
  36405. (WebCore::RenderBlock::hoverAncestor):
  36406. (WebCore::RenderBlock::updateDragState):
  36407. (WebCore::RenderBlock::outlineStyleForRepaint):
  36408. (WebCore::RenderBlock::childBecameNonInline):
  36409. (WebCore::RenderBlock::updateHitTestResult):
  36410. * rendering/RenderBlock.h:
  36411. (WebCore::RenderBlock::rightOffset):
  36412. (WebCore::RenderBlock::leftOffset):
  36413. (WebCore::RenderBlock::inlineContinuation):
  36414. (WebCore::RenderBlock::setInlineContinuation):
  36415. * rendering/RenderBox.cpp:
  36416. (WebCore::RenderBox::absoluteRects):
  36417. (WebCore::RenderBox::absoluteQuads):
  36418. (WebCore::RenderBox::addFocusRingRects):
  36419. (WebCore::RenderBox::containingBlockWidth):
  36420. * rendering/RenderBox.h:
  36421. (WebCore::RenderBox::collapsedMarginBottom):
  36422. (WebCore::RenderBox::childBecameNonInline):
  36423. * rendering/RenderContainer.cpp:
  36424. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  36425. (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
  36426. * rendering/RenderFlexibleBox.cpp:
  36427. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  36428. * rendering/RenderFlow.cpp:
  36429. (WebCore::nextContinuation):
  36430. (WebCore::RenderFlow::continuationBefore):
  36431. (WebCore::RenderFlow::addChildWithContinuation):
  36432. (WebCore::RenderFlow::addChild):
  36433. (WebCore::RenderFlow::destroy):
  36434. (WebCore::RenderFlow::addFocusRingRects):
  36435. * rendering/RenderFlow.h:
  36436. (WebCore::RenderFlow::RenderFlow):
  36437. * rendering/RenderInline.cpp:
  36438. (WebCore::RenderInline::RenderInline):
  36439. (WebCore::RenderInline::destroy):
  36440. (WebCore::RenderInline::inlineContinuation):
  36441. (WebCore::RenderInline::styleDidChange):
  36442. (WebCore::RenderInline::addChildToFlow):
  36443. (WebCore::RenderInline::cloneInline):
  36444. (WebCore::RenderInline::splitInlines):
  36445. (WebCore::RenderInline::splitFlow):
  36446. (WebCore::RenderInline::positionForCoordinates):
  36447. (WebCore::RenderInline::rectWithOutlineForRepaint):
  36448. (WebCore::RenderInline::updateDragState):
  36449. (WebCore::RenderInline::childBecameNonInline):
  36450. (WebCore::RenderInline::updateHitTestResult):
  36451. * rendering/RenderInline.h:
  36452. (WebCore::RenderInline::isRenderInline):
  36453. (WebCore::RenderInline::continuation):
  36454. (WebCore::RenderInline::setContinuation):
  36455. * rendering/RenderListItem.cpp:
  36456. (WebCore::RenderListItem::positionListMarker):
  36457. * rendering/RenderListMarker.cpp:
  36458. (WebCore::RenderListMarker::RenderListMarker):
  36459. (WebCore::RenderListMarker::setSelectionState):
  36460. * rendering/RenderListMarker.h:
  36461. * rendering/RenderObject.cpp:
  36462. (WebCore::RenderObject::RenderObject):
  36463. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  36464. (WebCore::RenderObject::rectWithOutlineForRepaint):
  36465. (WebCore::RenderObject::handleDynamicFloatPositionChange):
  36466. (WebCore::RenderObject::updateDragState):
  36467. (WebCore::RenderObject::updateHitTestResult):
  36468. (WebCore::RenderObject::getTextDecorationColors):
  36469. (WebCore::RenderObject::adjustRectForOutlineAndShadow):
  36470. * rendering/RenderObject.h:
  36471. (WebCore::RenderObject::isInlineBlockOrInlineTable):
  36472. (WebCore::RenderObject::childrenInline):
  36473. (WebCore::RenderObject::setChildrenInline):
  36474. (WebCore::RenderObject::hasColumns):
  36475. (WebCore::RenderObject::setHasColumns):
  36476. (WebCore::RenderObject::cellWidthChanged):
  36477. (WebCore::RenderObject::setCellWidthChanged):
  36478. (WebCore::RenderObject::isInlineContinuation):
  36479. (WebCore::RenderObject::hoverAncestor):
  36480. (WebCore::RenderObject::outlineStyleForRepaint):
  36481. (WebCore::RenderObject::setHasMarkupTruncation):
  36482. (WebCore::RenderObject::hasMarkupTruncation):
  36483. (WebCore::RenderObject::selectionState):
  36484. (WebCore::RenderObject::setSelectionState):
  36485. (WebCore::RenderObject::hasSelectedChildren):
  36486. (WebCore::RenderObject::isTopMarginQuirk):
  36487. (WebCore::RenderObject::isBottomMarginQuirk):
  36488. (WebCore::RenderObject::setTopMarginQuirk):
  36489. (WebCore::RenderObject::setBottomMarginQuirk):
  36490. * rendering/RenderReplaced.cpp:
  36491. (WebCore::RenderReplaced::RenderReplaced):
  36492. (WebCore::RenderReplaced::setSelectionState):
  36493. * rendering/RenderReplaced.h:
  36494. (WebCore::RenderReplaced::canBeSelectionLeaf):
  36495. * rendering/RenderTable.cpp:
  36496. (WebCore::RenderTable::calcWidth):
  36497. * rendering/RenderTableCell.cpp:
  36498. (WebCore::RenderTableCell::updateWidth):
  36499. (WebCore::RenderTableCell::layout):
  36500. * rendering/RenderText.cpp:
  36501. (WebCore::RenderText::RenderText):
  36502. (WebCore::RenderText::localCaretRect):
  36503. (WebCore::RenderText::setSelectionState):
  36504. * rendering/RenderText.h:
  36505. (WebCore::RenderText::canBeSelectionLeaf):
  36506. * rendering/RenderView.cpp:
  36507. (WebCore::RenderView::updateHitTestResult):
  36508. * rendering/RenderView.h:
  36509. * rendering/RootInlineBox.cpp:
  36510. (WebCore::RootInlineBox::selectionTop):
  36511. * rendering/bidi.cpp:
  36512. (WebCore::RenderBlock::createLineBoxes):
  36513. (WebCore::RenderBlock::constructLine):
  36514. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  36515. (WebCore::RenderBlock::layoutInlineChildren):
  36516. (WebCore::RenderBlock::determineStartPosition):
  36517. (WebCore::RenderBlock::skipTrailingWhitespace):
  36518. (WebCore::RenderBlock::skipLeadingWhitespace):
  36519. (WebCore::RenderBlock::fitBelowFloats):
  36520. (WebCore::RenderBlock::findNextLineBreak):
  36521. (WebCore::RenderBlock::checkLinesForTextOverflow):
  36522. 2009-01-28 Adam Treat <adam.treat@torchmobile.com>
  36523. Reviewed by Nikolas Zimmermann and George Staikos.
  36524. https://bugs.webkit.org/show_bug.cgi?id=23557
  36525. Allow option of hit testing frame content without clipping to the visible
  36526. viewport.
  36527. * WebCore.base.exp:
  36528. * page/EventHandler.cpp:
  36529. (WebCore::EventHandler::hitTestResultAtPoint):
  36530. * page/EventHandler.h:
  36531. * rendering/HitTestRequest.h:
  36532. (WebCore::HitTestRequest::HitTestRequest):
  36533. * rendering/RenderLayer.cpp:
  36534. (WebCore::RenderLayer::hitTest):
  36535. 2009-01-28 Simon Hausmann <simon.hausmann@nokia.com>
  36536. Reviewed by Holger Freyther.
  36537. Fix the build with Qt on Windows.
  36538. Make sure that the QTWEBKIT_EXPORT macro becomes the Q_DECL_EXPORT macro
  36539. instead of the import macro when building the dll, by defining
  36540. QT_MAKEDLL.
  36541. SystemTimeWin.cpp is needed on Windows for userIdleTime(), which for the
  36542. other Qt platforms comes from TemporaryLinkStubs.cpp.
  36543. * WebCore.pro:
  36544. 2009-01-28 Ariya Hidayat <ariya.hidayat@trolltech.com>
  36545. Reviewed by Simon Hausmann.
  36546. [Qt] Speed-up clipping: avoid calling expensive QPainter::clipRegion().
  36547. Beside, the check is not necessary since QPainter::setClipRect() will
  36548. work just fine if there is no clip region yet.
  36549. * platform/graphics/qt/GraphicsContextQt.cpp:
  36550. (WebCore::GraphicsContext::clip):
  36551. 2009-01-28 Darin Fisher <darin@chromium.org>
  36552. Reviewed by Darin Adler.
  36553. https://bugs.webkit.org/show_bug.cgi?id=23546
  36554. Upstream GoogleURL implementation of KURL
  36555. * platform/KURL.h:
  36556. * platform/KURLGoogle.cpp: Added.
  36557. * platform/KURLGooglePrivate.h: Added.
  36558. 2009-01-27 Darin Adler <darin@apple.com>
  36559. Reviewed by Sam Weinig.
  36560. REGRESSION (r40234): Launching iTunes from a link displays a
  36561. "Safari can't find the Internet plug-in" sheet in Safari
  36562. rdar://problem/6533678
  36563. * rendering/RenderPartObject.cpp:
  36564. (WebCore::havePlugin): Put the check for empty string in here.
  36565. (WebCore::serviceTypeForClassId): Only return activeXType() if
  36566. we have a plug-in that can handle that type. While it might be logical
  36567. to return an Active X type for any <object> with a classId in it,
  36568. even if we don't have a plug-in that implements Active X, existing
  36569. clients, such as Safari, don't expect that.
  36570. 2009-01-27 Dan Bernstein <mitz@apple.com>
  36571. Reviewed by Steve Falkenburg.
  36572. - fix <rdar://problem/6524351> Text looks bad when font smoothing is
  36573. forced off
  36574. * platform/graphics/win/FontCGWin.cpp:
  36575. (WebCore::Font::drawGlyphs): Changed to use GDI rather than Core
  36576. Graphics if the client has turned font smoothing off.
  36577. 2009-01-27 Simon Fraser <simon.fraser@apple.com>
  36578. Reviewed by Dave Hyatt
  36579. https://bugs.webkit.org/show_bug.cgi?id=23360
  36580. Use the new container-relative repaint methods to compute
  36581. post-layout repaints, and repaints using RenderLayer's
  36582. cached repaintRect() relative to that container, rather than
  36583. using absolute coords.
  36584. Replaced lots of boilerplate old/new rect code in various
  36585. layout methods with a stack-based LayoutRepainter class, and
  36586. fixed a bug in RenderTable which set didFullRepaint to
  36587. 'true' every time.
  36588. * rendering/RenderBlock.cpp:
  36589. (WebCore::RenderBlock::layoutBlock):
  36590. * rendering/RenderFlexibleBox.cpp:
  36591. (WebCore::RenderFlexibleBox::layoutBlock):
  36592. * rendering/RenderForeignObject.cpp:
  36593. (WebCore::RenderForeignObject::layout):
  36594. * rendering/RenderLayer.cpp:
  36595. (WebCore::RenderLayer::updateLayerPositions):
  36596. (WebCore::RenderLayer::setHasVisibleContent):
  36597. * rendering/RenderLayer.h:
  36598. * rendering/RenderObject.cpp:
  36599. (WebCore::RenderObject::repaintUsingContainer):
  36600. (WebCore::RenderObject::repaint):
  36601. (WebCore::RenderObject::repaintRectangle):
  36602. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  36603. * rendering/RenderObject.h:
  36604. (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
  36605. (WebCore::RenderObject::LayoutRepainter::repaintAfterLayout):
  36606. (WebCore::RenderObject::LayoutRepainter::checkForRepaint):
  36607. * rendering/RenderPath.cpp:
  36608. (WebCore::RenderPath::layout):
  36609. * rendering/RenderReplaced.cpp:
  36610. (WebCore::RenderReplaced::layout):
  36611. * rendering/RenderSVGContainer.cpp:
  36612. (WebCore::RenderSVGContainer::layout):
  36613. * rendering/RenderSVGImage.cpp:
  36614. (WebCore::RenderSVGImage::layout):
  36615. * rendering/RenderSVGRoot.cpp:
  36616. (WebCore::RenderSVGRoot::layout):
  36617. * rendering/RenderSVGText.cpp:
  36618. (WebCore::RenderSVGText::layout):
  36619. * rendering/RenderSVGViewportContainer.cpp:
  36620. (WebCore::RenderSVGViewportContainer::layout):
  36621. * rendering/RenderTable.cpp:
  36622. (WebCore::RenderTable::layout):
  36623. * rendering/bidi.cpp:
  36624. (WebCore::RenderBlock::layoutInlineChildren):
  36625. 2009-01-27 Brady Eidson <beidson@apple.com>
  36626. Reviewed by Darin Adler
  36627. <rdar://problem/3541409> - More groundwork and cleanup for CachedFrames
  36628. * history/CachedFrame.cpp:
  36629. (WebCore::CachedFrame::CachedFrame): Make the savePlatformDataToCachedFrame() client call here,
  36630. and add the code for caching subframes.
  36631. (WebCore::CachedFrame::clear):
  36632. * history/CachedFrame.h: Change to be RefCounted
  36633. (WebCore::CachedFrame::create):
  36634. (WebCore::CachedFrame::url):
  36635. * history/CachedPage.cpp:
  36636. (WebCore::CachedPage::CachedPage):
  36637. (WebCore::CachedPage::restore):
  36638. * history/CachedPage.h:
  36639. (WebCore::CachedPage::document):
  36640. (WebCore::CachedPage::documentLoader):
  36641. (WebCore::CachedPage::view):
  36642. (WebCore::CachedPage::url):
  36643. (WebCore::CachedPage::domWindow):
  36644. (WebCore::CachedPage::cachedMainFrame):
  36645. * loader/FrameLoader.cpp:
  36646. (WebCore::FrameLoader::cachePageForHistoryItem): Move the platform data saving into the
  36647. CachedFrame itself.
  36648. 2009-01-27 Simon Fraser <simon.fraser@apple.com>
  36649. Reviewed by Dave Hyatt
  36650. Flip the arguments of computeRectForRepaint() from
  36651. computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)
  36652. to
  36653. computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)
  36654. * rendering/RenderBox.cpp:
  36655. (WebCore::RenderBox::clippedOverflowRectForRepaint):
  36656. (WebCore::RenderBox::computeRectForRepaint):
  36657. * rendering/RenderBox.h:
  36658. * rendering/RenderForeignObject.cpp:
  36659. (WebCore::RenderForeignObject::computeRectForRepaint):
  36660. * rendering/RenderForeignObject.h:
  36661. * rendering/RenderInline.cpp:
  36662. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  36663. * rendering/RenderObject.cpp:
  36664. (WebCore::RenderObject::computeRectForRepaint):
  36665. * rendering/RenderObject.h:
  36666. (WebCore::RenderObject::computeAbsoluteRepaintRect):
  36667. * rendering/RenderReplaced.cpp:
  36668. (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
  36669. * rendering/RenderTableCell.cpp:
  36670. (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
  36671. (WebCore::RenderTableCell::computeRectForRepaint):
  36672. * rendering/RenderTableCell.h:
  36673. * rendering/RenderView.cpp:
  36674. (WebCore::RenderView::computeRectForRepaint):
  36675. * rendering/RenderView.h:
  36676. 2009-01-27 David Kilzer <ddkilzer@apple.com>
  36677. Add missing header guards to AccessibilityObjectWrapper.h
  36678. Reviewed by Anders Carlsson.
  36679. * page/mac/AccessibilityObjectWrapper.h: Added missing header guards.
  36680. 2009-01-27 Simon Fraser <simon.fraser@apple.com>
  36681. Reviewed by Dave Hyatt
  36682. https://bugs.webkit.org/show_bug.cgi?id=23567
  36683. Fix crash of svg/custom/stop-crash.svg testcase because of
  36684. infinite recursion, as I missed replacing absoluteClippedOverflowRect()
  36685. with clippedOverflowRectForRepaint() in RenderSVGGradientStop.
  36686. Also fix a missed conversion in RenderTableCol, and add a couple
  36687. of comments.
  36688. * rendering/RenderSVGGradientStop.h:
  36689. (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
  36690. * rendering/RenderSVGImage.cpp:
  36691. (WebCore::RenderSVGImage::imageChanged):
  36692. * rendering/RenderTableCol.cpp:
  36693. (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
  36694. * rendering/RenderTableRow.cpp:
  36695. (WebCore::RenderTableRow::layout):
  36696. 2009-01-27 Adele Peterson <adele@apple.com>
  36697. RS by Dave Hyatt
  36698. Use the textfield appearance for search fields in themeWin.css so the border/background
  36699. styling will work correctly on these fields.
  36700. * css/themeWin.css:
  36701. 2009-01-27 Dan Bernstein <mitz@apple.com>
  36702. - build fix
  36703. * bindings/js/JSHTMLInputElementCustom.cpp:
  36704. (WebCore::JSHTMLInputElement::setSelectionStart):
  36705. (WebCore::JSHTMLInputElement::setSelectionEnd):
  36706. (WebCore::JSHTMLInputElement::setSelectionRange):
  36707. 2009-01-27 Dan Bernstein <mitz@apple.com>
  36708. - build fix
  36709. * platform/graphics/Gradient.cpp:
  36710. (WebCore::Gradient::setSpreadMethod):
  36711. 2009-01-27 Paul Godavari <paul@chromium.org>
  36712. Reviewed by Eric Seidel.
  36713. https://bugs.webkit.org/show_bug.cgi?id=23561
  36714. Explicitly send the MIME type from an image dragged from a web
  36715. page to the desktop, to Chromium so that it can properly generate
  36716. a file name.
  36717. * platform/chromium/ChromiumDataObject.cpp:
  36718. (WebCore::ChromiumDataObject::clear):
  36719. (WebCore::ChromiumDataObject::hasData):
  36720. * platform/chromium/ChromiumDataObject.h:
  36721. * platform/chromium/ClipboardChromium.cpp:
  36722. (WebCore::writeImageToDataObject):
  36723. 2009-01-27 Mads Ager <ager@chromium.org>
  36724. Reviewed by Darin Adler.
  36725. https://bugs.webkit.org/show_bug.cgi?id=23300
  36726. Follow Firefox in throwing exceptions when using selection
  36727. functions on HTMLInputElements that cannot have selection.
  36728. This requires custom setSelectionRange, setSelectionStart and
  36729. setSelectionEnd implementations, but it gets rid of the custom
  36730. getOwnPropertySlot.
  36731. * bindings/js/JSHTMLInputElementCustom.cpp:
  36732. (WebCore::JSHTMLInputElement::selectionStart):
  36733. (WebCore::JSHTMLInputElement::selectionEnd):
  36734. (WebCore::JSHTMLInputElement::setSelectionRange):
  36735. * html/HTMLInputElement.idl:
  36736. 2009-01-27 Evan Stade <estade@chromium.org>
  36737. Reviewed by Nikolas Zimmermann.
  36738. https://bugs.webkit.org/show_bug.cgi?id=23435
  36739. Make spreadMethod a member of Gradient rather than GraphicsContext.
  36740. Implement spreadMethod for Skia.
  36741. * platform/graphics/Gradient.cpp:
  36742. (WebCore::Gradient::Gradient):
  36743. * platform/graphics/Gradient.h:
  36744. (WebCore::Gradient::setSpreadMethod):
  36745. (WebCore::Gradient::spreadMethod):
  36746. * platform/graphics/GraphicsContext.cpp:
  36747. * platform/graphics/GraphicsContext.h:
  36748. * platform/graphics/GraphicsContextPrivate.h:
  36749. * platform/graphics/GraphicsTypes.h:
  36750. (WebCore::):
  36751. * platform/graphics/cairo/GradientCairo.cpp:
  36752. (WebCore::Gradient::platformGradient):
  36753. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  36754. (WebCore::GraphicsContext::fillPath):
  36755. (WebCore::GraphicsContext::strokePath):
  36756. * platform/graphics/qt/GradientQt.cpp:
  36757. (WebCore::Gradient::platformGradient):
  36758. * platform/graphics/qt/GraphicsContextQt.cpp:
  36759. (WebCore::GraphicsContext::fillPath):
  36760. (WebCore::GraphicsContext::strokePath):
  36761. * platform/graphics/skia/GradientSkia.cpp:
  36762. (WebCore::Gradient::platformGradient):
  36763. * svg/SVGLinearGradientElement.cpp:
  36764. (WebCore::SVGLinearGradientElement::buildGradient):
  36765. * svg/SVGRadialGradientElement.cpp:
  36766. (WebCore::SVGRadialGradientElement::buildGradient):
  36767. * svg/graphics/SVGPaintServerGradient.cpp:
  36768. (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
  36769. (WebCore::SVGPaintServerGradient::setup):
  36770. (WebCore::SVGPaintServerGradient::externalRepresentation):
  36771. * svg/graphics/SVGPaintServerGradient.h:
  36772. 2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
  36773. Rubber-stamped by Simon Hausmann.
  36774. http://qt.nokia.com/developer/task-tracker/index_html?id=238662&method=entry
  36775. [Qt] Map function keys F1 to F24.
  36776. * platform/qt/PlatformKeyboardEventQt.cpp:
  36777. (WebCore::windowsKeyCodeForKeyEvent):
  36778. 2009-01-27 Brady Eidson <beidson@apple.com>
  36779. Reviewed by Dan Bernstein
  36780. Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
  36781. * WebCore.base.exp:
  36782. * history/CachedPage.cpp:
  36783. * history/CachedPage.h:
  36784. (WebCore::CachedPage::cachedMainFrame):
  36785. * loader/EmptyClients.h:
  36786. (WebCore::EmptyFrameLoaderClient::savePlatformDataToCachedFrame):
  36787. (WebCore::EmptyFrameLoaderClient::transitionToCommittedFromCachedFrame):
  36788. * loader/FrameLoader.cpp:
  36789. (WebCore::FrameLoader::restoreDocumentState):
  36790. (WebCore::FrameLoader::commitProvisionalLoad):
  36791. (WebCore::FrameLoader::transitionToCommitted):
  36792. (WebCore::FrameLoader::cachePageForHistoryItem):
  36793. * loader/FrameLoaderClient.h:
  36794. 2009-01-26 Simon Fraser <simon.fraser@apple.com>
  36795. Reviewed by Dave Hyatt
  36796. https://bugs.webkit.org/show_bug.cgi?id=23360
  36797. Add variants of all the methods that compute dirty rects for repainting
  36798. with versions that compute those rects relative to some container
  36799. RenderBox that acts as a painting root.
  36800. * rendering/RenderBox.cpp:
  36801. (WebCore::RenderBox::styleDidChange):
  36802. (WebCore::RenderBox::outlineBoundsForRepaint):
  36803. (WebCore::RenderBox::localToContainerQuad):
  36804. (WebCore::RenderBox::clippedOverflowRectForRepaint):
  36805. (WebCore::RenderBox::computeRectForRepaint):
  36806. * rendering/RenderBox.h:
  36807. * rendering/RenderForeignObject.cpp:
  36808. (WebCore::RenderForeignObject::computeRectForRepaint):
  36809. * rendering/RenderForeignObject.h:
  36810. * rendering/RenderInline.cpp:
  36811. (WebCore::RenderInline::clippedOverflowRectForRepaint):
  36812. * rendering/RenderInline.h:
  36813. * rendering/RenderObject.cpp:
  36814. (WebCore::RenderObject::containerForRepaint):
  36815. (WebCore::RenderObject::repaint):
  36816. (WebCore::RenderObject::repaintRectangle):
  36817. (WebCore::RenderObject::rectWithOutlineForRepaint):
  36818. (WebCore::RenderObject::clippedOverflowRectForRepaint):
  36819. (WebCore::RenderObject::computeRectForRepaint):
  36820. (WebCore::RenderObject::localToContainerQuad):
  36821. * rendering/RenderObject.h:
  36822. (WebCore::RenderObject::localToAbsoluteQuad):
  36823. (WebCore::RenderObject::absoluteClippedOverflowRect):
  36824. (WebCore::RenderObject::computeAbsoluteRepaintRect):
  36825. (WebCore::RenderObject::absoluteOutlineBounds):
  36826. (WebCore::RenderObject::outlineBoundsForRepaint):
  36827. * rendering/RenderPath.cpp:
  36828. (WebCore::RenderPath::clippedOverflowRectForRepaint):
  36829. (WebCore::RenderPath::outlineBoundsForRepaint):
  36830. * rendering/RenderPath.h:
  36831. * rendering/RenderReplaced.cpp:
  36832. (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
  36833. * rendering/RenderReplaced.h:
  36834. * rendering/RenderSVGContainer.cpp:
  36835. (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
  36836. (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
  36837. * rendering/RenderSVGContainer.h:
  36838. * rendering/RenderSVGHiddenContainer.cpp:
  36839. (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
  36840. * rendering/RenderSVGHiddenContainer.h:
  36841. * rendering/RenderSVGImage.cpp:
  36842. (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
  36843. * rendering/RenderSVGImage.h:
  36844. * rendering/RenderSVGRoot.cpp:
  36845. (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
  36846. * rendering/RenderSVGRoot.h:
  36847. * rendering/RenderSVGText.cpp:
  36848. (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
  36849. * rendering/RenderSVGText.h:
  36850. * rendering/RenderTableCell.cpp:
  36851. (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
  36852. (WebCore::RenderTableCell::computeRectForRepaint):
  36853. (WebCore::RenderTableCell::localToContainerQuad):
  36854. * rendering/RenderTableCell.h:
  36855. * rendering/RenderTableCol.cpp:
  36856. (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
  36857. * rendering/RenderTableCol.h:
  36858. * rendering/RenderTableRow.cpp:
  36859. (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
  36860. * rendering/RenderTableRow.h:
  36861. * rendering/RenderText.cpp:
  36862. (WebCore::RenderText::clippedOverflowRectForRepaint):
  36863. * rendering/RenderText.h:
  36864. * rendering/RenderView.cpp:
  36865. (WebCore::RenderView::localToContainerQuad):
  36866. (WebCore::RenderView::computeRectForRepaint):
  36867. * rendering/RenderView.h:
  36868. 2009-01-26 Simon Fraser <simon.fraser@apple.com>
  36869. Reviewed by David Hyatt
  36870. Back out r40285, because it was checked in with no bug number, no
  36871. testcase, is rendering change that did not get thorough review,
  36872. and broke the Mac build.
  36873. * page/EventHandler.cpp:
  36874. (WebCore::EventHandler::hitTestResultAtPoint):
  36875. * page/EventHandler.h:
  36876. * rendering/HitTestRequest.h:
  36877. (WebCore::HitTestRequest::HitTestRequest):
  36878. * rendering/RenderLayer.cpp:
  36879. (WebCore::RenderLayer::hitTest):
  36880. 2009-01-26 Brady Eidson <beidson@apple.com>
  36881. Reviewed by Darin Adler
  36882. -Make the recently added back/forward cache logging much better by actually
  36883. walking the entire frame tree and indenting the resulting output.
  36884. -Fix a null-termination bug in HistoryItem tree logging
  36885. * history/HistoryItem.cpp:
  36886. (WebCore::HistoryItem::showTreeWithIndent):
  36887. * loader/FrameLoader.cpp:
  36888. (WebCore::pageCacheLogPrefix):
  36889. (WebCore::pageCacheLog):
  36890. (WebCore::FrameLoader::logCanCachePageDecision):
  36891. (WebCore::FrameLoader::logCanCacheFrameDecision):
  36892. * loader/FrameLoader.h:
  36893. 2009-01-26 Adam Treat <adam.treat@torchmobile.com>
  36894. Reviewed by Nikolas Zimmermann.
  36895. Allow option of hit testing frame content without clipping to the visible
  36896. viewport.
  36897. * page/EventHandler.cpp:
  36898. (WebCore::EventHandler::hitTestResultAtPoint):
  36899. * page/EventHandler.h:
  36900. * rendering/HitTestRequest.h:
  36901. (WebCore::HitTestRequest::HitTestRequest):
  36902. * rendering/RenderLayer.cpp:
  36903. (WebCore::RenderLayer::hitTest):
  36904. 2009-01-26 Sam Weinig <sam@webkit.org>
  36905. Reviewed by Dan Bernstein.
  36906. Fix for https://bugs.webkit.org/show_bug.cgi?id=18141
  36907. Acid3 tests 77 and 78 fail on reload due to SVG font race
  36908. <rdar://problem/6504899>
  36909. Match Opera's behavior of loading SVGFonts as soon as <font-face-uri>
  36910. tag is inserted into the document and not at the first use of the font
  36911. as is done for CSS web fonts.
  36912. This fixes a race condition noticeable by some in the Acid3 test that
  36913. happened because the onload event handler for an iframe containing a
  36914. <font-face-uri> with an external reference was not delayed by the pending
  36915. load of the font.
  36916. Test: http/tests/misc/SVGFont-delayed-load.html
  36917. * svg/SVGFontFaceUriElement.cpp:
  36918. (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement):
  36919. (WebCore::SVGFontFaceUriElement::parseMappedAttribute): Call loadFont if
  36920. the href attribute changes.
  36921. (WebCore::SVGFontFaceUriElement::insertedIntoDocument): Call loadFont.
  36922. (WebCore::SVGFontFaceUriElement::loadFont): Force a load of the
  36923. font specified in href attribute.
  36924. * svg/SVGFontFaceUriElement.h:
  36925. 2009-01-26 Timothy Hatcher <timothy@apple.com>
  36926. Change Web Archive serialization back to the binary property list format.
  36927. <rdar://problem/6127865> Web archives saved with Safari 4 cannot be read by Safari 3
  36928. Reviewed by Brady Eidson.
  36929. * loader/archive/cf/LegacyWebArchive.cpp:
  36930. (WebCore::LegacyWebArchive::rawDataRepresentation):
  36931. 2009-01-26 Anders Carlsson <andersca@apple.com>
  36932. Fix 64-bit build.
  36933. * WebCore.LP64.exp:
  36934. 2009-01-26 Dmitry Titov <dimich@chromium.org>
  36935. Reviewed by Alexey Proskuryakov.
  36936. https://bugs.webkit.org/show_bug.cgi?id=23511
  36937. Move DOMTimer from bindings/js to page/.
  36938. This was prepared by moving all JSC dependencies from DOMTimer
  36939. to ScheduledAction earlier, and helps unfork the Chromuim version
  36940. of the DOMTimer.
  36941. * GNUmakefile.am:
  36942. * WebCore.pro:
  36943. * WebCore.scons:
  36944. * WebCore.vcproj/WebCore.vcproj:
  36945. * WebCore.xcodeproj/project.pbxproj:
  36946. * WebCoreSources.bkl:
  36947. * bindings/js/DOMTimer.cpp: Removed.
  36948. * bindings/js/DOMTimer.h: Removed.
  36949. * page/DOMTimer.cpp: Copied from WebCore/bindings/js/DOMTimer.cpp.
  36950. * page/DOMTimer.h: Copied from WebCore/bindings/js/DOMTimer.h.
  36951. 2009-01-26 David Hyatt <hyatt@apple.com>
  36952. Eliminate rightmostPosition, lowestPosition and leftmostPosition from RenderFlow. Move the code into
  36953. RenderBlock's methods.
  36954. Reviewed by Eric Seidel
  36955. * rendering/RenderBlock.cpp:
  36956. (WebCore::RenderBlock::lowestPosition):
  36957. (WebCore::RenderBlock::rightmostPosition):
  36958. (WebCore::RenderBlock::leftmostPosition):
  36959. * rendering/RenderFlow.cpp:
  36960. * rendering/RenderFlow.h:
  36961. 2009-01-26 Darin Fisher <darin@chromium.org>
  36962. Reviewed by Eric Seidel.
  36963. https://bugs.webkit.org/show_bug.cgi?id=23553
  36964. Upstream changes from jcampan to fix chromium bugs 6692 and 6694.
  36965. * platform/chromium/PopupMenuChromium.cpp:
  36966. (WebCore::PopupListBox::setLoopSelectionNavigation):
  36967. (WebCore::PopupListBox::PopupListBox):
  36968. (WebCore::PopupContainer::setLoopSelectionNavigation):
  36969. (WebCore::PopupListBox::handleKeyEvent):
  36970. (WebCore::PopupListBox::paintRow):
  36971. (WebCore::PopupListBox::clearSelection):
  36972. (WebCore::PopupListBox::selectNextRow):
  36973. (WebCore::PopupListBox::selectPreviousRow):
  36974. * platform/chromium/PopupMenuChromium.h:
  36975. 2009-01-26 Brady Eidson <beidson@apple.com>
  36976. Reviewed by Sam Weinig
  36977. Remove some historical CachedPage time stamp fluff.
  36978. * history/CachedPage.cpp:
  36979. (WebCore::CachedPage::CachedPage):
  36980. * history/CachedPage.h:
  36981. (WebCore::CachedPage::timeStamp):
  36982. * loader/FrameLoader.cpp:
  36983. (WebCore::FrameLoader::cachePageForHistoryItem):
  36984. 2009-01-26 David Hyatt <hyatt@apple.com>
  36985. Move absoluteClippedOverflowRect, linesBoundingBox and borderBoundingBox from RenderFlow to RenderInline.
  36986. Reviewed by Eric Seidel
  36987. * rendering/RenderBox.cpp:
  36988. (WebCore::RenderBox::containingBlockHeightForPositioned):
  36989. * rendering/RenderFlow.cpp:
  36990. * rendering/RenderFlow.h:
  36991. * rendering/RenderInline.cpp:
  36992. (WebCore::RenderInline::linesBoundingBox):
  36993. (WebCore::RenderInline::absoluteClippedOverflowRect):
  36994. * rendering/RenderInline.h:
  36995. (WebCore::RenderInline::borderBoundingBox):
  36996. * rendering/RenderLayer.cpp:
  36997. (WebCore::RenderLayer::updateLayerPosition):
  36998. * rendering/RenderTreeAsText.cpp:
  36999. (WebCore::operator<<):
  37000. 2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
  37001. Reviewed by Eric Seidel.
  37002. https://bugs.webkit.org/show_bug.cgi?id=22650
  37003. Implement support for "Immutable" attribute to CodeGeneratorJS.pm, thus
  37004. allowing to explicitly mark methods as immutable (i.e. returning a new
  37005. instance rather than a reference to an existing instance).
  37006. * bindings/js/JSSVGMatrixCustom.cpp: Removed custom methods.
  37007. * bindings/scripts/CodeGeneratorJS.pm: Added check for Immutable
  37008. attribute when generating function call.
  37009. * svg/SVGMatrix.idl: Replaced Custom attribute with Immutable on
  37010. methods.
  37011. 2009-01-26 David Hyatt <hyatt@apple.com>
  37012. Eliminate isInlineFlow() now that a RenderBlock can never be an inline flow. isInlineFlow() is now
  37013. equivalent to isRenderInline(), so all calls to isInlineFlow() have been replaced with isRenderInline().
  37014. Reviewed by Eric Seidel
  37015. * dom/Text.cpp:
  37016. (WebCore::Text::rendererIsNeeded):
  37017. * rendering/InlineFlowBox.cpp:
  37018. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  37019. (WebCore::shouldDrawTextDecoration):
  37020. * rendering/RenderBlock.cpp:
  37021. (WebCore::RenderBlock::hitTestContents):
  37022. (WebCore::InlineMinMaxIterator::next):
  37023. (WebCore::RenderBlock::calcInlinePrefWidths):
  37024. * rendering/RenderBlock.h:
  37025. (WebCore::RenderBlock::isBlockFlow):
  37026. * rendering/RenderBox.cpp:
  37027. (WebCore::RenderBox::clientWidth):
  37028. (WebCore::RenderBox::clientHeight):
  37029. (WebCore::RenderBox::nodeAtPoint):
  37030. (WebCore::RenderBox::imageChanged):
  37031. (WebCore::RenderBox::offsetForPositionedInContainer):
  37032. (WebCore::RenderBox::containingBlockWidthForPositioned):
  37033. (WebCore::RenderBox::containingBlockHeightForPositioned):
  37034. * rendering/RenderBox.h:
  37035. (WebCore::RenderBox::width):
  37036. (WebCore::RenderBox::height):
  37037. (WebCore::RenderBox::size):
  37038. (WebCore::RenderBox::frameRect):
  37039. * rendering/RenderContainer.cpp:
  37040. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  37041. * rendering/RenderFlow.cpp:
  37042. (WebCore::RenderFlow::dirtyLinesFromChangedChild):
  37043. (WebCore::RenderFlow::createInlineBox):
  37044. (WebCore::RenderFlow::paintLines):
  37045. (WebCore::RenderFlow::hitTestLines):
  37046. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  37047. (WebCore::RenderFlow::lowestPosition):
  37048. (WebCore::RenderFlow::rightmostPosition):
  37049. (WebCore::RenderFlow::leftmostPosition):
  37050. * rendering/RenderFlow.h:
  37051. (WebCore::RenderFlow::borderBoundingBox):
  37052. * rendering/RenderInline.h:
  37053. (WebCore::RenderInline::isRenderInline):
  37054. * rendering/RenderLayer.cpp:
  37055. (WebCore::RenderLayer::updateLayerPosition):
  37056. (WebCore::RenderLayer::intersectsDamageRect):
  37057. (WebCore::RenderLayer::boundingBox):
  37058. * rendering/RenderListItem.cpp:
  37059. (WebCore::getParentOfFirstLineBox):
  37060. * rendering/RenderObject.cpp:
  37061. (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
  37062. (WebCore::RenderObject::styleWillChange):
  37063. (WebCore::RenderObject::firstLineStyle):
  37064. * rendering/RenderObject.h:
  37065. * rendering/RenderSVGInline.cpp:
  37066. (WebCore::RenderSVGInline::createInlineBox):
  37067. * rendering/RenderSVGText.cpp:
  37068. (WebCore::RenderSVGText::createInlineBox):
  37069. * rendering/RenderTableRow.cpp:
  37070. (WebCore::RenderTableRow::nodeAtPoint):
  37071. * rendering/RenderTableSection.cpp:
  37072. (WebCore::RenderTableSection::nodeAtPoint):
  37073. * rendering/RenderText.cpp:
  37074. (WebCore::isInlineFlowOrEmptyText):
  37075. * rendering/RenderTreeAsText.cpp:
  37076. (WebCore::operator<<):
  37077. * rendering/bidi.cpp:
  37078. (WebCore::bidiNext):
  37079. (WebCore::bidiFirst):
  37080. (WebCore::appendRunsForObject):
  37081. (WebCore::RenderBlock::createLineBoxes):
  37082. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  37083. (WebCore::RenderBlock::layoutInlineChildren):
  37084. (WebCore::inlineFlowRequiresLineBox):
  37085. (WebCore::requiresLineBox):
  37086. (WebCore::RenderBlock::skipTrailingWhitespace):
  37087. (WebCore::RenderBlock::skipLeadingWhitespace):
  37088. (WebCore::RenderBlock::findNextLineBreak):
  37089. 2009-01-26 David Hyatt <hyatt@apple.com>
  37090. Drop support for display:compact.
  37091. (1) display:compact is no longer part of CSS2.1.
  37092. (2) Shipping Safari has completely broken compact support with severely broken rendering
  37093. (all of the compact text just piles on top of the text in the inserted block and on top of itself as well).
  37094. (3) This has been broken in WebKit for years (ever since blocks converted to painting lines directly) without
  37095. anyone even noticing.
  37096. Reviewed by Eric Seidel
  37097. * rendering/InlineFlowBox.cpp:
  37098. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  37099. * rendering/RenderBlock.cpp:
  37100. (WebCore::RenderBlock::handleSpecialChild):
  37101. (WebCore::RenderBlock::handleRunInChild):
  37102. (WebCore::RenderBlock::layoutBlockChildren):
  37103. (WebCore::RenderBlock::paint):
  37104. (WebCore::RenderBlock::paintObject):
  37105. (WebCore::RenderBlock::nodeAtPoint):
  37106. (WebCore::RenderBlock::positionForCoordinates):
  37107. (WebCore::shouldCheckLines):
  37108. (WebCore::getHeightForLineCount):
  37109. (WebCore::RenderBlock::renderName):
  37110. * rendering/RenderBlock.h:
  37111. * rendering/RenderBox.cpp:
  37112. (WebCore::RenderBox::sizesToIntrinsicWidth):
  37113. * rendering/RenderBox.h:
  37114. (WebCore::RenderBox::width):
  37115. (WebCore::RenderBox::height):
  37116. (WebCore::RenderBox::size):
  37117. (WebCore::RenderBox::frameRect):
  37118. * rendering/RenderFlow.cpp:
  37119. (WebCore::RenderFlow::paintLines):
  37120. (WebCore::RenderFlow::hitTestLines):
  37121. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  37122. (WebCore::RenderFlow::linesBoundingBox):
  37123. * rendering/RenderObject.h:
  37124. (WebCore::RenderObject::isInline):
  37125. * rendering/bidi.cpp:
  37126. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  37127. (WebCore::RenderBlock::layoutInlineChildren):
  37128. * rendering/bidi.h:
  37129. (WebCore::BidiRun::BidiRun):
  37130. 2009-01-26 Adam Langley <agl@google.com>
  37131. Reviewed by Nikolas Zimmermann.
  37132. gtk2drawing: fix compiler warnings
  37133. g_object_set_data expects a gpointer as the last argument. Cast the
  37134. TRUE/FALSE values to avoid a warning.
  37135. gtk_tree_view_column_new doesn't return a GtkWidget.
  37136. * platform/gtk/gtk2drawing.c:
  37137. (setup_widget_prototype):
  37138. (moz_gtk_get_combo_box_inner_button):
  37139. (moz_gtk_get_combo_box_button_inner_widgets):
  37140. (ensure_combo_box_widgets):
  37141. (moz_gtk_get_combo_box_entry_inner_widgets):
  37142. (moz_gtk_get_combo_box_entry_arrow):
  37143. (ensure_combo_box_entry_widgets):
  37144. (ensure_toolbar_widget):
  37145. (ensure_menu_bar_item_widget):
  37146. (ensure_menu_popup_widget):
  37147. (ensure_menu_item_widget):
  37148. (ensure_image_menu_item_widget):
  37149. (ensure_menu_separator_widget):
  37150. (ensure_check_menu_item_widget):
  37151. (ensure_tree_header_cell_widget):
  37152. (moz_gtk_entry_paint):
  37153. 2009-01-26 David Hyatt <hyatt@apple.com>
  37154. Change display:run-in handling so that we no longer reuse RenderBlock as though it is an inline flow.
  37155. Instead we create a new RenderInline, move the RenderBlock's children underneath it, and then set the
  37156. inline as the new element's renderer.
  37157. Reviewed by Dan Bernstein
  37158. * rendering/RenderBlock.cpp:
  37159. (WebCore::RenderBlock::handleRunInChild):
  37160. * rendering/RenderInline.cpp:
  37161. (WebCore::RenderInline::renderName):
  37162. 2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
  37163. Reviewed by Darin Adler.
  37164. https://bugs.webkit.org/show_bug.cgi?id=23480
  37165. Add missing method stubs to BackForwardListChromium.
  37166. * history/BackForwardListChromium.cpp:
  37167. (WebCore::BackForwardList::backItem):
  37168. (WebCore::BackForwardList::forwardItem):
  37169. 2009-01-25 Darin Adler <darin@apple.com>
  37170. Try to fix Tiger buildbot.
  37171. * WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
  37172. * page/mac/WebDashboardRegion.m:
  37173. (typeName): Added.
  37174. (-[WebDashboardRegion description]): Use typeName.
  37175. (-[WebDashboardRegion isEqual:]): Added comment.
  37176. 2009-01-25 Alexey Proskuryakov <ap@webkit.org>
  37177. Reviewed by Darin Adler.
  37178. https://bugs.webkit.org/show_bug.cgi?id=23535
  37179. Strengthen debug checks in KURL
  37180. Covered (and prompted) by existing tests.
  37181. * platform/KURL.cpp:
  37182. (WebCore::checkEncodedString): Check that the first character of the URL is an allowed
  37183. first scheme character, not just that it isn't a slash.
  37184. (WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case
  37185. because of parsing being idempotent).
  37186. * page/SecurityOrigin.cpp:
  37187. (WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an
  37188. empty security origin is created.
  37189. (WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert
  37190. it - it is not guaranteed to be properly encoded.
  37191. * dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary
  37192. string, it needs to be parsed into an URL, not just converted into one.
  37193. * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
  37194. Create the security origin with createFromString() instead of create(). I do not know where
  37195. the string comes from and whether it might not be properly encoded, but this change can't
  37196. hurt, and makes the code slightly more clear.
  37197. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security
  37198. origin with createFromString() instead of create(). The string comes from an HTTP response
  37199. header, so it may not be a properly encoded URL.
  37200. * loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using
  37201. invalid URLs.
  37202. * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call
  37203. SecurityOrigin::createFromString() (no change in behavior).
  37204. 2009-01-25 Mark Rowe <mrowe@apple.com>
  37205. Rubber-stamped by Dan Bernstein.
  37206. Improve the consistency of settings in our .xcconfig files.
  37207. * Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS to match other projects,
  37208. and handle all cases in GCC_GENERATE_DEBUGGING_SYMBOLS.
  37209. 2009-01-25 David Hyatt <hyatt@apple.com>
  37210. Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.
  37211. The new table code created a bug involving markAllDescendantsWithFloatsForLayout, namely that it could
  37212. end up marking ancestors of a block as needing layout when that block was still in the process of
  37213. doing a layout.
  37214. The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
  37215. we are "mid-layout." If this flag is set, then the method will make sure to do only local dirtying
  37216. of objects to avoid accidentally marking a clean ancestor as needing layout again.
  37217. Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
  37218. with a check of whether or not we are mid-layout being done by those methods instead.
  37219. Reviewed by Oliver Hunt
  37220. Added fast/repaint/dynamic-table-vertical-alignment-change.html
  37221. * rendering/RenderBlock.cpp:
  37222. (WebCore::RenderBlock::collapseMargins):
  37223. (WebCore::RenderBlock::clearFloatsIfNeeded):
  37224. (WebCore::RenderBlock::layoutBlockChildren):
  37225. (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  37226. * rendering/RenderBlock.h:
  37227. * rendering/RenderObject.cpp:
  37228. (WebCore::RenderObject::removeFromObjectLists):
  37229. * rendering/RenderObject.h:
  37230. * rendering/RenderTableSection.cpp:
  37231. (WebCore::RenderTableSection::layoutRows):
  37232. 2009-01-25 Darin Adler <darin@apple.com>
  37233. Reviewed by Mark Rowe.
  37234. Bug 23352: Turn on more compiler warnings in the Mac build
  37235. https://bugs.webkit.org/show_bug.cgi?id=23352
  37236. Turn on the following warnings:
  37237. -Wcast-qual
  37238. -Wextra-tokens
  37239. -Wformat=2
  37240. -Winit-self
  37241. -Wmissing-noreturn
  37242. -Wpacked
  37243. -Wrendundant-decls
  37244. * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
  37245. -W for clarity since we don't have to support the older versions of gcc that require the
  37246. old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
  37247. -Wno-format-y2k since we can have that one on now.
  37248. 2009-01-25 Dan Bernstein <mitz@apple.com>
  37249. Reviewed by Oliver Hunt.
  37250. - fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
  37251. string hashing code when opening a Digg RSS article
  37252. Test: fast/loader/null-request-after-willSendRequest.html
  37253. * loader/FrameLoader.cpp:
  37254. (WebCore::FrameLoader::loadItem): Null-check the request returned from
  37255. the client's willSendRequest method.
  37256. 2009-01-25 David Hyatt <hyatt@apple.com>
  37257. Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
  37258. instead of the ancestor overflow (23525)
  37259. Make sure that we always call scroll() on the nearest enclosing RenderBox. No test case is possible
  37260. here, since wheel scrolling is currently untestable (the offset varies from machine to machine).
  37261. Reviewed by Dan Bernstein
  37262. * page/EventHandler.cpp:
  37263. (WebCore::scrollAndAcceptEvent):
  37264. (WebCore::EventHandler::scrollOverflow):
  37265. * rendering/RenderObject.cpp:
  37266. (WebCore::RenderObject::enclosingBox):
  37267. * rendering/RenderObject.h:
  37268. 2009-01-25 Darin Adler <darin@apple.com>
  37269. Reviewed by Dan Bernstein.
  37270. Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled
  37271. https://bugs.webkit.org/show_bug.cgi?id=23538
  37272. rdar://problem/6523719
  37273. I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.
  37274. The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
  37275. the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
  37276. than doing fallback.
  37277. * rendering/RenderPartObject.cpp:
  37278. (WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an
  37279. inelegant if statement.
  37280. (WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo.
  37281. (WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check.
  37282. (WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to
  37283. return a string than an "out" parameter. Fixed the logic to only prefer the ActiveX type over the
  37284. type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed
  37285. there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many
  37286. other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the
  37287. new havePlugin function so we handle the case where pluginData is 0.
  37288. (WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId
  37289. instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in
  37290. that knows how to handle <object> elements.
  37291. (WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that
  37292. use this data still need to be called; they still do something even if no plug-ins are present. And
  37293. they have now been corrected to handle 0 properly.
  37294. 2009-01-25 Darin Adler <darin@apple.com>
  37295. * rendering/RenderMenuList.cpp: Fix build by adding back needed include.
  37296. 2009-01-25 Darin Adler <darin@apple.com>
  37297. Reviewed by Sam Weinig.
  37298. Bug 23352: Turn on more compiler warnings in the Mac build
  37299. https://bugs.webkit.org/show_bug.cgi?id=23352
  37300. Fourth patch: Deal with the last few stray warnings.
  37301. * rendering/RenderBlock.cpp:
  37302. (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
  37303. Also make the local variable be a RenderBlock so the cast is closer to the code
  37304. that guarantees it's correct.
  37305. * rendering/SVGRenderTreeAsText.cpp:
  37306. (WebCore::writeStyle): Put the enum into a local variable that's a built-in
  37307. type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
  37308. 2009-01-25 Darin Adler <darin@apple.com>
  37309. Reviewed by Sam Weinig.
  37310. Bug 23522: use checked casts for render tree
  37311. https://bugs.webkit.org/show_bug.cgi?id=23522
  37312. Step one: RenderText.
  37313. Also change set of RenderFlow* to be a ListHashSet as the comment in the
  37314. header indicated.
  37315. * dom/CharacterData.cpp:
  37316. (WebCore::CharacterData::setData): Use toRenderText.
  37317. (WebCore::CharacterData::appendData): Ditto.
  37318. (WebCore::CharacterData::insertData): Ditto.
  37319. (WebCore::CharacterData::deleteData): Ditto.
  37320. (WebCore::CharacterData::replaceData): Ditto.
  37321. * dom/ContainerNode.cpp:
  37322. (WebCore::ContainerNode::getUpperLeftCorner): Ditto.
  37323. (WebCore::ContainerNode::getLowerRightCorner): Ditto.
  37324. * dom/Position.cpp:
  37325. (WebCore::nextRenderedEditable): Ditto.
  37326. (WebCore::previousRenderedEditable): Ditto.
  37327. (WebCore::Position::renderedOffset): Ditto. Also use function members
  37328. instead of data members of InlineTextBox.
  37329. (WebCore::Position::upstream): Ditto.
  37330. (WebCore::Position::downstream): Ditto.
  37331. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
  37332. (WebCore::Position::inRenderedText): Ditto.
  37333. (WebCore::Position::isRenderedCharacter): Ditto.
  37334. (WebCore::searchAheadForBetterMatch): Ditto.
  37335. (WebCore::Position::getInlineBoxAndOffset): Ditto.
  37336. * dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
  37337. included in RenderObject.h.
  37338. * dom/Text.cpp:
  37339. (WebCore::Text::splitText): Use toRenderText.
  37340. (WebCore::Text::recalcStyle): Ditto.
  37341. * editing/CompositeEditCommand.cpp:
  37342. (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
  37343. * editing/SelectionController.cpp:
  37344. (WebCore::SelectionController::debugRenderer): Ditto.
  37345. * editing/TextIterator.cpp:
  37346. (WebCore::TextIterator::handleTextNode): Ditto.
  37347. (WebCore::TextIterator::handleTextBox): Ditto.
  37348. (WebCore::TextIterator::emitText): Ditto.
  37349. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
  37350. * editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
  37351. no longer included in RenderObject.h.
  37352. * inspector/InspectorController.cpp: Ditto.
  37353. * page/Frame.cpp: Ditto.
  37354. * rendering/RenderBox.cpp: Ditto.
  37355. * rendering/RenderInline.cpp: Ditto.
  37356. * rendering/RenderPath.cpp: Ditto.
  37357. * rendering/RenderSVGContainer.cpp: Ditto.
  37358. * rendering/RenderSVGImage.cpp: Ditto.
  37359. * rendering/RenderSVGInlineText.cpp: Ditto.
  37360. * rendering/RenderSVGTSpan.cpp: Ditto.
  37361. * rendering/RenderSVGText.cpp: Ditto.
  37362. * rendering/RenderSVGTextPath.cpp: Ditto.
  37363. * rendering/RenderTableCell.cpp: Ditto.
  37364. * rendering/RenderView.cpp: Ditto.
  37365. * editing/visible_units.cpp:
  37366. (WebCore::startPositionForLine): Use function members instead of data
  37367. members of InlineTextBox.
  37368. (WebCore::endPositionForLine): Ditto.
  37369. (WebCore::startOfParagraph): Use toRenderText.
  37370. (WebCore::endOfParagraph): Ditto.
  37371. * page/AccessibilityRenderObject.cpp:
  37372. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
  37373. * rendering/InlineFlowBox.cpp:
  37374. (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
  37375. * rendering/InlineTextBox.cpp:
  37376. (WebCore::InlineTextBox::deleteLine): Ditto.
  37377. (WebCore::InlineTextBox::extractLine): Ditto.
  37378. (WebCore::InlineTextBox::attachLine): Ditto.
  37379. (WebCore::InlineTextBox::placeEllipsisBox): Ditto.
  37380. (WebCore::InlineTextBox::paintDecoration): Ditto.
  37381. (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
  37382. (WebCore::InlineTextBox::offsetForPosition): Ditto.
  37383. (WebCore::InlineTextBox::positionForOffset): Ditto.
  37384. * rendering/InlineTextBox.h: Made most members private. Use toRenderText.
  37385. * rendering/RenderArena.cpp:
  37386. (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
  37387. (WebCore::RenderArena::free): Ditto.
  37388. * rendering/RenderBlock.cpp:
  37389. (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
  37390. instead of RenderFlowSequencedSet.
  37391. (WebCore::RenderBlock::paintContinuationOutlines): Ditto.
  37392. (WebCore::stripTrailingSpace): Ditto.
  37393. (WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
  37394. (WebCore::RenderBlock::updateFirstLetter): Ditto.
  37395. * rendering/RenderContainer.cpp:
  37396. (WebCore::RenderContainer::addChild): Use toRenderText.
  37397. * rendering/RenderFlow.cpp:
  37398. (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
  37399. instead of RenderFlowSequencedSet.
  37400. (WebCore::RenderFlow::paintLines): Ditto.
  37401. * rendering/RenderMenuList.cpp: Removed some unneeded includes.
  37402. * rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
  37403. Made more members private.
  37404. * rendering/RenderObject.cpp: Updated includes.
  37405. (WebCore::RenderObject::isEditable): Use toRenderText.
  37406. (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
  37407. include VisiblePosition.h in the header just for this.
  37408. * rendering/RenderObject.h: Removed unneeded includes and forward declarations.
  37409. Changed special vertical position values to be constants rather than an enum.
  37410. Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
  37411. * rendering/RenderText.cpp:
  37412. (WebCore::RenderText::findNextInlineTextBox): Use function members instead of
  37413. data members of InlineTextBox.
  37414. (WebCore::RenderText::positionForCoordinates): Ditto.
  37415. (WebCore::isInlineFlowOrEmptyText): Use toRenderText.
  37416. (WebCore::RenderText::previousCharacter): Use function members instead of
  37417. data members of InlineTextBox.
  37418. (WebCore::RenderText::position): Ditto.
  37419. (WebCore::RenderText::caretMinOffset): Ditto.
  37420. (WebCore::RenderText::caretMaxOffset): Ditto.
  37421. (WebCore::RenderText::caretMaxRenderedOffset): Ditto.
  37422. * rendering/RenderText.h: Added definition of toRenderText.
  37423. * rendering/RenderTextControl.cpp:
  37424. (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
  37425. * rendering/RenderTreeAsText.cpp:
  37426. (WebCore::operator<<): Use toRenderText and toRenderBox.
  37427. (WebCore::writeTextRun): Ditto.
  37428. (WebCore::write): Ditto.
  37429. * rendering/bidi.cpp:
  37430. (WebCore::InlineIterator::increment): Use toRenderText.
  37431. (WebCore::InlineIterator::current): Ditto.
  37432. (WebCore::checkMidpoints): Ditto.
  37433. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
  37434. (WebCore::RenderBlock::layoutInlineChildren): Ditto.
  37435. (WebCore::RenderBlock::determineStartPosition): Ditto.
  37436. (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
  37437. (WebCore::RenderBlock::findNextLineBreak): Ditto.
  37438. 2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
  37439. Reviewed by Simon Hausmann.
  37440. Fix gcc compiler warning (deprecated conversion from constant string to char*)
  37441. "" cannot be stored in a char*
  37442. * plugins/PluginStream.cpp:
  37443. (WebCore::PluginStream::destroyStream):
  37444. 2009-01-24 Alexey Proskuryakov <ap@webkit.org>
  37445. Reviewed by Darin Adler.
  37446. <rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)
  37447. Changed single argument KURL constructors back to always expect an already encoded string,
  37448. eliminating extra conversions.
  37449. This is a rather unstable situation, as it is often unclear whether a given string is safe
  37450. to convert to KURL without resolving. I think that going forward, the solution is to try to
  37451. keep encoded URLs as KURL instances, and not as strings.
  37452. * platform/KURL.h: Updated comments.
  37453. * platform/KURL.cpp:
  37454. (WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The
  37455. intention is to verify that it is already parsed and encoded by KURL or equivalent code, but
  37456. since encoding is scheme-dependent, such a verification would be quite complicated.
  37457. Don't encode the string as UTF-8, as it supposed to be ASCII-only.
  37458. Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find
  37459. any reason for it to exist, but I saw several cases where this code path was taken
  37460. inadvertently (see examples in LayoutTests/ChangeLog).
  37461. (WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding
  37462. is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing
  37463. the old one), and an already encoded string is expected by parse().
  37464. In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME.
  37465. (WebCore::KURL::setHost): Ditto.
  37466. (WebCore::KURL::setPort): Ditto.
  37467. (WebCore::KURL::setHostAndPort): Ditto.
  37468. (WebCore::KURL::setUser): Ditto.
  37469. (WebCore::KURL::setPass): Ditto.
  37470. (WebCore::KURL::setRef): Ditto.
  37471. (WebCore::KURL::setQuery): Ditto.
  37472. (WebCore::KURL::setPath): Ditto.
  37473. (WebCore::KURL::parse): Verify that the passed string is already encoded.
  37474. * html/HTMLLinkElement.cpp:
  37475. (WebCore::HTMLLinkElement::parseMappedAttribute):
  37476. (WebCore::HTMLLinkElement::process):
  37477. * html/HTMLLinkElement.h:
  37478. Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see
  37479. LayoutTests/ChangeLog).
  37480. * loader/FrameLoader.cpp:
  37481. (WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup.
  37482. (WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that
  37483. String to KURL conversion requires the string to be already encoded.
  37484. * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin.
  37485. HTML5 seems a little unclear on how this should work (it talks about "either parsing it as
  37486. a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a
  37487. security origin object), so I just made the code as close to what we already had as possible.
  37488. 2009-01-24 Darin Adler <darin@apple.com>
  37489. Try to fix Qt build.
  37490. * WebCore.pro: Added JSTextCustom.cpp.
  37491. 2009-01-23 Chris Marrin <cmarrin@apple.com>
  37492. Reviewed by David Hyatt.
  37493. https://bugs.webkit.org/show_bug.cgi?id=23467
  37494. Change styleAvailable functionality to be a linked list
  37495. rather than scanning every CompositeAnimation for
  37496. Animations that are waiting for styleAvailable. This has
  37497. potential for large performance improvement in cases where
  37498. there are many animations firing at once. But it will also
  37499. help in my next fix, which is to synchronize software and
  37500. accelerated animations.
  37501. I also changed slightly when the beginAnimationUpdate and
  37502. endAnimationUpdate calls are made. But this has no real
  37503. effect on performance or behavior.
  37504. * dom/Document.cpp:
  37505. (WebCore::Document::recalcStyle):
  37506. (WebCore::Document::updateRendering):
  37507. * page/animation/AnimationBase.cpp:
  37508. (WebCore::AnimationBase::AnimationBase):
  37509. (WebCore::AnimationBase::~AnimationBase):
  37510. (WebCore::AnimationBase::updateStateMachine):
  37511. * page/animation/AnimationBase.h:
  37512. (WebCore::AnimationBase::next):
  37513. (WebCore::AnimationBase::setNext):
  37514. (WebCore::AnimationBase::styleAvailable):
  37515. * page/animation/AnimationController.cpp:
  37516. (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
  37517. (WebCore::AnimationControllerPrivate::addToStyleAvailableWaitList):
  37518. (WebCore::AnimationControllerPrivate::removeFromStyleAvailableWaitList):
  37519. (WebCore::AnimationControllerPrivate::styleAvailable):
  37520. (WebCore::AnimationController::AnimationController):
  37521. (WebCore::AnimationController::endAnimationUpdate):
  37522. (WebCore::AnimationController::addToStyleAvailableWaitList):
  37523. (WebCore::AnimationController::removeFromStyleAvailableWaitList):
  37524. * page/animation/AnimationController.h:
  37525. * page/animation/CompositeAnimation.cpp:
  37526. (WebCore::CompositeAnimationPrivate::addToStyleAvailableWaitList):
  37527. (WebCore::CompositeAnimationPrivate::removeFromStyleAvailableWaitList):
  37528. (WebCore::CompositeAnimation::addToStyleAvailableWaitList):
  37529. (WebCore::CompositeAnimation::removeFromStyleAvailableWaitList):
  37530. * page/animation/CompositeAnimation.h:
  37531. 2009-01-24 Alexey Proskuryakov <ap@webkit.org>
  37532. Reviewed by Darin Adler.
  37533. <rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch
  37534. Test: http/tests/xmlhttprequest/encode-request-url-2.html
  37535. * platform/KURL.cpp:
  37536. (WebCore::appendASCII): Added a helper function.
  37537. (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
  37538. specified behavior.
  37539. (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
  37540. stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
  37541. of the byte stream can use different encodings, round-tripping is not possible.
  37542. (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
  37543. this function convert the string to utf-8. I think that on the remanining code paths, it is
  37544. correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
  37545. FIXME warning.
  37546. 2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
  37547. Gtk build fix after r40170
  37548. * GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
  37549. and editing/RemoveNodeAttributeCommand.h
  37550. 2009-01-23 Adam Treat <adam.treat@torchmobile.com>
  37551. Fix the Qt build after r40205.
  37552. * WebCore.pro:
  37553. 2009-01-23 Brady Eidson <beidson@apple.com>
  37554. Reviewed by Darin Adler
  37555. In CachedPage, break off per-Frame pieces of data into a CachedFrame object.
  37556. * GNUmakefile.am:
  37557. * WebCore.base.exp:
  37558. * WebCore.pro:
  37559. * WebCore.scons:
  37560. * WebCore.vcproj/WebCore.vcproj:
  37561. * WebCore.xcodeproj/project.pbxproj:
  37562. * WebCoreSources.bkl:
  37563. * history/CachedFrame.cpp: Added.
  37564. (WebCore::cachedFrameCounter):
  37565. (WebCore::CachedFrame::CachedFrame):
  37566. (WebCore::CachedFrame::~CachedFrame):
  37567. (WebCore::CachedFrame::restore):
  37568. (WebCore::CachedFrame::clear):
  37569. (WebCore::CachedFrame::setCachedFramePlatformData):
  37570. (WebCore::CachedFrame::cachedFramePlatformData):
  37571. * history/CachedFrame.h: Added.
  37572. (WebCore::CachedFrame::document):
  37573. (WebCore::CachedFrame::documentLoader):
  37574. (WebCore::CachedFrame::view):
  37575. (WebCore::CachedFrame::mousePressNode):
  37576. (WebCore::CachedFrame::url):
  37577. (WebCore::CachedFrame::domWindow):
  37578. * history/CachedPage.cpp:
  37579. (WebCore::CachedPage::CachedPage):
  37580. (WebCore::CachedPage::restore):
  37581. (WebCore::CachedPage::clear):
  37582. (WebCore::CachedPage::setCachedFramePlatformData):
  37583. (WebCore::CachedPage::cachedFramePlatformData):
  37584. * history/CachedPage.h:
  37585. (WebCore::CachedPage::document):
  37586. (WebCore::CachedPage::documentLoader):
  37587. (WebCore::CachedPage::view):
  37588. (WebCore::CachedPage::mousePressNode):
  37589. (WebCore::CachedPage::url):
  37590. (WebCore::CachedPage::domWindow):
  37591. * loader/FrameLoader.cpp:
  37592. (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
  37593. creating a CachedPage was a historical relic. Take the opportunity to clean that up.
  37594. 2009-01-23 David Hyatt <hyatt@apple.com>
  37595. Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow. Fix up all the places
  37596. that triggered the ASSERT (since all of these places are effectively regressions from my landing that
  37597. devirtualized width()/height()).
  37598. Reviewed by Adele
  37599. * dom/Position.cpp:
  37600. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
  37601. * editing/DeleteButtonController.cpp:
  37602. (WebCore::isDeletableElement):
  37603. * html/HTMLAnchorElement.cpp:
  37604. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  37605. * rendering/RenderBox.cpp:
  37606. (WebCore::RenderBox::clientWidth):
  37607. (WebCore::RenderBox::clientHeight):
  37608. (WebCore::RenderBox::scrollWidth):
  37609. (WebCore::RenderBox::scrollHeight):
  37610. (WebCore::RenderBox::absoluteOutlineBounds):
  37611. * rendering/RenderBox.h:
  37612. (WebCore::RenderBox::width):
  37613. (WebCore::RenderBox::height):
  37614. (WebCore::RenderBox::size):
  37615. (WebCore::RenderBox::frameRect):
  37616. (WebCore::RenderBox::borderBoundingBox):
  37617. * rendering/RenderFlow.h:
  37618. (WebCore::RenderFlow::borderBoundingBox):
  37619. * rendering/RenderLayer.cpp:
  37620. (WebCore::RenderLayer::updateLayerPosition):
  37621. * rendering/RenderScrollbarPart.cpp:
  37622. (WebCore::RenderScrollbarPart::styleWillChange):
  37623. * rendering/RenderScrollbarPart.h:
  37624. * wml/WMLAElement.cpp:
  37625. (WebCore::WMLAElement::isKeyboardFocusable):
  37626. 2009-01-23 Darin Adler <darin@apple.com>
  37627. Reviewed by Anders Carlsson.
  37628. Bug 23352: Turn on more compiler warnings in the Mac build
  37629. https://bugs.webkit.org/show_bug.cgi?id=23352
  37630. Second patch: Slightly less simple cases of various warnings.
  37631. * bridge/jni/jni_runtime.h:
  37632. (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
  37633. away const.
  37634. * dom/XMLTokenizerLibxml2.cpp:
  37635. (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
  37636. reinterpret_cast; this is casting the result of malloc, and the idiom is to use
  37637. static_cast, which works because we're casting from void*.
  37638. (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
  37639. C-style casts.
  37640. * xml/XSLTUnicodeSort.cpp:
  37641. (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
  37642. instead of redefining the function.
  37643. 2009-01-23 Darin Adler <darin@apple.com>
  37644. Reviewed by Anders Carlsson.
  37645. Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
  37646. https://bugs.webkit.org/show_bug.cgi?id=23475
  37647. * editing/TextIterator.cpp:
  37648. (WebCore::SearchBuffer::search): Set the character start flag to false to
  37649. ensure we won't ever return the same result twice. There are other ways we
  37650. could accomplish this, mentioned in the comment, but this one was the smallest
  37651. and cleanest I could think of.
  37652. 2009-01-23 Darin Adler <darin@apple.com>
  37653. Reviewed by Anders Carlsson.
  37654. Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
  37655. https://bugs.webkit.org/show_bug.cgi?id=23510
  37656. That patch fixed the optimization that's supposed to give a faster path for
  37657. allocating the wrappers for DOM Text objects. But CDATASection is the one
  37658. subclass of Text objects.
  37659. * GNUmakefile.am: Added JSCDATASectionCustom.cpp.
  37660. * WebCore.scons: Ditto.
  37661. * WebCore.vcproj/WebCore.vcproj: Ditto.
  37662. * WebCore.xcodeproj/project.pbxproj: Ditto.
  37663. * WebCoreSources.bkl: Ditto.
  37664. * bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
  37665. (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.
  37666. * bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
  37667. for CDATASection. We don't want to have to check when creating a wrapper for a
  37668. Text object whether it's a CDATASection object or not, so we need to do this overload
  37669. at compile time.
  37670. 2009-01-23 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  37671. Reviewed by Eric Seidel.
  37672. Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
  37673. WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).
  37674. WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
  37675. Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
  37676. from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
  37677. base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
  37678. another base class, just like FormControlElement.
  37679. Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
  37680. HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
  37681. objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.
  37682. Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
  37683. Add new virtual function isFormControlElementWithState() to Element.h.
  37684. * GNUmakefile.am:
  37685. * WebCore.order:
  37686. * WebCore.pro:
  37687. * WebCore.scons:
  37688. * WebCore.vcproj/WebCore.vcproj:
  37689. * WebCore.xcodeproj/project.pbxproj:
  37690. * WebCoreSources.bkl:
  37691. * dom/Document.cpp:
  37692. (WebCore::Document::formElementsState):
  37693. * dom/Document.h:
  37694. (WebCore::Document::registerFormElementWithState):
  37695. (WebCore::Document::unregisterFormElementWithState):
  37696. * dom/Element.h:
  37697. (WebCore::Element::isFormControlElement):
  37698. (WebCore::Element::isFormControlElementWithState):
  37699. * dom/FormControlElement.cpp:
  37700. (WebCore::toFormControlElement):
  37701. * dom/FormControlElement.h:
  37702. * dom/FormControlElementWithState.cpp: Added.
  37703. (WebCore::FormControlElementWithState::registerFormControlElementWithState):
  37704. (WebCore::FormControlElementWithState::unregisterFormControlElementWithState):
  37705. (WebCore::FormControlElementWithState::finishParsingChildren):
  37706. (WebCore::toFormControlElementWithState):
  37707. * dom/FormControlElementWithState.h: Added.
  37708. (WebCore::FormControlElementWithState::~FormControlElementWithState):
  37709. (WebCore::FormControlElementWithState::FormControlElementWithState):
  37710. * html/HTMLElement.h:
  37711. * html/HTMLFormControlElement.cpp:
  37712. (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
  37713. (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
  37714. (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
  37715. (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
  37716. * html/HTMLFormControlElement.h:
  37717. (WebCore::HTMLFormControlElement::isFormControlElement):
  37718. (WebCore::HTMLFormControlElementWithState::isFormControlElementWithState):
  37719. (WebCore::HTMLFormControlElementWithState::toFormControlElement):
  37720. * html/HTMLFormElement.cpp:
  37721. (WebCore::HTMLFormElement::formElementIndex):
  37722. * html/HTMLLabelElement.cpp:
  37723. (WebCore::HTMLLabelElement::correspondingControl):
  37724. * html/HTMLLegendElement.cpp:
  37725. (WebCore::HTMLLegendElement::formElement):
  37726. * page/Frame.cpp:
  37727. (WebCore::Frame::searchForLabelsBeforeElement):
  37728. (WebCore::scanForForm):
  37729. (WebCore::Frame::currentForm):
  37730. * page/mac/FrameMac.mm:
  37731. (WebCore::Frame::searchForLabelsBeforeElement):
  37732. * wml/WMLCardElement.cpp:
  37733. (WebCore::WMLCardElement::WMLCardElement):
  37734. (WebCore::WMLCardElement::parseMappedAttribute):
  37735. (WebCore::WMLCardElement::insertedIntoDocument):
  37736. * wml/WMLCardElement.h:
  37737. * wml/WMLDoElement.cpp:
  37738. (WebCore::WMLDoElement::insertedIntoDocument):
  37739. * wml/WMLElement.h:
  37740. (WebCore::WMLElement::isWMLElement):
  37741. * wml/WMLEventHandlingElement.cpp:
  37742. (WebCore::WMLEventHandlingElement::WMLEventHandlingElement):
  37743. (WebCore::WMLEventHandlingElement::registerDoElement):
  37744. (WebCore::toWMLEventHandlingElement):
  37745. * wml/WMLEventHandlingElement.h:
  37746. * wml/WMLFormControlElement.cpp: Added.
  37747. (WebCore::WMLFormControlElement::WMLFormControlElement):
  37748. (WebCore::WMLFormControlElement::~WMLFormControlElement):
  37749. (WebCore::WMLFormControlElementWithState::WMLFormControlElementWithState):
  37750. (WebCore::WMLFormControlElementWithState::~WMLFormControlElementWithState):
  37751. * wml/WMLFormControlElement.h: Added.
  37752. (WebCore::WMLFormControlElement::isFormControlElement):
  37753. (WebCore::WMLFormControlElement::valueMatchesRenderer):
  37754. (WebCore::WMLFormControlElement::setValueMatchesRenderer):
  37755. (WebCore::WMLFormControlElement::name):
  37756. (WebCore::WMLFormControlElementWithState::isFormControlElementWithState):
  37757. (WebCore::WMLFormControlElementWithState::toFormControlElement):
  37758. * wml/WMLInputElement.cpp:
  37759. (WebCore::WMLInputElement::WMLInputElement):
  37760. (WebCore::WMLInputElement::type):
  37761. * wml/WMLInputElement.h:
  37762. * wml/WMLOnEventElement.cpp:
  37763. (WebCore::WMLOnEventElement::registerTask):
  37764. * wml/WMLOptGroupElement.cpp:
  37765. (WebCore::WMLOptGroupElement::WMLOptGroupElement):
  37766. (WebCore::WMLOptGroupElement::type):
  37767. * wml/WMLOptGroupElement.h:
  37768. * wml/WMLOptionElement.cpp:
  37769. (WebCore::WMLOptionElement::WMLOptionElement):
  37770. (WebCore::WMLOptionElement::type):
  37771. * wml/WMLOptionElement.h:
  37772. * wml/WMLTemplateElement.cpp:
  37773. (WebCore::WMLTemplateElement::WMLTemplateElement):
  37774. (WebCore::WMLTemplateElement::parseMappedAttribute):
  37775. * wml/WMLTemplateElement.h:
  37776. 2009-01-23 Chris Fleizach <cfleizach@apple.com>
  37777. Reviewed by Darin Adler.
  37778. Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
  37779. https://bugs.webkit.org/show_bug.cgi?id=23509
  37780. Add null checking in makeRange instead of AX code
  37781. * editing/VisiblePosition.cpp:
  37782. (WebCore::makeRange):
  37783. * page/AccessibilityObject.cpp:
  37784. (WebCore::AccessibilityObject::nextSentenceEndPosition):
  37785. (WebCore::AccessibilityObject::previousSentenceStartPosition):
  37786. 2009-01-23 Adam Treat <adam.treat@torchmobile.com>
  37787. Fix the Gtk build too after removal of RenderBox::toConstRenderBox
  37788. * platform/gtk/RenderThemeGtk.cpp:
  37789. (WebCore::RenderThemeGtk::baselinePosition):
  37790. 2009-01-23 Adam Treat <adam.treat@torchmobile.com>
  37791. Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
  37792. * platform/qt/RenderThemeQt.cpp:
  37793. (WebCore::RenderThemeQt::baselinePosition):
  37794. 2009-01-23 Adam Treat <adam.treat@torchmobile.com>
  37795. Fix the Qt build after r40168.
  37796. * WebCore.pro:
  37797. 2009-01-23 Brady Eidson <beidson@apple.com>
  37798. Rubberstamped by Darin Adler
  37799. Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
  37800. * GNUmakefile.am:
  37801. * WebCore.base.exp:
  37802. * WebCore.order:
  37803. * WebCore.xcodeproj/project.pbxproj:
  37804. * history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
  37805. (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
  37806. * history/CachedPagePlatformData.h: Removed.
  37807. * history/CachedPage.cpp:
  37808. (WebCore::CachedPage::clear):
  37809. (WebCore::CachedPage::setCachedFramePlatformData):
  37810. (WebCore::CachedPage::cachedFramePlatformData):
  37811. * history/CachedPage.h:
  37812. 2009-01-23 Kevin Watters <kevinwatters@gmail.com>
  37813. Reviewed by Kevin Ollivier.
  37814. Fix drawing in situations where sub-portions of the bitmap are to be
  37815. drawn to the screen.
  37816. * platform/graphics/wx/ImageWx.cpp:
  37817. (WebCore::BitmapImage::draw):
  37818. 2009-01-23 Kevin Ollivier <kevino@theolliviers.com>
  37819. Build fixes for recent changes.
  37820. * WebCoreSources.bkl:
  37821. * plugins/PluginView.cpp:
  37822. (WebCore::PluginView::invalidateWindowlessPluginRect):
  37823. 2009-01-23 Eric Carlson <eric.carlson@apple.com>
  37824. Reviewed by Adele Peterson
  37825. Fix for https://bugs.webkit.org/show_bug.cgi?id=23407
  37826. Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
  37827. is never hidden (as with an <audio> element).
  37828. Test: media/video-controls-visible-audio-only.html
  37829. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  37830. (WebCore::MediaPlayerPrivate::hasVideo):
  37831. * platform/graphics/win/QTMovieWin.cpp:
  37832. (QTMovieWin::hasVideo):
  37833. * platform/graphics/win/QTMovieWin.h:
  37834. 2009-01-23 David Hyatt <hyatt@apple.com>
  37835. Make toRenderBox a non-member function. Rename toConstRenderBox to just also be called toRenderBox.
  37836. Reviewed by Oliver Hunt
  37837. * css/CSSComputedStyleDeclaration.cpp:
  37838. (WebCore::sizingBox):
  37839. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  37840. * dom/ContainerNode.cpp:
  37841. (WebCore::ContainerNode::getUpperLeftCorner):
  37842. (WebCore::ContainerNode::getLowerRightCorner):
  37843. * dom/Element.cpp:
  37844. (WebCore::Element::scrollByUnits):
  37845. * dom/Position.cpp:
  37846. (WebCore::endsOfNodeAreVisuallyDistinctPositions):
  37847. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
  37848. (WebCore::Position::isCandidate):
  37849. * editing/DeleteButtonController.cpp:
  37850. (WebCore::isDeletableElement):
  37851. * editing/EditorCommand.cpp:
  37852. (WebCore::verticalScrollDistance):
  37853. * editing/TextIterator.cpp:
  37854. (WebCore::shouldEmitExtraNewlineForNode):
  37855. * html/HTMLAnchorElement.cpp:
  37856. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  37857. * html/HTMLFormControlElement.cpp:
  37858. (WebCore::HTMLFormControlElement::isFocusable):
  37859. * html/HTMLFrameElementBase.cpp:
  37860. (WebCore::HTMLFrameElementBase::width):
  37861. (WebCore::HTMLFrameElementBase::height):
  37862. * page/AccessibilityRenderObject.cpp:
  37863. (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  37864. * page/EventHandler.cpp:
  37865. (WebCore::EventHandler::handleMouseDraggedEvent):
  37866. (WebCore::EventHandler::autoscrollTimerFired):
  37867. (WebCore::EventHandler::updateAutoscrollRenderer):
  37868. (WebCore::EventHandler::stopAutoscrollTimer):
  37869. (WebCore::EventHandler::scrollOverflow):
  37870. * page/FrameView.cpp:
  37871. (WebCore::FrameView::layout):
  37872. * page/animation/AnimationBase.cpp:
  37873. (WebCore::blendFunc):
  37874. * rendering/InlineBox.cpp:
  37875. (WebCore::InlineBox::adjustPosition):
  37876. * rendering/InlineBox.h:
  37877. (WebCore::InlineBox::renderBox):
  37878. * rendering/RenderBlock.cpp:
  37879. (WebCore::RenderBlock::clearFloats):
  37880. * rendering/RenderBox.cpp:
  37881. (WebCore::RenderBox::offsetFromContainer):
  37882. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  37883. (WebCore::RenderBox::containingBlockWidthForPositioned):
  37884. (WebCore::RenderBox::containingBlockHeightForPositioned):
  37885. (WebCore::RenderBox::calcAbsoluteHorizontal):
  37886. (WebCore::RenderBox::calcAbsoluteVertical):
  37887. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  37888. (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  37889. * rendering/RenderBox.h:
  37890. (WebCore::toRenderBox):
  37891. (WebCore::RenderBox::previousSiblingBox):
  37892. (WebCore::RenderBox::nextSiblingBox):
  37893. (WebCore::RenderBox::parentBox):
  37894. * rendering/RenderFlow.cpp:
  37895. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  37896. * rendering/RenderLayer.cpp:
  37897. (WebCore::RenderLayer::updateLayerPosition):
  37898. (WebCore::RenderLayer::resize):
  37899. (WebCore::RenderLayer::boundingBox):
  37900. * rendering/RenderObject.cpp:
  37901. (WebCore::addLayers):
  37902. (WebCore::RenderObject::removeLayers):
  37903. (WebCore::RenderObject::moveLayers):
  37904. (WebCore::RenderObject::findNextLayer):
  37905. (WebCore::RenderObject::enclosingLayer):
  37906. (WebCore::RenderObject::setNeedsLayout):
  37907. (WebCore::RenderObject::setNeedsPositionedMovementLayout):
  37908. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  37909. (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
  37910. (WebCore::RenderObject::computeAbsoluteRepaintRect):
  37911. (WebCore::RenderObject::localToAbsolute):
  37912. (WebCore::RenderObject::absoluteToLocal):
  37913. (WebCore::RenderObject::localToAbsoluteQuad):
  37914. (WebCore::RenderObject::offsetFromContainer):
  37915. (WebCore::RenderObject::removeFromObjectLists):
  37916. (WebCore::RenderObject::destroy):
  37917. (WebCore::RenderObject::updateHitTestResult):
  37918. (WebCore::RenderObject::addDashboardRegions):
  37919. * rendering/RenderTableSection.cpp:
  37920. (WebCore::RenderTableSection::layoutRows):
  37921. * rendering/RenderTheme.cpp:
  37922. (WebCore::RenderTheme::hitTestMediaControlPart):
  37923. (WebCore::RenderTheme::baselinePosition):
  37924. * rendering/RenderThemeMac.mm:
  37925. (WebCore::RenderThemeMac::hitTestMediaControlPart):
  37926. * rendering/RenderTreeAsText.cpp:
  37927. (WebCore::externalRepresentation):
  37928. * rendering/bidi.cpp:
  37929. (WebCore::inlineWidth):
  37930. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  37931. (WebCore::requiresLineBox):
  37932. (WebCore::RenderBlock::findNextLineBreak):
  37933. * svg/SVGLength.cpp:
  37934. (WebCore::SVGLength::PercentageOfViewport):
  37935. * wml/WMLAElement.cpp:
  37936. (WebCore::WMLAElement::isKeyboardFocusable):
  37937. * wml/WMLInputElement.cpp:
  37938. (WebCore::isInputFocusable):
  37939. 2009-01-23 Chris Fleizach <cfleizach@apple.com>
  37940. Reviewed by Beth Dakin.
  37941. Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
  37942. https://bugs.webkit.org/show_bug.cgi?id=23509
  37943. Add null checking around next/previous sentence retrieval in AX code
  37944. * page/AccessibilityObject.cpp:
  37945. (WebCore::AccessibilityObject::nextSentenceEndPosition):
  37946. (WebCore::AccessibilityObject::previousSentenceStartPosition):
  37947. 2009-01-23 David Hyatt <hyatt@apple.com>
  37948. Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites
  37949. Inline flow repainting was broken because it relied on width() and height(). Give RenderFlow a linesBoundingBox
  37950. method for obtaining a reasonable bounding box to use for repainting. Eliminate the methods from RenderInline
  37951. since compacts/run-ins need them too, so putting them on RenderFlow is necessary.
  37952. For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
  37953. well.
  37954. Reviewed by Oliver Hunt
  37955. * WebCore.base.exp:
  37956. * dom/ContainerNode.cpp:
  37957. (WebCore::ContainerNode::getUpperLeftCorner):
  37958. (WebCore::ContainerNode::getLowerRightCorner):
  37959. * dom/Position.cpp:
  37960. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
  37961. * rendering/RenderBox.cpp:
  37962. (WebCore::RenderBox::containingBlockHeightForPositioned):
  37963. * rendering/RenderFlow.cpp:
  37964. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  37965. (WebCore::RenderFlow::linesBoundingBox):
  37966. * rendering/RenderFlow.h:
  37967. * rendering/RenderInline.cpp:
  37968. * rendering/RenderInline.h:
  37969. (WebCore::RenderInline::offsetWidth):
  37970. (WebCore::RenderInline::offsetHeight):
  37971. * rendering/RenderLayer.cpp:
  37972. (WebCore::RenderLayer::updateLayerPosition):
  37973. * rendering/RenderText.cpp:
  37974. (WebCore::RenderText::linesBoundingBox):
  37975. * rendering/RenderText.h:
  37976. * rendering/RenderTreeAsText.cpp:
  37977. (WebCore::operator<<):
  37978. * rendering/SVGRenderTreeAsText.cpp:
  37979. (WebCore::write):
  37980. 2009-01-23 David Hyatt <hyatt@apple.com>
  37981. Move layer() into RenderBox and make it non-virtual. Move all of the scrolling functions from RenderObject
  37982. to RenderBox and devirtualize as many as possible. Clean up styleWillChange to factor code specific to
  37983. RenderBox and RenderBlock into their appropriate subclasses. Stubbed out an empty styleWillChange on
  37984. RenderText, since none of the work done in styleWillChange was relevant to text nodes.
  37985. Reviewed by Sam Weinig
  37986. * dom/Document.cpp:
  37987. (WebCore::Document::elementFromPoint):
  37988. (WebCore::Document::renderView):
  37989. (WebCore::Document::prepareMouseEvent):
  37990. * dom/Document.h:
  37991. * dom/Element.cpp:
  37992. (WebCore::Element::scrollByUnits):
  37993. * editing/SelectionController.cpp:
  37994. (WebCore::SelectionController::contains):
  37995. * html/HTMLMarqueeElement.cpp:
  37996. (WebCore::HTMLMarqueeElement::start):
  37997. (WebCore::HTMLMarqueeElement::stop):
  37998. * page/AccessibilityRenderObject.cpp:
  37999. (WebCore::AccessibilityRenderObject::topRenderer):
  38000. (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  38001. (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  38002. * page/AccessibilityRenderObject.h:
  38003. * page/EventHandler.cpp:
  38004. (WebCore::scrollAndAcceptEvent):
  38005. (WebCore::EventHandler::handleMousePressEvent):
  38006. (WebCore::EventHandler::handleMouseDraggedEvent):
  38007. (WebCore::EventHandler::updateSelectionForMouseDrag):
  38008. (WebCore::EventHandler::autoscrollTimerFired):
  38009. (WebCore::EventHandler::updateAutoscrollRenderer):
  38010. (WebCore::EventHandler::stopAutoscrollTimer):
  38011. (WebCore::EventHandler::scrollOverflow):
  38012. (WebCore::EventHandler::handleWheelEvent):
  38013. (WebCore::EventHandler::hoverTimerFired):
  38014. * page/Frame.cpp:
  38015. (WebCore::Frame::clearTimers):
  38016. * rendering/RenderBlock.cpp:
  38017. (WebCore::RenderBlock::styleWillChange):
  38018. * rendering/RenderBlock.h:
  38019. * rendering/RenderBox.cpp:
  38020. (WebCore::RenderBox::styleWillChange):
  38021. (WebCore::RenderBox::verticalScrollbarWidth):
  38022. (WebCore::RenderBox::horizontalScrollbarHeight):
  38023. (WebCore::RenderBox::scroll):
  38024. (WebCore::RenderBox::canBeProgramaticallyScrolled):
  38025. (WebCore::RenderBox::autoscroll):
  38026. (WebCore::RenderBox::panScroll):
  38027. (WebCore::RenderBox::offsetFromContainer):
  38028. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  38029. * rendering/RenderBox.h:
  38030. (WebCore::RenderBox::layer):
  38031. (WebCore::RenderBox::requiresLayer):
  38032. (WebCore::RenderBox::stopAutoscroll):
  38033. (WebCore::RenderBox::hasAutoVerticalScrollbar):
  38034. (WebCore::RenderBox::hasAutoHorizontalScrollbar):
  38035. (WebCore::RenderBox::scrollsOverflow):
  38036. (WebCore::RenderBox::scrollsOverflowX):
  38037. (WebCore::RenderBox::scrollsOverflowY):
  38038. (WebCore::RenderBox::includeVerticalScrollbarSize):
  38039. (WebCore::RenderBox::includeHorizontalScrollbarSize):
  38040. * rendering/RenderFlow.cpp:
  38041. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  38042. (WebCore::RenderFlow::addFocusRingRects):
  38043. * rendering/RenderForeignObject.cpp:
  38044. * rendering/RenderForeignObject.h:
  38045. (WebCore::RenderForeignObject::requiresLayer):
  38046. * rendering/RenderInline.cpp:
  38047. * rendering/RenderInline.h:
  38048. (WebCore::RenderInline::requiresLayer):
  38049. * rendering/RenderLayer.cpp:
  38050. (WebCore::RenderLayer::childrenClipRect):
  38051. (WebCore::RenderLayer::selfClipRect):
  38052. * rendering/RenderListBox.cpp:
  38053. * rendering/RenderListBox.h:
  38054. * rendering/RenderObject.cpp:
  38055. (WebCore::addLayers):
  38056. (WebCore::RenderObject::removeLayers):
  38057. (WebCore::RenderObject::moveLayers):
  38058. (WebCore::RenderObject::findNextLayer):
  38059. (WebCore::RenderObject::enclosingLayer):
  38060. (WebCore::RenderObject::setNeedsLayout):
  38061. (WebCore::RenderObject::setNeedsPositionedMovementLayout):
  38062. (WebCore::RenderObject::computeAbsoluteRepaintRect):
  38063. (WebCore::RenderObject::styleWillChange):
  38064. (WebCore::RenderObject::localToAbsolute):
  38065. (WebCore::RenderObject::absoluteToLocal):
  38066. (WebCore::RenderObject::localToAbsoluteQuad):
  38067. (WebCore::RenderObject::offsetFromContainer):
  38068. (WebCore::RenderObject::destroy):
  38069. * rendering/RenderObject.h:
  38070. * rendering/RenderPath.cpp:
  38071. * rendering/RenderPath.h:
  38072. (WebCore::RenderPath::requiresLayer):
  38073. * rendering/RenderReplica.h:
  38074. (WebCore::RenderReplica::requiresLayer):
  38075. * rendering/RenderSVGContainer.cpp:
  38076. * rendering/RenderSVGContainer.h:
  38077. (WebCore::RenderSVGContainer::requiresLayer):
  38078. * rendering/RenderSVGHiddenContainer.cpp:
  38079. * rendering/RenderSVGHiddenContainer.h:
  38080. (WebCore::RenderSVGHiddenContainer::requiresLayer):
  38081. * rendering/RenderSVGImage.cpp:
  38082. * rendering/RenderSVGImage.h:
  38083. (WebCore::RenderSVGImage::requiresLayer):
  38084. * rendering/RenderSVGInline.h:
  38085. (WebCore::RenderSVGInline::requiresLayer):
  38086. * rendering/RenderSVGInlineText.h:
  38087. (WebCore::RenderSVGInlineText::requiresLayer):
  38088. * rendering/RenderSVGText.cpp:
  38089. * rendering/RenderSVGText.h:
  38090. (WebCore::RenderSVGText::requiresLayer):
  38091. * rendering/RenderScrollbarPart.h:
  38092. (WebCore::RenderScrollbarPart::requiresLayer):
  38093. * rendering/RenderSlider.cpp:
  38094. (WebCore::RenderSlider::setCurrentPosition):
  38095. * rendering/RenderTableCell.cpp:
  38096. * rendering/RenderTableCell.h:
  38097. (WebCore::RenderTableCell::requiresLayer):
  38098. * rendering/RenderTableCol.h:
  38099. (WebCore::RenderTableCol::requiresLayer):
  38100. * rendering/RenderTableRow.h:
  38101. (WebCore::RenderTableRow::requiresLayer):
  38102. * rendering/RenderTableSection.cpp:
  38103. (WebCore::RenderTableSection::layoutRows):
  38104. * rendering/RenderText.h:
  38105. (WebCore::RenderText::styleWillChange):
  38106. * rendering/RenderTextControl.cpp:
  38107. (WebCore::RenderTextControl::autoscroll):
  38108. (WebCore::RenderTextControl::scroll):
  38109. * rendering/RenderTextControl.h:
  38110. * rendering/RenderTreeAsText.cpp:
  38111. (WebCore::write):
  38112. (WebCore::externalRepresentation):
  38113. 2009-01-23 Anders Carlsson <andersca@apple.com>
  38114. Fix tyop.
  38115. * editing/markup.cpp:
  38116. (WebCore::joinMarkups):
  38117. 2009-01-23 Anders Carlsson <andersca@apple.com>
  38118. Reviewed by Darin Adler.
  38119. * Configurations/Base.xcconfig:
  38120. Fix GCC 4.0 build.
  38121. * editing/markup.cpp:
  38122. (WebCore::joinMarkups):
  38123. Pass a const reference to the vector.
  38124. * html/HTMLElement.cpp:
  38125. * platform/text/String.cpp:
  38126. Add comments indicating that these functions are for use in the debugger.
  38127. 2009-01-23 Anders Carlsson <andersca@apple.com>
  38128. Reviewed by Sam Weinig.
  38129. Turn on -Wmissing-prototypes and fix the resulting warnings.
  38130. * Configurations/Base.xcconfig:
  38131. * bindings/js/JSHistoryCustom.cpp:
  38132. (WebCore::nonCachingStaticBackFunctionGetter):
  38133. (WebCore::nonCachingStaticForwardFunctionGetter):
  38134. (WebCore::nonCachingStaticGoFunctionGetter):
  38135. * bindings/js/JSLocationCustom.cpp:
  38136. (WebCore::nonCachingStaticReplaceFunctionGetter):
  38137. (WebCore::nonCachingStaticReloadFunctionGetter):
  38138. (WebCore::nonCachingStaticAssignFunctionGetter):
  38139. (WebCore::JSLocation::customGetOwnPropertySlot):
  38140. * bindings/objc/DOMRGBColor.mm:
  38141. (WebCore::getWrapperForRGB):
  38142. (WebCore::setWrapperForRGB):
  38143. (WebCore::removeWrapperForRGB):
  38144. * bindings/scripts/CodeGeneratorJS.pm:
  38145. * bridge/c/c_instance.cpp:
  38146. (JSC::Bindings::globalExceptionString):
  38147. * bridge/runtime_object.cpp:
  38148. (JSC::callRuntimeConstructor):
  38149. * css/CSSParser.cpp:
  38150. (WebCore::parseGradientColorStop):
  38151. * css/CSSPrimitiveValue.cpp:
  38152. (WebCore::scaleFactorForConversion):
  38153. * css/CSSStyleSelector.cpp:
  38154. (WebCore::operator >):
  38155. (WebCore::operator <=):
  38156. (WebCore::getTransformOperationType):
  38157. * dom/make_names.pl:
  38158. * editing/DeleteSelectionCommand.cpp:
  38159. (WebCore::updatePositionForTextRemoval):
  38160. * editing/EditorCommand.cpp:
  38161. (WebCore::valueBackColor):
  38162. (WebCore::valueFontName):
  38163. (WebCore::valueFontSize):
  38164. (WebCore::valueFontSizeDelta):
  38165. (WebCore::valueForeColor):
  38166. * editing/VisiblePosition.cpp:
  38167. (WebCore::canonicalizeCandidate):
  38168. * editing/htmlediting.cpp:
  38169. * editing/markup.cpp:
  38170. (WebCore::joinMarkups):
  38171. * html/HTMLElement.cpp:
  38172. (WebCore::inlineTagList):
  38173. (WebCore::blockTagList):
  38174. * html/HTMLMediaElement.cpp:
  38175. (WebCore::serializeTimeOffset):
  38176. (WebCore::parseTimeOffset):
  38177. * page/mac/FrameMac.mm:
  38178. (WebCore::regExpForLabels):
  38179. * platform/Arena.cpp:
  38180. * platform/graphics/Color.cpp:
  38181. (WebCore::colorFloatToRGBAByte):
  38182. * platform/graphics/cg/ImageSourceCG.cpp:
  38183. (WebCore::imageSourceOptions):
  38184. * platform/graphics/cg/PathCG.cpp:
  38185. (WebCore::CGPathApplierToPathApplier):
  38186. * platform/graphics/mac/SimpleFontDataMac.mm:
  38187. (WebCore::initFontData):
  38188. * platform/mac/PlatformMouseEventMac.mm:
  38189. * platform/text/String.cpp:
  38190. * rendering/RenderBlock.cpp:
  38191. (WebCore::continuationOutlineTable):
  38192. (WebCore::getHeightForLineCount):
  38193. * rendering/RenderView.cpp:
  38194. (WebCore::rendererAfterPosition):
  38195. * rendering/RootInlineBox.cpp:
  38196. (WebCore::isEditableLeaf):
  38197. * rendering/SVGRenderTreeAsText.cpp:
  38198. (WebCore::hasFractions):
  38199. * rendering/style/RenderStyle.cpp:
  38200. (WebCore::positionedObjectMoved):
  38201. * svg/SVGFont.cpp:
  38202. (WebCore::floatWidthUsingSVGFontCallback):
  38203. (WebCore::floatWidthMissingGlyphCallback):
  38204. (WebCore::drawTextUsingSVGFontCallback):
  38205. (WebCore::drawTextMissingGlyphCallback):
  38206. * svg/SVGTransformable.cpp:
  38207. (WebCore::parseTransformParamList):
  38208. * svg/graphics/SVGPaintServerGradient.cpp:
  38209. (WebCore::operator<<):
  38210. * xml/XPathGrammar.y:
  38211. * xml/XSLTExtensions.cpp:
  38212. 2009-01-23 Eric Seidel <eric@webkit.org>
  38213. No review, removing an empty file.
  38214. Remove RemoveNodeAttributeCommand since it was empty.
  38215. * WebCore.pro:
  38216. * WebCore.scons:
  38217. * WebCore.vcproj/WebCore.vcproj:
  38218. * WebCore.xcodeproj/project.pbxproj:
  38219. * editing/RemoveNodeAttributeCommand.cpp: Removed.
  38220. * editing/RemoveNodeAttributeCommand.h: Removed.
  38221. 2009-01-23 Brady Eidson <beidson@apple.com>
  38222. Rubberstamped by Sam Weinig
  38223. Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose
  38224. * GNUmakefile.am:
  38225. * WebCore.vcproj/WebCore.vcproj:
  38226. * WebCore.xcodeproj/project.pbxproj:
  38227. * WebCoreSources.bkl:
  38228. * bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp.
  38229. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
  38230. (WebCore::ScriptCachedFrameData::domWindow):
  38231. (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
  38232. (WebCore::ScriptCachedFrameData::restore):
  38233. (WebCore::ScriptCachedFrameData::clear):
  38234. * bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
  38235. * bindings/js/ScriptCachedPageData.cpp: Removed.
  38236. * bindings/js/ScriptCachedPageData.h: Removed.
  38237. * history/CachedPage.cpp:
  38238. (WebCore::CachedPage::CachedPage):
  38239. (WebCore::CachedPage::restore):
  38240. * history/CachedPage.h:
  38241. 2009-01-23 Steve Falkenburg <sfalken@apple.com>
  38242. Fix build.
  38243. * rendering/RenderThemeSafari.cpp:
  38244. (WebCore::RenderThemeSafari::baselinePosition):
  38245. 2009-01-23 Darin Fisher <darin@chromium.org>
  38246. Reviewed by Eric Seidel.
  38247. https://bugs.webkit.org/show_bug.cgi?id=23506
  38248. Upstream Chromium's image decoders for use with PLATFORM(SKIA)
  38249. * platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
  38250. * platform/image-decoders/skia/BMPImageDecoder.h: Added.
  38251. * platform/image-decoders/skia/BMPImageReader.cpp: Added.
  38252. * platform/image-decoders/skia/BMPImageReader.h: Added.
  38253. * platform/image-decoders/skia/GIFImageDecoder.cpp:
  38254. (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate):
  38255. (WebCore::GIFImageDecoderPrivate::decode):
  38256. (WebCore::GIFImageDecoderPrivate::getColorMap):
  38257. (WebCore::GIFImageDecoder::GIFImageDecoder):
  38258. (WebCore::GIFImageDecoder::isSizeAvailable):
  38259. (WebCore::GIFImageDecoder::frameCount):
  38260. (WebCore::GIFImageDecoder::frameBufferAtIndex):
  38261. (WebCore::GIFImageDecoder::clearFrameBufferCache):
  38262. (WebCore::GIFImageDecoder::decode):
  38263. (WebCore::GIFImageDecoder::sizeNowAvailable):
  38264. (WebCore::GIFImageDecoder::initFrameBuffer):
  38265. (WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
  38266. (WebCore::GIFImageDecoder::haveDecodedRow):
  38267. (WebCore::GIFImageDecoder::frameComplete):
  38268. * platform/image-decoders/skia/GIFImageDecoder.h:
  38269. (WebCore::GIFImageDecoder::filenameExtension):
  38270. (WebCore::GIFImageDecoder::frameDurationAtIndex):
  38271. (WebCore::GIFImageDecoder::):
  38272. * platform/image-decoders/skia/GIFImageReader.cpp:
  38273. (GIFImageReader::do_lzw):
  38274. (GIFImageReader::read):
  38275. * platform/image-decoders/skia/GIFImageReader.h:
  38276. * platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
  38277. * platform/image-decoders/skia/ICOImageDecoder.h: Added.
  38278. * platform/image-decoders/skia/ImageDecoder.h:
  38279. (WebCore::RefCountedNativeImageSkia::create):
  38280. (WebCore::RefCountedNativeImageSkia::bitmap):
  38281. (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia):
  38282. (WebCore::RGBA32Buffer::):
  38283. (WebCore::RGBA32Buffer::RGBA32Buffer):
  38284. (WebCore::RGBA32Buffer::~RGBA32Buffer):
  38285. (WebCore::RGBA32Buffer::operator=):
  38286. (WebCore::RGBA32Buffer::clear):
  38287. (WebCore::RGBA32Buffer::copyBitmapData):
  38288. (WebCore::RGBA32Buffer::bitmap):
  38289. (WebCore::RGBA32Buffer::setSize):
  38290. (WebCore::RGBA32Buffer::width):
  38291. (WebCore::RGBA32Buffer::height):
  38292. (WebCore::RGBA32Buffer::rect):
  38293. (WebCore::RGBA32Buffer::status):
  38294. (WebCore::RGBA32Buffer::duration):
  38295. (WebCore::RGBA32Buffer::disposalMethod):
  38296. (WebCore::RGBA32Buffer::hasAlpha):
  38297. (WebCore::RGBA32Buffer::setRect):
  38298. (WebCore::RGBA32Buffer::setStatus):
  38299. (WebCore::RGBA32Buffer::setDuration):
  38300. (WebCore::RGBA32Buffer::setDisposalMethod):
  38301. (WebCore::RGBA32Buffer::setHasAlpha):
  38302. (WebCore::RGBA32Buffer::setRGBA):
  38303. (WebCore::ImageDecoder::ImageDecoder):
  38304. (WebCore::ImageDecoder::~ImageDecoder):
  38305. (WebCore::ImageDecoder::setData):
  38306. (WebCore::ImageDecoder::isSizeAvailable):
  38307. (WebCore::ImageDecoder::size):
  38308. (WebCore::ImageDecoder::frameCount):
  38309. (WebCore::ImageDecoder::repetitionCount):
  38310. (WebCore::ImageDecoder::supportsAlpha):
  38311. (WebCore::ImageDecoder::failed):
  38312. (WebCore::ImageDecoder::setFailed):
  38313. (WebCore::ImageDecoder::clearFrameBufferCache):
  38314. (WebCore::ImageDecoder::setSize):
  38315. (WebCore::ImageDecoder::isOverSize):
  38316. * platform/image-decoders/skia/JPEGImageDecoder.cpp:
  38317. (WebCore::JPEGImageReader::JPEGImageReader):
  38318. (WebCore::JPEGImageReader::decode):
  38319. (WebCore::JPEGImageDecoder::isSizeAvailable):
  38320. (WebCore::JPEGImageDecoder::outputScanlines):
  38321. * platform/image-decoders/skia/JPEGImageDecoder.h:
  38322. (WebCore::JPEGImageDecoder::filenameExtension):
  38323. (WebCore::JPEGImageDecoder::supportsAlpha):
  38324. (WebCore::JPEGImageDecoder::reader):
  38325. * platform/image-decoders/skia/PNGImageDecoder.cpp:
  38326. (WebCore::PNGImageReader::close):
  38327. (WebCore::PNGImageDecoder::PNGImageDecoder):
  38328. (WebCore::PNGImageDecoder::isSizeAvailable):
  38329. (WebCore::PNGImageDecoder::frameBufferAtIndex):
  38330. (WebCore::PNGImageDecoder::decode):
  38331. (WebCore::PNGImageDecoder::decodingFailed):
  38332. (WebCore::PNGImageDecoder::headerAvailable):
  38333. (WebCore::rowAvailable):
  38334. (WebCore::PNGImageDecoder::rowAvailable):
  38335. (WebCore::PNGImageDecoder::pngComplete):
  38336. * platform/image-decoders/skia/PNGImageDecoder.h:
  38337. (WebCore::PNGImageDecoder::filenameExtension):
  38338. (WebCore::PNGImageDecoder::reader):
  38339. * platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
  38340. * platform/image-decoders/skia/XBMImageDecoder.h: Added.
  38341. 2009-01-23 Darin Fisher <darin@chromium.org>
  38342. Reviewed by Eric Seidel.
  38343. https://bugs.webkit.org/show_bug.cgi?id=23506
  38344. Copy existing ImageDecoder.h in preparation for landing Skia changes on top.
  38345. * platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.
  38346. 2009-01-23 Darin Fisher <darin@chromium.org>
  38347. Reviewed by Eric Seidel.
  38348. https://bugs.webkit.org/show_bug.cgi?id=23506
  38349. Copy existing image-decoders in preparation for landing Skia changes on top.
  38350. * platform/image-decoders/skia: Added.
  38351. * platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
  38352. * platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
  38353. * platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
  38354. * platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
  38355. * platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
  38356. * platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
  38357. * platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
  38358. * platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.
  38359. 2009-01-23 Holger Freyther <zecke@selfish.org>
  38360. Unreviewed build fix.
  38361. Based on https://bugs.webkit.org/show_bug.cgi?id=23498
  38362. from craig.schlenter@gmail.com
  38363. * platform/gtk/RenderThemeGtk.cpp:
  38364. (WebCore::RenderThemeGtk::baselinePosition):
  38365. 2009-01-23 David Levin <levin@chromium.org>
  38366. Reviewed by Alexey Proskuryakov.
  38367. Bug 22720: Make XMLHttpRequest work in Workers
  38368. <https://bugs.webkit.org/show_bug.cgi?id=22720>
  38369. Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
  38370. data to be passed across threads.
  38371. No observable change in behavior, so no test.
  38372. * platform/network/FormData.cpp:
  38373. (WebCore::FormData::deepCopy):
  38374. * platform/network/FormData.h:
  38375. * platform/network/HTTPHeaderMap.cpp:
  38376. (WebCore::HTTPHeaderMap::copyData):
  38377. (WebCore::HTTPHeaderMap::adopt):
  38378. * platform/network/HTTPHeaderMap.h:
  38379. * platform/network/ResourceRequestBase.cpp:
  38380. (WebCore::ResourceRequestBase::adopt):
  38381. (WebCore::ResourceRequestBase::copyData):
  38382. * platform/network/ResourceRequestBase.h:
  38383. * platform/network/ResourceResponseBase.cpp:
  38384. (WebCore::ResourceResponseBase::adopt):
  38385. (WebCore::ResourceResponseBase::copyData):
  38386. * platform/network/ResourceResponseBase.h:
  38387. 2009-01-23 Dmitry Titov <dimich@chromium.org>
  38388. Reviewed by Alexey Proskuryakov.
  38389. https://bugs.webkit.org/show_bug.cgi?id=23374
  38390. Add WorkerRunLoop to encapsulate message queue and timer heap.
  38391. This is first half (timer heap is added as separate patch).
  38392. * GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
  38393. * WebCore.vcproj/WebCore.vcproj: Same as above.
  38394. * WebCore.xcodeproj/project.pbxproj: Same as above
  38395. * dom/WorkerContext.cpp:
  38396. (WebCore::WorkerContext::postTask):
  38397. * dom/WorkerContext.h:
  38398. * dom/WorkerMessagingProxy.cpp:
  38399. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
  38400. (WebCore::WorkerMessagingProxy::workerThreadCreated):
  38401. * dom/WorkerRunLoop.cpp: Added.
  38402. (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
  38403. (WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
  38404. (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
  38405. * dom/WorkerRunLoop.h: Added.
  38406. (WebCore::WorkerRunLoop::WorkerRunLoop):
  38407. * dom/WorkerThread.cpp:
  38408. (WebCore::WorkerThread::workerThread):
  38409. (WebCore::WorkerThread::stop):
  38410. * dom/WorkerThread.h:
  38411. (WebCore::WorkerThread::runLoop):
  38412. 2009-01-23 Adam Treat <adam.treat@torchmobile.com>
  38413. Reviewed by Holger Hans Peter Freyther.
  38414. Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a
  38415. huge memory leak by ensuring that the timer is fired one last time on
  38416. application tear down thus triggering the GCController thereby freeing
  38417. JavaScript objects as well as triggering other timer based tear down methods.
  38418. * platform/qt/SharedTimerQt.cpp:
  38419. (WebCore::SharedTimerQt::~SharedTimerQt):
  38420. 2009-01-23 Alexey Proskuryakov <ap@webkit.org>
  38421. Reviewed by Oliver Hunt.
  38422. https://bugs.webkit.org/show_bug.cgi?id=23459
  38423. Workers are not properly terminated if execution hasn't begun yet
  38424. Doesn't affect observable behavior, so test case is not possible.
  38425. * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
  38426. it couldn't be called earlier.
  38427. 2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
  38428. [Qt] Fix the build after RenderBox refactoring in r40153.
  38429. * platform/qt/RenderThemeQt.cpp:
  38430. (WebCore::RenderThemeQt::baselinePosition):
  38431. 2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
  38432. Rubber-stamped by Alexey Proskuryakov.
  38433. Fix the build after RenderBox refactoring in r40153.
  38434. * plugins/PluginView.cpp:
  38435. (WebCore::PluginView::invalidateWindowlessPluginRect):
  38436. 2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
  38437. Reviewed by Simon Hausmann.
  38438. [Qt] Simplify the assertion.
  38439. * platform/graphics/qt/GraphicsContextQt.cpp:
  38440. (WebCore::GraphicsContext::getWindowsContext):
  38441. (WebCore::GraphicsContext::releaseWindowsContext):
  38442. 2009-01-22 David Hyatt <hyatt@apple.com>
  38443. Move the border and padding methods from RenderObject to RenderBox.
  38444. Reviewed by Oliver Hunt
  38445. * css/CSSComputedStyleDeclaration.cpp:
  38446. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  38447. * editing/DeleteButtonController.cpp:
  38448. (WebCore::DeleteButtonController::createDeletionUI):
  38449. * page/EventHandler.cpp:
  38450. (WebCore::EventHandler::hitTestResultAtPoint):
  38451. * rendering/InlineFlowBox.cpp:
  38452. (WebCore::InlineFlowBox::placeBoxesVertically):
  38453. * rendering/InlineFlowBox.h:
  38454. (WebCore::InlineFlowBox::borderLeft):
  38455. (WebCore::InlineFlowBox::borderRight):
  38456. (WebCore::InlineFlowBox::paddingLeft):
  38457. (WebCore::InlineFlowBox::paddingRight):
  38458. * rendering/RenderBlock.cpp:
  38459. (WebCore::RenderBlock::clearFloats):
  38460. * rendering/RenderBox.cpp:
  38461. (WebCore::RenderBox::paddingTop):
  38462. (WebCore::RenderBox::paddingBottom):
  38463. (WebCore::RenderBox::paddingLeft):
  38464. (WebCore::RenderBox::paddingRight):
  38465. (WebCore::RenderBox::calcHeight):
  38466. (WebCore::RenderBox::containingBlockWidthForPositioned):
  38467. (WebCore::RenderBox::containingBlockHeightForPositioned):
  38468. (WebCore::RenderBox::calcAbsoluteHorizontal):
  38469. (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  38470. (WebCore::RenderBox::calcAbsoluteVertical):
  38471. (WebCore::RenderBox::calcAbsoluteVerticalValues):
  38472. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  38473. (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  38474. * rendering/RenderBox.h:
  38475. (WebCore::RenderBox::borderTop):
  38476. (WebCore::RenderBox::borderBottom):
  38477. (WebCore::RenderBox::borderLeft):
  38478. (WebCore::RenderBox::borderRight):
  38479. * rendering/RenderObject.cpp:
  38480. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  38481. * rendering/RenderObject.h:
  38482. * rendering/RenderTextControl.cpp:
  38483. (WebCore::RenderTextControl::textBlockWidth):
  38484. (WebCore::RenderTextControl::calcHeight):
  38485. (WebCore::RenderTextControl::calcPrefWidths):
  38486. * rendering/RenderTextControlSingleLine.cpp:
  38487. (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  38488. * rendering/RenderTreeAsText.cpp:
  38489. (WebCore::operator<<):
  38490. * rendering/RenderView.cpp:
  38491. (WebCore::RenderView::repaintViewRectangle):
  38492. 2009-01-22 David Hyatt <hyatt@apple.com>
  38493. Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
  38494. other margin functions that have to come along for the ride).
  38495. Reviewed by Oliver Hunt
  38496. * css/CSSComputedStyleDeclaration.cpp:
  38497. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  38498. * editing/TextIterator.cpp:
  38499. (WebCore::shouldEmitExtraNewlineForNode):
  38500. * rendering/InlineBox.cpp:
  38501. * rendering/InlineBox.h:
  38502. (WebCore::InlineBox::renderBox):
  38503. * rendering/InlineFlowBox.cpp:
  38504. (WebCore::InlineFlowBox::marginLeft):
  38505. (WebCore::InlineFlowBox::marginRight):
  38506. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  38507. (WebCore::InlineFlowBox::computeLogicalBoxHeights):
  38508. (WebCore::InlineFlowBox::placeBoxesVertically):
  38509. (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  38510. * rendering/RenderBlock.cpp:
  38511. (WebCore::RenderBlock::isSelfCollapsingBlock):
  38512. (WebCore::RenderBlock::adjustPositionedBlock):
  38513. (WebCore::RenderBlock::handleCompactChild):
  38514. (WebCore::RenderBlock::estimateVerticalPosition):
  38515. (WebCore::getBorderPaddingMargin):
  38516. (WebCore::RenderBlock::calcInlinePrefWidths):
  38517. * rendering/RenderBlock.h:
  38518. * rendering/RenderBox.cpp:
  38519. (WebCore::RenderBox::calcHeight):
  38520. * rendering/RenderBox.h:
  38521. (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin):
  38522. (WebCore::RenderBox::hasHorizontalBordersOrPadding):
  38523. (WebCore::RenderBox::marginTop):
  38524. (WebCore::RenderBox::marginBottom):
  38525. (WebCore::RenderBox::marginLeft):
  38526. (WebCore::RenderBox::marginRight):
  38527. (WebCore::RenderBox::isSelfCollapsingBlock):
  38528. (WebCore::RenderBox::collapsedMarginTop):
  38529. (WebCore::RenderBox::collapsedMarginBottom):
  38530. (WebCore::RenderBox::isTopMarginQuirk):
  38531. (WebCore::RenderBox::isBottomMarginQuirk):
  38532. (WebCore::RenderBox::maxTopMargin):
  38533. (WebCore::RenderBox::maxBottomMargin):
  38534. * rendering/RenderObject.cpp:
  38535. (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
  38536. * rendering/RenderObject.h:
  38537. * rendering/RenderSVGContainer.cpp:
  38538. (WebCore::RenderSVGContainer::lineHeight):
  38539. (WebCore::RenderSVGContainer::baselinePosition):
  38540. * rendering/RenderTextControl.cpp:
  38541. (WebCore::RenderTextControl::calcHeight):
  38542. * rendering/RenderTheme.cpp:
  38543. (WebCore::RenderTheme::baselinePosition):
  38544. * rendering/bidi.cpp:
  38545. (WebCore::getBorderPaddingMargin):
  38546. (WebCore::inlineWidth):
  38547. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  38548. (WebCore::inlineFlowRequiresLineBox):
  38549. (WebCore::requiresLineBox):
  38550. (WebCore::RenderBlock::findNextLineBreak):
  38551. 2009-01-22 Mark Rowe <mrowe@apple.com>
  38552. Rubber-stamped by Anders Carlsson.
  38553. Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
  38554. Current versions of Xcode only respect it for C and Objective-C files,
  38555. and our code doesn't currently compile if it is applied to C++ and
  38556. Objective-C++ files.
  38557. * Configurations/Base.xcconfig:
  38558. 2009-01-22 David Hyatt <hyatt@apple.com>
  38559. Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits. Let intrinsicPaddingTop and
  38560. intrinsicPaddingBottom just be normal non-bitfield values.
  38561. Reviewed by Oliver Hunt
  38562. * rendering/RenderFlow.h:
  38563. (WebCore::RenderFlow::RenderFlow):
  38564. * rendering/RenderTableCell.cpp:
  38565. (WebCore::RenderTableCell::RenderTableCell):
  38566. (WebCore::RenderTableCell::updateWidth):
  38567. (WebCore::RenderTableCell::layout):
  38568. * rendering/RenderTableCell.h:
  38569. 2009-01-22 David Hyatt <hyatt@apple.com>
  38570. Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
  38571. Make m_frameRect private.
  38572. Reviewed by Oliver Hunt
  38573. * rendering/RenderBlock.cpp:
  38574. (WebCore::RenderBlock::paint):
  38575. (WebCore::RenderBlock::clearFloats):
  38576. * rendering/RenderBox.cpp:
  38577. (WebCore::RenderBox::offsetTop):
  38578. (WebCore::RenderBox::nodeAtPoint):
  38579. (WebCore::RenderBox::paint):
  38580. (WebCore::RenderBox::paintCustomHighlight):
  38581. (WebCore::RenderBox::containingBlockWidth):
  38582. (WebCore::RenderBox::localToAbsolute):
  38583. (WebCore::RenderBox::offsetFromContainer):
  38584. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  38585. (WebCore::RenderBox::repaintDuringLayoutIfMoved):
  38586. * rendering/RenderContainer.cpp:
  38587. (WebCore::RenderContainer::layout):
  38588. * rendering/RenderFlexibleBox.cpp:
  38589. (WebCore::RenderFlexibleBox::layoutBlock):
  38590. * rendering/RenderFrameSet.cpp:
  38591. (WebCore::RenderFrameSet::paint):
  38592. * rendering/RenderImage.cpp:
  38593. (WebCore::RenderImage::paintReplaced):
  38594. (WebCore::RenderImage::nodeAtPoint):
  38595. * rendering/RenderListMarker.cpp:
  38596. (WebCore::RenderListMarker::paint):
  38597. (WebCore::RenderListMarker::getRelativeMarkerRect):
  38598. * rendering/RenderReplaced.cpp:
  38599. (WebCore::RenderReplaced::paint):
  38600. (WebCore::RenderReplaced::shouldPaint):
  38601. * rendering/RenderReplica.cpp:
  38602. (WebCore::RenderReplica::paint):
  38603. * rendering/RenderSVGRoot.cpp:
  38604. (WebCore::RenderSVGRoot::applyContentTransforms):
  38605. (WebCore::RenderSVGRoot::paint):
  38606. (WebCore::RenderSVGRoot::absoluteTransform):
  38607. (WebCore::RenderSVGRoot::nodeAtPoint):
  38608. * rendering/RenderTable.cpp:
  38609. (WebCore::RenderTable::calcWidth):
  38610. (WebCore::RenderTable::layout):
  38611. * rendering/RenderTableCell.cpp:
  38612. (WebCore::RenderTableCell::paint):
  38613. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  38614. * rendering/RenderTableSection.cpp:
  38615. (WebCore::RenderTableSection::setCellWidths):
  38616. (WebCore::RenderTableSection::calcRowHeight):
  38617. (WebCore::RenderTableSection::layoutRows):
  38618. (WebCore::RenderTableSection::paint):
  38619. (WebCore::RenderTableSection::nodeAtPoint):
  38620. * rendering/RenderWidget.cpp:
  38621. (WebCore::RenderWidget::paint):
  38622. 2009-01-22 David Hyatt <hyatt@apple.com>
  38623. Fix for https://bugs.webkit.org/show_bug.cgi?id=23487.
  38624. This patch completely reworks vertical alignment of table cells. The current system uses methods called borderTopExtra() and borderBottomExtra() to
  38625. add extra space above and below the content of a cell. This system was not confined to the table code and spilled out into all the other RenderObjects.
  38626. The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra(). height()
  38627. also excluded the extra space, so did not accurately reflect the true size of the cell.
  38628. With the new system, the table cell box is completely accurate. The extra space becomes part of the padding of the cell. Padding has been reworked so that
  38629. additional intrinsic padding can be added on to the specified padding from style. Only the table code has to deal with the extra cell padding.
  38630. localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.
  38631. A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.
  38632. Reviewed by Oliver Hunt
  38633. * css/CSSComputedStyleDeclaration.cpp:
  38634. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  38635. Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding. This ensures that getComputedStyle continues
  38636. to give the right answer.
  38637. * dom/ContainerNode.cpp:
  38638. (WebCore::ContainerNode::getLowerRightCorner):
  38639. * editing/visible_units.cpp:
  38640. (WebCore::previousLinePosition):
  38641. (WebCore::nextLinePosition):
  38642. * rendering/LayoutState.cpp:
  38643. (WebCore::LayoutState::LayoutState):
  38644. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38645. * rendering/RenderBlock.cpp:
  38646. (WebCore::RenderBlock::overflowRect):
  38647. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38648. (WebCore::RenderBlock::layoutBlock):
  38649. (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
  38650. The expandsToEncloseOverhangingFloats logic has been reworked. Table cells and fieldsets did not properly handle floats that spilled into the bottom padding. The
  38651. resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float. The switch to make the extra table cell
  38652. space into padding exposed this issue. No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
  38653. this change.
  38654. (WebCore::RenderBlock::selectionGapRects):
  38655. (WebCore::RenderBlock::paintSelection):
  38656. (WebCore::RenderBlock::fillSelectionGaps):
  38657. (WebCore::RenderBlock::nodeAtPoint):
  38658. (WebCore::RenderBlock::positionForCoordinates):
  38659. (WebCore::RenderBlock::offsetForContents):
  38660. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38661. * rendering/RenderBlock.h:
  38662. Add the new simplified method for expanding to encompass overhanging floats. The method has been devirtualized and made to include all of the cases (and not just a subset).
  38663. * rendering/RenderBox.cpp:
  38664. (WebCore::RenderBox::absoluteRects):
  38665. (WebCore::RenderBox::absoluteQuads):
  38666. (WebCore::RenderBox::absoluteContentBox):
  38667. (WebCore::RenderBox::paintBoxDecorations):
  38668. (WebCore::RenderBox::paintMask):
  38669. (WebCore::RenderBox::getOverflowClipRect):
  38670. (WebCore::RenderBox::localToAbsolute):
  38671. (WebCore::RenderBox::absoluteToLocal):
  38672. (WebCore::RenderBox::localToAbsoluteQuad):
  38673. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38674. * rendering/RenderBox.h:
  38675. (WebCore::RenderBox::y):
  38676. (WebCore::RenderBox::location):
  38677. (WebCore::RenderBox::borderBoxRect):
  38678. (WebCore::RenderBox::offsetHeight):
  38679. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38680. * rendering/RenderContainer.cpp:
  38681. (WebCore::RenderContainer::addLineBoxRects):
  38682. * rendering/RenderFieldset.cpp:
  38683. (WebCore::RenderFieldset::paintBoxDecorations):
  38684. (WebCore::RenderFieldset::paintMask):
  38685. * rendering/RenderFieldset.h:
  38686. (WebCore::RenderFieldset::avoidsFloats):
  38687. * rendering/RenderFlow.cpp:
  38688. (WebCore::RenderFlow::localCaretRect):
  38689. * rendering/RenderLayer.cpp:
  38690. (WebCore::RenderLayer::updateLayerPosition):
  38691. (WebCore::RenderLayer::paintLayer):
  38692. (WebCore::RenderLayer::hitTestLayer):
  38693. (WebCore::RenderLayer::boundingBox):
  38694. * rendering/RenderListBox.cpp:
  38695. (WebCore::RenderListBox::isPointInOverflowControl):
  38696. * rendering/RenderObject.cpp:
  38697. (WebCore::RenderObject::localToAbsolute):
  38698. (WebCore::RenderObject::absoluteToLocal):
  38699. (WebCore::RenderObject::localToAbsoluteQuad):
  38700. (WebCore::RenderObject::offsetFromContainer):
  38701. (WebCore::RenderObject::paddingTop):
  38702. (WebCore::RenderObject::paddingBottom):
  38703. (WebCore::RenderObject::paddingLeft):
  38704. (WebCore::RenderObject::paddingRight):
  38705. * rendering/RenderObject.h:
  38706. (WebCore::RenderObject::hasOverhangingFloats):
  38707. * rendering/RenderReplaced.cpp:
  38708. (WebCore::RenderReplaced::selectionRect):
  38709. (WebCore::RenderReplaced::localSelectionRect):
  38710. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls. Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating
  38711. whether or not the intrinsic padding of an object should be included (by default it is). getComputedStyle needs to exclude it, which is why this argument is
  38712. necessary.
  38713. * rendering/RenderTableCell.cpp:
  38714. (WebCore::RenderTableCell::RenderTableCell):
  38715. (WebCore::RenderTableCell::paddingTop):
  38716. (WebCore::RenderTableCell::paddingBottom):
  38717. The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.
  38718. (WebCore::RenderTableCell::setOverrideSize):
  38719. When a table's override size gets altered, the intrinsic padding needs to be cleared.
  38720. (WebCore::RenderTableCell::absoluteClippedOverflowRect):
  38721. (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
  38722. (WebCore::RenderTableCell::baselinePosition):
  38723. (WebCore::RenderTableCell::paint):
  38724. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  38725. (WebCore::RenderTableCell::paintBoxDecorations):
  38726. (WebCore::RenderTableCell::paintMask):
  38727. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38728. * rendering/RenderTableCell.h:
  38729. (WebCore::RenderTableCell::setIntrinsicPaddingTop):
  38730. (WebCore::RenderTableCell::setIntrinsicPaddingBottom):
  38731. (WebCore::RenderTableCell::setIntrinsicPadding):
  38732. (WebCore::RenderTableCell::clearIntrinsicPadding):
  38733. (WebCore::RenderTableCell::intrinsicPaddingTop):
  38734. (WebCore::RenderTableCell::intrinsicPaddingBottom):
  38735. Add new helper methods for getting/setting a cell's intrinsic padding.
  38736. * rendering/RenderTableSection.cpp:
  38737. (WebCore::RenderTableSection::calcRowHeight):
  38738. calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing. Because a cell now includes that
  38739. extra space, it has to be subtracted out in this method.
  38740. (WebCore::RenderTableSection::layoutRows):
  38741. Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes. There was also an error where the baseline
  38742. position mismatched leading to negative intrinsic padding being added in (this error exists in ToT). The code now properly ignores cells that don't establish
  38743. a baseline. A number of tests progress with this change.
  38744. * rendering/RenderText.cpp:
  38745. (WebCore::RenderText::addLineBoxRects):
  38746. Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
  38747. * rendering/RenderTreeAsText.cpp:
  38748. (WebCore::operator<<):
  38749. (WebCore::writeTextRun):
  38750. Modify the render tree dumping code to continue to produce the same results as before. This is really a hack, since we're now capable of indicating the correct
  38751. position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is). A future patch can remove these hacks so that the
  38752. layout test results can all be regenerated.
  38753. 2009-01-22 Eric Seidel <eric@webkit.org>
  38754. Reviewed by Darin Adler.
  38755. Remove <strong>/<em> tags when toggling bold/italic since IE inserts them instead of <b>/<i>
  38756. https://bugs.webkit.org/show_bug.cgi?id=23486
  38757. Test: editing/execCommand/toggle-styles.html
  38758. * editing/ApplyStyleCommand.cpp:
  38759. (WebCore::ApplyStyleCommand::isHTMLStyleNode):
  38760. 2009-01-22 Eric Seidel <eric@webkit.org>
  38761. Reviewed by Justin Garcia.
  38762. Remove <span> turds left by editing commands
  38763. https://bugs.webkit.org/show_bug.cgi?id=23466
  38764. Tests:
  38765. * editing/execCommand/empty-span-removal.html
  38766. * editing/execCommand/toggle-styles.html
  38767. * editing/ApplyStyleCommand.cpp:
  38768. (WebCore::styleSpanClassString):
  38769. (WebCore::isStyleSpan):
  38770. (WebCore::isUnstyledStyleSpan):
  38771. (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
  38772. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  38773. (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
  38774. (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle):
  38775. (WebCore::ApplyStyleCommand::removeCSSStyle):
  38776. 2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  38777. Reviewed by Eric Seidel.
  38778. Rename some of the casting functions in dom/*Element.cpp:
  38779. formControlElementForElement -> toFormControlElement
  38780. inputElementForElement -> toInputElement
  38781. optionElementForElement -> toOptionElement
  38782. optionGroupElementForElement -> toOptionGroupElement
  38783. Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
  38784. The Element*->ScriptElement* helper function is already named 'toScriptElement'.
  38785. * dom/FormControlElement.cpp:
  38786. (WebCore::toFormControlElement):
  38787. * dom/FormControlElement.h:
  38788. * dom/InputElement.cpp:
  38789. (WebCore::InputElement::setValueFromRenderer):
  38790. (WebCore::toInputElement):
  38791. * dom/InputElement.h:
  38792. * dom/OptionElement.cpp:
  38793. (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
  38794. (WebCore::toOptionElement):
  38795. * dom/OptionElement.h:
  38796. * dom/OptionGroupElement.cpp:
  38797. (WebCore::toOptionGroupElement):
  38798. * dom/OptionGroupElement.h:
  38799. * rendering/RenderListBox.cpp:
  38800. (WebCore::RenderListBox::updateFromElement):
  38801. (WebCore::RenderListBox::paintItemForeground):
  38802. (WebCore::RenderListBox::paintItemBackground):
  38803. * rendering/RenderMenuList.cpp:
  38804. (WebCore::RenderMenuList::updateOptionsWidth):
  38805. (WebCore::RenderMenuList::setTextFromOption):
  38806. (WebCore::RenderMenuList::itemText):
  38807. (WebCore::RenderMenuList::itemIsSelected):
  38808. * rendering/RenderTextControl.cpp:
  38809. (WebCore::RenderTextControl::formControlElement):
  38810. * rendering/RenderTextControlSingleLine.cpp:
  38811. (WebCore::RenderTextControlSingleLine::inputElement):
  38812. 2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  38813. Rubber-stamped by George Staikos.
  38814. Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.
  38815. * dom/OptionElement.cpp:
  38816. (WebCore::optionElementForElement):
  38817. * dom/OptionGroupElement.cpp:
  38818. (WebCore::optionGroupElementForElement):
  38819. 2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  38820. Reviewed by George Staikos.
  38821. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454
  38822. Add WML <option>/<optgroup> element support.
  38823. Currently the implementation is stubbed, all relevant parts can be enabled
  38824. once WMLSelectElement/SelectElement has been created.
  38825. * GNUmakefile.am:
  38826. * WebCore.pro:
  38827. * WebCore.vcproj/WebCore.vcproj:
  38828. * WebCore.xcodeproj/project.pbxproj:
  38829. * wml/WMLOptGroupElement.cpp: Added.
  38830. (WebCore::WMLOptGroupElement::WMLOptGroupElement):
  38831. (WebCore::WMLOptGroupElement::~WMLOptGroupElement):
  38832. (WebCore::WMLOptGroupElement::insertBefore):
  38833. (WebCore::WMLOptGroupElement::replaceChild):
  38834. (WebCore::WMLOptGroupElement::removeChild):
  38835. (WebCore::WMLOptGroupElement::appendChild):
  38836. (WebCore::WMLOptGroupElement::removeChildren):
  38837. (WebCore::ownerSelectElement):
  38838. (WebCore::WMLOptGroupElement::accessKeyAction):
  38839. (WebCore::WMLOptGroupElement::childrenChanged):
  38840. (WebCore::WMLOptGroupElement::parseMappedAttribute):
  38841. (WebCore::WMLOptGroupElement::attach):
  38842. (WebCore::WMLOptGroupElement::detach):
  38843. (WebCore::WMLOptGroupElement::setRenderStyle):
  38844. (WebCore::WMLOptGroupElement::nonRendererRenderStyle):
  38845. (WebCore::WMLOptGroupElement::groupLabelText):
  38846. (WebCore::WMLOptGroupElement::recalcSelectOptions):
  38847. * wml/WMLOptGroupElement.h: Added.
  38848. (WebCore::WMLOptGroupElement::title):
  38849. (WebCore::WMLOptGroupElement::valueMatchesRenderer):
  38850. (WebCore::WMLOptGroupElement::setValueMatchesRenderer):
  38851. (WebCore::WMLOptGroupElement::rendererIsNeeded):
  38852. * wml/WMLOptionElement.cpp: Added.
  38853. (WebCore::WMLOptionElement::WMLOptionElement):
  38854. (WebCore::WMLOptionElement::~WMLOptionElement):
  38855. (WebCore::ownerSelectElement):
  38856. (WebCore::WMLOptionElement::accessKeyAction):
  38857. (WebCore::WMLOptionElement::childrenChanged):
  38858. (WebCore::WMLOptionElement::parseMappedAttribute):
  38859. (WebCore::WMLOptionElement::attach):
  38860. (WebCore::WMLOptionElement::detach):
  38861. (WebCore::WMLOptionElement::setRenderStyle):
  38862. (WebCore::WMLOptionElement::insertedIntoDocument):
  38863. (WebCore::WMLOptionElement::selected):
  38864. (WebCore::WMLOptionElement::setSelectedState):
  38865. (WebCore::WMLOptionElement::value):
  38866. (WebCore::WMLOptionElement::textIndentedToRespectGroupLabel):
  38867. (WebCore::WMLOptionElement::nonRendererRenderStyle):
  38868. (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
  38869. * wml/WMLOptionElement.h: Added.
  38870. (WebCore::WMLOptionElement::valueMatchesRenderer):
  38871. (WebCore::WMLOptionElement::setValueMatchesRenderer):
  38872. (WebCore::WMLOptionElement::rendererIsNeeded):
  38873. * wml/WMLTagNames.in:
  38874. 2009-01-22 Eric Roman <eroman@chromium.org>
  38875. Reviewed by Eric Seidel.
  38876. https://bugs.webkit.org/show_bug.cgi?id=20806
  38877. Send referrer for history navigations.
  38878. Test: http/tests/navigation/back-send-referrer.html
  38879. Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.
  38880. * history/HistoryItem.cpp:
  38881. (WebCore::HistoryItem::HistoryItem):
  38882. (WebCore::HistoryItem::referrer):
  38883. (WebCore::HistoryItem::setReferrer):
  38884. (WebCore::HistoryItem::formReferrer):
  38885. (WebCore::HistoryItem::rssFeedReferrer):
  38886. (WebCore::HistoryItem::setRSSFeedReferrer):
  38887. (WebCore::HistoryItem::setFormInfoFromRequest):
  38888. * history/HistoryItem.h:
  38889. * loader/FrameLoader.cpp:
  38890. (WebCore::FrameLoader::loadItem):
  38891. 2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  38892. Reviewed by Eric Seidel.
  38893. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465
  38894. Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.
  38895. Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
  38896. optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.
  38897. Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
  38898. These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
  38899. used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.
  38900. * dom/OptionElement.cpp:
  38901. (WebCore::OptionElement::setSelectedState):
  38902. (WebCore::OptionElement::collectOptionText):
  38903. (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
  38904. (WebCore::OptionElement::collectOptionValue):
  38905. (WebCore::OptionElementData::OptionElementData):
  38906. (WebCore::OptionElementData::~OptionElementData):
  38907. * dom/OptionElement.h:
  38908. (WebCore::OptionElementData::element):
  38909. (WebCore::OptionElementData::value):
  38910. (WebCore::OptionElementData::setValue):
  38911. (WebCore::OptionElementData::label):
  38912. (WebCore::OptionElementData::setLabel):
  38913. (WebCore::OptionElementData::selected):
  38914. (WebCore::OptionElementData::setSelected):
  38915. * html/HTMLOptionElement.cpp:
  38916. (WebCore::HTMLOptionElement::HTMLOptionElement):
  38917. (WebCore::HTMLOptionElement::text):
  38918. (WebCore::HTMLOptionElement::parseMappedAttribute):
  38919. (WebCore::HTMLOptionElement::value):
  38920. (WebCore::HTMLOptionElement::selected):
  38921. (WebCore::HTMLOptionElement::setSelected):
  38922. (WebCore::HTMLOptionElement::setSelectedState):
  38923. (WebCore::HTMLOptionElement::label):
  38924. (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
  38925. * html/HTMLOptionElement.h:
  38926. * html/HTMLSelectElement.cpp:
  38927. (WebCore::HTMLSelectElement::typeAheadFind):
  38928. * rendering/RenderListBox.cpp:
  38929. (WebCore::RenderListBox::updateFromElement):
  38930. (WebCore::RenderListBox::paintItemForeground):
  38931. * rendering/RenderMenuList.cpp:
  38932. (WebCore::RenderMenuList::updateOptionsWidth):
  38933. (WebCore::RenderMenuList::setTextFromOption):
  38934. (WebCore::RenderMenuList::itemText):
  38935. 2009-01-22 Chris Fleizach <cfleizach@apple.com>
  38936. Reviewed by Justin Garcia.
  38937. Bug 23464: Infinite recursion at SelectionController::setSelection
  38938. https://bugs.webkit.org/show_bug.cgi?id=23464
  38939. Check for conditions leading to infinite recursion.
  38940. * editing/SelectionController.cpp:
  38941. (WebCore::SelectionController::setSelection):
  38942. 2009-01-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  38943. Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
  38944. * rendering/RenderBox.cpp:
  38945. 2009-01-22 Adam Treat <adam.treat@torchmobile.com>
  38946. Fix the Qt build after RenderBox changes.
  38947. * platform/qt/RenderThemeQt.cpp:
  38948. (WebCore::RenderThemeQt::baselinePosition):
  38949. 2009-01-22 David Hyatt <hyatt@apple.com>
  38950. Fix regressions in list box selection on Mac. The wrong color was being used for the list box
  38951. background, and list box colors actually weren't even being properly fetched because of a bug in
  38952. the RenderTheme base class. Existing pixel tests cover the bug fix.
  38953. Reviewed by Jon Honeycutt
  38954. * rendering/RenderTheme.cpp:
  38955. (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
  38956. (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
  38957. (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
  38958. (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
  38959. * rendering/RenderThemeMac.mm:
  38960. (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
  38961. 2009-01-22 David Levin <levin@chromium.org>
  38962. Reviewed by Alexey Proskuryakov.
  38963. Bug 22720: Make XMLHttpRequest work in Workers
  38964. <https://bugs.webkit.org/show_bug.cgi?id=22720>
  38965. Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.
  38966. No observable change in behavior, so no test.
  38967. * GNUmakefile.am:
  38968. * WebCore.pro:
  38969. * WebCore.scons:
  38970. * WebCore.vcproj/WebCore.vcproj:
  38971. * WebCore.xcodeproj/project.pbxproj:
  38972. * WebCoreSources.bkl:
  38973. * platform/network/HTTPHeaderMap.cpp: Added.
  38974. (WebCore::HTTPHeaderMap::copyData):
  38975. (WebCore::HTTPHeaderMap::adopt):
  38976. * platform/network/HTTPHeaderMap.h:
  38977. 2009-01-21 David Hyatt <hyatt@apple.com>
  38978. Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
  38979. was before my landing. Fixes failing SVG focus ring tests.
  38980. * rendering/RenderObject.cpp:
  38981. (WebCore::RenderObject::paintOutline):
  38982. * rendering/RenderObject.h:
  38983. * rendering/RenderPath.cpp:
  38984. (WebCore::RenderPath::paint):
  38985. * rendering/RenderSVGContainer.cpp:
  38986. (WebCore::RenderSVGContainer::paint):
  38987. 2009-01-21 David Hyatt <hyatt@apple.com>
  38988. Fix Node's renderBox() method on Windows.
  38989. * dom/Node.cpp:
  38990. (WebCore::Node::renderBox):
  38991. 2009-01-21 David Hyatt <hyatt@apple.com>
  38992. Fix RenderThemeSafari bustage on Win32.
  38993. * rendering/RenderThemeSafari.cpp:
  38994. (WebCore::RenderThemeSafari::baselinePosition):
  38995. 2009-01-21 David Hyatt <hyatt@apple.com>
  38996. Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
  38997. but that's a problem for another day.
  38998. * rendering/RenderThemeWin.cpp:
  38999. (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
  39000. (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
  39001. (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
  39002. 2009-01-21 Oliver Hunt <oliver@apple.com>
  39003. Reviewed by Dave Hyatt.
  39004. Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
  39005. <https://bugs.webkit.org/show_bug.cgi?id=23470>
  39006. Add a RefPtr protector to handleWheelEvent to guard against destruction
  39007. while processing the scroll event. Alas the absurd set of circumstances
  39008. required to trigger this do not appear to be reproducible in DRT.
  39009. * page/EventHandler.cpp:
  39010. (WebCore::EventHandler::handleWheelEvent):
  39011. 2009-01-21 David Hyatt <hyatt@apple.com>
  39012. Fix for https://bugs.webkit.org/show_bug.cgi?id=23453
  39013. Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
  39014. Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.
  39015. Reviewed by Eric Seidel and Darin Adler
  39016. * WebCore.base.exp:
  39017. * css/CSSComputedStyleDeclaration.cpp:
  39018. (WebCore::sizingBox):
  39019. * dom/ContainerNode.cpp:
  39020. (WebCore::ContainerNode::getUpperLeftCorner):
  39021. (WebCore::ContainerNode::getLowerRightCorner):
  39022. * dom/Element.cpp:
  39023. (WebCore::Element::offsetLeft):
  39024. (WebCore::Element::offsetTop):
  39025. (WebCore::Element::offsetWidth):
  39026. (WebCore::Element::offsetHeight):
  39027. (WebCore::Element::offsetParent):
  39028. (WebCore::Element::clientLeft):
  39029. (WebCore::Element::clientTop):
  39030. (WebCore::Element::clientWidth):
  39031. (WebCore::Element::clientHeight):
  39032. (WebCore::Element::scrollLeft):
  39033. (WebCore::Element::scrollTop):
  39034. (WebCore::Element::setScrollLeft):
  39035. (WebCore::Element::setScrollTop):
  39036. (WebCore::Element::scrollWidth):
  39037. (WebCore::Element::scrollHeight):
  39038. * dom/Node.cpp:
  39039. (WebCore::Node::renderBox):
  39040. (WebCore::Node::getRect):
  39041. * dom/Node.h:
  39042. * dom/Position.cpp:
  39043. (WebCore::endsOfNodeAreVisuallyDistinctPositions):
  39044. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
  39045. (WebCore::Position::isCandidate):
  39046. * dom/PositionIterator.cpp:
  39047. (WebCore::PositionIterator::isCandidate):
  39048. * editing/CompositeEditCommand.cpp:
  39049. (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  39050. * editing/DeleteButtonController.cpp:
  39051. (WebCore::isDeletableElement):
  39052. * editing/DeleteSelectionCommand.cpp:
  39053. (WebCore::DeleteSelectionCommand::removeNode):
  39054. * editing/Editor.cpp:
  39055. (WebCore::Editor::insideVisibleArea):
  39056. * editing/EditorCommand.cpp:
  39057. (WebCore::verticalScrollDistance):
  39058. * html/HTMLAnchorElement.cpp:
  39059. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  39060. * html/HTMLCanvasElement.cpp:
  39061. (WebCore::HTMLCanvasElement::willDraw):
  39062. * html/HTMLFormControlElement.cpp:
  39063. (WebCore::HTMLFormControlElement::isFocusable):
  39064. * html/HTMLFrameElementBase.cpp:
  39065. (WebCore::HTMLFrameElementBase::width):
  39066. (WebCore::HTMLFrameElementBase::height):
  39067. * html/HTMLImageElement.cpp:
  39068. (WebCore::HTMLImageElement::width):
  39069. (WebCore::HTMLImageElement::height):
  39070. * inspector/InspectorController.cpp:
  39071. (WebCore::InspectorController::drawNodeHighlight):
  39072. * page/AccessibilityRenderObject.cpp:
  39073. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  39074. * page/FrameView.cpp:
  39075. (WebCore::FrameView::createScrollbar):
  39076. (WebCore::FrameView::updateDashboardRegions):
  39077. * page/animation/AnimationBase.cpp:
  39078. (WebCore::blendFunc):
  39079. * rendering/HitTestResult.cpp:
  39080. (WebCore::HitTestResult::imageRect):
  39081. * rendering/InlineBox.cpp:
  39082. (WebCore::InlineBox::renderBox):
  39083. (WebCore::InlineBox::adjustPosition):
  39084. * rendering/InlineBox.h:
  39085. * rendering/InlineFlowBox.cpp:
  39086. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  39087. (WebCore::InlineFlowBox::verticallyAlignBoxes):
  39088. (WebCore::InlineFlowBox::placeBoxesVertically):
  39089. * rendering/InlineFlowBox.h:
  39090. * rendering/RenderApplet.cpp:
  39091. (WebCore::RenderApplet::createWidgetIfNecessary):
  39092. * rendering/RenderBlock.cpp:
  39093. (WebCore::RenderBlock::overflowHeight):
  39094. (WebCore::RenderBlock::overflowWidth):
  39095. (WebCore::RenderBlock::overflowRect):
  39096. (WebCore::RenderBlock::isSelfCollapsingBlock):
  39097. (WebCore::RenderBlock::layout):
  39098. (WebCore::RenderBlock::layoutBlock):
  39099. (WebCore::RenderBlock::adjustPositionedBlock):
  39100. (WebCore::RenderBlock::adjustFloatingBlock):
  39101. (WebCore::RenderBlock::handleSpecialChild):
  39102. (WebCore::RenderBlock::handlePositionedChild):
  39103. (WebCore::RenderBlock::handleFloatingChild):
  39104. (WebCore::RenderBlock::handleCompactChild):
  39105. (WebCore::RenderBlock::insertCompactIfNeeded):
  39106. (WebCore::RenderBlock::handleRunInChild):
  39107. (WebCore::RenderBlock::collapseMargins):
  39108. (WebCore::RenderBlock::clearFloatsIfNeeded):
  39109. (WebCore::RenderBlock::estimateVerticalPosition):
  39110. (WebCore::RenderBlock::determineHorizontalPosition):
  39111. (WebCore::RenderBlock::handleBottomOfBlock):
  39112. (WebCore::RenderBlock::layoutBlockChildren):
  39113. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  39114. (WebCore::RenderBlock::layoutPositionedObjects):
  39115. (WebCore::RenderBlock::markPositionedObjectsForLayout):
  39116. (WebCore::RenderBlock::repaintOverhangingFloats):
  39117. (WebCore::RenderBlock::paint):
  39118. (WebCore::RenderBlock::paintChildren):
  39119. (WebCore::RenderBlock::paintObject):
  39120. (WebCore::RenderBlock::paintFloats):
  39121. (WebCore::RenderBlock::paintContinuationOutlines):
  39122. (WebCore::clipOutPositionedObjects):
  39123. (WebCore::RenderBlock::fillSelectionGaps):
  39124. (WebCore::RenderBlock::fillBlockSelectionGaps):
  39125. (WebCore::RenderBlock::leftSelectionOffset):
  39126. (WebCore::RenderBlock::rightSelectionOffset):
  39127. (WebCore::RenderBlock::insertPositionedObject):
  39128. (WebCore::RenderBlock::removePositionedObject):
  39129. (WebCore::RenderBlock::removePositionedObjects):
  39130. (WebCore::RenderBlock::insertFloatingObject):
  39131. (WebCore::RenderBlock::removeFloatingObject):
  39132. (WebCore::RenderBlock::positionNewFloats):
  39133. (WebCore::RenderBlock::newLine):
  39134. (WebCore::RenderBlock::lowestPosition):
  39135. (WebCore::RenderBlock::rightmostPosition):
  39136. (WebCore::RenderBlock::leftmostPosition):
  39137. (WebCore::RenderBlock::clearFloats):
  39138. (WebCore::RenderBlock::addOverhangingFloats):
  39139. (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  39140. (WebCore::RenderBlock::getClearDelta):
  39141. (WebCore::RenderBlock::nodeAtPoint):
  39142. (WebCore::RenderBlock::positionForCoordinates):
  39143. (WebCore::RenderBlock::layoutColumns):
  39144. (WebCore::RenderBlock::getBaselineOfFirstLineBox):
  39145. (WebCore::RenderBlock::getBaselineOfLastLineBox):
  39146. (WebCore::getHeightForLineCount):
  39147. (WebCore::RenderBlock::adjustForBorderFit):
  39148. * rendering/RenderBlock.h:
  39149. (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
  39150. (WebCore::RenderBlock::hasOverhangingFloats):
  39151. (WebCore::RenderBlock::CompactInfo::compact):
  39152. (WebCore::RenderBlock::CompactInfo::set):
  39153. * rendering/RenderBox.cpp:
  39154. (WebCore::RenderBox::RenderBox):
  39155. (WebCore::RenderBox::offsetLeft):
  39156. (WebCore::RenderBox::offsetTop):
  39157. (WebCore::RenderBox::offsetParent):
  39158. (WebCore::RenderBox::clientWidth):
  39159. (WebCore::RenderBox::clientHeight):
  39160. (WebCore::RenderBox::scrollWidth):
  39161. (WebCore::RenderBox::scrollHeight):
  39162. (WebCore::RenderBox::scrollLeft):
  39163. (WebCore::RenderBox::scrollTop):
  39164. (WebCore::RenderBox::setScrollLeft):
  39165. (WebCore::RenderBox::setScrollTop):
  39166. (WebCore::RenderBox::absoluteRects):
  39167. (WebCore::RenderBox::absoluteQuads):
  39168. (WebCore::RenderBox::absoluteContentBox):
  39169. (WebCore::RenderBox::absoluteContentQuad):
  39170. (WebCore::RenderBox::absoluteOutlineBounds):
  39171. (WebCore::RenderBox::addFocusRingRects):
  39172. (WebCore::RenderBox::reflectionBox):
  39173. (WebCore::RenderBox::reflectionOffset):
  39174. (WebCore::RenderBox::reflectedRect):
  39175. (WebCore::RenderBox::overrideWidth):
  39176. (WebCore::RenderBox::overrideHeight):
  39177. (WebCore::RenderBox::nodeAtPoint):
  39178. (WebCore::RenderBox::paint):
  39179. (WebCore::RenderBox::maskClipRect):
  39180. (WebCore::RenderBox::repaintLayerRectsForImage):
  39181. (WebCore::RenderBox::paintCustomHighlight):
  39182. (WebCore::RenderBox::getOverflowClipRect):
  39183. (WebCore::RenderBox::getClipRect):
  39184. (WebCore::RenderBox::containingBlockWidth):
  39185. (WebCore::RenderBox::localToAbsolute):
  39186. (WebCore::RenderBox::offsetFromContainer):
  39187. (WebCore::RenderBox::position):
  39188. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  39189. (WebCore::RenderBox::repaintDuringLayoutIfMoved):
  39190. (WebCore::RenderBox::calcWidth):
  39191. (WebCore::RenderBox::calcWidthUsing):
  39192. (WebCore::RenderBox::calcHorizontalMargins):
  39193. (WebCore::RenderBox::calcHeight):
  39194. (WebCore::RenderBox::calcPercentageHeight):
  39195. (WebCore::RenderBox::calcReplacedHeightUsing):
  39196. (WebCore::RenderBox::containingBlockWidthForPositioned):
  39197. (WebCore::RenderBox::containingBlockHeightForPositioned):
  39198. (WebCore::RenderBox::calcAbsoluteHorizontal):
  39199. (WebCore::RenderBox::calcAbsoluteVertical):
  39200. (WebCore::RenderBox::calcAbsoluteVerticalValues):
  39201. (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  39202. (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  39203. (WebCore::RenderBox::localCaretRect):
  39204. (WebCore::RenderBox::lowestPosition):
  39205. (WebCore::RenderBox::rightmostPosition):
  39206. (WebCore::RenderBox::leftmostPosition):
  39207. (WebCore::RenderBox::localTransform):
  39208. * rendering/RenderBox.h:
  39209. (WebCore::):
  39210. (WebCore::RenderBox::x):
  39211. (WebCore::RenderBox::y):
  39212. (WebCore::RenderBox::width):
  39213. (WebCore::RenderBox::height):
  39214. (WebCore::RenderBox::setX):
  39215. (WebCore::RenderBox::setY):
  39216. (WebCore::RenderBox::setWidth):
  39217. (WebCore::RenderBox::setHeight):
  39218. (WebCore::RenderBox::location):
  39219. (WebCore::RenderBox::size):
  39220. (WebCore::RenderBox::setLocation):
  39221. (WebCore::RenderBox::setSize):
  39222. (WebCore::RenderBox::move):
  39223. (WebCore::RenderBox::frameRect):
  39224. (WebCore::RenderBox::setFrameRect):
  39225. (WebCore::RenderBox::borderBoxRect):
  39226. (WebCore::RenderBox::contentBoxRect):
  39227. (WebCore::RenderBox::previousSiblingBox):
  39228. (WebCore::RenderBox::nextSiblingBox):
  39229. (WebCore::RenderBox::parentBox):
  39230. (WebCore::RenderBox::overflowHeight):
  39231. (WebCore::RenderBox::overflowWidth):
  39232. (WebCore::RenderBox::setOverflowHeight):
  39233. (WebCore::RenderBox::setOverflowWidth):
  39234. (WebCore::RenderBox::overflowLeft):
  39235. (WebCore::RenderBox::overflowTop):
  39236. (WebCore::RenderBox::overflowRect):
  39237. (WebCore::RenderBox::contentWidth):
  39238. (WebCore::RenderBox::contentHeight):
  39239. (WebCore::RenderBox::offsetWidth):
  39240. (WebCore::RenderBox::offsetHeight):
  39241. (WebCore::RenderBox::clientLeft):
  39242. (WebCore::RenderBox::clientTop):
  39243. (WebCore::RenderBox::availableWidth):
  39244. (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
  39245. * rendering/RenderButton.cpp:
  39246. (WebCore::RenderButton::controlClipRect):
  39247. * rendering/RenderContainer.cpp:
  39248. (WebCore::RenderContainer::layout):
  39249. (WebCore::RenderContainer::positionForCoordinates):
  39250. * rendering/RenderContainer.h:
  39251. (WebCore::RenderContainer::firstChildBox):
  39252. (WebCore::RenderContainer::lastChildBox):
  39253. * rendering/RenderFieldset.cpp:
  39254. (WebCore::RenderFieldset::calcPrefWidths):
  39255. (WebCore::RenderFieldset::layoutLegend):
  39256. (WebCore::RenderFieldset::findLegend):
  39257. (WebCore::RenderFieldset::paintBoxDecorations):
  39258. (WebCore::RenderFieldset::paintMask):
  39259. * rendering/RenderFieldset.h:
  39260. * rendering/RenderFileUploadControl.cpp:
  39261. (WebCore::RenderFileUploadControl::maxFilenameWidth):
  39262. (WebCore::RenderFileUploadControl::paintObject):
  39263. * rendering/RenderFlexibleBox.cpp:
  39264. (WebCore::FlexBoxIterator::FlexBoxIterator):
  39265. (WebCore::FlexBoxIterator::first):
  39266. (WebCore::FlexBoxIterator::next):
  39267. (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
  39268. (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
  39269. (WebCore::RenderFlexibleBox::layoutBlock):
  39270. (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  39271. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  39272. (WebCore::RenderFlexibleBox::placeChild):
  39273. (WebCore::RenderFlexibleBox::allowedChildFlex):
  39274. * rendering/RenderFlexibleBox.h:
  39275. * rendering/RenderFlow.cpp:
  39276. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  39277. (WebCore::RenderFlow::lowestPosition):
  39278. (WebCore::RenderFlow::rightmostPosition):
  39279. (WebCore::RenderFlow::leftmostPosition):
  39280. (WebCore::RenderFlow::localCaretRect):
  39281. (WebCore::RenderFlow::addFocusRingRects):
  39282. * rendering/RenderFrameSet.cpp:
  39283. (WebCore::RenderFrameSet::paint):
  39284. (WebCore::RenderFrameSet::layout):
  39285. (WebCore::RenderFrameSet::positionFrames):
  39286. * rendering/RenderHTMLCanvas.cpp:
  39287. (WebCore::RenderHTMLCanvas::paintReplaced):
  39288. (WebCore::RenderHTMLCanvas::canvasSizeChanged):
  39289. * rendering/RenderImage.cpp:
  39290. (WebCore::RenderImage::imageChanged):
  39291. (WebCore::RenderImage::paintReplaced):
  39292. (WebCore::RenderImage::nodeAtPoint):
  39293. (WebCore::RenderImage::calcReplacedWidth):
  39294. * rendering/RenderInline.cpp:
  39295. (WebCore::RenderInline::absoluteRects):
  39296. (WebCore::RenderInline::boundingBoxWidth):
  39297. (WebCore::RenderInline::boundingBoxHeight):
  39298. (WebCore::RenderInline::positionForCoordinates):
  39299. * rendering/RenderInline.h:
  39300. (WebCore::RenderInline::offsetWidth):
  39301. (WebCore::RenderInline::offsetHeight):
  39302. * rendering/RenderLayer.cpp:
  39303. (WebCore::RenderLayer::updateTransform):
  39304. (WebCore::RenderLayer::updateLayerPosition):
  39305. (WebCore::RenderLayer::scrollbarCornerPresent):
  39306. (WebCore::RenderLayer::createScrollbar):
  39307. (WebCore::RenderLayer::positionOverflowControls):
  39308. (WebCore::RenderLayer::paintScrollCorner):
  39309. (WebCore::RenderLayer::paintResizer):
  39310. (WebCore::RenderLayer::paintLayer):
  39311. (WebCore::RenderLayer::hitTestLayer):
  39312. (WebCore::RenderLayer::calculateRects):
  39313. (WebCore::RenderLayer::boundingBox):
  39314. * rendering/RenderListBox.cpp:
  39315. (WebCore::RenderListBox::calcHeight):
  39316. (WebCore::RenderListBox::controlClipRect):
  39317. * rendering/RenderListItem.cpp:
  39318. (WebCore::RenderListItem::positionListMarker):
  39319. (WebCore::RenderListItem::paint):
  39320. * rendering/RenderListMarker.cpp:
  39321. (WebCore::RenderListMarker::paint):
  39322. (WebCore::RenderListMarker::layout):
  39323. (WebCore::RenderListMarker::imageChanged):
  39324. (WebCore::RenderListMarker::getRelativeMarkerRect):
  39325. (WebCore::RenderListMarker::selectionRect):
  39326. * rendering/RenderMarquee.cpp:
  39327. (WebCore::RenderMarquee::computePosition):
  39328. * rendering/RenderMedia.cpp:
  39329. (WebCore::RenderMedia::layout):
  39330. (WebCore::RenderMedia::lowestPosition):
  39331. (WebCore::RenderMedia::rightmostPosition):
  39332. (WebCore::RenderMedia::leftmostPosition):
  39333. * rendering/RenderMenuList.cpp:
  39334. (WebCore::RenderMenuList::controlClipRect):
  39335. * rendering/RenderObject.cpp:
  39336. (WebCore::RenderObject::RenderObject):
  39337. (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout):
  39338. (WebCore::RenderObject::paintOutline):
  39339. (WebCore::RenderObject::addLineBoxRects):
  39340. (WebCore::RenderObject::absoluteBoundingBoxRect):
  39341. (WebCore::RenderObject::addAbsoluteRectForLayer):
  39342. (WebCore::RenderObject::paintingRootRect):
  39343. (WebCore::RenderObject::container):
  39344. (WebCore::RenderObject::removeFromObjectLists):
  39345. (WebCore::RenderObject::updateHitTestResult):
  39346. (WebCore::RenderObject::addDashboardRegions):
  39347. (WebCore::RenderObject::localTransform):
  39348. * rendering/RenderObject.h:
  39349. (WebCore::RenderObject::isBox):
  39350. (WebCore::RenderObject::hasMask):
  39351. (WebCore::RenderObject::setIsText):
  39352. (WebCore::RenderObject::setIsBox):
  39353. (WebCore::RenderObject::borderTop):
  39354. (WebCore::RenderObject::borderBottom):
  39355. (WebCore::RenderObject::absoluteRects):
  39356. (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
  39357. (WebCore::RenderObject::absoluteQuads):
  39358. (WebCore::RenderObject::hasReflection):
  39359. (WebCore::RenderObject::addFocusRingRects):
  39360. (WebCore::RenderObject::absoluteOutlineBounds):
  39361. * rendering/RenderPart.cpp:
  39362. (WebCore::RenderPart::updateWidgetPosition):
  39363. * rendering/RenderPath.cpp:
  39364. (WebCore::RenderPath::layout):
  39365. (WebCore::RenderPath::paint):
  39366. (WebCore::RenderPath::absoluteOutlineBounds):
  39367. * rendering/RenderPath.h:
  39368. * rendering/RenderReplaced.cpp:
  39369. (WebCore::RenderReplaced::layout):
  39370. (WebCore::RenderReplaced::paint):
  39371. (WebCore::RenderReplaced::shouldPaint):
  39372. (WebCore::RenderReplaced::positionForCoordinates):
  39373. (WebCore::RenderReplaced::localSelectionRect):
  39374. (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
  39375. (WebCore::RenderReplaced::overflowRect):
  39376. * rendering/RenderReplica.cpp:
  39377. (WebCore::RenderReplica::layout):
  39378. (WebCore::RenderReplica::calcPrefWidths):
  39379. (WebCore::RenderReplica::paint):
  39380. * rendering/RenderSVGContainer.cpp:
  39381. (WebCore::RenderSVGContainer::paint):
  39382. (WebCore::RenderSVGContainer::absoluteOutlineBounds):
  39383. * rendering/RenderSVGContainer.h:
  39384. (WebCore::RenderSVGContainer::width):
  39385. (WebCore::RenderSVGContainer::height):
  39386. * rendering/RenderSVGImage.cpp:
  39387. (WebCore::RenderSVGImage::layout):
  39388. * rendering/RenderSVGInlineText.cpp:
  39389. (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
  39390. (WebCore::RenderSVGInlineText::positionForCoordinates):
  39391. * rendering/RenderSVGRoot.cpp:
  39392. (WebCore::RenderSVGRoot::layout):
  39393. (WebCore::RenderSVGRoot::applyContentTransforms):
  39394. (WebCore::RenderSVGRoot::paint):
  39395. (WebCore::RenderSVGRoot::absoluteTransform):
  39396. (WebCore::RenderSVGRoot::nodeAtPoint):
  39397. * rendering/RenderSVGTSpan.cpp:
  39398. (WebCore::RenderSVGTSpan::absoluteRects):
  39399. (WebCore::RenderSVGTSpan::absoluteQuads):
  39400. * rendering/RenderSVGText.cpp:
  39401. (WebCore::RenderSVGText::layout):
  39402. (WebCore::RenderSVGText::relativeBBox):
  39403. * rendering/RenderSVGTextPath.cpp:
  39404. (WebCore::RenderSVGTextPath::absoluteRects):
  39405. (WebCore::RenderSVGTextPath::absoluteQuads):
  39406. * rendering/RenderSVGViewportContainer.cpp:
  39407. (WebCore::RenderSVGViewportContainer::nodeAtPoint):
  39408. * rendering/RenderScrollbar.cpp:
  39409. (WebCore::RenderScrollbar::createCustomScrollbar):
  39410. (WebCore::RenderScrollbar::RenderScrollbar):
  39411. (WebCore::RenderScrollbar::setParent):
  39412. * rendering/RenderScrollbar.h:
  39413. (WebCore::RenderScrollbar::owningRenderer):
  39414. * rendering/RenderScrollbarPart.cpp:
  39415. (WebCore::RenderScrollbarPart::layout):
  39416. (WebCore::RenderScrollbarPart::layoutHorizontalPart):
  39417. (WebCore::RenderScrollbarPart::layoutVerticalPart):
  39418. (WebCore::RenderScrollbarPart::computeScrollbarWidth):
  39419. (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  39420. (WebCore::RenderScrollbarPart::paintIntoRect):
  39421. * rendering/RenderSlider.cpp:
  39422. (WebCore::HTMLSliderThumbElement::defaultEventHandler):
  39423. (WebCore::RenderSlider::layout):
  39424. (WebCore::RenderSlider::mouseEventIsInThumb):
  39425. (WebCore::RenderSlider::positionForOffset):
  39426. (WebCore::RenderSlider::trackSize):
  39427. * rendering/RenderTable.cpp:
  39428. (WebCore::RenderTable::calcWidth):
  39429. (WebCore::RenderTable::layout):
  39430. (WebCore::RenderTable::paint):
  39431. (WebCore::RenderTable::getBaselineOfFirstLineBox):
  39432. * rendering/RenderTableCell.cpp:
  39433. (WebCore::RenderTableCell::updateWidth):
  39434. (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
  39435. (WebCore::RenderTableCell::localToAbsolute):
  39436. (WebCore::RenderTableCell::absoluteToLocal):
  39437. (WebCore::RenderTableCell::localToAbsoluteQuad):
  39438. (WebCore::RenderTableCell::paint):
  39439. (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  39440. * rendering/RenderTableCell.h:
  39441. * rendering/RenderTableSection.cpp:
  39442. (WebCore::RenderTableSection::addChild):
  39443. (WebCore::RenderTableSection::addCell):
  39444. (WebCore::RenderTableSection::setCellWidths):
  39445. (WebCore::RenderTableSection::calcRowHeight):
  39446. (WebCore::RenderTableSection::layoutRows):
  39447. (WebCore::RenderTableSection::lowestPosition):
  39448. (WebCore::RenderTableSection::rightmostPosition):
  39449. (WebCore::RenderTableSection::leftmostPosition):
  39450. (WebCore::RenderTableSection::getBaselineOfFirstLineBox):
  39451. (WebCore::RenderTableSection::paint):
  39452. (WebCore::RenderTableSection::recalcCells):
  39453. (WebCore::RenderTableSection::nodeAtPoint):
  39454. * rendering/RenderTableSection.h:
  39455. (WebCore::RenderTableSection::overflowWidth):
  39456. (WebCore::RenderTableSection::overflowHeight):
  39457. * rendering/RenderText.cpp:
  39458. (WebCore::RenderText::RenderText):
  39459. (WebCore::RenderText::boundingBoxX):
  39460. (WebCore::RenderText::boundingBoxY):
  39461. (WebCore::RenderText::firstRunX):
  39462. (WebCore::RenderText::firstRunY):
  39463. (WebCore::RenderText::boundingBoxHeight):
  39464. (WebCore::RenderText::boundingBoxWidth):
  39465. * rendering/RenderText.h:
  39466. * rendering/RenderTextControl.cpp:
  39467. (WebCore::RenderTextControl::textBlockHeight):
  39468. (WebCore::RenderTextControl::textBlockWidth):
  39469. (WebCore::RenderTextControl::setSelectionRange):
  39470. (WebCore::RenderTextControl::calcHeight):
  39471. (WebCore::RenderTextControl::hitInnerTextBlock):
  39472. (WebCore::RenderTextControl::controlClipRect):
  39473. * rendering/RenderTextControlMultiLine.cpp:
  39474. (WebCore::RenderTextControlMultiLine::layout):
  39475. (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
  39476. * rendering/RenderTextControlSingleLine.cpp:
  39477. (WebCore::RenderTextControlSingleLine::paint):
  39478. (WebCore::RenderTextControlSingleLine::layout):
  39479. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  39480. (WebCore::RenderTextControlSingleLine::forwardEvent):
  39481. (WebCore::RenderTextControlSingleLine::textBlockWidth):
  39482. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  39483. (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
  39484. (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  39485. * rendering/RenderTheme.cpp:
  39486. (WebCore::RenderTheme::hitTestMediaControlPart):
  39487. (WebCore::RenderTheme::baselinePosition):
  39488. * rendering/RenderThemeMac.mm:
  39489. (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
  39490. (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
  39491. (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
  39492. (WebCore::RenderThemeMac::hitTestMediaControlPart):
  39493. * rendering/RenderTreeAsText.cpp:
  39494. (WebCore::operator<<):
  39495. * rendering/RenderVideo.cpp:
  39496. (WebCore::RenderVideo::videoBox):
  39497. * rendering/RenderView.cpp:
  39498. (WebCore::RenderView::RenderView):
  39499. (WebCore::RenderView::calcHeight):
  39500. (WebCore::RenderView::calcWidth):
  39501. (WebCore::RenderView::layout):
  39502. (WebCore::RenderView::viewRect):
  39503. (WebCore::RenderView::docHeight):
  39504. (WebCore::RenderView::docWidth):
  39505. (WebCore::RenderView::setBestTruncatedAt):
  39506. * rendering/RenderView.h:
  39507. * rendering/RenderWidget.cpp:
  39508. (WebCore::RenderWidget::paint):
  39509. (WebCore::RenderWidget::updateWidgetPosition):
  39510. (WebCore::RenderWidget::nodeAtPoint):
  39511. * rendering/RootInlineBox.h:
  39512. (WebCore::RootInlineBox::floats):
  39513. (WebCore::RootInlineBox::floatsPtr):
  39514. * rendering/SVGInlineFlowBox.cpp:
  39515. (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
  39516. * rendering/SVGInlineFlowBox.h:
  39517. * rendering/SVGRenderTreeAsText.cpp:
  39518. (WebCore::operator<<):
  39519. (WebCore::write):
  39520. * rendering/SVGRootInlineBox.cpp:
  39521. (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
  39522. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
  39523. (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  39524. * rendering/SVGRootInlineBox.h:
  39525. * rendering/bidi.cpp:
  39526. (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  39527. (WebCore::RenderBlock::computeVerticalPositionsForLine):
  39528. (WebCore::RenderBlock::layoutInlineChildren):
  39529. (WebCore::RenderBlock::determineStartPosition):
  39530. (WebCore::RenderBlock::matchedEndLine):
  39531. (WebCore::RenderBlock::skipTrailingWhitespace):
  39532. (WebCore::RenderBlock::skipLeadingWhitespace):
  39533. (WebCore::RenderBlock::fitBelowFloats):
  39534. (WebCore::RenderBlock::findNextLineBreak):
  39535. (WebCore::RenderBlock::checkLinesForOverflow):
  39536. * svg/SVGLength.cpp:
  39537. (WebCore::SVGLength::PercentageOfViewport):
  39538. 2009-01-21 Anders Carlsson <andersca@apple.com>
  39539. Reviewed by Sam Weinig.
  39540. * WebCore.LP64.exp:
  39541. Add some bridge related symbols.
  39542. * WebCore.xcodeproj/project.pbxproj:
  39543. Make runtime_object.h a private header.
  39544. 2009-01-20 David Levin <levin@chromium.org>
  39545. Reviewed by Alexey Proskuryakov.
  39546. Bug 22720: Make XMLHttpRequest work in Workers
  39547. <https://bugs.webkit.org/show_bug.cgi?id=22720>
  39548. More removal of document usage from XMLHttpRequest.
  39549. * Abstracted away the sync and async requests behind the ThreadableLoader class, which
  39550. will get an implementation for Workers. ThreadableLoader follows the same model as
  39551. SubresourceLoader because DocumentThreadableLoader is a thin wrapper around SubresourceLoader.
  39552. Also, WorkerThreadableLoader (coming soon) will use DocumentThreadableLoader to get things done.
  39553. * Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode
  39554. which handles workers.
  39555. No observable change in behavior, so no test.
  39556. * GNUmakefile.am:
  39557. * WebCore.pro:
  39558. * WebCore.scons:
  39559. * WebCore.vcproj/WebCore.vcproj:
  39560. * WebCore.xcodeproj/project.pbxproj:
  39561. * WebCoreSources.bkl:
  39562. * loader/DocumentThreadableLoader.cpp: Added.
  39563. (WebCore::DocumentThreadableLoader::create):
  39564. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
  39565. (WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
  39566. (WebCore::DocumentThreadableLoader::cancel):
  39567. (WebCore::DocumentThreadableLoader::willSendRequest):
  39568. (WebCore::DocumentThreadableLoader::didSendData):
  39569. (WebCore::DocumentThreadableLoader::didReceiveResponse):
  39570. (WebCore::DocumentThreadableLoader::didReceiveData):
  39571. (WebCore::DocumentThreadableLoader::didFinishLoading):
  39572. (WebCore::DocumentThreadableLoader::didFail):
  39573. (WebCore::DocumentThreadableLoader::receivedCancellation):
  39574. * loader/DocumentThreadableLoader.h: Added.
  39575. (WebCore::DocumentThreadableLoader::refThreadableLoader):
  39576. (WebCore::DocumentThreadableLoader::derefThreadableLoader):
  39577. * loader/SubresourceLoaderClient.h:
  39578. (WebCore::SubresourceLoaderClient::didReceiveData):
  39579. * loader/ThreadableLoader.cpp: Added.
  39580. (WebCore::ThreadableLoader::create):
  39581. (WebCore::ThreadableLoader::loadResourceSynchronously):
  39582. * loader/ThreadableLoader.h: Added.
  39583. (WebCore::):
  39584. (WebCore::ThreadableLoader::ref):
  39585. (WebCore::ThreadableLoader::deref):
  39586. (WebCore::ThreadableLoader::~ThreadableLoader):
  39587. * loader/ThreadableLoaderClient.h: Added.
  39588. (WebCore::ThreadableLoaderClient::didSendData):
  39589. (WebCore::ThreadableLoaderClient::didReceiveResponse):
  39590. (WebCore::ThreadableLoaderClient::didReceiveData):
  39591. (WebCore::ThreadableLoaderClient::didFinishLoading):
  39592. (WebCore::ThreadableLoaderClient::didFail):
  39593. (WebCore::ThreadableLoaderClient::didGetCancelled):
  39594. (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
  39595. (WebCore::ThreadableLoaderClient::~ThreadableLoaderClient):
  39596. * xml/XMLHttpRequest.cpp:
  39597. (WebCore::XMLHttpRequest::XMLHttpRequest):
  39598. (WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode):
  39599. (WebCore::XMLHttpRequest::send):
  39600. (WebCore::XMLHttpRequest::loadRequestSynchronously):
  39601. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  39602. (WebCore::XMLHttpRequest::setRequestHeader):
  39603. (WebCore::XMLHttpRequest::processSyncLoadResults):
  39604. (WebCore::XMLHttpRequest::didFail):
  39605. (WebCore::XMLHttpRequest::didGetCancelled):
  39606. (WebCore::XMLHttpRequest::didFinishLoading):
  39607. (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
  39608. (WebCore::XMLHttpRequest::didSendData):
  39609. (WebCore::XMLHttpRequest::didReceiveResponse):
  39610. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  39611. (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
  39612. (WebCore::XMLHttpRequest::didReceiveData):
  39613. * xml/XMLHttpRequest.h:
  39614. 2009-01-19 Chris Marrin <cmarrin@apple.com>
  39615. Reviewed by David Hyatt.
  39616. Fix for https://bugs.webkit.org/show_bug.cgi?id=23317
  39617. The high CPU usage was really from repeatedly firing transitions caused
  39618. by a bug in the way we handle background-color animations. If animating
  39619. from a valid background color to no background color, we sometimes left
  39620. (based on timing) the background color as transparent black, but valid
  39621. rather than invalid, which it should be. Fixing that got rid of the
  39622. repeated firing.
  39623. But we really were doing more expensive iteration of all objects with
  39624. animations or transitions on them (running or not). So I added two
  39625. optimizations to quickly short circuit when an object had no running
  39626. animations or transitions. Things are now as zippy as ever.
  39627. Test: transitions/repeated-firing-background-color.html
  39628. * page/animation/AnimationBase.cpp:
  39629. (WebCore::blendFunc):
  39630. * page/animation/AnimationController.cpp:
  39631. (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  39632. * page/animation/CompositeAnimation.cpp:
  39633. (WebCore::CompositeAnimationPrivate::hasAnimations):
  39634. (WebCore::CompositeAnimationPrivate::clearRenderer):
  39635. (WebCore::CompositeAnimationPrivate::animate):
  39636. (WebCore::CompositeAnimationPrivate::setAnimating):
  39637. (WebCore::CompositeAnimationPrivate::willNeedService):
  39638. (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
  39639. (WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
  39640. (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
  39641. (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
  39642. (WebCore::CompositeAnimationPrivate::suspendAnimations):
  39643. (WebCore::CompositeAnimationPrivate::resumeAnimations):
  39644. (WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
  39645. (WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
  39646. (WebCore::CompositeAnimationPrivate::styleAvailable):
  39647. (WebCore::CompositeAnimationPrivate::isAnimatingProperty):
  39648. (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
  39649. (WebCore::CompositeAnimation::hasAnimations):
  39650. * page/animation/CompositeAnimation.h:
  39651. 2009-01-21 Eric Seidel <eric@webkit.org>
  39652. Reviewed by Justin Garcia.
  39653. Remove the style='' turds left by some editing commands
  39654. https://bugs.webkit.org/show_bug.cgi?id=23463
  39655. Test: editing/execCommand/toggle-styles.html
  39656. * editing/ApplyStyleCommand.cpp:
  39657. (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
  39658. * editing/CompositeEditCommand.cpp:
  39659. (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;
  39660. 2009-01-21 Eric Seidel <eric@webkit.org>
  39661. No review, build fix.
  39662. Fix release-only build failure (and do a tiny code-cleanup).
  39663. * editing/ApplyStyleCommand.cpp:
  39664. (WebCore::createFontElement):
  39665. (WebCore::createStyleSpanElement):
  39666. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  39667. 2009-01-21 Chris Fleizach <cfleizach@apple.com>
  39668. Reviewed by Beth Dakin.
  39669. Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility()
  39670. https://bugs.webkit.org/show_bug.cgi?id=23443
  39671. Test: accessibility/table-modification-crash.html
  39672. * page/AccessibilityObject.cpp:
  39673. (WebCore::AccessibilityObject::updateBackingStore):
  39674. * page/AccessibilityObject.h:
  39675. * page/AccessibilityRenderObject.cpp:
  39676. (WebCore::AccessibilityRenderObject::childrenChanged):
  39677. (WebCore::AccessibilityRenderObject::children):
  39678. (WebCore::AccessibilityRenderObject::updateBackingStore):
  39679. * page/AccessibilityRenderObject.h:
  39680. (WebCore::AccessibilityRenderObject::markChildrenDirty):
  39681. * page/AccessibilityTable.cpp:
  39682. (WebCore::AccessibilityTable::AccessibilityTable):
  39683. * page/mac/AccessibilityObjectWrapper.mm:
  39684. (-[AccessibilityObjectWrapper accessibilityActionNames]):
  39685. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  39686. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  39687. (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
  39688. (-[AccessibilityObjectWrapper accessibilityHitTest:]):
  39689. (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
  39690. (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
  39691. (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
  39692. (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
  39693. (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
  39694. (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
  39695. (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
  39696. (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
  39697. (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
  39698. (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
  39699. * rendering/RenderObject.cpp:
  39700. (WebCore::RenderObject::destroy):
  39701. * rendering/RenderWidget.cpp:
  39702. (WebCore::RenderWidget::destroy):
  39703. 2009-01-16 Eric Seidel <eric@webkit.org>
  39704. Reviewed by Justin Garcia.
  39705. Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
  39706. https://bugs.webkit.org/show_bug.cgi?id=17733
  39707. Test changed: editing/execCommand/toggle-styles-expected.txt
  39708. * editing/ApplyStyleCommand.cpp:
  39709. (WebCore::StyleChange::applySubscript):
  39710. (WebCore::StyleChange::applySuperscript):
  39711. (WebCore::StyleChange::StyleChange):
  39712. (WebCore::StyleChange::init):
  39713. (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
  39714. (WebCore::ApplyStyleCommand::isHTMLStyleNode):
  39715. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  39716. * editing/EditorCommand.cpp:
  39717. (WebCore::executeSubscript):
  39718. (WebCore::executeSuperscript):
  39719. * editing/htmlediting.cpp:
  39720. (WebCore::createHTMLElement):
  39721. * editing/htmlediting.h:
  39722. 2009-01-21 Anders Carlsson <andersca@apple.com>
  39723. Fix 64-bit build.
  39724. * WebCore.LP64.exp:
  39725. 2009-01-21 Oliver Hunt <oliver@apple.com>
  39726. Reviewed by Alexey Proskuryakov.
  39727. Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
  39728. <https://bugs.webkit.org/show_bug.cgi?id=23458>
  39729. Return CanvasPixelArray, et al -- the only difference between this
  39730. and the original CPA implementation is that it now uses a ByteArray
  39731. rather than a vector. JSC still uses a custom wrapper, but this allows
  39732. ObjC, COM, and V8 bindings to be autogenerated again.
  39733. * GNUmakefile.am:
  39734. * WebCore.pro:
  39735. * WebCore.vcproj/WebCore.vcproj:
  39736. * WebCore.xcodeproj/project.pbxproj:
  39737. * WebCoreSources.bkl:
  39738. * bindings/js/JSImageDataCustom.cpp:
  39739. (WebCore::toJS):
  39740. * html/CanvasPixelArray.cpp: Added.
  39741. (WebCore::CanvasPixelArray::create):
  39742. (WebCore::CanvasPixelArray::CanvasPixelArray):
  39743. * html/CanvasPixelArray.h: Added.
  39744. (WebCore::CanvasPixelArray::data):
  39745. (WebCore::CanvasPixelArray::length):
  39746. (WebCore::CanvasPixelArray::set):
  39747. (WebCore::CanvasPixelArray::get):
  39748. * html/CanvasPixelArray.idl: Added.
  39749. * html/CanvasRenderingContext2D.cpp:
  39750. (WebCore::createEmptyImageData):
  39751. * html/ImageData.cpp:
  39752. (WebCore::ImageData::ImageData):
  39753. * html/ImageData.h:
  39754. (WebCore::ImageData::data):
  39755. * html/ImageData.idl:
  39756. * platform/graphics/cairo/ImageBufferCairo.cpp:
  39757. (WebCore::ImageBuffer::getImageData):
  39758. (WebCore::ImageBuffer::putImageData):
  39759. * platform/graphics/cg/ImageBufferCG.cpp:
  39760. (WebCore::ImageBuffer::getImageData):
  39761. (WebCore::ImageBuffer::putImageData):
  39762. 2009-01-21 Dirk Schulze <krit@webkit.org>
  39763. Reviewed by Nikolas Zimmermann.
  39764. Remove last relics of platform dependent PaintServer in SVG.
  39765. We draw everything with the help of GraphicsContext.
  39766. Remove SVGPaintServerPlatform's
  39767. [https://bugs.webkit.org/show_bug.cgi?id=23439]
  39768. * GNUmakefile.am:
  39769. * WebCore.pro:
  39770. * WebCore.vcproj/WebCore.vcproj:
  39771. * WebCore.xcodeproj/project.pbxproj:
  39772. * svg/graphics/SVGPaintServer.cpp:
  39773. (WebCore::SVGPaintServer::draw):
  39774. (WebCore::SVGPaintServer::renderPath):
  39775. (WebCore::SVGPaintServer::teardown):
  39776. * svg/graphics/SVGPaintServer.h:
  39777. * svg/graphics/SVGPaintServerGradient.cpp:
  39778. * svg/graphics/SVGPaintServerGradient.h:
  39779. * svg/graphics/SVGPaintServerPattern.cpp:
  39780. * svg/graphics/SVGPaintServerPattern.h:
  39781. * svg/graphics/SVGPaintServerSolid.cpp:
  39782. * svg/graphics/SVGPaintServerSolid.h:
  39783. * svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
  39784. * svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
  39785. * svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
  39786. * svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.
  39787. 2009-01-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  39788. Reviewed by Alexey Proskuryakov.
  39789. Move "Element -> ScriptElement" casting functionality into ScriptElement.h
  39790. to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.
  39791. It was living in XMLTokenizer before, which is not an obvious place for this.
  39792. TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
  39793. as suggested by Alexey, it really reads better this way.
  39794. * dom/ScriptElement.cpp:
  39795. (WebCore::toScriptElement):
  39796. * dom/ScriptElement.h:
  39797. * dom/XMLTokenizer.cpp:
  39798. (WebCore::XMLTokenizer::notifyFinished):
  39799. * dom/XMLTokenizer.h:
  39800. * dom/XMLTokenizerLibxml2.cpp:
  39801. (WebCore::XMLTokenizer::startElementNs):
  39802. (WebCore::XMLTokenizer::endElementNs):
  39803. * dom/XMLTokenizerQt.cpp:
  39804. (WebCore::XMLTokenizer::parseStartElement):
  39805. (WebCore::XMLTokenizer::parseEndElement):
  39806. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  39807. Reviewed by George Staikos.
  39808. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444
  39809. Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
  39810. in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
  39811. has been done before for FormControlElement and RenderTextControl.
  39812. This is needed to prepare the addtion of WMLOption/OptGroupElement.
  39813. * GNUmakefile.am:
  39814. * WebCore.pro:
  39815. * WebCore.scons:
  39816. * WebCore.vcproj/WebCore.vcproj:
  39817. * WebCore.xcodeproj/project.pbxproj:
  39818. * WebCoreSources.bkl:
  39819. * dom/OptionElement.cpp: Added.
  39820. (WebCore::optionElementForElement):
  39821. * dom/OptionElement.h: Added.
  39822. (WebCore::OptionElement::~OptionElement):
  39823. (WebCore::OptionElement::OptionElement):
  39824. * dom/OptionGroupElement.cpp: Added.
  39825. (WebCore::optionGroupElementForElement):
  39826. * dom/OptionGroupElement.h: Added.
  39827. (WebCore::OptionGroupElement::~OptionGroupElement):
  39828. (WebCore::OptionGroupElement::OptionGroupElement):
  39829. * html/HTMLOptGroupElement.h:
  39830. * html/HTMLOptionElement.cpp:
  39831. (WebCore::HTMLOptionElement::optionText):
  39832. * html/HTMLOptionElement.h:
  39833. (WebCore::HTMLOptionElement::selected):
  39834. * rendering/RenderListBox.cpp:
  39835. (WebCore::RenderListBox::updateFromElement):
  39836. (WebCore::RenderListBox::paintItemForeground):
  39837. (WebCore::RenderListBox::paintItemBackground):
  39838. * rendering/RenderMenuList.cpp:
  39839. (WebCore::RenderMenuList::updateOptionsWidth):
  39840. (WebCore::RenderMenuList::setTextFromOption):
  39841. (WebCore::RenderMenuList::itemText):
  39842. (WebCore::RenderMenuList::itemIsSelected):
  39843. 2009-01-20 Darin Adler <darin@apple.com>
  39844. Reviewed by Alexey Proskuryakov.
  39845. Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
  39846. https://bugs.webkit.org/show_bug.cgi?id=23448
  39847. * platform/graphics/cg/ImageSourceCGMac.mm:
  39848. (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.
  39849. 2009-01-20 Darin Adler <darin@apple.com>
  39850. Try to fix Wx build.
  39851. * platform/wx/PasteboardWx.cpp:
  39852. (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash
  39853. with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing
  39854. to the clipboard. Other platforms don't do it. If it was needed, the new function
  39855. to use would be displayStringModifiedByEncoding.
  39856. 2009-01-19 Brent Fulgham <bfulgham@gmail.com>
  39857. Reviewed by Mitz Pettel.
  39858. Fixes https://bugs.webkit.org/show_bug.cgi?id=23423.
  39859. The Windows Cairo post-build targets (Release/Debug) do not
  39860. copy all of the headers that the CG-based build does.
  39861. * WebCore.vcproj/WebCore.vcproj: Extend WebCore Cairo build targets
  39862. to copy the page/animation/*.h files into WebKitBuild so that
  39863. WebKit can find them.
  39864. 2009-01-20 Dmitry Titov <dimich@chromium.org>
  39865. Reviewed by Alexey Proskuryakov.
  39866. https://bugs.webkit.org/show_bug.cgi?id=23413
  39867. Remove unused WebCore::setDeferringTimers()
  39868. * platform/Timer.cpp:
  39869. (WebCore::updateSharedTimer):
  39870. * platform/Timer.h:
  39871. 2009-01-20 David Hyatt <hyatt@apple.com>
  39872. Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox. Rename m_object to
  39873. m_renderer to be consistent with the corresponding member function.
  39874. Reviewed by Jon Honeycutt
  39875. * rendering/RenderLayer.cpp:
  39876. (WebCore::RenderLayer::RenderLayer):
  39877. (WebCore::RenderLayer::updateLayerPositions):
  39878. (WebCore::RenderLayer::updateVisibilityStatus):
  39879. (WebCore::RenderLayer::updateLayerPosition):
  39880. (WebCore::RenderLayer::stackingContext):
  39881. (WebCore::RenderLayer::enclosingPositionedAncestor):
  39882. (WebCore::RenderLayer::enclosingTransformedAncestor):
  39883. (WebCore::RenderLayer::isTransparent):
  39884. (WebCore::RenderLayer::convertToLayerCoords):
  39885. (WebCore::RenderLayer::scrollByRecursively):
  39886. (WebCore::RenderLayer::scrollToOffset):
  39887. (WebCore::RenderLayer::scrollRectToVisible):
  39888. (WebCore::RenderLayer::resize):
  39889. (WebCore::RenderLayer::scrollbarCornerPresent):
  39890. (WebCore::RenderLayer::createScrollbar):
  39891. (WebCore::RenderLayer::setHasHorizontalScrollbar):
  39892. (WebCore::RenderLayer::setHasVerticalScrollbar):
  39893. (WebCore::RenderLayer::positionOverflowControls):
  39894. (WebCore::RenderLayer::computeScrollDimensions):
  39895. (WebCore::RenderLayer::updateOverflowStatus):
  39896. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  39897. (WebCore::RenderLayer::paintOverflowControls):
  39898. (WebCore::RenderLayer::paintScrollCorner):
  39899. (WebCore::RenderLayer::paintResizer):
  39900. (WebCore::RenderLayer::isPointInResizeControl):
  39901. (WebCore::RenderLayer::paintLayer):
  39902. (WebCore::RenderLayer::hitTestLayer):
  39903. (WebCore::RenderLayer::updateClipRects):
  39904. (WebCore::RenderLayer::calculateClipRects):
  39905. (WebCore::RenderLayer::calculateRects):
  39906. (WebCore::RenderLayer::clearClipRects):
  39907. (WebCore::RenderLayer::repaintIncludingDescendants):
  39908. (WebCore::RenderLayer::styleChanged):
  39909. (WebCore::RenderLayer::updateScrollCornerStyle):
  39910. (WebCore::RenderLayer::updateResizerStyle):
  39911. * rendering/RenderLayer.h:
  39912. (WebCore::RenderLayer::renderer):
  39913. (WebCore::RenderLayer::hasReflection):
  39914. (WebCore::RenderLayer::hasTransform):
  39915. 2009-01-20 David Hyatt <hyatt@apple.com>
  39916. Fix Mac build bustage from my selection changes. I forgot to implement the functions on RenderThemeMac
  39917. for returning the appropriate listbox selection colors.
  39918. Reviewed by Adele
  39919. * rendering/RenderThemeMac.mm:
  39920. (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
  39921. (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
  39922. (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
  39923. 2009-01-20 Dave Hyatt <hyatt@apple.com>
  39924. Fix for focus rings on Windows. Make sure that focus rings draw for all controls but buttons.
  39925. Fix list box selection colors on Windows. Also add a cache for all of the selection colors (and not just the two
  39926. background selection colors).
  39927. Reviewed by Adam Roben
  39928. * rendering/RenderObject.cpp:
  39929. (WebCore::RenderObject::selectionForegroundColor):
  39930. * rendering/RenderTheme.cpp:
  39931. (WebCore::RenderTheme::activeSelectionBackgroundColor):
  39932. (WebCore::RenderTheme::inactiveSelectionBackgroundColor):
  39933. (WebCore::RenderTheme::activeSelectionForegroundColor):
  39934. (WebCore::RenderTheme::inactiveSelectionForegroundColor):
  39935. (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
  39936. (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
  39937. (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
  39938. (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
  39939. (WebCore::RenderTheme::platformActiveSelectionForegroundColor):
  39940. (WebCore::RenderTheme::platformInactiveSelectionBackgroundColor):
  39941. (WebCore::RenderTheme::platformInactiveSelectionForegroundColor):
  39942. (WebCore::RenderTheme::platformActiveListBoxSelectionBackgroundColor):
  39943. (WebCore::RenderTheme::platformActiveListBoxSelectionForegroundColor):
  39944. (WebCore::RenderTheme::platformInactiveListBoxSelectionBackgroundColor):
  39945. (WebCore::RenderTheme::platformInactiveListBoxSelectionForegroundColor):
  39946. (WebCore::RenderTheme::platformColorsDidChange):
  39947. * rendering/RenderTheme.h:
  39948. (WebCore::RenderTheme::supportsForegroundSelectionColors):
  39949. (WebCore::RenderTheme::supportsForegroundListBoxSelectionColors):
  39950. * rendering/RenderThemeMac.h:
  39951. (WebCore::RenderThemeMac::supportsForegroundSelectionColors):
  39952. * rendering/RenderThemeMac.mm:
  39953. (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
  39954. * rendering/RenderThemeWin.cpp:
  39955. (WebCore::RenderThemeWin::platformInactiveSelectionBackgroundColor):
  39956. (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor):
  39957. (WebCore::RenderThemeWin::supportsFocus):
  39958. (WebCore::RenderThemeWin::supportsFocusRing):
  39959. * rendering/RenderThemeWin.h:
  39960. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  39961. Reviewed by George Staikos.
  39962. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434
  39963. Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
  39964. Now any language can provide <input>-style elements, without having to inherit from HTML* classes.
  39965. No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
  39966. Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
  39967. Detailed testcases will follow in conjunction with the WML specific attribute support.
  39968. * GNUmakefile.am:
  39969. * WebCore.pro:
  39970. * WebCore.vcproj/WebCore.vcproj:
  39971. * WebCore.xcodeproj/project.pbxproj:
  39972. * css/CSSStyleSelector.cpp:
  39973. (WebCore::CSSStyleSelector::adjustRenderStyle):
  39974. * dom/FormControlElement.cpp: Activate disabled code from previous checking.
  39975. (WebCore::formControlElementForElement):
  39976. * dom/InputElement.cpp: Ditto.
  39977. (WebCore::inputElementForElement):
  39978. * wml/WMLInputElement.cpp: Added.
  39979. (WebCore::WMLInputElement::WMLInputElement):
  39980. (WebCore::WMLInputElement::~WMLInputElement):
  39981. (WebCore::isInputFocusable):
  39982. (WebCore::WMLInputElement::isKeyboardFocusable):
  39983. (WebCore::WMLInputElement::isMouseFocusable):
  39984. (WebCore::WMLInputElement::dispatchFocusEvent):
  39985. (WebCore::WMLInputElement::dispatchBlurEvent):
  39986. (WebCore::WMLInputElement::updateFocusAppearance):
  39987. (WebCore::WMLInputElement::aboutToUnload):
  39988. (WebCore::WMLInputElement::size):
  39989. (WebCore::WMLInputElement::name):
  39990. (WebCore::WMLInputElement::value):
  39991. (WebCore::WMLInputElement::setValue):
  39992. (WebCore::WMLInputElement::setValueFromRenderer):
  39993. (WebCore::WMLInputElement::saveState):
  39994. (WebCore::WMLInputElement::restoreState):
  39995. (WebCore::WMLInputElement::select):
  39996. (WebCore::WMLInputElement::accessKeyAction):
  39997. (WebCore::WMLInputElement::parseMappedAttribute):
  39998. (WebCore::WMLInputElement::copyNonAttributeProperties):
  39999. (WebCore::WMLInputElement::createRenderer):
  40000. (WebCore::WMLInputElement::attach):
  40001. (WebCore::WMLInputElement::detach):
  40002. (WebCore::WMLInputElement::appendFormData):
  40003. (WebCore::WMLInputElement::reset):
  40004. (WebCore::WMLInputElement::defaultEventHandler):
  40005. (WebCore::WMLInputElement::cacheSelection):
  40006. (WebCore::WMLInputElement::constrainValue):
  40007. (WebCore::WMLInputElement::documentDidBecomeActive):
  40008. (WebCore::WMLInputElement::placeholderShouldBeVisible):
  40009. (WebCore::WMLInputElement::willMoveToNewOwnerDocument):
  40010. (WebCore::WMLInputElement::didMoveToNewOwnerDocument):
  40011. * wml/WMLInputElement.h: Added.
  40012. (WebCore::WMLInputElement::valueMatchesRenderer):
  40013. (WebCore::WMLInputElement::setValueMatchesRenderer):
  40014. (WebCore::WMLInputElement::shouldUseInputMethod):
  40015. (WebCore::WMLInputElement::isChecked):
  40016. (WebCore::WMLInputElement::isIndeterminate):
  40017. (WebCore::WMLInputElement::isTextControl):
  40018. (WebCore::WMLInputElement::isRadioButton):
  40019. (WebCore::WMLInputElement::isTextField):
  40020. (WebCore::WMLInputElement::isSearchField):
  40021. (WebCore::WMLInputElement::isInputTypeHidden):
  40022. (WebCore::WMLInputElement::isPasswordField):
  40023. (WebCore::WMLInputElement::searchEventsShouldBeDispatched):
  40024. (WebCore::WMLInputElement::placeholderValue):
  40025. * wml/WMLTagNames.in:
  40026. 2009-01-20 Darin Adler <darin@apple.com>
  40027. Reviewed by John Sullivan.
  40028. Remove a little dead code left over after the fix for
  40029. https://bugs.webkit.org/show_bug.cgi?id=11395, which
  40030. moved pointer-events from SVG to be shared with HTML.
  40031. * css/SVGCSSParser.cpp:
  40032. (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this
  40033. property since it's handled in the non-SVG function now so we'll
  40034. never get here.
  40035. 2009-01-20 Julien Chaffraix <jchaffraix@webkit.org>
  40036. Reviewed by Darin Adler.
  40037. Bug 23438: Provide a default value to the .in file parser
  40038. Added the default value 1 as it simplifies some of
  40039. the format by removing some "=1" that were awkward.
  40040. This was suggested by Darin Adler as par of a previous
  40041. review.
  40042. * bindings/scripts/InFilesParser.pm: When no value
  40043. was entered (the second part of the split is undef),
  40044. provide the default value.
  40045. * html/HTMLAttributeNames.in: Removed unnecessary "=1".
  40046. * html/HTMLTagNames.in: Ditto.
  40047. * svg/svgattrs.in: Ditto.
  40048. * svg/svgtags.in: Ditto.
  40049. * svg/xlinkattrs.in: Ditto.
  40050. * wml/WMLAttributeNames.in: Ditto.
  40051. 2009-01-20 Anders Carlsson <andersca@apple.com>
  40052. Reviewed by Darin Adler.
  40053. * bridge/c/c_class.cpp:
  40054. * bridge/c/c_class.h:
  40055. Get rid of CClass::name().
  40056. * bridge/jni/jni_class.h:
  40057. Get rid of JavaClass::name().
  40058. * bridge/objc/objc_class.h:
  40059. * bridge/objc/objc_class.mm:
  40060. Get rid of ObjcClass::name().
  40061. * bridge/objc/objc_instance.h:
  40062. Get rid of supportsSetValueOfUndefinedField.
  40063. * bridge/objc/objc_instance.mm:
  40064. (ObjcInstance::setValueOfUndefinedField):
  40065. Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.
  40066. * bridge/runtime.cpp:
  40067. Get rid of getValueOfField and setValueOfField.
  40068. * bridge/runtime.h:
  40069. (JSC::Bindings::Instance::setValueOfUndefinedField):
  40070. Have this return a bool and get rid of supportsSetValueOfUndefinedField
  40071. * bridge/runtime_object.cpp:
  40072. (JSC::RuntimeObjectImp::fieldGetter):
  40073. Call Field::valueFromInstance on the field.
  40074. (JSC::RuntimeObjectImp::put):
  40075. Call Field::setValueToInstance on the field.
  40076. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  40077. Not reviewed. Forgot to land build changes for non-mac platforms.
  40078. * GNUmakefile.am:
  40079. * WebCore.pro:
  40080. * WebCore.scons:
  40081. * WebCore.vcproj/WebCore.vcproj:
  40082. * WebCoreSources.bkl:
  40083. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  40084. Reviewed by Adam Roben.
  40085. Fix last-minute regression, introduced by simplifying max length determination - by
  40086. clamping using min/max, negative maxLength values got broken.
  40087. * dom/InputElement.cpp:
  40088. (WebCore::InputElement::parseMaxLengthAttribute):
  40089. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  40090. Reviewed by Adam Roben.
  40091. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433
  40092. Add InputElement abstraction, similar to the FormControlElement refactorization
  40093. done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
  40094. In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
  40095. RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
  40096. depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.
  40097. A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
  40098. InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
  40099. derive from InputElement, and hold a InputElementData member variable, that they pass to the
  40100. static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.
  40101. * WebCore.xcodeproj/project.pbxproj:
  40102. * dom/FormControlElement.cpp: Added.
  40103. (WebCore::formControlElementForElement):
  40104. * dom/FormControlElement.h:
  40105. * dom/InputElement.cpp: Added.
  40106. (WebCore::InputElement::dispatchFocusEvent):
  40107. (WebCore::InputElement::dispatchBlurEvent):
  40108. (WebCore::InputElement::updatePlaceholderVisibility):
  40109. (WebCore::InputElement::updateFocusAppearance):
  40110. (WebCore::InputElement::updateSelectionRange):
  40111. (WebCore::InputElement::aboutToUnload):
  40112. (WebCore::InputElement::setValueFromRenderer):
  40113. (WebCore::numCharactersInGraphemeClusters):
  40114. (WebCore::InputElement::constrainValue):
  40115. (WebCore::numGraphemeClusters):
  40116. (WebCore::InputElement::handleBeforeTextInsertedEvent):
  40117. (WebCore::InputElement::parseSizeAttribute):
  40118. (WebCore::InputElement::parseMaxLengthAttribute):
  40119. (WebCore::InputElement::updateValueIfNeeded):
  40120. (WebCore::InputElement::notifyFormStateChanged):
  40121. (WebCore::InputElementData::InputElementData):
  40122. (WebCore::InputElementData::~InputElementData):
  40123. (WebCore::InputElementData::name):
  40124. (WebCore::inputElementForElement):
  40125. * dom/InputElement.h: Added.
  40126. (WebCore::InputElement::~InputElement):
  40127. (WebCore::InputElement::InputElement):
  40128. (WebCore::InputElementData::inputElement):
  40129. (WebCore::InputElementData::element):
  40130. (WebCore::InputElementData::placeholderShouldBeVisible):
  40131. (WebCore::InputElementData::setPlaceholderShouldBeVisible):
  40132. (WebCore::InputElementData::setName):
  40133. (WebCore::InputElementData::value):
  40134. (WebCore::InputElementData::setValue):
  40135. (WebCore::InputElementData::size):
  40136. (WebCore::InputElementData::setSize):
  40137. (WebCore::InputElementData::maxLength):
  40138. (WebCore::InputElementData::setMaxLength):
  40139. (WebCore::InputElementData::cachedSelectionStart):
  40140. (WebCore::InputElementData::setCachedSelectionStart):
  40141. (WebCore::InputElementData::cachedSelectionEnd):
  40142. (WebCore::InputElementData::setCachedSelectionEnd):
  40143. * html/HTMLInputElement.cpp:
  40144. (WebCore::HTMLInputElement::HTMLInputElement):
  40145. (WebCore::HTMLInputElement::name):
  40146. (WebCore::HTMLInputElement::updateFocusAppearance): Moved to InputElement.
  40147. (WebCore::HTMLInputElement::aboutToUnload): Ditto.
  40148. (WebCore::HTMLInputElement::dispatchFocusEvent): Ditto.
  40149. (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
  40150. (WebCore::HTMLInputElement::setSelectionRange): Moved to InputElement::updateSelectionRange, call it from here.
  40151. (WebCore::HTMLInputElement::parseMappedAttribute):
  40152. (WebCore::HTMLInputElement::size): Make virtual and override InputElements abstract version.
  40153. (WebCore::HTMLInputElement::copyNonAttributeProperties):
  40154. (WebCore::HTMLInputElement::value): Make virtual and override InputElements abstract version.
  40155. (WebCore::HTMLInputElement::setValue): Ditto.
  40156. (WebCore::HTMLInputElement::placeholderValue): Ditto.
  40157. (WebCore::HTMLInputElement::searchEventsShouldBeDispatched): Ditto.
  40158. (WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
  40159. (WebCore::HTMLInputElement::setFileListFromRenderer): Use new code in InputElement::setValueFromRenderer
  40160. (WebCore::HTMLInputElement::defaultEventHandler):
  40161. (WebCore::HTMLInputElement::setDefaultName): Added as helper function for HTMLIsIndexElement.
  40162. (WebCore::HTMLInputElement::maxLength): Added accesor.
  40163. (WebCore::HTMLInputElement::constrainValue): Move functionality to InputElement::constrainValue.
  40164. (WebCore::HTMLInputElement::cacheSelection): Move functionality to InputElement::cacheSelection.
  40165. (WebCore::HTMLInputElement::selection):
  40166. (WebCore::HTMLInputElement::placeholderShouldBeVisible): Make virtual and override InputElements abstract version.
  40167. * html/HTMLInputElement.h:
  40168. (WebCore::HTMLInputElement::isTextField):
  40169. (WebCore::HTMLInputElement::isSearchField):
  40170. (WebCore::HTMLInputElement::isAutofilled):
  40171. * html/HTMLIsIndexElement.cpp:
  40172. (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
  40173. * rendering/RenderTextControl.cpp:
  40174. (WebCore::RenderTextControl::formControlElement):
  40175. * rendering/RenderTextControlSingleLine.cpp:
  40176. (WebCore::RenderTextControlSingleLine::placeholderShouldBeVisible):
  40177. (WebCore::RenderTextControlSingleLine::addSearchResult):
  40178. (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
  40179. (WebCore::RenderTextControlSingleLine::showPopup):
  40180. (WebCore::RenderTextControlSingleLine::hidePopup):
  40181. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  40182. (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
  40183. (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  40184. (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
  40185. (WebCore::RenderTextControlSingleLine::updateFromElement):
  40186. (WebCore::RenderTextControlSingleLine::cacheSelection):
  40187. (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
  40188. (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
  40189. (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
  40190. (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
  40191. (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
  40192. (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
  40193. (WebCore::RenderTextControlSingleLine::valueChanged):
  40194. (WebCore::RenderTextControlSingleLine::setTextFromItem):
  40195. (WebCore::RenderTextControlSingleLine::inputElement):
  40196. * rendering/RenderTextControlSingleLine.h:
  40197. 2009-01-20 Dirk Schulze <krit@webkit.org>
  40198. Reviewed by Nikolas Zimmermann.
  40199. Make SVG pattern platform independent and remove platform code.
  40200. Make SVGPattern platform independent
  40201. https://bugs.webkit.org/show_bug.cgi?id=21205
  40202. * GNUmakefile.am:
  40203. * WebCore.pro:
  40204. * WebCore.vcproj/WebCore.vcproj:
  40205. * WebCore.xcodeproj/project.pbxproj:
  40206. * platform/graphics/GraphicsContext.h:
  40207. * platform/graphics/cg/GraphicsContextCG.cpp:
  40208. (WebCore::GraphicsContext::applyStrokePattern):
  40209. (WebCore::GraphicsContext::applyFillPattern):
  40210. (WebCore::GraphicsContext::drawPath):
  40211. (WebCore::GraphicsContext::fillPath):
  40212. (WebCore::GraphicsContext::strokePath):
  40213. (WebCore::GraphicsContext::fillRect):
  40214. (WebCore::GraphicsContext::strokeRect):
  40215. * svg/graphics/SVGPaintServerPattern.cpp:
  40216. (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
  40217. (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern):
  40218. (WebCore::SVGPaintServerPattern::setup):
  40219. (WebCore::SVGPaintServerPattern::renderPath):
  40220. (WebCore::SVGPaintServerPattern::teardown):
  40221. * svg/graphics/SVGPaintServerPattern.h:
  40222. * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
  40223. * svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
  40224. * svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
  40225. * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.
  40226. 2009-01-20 Darin Fisher <darin@chromium.org>
  40227. Reviewed by Eric Seidel.
  40228. https://bugs.webkit.org/show_bug.cgi?id=23436
  40229. Upstream rendering/RenderThemeChromium*
  40230. * rendering/RenderThemeChromiumGtk.cpp: Added.
  40231. * rendering/RenderThemeChromiumGtk.h: Added.
  40232. * rendering/RenderThemeChromiumMac.h: Added.
  40233. * rendering/RenderThemeChromiumMac.mm: Added.
  40234. * rendering/RenderThemeChromiumWin.cpp: Added.
  40235. * rendering/RenderThemeChromiumWin.h: Added.
  40236. 2009-01-20 Darin Adler <darin@apple.com>
  40237. Reviewed by Mark Rowe.
  40238. Bug 23352: Turn on more compiler warnings in the Mac build
  40239. https://bugs.webkit.org/show_bug.cgi?id=23352
  40240. First patch: Fix some simple cases of various warnings.
  40241. * platform/DeprecatedPtrListImpl.cpp:
  40242. (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
  40243. * platform/graphics/mac/SimpleFontDataMac.mm:
  40244. (WebCore::SimpleFontData::containsCharacters): Ditto.
  40245. * platform/text/PlatformString.h: Overload for short and unsigned short to avoid
  40246. ambiguity leading to warnings.
  40247. * platform/text/String.cpp:
  40248. (WebCore::String::number): Implemented overloads.
  40249. * platform/text/TextStream.cpp:
  40250. (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading
  40251. to warnings.
  40252. * platform/text/TextStream.h: Ditto.
  40253. * rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.
  40254. * svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after
  40255. #endif that should be a comment instead.
  40256. * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.
  40257. * xml/XPathPath.h: Remove unneeded redundant declaration.
  40258. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  40259. Build fix for WML enabled builds, not reviewed.
  40260. Fix unused variable warning.
  40261. * wml/WMLGoElement.cpp:
  40262. (WebCore::WMLGoElement::executeTask):
  40263. 2009-01-20 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  40264. Build fix for WML enabled builds, not reviewed.
  40265. Rename 'continuation' to 'virtualContinuation'.
  40266. * wml/WMLAElement.cpp:
  40267. (WebCore::WMLAElement::isKeyboardFocusable):
  40268. 2009-01-20 Oliver Hunt <oliver@apple.com>
  40269. RS=Dan Bernstein
  40270. Move runtime/ByteArray to wtf/ByteArray
  40271. * ForwardingHeaders/wtf/ByteArray.h: Renamed from WebCore/ForwardingHeaders/runtime/ByteArray.h.
  40272. * html/CanvasRenderingContext2D.cpp:
  40273. * html/ImageData.cpp:
  40274. (WebCore::ImageData::ImageData):
  40275. * html/ImageData.h:
  40276. (WebCore::ImageData::data):
  40277. 2009-01-20 Darin Fisher <darin@chromium.org>
  40278. Reviewed by Sam Weinig.
  40279. https://bugs.webkit.org/show_bug.cgi?id=23391
  40280. Upstream plugins/chromium/
  40281. * plugins/chromium: Added.
  40282. * plugins/chromium/PluginDataChromium.cpp: Added.
  40283. 2009-01-19 Steve Falkenburg <sfalken@apple.com>
  40284. Fix Windows release build.
  40285. Move SVG files into all-in-one file for Windows build.
  40286. * WebCore.vcproj/WebCore.vcproj:
  40287. * svg/SVGAllInOne.cpp: Added.
  40288. 2009-01-19 Steve Falkenburg <sfalken@apple.com>
  40289. Partial build fix.
  40290. Move new derived sources into all-in-one DerivedSources.cpp
  40291. * DerivedSources.cpp:
  40292. * WebCore.vcproj/WebCore.vcproj:
  40293. 2009-01-19 Sam Weinig <sam@webkit.org>
  40294. Fix Qt build.
  40295. * bridge/qt/qt_instance.cpp:
  40296. (JSC::Bindings::QtInstance::mark):
  40297. * bridge/qt/qt_runtime.cpp:
  40298. (JSC::Bindings::valueRealType):
  40299. (JSC::Bindings::convertValueToQVariant):
  40300. (JSC::Bindings::QtRuntimeConnectionMethod::call):
  40301. (JSC::Bindings::QtConnectionObject::execute):
  40302. 2009-01-19 Sam Weinig <sam@webkit.org>
  40303. Fix wx build.
  40304. * plugins/PluginView.cpp:
  40305. (WebCore::getString):
  40306. 2009-01-19 Sam Weinig <sam@webkit.org>
  40307. Rubber-stamped by Gavin Barraclough.
  40308. Remove temporary operator-> from JSValuePtr.
  40309. * WebCore.xcodeproj/project.pbxproj:
  40310. * bindings/js/JSAudioConstructor.cpp:
  40311. (WebCore::constructAudio):
  40312. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  40313. (WebCore::toHTMLCanvasStyle):
  40314. (WebCore::JSCanvasRenderingContext2D::setFillColor):
  40315. (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
  40316. (WebCore::JSCanvasRenderingContext2D::strokeRect):
  40317. (WebCore::JSCanvasRenderingContext2D::drawImage):
  40318. (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
  40319. (WebCore::JSCanvasRenderingContext2D::setShadow):
  40320. (WebCore::JSCanvasRenderingContext2D::createPattern):
  40321. (WebCore::JSCanvasRenderingContext2D::putImageData):
  40322. (WebCore::JSCanvasRenderingContext2D::fillText):
  40323. (WebCore::JSCanvasRenderingContext2D::strokeText):
  40324. * bindings/js/JSClipboardCustom.cpp:
  40325. (WebCore::JSClipboard::clearData):
  40326. (WebCore::JSClipboard::getData):
  40327. (WebCore::JSClipboard::setData):
  40328. (WebCore::JSClipboard::setDragImage):
  40329. * bindings/js/JSCustomPositionCallback.cpp:
  40330. (WebCore::JSCustomPositionCallback::handleEvent):
  40331. * bindings/js/JSCustomPositionErrorCallback.cpp:
  40332. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  40333. * bindings/js/JSCustomSQLStatementCallback.cpp:
  40334. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  40335. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  40336. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  40337. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  40338. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  40339. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  40340. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  40341. * bindings/js/JSCustomVoidCallback.cpp:
  40342. (WebCore::JSCustomVoidCallback::handleEvent):
  40343. (WebCore::toVoidCallback):
  40344. * bindings/js/JSCustomXPathNSResolver.cpp:
  40345. (WebCore::JSCustomXPathNSResolver::create):
  40346. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  40347. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  40348. (WebCore::JSDOMApplicationCache::hasItem):
  40349. (WebCore::JSDOMApplicationCache::add):
  40350. (WebCore::JSDOMApplicationCache::remove):
  40351. (WebCore::JSDOMApplicationCache::addEventListener):
  40352. (WebCore::JSDOMApplicationCache::removeEventListener):
  40353. * bindings/js/JSDOMBinding.cpp:
  40354. (WebCore::valueToStringWithNullCheck):
  40355. (WebCore::valueToStringWithUndefinedOrNullCheck):
  40356. (WebCore::reportException):
  40357. * bindings/js/JSDOMGlobalObject.cpp:
  40358. (WebCore::JSDOMGlobalObject::findJSEventListener):
  40359. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  40360. (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
  40361. (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
  40362. * bindings/js/JSDOMStringListCustom.cpp:
  40363. (WebCore::JSDOMStringList::item):
  40364. * bindings/js/JSDOMWindowBase.cpp:
  40365. (WebCore::JSDOMWindowBase::getOwnPropertySlot):
  40366. (windowProtoFuncOpen):
  40367. (WebCore::toJSDOMWindow):
  40368. * bindings/js/JSDOMWindowCustom.cpp:
  40369. (WebCore::JSDOMWindow::setLocation):
  40370. (WebCore::JSDOMWindow::postMessage):
  40371. (WebCore::setTimeoutOrInterval):
  40372. (WebCore::JSDOMWindow::clearTimeout):
  40373. (WebCore::JSDOMWindow::clearInterval):
  40374. (WebCore::JSDOMWindow::atob):
  40375. (WebCore::JSDOMWindow::btoa):
  40376. (WebCore::JSDOMWindow::addEventListener):
  40377. (WebCore::JSDOMWindow::removeEventListener):
  40378. (WebCore::toDOMWindow):
  40379. * bindings/js/JSDatabaseCustom.cpp:
  40380. (WebCore::JSDatabase::changeVersion):
  40381. (WebCore::JSDatabase::transaction):
  40382. * bindings/js/JSDocumentCustom.cpp:
  40383. (WebCore::JSDocument::setLocation):
  40384. * bindings/js/JSElementCustom.cpp:
  40385. (WebCore::JSElement::setAttribute):
  40386. (WebCore::JSElement::setAttributeNS):
  40387. * bindings/js/JSEventListener.cpp:
  40388. (WebCore::JSAbstractEventListener::handleEvent):
  40389. (WebCore::JSLazyEventListener::parseCode):
  40390. * bindings/js/JSEventTargetNodeCustom.cpp:
  40391. (WebCore::JSEventTargetNode::addEventListener):
  40392. (WebCore::JSEventTargetNode::removeEventListener):
  40393. * bindings/js/JSGeolocationCustom.cpp:
  40394. (WebCore::createPositionOptions):
  40395. (WebCore::JSGeolocation::getCurrentPosition):
  40396. (WebCore::JSGeolocation::watchPosition):
  40397. * bindings/js/JSHTMLCollectionCustom.cpp:
  40398. (WebCore::callHTMLCollection):
  40399. (WebCore::JSHTMLCollection::canGetItemsForName):
  40400. (WebCore::JSHTMLCollection::item):
  40401. (WebCore::JSHTMLCollection::namedItem):
  40402. * bindings/js/JSHTMLDocumentCustom.cpp:
  40403. (WebCore::JSHTMLDocument::open):
  40404. (WebCore::writeHelper):
  40405. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  40406. (WebCore::JSHTMLOptionsCollection::setLength):
  40407. (WebCore::JSHTMLOptionsCollection::add):
  40408. * bindings/js/JSHTMLSelectElementCustom.cpp:
  40409. (WebCore::JSHTMLSelectElement::remove):
  40410. (WebCore::selectIndexSetter):
  40411. * bindings/js/JSImageConstructor.cpp:
  40412. (WebCore::constructImage):
  40413. * bindings/js/JSInspectedObjectWrapper.cpp:
  40414. (WebCore::JSInspectedObjectWrapper::wrap):
  40415. (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
  40416. * bindings/js/JSInspectorCallbackWrapper.cpp:
  40417. (WebCore::JSInspectorCallbackWrapper::wrap):
  40418. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  40419. (WebCore::JSJavaScriptCallFrame::evaluate):
  40420. * bindings/js/JSLocationCustom.cpp:
  40421. (WebCore::JSLocation::setHref):
  40422. (WebCore::JSLocation::setProtocol):
  40423. (WebCore::JSLocation::setHost):
  40424. (WebCore::JSLocation::setHostname):
  40425. (WebCore::JSLocation::setPort):
  40426. (WebCore::JSLocation::setPathname):
  40427. (WebCore::JSLocation::setSearch):
  40428. (WebCore::JSLocation::setHash):
  40429. (WebCore::JSLocation::replace):
  40430. (WebCore::JSLocation::assign):
  40431. * bindings/js/JSMessageChannelConstructor.cpp:
  40432. (WebCore::JSMessageChannelConstructor::mark):
  40433. * bindings/js/JSMessagePortCustom.cpp:
  40434. (WebCore::JSMessagePort::startConversation):
  40435. (WebCore::JSMessagePort::addEventListener):
  40436. (WebCore::JSMessagePort::removeEventListener):
  40437. * bindings/js/JSNodeFilterCondition.cpp:
  40438. (WebCore::JSNodeFilterCondition::mark):
  40439. (WebCore::JSNodeFilterCondition::acceptNode):
  40440. * bindings/js/JSNodeFilterCondition.h:
  40441. * bindings/js/JSNodeFilterCustom.cpp:
  40442. (WebCore::toNodeFilter):
  40443. * bindings/js/JSNodeListCustom.cpp:
  40444. (WebCore::callNodeList):
  40445. * bindings/js/JSOptionConstructor.cpp:
  40446. (WebCore::constructHTMLOptionElement):
  40447. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  40448. (WebCore::JSQuarantinedObjectWrapper::asWrapper):
  40449. (WebCore::JSQuarantinedObjectWrapper::construct):
  40450. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  40451. (WebCore::JSSQLResultSetRowList::item):
  40452. * bindings/js/JSSQLTransactionCustom.cpp:
  40453. (WebCore::JSSQLTransaction::executeSql):
  40454. * bindings/js/JSSVGElementInstanceCustom.cpp:
  40455. (WebCore::JSSVGElementInstance::addEventListener):
  40456. (WebCore::JSSVGElementInstance::removeEventListener):
  40457. * bindings/js/JSSVGLengthCustom.cpp:
  40458. (WebCore::JSSVGLength::convertToSpecifiedUnits):
  40459. * bindings/js/JSSVGMatrixCustom.cpp:
  40460. (WebCore::JSSVGMatrix::translate):
  40461. (WebCore::JSSVGMatrix::scale):
  40462. (WebCore::JSSVGMatrix::scaleNonUniform):
  40463. (WebCore::JSSVGMatrix::rotate):
  40464. (WebCore::JSSVGMatrix::rotateFromVector):
  40465. (WebCore::JSSVGMatrix::skewX):
  40466. (WebCore::JSSVGMatrix::skewY):
  40467. * bindings/js/JSSVGPathSegListCustom.cpp:
  40468. (WebCore::JSSVGPathSegList::getItem):
  40469. (WebCore::JSSVGPathSegList::insertItemBefore):
  40470. (WebCore::JSSVGPathSegList::replaceItem):
  40471. (WebCore::JSSVGPathSegList::removeItem):
  40472. * bindings/js/JSSVGPointListCustom.cpp:
  40473. (WebCore::JSSVGPointList::getItem):
  40474. (WebCore::JSSVGPointList::insertItemBefore):
  40475. (WebCore::JSSVGPointList::replaceItem):
  40476. (WebCore::JSSVGPointList::removeItem):
  40477. * bindings/js/JSSVGTransformListCustom.cpp:
  40478. (WebCore::JSSVGTransformList::getItem):
  40479. (WebCore::JSSVGTransformList::insertItemBefore):
  40480. (WebCore::JSSVGTransformList::replaceItem):
  40481. (WebCore::JSSVGTransformList::removeItem):
  40482. * bindings/js/JSStorageCustom.cpp:
  40483. (WebCore::JSStorage::deleteProperty):
  40484. (WebCore::JSStorage::customPut):
  40485. * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
  40486. (WebCore::constructWebKitCSSMatrix):
  40487. * bindings/js/JSWorkerConstructor.cpp:
  40488. (WebCore::constructWorker):
  40489. * bindings/js/JSWorkerContextCustom.cpp:
  40490. (WebCore::JSWorkerContext::addEventListener):
  40491. (WebCore::JSWorkerContext::removeEventListener):
  40492. * bindings/js/JSWorkerCustom.cpp:
  40493. (WebCore::JSWorker::addEventListener):
  40494. (WebCore::JSWorker::removeEventListener):
  40495. * bindings/js/JSXMLHttpRequestCustom.cpp:
  40496. (WebCore::JSXMLHttpRequest::open):
  40497. (WebCore::JSXMLHttpRequest::setRequestHeader):
  40498. (WebCore::JSXMLHttpRequest::send):
  40499. (WebCore::JSXMLHttpRequest::getResponseHeader):
  40500. (WebCore::JSXMLHttpRequest::overrideMimeType):
  40501. (WebCore::JSXMLHttpRequest::addEventListener):
  40502. (WebCore::JSXMLHttpRequest::removeEventListener):
  40503. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  40504. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  40505. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  40506. * bindings/js/JSXSLTProcessorCustom.cpp:
  40507. (WebCore::JSXSLTProcessor::importStylesheet):
  40508. (WebCore::JSXSLTProcessor::transformToFragment):
  40509. (WebCore::JSXSLTProcessor::transformToDocument):
  40510. (WebCore::JSXSLTProcessor::setParameter):
  40511. (WebCore::JSXSLTProcessor::getParameter):
  40512. (WebCore::JSXSLTProcessor::removeParameter):
  40513. * bindings/js/ScheduledAction.cpp:
  40514. (WebCore::ScheduledAction::executeFunctionInContext):
  40515. * bindings/js/ScriptCallStack.cpp:
  40516. (WebCore::ScriptCallStack::initialize):
  40517. * bindings/js/ScriptController.cpp:
  40518. (WebCore::ScriptController::createScriptObjectForPluginElement):
  40519. * bindings/js/ScriptValue.cpp:
  40520. (WebCore::ScriptValue::getString):
  40521. (WebCore::ScriptValue::isNull):
  40522. (WebCore::ScriptValue::isUndefined):
  40523. * bindings/objc/WebScriptObject.mm:
  40524. (-[WebScriptObject callWebScriptMethod:withArguments:]):
  40525. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  40526. * bindings/scripts/CodeGeneratorJS.pm:
  40527. * bridge/NP_jsobject.cpp:
  40528. (_NPN_InvokeDefault):
  40529. (_NPN_Invoke):
  40530. (_NPN_HasMethod):
  40531. (_NPN_Construct):
  40532. * bridge/c/c_utility.cpp:
  40533. (JSC::Bindings::convertValueToNPVariant):
  40534. * bridge/jni/jni_instance.cpp:
  40535. (JavaInstance::invokeMethod):
  40536. * bridge/jni/jni_jsobject.mm:
  40537. (JavaJSObject::call):
  40538. (JavaJSObject::convertValueToJObject):
  40539. * bridge/jni/jni_runtime.cpp:
  40540. (JavaField::dispatchValueFromInstance):
  40541. (JavaField::valueFromInstance):
  40542. (JavaField::dispatchSetValueToInstance):
  40543. (JavaField::setValueToInstance):
  40544. * bridge/jni/jni_utility.cpp:
  40545. (JSC::Bindings::convertArrayInstanceToJavaArray):
  40546. (JSC::Bindings::convertValueToJValue):
  40547. * bridge/objc/objc_runtime.mm:
  40548. (JSC::Bindings::callObjCFallbackObject):
  40549. * bridge/objc/objc_utility.mm:
  40550. (JSC::Bindings::convertValueToObjcValue):
  40551. * bridge/runtime_method.cpp:
  40552. (JSC::callRuntimeMethod):
  40553. * bridge/runtime_object.cpp:
  40554. (JSC::RuntimeObjectImp::getOwnPropertySlot):
  40555. (JSC::callRuntimeConstructor):
  40556. 2009-01-20 Gustavo Noronha Silva <gns@gnome.org>
  40557. Reviewed by Mark Rowe.
  40558. https://bugs.webkit.org/show_bug.cgi?id=23419
  40559. removal of FramePrivate.h breaks GTK+'s make dist
  40560. * GNUmakefile.am: No longer mention FramePrivate.h in our build,
  40561. since it was removed.
  40562. 2009-01-20 Alexander V. Butenko <alex@digiqube.com>
  40563. Reviewed by Holger Freyther.
  40564. http://bugs.webkit.org/show_bug.cgi?id=23116
  40565. [GTK] Fix crash due a callback called from GIO after the
  40566. destruction of the ResourceHandle
  40567. * platform/network/soup/ResourceHandleSoup.cpp:
  40568. (WebCore::ResourceHandle::cancel): Only call didFinishLoading if
  40569. 'client' is set, otherwise cancelling a load could lead to a crash.
  40570. 2009-01-19 Simon Fraser <simon.fraser@apple.com>
  40571. Build fix: remove duplicate entries in the Xcode project, and
  40572. sort the project with sort-Xcode-project-file .
  40573. * WebCore.xcodeproj/project.pbxproj:
  40574. 2009-01-19 Simon Fraser <simon.fraser@apple.com>
  40575. Reviewed by Dave Hyatt
  40576. https://bugs.webkit.org/show_bug.cgi?id=18078
  40577. Support animations and transitions of shorthand properties by creating
  40578. PropertyWrappers that simply wrap a vector of atomic wrappers, and implement
  40579. equal() and blend(). Build that collection of shorthand wrappers using the
  40580. shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
  40581. shorthand wrappers during 'all' transitions.
  40582. * GNUmakefile.am:
  40583. * WebCore.pro:
  40584. * WebCore.scons:
  40585. * WebCore.vcproj/WebCore.vcproj:
  40586. * WebCore.xcodeproj/project.pbxproj:
  40587. * WebCoreSources.bkl:
  40588. Add CSSPropertyLonghand.h/cpp.
  40589. * css/CSSMutableStyleDeclaration.cpp:
  40590. (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
  40591. Move CSSPropertyLonghand to its own file.
  40592. * css/CSSPropertyLonghand.cpp: Added.
  40593. (WebCore::initShorthandMap):
  40594. (WebCore::longhandForProperty):
  40595. * css/CSSPropertyLonghand.h: Added.
  40596. (WebCore::CSSPropertyLonghand::CSSPropertyLonghand):
  40597. (WebCore::CSSPropertyLonghand::properties):
  40598. (WebCore::CSSPropertyLonghand::length):
  40599. Code moved from CSSMutableStyleDeclaration.h/cpp
  40600. * page/animation/AnimationBase.cpp:
  40601. (WebCore::PropertyWrapperBase::isShorthandWrapper):
  40602. (WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
  40603. (WebCore::ShorthandPropertyWrapper::isShorthandWrapper):
  40604. (WebCore::ShorthandPropertyWrapper::equals):
  40605. (WebCore::ShorthandPropertyWrapper::blend):
  40606. Add a wrapper class for shorthand properties that simply wraps an
  40607. array of atomic property wrappers.
  40608. (WebCore::ensurePropertyMap):
  40609. (WebCore::addPropertyWrapper):
  40610. (WebCore::addShorthandProperties):
  40611. (WebCore::wrapperForProperty):
  40612. (WebCore::AnimationBase::propertiesEqual):
  40613. (WebCore::AnimationBase::getPropertyAtIndex):
  40614. Some minor refactoring to re-use wrapperForProperty(), and ensure that gPropertyWrapperMap
  40615. is filled with an invalid index (-1), not 0.
  40616. (WebCore::AnimationBase::blendProperties):
  40617. * page/animation/AnimationBase.h:
  40618. * page/animation/CompositeAnimation.cpp:
  40619. (WebCore::CompositeAnimationPrivate::updateTransitions):
  40620. When doing 'all' transitions, skip shorthand wrappers, since 'all' transitions
  40621. just need to compare all the atomic property wrappers.
  40622. 2009-01-19 Oliver Hunt <oliver@apple.com>
  40623. Reviewed by NOBODY (Build fix).
  40624. Actually add the new header.
  40625. * dom/GenericWorkerTask.h: Added.
  40626. 2009-01-19 David Levin <levin@chromium.org>
  40627. Reviewed by Alexey Proskuryakov.
  40628. https://bugs.webkit.org/show_bug.cgi?id=22720
  40629. Provide a generic class to handle the pattern of task callbacks across worker/parent threads. It
  40630. only works for methods that need 6 parameters but similar classes could be added as needed for
  40631. other numbers of parameters.
  40632. Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.
  40633. Use these methods and others to remove document() from XMLHttpRequest in a few more places.
  40634. No observable change in behavior, so no test.
  40635. * GNUmakefile.am:
  40636. * WebCore.vcproj/WebCore.vcproj:
  40637. * WebCore.xcodeproj/project.pbxproj:
  40638. Sorted project file while adding GenericWorkerTask.h
  40639. * bindings/js/ScriptString.h:
  40640. (WebCore::ScriptString::operator=):
  40641. (WebCore::ScriptString::operator+=):
  40642. (WebCore::ScriptString::operator==):
  40643. (WebCore::ScriptString::operator!=):
  40644. Removed unnecessary JSLock.
  40645. * dom/Document.cpp:
  40646. (WebCore::Document::addMessage):
  40647. (WebCore::Document::resourceRetrievedByXMLHttpRequest):
  40648. * dom/Document.h:
  40649. * dom/GenericWorkerTask.h: Added.
  40650. (WebCore::GenericWorkerTaskBase::GenericWorkerTaskBase):
  40651. (WebCore::GenericWorkerTaskBase::canPerformTask):
  40652. (WebCore::GenericWorkerTask6::create):
  40653. (WebCore::GenericWorkerTask6::GenericWorkerTask6):
  40654. (WebCore::GenericWorkerTask6::performTask):
  40655. (WebCore::createCallbackTask):
  40656. * dom/ScriptExecutionContext.h:
  40657. * dom/WorkerContext.cpp:
  40658. (WebCore::addMessageTask):
  40659. (WebCore::WorkerContext::addMessage):
  40660. (WebCore::WorkerContext::resourceRetrievedByXMLHttpRequest):
  40661. (WebCore::WorkerContext::postTaskToParentContext):
  40662. * dom/WorkerContext.h:
  40663. * dom/WorkerMessagingProxy.cpp:
  40664. (WebCore::WorkerMessagingProxy::postTaskToParentContext):
  40665. * dom/WorkerMessagingProxy.h:
  40666. * dom/WorkerThread.h:
  40667. * xml/XMLHttpRequest.cpp:
  40668. (WebCore::XMLHttpRequest::XMLHttpRequest):
  40669. (WebCore::XMLHttpRequest::dropProtection):
  40670. (WebCore::reportUnsafeUsage):
  40671. (WebCore::XMLHttpRequest::setRequestHeader):
  40672. (WebCore::XMLHttpRequest::getResponseHeader):
  40673. (WebCore::XMLHttpRequest::didFinishLoading):
  40674. * xml/XMLHttpRequest.h:
  40675. (WebCore::XMLHttpRequest::create):
  40676. 2009-01-19 Chris Fleizach <cfleizach@apple.com>
  40677. Reviewed by Beth Dakin.
  40678. Bug 23422: AX: AXLinks should expose access key information
  40679. https://bugs.webkit.org/show_bug.cgi?id=23422
  40680. Test: accessibility/accesskey.html
  40681. * page/mac/AccessibilityObjectWrapper.mm:
  40682. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  40683. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  40684. 2009-01-19 Alexey Proskuryakov <ap@webkit.org>
  40685. Reviewed by Anders Carlsson.
  40686. https://bugs.webkit.org/show_bug.cgi?id=23417
  40687. Implement application cache obsolete state
  40688. Test: http/tests/appcache/remove-cache.html
  40689. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  40690. (WebCore::JSDOMApplicationCache::mark):
  40691. * dom/EventNames.h:
  40692. * loader/appcache/DOMApplicationCache.h:
  40693. (WebCore::DOMApplicationCache::Status):
  40694. (WebCore::DOMApplicationCache::setOnobsolete):
  40695. (WebCore::DOMApplicationCache::onobsolete):
  40696. * loader/appcache/DOMApplicationCache.idl:
  40697. Added "obsolete" event and status.
  40698. * loader/appcache/ApplicationCacheGroup.h:
  40699. (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer
  40700. any need to track what the newest cache was during teardown.
  40701. (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing
  40702. confusion with cache group lifecycle status.
  40703. (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
  40704. * loader/appcache/ApplicationCacheGroup.cpp:
  40705. (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete.
  40706. (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does
  40707. not belong to an obsolete group.
  40708. (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto.
  40709. (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen
  40710. via a JS swapCache() call, not only when the loader is destroyed.
  40711. (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer.
  40712. (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is
  40713. a caller responsibility, because this method is also used when loading caches from disk.
  40714. (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and
  40715. inform cache storage, so that it could be removed.
  40716. (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did
  40717. was call cacheUpdateFailed().
  40718. (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure
  40719. handing.
  40720. (WebCore::ApplicationCacheGroup::didFail): Ditto.
  40721. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound()
  40722. method for 404 and 410 responses.
  40723. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed()
  40724. directly, instead of the removed didFailToLoadManifest().
  40725. (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm.
  40726. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage
  40727. after update successfully finishes (moved from setNewestCache()).
  40728. (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using
  40729. an explicitly passed pointer, without the need to save it during teardown.
  40730. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader):
  40731. Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
  40732. * loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated
  40733. some comments.
  40734. * loader/appcache/ApplicationCacheStorage.cpp:
  40735. (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not
  40736. obsolete.
  40737. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
  40738. (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete
  40739. groups, as they cannot be in storage.
  40740. (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage
  40741. completely, so that a new one could replace it, if necessary.
  40742. (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions.
  40743. (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
  40744. * loader/appcache/DOMApplicationCache.cpp:
  40745. (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state.
  40746. (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the
  40747. application was removed server-side.
  40748. (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
  40749. * loader/appcache/DOMApplicationCache.h:
  40750. (WebCore::DOMApplicationCache::Status):
  40751. (WebCore::DOMApplicationCache::setOnobsolete):
  40752. (WebCore::DOMApplicationCache::onobsolete):
  40753. Added support for OBSOLETE state and obsolete event.
  40754. * loader/appcache/DOMApplicationCache.idl: Ditto.
  40755. 2009-01-19 Anders Carlsson <andersca@apple.com>
  40756. Reviewed by Kevin Decker.
  40757. Allow plug-in views to return an instance directly.
  40758. * bindings/js/ScriptControllerMac.mm:
  40759. (WebCore::ScriptController::createScriptInstanceForWidget):
  40760. 2009-01-19 Chris Fleizach <cfleizach@apple.com>
  40761. Reviewed by David Hyatt.
  40762. AX: some buttons don't expose AXPress as an action
  40763. https://bugs.webkit.org/show_bug.cgi?id=23399
  40764. Test: accessibility/button-press-action.html
  40765. * page/AccessibilityRenderObject.cpp:
  40766. (WebCore::AccessibilityRenderObject::actionElement):
  40767. 2009-01-19 Adam Roben <aroben@apple.com>
  40768. Windows build fix
  40769. * WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into
  40770. $WebKitOutputDir so that WebKit can access them.
  40771. * html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild
  40772. and header copy.
  40773. 2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
  40774. Reviewed by Simon Hausmann.
  40775. http://qt.nokia.com/developer/task-tracker/index_html?id=211228&method=entry
  40776. [Qt] Show focus rect when a button gets the focus for the first time.
  40777. This is important at least for Windows style.
  40778. * platform/qt/RenderThemeQt.cpp:
  40779. (WebCore::RenderThemeQt::applyTheme):
  40780. 2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
  40781. [Qt] Build fix after r39971.
  40782. * platform/qt/LoggingQt.cpp:
  40783. (WebCore::InitializeLoggingChannelsIfNecessary):
  40784. 2009-01-18 Sam Weinig <sam@webkit.org>
  40785. Reviewed by Cameron Zwarich.
  40786. Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
  40787. Remove FramePrivate
  40788. Minor PLT speedup.
  40789. * WebCore.base.exp:
  40790. * WebCore.vcproj/WebCore.vcproj:
  40791. * WebCore.xcodeproj/project.pbxproj:
  40792. * loader/FrameLoader.cpp:
  40793. * page/Frame.cpp:
  40794. (WebCore::Frame::Frame):
  40795. (WebCore::Frame::~Frame):
  40796. (WebCore::Frame::init):
  40797. (WebCore::Frame::loader):
  40798. (WebCore::Frame::view):
  40799. (WebCore::Frame::setView):
  40800. (WebCore::Frame::script):
  40801. (WebCore::Frame::document):
  40802. (WebCore::Frame::setDocument):
  40803. (WebCore::Frame::settings):
  40804. (WebCore::Frame::selection):
  40805. (WebCore::Frame::editor):
  40806. (WebCore::Frame::selectionGranularity):
  40807. (WebCore::Frame::setSelectionGranularity):
  40808. (WebCore::Frame::dragCaretController):
  40809. (WebCore::Frame::animation):
  40810. (WebCore::Frame::mark):
  40811. (WebCore::Frame::setMark):
  40812. (WebCore::Frame::setCaretVisible):
  40813. (WebCore::Frame::clearCaretRectIfNeeded):
  40814. (WebCore::Frame::selectionLayoutChanged):
  40815. (WebCore::Frame::caretBlinkTimerFired):
  40816. (WebCore::Frame::paintCaret):
  40817. (WebCore::Frame::paintDragCaret):
  40818. (WebCore::Frame::zoomFactor):
  40819. (WebCore::Frame::isZoomFactorTextOnly):
  40820. (WebCore::Frame::shouldApplyTextZoom):
  40821. (WebCore::Frame::shouldApplyPageZoom):
  40822. (WebCore::Frame::setZoomFactor):
  40823. (WebCore::Frame::setPrinting):
  40824. (WebCore::Frame::setJSStatusBarText):
  40825. (WebCore::Frame::setJSDefaultStatusBarText):
  40826. (WebCore::Frame::jsStatusBarText):
  40827. (WebCore::Frame::jsDefaultStatusBarText):
  40828. (WebCore::Frame::setNeedsReapplyStyles):
  40829. (WebCore::Frame::needsReapplyStyles):
  40830. (WebCore::Frame::reapplyStyles):
  40831. (WebCore::Frame::isContentEditable):
  40832. (WebCore::Frame::updateSecureKeyboardEntryIfActive):
  40833. (WebCore::Frame::typingStyle):
  40834. (WebCore::Frame::setTypingStyle):
  40835. (WebCore::Frame::clearTypingStyle):
  40836. (WebCore::Frame::computeAndSetTypingStyle):
  40837. (WebCore::Frame::selectionComputedStyle):
  40838. (WebCore::Frame::applyEditingStyleToBodyElement):
  40839. (WebCore::Frame::removeEditingStyleFromBodyElement):
  40840. (WebCore::Frame::keepAlive):
  40841. (WebCore::Frame::cancelAllKeepAlive):
  40842. (WebCore::Frame::clearDOMWindow):
  40843. (WebCore::Frame::ownerElement):
  40844. (WebCore::Frame::ownerRenderer):
  40845. (WebCore::Frame::isDisconnected):
  40846. (WebCore::Frame::setIsDisconnected):
  40847. (WebCore::Frame::excludeFromTextSearch):
  40848. (WebCore::Frame::setExcludeFromTextSearch):
  40849. (WebCore::Frame::selectionBounds):
  40850. (WebCore::Frame::selectionTextRects):
  40851. (WebCore::Frame::isFrameSet):
  40852. (WebCore::Frame::currentForm):
  40853. (WebCore::Frame::forceLayout):
  40854. (WebCore::Frame::sendScrollEvent):
  40855. (WebCore::Frame::clearTimers):
  40856. (WebCore::Frame::styleForSelectionStart):
  40857. (WebCore::Frame::inViewSourceMode):
  40858. (WebCore::Frame::setInViewSourceMode):
  40859. (WebCore::Frame::markAllMatchesForText):
  40860. (WebCore::Frame::markedTextMatchesAreHighlighted):
  40861. (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
  40862. (WebCore::Frame::tree):
  40863. (WebCore::Frame::setDOMWindow):
  40864. (WebCore::Frame::domWindow):
  40865. (WebCore::Frame::clearFormerDOMWindow):
  40866. (WebCore::Frame::page):
  40867. (WebCore::Frame::eventHandler):
  40868. (WebCore::Frame::pageDestroyed):
  40869. (WebCore::Frame::disconnectOwnerElement):
  40870. (WebCore::Frame::documentAtPoint):
  40871. * page/Frame.h:
  40872. * page/FramePrivate.h: Removed.
  40873. * page/FrameTree.h:
  40874. * page/chromium/FrameChromium.cpp:
  40875. * page/mac/FrameMac.mm:
  40876. (WebCore::Frame::imageFromRect):
  40877. (WebCore::Frame::selectionImage):
  40878. (WebCore::Frame::snapshotDragImage):
  40879. (WebCore::Frame::nodeImage):
  40880. (WebCore::Frame::setUserStyleSheetLocation):
  40881. (WebCore::Frame::setUserStyleSheet):
  40882. * page/qt/FrameQt.cpp:
  40883. (WebCore::Frame::setUserStyleSheetLocation):
  40884. (WebCore::Frame::setUserStyleSheet):
  40885. * page/win/FrameCGWin.cpp:
  40886. (WebCore::Frame::nodeImage):
  40887. * page/win/FrameWin.cpp:
  40888. 2009-01-18 Eric Carlson <eric.carlson@apple.com>
  40889. Build fix for !ENABLE(VIDEO) following r40016.
  40890. * rendering/RenderSlider.cpp:
  40891. (WebCore::RenderSlider::mouseEventIsInThumb):
  40892. 2009-01-17 Steve Falkenburg <sfalken@apple.com>
  40893. Build fix.
  40894. 2009-01-17 David Hyatt <hyatt@apple.com>
  40895. Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
  40896. on Node is now non-virtual and just checks a bit that is set at construction time by Text.
  40897. Reviewed by Sam Weinig
  40898. * dom/CharacterData.cpp:
  40899. (WebCore::CharacterData::CharacterData):
  40900. * dom/CharacterData.h:
  40901. * dom/EventTargetNode.cpp:
  40902. (WebCore::EventTargetNode::EventTargetNode):
  40903. * dom/EventTargetNode.h:
  40904. * dom/Node.cpp:
  40905. (WebCore::Node::Node):
  40906. * dom/Node.h:
  40907. (WebCore::Node::isTextNode):
  40908. (WebCore::Node::isAttributeNode):
  40909. * dom/Text.cpp:
  40910. (WebCore::Text::Text):
  40911. * dom/Text.h:
  40912. 2009-01-17 David Hyatt <hyatt@apple.com>
  40913. Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
  40914. replacement themselves, the exact transformation is instead done by the encoding (indirectly through
  40915. a method on Document).
  40916. These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
  40917. a slight speedup, and also allow encodings to do future alterations to displayed string content without
  40918. having to patch call sites again.
  40919. Reviewed by Oliver Hunt
  40920. * WebCore.base.exp:
  40921. * dom/Document.cpp:
  40922. * dom/Document.h:
  40923. (WebCore::Document::displayStringModifiedByEncoding):
  40924. (WebCore::Document::displayBufferModifiedByEncoding):
  40925. * editing/Editor.cpp:
  40926. (WebCore::Editor::addToKillRing):
  40927. * editing/TextIterator.cpp:
  40928. (WebCore::plainTextToMallocAllocatedBuffer):
  40929. (WebCore::plainText):
  40930. * editing/TextIterator.h:
  40931. * html/HTMLOptGroupElement.cpp:
  40932. (WebCore::HTMLOptGroupElement::groupLabelText):
  40933. * html/HTMLOptionElement.cpp:
  40934. (WebCore::HTMLOptionElement::text):
  40935. * loader/DocumentLoader.cpp:
  40936. (WebCore::canonicalizedTitle):
  40937. * page/Chrome.cpp:
  40938. (WebCore::displayString):
  40939. (WebCore::Chrome::runJavaScriptAlert):
  40940. (WebCore::Chrome::runJavaScriptConfirm):
  40941. (WebCore::Chrome::runJavaScriptPrompt):
  40942. (WebCore::Chrome::setStatusbarText):
  40943. * page/Frame.cpp:
  40944. (WebCore::Frame::shouldClose):
  40945. * page/Frame.h:
  40946. * platform/mac/PasteboardMac.mm:
  40947. (WebCore::Pasteboard::writeSelection):
  40948. * platform/text/TextCodecICU.cpp:
  40949. (WebCore::TextCodecICU::encode):
  40950. * platform/text/TextEncoding.cpp:
  40951. (WebCore::TextEncoding::TextEncoding):
  40952. * platform/text/TextEncoding.h:
  40953. (WebCore::TextEncoding::displayString):
  40954. (WebCore::TextEncoding::displayBuffer):
  40955. * rendering/HitTestResult.cpp:
  40956. (WebCore::displayString):
  40957. * rendering/RenderImage.cpp:
  40958. (WebCore::RenderImage::paintReplaced):
  40959. * rendering/RenderObject.cpp:
  40960. * rendering/RenderObject.h:
  40961. * rendering/RenderText.cpp:
  40962. (WebCore::RenderText::RenderText):
  40963. (WebCore::RenderText::setTextInternal):
  40964. * rendering/RenderTextControl.cpp:
  40965. (WebCore::RenderTextControl::setInnerTextValue):
  40966. (WebCore::RenderTextControl::finishText):
  40967. 2009-01-17 Eric Carlson <eric.carlson@apple.com>
  40968. Reviewed by Adele Peterson
  40969. Complete <rdar://problem/6293969>
  40970. * DerivedSources.make: include mediaControlsQT.css for Mac build.
  40971. * WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
  40972. * css/CSSPrimitiveValueMappings.h:
  40973. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart,
  40974. CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
  40975. * css/CSSSelector.cpp:
  40976. (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
  40977. * css/CSSSelector.h:
  40978. (WebCore::CSSSelector::): Ditto.
  40979. * css/CSSStyleSelector.cpp:
  40980. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media
  40981. controller element styles
  40982. * css/CSSValueKeywords.in: add keywords for new media time display controls
  40983. * css/mediaControls.css: adjust css for new control elements
  40984. * css/mediaControlsQT.css: Added.
  40985. * platform/ThemeTypes.h:
  40986. (WebCore::): add media time display controls to ControlPart
  40987. * platform/mac/WebCoreSystemInterface.h:
  40988. * platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
  40989. * rendering/MediaControlElements.cpp:
  40990. (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added
  40991. (WebCore::MediaTextDisplayElement::attachToParent): Added
  40992. (WebCore::MediaTextDisplayElement::update): Added
  40993. (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added
  40994. (WebCore::MediaControlInputElement::MediaControlInputElement): Added
  40995. (WebCore::MediaControlInputElement::hitTest): Added
  40996. (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when
  40997. dragging the thumb
  40998. * rendering/MediaControlElements.h:
  40999. (WebCore::): Add MediaTextDisplayElement
  41000. * rendering/RenderMedia.cpp:
  41001. (WebCore::RenderMedia::createTimelineContainer): Added
  41002. (WebCore::RenderMedia::createTimeline): Parent is now the timeline container
  41003. (WebCore::RenderMedia::createCurrentTimeDisplay): Added
  41004. (WebCore::RenderMedia::createTimeRemainingDisplay): Added
  41005. (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update
  41006. timer when the time display elements are not visible
  41007. (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes
  41008. (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not
  41009. visible. Display time remaining as well as current time.
  41010. (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when
  41011. visibility changes
  41012. (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
  41013. as we can't assume that all controls are rectangular
  41014. * rendering/RenderMedia.h: Updated
  41015. * rendering/RenderSlider.cpp:
  41016. (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call
  41017. element hitTest() method instead of assuming it is rectangular
  41018. * rendering/RenderSlider.h: make mouseEventIsInThumb virtual
  41019. * rendering/RenderTheme.cpp:
  41020. (WebCore::RenderTheme::paint): Deal with time display and timeline container
  41021. * rendering/RenderTheme.h:
  41022. (WebCore::RenderTheme::paintMediaTimelineContainer): Updated
  41023. (WebCore::RenderTheme::paintMediaCurrentTime): Added
  41024. (WebCore::RenderTheme::paintMediaTimeRemaining): Added
  41025. * rendering/RenderThemeMac.h: Updated
  41026. * rendering/RenderThemeMac.mm:
  41027. (WebCore::):
  41028. (WebCore::mediaControllerTheme):
  41029. (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb
  41030. size when appropriate
  41031. (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function
  41032. (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
  41033. (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
  41034. (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
  41035. (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
  41036. (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
  41037. (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
  41038. (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added
  41039. (WebCore::RenderThemeMac::paintMediaCurrentTime): Added
  41040. (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added
  41041. (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added
  41042. (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
  41043. * rendering/style/RenderStyle.h: Updated
  41044. (WebCore::):
  41045. 2009-01-17 David Hyatt <hyatt@apple.com>
  41046. Inline a few methods in FrameView for speed.
  41047. Reviewed by Oliver Hunt
  41048. * page/FrameView.cpp:
  41049. * page/FrameView.h:
  41050. (WebCore::FrameView::layoutCount):
  41051. (WebCore::FrameView::needsFullRepaint):
  41052. 2009-01-17 David Hyatt <hyatt@apple.com>
  41053. Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
  41054. the code that fetches and caches the document element into a separate function and inline the part that
  41055. does the null check and the return of the already-cached element.
  41056. Reviewed by Oliver Hunt
  41057. * dom/Document.cpp:
  41058. (WebCore::Document::cacheDocumentElement):
  41059. * dom/Document.h:
  41060. (WebCore::Document::documentElement):
  41061. 2009-01-17 David Hyatt <hyatt@apple.com>
  41062. Minor tweaks to RenderBox::styleChange to speed it up.
  41063. Reviewed by Oliver Hunt
  41064. * rendering/RenderBox.cpp:
  41065. (WebCore::RenderBox::styleDidChange):
  41066. 2009-01-17 David Hyatt <hyatt@apple.com>
  41067. Inline FrameLoader::client().
  41068. Reviewed by Oliver Hunt
  41069. * WebCore.base.exp:
  41070. * loader/FrameLoader.cpp:
  41071. * loader/FrameLoader.h:
  41072. (WebCore::FrameLoader::client):
  41073. 2009-01-17 David Hyatt <hyatt@apple.com>
  41074. Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
  41075. than needlessly creating a rect.
  41076. Reviewed by Oliver Hunt
  41077. * loader/CachedImage.cpp:
  41078. (WebCore::CachedImage::addClient):
  41079. * platform/graphics/Image.cpp:
  41080. * platform/graphics/Image.h:
  41081. (WebCore::Image::isNull):
  41082. (WebCore::Image::rect):
  41083. (WebCore::Image::width):
  41084. (WebCore::Image::height):
  41085. 2009-01-17 David Hyatt <hyatt@apple.com>
  41086. Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.
  41087. Reviewed by Oliver Hunt
  41088. * css/CSSParserValues.cpp:
  41089. (WebCore::CSSParserValueList::addValue):
  41090. 2009-01-17 David Hyatt <hyatt@apple.com>
  41091. Inline Document::inPageCache(), since - because of animation code - it is now called every time
  41092. styles change on any element and so is now super-hot.
  41093. Reviewed by Oliver Hunt
  41094. * dom/Document.cpp:
  41095. * dom/Document.h:
  41096. (WebCore::Document::inPageCache):
  41097. 2009-01-16 David Hyatt <hyatt@apple.com>
  41098. Take Font out of the GraphicsContext. Fonts are moderately expensive to both compare and to assign to.
  41099. The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
  41100. and was also causing expensive comparison checks to be made before doing alterations of the Font in the
  41101. GraphicsContext.
  41102. A font must now be passed as a parameter to all text drawing functions.
  41103. Reviewed by Oliver Hunt
  41104. * html/CanvasRenderingContext2D.cpp:
  41105. (WebCore::CanvasRenderingContext2D::setFont):
  41106. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  41107. * platform/graphics/GraphicsContext.cpp:
  41108. (WebCore::GraphicsContext::drawText):
  41109. (WebCore::GraphicsContext::drawBidiText):
  41110. (WebCore::GraphicsContext::drawHighlightForText):
  41111. * platform/graphics/GraphicsContext.h:
  41112. * platform/graphics/GraphicsContextPrivate.h:
  41113. * platform/graphics/qt/GraphicsContextQt.cpp:
  41114. * rendering/EllipsisBox.cpp:
  41115. (WebCore::EllipsisBox::paint):
  41116. * rendering/InlineTextBox.cpp:
  41117. (WebCore::paintTextWithShadows):
  41118. (WebCore::InlineTextBox::paint):
  41119. (WebCore::InlineTextBox::paintSelection):
  41120. (WebCore::InlineTextBox::paintCompositionBackground):
  41121. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  41122. (WebCore::InlineTextBox::paintTextMatchMarker):
  41123. (WebCore::InlineTextBox::paintDocumentMarkers):
  41124. * rendering/InlineTextBox.h:
  41125. * rendering/RenderFileUploadControl.cpp:
  41126. (WebCore::RenderFileUploadControl::paintObject):
  41127. * rendering/RenderImage.cpp:
  41128. (WebCore::RenderImage::paintReplaced):
  41129. * rendering/RenderListBox.cpp:
  41130. (WebCore::RenderListBox::paintItemForeground):
  41131. * rendering/RenderListMarker.cpp:
  41132. (WebCore::RenderListMarker::paint):
  41133. * rendering/SVGInlineTextBox.cpp:
  41134. (WebCore::SVGInlineTextBox::paintCharacters):
  41135. (WebCore::SVGInlineTextBox::paintSelection):
  41136. * rendering/SVGInlineTextBox.h:
  41137. * svg/SVGFont.cpp:
  41138. (WebCore::Font::drawTextUsingSVGFont):
  41139. 2009-01-16 David Hyatt <hyatt@apple.com>
  41140. Fix a regression from the virtualContinuation()/continuation() split where I accidentally changed
  41141. two if statements.
  41142. Reviewed by Oliver Hunt
  41143. * rendering/RenderObject.cpp:
  41144. (WebCore::RenderObject::absoluteRects):
  41145. (WebCore::RenderObject::absoluteQuads):
  41146. 2009-01-16 David Hyatt <hyatt@apple.com>
  41147. Fix a regression from my before/after optimization. Make sure the <q> element puts the document
  41148. into a mode where it will respect before/after rules, since <q> implicitly uses such rules.
  41149. Make sure view source mode documents also turn on before/after rules, since they are used there also.
  41150. Reviewed by Oliver Hunt
  41151. * html/HTMLElementFactory.cpp:
  41152. (WebCore::quoteConstructor):
  41153. * html/HTMLViewSourceDocument.cpp:
  41154. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  41155. 2009-01-16 Chris Fleizach <cfleizach@apple.com>
  41156. Reviewed by Oliver Hunt.
  41157. Bug 23397: AXURL is not reported for <INPUT type="image"> elements
  41158. https://bugs.webkit.org/show_bug.cgi?id=23397
  41159. Report an AXURL for inputs that have an image type.
  41160. Test: accessibility/input-image-url.html
  41161. * page/AccessibilityObject.h:
  41162. (WebCore::AccessibilityObject::isInputImage):
  41163. * page/AccessibilityRenderObject.cpp:
  41164. (WebCore::AccessibilityRenderObject::isInputImage):
  41165. (WebCore::AccessibilityRenderObject::url):
  41166. * page/AccessibilityRenderObject.h:
  41167. * page/mac/AccessibilityObjectWrapper.mm:
  41168. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  41169. 2009-01-16 Adele Peterson <adele@apple.com>
  41170. Windows build fix.
  41171. * loader/FrameLoader.cpp: (WebCore::FrameLoader::logCanCachePageDecision):
  41172. 2009-01-16 Steve Falkenburg <sfalken@apple.com>
  41173. <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
  41174. This was caused by mismatched ENABLE definitions across WebCore and WebKit.
  41175. Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
  41176. In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
  41177. to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
  41178. Our Windows ENABLE flags now match Mac.
  41179. Reviewed by Adele Peterson.
  41180. * WebCore.vcproj/WebCore.vcproj:
  41181. * WebCore.vcproj/build-generated-files.sh:
  41182. 2009-01-16 Mark Rowe <mrowe@apple.com>
  41183. 40,000!
  41184. * ChangeLog: Point out revision 40,000.
  41185. 2009-01-16 Eric Seidel <eric@webkit.org>
  41186. Reviewed by Justin Garcia.
  41187. Make surroundNodeRangeWithElement call insertNodeBefore implicitly
  41188. Make insertNodeBefore take PassRefPtr
  41189. Clean up the use of PassRefPtr vs. raw pointers a few places in the editing code.
  41190. https://bugs.webkit.org/show_bug.cgi?id=23389
  41191. * editing/ApplyStyleCommand.cpp:
  41192. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  41193. (WebCore::ApplyStyleCommand::applyTextDecorationStyle):
  41194. (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
  41195. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  41196. * editing/ApplyStyleCommand.h:
  41197. * editing/CompositeEditCommand.cpp:
  41198. (WebCore::CompositeEditCommand::insertNodeAt):
  41199. * editing/IndentOutdentCommand.cpp:
  41200. (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
  41201. * editing/InsertLineBreakCommand.cpp:
  41202. (WebCore::InsertLineBreakCommand::doApply):
  41203. * editing/InsertParagraphSeparatorCommand.cpp:
  41204. (WebCore::InsertParagraphSeparatorCommand::doApply):
  41205. * editing/InsertTextCommand.cpp:
  41206. (WebCore::InsertTextCommand::insertTab):
  41207. * editing/ModifySelectionListLevel.cpp:
  41208. (WebCore::IncreaseSelectionListLevelCommand::doApply):
  41209. * editing/ReplaceSelectionCommand.cpp:
  41210. (WebCore::ReplacementFragment::removeNodePreservingChildren):
  41211. (WebCore::ReplacementFragment::insertNodeBefore):
  41212. (WebCore::ReplacementFragment::removeInterchangeNodes):
  41213. (WebCore::ReplaceSelectionCommand::doApply):
  41214. (WebCore::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted):
  41215. (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
  41216. (WebCore::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted):
  41217. * editing/ReplaceSelectionCommand.h:
  41218. 2009-01-16 Chris Fleizach <cfleizach@apple.com>
  41219. Reviewed by Oliver Hunt.
  41220. Bug 23393: TextField has AXTitle and AXTitleUIElement
  41221. https://bugs.webkit.org/show_bug.cgi?id=23393
  41222. Test: accessibility/double-title.html
  41223. * page/AccessibilityRenderObject.cpp:
  41224. (WebCore::AccessibilityRenderObject::title):
  41225. 2009-01-16 Adam Treat <adam.treat@torchmobile.com>
  41226. The correct build fix for all platforms.
  41227. * platform/graphics/Font.h:
  41228. 2009-01-16 Adam Treat <adam.treat@torchmobile.com>
  41229. Fix the Qt build.
  41230. * platform/graphics/Font.h:
  41231. 2009-01-16 David Hyatt <hyatt@apple.com>
  41232. Add a new flag (similar to first-line and first-letter) to Document to track whether any before/after rules
  41233. are being used. If not, don't waste time probing for those pseudo element styles.
  41234. Reviewed by Sam Weinig
  41235. * css/CSSGrammar.y:
  41236. * dom/Document.cpp:
  41237. (WebCore::Document::Document):
  41238. * dom/Document.h:
  41239. (WebCore::Document::usesBeforeAfterRules):
  41240. (WebCore::Document::setUsesBeforeAfterRules):
  41241. * rendering/RenderBlock.cpp:
  41242. (WebCore::RenderBlock::styleDidChange):
  41243. * rendering/RenderContainer.cpp:
  41244. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  41245. * rendering/RenderInline.cpp:
  41246. (WebCore::RenderInline::styleDidChange):
  41247. (WebCore::RenderInline::addChildToFlow):
  41248. (WebCore::RenderInline::splitInlines):
  41249. 2009-01-16 Dmitry Titov <dimich@chromium.org>
  41250. Reviewed by Alp Toker.
  41251. https://bugs.webkit.org/show_bug.cgi?id=23394
  41252. Remove unnecessary calls to setDeferringTimers().
  41253. Use of this function was obsoleted by better handling of EINTR.
  41254. * platform/network/curl/ResourceHandleManager.cpp:
  41255. (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.
  41256. 2009-01-16 David Hyatt <hyatt@apple.com>
  41257. Fix badness with the cursor CSS property. For all links and form controls, resetting to a value of auto
  41258. was resulting in the creation of a cursor list. clearCursorList was creating a new list rather than just
  41259. nulling out the pointer. Since addCursor already lazily recreates the list, in the case of simple cursor types,
  41260. the clear method was wastefully creating a completely unnecessary list for all of these elements.
  41261. Also optimized the setting of simple cursor values to not alter the RenderStyle's cursor setting if it is already
  41262. set to the same value. Since this is the common case, it prevents a fault and copy of StyleInheritedData for
  41263. all links and form controls.
  41264. This is a PLT speedup.
  41265. Reviewed by Oliver Hunt
  41266. * css/CSSStyleSelector.cpp:
  41267. (WebCore::CSSStyleSelector::applyProperty):
  41268. * rendering/style/RenderStyle.cpp:
  41269. (WebCore::RenderStyle::clearCursorList):
  41270. 2009-01-16 Darin Fisher <darin@chromium.org>
  41271. Reviewed by Darin Adler.
  41272. https://bugs.webkit.org/show_bug.cgi?id=23384
  41273. PLATFORM(CHROMIUM) needs to delegate BackForwardList.cpp methods to the embedder
  41274. * history/BackForwardList.h:
  41275. (WebCore::BackForwardListClient::~BackForwardListClient):
  41276. (WebCore::BackForwardList::setClient):
  41277. * history/BackForwardListChromium.cpp: Added.
  41278. 2009-01-16 Dan Bernstein <mitz@apple.com>
  41279. Reviewed by Kevin Decker and Adam Roben.
  41280. - fix a regression that resulted in a crash when plug-ins were
  41281. disabled.
  41282. * rendering/RenderPartObject.cpp:
  41283. (WebCore::RenderPartObject::updateWidget): Added a null check.
  41284. 2009-01-16 David Hyatt <hyatt@apple.com>
  41285. Split continuation() into virtual and non-virtual versions so that the non-virtual version can
  41286. be used whereever possible. Eventually the virtual method can be eliminated completely.
  41287. Reviewed by Sam Weinig and Oliver Hunt
  41288. * html/HTMLAnchorElement.cpp:
  41289. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  41290. * page/AccessibilityRenderObject.cpp:
  41291. (WebCore::AccessibilityRenderObject::anchorElement):
  41292. * rendering/InlineFlowBox.cpp:
  41293. (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  41294. (WebCore::InlineFlowBox::paint):
  41295. * rendering/RenderBlock.cpp:
  41296. (WebCore::RenderBlock::removeChild):
  41297. * rendering/RenderContainer.cpp:
  41298. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  41299. * rendering/RenderFlow.h:
  41300. (WebCore::RenderFlow::virtualContinuation):
  41301. (WebCore::RenderFlow::continuation):
  41302. * rendering/RenderInline.cpp:
  41303. (WebCore::RenderInline::positionForCoordinates):
  41304. * rendering/RenderObject.cpp:
  41305. (WebCore::RenderObject::absoluteRects):
  41306. (WebCore::RenderObject::absoluteQuads):
  41307. (WebCore::RenderObject::addFocusRingRects):
  41308. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  41309. (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
  41310. (WebCore::RenderObject::handleDynamicFloatPositionChange):
  41311. (WebCore::RenderObject::hoverAncestor):
  41312. (WebCore::RenderObject::updateDragState):
  41313. (WebCore::RenderObject::updateHitTestResult):
  41314. (WebCore::RenderObject::getTextDecorationColors):
  41315. (WebCore::RenderObject::adjustRectForOutlineAndShadow):
  41316. * rendering/RenderObject.h:
  41317. (WebCore::RenderObject::virtualContinuation):
  41318. 2009-01-16 David Hyatt <hyatt@apple.com>
  41319. Inline the methods of Font for obtaining metrics such as ascent, descent and line spacing.
  41320. Reviewed by ggaren
  41321. * platform/graphics/Font.cpp:
  41322. * platform/graphics/Font.h:
  41323. (WebCore::Font::width):
  41324. (WebCore::Font::ascent):
  41325. (WebCore::Font::descent):
  41326. (WebCore::Font::lineSpacing):
  41327. (WebCore::Font::lineGap):
  41328. (WebCore::Font::xHeight):
  41329. (WebCore::Font::unitsPerEm):
  41330. (WebCore::Font::spaceWidth):
  41331. 2009-01-16 Sam Weinig <sam@webkit.org>
  41332. Reviewed by David Hyatt.
  41333. Fix for https://bugs.webkit.org/show_bug.cgi?id=23388
  41334. Remove FrameViewPrivate
  41335. Removes an indirection and is a small speedup on PLT.
  41336. * page/FrameView.cpp:
  41337. (WebCore::FrameView::FrameView):
  41338. (WebCore::FrameView::~FrameView):
  41339. (WebCore::FrameView::reset):
  41340. (WebCore::FrameView::resetScrollbars):
  41341. (WebCore::FrameView::init):
  41342. (WebCore::FrameView::clear):
  41343. (WebCore::FrameView::didFirstLayout):
  41344. (WebCore::FrameView::initScrollbars):
  41345. (WebCore::FrameView::updateDefaultScrollbarState):
  41346. (WebCore::FrameView::setCanHaveScrollbars):
  41347. (WebCore::FrameView::applyOverflowToViewport):
  41348. (WebCore::FrameView::layoutCount):
  41349. (WebCore::FrameView::needsFullRepaint):
  41350. (WebCore::FrameView::layoutRoot):
  41351. (WebCore::FrameView::layout):
  41352. (WebCore::FrameView::setMediaType):
  41353. (WebCore::FrameView::mediaType):
  41354. (WebCore::FrameView::useSlowRepaints):
  41355. (WebCore::FrameView::setUseSlowRepaints):
  41356. (WebCore::FrameView::addSlowRepaintObject):
  41357. (WebCore::FrameView::removeSlowRepaintObject):
  41358. (WebCore::FrameView::scrollRectIntoViewRecursively):
  41359. (WebCore::FrameView::setScrollPosition):
  41360. (WebCore::FrameView::repaintContentRectangle):
  41361. (WebCore::FrameView::beginDeferredRepaints):
  41362. (WebCore::FrameView::endDeferredRepaints):
  41363. (WebCore::FrameView::scheduleRelayout):
  41364. (WebCore::FrameView::scheduleRelayoutOfSubtree):
  41365. (WebCore::FrameView::layoutPending):
  41366. (WebCore::FrameView::needsLayout):
  41367. (WebCore::FrameView::unscheduleRelayout):
  41368. (WebCore::FrameView::isTransparent):
  41369. (WebCore::FrameView::setTransparent):
  41370. (WebCore::FrameView::baseBackgroundColor):
  41371. (WebCore::FrameView::setBaseBackgroundColor):
  41372. (WebCore::FrameView::shouldUpdateWhileOffscreen):
  41373. (WebCore::FrameView::setShouldUpdateWhileOffscreen):
  41374. (WebCore::FrameView::scheduleEvent):
  41375. (WebCore::FrameView::pauseScheduledEvents):
  41376. (WebCore::FrameView::resumeScheduledEvents):
  41377. (WebCore::FrameView::performPostLayoutTasks):
  41378. (WebCore::FrameView::updateOverflowStatus):
  41379. (WebCore::FrameView::dispatchScheduledEvents):
  41380. (WebCore::FrameView::wasScrolledByUser):
  41381. (WebCore::FrameView::setWasScrolledByUser):
  41382. (WebCore::FrameView::paintContents):
  41383. (WebCore::FrameView::setPaintRestriction):
  41384. (WebCore::FrameView::isPainting):
  41385. (WebCore::FrameView::setNodeToDraw):
  41386. * page/FrameView.h:
  41387. (WebCore::FrameView::setIsVisuallyNonEmpty): Inline.
  41388. 2009-01-14 Julien Chaffraix <jchaffraix@webkit.org>
  41389. Reviewed by Darin Adler.
  41390. Bug 23237: Some HTML constructors in HTMLElementFactory needs
  41391. an HTMLFormElement argument
  41392. - Added 'constructorNeedsFormElement' parameter to make_names.pl to account
  41393. for HTML form elements.
  41394. - Added the new information to HTMLTagNames.in.
  41395. * dom/make_names.pl:
  41396. * html/HTMLTagNames.in:
  41397. 2009-01-16 David Hyatt <hyatt@apple.com>
  41398. Eliminate a bunch of save/restore pairs from commonly used GraphicsContext methods. The most common reason
  41399. for needing save/restore in the line-drawing methods was antialiasing, so this has now been made part of
  41400. the cross-platform graphics state. By being able to query for the current antialiasing setting, antialiasing
  41401. can be temporarily changed and then restored back to the real value without needing to do a save/restore.
  41402. The line drawing code also set the fill color to the stroke color and relied on save/restore to prevent
  41403. a permanent mutation of the fill color in the CGContext. The new code just restores the fill color back
  41404. to its original value without doing the much more expensive save/restore.
  41405. Reviewed by Oliver Hunt
  41406. * platform/graphics/GraphicsContext.cpp:
  41407. (WebCore::GraphicsContext::setShouldAntialias):
  41408. (WebCore::GraphicsContext::shouldAntialias):
  41409. * platform/graphics/GraphicsContext.h:
  41410. * platform/graphics/GraphicsContextPrivate.h:
  41411. (WebCore::GraphicsContextState::GraphicsContextState):
  41412. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  41413. (WebCore::GraphicsContext::setPlatformShouldAntialias):
  41414. * platform/graphics/cg/GraphicsContextCG.cpp:
  41415. (WebCore::GraphicsContext::drawLine):
  41416. (WebCore::GraphicsContext::drawConvexPolygon):
  41417. (WebCore::GraphicsContext::drawLineForText):
  41418. (WebCore::GraphicsContext::setPlatformShouldAntialias):
  41419. * platform/graphics/qt/GraphicsContextQt.cpp:
  41420. (WebCore::GraphicsContext::setPlatformShouldAntialias):
  41421. * platform/graphics/skia/GraphicsContextSkia.cpp:
  41422. (WebCore::GraphicsContext::setPlatformShouldAntialias):
  41423. * platform/graphics/wx/GraphicsContextWx.cpp:
  41424. (WebCore::GraphicsContext::setPlatformShouldAntialias):
  41425. * rendering/RenderPath.cpp:
  41426. (WebCore::RenderPath::paint):
  41427. 2009-01-16 Anders Carlsson <andersca@apple.com>
  41428. Reviewed by Sam Weinig.
  41429. Clean up the bridge code and get rid of Field::name() and Method::name().
  41430. * bridge/c/c_instance.cpp:
  41431. (JSC::Bindings::CInstance::invokeMethod):
  41432. * bridge/c/c_runtime.cpp:
  41433. * bridge/c/c_runtime.h:
  41434. (JSC::Bindings::CField::identifier):
  41435. (JSC::Bindings::CMethod::identifier):
  41436. * bridge/jni/jni_class.cpp:
  41437. (JavaClass::JavaClass):
  41438. * bridge/jni/jni_instance.cpp:
  41439. (JavaInstance::invokeMethod):
  41440. * bridge/jni/jni_runtime.cpp:
  41441. (JavaField::valueFromInstance):
  41442. (JavaField::setValueToInstance):
  41443. (JavaMethod::methodID):
  41444. * bridge/jni/jni_runtime.h:
  41445. (JSC::Bindings::JavaField::name):
  41446. (JSC::Bindings::JavaMethod::name):
  41447. * bridge/objc/objc_class.mm:
  41448. (JSC::Bindings::ObjcClass::methodsNamed):
  41449. * bridge/objc/objc_instance.mm:
  41450. (ObjcInstance::invokeMethod):
  41451. * bridge/objc/objc_runtime.h:
  41452. (JSC::Bindings::ObjcMethod::isFallbackMethod):
  41453. (JSC::Bindings::ObjcMethod::selector):
  41454. * bridge/objc/objc_runtime.mm:
  41455. (JSC::Bindings::ObjcMethod::ObjcMethod):
  41456. (JSC::Bindings::ObjcMethod::getMethodSignature):
  41457. (JSC::Bindings::ObjcField::ObjcField):
  41458. (JSC::Bindings::ObjcField::valueFromInstance):
  41459. (JSC::Bindings::ObjcField::setValueToInstance):
  41460. (JSC::Bindings::callObjCFallbackObject):
  41461. * bridge/runtime.h:
  41462. 2009-01-16 David Hyatt <hyatt@apple.com>
  41463. Optimize RenderText::styleDidChange. Don't call the base class, which does extra meaningless work.
  41464. Instead just do the one check we need to do (for a diff of layout) and mark dirty as appropriate.
  41465. Clean up the base class method also to just bail early if no m_parent is set instead of repeatedly checking
  41466. for the existence of m_parent in each if clause.
  41467. Reviewed by Darin Adler
  41468. * rendering/RenderObject.cpp:
  41469. (WebCore::RenderObject::styleDidChange):
  41470. * rendering/RenderText.cpp:
  41471. (WebCore::RenderText::styleDidChange):
  41472. 2009-01-16 Chris Fleizach <cfleizach@apple.com>
  41473. Reviewed by Beth Dakin.
  41474. Bug 23387: AX hierarchy is incorrect when iframes are present
  41475. https://bugs.webkit.org/show_bug.cgi?id=23387
  41476. The AX hierarchy is incorrect when iframes are present.
  41477. Test: accessibility/iframe-bastardization.html
  41478. * page/mac/AccessibilityObjectWrapper.mm:
  41479. (-[AccessibilityObjectWrapper renderWidgetChildren]):
  41480. 2009-01-16 Brady Eidson <beidson@apple.com>
  41481. Reviewed by Darin Adler
  41482. <rdar://problem/3541409> - Split up some back/forward cache decision making and add detailed logging to
  41483. better understand what the common disqualifiers are.
  41484. * loader/FrameLoader.cpp:
  41485. (WebCore::FrameLoader::canCachePageContainingThisFrame):
  41486. (WebCore::FrameLoader::canCachePage): Split off what will be per-frame decision making into canCacheSubframe.
  41487. (WebCore::FrameLoader::logCanCachePageDecision): Detailed logging about why a page may not be considered for
  41488. the back/forward cache.
  41489. (WebCore::FrameLoader::logCanCacheFrameDecision): Same detailed logging on the per-frame basis.
  41490. (WebCore::FrameLoader::commitProvisionalLoad): Move the m_client->canCachePage() call into canCachePageContainingThisFrame().
  41491. * loader/FrameLoader.h:
  41492. 2009-01-16 Chris Marrin <cmarrin@apple.com>
  41493. Reviewed by David Hyatt.
  41494. Test: transitions/hang-with-bad-transition-list.html
  41495. Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
  41496. This was happening because I was calling setChanged() from inside updateRendering()
  41497. which causes an infinite loop. I fixed this by deferring the setChanged to the next
  41498. run loop iteration. That made it not infinite loop, but it still retriggers the
  41499. transition forever. The problem is that there is both an 'all' and specific transition
  41500. on 'opacity'. This tickled a bug in AnimationController which causes the opacity
  41501. transition to get constantly cancelled and then retriggered. The problem is that
  41502. the specific opacity transition has a duration of 0. I got rid of the logic to
  41503. flush out 0 duration transitions and it is no longer constantly triggered. The
  41504. logic to flush them was just an optimization, and you really need to keep them
  41505. around to make the logic to override earlier animations by later ones work. And there is
  41506. very little overhead in this case anyway, so the optimization was not that useful.
  41507. I made a LayoutTest from the original testcase which tests both the infinite
  41508. loop and constantly triggering animation cases.
  41509. * page/animation/AnimationBase.cpp:
  41510. (WebCore::AnimationBase::updateStateMachine):
  41511. * page/animation/AnimationController.cpp:
  41512. (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
  41513. (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
  41514. (WebCore::AnimationController::addNodeChangeToDispatch):
  41515. * page/animation/AnimationController.h:
  41516. * page/animation/CompositeAnimation.cpp:
  41517. (WebCore::CompositeAnimationPrivate::updateTransitions):
  41518. * rendering/style/RenderStyle.cpp:
  41519. (WebCore::RenderStyle::adjustAnimations):
  41520. (WebCore::RenderStyle::adjustTransitions):
  41521. 2009-01-16 Chris Fleizach <cfleizach@apple.com>
  41522. Reviewed by Darin Adler.
  41523. Bug 23385: crash at com.apple.WebCore WebCore::HTMLAnchorElement::isKeyboardFocusable
  41524. https://bugs.webkit.org/show_bug.cgi?id=23385
  41525. Option-tabbing through the page mentioned in the bug causes a crash
  41526. Test: fast/events/tab-crash-with-image-map.html
  41527. * html/HTMLAnchorElement.cpp:
  41528. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  41529. 2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>
  41530. Reviewed by Simon Hausmann.
  41531. [Qt] Fixes QString and 8-bit mix fixes.
  41532. Details: Make sure we use QLatin1String where appropriate (and don't
  41533. use QString when not necessary)
  41534. * platform/graphics/qt/ImageDecoderQt.cpp:
  41535. (WebCore::ImageDecoderQt::create):
  41536. * platform/graphics/qt/SimpleFontDataQt.cpp:
  41537. (WebCore::SimpleFontData::platformInit):
  41538. * platform/qt/FileSystemQt.cpp:
  41539. (WebCore::openTemporaryFile):
  41540. * platform/qt/LoggingQt.cpp:
  41541. (WebCore::InitializeLoggingChannelsIfNecessary):
  41542. * platform/qt/RenderThemeQt.cpp:
  41543. (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
  41544. * plugins/qt/PluginDataQt.cpp:
  41545. (WebCore::PluginData::initPlugins):
  41546. 2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
  41547. Reviewed by Adam Roben.
  41548. https://bugs.webkit.org/show_bug.cgi?id=22452
  41549. When plugins are disabled, plugin data should not be available for
  41550. the page. This ensures that navigator.plugins would not see the
  41551. additional MIME types supported by the plugins.
  41552. * page/Page.cpp:
  41553. (WebCore::Page::pluginData):
  41554. * loader/FrameLoader.cpp:
  41555. (WebCore::FrameLoader::shouldUsePlugin):
  41556. * rendering/RenderPartObject.cpp:
  41557. (WebCore::RenderPartObject::updateWidget):
  41558. 2009-01-15 Chris Marrin <cmarrin@apple.com>
  41559. Reviewed by Sam Weinig.
  41560. Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
  41561. Also fixed the test case to work on ppc.
  41562. * WebCore.xcodeproj/project.pbxproj:
  41563. 2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
  41564. Another attempt at fixing the Qt build.
  41565. * bridge/qt/qt_instance.cpp:
  41566. (JSC::Bindings::QtInstance::getInstance):
  41567. 2009-01-16 David Hyatt <hyatt@apple.com>
  41568. Fix for 1.85% PLT regression. Since asking if a frame is "complete" actually aggressively decodes
  41569. the frame, we add an optimization when advancing animations. If we have received all of the animated
  41570. image's data, then obviously we can go ahead and advance safely. This prevents the first draw of an image
  41571. from decoding two frames' worth of data in the case where all of the image's data has been received.
  41572. While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
  41573. as well. It's not immediately clear how that regression would be fixed, though, and it would likely be
  41574. a much smaller percentage of that overall uncached time.
  41575. Reviewed by Dan Bernstein
  41576. * platform/graphics/BitmapImage.cpp:
  41577. (WebCore::BitmapImage::startAnimation):
  41578. 2009-01-15 Alexey Proskuryakov <ap@webkit.org>
  41579. Reviewed by Anders Carlsson.
  41580. https://bugs.webkit.org/show_bug.cgi?id=23349
  41581. Don't store obsolete caches in disk storage
  41582. * loader/ResourceLoader.cpp:
  41583. (WebCore::ResourceLoader::ResourceLoader):
  41584. (WebCore::ResourceLoader::load):
  41585. (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
  41586. * loader/ResourceLoader.h:
  41587. Don't maintain m_wasLoadedFromApplicationCache, which was never used.
  41588. * loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
  41589. Assert that only implicit and dynamic resources can be added after the cache has been fully
  41590. loaded and stored to disk database.
  41591. * loader/appcache/ApplicationCacheGroup.cpp:
  41592. (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk
  41593. database, as this is now done whenever the cache becomes obsolete.
  41594. (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.
  41595. * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
  41596. A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed
  41597. the check to no longer rely on savedNewestCachePointer.
  41598. 2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>
  41599. <rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();
  41600. Reviewed by Timothy Hatcher.
  41601. * css/CSSSelector.cpp:
  41602. (WebCore::CSSSelector::selectorText):
  41603. 2009-01-15 Justin Garcia <justin.garcia@apple.com>
  41604. Reviewed by Oliver Hunt.
  41605. <rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break
  41606. If the range to style ended at [node, 0] or inside node (and if for some reason the node didn't get split),
  41607. applyInlineStyle would style node.
  41608. * editing/ApplyStyleCommand.cpp:
  41609. (WebCore::ApplyStyleCommand::applyInlineStyle): Rename pastLast to pastEndNode, since it doesn't come from
  41610. Range::pastLastNode() anymore. pastEndNode is the node after the last one that is fully selected, since
  41611. the work done in the loop that follows should only be performed on fully selected nodes.
  41612. * editing/InsertLineBreakCommand.cpp:
  41613. (WebCore::InsertLineBreakCommand::doApply): Explicitly handle insertion into containers and after non-text nodes.
  41614. Those were handled accidently before.
  41615. * editing/htmlediting.cpp:
  41616. (WebCore::caretMaxOffset): In various places we call this with a container and expect to be given the number
  41617. of children in that container, so I changed it to match that. RenderBR and RenderObject::caretMaxOffset() should
  41618. also be eliminated since maxDeepOffset handles non-text nodes.
  41619. 2009-01-15 Anders Carlsson <andersca@apple.com>
  41620. Reviewed by Geoffrey Garen.
  41621. Get rid of the dreaded BindingLanguage once and for all. Also get rid of Instance::getInstance.
  41622. * bridge/c/c_instance.h:
  41623. * bridge/jni/jni_instance.h:
  41624. * bridge/objc/objc_instance.h:
  41625. * bridge/qt/qt_instance.h:
  41626. * bridge/runtime.cpp:
  41627. * bridge/runtime.h:
  41628. * bridge/runtime_object.h:
  41629. 2009-01-15 David Hyatt <hyatt@apple.com>
  41630. Eliminate an extra virtual function call that occurs for every single RenderText by moving the SVG-specific
  41631. code that was placed into RenderText::styleDidChange into RenderSVGInlineText::styleDidChange.
  41632. Reviewed by Oliver Hunt
  41633. * rendering/RenderSVGInlineText.cpp:
  41634. (WebCore::RenderSVGInlineText::styleDidChange):
  41635. * rendering/RenderSVGInlineText.h:
  41636. * rendering/RenderText.cpp:
  41637. (WebCore::RenderText::styleDidChange):
  41638. 2009-01-15 Anders Carlsson <andersca@apple.com>
  41639. Another attempt at fixing the Qt build.
  41640. * bridge/qt/qt_instance.cpp:
  41641. (JSC::Bindings::QtInstance::getOwnPropertySlot):
  41642. (JSC::Bindings::QtInstance::put):
  41643. * bridge/qt/qt_instance.h:
  41644. * bridge/runtime.h:
  41645. (JSC::Bindings::Instance::getOwnPropertySlot):
  41646. (JSC::Bindings::Instance::put):
  41647. * bridge/runtime_object.cpp:
  41648. (JSC::RuntimeObjectImp::getOwnPropertySlot):
  41649. (JSC::RuntimeObjectImp::put):
  41650. 2009-01-15 Anders Carlsson <andersca@apple.com>
  41651. Reviewed by Darin Adler.
  41652. Add QtInstance::getInstance and start using it.
  41653. * bridge/qt/qt_instance.cpp:
  41654. (JSC::Bindings::QtRuntimeObjectImp::mark):
  41655. (JSC::Bindings::QtRuntimeObjectImp::classInfo):
  41656. (JSC::Bindings::):
  41657. (JSC::Bindings::QtInstance::getInstance):
  41658. * bridge/qt/qt_instance.h:
  41659. * bridge/qt/qt_runtime.cpp:
  41660. (JSC::Bindings::convertValueToQVariant):
  41661. 2009-01-15 Anders Carlsson <andersca@apple.com>
  41662. Reviewed by Sam Weinig.
  41663. Add the ability for Instance objects to override getOwnPropertySlot/put for runtime objects.
  41664. * bridge/qt/qt_instance.cpp:
  41665. (JSC::Bindings::QtInstance::getOwnPropertySlot):
  41666. (JSC::Bindings::QtInstance::put):
  41667. * bridge/qt/qt_instance.h:
  41668. * bridge/runtime.h:
  41669. (JSC::Bindings::Instance::getOwnPropertySlot):
  41670. (JSC::Bindings::Instance::put):
  41671. * bridge/runtime_object.cpp:
  41672. (JSC::RuntimeObjectImp::getOwnPropertySlot):
  41673. (JSC::RuntimeObjectImp::put):
  41674. 2009-01-15 Anders Carlsson <andersca@apple.com>
  41675. Fix the QT build.
  41676. * bridge/qt/qt_instance.cpp:
  41677. (JSC::Bindings::QtInstance::createRuntimeObject):
  41678. * bridge/qt/qt_instance.h:
  41679. 2009-01-15 David Hyatt <hyatt@apple.com>
  41680. Fix for <rdar://problem/6500278> REGRESSION: 3.5% of samples on iBench in WebCore::Frame::setZoomFactor
  41681. setZoomFactor was supposed to bail if both the zoom factor and mode were the same. The mode check was
  41682. buggy and doing the wrong thing.
  41683. Reviewed by Darin Adler
  41684. * page/Frame.cpp:
  41685. (WebCore::Frame::setZoomFactor):
  41686. 2009-01-15 Anders Carlsson <andersca@apple.com>
  41687. Reviewed by Geoffrey Garen.
  41688. Make Instance::createRuntimeObject a virtual function and override it for QtInstance.
  41689. * bindings/js/JSPluginElementFunctions.cpp:
  41690. (WebCore::getRuntimeObject):
  41691. * bridge/c/c_utility.cpp:
  41692. (JSC::Bindings::convertNPVariantToValue):
  41693. * bridge/jni/jni_instance.cpp:
  41694. (JavaInstance::invokeMethod):
  41695. * bridge/jni/jni_jsobject.mm:
  41696. (JavaJSObject::convertJObjectToValue):
  41697. * bridge/jni/jni_runtime.cpp:
  41698. (JavaField::valueFromInstance):
  41699. (JavaArray::valueAt):
  41700. * bridge/objc/objc_utility.mm:
  41701. (JSC::Bindings::convertObjcValueToValue):
  41702. * bridge/qt/qt_instance.cpp:
  41703. (JSC::Bindings::QtInstance::getRuntimeObject):
  41704. (JSC::Bindings::QtInstance::createRuntimeObject):
  41705. * bridge/qt/qt_instance.h:
  41706. * bridge/qt/qt_runtime.cpp:
  41707. (JSC::Bindings::convertQVariantToValue):
  41708. (JSC::Bindings::QtConnectionObject::execute):
  41709. * bridge/runtime.cpp:
  41710. (JSC::Bindings::Instance::createRuntimeObject):
  41711. * bridge/runtime.h:
  41712. 2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
  41713. Reviewed by Darin Adler.
  41714. https://bugs.webkit.org/show_bug.cgi?id=23354
  41715. Fix up graphics/chromium files to account for Uniscribe style scrubbing.
  41716. * platform/graphics/chromium/FontChromiumWin.cpp:
  41717. (WebCore::windowsCanHandleTextDrawing):
  41718. (WebCore::Font::selectionRectForComplexText):
  41719. (WebCore::Font::drawComplexText):
  41720. (WebCore::Font::floatWidthForComplexText):
  41721. (WebCore::Font::offsetForPositionForComplexText):
  41722. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
  41723. (WebCore::fillNonBMPGlyphs):
  41724. 2009-01-15 David Levin <levin@chromium.org>
  41725. Reviewed by Darin Adler.
  41726. https://bugs.webkit.org/show_bug.cgi?id=23333
  41727. Adjust due to a name change that happened in a WebKit.
  41728. * svg/graphics/skia/SVGPaintServerPatternSkia.cpp:
  41729. (WebCore::SVGPaintServerPattern::setup):
  41730. 2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
  41731. Reviewed by Eric Seidel.
  41732. https://bugs.webkit.org/show_bug.cgi?id=23340
  41733. Add remaining bits of graphics/chromium.
  41734. * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added.
  41735. (WebCore::scaleEmToUnits):
  41736. (WebCore::SimpleFontData::platformInit):
  41737. (WebCore::SimpleFontData::platformDestroy):
  41738. (WebCore::SimpleFontData::smallCapsFontData):
  41739. (WebCore::SimpleFontData::containsCharacters):
  41740. (WebCore::SimpleFontData::determinePitch):
  41741. (WebCore::SimpleFontData::platformWidthForGlyph):
  41742. * platform/graphics/chromium/SimpleFontDataLinux.cpp: Added.
  41743. (WebCore::SimpleFontData::platformInit):
  41744. (WebCore::SimpleFontData::platformDestroy):
  41745. (WebCore::SimpleFontData::smallCapsFontData):
  41746. (WebCore::SimpleFontData::containsCharacters):
  41747. (WebCore::SimpleFontData::determinePitch):
  41748. (WebCore::SimpleFontData::platformWidthForGlyph):
  41749. * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added.
  41750. (WebCore::ThemeHelperWin::ThemeHelperWin):
  41751. (WebCore::ThemeHelperWin::~ThemeHelperWin):
  41752. * platform/graphics/chromium/ThemeHelperChromiumWin.h: Added.
  41753. (WebCore::ThemeHelperWin::):
  41754. (WebCore::ThemeHelperWin::context):
  41755. (WebCore::ThemeHelperWin::rect):
  41756. * platform/graphics/chromium/UniscribeHelper.cpp: Added.
  41757. (WebCore::treatAsSpace):
  41758. (WebCore::containsMissingGlyphs):
  41759. (WebCore::setLogFontAndStyle):
  41760. (WebCore::UniscribeHelper::UniscribeHelper):
  41761. (WebCore::UniscribeHelper::~UniscribeHelper):
  41762. (WebCore::UniscribeHelper::initWithOptionalLengthProtection):
  41763. (WebCore::UniscribeHelper::width):
  41764. (WebCore::UniscribeHelper::justify):
  41765. (WebCore::UniscribeHelper::characterToX):
  41766. (WebCore::UniscribeHelper::xToCharacter):
  41767. (WebCore::UniscribeHelper::draw):
  41768. (WebCore::UniscribeHelper::firstGlyphForCharacter):
  41769. (WebCore::UniscribeHelper::fillRuns):
  41770. (WebCore::UniscribeHelper::shape):
  41771. (WebCore::UniscribeHelper::fillShapes):
  41772. (WebCore::UniscribeHelper::fillScreenOrder):
  41773. (WebCore::UniscribeHelper::adjustSpaceAdvances):
  41774. (WebCore::UniscribeHelper::applySpacing):
  41775. (WebCore::UniscribeHelper::advanceForItem):
  41776. * platform/graphics/chromium/UniscribeHelper.h: Added.
  41777. (WebCore::UniscribeHelper::directionalOverride):
  41778. (WebCore::UniscribeHelper::setDirectionalOverride):
  41779. (WebCore::UniscribeHelper::inhibitLigate):
  41780. (WebCore::UniscribeHelper::setInhibitLigate):
  41781. (WebCore::UniscribeHelper::letterSpacing):
  41782. (WebCore::UniscribeHelper::setLetterSpacing):
  41783. (WebCore::UniscribeHelper::spaceWidth):
  41784. (WebCore::UniscribeHelper::setSpaceWidth):
  41785. (WebCore::UniscribeHelper::wordSpacing):
  41786. (WebCore::UniscribeHelper::setWordSpacing):
  41787. (WebCore::UniscribeHelper::setAscent):
  41788. (WebCore::UniscribeHelper::init):
  41789. (WebCore::UniscribeHelper::tryToPreloadFont):
  41790. (WebCore::UniscribeHelper::Shaping::Shaping):
  41791. (WebCore::UniscribeHelper::Shaping::glyphLength):
  41792. (WebCore::UniscribeHelper::Shaping::charLength):
  41793. (WebCore::UniscribeHelper::Shaping::effectiveAdvances):
  41794. (WebCore::UniscribeHelper::nextWinFontData):
  41795. (WebCore::UniscribeHelper::resetFontIndex):
  41796. * platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added.
  41797. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
  41798. (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
  41799. (WebCore::UniscribeHelperTextRun::nextWinFontData):
  41800. (WebCore::UniscribeHelperTextRun::resetFontIndex):
  41801. * platform/graphics/chromium/UniscribeHelperTextRun.h: Added.
  41802. 2009-01-15 Chris Marrin <cmarrin@apple.com>
  41803. Reviewed by Dan Bernstein.
  41804. Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421
  41805. * WebCore.vcproj/WebCore.vcproj:
  41806. 2009-01-15 Aaron Boodman <aa@chromium.org>
  41807. Reviewed by Adam Roben.
  41808. https://bugs.webkit.org/show_bug.cgi?id=15279
  41809. Right clicking over text (or multiple spaces) auto selects the word
  41810. (or multiple spaces) under it, which is not a desirable effect for some
  41811. platforms.
  41812. * page/EventHandler.cpp:
  41813. (WebCore::EventHandler::sendContextMenuEvent):
  41814. Don't select words on right-click on Chromium.
  41815. 2009-01-15 Darin Fisher <darin@chromium.org>
  41816. Reviewed by Eric Seidel.
  41817. https://bugs.webkit.org/show_bug.cgi?id=23345
  41818. SharedBuffer.h should include wtf/OwnPtr.h
  41819. * platform/SharedBuffer.h:
  41820. 2009-01-14 David Kilzer <ddkilzer@apple.com>
  41821. Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it
  41822. <https://bugs.webkit.org/show_bug.cgi?id=23338>
  41823. Reviewed by Timothy Hatcher.
  41824. * WebCore.xcodeproj/project.pbxproj: Check to see if
  41825. "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector"
  41826. exists before trying to change directories into it and then
  41827. deleting, modifying and adding files to it.
  41828. 2009-01-14 miggilin <mr.diggilin@gmail.com>
  41829. Reviewed by Kevin Ollivier.
  41830. Fixing wx compilation for wx 2.9/trunk.
  41831. * platform/graphics/wx/FontPlatformData.h:
  41832. (WebCore::FontPlatformData::operator==):
  41833. (WebCore::FontPlatformData::computeHash):
  41834. * platform/graphics/wx/GraphicsContextWx.cpp:
  41835. (WebCore::GraphicsContext::clip):
  41836. (WebCore::GraphicsContext::setCompositeOperation):
  41837. * platform/graphics/wx/ImageSourceWx.cpp:
  41838. (WebCore::ImageSource::createFrameAtIndex):
  41839. * platform/graphics/wx/PathWx.cpp:
  41840. (WebCore::Path::contains):
  41841. * platform/wx/RenderThemeWx.cpp:
  41842. (WebCore::RenderThemeWx::paintButton):
  41843. (WebCore::RenderThemeWx::paintTextField):
  41844. (WebCore::RenderThemeWx::paintMenuList):
  41845. * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
  41846. 2009-01-14 Kevin Ollivier <kevino@theolliviers.com>
  41847. wx build fix. Adding WebKitCSSMatrix.
  41848. * WebCoreSources.bkl:
  41849. 2009-01-14 Adam Treat <adam.treat@torchmobile.com>
  41850. Prospective build fix for Qt following r39922.
  41851. * WebCore.pro:
  41852. 2009-01-14 Darin Adler <darin@apple.com>
  41853. Fix debug build.
  41854. * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
  41855. (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  41856. Use ASSERT_UNUSED.
  41857. 2009-01-14 Adele Peterson <adele@apple.com>
  41858. Reviewed by Darin Adler.
  41859. Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
  41860. <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
  41861. No new tests added. In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
  41862. we'll need a separate set of results for different themes.
  41863. * css/themeWin.css: Renable search fields. Added new rules for sub-element placement.
  41864. * rendering/RenderTextControlSingleLine.cpp:
  41865. (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the
  41866. desired width for the text block.
  41867. * rendering/RenderThemeWin.cpp:
  41868. (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart.
  41869. (WebCore::RenderThemeWin::determineState): ditto.
  41870. (WebCore::RenderThemeWin::getClassicThemeData): ditto.
  41871. (WebCore::RenderThemeWin::getThemeData): ditto.
  41872. (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork.
  41873. (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto.
  41874. (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto.
  41875. (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height.
  41876. (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto.
  41877. (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.
  41878. 2009-01-14 Alp Toker <alp@nuanti.com>
  41879. GTK+ build fix following r39922.
  41880. Add WebKitCSSMatrix to the build system.
  41881. * GNUmakefile.am:
  41882. 2009-01-14 Chris Marrin <cmarrin@apple.com>
  41883. Reviewed by Sam Weinig.
  41884. Implemented 2D WebKitCSSMatrix
  41885. https://bugs.webkit.org/show_bug.cgi?id=21421
  41886. Test: transforms/2d/cssmatrix-interface.xhtml
  41887. * DerivedSources.make:
  41888. * WebCore.xcodeproj/project.pbxproj:
  41889. * bindings/js/JSDOMWindowBase.cpp:
  41890. (jsDOMWindowBaseWebKitCSSMatrix):
  41891. (setJSDOMWindowBaseWebKitCSSMatrix):
  41892. * bindings/js/JSWebKitCSSMatrixConstructor.cpp: Added.
  41893. (WebCore::):
  41894. (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  41895. (WebCore::constructWebKitCSSMatrix):
  41896. (WebCore::JSWebKitCSSMatrixConstructor::getConstructData):
  41897. * bindings/js/JSWebKitCSSMatrixConstructor.h: Added.
  41898. (WebCore::JSWebKitCSSMatrixConstructor::classInfo):
  41899. * bindings/objc/DOMInternal.h:
  41900. * css/WebKitCSSMatrix.cpp: Added.
  41901. (WebCore::WebKitCSSMatrix::WebKitCSSMatrix):
  41902. (WebCore::WebKitCSSMatrix::~WebKitCSSMatrix):
  41903. (WebCore::WebKitCSSMatrix::setMatrixValue):
  41904. (WebCore::WebKitCSSMatrix::multiply):
  41905. (WebCore::WebKitCSSMatrix::inverse):
  41906. (WebCore::WebKitCSSMatrix::translate):
  41907. (WebCore::WebKitCSSMatrix::scale):
  41908. (WebCore::WebKitCSSMatrix::rotate):
  41909. (WebCore::WebKitCSSMatrix::toString):
  41910. * css/WebKitCSSMatrix.h: Added.
  41911. (WebCore::WebKitCSSMatrix::create):
  41912. (WebCore::WebKitCSSMatrix::a):
  41913. (WebCore::WebKitCSSMatrix::b):
  41914. (WebCore::WebKitCSSMatrix::c):
  41915. (WebCore::WebKitCSSMatrix::d):
  41916. (WebCore::WebKitCSSMatrix::e):
  41917. (WebCore::WebKitCSSMatrix::f):
  41918. (WebCore::WebKitCSSMatrix::setA):
  41919. (WebCore::WebKitCSSMatrix::setB):
  41920. (WebCore::WebKitCSSMatrix::setC):
  41921. (WebCore::WebKitCSSMatrix::setD):
  41922. (WebCore::WebKitCSSMatrix::setE):
  41923. (WebCore::WebKitCSSMatrix::setF):
  41924. (WebCore::WebKitCSSMatrix::transform):
  41925. * css/WebKitCSSMatrix.idl: Added.
  41926. 2009-01-14 Michael Moss <mmoss@chromium.org>
  41927. Reviewed by Eric Seidel.
  41928. Workaround a skia limitation on repeated patterns, and remove extra
  41929. transformations applied to pattern.
  41930. https://bugs.webkit.org/show_bug.cgi?id=23332
  41931. Fixes:
  41932. LayoutTests/fast/canvas/patternfill-repeat.html
  41933. LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg
  41934. * platform/graphics/skia/PatternSkia.cpp:
  41935. (WebCore::Pattern::createPlatformPattern):
  41936. 2009-01-14 Mark Rowe <mrowe@apple.com>
  41937. Fix https://bugs.webkit.org/show_bug.cgi?id=23334
  41938. Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp
  41939. Include wtf/UnusedParam.h to get UNUSED_PARAM.
  41940. * dom/XMLTokenizerLibxml2.cpp:
  41941. (WebCore::hackAroundLibXMLEntityBug):
  41942. 2009-01-14 David Levin <levin@chromium.org>
  41943. Reviewed by Darin Adler.
  41944. https://bugs.webkit.org/show_bug.cgi?id=23333
  41945. Platform code fixes. These compensate for changes in platform
  41946. callbacks from WebKit and minor API tweaks.
  41947. I enumerated a few below.
  41948. * platform/graphics/chromium/FontCacheChromiumWin.cpp:
  41949. fontExists has been gone since r34794.
  41950. * platform/graphics/skia/ImageSkia.cpp:
  41951. (WebCore::paintSkBitmap):
  41952. (WebCore::FrameData::clear):
  41953. r39751 changes this api to take and return a bool.
  41954. (WebCore::Image::drawPattern):
  41955. * platform/graphics/skia/PathSkia.cpp:
  41956. (WebCore::Path::apply):
  41957. (WebCore::boundingBoxForCurrentStroke):
  41958. (WebCore::Path::strokeContains):
  41959. * svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.
  41960. 2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
  41961. Reviewed by Eric Seidel.
  41962. <https://bugs.webkit.org/show_bug.cgi?id=16829>
  41963. Implement NPN_SetException()
  41964. This mirrors the implementation in the obj-c bindings.
  41965. Test: plugins/netscape-throw-exception.html
  41966. * bridge/NP_jsobject.cpp:
  41967. (_NPN_SetException):
  41968. * bridge/c/c_instance.cpp:
  41969. (JSC::Bindings::getExceptionString):
  41970. (JSC::Bindings::CInstance::setGlobalException):
  41971. (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
  41972. (JSC::Bindings::CInstance::invokeMethod):
  41973. (JSC::Bindings::CInstance::invokeDefaultMethod):
  41974. (JSC::Bindings::CInstance::invokeConstruct):
  41975. (JSC::Bindings::CInstance::getPropertyNames):
  41976. * bridge/c/c_instance.h:
  41977. 2009-01-14 Pierre-Olivier Latour <pol@apple.com>
  41978. Fixed build warning when LIBXML_VERSION >= 20627.
  41979. * dom/XMLTokenizerLibxml2.cpp:
  41980. (WebCore::hackAroundLibXMLEntityBug):
  41981. 2009-01-14 Alexey Proskuryakov <ap@webkit.org>
  41982. Reviewed by Anders Carlsson.
  41983. https://bugs.webkit.org/show_bug.cgi?id=23326
  41984. Resources are never deleted from application cache disk database
  41985. * loader/appcache/ApplicationCacheStorage.cpp:
  41986. (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when
  41987. a cache is deleted. Note that this change doesn't require bumping schema version. We should
  41988. consider switching to foreign keys and cascade delete instead of triggers in the future.
  41989. (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient
  41990. to only remove the cache itself.
  41991. (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this
  41992. is done automatically when a cache is deleted.
  41993. 2009-01-14 David Kilzer <ddkilzer@apple.com>
  41994. Bug 22795: favicons should be saved to webarchives
  41995. <https://bugs.webkit.org/show_bug.cgi?id=22795>
  41996. Reviewed by Darin Adler.
  41997. Test: webarchive/test-link-rel-icon.html
  41998. * html/HTMLLinkElement.cpp:
  41999. (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add
  42000. favicon URLs to the list since no ArchiveResource or CachedResource
  42001. is ever created for them.
  42002. * loader/archive/cf/LegacyWebArchive.cpp:
  42003. (WebCore::LegacyWebArchive::create): Handle favicons as a special
  42004. case for all main resources.
  42005. * loader/icon/IconDatabase.cpp:
  42006. (WebCore::IconDatabase::close): Actually close the SQLite database
  42007. so that isOpen() returns false when called. Added an ASSERT() for
  42008. good measure.
  42009. 2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
  42010. Reviewed by Eric Seidel.
  42011. https://bugs.webkit.org/show_bug.cgi?id=23321
  42012. Upstream more bits of graphics/chromium.
  42013. * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added.
  42014. (WebCore::FontPlatformData::FontPlatformData):
  42015. (WebCore::FontPlatformData::operator=):
  42016. (WebCore::FontPlatformData::~FontPlatformData):
  42017. (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
  42018. (WebCore::FontPlatformData::hashTableDeletedFontValue):
  42019. (WebCore::FontPlatformData::scriptFontProperties):
  42020. * platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added.
  42021. (WebCore::FontPlatformData::isHashTableDeletedValue):
  42022. (WebCore::FontPlatformData::hfont):
  42023. (WebCore::FontPlatformData::size):
  42024. (WebCore::FontPlatformData::hash):
  42025. (WebCore::FontPlatformData::operator==):
  42026. (WebCore::FontPlatformData::scriptCache):
  42027. (WebCore::FontPlatformData::RefCountedHFONT::create):
  42028. (WebCore::FontPlatformData::RefCountedHFONT::hfont):
  42029. (WebCore::FontPlatformData::RefCountedHFONT::hash):
  42030. (WebCore::FontPlatformData::RefCountedHFONT::operator==):
  42031. (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
  42032. * platform/graphics/chromium/FontPlatformDataLinux.cpp: Added.
  42033. (WebCore::FontPlatformData::FontPlatformData):
  42034. (WebCore::FontPlatformData::~FontPlatformData):
  42035. (WebCore::FontPlatformData::operator=):
  42036. (WebCore::FontPlatformData::setupPaint):
  42037. (WebCore::FontPlatformData::operator==):
  42038. (WebCore::FontPlatformData::hash):
  42039. (WebCore::FontPlatformData::isFixedPitch):
  42040. * platform/graphics/chromium/FontPlatformDataLinux.h: Added.
  42041. (WebCore::FontPlatformData::FontPlatformData):
  42042. (WebCore::FontPlatformData::size):
  42043. (WebCore::FontPlatformData::isHashTableDeletedValue):
  42044. (WebCore::FontPlatformData::hashTableDeletedFontValue):
  42045. * platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added.
  42046. (WebCore::):
  42047. (WebCore::FontMap::getAscent):
  42048. (WebCore::FontMap::FontData::FontData):
  42049. (WebCore::getFontFamilyForScript):
  42050. (WebCore::getFallbackFamily):
  42051. (WebCore::getDerivedFontData):
  42052. (WebCore::getStyleFromLogfont):
  42053. * platform/graphics/chromium/FontUtilsChromiumWin.h: Added.
  42054. (WebCore::):
  42055. 2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
  42056. Reviewed by Eric Seidel.
  42057. https://bugs.webkit.org/show_bug.cgi?id=23325
  42058. Upstream even more graphics/chromium bits.
  42059. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added.
  42060. (WebCore::fillEmptyGlyphs):
  42061. (WebCore::initSpaceGlyph):
  42062. (WebCore::fillBMPGlyphs):
  42063. (WebCore::fillNonBMPGlyphs):
  42064. (WebCore::GlyphPage::fill):
  42065. * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added.
  42066. (WebCore::GlyphPage::fill):
  42067. * platform/graphics/chromium/IconChromiumLinux.cpp: Added.
  42068. (WebCore::Icon::Icon):
  42069. (WebCore::Icon::~Icon):
  42070. (WebCore::Icon::createIconForFile):
  42071. (WebCore::Icon::createIconForFiles):
  42072. (WebCore::Icon::paint):
  42073. * platform/graphics/chromium/IconChromiumMac.cpp: Added.
  42074. (WebCore::Icon::createIconForFile):
  42075. (WebCore::Icon::createIconForFiles):
  42076. (WebCore::Icon::~Icon):
  42077. (WebCore::Icon::paint):
  42078. * platform/graphics/chromium/IconChromiumWin.cpp: Added.
  42079. (WebCore::Icon::Icon):
  42080. (WebCore::Icon::~Icon):
  42081. (WebCore::Icon::createIconForFile):
  42082. (WebCore::Icon::createIconForFiles):
  42083. (WebCore::Icon::paint):
  42084. * platform/graphics/chromium/ImageBufferData.h: Added.
  42085. * platform/graphics/chromium/ImageChromiumMac.mm: Added.
  42086. (WebCore::Image::loadPlatformResource):
  42087. (WebCore::BitmapImage::initPlatformData):
  42088. (WebCore::BitmapImage::invalidatePlatformData):
  42089. * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
  42090. * platform/graphics/chromium/PlatformIcon.h: Added.
  42091. 2009-01-14 Darin Fisher <darin@chromium.org>
  42092. Reviewed by Eric Seidel.
  42093. https://bugs.webkit.org/show_bug.cgi?id=23328
  42094. Upstream remaining files from platform/chromium/
  42095. * platform/chromium/CursorChromium.cpp:
  42096. (WebCore::pointerCursor):
  42097. (WebCore::crossCursor):
  42098. (WebCore::handCursor):
  42099. (WebCore::iBeamCursor):
  42100. (WebCore::waitCursor):
  42101. (WebCore::helpCursor):
  42102. (WebCore::eastResizeCursor):
  42103. (WebCore::northResizeCursor):
  42104. (WebCore::northEastResizeCursor):
  42105. (WebCore::northWestResizeCursor):
  42106. (WebCore::southResizeCursor):
  42107. (WebCore::southEastResizeCursor):
  42108. (WebCore::southWestResizeCursor):
  42109. (WebCore::westResizeCursor):
  42110. (WebCore::northSouthResizeCursor):
  42111. (WebCore::eastWestResizeCursor):
  42112. (WebCore::northEastSouthWestResizeCursor):
  42113. (WebCore::northWestSouthEastResizeCursor):
  42114. (WebCore::columnResizeCursor):
  42115. (WebCore::rowResizeCursor):
  42116. (WebCore::middlePanningCursor):
  42117. (WebCore::eastPanningCursor):
  42118. (WebCore::northPanningCursor):
  42119. (WebCore::northEastPanningCursor):
  42120. (WebCore::northWestPanningCursor):
  42121. (WebCore::southPanningCursor):
  42122. (WebCore::southEastPanningCursor):
  42123. (WebCore::southWestPanningCursor):
  42124. (WebCore::westPanningCursor):
  42125. (WebCore::moveCursor):
  42126. (WebCore::verticalTextCursor):
  42127. (WebCore::cellCursor):
  42128. (WebCore::contextMenuCursor):
  42129. (WebCore::aliasCursor):
  42130. (WebCore::progressCursor):
  42131. (WebCore::noDropCursor):
  42132. (WebCore::copyCursor):
  42133. (WebCore::noneCursor):
  42134. (WebCore::notAllowedCursor):
  42135. (WebCore::zoomInCursor):
  42136. (WebCore::zoomOutCursor):
  42137. * platform/chromium/DragDataRef.h: Added.
  42138. * platform/chromium/DragImageChromium.cpp: Added.
  42139. (WebCore::dragImageSize):
  42140. (WebCore::deleteDragImage):
  42141. (WebCore::scaleDragImage):
  42142. (WebCore::dissolveDragImageToFraction):
  42143. (WebCore::createDragImageFromImage):
  42144. (WebCore::createDragImageIconForCachedImage):
  42145. * platform/chromium/DragImageRef.h:
  42146. * platform/chromium/KeyCodeConversion.h: Added.
  42147. * platform/chromium/KeyCodeConversionGtk.cpp: Added.
  42148. (WebCore::windowsKeyCodeForKeyEvent):
  42149. * platform/chromium/KeyboardCodes.h: Added.
  42150. * platform/chromium/KeyboardCodesPosix.h: Added.
  42151. (WebCore::):
  42152. * platform/chromium/KeyboardCodesWin.h: Added.
  42153. (WebCore::):
  42154. * platform/chromium/Language.cpp: Added.
  42155. (WebCore::defaultLanguage):
  42156. * platform/chromium/LinkHashChromium.cpp: Added.
  42157. (WebCore::visitedLinkHash):
  42158. * platform/chromium/MimeTypeRegistryChromium.cpp: Added.
  42159. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  42160. (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
  42161. (WebCore::MIMETypeRegistry::getMIMETypeForPath):
  42162. (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
  42163. (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
  42164. (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
  42165. (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
  42166. (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  42167. (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
  42168. (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
  42169. (WebCore::dummyHashSet):
  42170. (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
  42171. (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
  42172. (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
  42173. (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
  42174. (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
  42175. * platform/chromium/PasteboardChromium.cpp: Added.
  42176. (WebCore::Pasteboard::generalPasteboard):
  42177. (WebCore::Pasteboard::Pasteboard):
  42178. (WebCore::Pasteboard::clear):
  42179. (WebCore::Pasteboard::writeSelection):
  42180. (WebCore::Pasteboard::writeURL):
  42181. (WebCore::Pasteboard::writeImage):
  42182. (WebCore::Pasteboard::canSmartReplace):
  42183. (WebCore::Pasteboard::plainText):
  42184. (WebCore::Pasteboard::documentFragment):
  42185. * platform/chromium/PasteboardPrivate.h:
  42186. * platform/chromium/PlatformCursor.h: Added.
  42187. (WebCore::PlatformCursor::):
  42188. (WebCore::PlatformCursor::PlatformCursor):
  42189. (WebCore::PlatformCursor::customImage):
  42190. (WebCore::PlatformCursor::hotSpot):
  42191. (WebCore::PlatformCursor::type):
  42192. * platform/chromium/PlatformKeyboardEventChromium.cpp: Added.
  42193. (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
  42194. (WebCore::PlatformKeyboardEvent::currentCapsLockState):
  42195. * platform/chromium/PlatformScreenChromium.cpp: Added.
  42196. (WebCore::screenDepth):
  42197. (WebCore::screenDepthPerComponent):
  42198. (WebCore::screenIsMonochrome):
  42199. (WebCore::screenRect):
  42200. (WebCore::screenAvailableRect):
  42201. * platform/chromium/PlatformWidget.h:
  42202. * platform/chromium/PopupMenuChromium.cpp: Added.
  42203. (WebCore::PopupListBox::selectedIndex):
  42204. (WebCore::PopupListBox::numItems):
  42205. (WebCore::PopupListBox::setBaseWidth):
  42206. (WebCore::PopupListBox::setTextOnIndexChange):
  42207. (WebCore::PopupListBox::setAcceptOnAbandon):
  42208. (WebCore::PopupListBox::):
  42209. (WebCore::PopupListBox::ListItem::ListItem):
  42210. (WebCore::PopupListBox::PopupListBox):
  42211. (WebCore::PopupListBox::~PopupListBox):
  42212. (WebCore::PopupListBox::disconnectClient):
  42213. (WebCore::PopupListBox::scrollToRevealSelection):
  42214. (WebCore::constructRelativeMouseEvent):
  42215. (WebCore::constructRelativeWheelEvent):
  42216. (WebCore::PopupContainer::create):
  42217. (WebCore::PopupContainer::PopupContainer):
  42218. (WebCore::PopupContainer::~PopupContainer):
  42219. (WebCore::PopupContainer::showPopup):
  42220. (WebCore::PopupContainer::hidePopup):
  42221. (WebCore::PopupContainer::layout):
  42222. (WebCore::PopupContainer::handleMouseDownEvent):
  42223. (WebCore::PopupContainer::handleMouseMoveEvent):
  42224. (WebCore::PopupContainer::handleMouseReleaseEvent):
  42225. (WebCore::PopupContainer::handleWheelEvent):
  42226. (WebCore::PopupContainer::handleKeyEvent):
  42227. (WebCore::PopupContainer::hide):
  42228. (WebCore::PopupContainer::paint):
  42229. (WebCore::PopupContainer::paintBorder):
  42230. (WebCore::PopupContainer::isInterestedInEventForKey):
  42231. (WebCore::PopupContainer::show):
  42232. (WebCore::PopupContainer::setTextOnIndexChange):
  42233. (WebCore::PopupContainer::setAcceptOnAbandon):
  42234. (WebCore::PopupContainer::refresh):
  42235. (WebCore::PopupListBox::handleMouseDownEvent):
  42236. (WebCore::PopupListBox::handleMouseMoveEvent):
  42237. (WebCore::PopupListBox::handleMouseReleaseEvent):
  42238. (WebCore::PopupListBox::handleWheelEvent):
  42239. (WebCore::PopupListBox::isInterestedInEventForKey):
  42240. (WebCore::PopupListBox::handleKeyEvent):
  42241. (WebCore::PopupListBox::hostWindow):
  42242. (WebCore::PopupListBox::invalidateRect):
  42243. (WebCore::stripLeadingWhiteSpace):
  42244. (WebCore::PopupListBox::typeAheadFind):
  42245. (WebCore::PopupListBox::paint):
  42246. (WebCore::PopupListBox::paintRow):
  42247. (WebCore::PopupListBox::getRowFont):
  42248. (WebCore::PopupListBox::abandon):
  42249. (WebCore::PopupListBox::pointToRowIndex):
  42250. (WebCore::PopupListBox::acceptIndex):
  42251. (WebCore::PopupListBox::selectIndex):
  42252. (WebCore::PopupListBox::setOriginalIndex):
  42253. (WebCore::PopupListBox::getRowHeight):
  42254. (WebCore::PopupListBox::getRowBounds):
  42255. (WebCore::PopupListBox::invalidateRow):
  42256. (WebCore::PopupListBox::scrollToRevealRow):
  42257. (WebCore::PopupListBox::isSelectableItem):
  42258. (WebCore::PopupListBox::adjustSelectedIndex):
  42259. (WebCore::PopupListBox::updateFromElement):
  42260. (WebCore::PopupListBox::layout):
  42261. (WebCore::PopupListBox::clear):
  42262. (WebCore::PopupListBox::isPointInBounds):
  42263. (WebCore::PopupMenu::PopupMenu):
  42264. (WebCore::PopupMenu::~PopupMenu):
  42265. (WebCore::PopupMenu::show):
  42266. (WebCore::PopupMenu::hide):
  42267. (WebCore::PopupMenu::updateFromElement):
  42268. (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  42269. * platform/chromium/PopupMenuChromium.h: Added.
  42270. (WebCore::PopupContainer::listBox):
  42271. * platform/chromium/PopupMenuPrivate.h: Added.
  42272. * platform/chromium/SSLKeyGeneratorChromium.cpp: Added.
  42273. (WebCore::supportedKeySizes):
  42274. * platform/chromium/ScrollbarThemeChromium.cpp: Added.
  42275. (WebCore::ScrollbarTheme::nativeTheme):
  42276. (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
  42277. (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
  42278. (WebCore::ScrollbarThemeChromium::themeChanged):
  42279. (WebCore::ScrollbarThemeChromium::hasThumb):
  42280. (WebCore::ScrollbarThemeChromium::backButtonRect):
  42281. (WebCore::ScrollbarThemeChromium::forwardButtonRect):
  42282. (WebCore::ScrollbarThemeChromium::trackRect):
  42283. (WebCore::ScrollbarThemeChromium::paintTrackBackground):
  42284. (WebCore::ScrollbarThemeChromium::paintTickmarks):
  42285. (WebCore::ScrollbarThemeChromium::paintScrollCorner):
  42286. (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb):
  42287. (WebCore::ScrollbarThemeChromium::buttonSize):
  42288. * platform/chromium/ScrollbarThemeChromium.h: Added.
  42289. (WebCore::ScrollbarThemeChromium::hasButtons):
  42290. * platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
  42291. (WebCore::ScrollbarThemeChromium::scrollbarThickness):
  42292. (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
  42293. (WebCore::initMozState):
  42294. (WebCore::paintScrollbarWidget):
  42295. (WebCore::ScrollbarThemeChromium::paintTrackPiece):
  42296. (WebCore::ScrollbarThemeChromium::paintButton):
  42297. (WebCore::ScrollbarThemeChromium::paintThumb):
  42298. * platform/chromium/ScrollbarThemeChromiumWin.cpp:
  42299. * platform/chromium/SearchPopupMenuChromium.cpp: Added.
  42300. (WebCore::SearchPopupMenu::SearchPopupMenu):
  42301. (WebCore::SearchPopupMenu::enabled):
  42302. (WebCore::SearchPopupMenu::saveRecentSearches):
  42303. (WebCore::SearchPopupMenu::loadRecentSearches):
  42304. * platform/chromium/SharedTimerChromium.cpp: Added.
  42305. (WebCore::setSharedTimerFiredFunction):
  42306. (WebCore::setSharedTimerFireTime):
  42307. (WebCore::stopSharedTimer):
  42308. * platform/chromium/TemporaryLinkStubs.cpp: Added.
  42309. (WebCore::signedPublicKeyAndChallengeString):
  42310. (WebCore::getSupportedKeySizes):
  42311. (WebCore::KURL::fileSystemPath):
  42312. (WebCore::SharedBuffer::createWithContentsOfFile):
  42313. (WTF::scheduleDispatchFunctionsOnMainThread):
  42314. 2009-01-14 Darin Fisher <darin@chromium.org>
  42315. Reviewed by Eric Seidel.
  42316. https://bugs.webkit.org/show_bug.cgi?id=23323
  42317. Upstream platform/text/chromium/
  42318. * platform/text/chromium: Added.
  42319. * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added.
  42320. (WebCore::currentTextBreakLocaleID):
  42321. 2009-01-14 Steve Falkenburg <sfalken@apple.com>
  42322. Update copyright year in version resources.
  42323. Reviewed by Adam Roben.
  42324. * WebCore.vcproj/QTMovieWin.rc:
  42325. 2009-01-14 Darin Fisher <darin@chromium.org>
  42326. Reviewed by Darin Adler.
  42327. https://bugs.webkit.org/show_bug.cgi?id=23324
  42328. Move platform/chromium/EditorChromium.cpp into editing/chromium/
  42329. * editing/chromium: Added.
  42330. * editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
  42331. * platform/chromium/EditorChromium.cpp: Removed.
  42332. 2009-01-14 Darin Fisher <darin@chromium.org>
  42333. Reviewed by Darin Adler.
  42334. https://bugs.webkit.org/show_bug.cgi?id=23320
  42335. Make it possible to use notImplemented outside of the WebCore namespace
  42336. * platform/NotImplemented.h:
  42337. 2009-01-14 Nigel Tao <nigel.tao.gnome@gmail.com>
  42338. Reviewed by Darin Adler.
  42339. - fix https://bugs.webkit.org/show_bug.cgi?id=22476
  42340. Check that the document's SecurityOrigin canLoadLocalResources,
  42341. when pages try to put NSFilenamesPboardtype data on the clipboard,
  42342. by calling event.dataTransfer.setData('URL', 'file:///foo/bar');
  42343. Tests: http/tests/security/dataTransfer-set-data-file-url.html
  42344. platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html
  42345. * platform/mac/ClipboardMac.mm:
  42346. (WebCore::ClipboardMac::setData):
  42347. 2009-01-14 Dan Bernstein <mitz@apple.com>
  42348. Reviewed by John Sullivan.
  42349. - update copyright
  42350. * Info.plist:
  42351. 2009-01-14 Alexey Proskuryakov <ap@webkit.org>
  42352. Reviewed by Darin Adler.
  42353. https://bugs.webkit.org/show_bug.cgi?id=23316
  42354. Application cache updating always fails with an assertion
  42355. Test: http/tests/appcache/update-cache.html
  42356. * loader/appcache/ApplicationCacheGroup.cpp:
  42357. (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where
  42358. multiple caches survive the last DocumentLoader destruction, preventing a crash in release
  42359. builds.
  42360. (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
  42361. 2009-01-14 Alexey Proskuryakov <ap@webkit.org>
  42362. Release build fix.
  42363. * loader/appcache/ApplicationCacheStorage.cpp:
  42364. (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.
  42365. 2009-01-13 Alexey Proskuryakov <ap@webkit.org>
  42366. Reviewed by Anders Carlsson.
  42367. Test: http/tests/appcache/xhr-foreign-resource.html
  42368. https://bugs.webkit.org/show_bug.cgi?id=23256
  42369. Implement application cache foreign entries
  42370. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
  42371. Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
  42372. * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
  42373. If a document that was loaded from appcache should be associated with a different cache,
  42374. mark the resource as foreign in the original cache and start over.
  42375. * loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType):
  42376. This function can now be called after a cache is stored, so it no longer asserts the opposite.
  42377. * loader/appcache/ApplicationCacheStorage.cpp:
  42378. (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore
  42379. in-memory caches that were already rejected.
  42380. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
  42381. (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of
  42382. an already stored cached resource.
  42383. * loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
  42384. 2009-01-13 Mark Rowe <mrowe@apple.com>
  42385. Fix the Tiger WebCore build after r39880.
  42386. * editing/Editor.cpp:
  42387. (WebCore::Editor::markBadGrammar):
  42388. * loader/mac/DocumentLoaderMac.cpp:
  42389. (WebCore::DocumentLoader::schedule):
  42390. (WebCore::DocumentLoader::unschedule):
  42391. * platform/mac/PasteboardMac.mm:
  42392. (WebCore::Pasteboard::writeSelection):
  42393. * platform/mac/WebCoreObjCExtras.mm:
  42394. (WebCoreObjCFinalizeOnMainThread):
  42395. * platform/network/mac/ResourceHandleMac.mm:
  42396. (WebCore::ResourceHandle::schedule):
  42397. (WebCore::ResourceHandle::unschedule):
  42398. 2009-01-13 Darin Adler <darin@apple.com>
  42399. Reviewed by Sam Weinig.
  42400. Bug 23102: turn on unused parameter warnings in WebCore
  42401. https://bugs.webkit.org/show_bug.cgi?id=23102
  42402. Last step: Turn on the warning and fix the last few instances.
  42403. * Configurations/Base.xcconfig: Removed -Wno-unused-parameter from
  42404. WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
  42405. * bindings/js/JSDOMWindowBase.cpp:
  42406. (jsDOMWindowBaseMessageChannel): Separate the version for use when
  42407. CHANNEL_MESSAGING is turned off, so we can omit the argument names.
  42408. It would be better to not even have this property in that case,
  42409. rather than having the function return undefined, but I don't know
  42410. how to do that with the bindings script.
  42411. * bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in
  42412. functions where they're not used (the SVG context, and the property
  42413. name in the index getter). Use UNUSED_PARAM where arguments are
  42414. sometimes not used.
  42415. * bridge/runtime_object.cpp:
  42416. (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
  42417. * css/MediaQueryEvaluator.cpp:
  42418. (WebCore::animationMediaFeatureEval): Omit argument names for style and frame.
  42419. (WebCore::transitionMediaFeatureEval): Ditto.
  42420. (WebCore::transform_2dMediaFeatureEval): Ditto.
  42421. (WebCore::transform_3dMediaFeatureEval): Ditto.
  42422. * dom/make_names.pl: Leave out the createdByParser property name in
  42423. cases where it's not used.
  42424. * inspector/JavaScriptDebugServer.cpp:
  42425. (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the
  42426. version for the Mac platform so we can omit the argument names.
  42427. * loader/EmptyClients.h:
  42428. (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
  42429. * loader/FrameLoaderClient.h:
  42430. (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out
  42431. argument name.
  42432. * loader/icon/IconFetcher.cpp:
  42433. (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED.
  42434. (WebCore::IconFetcher::didReceiveData): Ditto.
  42435. (WebCore::IconFetcher::didFinishLoading): Ditto.
  42436. (WebCore::IconFetcher::didFail): Ditto.
  42437. * platform/KURL.cpp:
  42438. (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so
  42439. we can omit the argument names.
  42440. * platform/Timer.cpp:
  42441. (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
  42442. * platform/graphics/GlyphBuffer.h:
  42443. (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case.
  42444. (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
  42445. * platform/graphics/cg/ImageSourceCG.cpp:
  42446. (WebCore::ImageSource::clear): Removed argument name.
  42447. * rendering/SVGRenderSupport.cpp:
  42448. (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS
  42449. is not enabled.
  42450. (WebCore::finishRenderSVGContent): Ditto.
  42451. 2009-01-13 Chris Marrin <cmarrin@apple.com>
  42452. Reviewed by Darin Adler.
  42453. Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
  42454. Simple fix to convertToLength to catch style==null cases
  42455. * css/CSSStyleSelector.cpp:
  42456. (WebCore::convertToLength):
  42457. 2009-01-13 Eric Seidel <eric@webkit.org>
  42458. Reviewed by Mark Rowe.
  42459. Speculative fix for an Uninitialized Memory Read (UMR)
  42460. seen by purify in chormium's equivalent V8 file.
  42461. * bindings/js/JSSVGPODTypeWrapper.h:
  42462. (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
  42463. 2009-01-13 Dimitri Glazkov <dglazkov@chromium.org>
  42464. Reviewed by Eric Seidel.
  42465. Land portions of platform/graphics/chromium.
  42466. https://bugs.webkit.org/show_bug.cgi?id=23297
  42467. * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
  42468. (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
  42469. (WebCore::FontCustomPlatformData::fontPlatformData):
  42470. (WebCore::EOTStream::EOTStream):
  42471. (WebCore::EOTStream::read):
  42472. (WebCore::readEmbedProc):
  42473. (WebCore::createUniqueFontName):
  42474. (WebCore::createFontCustomPlatformData):
  42475. * platform/graphics/chromium/FontCustomPlatformData.h: Added.
  42476. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  42477. * platform/graphics/chromium/FontLinux.cpp: Added.
  42478. (WebCore::Font::drawGlyphs):
  42479. (WebCore::Font::drawComplexText):
  42480. (WebCore::Font::floatWidthForComplexText):
  42481. (WebCore::Font::offsetForPositionForComplexText):
  42482. (WebCore::Font::selectionRectForComplexText):
  42483. * platform/graphics/chromium/FontPlatformData.h: Added.
  42484. 2009-01-13 Mark Rowe <mrowe@apple.com>
  42485. Rubber-stamped by Oliver Hunt.
  42486. Don't copy DOMStringList.idl into the framework bundle.
  42487. * WebCore.xcodeproj/project.pbxproj:
  42488. 2009-01-13 Christian Dywan <christian@twotoasts.de>
  42489. Build fix, StorageEvent is only defined if we have DOM_STORAGE
  42490. * dom/Document.cpp:
  42491. (WebCore::Document::createEvent): Conditionalize StorageEvent
  42492. 2009-01-13 Darin Adler <darin@apple.com>
  42493. Reviewed by Adele Peterson.
  42494. Bug 23277: space bar scrolls the page when typed in any text field
  42495. https://bugs.webkit.org/show_bug.cgi?id=23277
  42496. rdar://problem/6490249
  42497. There's already a regression test for this, since bug 16421 was the same problem, but on
  42498. Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
  42499. This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
  42500. a text input event from being generated at all. That difference may in itself be a bug, but
  42501. the only symptom is that you get text input events in more cases on platforms other than Mac.
  42502. * page/EventHandler.cpp:
  42503. (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was
  42504. handled, not the result of the dispatchEvent function, which indicates only whether the
  42505. default behavior was prevented, not if the default behavior did some insertion. This fix
  42506. makes it so the keyboard event handler can detect that no space was inserted and know that
  42507. the space bar keypress event can be treated as a scrolling command.
  42508. (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the
  42509. keydown event. Without the change above, making this change would have restored the old
  42510. behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
  42511. 2009-01-13 Darin Fisher <darin@chromium.org>
  42512. Reviewed by Eric Seidel.
  42513. Landing portions of platform/chromium/, taken from here:
  42514. http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
  42515. * platform/chromium/ChromiumBridge.h: Added.
  42516. * platform/chromium/ChromiumDataObject.cpp: Added.
  42517. (WebCore::ChromiumDataObject::clear):
  42518. (WebCore::ChromiumDataObject::hasData):
  42519. * platform/chromium/ChromiumDataObject.h: Added.
  42520. (WebCore::ChromiumDataObject::create):
  42521. (WebCore::ChromiumDataObject::ChromiumDataObject):
  42522. * platform/chromium/ClipboardChromium.cpp: Added.
  42523. (WebCore::):
  42524. (WebCore::clipboardTypeFromMIMEType):
  42525. (WebCore::ClipboardChromium::ClipboardChromium):
  42526. (WebCore::ClipboardChromium::create):
  42527. (WebCore::ClipboardChromium::clearData):
  42528. (WebCore::ClipboardChromium::clearAllData):
  42529. (WebCore::ClipboardChromium::getData):
  42530. (WebCore::ClipboardChromium::setData):
  42531. (WebCore::ClipboardChromium::types):
  42532. (WebCore::ClipboardChromium::setDragImage):
  42533. (WebCore::ClipboardChromium::setDragImageElement):
  42534. (WebCore::ClipboardChromium::createDragImage):
  42535. (WebCore::imageToMarkup):
  42536. (WebCore::getCachedImage):
  42537. (WebCore::writeImageToDataObject):
  42538. (WebCore::ClipboardChromium::declareAndWriteDragImage):
  42539. (WebCore::ClipboardChromium::writeURL):
  42540. (WebCore::ClipboardChromium::writeRange):
  42541. (WebCore::ClipboardChromium::hasData):
  42542. * platform/chromium/ClipboardChromium.h: Added.
  42543. (WebCore::ClipboardChromium::~ClipboardChromium):
  42544. (WebCore::ClipboardChromium::dataObject):
  42545. * platform/chromium/ClipboardUtilitiesChromium.cpp: Added.
  42546. (WebCore::replaceNewlinesWithWindowsStyleNewlines):
  42547. (WebCore::replaceNBSPWithSpace):
  42548. (WebCore::urlToMarkup):
  42549. * platform/chromium/ClipboardUtilitiesChromium.h: Added.
  42550. * platform/chromium/ContextMenuChromium.cpp: Added.
  42551. (WebCore::ContextMenu::ContextMenu):
  42552. (WebCore::ContextMenu::~ContextMenu):
  42553. (WebCore::ContextMenu::itemCount):
  42554. (WebCore::ContextMenu::insertItem):
  42555. (WebCore::ContextMenu::appendItem):
  42556. (WebCore::ContextMenu::itemWithAction):
  42557. (WebCore::ContextMenu::itemAtIndex):
  42558. (WebCore::ContextMenu::setPlatformDescription):
  42559. (WebCore::ContextMenu::platformDescription):
  42560. (WebCore::ContextMenu::releasePlatformDescription):
  42561. * platform/chromium/ContextMenuItemChromium.cpp: Added.
  42562. (WebCore::ContextMenuItem::ContextMenuItem):
  42563. (WebCore::ContextMenuItem::~ContextMenuItem):
  42564. (WebCore::ContextMenuItem::releasePlatformDescription):
  42565. (WebCore::ContextMenuItem::type):
  42566. (WebCore::ContextMenuItem::action):
  42567. (WebCore::ContextMenuItem::title):
  42568. (WebCore::ContextMenuItem::platformSubMenu):
  42569. (WebCore::ContextMenuItem::setType):
  42570. (WebCore::ContextMenuItem::setAction):
  42571. (WebCore::ContextMenuItem::setTitle):
  42572. (WebCore::ContextMenuItem::setSubMenu):
  42573. (WebCore::ContextMenuItem::setChecked):
  42574. (WebCore::ContextMenuItem::setEnabled):
  42575. (WebCore::ContextMenuItem::enabled):
  42576. * platform/chromium/CursorChromium.cpp: Added.
  42577. (WebCore::Cursor::Cursor):
  42578. (WebCore::Cursor::~Cursor):
  42579. (WebCore::Cursor::operator=):
  42580. (WebCore::pointerCursor):
  42581. (WebCore::crossCursor):
  42582. (WebCore::handCursor):
  42583. (WebCore::iBeamCursor):
  42584. (WebCore::waitCursor):
  42585. (WebCore::helpCursor):
  42586. (WebCore::eastResizeCursor):
  42587. (WebCore::northResizeCursor):
  42588. (WebCore::northEastResizeCursor):
  42589. (WebCore::northWestResizeCursor):
  42590. (WebCore::southResizeCursor):
  42591. (WebCore::southEastResizeCursor):
  42592. (WebCore::southWestResizeCursor):
  42593. (WebCore::westResizeCursor):
  42594. (WebCore::northSouthResizeCursor):
  42595. (WebCore::eastWestResizeCursor):
  42596. (WebCore::northEastSouthWestResizeCursor):
  42597. (WebCore::northWestSouthEastResizeCursor):
  42598. (WebCore::columnResizeCursor):
  42599. (WebCore::rowResizeCursor):
  42600. (WebCore::middlePanningCursor):
  42601. (WebCore::eastPanningCursor):
  42602. (WebCore::northPanningCursor):
  42603. (WebCore::northEastPanningCursor):
  42604. (WebCore::northWestPanningCursor):
  42605. (WebCore::southPanningCursor):
  42606. (WebCore::southEastPanningCursor):
  42607. (WebCore::southWestPanningCursor):
  42608. (WebCore::westPanningCursor):
  42609. (WebCore::moveCursor):
  42610. (WebCore::verticalTextCursor):
  42611. (WebCore::cellCursor):
  42612. (WebCore::contextMenuCursor):
  42613. (WebCore::aliasCursor):
  42614. (WebCore::progressCursor):
  42615. (WebCore::noDropCursor):
  42616. (WebCore::copyCursor):
  42617. (WebCore::noneCursor):
  42618. (WebCore::notAllowedCursor):
  42619. (WebCore::zoomInCursor):
  42620. (WebCore::zoomOutCursor):
  42621. (WebCore::grabCursor):
  42622. (WebCore::grabbingCursor):
  42623. * platform/chromium/DragDataChromium.cpp: Added.
  42624. (WebCore::containsHTML):
  42625. (WebCore::DragData::createClipboard):
  42626. (WebCore::DragData::containsURL):
  42627. (WebCore::DragData::asURL):
  42628. (WebCore::DragData::containsFiles):
  42629. (WebCore::DragData::asFilenames):
  42630. (WebCore::DragData::containsPlainText):
  42631. (WebCore::DragData::asPlainText):
  42632. (WebCore::DragData::containsColor):
  42633. (WebCore::DragData::canSmartReplace):
  42634. (WebCore::DragData::containsCompatibleContent):
  42635. (WebCore::DragData::asFragment):
  42636. (WebCore::DragData::asColor):
  42637. * platform/chromium/EditorChromium.cpp: Added.
  42638. (WebCore::Editor::newGeneralClipboard):
  42639. * platform/chromium/FileChooserChromium.cpp: Added.
  42640. (WebCore::FileChooser::basenameForWidth):
  42641. * platform/chromium/FileSystemChromium.cpp: Added.
  42642. (WebCore::deleteFile):
  42643. (WebCore::deleteEmptyDirectory):
  42644. (WebCore::getFileSize):
  42645. (WebCore::getFileModificationTime):
  42646. (WebCore::directoryName):
  42647. (WebCore::pathByAppendingComponent):
  42648. (WebCore::makeAllDirectories):
  42649. (WebCore::fileExists):
  42650. * platform/chromium/FileSystemChromiumLinux.cpp: Added.
  42651. (WebCore::pathGetFileName):
  42652. * platform/chromium/FileSystemChromiumMac.mm: Added.
  42653. (WebCore::pathGetFileName):
  42654. * platform/chromium/FileSystemChromiumWin.cpp: Added.
  42655. (WebCore::pathGetFileName):
  42656. * platform/chromium/FramelessScrollView.cpp: Added.
  42657. (WebCore::FramelessScrollView::~FramelessScrollView):
  42658. (WebCore::FramelessScrollView::invalidateScrollbarRect):
  42659. (WebCore::FramelessScrollView::isActive):
  42660. (WebCore::FramelessScrollView::invalidateRect):
  42661. (WebCore::FramelessScrollView::hostWindow):
  42662. (WebCore::FramelessScrollView::windowClipRect):
  42663. (WebCore::FramelessScrollView::paintContents):
  42664. (WebCore::FramelessScrollView::contentsResized):
  42665. (WebCore::FramelessScrollView::visibleContentsResized):
  42666. * platform/chromium/FramelessScrollView.h: Added.
  42667. (WebCore::FramelessScrollView::FramelessScrollView):
  42668. (WebCore::FramelessScrollView::client):
  42669. (WebCore::FramelessScrollView::setClient):
  42670. * platform/chromium/FramelessScrollViewClient.h: Added.
  42671. * platform/chromium/ScrollbarThemeChromiumWin.cpp: Added.
  42672. (WebCore::):
  42673. (WebCore::ScrollbarThemeChromium::scrollbarThickness):
  42674. (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
  42675. (WebCore::ScrollbarThemeChromium::paintTrackPiece):
  42676. (WebCore::ScrollbarThemeChromium::paintButton):
  42677. (WebCore::ScrollbarThemeChromium::paintThumb):
  42678. (WebCore::ScrollbarThemeChromium::getThemeState):
  42679. (WebCore::ScrollbarThemeChromium::getThemeArrowState):
  42680. (WebCore::ScrollbarThemeChromium::getClassicThemeState):
  42681. * platform/chromium/SoundChromiumPosix.cpp: Added.
  42682. (WebCore::systemBeep):
  42683. * platform/chromium/SoundChromiumWin.cpp: Added.
  42684. (WebCore::systemBeep):
  42685. * platform/chromium/SystemTimeChromium.cpp: Added.
  42686. (WebCore::currentTime):
  42687. (WebCore::userIdleTime):
  42688. * platform/chromium/WidgetChromium.cpp: Added.
  42689. (WebCore::Widget::Widget):
  42690. (WebCore::Widget::~Widget):
  42691. (WebCore::Widget::show):
  42692. (WebCore::Widget::hide):
  42693. (WebCore::Widget::setCursor):
  42694. (WebCore::Widget::paint):
  42695. (WebCore::Widget::setFocus):
  42696. (WebCore::Widget::setIsSelected):
  42697. (WebCore::Widget::frameRect):
  42698. (WebCore::Widget::setFrameRect):
  42699. * platform/chromium/WindowsVersion.cpp: Added.
  42700. (WebCore::isVistaOrNewer):
  42701. * platform/chromium/WindowsVersion.h: Added.
  42702. 2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
  42703. Reviewed by Simon Hausmann.
  42704. [Qt] Make sure media elements dispatch the 'loaded' event
  42705. We assume that when Phonon goes into paused state that we have the
  42706. complete media file. Once we do media loading ourselves we can
  42707. distinguish between loading the first frame and the complete media.
  42708. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  42709. (WebCore::MediaPlayerPrivate::updateStates):
  42710. 2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
  42711. Reviewed by Simon Hausmann.
  42712. [Qt] Add more verbose error output when loading NPAPI plugins
  42713. * plugins/qt/PluginPackageQt.cpp:
  42714. (WebCore::PluginPackage::load):
  42715. 2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
  42716. Reviewed by Tor Arne Vestbø.
  42717. Fix crash in the Qt port when deleting a popup from within a
  42718. JavaScript onchange handler.
  42719. * platform/qt/QWebPopup.cpp:
  42720. (WebCore::QWebPopup::QWebPopup): Perform the activation of the
  42721. combobox item (i.e. the call to the JS handler) from a different
  42722. call stack by using a queued connection.
  42723. 2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
  42724. Reviewed by Tor Arne Vestbø.
  42725. [GIO] Make sure to untef the GFile and the GInputStream on destruction
  42726. Make sure to call cleanupGioOperation from the ResourceHandleInternal
  42727. d'tor. Change the signature of cleanupGioOperation so we can do the
  42728. cleanup of GIO next to the cleanup of SOUP.
  42729. This is happening with many tests from dom/html/level2/html e.g.
  42730. LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
  42731. * platform/network/soup/ResourceHandleSoup.cpp:
  42732. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  42733. (WebCore::cleanupGioOperation):
  42734. (WebCore::closeCallback):
  42735. (WebCore::readCallback):
  42736. (WebCore::openCallback):
  42737. (WebCore::queryInfoCallback):
  42738. 2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
  42739. Reviewed by Tor Arne Vestbø.
  42740. [GIO] Attach the ResourceHandle to the GObject and get it from the GObject
  42741. https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
  42742. Sometimes it is not possible to cancel a pending GIO operation and the
  42743. callback might be invoked with a pointer to an already destructed
  42744. ResourceHandle. To avoid this issue we will attach the ResourceHandle
  42745. to the GObject* and in the callback attempt to get the ResourceHandle
  42746. from the GObject*. If no ResourceHandle is attached we silently fail
  42747. as the cleanup has been already done.
  42748. This is happening with many tests from dom/html/level2/html e.g.
  42749. LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
  42750. * platform/network/soup/ResourceHandleSoup.cpp:
  42751. (WebCore::cleanupGioOperation):
  42752. (WebCore::closeCallback):
  42753. (WebCore::readCallback):
  42754. (WebCore::openCallback):
  42755. (WebCore::queryInfoCallback):
  42756. (WebCore::ResourceHandle::startGio):
  42757. 2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
  42758. Reviewed by Tor Arne Vestbø.
  42759. [GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
  42760. https://bugs.webkit.org/show_bug.cgi?id=23116
  42761. The ResourceHandle becomes invalid (e.g. got destructed) from within
  42762. the invocation of didFail. Avoid this by cleaning up everything before
  42763. calling didFail and simply return afterwards.
  42764. This is happening with many tests from dom/html/level2/html e.g.
  42765. LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
  42766. * platform/network/soup/ResourceHandleSoup.cpp:
  42767. (WebCore::readCallback):
  42768. (WebCore::openCallback):
  42769. (WebCore::queryInfoCallback):
  42770. 2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
  42771. Reviewed by Simon Hausmann.
  42772. Change how themes adjust mediaControls.css to match html4/quicks.css
  42773. Instead of providing the full style sheet, the themes provide extra
  42774. overrides to the default style defined in UserAgentStyleSheetsData.
  42775. https://bugs.webkit.org/show_bug.cgi?id=23210
  42776. Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
  42777. build time for the Qt port.
  42778. * Resources/WebKitResources.qrc: Removed. Merged into WebCore.qrc
  42779. * WebCore.pro:
  42780. * WebCore.qrc: Added.
  42781. * css/CSSStyleSelector.cpp:
  42782. (WebCore::CSSStyleSelector::styleForElement):
  42783. * css/qt/mediaControls-extras.css: Rename from html4-adjustments-qt.css
  42784. * platform/qt/RenderThemeQt.cpp:
  42785. (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
  42786. * platform/qt/RenderThemeQt.h:
  42787. * platform/qt/WebCoreResources.qrc: Removed.
  42788. * platform/qt/html4-adjustments-qt.css: Rename to mediaControls-extras.css
  42789. * rendering/RenderTheme.cpp:
  42790. * rendering/RenderTheme.h:
  42791. (WebCore::RenderTheme::extraMediaControlsStyleSheet):
  42792. 2009-01-12 Gavin Barraclough <barraclough@apple.com>
  42793. Reviewed by Oliver Hunt.
  42794. Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
  42795. * bindings/js/JSSQLTransactionCustom.cpp:
  42796. (WebCore::JSSQLTransaction::executeSql):
  42797. * bindings/objc/WebScriptObject.mm:
  42798. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  42799. 2009-01-12 Chris Marrin <cmarrin@apple.com>
  42800. Reviewed by Dan Bernstein.
  42801. Fixed https://bugs.webkit.org/show_bug.cgi?id=22919
  42802. I added a common getElapsedTime() function to AnimationBase which uses a combination of
  42803. the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
  42804. states.
  42805. * page/animation/AnimationBase.cpp:
  42806. (WebCore::AnimationBase::progress):
  42807. (WebCore::AnimationBase::getElapsedTime):
  42808. * page/animation/AnimationBase.h:
  42809. * page/animation/KeyframeAnimation.cpp:
  42810. (WebCore::KeyframeAnimation::animate):
  42811. 2009-01-12 Robert Blaut <webkit@blaut.biz>
  42812. Reviewed by Darin Adler
  42813. Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
  42814. Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds
  42815. instead of miliseconds
  42816. Test: fast/css/webkit-marquee-speed-unit-in-quirksmode.html
  42817. * css/CSSParser.cpp:
  42818. (WebCore::CSSParser::validUnit): treat unitless values in quirks mode
  42819. as miliseconds instead of seconds.
  42820. 2009-01-12 David Hyatt <hyatt@apple.com>
  42821. Apply the same idea as the previous fix but for matched declarations.
  42822. Reviewed by Dan Bernstein
  42823. * css/CSSStyleSelector.h:
  42824. 2009-01-12 Brady Eidson <beidson@apple.com>
  42825. Reviewed by Darin Adler
  42826. <rdar://problem/6468274> - Track Non-get requests in global history
  42827. * WebCore.base.exp:
  42828. * history/HistoryItem.cpp:
  42829. (WebCore::HistoryItem::HistoryItem):
  42830. * history/HistoryItem.h:
  42831. (WebCore::HistoryItem::lastVisitWasHTTPNonGet):
  42832. (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
  42833. 2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
  42834. !ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header
  42835. so it can be used by all builds.
  42836. * platform/graphics/Font.h:
  42837. * platform/graphics/SimpleFontData.cpp:
  42838. * svg/SVGFontFaceElement.cpp:
  42839. * svg/SVGFontFaceElement.h:
  42840. 2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
  42841. wx build typo fix.
  42842. * platform/graphics/wx/TransformationMatrixWx.cpp:
  42843. (WebCore::TransformationMatrix::TransformationMatrix):
  42844. 2009-01-12 David Hyatt <hyatt@apple.com>
  42845. Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
  42846. elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.
  42847. Reviewed by Oliver Hunt
  42848. * css/CSSStyleSelector.h:
  42849. 2009-01-12 David Hyatt <hyatt@apple.com>
  42850. Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
  42851. two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
  42852. Tiny speedup.
  42853. Reviewed by Oliver Hunt
  42854. * dom/Element.cpp:
  42855. (WebCore::Element::attributeChanged):
  42856. 2009-01-12 David Hyatt <hyatt@apple.com>
  42857. Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
  42858. default to the normal case. Tiny speedup on PLT.
  42859. Reviewed by Oliver Hunt
  42860. * rendering/RenderFlow.cpp:
  42861. (WebCore::RenderFlow::lineHeight):
  42862. 2009-01-12 David Hyatt <hyatt@apple.com>
  42863. Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
  42864. in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
  42865. Reviewed by Oliver Hunt
  42866. * platform/ScrollView.cpp:
  42867. (WebCore::ScrollView::ScrollView):
  42868. 2009-01-12 Simon Fraser <simon.fraser@apple.com>
  42869. Reviewed by Dan Bernstein
  42870. https://bugs.webkit.org/show_bug.cgi?id=23273
  42871. In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
  42872. to be computed in absolute coordintes. Instead, we compute a repaintRect
  42873. relative to the RenderObject, which can repaint itself.
  42874. * rendering/RenderBox.cpp:
  42875. (WebCore::RenderBox::repaintLayerRectsForImage):
  42876. 2009-01-12 Simon Fraser <simon.fraser@apple.com>
  42877. Reviewed by Dan Bernstein
  42878. https://bugs.webkit.org/show_bug.cgi?id=23220
  42879. Merge layoutDelta into LayoutState. This requires that we
  42880. push even when layoutState is disabled, so that layoutDelta
  42881. can still be stored.
  42882. * rendering/LayoutState.cpp:
  42883. (WebCore::LayoutState::LayoutState):
  42884. * rendering/LayoutState.h:
  42885. (WebCore::LayoutState::LayoutState):
  42886. * rendering/RenderBlock.cpp:
  42887. (WebCore::RenderBlock::layoutBlock):
  42888. (WebCore::RenderBlock::layoutBlockChildren):
  42889. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  42890. * rendering/RenderBox.cpp:
  42891. (WebCore::RenderBox::localToAbsolute):
  42892. (WebCore::RenderBox::absoluteToLocal):
  42893. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  42894. * rendering/RenderFlexibleBox.cpp:
  42895. (WebCore::RenderFlexibleBox::layoutBlock):
  42896. * rendering/RenderFlow.cpp:
  42897. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  42898. * rendering/RenderLayer.cpp:
  42899. (WebCore::RenderLayer::updateLayerPositions):
  42900. * rendering/RenderTableCell.cpp:
  42901. (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
  42902. (WebCore::RenderTableCell::localToAbsolute):
  42903. * rendering/RenderView.cpp:
  42904. (WebCore::RenderView::pushLayoutState):
  42905. * rendering/RenderView.h:
  42906. (WebCore::RenderView::layoutDelta):
  42907. (WebCore::RenderView::addLayoutDelta):
  42908. (WebCore::RenderView::doingFullRepaint):
  42909. (WebCore::RenderView::pushLayoutState):
  42910. (WebCore::RenderView::popLayoutState):
  42911. (WebCore::RenderView::layoutStateEnabled):
  42912. (WebCore::RenderView::layoutState):
  42913. (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
  42914. (WebCore::LayoutStateMaintainer::push):
  42915. (WebCore::LayoutStateMaintainer::pop):
  42916. * rendering/bidi.cpp:
  42917. (WebCore::RenderBlock::layoutInlineChildren):
  42918. 2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
  42919. Reviewed by Holger Freyther.
  42920. [Qt] Build fix after turning the fontCache to a singleton
  42921. https://bugs.webkit.org/show_bug.cgi?id=23253
  42922. Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
  42923. * platform/graphics/qt/FontCacheQt.cpp:
  42924. (WebCore::fontCache):
  42925. (WebCore::FontCache::FontCache):
  42926. 2009-01-12 Eric Roman <eroman@chromium.org>
  42927. Reviewed by Darin Adler.
  42928. Fix some bugs with Selection::appendTrailingWhitespace().
  42929. https://bugs.webkit.org/show_bug.cgi?id=23232
  42930. Test: editing/selection/doubleclick-whitespace-crash.html
  42931. * editing/Selection.cpp:
  42932. (WebCore::makeSearchRange):
  42933. (WebCore::Selection::appendTrailingWhitespace):
  42934. 2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
  42935. Reviewed by Eric Seidel.
  42936. Add the first pieces of platform/graphics/chromium
  42937. https://bugs.webkit.org/show_bug.cgi?id=23257
  42938. * platform/graphics/chromium/ColorChromium.cpp: Added.
  42939. (WebCore::focusRingColor):
  42940. * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
  42941. (WebCore::FontCache::platformInit):
  42942. (WebCore::isStringASCII):
  42943. (WebCore::LookupAltName):
  42944. (WebCore::FontCodepage::):
  42945. (WebCore::FontCodepage::if):
  42946. (WebCore::createFontIndirectAndGetWinName):
  42947. (WebCore::fontContainsCharacter):
  42948. (WebCore::FontCache::getFontDataForCharacters):
  42949. (WebCore::FontCache::alternateFamilyName):
  42950. (WebCore::FontCache::getSimilarFontPlatformData):
  42951. (WebCore::FontCache::getLastResortFallbackFont):
  42952. (WebCore::toGDIFontWeight):
  42953. (WebCore::FontCache::getGenericFontForScript):
  42954. (WebCore::FillLogFont):
  42955. (WebCore::FontCache::fontExists):
  42956. (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
  42957. (WebCore::traitsInFamilyEnumProc):
  42958. (WebCore::FontCache::getTraitsInFamily):
  42959. (WebCore::FontCache::createFontPlatformData):
  42960. * platform/graphics/chromium/FontCacheLinux.cpp: Added.
  42961. (WebCore::FontCache::platformInit):
  42962. (WebCore::FontCache::getFontDataForCharacters):
  42963. (WebCore::FontCache::alternateFamilyName):
  42964. (WebCore::FontCache::getSimilarFontPlatformData):
  42965. (WebCore::FontCache::getLastResortFallbackFont):
  42966. (WebCore::FontCache::getTraitsInFamily):
  42967. (WebCore::FontCache::createFontPlatformData):
  42968. (WebCore::FontCache::getGenericFontForScript):
  42969. * platform/graphics/chromium/FontChromiumWin.cpp: Added.
  42970. (WebCore::windowsCanHandleTextDrawing):
  42971. (WebCore::skiaDrawText):
  42972. (WebCore::PaintSkiaText):
  42973. (WebCore::Font::drawGlyphs):
  42974. (WebCore::Font::selectionRectForComplexText):
  42975. (WebCore::Font::drawComplexText):
  42976. (WebCore::Font::floatWidthForComplexText):
  42977. (WebCore::Font::offsetForPositionForComplexText):
  42978. 2009-01-12 Darin Fisher <darin@chromium.org>
  42979. Reviewed by Eric Seidel.
  42980. https://bugs.webkit.org/show_bug.cgi?id=23254
  42981. Upstream page/chromium/
  42982. * page/chromium/AXObjectCacheChromium.cpp: Added.
  42983. (WebCore::AXObjectCache::detachWrapper):
  42984. (WebCore::AXObjectCache::attachWrapper):
  42985. (WebCore::AXObjectCache::postNotification):
  42986. (WebCore::AXObjectCache::postNotificationToElement):
  42987. (WebCore::AXObjectCache::handleFocusedUIElementChanged):
  42988. * page/chromium/AccessibilityObjectChromium.cpp:
  42989. * page/chromium/AccessibilityObjectWrapper.h:
  42990. * page/chromium/ChromeClientChromium.h: Added.
  42991. * page/chromium/DragControllerChromium.cpp: Added.
  42992. (WebCore::DragController::dragOperation):
  42993. (WebCore::DragController::isCopyKeyDown):
  42994. (WebCore::DragController::maxDragImageSize):
  42995. (WebCore::DragController::cleanupAfterSystemDrag):
  42996. * page/chromium/EventHandlerChromium.cpp: Added.
  42997. (WebCore::EventHandler::passMousePressEventToSubframe):
  42998. (WebCore::EventHandler::passMouseMoveEventToSubframe):
  42999. (WebCore::EventHandler::passMouseReleaseEventToSubframe):
  43000. (WebCore::EventHandler::passWheelEventToWidget):
  43001. (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  43002. (WebCore::EventHandler::passMouseDownEventToWidget):
  43003. (WebCore::EventHandler::tabsToAllControls):
  43004. (WebCore::EventHandler::eventActivatedView):
  43005. (WebCore::EventHandler::createDraggingClipboard):
  43006. (WebCore::EventHandler::focusDocumentView):
  43007. (WebCore::EventHandler::accessKeyModifiers):
  43008. * page/chromium/FrameChromium.cpp: Added.
  43009. (WebCore::computePageRectsForFrame):
  43010. (WebCore::Frame::dragImageForSelection):
  43011. * page/chromium/FrameChromium.h: Added.
  43012. 2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
  43013. Reviewed by Darin Adler.
  43014. https://bugs.webkit.org/show_bug.cgi?id=22936
  43015. Fix uninitialized memory read error, reported by Purify.
  43016. * platform/graphics/SimpleFontData.cpp:
  43017. (WebCore::SimpleFontData::SimpleFontData): Added initializer for
  43018. m_unitsPerEm using cDefaultUnitsPerEm constant.
  43019. * svg/SVGFontFaceElement.cpp:
  43020. (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
  43021. the constant.
  43022. * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
  43023. 2009-01-12 Adam Treat <adam.treat@torchmobile.com>
  43024. Reviewed by George Staikos.
  43025. Do not set fixedLayoutSize for anything other than the mainframe during
  43026. the transition as this is a page level state like the viewportSize.
  43027. * loader/FrameLoaderClient.cpp:
  43028. (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
  43029. 2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
  43030. Reviewed by Darin Adler.
  43031. Bug 22861: Turn the FontCache into a singleton
  43032. https://bugs.webkit.org/show_bug.cgi?id=22861
  43033. - Added fontCache() to get the global FontCache.
  43034. - Made all the methods in FontCache instance method.
  43035. - Changed FontCache:: to fontCache()-> in WebCore.
  43036. * WebCore.base.exp: Now export fontCache().
  43037. * css/CSSFontFaceSource.cpp:
  43038. (WebCore::CSSFontFaceSource::getFontData):
  43039. * css/CSSFontSelector.cpp:
  43040. (WebCore::CSSFontSelector::CSSFontSelector):
  43041. (WebCore::CSSFontSelector::~CSSFontSelector):
  43042. (WebCore::CSSFontSelector::addFontFaceRule):
  43043. (WebCore::fontDataForGenericFamily):
  43044. * platform/graphics/Font.cpp:
  43045. (WebCore::Font::glyphDataForCharacter):
  43046. * platform/graphics/FontCache.cpp:
  43047. (WebCore::fontCache):
  43048. (WebCore::FontCache::FontCache):
  43049. * platform/graphics/FontCache.h:
  43050. * platform/graphics/FontFallbackList.cpp:
  43051. (WebCore::FontFallbackList::FontFallbackList):
  43052. (WebCore::FontFallbackList::invalidate):
  43053. (WebCore::FontFallbackList::releaseFontData):
  43054. (WebCore::FontFallbackList::fontDataAt):
  43055. (WebCore::FontFallbackList::fontDataForCharacters):
  43056. (WebCore::FontFallbackList::setPlatformFont):
  43057. * platform/graphics/SimpleFontData.cpp:
  43058. (WebCore::SimpleFontData::~SimpleFontData):
  43059. * platform/graphics/mac/FontCacheMac.mm:
  43060. (WebCore::fontCacheATSNotificationCallback):
  43061. * platform/graphics/mac/SimpleFontDataMac.mm:
  43062. (WebCore::SimpleFontData::smallCapsFontData):
  43063. * platform/graphics/win/FontCacheWin.cpp:
  43064. (WebCore::getCJKCodePageMasks):
  43065. * platform/graphics/win/SimpleFontDataWin.cpp:
  43066. (WebCore::SimpleFontData::containsCharacters):
  43067. 2009-01-11 Darin Adler <darin@apple.com>
  43068. Reviewed by Dan Bernstein.
  43069. Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
  43070. https://bugs.webkit.org/show_bug.cgi?id=23247
  43071. Also fix problems where partially parsed paths will still have an effect
  43072. rather than failing parsing and being ignored.
  43073. Test: dom/path-segments.html
  43074. * platform/graphics/Path.h:
  43075. (WebCore::Path::swap): Added.
  43076. * svg/SVGParserUtilities.cpp:
  43077. (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
  43078. (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
  43079. (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
  43080. parsing fails.
  43081. (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
  43082. not directly into the segment list.
  43083. (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
  43084. (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
  43085. (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
  43086. (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
  43087. (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
  43088. (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
  43089. (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
  43090. (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
  43091. (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
  43092. * svg/SVGPathSegCurvetoCubicSmooth.h:
  43093. (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
  43094. Set y2 to y2, not to y.
  43095. 2009-01-11 Darin Adler <darin@apple.com>
  43096. Reviewed by Oliver Hunt.
  43097. Bug 23102: turn on unused parameter warnings in WebCore
  43098. https://bugs.webkit.org/show_bug.cgi?id=23102
  43099. Fourth step: Remove arguments entirely in the many cases where they are not
  43100. needed at all. This step is a little less mechanical than the earlier ones.
  43101. * dom/DOMImplementation.cpp:
  43102. (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
  43103. the regular expression, since we already specify a-zA-Z in our expression.
  43104. * dom/Document.cpp:
  43105. (WebCore::Document::databaseThread): Don't pass in the document when creating
  43106. a DatabaseThread.
  43107. * dom/Element.cpp:
  43108. (WebCore::Element::createRareData): Don't pass the element when creating an
  43109. ElementRareData.
  43110. (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
  43111. (WebCore::Element::recalcStyle): Ditto.
  43112. * dom/ElementRareData.h: Remove the unused Element* from the constructor and
  43113. the resetComputedStyle function.
  43114. * dom/EventTargetNode.cpp:
  43115. (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
  43116. (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
  43117. (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
  43118. * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
  43119. * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
  43120. (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
  43121. start and end arguments.
  43122. (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
  43123. and end to pushDownTextDecorationStyleAroundNode.
  43124. * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
  43125. unused start and end arguments from pushDownTextDecorationStyleAroundNode.
  43126. * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
  43127. * html/HTMLTokenizer.cpp:
  43128. (WebCore::Token::addAttribute): Removed unused Document* argument.
  43129. (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
  43130. * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
  43131. * page/DOMWindow.cpp:
  43132. (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
  43133. * page/DragController.cpp:
  43134. (WebCore::DragController::dragIsMove): Removed unused DragData argument.
  43135. (WebCore::DragController::performDrag): Call concludeEditDrag rather than
  43136. concludeDrag.
  43137. (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
  43138. (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
  43139. should only be called for edit drags. Removed the action mask argument. Also
  43140. changed dragIsMove call sites to not pass dragData.
  43141. * page/DragController.h: Updated for above changes and tweaked comment format.
  43142. * page/Frame.cpp:
  43143. (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
  43144. when creating regular expressions for clarity. Call match instead of search,
  43145. since both do the same thing except for with negative start offsets, and none
  43146. used here are negative.
  43147. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  43148. * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
  43149. * page/mac/AccessibilityObjectWrapper.mm:
  43150. (AXAttributeStringSetHeadingLevel): Removed unused object argument.
  43151. (AXAttributedStringAppendText): Ditto.
  43152. (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
  43153. * page/mac/FrameMac.mm:
  43154. (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
  43155. when creating regular expressions for clarity. Call match instead of search,
  43156. since both do the same thing except for with negative start offsets, and none
  43157. used here are negative.
  43158. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  43159. * platform/graphics/SegmentedFontData.cpp:
  43160. (WebCore::SegmentedFontData::containsCharacter): Added.
  43161. (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
  43162. instead of just the first one, using containsCharacter.
  43163. * platform/graphics/SegmentedFontData.h: Made more members private.
  43164. Added containsCharacter function member.
  43165. * platform/mac/DragImageMac.mm:
  43166. (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
  43167. DragImageRef for clarity, since this is platform-specific code.
  43168. (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
  43169. variable warning.
  43170. (WebCore::scaleDragImage): Ditto.
  43171. (WebCore::dissolveDragImageToFraction): Ditto.
  43172. (WebCore::createDragImageFromImage): Ditto.
  43173. (WebCore::createDragImageIconForCachedImage): Ditto.
  43174. * platform/mac/WebFontCache.mm:
  43175. (acceptableChoice): Removed the unused weight-related arguments.
  43176. (betterChoice): Ditto.
  43177. (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
  43178. * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
  43179. because we'd rather get a link error rather than a runtime error if we use it
  43180. for anything, and right now it's not used.
  43181. * platform/text/RegularExpression.cpp: Removed unused private data,
  43182. including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
  43183. and lastMatchPos. Made the RegularExpression::Private::regex be private
  43184. and use an accessor function to get at it.
  43185. (WebCore::RegularExpression::RegularExpression): Removed the const char* version
  43186. of the constructor because it's not any more efficient. Changed the boolean
  43187. constructor argument to use TextCaseSensitivity instead to make it less likely
  43188. we'll use it wrong.
  43189. (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
  43190. just use plain old assignment on it. The only reason we do this instead of using
  43191. the compiler generated assignment operator is that we want the Private structure
  43192. to be internal to the .cpp file.
  43193. (WebCore::RegularExpression::match): Added a null check so we won't crash if
  43194. we fail to compile the regular expression. Removed the code to handle multiple
  43195. match strings, since that was unused.
  43196. * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
  43197. TextCaseSensitivity and not have a default value. Removed the default constructor,
  43198. and the pattern, match, and pos functions.
  43199. * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
  43200. Page.h, because we should eventually use it in all the places where we have
  43201. an argument to control case sensitivity, starting with the functions in this
  43202. class.
  43203. * platform/text/mac/ShapeArabic.c:
  43204. (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
  43205. this is code borrowed from ICU, this seems like a simple safe change to make.
  43206. (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
  43207. * rendering/RenderPath.cpp:
  43208. (WebCore::RenderPath::RenderPath): Removed the unused style argument.
  43209. Also removed the type check. The argument already has the correct type,
  43210. so it's not helpful to upcast it and then check its type again, unless
  43211. we have some reason to believe the type is not reliable. And we don't.
  43212. * rendering/RenderPath.h: Removed the RenderStyle* argument to the
  43213. constructor. Also removed the explicit declaration of the destructor.
  43214. It's not helpful or needed.
  43215. * rendering/RenderSVGInlineText.cpp:
  43216. (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
  43217. make it clear that just returning an empty rect is not a good implementation.
  43218. Removed the argument names to get rid of the warning.
  43219. * rendering/RenderTreeAsText.cpp:
  43220. (WebCore::printBorderStyle): Removed the unused RenderObject argument.
  43221. (WebCore::operator<<): Updated for the change to printBorderStyle function.
  43222. * storage/DatabaseThread.cpp:
  43223. (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
  43224. * storage/DatabaseThread.h: Ditto.
  43225. * storage/LocalStorage.cpp:
  43226. (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
  43227. * storage/LocalStorage.h: Ditto.
  43228. * svg/SVGElement.cpp:
  43229. (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
  43230. code location to dispatchGenericEvent.
  43231. * svg/SVGElementInstance.cpp:
  43232. (WebCore::SVGElementInstance::dispatchEvent): Ditto.
  43233. * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
  43234. (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
  43235. the RenderPath constructor.
  43236. * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
  43237. * xml/XSLTProcessor.cpp:
  43238. (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
  43239. (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
  43240. 2009-01-11 Alexey Proskuryakov <ap@webkit.org>
  43241. Reviewed by Darin Adler.
  43242. https://bugs.webkit.org/show_bug.cgi?id=23165
  43243. Disable application cache dynamic entries support.
  43244. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  43245. * loader/appcache/DOMApplicationCache.idl:
  43246. 2009-01-11 Adam Treat <adam.treat@torchmobile.com>
  43247. Reviewed by Darin Adler.
  43248. Correct coordinate transformation for deeply nested frames on resizing. This
  43249. fixes https://bugs.webkit.org/show_bug.cgi?id=20766.
  43250. Test: fast/frames/frame-deep-nested-resize.html
  43251. * rendering/RenderFrameSet.cpp:
  43252. (WebCore::RenderFrameSet::userResize):
  43253. 2009-01-11 Mark Rowe <mrowe@apple.com>
  43254. Tiger build fix. The connection parameter is still used on Tiger in this method.
  43255. * platform/network/mac/ResourceHandleMac.mm:
  43256. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
  43257. 2009-01-11 Darin Adler <darin@apple.com>
  43258. Reviewed by Dan Bernstein.
  43259. Bug 23102: turn on unused parameter warnings in WebCore
  43260. https://bugs.webkit.org/show_bug.cgi?id=23102
  43261. Third step: Deal with cases of arguments used only in assertions.
  43262. * dom/MessagePort.cpp:
  43263. (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
  43264. * dom/Worker.cpp:
  43265. (WebCore::Worker::notifyFinished): Ditto.
  43266. * dom/XMLTokenizer.cpp:
  43267. (WebCore::XMLTokenizer::notifyFinished): Ditto.
  43268. * loader/appcache/ApplicationCacheGroup.cpp:
  43269. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
  43270. * loader/appcache/ApplicationCacheStorage.cpp:
  43271. (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
  43272. * loader/icon/IconLoader.cpp:
  43273. (WebCore::IconLoader::didReceiveData): Since loader and size are only
  43274. used when logging, use UNUSED_PARAM when logging is disabled.
  43275. * platform/mac/WidgetMac.mm:
  43276. (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
  43277. * platform/network/mac/ResourceHandleMac.mm:
  43278. (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
  43279. argument since it's probably a tiny bit more efficient and gets rid
  43280. of the unused argument warning.
  43281. * rendering/RenderListMarker.cpp:
  43282. (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
  43283. * rendering/RenderObject.cpp:
  43284. (WebCore::RenderObject::createInlineBox): Ditto.
  43285. * rendering/RenderSVGInline.cpp:
  43286. (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
  43287. I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
  43288. the only use for two different arguments.
  43289. * rendering/RenderText.cpp:
  43290. (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
  43291. * rendering/RenderThemeMac.mm:
  43292. (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
  43293. 2009-01-11 Simon Fraser <simon.fraser@apple.com>
  43294. Reviewed by Oliver Hunt
  43295. https://bugs.webkit.org/show_bug.cgi?id=23242
  43296. Fix CanvasRenderingContext2D::transform to do a pre-multiply,
  43297. rather than a post-multiply into m_transform. This bug did not affect
  43298. drawing, but did cause m_transform to be incorrect, which impacted
  43299. willDraw(), and isPointInPath.
  43300. Test: fast/canvas/canvas-incremental-repaint-2.html
  43301. * html/CanvasRenderingContext2D.cpp:
  43302. (WebCore::CanvasRenderingContext2D::transform):
  43303. 2009-01-11 Darin Adler <darin@apple.com>
  43304. Reviewed by Dan Bernstein.
  43305. Bug 23102: turn on unused parameter warnings in WebCore
  43306. https://bugs.webkit.org/show_bug.cgi?id=23102
  43307. Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
  43308. That's because you can't omit an argument name in Objective-C methods.
  43309. * bindings/objc/DOMObject.mm:
  43310. (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
  43311. the word "unused" so we don't just start using it without removing the macro.
  43312. * bindings/objc/WebScriptObject.mm:
  43313. (+[WebUndefined allocWithZone:]): Ditto.
  43314. (-[WebUndefined initWithCoder:]): Ditto.
  43315. (-[WebUndefined encodeWithCoder:]): Ditto.
  43316. (-[WebUndefined copyWithZone:]): Ditto.
  43317. * page/mac/WebDashboardRegion.m:
  43318. (-[WebDashboardRegion copyWithZone:]): Ditto.
  43319. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  43320. (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
  43321. (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
  43322. (-[WebCoreMovieObserver rateChanged:]): Ditto.
  43323. (-[WebCoreMovieObserver sizeChanged:]): Ditto.
  43324. (-[WebCoreMovieObserver timeChanged:]): Ditto.
  43325. (-[WebCoreMovieObserver didEnd:]): Ditto.
  43326. (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
  43327. * platform/mac/ScrollbarThemeMac.mm:
  43328. (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
  43329. (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
  43330. * platform/mac/SharedTimerMac.mm:
  43331. (-[WebCorePowerNotifier didWake:]): Ditto.
  43332. * platform/mac/WebCoreKeyGenerator.m:
  43333. (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
  43334. * platform/network/mac/ResourceHandleMac.mm:
  43335. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
  43336. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
  43337. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
  43338. (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
  43339. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
  43340. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
  43341. (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
  43342. (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
  43343. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
  43344. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
  43345. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
  43346. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
  43347. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
  43348. (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
  43349. (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
  43350. (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
  43351. (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
  43352. 2009-01-11 Dirk Schulze <krit@webkit.org>
  43353. Reviewed by Darin Adler.
  43354. Move platform dependent strokeContains back to RenderPath, Path and delete
  43355. unneeded Code in svg.
  43356. RenderPath clean-up for strokeContains
  43357. [https://bugs.webkit.org/show_bug.cgi?id=22957]
  43358. * GNUmakefile.am:
  43359. * WebCore.pro:
  43360. * WebCore.vcproj/WebCore.vcproj:
  43361. * WebCore.xcodeproj/project.pbxproj:
  43362. * platform/graphics/Path.h:
  43363. * platform/graphics/cairo/PathCairo.cpp:
  43364. (WebCore::Path::strokeContains):
  43365. * platform/graphics/cg/PathCG.cpp:
  43366. (WebCore::Path::strokeContains):
  43367. * platform/graphics/qt/PathQt.cpp:
  43368. (WebCore::Path::strokeContains):
  43369. * rendering/RenderPath.cpp:
  43370. (WebCore::RenderPath::strokeContains):
  43371. * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
  43372. * svg/graphics/cg/CgSupport.cpp: Removed.
  43373. * svg/graphics/cg/CgSupport.h: Removed.
  43374. * svg/graphics/cg/RenderPathCg.cpp: Removed.
  43375. * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
  43376. * svg/graphics/cg/SVGResourceMaskerCg.mm:
  43377. * svg/graphics/qt/RenderPathQt.cpp: Removed.
  43378. 2009-01-11 Holger Hans Peter Freyther <zecke@selfish.org>
  43379. Reviewed by Anders Carlsson.
  43380. [GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h
  43381. make distcheck pass by adding JSWorkerContextBase.lut.h to the
  43382. CLEANFILES that will be cleaned on a make distclean.
  43383. * GNUmakefile.am:
  43384. 2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
  43385. Reviewed by Alexey Proskuryakov.
  43386. https://bugs.webkit.org/show_bug.cgi?id=23235
  43387. Build fix for non-VIDEO builds.
  43388. * rendering/RenderTheme.cpp:
  43389. * rendering/RenderTheme.h:
  43390. 2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
  43391. Reviewed by Darin Adler.
  43392. https://bugs.webkit.org/show_bug.cgi?id=19287
  43393. return value of malloc() is not checked in npruntime.cpp
  43394. Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
  43395. (like in fastMalloc).
  43396. * bridge/npruntime.cpp:
  43397. (_NPN_GetStringIdentifier):
  43398. (_NPN_GetIntIdentifier):
  43399. (NPN_InitializeVariantWithStringCopy):
  43400. (_NPN_CreateObject):
  43401. 2009-01-11 Glenn Wilson <gwilson@google.com>
  43402. Reviewed by Darin Adler.
  43403. Changes radio buttons so they can be 'checked' even if they
  43404. don't have the name attribute set.
  43405. See https://bugs.webkit.org/show_bug.cgi?id=21534
  43406. Test: fast/html/select-unnamed-radio.html
  43407. * html/HTMLInputElement.cpp:
  43408. (WebCore::HTMLInputElement::preDispatchEventHandler):
  43409. 2009-01-11 Bernhard Rosenkraenzer <bero@arklinux.ch>
  43410. Reviewed by Darin Adler.
  43411. https://bugs.webkit.org/show_bug.cgi?id=22205
  43412. Fix compatibility with bison 2.4, partially based on older patch by
  43413. Priit Laes <amd@store20.com>
  43414. * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
  43415. 2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
  43416. Reviewed by Darin Adler.
  43417. https://bugs.webkit.org/show_bug.cgi?id=16001
  43418. Incorrect assumption that selection is always contiguous LTR.
  43419. Test: editing/selection/extend-selection-bidi.html
  43420. * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
  43421. Make this function not assume a contiguous visual LTR selection range.
  43422. 2009-01-11 Dmitry Titov <dimich@chromium.org>
  43423. Reviewed by Darin Adler.
  43424. https://bugs.webkit.org/show_bug.cgi?id=23207
  43425. Moved currentTime() to from WebCore to WTF.
  43426. Most of these files only have a different header file included.
  43427. Various build files reflect removal of SystemTimeGtk, Wx, Qt and Linux
  43428. which were removed since they only implemented currentTime().
  43429. * ForwardingHeaders/wtf/CurrentTime.h: Added.
  43430. * GNUmakefile.am:
  43431. * WebCore.base.exp:
  43432. * WebCore.pro:
  43433. * dom/ContainerNode.cpp:
  43434. * dom/Document.cpp:
  43435. * dom/Event.cpp:
  43436. * history/CachedPage.cpp:
  43437. * history/PageCache.cpp:
  43438. * html/HTMLMediaElement.cpp:
  43439. (WebCore::HTMLMediaElement::load):
  43440. (WebCore::HTMLMediaElement::progressEventTimerFired):
  43441. * html/HTMLTokenizer.cpp:
  43442. * html/PreloadScanner.cpp:
  43443. * inspector/InspectorController.cpp:
  43444. * loader/Cache.cpp:
  43445. (WebCore::Cache::pruneLiveResources):
  43446. * loader/CachedImage.cpp:
  43447. * loader/CachedResource.cpp:
  43448. * loader/FrameLoader.cpp:
  43449. * loader/ProgressTracker.cpp:
  43450. * loader/icon/IconDatabase.cpp:
  43451. * loader/icon/IconRecord.cpp:
  43452. * page/DragController.cpp:
  43453. * page/Frame.cpp:
  43454. * page/FrameView.cpp:
  43455. * page/animation/AnimationBase.cpp:
  43456. * page/animation/AnimationController.cpp:
  43457. * page/animation/KeyframeAnimation.cpp:
  43458. * platform/SystemTime.h:
  43459. * platform/Timer.cpp:
  43460. * platform/graphics/BitmapImage.cpp:
  43461. * platform/gtk/MouseEventGtk.cpp:
  43462. * platform/gtk/SharedTimerGtk.cpp:
  43463. * platform/gtk/SystemTimeGtk.cpp: Removed.
  43464. * platform/gtk/SystemTimeLinux.cpp: Removed.
  43465. * platform/mac/SystemTimeMac.cpp:
  43466. * platform/qt/PlatformMouseEventQt.cpp:
  43467. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  43468. * platform/qt/SharedTimerQt.cpp:
  43469. * platform/qt/SharedTimerQt.h:
  43470. * platform/qt/SystemTimeQt.cpp: Removed.
  43471. * platform/win/SharedTimerWin.cpp:
  43472. * platform/win/SystemTimeWin.cpp:
  43473. * platform/wx/MouseEventWx.cpp:
  43474. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  43475. * platform/wx/SharedTimerWx.cpp:
  43476. * platform/wx/SystemTimeWx.cpp: Removed.
  43477. * rendering/RenderImage.cpp:
  43478. * rendering/RenderMedia.cpp:
  43479. * svg/animation/SMILTimeContainer.cpp:
  43480. * webcore-wx.bkl:
  43481. * xml/XMLHttpRequest.cpp:
  43482. 2009-01-11 Dmitry Titov <dimich@chromium.org>
  43483. Reviewed by Darin Adler.
  43484. Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
  43485. Part of 'Timers in Workers' work.
  43486. https://bugs.webkit.org/show_bug.cgi?id=23223
  43487. * bindings/js/ScheduledAction.cpp:
  43488. (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
  43489. (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
  43490. * bindings/js/ScheduledAction.h:
  43491. 2009-01-10 Eric Carlson <eric.carlson@apple.com>
  43492. Reviewed by Eric Seidel.
  43493. https://bugs.webkit.org/show_bug.cgi?id=23210
  43494. Make it easier for ports to define custom UI for media controls
  43495. * css/CSSStyleSelector.cpp:
  43496. (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
  43497. get the media controller style sheet
  43498. * rendering/MediaControlElements.cpp:
  43499. (WebCore::MediaControlInputElement::hitTest): Added
  43500. * rendering/MediaControlElements.h: Updated
  43501. * rendering/RenderMedia.cpp:
  43502. (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
  43503. so control elements don't necessarily have to be rectangular
  43504. * rendering/RenderTheme.cpp:
  43505. (WebCore::RenderTheme::styleSheetForMediaControls): Added
  43506. (WebCore::RenderTheme::hitTestMediaControlPart): Added
  43507. * rendering/RenderTheme.h: Updated
  43508. 2009-01-10 Simon Fraser <simon.fraser@apple.com>
  43509. Reviewed by Dan Bernstein
  43510. https://bugs.webkit.org/show_bug.cgi?id=23222
  43511. We need to disable LayoutState when an object has transforms,
  43512. because LayoutState is not transform-aware and therefore
  43513. repaint rects can be computed incorrectly.
  43514. Test: fast/repaint/transform-disable-layoutstate.html
  43515. * rendering/RenderBlock.cpp:
  43516. (WebCore::RenderBlock::layoutBlock):
  43517. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  43518. * rendering/RenderFlexibleBox.cpp:
  43519. (WebCore::RenderFlexibleBox::layoutBlock):
  43520. 2009-01-09 Holger Hans Peter Freyther <zecke@selfish.org>
  43521. Reviewed by Simon Hausmann.
  43522. [QT] Make SharedTimer use QBasicTimer
  43523. Kill the SharedTimerQt.h and the usage of signal and slots
  43524. by using QBasicTimer.
  43525. * WebCore.pro:
  43526. * platform/qt/SharedTimerQt.cpp:
  43527. (WebCore::SharedTimerQt::SharedTimerQt):
  43528. (WebCore::SharedTimerQt::inst):
  43529. (WebCore::SharedTimerQt::start):
  43530. (WebCore::SharedTimerQt::stop):
  43531. (WebCore::SharedTimerQt::timerEvent):
  43532. (WebCore::setSharedTimerFiredFunction):
  43533. (WebCore::setSharedTimerFireTime):
  43534. (WebCore::stopSharedTimer):
  43535. * platform/qt/SharedTimerQt.h: Removed.
  43536. 2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
  43537. Reviewed by Holger Freyther.
  43538. [CURL] POST without body becomes GET
  43539. https://bugs.webkit.org/show_bug.cgi?id=23182
  43540. Make sure that method is always set to POST even when the body is
  43541. empty. Cleaned up httpBody null check.
  43542. * platform/network/curl/ResourceHandleManager.cpp:
  43543. (WebCore::ResourceHandleManager::setupPOST):
  43544. 2009-01-09 Adam Treat <adam.treat@torchmobile.com>
  43545. Build fix.
  43546. * plugins/PluginView.cpp:
  43547. 2009-01-09 Adele Peterson <adele@apple.com>
  43548. Reviewed by Darin Adler.
  43549. Fix infinite recursion in clientPaddingLeft and clientPaddingRight. This changes the code back to
  43550. how it was before RenderTextControlSingleLine was split out from RenderTextControl.
  43551. No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
  43552. * rendering/RenderTextControlSingleLine.cpp:
  43553. (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
  43554. (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  43555. 2009-01-09 Darin Adler <darin@apple.com>
  43556. Reviewed by Jon Honeycutt.
  43557. Bug 22913: REGRESSION: Space bar doesn't scroll on windows
  43558. https://bugs.webkit.org/show_bug.cgi?id=22913
  43559. rdar://problem/6479834
  43560. * page/EventHandler.cpp:
  43561. (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
  43562. defaultSpaceEventHandler.
  43563. (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
  43564. on the shift key.
  43565. * page/EventHandler.h: Added defaultSpaceEventHandler.
  43566. * platform/mac/ScrollViewMac.mm:
  43567. (WebCore::ScrollView::platformScroll): Return false, because this function does
  43568. not scroll. In an earlier version of this patch, I used this to prevent the
  43569. patch from affecting the Mac, but I decided to use #if instead.
  43570. 2009-01-09 Gavin Barraclough <barraclough@apple.com>
  43571. Reviewed by Oliver Hunt.
  43572. Delete references to JSValue, removing this class.
  43573. * bindings/js/JSWorkerContextCustom.cpp:
  43574. (WebCore::JSWorkerContext::self):
  43575. * bindings/js/ScriptCallStack.h:
  43576. 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
  43577. Reviewed by Eric Seidel.
  43578. Add svg/graphics/skia files.
  43579. https://bugs.webkit.org/show_bug.cgi?id=23147
  43580. * svg/graphics/skia/RenderPathSkia.cpp: Added.
  43581. (WebCore::RenderPath::strokeContains):
  43582. * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
  43583. (WebCore::SVGPaintServerPattern::setup):
  43584. * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
  43585. (WebCore::SVGPaintServer::draw):
  43586. (WebCore::SVGPaintServer::teardown):
  43587. (WebCore::SVGPaintServer::renderPath):
  43588. * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
  43589. (WebCore::SVGResourceFilter::createPlatformData):
  43590. (WebCore::SVGResourceFilter::prepareFilter):
  43591. (WebCore::SVGResourceFilter::applyFilter):
  43592. * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
  43593. (WebCore::SVGResourceMasker::applyMask):
  43594. 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
  43595. Reviewed by Eric Seidel.
  43596. Add SkiaFontWin to platform/graphics/chromium
  43597. https://bugs.webkit.org/show_bug.cgi?id=23215
  43598. * platform/graphics/skia/SkiaFontWin.cpp: Added.
  43599. (WebCore::CachedOutlineKey::CachedOutlineKey):
  43600. (WebCore::operator==):
  43601. (WebCore::CachedOutlineKeyHash::hash):
  43602. (WebCore::CachedOutlineKeyHash::equal):
  43603. (WebCore::FIXEDToSkScalar):
  43604. (WebCore::deleteOutline):
  43605. (WebCore::addPolyCurveToPath):
  43606. (WebCore::getPathForGlyph):
  43607. (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
  43608. (WebCore::SkiaWinOutlineCache::removePathsForFont):
  43609. * platform/graphics/skia/SkiaFontWin.h: Added.
  43610. 2009-01-09 Anders Carlsson <andersca@apple.com>
  43611. Fix build.
  43612. * WebCore.LP64.exp:
  43613. 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
  43614. Reviewed by Eric Seidel.
  43615. Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
  43616. https://bugs.webkit.org/show_bug.cgi?id=23215
  43617. * platform/graphics/skia/PlatformContextSkia.cpp: Added.
  43618. (PlatformContextSkia::State::State):
  43619. (PlatformContextSkia::State::~State):
  43620. (PlatformContextSkia::State::applyAlpha):
  43621. (PlatformContextSkia::PlatformContextSkia):
  43622. (PlatformContextSkia::~PlatformContextSkia):
  43623. (PlatformContextSkia::setCanvas):
  43624. (PlatformContextSkia::save):
  43625. (PlatformContextSkia::restore):
  43626. (PlatformContextSkia::drawRect):
  43627. (PlatformContextSkia::setupPaintCommon):
  43628. (PlatformContextSkia::setupPaintForFilling):
  43629. (PlatformContextSkia::setupPaintForStroking):
  43630. (PlatformContextSkia::setDrawLooper):
  43631. (PlatformContextSkia::setMiterLimit):
  43632. (PlatformContextSkia::setAlpha):
  43633. (PlatformContextSkia::setLineCap):
  43634. (PlatformContextSkia::setLineJoin):
  43635. (PlatformContextSkia::setPorterDuffMode):
  43636. (PlatformContextSkia::setFillColor):
  43637. (PlatformContextSkia::getDrawLooper):
  43638. (PlatformContextSkia::getStrokeStyle):
  43639. (PlatformContextSkia::setStrokeStyle):
  43640. (PlatformContextSkia::setStrokeColor):
  43641. (PlatformContextSkia::getStrokeThickness):
  43642. (PlatformContextSkia::setStrokeThickness):
  43643. (PlatformContextSkia::getTextDrawingMode):
  43644. (PlatformContextSkia::setTextDrawingMode):
  43645. (PlatformContextSkia::setUseAntialiasing):
  43646. (PlatformContextSkia::fillColor):
  43647. (PlatformContextSkia::beginPath):
  43648. (PlatformContextSkia::addPath):
  43649. (PlatformContextSkia::setFillRule):
  43650. (PlatformContextSkia::setGradient):
  43651. (PlatformContextSkia::setPattern):
  43652. (PlatformContextSkia::setDashPathEffect):
  43653. (PlatformContextSkia::paintSkPaint):
  43654. (PlatformContextSkia::bitmap):
  43655. (PlatformContextSkia::isPrinting):
  43656. * platform/graphics/skia/PlatformContextSkia.h: Added.
  43657. (PlatformContextSkia::currentPath):
  43658. (PlatformContextSkia::canvas):
  43659. (PlatformContextSkia::gdk_skia):
  43660. * platform/graphics/skia/PlatformGraphics.h: Added.
  43661. 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
  43662. Reviewed by Eric Seidel.
  43663. Add TransformationMatrixSkia to platform/graphics/skia
  43664. https://bugs.webkit.org/show_bug.cgi?id=23215
  43665. * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
  43666. (WebCore::TransformationMatrix::TransformationMatrix):
  43667. (WebCore::TransformationMatrix::setMatrix):
  43668. (WebCore::TransformationMatrix::map):
  43669. (WebCore::TransformationMatrix::mapRect):
  43670. (WebCore::TransformationMatrix::isIdentity):
  43671. (WebCore::TransformationMatrix::reset):
  43672. (WebCore::TransformationMatrix::scale):
  43673. (WebCore::TransformationMatrix::rotate):
  43674. (WebCore::TransformationMatrix::translate):
  43675. (WebCore::TransformationMatrix::shear):
  43676. (WebCore::TransformationMatrix::det):
  43677. (WebCore::TransformationMatrix::inverse):
  43678. (WebCore::TransformationMatrix::operator SkMatrix):
  43679. (WebCore::TransformationMatrix::operator==):
  43680. (WebCore::TransformationMatrix::operator*=):
  43681. (WebCore::TransformationMatrix::operator*):
  43682. (WebCore::TransformationMatrix::a):
  43683. (WebCore::TransformationMatrix::setA):
  43684. (WebCore::TransformationMatrix::b):
  43685. (WebCore::TransformationMatrix::setB):
  43686. (WebCore::TransformationMatrix::c):
  43687. (WebCore::TransformationMatrix::setC):
  43688. (WebCore::TransformationMatrix::d):
  43689. (WebCore::TransformationMatrix::setD):
  43690. (WebCore::TransformationMatrix::e):
  43691. (WebCore::TransformationMatrix::setE):
  43692. (WebCore::TransformationMatrix::f):
  43693. (WebCore::TransformationMatrix::setF):
  43694. 2009-01-09 Alexey Proskuryakov <ap@webkit.org>
  43695. Reviewed by Darin Adler.
  43696. <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
  43697. Test: http/tests/appcache/reload.html
  43698. On Windows, reloading resulted in the following sequence of events:
  43699. 1) A new main resource loader was created and associated with the cache. Its document loader
  43700. was not associated with the cache yet.
  43701. 2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
  43702. teardown started, with newestCache being zeroed out.
  43703. 3) The new document loader was associated with the cache group, and cache update started.
  43704. 4) Since newestCache was null, this caused many problems.
  43705. * loader/appcache/ApplicationCacheGroup.cpp:
  43706. (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
  43707. no functional changes.
  43708. (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
  43709. if its newest cache pointer is already saved for teardown. Note that the cache pointer
  43710. validity is ensured by MainResourceLoader that holds a reference to it.
  43711. 2009-01-09 Darin Fisher <darin@chromium.org>
  43712. Reviewed by Eric Seidel.
  43713. https://bugs.webkit.org/show_bug.cgi?id=23214
  43714. Upstream platform/network/chromium/
  43715. * platform/network/chromium/AuthenticationChallenge.h: Added.
  43716. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  43717. (WebCore::AuthenticationChallenge::sourceHandle):
  43718. * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
  43719. (WebCore::AuthenticationChallenge::platformCompare):
  43720. * platform/network/chromium/CookieJarChromium.cpp: Added.
  43721. (WebCore::setCookies):
  43722. (WebCore::cookies):
  43723. (WebCore::cookiesEnabled):
  43724. * platform/network/chromium/DNSChromium.cpp: Added.
  43725. (WebCore::prefetchDNS):
  43726. * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
  43727. (WebCore::NetworkStateNotifier::updateState):
  43728. (WebCore::NetworkStateNotifier::NetworkStateNotifier):
  43729. * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
  43730. * platform/network/chromium/ResourceError.h: Added.
  43731. (WebCore::ResourceError::ResourceError):
  43732. * platform/network/chromium/ResourceRequest.h: Added.
  43733. (WebCore::ResourceRequest::):
  43734. (WebCore::ResourceRequest::ResourceRequest):
  43735. (WebCore::ResourceRequest::frame):
  43736. (WebCore::ResourceRequest::setFrame):
  43737. (WebCore::ResourceRequest::setTargetType):
  43738. (WebCore::ResourceRequest::targetType):
  43739. (WebCore::ResourceRequest::originPid):
  43740. (WebCore::ResourceRequest::setOriginPid):
  43741. (WebCore::ResourceRequest::securityInfo):
  43742. (WebCore::ResourceRequest::setSecurityInfo):
  43743. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  43744. (WebCore::ResourceRequest::doUpdateResourceRequest):
  43745. * platform/network/chromium/ResourceResponse.h:
  43746. (WebCore::ResourceResponse::ResourceResponse):
  43747. (WebCore::ResourceResponse::getSecurityInfo):
  43748. (WebCore::ResourceResponse::setSecurityInfo):
  43749. (WebCore::ResourceResponse::isContentFiltered):
  43750. (WebCore::ResourceResponse::setIsContentFiltered):
  43751. (WebCore::ResourceResponse::doUpdateResourceResponse):
  43752. 2009-01-09 Peter Kasting <pkasting@google.com>
  43753. Reviewed by David Hyatt.
  43754. https://bugs.webkit.org/show_bug.cgi?id=22995
  43755. Fix flaky image animation by resetting the metadata for a frame when
  43756. we get new data for that frame. This fixes animations that halted
  43757. when the next frame of the animation wasn't complete by the time the
  43758. current frame's duration expired.
  43759. * platform/graphics/BitmapImage.cpp:
  43760. (WebCore::BitmapImage::destroyDecodedData):
  43761. (WebCore::BitmapImage::dataChanged):
  43762. * platform/graphics/BitmapImage.h:
  43763. (WebCore::FrameData::~FrameData):
  43764. * platform/graphics/cairo/ImageCairo.cpp:
  43765. (WebCore::FrameData::clear):
  43766. * platform/graphics/cg/ImageCG.cpp:
  43767. (WebCore::FrameData::clear):
  43768. * platform/graphics/qt/ImageQt.cpp:
  43769. (WebCore::FrameData::clear):
  43770. * platform/graphics/wx/ImageWx.cpp:
  43771. (WebCore::FrameData::clear):
  43772. 2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
  43773. Rubber-stamped by Tor Arne Vestbø.
  43774. Swap the .h and the .cpp output in the Qt build for the
  43775. UserAgentStyleSheetData files, to put the definition in the .cpp file
  43776. and the declaration in the header file.
  43777. * WebCore.pro:
  43778. 2009-01-09 David Levin <levin@chromium.org>
  43779. Reviewed by Oliver Hunt.
  43780. https://bugs.webkit.org/show_bug.cgi?id=23175
  43781. Added forwarding header.
  43782. * ForwardingHeaders/wtf/PtrAndFlags.h: Added.
  43783. 2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
  43784. Reviewed by Simon Hausmann.
  43785. Prevent qmake from generating duplicate rules for embedded stylesheets
  43786. The STYLESHEETS_EMBED variable used to contain only one file name, but
  43787. now that it is a list of files we need to change it to be a dependency
  43788. for the stylesheet generator instead of the input.
  43789. * WebCore.pro:
  43790. 2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
  43791. Reviewed by Tor Arne Vestbø.
  43792. Fix qmake warning about missing test function, a contains() call was
  43793. missing.
  43794. * WebCore.pro:
  43795. 2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
  43796. Rubber-stamped by Tor Arne Vestbø.
  43797. Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
  43798. * WebCore.pro:
  43799. 2009-01-09 David Levin <levin@chromium.org>
  43800. Reviewed by Alexey Proskuryakov.
  43801. https://bugs.webkit.org/show_bug.cgi?id=23199
  43802. Fix deref's of string happening on two different threads.
  43803. No observable change in behavior, so no test. However, there are asserts
  43804. being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
  43805. will detect this issue while running the normal worker tests.
  43806. * dom/WorkerThread.cpp:
  43807. (WebCore::WorkerThreadStartupData::create):
  43808. (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
  43809. (WebCore::WorkerThread::WorkerThread):
  43810. (WebCore::WorkerThread::workerThread):
  43811. * dom/WorkerThread.h:
  43812. 2009-01-08 Dan Bernstein <mitz@apple.com>
  43813. Reviewed by Adam Roben.
  43814. - use native glyph support in Core Graphics when available
  43815. * platform/graphics/win/FontCGWin.cpp:
  43816. (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if
  43817. native glyph support is not available or stroking is required. Changed
  43818. to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to
  43819. request the use of native glyphs.
  43820. * platform/graphics/win/FontCustomPlatformData.cpp:
  43821. (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to
  43822. wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
  43823. * platform/graphics/win/FontPlatformDataCGWin.cpp:
  43824. (WebCore::FontPlatformData::platformDataInit): Ditto.
  43825. 2009-01-08 Peter Kasting <pkasting@google.com>
  43826. Reviewed by Sam Weinig.
  43827. https://bugs.webkit.org/show_bug.cgi?id=22929
  43828. Fix memory regression when decoding large animated GIFs.
  43829. * platform/graphics/cg/ImageSourceCG.cpp:
  43830. (WebCore::ImageSource::clear):
  43831. 2009-01-08 Scott Violet <sky@chromium.org>
  43832. Reviewed by Eric Seidel (and Adam Barth).
  43833. Fix Images to return their file extension
  43834. http://code.google.com/p/chromium/issues/detail?id=5827
  43835. * platform/graphics/skia/ImageSourceSkia.cpp:
  43836. (WebCore::ImageSource::filenameExtension):
  43837. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  43838. Reviewed by Eric Seidel.
  43839. Add PathSkia and PatternSkia implementations to WebCore
  43840. https://bugs.webkit.org/show_bug.cgi?id=23200
  43841. * platform/graphics/skia/PathSkia.cpp: Added.
  43842. (WebCore::Path::Path):
  43843. (WebCore::Path::~Path):
  43844. (WebCore::Path::operator=):
  43845. (WebCore::Path::isEmpty):
  43846. (WebCore::Path::contains):
  43847. (WebCore::Path::translate):
  43848. (WebCore::Path::boundingRect):
  43849. (WebCore::Path::moveTo):
  43850. (WebCore::Path::addLineTo):
  43851. (WebCore::Path::addQuadCurveTo):
  43852. (WebCore::Path::addBezierCurveTo):
  43853. (WebCore::Path::addArcTo):
  43854. (WebCore::Path::closeSubpath):
  43855. (WebCore::Path::addArc):
  43856. (WebCore::Path::addRect):
  43857. (WebCore::Path::addEllipse):
  43858. (WebCore::Path::clear):
  43859. (WebCore::convertPathPoints):
  43860. (WebCore::Path::apply):
  43861. (WebCore::Path::transform):
  43862. (WebCore::Path::debugString):
  43863. (WebCore::boundingBoxForCurrentStroke):
  43864. (WebCore::Path::strokeBoundingRect):
  43865. * platform/graphics/skia/PatternSkia.cpp: Added.
  43866. (WebCore::shaderRule):
  43867. (WebCore::Pattern::createPlatformPattern):
  43868. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  43869. Reviewed by Eric Seidel.
  43870. Add ImageSourceSkia to platform/graphics/skia
  43871. https://bugs.webkit.org/show_bug.cgi?id=23200
  43872. ImageSourceSkia is mostly a hack to support our
  43873. ICO decoder model. See ImageSourceSkia.h for more
  43874. explanation. Eventually we'd like to make our ICO
  43875. decoder lazy.
  43876. * platform/graphics/ImageSource.h: mark m_decoder as protected
  43877. * platform/graphics/skia/ImageSourceSkia.cpp: Added.
  43878. (WebCore::createDecoder):
  43879. (WebCore::ImageSource::ImageSource):
  43880. (WebCore::ImageSource::~ImageSource):
  43881. (WebCore::ImageSource::clear):
  43882. (WebCore::ImageSource::initialized):
  43883. (WebCore::ImageSource::setData):
  43884. (WebCore::ImageSource::isSizeAvailable):
  43885. (WebCore::ImageSource::size):
  43886. (WebCore::ImageSource::frameSizeAtIndex):
  43887. (WebCore::ImageSource::repetitionCount):
  43888. (WebCore::ImageSource::frameCount):
  43889. (WebCore::ImageSource::createFrameAtIndex):
  43890. (WebCore::ImageSource::frameIsCompleteAtIndex):
  43891. (WebCore::ImageSource::frameDurationAtIndex):
  43892. (WebCore::ImageSource::frameHasAlphaAtIndex):
  43893. (WebCore::ImageSourceSkia::setData):
  43894. (WebCore::ImageSource::filenameExtension):
  43895. * platform/graphics/skia/ImageSourceSkia.h: Added.
  43896. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  43897. Reviewed by Eric Seidel.
  43898. Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
  43899. https://bugs.webkit.org/show_bug.cgi?id=23200
  43900. * platform/graphics/skia/NativeImageSkia.cpp: Added.
  43901. (NativeImageSkia::NativeImageSkia):
  43902. (NativeImageSkia::decodedSize):
  43903. (NativeImageSkia::hasResizedBitmap):
  43904. (NativeImageSkia::resizedBitmap):
  43905. (NativeImageSkia::shouldCacheResampling):
  43906. * platform/graphics/skia/NativeImageSkia.h: Added.
  43907. (NativeImageSkia::setDataComplete):
  43908. (NativeImageSkia::isDataComplete):
  43909. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  43910. Reviewed by Eric Seidel.
  43911. Add ImageBufferSkia and ImageSkia files.
  43912. https://bugs.webkit.org/show_bug.cgi?id=23200
  43913. For now we've left BitmapImage and BitmapImageSingleFrameSkia
  43914. implementations in the ImageSkia file (like ImageCG has), but
  43915. we intend to break them out into their own files.
  43916. * platform/graphics/skia/ImageBufferSkia.cpp: Added.
  43917. (WebCore::ImageBufferData::ImageBufferData):
  43918. (WebCore::ImageBuffer::ImageBuffer):
  43919. (WebCore::ImageBuffer::~ImageBuffer):
  43920. (WebCore::ImageBuffer::context):
  43921. (WebCore::ImageBuffer::image):
  43922. (WebCore::ImageBuffer::getImageData):
  43923. (WebCore::ImageBuffer::putImageData):
  43924. (WebCore::ImageBuffer::toDataURL):
  43925. * platform/graphics/skia/ImageSkia.cpp: Added.
  43926. (WebCore::):
  43927. (WebCore::FrameData::clear):
  43928. (WebCore::Image::loadPlatformResource):
  43929. (WebCore::Image::drawPattern):
  43930. (WebCore::BitmapImage::initPlatformData):
  43931. (WebCore::BitmapImage::invalidatePlatformData):
  43932. (WebCore::BitmapImage::checkForSolidColor):
  43933. (WebCore::BitmapImage::draw):
  43934. (WebCore::BitmapImageSingleFrameSkia::draw):
  43935. (WebCore::BitmapImageSingleFrameSkia::create):
  43936. 2009-01-08 James Robinson <jamesr@google.com>
  43937. Reviewed by Mark Rowe.
  43938. Landed by Pamela Greene.
  43939. WebCore::Event::timeStamp() is a simple accessor and should be const
  43940. https://bugs.webkit.org/show_bug.cgi?id=23176
  43941. * dom/Event.h:
  43942. (WebCore::Event::timeStamp):
  43943. 2009-01-08 Antti Koivisto <antti@apple.com>
  43944. Reviewed by Oliver Hunt.
  43945. Fix <rdar://problem/6467206>
  43946. Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)
  43947. Use CachedResourceHandle in document resource map so resources get updated correctly when using
  43948. using cache validation conditionals.
  43949. * loader/Cache.cpp:
  43950. (WebCore::Cache::evict):
  43951. * loader/DocLoader.cpp:
  43952. (WebCore::DocLoader::~DocLoader):
  43953. (WebCore::DocLoader::requestResource):
  43954. (WebCore::DocLoader::setAutoLoadImages):
  43955. (WebCore::DocLoader::removeCachedResource):
  43956. * loader/DocLoader.h:
  43957. (WebCore::DocLoader::cachedResource):
  43958. (WebCore::DocLoader::allCachedResources):
  43959. * loader/DocumentLoader.cpp:
  43960. (WebCore::DocumentLoader::getSubresources):
  43961. * loader/ImageLoader.cpp:
  43962. (WebCore::ImageLoader::updateFromElement):
  43963. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  43964. Reviewed by Eric Seidel.
  43965. Add a cleaned-up GraphicsContextSkia implementation to WebKit.
  43966. https://bugs.webkit.org/show_bug.cgi?id=23191
  43967. * platform/graphics/skia/GraphicsContextSkia.cpp: Added.
  43968. (WebCore::):
  43969. (WebCore::GraphicsContext::GraphicsContext):
  43970. (WebCore::GraphicsContext::~GraphicsContext):
  43971. (WebCore::GraphicsContext::platformContext):
  43972. (WebCore::GraphicsContext::savePlatformState):
  43973. (WebCore::GraphicsContext::restorePlatformState):
  43974. (WebCore::GraphicsContext::beginTransparencyLayer):
  43975. (WebCore::GraphicsContext::endTransparencyLayer):
  43976. (WebCore::GraphicsContext::addInnerRoundedRectClip):
  43977. (WebCore::GraphicsContext::addPath):
  43978. (WebCore::GraphicsContext::beginPath):
  43979. (WebCore::GraphicsContext::clearPlatformShadow):
  43980. (WebCore::GraphicsContext::clearRect):
  43981. (WebCore::GraphicsContext::clip):
  43982. (WebCore::GraphicsContext::clipOut):
  43983. (WebCore::GraphicsContext::clipOutEllipseInRect):
  43984. (WebCore::GraphicsContext::clipPath):
  43985. (WebCore::GraphicsContext::clipToImageBuffer):
  43986. (WebCore::GraphicsContext::concatCTM):
  43987. (WebCore::GraphicsContext::drawConvexPolygon):
  43988. (WebCore::GraphicsContext::drawEllipse):
  43989. (WebCore::GraphicsContext::drawFocusRing):
  43990. (WebCore::GraphicsContext::drawLine):
  43991. (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  43992. (WebCore::GraphicsContext::drawLineForText):
  43993. (WebCore::GraphicsContext::drawRect):
  43994. (WebCore::GraphicsContext::fillPath):
  43995. (WebCore::GraphicsContext::fillRect):
  43996. (WebCore::GraphicsContext::fillRoundedRect):
  43997. (WebCore::GraphicsContext::getCTM):
  43998. (WebCore::GraphicsContext::roundToDevicePixels):
  43999. (WebCore::GraphicsContext::scale):
  44000. (WebCore::GraphicsContext::setAlpha):
  44001. (WebCore::GraphicsContext::setCompositeOperation):
  44002. (WebCore::GraphicsContext::setImageInterpolationQuality):
  44003. (WebCore::GraphicsContext::setLineCap):
  44004. (WebCore::GraphicsContext::setLineDash):
  44005. (WebCore::GraphicsContext::setLineJoin):
  44006. (WebCore::GraphicsContext::setMiterLimit):
  44007. (WebCore::GraphicsContext::setPlatformFillColor):
  44008. (WebCore::GraphicsContext::setPlatformShadow):
  44009. (WebCore::GraphicsContext::setPlatformStrokeColor):
  44010. (WebCore::GraphicsContext::setPlatformStrokeStyle):
  44011. (WebCore::GraphicsContext::setPlatformStrokeThickness):
  44012. (WebCore::GraphicsContext::setPlatformTextDrawingMode):
  44013. (WebCore::GraphicsContext::setURLForRect):
  44014. (WebCore::GraphicsContext::setUseAntialiasing):
  44015. (WebCore::GraphicsContext::strokeArc):
  44016. (WebCore::GraphicsContext::strokePath):
  44017. (WebCore::GraphicsContext::strokeRect):
  44018. (WebCore::GraphicsContext::rotate):
  44019. (WebCore::GraphicsContext::translate):
  44020. 2009-01-08 David Hyatt <hyatt@apple.com>
  44021. Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.
  44022. Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
  44023. any scrollable views that may contain a WebView. Does nothing on platforms other than the Mac, but
  44024. might eventually be of interest to other platforms.
  44025. Reviewed by Oliver Hunt
  44026. * WebCore.base.exp:
  44027. * page/Chrome.cpp:
  44028. (WebCore::Chrome::scrollRectIntoView):
  44029. * page/Chrome.h:
  44030. * page/ChromeClient.h:
  44031. (WebCore::ChromeClient::scrollRectIntoView):
  44032. * platform/HostWindow.h:
  44033. * platform/ScrollView.cpp:
  44034. (WebCore::ScrollView::scrollRectIntoViewRecursively):
  44035. 2009-01-08 Adam Treat <adam.treat@torchmobile.com>
  44036. Reviewed by David Hyatt.
  44037. No need to make this part of HostWindow and moreover HostWindow should
  44038. not have any reference to non-platform parts of WebCore.
  44039. * page/Chrome.h:
  44040. * page/FrameView.cpp:
  44041. (WebCore::FrameView::setContentsSize):
  44042. * platform/HostWindow.h:
  44043. 2009-01-08 Eric Carlson <eric.carlson@apple.com>
  44044. Reviewed by Adele Peterson.
  44045. Simplify Mac interfaces for drawing media controller elements
  44046. <rdar://problem/6293969>
  44047. * WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
  44048. * platform/mac/WebCoreSystemInterface.h: Ditto
  44049. * platform/mac/WebCoreSystemInterface.mm: Ditto
  44050. * rendering/MediaControlElements.h:
  44051. (WebCore::): Add MediaControlElements enum
  44052. * rendering/RenderThemeMac.mm:
  44053. (WebCore::RenderThemeMac::paintMediaFullscreenButton): update for changed WebKitSystemInterface
  44054. media controller functions
  44055. (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
  44056. (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
  44057. (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
  44058. (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
  44059. (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
  44060. (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
  44061. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  44062. Reviewed by Eric Seidel.
  44063. Add two more files for platform/graphics/skia.
  44064. https://bugs.webkit.org/show_bug.cgi?id=23191
  44065. * platform/graphics/skia/GradientSkia.cpp: Added.
  44066. (WebCore::Gradient::platformDestroy):
  44067. (WebCore::F2B):
  44068. (WebCore::makeSkColor):
  44069. (WebCore::totalStopsNeeded):
  44070. (WebCore::fillStops):
  44071. (WebCore::compareStops):
  44072. (WebCore::Gradient::platformGradient):
  44073. (WebCore::Gradient::fill):
  44074. * platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h.
  44075. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  44076. (WebCore::GraphicsContextPlatformPrivate::context):
  44077. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  44078. Reviewed by Eric Seidel.
  44079. Commit the right files this time! (Instead of the ugly unfixed ones.)
  44080. https://bugs.webkit.org/show_bug.cgi?id=23191
  44081. * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
  44082. * platform/graphics/skia/FloatPointSkia.cpp:
  44083. * platform/graphics/skia/FloatRectSkia.cpp:
  44084. * platform/graphics/skia/IntPointSkia.cpp:
  44085. * platform/graphics/skia/IntRectSkia.cpp:
  44086. (WebCore::IntRect::operator SkRect):
  44087. * platform/graphics/skia/SkiaUtils.cpp:
  44088. (WebCore::):
  44089. (WebCore::WebCoreCompositeToSkiaComposite):
  44090. (WebCore::SkPMColorToWebCoreColor):
  44091. (WebCore::IntersectRectAndRegion):
  44092. (WebCore::ClipRectToCanvas):
  44093. (WebCore::SkPathContainsPoint):
  44094. (WebCore::scratchContext):
  44095. * platform/graphics/skia/SkiaUtils.h:
  44096. (WebCore::WebCoreFloatToSkScalar):
  44097. (WebCore::WebCoreDoubleToSkScalar):
  44098. 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
  44099. Reviewed by Eric Seidel.
  44100. Add the first few files from platform/graphics/skia
  44101. https://bugs.webkit.org/show_bug.cgi?id=23191
  44102. These are all pretty simple.
  44103. Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
  44104. SkiaUtils needs to die, but that can come later, no need to block up-streaming now.
  44105. * platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added.
  44106. (WebCore::BitmapImageSingleFrameSkia::isBitmapImage):
  44107. (WebCore::BitmapImageSingleFrameSkia::size):
  44108. (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData):
  44109. (WebCore::BitmapImageSingleFrameSkia::decodedSize):
  44110. (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame):
  44111. (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
  44112. * platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm.
  44113. (WebCore::FloatPoint::FloatPoint):
  44114. (WebCore::FloatPoint::operator SkPoint):
  44115. * platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
  44116. (WebCore::FloatRect::FloatRect):
  44117. (WebCore::FloatRect::operator SkRect):
  44118. * platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp.
  44119. (WebCore::IntPoint::IntPoint):
  44120. (WebCore::IntPoint::operator SkIPoint):
  44121. (WebCore::IntPoint::operator SkPoint):
  44122. * platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
  44123. (WebCore::IntRect::operator SkIRect):
  44124. (WebCore::IntRect::operator SkRect):
  44125. (WebCore::IntRect::IntRect):
  44126. * platform/graphics/skia/SkiaUtils.cpp: Added.
  44127. (WebCore::WebCorePointToSkiaPoint):
  44128. (WebCore::WebCoreRectToSkiaRect):
  44129. (WebCore::):
  44130. (WebCore::WebCoreCompositeToSkiaComposite):
  44131. (WebCore::InvScaleByte):
  44132. (WebCore::SkPMColorToColor):
  44133. (WebCore::SkPMColorToWebCoreColor):
  44134. (WebCore::IntersectRectAndRegion):
  44135. (WebCore::ClipRectToCanvas):
  44136. (WebCore::SkPathContainsPoint):
  44137. (WebCore::scratchContext):
  44138. * platform/graphics/skia/SkiaUtils.h: Added.
  44139. (WebCore::WebCoreFloatToSkScalar):
  44140. (WebCore::WebCoreDoubleToSkScalar):
  44141. 2009-01-08 Pierre-Olivier Latour <pol@apple.com>
  44142. Reviewed by Dan Bernstein.
  44143. Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.
  44144. Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
  44145. instead of simply the "running" ones.
  44146. https://bugs.webkit.org/show_bug.cgi?id=23177
  44147. Tests: transitions/zero-duration-with-non-zero-delay-end.html
  44148. transitions/zero-duration-with-non-zero-delay-start.html
  44149. * page/animation/AnimationBase.cpp:
  44150. (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
  44151. * page/animation/AnimationController.cpp:
  44152. (WebCore::AnimationControllerPrivate::animationTimerFired):
  44153. * page/animation/CompositeAnimation.cpp:
  44154. (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
  44155. 2009-01-08 Alexey Proskuryakov <ap@webkit.org>
  44156. Reviewed by Oliver Hunt.
  44157. <rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly
  44158. The crash happened whenever a cached resource was downloaded, as opposed to used directly.
  44159. No test, as downloading cannot be tested automatically.
  44160. * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  44161. Cancel downloads that do not have an associated ResourceHandle, such as downloads from the
  44162. application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
  44163. 2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
  44164. Reviewed by Simon Hausmann.
  44165. Fix the Qt build on older X11 systems with special X paths.
  44166. * WebCore.pro: Use the x11 qmake config to pull in extra paths
  44167. needed for NPAPI.
  44168. 2009-01-08 Adam Roben <aroben@apple.com>
  44169. Windows build fix after r39699
  44170. * DerivedSources.cpp: Added JSDOMStringList.cpp.
  44171. 2009-01-08 Kent Hansen <khansen@trolltech.com>
  44172. Reviewed by Simon Hausmann.
  44173. Fix copy & paste of images in the Qt port.
  44174. Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.
  44175. * platform/qt/ClipboardQt.cpp:
  44176. (WebCore::ClipboardQt::declareAndWriteDragImage):
  44177. 2009-01-08 Hiroyuki Ikezoe <poincare@ikezoe.net>
  44178. Reviewed by Holger Freyther.
  44179. https://bugs.webkit.org/show_bug.cgi?id=23127
  44180. Invoke pango_coverage_get with each Unicode character.
  44181. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  44182. (WebCore::SimpleFontData::containsCharacters):
  44183. 2009-01-07 Alexey Proskuryakov <ap@webkit.org>
  44184. Reviewed by Darin Adler.
  44185. Part one of
  44186. https://bugs.webkit.org/show_bug.cgi?id=23165
  44187. Add support for application cache dynamic entries
  44188. Test: http/tests/appcache/dynamic-entries-no-cache.html
  44189. * DerivedSources.make:
  44190. * GNUmakefile.am:
  44191. * WebCore.pro:
  44192. * WebCore.scons:
  44193. * WebCore.vcproj/WebCore.vcproj:
  44194. * WebCore.xcodeproj/project.pbxproj:
  44195. * WebCoreSources.bkl:
  44196. Added new files.
  44197. * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem):
  44198. Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom
  44199. to resolve relative URLs correctly.
  44200. * bindings/js/JSDOMStringListCustom.cpp: Added.
  44201. * dom/DOMStringList.cpp: Added.
  44202. * dom/DOMStringList.h: Added.
  44203. * dom/DOMStringList.idl: Added.
  44204. Added an implementation of DOM 3 Core DOMStringList interface, which is returned by
  44205. DOMApplicationCache items attribute.
  44206. * dom/StaticStringList.cpp: Added.
  44207. * dom/StaticStringList.h: Added.
  44208. An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this
  44209. matches Firefox, as the spec doesn't say whether the returned list should be live or not).
  44210. * loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be
  44211. used in the near future.
  44212. * loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length
  44213. attribute and item(), we now have an items attribute that returns a DOMStringList, and a
  44214. hasItem convenience method.
  44215. * loader/appcache/DOMApplicationCache.cpp:
  44216. (WebCore::DOMApplicationCache::items):
  44217. (WebCore::DOMApplicationCache::hasItem):
  44218. * loader/appcache/DOMApplicationCache.h:
  44219. Added implementations of items attribute and hasItem() (note that underlying ApplicationCache
  44220. methods are still unimplemented though).
  44221. * page/DOMWindow.idl: Expose a DOMStringList global constructor.
  44222. 2009-01-07 Chris Marrin <cmarrin@apple.com>
  44223. Reviewed by Eric Seidel.
  44224. https://bugs.webkit.org/show_bug.cgi?id=23122
  44225. This completes the removal of dependencies on WebKit from the platform code
  44226. * css/CSSComputedStyleDeclaration.cpp:
  44227. (WebCore::getDelayValue):
  44228. (WebCore::getDurationValue):
  44229. (WebCore::getTimingFunctionValue):
  44230. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  44231. * css/CSSHelper.h:
  44232. * css/CSSStyleSelector.cpp:
  44233. (WebCore::CSSStyleSelector::mapAnimationDelay):
  44234. (WebCore::CSSStyleSelector::mapAnimationDirection):
  44235. (WebCore::CSSStyleSelector::mapAnimationDuration):
  44236. (WebCore::CSSStyleSelector::mapAnimationIterationCount):
  44237. (WebCore::CSSStyleSelector::mapAnimationName):
  44238. (WebCore::CSSStyleSelector::mapAnimationPlayState):
  44239. (WebCore::CSSStyleSelector::mapAnimationProperty):
  44240. (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
  44241. * platform/animation/Animation.cpp:
  44242. (WebCore::Animation::Animation):
  44243. * platform/animation/Animation.h:
  44244. (WebCore::Animation::initialAnimationDelay):
  44245. (WebCore::Animation::initialAnimationDirection):
  44246. (WebCore::Animation::initialAnimationDuration):
  44247. (WebCore::Animation::initialAnimationIterationCount):
  44248. (WebCore::Animation::initialAnimationName):
  44249. (WebCore::Animation::initialAnimationPlayState):
  44250. (WebCore::Animation::initialAnimationProperty):
  44251. (WebCore::Animation::initialAnimationTimingFunction):
  44252. * rendering/style/RenderStyle.h:
  44253. 2008-01-07 Peter Kasting <pkasting@google.com>
  44254. Reviewed by Sam Weinig.
  44255. https://bugs.webkit.org/show_bug.cgi?id=22929
  44256. Fix errors while decoding GIFs by not calling setData() repeatedly
  44257. when it's not necessary. Pushes the responsibility for calling
  44258. setData() after clear() into the ImageSource which presumably knows
  44259. better than BitmapImage what needs to be done.
  44260. NOTE: The above bug is mainly about a memory regression, which this
  44261. patch does not fix.
  44262. * platform/graphics/BitmapImage.cpp:
  44263. (WebCore::BitmapImage::destroyDecodedData):
  44264. * platform/graphics/ImageSource.h:
  44265. * platform/graphics/cairo/ImageSourceCairo.cpp:
  44266. (WebCore::ImageSource::clear):
  44267. * platform/graphics/cg/ImageSourceCG.cpp:
  44268. (WebCore::ImageSource::clear):
  44269. * platform/graphics/qt/ImageSourceQt.cpp:
  44270. (WebCore::ImageSource::~ImageSource):
  44271. (WebCore::ImageSource::clear):
  44272. * platform/graphics/wx/ImageSourceWx.cpp:
  44273. (WebCore::ImageSource::~ImageSource):
  44274. (WebCore::ImageSource::clear):
  44275. 2009-01-07 Justin Garcia <justin.garcia@apple.com>
  44276. Reviewed by Darin Adler.
  44277. <rdar://problem/6355786> Find fails for queries that contain a line break
  44278. * editing/TextIterator.cpp:
  44279. (WebCore::findPlainText): Allow find with queries that contain newlines.
  44280. 2009-01-07 Dean Jackson <dino@apple.com>
  44281. Reviewed by Dan Bernstein.
  44282. Allow removal of inline shorthand properties for
  44283. animation, transition and transform origin. Also
  44284. add getter for shorthand animation property.
  44285. https://bugs.webkit.org/show_bug.cgi?id=22605
  44286. Test: fast/css/transform-inline-style-remove.html
  44287. * css/CSSMutableStyleDeclaration.cpp:
  44288. (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  44289. Getter for animation property shorthand
  44290. (WebCore::initShorthandMap):
  44291. Adds initialisation for transform-origin, animation and transition
  44292. 2009-01-07 Benjamin Otte <otte@gnome.org>
  44293. Reviewed by Holger Freyther.
  44294. * platform/network/ResourceHandleInternal.h:
  44295. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  44296. * platform/network/soup/ResourceHandleSoup.cpp:
  44297. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  44298. (WebCore::parseDataUrl):
  44299. (WebCore::ResourceHandle::startData): keep track of the idle handler
  44300. we add and remove it in the destructor
  44301. 2009-01-07 Dean Jackson <dino@apple.com>
  44302. Reviewed by Darin Adler.
  44303. Finish renaming of AffineTransform to TransformationMatrix, this
  44304. time ensuring that the platform implementations get the correct
  44305. name. Also, clean up some whitespace cruft in old content.
  44306. https://bugs.webkit.org/show_bug.cgi?id=23151
  44307. * GNUmakefile.am:
  44308. * WebCore.pro:
  44309. * WebCore.scons:
  44310. * WebCore.vcproj/WebCore.vcproj:
  44311. * WebCore.xcodeproj/project.pbxproj:
  44312. * platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
  44313. * platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
  44314. * platform/graphics/cg/AffineTransformCG.cpp: Removed.
  44315. * platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
  44316. * platform/graphics/qt/AffineTransformQt.cpp: Removed.
  44317. * platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
  44318. * platform/graphics/transforms/TransformationMatrix.cpp:
  44319. * platform/graphics/transforms/TransformationMatrix.h:
  44320. * platform/graphics/wx/AffineTransformWx.cpp: Removed.
  44321. * platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
  44322. * webcore-wx.bkl:
  44323. 2009-01-07 Anders Carlsson <andersca@apple.com>
  44324. Another build fix.
  44325. * WebCore.LP64.exp:
  44326. 2008-12-16 David Hyatt <hyatt@apple.com>
  44327. Make Safari RSS behave nicely with full page zoom. Need to add a new value to enable resetting of zoom
  44328. back to the document-level default.
  44329. Reviewed by Darin Adler
  44330. * css/CSSParser.cpp:
  44331. (WebCore::CSSParser::parseValue):
  44332. * css/CSSStyleSelector.cpp:
  44333. (WebCore::CSSStyleSelector::applyProperty):
  44334. * css/CSSValueKeywords.in:
  44335. 2009-01-07 Darin Adler <darin@apple.com>
  44336. Reviewed by Oliver Hunt.
  44337. Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
  44338. https://bugs.webkit.org/show_bug.cgi?id=23160
  44339. * WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
  44340. * inspector/InspectorController.cpp:
  44341. (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource
  44342. so that there's no extra work the caller has to do when the inspector is disabled.
  44343. * inspector/InspectorController.h: Ditto.
  44344. * loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification,
  44345. takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
  44346. * loader/FrameLoader.cpp:
  44347. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when
  44348. there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled
  44349. and if it's false, use recordMemoryCacheLoadForFutureClientNotification.
  44350. (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
  44351. * loader/FrameLoader.h: Ditto.
  44352. * page/Page.cpp:
  44353. (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior.
  44354. (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
  44355. * page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled,
  44356. and m_areMemoryCacheClientCallsEnabled.
  44357. 2009-01-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
  44358. Rubber-stamped by Simon Hausmann.
  44359. Qt build fix after r39670.
  44360. * bridge/qt/qt_class.cpp:
  44361. (JSC::Bindings::QtClass::fallbackObject):
  44362. * bridge/qt/qt_class.h:
  44363. * bridge/qt/qt_instance.cpp:
  44364. (JSC::Bindings::QtInstance::mark):
  44365. (JSC::Bindings::QtInstance::invokeMethod):
  44366. (JSC::Bindings::QtInstance::defaultValue):
  44367. (JSC::Bindings::QtInstance::stringValue):
  44368. (JSC::Bindings::QtInstance::numberValue):
  44369. (JSC::Bindings::QtInstance::booleanValue):
  44370. (JSC::Bindings::QtInstance::valueOf):
  44371. (JSC::Bindings::QtField::valueFromInstance):
  44372. (JSC::Bindings::QtField::setValueToInstance):
  44373. * bridge/qt/qt_instance.h:
  44374. * bridge/qt/qt_runtime.cpp:
  44375. (JSC::Bindings::valueRealType):
  44376. (JSC::Bindings::convertValueToQVariant):
  44377. (JSC::Bindings::convertQVariantToValue):
  44378. (JSC::Bindings::findMethodIndex):
  44379. (JSC::Bindings::QtRuntimeMetaMethod::call):
  44380. (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
  44381. (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
  44382. (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  44383. (JSC::Bindings::QtRuntimeConnectionMethod::call):
  44384. (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
  44385. (JSC::Bindings::::setValueAt):
  44386. (JSC::Bindings::::valueAt):
  44387. * bridge/qt/qt_runtime.h:
  44388. (JSC::Bindings::QtRuntimeMethod::createStructure):
  44389. 2009-01-06 Justin Garcia <justin.garcia@apple.com>
  44390. Reviewed by Oliver Hunt.
  44391. <rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu
  44392. Can't create an automated test case for specific contextual menu items yet and
  44393. a normal Copy doesn't cause a crash.
  44394. * platform/mac/PasteboardMac.mm:
  44395. (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data. It may,
  44396. for example, have a purgeable or regular buffer.
  44397. 2009-01-06 Mark Rowe <mrowe@apple.com>
  44398. Reviewed by Geoff Garen.
  44399. Fix <https://bugs.webkit.org/show_bug.cgi?id=23157>.
  44400. Bug 23157: Crashes on Acid 3
  44401. * dom/Document.cpp:
  44402. (WebCore::Document::recalcStyle): Null-check the frame.
  44403. 2009-01-05 Gavin Barraclough <baraclough@apple.com>
  44404. Rubber Stamped by Oliver Hunt.
  44405. Replace all uses of JSValue* with new wrapper class, JSValuePtr.
  44406. See JavaScriptCore/ChangeLog for more detailed description.
  44407. * bindings/js/JSAttrCustom.cpp:
  44408. (WebCore::JSAttr::setValue):
  44409. * bindings/js/JSCSSRuleCustom.cpp:
  44410. (WebCore::toJS):
  44411. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  44412. (WebCore::JSCSSStyleDeclaration::nameGetter):
  44413. (WebCore::JSCSSStyleDeclaration::customPut):
  44414. * bindings/js/JSCSSValueCustom.cpp:
  44415. (WebCore::toJS):
  44416. * bindings/js/JSCanvasPixelArrayCustom.h:
  44417. (WebCore::JSCanvasPixelArray::getByIndex):
  44418. (WebCore::JSCanvasPixelArray::indexSetter):
  44419. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  44420. (WebCore::toJS):
  44421. (WebCore::toHTMLCanvasStyle):
  44422. (WebCore::JSCanvasRenderingContext2D::strokeStyle):
  44423. (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
  44424. (WebCore::JSCanvasRenderingContext2D::fillStyle):
  44425. (WebCore::JSCanvasRenderingContext2D::setFillStyle):
  44426. (WebCore::JSCanvasRenderingContext2D::setFillColor):
  44427. (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
  44428. (WebCore::JSCanvasRenderingContext2D::strokeRect):
  44429. (WebCore::JSCanvasRenderingContext2D::drawImage):
  44430. (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
  44431. (WebCore::JSCanvasRenderingContext2D::setShadow):
  44432. (WebCore::JSCanvasRenderingContext2D::createPattern):
  44433. (WebCore::JSCanvasRenderingContext2D::putImageData):
  44434. (WebCore::JSCanvasRenderingContext2D::fillText):
  44435. (WebCore::JSCanvasRenderingContext2D::strokeText):
  44436. * bindings/js/JSClipboardCustom.cpp:
  44437. (WebCore::JSClipboard::types):
  44438. (WebCore::JSClipboard::clearData):
  44439. (WebCore::JSClipboard::getData):
  44440. (WebCore::JSClipboard::setData):
  44441. (WebCore::JSClipboard::setDragImage):
  44442. * bindings/js/JSConsoleCustom.cpp:
  44443. (WebCore::JSConsole::profiles):
  44444. * bindings/js/JSCustomPositionCallback.cpp:
  44445. (WebCore::JSCustomPositionCallback::handleEvent):
  44446. * bindings/js/JSCustomPositionErrorCallback.cpp:
  44447. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  44448. * bindings/js/JSCustomSQLStatementCallback.cpp:
  44449. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  44450. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  44451. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  44452. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  44453. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  44454. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  44455. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  44456. * bindings/js/JSCustomVoidCallback.cpp:
  44457. (WebCore::JSCustomVoidCallback::handleEvent):
  44458. (WebCore::toVoidCallback):
  44459. * bindings/js/JSCustomVoidCallback.h:
  44460. * bindings/js/JSCustomXPathNSResolver.cpp:
  44461. (WebCore::JSCustomXPathNSResolver::create):
  44462. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  44463. * bindings/js/JSCustomXPathNSResolver.h:
  44464. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  44465. (WebCore::JSDOMApplicationCache::add):
  44466. (WebCore::JSDOMApplicationCache::remove):
  44467. (WebCore::JSDOMApplicationCache::addEventListener):
  44468. (WebCore::JSDOMApplicationCache::removeEventListener):
  44469. * bindings/js/JSDOMBinding.cpp:
  44470. (WebCore::jsStringOrNull):
  44471. (WebCore::jsOwnedStringOrNull):
  44472. (WebCore::jsStringOrUndefined):
  44473. (WebCore::jsStringOrFalse):
  44474. (WebCore::valueToStringWithNullCheck):
  44475. (WebCore::valueToStringWithUndefinedOrNullCheck):
  44476. (WebCore::reportException):
  44477. (WebCore::reportCurrentException):
  44478. (WebCore::setDOMException):
  44479. (WebCore::objectToStringFunctionGetter):
  44480. * bindings/js/JSDOMBinding.h:
  44481. (WebCore::getDOMObjectWrapper):
  44482. (WebCore::getDOMNodeWrapper):
  44483. (WebCore::toJS):
  44484. * bindings/js/JSDOMGlobalObject.cpp:
  44485. (WebCore::JSDOMGlobalObject::findJSEventListener):
  44486. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  44487. (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
  44488. (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
  44489. * bindings/js/JSDOMGlobalObject.h:
  44490. * bindings/js/JSDOMWindowBase.cpp:
  44491. (WebCore::createWindow):
  44492. (WebCore::showModalDialog):
  44493. (jsDOMWindowBaseCrypto):
  44494. (jsDOMWindowBaseEvent):
  44495. (jsDOMWindowBaseImage):
  44496. (jsDOMWindowBaseMessageChannel):
  44497. (jsDOMWindowBaseOption):
  44498. (jsDOMWindowBaseXMLHttpRequest):
  44499. (jsDOMWindowBaseAudio):
  44500. (jsDOMWindowBaseWorker):
  44501. (jsDOMWindowBaseXSLTProcessor):
  44502. (setJSDOMWindowBaseEvent):
  44503. (setJSDOMWindowBaseAudio):
  44504. (setJSDOMWindowBaseImage):
  44505. (setJSDOMWindowBaseMessageChannel):
  44506. (setJSDOMWindowBaseOption):
  44507. (setJSDOMWindowBaseWorker):
  44508. (setJSDOMWindowBaseXMLHttpRequest):
  44509. (setJSDOMWindowBaseXSLTProcessor):
  44510. (WebCore::JSDOMWindowBase::childFrameGetter):
  44511. (WebCore::JSDOMWindowBase::indexGetter):
  44512. (WebCore::JSDOMWindowBase::namedItemGetter):
  44513. (WebCore::JSDOMWindowBase::getOwnPropertySlot):
  44514. (WebCore::JSDOMWindowBase::put):
  44515. (WebCore::JSDOMWindowBase::clear):
  44516. (windowProtoFuncOpen):
  44517. (windowProtoFuncShowModalDialog):
  44518. (windowProtoFuncNotImplemented):
  44519. (WebCore::JSDOMWindowBase::setReturnValueSlot):
  44520. (WebCore::JSDOMWindowBase::installTimeout):
  44521. (WebCore::toJS):
  44522. (WebCore::toJSDOMWindow):
  44523. * bindings/js/JSDOMWindowBase.h:
  44524. * bindings/js/JSDOMWindowCustom.cpp:
  44525. (WebCore::JSDOMWindow::lookupGetter):
  44526. (WebCore::JSDOMWindow::lookupSetter):
  44527. (WebCore::JSDOMWindow::setLocation):
  44528. (WebCore::JSDOMWindow::postMessage):
  44529. (WebCore::setTimeoutOrInterval):
  44530. (WebCore::JSDOMWindow::setTimeout):
  44531. (WebCore::JSDOMWindow::clearTimeout):
  44532. (WebCore::JSDOMWindow::setInterval):
  44533. (WebCore::JSDOMWindow::clearInterval):
  44534. (WebCore::JSDOMWindow::atob):
  44535. (WebCore::JSDOMWindow::btoa):
  44536. (WebCore::JSDOMWindow::addEventListener):
  44537. (WebCore::JSDOMWindow::removeEventListener):
  44538. (WebCore::toDOMWindow):
  44539. (WebCore::nonCachingStaticCloseFunctionGetter):
  44540. (WebCore::nonCachingStaticBlurFunctionGetter):
  44541. (WebCore::nonCachingStaticFocusFunctionGetter):
  44542. (WebCore::nonCachingStaticPostMessageFunctionGetter):
  44543. * bindings/js/JSDOMWindowCustom.h:
  44544. (WebCore::JSDOMWindow::customPut):
  44545. * bindings/js/JSDOMWindowShell.cpp:
  44546. (WebCore::JSDOMWindowShell::put):
  44547. (WebCore::JSDOMWindowShell::putWithAttributes):
  44548. (WebCore::JSDOMWindowShell::lookupGetter):
  44549. (WebCore::JSDOMWindowShell::lookupSetter):
  44550. (WebCore::toJS):
  44551. * bindings/js/JSDOMWindowShell.h:
  44552. (WebCore::JSDOMWindowShell::createStructure):
  44553. * bindings/js/JSDatabaseCustom.cpp:
  44554. (WebCore::JSDatabase::changeVersion):
  44555. (WebCore::JSDatabase::transaction):
  44556. * bindings/js/JSDocumentCustom.cpp:
  44557. (WebCore::JSDocument::location):
  44558. (WebCore::JSDocument::setLocation):
  44559. (WebCore::toJS):
  44560. * bindings/js/JSElementCustom.cpp:
  44561. (WebCore::JSElement::setAttribute):
  44562. (WebCore::JSElement::setAttributeNode):
  44563. (WebCore::JSElement::setAttributeNS):
  44564. (WebCore::JSElement::setAttributeNodeNS):
  44565. (WebCore::toJSNewlyCreated):
  44566. * bindings/js/JSEventCustom.cpp:
  44567. (WebCore::JSEvent::clipboardData):
  44568. (WebCore::toJS):
  44569. * bindings/js/JSEventListener.cpp:
  44570. (WebCore::JSAbstractEventListener::handleEvent):
  44571. (WebCore::eventParameterName):
  44572. (WebCore::JSLazyEventListener::parseCode):
  44573. * bindings/js/JSEventTarget.cpp:
  44574. (WebCore::toJS):
  44575. * bindings/js/JSEventTarget.h:
  44576. * bindings/js/JSEventTargetBase.h:
  44577. * bindings/js/JSEventTargetNodeCustom.cpp:
  44578. (WebCore::JSEventTargetNode::addEventListener):
  44579. (WebCore::JSEventTargetNode::removeEventListener):
  44580. * bindings/js/JSGeolocationCustom.cpp:
  44581. (WebCore::createPositionOptions):
  44582. (WebCore::JSGeolocation::getCurrentPosition):
  44583. (WebCore::JSGeolocation::watchPosition):
  44584. * bindings/js/JSHTMLAllCollection.h:
  44585. (WebCore::JSHTMLAllCollection::createStructure):
  44586. * bindings/js/JSHTMLAppletElementCustom.cpp:
  44587. (WebCore::JSHTMLAppletElement::customPut):
  44588. (WebCore::JSHTMLAppletElement::nameGetter):
  44589. * bindings/js/JSHTMLCollectionCustom.cpp:
  44590. (WebCore::getNamedItems):
  44591. (WebCore::callHTMLCollection):
  44592. (WebCore::JSHTMLCollection::nameGetter):
  44593. (WebCore::JSHTMLCollection::item):
  44594. (WebCore::JSHTMLCollection::namedItem):
  44595. (WebCore::toJS):
  44596. * bindings/js/JSHTMLDocumentCustom.cpp:
  44597. (WebCore::JSHTMLDocument::nameGetter):
  44598. (WebCore::JSHTMLDocument::all):
  44599. (WebCore::JSHTMLDocument::setAll):
  44600. (WebCore::JSHTMLDocument::open):
  44601. (WebCore::JSHTMLDocument::write):
  44602. (WebCore::JSHTMLDocument::writeln):
  44603. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  44604. (WebCore::JSHTMLEmbedElement::customPut):
  44605. (WebCore::JSHTMLEmbedElement::nameGetter):
  44606. * bindings/js/JSHTMLFormElementCustom.cpp:
  44607. (WebCore::JSHTMLFormElement::nameGetter):
  44608. * bindings/js/JSHTMLFrameElementCustom.cpp:
  44609. (WebCore::JSHTMLFrameElement::setSrc):
  44610. (WebCore::JSHTMLFrameElement::setLocation):
  44611. * bindings/js/JSHTMLFrameSetElementCustom.cpp:
  44612. (WebCore::JSHTMLFrameSetElement::nameGetter):
  44613. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  44614. (WebCore::JSHTMLIFrameElement::setSrc):
  44615. * bindings/js/JSHTMLInputElementCustom.cpp:
  44616. (WebCore::JSHTMLInputElement::selectionStart):
  44617. (WebCore::JSHTMLInputElement::selectionEnd):
  44618. * bindings/js/JSHTMLObjectElementCustom.cpp:
  44619. (WebCore::JSHTMLObjectElement::customPut):
  44620. (WebCore::JSHTMLObjectElement::nameGetter):
  44621. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  44622. (WebCore::JSHTMLOptionsCollection::length):
  44623. (WebCore::JSHTMLOptionsCollection::setLength):
  44624. (WebCore::JSHTMLOptionsCollection::indexSetter):
  44625. (WebCore::JSHTMLOptionsCollection::add):
  44626. (WebCore::JSHTMLOptionsCollection::remove):
  44627. * bindings/js/JSHTMLSelectElementCustom.cpp:
  44628. (WebCore::JSHTMLSelectElement::remove):
  44629. (WebCore::selectIndexSetter):
  44630. (WebCore::JSHTMLSelectElement::indexSetter):
  44631. * bindings/js/JSHTMLSelectElementCustom.h:
  44632. * bindings/js/JSHistoryCustom.cpp:
  44633. (WebCore::nonCachingStaticBackFunctionGetter):
  44634. (WebCore::nonCachingStaticForwardFunctionGetter):
  44635. (WebCore::nonCachingStaticGoFunctionGetter):
  44636. (WebCore::JSHistory::customPut):
  44637. * bindings/js/JSImageDataCustom.cpp:
  44638. (WebCore::toJS):
  44639. * bindings/js/JSInspectedObjectWrapper.cpp:
  44640. (WebCore::JSInspectedObjectWrapper::wrap):
  44641. (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
  44642. * bindings/js/JSInspectedObjectWrapper.h:
  44643. (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
  44644. * bindings/js/JSInspectorCallbackWrapper.cpp:
  44645. (WebCore::JSInspectorCallbackWrapper::wrap):
  44646. (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
  44647. * bindings/js/JSInspectorCallbackWrapper.h:
  44648. (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
  44649. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  44650. (WebCore::JSJavaScriptCallFrame::evaluate):
  44651. (WebCore::JSJavaScriptCallFrame::thisObject):
  44652. (WebCore::JSJavaScriptCallFrame::type):
  44653. (WebCore::JSJavaScriptCallFrame::scopeChain):
  44654. * bindings/js/JSLocationCustom.cpp:
  44655. (WebCore::nonCachingStaticReplaceFunctionGetter):
  44656. (WebCore::nonCachingStaticReloadFunctionGetter):
  44657. (WebCore::nonCachingStaticAssignFunctionGetter):
  44658. (WebCore::JSLocation::customPut):
  44659. (WebCore::JSLocation::setHref):
  44660. (WebCore::JSLocation::setProtocol):
  44661. (WebCore::JSLocation::setHost):
  44662. (WebCore::JSLocation::setHostname):
  44663. (WebCore::JSLocation::setPort):
  44664. (WebCore::JSLocation::setPathname):
  44665. (WebCore::JSLocation::setSearch):
  44666. (WebCore::JSLocation::setHash):
  44667. (WebCore::JSLocation::replace):
  44668. (WebCore::JSLocation::reload):
  44669. (WebCore::JSLocation::assign):
  44670. (WebCore::JSLocation::toString):
  44671. * bindings/js/JSMessageChannelConstructor.h:
  44672. * bindings/js/JSMessagePortCustom.cpp:
  44673. (WebCore::JSMessagePort::startConversation):
  44674. (WebCore::JSMessagePort::addEventListener):
  44675. (WebCore::JSMessagePort::removeEventListener):
  44676. * bindings/js/JSMimeTypeArrayCustom.cpp:
  44677. (WebCore::JSMimeTypeArray::nameGetter):
  44678. * bindings/js/JSNamedNodeMapCustom.cpp:
  44679. (WebCore::JSNamedNodeMap::nameGetter):
  44680. * bindings/js/JSNamedNodesCollection.cpp:
  44681. (WebCore::JSNamedNodesCollection::lengthGetter):
  44682. (WebCore::JSNamedNodesCollection::indexGetter):
  44683. * bindings/js/JSNamedNodesCollection.h:
  44684. (WebCore::JSNamedNodesCollection::createStructure):
  44685. * bindings/js/JSNavigatorCustom.cpp:
  44686. (WebCore::needsYouTubeQuirk):
  44687. (WebCore::JSNavigator::appVersion):
  44688. * bindings/js/JSNodeCustom.cpp:
  44689. (WebCore::JSNode::insertBefore):
  44690. (WebCore::JSNode::replaceChild):
  44691. (WebCore::JSNode::removeChild):
  44692. (WebCore::JSNode::appendChild):
  44693. (WebCore::createWrapper):
  44694. (WebCore::toJSNewlyCreated):
  44695. (WebCore::toJS):
  44696. * bindings/js/JSNodeFilterCondition.cpp:
  44697. (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
  44698. (WebCore::JSNodeFilterCondition::acceptNode):
  44699. * bindings/js/JSNodeFilterCondition.h:
  44700. (WebCore::JSNodeFilterCondition::create):
  44701. * bindings/js/JSNodeFilterCustom.cpp:
  44702. (WebCore::JSNodeFilter::acceptNode):
  44703. (WebCore::toNodeFilter):
  44704. * bindings/js/JSNodeIteratorCustom.cpp:
  44705. (WebCore::JSNodeIterator::nextNode):
  44706. (WebCore::JSNodeIterator::previousNode):
  44707. * bindings/js/JSNodeListCustom.cpp:
  44708. (WebCore::callNodeList):
  44709. (WebCore::JSNodeList::nameGetter):
  44710. * bindings/js/JSPluginArrayCustom.cpp:
  44711. (WebCore::JSPluginArray::nameGetter):
  44712. * bindings/js/JSPluginCustom.cpp:
  44713. (WebCore::JSPlugin::nameGetter):
  44714. * bindings/js/JSPluginElementFunctions.cpp:
  44715. (WebCore::runtimeObjectGetter):
  44716. (WebCore::runtimeObjectPropertyGetter):
  44717. (WebCore::runtimeObjectCustomPut):
  44718. (WebCore::callPlugin):
  44719. * bindings/js/JSPluginElementFunctions.h:
  44720. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  44721. (WebCore::JSQuarantinedObjectWrapper::asWrapper):
  44722. (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
  44723. (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
  44724. (WebCore::JSQuarantinedObjectWrapper::put):
  44725. (WebCore::JSQuarantinedObjectWrapper::construct):
  44726. (WebCore::JSQuarantinedObjectWrapper::hasInstance):
  44727. (WebCore::JSQuarantinedObjectWrapper::call):
  44728. * bindings/js/JSQuarantinedObjectWrapper.h:
  44729. (WebCore::JSQuarantinedObjectWrapper::createStructure):
  44730. * bindings/js/JSRGBColor.cpp:
  44731. (WebCore::getJSRGBColor):
  44732. (jsRGBColorRed):
  44733. (jsRGBColorGreen):
  44734. (jsRGBColorBlue):
  44735. * bindings/js/JSRGBColor.h:
  44736. (WebCore::JSRGBColor::createStructure):
  44737. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  44738. (WebCore::JSSQLResultSetRowList::item):
  44739. * bindings/js/JSSQLTransactionCustom.cpp:
  44740. (WebCore::JSSQLTransaction::executeSql):
  44741. * bindings/js/JSSVGElementInstanceCustom.cpp:
  44742. (WebCore::JSSVGElementInstance::addEventListener):
  44743. (WebCore::JSSVGElementInstance::removeEventListener):
  44744. * bindings/js/JSSVGLengthCustom.cpp:
  44745. (WebCore::JSSVGLength::value):
  44746. (WebCore::JSSVGLength::convertToSpecifiedUnits):
  44747. * bindings/js/JSSVGMatrixCustom.cpp:
  44748. (WebCore::JSSVGMatrix::multiply):
  44749. (WebCore::JSSVGMatrix::inverse):
  44750. (WebCore::JSSVGMatrix::translate):
  44751. (WebCore::JSSVGMatrix::scale):
  44752. (WebCore::JSSVGMatrix::scaleNonUniform):
  44753. (WebCore::JSSVGMatrix::rotate):
  44754. (WebCore::JSSVGMatrix::rotateFromVector):
  44755. (WebCore::JSSVGMatrix::flipX):
  44756. (WebCore::JSSVGMatrix::flipY):
  44757. (WebCore::JSSVGMatrix::skewX):
  44758. (WebCore::JSSVGMatrix::skewY):
  44759. * bindings/js/JSSVGPathSegCustom.cpp:
  44760. (WebCore::toJS):
  44761. * bindings/js/JSSVGPathSegListCustom.cpp:
  44762. (WebCore::JSSVGPathSegList::clear):
  44763. (WebCore::JSSVGPathSegList::initialize):
  44764. (WebCore::JSSVGPathSegList::getItem):
  44765. (WebCore::JSSVGPathSegList::insertItemBefore):
  44766. (WebCore::JSSVGPathSegList::replaceItem):
  44767. (WebCore::JSSVGPathSegList::removeItem):
  44768. (WebCore::JSSVGPathSegList::appendItem):
  44769. * bindings/js/JSSVGPointListCustom.cpp:
  44770. (WebCore::finishGetter):
  44771. (WebCore::finishSetter):
  44772. (WebCore::finishSetterReadOnlyResult):
  44773. (WebCore::JSSVGPointList::clear):
  44774. (WebCore::JSSVGPointList::initialize):
  44775. (WebCore::JSSVGPointList::getItem):
  44776. (WebCore::JSSVGPointList::insertItemBefore):
  44777. (WebCore::JSSVGPointList::replaceItem):
  44778. (WebCore::JSSVGPointList::removeItem):
  44779. (WebCore::JSSVGPointList::appendItem):
  44780. * bindings/js/JSSVGTransformListCustom.cpp:
  44781. (WebCore::finishGetter):
  44782. (WebCore::finishSetter):
  44783. (WebCore::finishSetterReadOnlyResult):
  44784. (WebCore::JSSVGTransformList::clear):
  44785. (WebCore::JSSVGTransformList::initialize):
  44786. (WebCore::JSSVGTransformList::getItem):
  44787. (WebCore::JSSVGTransformList::insertItemBefore):
  44788. (WebCore::JSSVGTransformList::replaceItem):
  44789. (WebCore::JSSVGTransformList::removeItem):
  44790. (WebCore::JSSVGTransformList::appendItem):
  44791. * bindings/js/JSStorageCustom.cpp:
  44792. (WebCore::JSStorage::nameGetter):
  44793. (WebCore::JSStorage::deleteProperty):
  44794. (WebCore::JSStorage::customPut):
  44795. * bindings/js/JSStyleSheetCustom.cpp:
  44796. (WebCore::toJS):
  44797. * bindings/js/JSStyleSheetListCustom.cpp:
  44798. (WebCore::JSStyleSheetList::nameGetter):
  44799. * bindings/js/JSTextCustom.cpp:
  44800. (WebCore::toJSNewlyCreated):
  44801. * bindings/js/JSTreeWalkerCustom.cpp:
  44802. (WebCore::JSTreeWalker::parentNode):
  44803. (WebCore::JSTreeWalker::firstChild):
  44804. (WebCore::JSTreeWalker::lastChild):
  44805. (WebCore::JSTreeWalker::nextSibling):
  44806. (WebCore::JSTreeWalker::previousSibling):
  44807. (WebCore::JSTreeWalker::previousNode):
  44808. (WebCore::JSTreeWalker::nextNode):
  44809. * bindings/js/JSWorkerContextBase.cpp:
  44810. (WebCore::JSWorkerContextBase::put):
  44811. * bindings/js/JSWorkerContextBase.h:
  44812. * bindings/js/JSWorkerContextCustom.cpp:
  44813. (WebCore::JSWorkerContext::self):
  44814. (WebCore::JSWorkerContext::setSelf):
  44815. (WebCore::JSWorkerContext::addEventListener):
  44816. (WebCore::JSWorkerContext::removeEventListener):
  44817. * bindings/js/JSWorkerCustom.cpp:
  44818. (WebCore::JSWorker::addEventListener):
  44819. (WebCore::JSWorker::removeEventListener):
  44820. * bindings/js/JSXMLHttpRequestCustom.cpp:
  44821. (WebCore::JSXMLHttpRequest::open):
  44822. (WebCore::JSXMLHttpRequest::setRequestHeader):
  44823. (WebCore::JSXMLHttpRequest::send):
  44824. (WebCore::JSXMLHttpRequest::getResponseHeader):
  44825. (WebCore::JSXMLHttpRequest::overrideMimeType):
  44826. (WebCore::JSXMLHttpRequest::addEventListener):
  44827. (WebCore::JSXMLHttpRequest::removeEventListener):
  44828. (WebCore::JSXMLHttpRequest::responseText):
  44829. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  44830. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  44831. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  44832. * bindings/js/JSXSLTProcessorCustom.cpp:
  44833. (WebCore::JSXSLTProcessor::importStylesheet):
  44834. (WebCore::JSXSLTProcessor::transformToFragment):
  44835. (WebCore::JSXSLTProcessor::transformToDocument):
  44836. (WebCore::JSXSLTProcessor::setParameter):
  44837. (WebCore::JSXSLTProcessor::getParameter):
  44838. (WebCore::JSXSLTProcessor::removeParameter):
  44839. * bindings/js/ScheduledAction.cpp:
  44840. (WebCore::ScheduledAction::ScheduledAction):
  44841. (WebCore::ScheduledAction::execute):
  44842. * bindings/js/ScheduledAction.h:
  44843. * bindings/js/ScriptCallStack.cpp:
  44844. (WebCore::ScriptCallStack::ScriptCallStack):
  44845. (WebCore::ScriptCallStack::initialize):
  44846. * bindings/js/ScriptController.cpp:
  44847. (WebCore::ScriptController::createScriptObjectForPluginElement):
  44848. * bindings/js/ScriptValue.cpp:
  44849. (WebCore::ScriptValue::getString):
  44850. (WebCore::ScriptValue::isNull):
  44851. (WebCore::ScriptValue::isUndefined):
  44852. * bindings/js/ScriptValue.h:
  44853. (WebCore::ScriptValue::ScriptValue):
  44854. (WebCore::ScriptValue::jsValue):
  44855. * bindings/objc/WebScriptObject.mm:
  44856. (-[WebScriptObject callWebScriptMethod:withArguments:]):
  44857. (-[WebScriptObject evaluateWebScript:]):
  44858. (-[WebScriptObject valueForKey:]):
  44859. (-[WebScriptObject webScriptValueAtIndex:]):
  44860. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  44861. * bindings/objc/WebScriptObjectPrivate.h:
  44862. * bindings/scripts/CodeGeneratorJS.pm:
  44863. * bridge/NP_jsobject.cpp:
  44864. (_NPN_InvokeDefault):
  44865. (_NPN_Invoke):
  44866. (_NPN_Evaluate):
  44867. (_NPN_GetProperty):
  44868. (_NPN_HasMethod):
  44869. (_NPN_Construct):
  44870. * bridge/c/c_instance.cpp:
  44871. (JSC::Bindings::CInstance::invokeMethod):
  44872. (JSC::Bindings::CInstance::invokeDefaultMethod):
  44873. (JSC::Bindings::CInstance::invokeConstruct):
  44874. (JSC::Bindings::CInstance::defaultValue):
  44875. (JSC::Bindings::CInstance::stringValue):
  44876. (JSC::Bindings::CInstance::numberValue):
  44877. (JSC::Bindings::CInstance::booleanValue):
  44878. (JSC::Bindings::CInstance::valueOf):
  44879. * bridge/c/c_instance.h:
  44880. * bridge/c/c_runtime.cpp:
  44881. (JSC::Bindings::CField::valueFromInstance):
  44882. (JSC::Bindings::CField::setValueToInstance):
  44883. * bridge/c/c_runtime.h:
  44884. * bridge/c/c_utility.cpp:
  44885. (JSC::Bindings::convertValueToNPVariant):
  44886. (JSC::Bindings::convertNPVariantToValue):
  44887. * bridge/c/c_utility.h:
  44888. * bridge/jni/jni_instance.cpp:
  44889. (JavaInstance::stringValue):
  44890. (JavaInstance::numberValue):
  44891. (JavaInstance::booleanValue):
  44892. (JavaInstance::invokeMethod):
  44893. (JavaInstance::defaultValue):
  44894. (JavaInstance::valueOf):
  44895. * bridge/jni/jni_instance.h:
  44896. * bridge/jni/jni_jsobject.h:
  44897. * bridge/jni/jni_jsobject.mm:
  44898. (JavaJSObject::call):
  44899. (JavaJSObject::eval):
  44900. (JavaJSObject::getMember):
  44901. (JavaJSObject::getSlot):
  44902. (JavaJSObject::convertValueToJObject):
  44903. (JavaJSObject::convertJObjectToValue):
  44904. * bridge/jni/jni_objc.mm:
  44905. (JSC::Bindings::dispatchJNICall):
  44906. * bridge/jni/jni_runtime.cpp:
  44907. (JavaArray::convertJObjectToArray):
  44908. (JavaField::dispatchValueFromInstance):
  44909. (JavaField::valueFromInstance):
  44910. (JavaField::dispatchSetValueToInstance):
  44911. (JavaField::setValueToInstance):
  44912. (JavaArray::setValueAt):
  44913. (JavaArray::valueAt):
  44914. * bridge/jni/jni_runtime.h:
  44915. * bridge/jni/jni_utility.cpp:
  44916. (JSC::Bindings::convertArrayInstanceToJavaArray):
  44917. (JSC::Bindings::convertValueToJValue):
  44918. * bridge/jni/jni_utility.h:
  44919. * bridge/objc/WebScriptObject.h:
  44920. * bridge/objc/objc_class.h:
  44921. * bridge/objc/objc_class.mm:
  44922. (JSC::Bindings::ObjcClass::fallbackObject):
  44923. * bridge/objc/objc_instance.h:
  44924. * bridge/objc/objc_instance.mm:
  44925. (ObjcInstance::invokeMethod):
  44926. (ObjcInstance::invokeDefaultMethod):
  44927. (ObjcInstance::setValueOfUndefinedField):
  44928. (ObjcInstance::getValueOfUndefinedField):
  44929. (ObjcInstance::defaultValue):
  44930. (ObjcInstance::stringValue):
  44931. (ObjcInstance::numberValue):
  44932. (ObjcInstance::booleanValue):
  44933. (ObjcInstance::valueOf):
  44934. * bridge/objc/objc_runtime.h:
  44935. (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  44936. * bridge/objc/objc_runtime.mm:
  44937. (JSC::Bindings::ObjcField::valueFromInstance):
  44938. (JSC::Bindings::convertValueToObjcObject):
  44939. (JSC::Bindings::ObjcField::setValueToInstance):
  44940. (JSC::Bindings::ObjcArray::setValueAt):
  44941. (JSC::Bindings::ObjcArray::valueAt):
  44942. (JSC::Bindings::ObjcFallbackObjectImp::put):
  44943. (JSC::Bindings::callObjCFallbackObject):
  44944. (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
  44945. * bridge/objc/objc_utility.h:
  44946. * bridge/objc/objc_utility.mm:
  44947. (JSC::Bindings::convertValueToObjcValue):
  44948. (JSC::Bindings::convertNSStringToString):
  44949. (JSC::Bindings::convertObjcValueToValue):
  44950. * bridge/runtime.cpp:
  44951. (JSC::Bindings::Instance::getValueOfField):
  44952. (JSC::Bindings::Instance::setValueOfField):
  44953. * bridge/runtime.h:
  44954. (JSC::Bindings::Class::fallbackObject):
  44955. (JSC::Bindings::Instance::getValueOfUndefinedField):
  44956. (JSC::Bindings::Instance::setValueOfUndefinedField):
  44957. (JSC::Bindings::Instance::invokeDefaultMethod):
  44958. (JSC::Bindings::Instance::invokeConstruct):
  44959. (JSC::Bindings::Instance::valueOf):
  44960. * bridge/runtime_array.cpp:
  44961. (JSC::RuntimeArray::lengthGetter):
  44962. (JSC::RuntimeArray::indexGetter):
  44963. (JSC::RuntimeArray::put):
  44964. * bridge/runtime_array.h:
  44965. (JSC::RuntimeArray::createStructure):
  44966. * bridge/runtime_method.cpp:
  44967. (JSC::RuntimeMethod::lengthGetter):
  44968. (JSC::callRuntimeMethod):
  44969. * bridge/runtime_method.h:
  44970. (JSC::RuntimeMethod::createStructure):
  44971. * bridge/runtime_object.cpp:
  44972. (JSC::RuntimeObjectImp::fallbackObjectGetter):
  44973. (JSC::RuntimeObjectImp::fieldGetter):
  44974. (JSC::RuntimeObjectImp::methodGetter):
  44975. (JSC::RuntimeObjectImp::put):
  44976. (JSC::RuntimeObjectImp::defaultValue):
  44977. (JSC::callRuntimeObject):
  44978. (JSC::callRuntimeConstructor):
  44979. * bridge/runtime_object.h:
  44980. (JSC::RuntimeObjectImp::createStructure):
  44981. * inspector/InspectorController.cpp:
  44982. * inspector/JavaScriptCallFrame.cpp:
  44983. (WebCore::JavaScriptCallFrame::evaluate):
  44984. * inspector/JavaScriptCallFrame.h:
  44985. * inspector/JavaScriptProfile.cpp:
  44986. (WebCore::toJS):
  44987. * inspector/JavaScriptProfile.h:
  44988. * inspector/JavaScriptProfileNode.cpp:
  44989. (WebCore::toJS):
  44990. * inspector/JavaScriptProfileNode.h:
  44991. * xml/XMLHttpRequest.cpp:
  44992. (WebCore::XMLHttpRequest::dropProtection):
  44993. 2009-01-06 Pierre-Olivier Latour <pol@apple.com>
  44994. Reviewed by Darin Adler.
  44995. Added new API on AnimationController::numberOfActiveAnimations() to be used by DRT.
  44996. https://bugs.webkit.org/show_bug.cgi?id=23126
  44997. Test: animations/animation-controller-drt-api.html
  44998. * WebCore.base.exp:
  44999. * page/animation/AnimationController.cpp:
  45000. (WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
  45001. (WebCore::AnimationController::numberOfActiveAnimations):
  45002. * page/animation/AnimationController.h:
  45003. * page/animation/CompositeAnimation.cpp:
  45004. (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
  45005. (WebCore::CompositeAnimation::numberOfActiveAnimations):
  45006. * page/animation/CompositeAnimation.h:
  45007. 2009-01-06 Eric Seidel <eric@webkit.org>
  45008. Reviewed by Gavin Barraclough.
  45009. Upstream 3 more files to get the WebCore-Chromium build a bit further.
  45010. * WebCore.scons:
  45011. * page/chromium/AccessibilityObjectChromium.cpp: Added.
  45012. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  45013. * page/chromium/AccessibilityObjectWrapper.h: Added.
  45014. (WebCore::AccessibilityObjectWrapper::~AccessibilityObjectWrapper):
  45015. (WebCore::AccessibilityObjectWrapper::attached):
  45016. (WebCore::AccessibilityObjectWrapper::accessibilityObject):
  45017. (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
  45018. * platform/chromium/PasteboardPrivate.h: Added.
  45019. (WebCore::PasteboardPrivate::):
  45020. 2009-01-06 Chris Marrin <cmarrin@apple.com>
  45021. Reviewed by David Hyatt.
  45022. Tests: animations/simultaneous-start-left.html
  45023. animations/simultaneous-start-transform.html
  45024. Fixed https://bugs.webkit.org/show_bug.cgi?id=22870
  45025. I added calls beginAnimationUpdate() and endAnimationUpdate() calls
  45026. to AnimationController. These are called by Document at the start
  45027. and end of the recalcStyle cycle. Right now, I'm just using the
  45028. beginAnimationUpdate() method to reset an animation time value.
  45029. The first time the animation time is accessed after this reset I set
  45030. it to the currentTime. So all animations in that cycle get the same
  45031. start time.
  45032. The test cases checked in test this, but in the case of the 'left'
  45033. test it actually doesn't make any difference in most cases. This is
  45034. because values are clamped to whole pixels, so the start times would
  45035. have to be pretty far off for the test to fail using the old
  45036. currentTime() model. Still, under really heavy load, it's possible for
  45037. the test to fail without these changes.
  45038. The 'transform' test is another story. It animates to the full resolution
  45039. of a floating point number, so the test fails miserably without this
  45040. fix.
  45041. * dom/Document.cpp:
  45042. (WebCore::Document::recalcStyle):
  45043. * page/animation/AnimationBase.cpp:
  45044. (WebCore::AnimationBase::updateStateMachine):
  45045. (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
  45046. (WebCore::AnimationBase::willNeedService):
  45047. (WebCore::AnimationBase::progress):
  45048. (WebCore::AnimationBase::goIntoEndingOrLoopingState):
  45049. (WebCore::AnimationBase::beginAnimationUpdateTime):
  45050. * page/animation/AnimationBase.h:
  45051. * page/animation/AnimationController.cpp:
  45052. (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  45053. (WebCore::AnimationControllerPrivate::setBeginAnimationUpdateTime):
  45054. (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
  45055. (WebCore::AnimationController::updateAnimations):
  45056. (WebCore::AnimationController::beginAnimationUpdateTime):
  45057. (WebCore::AnimationController::beginAnimationUpdate):
  45058. (WebCore::AnimationController::endAnimationUpdate):
  45059. * page/animation/AnimationController.h:
  45060. * page/animation/KeyframeAnimation.cpp:
  45061. (WebCore::KeyframeAnimation::animate):
  45062. 2009-01-06 Julien Chaffraix <jchaffraix@webkit.org>
  45063. Reviewed by Nikolas Zimmermann.
  45064. Bug 22858: Simplify make_names.pl code for avoiding multiple definitions or inclusions
  45065. https://bugs.webkit.org/show_bug.cgi?id=22858
  45066. I had introduced an awkward situation using hasCustomJSWrapper and
  45067. sometimes boolean parameter in order to ensure JS wrapper generated once
  45068. or header included once.
  45069. Simplified the code by using a %seenTag hash to detect multiple definitions
  45070. or inclusions and skipping it.
  45071. Also cleaned up a bit make_names.pl by using more explicit names and moving
  45072. code to where it belongs.
  45073. * dom/make_names.pl:
  45074. * html/HTMLTagNames.in: Necessary changes that were not detected by
  45075. the previous syntax but will be required for autogenerating HTMLElementFactory.
  45076. 2009-01-06 Anders Carlsson <andersca@apple.com>
  45077. Reviewed by Sam Weinig.
  45078. Add a way for frame loader clients to always create a PluginDocument, regardless of
  45079. the real document MIME type.
  45080. * loader/FrameLoader.cpp:
  45081. (WebCore::FrameLoader::begin):
  45082. (WebCore::FrameLoader::shouldUsePlugin):
  45083. * loader/FrameLoaderClient.h:
  45084. (WebCore::FrameLoaderClient::shouldUsePluginDocument):
  45085. 2009-01-06 Dean Jackson <dino@apple.com>
  45086. Reviewed by Dave Hyatt.
  45087. Extend Media Queries to cover transitions,
  45088. animations, transform-2d and transform-3d
  45089. http://webkit.org/specs/MediaQueriesExtensions.html
  45090. Note that the implementation uses -webkit- prefixes
  45091. even though the spec doesn't have them.
  45092. https://bugs.webkit.org/show_bug.cgi?id=22494
  45093. Tests: fast/media/mq-animation.html
  45094. fast/media/mq-transform-01.html
  45095. fast/media/mq-transform-02.html
  45096. fast/media/mq-transform-03.html
  45097. fast/media/mq-transform-04.html
  45098. fast/media/mq-transition.html
  45099. * css/MediaFeatureNames.h:
  45100. * css/MediaQueryEvaluator.cpp:
  45101. (WebCore::animationMediaFeatureEval):
  45102. (WebCore::transitionMediaFeatureEval):
  45103. (WebCore::transform_2dMediaFeatureEval):
  45104. (WebCore::transform_3dMediaFeatureEval):
  45105. 2009-01-06 Eric Seidel <eric@webkit.org>
  45106. Reviewed by Oliver Hunt.
  45107. Bring the Chromium-WebCore build closer to building
  45108. by upstreaming PlatformWidget.h add adding the JSC
  45109. plugin bridge files to the build.
  45110. * WebCore.scons:
  45111. * platform/chromium/PlatformWidget.h: Added.
  45112. 2009-01-06 Eric Seidel <eric@webkit.org>
  45113. Build fix only, no review.
  45114. Bring the Chromium-WebCore build back closer to building
  45115. by adding files from recent commits.
  45116. * WebCore.scons:
  45117. 2009-01-06 Alexey Proskuryakov <ap@webkit.org>
  45118. Reviewed by Darin Adler.
  45119. <rdar://problem/6474973> REGRESSION: PLT ~2% slower due to 39465 (consolidate thread data)
  45120. I could not reproduce the slowdown on my PowerPC test machine, but the change should bring
  45121. performance back.
  45122. * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Don't use AtomicallyInitializedStatic.
  45123. Prior to r39465, it was only used for cached converters, which was necessary because the
  45124. first access to ICU or TEC one could happen on a secondary thread, but now they are all
  45125. initialized from ThreadGlobalData constructor.
  45126. 2009-01-06 David Smith <catfish.man@gmail.com>
  45127. Reviewed by Darin Adler.
  45128. https://bugs.webkit.org/show_bug.cgi?id=23129
  45129. Devirtualize Node::childNodes().
  45130. 2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
  45131. Unreviewed build fix.
  45132. Fix the Qt build with Qt 4.4.x, the HTTP-only cookie support was
  45133. added in Qt 4.5.
  45134. * platform/qt/CookieJarQt.cpp:
  45135. (WebCore::setCookies):
  45136. (WebCore::cookies):
  45137. 2009-01-06 Zalan Bujtas <zbujtas@gmail.com>
  45138. Reviewed by David Kilzer.
  45139. https://bugs.webkit.org/show_bug.cgi?id=23133
  45140. Fix SVG disabled build. Move 'pointer-events' from SVGCSSPropertyNames.in to
  45141. CSSPropertyNames.in and move PointerEvents functions out of #if ENABLE(SVG)
  45142. NOTE: Property name fixes landed as part of r39648.
  45143. * css/CSSPrimitiveValueMappings.h:
  45144. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  45145. (WebCore::CSSPrimitiveValue::operator EPointerEvents):
  45146. * css/CSSPropertyNames.in:
  45147. * css/SVGCSSPropertyNames.in:
  45148. 2009-01-06 David Kilzer <ddkilzer@apple.com>
  45149. BUILD FIX (r39634): Fix build for non-SVG builds (Wx)
  45150. * css/CSSPropertyNames.in: Added 'pointer-events'.
  45151. * css/SVGCSSPropertyNames.in: Commented out pointer-events
  45152. since it's now a plain CSS property.
  45153. 2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
  45154. Reviewed by Lars Knoll.
  45155. Added support for HTTP-only cookies to the Qt build.
  45156. * platform/qt/CookieJarQt.cpp:
  45157. (WebCore::setCookies): Don't set HTTP-only cookies through the DOM.
  45158. (WebCore::cookies): Don't return HTTP-only cookies to the DOM.
  45159. 2009-01-05 David Smith <catfish.man@gmail.com>
  45160. Reviewed by Oliver Hunt.
  45161. https://bugs.webkit.org/show_bug.cgi?id=23084
  45162. Avoid redundant AtomicString conversions
  45163. * dom/Node.cpp: Create an AtomicString early to avoid converting twice
  45164. (WebCore::Node::getElementsByTagNameNS):
  45165. * dom/QualifiedName.h: Use the appropriate AtomicString constructor instead of converting from a String
  45166. 2009-01-05 Simon Fraser <simon.fraser@apple.com>
  45167. Reviewed by Dave Hyatt
  45168. https://bugs.webkit.org/show_bug.cgi?id=22985
  45169. Add an assertion that clip rects are being used when painting with the same
  45170. rootLayer that they were computed with.
  45171. Fix two issues detected by the assertion:
  45172. RenderLayer::updateClipRects() should not unconditionally update the clip rects
  45173. on its parent, but stop when reaching rootLayer (just like calculateClipRects()).
  45174. We need to pass the temporaryClipRects flag down through reflection painting
  45175. to handle the case of nested reflections.
  45176. Also use temporary clip rects in RenderTreeAsText, since that code does not
  45177. reset the painting root for transformed layers, so cached clip rects will not
  45178. match those used for painting.
  45179. * rendering/RenderLayer.cpp:
  45180. (WebCore::RenderLayer::RenderLayer):
  45181. (WebCore::RenderLayer::paintLayer):
  45182. (WebCore::RenderLayer::updateClipRects):
  45183. (WebCore::RenderLayer::clearClipRects):
  45184. * rendering/RenderLayer.h:
  45185. * rendering/RenderTreeAsText.cpp:
  45186. (WebCore::writeLayers):
  45187. 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
  45188. Fix the Qt build
  45189. * platform/graphics/qt/AffineTransformQt.cpp:
  45190. (WebCore::TransformationMatrix::TransformationMatrix):
  45191. 2009-01-05 Mark Rowe <mrowe@apple.com>
  45192. Fix the build some more.
  45193. * platform/graphics/cairo/AffineTransformCairo.cpp:
  45194. (WebCore::TransformationMatrix::TransformationMatrix):
  45195. 2009-01-05 Oliver Hunt <oliver@apple.com>
  45196. Reviewed by NOBODY (Build fix).
  45197. Fix Cairo/Gtk build
  45198. * platform/graphics/cairo/ImageBufferCairo.cpp:
  45199. (WebCore::ImageBuffer::putImageData):
  45200. 2009-01-05 Dean Jackson <dino@apple.com>
  45201. Reviewed by Darin Adler.
  45202. Rename AffineTransform to TransformationMatrix in
  45203. preparation for future enhancements (non-affine matrices)
  45204. https://bugs.webkit.org/show_bug.cgi?id=22943
  45205. * GNUmakefile.am:
  45206. * WebCore.pro:
  45207. * WebCore.scons:
  45208. * WebCore.vcproj/WebCore.vcproj:
  45209. * WebCore.xcodeproj/project.pbxproj:
  45210. * WebCoreSources.bkl:
  45211. * platform/graphics/transforms/AffineTransform.cpp: Removed.
  45212. * platform/graphics/transforms/AffineTransform.h: Removed.
  45213. * platform/graphics/transforms/TransformationMatrix.cpp: Copied from WebCore/platform/graphics/transforms/AffineTransform.cpp.
  45214. * platform/graphics/transforms/TransformationMatrix.h: Copied from WebCore/platform/graphics/transforms/AffineTransform.h.
  45215. * lots of other files with s/AffineTransform/TransformationMatrix/g
  45216. 2008-01-05 Dean Jackson <dino@apple.com>
  45217. Reviewed by David Hyatt.
  45218. Implement 'pointer-events' for HTML content. This involved
  45219. adding a new value 'auto' which behaves as 'visiblePainted'
  45220. in SVG content.
  45221. Moved the property out of the SVG CSS code and into
  45222. the general CSS (both parsing and RenderStyle).
  45223. Changes to the hit testing functionality of the Render tree,
  45224. specifically the nodeAtPoint methods. Where they used to
  45225. test for visibility, they now use a helper function defined
  45226. on base classes (RenderObject and InlineBox) that checks both
  45227. visibility and pointer-events.
  45228. https://bugs.webkit.org/show_bug.cgi?id=11395
  45229. Tests: fast/events/pointer-events-2.html
  45230. fast/events/pointer-events.html
  45231. * css/CSSComputedStyleDeclaration.cpp:
  45232. (WebCore::):
  45233. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  45234. * css/CSSParser.cpp:
  45235. (WebCore::CSSParser::parseValue):
  45236. * css/CSSPrimitiveValueMappings.h:
  45237. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  45238. (WebCore::CSSPrimitiveValue::operator EPointerEvents):
  45239. * css/CSSStyleSelector.cpp:
  45240. (WebCore::CSSStyleSelector::applyProperty):
  45241. * css/SVGCSSComputedStyleDeclaration.cpp:
  45242. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  45243. * css/SVGCSSStyleSelector.cpp:
  45244. (WebCore::CSSStyleSelector::applySVGProperty):
  45245. * manual-tests/pointer-events.html: Added.
  45246. * rendering/EllipsisBox.cpp:
  45247. (WebCore::EllipsisBox::nodeAtPoint):
  45248. * rendering/InlineBox.h:
  45249. (WebCore::InlineBox::visibleToHitTesting):
  45250. * rendering/InlineFlowBox.cpp:
  45251. (WebCore::InlineFlowBox::nodeAtPoint):
  45252. * rendering/InlineTextBox.cpp:
  45253. (WebCore::InlineTextBox::nodeAtPoint):
  45254. * rendering/PointerEventsHitRules.cpp:
  45255. (WebCore::PointerEventsHitRules::PointerEventsHitRules):
  45256. * rendering/PointerEventsHitRules.h:
  45257. (WebCore::PointerEventsHitRules::):
  45258. * rendering/RenderBlock.cpp:
  45259. (WebCore::RenderBlock::nodeAtPoint):
  45260. * rendering/RenderBox.cpp:
  45261. (WebCore::RenderBox::nodeAtPoint):
  45262. * rendering/RenderObject.h:
  45263. (WebCore::RenderObject::visibleToHitTesting):
  45264. * rendering/RenderPath.cpp:
  45265. (WebCore::RenderPath::nodeAtPoint):
  45266. * rendering/RenderSVGImage.cpp:
  45267. (WebCore::RenderSVGImage::nodeAtPoint):
  45268. * rendering/RenderSVGText.cpp:
  45269. (WebCore::RenderSVGText::nodeAtPoint):
  45270. * rendering/RootInlineBox.cpp:
  45271. (WebCore::RootInlineBox::nodeAtPoint):
  45272. * rendering/TextControlInnerElements.cpp:
  45273. (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  45274. * rendering/style/RenderStyle.h:
  45275. (WebCore::):
  45276. (WebCore::InheritedFlags::setBitDefaults):
  45277. (WebCore::InheritedFlags::pointerEvents):
  45278. (WebCore::InheritedFlags::setPointerEvents):
  45279. (WebCore::InheritedFlags::initialPointerEvents):
  45280. * rendering/style/RenderStyleConstants.h:
  45281. (WebCore::):
  45282. * rendering/style/SVGRenderStyle.h:
  45283. (WebCore::SVGRenderStyle::InheritedFlags::operator==):
  45284. (WebCore::SVGRenderStyle::setBitDefaults):
  45285. * rendering/style/SVGRenderStyleDefs.h:
  45286. * css/CSSValueKeywords.in:
  45287. * css/SVGCSSValueKeywords.in:
  45288. 2009-01-05 Oliver Hunt <oliver@apple.com>
  45289. Reviewed by NOBODY (Build fix).
  45290. Fix Cairo/Gtk build
  45291. * platform/graphics/cairo/ImageBufferCairo.cpp:
  45292. (WebCore::ImageBuffer::getImageData):
  45293. 2009-01-05 Oliver Hunt <oliver@apple.com>
  45294. Reviewed by Gavin Barraclough.
  45295. CanvasPixelArray performance is too slow
  45296. <https://bugs.webkit.org/show_bug.cgi?id=23123>
  45297. Remove the WebCore CanvasPixelArray implementation and replace
  45298. CPA usage with JSC::ByteArray. Replace the JSCanvasPixelArray
  45299. wrapper with an explicitly instantiated JSByteArray put on the
  45300. JSImageData object as an ordinary ReadOnly, DontDelete property.
  45301. * DerivedSources.make:
  45302. * ForwardingHeaders/runtime/ByteArray.h: Added.
  45303. * ForwardingHeaders/runtime/JSByteArray.h: Added.
  45304. * GNUmakefile.am:
  45305. * WebCore.pro:
  45306. * WebCore.scons:
  45307. * WebCore.vcproj/WebCore.vcproj:
  45308. * WebCore.xcodeproj/project.pbxproj:
  45309. * bindings/js/JSCanvasPixelArrayCustom.h: Removed.
  45310. * bindings/js/JSImageDataCustom.cpp:
  45311. (WebCore::toJS):
  45312. * html/CanvasPixelArray.cpp: Removed.
  45313. * html/CanvasPixelArray.h: Removed.
  45314. * html/CanvasPixelArray.idl: Removed.
  45315. * html/CanvasRenderingContext2D.cpp:
  45316. (WebCore::createEmptyImageData):
  45317. * html/ImageData.cpp:
  45318. (WebCore::ImageData::ImageData):
  45319. * html/ImageData.h:
  45320. (WebCore::ImageData::data):
  45321. * html/ImageData.idl:
  45322. * platform/graphics/cg/ImageBufferCG.cpp:
  45323. (WebCore::ImageBuffer::getImageData):
  45324. (WebCore::ImageBuffer::putImageData):
  45325. 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
  45326. Reviewed by George Staikos.
  45327. Add notification for contentsSizeChanged which the Qt API will
  45328. introduce.
  45329. * loader/EmptyClients.h:
  45330. (WebCore::EmptyChromeClient::contentsSizeChanged):
  45331. * page/Chrome.cpp:
  45332. (WebCore::Chrome::contentsSizeChanged):
  45333. * page/Chrome.h:
  45334. * page/ChromeClient.h:
  45335. * page/FrameView.cpp:
  45336. (WebCore::FrameView::setContentsSize):
  45337. * page/FrameView.h:
  45338. * platform/HostWindow.h:
  45339. * platform/ScrollView.h:
  45340. 2009-01-05 Anders Carlsson <andersca@apple.com>
  45341. Build fix.
  45342. * plugins/PluginView.h:
  45343. (WebCore::PluginManualLoader::~PluginManualLoader):
  45344. 2009-01-05 Anders Carlsson <andersca@apple.com>
  45345. Reviewed by Kevin Decker.
  45346. Add an abstract PluginManualLoader class and make PluginView inherit from it.
  45347. Add some error checking that currently exists in WebKit (but not for long!)
  45348. * plugins/PluginView.cpp:
  45349. (WebCore::PluginView::didReceiveResponse):
  45350. (WebCore::PluginView::didReceiveData):
  45351. (WebCore::PluginView::didFinishLoading):
  45352. (WebCore::PluginView::didFail):
  45353. * plugins/PluginView.h:
  45354. 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
  45355. Reviewed by George Staikos.
  45356. Fixes FrameView to respect the state of scrollbarmode when it is explicitly
  45357. set programatically via a webkit API.
  45358. * loader/FrameLoaderClient.cpp:
  45359. (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
  45360. * loader/FrameLoaderClient.h:
  45361. * page/FrameView.cpp:
  45362. (WebCore::FrameView::initScrollbars):
  45363. (WebCore::FrameView::updateDefaultScrollbarState):
  45364. * page/FrameView.h:
  45365. 2009-01-05 Darin Adler <darin@apple.com>
  45366. Reviewed by Dan Bernstein.
  45367. Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
  45368. https://bugs.webkit.org/show_bug.cgi?id=23109
  45369. Test: fast/text/find-backwards.html
  45370. * editing/TextIterator.cpp:
  45371. (WebCore::SearchBuffer::append): Fix incorrect size passed to memcpy.
  45372. (WebCore::SearchBuffer::search): Handle case where we have an empty buffer but
  45373. we're at a break; must not try to search because ICU will give us an error.
  45374. Fix incorrect size passed to memcpy and memmove.
  45375. (WebCore::findPlainText): Fix case where we found a match and need to search
  45376. again because we want to find the last match. We need to try again without
  45377. adding any more text or handling the break before moving on.
  45378. 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
  45379. Fix the Qt build
  45380. * bridge/runtime_object.cpp:
  45381. (JSC::RuntimeObjectImp::put):
  45382. 2009-01-05 Alexey Proskuryakov <ap@webkit.org>
  45383. Reviewed by Sam Weinig.
  45384. Fix platforms that don't have Workers enabled.
  45385. * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Create ThreadGlobalData in
  45386. two stages, so that EventNames constructor can access the just-created atomic string table.
  45387. This matches what happens in ThreadSpecific case.
  45388. 2009-01-05 Alexey Proskuryakov <ap@webkit.org>
  45389. Suggested by Dave Levin.
  45390. Mac release build fix.
  45391. * WebCore.base.exp: Remove ThreadGlobalData::eventNames(), which is now inline.
  45392. 2009-01-05 Darin Adler <darin@apple.com>
  45393. * dom/Document.cpp: Fix build. Oops again.
  45394. 2009-01-05 Darin Adler <darin@apple.com>
  45395. Reviewed by Anders Carlsson.
  45396. Fix hang whenever following an anchor.
  45397. * dom/Document.cpp:
  45398. (WebCore::Document::findAnchor): Oops!
  45399. 2009-01-05 Alexey Proskuryakov <ap@webkit.org>
  45400. Reviewed by Darin Adler.
  45401. https://bugs.webkit.org/show_bug.cgi?id=23073
  45402. <rdar://problem/6471129> Workers crash on Windows Release builds
  45403. * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData):
  45404. * platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::eventNames):
  45405. Now that ThreadSpecific sets up the pointer before invoking data constructor, we can
  45406. initialize EventNames right away.
  45407. 2009-01-05 Darin Adler <darin@apple.com>
  45408. Reviewed by Anders Carlsson.
  45409. Bug 23106: HTMLFormCollection::namedItem ignores caseSensitive argument
  45410. https://bugs.webkit.org/show_bug.cgi?id=23106
  45411. This led me to a bunch of dead code. It turns out that HTML collections
  45412. were carrying the case-insensitive code just so they could be used to
  45413. find anchors, something we can do more simply and efficiently without
  45414. creating a DOM HTMLCollection object.
  45415. No behavior change. Just adding a new function findAnchor function and
  45416. removing some dead code.
  45417. * dom/Document.cpp:
  45418. (WebCore::Document::findAnchor): Added.
  45419. * dom/Document.h: Ditto.
  45420. * html/HTMLAnchorElement.cpp:
  45421. (WebCore::HTMLAnchorElement::accessKey): Take and return AtomicString
  45422. references for better efficiency.
  45423. (WebCore::HTMLAnchorElement::setAccessKey): Ditto.
  45424. (WebCore::HTMLAnchorElement::charset): Ditto.
  45425. (WebCore::HTMLAnchorElement::setCharset): Ditto.
  45426. (WebCore::HTMLAnchorElement::coords): Ditto.
  45427. (WebCore::HTMLAnchorElement::setCoords): Ditto.
  45428. (WebCore::HTMLAnchorElement::setHref): Ditto.
  45429. (WebCore::HTMLAnchorElement::hreflang): Ditto.
  45430. (WebCore::HTMLAnchorElement::setHreflang): Ditto.
  45431. (WebCore::HTMLAnchorElement::name): Ditto.
  45432. (WebCore::HTMLAnchorElement::setName): Ditto.
  45433. (WebCore::HTMLAnchorElement::rel): Ditto.
  45434. (WebCore::HTMLAnchorElement::setRel): Ditto.
  45435. (WebCore::HTMLAnchorElement::rev): Ditto.
  45436. (WebCore::HTMLAnchorElement::setRev): Ditto.
  45437. (WebCore::HTMLAnchorElement::shape): Ditto.
  45438. (WebCore::HTMLAnchorElement::setShape): Ditto.
  45439. (WebCore::HTMLAnchorElement::setTarget): Ditto.
  45440. (WebCore::HTMLAnchorElement::type): Ditto.
  45441. (WebCore::HTMLAnchorElement::setType): Ditto.
  45442. * html/HTMLAnchorElement.h: Ditto.
  45443. * html/HTMLCollection.cpp:
  45444. (WebCore::HTMLCollection::checkForNameMatch): Changed argument to an
  45445. AtomicString and removed the caseSensitive boolean, since we're now always
  45446. case sensitive.
  45447. (WebCore::HTMLCollection::namedItem): Ditto.
  45448. (WebCore::HTMLCollection::nextNamedItem): Ditto.
  45449. * html/HTMLCollection.h: Ditto.
  45450. * html/HTMLFormCollection.cpp:
  45451. (WebCore::HTMLFormCollection::getNamedItem): Ditto.
  45452. (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
  45453. (WebCore::HTMLFormCollection::nextNamedItemInternal): Ditto.
  45454. (WebCore::HTMLFormCollection::namedItem): Ditto.
  45455. (WebCore::HTMLFormCollection::nextNamedItem): Ditto.
  45456. * html/HTMLFormCollection.h: Ditto.
  45457. * html/HTMLSelectElement.cpp:
  45458. (WebCore::HTMLSelectElement::namedItem): Ditto.
  45459. * html/HTMLSelectElement.h: Ditto.
  45460. * loader/FrameLoader.cpp:
  45461. (WebCore::FrameLoader::gotoAnchor): Use the new findAnchor function.
  45462. * page/AccessibilityRenderObject.cpp:
  45463. (WebCore::AccessibilityRenderObject::internalLinkElement): Ditto.
  45464. 2009-01-05 Darin Adler <darin@apple.com>
  45465. Reviewed by Anders Carlsson.
  45466. Bug 23104: minor mistakes in init functions for animation and transition events
  45467. https://bugs.webkit.org/show_bug.cgi?id=23104
  45468. Test: fast/events/init-events.html
  45469. Also fixed two StorageEvent problems the test case uncovered:
  45470. Made document.createEvent("StorageEvent") work.
  45471. Allow null values for StorageEvent.oldValue and StorageEvent.newValue.
  45472. * dom/Document.cpp:
  45473. (WebCore::Document::createEvent): Sorted alphabetically by the name of the event
  45474. class. Added StorageEvent.
  45475. * dom/UIEvent.idl: Fixed typo in a comment.
  45476. * dom/WebKitAnimationEvent.cpp:
  45477. (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
  45478. * dom/WebKitTransitionEvent.cpp:
  45479. (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.
  45480. * storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the
  45481. arguments to initStorageEvent so it can create events with null values for the
  45482. oldValue and newValue, just like the real storage events. Note that the properties
  45483. already had ConvertNullStringTo=Null, so this is just the other half of that.
  45484. 2009-01-05 Darin Adler <darin@apple.com>
  45485. Reviewed by Alexey Proskuryakov.
  45486. Bug 23102: turn on unused parameter warnings in WebCore
  45487. https://bugs.webkit.org/show_bug.cgi?id=23102
  45488. First step: Fix the simple cases where we can just remove an argument name.
  45489. Also made a few more things protected and private.
  45490. * many files
  45491. 2009-01-05 Alexey Proskuryakov <ap@webkit.org>
  45492. Reviewed by Darin Adler.
  45493. https://bugs.webkit.org/show_bug.cgi?id=23115
  45494. Create a version of ASSERT for use with otherwise unused variables
  45495. * loader/appcache/ApplicationCacheStorage.cpp:
  45496. (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.
  45497. 2009-01-05 Alexey Proskuryakov <ap@webkit.org>
  45498. Non-Mac build fix.
  45499. * loader/appcache/ApplicationCacheStorage.cpp: Include wtf/StringExtras.h for snprintf.
  45500. 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
  45501. Reviewed by George Staikos.
  45502. Remove unnecessary methods from EmptyFrameLoaderClient
  45503. * loader/EmptyClients.h:
  45504. 2009-01-05 Alexey Proskuryakov <ap@webkit.org>
  45505. Reviewed by Darin Adler.
  45506. https://bugs.webkit.org/show_bug.cgi?id=23077
  45507. Make application cache use SQLite built-in user_version
  45508. * loader/appcache/ApplicationCacheStorage.cpp:
  45509. (WebCore::ApplicationCacheStorage::verifySchemaVersion): Changed to track versions with
  45510. PRAGMA user_version.
  45511. * loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
  45512. Used the occasion to get rid of the hole in bitmask that was a leftover from opportunistic
  45513. cache entries.
  45514. 2009-01-04 David Smith <catfish.man@gmail.com>
  45515. Reviewed by Oliver Hunt.
  45516. https://bugs.webkit.org/show_bug.cgi?id=23084
  45517. Avoid redundant AtomicString conversions
  45518. * dom/Node.cpp:
  45519. (WebCore::Node::getElementsByTagName): Pass starAtom instead of "*"
  45520. (WebCore::Node::getElementsByTagNameNS): Take an AtomicString for the namespace URI
  45521. (WebCore::Node::isDefaultNamespace): Ditto
  45522. (WebCore::Node::lookupPrefix): Ditto
  45523. (WebCore::Node::lookupNamespacePrefix): Ditto
  45524. * dom/Node.h: Ditto
  45525. 2009-01-04 Darin Adler <darin@apple.com>
  45526. Reviewed by Oliver Hunt.
  45527. Bug 23105: canvas setFillColor function ignores alpha argument
  45528. https://bugs.webkit.org/show_bug.cgi?id=23105
  45529. Test: fast/canvas/set-colors.html
  45530. * html/CanvasRenderingContext2D.cpp:
  45531. (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead
  45532. of ignoring it and always passing 1.
  45533. * html/CanvasStyle.cpp:
  45534. (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments.
  45535. (WebCore::CanvasStyle::applyFillColor): Ditto.
  45536. 2009-01-04 Darin Adler <darin@apple.com>
  45537. Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors
  45538. https://bugs.webkit.org/show_bug.cgi?id=23086
  45539. * editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile
  45540. in the new search path if it's 0.
  45541. 2009-01-04 David Kilzer <ddkilzer@apple.com>
  45542. Don't install *.idl and *.in files as resources
  45543. Reviewed by Oliver Hunt.
  45544. Don't install these files as resources in the WebCore framework:
  45545. - WMLAttributeNames.in
  45546. - WMLTagNames.in
  45547. - WorkerContext.idl
  45548. - WorkerLocation.idl
  45549. - WorkerNavigator.idl
  45550. * WebCore.xcodeproj/project.pbxproj: Removed resources.
  45551. 2009-01-04 Simon Fraser <simon.fraser@apple.com>
  45552. Reviewed by Darin Adler
  45553. https://bugs.webkit.org/show_bug.cgi?id=23090
  45554. If an object gets a Layout hint, and the style change will result in
  45555. the creation of a RenderLayer, then we need to repaint the old position
  45556. of the object. This was done for transform, but we have to test opacity too.
  45557. Test: fast/repaint/create-layer-repaint.html
  45558. * rendering/RenderObject.cpp:
  45559. (WebCore::RenderObject::styleWillChange):
  45560. 2009-01-04 Darin Adler <darin@apple.com>
  45561. Reviewed by Dan Bernstein.
  45562. Bug 23103: Safari's auto-fill no longer works for <select> elements
  45563. https://bugs.webkit.org/show_bug.cgi?id=23103
  45564. rdar://problem/6472061
  45565. * bindings/objc/DOMHTML.mm:
  45566. (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
  45567. 2009-01-04 Adam Treat <adam.treat@torchmobile.com>
  45568. Reviewed by George Staikos.
  45569. Add fixedLayoutSize feature to ScrollView to allow for controlling the
  45570. layout beyond the constraint of the current viewports dynamic size
  45571. * css/MediaQueryEvaluator.cpp:
  45572. (WebCore::heightMediaFeatureEval):
  45573. (WebCore::widthMediaFeatureEval):
  45574. * dom/Element.cpp:
  45575. (WebCore::Element::clientWidth):
  45576. (WebCore::Element::clientHeight):
  45577. * loader/FrameLoaderClient.cpp:
  45578. (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
  45579. * loader/FrameLoaderClient.h:
  45580. * page/FrameView.cpp:
  45581. (WebCore::FrameView::layout):
  45582. * platform/ScrollView.cpp:
  45583. (WebCore::ScrollView::ScrollView):
  45584. (WebCore::ScrollView::layoutWidth):
  45585. (WebCore::ScrollView::layoutHeight):
  45586. (WebCore::ScrollView::fixedLayoutSize):
  45587. (WebCore::ScrollView::setFixedLayoutSize):
  45588. (WebCore::ScrollView::useFixedLayout):
  45589. (WebCore::ScrollView::setUseFixedLayout):
  45590. * platform/ScrollView.h:
  45591. * rendering/RenderView.cpp:
  45592. (WebCore::RenderView::viewHeight):
  45593. (WebCore::RenderView::viewWidth):
  45594. * rendering/RenderView.h:
  45595. 2009-01-03 Rob Buis <rwlbuis@gmail.com>
  45596. Reviewed by Darin.
  45597. https://bugs.webkit.org/show_bug.cgi?id=22660
  45598. SVG elements that are moved are nor fully invalidated/earsed
  45599. Mark the SVG root as needing a layout when its position changes.
  45600. Tests: svg/custom/circle-move-invalidation.svg
  45601. * rendering/RenderSVGRoot.cpp:
  45602. (WebCore::RenderSVGRoot::position):
  45603. * rendering/RenderSVGRoot.h:
  45604. 2009-01-03 Steve Falkenburg <sfalken@apple.com>
  45605. Build fix.
  45606. * loader/FrameLoader.h:
  45607. 2009-01-02 Cary Clark <caryclark@google.com>
  45608. Reviewed and landed by Darin Adler.
  45609. Bug 22963: write icons before reading them
  45610. https://bugs.webkit.org/show_bug.cgi?id=22963
  45611. Reverse the order in the icon database main thread loop to
  45612. write the pending icons to the database before trying
  45613. to read any requested icons. This ensures that a requested icon
  45614. has the correct data when read.
  45615. * loader/icon/IconDatabase.cpp:
  45616. (WebCore::IconDatabase::syncThreadMainLoop):
  45617. 2009-01-02 Darin Adler <darin@apple.com>
  45618. * loader/FrameLoader.cpp:
  45619. (WebCore::FrameLoader::loadItem): One small thing I forgot in my last check-in.
  45620. This cuts down on the number of hash table operations during loading.
  45621. 2009-01-02 Dmitry Titov <dimich@chromium.org>
  45622. Reviewed and landed by Darin Adler.
  45623. https://bugs.webkit.org/show_bug.cgi?id=23025
  45624. DOMTimer lifetime cleanup: timeoutMap methods on Document now do not delete the timer.
  45625. Instead, all 3 places that delete timers do it directly calling 'delete' and then timer's dtor removes the ID from the timeoutMap.
  45626. Note that in case the context is destroyed and timers are deleted at once, the check in ~DOMTimer() prevents
  45627. unnecessary HashMap remove in case the Document is being destroyed.
  45628. * bindings/js/DOMTimer.cpp:
  45629. (WebCore::DOMTimer::~DOMTimer): removes the id from the timeoutMap.
  45630. (WebCore::DOMTimer::install):
  45631. (WebCore::DOMTimer::removeById): simply uses 'delete this'.
  45632. (WebCore::DOMTimer::fired): same.
  45633. (WebCore::DOMTimer::contextDestroyed): same.
  45634. * dom/Document.cpp:
  45635. (WebCore::Document::removeTimeout): now it only removes the id from the map, does not delete the timer.
  45636. 2009-01-02 Darin Adler <darin@apple.com>
  45637. Reviewed by Sam Weinig.
  45638. Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
  45639. inside its web view when resizing its window
  45640. https://bugs.webkit.org/show_bug.cgi?id=23072
  45641. rdar://problem/6368028
  45642. The first attempt at fixing this did not work.
  45643. This time I was able to reproduce the bug and test the fix.
  45644. Bug 11212: REGRESSION: Activity window doesn't always list all files until refresh
  45645. https://bugs.webkit.org/show_bug.cgi?id=11212
  45646. rdar://problem/4959702
  45647. I had to fix this second bug because otherwise the WebKit code to trigger the first
  45648. fix didn't run.
  45649. Also fixes memory use that kept growing as we maintained a set of all URLs loaded in
  45650. a particular frame. Bad idea! It's bad enough that we do it for each document, but
  45651. the old version kept the set around forever as you moved from one document to the next.
  45652. * html/HTMLFrameElementBase.cpp:
  45653. (WebCore::HTMLFrameElementBase::parseMappedAttribute): Change this so that we allow
  45654. turning off scrolling when the quirk is enabled. We just don't allow turning it on.
  45655. This fixes one of the two problems with the initial patch; the other fix is in WebKit.
  45656. * loader/DocumentLoader.h: Moved didTellClientAboutLoad and haveToldClientAboutLoad
  45657. here from FrameLoader. The old way meant that a given frame would forever remember
  45658. the URL of any resources loaded in that frame and never send any "loaded from cache"
  45659. client calls about those URLs.
  45660. * loader/FrameLoader.cpp:
  45661. (WebCore::FrameLoader::loadResourceSynchronously): Removed call to didTellCientAboutLoad.
  45662. This is now handled by dispatchWillSendRequest, which is safer since that's the actual
  45663. function that tells the client about the load.
  45664. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Changed calls to
  45665. haveToldClientAboutLoad and didTellClientAboutLoad to call the document loader.
  45666. Also removed the call in the case where we don't load from the cache, since
  45667. dispatchWillSendRequest now takes care of it.
  45668. (WebCore::FrameLoader::dispatchWillSendRequest): Put calls to didTellClientAboutLoad
  45669. here. Call it both on the URL we pass in and the URL the client returns; we won't
  45670. tell the client about either if it's loaded from the memory cache.
  45671. * loader/FrameLoader.h: Removed didTellClientAboutLoad, haveToldClientAboutLoad, and
  45672. m_urlsClientKnowsAbout.
  45673. * loader/SubresourceLoader.cpp: Removed unneeded load function that called
  45674. didTellClientAboutLoad. That's now taken care of in dispatchWillSendRequest.
  45675. * loader/SubresourceLoader.h: Removed load function. Also made all members private
  45676. except for create and clearClient.
  45677. 2009-01-02 Simon Fraser <simon.fraser@apple.com>
  45678. Reviewed by Darin Adler
  45679. https://bugs.webkit.org/show_bug.cgi?id=23082
  45680. Fix GIF animation by ensuring that the signature of
  45681. startAnimation() in the base class matches the method in BitmapImage.
  45682. Test: fast/backgrounds/animated-gif-as-background.html
  45683. * platform/graphics/Image.h:
  45684. (WebCore::Image::startAnimation):
  45685. 2009-01-02 David Smith <catfish.man@gmail.com>
  45686. Reviewed by Darin Adler.
  45687. https://bugs.webkit.org/show_bug.cgi?id=22699
  45688. Enable NodeList caching for getElementsByTagName
  45689. test: fast/dom/getelementsbytagnamens-mixed-namespaces.html
  45690. * dom/Document.cpp:
  45691. (WebCore::FormElementKeyHash::hash): Use WTF::stringHashingStartValue
  45692. * dom/Node.cpp:
  45693. (WebCore::Node::getElementsByTagNameNS): Ensure rare data and add a node list cache
  45694. (WebCore::NodeListsNodeData::invalidateCaches): Invalidate the tag name node list cache as well as the others
  45695. (WebCore::NodeListsNodeData::isEmpty): Check the tag name node list cache as well as the others
  45696. * dom/NodeRareData.h: Add m_tagNodeListCaches
  45697. * dom/QualifiedName.cpp:
  45698. * dom/QualifiedName.h: Move QNameHash to the header, make it work on QualifiedNames, and rename to QualifiedNameHash
  45699. * dom/StyledElement.cpp:
  45700. (WebCore::MappedAttributeHash::hash): Use WTF::stringHashingStartValue
  45701. * dom/TagNodeList.cpp:
  45702. (WebCore::TagNodeList::TagNodeList): Add a NodeList cache argument
  45703. * dom/TagNodeList.h:
  45704. (WebCore::TagNodeList::create): Add a NodeList cache argument
  45705. * platform/text/StringHash.h:
  45706. (WebCore::CaseFoldingHash::hash): Use WTF::stringHashingStartValue
  45707. * platform/text/TextEncodingRegistry.cpp:
  45708. (WebCore::TextEncodingNameHash::hash): Use WTF::stringHashingStartValue
  45709. 2009-01-02 Eric Carlson <eric.carlson@apple.com>
  45710. Reviewed by Darin Adler
  45711. Fix for https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
  45712. Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
  45713. * rendering/RenderVideo.cpp:
  45714. (WebCore::RenderVideo::calcReplacedWidth): Multiply aspect ratio width by style()->effectiveZoom()
  45715. (WebCore::RenderVideo::calcReplacedHeight): Multiply aspect ratio height by style()->effectiveZoom()
  45716. 2009-01-02 David Kilzer <ddkilzer@apple.com>
  45717. BUILD FIX (r39552): Add mediaControls.css to other build files
  45718. * GNUmakefile.am:
  45719. * WebCore.pro:
  45720. * WebCore.vcproj/WebCore.vcproj:
  45721. 2009-01-02 David Kilzer <ddkilzer@apple.com>
  45722. Try to fix Wx build after r39427
  45723. * platform/graphics/wx/PathWx.cpp:
  45724. (WebCore::Path::strokeBoundingRect): Added stub.
  45725. 2009-01-02 Alexey Proskuryakov <ap@webkit.org>
  45726. Reviewed by Adele Peterson.
  45727. <rdar://problem/6471356> Failed assertion on quit
  45728. * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData):
  45729. Only assert that empty string are all removed on secondary threads.
  45730. 2009-01-02 David Kilzer <ddkilzer@apple.com>
  45731. Bug 23081: These files are no longer part of the KDE libraries
  45732. <https://bugs.webkit.org/show_bug.cgi?id=23081>
  45733. Reviewed by Darin Adler.
  45734. Removed "This file is part of the KDE libraries" comment from
  45735. source files. Added or updated Apple copyrights as well.
  45736. No tests since there are only changes to comments.
  45737. * bridge/testbindings.cpp:
  45738. * html/HTMLEntityNames.gperf:
  45739. * loader/Cache.h:
  45740. * loader/CachedCSSStyleSheet.h:
  45741. * loader/CachedResourceClient.h:
  45742. * loader/CachedResourceClientWalker.cpp:
  45743. * loader/CachedResourceClientWalker.h:
  45744. * loader/CachedScript.cpp:
  45745. * loader/CachedScript.h:
  45746. * loader/CachedXBLDocument.cpp:
  45747. * loader/CachedXBLDocument.h:
  45748. * loader/CachedXSLStyleSheet.cpp:
  45749. * loader/CachedXSLStyleSheet.h:
  45750. * rendering/GapRects.h:
  45751. * xml/XMLSerializer.cpp:
  45752. 2009-01-02 Simon Fraser <simon.fraser@apple.com>
  45753. Reviewed by Darin Adler
  45754. Use an OwnPtr for m_chromeClient.
  45755. * svg/graphics/SVGImage.cpp:
  45756. (WebCore::SVGImage::~SVGImage):
  45757. (WebCore::SVGImage::dataChanged):
  45758. * svg/graphics/SVGImage.h:
  45759. 2009-01-02 Simon Fraser <simon.fraser@apple.com>
  45760. Reviewed by Darin Adler
  45761. https://bugs.webkit.org/show_bug.cgi?id=22981
  45762. Repaints inside of an SVGImage were thrown on the floor,
  45763. which broke incremental painting due to loading, or SVG animation.
  45764. Fix this by assigning the SVGImage a ChromeClient subclass that passes
  45765. along repaints via a new method on ImageObserver, which also takes
  45766. a rect parameter for the changed rect, allowing incremental repaints.
  45767. Fix RenderImage::imageChanged to take advantage of this changedRect to
  45768. only repaint the changed parts of the image.
  45769. This also enables incremental painting for canvas-as-image, so
  45770. add tests for that too.
  45771. Tests: fast/backgrounds/animated-svg-as-background.html
  45772. fast/backgrounds/animated-svg-as-mask.html
  45773. fast/canvas/canvas-as-image-incremental-repaint.html
  45774. fast/canvas/canvas-as-image.html
  45775. fast/images/animated-svg-as-image.html
  45776. * css/CSSCanvasValue.cpp:
  45777. (WebCore::CSSCanvasValue::canvasChanged):
  45778. * loader/CachedImage.cpp:
  45779. (WebCore::CachedImage::notifyObservers):
  45780. (WebCore::CachedImage::data):
  45781. (WebCore::CachedImage::changedInRect):
  45782. * loader/CachedImage.h:
  45783. * loader/CachedResourceClient.h:
  45784. (WebCore::CachedResourceClient::imageChanged):
  45785. * platform/graphics/ImageObserver.h:
  45786. * rendering/RenderBox.cpp:
  45787. (WebCore::RenderBox::imageChanged):
  45788. * rendering/RenderBox.h:
  45789. * rendering/RenderImage.cpp:
  45790. (WebCore::RenderImage::imageChanged):
  45791. * rendering/RenderImage.h:
  45792. * rendering/RenderListMarker.cpp:
  45793. (WebCore::RenderListMarker::imageChanged):
  45794. * rendering/RenderListMarker.h:
  45795. * rendering/RenderObject.cpp:
  45796. (WebCore::RenderObject::imageChanged):
  45797. * rendering/RenderObject.h:
  45798. (WebCore::RenderObject::imageChanged):
  45799. * rendering/RenderSVGImage.cpp:
  45800. (WebCore::RenderSVGImage::imageChanged):
  45801. * rendering/RenderSVGImage.h:
  45802. * rendering/RenderScrollbarPart.cpp:
  45803. (WebCore::RenderScrollbarPart::imageChanged):
  45804. * rendering/RenderScrollbarPart.h:
  45805. * rendering/RenderTableCol.cpp:
  45806. (WebCore::RenderTableCol::imageChanged):
  45807. * rendering/RenderTableCol.h:
  45808. * rendering/RenderTableRow.cpp:
  45809. (WebCore::RenderTableRow::imageChanged):
  45810. * rendering/RenderTableRow.h:
  45811. * rendering/RenderTableSection.cpp:
  45812. (WebCore::RenderTableSection::imageChanged):
  45813. * rendering/RenderTableSection.h:
  45814. * svg/graphics/SVGImage.cpp:
  45815. (WebCore::SVGImageChromeClient::SVGImageChromeClient):
  45816. (WebCore::SVGImageChromeClient::image):
  45817. (WebCore::SVGImageChromeClient::chromeDestroyed):
  45818. (WebCore::SVGImageChromeClient::repaint):
  45819. (WebCore::SVGImage::SVGImage):
  45820. (WebCore::SVGImage::~SVGImage):
  45821. (WebCore::SVGImage::dataChanged):
  45822. * svg/graphics/SVGImage.h:
  45823. 2009-01-02 Eric Carlson <eric.carlson@apple.com>
  45824. Reviewed by Darin Adler
  45825. https://bugs.webkit.org/show_bug.cgi?id=23043
  45826. Pull media controls css out of html4.css into separate file. Don't generate
  45827. wml, svg, or media css globals unless the feature is enabled.
  45828. * DerivedSources.make:
  45829. Don't include css for unused features.
  45830. * WebCore.xcodeproj/project.pbxproj:
  45831. include mediaControls.css
  45832. * css/CSSStyleSelector.cpp:
  45833. (WebCore::CSSStyleSelector::styleForElement):
  45834. don't parse or add media css unless VIDEO feature is enabled and the target
  45835. element is video or audio
  45836. * css/html4.css:
  45837. moved media controls css to mediaControls.css
  45838. * css/mediaControls.css: Added.
  45839. 2009-01-02 Alexey Proskuryakov <ap@webkit.org>
  45840. Reviewed by Darin Adler.
  45841. https://bugs.webkit.org/show_bug.cgi?id=23022
  45842. Fix multiple issues with appcache online whitelist handling
  45843. Test: http/tests/appcache/online-whitelist.html
  45844. * loader/appcache/ApplicationCache.cpp:
  45845. (WebCore::ApplicationCache::isURLInOnlineWhitelist): Test whitelist entries as prefixes,
  45846. making it possible to use them for CGI invocation (as required by HTML5).
  45847. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
  45848. Re-ordered checks, so that resources that are cached, but are also listed in online whitelist
  45849. are loaded from the cache. This is required by HTML5, although Firefox doesn't match.
  45850. * loader/appcache/ManifestParser.cpp:
  45851. (WebCore::parseManifest):
  45852. * loader/appcache/ManifestParser.h:
  45853. * loader/appcache/ApplicationCache.h:
  45854. (WebCore::ApplicationCache::onlineWhitelist):
  45855. * loader/appcache/ApplicationCacheStorage.cpp:
  45856. (WebCore::ApplicationCacheStorage::store):
  45857. (WebCore::ApplicationCacheStorage::loadCache):
  45858. Changed online whitelist to be a vector of URLs, which is better suited for the new algorithm.
  45859. 2009-01-02 Darin Adler <darin@apple.com>
  45860. Reviewed by Oliver Hunt.
  45861. Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
  45862. https://bugs.webkit.org/show_bug.cgi?id=23072
  45863. rdar://problem/6368028
  45864. * WebCore.base.exp: Updated.
  45865. * WebCore.xcodeproj/project.pbxproj: Mark HTMLHeadElement.h Private so it can be used in WebKit.
  45866. * dom/Document.cpp:
  45867. (WebCore::Document::Document): Initialize m_frameElementsShouldIgnoreScrolling to false.
  45868. * dom/Document.h: Added setFrameElementsShouldIgnoreScrolling, frameElementsShouldIgnoreScrolling,
  45869. and m_frameElementsShouldIgnoreScrolling.
  45870. * html/HTMLFrameElementBase.cpp:
  45871. (WebCore::HTMLFrameElementBase::parseMappedAttribute): Don't allow changes to the scrolling attribute
  45872. to affect the scrolling mode if frameElementsShouldIgnoreScrolling() returns true. This is only
  45873. triggered on Mac OS X when running the Dictionary application.
  45874. 2009-01-02 Alexey Proskuryakov <ap@webkit.org>
  45875. Reviewed by Darin Adler.
  45876. https://bugs.webkit.org/show_bug.cgi?id=23036
  45877. <rdar://problem/6451666> Implement AppCache fallback entries (23036)
  45878. Test: http/tests/appcache/fallback.html
  45879. * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use fallback
  45880. entries if normal loading fails.
  45881. * loader/DocumentLoader.cpp:
  45882. (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Do not prevent normal
  45883. loading for resources that match fallback namespaces - they are only loaded from the cache
  45884. if that fails.
  45885. (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Get a fallback entry for
  45886. resource from associated appcache, or from passed in one, if any.
  45887. (WebCore::DocumentLoader::scheduleLoadFallbackResourceFromApplicationCache): If a fallback
  45888. entry for resourse exists, add it to pending substitute loads.
  45889. * loader/DocumentLoader.h: Added new functions for loading fallback data for resources.
  45890. * loader/ResourceLoader.h:
  45891. * loader/ResourceLoader.cpp:
  45892. (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache): This function
  45893. is called when normal loading fails (which includes network failures, 4xx and 5xx responses,
  45894. and cross-origin redirects) to load appcache fallback data instead. It can use either the
  45895. cache that is associated with the browsing context, or a custom one if association is yet
  45896. to take place.
  45897. (WebCore::ResourceLoader::willSendRequest): Try using fallback data.
  45898. (WebCore::ResourceLoader::didReceiveResponse): Ditto.
  45899. (WebCore::ResourceLoader::didFail): Ditto.
  45900. * loader/MainResourceLoader.cpp:
  45901. (WebCore::MainResourceLoader::didReceiveResponse): Locate an appropriate cache and load
  45902. fallback data from it if loading fails. The browsing context may still be associated with
  45903. its previous document here, so the cache to load from must be passed explicitly.
  45904. (WebCore::MainResourceLoader::didFail): Ditto.
  45905. (WebCore::MainResourceLoader::load): Remove unnecessary check and FIXME.
  45906. * loader/appcache/ApplicationCache.cpp:
  45907. (WebCore::ApplicationCache::setFallbackURLs):
  45908. (WebCore::ApplicationCache::urlMatchesFallbackNamespace):
  45909. * loader/appcache/ApplicationCache.h:
  45910. (WebCore::ApplicationCache::fallbackURLs):
  45911. * loader/appcache/ApplicationCacheStorage.cpp:
  45912. (WebCore::ApplicationCacheStorage::cacheGroupForURL):
  45913. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
  45914. (WebCore::ApplicationCacheStorage::store):
  45915. (WebCore::ApplicationCacheStorage::loadCache):
  45916. (WebCore::ApplicationCacheStorage::storeCopyOfCache):
  45917. * loader/appcache/ApplicationCacheStorage.h:
  45918. * loader/appcache/ApplicationCacheGroup.cpp:
  45919. (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
  45920. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
  45921. * loader/appcache/ApplicationCacheGroup.h:
  45922. Implement fallback map saving and loading, pass it to the cache.
  45923. * loader/appcache/ManifestParser.h: Use a correct data structure for fallback map - keys
  45924. are matched by prefix, so HAshMap cannot be used.
  45925. * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Fix bugs in fallback section
  45926. parsing.
  45927. 2009-01-01 Oliver Hunt <oliver@apple.com>
  45928. Reviewed by Dan Bernstein.
  45929. <rdar://problem/6450530> WebCore::FontPlatformData should not leak
  45930. Whoops, previous patch should also have fixed the font referencing in
  45931. the constructor.
  45932. * WebCore.xcodeproj/project.pbxproj:
  45933. * platform/graphics/mac/FontPlatformDataMac.mm:
  45934. (WebCore::FontPlatformData::FontPlatformData):
  45935. 2009-01-01 Oliver Hunt <oliver@apple.com>
  45936. Reviewed by Dan Bernstein.
  45937. <rdar://problem/6450530> WebCore::FontPlatformData should not leak
  45938. Make sure we only adopt the new font, rather than re-referencing (and so leaking).
  45939. * platform/graphics/mac/FontPlatformDataMac.mm:
  45940. (WebCore::FontPlatformData::setFont):
  45941. 2009-01-01 Darin Adler <darin@apple.com>
  45942. Reviewed by Dan Bernstein.
  45943. Bug 23071: REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search)
  45944. https://bugs.webkit.org/show_bug.cgi?id=23071
  45945. Also fix some things that Dan suggested during review of the ICU search patch that I forgot
  45946. the first time around.
  45947. * editing/TextIterator.cpp: Use ICU search on all platforms that use ICU, now that
  45948. we've double checked it works everywhere, removing HAVE_ICU_SEARCH entirely.
  45949. Removed unused m_atBreak data member from the non-ICU code path.
  45950. (WebCore::TextIterator::TextIterator): Move null check up.
  45951. (WebCore::TextIterator::handleTextBox): Fix mistake that made the iterator include
  45952. collapsed whitespace. This was left over from an earlier version of the patch.
  45953. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
  45954. Move null check up.
  45955. 2009-01-01 Simon Fraser <simon.fraser@apple.com>
  45956. Reviewed by Darin Adler, Oliver Hunt
  45957. https://bugs.webkit.org/show_bug.cgi?id=23065
  45958. Enable incremental painting of canvas. This turns incremental painting
  45959. back on, and fixes issues with stroke width and miters, calling willDraw()
  45960. for strokeText and fillText, and taking shadows into account.
  45961. Test: fast/canvas/canvas-incremental-repaint.html
  45962. * html/CanvasRenderingContext2D.cpp:
  45963. (WebCore::CanvasStrokeStyleApplier::CanvasStrokeStyleApplier):
  45964. (WebCore::CanvasStrokeStyleApplier::strokeStyle):
  45965. (WebCore::CanvasRenderingContext2D::stroke):
  45966. (WebCore::CanvasRenderingContext2D::willDraw):
  45967. (WebCore::CanvasRenderingContext2D::putImageData):
  45968. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  45969. * html/CanvasRenderingContext2D.h:
  45970. * html/HTMLCanvasElement.cpp:
  45971. (WebCore::HTMLCanvasElement::willDraw):
  45972. * platform/graphics/FloatRect.h:
  45973. (WebCore::mapRect): new method to map a rect contained
  45974. in one rect to an equivalent rect inside another rect.
  45975. 2008-12-29 Konstantin Käfer <kkaefer@gmail.com>
  45976. Reviewed by Tim Hatcher.
  45977. Fix for https://bugs.webkit.org/show_bug.cgi?id=17229
  45978. <rdar://problem/5732829> Inspector should show properties of all JS objects in Console
  45979. Prints objects not as plain text but makes them expandable so that
  45980. they can be inspected.
  45981. * inspector/front-end/Console.js:
  45982. (): added a parameter "inline" to the WebInspector.Console._format function which indicates
  45983. whether the object is printed in the context of another string (with console.log()) or
  45984. as sole element.
  45985. (.): objects and DOM nodes are now printed in an expandable form when they are printed alone
  45986. (i.e. not in the context of a console.log() string) so that they can be inspected.
  45987. * inspector/front-end/PropertiesSection.js:
  45988. (WebInspector.PropertiesSection.prototype.set title): Allow DOM Nodes as title instead of strings
  45989. in that case, the Node is inserted into the title instead of the string value of the passed
  45990. object. This is used for displaying linkified titles, for example when inspecting DOM nodes,
  45991. the syntax highlighted HTML representation is shown instead of the plain source code.
  45992. * inspector/front-end/inspector.css: correct the offsetParent for the expandable object inspector.
  45993. 2009-01-01 Darin Adler <darin@apple.com>
  45994. Reviewed by Dan Bernstein.
  45995. Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences
  45996. https://bugs.webkit.org/show_bug.cgi?id=23051
  45997. rdar://problem/3574497
  45998. Test: editing/execCommand/findString-diacriticals.html
  45999. * editing/TextIterator.cpp: Changed the CircularSearchBuffer class to have a new
  46000. name, since it doesn't always use a circular buffer any more. Changed the interface
  46001. so it can work well in the new chunky comparison mode for ICU search, and also
  46002. added private data members for both the ICU-search and non-ICU-search code paths.
  46003. (WebCore::TextIterator::TextIterator): Use the versions of the Range functions
  46004. that don't take an exception code.
  46005. (WebCore::TextIterator::handleTextBox): Added a special case to handle the position
  46006. of a collapsed-away space better. This is not needed for search mechanism, but was
  46007. helpful in an earlier version of this patch, and is still an improvement.
  46008. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Use the
  46009. versions of the Range functions that don't take an exception code.
  46010. (WebCore::CharacterIterator::range): Ditto.
  46011. (WebCore::characterSubrange): Added. Helper function used in both places below where
  46012. we want to convert a range and character offsets into a subrange.
  46013. (WebCore::WordAwareIterator::advance): Use the versions of the Range functions that
  46014. don't take an exception code.
  46015. (WebCore::createSearcher): Added.
  46016. (WebCore::searcher): Added.
  46017. (WebCore::lockSearcher): Added.
  46018. (WebCore::unlockSearcher): Added.
  46019. (WebCore::SearchBuffer::SearchBuffer): Added.
  46020. (WebCore::SearchBuffer::~SearchBuffer): Added.
  46021. (WebCore::SearchBuffer::append): Added.
  46022. (WebCore::SearchBuffer::atBreak): Added.
  46023. (WebCore::SearchBuffer::reachedBreak): Added.
  46024. (WebCore::SearchBuffer::search): Added.
  46025. (WebCore::SearchBuffer::length): Added.
  46026. (WebCore::TextIterator::subrange): Changed to call the characterSubrange
  46027. function above.
  46028. (WebCore::TextIterator::rangeFromLocationAndLength): Use the versions of the
  46029. Range functions that don't take an exception code. Also tweak some other details
  46030. of the code.
  46031. (WebCore::isAllCollapsibleWhitespace): Added.
  46032. (WebCore::collapsedToBoundary): Added.
  46033. (WebCore::findPlainText): Rewrote to use new interface and streamline the
  46034. logic a bit.
  46035. Add the relevant files in the icu directory. As icu/README says, the "icu"
  46036. directory is really just for Mac OS X, where we have the ICU library but not
  46037. the headers installed. It should be moved inside platform/mac at some point
  46038. to make this more clear (and the copy in JavaScriptCore should be moved
  46039. somewhere similar for the same reason).
  46040. * icu/unicode/ucoleitr.h: Added.
  46041. * icu/unicode/usearch.h: Added.
  46042. 2009-01-01 Oliver Hunt <oliver@apple.com>
  46043. Reviewed by Cameron Zwarich.
  46044. CrashTracer: [REGRESSION] 1090 crashes in Safari at com.apple.JavaScriptCore: KJS::JSGlobalObject::stopTimeoutCheck + 0
  46045. <rdar://problem/5821130>
  46046. This was caused by a plugin instance calling into JS code that removed the plugin
  46047. object. This fix is to cache the global object locally in a ProtectedPtr so we don't
  46048. need to rely on the continued existence of the plugin instance.
  46049. * bridge/NP_jsobject.cpp:
  46050. (_NPN_InvokeDefault):
  46051. (_NPN_Invoke):
  46052. (_NPN_Evaluate):
  46053. (_NPN_Construct):
  46054. 2008-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  46055. Reviewed by Holger Freyther.
  46056. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22964
  46057. MinGW build failure.
  46058. * platform/graphics/qt/SimpleFontDataQt.cpp:
  46059. (WebCore::SimpleFontData::containsCharacters):
  46060. 2008-12-31 Alexander V. Butenko <alex@digiqube.com>
  46061. Reviewed by Holger Freyther.
  46062. https://bugs.webkit.org/show_bug.cgi?id=22750
  46063. [gtk] webkit up to r39121 crash on image urls like
  46064. http:///sitename.com
  46065. * platform/network/soup/ResourceHandleSoup.cpp:
  46066. (WebCore::ResourceHandle::start):
  46067. 2008-12-31 Hiroyuki Ikezoe <poincare@ikezoe.net>
  46068. Reviewed by Holger Freyther.
  46069. https://bugs.webkit.org/show_bug.cgi?id=18310
  46070. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  46071. (WebCore::SimpleFontData::determinePitch): Do not invoke
  46072. isFixedPitch() when the font is a custom font.
  46073. 2008-12-31 Oliver Hunt <oliver@apple.com>
  46074. Reviewed by Cameron Zwarich.
  46075. More work on Bug 3781: Animation via canvas could be faster
  46076. <https://bugs.webkit.org/show_bug.cgi?id=3781>
  46077. Make use of the fast path parsing of color strings that Color
  46078. uses. This improves performance of '#rgb', '#rrggbb', etc and
  46079. named (eg. 'green') colors.
  46080. Improves frame rate of test by around 40%
  46081. * html/CanvasStyle.cpp:
  46082. (WebCore::CanvasStyle::applyStrokeColor):
  46083. (WebCore::CanvasStyle::applyFillColor):
  46084. 2008-12-30 Simon Fraser <simon.fraser@apple.com>
  46085. Reviewed by Darin Adler
  46086. https://bugs.webkit.org/show_bug.cgi?id=23042
  46087. Rather than doing a repaint() inside of computeAbsoluteRepaintRect()
  46088. when there is a reflection, compute the location of the rect inside
  46089. the reflection and take the union of the unreflected and reflected rects.
  46090. Test: fast/repaint/reflection-redraw.html
  46091. * rendering/RenderBox.cpp:
  46092. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  46093. * rendering/RenderObject.cpp:
  46094. (WebCore::RenderObject::reflectedRect):
  46095. * rendering/RenderObject.h:
  46096. 2008-12-30 Dan Bernstein <mitz@apple.com>
  46097. Reviewed by Adele Peterson.
  46098. - fix <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
  46099. Test: fast/forms/placeholder-non-textfield.html
  46100. * html/HTMLInputElement.cpp:
  46101. (WebCore::HTMLInputElement::parseMappedAttribute): Only call
  46102. updatePlaceholderVisibility() when the placeholder attribute changes if
  46103. the element is a text field.
  46104. 2008-12-30 Oliver Hunt <oliver@apple.com>
  46105. Reviewed by Antti Koivisto.
  46106. First step of Bug 3781: Animation via canvas could be faster
  46107. Amortise the cost of calling repaint by coalescing repaint rects
  46108. while the canvas is drawn to. In a later step we'll stop calling
  46109. repaint() directly, and instead have all dirty canvases repaint
  46110. at the end of JS execution.
  46111. * html/HTMLCanvasElement.cpp:
  46112. (WebCore::HTMLCanvasElement::willDraw):
  46113. (WebCore::HTMLCanvasElement::paint):
  46114. * html/HTMLCanvasElement.h:
  46115. 2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  46116. Reviewed by Antti Koivisto.
  46117. Bug 22931: Using the inspector with purgeable resources leads to assertion failures
  46118. <https://bugs.webkit.org/show_bug.cgi?id=22931>
  46119. Change InspectorResource::sourceString() so that it doesn't attempt to
  46120. unsafely get the data of a purgeable CachedResource.
  46121. * inspector/InspectorController.cpp:
  46122. (WebCore::InspectorResource::sourceString): Attempt to make a purgeable
  46123. resource unpurgeable, and if this not possible, return an empty string.
  46124. * loader/CachedResource.h: Make InspectorResource a friend of CachedResource.
  46125. 2008-12-29 Alexey Proskuryakov <ap@webkit.org>
  46126. Reviewed by Sam Weinig.
  46127. https://bugs.webkit.org/show_bug.cgi?id=23023
  46128. Remove incomplete support for opportunistic appcache entries
  46129. No change in behavior, thus no test.
  46130. * loader/appcache/ApplicationCacheResource.h:
  46131. (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema
  46132. version changes.
  46133. * loader/DocumentLoader.cpp:
  46134. (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
  46135. * loader/appcache/ApplicationCacheGroup.cpp:
  46136. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
  46137. * loader/appcache/ApplicationCacheResource.cpp:
  46138. (WebCore::ApplicationCacheResource::dumpType):
  46139. 2008-12-29 Dirk Schulze <krit@webkit.org>
  46140. Reviewed by Oliver Hunt.
  46141. Add arcTo support for Cairo. This is needed by Canvas.
  46142. Cairo has no native support for arcTo. We have to make our
  46143. own implementation.
  46144. [Canvas] Cairo needs arcTo
  46145. https://bugs.webkit.org/show_bug.cgi?id=23003
  46146. * platform/graphics/cairo/PathCairo.cpp:
  46147. (WebCore::Path::addArcTo):
  46148. 2008-12-29 Oliver Hunt <oliver@apple.com>
  46149. Reviewed by Cameron Zwarich.
  46150. Bug 23030: Cannot setTransform with a non-invertible ctm
  46151. Removed a series of unnecessary and incorrect checks for an invertible
  46152. transform.
  46153. Test: fast/canvas/canvas-set-properties-with-non-invertible-ctm.html
  46154. * html/CanvasRenderingContext2D.cpp:
  46155. (WebCore::CanvasRenderingContext2D::setStrokeStyle):
  46156. (WebCore::CanvasRenderingContext2D::setFillStyle):
  46157. These properties are not effected by the current CTM, so there
  46158. is no need to prevent them from being assigned.
  46159. (WebCore::CanvasRenderingContext2D::setTransform):
  46160. The whole point of tracking whether the current CTM was expected to be
  46161. non-invertible was to allow setTransform to be used when the CTM had become
  46162. non-invertible.
  46163. (WebCore::CanvasRenderingContext2D::beginPath):
  46164. (WebCore::CanvasRenderingContext2D::closePath):
  46165. beginPath and closePath change the state of the path, but not any of
  46166. its coordinates so there is no need prevent them from being called.
  46167. 2008-12-29 Josh Roesslein <jroesslein@gmail.com>
  46168. Reviewed by Oliver Hunt.
  46169. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22968
  46170. Context menu rendering error when full page zoomed
  46171. * page/ContextMenuController.cpp:
  46172. (WebCore::ContextMenuController::handleContextMenuEvent):
  46173. 2008-12-29 Sam Weinig <sam@webkit.org>
  46174. Reviewed by Mark Rowe.
  46175. Add some basic memory statistic logging for Node.
  46176. * dom/Node.cpp:
  46177. (WebCore::Node::dumpStatistics):
  46178. (WebCore::Node::Node):
  46179. (WebCore::Node::~Node):
  46180. (WebCore::Node::setDocument):
  46181. * dom/Node.h:
  46182. 2008-12-29 Sam Weinig <sam@webkit.org>
  46183. Reviewed by Anders Carlsson.
  46184. Remove one use of DeprecatedPtrList.
  46185. * css/CSSRuleList.cpp:
  46186. (WebCore::CSSRuleList::~CSSRuleList):
  46187. (WebCore::CSSRuleList::length):
  46188. (WebCore::CSSRuleList::item):
  46189. (WebCore::CSSRuleList::deleteRule):
  46190. (WebCore::CSSRuleList::append):
  46191. (WebCore::CSSRuleList::insertRule):
  46192. * css/CSSRuleList.h: Change m_lstCSSRules from using DeprecatedPtrList to a Vector.
  46193. I measured no performance change and was comforted by the fact that we use a Vector
  46194. for StyleList, which serves the exact same purpose.
  46195. 2008-12-29 Adele Peterson <adele@apple.com>
  46196. Reviewed by Brady Eidson.
  46197. Fix for https://bugs.webkit.org/show_bug.cgi?id=21797
  46198. <rdar://problem/6310682> REGRESSION: Crash in CFHTTPCookieStorageCopy beneath WebCore::cookies() when
  46199. running fast/dom/document-attribute-js-null.html and http/tests/security/cookies/create-document.html
  46200. Return early if the document is trying to get or set a cookie with an empty cookie url.
  46201. * dom/Document.cpp:
  46202. (WebCore::Document::cookie):
  46203. (WebCore::Document::setCookie):
  46204. 2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  46205. Reviewed by Sam Weinig.
  46206. Bug 23016: JavaScriptDebugServer::recompileAllJSFunctions() should not execute JS while reparsing all functions
  46207. <https://bugs.webkit.org/show_bug.cgi?id=23016>
  46208. <rdar://problem/6425077>
  46209. JavaScriptDebugServer::recompileAllJSFunctions() calls sourceParsed() while
  46210. reparsing all JS functions, which will execute JS in the inspector. Depending
  46211. on the order in which functions are recompiled, a function could have a new
  46212. body but other functions that have not been recompiled could have an optimized
  46213. (in the sense of inline caching) call to it, bypassing the check of whether or
  46214. not there is generated bytecode. This leads to a crash caused by accessing
  46215. indices off of a null pointer.
  46216. To fix the problem, simply delay calling sourceParsed() until after all functions
  46217. have been reparsed. The crash isn't 100% reproducible, but on the one test case
  46218. I have, this makes it impossible to reproduce after a large number of attempts,
  46219. when it used to happen every few attempts.
  46220. * inspector/JavaScriptDebugServer.cpp:
  46221. (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
  46222. 2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46223. Rubber-stamped by Antti Koivisto.
  46224. Oops, remove some last minute ASSERTS that are obviously wrong.
  46225. * rendering/RenderTextControlMultiLine.cpp:
  46226. (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
  46227. * rendering/RenderTextControlSingleLine.cpp:
  46228. (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
  46229. 2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46230. Reviewed by Antti Koivisto.
  46231. Fixes: https://bugs.webkit.org/show_bug.cgi?id=23015
  46232. Don't rely on HTMLFormControlElement in RenderTextControl.
  46233. Introduce an abstract FormControlElement class, containing the
  46234. valueMatchesRenderer/setValueMatchesRenderer, the only HTMLFormControlElement
  46235. specific methods that RenderTextControl relies on.
  46236. This makes it possible for WML to reuse RenderTextControl.
  46237. RenderTextControlSingleLine still relies on HTMLInputElement,
  46238. this will change if WMLInputElement is introduced.
  46239. * GNUmakefile.am:
  46240. * WebCore.vcproj/WebCore.vcproj:
  46241. * WebCore.xcodeproj/project.pbxproj:
  46242. * dom/FormControlElement.h: Added.
  46243. (WebCore::FormControlElement::~FormControlElement):
  46244. (WebCore::FormControlElement::FormControlElement):
  46245. * html/HTMLFormControlElement.h:
  46246. (WebCore::HTMLFormControlElement::valueMatchesRenderer):
  46247. (WebCore::HTMLFormControlElement::setValueMatchesRenderer):
  46248. * html/HTMLTextAreaElement.cpp:
  46249. (WebCore::HTMLTextAreaElement::updateValue):
  46250. * rendering/RenderTextControl.cpp:
  46251. (WebCore::RenderTextControl::adjustInnerTextStyle):
  46252. (WebCore::RenderTextControl::updateFromElement):
  46253. (WebCore::RenderTextControl::setInnerTextValue):
  46254. (WebCore::RenderTextControl::selectionChanged):
  46255. (WebCore::RenderTextControl::formControlElement):
  46256. * rendering/RenderTextControl.h:
  46257. * rendering/RenderTextControlMultiLine.cpp:
  46258. (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
  46259. (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  46260. * rendering/RenderTextControlSingleLine.cpp:
  46261. (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
  46262. (WebCore::RenderTextControlSingleLine::updateFromElement):
  46263. 2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  46264. Reviewed by Darin Adler.
  46265. Bug 23006: Many Loader::Host member functions are not safe to use reentrantly
  46266. <https://bugs.webkit.org/show_bug.cgi?id=23006>
  46267. <rdar://problem/6216106>
  46268. Many Loader::Host member functions set m_processingResource to true when they
  46269. begin processing a resource and set it to false when they are done. Thanks to
  46270. JavaScript and the web inspector, almost anything can happen during the
  46271. processing of a resource, including these functions being called reentrantly,
  46272. which is unsafe due to this way of using m_processingResource.
  46273. This can theoretically cause a Loader::Host to be used after it is freed,
  46274. because when Loader::servedPendingRequests() is called, it will free Hosts
  46275. that have m_processingResource set to false.
  46276. To fix this, we replace m_processingResource with m_numResourcesProcessing,
  46277. which is incremented and decremented using a helper object, ProcessingResource.
  46278. There are no occurrences of crashes caused by this bug that are reproducible
  46279. by multiple people, but this fixes the problem of m_processingResource being
  46280. set to false while a Host is still alive.
  46281. * loader/loader.cpp:
  46282. (WebCore::Loader::Host::Host):
  46283. (WebCore::Loader::Host::didFinishLoading): Change to use ProcessingResource
  46284. instead of manually setting m_processingResource.
  46285. (WebCore::Loader::Host::didFail): Ditto.
  46286. (WebCore::Loader::Host::didReceiveData): Ditto.
  46287. * loader/loader.h:
  46288. (WebCore::Loader::Host::ProcessingResource::ProcessingResource): Added.
  46289. (WebCore::Loader::Host::ProcessingResource::~ProcessingResource): Added.
  46290. (WebCore::Loader::Host::processingResource): Change to use m_numResourcesProcessing
  46291. instead of just getting m_processingResource.
  46292. 2008-12-28 Alexey Proskuryakov <ap@webkit.org>
  46293. Reviewed by Darin Adler.
  46294. https://bugs.webkit.org/show_bug.cgi?id=23007
  46295. REGRESSION: Timer-related crash when closing Web Inspector
  46296. Test: fast/dom/Window/remove-timeout-crash.html
  46297. * bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::fired): Besides deleting the timer, make
  46298. sure to remove it from a Document map.
  46299. 2008-12-28 Alexey Proskuryakov <ap@webkit.org>
  46300. Reviewed by Anders Carlsson.
  46301. https://bugs.webkit.org/show_bug.cgi?id=23012
  46302. Bring application cache manifest parsing up to date
  46303. Test: http/tests/appcache/manifest-parsing.html
  46304. * loader/appcache/ManifestParser.cpp:
  46305. (WebCore::Mode): Added a constant for unknown sections, which are ignored when parsing. This
  46306. is necessary for future extensions.
  46307. (WebCore::parseManifest): Parse unknown sections correctly. Ignore trailing tokens in
  46308. supported sections.
  46309. 2008-12-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46310. Reviewed by Darin Adler.
  46311. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22996
  46312. RenderTextControl heavily depends on HTMLInputElement & HTMLTextAreaElement.
  46313. It handles multi & single line text control rendering in one class. Split up
  46314. in two new classes: RenderTextControlSingleLine & RenderTextControlMultiLine.
  46315. This has several benefits - code is more readable now, the memory usage
  46316. for RenderTextControlMultiLine is reduced, as all stuff related to search fields
  46317. lives in RenderTextControlSingleLine, and it's easier to introduce an
  46318. abstraction for input/textarea-like elements for other HTML flavours like WML.
  46319. * GNUmakefile.am:
  46320. * WebCore.order:
  46321. * WebCore.pro:
  46322. * WebCore.scons:
  46323. * WebCore.vcproj/WebCore.vcproj:
  46324. * WebCore.xcodeproj/project.pbxproj:
  46325. * WebCoreSources.bkl:
  46326. * html/HTMLInputElement.cpp:
  46327. (WebCore::HTMLInputElement::createRenderer):
  46328. (WebCore::HTMLInputElement::defaultEventHandler):
  46329. (WebCore::HTMLInputElement::updatePlaceholderVisibility):
  46330. (WebCore::HTMLInputElement::addSearchResult):
  46331. (WebCore::HTMLInputElement::onSearch):
  46332. * html/HTMLTextAreaElement.cpp:
  46333. (WebCore::HTMLTextAreaElement::createRenderer):
  46334. (WebCore::HTMLTextAreaElement::defaultEventHandler):
  46335. * rendering/RenderTextControl.cpp:
  46336. (WebCore::RenderTextControl::RenderTextControl):
  46337. (WebCore::RenderTextControl::~RenderTextControl):
  46338. (WebCore::RenderTextControl::styleDidChange):
  46339. (WebCore::RenderTextControl::adjustInnerTextStyle):
  46340. (WebCore::RenderTextControl::createSubtreeIfNeeded):
  46341. (WebCore::RenderTextControl::textBlockHeight):
  46342. (WebCore::RenderTextControl::textBlockWidth):
  46343. (WebCore::RenderTextControl::updateFromElement):
  46344. (WebCore::RenderTextControl::setInnerTextValue):
  46345. (WebCore::RenderTextControl::setSelectionRange):
  46346. (WebCore::RenderTextControl::visiblePositionForIndex):
  46347. (WebCore::RenderTextControl::indexForVisiblePosition):
  46348. (WebCore::RenderTextControl::subtreeHasChanged):
  46349. (WebCore::RenderTextControl::scrollbarThickness):
  46350. (WebCore::RenderTextControl::calcHeight):
  46351. (WebCore::RenderTextControl::hitInnerTextBlock):
  46352. (WebCore::RenderTextControl::forwardEvent):
  46353. (WebCore::RenderTextControl::calcPrefWidths):
  46354. (WebCore::RenderTextControl::selectionChanged):
  46355. (WebCore::RenderTextControl::innerTextElement):
  46356. * rendering/RenderTextControl.h:
  46357. (WebCore::RenderTextControl::hasControlClip):
  46358. (WebCore::RenderTextControl::canHaveChildren):
  46359. (WebCore::RenderTextControl::avoidsFloats):
  46360. (WebCore::RenderTextControl::isEdited):
  46361. (WebCore::RenderTextControl::setEdited):
  46362. * rendering/RenderTextControlMultiLine.cpp: Added.
  46363. (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
  46364. (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
  46365. (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  46366. (WebCore::RenderTextControlMultiLine::layout):
  46367. (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  46368. (WebCore::RenderTextControlMultiLine::forwardEvent):
  46369. (WebCore::RenderTextControlMultiLine::preferredContentWidth):
  46370. (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
  46371. (WebCore::RenderTextControlMultiLine::baselinePosition):
  46372. (WebCore::RenderTextControlMultiLine::updateFromElement):
  46373. (WebCore::RenderTextControlMultiLine::cacheSelection):
  46374. (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  46375. * rendering/RenderTextControlMultiLine.h: Added.
  46376. (WebCore::RenderTextControlMultiLine::isTextArea):
  46377. * rendering/RenderTextControlSingleLine.cpp: Added.
  46378. (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
  46379. (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
  46380. (WebCore::RenderTextControlSingleLine::placeholderShouldBeVisible):
  46381. (WebCore::RenderTextControlSingleLine::updatePlaceholderVisibility):
  46382. (WebCore::RenderTextControlSingleLine::addSearchResult):
  46383. (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
  46384. (WebCore::RenderTextControlSingleLine::showPopup):
  46385. (WebCore::RenderTextControlSingleLine::hidePopup):
  46386. (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  46387. (WebCore::RenderTextControlSingleLine::paint):
  46388. (WebCore::RenderTextControlSingleLine::layout):
  46389. (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  46390. (WebCore::RenderTextControlSingleLine::forwardEvent):
  46391. (WebCore::RenderTextControlSingleLine::styleDidChange):
  46392. (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
  46393. (WebCore::RenderTextControlSingleLine::textBlockWidth):
  46394. (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  46395. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  46396. (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
  46397. (WebCore::RenderTextControlSingleLine::updateFromElement):
  46398. (WebCore::RenderTextControlSingleLine::cacheSelection):
  46399. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  46400. (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
  46401. (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
  46402. (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
  46403. (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
  46404. (WebCore::RenderTextControlSingleLine::autosaveName):
  46405. (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
  46406. (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
  46407. (WebCore::RenderTextControlSingleLine::valueChanged):
  46408. (WebCore::RenderTextControlSingleLine::itemText):
  46409. (WebCore::RenderTextControlSingleLine::itemIsEnabled):
  46410. (WebCore::RenderTextControlSingleLine::itemStyle):
  46411. (WebCore::RenderTextControlSingleLine::menuStyle):
  46412. (WebCore::RenderTextControlSingleLine::clientInsetLeft):
  46413. (WebCore::RenderTextControlSingleLine::clientInsetRight):
  46414. (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
  46415. (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  46416. (WebCore::RenderTextControlSingleLine::listSize):
  46417. (WebCore::RenderTextControlSingleLine::selectedIndex):
  46418. (WebCore::RenderTextControlSingleLine::itemIsSeparator):
  46419. (WebCore::RenderTextControlSingleLine::itemIsLabel):
  46420. (WebCore::RenderTextControlSingleLine::itemIsSelected):
  46421. (WebCore::RenderTextControlSingleLine::setTextFromItem):
  46422. (WebCore::RenderTextControlSingleLine::fontSelector):
  46423. (WebCore::RenderTextControlSingleLine::hostWindow):
  46424. (WebCore::RenderTextControlSingleLine::createScrollbar):
  46425. * rendering/RenderTextControlSingleLine.h: Added.
  46426. (WebCore::RenderTextControlSingleLine::hasControlClip):
  46427. (WebCore::RenderTextControlSingleLine::isTextField):
  46428. (WebCore::RenderTextControlSingleLine::placeholderIsVisible):
  46429. (WebCore::RenderTextControlSingleLine::popupIsVisible):
  46430. (WebCore::RenderTextControlSingleLine::shouldPopOver):
  46431. (WebCore::RenderTextControlSingleLine::valueShouldChangeOnHotTrack):
  46432. * rendering/TextControlInnerElements.cpp:
  46433. (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
  46434. (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
  46435. 2008-12-28 Dmitry Titov <dimich@chromium.org>
  46436. Reviewed by Darin Adler.
  46437. https://bugs.webkit.org/show_bug.cgi?id=22755
  46438. Prepare to add create/remove timeout methods to JSWorkerContext by moving
  46439. timer-specific code from JSDOMWindowBase to DOMTimer.
  46440. Moved everything JS-related from DOMTimer to ScheduledAction.
  46441. Now ScheduledAction is what it wanted to be all the time: a JS engine-specific
  46442. container for timer callback that knows how to invoke it.
  46443. DOMTimer is not anymore JS-specific.
  46444. This is mostly moving the code around. No intended functional changes.
  46445. * bindings/js/DOMTimer.cpp:
  46446. (WebCore::DOMTimer::DOMTimer):
  46447. (WebCore::DOMTimer::~DOMTimer):
  46448. (WebCore::DOMTimer::install):
  46449. (WebCore::DOMTimer::removeById):
  46450. (WebCore::DOMTimer::fired):
  46451. (WebCore::DOMTimer::stop):
  46452. * bindings/js/DOMTimer.h:
  46453. * bindings/js/JSDOMWindowBase.cpp:
  46454. (WebCore::JSDOMWindowBase::installTimeout):
  46455. (WebCore::JSDOMWindowBase::removeTimeout):
  46456. * bindings/js/JSDOMWindowBase.h:
  46457. * bindings/js/ScheduledAction.cpp:
  46458. (WebCore::ScheduledAction::execute):
  46459. * bindings/js/ScheduledAction.h:
  46460. * dom/Document.cpp:
  46461. (WebCore::Document::addTimeout):
  46462. 2008-12-26 Zalan Bujtas <zbujtas@gmail.com>
  46463. Reviewed by Darin Adler.
  46464. https://bugs.webkit.org/show_bug.cgi?id=22999
  46465. Check if database thread exists.
  46466. * storage/Database.cpp:
  46467. (WebCore::Database::openAndVerifyVersion):
  46468. (WebCore::Database::markAsDeletedAndClose):
  46469. (WebCore::Database::tableNames):
  46470. 2008-12-26 Alexey Proskuryakov <ap@webkit.org>
  46471. Reviewed by Darin Adler.
  46472. https://bugs.webkit.org/show_bug.cgi?id=23001
  46473. A call to applicationCache.update() from a cached event listener should be ignored
  46474. Test: http/tests/appcache/idempotent-update.html
  46475. * loader/appcache/ApplicationCacheGroup.cpp:
  46476. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Only reset m_status after
  46477. dispatching events.
  46478. 2008-12-26 Alexey Proskuryakov <ap@webkit.org>
  46479. Reviewed by Darin Adler.
  46480. https://bugs.webkit.org/show_bug.cgi?id=22997
  46481. ASSERTION FAILED: !m_resources.contains(url) in ApplicationCache::addResource()
  46482. Tests: http/tests/appcache/top-frame-1.html
  46483. http/tests/appcache/top-frame-2.html
  46484. http/tests/appcache/top-frame-3.html
  46485. http/tests/appcache/top-frame-4.html
  46486. * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest):
  46487. Fixed one more instance of top level frame being used for caching purposes.
  46488. 2008-12-26 Dmitry Titov <dimich@chromium.org>
  46489. Reviewed by Darin Adler.
  46490. https://bugs.webkit.org/show_bug.cgi?id=22987
  46491. Fix for broken test editing/execCommand/5763082.html
  46492. * editing/CompositeEditCommand.cpp:
  46493. (WebCore::CompositeEditCommand::mergeIdenticalElements): Used local RefPtr to hold onto
  46494. function parameter across multiple calls.
  46495. 2008-12-25 Alexey Proskuryakov <ap@webkit.org>
  46496. Reviewed by Darin Adler.
  46497. https://bugs.webkit.org/show_bug.cgi?id=22993
  46498. Application cache shouldn't be inherited by subframes
  46499. <rdar://problem/6284708> AppCache crashes in ApplicationCacheResource::addType()
  46500. This crash happened because main resource for subframe was looked up in top frame's
  46501. appcache. If not for the spec change, it could have been fixed by preventing the load
  46502. altogether.
  46503. Test: http/tests/appcache/foreign-iframe-main.html
  46504. I intend to write additional tests for the behavior change.
  46505. * loader/DocumentLoader.cpp:
  46506. (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
  46507. * loader/DocumentLoader.h:
  46508. (WebCore::DocumentLoader::applicationCache):
  46509. * loader/MainResourceLoader.cpp:
  46510. (WebCore::MainResourceLoader::load):
  46511. * loader/appcache/DOMApplicationCache.cpp:
  46512. (WebCore::DOMApplicationCache::associatedCache):
  46513. Removed DocumentLoader::topLevelApplicationCache(), and changed callers accordingly.
  46514. * loader/appcache/ApplicationCacheGroup.cpp:
  46515. (WebCore::ApplicationCacheGroup::selectCache):
  46516. (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
  46517. Removed checks for the frame being top-level one, now that subframes are cached independently.
  46518. 2008-12-25 Antti Koivisto <antti@apple.com>
  46519. Reviewed by Oliver Hunt.
  46520. <rdar://problem/6465669> Frequent !isPurgeable() assertion in WebCore::CachedResource::addClient
  46521. Disallow turning resources that are being revalidated to purgable state.
  46522. No test, the condition is difficult to produce in DRT.
  46523. * loader/CachedCSSStyleSheet.cpp:
  46524. (WebCore::CachedCSSStyleSheet::allClientsRemoved):
  46525. * loader/CachedImage.cpp:
  46526. (WebCore::CachedImage::destroyDecodedData):
  46527. * loader/CachedResource.cpp:
  46528. (WebCore::CachedResource::isSafeToMakePurgeable):
  46529. (WebCore::CachedResource::makePurgeable):
  46530. * loader/CachedResource.h:
  46531. * loader/CachedScript.cpp:
  46532. (WebCore::CachedScript::destroyDecodedData):
  46533. 2008-12-25 Alexey Proskuryakov <ap@webkit.org>
  46534. Qt build fix.
  46535. * WebCore.pro: Added ThreadGlobalData.cpp.
  46536. 2008-12-24 Mark Rowe <mrowe@apple.com>
  46537. Build fix.
  46538. * WebCore.base.exp: Remove a symbol from the export file now that it is no longer generated.
  46539. 2008-12-24 Holger Hans Peter Freyther <zecke@selfish.org>
  46540. Unreviewed build fix to find addSubresourceURL
  46541. This is needed to compile on WebKit/Gtk+
  46542. * css/CSSFontFaceSrcValue.cpp:
  46543. 2008-12-23 Alexey Proskuryakov <ap@webkit.org>
  46544. Reviewed by Darin Adler.
  46545. https://bugs.webkit.org/show_bug.cgi?id=22980
  46546. WebCore uses more thread specific keys than it really needs
  46547. Consolidated ThreadSpecific data into a single ThreadGlobalData structure.
  46548. * GNUmakefile.am:
  46549. * WebCore.base.exp:
  46550. * WebCore.scons:
  46551. * WebCore.vcproj/WebCore.vcproj:
  46552. * WebCore.xcodeproj/project.pbxproj:
  46553. * WebCoreSources.bkl:
  46554. * dom/EventNames.cpp:
  46555. * dom/EventNames.h:
  46556. (WebCore::eventNames):
  46557. * page/Frame.cpp:
  46558. (WebCore::Frame::Frame):
  46559. * platform/ThreadGlobalData.cpp: Added.
  46560. (WebCore::threadGlobalData):
  46561. (WebCore::ThreadGlobalData::ThreadGlobalData):
  46562. (WebCore::ThreadGlobalData::~ThreadGlobalData):
  46563. * platform/ThreadGlobalData.h: Added.
  46564. (WebCore::ThreadGlobalData::eventNames):
  46565. (WebCore::ThreadGlobalData::emptyString):
  46566. (WebCore::ThreadGlobalData::atomicStringTable):
  46567. (WebCore::ThreadGlobalData::cachedConverterICU):
  46568. (WebCore::ThreadGlobalData::cachedConverterTEC):
  46569. * platform/text/AtomicString.cpp:
  46570. (WebCore::stringTable):
  46571. (WebCore::AtomicString::add):
  46572. (WebCore::AtomicString::remove):
  46573. (WebCore::AtomicString::find):
  46574. (WebCore::AtomicString::init):
  46575. * platform/text/StringImpl.cpp:
  46576. (WebCore::StringImpl::empty):
  46577. * platform/text/StringImpl.h:
  46578. * platform/text/TextCodecICU.cpp:
  46579. (WebCore::ICUConverterWrapper::~ICUConverterWrapper):
  46580. (WebCore::cachedConverterICU):
  46581. * platform/text/TextCodecICU.h:
  46582. (WebCore::ICUConverterWrapper::ICUConverterWrapper):
  46583. * platform/text/mac/TextCodecMac.cpp:
  46584. (WebCore::cachedConverterTEC):
  46585. * platform/text/mac/TextCodecMac.h:
  46586. (WebCore::TECConverterWrapper::TECConverterWrapper):
  46587. (WebCore::TECConverterWrapper::~TECConverterWrapper):
  46588. 2008-12-23 Mark Rowe <mrowe@apple.com>
  46589. Build fix.
  46590. * WebCore.xcodeproj/project.pbxproj: CSSPropertyNames.h is a generated file so it needs to be explicitly copied
  46591. into the PrivateHeaders directory, rather than relying on the automatic copying of headers which runs before the
  46592. derived sources are generated.
  46593. 2008-12-23 Simon Fraser <simon.fraser@apple.com>
  46594. Reviewed by Dan Bernstein
  46595. https://bugs.webkit.org/show_bug.cgi?id=22941
  46596. If the document element has opacity, we need to erase the view background to
  46597. white before painting.
  46598. Test: fast/backgrounds/opacity-on-document-element.html
  46599. * rendering/RenderView.cpp:
  46600. (WebCore::rendererObscuresBackground):
  46601. 2008-12-23 Simon Fraser <simon.fraser@apple.com>
  46602. Reviewed by Dan Bernstein
  46603. https://bugs.webkit.org/show_bug.cgi?id=21910
  46604. Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
  46605. Otherwise the FrameView is left at 0x0, and nothing paints.
  46606. * svg/graphics/SVGImage.cpp:
  46607. (WebCore::SVGImage::draw):
  46608. 2008-12-23 Darin Adler <darin@apple.com>
  46609. Reviewed by John Sullivan.
  46610. - improve robustness of undo/redo in HTML editing to fix the following bugs
  46611. <https://bugs.webkit.org/show_bug.cgi?id=19703> Crash in WebCore::InsertNodeBeforeCommand::doUnapply()
  46612. <rdar://problem/4059423> DOM operations performed on editable HTML can cause a crash later during Undo
  46613. Major categories of improvements:
  46614. 1) Added null checks.
  46615. 2) Eliminated type casts without corresponding type checks.
  46616. 3) Avoided possible infinite loops by building up lists of nodes to operate on
  46617. before starting to make DOM changes.
  46618. 4) Use more RefPtr.
  46619. No test at this time, but test cases should follow in separate patches.
  46620. * WebCore.xcodeproj/project.pbxproj: Set the role of CSSPropertyNames.h to Private so it
  46621. can be used in other Private headers, specifically editing ones.
  46622. * css/CSSStyleSelector.cpp:
  46623. (WebCore::CSSStyleSelector::locateCousinList): Adopt parentElement.
  46624. (WebCore::CSSStyleSelector::locateSharedStyle): Ditto.
  46625. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  46626. * dom/Element.cpp: (WebCore::Element::cloneElement): Added.
  46627. * dom/Element.h: Added cloneElement and an implementation of parentElement.
  46628. * dom/Node.h: Moved parentElement from here to Element.h and changed its
  46629. implementation so it will return 0 when the parent is not an element
  46630. (document, document fragment, etc.).
  46631. * editing/AppendNodeCommand.cpp:
  46632. (WebCore::AppendNodeCommand::AppendNodeCommand): Made parent be an Element.
  46633. Moved assertions from doApply in here.
  46634. (WebCore::AppendNodeCommand::doApply): Simplified to just a single unchecked
  46635. appendChild call.
  46636. (WebCore::AppendNodeCommand::doUnapply): Simplified to just a single remove call.
  46637. * editing/AppendNodeCommand.h: Updated.
  46638. * editing/ApplyStyleCommand.cpp:
  46639. (WebCore::createStyleSpanElement): Eliminate casting by creating an element in a more
  46640. direct way with new instead of createElementNS.
  46641. (WebCore::ApplyStyleCommand::ApplyStyleCommand): Use PassRefPtr.
  46642. (WebCore::ApplyStyleCommand::removeCSSStyle): Use CSSPropertyID.
  46643. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Use cloneElement.
  46644. * editing/ApplyStyleCommand.h:
  46645. * editing/BreakBlockquoteCommand.cpp:
  46646. (WebCore::BreakBlockquoteCommand::doApply): Use Element* and cloneElement.
  46647. * editing/CompositeEditCommand.cpp:
  46648. (WebCore::CompositeEditCommand::applyStyledElement): Use PassRefPtr and unsigned.
  46649. (WebCore::CompositeEditCommand::removeStyledElement): Ditto.
  46650. (WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
  46651. (WebCore::CompositeEditCommand::insertNodeAfter): Ditto.
  46652. (WebCore::CompositeEditCommand::insertNodeAt): Ditto.
  46653. (WebCore::CompositeEditCommand::appendNode): Ditto.
  46654. (WebCore::CompositeEditCommand::removeChildrenInRange): Ditto. Also use a vector to
  46655. make the list of children in case removing them has side effects.
  46656. (WebCore::CompositeEditCommand::removeNode): Ditto.
  46657. (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
  46658. (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Ditto.
  46659. (WebCore::CompositeEditCommand::splitTextNode): Ditto.
  46660. (WebCore::CompositeEditCommand::splitElement): Ditto.
  46661. (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
  46662. (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
  46663. (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
  46664. (WebCore::CompositeEditCommand::joinTextNodes): Ditto.
  46665. (WebCore::CompositeEditCommand::inputText): Ditto.
  46666. (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
  46667. (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
  46668. (WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
  46669. (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): Ditto.
  46670. (WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
  46671. (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Implement by calling
  46672. setNodeAttribute instead of with its own SimpleEditCommand.
  46673. (WebCore::CompositeEditCommand::setNodeAttribute): Ditto.
  46674. (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
  46675. (WebCore::CompositeEditCommand::appendBlockPlaceholder): Ditto.
  46676. (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto.
  46677. (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto. Don't
  46678. bother using an undoable operation to put the break element into the paragraph
  46679. element because there's no need to split them and redo this when doing undo/redo.
  46680. (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  46681. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
  46682. * editing/CompositeEditCommand.h: Ditto.
  46683. * editing/DeleteFromTextNodeCommand.cpp:
  46684. (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Use unsigned.
  46685. (WebCore::DeleteFromTextNodeCommand::doApply): Eliminated inappropriate assertions.
  46686. (WebCore::DeleteFromTextNodeCommand::doUnapply): Ditto.
  46687. * editing/DeleteFromTextNodeCommand.h:
  46688. * editing/DeleteSelectionCommand.cpp:
  46689. (WebCore::DeleteSelectionCommand::removeNode): Use PassRefPtr.
  46690. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Ditto.
  46691. * editing/DeleteSelectionCommand.h:
  46692. * editing/FormatBlockCommand.cpp:
  46693. (WebCore::FormatBlockCommand::FormatBlockCommand): Use AtomicString.
  46694. (WebCore::FormatBlockCommand::doApply): Use Element.
  46695. * editing/FormatBlockCommand.h:
  46696. * editing/IndentOutdentCommand.cpp:
  46697. (WebCore::createIndentBlockquoteElement): Use new to create the element
  46698. instead of calling a function so we have a more specific type.
  46699. (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
  46700. Use RefPtr and Element.
  46701. (WebCore::IndentOutdentCommand::indentRegion): Ditto.
  46702. (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.
  46703. * editing/IndentOutdentCommand.h:
  46704. * editing/InsertIntoTextNodeCommand.cpp:
  46705. (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
  46706. Use unsigned. Added an assertion.
  46707. (WebCore::InsertIntoTextNodeCommand::doApply): Eliminated inappropriate assertions.
  46708. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
  46709. * editing/InsertIntoTextNodeCommand.h:
  46710. * editing/InsertLineBreakCommand.cpp:
  46711. (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use Element.
  46712. (WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
  46713. * editing/InsertListCommand.cpp:
  46714. (WebCore::InsertListCommand::doApply): Use Element.
  46715. * editing/InsertNodeBeforeCommand.cpp:
  46716. (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Moved assertions
  46717. here from doApply.
  46718. (WebCore::InsertNodeBeforeCommand::doApply): Eliminated inappropriate assertions.
  46719. Added a null check.
  46720. (WebCore::InsertNodeBeforeCommand::doUnapply): Simplified to just a single remove call.
  46721. * editing/InsertParagraphSeparatorCommand.cpp:
  46722. (WebCore::InsertParagraphSeparatorCommand::doApply): Use Element and cloneElement.
  46723. * editing/JoinTextNodesCommand.cpp:
  46724. (WebCore::JoinTextNodesCommand::doApply): Eliminated inappropriate assertions.
  46725. Added some runtime checks. Don't store anything in m_offset.
  46726. (WebCore::JoinTextNodesCommand::doUnapply): Ditto.
  46727. * editing/JoinTextNodesCommand.h:
  46728. * editing/MergeIdenticalElementsCommand.cpp:
  46729. (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Moved
  46730. an assertion here from doApply.
  46731. (WebCore::MergeIdenticalElementsCommand::doApply): Eliminated inappropriate assertions.
  46732. Added a null check. Changed implementation to use remove to avoid null parent issue.
  46733. Use a vector of nodes to avoid possible infinite loop if mutation happens while iterating.
  46734. (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
  46735. * editing/ModifySelectionListLevel.cpp:
  46736. (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): Use Element*.
  46737. (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
  46738. * editing/ModifySelectionListLevel.h:
  46739. * editing/RemoveCSSPropertyCommand.cpp:
  46740. (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Use PassRefPtr and
  46741. CSSPropertyID. Also renamed m_decl to m_style.
  46742. (WebCore::RemoveCSSPropertyCommand::doApply): Eliminated inappropriate assertions.
  46743. (WebCore::RemoveCSSPropertyCommand::doUnapply): Ditto.
  46744. * editing/RemoveNodeAttributeCommand.cpp: Removed contents of this file. To be deleted.
  46745. Use SetNodeAttributeCommand instead.
  46746. * editing/RemoveNodeAttributeCommand.h: Ditto.
  46747. * editing/RemoveNodeCommand.cpp:
  46748. (WebCore::RemoveNodeCommand::RemoveNodeCommand): Moved assertions here from doApply.
  46749. Don't initialize m_refChild here; rather do it in doApply.
  46750. (WebCore::RemoveNodeCommand::doApply): Eliminated inappropriate assertions. Added
  46751. checks and streamlined implementation.
  46752. (WebCore::RemoveNodeCommand::doUnapply): Ditto.
  46753. * editing/RemoveNodeCommand.h:
  46754. * editing/RemoveNodePreservingChildrenCommand.cpp:
  46755. (WebCore::RemoveNodePreservingChildrenCommand::doApply): Use a vector.
  46756. * editing/ReplaceSelectionCommand.cpp:
  46757. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Removed now-unneeded cast.
  46758. * editing/SetNodeAttributeCommand.cpp:
  46759. (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Use AtomicString.
  46760. Removed assertion that prevents us from using this to remove an attribute.
  46761. (WebCore::SetNodeAttributeCommand::doApply): Eliminated inappropriate assertions.
  46762. (WebCore::SetNodeAttributeCommand::doUnapply): Ditto.
  46763. * editing/SetNodeAttributeCommand.h:
  46764. * editing/SplitElementCommand.cpp:
  46765. (WebCore::SplitElementCommand::SplitElementCommand): Moved assertion here from doApply.
  46766. (WebCore::SplitElementCommand::doApply): Check some more invariants and use a vector
  46767. to avoid possible infinite loops.
  46768. (WebCore::SplitElementCommand::doUnapply): Ditto.
  46769. * editing/SplitTextNodeCommand.cpp:
  46770. (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Moved assertions and comment
  46771. here from doApply.
  46772. (WebCore::SplitTextNodeCommand::doApply): Check for null and failures when applying.
  46773. (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
  46774. * editing/SplitTextNodeContainingElementCommand.cpp:
  46775. (WebCore::SplitTextNodeContainingElementCommand::doApply): Use Element.
  46776. * editing/WrapContentsInDummySpanCommand.cpp:
  46777. (WebCore::WrapContentsInDummySpanCommand::doApply): Check for null and ignore failures.
  46778. Don't reuse the dummy span. Simplified logic.
  46779. (WebCore::WrapContentsInDummySpanCommand::doUnapply): Ditto.
  46780. * editing/htmlediting.cpp:
  46781. (WebCore::isBlock): Make sure this returns true only for elements.
  46782. (WebCore::enclosingBlock): Return an Element*.
  46783. (WebCore::enclosingTableCell): Ditto.
  46784. (WebCore::enclosingList): Return an HTMLElement*.
  46785. (WebCore::outermostEnclosingList): Return an HTMLElement*.
  46786. (WebCore::createDefaultParagraphElement): Return an HTMLElement*.
  46787. (WebCore::createBreakElement): Return an HTMLElement*.
  46788. (WebCore::createOrderedListElement): Return an HTMLElement*.
  46789. (WebCore::createUnorderedListElement): Return an HTMLElement*.
  46790. (WebCore::createListItemElement): Return an HTMLElement*.
  46791. (WebCore::createHTMLElement): Return an HTMLElement*.
  46792. * editing/htmlediting.h:
  46793. * editing/markup.cpp:
  46794. (WebCore::createFragmentFromText): Use createBreakElement and use Element*.
  46795. * page/MouseEventWithHitTestResults.cpp:
  46796. (WebCore::MouseEventWithHitTestResults::targetNode): Use parentElement.
  46797. 2008-12-23 Darin Adler <darin@apple.com>
  46798. Reviewed by Dan Bernstein.
  46799. * dom/Node.h: Tweak comments and order of bits that Sam moved
  46800. here last night.
  46801. * dom/Node.cpp: Ditto.
  46802. 2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
  46803. Reviewed by Darin Adler.
  46804. Bug 11106: Some XMLHttpRequest URI resolving tests fail
  46805. https://bugs.webkit.org/show_bug.cgi?id=11106
  46806. Use the ScriptExecutionContext to resolve the URI when calling open in JavaScript.
  46807. The previous code was using the containing DOMWindow to do so which would fail for
  46808. XMLHttpRequest object being passed between iframe.
  46809. Tests: http/tests/xmlhttprequest/uri-resolution-opera-open-004.html
  46810. http/tests/xmlhttprequest/uri-resolution-opera-open-005.html
  46811. http/tests/xmlhttprequest/uri-resolution-opera-open-006.html
  46812. http/tests/xmlhttprequest/uri-resolution-opera-open-007.html
  46813. http/tests/xmlhttprequest/uri-resolution-opera-open-008.html
  46814. http/tests/xmlhttprequest/uri-resolution-opera-open-009.html
  46815. http/tests/xmlhttprequest/uri-resolution-opera-open-010.html
  46816. * bindings/js/JSXMLHttpRequestCustom.cpp:
  46817. (WebCore::JSXMLHttpRequest::open): Use the ScriptExecutionContext
  46818. to resolve the URL.
  46819. * dom/Document.cpp:
  46820. (WebCore::Document::virtualCompleteURL): Virtual method added to
  46821. avoid performance hit on completeURL call.
  46822. * dom/Document.h:
  46823. * dom/ScriptExecutionContext.h:
  46824. (WebCore::ScriptExecutionContext::completeURL): Non-virtual method
  46825. that wrap the call to the virtual call.
  46826. * dom/WorkerContext.cpp:
  46827. (WebCore::WorkerContext::virtualCompleteURL): Pure virtual method.
  46828. * dom/WorkerContext.h:
  46829. 2008-12-23 Darin Adler <darin@apple.com>
  46830. Reviewed by Dan Bernstein.
  46831. - https://bugs.webkit.org/show_bug.cgi?id=22978
  46832. a couple tweaks to the new strokeBoundingRect functions
  46833. * platform/graphics/cairo/PathCairo.cpp:
  46834. (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext
  46835. if the applier is non-null.
  46836. * platform/graphics/cg/PathCG.cpp:
  46837. (WebCore::putBytesNowhere): Added.
  46838. (WebCore::createScratchContext): Changed to use a "/dev/null" type
  46839. function to discard bytes rather than using a data object. This
  46840. eliminates the possibility that memory will be used if someone draws
  46841. into the scratch context by accident. Also moved to the top of the
  46842. file; it was in a slightly strange place before.
  46843. (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext
  46844. if the applier is non-null. Simplify the empty path special case.
  46845. 2008-12-22 Sam Weinig <sam@webkit.org>
  46846. Reviewed by Mark Rowe.
  46847. Save a word in all Elements by moving the 5 loose bits to Node,
  46848. where we had 16 spare.
  46849. * dom/Element.cpp:
  46850. (WebCore::Element::Element):
  46851. * dom/Element.h:
  46852. * dom/Node.cpp:
  46853. (WebCore::Node::Node):
  46854. * dom/Node.h:
  46855. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46856. Reviewed by George Staikos.
  46857. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22972
  46858. Add WML <meta> element support. All needed functionality is present
  46859. in Document::processHttpEquiv, already covered by tests.
  46860. * GNUmakefile.am:
  46861. * WebCore.pro:
  46862. * WebCore.vcproj/WebCore.vcproj:
  46863. * WebCore.xcodeproj/project.pbxproj:
  46864. * wml/WMLMetaElement.cpp: Added.
  46865. (WebCore::WMLMetaElement::WMLMetaElement):
  46866. (WebCore::WMLMetaElement::parseMappedAttribute):
  46867. (WebCore::WMLMetaElement::insertedIntoDocument):
  46868. * wml/WMLMetaElement.h: Added.
  46869. * wml/WMLTagNames.in:
  46870. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46871. Rubber-stamped by Darin Adler.
  46872. Don't reference specific layout tests in comments.
  46873. * html/HTMLFormElement.cpp:
  46874. (WebCore::HTMLFormElement::createFormData):
  46875. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46876. Reviewed by George Staikos.
  46877. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22965
  46878. Add WML <head> element support. Doesn't require a WMLHeadElement.
  46879. No functional behaviour, as we already created a WMLElement for headTag, by default.
  46880. It's just cleaner to list <head> in WMLTagNames, forwarding to a WMLElement constructor.
  46881. * wml/WMLTagNames.in:
  46882. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46883. Reviewed by George Staikos.
  46884. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
  46885. Fix regression caused by the HTMLFormElement refactorization.
  46886. File form elements without a name have to be included in multipart/form-data
  46887. submission. Cover this behaviour with a new test case.
  46888. Test: http/tests/misc/empty-file-formdata.html
  46889. * html/HTMLFormElement.cpp:
  46890. (WebCore::HTMLFormElement::createFormData):
  46891. * wml/WMLTagNames.in:
  46892. 2008-12-22 David Kilzer <ddkilzer@apple.com>
  46893. <rdar://problem/6438298> Bump schema version for app cache
  46894. Reviewed by Alexey Proskuryakov.
  46895. * loader/appcache/ApplicationCacheStorage.cpp: Increment
  46896. SchemaVersion from 2 to 3.
  46897. 2008-12-22 David Kilzer <ddkilzer@apple.com>
  46898. Use Deque in CSSStyleSheet::addSubresourceStyleURLs()
  46899. Reviewed by Darin Adler.
  46900. * css/CSSStyleSheet.cpp:
  46901. (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced
  46902. use of ListHashSet with more efficient Deque.
  46903. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  46904. Reviewed by Sam Weinig.
  46905. Fix obvious crash fix for WML enabled builds.
  46906. * css/CSSStyleSelector.cpp:
  46907. (WebCore::CSSStyleSelector::adjustRenderStyle):
  46908. 2008-12-22 David Kilzer <ddkilzer@apple.com>
  46909. Bug 11850: Webarchive fails to save images referenced in CSS
  46910. <https://bugs.webkit.org/show_bug.cgi?id=11850>
  46911. Reviewed by Darin Adler.
  46912. This entry contains two parts since the tests for adding a
  46913. completeURL() method to StyleSheet and CSSStyleSheet (part 1) depend
  46914. on Bug 11850 being fixed (part 2).
  46915. --
  46916. Tests: http/tests/webarchive/test-css-url-encoding-shift-jis.html
  46917. http/tests/webarchive/test-css-url-encoding-utf-8.html
  46918. http/tests/webarchive/test-css-url-encoding.html
  46919. Added completeURL() methods to StyleSheet and CSSStyleSheet that
  46920. match the behavior of Document::completeURL(). Most notably,
  46921. CSSStyleSheet::completeURL() uses the charset of the stylesheet
  46922. (if it exists) to construct URLs, just like Document::completeURL().
  46923. * css/CSSParser.cpp:
  46924. (WebCore::CSSParser::parseValue): Use CSSStyleSheet::completeURL().
  46925. (WebCore::CSSParser::parseContent): Ditto.
  46926. (WebCore::CSSParser::parseFillImage): Ditto.
  46927. (WebCore::CSSParser::parseFontFaceSrc): Ditto.
  46928. (WebCore::CSSParser::parseBorderImage): Ditto.
  46929. * css/CSSStyleSheet.cpp:
  46930. (WebCore::CSSStyleSheet::completeURL): Added.
  46931. * css/CSSStyleSheet.h:
  46932. (WebCore::CSSStyleSheet::completeURL): Added declaration.
  46933. * css/StyleSheet.cpp:
  46934. (WebCore::StyleSheet::completeURL): Added.
  46935. * css/StyleSheet.h:
  46936. (WebCore::StyleSheet::completeURL): Added declaration.
  46937. * dom/Document.cpp:
  46938. (WebCore::Document::completeURL): Added comment referring to the new
  46939. completeURL() methods in StyleSheet and CSSStyleSheet.
  46940. --
  46941. Tests: webarchive/test-css-url-resources-in-stylesheets.html
  46942. webarchive/test-css-url-resources-inline-styles.html
  46943. Walk stylesheets and inline style attributes for url() references
  46944. when building a list of URLs to include in a webarchive. Note that
  46945. not all URLs found this way will be included in the webarchive if
  46946. they were not used (and thus not downloaded) when laying out the
  46947. page.
  46948. The key method for CSS stylesheets is
  46949. CSSStyleSheet::addSubresourceStyleURLs() which iterates over all
  46950. CSSStyleSheet objects recursively referenced from its own stylesheet
  46951. through @import rules. Starting with the CSSRule objects in each
  46952. sheet and continuing down through the CSSMutableStyleDeclaration and
  46953. CSSValue objects, addSubresourceStyleURLs() methods are called to
  46954. gather URLs.
  46955. For inline style attributes in HTML DOM elements,
  46956. StyledElement::addSubresourceAttributeURLs() calls
  46957. CSSMutableStyleDeclaration::addSubresourceStyleURLs() to gather URLs
  46958. from each element, hence the need to call
  46959. addSubresourceAttributeURLs() on superclasses when the method is
  46960. implemented on the element class itself.
  46961. * css/CSSBorderImageValue.cpp:
  46962. (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added.
  46963. * css/CSSBorderImageValue.h:
  46964. (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added
  46965. declaration.
  46966. * css/CSSFontFaceRule.cpp:
  46967. (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added.
  46968. * css/CSSFontFaceRule.h:
  46969. (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added
  46970. declaration.
  46971. * css/CSSFontFaceSrcValue.cpp:
  46972. (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added.
  46973. * css/CSSFontFaceSrcValue.h:
  46974. (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added
  46975. declaration.
  46976. * css/CSSImportRule.cpp:
  46977. (WebCore::CSSImportRule::addSubresourceStyleURLs): Added.
  46978. * css/CSSImportRule.h:
  46979. (WebCore::CSSImportRule::addSubresourceStyleURLs): Added
  46980. declaration.
  46981. * css/CSSMutableStyleDeclaration.cpp:
  46982. (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added.
  46983. Iterates over m_properties vector of CSSProperty objects calling
  46984. addSubresourceStyleURLs() on each property's CSSValue object.
  46985. * css/CSSMutableStyleDeclaration.h:
  46986. (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added
  46987. declaration.
  46988. * css/CSSPrimitiveValue.cpp:
  46989. (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added.
  46990. * css/CSSPrimitiveValue.h:
  46991. (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added
  46992. declaration.
  46993. * css/CSSReflectValue.cpp:
  46994. (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added.
  46995. * css/CSSReflectValue.h:
  46996. (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added
  46997. declaration.
  46998. * css/CSSRule.h:
  46999. (WebCore::CSSRule::addSubresourceStyleURLs): Added. Virtual
  47000. method with empty implementation that's overridden by subclasses
  47001. as needed.
  47002. * css/CSSStyleRule.cpp:
  47003. (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added.
  47004. * css/CSSStyleRule.h:
  47005. (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added
  47006. declaration.
  47007. * css/CSSStyleSheet.cpp:
  47008. (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated to
  47009. call CSSRule::addSubresourceStyleURLs on each rule to extract
  47010. URLs. Removed unneeded baseURL parameter now that the
  47011. completeURL() method exists.
  47012. * css/CSSStyleSheet.h:
  47013. (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated
  47014. declaration.
  47015. * css/CSSValue.h:
  47016. (WebCore::CSSValue::addSubresourceStyleURLs): Added. Virtual
  47017. method with empty implementation that's overridden by subclasses
  47018. as needed.
  47019. * css/CSSValueList.cpp:
  47020. (WebCore::CSSValueList::addSubresourceStyleURLs): Added.
  47021. Iterates over m_values vector of CSSValue objects calling
  47022. addSubresourceStyleURLs() on each.
  47023. * css/CSSValueList.h:
  47024. (WebCore::CSSValueList::addSubresourceStyleURLs): Added
  47025. declaration.
  47026. * css/StyleSheet.h:
  47027. (WebCore::StyleSheet::addSubresourceStyleURLs): Updated
  47028. declaration to remove unneeded baseURL parameter.
  47029. * dom/ProcessingInstruction.cpp:
  47030. (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
  47031. Fixed to use the StyleBase::baseURL() method to get the
  47032. stylesheet's URL instead of calling Document::completeURL().
  47033. * dom/StyledElement.cpp:
  47034. (WebCore::StyledElement::addSubresourceAttributeURLs): Added method
  47035. to extract URLs from inline style declarations.
  47036. * dom/StyledElement.h:
  47037. (WebCore::StyledElement::addSubresourceAttributeURLs): Added
  47038. declaration.
  47039. * html/HTMLBodyElement.cpp:
  47040. (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Call
  47041. addSubresourceAttributeURLs() in superclass to extract URLs
  47042. from inline style declarations.
  47043. * html/HTMLEmbedElement.cpp:
  47044. (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
  47045. * html/HTMLImageElement.cpp:
  47046. (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
  47047. * html/HTMLInputElement.cpp:
  47048. (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
  47049. * html/HTMLLinkElement.cpp:
  47050. (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
  47051. * html/HTMLObjectElement.cpp:
  47052. (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
  47053. * html/HTMLParamElement.cpp:
  47054. (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
  47055. * html/HTMLScriptElement.cpp:
  47056. (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
  47057. * html/HTMLStyleElement.cpp:
  47058. (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
  47059. * html/HTMLTableCellElement.cpp:
  47060. (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
  47061. * html/HTMLTableElement.cpp:
  47062. (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
  47063. * svg/SVGCursorElement.cpp:
  47064. (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Ditto.
  47065. * svg/SVGFEImageElement.cpp:
  47066. (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
  47067. * svg/SVGImageElement.cpp:
  47068. (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
  47069. * svg/SVGScriptElement.cpp:
  47070. (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
  47071. 2008-12-22 Dhananjoy Chutia <dhanrd@gmail.com>
  47072. Reviewed by David Kilzer.
  47073. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22959
  47074. Memory leak fixes for WebKit+soup
  47075. * platform/network/soup/ResourceHandleSoup.cpp:
  47076. (WebCore::finishedCallback):
  47077. 2008-12-22 Alexey Proskuryakov <ap@webkit.org>
  47078. Reviewed by Darin Adler.
  47079. <rdar://problem/6277060> ASSERTION FAILED: !m_cacheBeingUpdated if the manifest is not available
  47080. Tests: http/tests/appcache/404-manifest.html
  47081. http/tests/appcache/fail-on-update.html
  47082. * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading):
  47083. Removed the incorrect assertion.
  47084. * loader/appcache/ApplicationCacheGroup.h: Added an explanation of somewhat nonintuitive
  47085. m_currentHandle handling.
  47086. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47087. Reviewed by Alexey Proskuryakov & George Staikos.
  47088. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22961
  47089. Add WML <fieldset> element support.
  47090. Unlike HTML's <fieldset> element, WML doesn't provide a <legend> child element
  47091. to describe the <fieldset>. WML instead offers a 'title' attribute on the <fieldset>
  47092. element. To integrate within the existing RenderFieldset code, we just create an
  47093. internal <insertedLegend> element as first child for a WML <fieldset> element, containing
  47094. the title attribute value.
  47095. * GNUmakefile.am:
  47096. * WebCore.pro:
  47097. * WebCore.vcproj/WebCore.vcproj:
  47098. * WebCore.xcodeproj/project.pbxproj:
  47099. * css/CSSStyleSelector.cpp:
  47100. (WebCore::CSSStyleSelector::adjustRenderStyle):
  47101. * css/wml.css:
  47102. * rendering/RenderFieldset.cpp:
  47103. (WebCore::RenderFieldset::RenderFieldset):
  47104. (WebCore::RenderFieldset::findLegend):
  47105. * rendering/RenderFieldset.h:
  47106. * rendering/RenderLegend.cpp:
  47107. (WebCore::RenderLegend::RenderLegend):
  47108. * rendering/RenderLegend.h:
  47109. * wml/WMLFieldSetElement.cpp: Added.
  47110. (WebCore::WMLFieldSetElement::WMLFieldSetElement):
  47111. (WebCore::WMLFieldSetElement::~WMLFieldSetElement):
  47112. (WebCore::WMLFieldSetElement::parseMappedAttribute):
  47113. (WebCore::WMLFieldSetElement::insertedIntoDocument):
  47114. (WebCore::WMLFieldSetElement::removedFromDocument):
  47115. (WebCore::WMLFieldSetElement::createRenderer):
  47116. * wml/WMLFieldSetElement.h: Added.
  47117. * wml/WMLInsertedLegendElement.cpp: Added.
  47118. (WebCore::WMLInsertedLegendElement::WMLInsertedLegendElement):
  47119. (WebCore::WMLInsertedLegendElement::~WMLInsertedLegendElement):
  47120. (WebCore::WMLInsertedLegendElement::createRenderer):
  47121. * wml/WMLInsertedLegendElement.h: Added.
  47122. * wml/WMLTagNames.in:
  47123. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47124. Not reviewed. Try to fix clean Mac builds, set role=private for FormDataBuilder.h
  47125. * WebCore.xcodeproj/project.pbxproj:
  47126. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47127. Rubber-stamped by George Staikos.
  47128. Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
  47129. * css/CSSStyleSelector.cpp:
  47130. * css/wml.css:
  47131. * dom/DOMImplementation.cpp:
  47132. * dom/Document.cpp:
  47133. * dom/Document.h:
  47134. * dom/XMLTokenizer.cpp:
  47135. * dom/XMLTokenizerLibxml2.cpp:
  47136. * dom/XMLTokenizerQt.cpp:
  47137. * history/BackForwardList.cpp:
  47138. * history/BackForwardList.h:
  47139. * loader/FrameLoader.cpp:
  47140. * loader/FrameLoader.h:
  47141. * loader/MainResourceLoader.cpp:
  47142. * page/Page.cpp:
  47143. * page/Page.h:
  47144. * platform/MIMETypeRegistry.cpp:
  47145. * platform/network/FormDataBuilder.cpp:
  47146. * platform/network/FormDataBuilder.h:
  47147. * platform/qt/MIMETypeRegistryQt.cpp:
  47148. * wml/WMLAElement.cpp:
  47149. * wml/WMLAElement.h:
  47150. * wml/WMLAccessElement.cpp:
  47151. * wml/WMLAccessElement.h:
  47152. * wml/WMLAnchorElement.cpp:
  47153. * wml/WMLAnchorElement.h:
  47154. * wml/WMLBRElement.cpp:
  47155. * wml/WMLBRElement.h:
  47156. * wml/WMLCardElement.cpp:
  47157. * wml/WMLCardElement.h:
  47158. * wml/WMLDoElement.cpp:
  47159. * wml/WMLDoElement.h:
  47160. * wml/WMLDocument.cpp:
  47161. * wml/WMLDocument.h:
  47162. * wml/WMLElement.cpp:
  47163. * wml/WMLElement.h:
  47164. * wml/WMLErrorHandling.cpp:
  47165. * wml/WMLErrorHandling.h:
  47166. * wml/WMLEventHandlingElement.cpp:
  47167. * wml/WMLEventHandlingElement.h:
  47168. * wml/WMLGoElement.cpp:
  47169. * wml/WMLGoElement.h:
  47170. * wml/WMLImageElement.cpp:
  47171. * wml/WMLImageElement.h:
  47172. * wml/WMLImageLoader.cpp:
  47173. * wml/WMLImageLoader.h:
  47174. * wml/WMLIntrinsicEvent.cpp:
  47175. * wml/WMLIntrinsicEvent.h:
  47176. * wml/WMLIntrinsicEventHandler.cpp:
  47177. * wml/WMLIntrinsicEventHandler.h:
  47178. * wml/WMLNoopElement.cpp:
  47179. * wml/WMLNoopElement.h:
  47180. * wml/WMLOnEventElement.cpp:
  47181. * wml/WMLOnEventElement.h:
  47182. * wml/WMLPElement.cpp:
  47183. * wml/WMLPElement.h:
  47184. * wml/WMLPageState.cpp:
  47185. * wml/WMLPageState.h:
  47186. * wml/WMLPostfieldElement.cpp:
  47187. * wml/WMLPostfieldElement.h:
  47188. * wml/WMLPrevElement.cpp:
  47189. * wml/WMLPrevElement.h:
  47190. * wml/WMLRefreshElement.cpp:
  47191. * wml/WMLRefreshElement.h:
  47192. * wml/WMLSetvarElement.cpp:
  47193. * wml/WMLSetvarElement.h:
  47194. * wml/WMLTableElement.cpp:
  47195. * wml/WMLTableElement.h:
  47196. * wml/WMLTaskElement.cpp:
  47197. * wml/WMLTaskElement.h:
  47198. * wml/WMLTemplateElement.cpp:
  47199. * wml/WMLTemplateElement.h:
  47200. * wml/WMLTimerElement.cpp:
  47201. * wml/WMLTimerElement.h:
  47202. * wml/WMLVariables.cpp:
  47203. * wml/WMLVariables.h:
  47204. 2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47205. Reviewed by George Staikos.
  47206. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22638
  47207. Add POST method support to WMLGoElement. GET & POST over HTTP
  47208. covered by a new set of WML HTTP layout tests.
  47209. Tests: http/tests/wml/go-task-get-method-accept-charset.html
  47210. http/tests/wml/go-task-get-method.html
  47211. http/tests/wml/go-task-post-method-accept-charset.html
  47212. http/tests/wml/go-task-post-method.html
  47213. * wml/WMLGoElement.cpp:
  47214. (WebCore::WMLGoElement::WMLGoElement):
  47215. (WebCore::WMLGoElement::registerPostfieldElement):
  47216. (WebCore::WMLGoElement::parseMappedAttribute):
  47217. (WebCore::WMLGoElement::executeTask):
  47218. (WebCore::WMLGoElement::preparePOSTRequest):
  47219. (WebCore::WMLGoElement::prepareGETRequest):
  47220. (WebCore::WMLGoElement::createFormData):
  47221. * wml/WMLGoElement.h:
  47222. * wml/WMLPostfieldElement.cpp:
  47223. (WebCore::encodedString):
  47224. (WebCore::WMLPostfieldElement::encodeData):
  47225. * wml/WMLPostfieldElement.h:
  47226. 2008-12-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47227. Reviewed by Darin Adler and George Staikos.
  47228. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22949
  47229. Refactor HTMLFormElement to share a maximum level of code between HTMLFormElement & WMLGoElement.
  47230. Create a new helper class 'FormDataBuilder', which is hold as member variable in those classes.
  47231. It encapsulates all functionality needed to generate a FormData object, usable for HTML/WML form
  47232. submission, including boundary string generation, multi-part form handling etc.
  47233. No functional changes, no test cases affected.
  47234. WMLGoElement will be converted in a follow-up patch.
  47235. * GNUmakefile.am:
  47236. * WebCore.pro:
  47237. * WebCore.scons:
  47238. * WebCore.vcproj/WebCore.vcproj:
  47239. * WebCore.xcodeproj/project.pbxproj:
  47240. * WebCoreSources.bkl:
  47241. * html/HTMLFormElement.cpp:
  47242. (WebCore::HTMLFormElement::HTMLFormElement):
  47243. (WebCore::HTMLFormElement::dataEncoding):
  47244. (WebCore::HTMLFormElement::createFormData):
  47245. (WebCore::HTMLFormElement::submit):
  47246. (WebCore::HTMLFormElement::parseMappedAttribute):
  47247. * html/HTMLFormElement.h:
  47248. (WebCore::HTMLFormElement::enctype):
  47249. (WebCore::HTMLFormElement::encoding):
  47250. (WebCore::HTMLFormElement::setEncoding):
  47251. (WebCore::HTMLFormElement::acceptCharset):
  47252. * platform/network/FormDataBuilder.cpp: Added.
  47253. (WebCore::FormDataBuilder::FormDataBuilder):
  47254. (WebCore::FormDataBuilder::~FormDataBuilder):
  47255. (WebCore::FormDataBuilder::parseEncodingType):
  47256. (WebCore::FormDataBuilder::parseMethodType):
  47257. (WebCore::FormDataBuilder::dataEncoding):
  47258. (WebCore::appendString):
  47259. (WebCore::FormDataBuilder::beginMultiPartHeader):
  47260. (WebCore::FormDataBuilder::addBoundaryToMultiPartHeader):
  47261. (WebCore::FormDataBuilder::addFileNameToMultiPartHeader):
  47262. (WebCore::FormDataBuilder::addContentTypeToMultiPartHeader):
  47263. (WebCore::FormDataBuilder::finishMultiPartHeader):
  47264. (WebCore::FormDataBuilder::clear):
  47265. (WebCore::FormDataBuilder::addKeyValuePairAsFormData):
  47266. (WebCore::FormDataBuilder::encodeStringAsFormData):
  47267. (WebCore::FormDataBuilder::generateUniqueBoundaryString):
  47268. * platform/network/FormDataBuilder.h: Added.
  47269. (WebCore::FormDataBuilder::isPostMethod):
  47270. (WebCore::FormDataBuilder::setIsPostMethod):
  47271. (WebCore::FormDataBuilder::isMultiPartForm):
  47272. (WebCore::FormDataBuilder::setIsMultiPartForm):
  47273. (WebCore::FormDataBuilder::encodingType):
  47274. (WebCore::FormDataBuilder::setEncodingType):
  47275. (WebCore::FormDataBuilder::acceptCharset):
  47276. (WebCore::FormDataBuilder::setAcceptCharset):
  47277. (WebCore::FormDataBuilder::encodedData):
  47278. (WebCore::FormDataBuilder::multiPartData):
  47279. 2008-12-21 Dirk Schulze <krit@webkit.org>
  47280. Reviewed by Darin Adler, Nikolas Zimmermann.
  47281. Move the the platform dependent strokeBBox functionality out of RenderPath
  47282. into Path with strokeBoundingRect.
  47283. RenderPath clean-up for strokeBoundingBox
  47284. [https://bugs.webkit.org/show_bug.cgi?id=22902]
  47285. * GNUmakefile.am:
  47286. * WebCore.xcodeproj/project.pbxproj:
  47287. * platform/graphics/GraphicsContext.h:
  47288. * platform/graphics/Path.h:
  47289. * platform/graphics/StrokeStyleApplier.h: Added.
  47290. (WebCore::StrokeStyleApplier::~StrokeStyleApplier):
  47291. * platform/graphics/cairo/PathCairo.cpp:
  47292. (WebCore::Path::strokeBoundingRect):
  47293. * platform/graphics/cg/PathCG.cpp:
  47294. (WebCore::createScratchContext):
  47295. (WebCore::scratchContext):
  47296. (WebCore::Path::strokeBoundingRect):
  47297. * platform/graphics/qt/GraphicsContextQt.cpp:
  47298. (WebCore::GraphicsContext::pen):
  47299. * platform/graphics/qt/PathQt.cpp:
  47300. (WebCore::Path::strokeBoundingRect):
  47301. * rendering/RenderPath.cpp:
  47302. (WebCore::StrokeBoundingRectStyleApplier::StrokeBoundingRectStyleApplier):
  47303. (WebCore::StrokeBoundingRectStyleApplier::strokeStyle):
  47304. (WebCore::RenderPath::relativeBBox):
  47305. * rendering/RenderPath.h:
  47306. * svg/graphics/cairo/RenderPathCairo.cpp:
  47307. * svg/graphics/cg/RenderPathCg.cpp:
  47308. * svg/graphics/qt/RenderPathQt.cpp:
  47309. 2008-12-20 David Kilzer <ddkilzer@apple.com>
  47310. Fix typo "CSSAferRuleValue" to "CSSAfterRuleValue"
  47311. * html/PreloadScanner.cpp:
  47312. (WebCore::PreloadScanner::tokenizeCSS):
  47313. * html/PreloadScanner.h:
  47314. (WebCore::PreloadScanner::CSSState):
  47315. 2008-12-19 Alexey Proskuryakov <ap@webkit.org>
  47316. Reviewed by Geoff Garen.
  47317. <rdar://problem/6454076> Random crashes on JS raytracer
  47318. No test, because the crash is not readily reproducible.
  47319. * platform/text/StringImpl.cpp:
  47320. (WebCore::StringImpl::empty):
  47321. * platform/text/StringImpl.h:
  47322. Made empty string per-thread.
  47323. 2008-12-19 Anders Carlsson <andersca@apple.com>
  47324. Reviewed by Sam Weinig.
  47325. Replace some uses of HardRetain etc with RetainPtr.
  47326. * platform/mac/DragImageMac.mm:
  47327. * platform/mac/SharedBufferMac.mm:
  47328. (WebCore::SharedBuffer::createCFData):
  47329. * rendering/RenderThemeMac.mm:
  47330. * svg/graphics/cg/SVGResourceFilterCg.mm:
  47331. (WebCore::SVGResourceFilter::prepareFilter):
  47332. (WebCore::SVGResourceFilter::applyFilter):
  47333. * svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  47334. * svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
  47335. (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
  47336. 2008-12-19 miggilin <mr.diggilin@gmail.com>
  47337. Reviewed by Kevin Ollivier.
  47338. Add Context Menu support to wx bindings.
  47339. https://bugs.webkit.org/show_bug.cgi?id=22675
  47340. * platform/ContextMenu.h:
  47341. * platform/ContextMenuItem.h:
  47342. (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  47343. * platform/wx/ContextMenuItemWx.cpp: Added.
  47344. * platform/wx/ContextMenuWx.cpp: Added.
  47345. * platform/wx/LocalizedStringsWx.cpp:
  47346. * platform/wx/TemporaryLinkStubs.cpp:
  47347. * webcore-wx.bkl:
  47348. 2008-12-19 Beth Dakin <bdakin@apple.com>
  47349. Reviewed by Darin Adler.
  47350. Temporary band-aide fix for <rdar://problem/6372481> In Gmail, a
  47351. crash occurs at
  47352. AccessibilityTable::isTableExposableThroughAccessibility() when
  47353. attempting to create a link in a rich text message
  47354. We need to disable Accessibility Tables until we get this fixed for
  47355. real to prevent rampant crashing.
  47356. * page/AccessibilityTable.cpp:
  47357. (WebCore::AccessibilityTable::AccessibilityTable):
  47358. 2008-12-19 Simon Fraser <simon.fraser@apple.com>
  47359. Reviewed by Darin Adler
  47360. https://bugs.webkit.org/show_bug.cgi?id=22938
  47361. When the document element is transformed, we need to paint
  47362. the view background to avoid unpainted areas.
  47363. Test: fast/transforms/transformed-document-element.html
  47364. * rendering/RenderView.cpp:
  47365. (WebCore::RenderView::paintBoxDecorations):
  47366. 2008-12-19 Steve Falkenburg <sfalken@apple.com>
  47367. Fix build.
  47368. * WebCore.vcproj/WebCore.vcproj:
  47369. 2008-12-19 Kevin Ollivier <kevino@theolliviers.com>
  47370. wx build fixes after recent changes.
  47371. * WebCoreSources.bkl:
  47372. * platform/graphics/wx/ImageSourceWx.cpp:
  47373. (WebCore::ImageSource::clear):
  47374. * webcore-base.bkl:
  47375. 2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
  47376. Reviewed by Sam Weinig.
  47377. [GTK] Fix make distcheck again
  47378. These files were moved to WebCore/platform/animation
  47379. and WebCore/platform/graphics/transforms.
  47380. * GNUmakefile.am:
  47381. 2008-12-19 Gustavo Noronha Silva <gns@gnome.org>
  47382. Reviewed by Holger Freyther.
  47383. https://bugs.webkit.org/show_bug.cgi?id=22900
  47384. Fix AtomicString usage, so that building works.
  47385. * platform/network/soup/ResourceHandleSoup.cpp:
  47386. 2008-12-19 Adam Roben <aroben@apple.com>
  47387. Windows build fix on older versions of CFNetwork after r39393
  47388. * platform/network/cf/ResourceHandleCFNet.cpp:
  47389. (WebCore::highestSupportedCFURLConnectionClientVersion): Changed
  47390. preprocessor directives not to leave in unreachable code on old
  47391. versions of CFNetwork.
  47392. 2008-12-19 Antti Koivisto <antti@apple.com>
  47393. Comment fix.
  47394. * platform/PurgeableBuffer.h:
  47395. 2008-12-19 Holger Hans Peter Freyther <zecke@selfish.org>
  47396. [GTK] Build fix by adding the new files.
  47397. * GNUmakefile.am:
  47398. 2008-12-19 Jade Han <jade.han@nokia.com>
  47399. Reviewed by Tor Arne Vestbø.
  47400. [Qt] Allow conversion of JavaScript Number and Boolean types to Qt types
  47401. https://bugs.webkit.org/show_bug.cgi?id=22880
  47402. * bridge/qt/qt_runtime.cpp:
  47403. (JSC::Bindings::convertValueToQVariant):
  47404. 2008-12-19 Tor Arne Vestbø <tavestbo@trolltech.com>
  47405. Reviewed by Holger Freyther.
  47406. Implement ImageDecoder::filenameExtension() for Qt
  47407. * platform/graphics/qt/ImageDecoderQt.cpp:
  47408. (WebCore::ImageDecoderQt::filenameExtension):
  47409. * platform/graphics/qt/ImageDecoderQt.h:
  47410. * platform/graphics/qt/ImageSourceQt.cpp:
  47411. (WebCore::ImageSource::filenameExtension):
  47412. 2008-12-19 Adam Barth <abarth@webkit.org>
  47413. Reviewed by Darin Alder.
  47414. Implement ImageSource::filenameExtension for Cario
  47415. https://bugs.webkit.org/show_bug.cgi?id=22905
  47416. * platform/graphics/cairo/ImageSourceCairo.cpp:
  47417. (WebCore::ImageSource::filenameExtension):
  47418. * platform/image-decoders/ImageDecoder.h:
  47419. * platform/image-decoders/bmp/BMPImageDecoder.h:
  47420. (WebCore::BMPImageDecoder::filenameExtension):
  47421. * platform/image-decoders/gif/GIFImageDecoder.h:
  47422. (WebCore::GIFImageDecoder::filenameExtension):
  47423. * platform/image-decoders/ico/ICOImageDecoder.h:
  47424. (WebCore::ICOImageDecoder::filenameExtension):
  47425. * platform/image-decoders/jpeg/JPEGImageDecoder.h:
  47426. (WebCore::JPEGImageDecoder::filenameExtension):
  47427. * platform/image-decoders/png/PNGImageDecoder.h:
  47428. (WebCore::PNGImageDecoder::filenameExtension):
  47429. * platform/image-decoders/xbm/XBMImageDecoder.h:
  47430. (WebCore::XBMImageDecoder::filenameExtension):
  47431. 2008-12-18 Dan Bernstein <mitz@apple.com>
  47432. Reviewed by Sam Weinig.
  47433. - avoid using the ResourceHandle-level credential storage, if any,
  47434. unless the client opts to use it; when use of the credential
  47435. storage is disallowed, all authentication challenges are sent to
  47436. the client.
  47437. - let the FrameLoaderClient decide whether to use the credential
  47438. storage.
  47439. * loader/EmptyClients.h:
  47440. (WebCore::EmptyFrameLoaderClient::shouldUseCredentialStorage): Added.
  47441. Returns false.
  47442. * loader/FrameLoader.cpp:
  47443. (WebCore::FrameLoader::shouldUseCredentialStorage): Added. Calls through
  47444. to the FrameLoaderClient.
  47445. * loader/FrameLoader.h: Declared shouldUseCredentialStorage().
  47446. * loader/FrameLoaderClient.h: Declared shouldUseCredentialStorage().
  47447. * loader/ResourceLoader.cpp:
  47448. (WebCore::ResourceLoader::shouldUseCredentialStorage): Added. Calls
  47449. through to the FrameLoader.
  47450. * loader/ResourceLoader.h:
  47451. (WebCore::ResourceLoader::shouldUseCredentialStorage): Implemented this
  47452. ResourceHandleClient method.
  47453. * loader/SubresourceLoader.cpp:
  47454. (WebCore::SubresourceLoader::shouldUseCredentialStorage): Added.
  47455. Overrides the ResourceLoader implementation by letting the client
  47456. supply the return value. If the client does not do this, continues
  47457. with the ResourceLoader behavior of asking the FrameLoader.
  47458. * loader/SubresourceLoader.h: Removed an unused #include and declared
  47459. shouldUseCredentialStorage().
  47460. * loader/SubresourceLoaderClient.h:
  47461. (WebCore::SubresourceLoaderClient::getShouldUseCredentialStorage):
  47462. Added a default implementation which returns false, meaning the client
  47463. does not wish to decide whether the credential storage should be used.
  47464. * platform/network/ResourceHandle.h: Removed unused forward declarations.
  47465. Declared a new member function, shouldUseCredentialStorage(), on Mac and
  47466. CFNetwork-using builds.
  47467. * platform/network/ResourceHandleClient.h:
  47468. (WebCore::ResourceHandleClient::shouldUseCredentialStorage): Added this
  47469. default implementation that returns false.
  47470. * platform/network/cf/ResourceHandleCFNet.cpp:
  47471. (WebCore::findCFNetworkModule): Added. Returns a handle to the CFNetwork
  47472. module.
  47473. (WebCore::cfNetworkVersion): Added. Returns the high word of the
  47474. CFNetwork library's product version.
  47475. (WebCore::highestSupportedCFURLConnectionClientVersion): Added. Returns
  47476. the highest version of the CFURLConnectionClient structure supported by
  47477. the CFNetwork library. The only reason to check this at runtime is
  47478. that WebKit may be linking at runtime against an older version of
  47479. CFNetwork than the one it was built with, as is the case with nightly
  47480. builds.
  47481. (WebCore::shouldUseCredentialStorageCallback): Added this
  47482. CFURLConnection callback which calls through to
  47483. ResourceHandle::shouldUseCredentialStorage().
  47484. (WebCore::ResourceHandle::start): Pass a version 3 CFURLConnectionClient
  47485. including the shouldUseCredentialStorage callback. At runtime, clamp the
  47486. client structure version down to the highest supported by CFNetwork.
  47487. (WebCore::ResourceHandle::shouldUseCredentialStorage): Added. Calls through
  47488. to the client if there is one. Otherwise returns false.
  47489. * platform/network/mac/ResourceHandleMac.mm:
  47490. (WebCore::ResourceHandle::shouldUseCredentialStorage): Ditto.
  47491. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
  47492. Added this delegate method which callls through to
  47493. ResourceHandle::shouldUseCredentialStorage().
  47494. 2008-12-18 David Kilzer <ddkilzer@apple.com>
  47495. Reset role to "Private" on 6 header files to fix clean builds after r39378
  47496. Reviewed by BUILD FIX.
  47497. * WebCore.xcodeproj/project.pbxproj: Added back "Private" role
  47498. that was lost on 6 headers when they were "moved":
  47499. AffineTransform.h, Animation.h, AnimationList.h,
  47500. TimingFunction.h, TransformOperation.h and
  47501. TransformOperations.h.
  47502. 2008-12-18 Pamela Greene <pam@chromium.org>
  47503. Reviewed by Dan Bernstein.
  47504. Add initializer for m_textDirectionSubmenuInclusionBehavior.
  47505. https://bugs.webkit.org/show_bug.cgi?id=22926
  47506. * page/Settings.cpp:
  47507. (WebCore::Settings::Settings): Initialize m_textDirectionSubmenuInclusionBehavior
  47508. 2008-12-18 Sam Weinig <sam@webkit.org>
  47509. Reviewed by John Sullivan.
  47510. Add new FrameLoaderClient method to indicate the first visually
  47511. non-empty layout based on an heuristic. Right now that heuristic
  47512. is the first layout after an image, text or plugin has been added
  47513. to the render tree, but I can imagine it becoming much smarter.
  47514. * loader/EmptyClients.h:
  47515. (WebCore::EmptyFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
  47516. * loader/FrameLoader.cpp:
  47517. (WebCore::FrameLoader::didFirstVisuallyNonEmptyLayout):
  47518. * loader/FrameLoader.h:
  47519. * loader/FrameLoaderClient.h:
  47520. * page/FrameView.cpp:
  47521. (WebCore::FrameViewPrivate::reset):
  47522. (WebCore::FrameView::layout):
  47523. (WebCore::FrameView::performPostLayoutTasks):
  47524. (WebCore::FrameView::setIsVisuallyNonEmpty):
  47525. * page/FrameView.h:
  47526. * rendering/RenderImage.cpp:
  47527. (WebCore::RenderImage::RenderImage):
  47528. * rendering/RenderPartObject.cpp:
  47529. (WebCore::RenderPartObject::RenderPartObject):
  47530. * rendering/RenderText.cpp:
  47531. (WebCore::RenderText::RenderText):
  47532. 2008-12-18 Darin Adler <darin@apple.com>
  47533. Reviewed by Sam Weinig.
  47534. - fix <rdar://problem/6449841> reduce memory use of ResourceResponseBase by removing two maps
  47535. We were parsing the cache-control and pragma header field values into maps.
  47536. I changed that so instead we only cache two bits with the data we were actually
  47537. using. Later we might want to move this responsibility out of this class entirely;
  47538. we can cache it at the higher level instead.
  47539. * loader/CachedResource.cpp:
  47540. (WebCore::CachedResource::mustRevalidate): Changed to call a specific API to get at
  47541. the bits in quest instead of a general "cache control directives" API.
  47542. * platform/network/ResourceResponseBase.cpp:
  47543. (WebCore::ResourceResponseBase::setHTTPHeaderField): Remove the logic for the
  47544. pragma header field since no one is using this for now.
  47545. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Eliminated the return
  47546. value and made this function have side effects only. Changed it so it's the caller's
  47547. responsibility to check m_haveParsedCacheControl. Set m_cacheControlContainsNoCache
  47548. and m_cacheControlContainsMustRevalidate rather than keeping a map around.
  47549. * platform/network/ResourceResponseBase.h:
  47550. (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Added.
  47551. (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate): Added.
  47552. (WebCore::ResourceResponseBase::ResourceResponseBase): Updated since I removed
  47553. m_haveParsedCacheControl and renamed m_haveParsedCacheControlHeader to remove
  47554. the imprecise use of the term "header".
  47555. 2008-12-18 Steve Falkenburg <sfalken@apple.com>
  47556. Build fix.
  47557. Delete 2nd copy of code in these files.
  47558. * platform/animation/Animation.cpp:
  47559. * platform/animation/Animation.h:
  47560. * platform/animation/AnimationList.cpp:
  47561. * platform/animation/AnimationList.h:
  47562. * platform/animation/TimingFunction.h:
  47563. * platform/graphics/transforms/AffineTransform.cpp:
  47564. * platform/graphics/transforms/AffineTransform.h:
  47565. * platform/graphics/transforms/IdentityTransformOperation.h:
  47566. * platform/graphics/transforms/MatrixTransformOperation.cpp:
  47567. * platform/graphics/transforms/MatrixTransformOperation.h:
  47568. * platform/graphics/transforms/RotateTransformOperation.cpp:
  47569. * platform/graphics/transforms/RotateTransformOperation.h:
  47570. * platform/graphics/transforms/ScaleTransformOperation.cpp:
  47571. * platform/graphics/transforms/ScaleTransformOperation.h:
  47572. * platform/graphics/transforms/SkewTransformOperation.cpp:
  47573. * platform/graphics/transforms/SkewTransformOperation.h:
  47574. * platform/graphics/transforms/TransformOperation.h:
  47575. * platform/graphics/transforms/TransformOperations.cpp:
  47576. * platform/graphics/transforms/TransformOperations.h:
  47577. * platform/graphics/transforms/TranslateTransformOperation.cpp:
  47578. * platform/graphics/transforms/TranslateTransformOperation.h:
  47579. 2008-12-18 Dimitri Glazkov <dglazkov@chromium.org>
  47580. Reviewed by Geoffrey Garen.
  47581. https://bugs.webkit.org/show_bug.cgi?id=22859
  47582. Abstract away the use of JSDOMWindow in CachedPage and introduce
  47583. ScriptCachedPageData abstraction.
  47584. * GNUmakefile.am: Added ScriptCachedPageData to project.
  47585. * WebCore.pro: Added ScriptCachedPageData to project.
  47586. * WebCore.vcproj/WebCore.vcproj: Added ScriptCachedPageData to project.
  47587. * WebCore.xcodeproj/project.pbxproj: Added ScriptCachedPageData to
  47588. project.
  47589. * bindings/js/ScriptCachedPageData.cpp: Added.
  47590. (WebCore::ScriptCachedPageData::ScriptCachedPageData):
  47591. (WebCore::ScriptCachedPageData::~ScriptCachedPageData):
  47592. (WebCore::ScriptCachedPageData::restore):
  47593. (WebCore::ScriptCachedPageData::clear):
  47594. * bindings/js/ScriptCachedPageData.h: Added.
  47595. * history/CachedPage.cpp: Replaced JSDOMWindow and ProtectedPtr with
  47596. ScriptCachedPageData.
  47597. (WebCore::CachedPage::CachedPage):
  47598. (WebCore::CachedPage::domWindow):
  47599. (WebCore::CachedPage::restore):
  47600. (WebCore::CachedPage::clear):
  47601. * history/CachedPage.h: Replaced JSDOMWindow and ProtectedPtr with
  47602. ScriptCachedPageData.
  47603. 2008-12-18 Chris Marrin <cmarrin@apple.com>
  47604. Reviewed by Dave Hyatt.
  47605. https://bugs.webkit.org/show_bug.cgi?id=22888
  47606. To avoid future dependency issues, all the TransformOperations and Animation related files need to be moved to platform
  47607. * WebCore.xcodeproj/project.pbxproj:
  47608. * platform/animation: Added.
  47609. * platform/animation/Animation.cpp: Copied from WebCore/rendering/style/Animation.cpp.
  47610. * platform/animation/Animation.h: Copied from WebCore/rendering/style/Animation.h.
  47611. * platform/animation/AnimationList.cpp: Copied from WebCore/rendering/style/AnimationList.cpp.
  47612. * platform/animation/AnimationList.h: Copied from WebCore/rendering/style/AnimationList.h.
  47613. * platform/animation/TimingFunction.h: Copied from WebCore/rendering/style/TimingFunction.h.
  47614. * platform/graphics/AffineTransform.cpp: Removed.
  47615. * platform/graphics/AffineTransform.h: Removed.
  47616. * platform/graphics/transforms: Added.
  47617. * platform/graphics/transforms/AffineTransform.cpp: Copied from WebCore/platform/graphics/AffineTransform.cpp.
  47618. * platform/graphics/transforms/AffineTransform.h: Copied from WebCore/platform/graphics/AffineTransform.h.
  47619. * platform/graphics/transforms/IdentityTransformOperation.h: Copied from WebCore/rendering/style/IdentityTransformOperation.h.
  47620. * platform/graphics/transforms/MatrixTransformOperation.cpp: Copied from WebCore/rendering/style/MatrixTransformOperation.cpp.
  47621. * platform/graphics/transforms/MatrixTransformOperation.h: Copied from WebCore/rendering/style/MatrixTransformOperation.h.
  47622. * platform/graphics/transforms/RotateTransformOperation.cpp: Copied from WebCore/rendering/style/RotateTransformOperation.cpp.
  47623. * platform/graphics/transforms/RotateTransformOperation.h: Copied from WebCore/rendering/style/RotateTransformOperation.h.
  47624. * platform/graphics/transforms/ScaleTransformOperation.cpp: Copied from WebCore/rendering/style/ScaleTransformOperation.cpp.
  47625. * platform/graphics/transforms/ScaleTransformOperation.h: Copied from WebCore/rendering/style/ScaleTransformOperation.h.
  47626. * platform/graphics/transforms/SkewTransformOperation.cpp: Copied from WebCore/rendering/style/SkewTransformOperation.cpp.
  47627. * platform/graphics/transforms/SkewTransformOperation.h: Copied from WebCore/rendering/style/SkewTransformOperation.h.
  47628. * platform/graphics/transforms/TransformOperation.h: Copied from WebCore/rendering/style/TransformOperation.h.
  47629. * platform/graphics/transforms/TransformOperations.cpp: Copied from WebCore/rendering/style/TransformOperations.cpp.
  47630. * platform/graphics/transforms/TransformOperations.h: Copied from WebCore/rendering/style/TransformOperations.h.
  47631. * platform/graphics/transforms/TranslateTransformOperation.cpp: Copied from WebCore/rendering/style/TranslateTransformOperation.cpp.
  47632. * platform/graphics/transforms/TranslateTransformOperation.h: Copied from WebCore/rendering/style/TranslateTransformOperation.h.
  47633. * rendering/style/Animation.cpp: Removed.
  47634. * rendering/style/Animation.h: Removed.
  47635. * rendering/style/AnimationList.cpp: Removed.
  47636. * rendering/style/AnimationList.h: Removed.
  47637. * rendering/style/IdentityTransformOperation.h: Removed.
  47638. * rendering/style/MatrixTransformOperation.cpp: Removed.
  47639. * rendering/style/MatrixTransformOperation.h: Removed.
  47640. * rendering/style/RotateTransformOperation.cpp: Removed.
  47641. * rendering/style/RotateTransformOperation.h: Removed.
  47642. * rendering/style/ScaleTransformOperation.cpp: Removed.
  47643. * rendering/style/ScaleTransformOperation.h: Removed.
  47644. * rendering/style/SkewTransformOperation.cpp: Removed.
  47645. * rendering/style/SkewTransformOperation.h: Removed.
  47646. * rendering/style/TimingFunction.h: Removed.
  47647. * rendering/style/TransformOperation.h: Removed.
  47648. * rendering/style/TransformOperations.cpp: Removed.
  47649. * rendering/style/TransformOperations.h: Removed.
  47650. * rendering/style/TranslateTransformOperation.cpp: Removed.
  47651. * rendering/style/TranslateTransformOperation.h: Removed.
  47652. 2008-12-18 Cameron Zwarich <zwarich@apple.com>
  47653. Reviewed by Geoff Garen.
  47654. Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
  47655. <https://bugs.webkit.org/show_bug.cgi?id=21855>
  47656. <rdar://problem/6278244>
  47657. If JavaScript is not currently executing, the handleEvent member function
  47658. of JSAbstractEventListener should set the dynamic global object to the
  47659. global object of the context in which the event occurred.
  47660. If this is not set, then JavaScriptCore will simply take the global object
  47661. of the context where the event handler function was created, which may be
  47662. a different frame. This will cause the popup blocker to incorrectly block
  47663. windows opened from onclick events inside of an iframe whose handler was
  47664. created in the outer frame, as it will check the outer frame and see that
  47665. it is not processing any events.
  47666. * bindings/js/JSEventListener.cpp:
  47667. (WebCore::JSAbstractEventListener::handleEvent):
  47668. 2008-12-17 Simon Fraser <simon.fraser@apple.com>
  47669. Reviewed by Dave Hyatt
  47670. https://bugs.webkit.org/show_bug.cgi?id=22570
  47671. Add the ability to compute clip rects independently from
  47672. caching them on the RenderLayer. When painting reflections, use
  47673. such temporarily computed clipRects, otherwise the layer may cache
  47674. clipRects which are invalid, since they have been computed with
  47675. a rootLayer that is not the one usually used to paint.
  47676. Test: fast/reflections/reflection-overflow-hidden.html
  47677. * rendering/RenderLayer.cpp:
  47678. (WebCore::RenderLayer::paintLayer):
  47679. (WebCore::RenderLayer::hitTestLayer):
  47680. (WebCore::RenderLayer::updateClipRects):
  47681. (WebCore::RenderLayer::calculateClipRects):
  47682. (WebCore::RenderLayer::calculateRects):
  47683. * rendering/RenderLayer.h:
  47684. (WebCore::ClipRects::ClipRects):
  47685. (WebCore::ClipRects::reset):
  47686. (WebCore::ClipRects::overflowClipRect):
  47687. (WebCore::ClipRects::setOverflowClipRect):
  47688. (WebCore::ClipRects::fixedClipRect):
  47689. (WebCore::ClipRects::setFixedClipRect):
  47690. (WebCore::ClipRects::posClipRect):
  47691. (WebCore::ClipRects::setPosClipRect):
  47692. (WebCore::ClipRects::setFixed):
  47693. (WebCore::ClipRects::operator==):
  47694. (WebCore::ClipRects::operator=):
  47695. * rendering/RenderReplica.cpp:
  47696. (WebCore::RenderReplica::paint):
  47697. 2008-12-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  47698. Reviewed by Simon Hausmann.
  47699. https://bugs.webkit.org/show_bug.cgi?id=22618
  47700. Fix MinGW QtWebKit linking problems and also make the
  47701. QtWebKit build system more robust.
  47702. * WebCore.pro:
  47703. 2008-12-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47704. Reviewed by Maciej Stachowiak.
  47705. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22866
  47706. wml.css is based on an older copy of html4.css. Synchronize them.
  47707. Remove all entries, that are irrelevant for WML.
  47708. Fix <do> appearance: should behave like HTMLs <button>.
  47709. * css/wml.css:
  47710. 2008-12-17 Yury Semikhatsky <yurys@google.com>
  47711. Reviewed by Timothy Hatcher.
  47712. Landed by Adam Barth.
  47713. Added more checks that WebInspector.panels.{resources,scripts} are
  47714. defined where they are accessed from other panels and WebInspector
  47715. (some panels are not yet supported in Chrome).
  47716. * inspector/front-end/Console.js:
  47717. (WebInspector.Console.prototype.addMessage):
  47718. (WebInspector.Console.prototype.clearMessages):
  47719. (WebInspector.Console.prototype.completions):
  47720. * inspector/front-end/ObjectPropertiesSection.js:
  47721. (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
  47722. * inspector/front-end/ScriptsPanel.js:
  47723. (WebInspector.ScriptsPanel.prototype.get searchableViews):
  47724. (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource):
  47725. (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
  47726. (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  47727. * inspector/front-end/SourceView.js:
  47728. (WebInspector.SourceView.prototype._addBreakpoint):
  47729. * inspector/front-end/inspector.js:
  47730. (WebInspector.addResource):
  47731. (WebInspector.removeResource):
  47732. (WebInspector.showResourceForURL):
  47733. 2008-12-17 Cary Clark < caryclark@google.com>
  47734. Reviewed by Darin Adler.
  47735. Landed by Adam Barth.
  47736. Add ENABLE_TEXT_CARET to permit the ANDROID platform
  47737. to invalidate and draw the caret in a separate thread.
  47738. * page/Frame.cpp:
  47739. (WebCore::Frame::clearCaretRectIfNeeded): Body of
  47740. function does nothing if text caret is disabled.
  47741. (WebCore::Frame::selectionLayoutChanged): Do nothing
  47742. if text caret is disabled and the caret only blinked.
  47743. (WebCore::Frame::caretBlinkTimerFired):
  47744. (WebCore::Frame::paintCaret):
  47745. (WebCore::Frame::paintDragCaret): Body of
  47746. functions does nothing if text caret is disabled.
  47747. 2008-12-16 Darin Adler <darin@apple.com>
  47748. Reviewed and landed by Cameron Zwarich.
  47749. Change the style of AtomicString::add() to match Identifier:add().
  47750. * platform/text/AtomicString.cpp:
  47751. (WebCore::AtomicString::add):
  47752. 2008-12-16 Adele Peterson <adele@apple.com>
  47753. Reviewed by Darin Adler.
  47754. Fix for https://bugs.webkit.org/show_bug.cgi?id=22827
  47755. <rdar://problem/6247724> RenderThemeWin buttons have weird heavy text
  47756. * rendering/RenderThemeWin.cpp:
  47757. (WebCore::fillFontDescription): Add version that takes a font size.
  47758. (WebCore::RenderThemeWin::systemFont): Use the default GUI font for control fonts, but specify the size.
  47759. This will match Firefox.
  47760. 2008-12-16 Stephanie Lewis <slewis@apple.com>
  47761. Another build fix.
  47762. * platform/text/AtomicString.h:
  47763. (WebCore::AtomicString::AtomicString):
  47764. 2008-12-16 Stephanie Lewis <slewis@apple.com>
  47765. Windows Build Fix.
  47766. * platform/text/AtomicString.h:
  47767. (WebCore::AtomicString::AtomicString):
  47768. (WebCore::AtomicString::createCFString):
  47769. 2008-12-16 Peter Kasting <pkasting@google.com>
  47770. Reviewed by David Hyatt.
  47771. https://bugs.webkit.org/show_bug.cgi?id=22885
  47772. Fix memory corruption in GIFImageDecoder.cpp with certain GIFs.
  47773. * platform/image-decoders/gif/GIFImageDecoder.cpp:
  47774. (WebCore::GIFImageDecoder::frameComplete):
  47775. 2008-12-16 Stephanie Lewis <slewis@apple.com>
  47776. Reviewed by Geoff Garen.
  47777. Change HTTPHeaderMap to use an AtomicString as its key.
  47778. Shaves ~1MB off of the Mozilla Memory Test
  47779. No functionality difference
  47780. * WebCore.xcodeproj/project.pbxproj:
  47781. * inspector/InspectorController.cpp:
  47782. (WebCore::addHeaders):
  47783. * loader/appcache/ApplicationCacheStorage.cpp:
  47784. (WebCore::parseHeader):
  47785. * platform/network/HTTPHeaderMap.h:
  47786. * platform/network/ResourceRequestBase.cpp:
  47787. (WebCore::ResourceRequestBase::httpHeaderField):
  47788. (WebCore::ResourceRequestBase::setHTTPHeaderField):
  47789. (WebCore::ResourceRequestBase::addHTTPHeaderField):
  47790. * platform/network/ResourceRequestBase.h:
  47791. * platform/network/ResourceResponseBase.cpp:
  47792. (WebCore::ResourceResponseBase::httpHeaderField):
  47793. (WebCore::ResourceResponseBase::setHTTPHeaderField):
  47794. * platform/network/ResourceResponseBase.h:
  47795. * platform/text/StringHash.h:
  47796. (WebCore::CaseFoldingHash::hash):
  47797. (WebCore::CaseFoldingHash::equal):
  47798. * xml/XMLHttpRequest.cpp:
  47799. (WebCore::isSetCookieHeader):
  47800. (WebCore::XMLHttpRequest::setRequestHeader):
  47801. (WebCore::XMLHttpRequest::setRequestHeaderInternal):
  47802. (WebCore::XMLHttpRequest::getRequestHeader):
  47803. (WebCore::XMLHttpRequest::getResponseHeader):
  47804. * xml/XMLHttpRequest.h:
  47805. 2008-12-16 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47806. Reviewed by Darin Adler.
  47807. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22876
  47808. Remove legacy randomNumber() functionality from HTMLFormElement, and use the new wtf/RandomNumber.h.
  47809. Also remove an uneeded QFileInfo include while I'm at it - there is no Qt usage in this file.
  47810. * ForwardingHeaders/wtf/RandomNumber.h: Added.
  47811. * html/HTMLFormElement.cpp:
  47812. (WebCore::getUniqueBoundaryString):
  47813. 2008-12-16 Yael Aharon <yael.aharon@nokia.com>
  47814. Reviewed by Tor Arne Vestbø.
  47815. Qt/Win build fix
  47816. * platform/win/SystemTimeWin.cpp:
  47817. 2008-12-16 Kalle Vahlman <kalle.vahlman@movial.com>
  47818. Reviewed by Holger Freyther.
  47819. [CURL] memory leak of ResouceHandles
  47820. http://bugs.webkit.org/show_bug.cgi?id=20777
  47821. Fix ResourceHandle ref management to be consistent and correct.
  47822. Original patch from Marco Barisione.
  47823. * platform/network/curl/ResourceHandleCurl.cpp:
  47824. (WebCore::ResourceHandle::start):
  47825. * platform/network/curl/ResourceHandleManager.cpp:
  47826. (WebCore::ResourceHandleManager::removeFromCurl):
  47827. (WebCore::ResourceHandleManager::add):
  47828. (WebCore::ResourceHandleManager::removeScheduledJob):
  47829. 2008-12-16 Simon Hausmann <simon.hausmann@nokia.com>
  47830. Fix the Qt build.
  47831. * platform/graphics/qt/ImageSourceQt.cpp:
  47832. (WebCore::ImageSource::clear): Adjust to new signature.
  47833. 2008-12-15 Mark Rowe <mrowe@apple.com>
  47834. Rubber-stamped by Cameron Zwarich.
  47835. <rdar://problem/6289933> Change WebKit-related projects to build with GCC 4.2 on Leopard.
  47836. * Configurations/Base.xcconfig:
  47837. * Configurations/DebugRelease.xcconfig:
  47838. 2008-12-15 Adele Peterson <adele@apple.com>
  47839. Reviewed by Darin Adler.
  47840. Fix for https://bugs.webkit.org/show_bug.cgi?id=22871
  47841. <rdar://problem/6417316> RenderThemeWin buttons are too short/thin
  47842. * rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
  47843. Check if the button's style (not the new inner style) has appearance set to determine whether we should set padding on the inner style.
  47844. 2008-12-15 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  47845. Reviewed by Oliver Hunt.
  47846. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22865
  47847. Add complete WML <table> / <tr> / <td> element support.
  47848. Proper handling of all table related attributes, including tests.
  47849. Tests: fast/wml/table-element-align-attribute-invalid.wml (variable reference in 'align' attribute, raises error)
  47850. fast/wml/table-element-columns-attribute-invalid-number.wml (columns='0', raises error)
  47851. fast/wml/table-element-columns-attribute-invalid.wml (non-numeric 'columns' attribute value, raises error)
  47852. fast/wml/table-element-columns-attribute-missing.wml (missing 'columns')
  47853. fast/wml/table-element-columns-attribute.wml (test 'columns' attribute and <td> count mismatches)
  47854. * GNUmakefile.am:
  47855. * WebCore.pro:
  47856. * WebCore.vcproj/WebCore.vcproj:
  47857. * WebCore.xcodeproj/project.pbxproj:
  47858. * rendering/RenderObject.cpp:
  47859. (WebCore::RenderObject::offsetParent):
  47860. * rendering/RenderTableRow.cpp:
  47861. (WebCore::RenderTableRow::addChild):
  47862. * wml/WMLTableElement.cpp: Added.
  47863. (WebCore::WMLTableElement::WMLTableElement):
  47864. (WebCore::WMLTableElement::~WMLTableElement):
  47865. (WebCore::WMLTableElement::mapToEntry):
  47866. (WebCore::WMLTableElement::parseMappedAttribute):
  47867. (WebCore::WMLTableElement::finishParsingChildren):
  47868. * wml/WMLTableElement.h: Added.
  47869. * wml/WMLTagNames.in:
  47870. 2008-12-15 Darin Adler <darin@apple.com>
  47871. Reviewed by Sam Weinig.
  47872. - fix <rdar://problem/6427048> crash due to infinite recursion after setting window.__proto__ = window
  47873. Test: fast/dom/Window/window-custom-prototype.html
  47874. Replaced toGlobalObject with the more generally useful unwrappedObject.
  47875. * bindings/js/JSDOMWindowShell.cpp:
  47876. (WebCore::JSDOMWindowShell::unwrappedObject): Added.
  47877. * bindings/js/JSDOMWindowShell.h: Declared unwrappedObject.
  47878. * bindings/js/JSQuarantinedObjectWrapper.h:
  47879. (WebCore::JSQuarantinedObjectWrapper::unwrappedObject): Ditto.
  47880. 2008-12-15 Gustavo Noronha Silva <kov@kov.eti.br>
  47881. Reviewed by Mark Rowe.
  47882. https://bugs.webkit.org/show_bug.cgi?id=22686
  47883. GTK+ build fix.
  47884. * GNUmakefile.am:
  47885. 2008-12-15 Sam Weinig <sam@webkit.org>
  47886. Reviewed by Darin Adler.
  47887. Fix for https://bugs.webkit.org/show_bug.cgi?id=22847
  47888. Geolocation PositionOptions cannot be an arbitrary object.
  47889. Allow the PositionOptions to be a vanilla JS object and parse it
  47890. appropriately.
  47891. * DerivedSources.make: Remove PositionOptions.
  47892. * GNUmakefile.am: Ditto.
  47893. * WebCore.pro: Ditto.
  47894. * WebCore.vcproj/WebCore.vcproj: Ditto.
  47895. * WebCore.xcodeproj/project.pbxproj: Ditto.
  47896. * WebCoreSources.bkl: Ditto.
  47897. * bindings/js/JSGeolocationCustom.cpp:
  47898. (WebCore::createPositionOptions): Added. Extracts the enableHighAccuracy
  47899. and timeout fields from a vanilla JS object in order to create the
  47900. PositionOptions object, checking for exceptions as necessary.
  47901. (WebCore::JSGeolocation::getCurrentPosition): Use createPositionOptions
  47902. instead of toPositionOptions.
  47903. (WebCore::JSGeolocation::watchPosition): Ditto.
  47904. * page/PositionOptions.idl: Removed
  47905. 2008-12-15 Peter Kasting <pkasting@google.com>
  47906. Reviewed by David Hyatt.
  47907. https://bugs.webkit.org/show_bug.cgi?id=22108
  47908. Large animated GIFs weren't always animating. The code that deleted
  47909. the entire decoder after each frame of a large image was resulting in
  47910. us forgetting the loop count, breaking animations intermittently.
  47911. Instead of throwing the whole decoder away, we're more careful to just
  47912. delete frames we don't care about. This additionally addresses
  47913. problems in the Cairo and Chromium ports with excessive peak memory
  47914. use and CPU use when decoding large animated GIFs because it leads to
  47915. much less redecoding (O(n) instead of O(n^2) CPU, and O(1) instead of
  47916. O(n) memory).
  47917. This change has less impact on the CG decoder, which seems to throw
  47918. away frames automatically when their external references are dropped;
  47919. this means the CG decoder didn't suffer from the peak memory usage
  47920. issue before (and still doesn't), but it also still burns excessive
  47921. CPU redecoding earlier frames, that in theory it wouldn't need to
  47922. redecode if it would judiciously save the most recent frames. At
  47923. least this patch plumbs some useful info to the ImageSource so it can
  47924. help guide the CG decoder heuristics in the future.
  47925. * platform/graphics/BitmapImage.cpp:
  47926. (WebCore::frameBytes):
  47927. (WebCore::BitmapImage::destroyDecodedData):
  47928. (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
  47929. (WebCore::BitmapImage::destroyMetadataAndNotify):
  47930. (WebCore::BitmapImage::clearFrame):
  47931. (WebCore::BitmapImage::cacheFrame):
  47932. (WebCore::BitmapImage::dataChanged):
  47933. (WebCore::BitmapImage::startAnimation):
  47934. (WebCore::BitmapImage::resetAnimation):
  47935. (WebCore::BitmapImage::internalAdvanceAnimation):
  47936. * platform/graphics/BitmapImage.h:
  47937. * platform/graphics/GeneratedImage.h:
  47938. (WebCore::GeneratedImage::destroyDecodedData):
  47939. * platform/graphics/Image.h:
  47940. * platform/graphics/ImageSource.h:
  47941. * platform/graphics/cairo/ImageSourceCairo.cpp:
  47942. (WebCore::ImageSource::~ImageSource):
  47943. (WebCore::ImageSource::clear):
  47944. * platform/graphics/cg/ImageSourceCG.cpp:
  47945. (WebCore::ImageSource::~ImageSource):
  47946. (WebCore::ImageSource::clear):
  47947. * platform/graphics/cg/PDFDocumentImage.h:
  47948. (WebCore::PDFDocumentImage::destroyDecodedData):
  47949. * platform/graphics/qt/StillImageQt.h:
  47950. (WebCore::StillImage::destroyDecodedData):
  47951. * platform/image-decoders/ImageDecoder.h:
  47952. (WebCore::RGBA32Buffer::clear):
  47953. (WebCore::ImageDecoder::clearFrameBufferCache):
  47954. * platform/image-decoders/gif/GIFImageDecoder.cpp:
  47955. (WebCore::GIFImageDecoder::repetitionCount):
  47956. (WebCore::GIFImageDecoder::clearFrameBufferCache):
  47957. (WebCore::GIFImageDecoder::initFrameBuffer):
  47958. * platform/image-decoders/gif/GIFImageDecoder.h:
  47959. * platform/image-decoders/gif/GIFImageReader.h:
  47960. (GIFImageReader::GIFImageReader):
  47961. * svg/graphics/SVGImage.h:
  47962. (WebCore::SVGImage::destroyDecodedData):
  47963. 2008-12-15 Cameron Zwarich <zwarich@apple.com>
  47964. Reviewed by Darin Adler.
  47965. Bug 22562: REGRESSION (r37971): events not firing after going back in back/forward cache
  47966. <https://bugs.webkit.org/show_bug.cgi?id=22562>
  47967. <rdar://problem/6414593>
  47968. Restore the Frame's DOMWindow to its previous value when going back in
  47969. the back/forward cache. The fact that it was not getting set before may
  47970. have always caused some subtle bugs with the back/forward cache, but
  47971. after r37971, it causes no events to fire after restoring a page.
  47972. Previously, ScriptController::clearScriptObjects() was calling
  47973. clearPlatformScriptObjects(), which was not actually clearing any
  47974. objects, only updating them to reflect some change in state. Since the
  47975. window shell was not updated until after the call to clearScriptObjects(),
  47976. this didn't actually make that much sense.
  47977. We rename clearPlatformScriptObjects() to reflect its actual purpose and
  47978. call it after the window shell has been updated rather than before.
  47979. Unfortunately, there is no way to test this with a layout test because
  47980. it involves the back/forward cache.
  47981. * bindings/js/ScriptController.cpp:
  47982. (WebCore::ScriptController::updatePlatformScriptObjects): Renamed from
  47983. clearPlatformScriptObjects(), because the only nonempty implementation
  47984. doesn't actually clear any objects, it updates them. Also made public.
  47985. (WebCore::ScriptController::clearScriptObjects): Remove the call to
  47986. clearPlatformScriptObjects().
  47987. * bindings/js/ScriptController.h:
  47988. * bindings/js/ScriptControllerMac.mm:
  47989. (WebCore::ScriptController::updatePlatformScriptObjects):
  47990. * history/CachedPage.cpp:
  47991. (WebCore::CachedPage::domWindow): Added.
  47992. * history/CachedPage.h:
  47993. * loader/FrameLoader.cpp:
  47994. (WebCore::FrameLoader::cancelAndClear): Added call to updatePlatformScriptObjects().
  47995. (WebCore::FrameLoader::begin): Added call to updatePlatformScriptObjects().
  47996. (WebCore::FrameLoader::open): Added call to updatePlatformScriptObjects().
  47997. * page/Frame.cpp:
  47998. (WebCore::Frame::setDOMWindow): Added.
  47999. (WebCore::Frame::pageDestroyed): Added call to updatePlatformScriptObjects().
  48000. * page/Frame.h:
  48001. 2008-12-15 Antti Koivisto <antti@apple.com>
  48002. Reviewed by Darin Adler.
  48003. When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
  48004. https://bugs.webkit.org/show_bug.cgi?id=17998
  48005. - Enable conditional revalidation for reloads by default.
  48006. - Add a parameter to FrameLoader::reload() for forcing end-to-end reload.
  48007. - To avoid duplicating state remove m_cachePolicy variables from FrameLoader and DocLoader.
  48008. Instead synthezise the policy on demand.
  48009. This speeds up reloads and makes them use way less bandwidth.
  48010. * WebCore.base.exp:
  48011. * loader/CachePolicy.h: Rename CachePolicyRefresh to CachePolicyRevalidate.
  48012. (WebCore::):
  48013. * loader/DocLoader.cpp:
  48014. (WebCore::DocLoader::DocLoader):
  48015. (WebCore::DocLoader::checkForReload): Support CachePolicyRevalidate.
  48016. (WebCore::DocLoader::requestResource):
  48017. (WebCore::DocLoader::cachePolicy):
  48018. * loader/DocLoader.h: Get rid of m_cachePolicy member.
  48019. * loader/FrameLoader.cpp:
  48020. (WebCore::ScheduledRedirection::ScheduledRedirection):
  48021. Add parameter to differentiate refresh from other types of redirects.
  48022. m_cachePolicy was used for signaling this before.
  48023. (WebCore::isBackForwardLoadType):
  48024. (WebCore::FrameLoader::FrameLoader):
  48025. (WebCore::FrameLoader::changeLocation):
  48026. (WebCore::FrameLoader::stopLoading):
  48027. (WebCore::FrameLoader::receivedFirstData):
  48028. (WebCore::FrameLoader::write):
  48029. (WebCore::FrameLoader::startIconLoader):
  48030. (WebCore::FrameLoader::restoreDocumentState):
  48031. (WebCore::FrameLoader::scheduleHTTPRedirection):
  48032. (WebCore::FrameLoader::scheduleLocationChange):
  48033. (WebCore::FrameLoader::scheduleRefresh):
  48034. (WebCore::FrameLoader::redirectionTimerFired):
  48035. (WebCore::FrameLoader::canCachePage):
  48036. (WebCore::FrameLoader::loadURL):
  48037. (WebCore::FrameLoader::reload):
  48038. Differentiate between revalidation and reload.
  48039. No need to use setHTTPHeaderField here, addExtraFieldsToRequest will set the headers.
  48040. (WebCore::FrameLoader::transitionToCommitted):
  48041. (WebCore::FrameLoader::cachePolicy): Determine the cache policy based on current load type.
  48042. (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
  48043. (WebCore::FrameLoader::addExtraFieldsToRequest): Set Cache-control: no-cache for FrameLoadTypeReloadFromOrigin
  48044. (WebCore::FrameLoader::shouldScrollToAnchor):
  48045. (WebCore::FrameLoader::loadItem):
  48046. (WebCore::FrameLoader::updateHistoryForReload):
  48047. (WebCore::FrameLoader::updateHistoryForCommit):
  48048. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
  48049. * loader/FrameLoader.h:
  48050. * loader/FrameLoaderTypes.h: Add FrameLoadTypeReloadFromOrigin
  48051. (WebCore::):
  48052. * loader/NavigationAction.cpp:
  48053. (WebCore::navigationType): Support FrameLoadTypeReloadFromOrigin
  48054. * loader/loader.cpp:
  48055. (WebCore::Loader::Host::servePendingRequests):
  48056. 2008-12-15 Holger Hans Peter Freyther <zecke@selfish.org>
  48057. Reviewed by Simon Hausmann.
  48058. Add null checks to PlatformScreenQt
  48059. The other ports do the null checks and JSDOMWindowBase is
  48060. at least one caller that is passing 0.
  48061. * platform/qt/PlatformScreenQt.cpp:
  48062. (WebCore::screenDepth):
  48063. (WebCore::screenDepthPerComponent):
  48064. (WebCore::screenIsMonochrome):
  48065. (WebCore::screenRect):
  48066. (WebCore::screenAvailableRect):
  48067. 2008-12-15 Alexey Proskuryakov <ap@webkit.org>
  48068. Reviewed by Oliver Hunt.
  48069. <rdar://problem/6444455> Worker Thread crash running multiple workers for a moderate amount of time
  48070. * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
  48071. Detach the thread. Without this, one page of its stack was never unmmaped, and fragmentation
  48072. made RegisterFile allocaiton fail after a while.
  48073. 2008-12-13 Darin Adler <darin@apple.com>
  48074. Reviewed by Sam Weinig.
  48075. - half of https://bugs.webkit.org/show_bug.cgi?id=17425
  48076. eliminate DeprecatedPtrList
  48077. * dom/Document.cpp:
  48078. (WebCore::Document::removeImage): Change to set slots in the vector
  48079. to 0 rather than removing items from a list.
  48080. (WebCore::Document::dispatchImageLoadEventsNow): Rewrite to process
  48081. the list. Since we now use a "set to zero" design, we don't need to
  48082. be careful about where the iterator points while iterating the list,
  48083. instead we just have to skip zeros.
  48084. * dom/Document.h: Use Vector instead of DeprecatedPtrList.
  48085. * dom/EventTargetNode.cpp:
  48086. (WebCore::EventTargetNode::dispatchGenericEvent): Use a Vector instead
  48087. of a DeprecatedPtrList for the list of nodes to handle. Also streamlined
  48088. the logic a bit and used goto in a couple key places.
  48089. * dom/Node.cpp:
  48090. (WebCore::Node::eventParentNode): Moved this function into this file
  48091. because it's a virtual function so already can't be inlined. Also updated
  48092. to return a ContainerNode, so it needs to be in a place where the
  48093. definition of ContainerNode is visible, not the header file.
  48094. * dom/Node.h: Changed return type of eventParentNode to ContainerNode
  48095. and moved its definition into the cpp file.
  48096. * dom/XMLTokenizerLibxml2.cpp:
  48097. (WebCore::PendingCallbacks::~PendingCallbacks): Added a call to
  48098. deleteAllValues here instead of setAutoDelete in the constructor, since
  48099. we're using Deque instead of DeprecatedPtrList.
  48100. (WebCore::PendingCallbacks::callAndRemoveFirstCallback): Changed the
  48101. code to use an OwnPtr since the deque won't delete the callback object.
  48102. * editing/ApplyStyleCommand.cpp:
  48103. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use a
  48104. Vector instead of a DeprecatedPtrList.
  48105. * svg/SVGElement.cpp:
  48106. (WebCore::SVGElement::eventParentNode): Moved this function into this file
  48107. because it's a virtual function so already can't be inlined. Also updated
  48108. to return a ContainerNode.
  48109. * svg/SVGElement.h: Changed setShadowParentNode to take a ContainerNode*,
  48110. made eventParentNode return a ContainerNode*, and made m_shadowParent a
  48111. ContainerNode*.
  48112. 2008-12-14 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  48113. Reviewed by George Staikos.
  48114. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22857
  48115. Jumps within a WML deck using <go> task elements fail. Manual reloading
  48116. is necessary to display the page - fix cache-policy in WMLGoElement::executeTask
  48117. to prevent the problem.
  48118. Refactor setActiveCardInDocument in two new functions: findNamedCardInDocument
  48119. and determineActiveCard, to fix a side-effect of executing a <go> task:
  48120. when switching cards within a deck the active card was changed before the load
  48121. was fired which resulted in a flash effect on the screen, and doing unnecessary work.
  48122. Test: wml/go-task-animation.html
  48123. * wml/WMLCardElement.cpp:
  48124. (WebCore::WMLCardElement::findNamedCardInDocument):
  48125. (WebCore::WMLCardElement::determineActiveCard):
  48126. * wml/WMLCardElement.h:
  48127. * wml/WMLDocument.cpp:
  48128. (WebCore::WMLDocument::finishedParsing):
  48129. * wml/WMLGoElement.cpp:
  48130. (WebCore::WMLGoElement::executeTask):
  48131. (WebCore::WMLGoElement::prepareGETRequest):
  48132. * wml/WMLGoElement.h:
  48133. 2008-12-14 Dirk Schulze <krit@webkit.org>
  48134. Reviewed by Oliver Hunt.
  48135. Fixes an issue in cairo. A fully transparent color can cause wrong
  48136. drawings on canvas' composite.
  48137. https://bugs.webkit.org/show_bug.cgi?id=22846
  48138. [CAIRO] Canvas: transparent color and composite
  48139. Test: fast/canvas/canvas-transparency-and-composite.html
  48140. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  48141. (WebCore::GraphicsContext::fillPath):
  48142. (WebCore::GraphicsContext::strokePath):
  48143. 2008-12-13 Julien Chaffraix <jchaffraix@webkit.org>
  48144. Reviewed by Darin Adler.
  48145. Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
  48146. https://bugs.webkit.org/show_bug.cgi?id=22665
  48147. Remove setCreatedByParser from frame and iframe.
  48148. * html/HTMLElementFactory.cpp:
  48149. (WebCore::frameConstructor):
  48150. (WebCore::iframeConstructor):
  48151. (WebCore::objectConstructor):
  48152. * html/HTMLFrameElement.cpp:
  48153. (WebCore::HTMLFrameElement::HTMLFrameElement):
  48154. * html/HTMLFrameElement.h:
  48155. * html/HTMLFrameElementBase.cpp:
  48156. (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
  48157. * html/HTMLFrameElementBase.h:
  48158. * html/HTMLFrameOwnerElement.cpp:
  48159. (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
  48160. * html/HTMLFrameOwnerElement.h:
  48161. (WebCore::HTMLFrameOwnerElement::createdByParser):
  48162. * html/HTMLIFrameElement.cpp:
  48163. (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  48164. * html/HTMLIFrameElement.h:
  48165. * html/HTMLPlugInElement.cpp:
  48166. (WebCore::HTMLPlugInElement::HTMLPlugInElement):
  48167. * html/HTMLTagNames.in:
  48168. 2008-12-13 Alexey Proskuryakov <ap@webkit.org>
  48169. Reviewed by Darin Adler.
  48170. https://bugs.webkit.org/show_bug.cgi?id=22843
  48171. Auto-generate JSWorkerContext
  48172. * bindings/scripts/CodeGeneratorJS.pm:
  48173. * dom/WorkerContext.idl: Added.
  48174. * page/DOMWindow.idl:
  48175. Added ExtendsDOMGlobalObject, a new attribute for behaviors common to DOMWindow and
  48176. WorkerContext.
  48177. * bindings/js/WorkerScriptController.cpp:
  48178. (WebCore::WorkerScriptController::initScript):
  48179. Made JSWorkerContext creation look more like JSDOMWindow creation, to work with generated code.
  48180. * DerivedSources.make:
  48181. * GNUmakefile.am:
  48182. * WebCore.pro:
  48183. * WebCore.scons:
  48184. * WebCore.vcproj/WebCore.vcproj:
  48185. * WebCore.xcodeproj/project.pbxproj:
  48186. * bindings/js/JSWorkerContext.cpp: Removed.
  48187. * bindings/js/JSWorkerContext.h: Removed.
  48188. * bindings/js/JSWorkerContextBase.cpp: Copied from WebCore/bindings/js/JSWorkerContext.cpp.
  48189. (WebCore::JSWorkerContextBase::JSWorkerContextBase):
  48190. (WebCore::JSWorkerContextBase::~JSWorkerContextBase):
  48191. (WebCore::JSWorkerContextBase::scriptExecutionContext):
  48192. (WebCore::getJSWorkerContextBaseTable):
  48193. (WebCore::):
  48194. (WebCore::JSWorkerContextBase::put):
  48195. * bindings/js/JSWorkerContextBase.h: Copied from WebCore/bindings/js/JSWorkerContext.h.
  48196. * bindings/js/JSWorkerContextCustom.cpp: Added.
  48197. (WebCore::JSWorkerContext::customGetOwnPropertySlot):
  48198. (WebCore::JSWorkerContext::mark):
  48199. (WebCore::JSWorkerContext::self):
  48200. (WebCore::JSWorkerContext::setSelf):
  48201. (WebCore::JSWorkerContext::addEventListener):
  48202. (WebCore::JSWorkerContext::removeEventListener):
  48203. Moved code around. Note that currently, JSWorkerContextBase lookup table is empty, but we'll
  48204. need to add some global objects to it in the future, as it is done in JSDOMWindowBase.
  48205. * page/WorkerNavigator.cpp:
  48206. * page/WorkerNavigator.h:
  48207. Added ENABLE(WORKERS) ifdefs.
  48208. 2008-12-13 Darin Adler <darin@apple.com>
  48209. - fix Release build
  48210. * dom/Node.cpp:
  48211. (WebCore::Node::rareData): Remove inappropriate inline directive.
  48212. 2008-12-13 Darin Adler <darin@apple.com>
  48213. Reviewed by Dan Bernstein.
  48214. - fix https://bugs.webkit.org/show_bug.cgi?id=18734
  48215. REGRESSION (r31081): Focus problems in Gmail 2/Plain text message text
  48216. <rdar://problem/5892415>
  48217. Test: fast/forms/textarea-selection-preservation.html
  48218. The regression reported was caused by the fact that the renderer code had
  48219. a bug where it would constantly think the newline at the end of text was
  48220. missing, and so it would replace all the text even though it wasn't changing,
  48221. which would destroy the selection.
  48222. When writing the regression test I discovered another problem: The value
  48223. property in HTMLTextAreaElement was intentionally changing the selection
  48224. to the end of the textarea, but doing that even when the value wasn't changing.
  48225. This patch fixes both and the test checks both.
  48226. * html/HTMLTextAreaElement.cpp:
  48227. (WebCore::HTMLTextAreaElement::setValue): Exit early if the value is
  48228. not changing.
  48229. * rendering/RenderTextControl.cpp:
  48230. (WebCore::RenderTextControl::text): Add a newline character for each <br>
  48231. element encountered in the control
  48232. 2008-12-13 Darin Adler <darin@apple.com>
  48233. - file deletion part of https://bugs.webkit.org/show_bug.cgi?id=17497
  48234. eliminate DeprecatedValueList
  48235. * GNUmakefile.am: Removed references to deleted files.
  48236. * WebCore.pro: Ditto.
  48237. * WebCore.scons: Ditto.
  48238. * WebCore.vcproj/WebCore.vcproj: Ditto.
  48239. * WebCore.xcodeproj/project.pbxproj: Ditto.
  48240. * WebCoreSources.bkl: Ditto.
  48241. * platform/DeprecatedPtrQueue.h: Removed.
  48242. * platform/DeprecatedValueList.h: Removed.
  48243. * platform/DeprecatedValueListImpl.cpp: Removed.
  48244. * platform/DeprecatedValueListImpl.h: Removed.
  48245. 2008-12-13 Darin Adler <darin@apple.com>
  48246. Reviewed by Anders Carlsson.
  48247. - https://bugs.webkit.org/show_bug.cgi?id=17497
  48248. eliminate DeprecatedValueList
  48249. * css/CSSStyleDeclaration.cpp: Removed unneeded include.
  48250. * dom/Document.cpp:
  48251. (WebCore::Document::removeAllEventListenersFromAllNodes):
  48252. Set the removed flag on the window event listeners in case we
  48253. are in the middle of dispatching events on this window.
  48254. (WebCore::Document::clear): Ditto.
  48255. (WebCore::Document::handleWindowEvent): Changed to use a vector
  48256. instead of a DeprecatedPtrList.
  48257. (WebCore::Document::windowInlineEventListenerForType): Ditto.
  48258. (WebCore::Document::removeWindowInlineEventListenerForType): Ditto.
  48259. Also added a call to setRemoved, which is needed here just as in
  48260. other functions that remove.
  48261. (WebCore::Document::removeWindowEventListener): Ditto.
  48262. (WebCore::Document::hasWindowEventListener): Ditto.
  48263. * dom/Document.h: Changed RegisteredEventListenerList to
  48264. RegisteredEventListeners.
  48265. * dom/Element.cpp:
  48266. (WebCore::Element::attach): Use a function to access rare data instead
  48267. of getting directly at the data field.
  48268. (WebCore::Element::focus): Ditto.
  48269. (WebCore::Element::cancelFocusAppearanceUpdate): Ditto.
  48270. * dom/ElementRareData.h: Use "using" to make things that are protected
  48271. in NodeRareData be public here.
  48272. * dom/EventTarget.h: Removed include of DeprecatedValueList and
  48273. related declearations that weren't needed. Tweaked the definitions
  48274. of the forbidEventDispatch functions too.
  48275. * dom/EventTargetNode.cpp:
  48276. (WebCore::EventTargetNode::EventTargetNode): Eliminated code that
  48277. was used to initialized m_regdListeners.
  48278. (WebCore::EventTargetNode::~EventTargetNode): Elminated delete of
  48279. m_regdListeners. Changed code to use eventListeners() instead of
  48280. m_regdListeners.
  48281. (WebCore::EventTargetNode::eventListeners): Added.
  48282. (WebCore::EventTargetNode::insertedIntoDocument): Use eventListeners.
  48283. (WebCore::EventTargetNode::removedFromDocument): Ditto.
  48284. (WebCore::EventTargetNode::willMoveToNewOwnerDocument): Ditto.
  48285. (WebCore::EventTargetNode::didMoveToNewOwnerDocument): Ditto.
  48286. (WebCore::EventTargetNode::addEventListener): Ditto.
  48287. (WebCore::EventTargetNode::removeEventListener): Ditto.
  48288. (WebCore::EventTargetNode::removeAllEventListeners): Ditto.
  48289. Also added code to call setRemoved on all the listeners.
  48290. (WebCore::EventTargetNode::handleLocalEvents): Ditto.
  48291. (WebCore::EventTargetNode::dispatchGenericEvent): Fixed indentation.
  48292. (WebCore::EventTargetNode::removeInlineEventListenerForType): Use
  48293. the new event listeners vector. Also added missing call to setRemoved.
  48294. (WebCore::EventTargetNode::inlineEventListenerForType): Ditto.
  48295. * dom/EventTargetNode.h: Added a new RegisteredEventListenerVector
  48296. type and replaced the old localEventListeners function with a new
  48297. eventListeners function. Removed m_regdListeners.
  48298. * dom/Node.cpp:
  48299. (WebCore::Node::childNodes): Removed unneeded std prefix.
  48300. (WebCore::Node::setFocus): Use function instead of going directly
  48301. at rare data.
  48302. (WebCore::Node::rareDataFocused): Ditto.
  48303. (WebCore::Node::registerDynamicNodeList): Removed unneeded std prefix.
  48304. (WebCore::Node::getElementsByName): Ditto.
  48305. (WebCore::Node::getElementsByClassName): Ditto.
  48306. (WebCore::Node::compareDocumentPosition): Ditto.
  48307. * dom/Node.h: Removed unneeded forward declaration of
  48308. RegisteredEventListener. This is now in EventTargetNode.
  48309. * dom/NodeRareData.h: Renamed m_focused to m_isFocused and made it
  48310. private. Made m_needsFocusAppearanceUpdateSoonAfterAttach private.
  48311. Added listeners and ensureListeners functions as well as isFocused,
  48312. setFocused, and focus-appearance functions. Made all data members private.
  48313. * dom/RegisteredEventListener.cpp: Removed operator ==.
  48314. * dom/RegisteredEventListener.h: Removed operator == and !=.
  48315. * svg/SVGElement.cpp:
  48316. (WebCore::hasLoadListener): Rewrote to work with the vector.
  48317. * svg/SVGUseElement.cpp:
  48318. (WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
  48319. 2008-12-13 Holger Hans Peter Freyther <zecke@selfish.org>
  48320. Reviewed by Dan Bernstein.
  48321. https://bugs.webkit.org/show_bug.cgi?id=22824
  48322. Change ENABLE(FONT_FAST_PATH) to USE(FONT_FAST_PATH). With r39206
  48323. floatWidth always used the complex path causing a regression
  48324. in the pixel tests.
  48325. * platform/graphics/Font.cpp:
  48326. (WebCore::Font::floatWidth): Use the fast path again
  48327. 2008-12-13 Dirk Schulze <krit@webkit.org>
  48328. Reviewed by Darin Adler.
  48329. Fixes behavior of gradients on empty path in canvas/Cg
  48330. https://bugs.webkit.org/show_bug.cgi?id=22844
  48331. [Cg] Canvas fill() draws gradients even without a path
  48332. Test: fast/canvas/canvas-gradient-without-path.html
  48333. * html/CanvasRenderingContext2D.cpp:
  48334. (WebCore::CanvasRenderingContext2D::fill):
  48335. (WebCore::CanvasRenderingContext2D::stroke):
  48336. 2008-12-13 Kevin Ollivier <kevino@theolliviers.com>
  48337. wx build fix.
  48338. * platform/graphics/wx/ImageSourceWx.cpp:
  48339. (WebCore::ImageSource::filenameExtension):
  48340. 2008-12-12 Brent Fulgham <bfulgham@gmail.com>
  48341. Reviewed by Oliver Hunt.
  48342. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
  48343. Provides implementation of image dragging logic for Windows Cairo
  48344. back-end.
  48345. * platform/win/DragImageCGWin.cpp:
  48346. (WebCore::deallocContext): Add a generic CGContextRef destructor.
  48347. * platform/win/DragImageCairoWin.cpp:
  48348. (WebCore::deallocContext): Add a generic cairo_* destructor.
  48349. (WebCore::allocImage): New implementation to allocate a Cairo
  48350. surface of a specified size.
  48351. (WebCore::createCairoContextFromBitmap): New implementation to
  48352. create a Cairo surface from a Windows BITMAP.
  48353. (WebCore::scaleDragImage): Replace stub with implementation to
  48354. actually create a scaled image.
  48355. (WebCore::createDragImageFromImage): Replace stub with implementation
  48356. to actually create an image.
  48357. 2008-12-12 Dean Jackson <dino@apple.com>
  48358. Reviewed by Darin Adler.
  48359. Expose WebKitAnimationEvent, WebKitTransitionEvent,
  48360. WebKitCSSTransformValue, WebKitCSSKeyframeRule and
  48361. WebKitCSSKeyframesRule to Window object.
  48362. This required generating constructors for the event
  48363. interfaces.
  48364. https://bugs.webkit.org/show_bug.cgi?id=20560
  48365. * dom/WebKitAnimationEvent.idl:
  48366. * dom/WebKitTransitionEvent.idl:
  48367. * page/DOMWindow.idl:
  48368. 2008-12-12 Dave Moore <davemoore@google.com>
  48369. Reviewed by Eric Seidel.
  48370. Fixed https://bugs.webkit.org/show_bug.cgi?id=22798
  48371. In Font::drawTextUsingSVGFont() a variable of type SVGTextRunWalkerDrawTextData
  48372. is created on the stack (called data). One of its fields, charsConsumed, is
  48373. unitialized, leading to random values after calling walk() on the
  48374. SVGTextRunWalker created with it. I now initialize the variable
  48375. This bug was revealed in our Purify run. I don't know of any specific incorrect
  48376. behavior caused by it but it would lead to the charsConsumed field having a
  48377. a wrong value.
  48378. * svg/SVGFont.cpp:
  48379. (WebCore::Font::drawTextUsingSVGFont):
  48380. 2008-12-12 Beth Dakin <bdakin@apple.com>
  48381. Rubber Stamped by Steve Falkenburg.
  48382. Build fix.
  48383. * platform/KURL.h:
  48384. 2008-12-12 Brett Wilson <brettw@chromium.org>
  48385. Reviewed by Darin Adler.
  48386. Add the ability so that Google-URL can optionally be used in a build
  48387. of WebKit without changing the shared header. The guts of KURL are
  48388. optionally ifdefed out, and the replacement code goes in a different
  48389. header to avoid polluting KURL.h
  48390. * platform/KURL.cpp:
  48391. * platform/KURL.h:
  48392. (WebCore::KURL::string):
  48393. (WebCore::KURL::operator const String&):
  48394. (WebCore::KURL::operator JSC::UString):
  48395. (WebCore::KURL::operator NSString*):
  48396. (WebCore::KURL::parsed):
  48397. (WebCore::KURL::utf8String):
  48398. (WebCore::KURL::isNull):
  48399. (WebCore::KURL::isEmpty):
  48400. (WebCore::KURL::isValid):
  48401. (WebCore::KURL::hostStart):
  48402. (WebCore::KURL::hostEnd):
  48403. (WebCore::KURL::pathStart):
  48404. (WebCore::KURL::pathEnd):
  48405. (WebCore::KURL::pathAfterLastSlash):
  48406. 2008-12-11 Steve Falkenburg <sfalken@apple.com>
  48407. Delete the previous timer-queue timer in the main thread, just prior to scheduling a new timer.
  48408. The code previously called DeleteTimerQueueTimer in the timer callback proc.
  48409. The new technique simplifies the code, since we now create and delete timers on the
  48410. same thread, and don't access the timer queue or timer handles in the callback.
  48411. This allows us to remove some mutex use, and more importantly, it solves a race
  48412. condition that was occuring between ChangeTimerQueueTimer and DeleteTimerQueueTimer.
  48413. Since the timer callback isn't passed the timer handle, we were retrieving that handle
  48414. via a global. If the timer callback code was entered, but then a new timer was immediately
  48415. scheduled (prior to the callback acquiring the mutex and calling DeleteTimerQueueTimer),
  48416. there was a small window where the timer could be re-scheduled via ChangeTimerQueueTimer
  48417. and then immediately deleted once the already running callback acquired the mutex and
  48418. then called DeleteTimerQueueTimer. This resulted in the newly scheduled timer never firing.
  48419. Reviewed by Oliver Hunt.
  48420. * platform/win/SharedTimerWin.cpp:
  48421. (WebCore::queueTimerProc): Don't delete the timer in the callback.
  48422. (WebCore::setSharedTimerFireTime): Always delete and create the timer instead of using ChangeTimerQueueTimer.
  48423. (WebCore::stopSharedTimer): Call DeleteTimerQueueTimer directly.
  48424. 2008-12-12 Kai Brüning <kai@granus.net>
  48425. Reviewed and tweaked by Darin Adler.
  48426. - fix https://bugs.webkit.org/show_bug.cgi?id=18205
  48427. DOMNode objects are garbage collected although there are strong references
  48428. <rdar://problem/6441200>
  48429. Fixes resurrection bug for wrapper objects by using an NSMapTable with zeroing weak
  48430. memory for the wrapper reference for DOMWrapperCache (DOMInternal.mm),
  48431. JSWrapperCache (WebScriptObject.mm) and wrapperCache (DOMRGBColor.mm).
  48432. BUILDING_ON_TIGER is used to create a Leopard-only NSMapTable or an old-style
  48433. procedural map table for Tiger systems.
  48434. No regression tests yet since we don't currently run any tests in GC mode.
  48435. * bindings/objc/DOMInternal.h: added WebCore::createWrapperCache for use by all three caches
  48436. * bindings/objc/DOMInternal.mm:
  48437. (WebCore::createWrapperCache): Contains the compile-time check for map table creation
  48438. (WebCore::getDOMWrapper): HashMap -> NSMapTable
  48439. (WebCore::addDOMWrapper): ditto
  48440. (WebCore::removeDOMWrapper): ditto
  48441. * bindings/objc/DOMObject.mm: removed [DOMObject finalize]
  48442. * bindings/objc/DOMRGBColor.mm: removed [DOMRGBColor finalize]
  48443. (WebCore::getWrapperForRGB): CFMutableDictionaryRef -> NSMapTable
  48444. (WebCore::setWrapperForRGB): ditto
  48445. (WebCore::removeWrapperForRGB): ditto
  48446. * bindings/objc/WebScriptObject.mm:
  48447. (WebCore::getJSWrapper): HashMap -> NSMapTable
  48448. (WebCore::addJSWrapper): ditto
  48449. (WebCore::removeJSWrapper): ditto
  48450. (-[WebScriptObject finalize]): removed call of removeJSWrapper()
  48451. 2008-12-12 Dimitri Glazkov <dglazkov@chromium.org>
  48452. Reviewed by Alexey Proskuryakov.
  48453. https://bugs.webkit.org/show_bug.cgi?id=22813
  48454. Remove unused references to JSDOMBinding, CallFrame, and JSLock.
  48455. * dom/Node.cpp: Removed CallFrame and JSLock header includes.
  48456. * loader/FrameLoader.cpp: Removed JSDOMBinding header include.
  48457. 2008-12-12 Holger Hans Peter Freyther <zecke@selfish.org>
  48458. Reviewed by Simon Hausmann.
  48459. Update the WebKit.qrc and add a script to automatically generate the file.
  48460. With the way rcc and qmake work this can not be done at build time
  48461. as the WebKit.qrc must sit inside the directory that contains the files
  48462. and at build time we may not change the content of the source directory.
  48463. * inspector/front-end/WebKit.qrc: Updated with new script
  48464. 2008-12-12 Oliver Hunt <oliver@apple.com>
  48465. Reviewed by Alexey Proskuryakov.
  48466. REGRESSION: Canvas is broken in high dpi mode
  48467. <rdar://problem/6432739> <https://bugs.webkit.org/show_bug.cgi?id=22823>
  48468. Simply made sure that we correctly scale the graphics context to
  48469. account for the difference between logical and buffer resolution.
  48470. * html/HTMLCanvasElement.cpp:
  48471. (WebCore::HTMLCanvasElement::createImageBuffer):
  48472. (WebCore::HTMLCanvasElement::baseTransform):
  48473. 2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
  48474. Rubber-stamped by Oliver Hunt.
  48475. Share PluginView::paintMissingPluginIcon() between ports
  48476. Also, enable this feature for Qt/X11, Qt/Mac and GTK
  48477. * plugins/PluginView.cpp:
  48478. (WebCore::PluginView::paintMissingPluginIcon):
  48479. * plugins/gtk/PluginViewGtk.cpp:
  48480. (WebCore::PluginView::paint):
  48481. * plugins/mac/PluginViewMac.cpp:
  48482. (WebCore::PluginView::paint):
  48483. * plugins/qt/PluginViewQt.cpp:
  48484. (WebCore::PluginView::paint):
  48485. * plugins/win/PluginViewWin.cpp:
  48486. 2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
  48487. Reviewed by Simon Hausmann.
  48488. [Qt/Mac] Implement PluginView::updatePluginWidget()
  48489. We should update the window and clip rect regardless of whether or
  48490. not the plugin has been loaded, for example to ensure that the
  48491. missing plugin image is placed correctly.
  48492. * plugins/mac/PluginViewMac.cpp:
  48493. (WebCore::PluginView::setNPWindowIfNeeded):
  48494. (WebCore::PluginView::updatePluginWidget):
  48495. 2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
  48496. Rubber-stamped by Oliver Hunt.
  48497. Make PluginView::updatePluginWidget() non-const
  48498. We can do this now since frameRectsChanged() is no longer const. This
  48499. also allows us to get rid of the mutables in the PluginView.
  48500. * platform/qt/TemporaryLinkStubs.cpp:
  48501. (PluginView::updatePluginWidget):
  48502. * plugins/PluginView.h:
  48503. * plugins/gtk/PluginViewGtk.cpp:
  48504. (WebCore::PluginView::updatePluginWidget):
  48505. * plugins/mac/PluginViewMac.cpp:
  48506. (WebCore::PluginView::updatePluginWidget):
  48507. * plugins/qt/PluginViewQt.cpp:
  48508. (WebCore::PluginView::updatePluginWidget):
  48509. * plugins/win/PluginViewWin.cpp:
  48510. (WebCore::PluginView::updatePluginWidget):
  48511. * plugins/wx/PluginViewWx.cpp:
  48512. (WebCore::PluginView::updatePluginWidget):
  48513. 2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
  48514. Reviewed by Simon Hausmann.
  48515. Implement ImageSource::filenameExtension() for the Qt port
  48516. We're using QImageReader::imageFormat().toLower() to check
  48517. that the image format is supported, and if it is we store
  48518. the resulting extension when creating the ImageDecoderQt.
  48519. * platform/graphics/qt/ImageDecoderQt.cpp:
  48520. (WebCore::ImageDecoderQt::create):
  48521. (WebCore::ImageDecoderQt::ImageDecoderQt):
  48522. (WebCore::ImageDecoderQt::imageFormat):
  48523. * platform/graphics/qt/ImageDecoderQt.h:
  48524. * platform/graphics/qt/ImageSourceQt.cpp:
  48525. (WebCore::ImageSource::setData):
  48526. (WebCore::ImageSource::filenameExtension):
  48527. 2008-12-11 Stephanie Lewis <slewis@apple.com>
  48528. Reviewed by Geoff Garen
  48529. Account for the size of the response and request headers as well as other overhead
  48530. when calculating the size a resource takes up in the cache. Halts unbounded
  48531. growth in the cache. Reduced stress test memory high water marks by > 50%.
  48532. Uses estimates gathered from the stress test to set the overhead size.
  48533. A version of the patch was created that calculated most of the sizes, but it was
  48534. decided that the patch was still at a basic level an estimate. What gains it made
  48535. in accuracy was offset by the complexity involved in creating and updating the
  48536. estimate.
  48537. * loader/Cache.cpp:
  48538. (WebCore::Cache::resourceAccessed):
  48539. (WebCore::Cache::TypeStatistic::addResource):
  48540. (WebCore::Cache::dumpLRULists):
  48541. * loader/CachedResource.cpp:
  48542. (WebCore::CachedResource::overheadSize):
  48543. * loader/CachedResource.h:
  48544. (WebCore::CachedResource::size):
  48545. 2008-12-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  48546. Reviewed by Holger Freyther.
  48547. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22814
  48548. Add <wml> image element support. Based on HTML/SVGImage{Element/Loader}, with
  48549. the only difference that WML defines a second source attribute 'localsrc', that
  48550. takes precedence over the 'src' attribute. If loading the 'localsrc' attribute
  48551. fails, the user agent should try loading the 'src' attribute. If both fail the
  48552. 'alt' fallback content will be used - just like in HTML.
  48553. Fixes: fast/wml/img-localsrc.wml (<img> and 'localsrc' attribute)
  48554. fast/wml/img-src-localsrc-alt.wml ('localsrc'/'src' fallback handling)
  48555. fast/wml/img-src.wml (<img> and 'src' attribute)
  48556. * GNUmakefile.am:
  48557. * WebCore.vcproj/WebCore.vcproj:
  48558. * WebCore.xcodeproj/project.pbxproj:
  48559. * rendering/HitTestResult.cpp:
  48560. (WebCore::HitTestResult::altDisplayString):
  48561. (WebCore::HitTestResult::absoluteImageURL):
  48562. * rendering/RenderImage.cpp:
  48563. (WebCore::RenderImage::updateAltText):
  48564. * wml/WMLImageElement.cpp: Added.
  48565. (WebCore::WMLImageElement::WMLImageElement):
  48566. (WebCore::WMLImageElement::~WMLImageElement):
  48567. (WebCore::WMLImageElement::mapToEntry):
  48568. (WebCore::WMLImageElement::parseMappedAttribute):
  48569. (WebCore::WMLImageElement::attach):
  48570. (WebCore::WMLImageElement::createRenderer):
  48571. (WebCore::WMLImageElement::insertedIntoDocument):
  48572. (WebCore::WMLImageElement::isURLAttribute):
  48573. (WebCore::WMLImageElement::imageSourceAttributeName):
  48574. (WebCore::WMLImageElement::altText):
  48575. * wml/WMLImageElement.h: Added.
  48576. (WebCore::WMLImageElement::useFallbackAttribute):
  48577. (WebCore::WMLImageElement::setUseFallbackAttribute):
  48578. * wml/WMLImageLoader.cpp: Added.
  48579. (WebCore::WMLImageLoader::WMLImageLoader):
  48580. (WebCore::WMLImageLoader::~WMLImageLoader):
  48581. (WebCore::WMLImageLoader::dispatchLoadEvent):
  48582. (WebCore::WMLImageLoader::sourceURI):
  48583. (WebCore::WMLImageLoader::notifyFinished):
  48584. * wml/WMLImageLoader.h: Added.
  48585. * wml/WMLTagNames.in:
  48586. 2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
  48587. Reviewed by Darin Adler.
  48588. https://bugs.webkit.org/show_bug.cgi?id=22043
  48589. Do not run into the WebCore::DocumentLoader::updateLoading
  48590. ASSERT on Gtk+/CURL when trying to load tests from our LayoutTests.
  48591. Do not call setPrimaryLoadComplete when the
  48592. activeDocumentLoader has already been replaced. This can happen
  48593. when a script executed from within FramerLoader::didFinishLoading will
  48594. navigate to another URL.
  48595. The assertion is caused by existing tests (e.g.
  48596. fast/history/clicked-link-is-visited.html) reproducing this with
  48597. network backends not equal to curl is tough or maybe not
  48598. even possible.
  48599. * loader/DocumentLoader.cpp:
  48600. (WebCore::DocumentLoader::setPrimaryLoadComplete):
  48601. 2008-12-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  48602. Reviewed by Eric Seidel.
  48603. - Remove some dead, commented-out code from WMLAElement.
  48604. - Add missing virtual destructor for <noop>, as suggested by Alexey.
  48605. - Refactor addHTMLAlignment in a static helper function to share with WML.
  48606. * html/HTMLElement.cpp:
  48607. (WebCore::HTMLElement::addHTMLAlignment):
  48608. (WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
  48609. * html/HTMLElement.h:
  48610. * wml/WMLAElement.cpp:
  48611. (WebCore::WMLAElement::defaultEventHandler):
  48612. * wml/WMLNoopElement.cpp:
  48613. (WebCore::WMLNoopElement::~WMLNoopElement):
  48614. * wml/WMLNoopElement.h:
  48615. 2008-12-10 Oliver Hunt <oliver@apple.com>
  48616. Reviewed by Adele Peterson.
  48617. <rdar://problem/6302405> Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG
  48618. <https://bugs.webkit.org/show_bug.cgi?id=22804>
  48619. This issue was caused by css generated content resulting in non-svg flowboxes
  48620. being injected into SVG content. As SVG spec does not describe behaviour in
  48621. this case, and neither Opera nor Firefox displays such generated content, so
  48622. now we make svg text layout and rendering just ignore any such content.
  48623. Test: svg/css/crash-css-generated-content.xhtml
  48624. * rendering/SVGRootInlineBox.cpp:
  48625. (WebCore::SVGRootInlineBox::buildLayoutInformation):
  48626. (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  48627. (WebCore::SVGRootInlineBox::buildTextChunks):
  48628. 2008-12-11 Cameron Zwarich <zwarich@apple.com>
  48629. Reviewed by Dave Hyatt.
  48630. Bug 21256: REGRESSION (r36906): horizontally repeating image leaves ghosts when vertical scrolling
  48631. <https://bugs.webkit.org/show_bug.cgi?id=21256>
  48632. <rdar://problem/6362978>
  48633. The ScrollView refactoring in r36906 caused the ScrollView and the
  48634. platform widget to disagree about whether optimizing scrolling via
  48635. blitting is allowed. The easiest way to fix this is to make ScrollView
  48636. simply ask the platform widget whether this is safe on platforms that
  48637. are affected.
  48638. It is not possible to write a layout test for this bug because it
  48639. involves the back/forward cache.
  48640. * platform/ScrollView.cpp:
  48641. (WebCore::ScrollView::ScrollView):
  48642. (WebCore::ScrollView::setCanBlitOnScroll):
  48643. (WebCore::ScrollView::canBlitOnScroll):
  48644. (WebCore::ScrollView::platformSetCanBlitOnScroll):
  48645. (WebCore::ScrollView::platformCanBlitOnScroll):
  48646. * platform/ScrollView.h:
  48647. * platform/mac/ScrollViewMac.mm:
  48648. (WebCore::ScrollView::platformSetCanBlitOnScroll):
  48649. (WebCore::ScrollView::platformCanBlitOnScroll):
  48650. * platform/wx/ScrollViewWx.cpp:
  48651. (WebCore::ScrollView::platformSetCanBlitOnScroll):
  48652. (WebCore::ScrollView::platformCanBlitOnScroll):
  48653. 2008-12-11 Brent Fulgham <bfulgham@gmail.com>
  48654. Reviewed by Adam Roben.
  48655. https://bugs.webkit.org/show_bug.cgi?id=22808
  48656. Correct build break due to malformed XML in Visual Studio project
  48657. following @r39205 change.
  48658. * WebCore.vcproj/WebCore.vcproj: Correct file entry so project loads.
  48659. 2008-12-10 Chris Marrin <cmarrin@apple.com>
  48660. Reviewed by Dave Hyatt.
  48661. Fixed https://bugs.webkit.org/show_bug.cgi?id=22738
  48662. This gets rid of the per-animation timers which were used when an animation
  48663. started, ended and looped. Their job is now done by the main AnimationController's
  48664. timer. It is now set to fire as needed. For instance, if there is a delay, it will
  48665. fire after the delay time and then every 30ms to run the animation. The start, loop
  48666. and end events are generated as needed during the firing of this timer.
  48667. I had to add one more bit of code. When animation timers used to fire the animation events.
  48668. This would always happen from the RunLoop, so any style changes that happened in the
  48669. event handler would get picked up on the next updateRendering() call. But now the start
  48670. event is generated during the styleIsAvailable() call, which is in the middle of the
  48671. updateRendering() cycle. And calling an event handler in the middle of updateRendering()
  48672. is not allowed and causes style changes to get missed. We already have a mechanism in
  48673. AnimationController to defer updateRendering() calls. So I added logic to defer all
  48674. event handling to there. Now, I put any request for event handling into a list and ask
  48675. for a deferred updateRendering() call. When that deferred timer fires, I go through that
  48676. list, send all the events and then call updateRendering().
  48677. * page/animation/AnimationBase.cpp:
  48678. (WebCore::AnimationBase::AnimationBase):
  48679. (WebCore::AnimationBase::updateStateMachine):
  48680. (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
  48681. (WebCore::AnimationBase::willNeedService):
  48682. (WebCore::AnimationBase::goIntoEndingOrLoopingState):
  48683. * page/animation/AnimationBase.h:
  48684. * page/animation/AnimationController.cpp:
  48685. (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  48686. (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
  48687. (WebCore::AnimationControllerPrivate::addEventToDispatch):
  48688. (WebCore::AnimationControllerPrivate::animationTimerFired):
  48689. (WebCore::AnimationController::addEventToDispatch):
  48690. * page/animation/AnimationController.h:
  48691. * page/animation/CompositeAnimation.cpp:
  48692. (WebCore::CompositeAnimationPrivate::updateTransitions):
  48693. (WebCore::CompositeAnimationPrivate::willNeedService):
  48694. (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
  48695. (WebCore::CompositeAnimation::willNeedService):
  48696. (WebCore::CompositeAnimation::getAnimationForProperty):
  48697. * page/animation/CompositeAnimation.h:
  48698. * page/animation/ImplicitAnimation.cpp:
  48699. (WebCore::ImplicitAnimation::animate):
  48700. (WebCore::ImplicitAnimation::onAnimationEnd):
  48701. (WebCore::ImplicitAnimation::sendTransitionEvent):
  48702. * page/animation/ImplicitAnimation.h:
  48703. * page/animation/KeyframeAnimation.cpp:
  48704. (WebCore::KeyframeAnimation::animate):
  48705. (WebCore::KeyframeAnimation::sendAnimationEvent):
  48706. * page/animation/KeyframeAnimation.h:
  48707. (WebCore::KeyframeAnimation::setUnanimatedStyle):
  48708. 2008-12-11 Simon Hausmann <simon.hausmann@nokia.com>
  48709. Fix the Qt build with an empty filenameExtension() implementation.
  48710. * platform/graphics/qt/ImageSourceQt.cpp:
  48711. (WebCore::ImageSource::filenameExtension):
  48712. 2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
  48713. Reviewed by Simon Hausmann.
  48714. Fix crash in the cairo implementation of the SVGPaintServer
  48715. For SVGFonts the RenderObject can be zero. The existing SVGFont
  48716. test cases is exposing this bug. Qt and other ports have fixed
  48717. this issue by adding null checks as well.
  48718. * svg/graphics/cairo/SVGPaintServerCairo.cpp:
  48719. (WebCore::SVGPaintServer::renderPath):
  48720. 2008-12-11 Holger Freyther <zecke@selfish.org>
  48721. Reviewed by Simon Hausmann.
  48722. https://bugs.webkit.org/show_bug.cgi?id=20953
  48723. Make the Qt port follow the Win, Mac, Gtk+ port in regard to Font
  48724. handling. FontQt.cpp from now on is only implementing the complex path. Create
  48725. FontFallbackListQt.cpp and FontPlatformDataQt.cpp to work within
  48726. the framework set by the Font code.
  48727. Sharing the Font.cpp implementation allows the Qt port to support
  48728. the CSS font faces and SVG fonts.
  48729. Split out the Qt4.3 Font handling into FonQt43.cpp to allow to more
  48730. easily deprecate it.
  48731. This commit is removing a lot of #ifdefs from Font.h as the Qt Font
  48732. implementation is now in line with the rest of WebCore.
  48733. * WebCore.pro:
  48734. * platform/graphics/Font.h: Remove #ifdefs
  48735. (WebCore::Font::letterSpacing):
  48736. (WebCore::Font::setLetterSpacing):
  48737. (WebCore::Font::isPlatformFont):
  48738. * platform/graphics/FontFallbackList.h:
  48739. * platform/graphics/SimpleFontData.cpp:
  48740. (WebCore::SimpleFontData::SimpleFontData):
  48741. (WebCore::SimpleFontData::platformGlyphInit): There is no GlyphCache
  48742. on Qt, move the initialisation over.
  48743. (WebCore::SimpleFontData::~SimpleFontData):
  48744. * platform/graphics/SimpleFontData.h:
  48745. (WebCore::SimpleFontData::getQtFont):
  48746. * platform/graphics/qt/FontCacheQt.cpp:
  48747. (WebCore::FontCache::getCachedFontPlatformData): Remove unused parameter
  48748. (WebCore::FontCache::releaseFontData): Add to build
  48749. * platform/graphics/qt/FontCustomPlatformData.cpp:
  48750. (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
  48751. (WebCore::FontCustomPlatformData::fontPlatformData):
  48752. (WebCore::createFontCustomPlatformData):
  48753. * platform/graphics/qt/FontCustomPlatformData.h:
  48754. * platform/graphics/qt/FontFallbackListQt.cpp: Added.
  48755. (WebCore::FontFallbackList::FontFallbackList):
  48756. (WebCore::FontFallbackList::invalidate):
  48757. (WebCore::FontFallbackList::releaseFontData):
  48758. (WebCore::FontFallbackList::determinePitch):
  48759. (WebCore::FontFallbackList::fontDataAt):
  48760. (WebCore::FontFallbackList::fontDataForCharacters):
  48761. (WebCore::FontFallbackList::setPlatformFont):
  48762. * platform/graphics/qt/FontPlatformData.h:
  48763. (WebCore::FontPlatformData::font):
  48764. (WebCore::FontPlatformData::size):
  48765. * platform/graphics/qt/FontPlatformDataQt.cpp: Added.
  48766. (WebCore::FontPlatformData::FontPlatformData):
  48767. * platform/graphics/qt/FontQt.cpp:
  48768. (WebCore::Font::drawComplexText):
  48769. (WebCore::Font::floatWidthForComplexText):
  48770. (WebCore::Font::offsetForPositionForComplexText):
  48771. (WebCore::Font::selectionRectForComplexText):
  48772. (WebCore::Font::font):
  48773. * platform/graphics/qt/FontQt43.cpp: Added. Moved Qt4.3 code from FontQt.cpp
  48774. (WebCore::Font::drawComplexText):
  48775. (WebCore::Font::floatWidthForComplexText):
  48776. (WebCore::Font::offsetForPositionForComplexText):
  48777. (WebCore::Font::selectionRectForComplexText):
  48778. * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
  48779. (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
  48780. (WebCore::GlyphPageTreeNode::pruneTreeFontData):
  48781. * platform/graphics/qt/SimpleFontDataQt.cpp:
  48782. (WebCore::SimpleFontData::determinePitch):
  48783. (WebCore::SimpleFontData::containsCharacters):
  48784. (WebCore::SimpleFontData::platformInit):
  48785. (WebCore::SimpleFontData::platformGlyphInit):
  48786. (WebCore::SimpleFontData::platformDestroy):
  48787. * platform/qt/RenderThemeQt.cpp:
  48788. (WebCore::RenderThemeQt::adjustButtonStyle): Avoid crashes.
  48789. 2008-12-11 Holger Freyther <zecke@selfish.org>
  48790. Reviewed by Simon Hausmann.
  48791. https://bugs.webkit.org/show_bug.cgi?id=20953
  48792. For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
  48793. implementation. This is one of the reasons why the Qt port is currently not
  48794. using WebCore/platform/graphics/Font.cpp. By allowing to not use
  48795. the simple/fast-path the Qt port will be able to use it.
  48796. Introduce USE(FONT_FAST_PATH) and define it for every port but the
  48797. Qt one.
  48798. * platform/graphics/Font.cpp:
  48799. (WebCore::Font::drawText):
  48800. (WebCore::Font::floatWidth):
  48801. (WebCore::Font::selectionRectForText):
  48802. (WebCore::Font::offsetForPosition):
  48803. * platform/graphics/Font.h:
  48804. 2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
  48805. Reviewed by Darin Adler.
  48806. https://bugs.webkit.org/show_bug.cgi?id=20953
  48807. Split out the font fast path from Fast.cpp into FontFastPath.cpp. This
  48808. will allow the Qt port to share most of WebCore::Font
  48809. implementation but the fast path. Qt does not provide the API to get
  48810. individual Glyphs making the fast path hard to support.
  48811. * GNUmakefile.am:
  48812. * WebCore.vcproj/WebCore.vcproj:
  48813. * WebCore.xcodeproj/project.pbxproj:
  48814. * WebCoreSources.bkl:
  48815. * platform/graphics/Font.cpp:
  48816. * platform/graphics/FontFastPath.cpp: Added.
  48817. (WebCore::Font::glyphDataForCharacter):
  48818. 2008-12-11 Robert Carr <racarr@svn.gnome.org>
  48819. Reviewed by Holger Freyther.
  48820. https://bugs.webkit.org/show_bug.cgi?id=22560
  48821. Code in PlatformScreenGtk for screenDepth and screenRect can not
  48822. assume that the platformWindow for the widget has a valid "window"
  48823. member. For example in the case of, a new browser view opening as a
  48824. child of a GtkNotebook, but never being switched to, or manually
  48825. realized. Solve by using the toplevel window of the widget, rather
  48826. than the widget itself.
  48827. * platform/gtk/PlatformScreenGtk.cpp:
  48828. (WebCore::screenDepth):
  48829. (WebCore::screenRect):
  48830. 2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com>
  48831. Reviewed by Darin Adler and Holger Freyther.
  48832. Make Widget::frameRectsChanged() and overrides non-const
  48833. This will hopefully allow us to get rid of some of the mutables in
  48834. the classes that react to the callback by changing their own state.
  48835. * platform/ScrollView.cpp:
  48836. (WebCore::ScrollView::frameRectsChanged):
  48837. * platform/ScrollView.h:
  48838. * platform/Widget.h:
  48839. (WebCore::Widget::frameRectsChanged):
  48840. * platform/gtk/ScrollbarGtk.cpp: Remove non-const version since
  48841. this was more complex and did the same thing, changed const of
  48842. the leftover frameRectsChanged() method.
  48843. (ScrollbarGtk::frameRectsChanged):
  48844. * platform/gtk/ScrollbarGtk.h:
  48845. * plugins/PluginView.cpp:
  48846. (WebCore::PluginView::frameRectsChanged):
  48847. * plugins/PluginView.h:
  48848. 2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
  48849. Reviewed and implemented with Tor Arne Vestbø.
  48850. Reimplement RenderTheme::caretBlinkInterval for Qt.
  48851. The QApplication::cursorFlashTime is in milliseconds and describes
  48852. the whole cycle while WebCore expects half a cycle.
  48853. * platform/qt/RenderThemeQt.cpp:
  48854. (WebCore::RenderThemeQt::caretBlinkInterval):
  48855. * platform/qt/RenderThemeQt.h:
  48856. 2008-12-09 Trenton Schulz <trenton.schulz@nokia.com>
  48857. Reviewed by Tor Arne Vestbø.
  48858. [Qt/Mac] Don't call HIGetScaleFactor() if we're not on Tiger or better
  48859. * plugins/mac/PluginViewMac.cpp:
  48860. (WebCore::tigerOrBetter):
  48861. (WebCore::PluginView::globalMousePosForPlugin):
  48862. 2008-12-10 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  48863. Reviewed by Eric Seidel and George Staikos.
  48864. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22799
  48865. Add WML <template> support. The <template> element is specified at deck-level
  48866. and declares a template for all <card> elements in the document.
  48867. * GNUmakefile.am:
  48868. * WebCore.vcproj/WebCore.vcproj:
  48869. * WebCore.xcodeproj/project.pbxproj:
  48870. * editing/htmlediting.cpp:
  48871. (WebCore::canHaveChildrenForEditing): Treat <do> just like a <button>.
  48872. * wml/WMLCardElement.cpp:
  48873. (WebCore::WMLCardElement::WMLCardElement):
  48874. (WebCore::WMLCardElement::setTemplateElement):
  48875. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
  48876. (WebCore::WMLCardElement::handleDeckLevelTaskOverridesIfNeeded):
  48877. * wml/WMLCardElement.h:
  48878. (WebCore::WMLCardElement::templateElement):
  48879. * wml/WMLDoElement.cpp:
  48880. (WebCore::WMLDoElement::insertedIntoDocument):
  48881. * wml/WMLDocument.cpp:
  48882. (WebCore::WMLDocument::finishedParsing):
  48883. * wml/WMLErrorHandling.cpp:
  48884. (WebCore::errorMessageForErrorCode):
  48885. * wml/WMLErrorHandling.h:
  48886. (WebCore::):
  48887. * wml/WMLEventHandlingElement.cpp:
  48888. (WebCore::WMLEventHandlingElement::~WMLEventHandlingElement):
  48889. * wml/WMLEventHandlingElement.h:
  48890. (WebCore::WMLEventHandlingElement::doElements):
  48891. * wml/WMLTagNames.in:
  48892. * wml/WMLTemplateElement.cpp: Added.
  48893. (WebCore::WMLTemplateElement::WMLTemplateElement):
  48894. (WebCore::WMLTemplateElement::~WMLTemplateElement):
  48895. (WebCore::WMLTemplateElement::parseMappedAttribute):
  48896. (WebCore::WMLTemplateElement::registerTemplatesInDocument):
  48897. * wml/WMLTemplateElement.h: Added.
  48898. * wml/WMLTimerElement.cpp:
  48899. (WebCore::WMLTimerElement::timerFired):
  48900. 2008-12-09 Dmitry Titov <dimich@chromium.org>
  48901. Reviewed by Darin Adler.
  48902. Fix memory leak - need to call stopActiveDOMObjects
  48903. when cached pages get destroyed.
  48904. https://bugs.webkit.org/show_bug.cgi?id=22753
  48905. * dom/Document.cpp:
  48906. (WebCore::Document::detach):
  48907. 2008-12-10 Alice Liu <alice.liu@apple.com>
  48908. Manual test for https://bugs.webkit.org/show_bug.cgi?id=20685
  48909. Reviewed by Darin Adler.
  48910. * manual-tests/drag-image-to-desktop.html: Added.
  48911. 2008-12-10 Alice Liu <alice.liu@apple.com>
  48912. fixed https://bugs.webkit.org/show_bug.cgi?id=20685
  48913. Reviewed by Darin Adler.
  48914. Manual test case is manual-tests/drag-image-to-desktop.html
  48915. Added new files to projects
  48916. * WebCore.vcproj/WebCore.vcproj:
  48917. * WebCore.xcodeproj/project.pbxproj:
  48918. * page/DragController.cpp:
  48919. (WebCore::DragController::startDrag):
  48920. * platform/MIMETypeRegistry.cpp:
  48921. (WebCore::initializeSupportedImageMIMETypes):
  48922. (WebCore::initializeSupportedImageMIMETypesForEncoding):
  48923. These changes add a method to obtain the extension for an image
  48924. * platform/graphics/BitmapImage.cpp:
  48925. (WebCore::BitmapImage::filenameExtension):
  48926. * platform/graphics/BitmapImage.h:
  48927. * platform/graphics/Image.h:
  48928. (WebCore::Image::filenameExtension):
  48929. * platform/graphics/ImageSource.h:
  48930. * platform/graphics/cairo/ImageSourceCairo.cpp:
  48931. (WebCore::ImageSource::filenameExtension):
  48932. * platform/graphics/cg/ImageSourceCG.cpp:
  48933. (WebCore::ImageSource::filenameExtension):
  48934. These changes added a utility that returns the preferred extension for a UTI
  48935. * platform/graphics/cg/ImageSourceCG.h: Added.
  48936. * platform/graphics/cg/ImageSourceCGMac.mm: Added.
  48937. (WebCore::MIMETypeForImageSourceType):
  48938. (WebCore::preferredExtensionForImageSourceType):
  48939. * platform/graphics/cg/ImageSourceCGWin.cpp: Added.
  48940. (WebCore::MIMETypeForImageSourceType):
  48941. (WebCore::preferredExtensionForImageSourceType):
  48942. * platform/mac/MIMETypeRegistryMac.mm:
  48943. moved getMIMETypeForUTI to ImageSourceCGMac.mm
  48944. Ask image for its file extension instead of relying on MIME type and file path
  48945. * platform/win/ClipboardWin.cpp:
  48946. (WebCore::createGlobalImageFileDescriptor):
  48947. Remove extraneous code from getPreferredExtensionForMIMEType.
  48948. Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
  48949. * platform/win/MIMETypeRegistryWin.cpp:
  48950. (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
  48951. 2008-12-10 Simon Fraser <simon.fraser@apple.com>
  48952. Reviewed by Antti Koivisto
  48953. <rdar://problem/6431224>
  48954. When updating the value of a slider, don't mark the parents
  48955. as needing layout, because the size of the slider can never
  48956. change. This fixes full-page repaints in some cases.
  48957. * rendering/RenderSlider.cpp:
  48958. (WebCore::RenderSlider::updateFromElement):
  48959. 2008-12-10 Simon Fraser <simon.fraser@apple.com>
  48960. Potential build fix. The forward declaration of FloatPoint should
  48961. be inside the WebCore namespace.
  48962. * platform/graphics/FloatPoint3D.h:
  48963. 2008-12-10 Simon Fraser <simon.fraser@apple.com>
  48964. Reviewed by Sam Weinig.
  48965. https://bugs.webkit.org/show_bug.cgi?id=22793
  48966. Cleanup FloatPoint3D: inline the getters and setters,
  48967. fix a potential divide-by-zero in normalize(), and add
  48968. a FloatPoint constructor.
  48969. * platform/graphics/FloatPoint3D.cpp:
  48970. (WebCore::FloatPoint3D::FloatPoint3D):
  48971. (WebCore::FloatPoint3D::normalize):
  48972. * platform/graphics/FloatPoint3D.h:
  48973. (WebCore::FloatPoint3D::x):
  48974. (WebCore::FloatPoint3D::setX):
  48975. (WebCore::FloatPoint3D::y):
  48976. (WebCore::FloatPoint3D::setY):
  48977. (WebCore::FloatPoint3D::z):
  48978. (WebCore::FloatPoint3D::setZ):
  48979. 2008-12-09 Julien Chaffraix <jchaffraix@webkit.org>
  48980. Reviewed by Eric Seidel.
  48981. Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
  48982. https://bugs.webkit.org/show_bug.cgi?id=22665
  48983. - Removed setCreatedByParser from style and link elements.
  48984. - Removed XMLTokenizer::eventuallyMarkAsCreatedByParser.
  48985. * dom/XMLTokenizer.cpp:
  48986. * dom/XMLTokenizer.h:
  48987. * dom/XMLTokenizerLibxml2.cpp:
  48988. (WebCore::XMLTokenizer::startElementNs):
  48989. * dom/XMLTokenizerQt.cpp:
  48990. (WebCore::XMLTokenizer::parseStartElement):
  48991. * html/HTMLElementFactory.cpp:
  48992. (WebCore::linkConstructor):
  48993. (WebCore::styleConstructor):
  48994. * html/HTMLLinkElement.cpp:
  48995. (WebCore::HTMLLinkElement::HTMLLinkElement):
  48996. * html/HTMLLinkElement.h:
  48997. * html/HTMLStyleElement.cpp:
  48998. (WebCore::HTMLStyleElement::HTMLStyleElement):
  48999. * html/HTMLStyleElement.h:
  49000. * html/HTMLTagNames.in:
  49001. * svg/SVGStyleElement.cpp:
  49002. (WebCore::SVGStyleElement::SVGStyleElement):
  49003. * svg/SVGStyleElement.h:
  49004. * svg/svgtags.in:
  49005. 2008-12-10 Brady Eidson <beidson@apple.com>
  49006. Reviewed by Darin
  49007. https://bugs.webkit.org/show_bug.cgi?id=22194 and <rdar://problem/6388378> -
  49008. Dialog when going back to a page from whence you submitted a form
  49009. http://trac.webkit.org/changeset/37317 changed the manner in which headers are added to
  49010. http requests, which caused the networking layer to have an incomplete set of headers
  49011. just before consulting the Policy Delegate. This caused a cache miss and incorrectly made
  49012. us believe we'd be resubmitting the form.
  49013. * loader/FrameLoader.cpp:
  49014. (WebCore::FrameLoader::loadItem): Being careful to maintain the new behavior required by
  49015. the Origin header mechanism as discussed in bug 22194, restore the previous behavior of
  49016. setting all the headers before the networking layer is asked about the cache lookup.
  49017. 2008-12-10 Dimitri Glazkov <dglazkov@chromium.org>
  49018. Reviewed by Timothy Hatcher.
  49019. Add back ability to end all profiling via console by invoking profileEnd
  49020. with no arguments.
  49021. * page/Console.cpp:
  49022. (WebCore::Console::profileEnd): Removed title null-checking and
  49023. subsequent early exit.
  49024. 2008-12-10 Pierre-Olivier Latour <pol@apple.com>
  49025. Reviewed by Darin Adler.
  49026. KeyframeAnimation::animate() needs to compute the elapsed animation time
  49027. properly taking into account its paused state.
  49028. https://bugs.webkit.org/show_bug.cgi?id=22773
  49029. Test: animations/animation-drt-api-multiple-keyframes.html
  49030. * page/animation/KeyframeAnimation.cpp:
  49031. (WebCore::KeyframeAnimation::animate):
  49032. 2008-12-10 Simon Fraser <simon.fraser@apple.com>
  49033. Reviewed by Dan Bernstein
  49034. Part of
  49035. https://bugs.webkit.org/show_bug.cgi?id=22570
  49036. Rename methods on RenderLayer for clarity:
  49037. clearClipRects -> clearClipRectsIncludingDescendants
  49038. clearClipRect -> clearClipRects
  49039. * rendering/RenderBox.cpp:
  49040. (WebCore::RenderBox::destroy):
  49041. * rendering/RenderLayer.cpp:
  49042. (WebCore::RenderLayer::updateLayerPosition):
  49043. (WebCore::RenderLayer::removeOnlyThisLayer):
  49044. (WebCore::RenderLayer::insertOnlyThisLayer):
  49045. (WebCore::RenderLayer::clearClipRectsIncludingDescendants):
  49046. (WebCore::RenderLayer::clearClipRects):
  49047. * rendering/RenderLayer.h:
  49048. * rendering/RenderObject.cpp:
  49049. (WebCore::RenderObject::styleWillChange):
  49050. * rendering/RenderWidget.cpp:
  49051. (WebCore::RenderWidget::destroy):
  49052. 2008-12-10 Kevin Ollivier <kevino@theolliviers.com>
  49053. wx build fix after the script call stack/frame additions.
  49054. * WebCoreSources.bkl:
  49055. 2008-12-10 Srinivasa Rao M. Hamse <msrinirao@gmail.com>
  49056. Reviewed by Holger Freyther.
  49057. F1-F12 key mappings for WebKit Gtk Port
  49058. * platform/gtk/KeyEventGtk.cpp:
  49059. (WebCore::windowsKeyCodeForKeyEvent):
  49060. 2008-12-10 Enrico Ros <enrico.ros@m31.com>
  49061. Reviewed by Simon Hausmann.
  49062. Fix the Qt build when SVG is disabled. A broken dependancy caused
  49063. unnecessary rebuilds even with no changes.
  49064. * WebCore.pro: fix a broken build dependancy
  49065. 2008-12-10 Hironori Bono <hbono@chromium.org>
  49066. Reviewed by Alexey Proskuryakov.
  49067. Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME
  49068. https://bugs.webkit.org/show_bug.cgi?id=21820
  49069. <rdar://problem/5683248> Typing backspace to delete a diacritical mark also deletes the character before (Arabic)
  49070. <rdar://problem/5702038> Backspace removes Thai Character in wrong sequence
  49071. Tests: editing/deleting/delete-ligature-001.html
  49072. editing/deleting/delete-ligature-002.html
  49073. editing/deleting/delete-ligature-003.html
  49074. * editing/TypingCommand.cpp:
  49075. (WebCore::TypingCommand::deleteKeyPressed): Delete only the last character
  49076. of a ligature which consists of multiple Unicode characters when deleting it with
  49077. a backspace key.
  49078. 2008-12-10 David Levin <levin@chromium.org>
  49079. Reviewed by Alexey Proskuryakov.
  49080. https://bugs.webkit.org/show_bug.cgi?id=22177
  49081. Fix the windows build by removing calls to notifyFormStateChanged
  49082. where they didn't appear in the original reviewed patch.
  49083. * html/HTMLInputElement.cpp:
  49084. (WebCore::HTMLInputElement::type):
  49085. (WebCore::HTMLInputElement::attach):
  49086. 2008-12-09 Adam Barth <abarth@webkit.org>
  49087. Reviewed by Sam Weinig.
  49088. Add ScriptController::updateSecurityOrigin to notify the bindings
  49089. that a document's securityOrigin has been updated. This is used by
  49090. V8 to update its security context.
  49091. * bindings/js/ScriptController.cpp:
  49092. (WebCore::ScriptController::updateSecurityOrigin):
  49093. * bindings/js/ScriptController.h:
  49094. * dom/Document.cpp:
  49095. (WebCore::Document::setDomain):
  49096. 2008-12-09 Eric Seidel <eric@webkit.org>
  49097. No review, build fix only.
  49098. Fix a few config issues to let the Chromium Windows WebCore build get further.
  49099. * WebCore.scons:
  49100. 2008-12-09 Brett Wilson <brettw@chromium.org>
  49101. Reviewed by Dave Hyatt.
  49102. https://bugs.webkit.org/show_bug.cgi?id=22177
  49103. Add a callback on ChromeClient that the state of form elements on
  49104. the page has changed. This is to allow clients implementing session
  49105. saving to know when the current state is dirty.
  49106. * html/HTMLInputElement.cpp:
  49107. (WebCore::notifyFormStateChanged):
  49108. (WebCore::HTMLInputElement::setInputType):
  49109. (WebCore::HTMLInputElement::type):
  49110. (WebCore::HTMLInputElement::attach):
  49111. (WebCore::HTMLInputElement::setValue):
  49112. (WebCore::HTMLInputElement::setValueFromRenderer):
  49113. (WebCore::HTMLInputElement::setFileListFromRenderer):
  49114. * html/HTMLSelectElement.cpp:
  49115. (WebCore::HTMLSelectElement::setSelectedIndex):
  49116. * html/HTMLTextAreaElement.cpp:
  49117. (WebCore::notifyFormStateChanged):
  49118. (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  49119. (WebCore::HTMLTextAreaElement::updateValue):
  49120. (WebCore::HTMLTextAreaElement::setValue):
  49121. * loader/EmptyClients.h:
  49122. (WebCore::EmptyChromeClient::formStateDidChange):
  49123. * page/ChromeClient.h:
  49124. 2008-12-09 Sam Weinig <sam@webkit.org>
  49125. Reviewed by Darin Adler.
  49126. https://bugs.webkit.org/show_bug.cgi?id=19762
  49127. Fix intermittent crash in buildbot. The CSSCursorImageValues and
  49128. SVGCursorElements held onto raw SVGElement pointers without any
  49129. guarantee that the element is still around.
  49130. We did not fix the design that resulted in this issue, we just fixed
  49131. the pointer lifetimes.
  49132. * css/CSSCursorImageValue.cpp:
  49133. (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Zero out the back pointers.
  49134. (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Set up a back pointer.
  49135. (WebCore::CSSCursorImageValue::removeReferencedElement): Added. Used when the element
  49136. is destroyed.
  49137. * css/CSSCursorImageValue.h: Added removeReferencedElement.
  49138. * svg/SVGCursorElement.cpp:
  49139. (WebCore::SVGCursorElement::~SVGCursorElement): Zero out the back pointers.
  49140. (WebCore::SVGCursorElement::addClient): Set up a back pointer.
  49141. (WebCore::SVGCursorElement::removeClient): Zero out the back pointer.
  49142. * svg/SVGElement.cpp:
  49143. (WebCore::SVGElement::SVGElement): Initialize back pointers to zero.
  49144. (WebCore::SVGElement::~SVGElement): Call both the element and cursor image value
  49145. to remove the element from their sets.
  49146. * svg/SVGElement.h:
  49147. (WebCore::SVGElement::setCursorElement): Added.
  49148. (WebCore::SVGElement::setCursorImageValue): Added.
  49149. 2008-12-09 David Hyatt <hyatt@apple.com>
  49150. Add code that will create custom CSS scrollbars from the <body>, the document element (<html>) and the owning
  49151. frame/iframe. If any of them set a custom style, it will be used. The scrollbars do not update dynamically
  49152. yet as you switch from page to page (until they are destroyed and recreated).
  49153. Reviewed by Adele
  49154. * page/FrameView.cpp:
  49155. (WebCore::FrameView::createScrollbar):
  49156. 2008-12-09 Ojan Vafai <ojan@chromium.org>
  49157. Reviewed by Dave Hyatt.
  49158. https://bugs.webkit.org/show_bug.cgi?id=22689
  49159. Match Firefox button metrics on Windows.
  49160. * rendering/RenderButton.cpp:
  49161. (WebCore::RenderButton::addChild):
  49162. (WebCore::RenderButton::styleDidChange):
  49163. (WebCore::RenderButton::setupInnerStyle):
  49164. * rendering/RenderButton.h:
  49165. * rendering/RenderTheme.cpp:
  49166. (WebCore::RenderTheme::adjustButtonInnerStyle):
  49167. * rendering/RenderTheme.h:
  49168. * rendering/RenderThemeWin.cpp:
  49169. (WebCore::RenderThemeWin::adjustSliderThumbSize):
  49170. (WebCore::RenderThemeWin::adjustButtonInnerStyle):
  49171. * rendering/RenderThemeWin.h:
  49172. 2008-12-09 Darin Fisher <darin@chromium.org>
  49173. Fixes bustages.
  49174. https://bugs.webkit.org/show_bug.cgi?id=22631
  49175. Adding missing files from previous commit.
  49176. * bindings/js/ScriptCallFrame.cpp: Added.
  49177. (WebCore::ScriptCallFrame::ScriptCallFrame):
  49178. (WebCore::ScriptCallFrame::~ScriptCallFrame):
  49179. (WebCore::ScriptCallFrame::argumentAt):
  49180. * bindings/js/ScriptCallFrame.h: Added.
  49181. (WebCore::ScriptCallFrame::functionName):
  49182. (WebCore::ScriptCallFrame::sourceURL):
  49183. (WebCore::ScriptCallFrame::lineNumber):
  49184. (WebCore::ScriptCallFrame::argumentCount):
  49185. * bindings/js/ScriptCallStack.cpp: Added.
  49186. (WebCore::ScriptCallStack::ScriptCallStack):
  49187. (WebCore::ScriptCallStack::~ScriptCallStack):
  49188. (WebCore::ScriptCallStack::at):
  49189. (WebCore::ScriptCallStack::size):
  49190. (WebCore::ScriptCallStack::initialize):
  49191. * bindings/js/ScriptCallStack.h: Added.
  49192. (WebCore::ScriptCallStack::state):
  49193. 2008-12-09 Dimitri Glazkov <dglazkov@chromium.org>
  49194. Reviewed by Timothy Hatcher.
  49195. https://bugs.webkit.org/show_bug.cgi?id=22631
  49196. Streamline Console.cpp, abstract out the use of JSC::ExecState and
  49197. JSC::ArgList by introducing ScriptCallFrame and ScriptCallStack
  49198. abstractions.
  49199. * GNUmakefile.am: Added ScriptCallFrame and ScriptCallStack to build
  49200. * WebCore.pro: Added ScriptCallFrame and ScriptCallStack to build
  49201. * WebCore.vcproj/WebCore.vcproj: Added ScriptCallFrame and
  49202. ScriptCallStack to project
  49203. * WebCore.xcodeproj/project.pbxproj: Added ScriptCallFrame and
  49204. ScriptCallStack to project
  49205. * bindings/js/JSConsoleCustom.cpp: Remove custom bindings.
  49206. * bindings/js/ScriptCallFrame.cpp: Added.
  49207. (WebCore::ScriptCallFrame::ScriptCallFrame):
  49208. (WebCore::ScriptCallFrame::~ScriptCallFrame):
  49209. (WebCore::ScriptCallFrame::argumentAt):
  49210. * bindings/js/ScriptCallFrame.h: Added.
  49211. (WebCore::ScriptCallFrame::functionName):
  49212. (WebCore::ScriptCallFrame::sourceURL):
  49213. (WebCore::ScriptCallFrame::lineNumber):
  49214. (WebCore::ScriptCallFrame::argumentCount):
  49215. * bindings/js/ScriptCallStack.cpp: Added.
  49216. (WebCore::ScriptCallStack::ScriptCallStack):
  49217. (WebCore::ScriptCallStack::~ScriptCallStack):
  49218. (WebCore::ScriptCallStack::at):
  49219. (WebCore::ScriptCallStack::size):
  49220. (WebCore::ScriptCallStack::initialize):
  49221. * bindings/js/ScriptCallStack.h: Added.
  49222. (WebCore::ScriptCallStack::ScriptCallStack):
  49223. (WebCore::ScriptCallStack::~ScriptCallStack):
  49224. (WebCore::ScriptCallStack::state):
  49225. (WebCore::ScriptCallStack::at):
  49226. (WebCore::ScriptCallStack::size):
  49227. (WebCore::ScriptCallStack::initialize):
  49228. * bindings/js/ScriptString.h: Added missing PlatformString include.
  49229. (WebCore::ScriptString::ScriptString): Added default constructor.
  49230. (WebCore::ScriptString::operator==): Added equality operator.
  49231. (WebCore::ScriptString::operator!=):
  49232. * bindings/js/ScriptValue.cpp: Added isNull and isUndefined.
  49233. (WebCore::ScriptValue::isNull):
  49234. (WebCore::ScriptValue::isUndefined):
  49235. * bindings/js/ScriptValue.h: Added isNull and isUndefined
  49236. * bindings/scripts/CodeGeneratorJS.pm: Add handling for
  49237. CustomArgumentHandling attribute.
  49238. * inspector/InspectorController.cpp: Refactored to use
  49239. ScriptCallFrame and ScriptCallStack.
  49240. (WebCore::ConsoleMessage::ConsoleMessage):
  49241. (WebCore::InspectorController::addMessageToConsole):
  49242. (WebCore::InspectorController::startGroup):
  49243. (WebCore::InspectorController::addScriptConsoleMessage):
  49244. (WebCore::InspectorController::count):
  49245. (WebCore::InspectorController::startTiming):
  49246. (WebCore::InspectorController::stopTiming):
  49247. * inspector/InspectorController.h: Refactored to use ScriptCallFrame and
  49248. ScriptCallStack.
  49249. * inspector/front-end/Console.js: Modified to use argument value itself
  49250. rather than f.name for stack trace.
  49251. * page/Console.cpp: Refactored to use ScriptCallFrame and
  49252. ScriptCallStack.
  49253. (WebCore::getFirstArgumentAsString):
  49254. (WebCore::Console::addMessage):
  49255. (WebCore::Console::debug):
  49256. (WebCore::Console::error):
  49257. (WebCore::Console::info):
  49258. (WebCore::Console::log):
  49259. (WebCore::Console::dir):
  49260. (WebCore::Console::dirxml):
  49261. (WebCore::Console::trace):
  49262. (WebCore::Console::assertCondition):
  49263. (WebCore::Console::count):
  49264. (WebCore::Console::profile):
  49265. (WebCore::Console::profileEnd):
  49266. (WebCore::Console::time):
  49267. (WebCore::Console::timeEnd):
  49268. (WebCore::Console::group):
  49269. (WebCore::Console::warn):
  49270. * page/Console.h:
  49271. * page/Console.idl: Removed Custom attributes, added
  49272. CustomArgumentHandling attributes, and tweaked argument defs.
  49273. 2008-12-09 Darin Adler <darin@apple.com>
  49274. Try to fix non-Mac builds.
  49275. * GNUmakefile.am: Added NavigatorBase.
  49276. * WebCore.pro: Ditto.
  49277. * WebCore.scons: Ditto.
  49278. * WebCore.vcproj/WebCore.vcproj: Ditto.
  49279. * WebCoreSources.bkl: Ditto.
  49280. Unrelated tweak sitting in my tree.
  49281. * bindings/objc/DOMAbstractView.mm: Remove pointless override of finalize method.
  49282. 2008-12-09 Darin Adler <darin@apple.com>
  49283. Try to fix Tiger build.
  49284. * platform/network/mac/NetworkStateNotifierMac.cpp: Declare CFRunLoopGetMain.
  49285. 2008-12-09 Alexey Proskuryakov <ap@webkit.org>
  49286. Reviewed by Darin Adler.
  49287. https://bugs.webkit.org/show_bug.cgi?id=22719
  49288. Implement Navigator object in Workers
  49289. Test: fast/workers/worker-navigator.html
  49290. * DerivedSources.make:
  49291. * GNUmakefile.am:
  49292. * WebCore.pro:
  49293. * WebCore.vcproj/WebCore.vcproj:
  49294. * WebCore.xcodeproj/project.pbxproj:
  49295. Added WorkerNavigator sources.
  49296. * bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextNavigator):
  49297. Worker.navigator returns a WoerkerNavigator object (it is named just Navigator in the spec,
  49298. but it is not the same interface that is available on Windows).
  49299. * dom/Worker.cpp:
  49300. (WebCore::Worker::notifyFinished):
  49301. * dom/WorkerContext.cpp:
  49302. (WebCore::WorkerContext::WorkerContext):
  49303. (WebCore::WorkerContext::navigator):
  49304. * dom/WorkerContext.h:
  49305. (WebCore::WorkerContext::create):
  49306. * dom/WorkerThread.cpp:
  49307. (WebCore::WorkerThread::create):
  49308. (WebCore::WorkerThread::WorkerThread):
  49309. (WebCore::WorkerThread::workerThread):
  49310. * dom/WorkerThread.h:
  49311. Pass a pre-computed user agent string into worker, because it cannot call a client method
  49312. directly, and pre-computing is easier than sending a synchronous message to the main thread.
  49313. * page/Navigator.cpp:
  49314. * page/Navigator.h:
  49315. * page/NavigatorBase.cpp: Added.
  49316. * page/NavigatorBase.h: Added.
  49317. Factor out common (and uncommon, but very similar) functionality into a base class.
  49318. * page/WorkerNavigator.cpp: Added.
  49319. * page/WorkerNavigator.h: Added.
  49320. * page/WorkerNavigator.idl: Added.
  49321. Per Web Workers and HTML5, implement a small subset of what we currently have in Window.Navigator.
  49322. * platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier):
  49323. Make networkStateNotifier() static constructor thread safe. The object is created on the
  49324. thread it is first called from, while callbacks are registered on the main thread. Calls to
  49325. onLine() from other threads are safe, because it is just loading a boolean.
  49326. * platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
  49327. Schedule notifications on main event loop, not the current one.
  49328. 2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  49329. Rubber-stamped by Alexey Proskuryakov.
  49330. Forgot to update Qt/WML build - add some new files to the build.
  49331. * WebCore.pro:
  49332. 2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  49333. Reviewed by Alexey Proskuryakov.
  49334. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22637
  49335. Implement the GET method for WMLGoElement, and some test covering it's behaviour.
  49336. Update all build systems supporting WML that haven't been updated since a while.
  49337. Add WMLPostField stub implementation, needed for implementing POST method.
  49338. Tests: wml/go-task-get-method-external-deck-with-href.html
  49339. wml/go-task-get-method-external-deck.html
  49340. wml/go-task-get-method-same-deck.html
  49341. * GNUmakefile.am:
  49342. * WebCore.vcproj/WebCore.vcproj:
  49343. * WebCore.xcodeproj/project.pbxproj:
  49344. * dom/Document.cpp:
  49345. (WebCore::Document::resetWMLPageState):
  49346. * wml/WMLCardElement.cpp:
  49347. * wml/WMLCardElement.h:
  49348. * wml/WMLEventHandlingElement.cpp:
  49349. (WebCore::WMLCardElement::registerDoElement):
  49350. * wml/WMLEventHandlingElement.h:
  49351. * wml/WMLGoElement.cpp:
  49352. (WebCore::WMLGoElement::WMLGoElement):
  49353. (WebCore::WMLGoElement::registerPostfieldElement):
  49354. (WebCore::WMLGoElement::parseMappedAttribute):
  49355. (WebCore::WMLGoElement::executeTask):
  49356. (WebCore::WMLGoElement::parseContentType):
  49357. (WebCore::WMLGoElement::preparePOSTRequest):
  49358. (WebCore::WMLGoElement::prepareGETRequest):
  49359. * wml/WMLGoElement.h:
  49360. * wml/WMLPostfieldElement.cpp: Added.
  49361. (WebCore::WMLPostfieldElement::WMLPostfieldElement):
  49362. (WebCore::WMLPostfieldElement::parseMappedAttribute):
  49363. (WebCore::WMLPostfieldElement::insertedIntoDocument):
  49364. * wml/WMLPostfieldElement.h: Added.
  49365. (WebCore::WMLPostfieldElement::name):
  49366. (WebCore::WMLPostfieldElement::value):
  49367. * wml/WMLTagNames.in:
  49368. 2008-12-08 Peter Kasting <pkasting@google.com>
  49369. Reviewed by Anders Carlsson.
  49370. https://bugs.webkit.org/show_bug.cgi?id=16814
  49371. Allow ports to disable ActiveX->NPAPI conversion for Media Player.
  49372. Improve handling of miscellaneous ActiveX objects.
  49373. * rendering/RenderPartObject.cpp:
  49374. (WebCore::mapClassIdToServiceType):
  49375. (WebCore::shouldUseChildEmbedOfObject):
  49376. (WebCore::RenderPartObject::updateWidget):
  49377. 2008-12-08 Darin Adler <darin@apple.com>
  49378. Reviewed by John Sullivan.
  49379. - fix https://bugs.webkit.org/show_bug.cgi?id=22409
  49380. REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
  49381. Tests: editing/execCommand/enabling-and-selection-2.html
  49382. editing/execCommand/enabling-and-selection.html
  49383. * editing/EditorCommand.cpp: Updated table to use these functions by their new names.
  49384. (WebCore::enabledVisibleSelection): Renamed this to reflect its new algorithm.
  49385. An invisible selection with a position that selects no characters doesn't count
  49386. as a visible selection.
  49387. (WebCore::enabledVisibleSelectionAndMark): Ditto.
  49388. 2008-12-08 David Kilzer <ddkilzer@apple.com>
  49389. Remove duplicate entries from WebCore project.
  49390. Reviewed by Eric Seidel.
  49391. Bug 22555: Sort "children" sections in Xcode project files.
  49392. <https://bugs.webkit.org/show_bug.cgi?id=22555>
  49393. Recipe for removing duplicates:
  49394. $ ./WebKitTools/Scripts/sort-Xcode-project-file project.pbxproj
  49395. $ uniq < project.pbxproj | diff -u project.pbxproj - | patch -p0 project.pbxproj
  49396. * WebCore.xcodeproj/project.pbxproj: Removed duplicates.
  49397. 2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
  49398. Reviewed by Darin Adler.
  49399. Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
  49400. https://bugs.webkit.org/show_bug.cgi?id=22665
  49401. Remove setCreatedByParser from the script elements (HTML and SVG).
  49402. * dom/XMLTokenizer.cpp:
  49403. (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): Removed
  49404. call to setCreatedByParser for the 2 elements.
  49405. * dom/make_names.pl: Modified to call the constructor with
  49406. the createByParser parameter if 'constructorNeedsCreatedByParser'
  49407. is set.
  49408. * html/HTMLElementFactory.cpp:
  49409. (WebCore::scriptConstructor):
  49410. * html/HTMLScriptElement.cpp:
  49411. (WebCore::HTMLScriptElement::HTMLScriptElement):
  49412. * html/HTMLScriptElement.h:
  49413. * html/HTMLTagNames.in: Added constructorNeedsCreatedByParser
  49414. to script.
  49415. * svg/SVGScriptElement.cpp:
  49416. (WebCore::SVGScriptElement::SVGScriptElement):
  49417. * svg/SVGScriptElement.h:
  49418. * svg/svgtags.in: Added constructorNeedsCreatedByParser
  49419. to script.
  49420. 2008-12-08 David Kilzer <ddkilzer@apple.com>
  49421. Bug 22555: Sort "children" sections in Xcode project files
  49422. <https://bugs.webkit.org/show_bug.cgi?id=22555>
  49423. Reviewed by Eric Seidel.
  49424. * WebCore.xcodeproj/project.pbxproj: Sorted.
  49425. * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Sorted.
  49426. 2008-12-08 Tony Chang <tony@chromium.org>
  49427. Reviewed by Eric Seidel.
  49428. Add a bool to GraphicsContext so that shadows can ignore
  49429. transformations. This is needed by HTML canvas element
  49430. where the spec says shadows are applied w/o transformations.
  49431. https://bugs.webkit.org/show_bug.cgi?id=22580
  49432. No functional changes, thus no tests.
  49433. * html/CanvasRenderingContext2D.cpp:
  49434. (WebCore::CanvasRenderingContext2D::setShadow):
  49435. (WebCore::CanvasRenderingContext2D::applyShadow):
  49436. * html/HTMLCanvasElement.cpp:
  49437. (WebCore::HTMLCanvasElement::createImageBuffer):
  49438. * platform/graphics/GraphicsContext.cpp:
  49439. (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
  49440. * platform/graphics/GraphicsContext.h:
  49441. * platform/graphics/GraphicsContextPrivate.h:
  49442. (WebCore::GraphicsContextState::GraphicsContextState):
  49443. * platform/graphics/cg/GraphicsContextCG.cpp:
  49444. (WebCore::GraphicsContext::setPlatformShadow):
  49445. 2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
  49446. Reviewed by Darin Adler.
  49447. Bug 17897: Not Rendering Images Imported from XHTML Document
  49448. <rdar://problem/5827614>
  49449. When we were loading document with XMLHttpRequest that contained images, the images
  49450. would not be fetched as they would not be displayed. However if we inserted such
  49451. an image element into a rendered document, we would not fetch the image and thus never
  49452. display it.
  49453. Now we check if the image has been loaded when we insert an HTMLImageElement into a
  49454. document.
  49455. To enable this, the image loader has an error flag. To avoid doing several attempts
  49456. when we know that the image is in error, we store the failed URL.
  49457. However Firefox and Opera ignore errors when the 'src' attribute changes and thus
  49458. we also have an updateFromElementIgnoringPreviousError to match the other browser.
  49459. Tests: http/tests/misc/image-blocked-src-change.html
  49460. http/tests/misc/image-blocked-src-no-change.html
  49461. http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
  49462. http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html
  49463. * html/HTMLEmbedElement.cpp:
  49464. (WebCore::HTMLEmbedElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
  49465. * html/HTMLImageElement.cpp:
  49466. (WebCore::HTMLImageElement::parseMappedAttribute): Ditto.
  49467. (WebCore::HTMLImageElement::insertedIntoDocument): Call updateFromElement if we do not have
  49468. an image.
  49469. * html/HTMLInputElement.cpp:
  49470. (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
  49471. * html/HTMLObjectElement.cpp:
  49472. (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
  49473. * html/HTMLVideoElement.cpp:
  49474. (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
  49475. * loader/ImageLoader.cpp:
  49476. (WebCore::ImageLoader::setImage): Added an assertion.
  49477. (WebCore::ImageLoader::updateFromElement): Added a check for load error (to avoid displaying
  49478. multiple errors in the console for a single image load).
  49479. (WebCore::ImageLoader::updateFromElementIgnoringPreviousError): This method clears previous error
  49480. before calling updateFromElement.
  49481. (WebCore::ImageLoader::notifyFinished): Added an assertion.
  49482. * loader/ImageLoader.h:
  49483. * svg/SVGImageElement.cpp:
  49484. (WebCore::SVGImageElement::svgAttributeChanged): Changed to call updateFromElementIgnoringPreviousError.
  49485. 2008-12-08 David Hyatt <hyatt@apple.com>
  49486. Make scrollbar creation virtual on ScrollView so that FrameView can have the capability to create
  49487. custom CSS scrollbars.
  49488. Reviewed by Eric Seidel
  49489. * page/FrameView.cpp:
  49490. (WebCore::FrameView::createScrollbar):
  49491. * page/FrameView.h:
  49492. * platform/ScrollView.cpp:
  49493. (WebCore::ScrollView::setHasHorizontalScrollbar):
  49494. (WebCore::ScrollView::setHasVerticalScrollbar):
  49495. (WebCore::ScrollView::createScrollbar):
  49496. * platform/ScrollView.h:
  49497. 2008-12-08 Dan Bernstein <mitz@apple.com>
  49498. Reviewed by John Sullivan.
  49499. - WebCore part of tracking the global history item for a WebView
  49500. * loader/FrameLoader.cpp:
  49501. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Set the page's
  49502. global history item to the current back/forward list item, respecting
  49503. private browsing mode.
  49504. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto in this
  49505. case.
  49506. (WebCore::FrameLoader::goToItem): Ditto in this case.
  49507. (WebCore::FrameLoader::updateHistoryForStandardLoad): If this load
  49508. creates a new global history item, set the page's global history item
  49509. to it.
  49510. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
  49511. Ditto.
  49512. * page/Page.cpp:
  49513. (WebCore::Page::setGlobalHistoryItem): Added this setter.
  49514. * page/Page.h: Added a m_globalHistoryItem data member.
  49515. (WebCore::Page::globalHistoryItem): Added this getter.
  49516. 2008-12-08 Antti Koivisto <antti@apple.com>
  49517. Reviewed by Dave Kilzer.
  49518. A few stylistic fixes suggested by Dave Kilzer.
  49519. * css/CSSPrimitiveValue.cpp:
  49520. (WebCore::CSSPrimitiveValue::createIdentifier):
  49521. (WebCore::CSSPrimitiveValue::create):
  49522. 2008-12-08 Alexey Proskuryakov <ap@webkit.org>
  49523. Reviewed by Darin Adler.
  49524. https://bugs.webkit.org/show_bug.cgi?id=22737
  49525. Try debug version when locating CFNetwork
  49526. * platform/network/cf/ResourceRequestCFNet.cpp:
  49527. (WebCore::findCFNetworkModule):
  49528. (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
  49529. (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
  49530. * platform/network/win/CookieJarCFNetWin.cpp:
  49531. (WebCore::findCFNetworkModule):
  49532. (WebCore::findIsHTTPOnlyFunction):
  49533. 2008-12-08 Aaron Boodman <aa@chromium.org>
  49534. Reviewed by Stephanie Lewis.
  49535. https://bugs.webkit.org/show_bug.cgi?id=22301
  49536. Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().
  49537. * loader/FrameLoader.cpp:
  49538. (WebCore::FrameLoader::finishedParsing):
  49539. 2008-12-08 Trenton Schulz <trenton.schulz@nokia.com>
  49540. Rubber-stamped by Tor Arne Vestbø.
  49541. Fix build warning on Mac
  49542. * platform/text/mac/StringImplMac.mm:
  49543. 2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
  49544. Fix the Qt build.
  49545. * bridge/qt/qt_runtime.cpp:
  49546. (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData to RegExp
  49547. constructor.
  49548. 2008-12-08 Oliver Hunt <oliver@apple.com>
  49549. Reviewed by Alexey Proskuryakov.
  49550. Bug 22398: r39059: Crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler
  49551. <rdar://problem/6426245> REGRESSION(r39059): Reproducible crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler (22398)
  49552. This regression was caused by r39059 replacing the protector on the active
  49553. animation with a protector on just the composition. It turns out that both
  49554. protectors are necessary.
  49555. Test: transitions/transition-duration-cleared-in-transitionend-crash.html
  49556. * page/animation/AnimationBase.cpp:
  49557. (WebCore::AnimationBase::animationTimerCallbackFired):
  49558. 2008-12-08 Dmitry Titov <dimich@chromium.org>
  49559. Reviewed by Alexey Proskuryakov.
  49560. https://bugs.webkit.org/show_bug.cgi?id=22732
  49561. Remove unused files PausedTimeouts.h,.cpp
  49562. The change that deprecated this code was https://bugs.webkit.org/show_bug.cgi?id=22620
  49563. * GNUmakefile.am:
  49564. * WebCore.pro:
  49565. * WebCore.scons:
  49566. * WebCore.vcproj/WebCore.vcproj:
  49567. * WebCore.xcodeproj/project.pbxproj:
  49568. * WebCoreSources.bkl:
  49569. These are build files which had PausedTimeouts referenced.
  49570. * bindings/js/PausedTimeouts.cpp: Removed.
  49571. * bindings/js/PausedTimeouts.h: Removed.
  49572. * bindings/js/ScriptController.cpp: Removed '#include'
  49573. * page/Chrome.cpp: Removed '#include' and unused variable.
  49574. 2008-12-07 Simon Fraser <simon.fraser@apple.com>
  49575. Reviewed by Dan Bernstein
  49576. https://bugs.webkit.org/show_bug.cgi?id=22594
  49577. Fix issues which break reading inline style for -webkit-transition
  49578. and -webkit-transform-origin.
  49579. Test: fast/css/transform-inline-style.html
  49580. * css/CSSMutableStyleDeclaration.cpp:
  49581. (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Add cases
  49582. for CSSPropertyWebkitTransformOrigin and CSSPropertyWebkitTransition
  49583. so that these shorthand properties are returned correctly.
  49584. * css/CSSParser.cpp:
  49585. (WebCore::CSSParser::parseAnimationProperty): Create CSSPrimitiveValues
  49586. with the correct CSSValueAll and CSSValueNone identifiers, not the
  49587. RenderStyle-level cAnimateAll, cAnimateNone.
  49588. * css/CSSStyleSelector.cpp:
  49589. (WebCore::CSSStyleSelector::mapAnimationProperty): Special-case CSSValueAll
  49590. and CSSValueNone values to set cAnimateAll and cAnimateNone transition properties.
  49591. 2008-12-07 Antti Koivisto <antti@apple.com>
  49592. Reviewed by Darin Adler.
  49593. https://bugs.webkit.org/show_bug.cgi?id=22717
  49594. Make CSS values use less memory
  49595. Share CSSPrimitiveValue objects for commonly used values including
  49596. - idents
  49597. - colors
  49598. - small integers
  49599. This reduces the amount CSSPrimitiveValue instances by > 80%.
  49600. * css/CSSPrimitiveValue.cpp:
  49601. (WebCore::CSSPrimitiveValue::createIdentifier):
  49602. (WebCore::CSSPrimitiveValue::createColor):
  49603. (WebCore::CSSPrimitiveValue::create):
  49604. * css/CSSPrimitiveValue.h:
  49605. (WebCore::CSSPrimitiveValue::create):
  49606. 2008-12-07 Antti Koivisto <antti@apple.com>
  49607. Reviewed by Darin Adler.
  49608. https://bugs.webkit.org/show_bug.cgi?id=22717
  49609. Make CSS values use less memory
  49610. Get CSSValues off from the common StyleBase base class. They don't
  49611. need a parent pointer or anything else there and there is no real
  49612. reason to have them in same data structures with other CSSOM objects.
  49613. Disabled (instead of refactoring around the lack of common base) the ability
  49614. to have style declaration blocks as CSS variable values. They don't exist in
  49615. the spec so I wasn't sure if they have future or not. It would not be hard to
  49616. get them back. CSS variables are in any case an experimental feature and
  49617. not enabled by default.
  49618. * css/CSSInitialValue.h:
  49619. (WebCore::CSSInitialValue::createExplicit):
  49620. (WebCore::CSSInitialValue::createImplicit):
  49621. * css/CSSParser.cpp:
  49622. (WebCore::CSSParser::addVariableDeclarationBlock):
  49623. * css/CSSParser.h:
  49624. * css/CSSValue.h:
  49625. (WebCore::CSSValue::~CSSValue):
  49626. (WebCore::CSSValue::parserValue):
  49627. * css/CSSVariablesDeclaration.cpp:
  49628. (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration):
  49629. (WebCore::CSSVariablesDeclaration::getVariableValue):
  49630. (WebCore::CSSVariablesDeclaration::removeVariable):
  49631. (WebCore::CSSVariablesDeclaration::addParsedVariable):
  49632. (WebCore::CSSVariablesDeclaration::getParsedVariable):
  49633. (WebCore::CSSVariablesDeclaration::getParsedVariableDeclarationBlock):
  49634. * css/CSSVariablesDeclaration.h:
  49635. (WebCore::CSSVariablesDeclaration::create):
  49636. * css/StyleBase.h:
  49637. 2008-12-07 Dirk Schulze <krit@webkit.org>
  49638. Reviewed by Oliver Hunt.
  49639. Add gradient and pattern support for strokeRect on canvas/Cg.
  49640. Canvas strokeRect() doesn't support gradients
  49641. https://bugs.webkit.org/show_bug.cgi?id=19790
  49642. Test: fast/canvas/canvas-strokeRect.html
  49643. * platform/graphics/cg/GraphicsContextCG.cpp:
  49644. (WebCore::GraphicsContext::strokeRect):
  49645. 2008-12-06 Dirk Schulze <krit@webkit.org>
  49646. Reviewed by Oliver Hunt.
  49647. Add support for setTransform() in canvas.
  49648. <canvas> lacks transform() and setTransform()
  49649. https://bugs.webkit.org/show_bug.cgi?id=16604
  49650. Test: fast/canvas/canvas-setTransform.html
  49651. * html/CanvasRenderingContext2D.cpp:
  49652. (WebCore::CanvasRenderingContext2D::State::State):
  49653. (WebCore::CanvasRenderingContext2D::setStrokeStyle):
  49654. (WebCore::CanvasRenderingContext2D::setFillStyle):
  49655. (WebCore::CanvasRenderingContext2D::scale):
  49656. (WebCore::CanvasRenderingContext2D::rotate):
  49657. (WebCore::CanvasRenderingContext2D::translate):
  49658. (WebCore::CanvasRenderingContext2D::transform):
  49659. (WebCore::CanvasRenderingContext2D::setTransform):
  49660. (WebCore::CanvasRenderingContext2D::beginPath):
  49661. (WebCore::CanvasRenderingContext2D::closePath):
  49662. (WebCore::CanvasRenderingContext2D::moveTo):
  49663. (WebCore::CanvasRenderingContext2D::lineTo):
  49664. (WebCore::CanvasRenderingContext2D::quadraticCurveTo):
  49665. (WebCore::CanvasRenderingContext2D::bezierCurveTo):
  49666. (WebCore::CanvasRenderingContext2D::arcTo):
  49667. (WebCore::CanvasRenderingContext2D::arc):
  49668. (WebCore::CanvasRenderingContext2D::rect):
  49669. (WebCore::CanvasRenderingContext2D::fill):
  49670. (WebCore::CanvasRenderingContext2D::stroke):
  49671. (WebCore::CanvasRenderingContext2D::clip):
  49672. (WebCore::CanvasRenderingContext2D::isPointInPath):
  49673. (WebCore::CanvasRenderingContext2D::clearRect):
  49674. (WebCore::CanvasRenderingContext2D::fillRect):
  49675. (WebCore::CanvasRenderingContext2D::strokeRect):
  49676. (WebCore::CanvasRenderingContext2D::drawImage):
  49677. (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  49678. (WebCore::CanvasRenderingContext2D::willDraw):
  49679. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  49680. * html/CanvasRenderingContext2D.h:
  49681. * html/CanvasRenderingContext2D.idl:
  49682. * html/HTMLCanvasElement.cpp:
  49683. (WebCore::HTMLCanvasElement::baseTransform):
  49684. * html/HTMLCanvasElement.h:
  49685. * platform/graphics/ImageBuffer.h:
  49686. (WebCore::ImageBuffer::baseTransform):
  49687. 2008-12-06 Antti Koivisto <antti@apple.com>
  49688. Reviewed by Darin Adler.
  49689. Also copy m_implicit field. Darin wanted this change commited separately.
  49690. * css/CSSProperty.h:
  49691. (WebCore::CSSProperty::operator=):
  49692. 2008-12-06 Antti Koivisto <antti@apple.com>
  49693. Reviewed by Darin Adler.
  49694. https://bugs.webkit.org/show_bug.cgi?id=22379
  49695. Make CSSOM use less memory
  49696. Use vector instead of a double linked list for properties in CSSMutableStyleDeclaration.
  49697. Taught setter functions to use existing slots to avoid memory moves, plus some
  49698. other optimizations.
  49699. * WebCore.xcodeproj/project.pbxproj:
  49700. * css/CSSMutableStyleDeclaration.cpp:
  49701. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  49702. (WebCore::CSSMutableStyleDeclaration::operator=):
  49703. (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
  49704. (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
  49705. (WebCore::CSSMutableStyleDeclaration::removeProperty):
  49706. (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
  49707. (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
  49708. (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
  49709. (WebCore::CSSMutableStyleDeclaration::setProperty):
  49710. (WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
  49711. (WebCore::CSSMutableStyleDeclaration::setStringProperty):
  49712. (WebCore::CSSMutableStyleDeclaration::setImageProperty):
  49713. (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
  49714. (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
  49715. (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
  49716. (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
  49717. (WebCore::CSSMutableStyleDeclaration::length):
  49718. (WebCore::CSSMutableStyleDeclaration::item):
  49719. (WebCore::CSSMutableStyleDeclaration::cssText):
  49720. (WebCore::CSSMutableStyleDeclaration::setCssText):
  49721. (WebCore::CSSMutableStyleDeclaration::merge):
  49722. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  49723. (WebCore::CSSMutableStyleDeclaration::copy):
  49724. (WebCore::CSSMutableStyleDeclaration::findPropertyWithId):
  49725. * css/CSSMutableStyleDeclaration.h:
  49726. (WebCore::CSSMutableStyleDeclarationConstIterator::operator*):
  49727. (WebCore::CSSMutableStyleDeclarationConstIterator::operator->):
  49728. (WebCore::CSSMutableStyleDeclarationConstIterator::operator!=):
  49729. (WebCore::CSSMutableStyleDeclarationConstIterator::operator==):
  49730. (WebCore::CSSMutableStyleDeclaration::create):
  49731. (WebCore::CSSMutableStyleDeclaration::begin):
  49732. (WebCore::CSSMutableStyleDeclaration::end):
  49733. (WebCore::CSSMutableStyleDeclarationConstIterator::CSSMutableStyleDeclarationConstIterator):
  49734. (WebCore::CSSMutableStyleDeclarationConstIterator::~CSSMutableStyleDeclarationConstIterator):
  49735. (WebCore::CSSMutableStyleDeclarationConstIterator::operator=):
  49736. (WebCore::CSSMutableStyleDeclarationConstIterator::operator++):
  49737. (WebCore::CSSMutableStyleDeclarationConstIterator::operator--):
  49738. * css/CSSProperty.h:
  49739. (WTF::):
  49740. * css/CSSStyleDeclaration.cpp:
  49741. (WebCore::CSSStyleDeclaration::diff):
  49742. (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
  49743. * css/CSSStyleSelector.cpp:
  49744. (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
  49745. (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  49746. (WebCore::CSSStyleSelector::applyDeclarations):
  49747. * dom/EventTarget.h:
  49748. * editing/ApplyStyleCommand.cpp:
  49749. (WebCore::StyleChange::init):
  49750. (WebCore::ApplyStyleCommand::isHTMLStyleNode):
  49751. (WebCore::ApplyStyleCommand::removeHTMLFontStyle):
  49752. (WebCore::ApplyStyleCommand::removeCSSStyle):
  49753. * editing/Editor.cpp:
  49754. (WebCore::Editor::selectionStartHasStyle):
  49755. (WebCore::updateState):
  49756. * editing/ReplaceSelectionCommand.cpp:
  49757. (WebCore::ReplaceSelectionCommand::handleStyleSpans):
  49758. * editing/markup.cpp:
  49759. (WebCore::appendStartMarkup):
  49760. 2008-12-06 Simon Fraser <simon.fraser@apple.com>
  49761. Reviewed by Antti Koivisto, Dan Bernstein
  49762. https://bugs.webkit.org/show_bug.cgi?id=22088
  49763. Fix logic related to repainting when transform changes:
  49764. If an object has a layer, and the transform changes, then we need
  49765. to do a repaintIncludingDescendants(), not just a repaint.
  49766. Test: fast/repaint/transform-repaint-descendants.html
  49767. * rendering/RenderObject.cpp:
  49768. (WebCore::RenderObject::styleWillChange):
  49769. 2008-12-06 Simon Fraser <simon.fraser@apple.com>
  49770. Reviewed by Dan Bernstein
  49771. https://bugs.webkit.org/show_bug.cgi?id=15739
  49772. When painting the selection on a replaced element, paint
  49773. using local coordinates so that the selection is correctly
  49774. painted for transformed elements.
  49775. Test: fast/replaced/selection-rect-transform.html
  49776. * rendering/RenderReplaced.cpp:
  49777. (WebCore::RenderReplaced::paint):
  49778. 2008-12-06 Simon Fraser <simon.fraser@apple.com>
  49779. Reviewed by Dave Hyatt
  49780. https://bugs.webkit.org/show_bug.cgi?id=15671
  49781. Fix caret rendering to behave correctly with transforms:
  49782. * Rename caretRect() methods to localCaretRect() and
  49783. absoluteCaretBounds() as appropriate
  49784. * Fix localCaretRect() methods to return a rect in the
  49785. appropriate coordinates.
  49786. * Pass tx, ty down through the paintCaret() methods, after fixing them
  49787. up to account for differences between contents coords, and renderer-local
  49788. coords (via RenderBlock::offsetForContents()).
  49789. * Remove m_caretPositionOnLayout from SelectionController, and instead
  49790. call invalidateSelection() from RenderLayer::scrollToOffset(), because
  49791. we can no longer assume simple x/y offsets from scrolling with transforms.
  49792. * Move the logic to compute which RenderObject actually paints the caret into
  49793. SelectionController::caretRenderer(), rather than having it in RenderBlock.
  49794. * SelectionController now computes and caches a local caret rect. For invalidation,
  49795. it computes the absolute bounds of that (possibly transformed) local rect.
  49796. The local rect is computed in the coordinate system of the RenderObject that
  49797. will paint the caret (this may require offsetting from the actual renderer
  49798. at the start of the selection).
  49799. * Fix LayoutState(RenderObject* root) to take transforms into account
  49800. * Make offsetFromContainer() a virtual method on RenderObject, and implement
  49801. the RenderObject version. It's used to map from selection start renderer
  49802. to caret renderer.
  49803. Test: fast/transforms/transformed-caret.html
  49804. * WebCore.base.exp:
  49805. * editing/DeleteSelectionCommand.cpp:
  49806. (WebCore::DeleteSelectionCommand::mergeParagraphs):
  49807. * editing/SelectionController.cpp:
  49808. (WebCore::SelectionController::SelectionController):
  49809. (WebCore::absoluteCaretY):
  49810. (WebCore::SelectionController::modify):
  49811. (WebCore::SelectionController::xPosForVerticalArrowNavigation):
  49812. (WebCore::SelectionController::layout):
  49813. (WebCore::SelectionController::caretRenderer):
  49814. (WebCore::SelectionController::localCaretRect):
  49815. (WebCore::SelectionController::absoluteCaretBounds):
  49816. (WebCore::SelectionController::caretRepaintRect):
  49817. (WebCore::SelectionController::recomputeCaretRect):
  49818. (WebCore::SelectionController::invalidateCaretRect):
  49819. (WebCore::SelectionController::paintCaret):
  49820. (WebCore::SelectionController::caretRendersInsideNode):
  49821. * editing/SelectionController.h:
  49822. * editing/VisiblePosition.cpp:
  49823. (WebCore::VisiblePosition::localCaretRect):
  49824. (WebCore::VisiblePosition::absoluteCaretBounds):
  49825. (WebCore::VisiblePosition::xOffsetForVerticalNavigation):
  49826. * editing/VisiblePosition.h:
  49827. * editing/mac/SelectionControllerMac.mm:
  49828. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  49829. * html/HTMLElement.cpp:
  49830. (WebCore::HTMLElement::isContentEditable):
  49831. * page/AccessibilityRenderObject.cpp:
  49832. (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
  49833. * page/Frame.cpp:
  49834. (WebCore::Frame::firstRectForRange):
  49835. (WebCore::Frame::selectionLayoutChanged):
  49836. (WebCore::Frame::paintCaret):
  49837. (WebCore::Frame::paintDragCaret):
  49838. (WebCore::Frame::revealSelection):
  49839. (WebCore::Frame::revealCaret):
  49840. * page/Frame.h:
  49841. * rendering/LayoutState.cpp:
  49842. (WebCore::LayoutState::LayoutState):
  49843. * rendering/RenderBlock.cpp:
  49844. (WebCore::RenderBlock::paintCaret):
  49845. (WebCore::RenderBlock::paintObject):
  49846. (WebCore::RenderBlock::positionForCoordinates):
  49847. (WebCore::RenderBlock::offsetForContents):
  49848. * rendering/RenderBlock.h:
  49849. * rendering/RenderBox.cpp:
  49850. (WebCore::RenderBox::localCaretRect):
  49851. * rendering/RenderBox.h:
  49852. * rendering/RenderFlow.cpp:
  49853. (WebCore::RenderFlow::localCaretRect):
  49854. * rendering/RenderFlow.h:
  49855. * rendering/RenderLayer.cpp:
  49856. (WebCore::RenderLayer::scrollToOffset):
  49857. * rendering/RenderObject.cpp:
  49858. (WebCore::RenderObject::localCaretRect):
  49859. * rendering/RenderObject.h:
  49860. * rendering/RenderSVGInlineText.cpp:
  49861. (WebCore::RenderSVGInlineText::localCaretRect):
  49862. * rendering/RenderSVGInlineText.h:
  49863. * rendering/RenderText.cpp:
  49864. (WebCore::RenderText::RenderText):
  49865. (WebCore::RenderText::localCaretRect):
  49866. * rendering/RenderText.h:
  49867. 2008-12-06 David Kilzer <ddkilzer@apple.com>
  49868. Bug 22711: Current svn (build 39065) fails to compile
  49869. <https://bugs.webkit.org/show_bug.cgi?id=22711>
  49870. BUILD FIX for r39065: Forgot parentheses after "document".
  49871. Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
  49872. <https://bugs.webkit.org/show_bug.cgi?id=22666>
  49873. * svg/SVGFEImageElement.cpp:
  49874. (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Changed
  49875. document to document().
  49876. 2008-12-06 Dmitry Titov <dimich@chromium.org>
  49877. Reviewed by Alexey Proskuryakov.
  49878. https://bugs.webkit.org/show_bug.cgi?id=22710
  49879. Memory leak due to circular reference Document->DOMTimer->ScheduledAction->[JS objects]->Document
  49880. * bindings/js/DOMTimer.cpp:
  49881. (WebCore::DOMTimer::stop): Delete ScheduledAction, which contains a protected object.
  49882. 2008-12-06 David Kilzer <ddkilzer@apple.com>
  49883. Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
  49884. <https://bugs.webkit.org/show_bug.cgi?id=22666>
  49885. Reviewed by Darin Adler.
  49886. When creating a webarchive from WebCore::LegacyWebArchive::create(),
  49887. HashSet<String>, Vector<KURL> and Vector<String> were all used to
  49888. store a list of URLs for resources found in the document. Instead
  49889. use a single ListHashSet<KURL> to store the list and resolve the
  49890. relative URLs as they're added. We use a new inline method called
  49891. WebCore::addSubresourceURL() to add KURL objects to the ListHashSet
  49892. to prevent "null" KURL objects from crashing in the KURL hashing
  49893. function.
  49894. * WebCore.base.exp: Changed export of
  49895. WebCore::Node::getSubresourceURLs() to take a ListHashSet<KURL>
  49896. argument instead of a Vector<KURL>.
  49897. * WebCore.xcodeproj/project.pbxproj: Marked KURLHash.h as a private
  49898. header for use in WebKit.
  49899. * css/CSSStyleSheet.cpp:
  49900. (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Renamed from
  49901. addSubresourceURLStrings(). Changed to use ListHashSet<KURL>
  49902. instead of HashSet<String>. Cleaned up code.
  49903. * css/CSSStyleSheet.h:
  49904. (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Ditto.
  49905. * css/StyleSheet.h:
  49906. (WebCore::StyleSheet::addSubresourceStyleURLs): Ditto.
  49907. * dom/Node.cpp:
  49908. (WebCore::Node::getSubresourceURLs): Changed to use
  49909. ListHashSet<KURL> instead of Vector<KURL>. Cleaned up code.
  49910. * dom/Node.h:
  49911. (WebCore::Node::getSubresourceURLs): Ditto.
  49912. (WebCore::Node::addSubresourceAttributeURLs): Renamed from
  49913. getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL>
  49914. instead of Vector<String>.
  49915. (WebCore::addSubresourceURL): Added. Safely adds new KURL objects
  49916. to a ListHashSet<KURL> object. A "null" KURL object will cause the
  49917. hash function to crash since it contains a null StringImpl. Used in
  49918. Node::addSubresourceAttributeURLs() and addSubresourceStyleURLs() in
  49919. the style subsystem.
  49920. * dom/ProcessingInstruction.cpp:
  49921. (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
  49922. Renamed from getSubresourceAttributeStrings(). Changed to use
  49923. ListHashSet<KURL> instead of Vector<String>. Use
  49924. WebCore::addSubresourceURL() to add new KURL objects.
  49925. * dom/ProcessingInstruction.h: Ditto.
  49926. * html/HTMLBodyElement.cpp:
  49927. (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Ditto.
  49928. * html/HTMLBodyElement.h: Ditto.
  49929. * html/HTMLEmbedElement.cpp:
  49930. (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
  49931. * html/HTMLEmbedElement.h: Ditto.
  49932. * html/HTMLImageElement.cpp:
  49933. (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
  49934. * html/HTMLImageElement.h: Ditto.
  49935. * html/HTMLInputElement.cpp:
  49936. (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
  49937. * html/HTMLInputElement.h: Ditto.
  49938. * html/HTMLLinkElement.cpp:
  49939. (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
  49940. * html/HTMLLinkElement.h: Ditto.
  49941. * html/HTMLObjectElement.cpp:
  49942. (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
  49943. * html/HTMLObjectElement.h: Ditto.
  49944. * html/HTMLParamElement.cpp:
  49945. (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
  49946. * html/HTMLParamElement.h: Ditto.
  49947. * html/HTMLScriptElement.cpp:
  49948. (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
  49949. * html/HTMLScriptElement.h: Ditto.
  49950. * html/HTMLStyleElement.cpp:
  49951. (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
  49952. * html/HTMLStyleElement.h: Ditto.
  49953. * html/HTMLTableCellElement.cpp:
  49954. (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
  49955. * html/HTMLTableCellElement.h: Ditto.
  49956. * html/HTMLTableElement.cpp:
  49957. (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
  49958. * html/HTMLTableElement.h: Ditto.
  49959. * loader/archive/cf/LegacyWebArchive.cpp:
  49960. (WebCore::LegacyWebArchive::create): Changed from using
  49961. HashSet<String> to ListHashSet<KURL> for tracking unique
  49962. subresources. Changed from using Vector<KURL> to ListHashSet<KURL>
  49963. when calling WebCore::Node::getSubresourceURLs(). Cleaned up code.
  49964. * svg/SVGCursorElement.cpp:
  49965. (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Renamed
  49966. from getSubresourceAttributeStrings(). Changed to use
  49967. ListHashSet<KURL> instead of Vector<String>. Use
  49968. WebCore::addSubresourceURL() to add new KURL objects.
  49969. * svg/SVGCursorElement.h: Ditto.
  49970. * svg/SVGFEImageElement.cpp:
  49971. (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
  49972. * svg/SVGFEImageElement.h: Ditto.
  49973. * svg/SVGImageElement.cpp:
  49974. (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
  49975. * svg/SVGImageElement.h: Ditto.
  49976. * svg/SVGScriptElement.cpp:
  49977. (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
  49978. * svg/SVGScriptElement.h: Ditto.
  49979. 2008-12-05 Brett Wilson <brettw@chromium.org>
  49980. Reviewed by Darin Adler.
  49981. Make the page group use the proper link hashing functions rather than
  49982. calling the string hash functions directly. Add Chromium-specfic ifdefs
  49983. in the visited link computation functions to allow integration.
  49984. * page/PageGroup.cpp:
  49985. (WebCore::PageGroup::isLinkVisited):
  49986. (WebCore::PageGroup::addVisitedLink):
  49987. * platform/LinkHash.cpp:
  49988. (WebCore::visitedLinkHash):
  49989. * platform/LinkHash.h:
  49990. 2008-12-05 Chris Marrin <cmarrin@apple.com>
  49991. Reviewed by Dave Hyatt.
  49992. Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
  49993. For iteration and end events, previous fixes to prevent the deletion of
  49994. Animation objects (ref counting and hanging onto a ref during event callbacks)
  49995. was sufficient to prevent dangling pointers. But start events are sent in
  49996. the styleAvailable() call, which iterates over CompositeAnimation objects,
  49997. which are not ref counted. So that object can get destroyed in the event
  49998. handler while still active. So I added refcounting for CompositeAnimations.
  49999. Additionally, when am iterating over the CompositingAnimation list, it can
  50000. be deleted, which mutates the list. So I now make one pass over the list
  50001. building a vector of CompositeAnimation objects that need to be called and
  50002. then iterate over that vector to make the actual calls.
  50003. Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
  50004. the Animation objects it owns, I now keep a ref to the CompositeAnimation
  50005. in the timer callback for the iteration and end events. That means I no
  50006. longer need to keep a ref to the Animation objects themselves in that timer
  50007. callback, since the CompositeAnimation already has one.
  50008. Tests: animations/animation-iteration-event-destroy-renderer.html
  50009. animations/animation-start-event-destroy-renderer.html
  50010. * page/animation/AnimationBase.cpp:
  50011. (WebCore::AnimationBase::updateStateMachine):
  50012. (WebCore::AnimationBase::animationTimerCallbackFired):
  50013. * page/animation/AnimationController.cpp:
  50014. (WebCore::AnimationControllerPrivate::~AnimationControllerPrivate):
  50015. (WebCore::AnimationControllerPrivate::accessCompositeAnimation):
  50016. (WebCore::AnimationControllerPrivate::clear):
  50017. (WebCore::AnimationControllerPrivate::styleAvailable):
  50018. (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  50019. (WebCore::AnimationControllerPrivate::animationTimerFired):
  50020. (WebCore::AnimationControllerPrivate::isAnimatingPropertyOnRenderer):
  50021. (WebCore::AnimationControllerPrivate::suspendAnimations):
  50022. (WebCore::AnimationControllerPrivate::resumeAnimations):
  50023. (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
  50024. (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  50025. (WebCore::AnimationController::updateAnimations):
  50026. (WebCore::AnimationController::setAnimationStartTime):
  50027. (WebCore::AnimationController::setTransitionStartTime):
  50028. * page/animation/CompositeAnimation.cpp:
  50029. (WebCore::CompositeAnimationPrivate::animationController):
  50030. (WebCore::CompositeAnimationPrivate::isWaitingForStyleAvailable):
  50031. (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
  50032. (WebCore::CompositeAnimationPrivate::clearRenderer):
  50033. (WebCore::CompositeAnimation::clearRenderer):
  50034. (WebCore::CompositeAnimation::animationController):
  50035. (WebCore::CompositeAnimation::isWaitingForStyleAvailable):
  50036. * page/animation/CompositeAnimation.h:
  50037. (WebCore::CompositeAnimation::create):
  50038. 2008-12-05 David Kilzer <ddkilzer@apple.com>
  50039. Bug 22609: Provide a build-time choice when generating hash tables for properties of built-in DOM objects
  50040. <https://bugs.webkit.org/show_bug.cgi?id=22609>
  50041. <rdar://problem/6331749>
  50042. Reviewed by Darin Adler.
  50043. Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
  50044. Added back the code that generates a "compact" hash (instead of a
  50045. perfect hash) as a build-time option using the
  50046. ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
  50047. * bindings/scripts/CodeGeneratorJS.pm:
  50048. (GenerateImplementation): Compute the number of elements that will
  50049. be stored in each hash table and pass it to GenerateHashTable().
  50050. (GenerateHashTable): Added new second parameter representing the
  50051. number of elements to store in the compact hash table. Added back
  50052. code to compute compact hash tables. Generate both hash table sizes
  50053. and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
  50054. 2008-12-05 Brett Wilson <brettw@chromium.org>
  50055. Fix build bustage from previous patch.
  50056. * css/CSSSelector.h:
  50057. 2008-12-05 Brett Wilson <brettw@chromium.org>
  50058. Reviewed by Eric Seidel.
  50059. Add a missing include for OwnPtr to make CSSSelector compile without
  50060. precompiled headers.
  50061. * css/CSSSelector.h:
  50062. 2008-12-05 Finnur Thorarinsson <finnur.webkit@gmail.com>
  50063. Reviewed by Darin Adler.
  50064. Bug 22579: Providing a function to ScrollbarClient.h which allows us to get at the tickmarks
  50065. without relying on high-level WebCore types, as requested by Dave Hyatt.
  50066. No functional changes, thus no test cases.
  50067. * page/FrameView.cpp:
  50068. (WebCore::FrameView::getTickmarks):
  50069. * page/FrameView.h:
  50070. * platform/ScrollbarClient.h:
  50071. 2008-12-05 Dean Jackson <dino@apple.com>
  50072. Reviewed by David Hyatt.
  50073. Make sure Window event listeners also tell the
  50074. Document about the event type, so noisy events
  50075. will be dispatched even if nothing in the document
  50076. is listening.
  50077. https://bugs.webkit.org/show_bug.cgi?id=20572
  50078. * dom/Document.cpp:
  50079. (WebCore::Document::addWindowEventListener):
  50080. 2008-12-05 Adam Roben <aroben@apple.com>
  50081. Windows build fix after r39026
  50082. * platform/network/cf/ResourceRequestCFNet.cpp:
  50083. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  50084. (WebCore::ResourceRequest::doUpdateResourceRequest):
  50085. Add some missing .get()s.
  50086. 2008-12-05 Alexey Proskuryakov <ap@webkit.org>
  50087. Tiger build fix.
  50088. * platform/network/mac/ResourceRequestMac.mm: Define NSUInteger.
  50089. 2008-12-05 Alexey Proskuryakov <ap@webkit.org>
  50090. Reviewed by Darin Adler.
  50091. <rdar://problem/6405599> Tiger Mail crashes when using "Mail Contents of This Page"
  50092. in Safari before opening a mail message in Mail
  50093. * platform/mac/WebCoreObjCExtras.mm:
  50094. (WebCoreObjCFinalizeOnMainThread):
  50095. Don't call initializeThreading: we now expect the caller to do it, to simplify keeping
  50096. Tiger and post-Tiger behavior in line.
  50097. * bindings/objc/DOMRGBColor.mm:
  50098. (+[DOMRGBColor initialize]):
  50099. * bindings/objc/WebScriptObject.mm:
  50100. (+[WebScriptObject initialize]):
  50101. * page/mac/AccessibilityObjectWrapper.mm:
  50102. (+[AccessibilityObjectWrapper initialize]):
  50103. * platform/mac/SharedBufferMac.mm:
  50104. (+[WebCoreSharedBufferData initialize]):
  50105. Call JSC::initializeThreading();
  50106. 2008-12-05 Alexey Proskuryakov <ap@webkit.org>
  50107. Reviewed by Darin Adler.
  50108. <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
  50109. * platform/network/ResourceRequestBase.cpp:
  50110. (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
  50111. * platform/network/ResourceRequestBase.h:
  50112. * platform/network/cf/ResourceRequestCFNet.cpp:
  50113. (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction):
  50114. (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
  50115. (WebCore::setContentDispositionEncodingFallbackArray):
  50116. (WebCore::copyContentDispositionEncodingFallbackArray):
  50117. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  50118. (WebCore::ResourceRequest::doUpdateResourceRequest):
  50119. * platform/network/mac/ResourceRequestMac.mm:
  50120. (WebCore::ResourceRequest::doUpdateResourceRequest):
  50121. (WebCore::ResourceRequest::doUpdatePlatformRequest):
  50122. Added a way to specify encoding fallback list for Content-Disposition header.
  50123. * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Generate and
  50124. pass a list of encodings to try when decoding Content-Disposition header, as described
  50125. in comments.
  50126. 2008-12-05 Alexey Proskuryakov <ap@webkit.org>
  50127. Reviewed by Darin Adler.
  50128. https://bugs.webkit.org/show_bug.cgi?id=22672
  50129. ASSERT(m_table) when xhr.onabort creates another xhr or calls setTimeout
  50130. Test: http/tests/xmlhttprequest/send-on-abort.html
  50131. * dom/ScriptExecutionContext.cpp:
  50132. (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
  50133. (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
  50134. (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
  50135. (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
  50136. Add a comment explaining that ActiveDOMObject methods shouldn't execute arbitrary JS.
  50137. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::stop): Don't dispatch events. This
  50138. reverts a recent change that made the behavior slightly closer to Firefox - but the
  50139. compatibility effect should be very minor if any, and Firefox itself behaves inconsistently.
  50140. 2008-12-05 Tobias König <tobias.koenig@nokia.com>
  50141. Reviewed by Simon Hausmann.
  50142. Record required package dependencies for the Qt build for a correct
  50143. pkg-config file.
  50144. * WebCore.pro:
  50145. 2008-12-05 Tor Arne Vestbø <tavestbo@trolltech.com>
  50146. Rubber-stamped by Simon Hausmann.
  50147. [Qt/Mac] Blacklist QuickTime plugin until we support the QuickDraw drawing model
  50148. * plugins/mac/PluginPackageMac.cpp:
  50149. (WebCore::PluginPackage::fetchInfo):
  50150. (WebCore::PluginPackage::isPluginBlacklisted):
  50151. 2008-12-05 Jungshik Shin <jshin@chromium.org>
  50152. Reviewed by Alexey Proskuryakov.
  50153. https://bugs.webkit.org/show_bug.cgi?id=22472
  50154. Revises charset alias map for TextCodecICU.
  50155. - Uses windows-949 and windows-874 instead of windows-949-2000 and windows-874-2000
  50156. - Replaces 'windows874' in a couple of place with 'windows-874' (for the canonical name)
  50157. - Maps 'dos-874' to 'windows-874'. Currently, it's aliases to 'cp874', which is in turn
  50158. mapped to 'TIS-620'. 'TIS-620' is manually aliased to 'windows-874'. We'd better directly
  50159. alias 'dos-874' to 'windows-874'.
  50160. - Replaces 'EUC-CN' with 'GBK' when it's used as the canonical name.
  50161. Similar to the above case, we're getting rid of indirection that eventually leads to 'GBK' by
  50162. directly going to 'GBK'.
  50163. - Adds 'x-uhc' as an alias for 'windows-949'. It's used in some web pages.
  50164. Tests: fast/encoding/char-decoding-mac.html
  50165. fast/encoding/char-decoding.html
  50166. * platform/text/TextCodecICU.cpp:
  50167. (WebCore::TextCodecICU::registerExtendedEncodingNames):
  50168. 2008-12-04 Kevin Watters <kevinwatters@gmail.com>
  50169. Reviewed by Kevin Ollivier.
  50170. Add a MIME mapping for the .htm extension to wx and GTK ports.
  50171. https://bugs.webkit.org/show_bug.cgi?id=22668
  50172. * platform/gtk/MIMETypeRegistryGtk.cpp:
  50173. (WebCore::):
  50174. * platform/wx/MimeTypeRegistryWx.cpp:
  50175. (WebCore::):
  50176. 2008-12-04 Kevin Watters <kevinwatters@gmail.com>
  50177. Reviewed by Kevin Ollivier.
  50178. Implement basic text paste support in wx and add notImplemented stubs
  50179. to catch other methods.
  50180. https://bugs.webkit.org/show_bug.cgi?id=22667
  50181. * platform/wx/PasteboardWx.cpp:
  50182. (WebCore::Pasteboard::canSmartReplace):
  50183. (WebCore::Pasteboard::plainText):
  50184. (WebCore::Pasteboard::documentFragment):
  50185. (WebCore::Pasteboard::writeImage):
  50186. 2008-12-04 Kevin Ollivier <kevino@theolliviers.com>
  50187. wx build fix for !USE(WXGC) build config.
  50188. * platform/graphics/wx/PathWx.cpp:
  50189. (WebCore::Path::contains):
  50190. (WebCore::Path::addLineTo):
  50191. (WebCore::Path::addQuadCurveTo):
  50192. (WebCore::Path::addBezierCurveTo):
  50193. (WebCore::Path::addArcTo):
  50194. (WebCore::Path::closeSubpath):
  50195. (WebCore::Path::addArc):
  50196. (WebCore::Path::addRect):
  50197. (WebCore::Path::addEllipse):
  50198. (WebCore::Path::transform):
  50199. (WebCore::Path::apply):
  50200. (WebCore::Path::isEmpty):
  50201. 2008-12-04 Kevin Watters <kevinwatters@gmail.com>
  50202. Reviewed by Kevin Ollivier.
  50203. Turn off styled controls until we can implement them properly.
  50204. https://bugs.webkit.org/show_bug.cgi?id=22662
  50205. * platform/wx/RenderThemeWx.cpp:
  50206. (WebCore::RenderThemeWx::isControlStyled):
  50207. 2008-12-04 Kevin Watters <kevinwatters@gmail.com>
  50208. Reviewed by Kevin Ollivier.
  50209. wx implementations for Path API.
  50210. https://bugs.webkit.org/show_bug.cgi?id=22661
  50211. * platform/graphics/wx/PathWx.cpp:
  50212. (WebCore::Path::~Path):
  50213. (WebCore::Path::contains):
  50214. (WebCore::Path::addLineTo):
  50215. (WebCore::Path::addQuadCurveTo):
  50216. (WebCore::Path::addBezierCurveTo):
  50217. (WebCore::Path::addArcTo):
  50218. (WebCore::Path::closeSubpath):
  50219. (WebCore::Path::addArc):
  50220. (WebCore::Path::addRect):
  50221. (WebCore::Path::addEllipse):
  50222. (WebCore::Path::transform):
  50223. (WebCore::Path::isEmpty):
  50224. 2008-12-04 Julien Chaffraix <jchaffraix@webkit.org>
  50225. Reviewed by Eric Seidel.
  50226. Bug 22564: Make HTML elements' constructors take a QualifiedName
  50227. https://bugs.webkit.org/show_bug.cgi?id=22564
  50228. Updated the remaining constructors.
  50229. * bindings/js/JSImageConstructor.cpp:
  50230. (WebCore::constructImage):
  50231. * dom/Document.cpp:
  50232. (WebCore::Document::getCSSCanvasElement):
  50233. * editing/DeleteButton.cpp:
  50234. (WebCore::DeleteButton::DeleteButton):
  50235. * html/HTMLAppletElement.cpp:
  50236. (WebCore::HTMLAppletElement::HTMLAppletElement):
  50237. * html/HTMLAppletElement.h:
  50238. * html/HTMLAreaElement.cpp:
  50239. (WebCore::HTMLAreaElement::HTMLAreaElement):
  50240. * html/HTMLAreaElement.h:
  50241. * html/HTMLBaseFontElement.cpp:
  50242. (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
  50243. * html/HTMLBaseFontElement.h:
  50244. * html/HTMLCanvasElement.cpp:
  50245. (WebCore::HTMLCanvasElement::HTMLCanvasElement):
  50246. * html/HTMLCanvasElement.h:
  50247. * html/HTMLElementFactory.cpp:
  50248. (WebCore::hrConstructor):
  50249. (WebCore::paragraphConstructor):
  50250. (WebCore::basefontConstructor):
  50251. (WebCore::fontConstructor):
  50252. (WebCore::anchorConstructor):
  50253. (WebCore::imageConstructor):
  50254. (WebCore::mapConstructor):
  50255. (WebCore::areaConstructor):
  50256. (WebCore::canvasConstructor):
  50257. (WebCore::appletConstructor):
  50258. (WebCore::embedConstructor):
  50259. (WebCore::objectConstructor):
  50260. (WebCore::paramConstructor):
  50261. (WebCore::scriptConstructor):
  50262. (WebCore::tableConstructor):
  50263. (WebCore::tableCaptionConstructor):
  50264. (WebCore::tableRowConstructor):
  50265. * html/HTMLEmbedElement.cpp:
  50266. (WebCore::HTMLEmbedElement::HTMLEmbedElement):
  50267. * html/HTMLEmbedElement.h:
  50268. * html/HTMLFontElement.cpp:
  50269. (WebCore::HTMLFontElement::HTMLFontElement):
  50270. * html/HTMLFontElement.h:
  50271. * html/HTMLHRElement.cpp:
  50272. (WebCore::HTMLHRElement::HTMLHRElement):
  50273. * html/HTMLHRElement.h:
  50274. * html/HTMLImageElement.cpp:
  50275. (WebCore::HTMLImageElement::HTMLImageElement):
  50276. * html/HTMLImageElement.h:
  50277. * html/HTMLMapElement.cpp:
  50278. (WebCore::HTMLMapElement::HTMLMapElement):
  50279. * html/HTMLMapElement.h:
  50280. * html/HTMLObjectElement.cpp:
  50281. (WebCore::HTMLObjectElement::HTMLObjectElement):
  50282. * html/HTMLObjectElement.h:
  50283. * html/HTMLParagraphElement.cpp:
  50284. (WebCore::HTMLParagraphElement::HTMLParagraphElement):
  50285. * html/HTMLParagraphElement.h:
  50286. * html/HTMLParamElement.cpp:
  50287. (WebCore::HTMLParamElement::HTMLParamElement):
  50288. * html/HTMLParamElement.h:
  50289. * html/HTMLParser.cpp:
  50290. (WebCore::HTMLParser::handleError):
  50291. (WebCore::HTMLParser::mapCreateErrorCheck):
  50292. (WebCore::HTMLParser::handleIsindex):
  50293. * html/HTMLScriptElement.cpp:
  50294. (WebCore::HTMLScriptElement::HTMLScriptElement):
  50295. * html/HTMLScriptElement.h:
  50296. * html/HTMLTableCaptionElement.cpp:
  50297. (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
  50298. * html/HTMLTableCaptionElement.h:
  50299. * html/HTMLTableElement.cpp:
  50300. (WebCore::HTMLTableElement::HTMLTableElement):
  50301. (WebCore::HTMLTableElement::createCaption):
  50302. (WebCore::HTMLTableElement::insertRow):
  50303. * html/HTMLTableElement.h:
  50304. * html/HTMLTableRowElement.cpp:
  50305. (WebCore::HTMLTableRowElement::HTMLTableRowElement):
  50306. * html/HTMLTableRowElement.h:
  50307. * html/HTMLTableSectionElement.cpp:
  50308. (WebCore::HTMLTableSectionElement::insertRow):
  50309. * html/HTMLViewSourceDocument.cpp:
  50310. (WebCore::HTMLViewSourceDocument::createContainingTable):
  50311. (WebCore::HTMLViewSourceDocument::addLine):
  50312. * loader/ImageDocument.cpp:
  50313. (WebCore::ImageDocumentElement::ImageDocumentElement):
  50314. 2008-12-04 Eric Seidel <eric@webkit.org>
  50315. No review, build fix only.
  50316. Add file missing from last commit.
  50317. * bindings/js/ScriptState.h: Added.
  50318. 2008-12-04 Dimitri Glazkov <dglazkov@chromium.org>
  50319. Reviewed by Geoff Garen.
  50320. Implement ScriptState abstraction (initially, a simple typedef)
  50321. as means of carrying exception information across bindings boundaries
  50322. and in a script engine-independent way.
  50323. * WebCore.vcproj/WebCore.vcproj:
  50324. * WebCore.xcodeproj/project.pbxproj:
  50325. * bindings/js/JSDOMBinding.cpp:
  50326. (WebCore::scriptStateFromNode):
  50327. * bindings/js/JSDOMBinding.h:
  50328. * bindings/js/JSNodeFilterCondition.h:
  50329. * bindings/js/ScriptState.h: Added.
  50330. * dom/NodeFilter.cpp:
  50331. (WebCore::NodeFilter::acceptNode):
  50332. * dom/NodeFilter.h:
  50333. (WebCore::NodeFilter::acceptNode):
  50334. * dom/NodeFilterCondition.cpp:
  50335. (WebCore::NodeFilterCondition::acceptNode):
  50336. * dom/NodeFilterCondition.h:
  50337. * dom/NodeIterator.cpp:
  50338. (WebCore::NodeIterator::nextNode):
  50339. (WebCore::NodeIterator::previousNode):
  50340. * dom/NodeIterator.h:
  50341. (WebCore::NodeIterator::nextNode):
  50342. (WebCore::NodeIterator::previousNode):
  50343. * dom/Traversal.cpp:
  50344. (WebCore::Traversal::acceptNode):
  50345. * dom/Traversal.h:
  50346. * dom/TreeWalker.cpp:
  50347. (WebCore::TreeWalker::parentNode):
  50348. (WebCore::TreeWalker::firstChild):
  50349. (WebCore::TreeWalker::lastChild):
  50350. (WebCore::TreeWalker::previousSibling):
  50351. (WebCore::TreeWalker::nextSibling):
  50352. (WebCore::TreeWalker::previousNode):
  50353. (WebCore::TreeWalker::nextNode):
  50354. * dom/TreeWalker.h:
  50355. (WebCore::TreeWalker::parentNode):
  50356. (WebCore::TreeWalker::firstChild):
  50357. (WebCore::TreeWalker::lastChild):
  50358. (WebCore::TreeWalker::previousSibling):
  50359. (WebCore::TreeWalker::nextSibling):
  50360. (WebCore::TreeWalker::previousNode):
  50361. (WebCore::TreeWalker::nextNode):
  50362. 2008-12-04 Pierre-Olivier Latour <pol@apple.com>
  50363. Reviewed by Dan Bernstein.
  50364. Fixed pauseTransitionAtTimeOnElementWithId() in DRT asserting when passed invalid property name
  50365. and potential similar issue with pauseAnimationAtTimeOnElementWithId().
  50366. https://bugs.webkit.org/show_bug.cgi?id=22641
  50367. * page/animation/CompositeAnimation.cpp:
  50368. (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime):
  50369. (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
  50370. 2008-12-04 Dimitri Glazkov <dglazkov@chromium.org>
  50371. Reviewed by Darin Adler.
  50372. Remove unused Completion.h include.
  50373. * html/CanvasRenderingContext2D.cpp: Removed Completion.h include.
  50374. 2008-11-13 David Hyatt <hyatt@apple.com>
  50375. Fix a bug in ScrollView's refactoring. An isVisible check should have been isSelfVisible.
  50376. Reviewed by Darin Adler
  50377. * platform/ScrollView.cpp:
  50378. (WebCore::ScrollView::setParentVisible):
  50379. 2008-12-04 Friedemann Kleint <friedemann.kleint@nokia.com>
  50380. Reviewed by Tor Arne Vestbø.
  50381. Fix small translation glitch in the Qt file chooser.
  50382. * platform/qt/FileChooserQt.cpp:
  50383. (WebCore::FileChooser::basenameForWidth):
  50384. 2008-12-04 Tor Arne Vestbø <tavestbo@trolltech.com>
  50385. Rubber-stamped by Simon Hausmann.
  50386. Blacklist Silverlight plugin on Qt/Mac until supported
  50387. Currently the plugin crashes with a corrupted stack trace, possibly
  50388. related to https://bugs.webkit.org/show_bug.cgi?id=20635
  50389. * plugins/mac/PluginPackageMac.cpp:
  50390. (WebCore::PluginPackage::fetchInfo):
  50391. (WebCore::PluginPackage::isPluginBlacklisted):
  50392. 2008-12-03 Dmitry Titov <dimich@chromium.org>
  50393. Reviewed by Alexey Proskuryakov.
  50394. Fix non-Mac build.
  50395. * page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  50396. 2008-12-03 David Levin <levin@chromium.org>
  50397. Reviewed by Alexey Proskuryakov.
  50398. Remove uses of document() in XMLHttpRequest where simple.
  50399. https://bugs.webkit.org/show_bug.cgi?id=22619
  50400. * xml/XMLHttpRequest.cpp:
  50401. (WebCore::XMLHttpRequest::responseXML):
  50402. Return NULL in the worker case which is according to spec (and avoids using document()).
  50403. (WebCore::XMLHttpRequest::callReadyStateChangeListener):
  50404. (WebCore::XMLHttpRequest::initSend):
  50405. Use scriptExecutionContext() instead of document().
  50406. 2008-12-03 David Levin <levin@chromium.org>
  50407. Reviewed by Alexey Proskuryakov.
  50408. Make ScriptExecutionContextTaskWorkerTask::performTask a pure virtual function.
  50409. https://bugs.webkit.org/show_bug.cgi?id=22642
  50410. * dom/Document.cpp:
  50411. (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
  50412. (WebCore::ScriptExecutionContextTaskTimer::fired):
  50413. (WebCore::PerformTaskContext::PerformTaskContext):
  50414. (WebCore::performTask):
  50415. (WebCore::Document::postTask):
  50416. * dom/Document.h:
  50417. * dom/ScriptExecutionContext.cpp:
  50418. * dom/ScriptExecutionContext.h:
  50419. * dom/WorkerContext.cpp:
  50420. (WebCore::ScriptExecutionContextTaskWorkerTask::create):
  50421. (WebCore::ScriptExecutionContextTaskWorkerTask::ScriptExecutionContextTaskWorkerTask):
  50422. (WebCore::ScriptExecutionContextTaskWorkerTask::performTask):
  50423. (WebCore::WorkerContext::postTask):
  50424. * dom/WorkerContext.h:
  50425. 2008-12-03 Dmitry Titov <dimich@chromium.org>
  50426. Reviewed by Alexey Proskuryakov.
  50427. Using ActiveDOMObject as base class for DOMTimer.
  50428. https://bugs.webkit.org/show_bug.cgi?id=22620
  50429. Using ActiveDOMObject simplifies the code because ActiveDOMObject
  50430. is wired for stop/pause/resume on loading/unloading/caching the page etc
  50431. so the timer-specific code that does the same can be removed.
  50432. In addition, timers can be now paused/resumed 'in place' which
  50433. makes it unnecessary to 'serialize' them into special PausedTimeouts
  50434. instance, so pause/resumeTimeouts implementation in JSDOMWindowBase can also be removed.
  50435. Also, moving TimeoutMap from JSDOMWindowBase to Document matches lifetime
  50436. of timeouts and makes it possible to not roundtrip them via PausedTimeouts
  50437. every time when JSDOMWindow wrapper is destroyed while the page is in the b/f cache.
  50438. Timeouts are now paused with other ActiveDOMObjects:
  50439. - before creating CachedPage in FrameLoader::commitProvisionalLoad()
  50440. - in JavaScriptDebugServer::setJavaScriptPaused
  50441. - during modal UI operations in Chrome::*
  50442. this is equivalent to previous usage of JSDOMWindowBase::pauseTimeouts()
  50443. Timeouts are stopped to prevent future firing from:
  50444. - FrameLoader::clear()
  50445. - FrameLoader::frameDetached()
  50446. this is equivalent to previous usage of JSDOMWindowBase::clearAllTimeouts()
  50447. This is also one of the steps to having timers in Workers. See the plan of
  50448. the next steps in the bug above.
  50449. * bindings/js/DOMTimer.cpp:
  50450. (WebCore::DOMTimer::DOMTimer):
  50451. (WebCore::DOMTimer::fired):
  50452. (WebCore::DOMTimer::hasPendingActivity):
  50453. (WebCore::DOMTimer::contextDestroyed):
  50454. (WebCore::DOMTimer::stop):
  50455. (WebCore::DOMTimer::suspend):
  50456. (WebCore::DOMTimer::resume):
  50457. (WebCore::DOMTimer::canSuspend): Implemented ActiveDOMObject methods.
  50458. * bindings/js/DOMTimer.h:
  50459. * bindings/js/JSDOMBinding.cpp: ActiveDOMObject can have no JS wrapper
  50460. (WebCore::markActiveObjectsForContext):
  50461. * bindings/js/JSDOMWindowBase.cpp:
  50462. (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  50463. (WebCore::JSDOMWindowBase::clear):
  50464. (WebCore::JSDOMWindowBase::installTimeout):
  50465. (WebCore::JSDOMWindowBase::removeTimeout):
  50466. (WebCore::JSDOMWindowBase::timerFired):
  50467. (WebCore::JSDOMWindowBase::disconnectFrame):
  50468. * bindings/js/JSDOMWindowBase.h:
  50469. * bindings/js/ScriptController.cpp:
  50470. * bindings/js/ScriptController.h:
  50471. * dom/Document.cpp: Document now holds a hash map id->timeout
  50472. (WebCore::Document::addTimeout):
  50473. (WebCore::Document::removeTimeout):
  50474. (WebCore::Document::findTimeout):
  50475. * dom/Document.h:
  50476. * history/CachedPage.cpp:
  50477. (WebCore::CachedPage::CachedPage):
  50478. (WebCore::CachedPage::restore):
  50479. (WebCore::CachedPage::clear):
  50480. * history/CachedPage.h:
  50481. * inspector/JavaScriptDebugServer.cpp:
  50482. (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
  50483. (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  50484. * inspector/JavaScriptDebugServer.h:
  50485. * loader/FrameLoader.cpp:
  50486. (WebCore::FrameLoader::commitProvisionalLoad):
  50487. removed clearAllTimeouts since all ActiveDOMObjects will be stopped in FrameLoader::clear();
  50488. I don't see how the old comment can be correct - the code in the same method proceeds to invoke 'onunload'
  50489. and then calls into client which can be external code and can cause any active object created in onunload
  50490. to fire. We can stop them all before firing onunload but it does not make a lot of sense.
  50491. I have a test to go with the next patch which verifies that timers set in onunload do not fire.
  50492. (WebCore::FrameLoader::open):
  50493. * page/Chrome.cpp:
  50494. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  50495. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  50496. 2008-12-03 Justin Garcia <justin.garcia@apple.com>
  50497. Reviewed by Beth Dakin.
  50498. <rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
  50499. In SnowLeopard, Mail occasionally adds an empty, unstyled paragraph at the
  50500. end of pasted content so that users don't get stuck with non-standard pargraph
  50501. spacing. This content threw off our handling of interchange newlines. Any interchange
  50502. newline, regardless of it's position in the incoming fragment was considered to be
  50503. "at the start" of the fragment, and would result in us inserting in a newline before
  50504. inserted content. This patch makes the checks for interchange newlines more strict,
  50505. and treats interchange newlines found elsewhere as normal <br>s.
  50506. * editing/ReplaceSelectionCommand.cpp:
  50507. (WebCore::ReplacementFragment::ReplacementFragment):
  50508. (WebCore::ReplacementFragment::removeInterchangeNodes):
  50509. * editing/VisiblePosition.cpp:
  50510. (WebCore::VisiblePosition::init):
  50511. (WebCore::VisiblePosition::canonicalPosition):
  50512. * editing/VisiblePosition.h:
  50513. 2008-12-03 Eric Seidel <eric@webkit.org>
  50514. Rubber-stamped by David Hyatt.
  50515. Bring the WebCore chromium build a couple steps closer to building.
  50516. * WebCore.scons:
  50517. 2008-12-03 Kevin Ollivier <kevino@theolliviers.com>
  50518. wx build fix.
  50519. * WebCoreSources.bkl:
  50520. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50521. Reviewed by George Staikos.
  50522. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22636
  50523. Implement WML variable substitution & validation.
  50524. Created a framework for scriptable WML layout tests, that are able to test variable substiution & validation.
  50525. Tests: wml/variable-reference-invalid-character.html
  50526. wml/variable-reference-valid.html
  50527. * wml/WMLVariables.cpp:
  50528. (WebCore::isValidFirstVariableNameCharacter):
  50529. (WebCore::isValidVariableNameCharacter):
  50530. (WebCore::isValidVariableEscapingModeString):
  50531. (WebCore::isValidVariableName):
  50532. (WebCore::containsVariableReference):
  50533. (WebCore::substituteVariableReferences):
  50534. * wml/WMLVariables.h:
  50535. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50536. Reviewed by Cameron Zwarich.
  50537. Further preparations for WML layout tests.
  50538. - Enable variable substitution in Text.cpp - if the parent is a WMLElement derived class.
  50539. - Dump WMLMessageSource messages to the console, just like it's done for JSMessageSource
  50540. - Add helper method in Document.idl, to reset the WML page state to a well-known default state.
  50541. (will be used in the upcoming LayoutTests/wml testcases)
  50542. * dom/Document.cpp:
  50543. (WebCore::Document::resetWMLPageState):
  50544. * dom/Document.h:
  50545. * dom/Document.idl:
  50546. * dom/Text.cpp:
  50547. (WebCore::Text::insertedIntoDocument):
  50548. * dom/Text.h:
  50549. * page/Console.cpp:
  50550. (WebCore::Console::addMessage):
  50551. * wml/WMLPageState.h: Readd heper function
  50552. (WebCore::WMLPageState::hasVariables):
  50553. 2008-12-03 Antti Koivisto <antti@apple.com>
  50554. Reviewed by Sam Weinig.
  50555. Don't leak selectors in case selector list parsing failed.
  50556. * css/CSSGrammar.y:
  50557. * css/CSSParser.cpp:
  50558. (WebCore::CSSParser::~CSSParser):
  50559. 2008-12-03 Chris Marrin <cmarrin@apple.com>
  50560. Reviewed by Dave Hyatt.
  50561. Fix https://bugs.webkit.org/show_bug.cgi?id=22520
  50562. This is a regression (causes a crash of LayoutTests/animations/transform-animation-event-destroy-element.html).
  50563. This patch fixes the testcase.
  50564. This is another case of animations getting destroyed in the end animation callback and causing dangling
  50565. pointers on return. This one involves iterating over the CompositeAnimation, which has been destroyed.
  50566. So I now check for a null m_object pointer (which is nullified when the CompositeAnimation is destroyed)
  50567. and skip that call.
  50568. * page/animation/AnimationBase.cpp:
  50569. (WebCore::AnimationBase::updateStateMachine):
  50570. 2008-12-03 Antti Koivisto <antti@apple.com>
  50571. Reviewed by Darin Adler.
  50572. https://bugs.webkit.org/show_bug.cgi?id=22379
  50573. Make CSSOM use less memory
  50574. Reduce size of the CSSSelector by one more pointer by using an array
  50575. instead of a linked list to store them.
  50576. * WebCore.xcodeproj/project.pbxproj:
  50577. * css/CSSGrammar.y:
  50578. * css/CSSParser.cpp:
  50579. (WebCore::CSSParser::CSSParser):
  50580. (WebCore::CSSParser::parseSelector):
  50581. (WebCore::CSSParser::createStyleRule):
  50582. * css/CSSParser.h:
  50583. (WebCore::CSSParser::reusableSelectorVector):
  50584. * css/CSSSelector.h:
  50585. (WebCore::CSSSelector::CSSSelector):
  50586. (WebCore::CSSSelector::~CSSSelector):
  50587. (WebCore::CSSSelector::isLastInSelectorList):
  50588. (WebCore::CSSSelector::setLastInSelectorList):
  50589. * css/CSSStyleRule.cpp:
  50590. (WebCore::CSSStyleRule::CSSStyleRule):
  50591. (WebCore::CSSStyleRule::~CSSStyleRule):
  50592. (WebCore::CSSStyleRule::selectorText):
  50593. * css/CSSStyleRule.h:
  50594. (WebCore::CSSStyleRule::adoptSelectorVector):
  50595. (WebCore::CSSStyleRule::selectorList):
  50596. * css/CSSStyleSelector.cpp:
  50597. (WebCore::CSSRuleSet::addRulesFromSheet):
  50598. * dom/Node.cpp:
  50599. (WebCore::forEachSelector):
  50600. (WebCore::selectorNeedsNamespaceResolution):
  50601. (WebCore::Node::querySelector):
  50602. (WebCore::Node::querySelectorAll):
  50603. * dom/SelectorNodeList.cpp:
  50604. (WebCore::createSelectorNodeList):
  50605. * dom/SelectorNodeList.h:
  50606. 2008-12-03 Alexey Proskuryakov <ap@webkit.org>
  50607. Reviewed by Darin Adler.
  50608. https://bugs.webkit.org/show_bug.cgi?id=22630
  50609. Assertion failure in XMLHttpRequest::contextDestroyed
  50610. Test: http/tests/xmlhttprequest/close-window.html
  50611. * loader/FrameLoader.cpp:
  50612. (WebCore::FrameLoader::clear):
  50613. (WebCore::FrameLoader::commitProvisionalLoad):
  50614. Move stopping active objects to clear(), so that closing a window is also covered.
  50615. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): Protect the object in abort(),
  50616. because internalAbort() deref()'s.
  50617. 2008-12-03 Dean Jackson <dino@apple.com>
  50618. Reviewed by Dan Bernstein.
  50619. Implement CSS 3 <angle> turn unit and support it
  50620. in rotations.
  50621. https://bugs.webkit.org/show_bug.cgi?id=22497
  50622. * css/CSSGrammar.y:
  50623. * css/CSSParser.cpp:
  50624. (WebCore::CSSParser::validUnit):
  50625. (WebCore::unitFromString):
  50626. (WebCore::CSSParser::lex):
  50627. * css/CSSPrimitiveValue.cpp:
  50628. (WebCore::CSSPrimitiveValue::cssText):
  50629. (WebCore::CSSPrimitiveValue::parserValue):
  50630. * css/CSSPrimitiveValue.h:
  50631. (WebCore::CSSPrimitiveValue::):
  50632. * css/CSSStyleSelector.cpp:
  50633. (WebCore::CSSStyleSelector::createTransformOperations):
  50634. * css/tokenizer.flex:
  50635. 2008-12-03 Dirk Schulze <krit@webkit.org>
  50636. Reviewed by Nikolas Zimmermann.
  50637. Make use of the gradient code in GraphicsContext and get rid of most of the
  50638. platform dependent code.
  50639. SVG should use the new Gradient support on GraphicsContext
  50640. https://bugs.webkit.org/show_bug.cgi?id=20543
  50641. * GNUmakefile.am:
  50642. * WebCore.pro:
  50643. * WebCore.vcproj/WebCore.vcproj:
  50644. * WebCore.xcodeproj/project.pbxproj:
  50645. * platform/graphics/FloatSize.h:
  50646. (WebCore::FloatSize::shrunkTo):
  50647. * svg/SVGLinearGradientElement.cpp:
  50648. (WebCore::SVGLinearGradientElement::buildGradient):
  50649. * svg/SVGRadialGradientElement.cpp:
  50650. (WebCore::SVGRadialGradientElement::buildGradient):
  50651. * svg/graphics/SVGPaintServer.h:
  50652. * svg/graphics/SVGPaintServerGradient.cpp:
  50653. (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
  50654. (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
  50655. (WebCore::SVGPaintServerGradient::gradient):
  50656. (WebCore::SVGPaintServerGradient::setGradient):
  50657. (WebCore::findTextRootObject):
  50658. (WebCore::createMaskAndSwapContextForTextGradient):
  50659. (WebCore::clipToTextMask):
  50660. (WebCore::SVGPaintServerGradient::setup):
  50661. (WebCore::SVGPaintServerGradient::renderPath):
  50662. (WebCore::SVGPaintServerGradient::teardown):
  50663. * svg/graphics/SVGPaintServerGradient.h:
  50664. (WebCore::SVGPaintServerGradient::setGradientStops):
  50665. (WebCore::SVGPaintServerGradient::gradientStops):
  50666. * svg/graphics/SVGPaintServerLinearGradient.h:
  50667. * svg/graphics/SVGPaintServerRadialGradient.h:
  50668. * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: Removed.
  50669. * svg/graphics/cg/SVGPaintServerCg.cpp:
  50670. * svg/graphics/cg/SVGPaintServerGradientCg.cpp: Removed.
  50671. * svg/graphics/qt/SVGPaintServerGradientQt.cpp: Removed.
  50672. * svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp: Removed.
  50673. * svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp: Removed.
  50674. 2008-12-03 Sam Weinig <sam@webkit.org>
  50675. Reviewed by Mark Rowe.
  50676. Fix formatting.
  50677. * css/CSSSelector.h:
  50678. (WebCore::CSSSelector::createRareData):
  50679. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50680. Reviewed by Adam Roben.
  50681. As Adam Roben noticed, synchronize MessageSource enum with Console.js, and add a comment.
  50682. * inspector/front-end/Console.js:
  50683. * page/Console.h:
  50684. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50685. Reviewed by Alexey Proskuryakov.
  50686. Next steps to make LayoutTests work:
  50687. Never access the main frame from WMLRefreshElement/WMLCardElement, but
  50688. the current documents frame (WML layout tests will run in an <iframe>)
  50689. Prepare WMLErrorHandling for the case that no tokenizer is available anymore
  50690. -> report errors through Console::addMessage(), so they get logged in the
  50691. expected layout test results.
  50692. * wml/WMLCardElement.cpp:
  50693. (WebCore::WMLCardElement::setActiveCardInDocument):
  50694. * wml/WMLErrorHandling.cpp:
  50695. (WebCore::reportWMLError):
  50696. (WebCore::errorMessageForErrorCode):
  50697. * wml/WMLErrorHandling.h:
  50698. * wml/WMLRefreshElement.cpp:
  50699. (WebCore::WMLRefreshElement::executeTask):
  50700. * page/Console.cpp: Handle WMLMessageSource.
  50701. (WebCore::printMessageSourceAndLevelPrefix):
  50702. * page/Console.h: Add WMLMessageSource.
  50703. (WebCore::):
  50704. 2008-12-03 Tor Arne Vestbø <tavestbo@trolltech.com>
  50705. Reviewed by Simon Hausmann.
  50706. Allow passing jsNull and jsUndefined to Qt plugins
  50707. Currently limited to functions with QString and QVariant arguments,
  50708. and properties of these types. Both jsNull and jsUndefined ends up
  50709. as default-constructed QStrings and QVariants, which means you can
  50710. check for isEmpty() and isValid() in the native plugin code.
  50711. Based on patches by Jade Han <jade.han@nokia.com>
  50712. * bridge/qt/qt_runtime.cpp:
  50713. (JSC::Bindings::convertValueToQVariant):
  50714. (JSC::Bindings::findMethodIndex):
  50715. 2008-12-03 Trenton Schulz <trenton.schulz@nokia.com>
  50716. Reviewed by Simon Hausmann.
  50717. Fix the build with Qt for Mac OS X.
  50718. * platform/PurgeableBuffer.h: Use the dummy wrappers for now.
  50719. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50720. Reviewed by Alexey Proskuryakov.
  50721. Fix error handling in WMLSetvarElement. If an invalid variable reference is contained
  50722. in the 'name' attribute of <setvar>, a 'WMLErrorInvalidVariableName' error should be
  50723. reported, instead of 'WMLErrorInvalidVariableReference'.
  50724. * wml/WMLElement.cpp:
  50725. (WebCore::WMLElement::parseValueSubstitutingVariableReferences):
  50726. (WebCore::WMLElement::parseValueForbiddingVariableReferences):
  50727. * wml/WMLElement.h:
  50728. * wml/WMLSetvarElement.cpp:
  50729. (WebCore::WMLSetvarElement::parseMappedAttribute):
  50730. * wml/WMLSetvarElement.h:
  50731. (WebCore::WMLSetvarElement::name):
  50732. (WebCore::WMLSetvarElement::value):
  50733. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50734. Reviewed by Alexey Proskuryakov.
  50735. Preparations to get WML layout tests going.
  50736. Make WMLPageState an OwnPtr to Page, and let Page create it on demand.
  50737. * page/Page.cpp:
  50738. (WebCore::Page::Page):
  50739. (WebCore::Page::wmlPageState):
  50740. * page/Page.h:
  50741. * wml/WMLDocument.cpp:
  50742. (WebCore::WMLDocument::WMLDocument):
  50743. (WebCore::WMLDocument::finishedParsing):
  50744. (WebCore::wmlPageStateForDocument):
  50745. * wml/WMLPageState.h: Don't inherit from RefCounted anymore.
  50746. (WebCore::WMLPageState::hasVariables): Remove helper function.
  50747. 2008-12-03 Alexey Proskuryakov <ap@webkit.org>
  50748. Reviewed by Mark Rowe.
  50749. https://bugs.webkit.org/show_bug.cgi?id=22627
  50750. fast/workers/worker-terminate.html fails randomly
  50751. The problem is that worker termination uses script timeouts, so an InterruptedExecutionError
  50752. is raised, and it sometimes reaches the main thread.
  50753. * dom/WorkerMessagingProxy.cpp:
  50754. (WebCore::WorkerExceptionTask::create):
  50755. (WebCore::WorkerExceptionTask::WorkerExceptionTask):
  50756. (WebCore::WorkerExceptionTask::performTask):
  50757. (WebCore::WorkerMessagingProxy::postWorkerException):
  50758. * dom/WorkerMessagingProxy.h:
  50759. Ignore exceptions that happen in terminated workers.
  50760. 2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  50761. Reviewed by Alexey Proskuryakov.
  50762. Remove some unncessary includes.
  50763. * wml/WMLAccessElement.cpp:
  50764. * wml/WMLDocument.h:
  50765. * wml/WMLRefreshElement.cpp:
  50766. 2008-12-03 Alexey Proskuryakov <ap@webkit.org>
  50767. Rubber-stamped by Cameron Zwarich and Adam Roben.
  50768. Fix a typo: m_executionForbidded.
  50769. * bindings/js/WorkerScriptController.cpp:
  50770. (WebCore::WorkerScriptController::WorkerScriptController):
  50771. (WebCore::WorkerScriptController::evaluate):
  50772. (WebCore::WorkerScriptController::forbidExecution):
  50773. * bindings/js/WorkerScriptController.h:
  50774. 2008-12-03 Dean McNamee <deanm@chromium.org>
  50775. Bug 22623: Uninitialized memory access in cache parsing code
  50776. <https://bugs.webkit.org/show_bug.cgi?id=22623>
  50777. Reviewed by David Kilzer.
  50778. Initialize m_haveParsedCacheControlHeader and m_haveParsedPragmaHeader.
  50779. * platform/network/ResourceResponseBase.h:
  50780. (WebCore::ResourceResponseBase::ResourceResponseBase):
  50781. 2008-12-03 Antti Koivisto <antti@apple.com>
  50782. Probable build fix.
  50783. * WebCoreSources.bkl:
  50784. 2008-12-03 Antti Koivisto <antti@apple.com>
  50785. Forgot to commit these.
  50786. * dom/Node.cpp:
  50787. (WebCore::forEachTagSelector):
  50788. (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
  50789. (WebCore::Node::querySelector):
  50790. * dom/SelectorNodeList.cpp:
  50791. (WebCore::createSelectorNodeList):
  50792. 2008-12-03 Antti Koivisto <antti@apple.com>
  50793. Reviewed by Dan Bernstein and Mark Rowe.
  50794. https://bugs.webkit.org/show_bug.cgi?id=22379
  50795. Make CSSOM use less memory
  50796. Reduce size of the CSSSelector by 3/8 by moving rarely used fields to a rare data
  50797. struct. Browsing around with some instrumentation showed that ~0.1% of all selectors
  50798. encountered had rare data.
  50799. This also eliminates the CSSNthSelector subclass which will make possible to store
  50800. CSSSelectors in an array instead of a linked list for futher memory savings.
  50801. * css/CSSGrammar.y:
  50802. * css/CSSNthSelector.cpp: Removed.
  50803. * css/CSSNthSelector.h: Removed.
  50804. * css/CSSParser.cpp:
  50805. (WebCore::CSSParser::createFloatingSelector):
  50806. * css/CSSParser.h:
  50807. * css/CSSSelector.cpp:
  50808. (WebCore::CSSSelector::specificity):
  50809. (WebCore::CSSSelector::operator==):
  50810. (WebCore::CSSSelector::selectorText):
  50811. (WebCore::CSSSelector::setTagHistory):
  50812. (WebCore::CSSSelector::attribute):
  50813. (WebCore::CSSSelector::setAttribute):
  50814. (WebCore::CSSSelector::setArgument):
  50815. (WebCore::CSSSelector::setSimpleSelector):
  50816. (WebCore::CSSSelector::parseNth):
  50817. (WebCore::CSSSelector::matchNth):
  50818. (WebCore::CSSSelector::RareData::parseNth):
  50819. (WebCore::CSSSelector::RareData::matchNth):
  50820. * css/CSSSelector.h:
  50821. (WebCore::CSSSelector::CSSSelector):
  50822. (WebCore::CSSSelector::~CSSSelector):
  50823. (WebCore::CSSSelector::tagHistory):
  50824. (WebCore::CSSSelector::hasAttribute):
  50825. (WebCore::CSSSelector::argument):
  50826. (WebCore::CSSSelector::simpleSelector):
  50827. (WebCore::CSSSelector::RareData::RareData):
  50828. (WebCore::CSSSelector::createRareData):
  50829. (WebCore::CSSSelector::):
  50830. * css/CSSStyleSelector.cpp:
  50831. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  50832. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  50833. 2008-12-03 Jian Li <jianli@chromium.org>
  50834. Reviewed by Alexey Proskuryakov.
  50835. Remove unneeded included file in WorkerThread.cpp.
  50836. https://bugs.webkit.org/show_bug.cgi?id=22613
  50837. * dom/WorkerThread.cpp: No need to include JSWorkerContext.h.
  50838. 2008-12-02 Alexey Proskuryakov <ap@webkit.org>
  50839. Reviewed by Maciej Stachowiak.
  50840. https://bugs.webkit.org/show_bug.cgi?id=22543
  50841. Consolidate ActiveDOMObject page cache interaction
  50842. Test: http/tests/xmlhttprequest/abort-on-leaving-page.html
  50843. * dom/ActiveDOMObject.cpp:
  50844. (WebCore::ActiveDOMObject::canSuspend):
  50845. (WebCore::ActiveDOMObject::suspend):
  50846. (WebCore::ActiveDOMObject::resume):
  50847. * dom/ActiveDOMObject.h:
  50848. * dom/ScriptExecutionContext.cpp:
  50849. (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
  50850. (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
  50851. (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
  50852. * dom/ScriptExecutionContext.h:
  50853. Added methods for suspending and resuming active objects.
  50854. * dom/Worker.cpp:
  50855. (WebCore::Worker::canSuspend):
  50856. (WebCore::Worker::stop):
  50857. * dom/Worker.h:
  50858. Workers cannot be suspended yet. This is a change in behavior, as workers used to keep
  50859. running until their owner was destroyed.
  50860. * loader/FrameLoader.cpp:
  50861. (WebCore::FrameLoader::stopLoading): No longer call stopActiveDOMObjects() here, because
  50862. their activity is not necessarily loading.
  50863. (WebCore::FrameLoader::canCachePage): Can only cache if all active objects can be suspended.
  50864. Previously, stopLoading() cancelled outstanding XMLHttpRequests, which made the page
  50865. uncacheable due to no-null main document error.
  50866. (WebCore::FrameLoader::commitProvisionalLoad): Suspend or stop active objects, depending on
  50867. whether the document will be cached.
  50868. (WebCore::FrameLoader::frameDetached): Stop active objects to let them clean up before their
  50869. context is destroyed.
  50870. * xml/XMLHttpRequest.h: added canSuspend().
  50871. * xml/XMLHttpRequest.cpp:
  50872. (WebCore::XMLHttpRequest::canSuspend): Only XHRs that are not loading can be suspended.
  50873. (WebCore::XMLHttpRequest::stop): Call abort() instead of internalAbort() to dispatch events
  50874. for Firefox compatibility. This is a change in behavior that helps test that requests do
  50875. get aborted.
  50876. (WebCore::XMLHttpRequest::contextDestroyed): The request must have been stopped by now, so
  50877. assert that.
  50878. 2008-12-02 Chris Fleizach <cfleizach@apple.com>
  50879. Reviewed by Beth Dakin.
  50880. Bug 22606: Can <th> serves as the AXTitleUIElement for <td>?
  50881. Test: accessibility/th-as-title-ui.html
  50882. * page/AccessibilityObject.h:
  50883. (WebCore::AccessibilityObject::isGroup):
  50884. * page/AccessibilityRenderObject.cpp:
  50885. (WebCore::AccessibilityRenderObject::isGroup):
  50886. * page/AccessibilityRenderObject.h:
  50887. * page/AccessibilityTableCell.cpp:
  50888. (WebCore::AccessibilityTableCell::rowIndexRange):
  50889. (WebCore::AccessibilityTableCell::columnIndexRange):
  50890. (WebCore::AccessibilityTableCell::titleUIElement):
  50891. * page/AccessibilityTableCell.h:
  50892. * page/mac/AccessibilityObjectWrapper.mm:
  50893. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  50894. 2008-12-02 Simon Fraser <simon.fraser@apple.com>
  50895. Reviewed by Dave Hyatt
  50896. https://bugs.webkit.org/show_bug.cgi?id=22472
  50897. Override absoluteClippedOverflowRect() in RenderReplaced to return a rect
  50898. that is large enough to encompass the selection, so that the repainting of
  50899. selected replaced elements works correctly.
  50900. Test: fast/repaint/selected-replaced.html
  50901. * rendering/RenderReplaced.cpp:
  50902. (WebCore::RenderReplaced::selectionRect):
  50903. (WebCore::RenderReplaced::localSelectionRect):
  50904. (WebCore::RenderReplaced::absoluteClippedOverflowRect):
  50905. * rendering/RenderReplaced.h:
  50906. 2008-12-02 Gregory Hughes <ghughes@apple.com>
  50907. Reviewed by Beth Dakin.
  50908. Bug 22513: ZOOM: text selection does not send correct zoom bounds
  50909. When zoomed, text selection must send the zoom bounds in flipped
  50910. screen coordinates.
  50911. * editing/mac/SelectionControllerMac.mm:
  50912. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  50913. * page/mac/WebCoreViewFactory.h:
  50914. 2008-12-02 Dean Jackson <dino@apple.com>
  50915. Reviewed by Sam Weinig.
  50916. Remove support for 'now' from CSS (was
  50917. erroneously added to transition and animation delay)
  50918. https://bugs.webkit.org/show_bug.cgi?id=22571
  50919. * css/CSSParser.cpp:
  50920. (WebCore::CSSParser::parseAnimationDelay):
  50921. * css/CSSStyleSelector.cpp:
  50922. (WebCore::CSSStyleSelector::mapAnimationDelay):
  50923. * css/CSSValueKeywords.in:
  50924. 2008-12-02 Eric Seidel <eric@webkit.org>
  50925. Build fix, no review.
  50926. Fix the Mac and gtk builds:
  50927. Don't use a float to hold a double.
  50928. Remove a now duplicate symbol.
  50929. * page/Frame.cpp:
  50930. (WebCore::Frame::selectionLayoutChanged):
  50931. * platform/gtk/TemporaryLinkStubs.cpp:
  50932. 2008-12-02 Chris Fleizach <cfleizach@apple.com>
  50933. Bug 22596: Some elements don't report AXBlockQuoteLevel
  50934. https://bugs.webkit.org/show_bug.cgi?id=22596
  50935. Reviewed by John Sullivan.
  50936. * page/mac/AccessibilityObjectWrapper.mm:
  50937. (blockquoteLevel):
  50938. (AXAttributeStringSetBlockquoteLevel):
  50939. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  50940. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  50941. 2008-12-02 Dean McNamee <deanm@chromium.org>
  50942. Reviewed by Eric Seidel.
  50943. Correctly handle a theme returning a non-blinking interval. We should
  50944. not set any timers when the interval is 0 (non-blinking), otherwise we
  50945. repeatedly set and destroy a blinking timer, causing a paint and timer
  50946. storm. This is applicable to GTK and Windows, where a user can set a
  50947. non-blinking caret in their system preferences.
  50948. Renamed caretBlinkFrequency to the more accurate caretBlinkInterval.
  50949. * page/Frame.cpp:
  50950. (WebCore::Frame::selectionLayoutChanged):
  50951. * platform/Theme.h:
  50952. (WebCore::Theme::caretBlinkInterval):
  50953. * platform/gtk/RenderThemeGtk.cpp:
  50954. (WebCore::RenderThemeGtk::caretBlinkInterval):
  50955. * platform/gtk/RenderThemeGtk.h:
  50956. * rendering/RenderTheme.h:
  50957. (WebCore::RenderTheme::caretBlinkInterval):
  50958. 2008-12-02 David Levin <levin@chromium.org>
  50959. Reviewed by Eric Seidel.
  50960. https://bugs.webkit.org/show_bug.cgi?id=22538
  50961. startsWith uses find which searches through the whole string if no match is found.
  50962. Using reverseFind with an index of 0 has the benefit of only searching for the match
  50963. at the beginning of the string. This may only be a small benefit in the overall program,
  50964. but it may help in some cases when the string is big.
  50965. No observable change in behavior, so no test.
  50966. * platform/text/StringImpl.h:
  50967. (WebCore::StringImpl::startsWith):
  50968. 2008-10-29 Eric Seidel <eric@webkit.org>
  50969. Reviewed by Darin Adler.
  50970. Wrap a JSC-only hack in a USE(JSC) block to fix the v8 build.
  50971. https://bugs.webkit.org/show_bug.cgi?id=21951
  50972. * svg/SVGElementInstance.cpp:
  50973. (WebCore::SVGElementInstance::forgetWrapper):
  50974. 2008-12-02 Eric Seidel <eric@webkit.org>
  50975. Reviewed by Darin Adler.
  50976. Add an ASSERT to try and catch the root cause of:
  50977. https://bugs.webkit.org/show_bug.cgi?id=22168
  50978. http://code.google.com/p/chromium/issues/detail?id=4122
  50979. * editing/TextIterator.cpp:
  50980. (WebCore::TextIterator::emitText):
  50981. 2008-12-02 Brent Fulgham <bfulgham@gmail.com>
  50982. Reviewed by Adam Roben.
  50983. Remove some CG-specific code from the Windows Cairo build.
  50984. https://bugs.webkit.org/show_bug.cgi?id=22586
  50985. No new test cases since this update should create no user-visible
  50986. changes, and should be fully covered by the existing regression
  50987. tests.
  50988. * WebCore.vcproj/WebCore.vcproj: Remove FontDatabase from
  50989. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  50990. (WebCore::focusRingColor): Add stub method
  50991. * platform/win/TemporaryLinkStubs.cpp:
  50992. (WebCore::populateFontDatabase): Add stub method.
  50993. 2008-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  50994. Reviewed by Tor Arne Vestbø.
  50995. MinGW compilation fix for PluginPackageWin.cpp
  50996. https://bugs.webkit.org/show_bug.cgi?id=22585
  50997. * plugins/win/PluginPackageWin.cpp:
  50998. (WebCore::PluginPackage::fetchInfo):
  50999. 2008-12-02 Adam Roben <aroben@apple.com>
  51000. Build fix for Windows projects with NOMINMAX defined globally
  51001. * platform/win/COMPtr.h: Don't redefine NOMINMAX if it's already
  51002. defined.
  51003. 2008-12-02 Simon Hausmann <hausmann@webkit.org>
  51004. Reviewed by Tor Arne Vestbø.
  51005. Build JavaScriptCore into libQtWebKit.so through a direct build
  51006. instead of a static library. When linking a static library into
  51007. a shared library qmake generates an incorrect .prl file, which
  51008. causes all sorts of different build problems when linking against
  51009. QtWebKit. Fixing this in qmake requires bigger changes that are
  51010. currently not possible, so we need to work around this limitation
  51011. for now. The advantages of the separate build did not outweight the
  51012. build problems it caused.
  51013. * WebCore.pro: include JavaScriptCore.pri, re-enable prl support
  51014. and rename the lut generator to domlut to avoid a conflict with
  51015. JavaScriptCore.pri's lut generator.
  51016. 2008-12-02 David Levin <levin@chromium.org>
  51017. Reviewed by Alexey Proskuryakov.
  51018. https://bugs.webkit.org/show_bug.cgi?id=22588
  51019. Move securityOrigin() from Document and WorkerContext into ScriptExecutionContext.
  51020. No observable change in behavior, so no test.
  51021. * dom/Document.cpp:
  51022. (WebCore::Document::open):
  51023. (WebCore::Document::domain):
  51024. (WebCore::Document::setDomain):
  51025. (WebCore::Document::initSecurityContext):
  51026. (WebCore::Document::setSecurityOrigin):
  51027. * dom/Document.h:
  51028. * dom/ScriptExecutionContext.cpp:
  51029. (WebCore::ScriptExecutionContext::setSecurityOrigin):
  51030. * dom/ScriptExecutionContext.h:
  51031. (WebCore::ScriptExecutionContext::securityOrigin):
  51032. * dom/WorkerContext.cpp:
  51033. (WebCore::WorkerContext::WorkerContext):
  51034. * dom/WorkerContext.h:
  51035. These changes are for the move of securityOrigin().
  51036. * xml/XMLHttpRequest.cpp:
  51037. (WebCore::XMLHttpRequest::createRequest):
  51038. (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
  51039. (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
  51040. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
  51041. (WebCore::XMLHttpRequest::setRequestHeader):
  51042. (WebCore::XMLHttpRequest::getAllResponseHeaders):
  51043. (WebCore::XMLHttpRequest::getResponseHeader):
  51044. (WebCore::XMLHttpRequest::processSyncLoadResults):
  51045. (WebCore::XMLHttpRequest::willSendRequest):
  51046. (WebCore::XMLHttpRequest::accessControlCheck):
  51047. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  51048. Change XMLHttpRequest to use ScriptExecutionContext instead of Document to access securityOrigin().
  51049. 2008-12-02 André Pönitz <apoenitz@trolltech.com>
  51050. Reviewed by Simon Hausmann.
  51051. Disable the creation of debug information for the Qt build when done
  51052. inside Qt. With 670 mb it was slowing down gdb start significantly
  51053. for third-party applications that usually don't need it.
  51054. * WebCore.pro:
  51055. 2008-12-01 Beth Dakin <bdakin@apple.com>
  51056. Reviewed by Dan Bernstein.
  51057. Fix for https://bugs.webkit.org/show_bug.cgi?id=13736 REGRESSION
  51058. (r19811): Using the down arrow in a textarea gets "stuck" at the
  51059. end of a wrapped line
  51060. And corresponding: <rdar://problem/5347931>
  51061. The basic problem here is that Position::getInlineBoxAndOffset()
  51062. failed to look beyond a single renderer. This patch looks for a
  51063. better match beyond the first renderer when the affinity is
  51064. downstream and we failed to find a "perfect" match.
  51065. * dom/Position.cpp:
  51066. (WebCore::isNonTextLeafChild):
  51067. (WebCore::searchAheadForBetterMatch):
  51068. (WebCore::Position::getInlineBoxAndOffset):
  51069. This is a fix I made based on code inspection. It looks like the
  51070. old code here and skipped over the parent as a possible match.
  51071. * rendering/RenderObject.cpp:
  51072. (WebCore::RenderObject::nextInPreOrderAfterChildren):
  51073. 2008-12-01 Brent Fulgham <bfulgham@gmail.com>
  51074. Reviewed by Adam Roben.
  51075. Add WML related files to Visual Studio projects.
  51076. https://bugs.webkit.org/show_bug.cgi?id=22561
  51077. * WebCore.vcproj/WebCore.vcproj:
  51078. 1. Add files from the wml directory to the set of windows files.
  51079. 2. Extend include paths with new wml directory.
  51080. 3. Add new autogenerated WML files to DerivedSources.
  51081. 4. Alphabetize preprocesor includes (holdover from earlier debugging).
  51082. 2008-12-01 Steve Falkenburg <sfalken@apple.com>
  51083. Revise node/selection image fix.
  51084. Moved updateLayout call so selection rect is fetched after the layout.
  51085. Reviewed by Adam Roben.
  51086. * page/win/FrameCGWin.cpp:
  51087. (WebCore::imageFromRect):
  51088. (WebCore::imageFromSelection):
  51089. (WebCore::Frame::nodeImage):
  51090. 2008-12-01 Steve Falkenburg <sfalken@apple.com>
  51091. Support needed to implement renderedImage for Windows.
  51092. https://bugs.webkit.org/show_bug.cgi?25648
  51093. Reviewed by Adam Roben.
  51094. * page/Frame.h:
  51095. * page/win/FrameCGWin.cpp:
  51096. (WebCore::imageFromRect):
  51097. (WebCore::imageFromSelection):
  51098. (WebCore::Frame::nodeImage):
  51099. * page/win/FrameCairoWin.cpp:
  51100. (WebCore::imageFromNode):
  51101. 2008-12-01 Simon Fraser <simon.fraser@apple.com>
  51102. Reviewed by Dan Bernstein
  51103. https://bugs.webkit.org/show_bug.cgi?id=22581
  51104. Fix the painting of the caps lock indicator for transformed text inputs,
  51105. by replacing a call to absoluteContentBox() with code that computes the
  51106. painting rect for the input contents.
  51107. * rendering/RenderTextControl.cpp:
  51108. (WebCore::RenderTextControl::paint):
  51109. 2008-12-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51110. Reviewed by George Staikos.
  51111. Add two new helper functions to WMLElement, parseValueSubstitutingVariableReferences/parseValueForbiddingVariableReferences.
  51112. Convert all elements to parse their attribute values using these new helper functions. This simplifies the
  51113. actual attribute parsing code in all WMLElement derived classes, as most WML attribute values either report
  51114. an error if there's a variable reference used in the attribute value, or if it's invalid.
  51115. Split the WMLErrorInvalidVariableReference error which covered both 'invalid syntax' / 'wrong location'
  51116. in two seperated error codes: WMLErrorInvalidVariableReference / WMLErrorInvalidVariableReferenceLocation.
  51117. * wml/WMLAccessElement.cpp:
  51118. (WebCore::WMLAccessElement::parseMappedAttribute):
  51119. * wml/WMLDoElement.cpp:
  51120. (WebCore::WMLDoElement::defaultEventHandler):
  51121. (WebCore::WMLDoElement::parseMappedAttribute):
  51122. * wml/WMLElement.cpp:
  51123. (WebCore::WMLElement::parseValueSubstitutingVariableReferences):
  51124. (WebCore::WMLElement::parseValueForbiddingVariableReferences):
  51125. * wml/WMLElement.h:
  51126. * wml/WMLErrorHandling.cpp:
  51127. (WebCore::reportWMLError):
  51128. * wml/WMLErrorHandling.h:
  51129. (WebCore::):
  51130. * wml/WMLOnEventElement.cpp:
  51131. (WebCore::WMLOnEventElement::parseMappedAttribute):
  51132. * wml/WMLPrevElement.cpp:
  51133. (WebCore::WMLPrevElement::executeTask):
  51134. * wml/WMLSetvarElement.cpp:
  51135. (WebCore::WMLSetvarElement::parseMappedAttribute):
  51136. * wml/WMLTimerElement.cpp:
  51137. (WebCore::WMLTimerElement::parseMappedAttribute):
  51138. 2008-12-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51139. Reviewed by George Staikos.
  51140. Fix switching active cards within a document. No way to test, until <go> support is implemented.
  51141. * wml/WMLCardElement.cpp:
  51142. (WebCore::WMLCardElement::showCard):
  51143. (WebCore::WMLCardElement::hideCard):
  51144. (WebCore::WMLCardElement::setActiveCardInDocument):
  51145. * wml/WMLCardElement.h:
  51146. 2008-12-01 David Kilzer <ddkilzer@apple.com>
  51147. Fix logic error in LegacyWebArchive::create() from r38884.
  51148. * loader/archive/cf/LegacyWebArchive.cpp:
  51149. (WebCore::LegacyWebArchive::create): Only continue if the
  51150. subresource is actually added.
  51151. 2008-12-01 David Kilzer <ddkilzer@apple.com>
  51152. Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
  51153. <https://bugs.webkit.org/show_bug.cgi?id=22466>
  51154. <rdar://problem/6403593>
  51155. Reviewed by Brady Eidson.
  51156. Test: http/tests/webarchive/test-preload-resources.html
  51157. * loader/archive/cf/LegacyWebArchive.cpp:
  51158. (WebCore::LegacyWebArchive::create): Check the WebCore cache for
  51159. resources if DocumentLoader::subresource() doesn't return them.
  51160. Note that the DocumentLoader::subresource() method returned
  51161. preloaded resources before r35867, but this caused a regression in
  51162. Mail.
  51163. 2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
  51164. Reviewed by Eric Seidel.
  51165. Bug 22564: Make HTML elements' constructors take a QualifiedName
  51166. https://bugs.webkit.org/show_bug.cgi?id=22564
  51167. - Modified the remaining HTML elements' constructors to take a QualifiedName.
  51168. - Added an assertion that the QualifiedName given corresponds to the element constructed.
  51169. * bindings/js/JSAudioConstructor.cpp:
  51170. (WebCore::constructAudio):
  51171. * html/HTMLAudioElement.cpp:
  51172. (WebCore::HTMLAudioElement::HTMLAudioElement):
  51173. * html/HTMLAudioElement.h:
  51174. * html/HTMLBRElement.cpp:
  51175. (WebCore::HTMLBRElement::HTMLBRElement):
  51176. * html/HTMLBRElement.h:
  51177. * html/HTMLElement.cpp:
  51178. (WebCore::HTMLElement::setInnerText):
  51179. * html/HTMLElementFactory.cpp:
  51180. (WebCore::brConstructor):
  51181. (WebCore::quoteConstructor):
  51182. (WebCore::marqueeConstructor):
  51183. (WebCore::audioConstructor):
  51184. (WebCore::videoConstructor):
  51185. (WebCore::sourceConstructor):
  51186. * html/HTMLMarqueeElement.cpp:
  51187. (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
  51188. * html/HTMLMarqueeElement.h:
  51189. * html/HTMLQuoteElement.cpp:
  51190. (WebCore::HTMLQuoteElement::HTMLQuoteElement):
  51191. * html/HTMLQuoteElement.h:
  51192. * html/HTMLSourceElement.cpp:
  51193. (WebCore::HTMLSourceElement::HTMLSourceElement):
  51194. * html/HTMLSourceElement.h:
  51195. * html/HTMLVideoElement.cpp:
  51196. (WebCore::HTMLVideoElement::HTMLVideoElement):
  51197. * html/HTMLVideoElement.h:
  51198. * rendering/RenderTextControl.cpp:
  51199. (WebCore::RenderTextControl::updateFromElement):
  51200. 2008-12-01 Julien Chaffraix <jchaffraix@webkit.org>
  51201. Reviewed by Antti Koivisto.
  51202. Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
  51203. https://bugs.webkit.org/show_bug.cgi?id=22441
  51204. Add an assertion to the modified HTML elements' constructor
  51205. to check that the QualifiedName parameter is the one that
  51206. matches the Element's.
  51207. * html/HTMLBaseElement.cpp:
  51208. (WebCore::HTMLBaseElement::HTMLBaseElement):
  51209. * html/HTMLBlockquoteElement.cpp:
  51210. (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  51211. * html/HTMLBodyElement.cpp:
  51212. (WebCore::HTMLBodyElement::HTMLBodyElement):
  51213. * html/HTMLButtonElement.cpp:
  51214. (WebCore::HTMLButtonElement::HTMLButtonElement):
  51215. * html/HTMLDListElement.cpp:
  51216. (WebCore::HTMLDListElement::HTMLDListElement):
  51217. * html/HTMLDirectoryElement.cpp:
  51218. (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  51219. * html/HTMLDivElement.cpp:
  51220. (WebCore::HTMLDivElement::HTMLDivElement):
  51221. * html/HTMLFieldSetElement.cpp:
  51222. (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  51223. * html/HTMLFormElement.cpp:
  51224. (WebCore::HTMLFormElement::HTMLFormElement):
  51225. * html/HTMLFrameElement.cpp:
  51226. (WebCore::HTMLFrameElement::HTMLFrameElement):
  51227. * html/HTMLFrameSetElement.cpp:
  51228. (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
  51229. * html/HTMLHeadElement.cpp:
  51230. (WebCore::HTMLHeadElement::HTMLHeadElement):
  51231. * html/HTMLHtmlElement.cpp:
  51232. (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  51233. * html/HTMLIFrameElement.cpp:
  51234. (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  51235. * html/HTMLInputElement.cpp:
  51236. (WebCore::HTMLInputElement::HTMLInputElement):
  51237. * html/HTMLIsIndexElement.cpp:
  51238. (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
  51239. * html/HTMLKeygenElement.cpp:
  51240. (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  51241. * html/HTMLLIElement.cpp:
  51242. (WebCore::HTMLLIElement::HTMLLIElement):
  51243. * html/HTMLLabelElement.cpp:
  51244. (WebCore::HTMLLabelElement::HTMLLabelElement):
  51245. * html/HTMLLegendElement.cpp:
  51246. (WebCore::HTMLLegendElement::HTMLLegendElement):
  51247. * html/HTMLLinkElement.cpp:
  51248. (WebCore::HTMLLinkElement::HTMLLinkElement):
  51249. * html/HTMLMenuElement.cpp:
  51250. (WebCore::HTMLMenuElement::HTMLMenuElement):
  51251. * html/HTMLMetaElement.cpp:
  51252. (WebCore::HTMLMetaElement::HTMLMetaElement):
  51253. * html/HTMLOListElement.cpp:
  51254. (WebCore::HTMLOListElement::HTMLOListElement):
  51255. * html/HTMLOptGroupElement.cpp:
  51256. (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
  51257. * html/HTMLOptionElement.cpp:
  51258. (WebCore::HTMLOptionElement::HTMLOptionElement):
  51259. * html/HTMLSelectElement.cpp:
  51260. (WebCore::HTMLSelectElement::HTMLSelectElement):
  51261. * html/HTMLStyleElement.cpp:
  51262. (WebCore::HTMLStyleElement::HTMLStyleElement):
  51263. * html/HTMLTextAreaElement.cpp:
  51264. (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  51265. * html/HTMLTitleElement.cpp:
  51266. (WebCore::HTMLTitleElement::HTMLTitleElement):
  51267. * html/HTMLUListElement.cpp:
  51268. (WebCore::HTMLUListElement::HTMLUListElement):
  51269. 2008-12-01 Chris Marrin <cmarrin@apple.com>
  51270. Reviewed by Darin Adler.
  51271. https://bugs.webkit.org/show_bug.cgi?id=22046
  51272. Fixed another case of crashing because the animation object is getting deleted when
  51273. it's in the middle of a callback. I actually moved where I am retaining the pointer
  51274. up out of the lower level AnimationBase code and into the timer callback that calls
  51275. them. So now the pointer is valid throughout the entire sequence of callback code.
  51276. The testcase for https://bugs.webkit.org/show_bug.cgi?id=22052 also exhibits a
  51277. crash which this patch fixes.
  51278. * page/animation/AnimationBase.cpp:
  51279. (WebCore::AnimationBase::updateStateMachine):
  51280. (WebCore::AnimationBase::animationTimerCallbackFired):
  51281. * page/animation/CompositeAnimation.cpp:
  51282. (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
  51283. (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
  51284. (WebCore::CompositeAnimationPrivate::styleAvailable):
  51285. * page/animation/ImplicitAnimation.cpp:
  51286. (WebCore::ImplicitAnimation::sendTransitionEvent):
  51287. * page/animation/KeyframeAnimation.cpp:
  51288. (WebCore::KeyframeAnimation::sendAnimationEvent):
  51289. (WebCore::KeyframeAnimation::resumeOverriddenAnimations):
  51290. 2008-12-01 Tor Arne Vestbø <tavestbo@trolltech.com>
  51291. Reviewed by Simon Hausmann.
  51292. [Qt/Mac] Initialize NPAPI plugins before getting their entry points
  51293. The old behavior (calling NP_GetEntryPoints before NP_Initialize) was
  51294. copied from Windows, but caused Silverlight on Mac to crash when loaded.
  51295. Apparently the call order of NP_Initialize and NP_GetEntryPoints is
  51296. reversed on Mac. See https://bugzilla.mozilla.org/show_bug.cgi?id=344425
  51297. Reported-by: Peter Johnson <peter@zattoo.com>
  51298. * plugins/mac/PluginPackageMac.cpp:
  51299. (WebCore::PluginPackage::load):
  51300. 2008-11-30 Chris Fleizach <cfleizach@apple.com>
  51301. Reviewed by John Sullivan.
  51302. https://bugs.webkit.org/show_bug.cgi?id=22510
  51303. Crash at WebCore::AccessibilityRenderObject::activeDescendant() on Google Reader with ARIA (22510)
  51304. A nil pointer needed to be checked
  51305. * page/AccessibilityRenderObject.cpp:
  51306. (WebCore::AccessibilityRenderObject::activeDescendant):
  51307. 2008-11-30 Alexey Proskuryakov <ap@webkit.org>
  51308. Reviewed by Dan Bernstein.
  51309. https://bugs.webkit.org/show_bug.cgi?id=22530
  51310. Assertion failures seen on buildbot due to uninitialized WorkerThread::m_threadID
  51311. * dom/WorkerThread.cpp:
  51312. (WebCore::WorkerThread::start): Protect worker startup with a mutex to ensure that this
  51313. function runs to completion before the thread begins execution.
  51314. (WebCore::WorkerThread::workerThread): Updated comments.
  51315. (WebCore::WorkerThread::stop): Ditto.
  51316. * dom/WorkerThread.h: Renamed m_workerContextMutex to m_threadCreationMutex, because it now
  51317. protects startup as a whole.
  51318. * storage/DatabaseThread.cpp:
  51319. * storage/DatabaseThread.h:
  51320. * storage/LocalStorageThread.cpp:
  51321. * storage/LocalStorageThread.h:
  51322. Fixed the same m_threadID problem.
  51323. 2008-11-29 Brent Fulgham <bfulgham@gmail.com>
  51324. Reviewed by Alexey Proskuryakov.
  51325. Remove Visual Studio project dependencies on non-redistributable
  51326. components in the Debug_Cairo and Release_Cairo build targets.
  51327. See https://bugs.webkit.org/show_bug.cgi?id=22527
  51328. * WebCore.vcproj/WebCore.vcproj:
  51329. 2008-11-29 Sam Weinig <sam@webkit.org>
  51330. Rubber-stamped by Alexey Proskuryakov.
  51331. Fix some sorting
  51332. * WebCore.xcodeproj/project.pbxproj:
  51333. 2008-11-28 Sam Weinig <sam@webkit.org>
  51334. Reviewed by Alexey Proskuryakov.
  51335. Fix for https://bugs.webkit.org/show_bug.cgi?id=21063
  51336. NULL pointer crash in dispatchEvent(null);
  51337. Test: fast/events/dispatchEvent-crash.html
  51338. * dom/MessagePort.cpp:
  51339. (WebCore::MessagePort::dispatchEvent):
  51340. * dom/Worker.cpp:
  51341. (WebCore::Worker::dispatchEvent):
  51342. * dom/WorkerContext.cpp:
  51343. (WebCore::WorkerContext::dispatchEvent):
  51344. * loader/appcache/DOMApplicationCache.cpp:
  51345. (WebCore::DOMApplicationCache::dispatchEvent):
  51346. * xml/XMLHttpRequest.cpp:
  51347. (WebCore::XMLHttpRequest::dispatchEvent):
  51348. * xml/XMLHttpRequestUpload.cpp:
  51349. (WebCore::XMLHttpRequestUpload::dispatchEvent):
  51350. 2008-11-29 Dan Bernstein <mitz@apple.com>
  51351. Reviewed by Alexey Proskuryakov.
  51352. - fix https://bugs.webkit.org/show_bug.cgi?id=22454
  51353. <rdar://problem/6405550> REGRESSION (3.2-TOT): Crash below FontFallbackList::fontDataAt on jacobian.org
  51354. Test: http/tests/misc/font-face-in-multiple-segmented-faces.html
  51355. The crash happened because style recalculation was invoked by
  51356. CSSFontSelector after one CSSSegmentedFontFace had pruned its tables but
  51357. before another CSSSegmentedFontFace using the same CSSFontFace had done
  51358. so. The fix is to let all CSSSegmentedFontFaces using the CSSFontFace
  51359. prune their tables before telling the CSSFontSelector to recalc style.
  51360. * css/CSSFontFace.cpp:
  51361. (WebCore::CSSFontFace::fontLoaded):
  51362. * css/CSSFontSelector.cpp:
  51363. (WebCore::CSSFontSelector::fontLoaded):
  51364. * css/CSSFontSelector.h:
  51365. * css/CSSSegmentedFontFace.cpp:
  51366. (WebCore::CSSSegmentedFontFace::fontLoaded):
  51367. 2008-11-29 Alexey Proskuryakov <ap@webkit.org>
  51368. Reviewed by Eric Seidel.
  51369. https://bugs.webkit.org/show_bug.cgi?id=14968
  51370. document.open() erroneously returns void instead of the new Document
  51371. Test: fast/dom/HTMLDocument/document-open-return-value.html
  51372. * bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
  51373. Return the document on which this method was invoked, per HTML5.
  51374. 2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51375. Reviewed by Cameron Zwarich.
  51376. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550
  51377. Add <timer> element support. It provides a way to execute a task with a delay.
  51378. The user is notified by firing the task associated with the <card>'s ontimer attribute.
  51379. Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)
  51380. * WebCore.xcodeproj/project.pbxproj:
  51381. * wml/WMLCardElement.cpp:
  51382. (WebCore::WMLCardElement::WMLCardElement):
  51383. (WebCore::WMLCardElement::setIntrinsicEventTimer):
  51384. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
  51385. * wml/WMLCardElement.h:
  51386. * wml/WMLDoElement.cpp:
  51387. (WebCore::WMLDoElement::defaultEventHandler):
  51388. * wml/WMLErrorHandling.cpp:
  51389. (WebCore::reportWMLError):
  51390. * wml/WMLPageState.h:
  51391. (WebCore::WMLPageState::getVariable):
  51392. * wml/WMLPrevElement.cpp:
  51393. (WebCore::WMLPrevElement::executeTask):
  51394. * wml/WMLRefreshElement.cpp:
  51395. (WebCore::WMLRefreshElement::executeTask):
  51396. * wml/WMLTagNames.in:
  51397. * wml/WMLTimerElement.cpp: Added.
  51398. (WebCore::WMLTimerElement::WMLTimerElement):
  51399. (WebCore::WMLTimerElement::parseMappedAttribute):
  51400. (WebCore::WMLTimerElement::insertedIntoDocument):
  51401. (WebCore::WMLTimerElement::timerFired):
  51402. (WebCore::WMLTimerElement::start):
  51403. (WebCore::WMLTimerElement::stop):
  51404. (WebCore::WMLTimerElement::storeIntervalToPageState):
  51405. * wml/WMLTimerElement.h: Added.
  51406. 2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51407. Reviewed by Holger Freyther.
  51408. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549
  51409. Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
  51410. Changes numerous of layout tests which contain <do> elements, as they render as buttons now.
  51411. * WebCore.xcodeproj/project.pbxproj:
  51412. * rendering/RenderButton.cpp:
  51413. (WebCore::RenderButton::updateFromElement):
  51414. * wml/WMLCardElement.cpp:
  51415. (WebCore::WMLCardElement::registerDoElement):
  51416. * wml/WMLCardElement.h:
  51417. * wml/WMLDoElement.cpp: Added.
  51418. (WebCore::WMLDoElement::WMLDoElement):
  51419. (WebCore::WMLDoElement::defaultEventHandler):
  51420. (WebCore::WMLDoElement::parseMappedAttribute):
  51421. (WebCore::WMLDoElement::insertedIntoDocument):
  51422. (WebCore::WMLDoElement::createRenderer):
  51423. (WebCore::WMLDoElement::recalcStyle):
  51424. * wml/WMLDoElement.h: Added.
  51425. (WebCore::WMLDoElement::registerTask):
  51426. (WebCore::WMLDoElement::isActive):
  51427. (WebCore::WMLDoElement::label):
  51428. (WebCore::WMLDoElement::name):
  51429. (WebCore::WMLDoElement::setActive):
  51430. (WebCore::WMLDoElement::setNoop):
  51431. * wml/WMLNoopElement.cpp:
  51432. (WebCore::WMLNoopElement::insertedIntoDocument):
  51433. * wml/WMLTagNames.in:
  51434. * wml/WMLTaskElement.cpp:
  51435. (WebCore::WMLTaskElement::insertedIntoDocument):
  51436. 2008-11-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51437. Reviewed by Sam Weinig.
  51438. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545
  51439. Add onenterforward/onenterbackward/ontimer support for <card> elements.
  51440. No testing possible at the moment because WMLGoElement is not yet implemented.
  51441. After that we can add tests covering the <card> event handling.
  51442. * wml/WMLCardElement.cpp:
  51443. (WebCore::WMLCardElement::WMLCardElement):
  51444. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
  51445. (WebCore::WMLCardElement::parseMappedAttribute):
  51446. (WebCore::WMLCardElement::setActiveCardInDocument):
  51447. * wml/WMLCardElement.h:
  51448. (WebCore::WMLCardElement::isNewContext):
  51449. (WebCore::WMLCardElement::isOrdered):
  51450. * wml/WMLDocument.cpp:
  51451. (WebCore::WMLDocument::finishedParsing):
  51452. * wml/WMLIntrinsicEvent.cpp:
  51453. (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
  51454. * wml/WMLIntrinsicEvent.h:
  51455. (WebCore::WMLIntrinsicEvent::create):
  51456. 2008-11-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  51457. Reviewed by Tor Arne Vestbø.
  51458. Regression seen on QtWebKit - causes a build failure on Win using MinGW
  51459. https://bugs.webkit.org/show_bug.cgi?id=22536
  51460. * WebCore.pro:
  51461. 2008-11-28 Simon Hausmann <hausmann@webkit.org>
  51462. Reviewed by Tor Arne Vestbø.
  51463. Fix compilation and linking on Windows CE.
  51464. Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
  51465. from the Windows'ish build.
  51466. Link against the newly required mmtimer.
  51467. * WebCore.pro:
  51468. * plugins/PluginPackage.cpp:
  51469. 2008-11-28 David Levin <levin@chromium.org>
  51470. Reviewed by Alexey Proskuryakov.
  51471. http://bugs.webkit.org/show_bug.cgi?id=22524
  51472. Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
  51473. of XMLHttpRequest by Workers (on threads).
  51474. No observable change in behavior, so no test.
  51475. * xml/XMLHttpRequest.cpp:
  51476. (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
  51477. (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
  51478. (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
  51479. (WebCore::PreflightResultCacheItem::allowsRequest):
  51480. (WebCore::createXMLHttpRequestStaticData):
  51481. (WebCore::initializeXMLHttpRequestStaticData):
  51482. (WebCore::XMLHttpRequest::XMLHttpRequest):
  51483. (WebCore::XMLHttpRequest::isSafeRequestHeader):
  51484. (WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
  51485. * xml/XMLHttpRequest.h:
  51486. 2008-11-27 Cameron Zwarich <zwarich@apple.com>
  51487. Not reviewed.
  51488. r38825, was committed without checking whether anything in WebCore
  51489. uses JSFunction::m_body. Use the appropriate getters and setters
  51490. instead.
  51491. * inspector/JavaScriptDebugServer.cpp:
  51492. (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
  51493. 2008-11-27 Alexey Proskuryakov <ap@webkit.org>
  51494. Reviewed by Dan Bernstein.
  51495. https://bugs.webkit.org/show_bug.cgi?id=22529
  51496. Crashes seen on buildbots due to trying to stop a worker thread twice
  51497. * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
  51498. Don't try to stop the thread if it's already stopping.
  51499. 2008-11-27 Kent Hansen <khansen@trolltech.com>
  51500. Reviewed by Simon Hausmann.
  51501. Make JavaScript bindings for Qt plugin widgets work again
  51502. this was a regression; need to handle non-NPAPI plugins as in 4.4.
  51503. * bindings/js/ScriptControllerQt.cpp:
  51504. (WebCore::ScriptController::createScriptInstanceForWidget):
  51505. 2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51506. Reviewed by George Staikos.
  51507. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22522
  51508. Catch WML errors (invalid variable name/reference, multiple access elements, etc)
  51509. while parsing the document, and stop parsing immediately and wrap the document
  51510. fragment in a XHTML error document, just like it's done from XML parsing errors.
  51511. Until now all card elements were hidden by default (no renderer created), and
  51512. WMLDocument::finishedParsing() took care of showing the right card (either the first,
  51513. or any named card in the document, specified by document URL reference). Change this
  51514. behaviour to support displaying partially parsed WML document fragments: Mark the first
  51515. WMLCardElement inserted into the document as visible. If the document parsing finishes
  51516. without problems, WMLDocument::finishedParsing() will be called, which takes care of
  51517. showing the desired card (common case: first card in the document, which is already
  51518. visible, so nothing actually has to be done). If an error occours, the document is
  51519. correctly rendered until the error happened - wrapped in a XHTML document.
  51520. Fixes: fast/wml/err-event-binding-conflict.wml
  51521. fast/wml/err-invalid-variable-name.wml
  51522. fast/wml/err-multi-access.wml
  51523. fast/wml/err-unallowed-task-in-anchor.wml
  51524. * WebCore.xcodeproj/project.pbxproj:
  51525. * wml/WMLAccessElement.cpp:
  51526. (WebCore::WMLAccessElement::parseMappedAttribute):
  51527. (WebCore::WMLAccessElement::insertedIntoDocument):
  51528. * wml/WMLAccessElement.h:
  51529. * wml/WMLCardElement.cpp:
  51530. (WebCore::WMLCardElement::insertedIntoDocument):
  51531. (WebCore::WMLCardElement::setActiveCardInDocument):
  51532. * wml/WMLCardElement.h:
  51533. * wml/WMLDocument.cpp:
  51534. (WebCore::WMLDocument::finishedParsing):
  51535. * wml/WMLErrorHandling.cpp: Added.
  51536. (WebCore::reportWMLError):
  51537. * wml/WMLErrorHandling.h: Added.
  51538. (WebCore::):
  51539. * wml/WMLIntrinsicEventHandler.cpp:
  51540. (WebCore::WMLIntrinsicEventHandler::registerIntrinsicEvent):
  51541. * wml/WMLIntrinsicEventHandler.h:
  51542. * wml/WMLNoopElement.cpp:
  51543. (WebCore::WMLNoopElement::insertedIntoDocument):
  51544. * wml/WMLOnEventElement.cpp:
  51545. (WebCore::WMLOnEventElement::parseMappedAttribute):
  51546. (WebCore::WMLOnEventElement::registerTask):
  51547. * wml/WMLPageState.cpp:
  51548. (WebCore::WMLPageState::setNeedCheckDeckAccess):
  51549. * wml/WMLPageState.h:
  51550. * wml/WMLSetvarElement.cpp:
  51551. (WebCore::WMLSetvarElement::parseMappedAttribute):
  51552. 2008-11-26 Glenn Wilson <gwilson@chromium.org>
  51553. Reviewed by Dan Bernstein.
  51554. Fixed bug http://bugs.webkit.org/show_bug.cgi?id=21953
  51555. This fixes the crash when the small-caps font variant is used
  51556. on a lower-case glyph that does not have a corresponding
  51557. upper-case glyph defined in the set of available fonts.
  51558. This changes Font.cpp to check if the font being used exists before trying to apply the small-caps variant.
  51559. Test: fast/css/small-caps-crash.html
  51560. * platform/graphics/Font.cpp:
  51561. (WebCore::Font::glyphDataForCharacter):
  51562. 2008-11-26 Tony Chang <tony@chromium.org>
  51563. Reviewed by Oliver Hunt.
  51564. Add a new platform specific method cleanupAfterSystemDrag
  51565. that platforms can ue to clean up drag state after a
  51566. system drag. Use this method on PLAFORM(MAC).
  51567. https://bugs.webkit.org/show_bug.cgi?id=21956
  51568. * ChangeLog:
  51569. * page/DragController.cpp:
  51570. (WebCore::DragController::doSystemDrag):
  51571. * page/DragController.h:
  51572. * page/gtk/DragControllerGtk.cpp:
  51573. (WebCore::DragController::cleanupAfterSystemDrag):
  51574. * page/mac/DragControllerMac.mm:
  51575. (WebCore::DragController::cleanupAfterSystemDrag):
  51576. * page/qt/DragControllerQt.cpp:
  51577. (WebCore::DragController::cleanupAfterSystemDrag):
  51578. * page/win/DragControllerWin.cpp:
  51579. (WebCore::DragController::cleanupAfterSystemDrag):
  51580. * page/wx/DragControllerWx.cpp:
  51581. (WebCore::DragController::cleanupAfterSystemDrag):
  51582. 2008-11-26 Nikolas Zimmermann <zimmermann@kde.org>
  51583. Reviewed by Oliver Hunt.
  51584. Fix path to string logic, correctly taking closed (sub-)paths into account.
  51585. Code was just broken on cg, observed by Dirk Schulze.
  51586. QPainterPath doesn't seem to expose any functionality to detect closed sub paths,
  51587. using the elementAt() function. There might be a workaround - Dirk will investigate.
  51588. * platform/graphics/cg/PathCG.cpp:
  51589. (WebCore::CGPathToCFStringApplierFunction):
  51590. * platform/graphics/cairo/PathCairo.cpp:
  51591. (WebCore::Path::debugString):
  51592. 2008-11-26 Darin Fisher <darin@chromium.org>
  51593. Reviewed by Eric Seidel.
  51594. https://bugs.webkit.org/show_bug.cgi?id=22519
  51595. Remove unnecessary include.
  51596. * dom/XMLTokenizer.cpp:
  51597. 2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51598. Reviewed by Oliver Hunt.
  51599. Add <noop> element support, completing the task element support.
  51600. * WebCore.xcodeproj/project.pbxproj:
  51601. * wml/WMLNoopElement.cpp: Added.
  51602. (WebCore::WMLNoopElement::WMLNoopElement):
  51603. (WebCore::WMLNoopElement::insertedIntoDocument):
  51604. * wml/WMLNoopElement.h: Added.
  51605. * wml/WMLTagNames.in: Reorganize file a bit.
  51606. 2008-11-26 Julien Chaffraix <jchaffraix@webkit.org>
  51607. Reviewed by Eric Seidel.
  51608. Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
  51609. https://bugs.webkit.org/show_bug.cgi?id=22441
  51610. Make more HTML elements' constructors take a QualifiedName.
  51611. * editing/DeleteButtonController.cpp:
  51612. (WebCore::DeleteButtonController::createDeletionUI):
  51613. * html/HTMLBlockquoteElement.cpp:
  51614. (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  51615. * html/HTMLBlockquoteElement.h:
  51616. * html/HTMLButtonElement.cpp:
  51617. (WebCore::HTMLButtonElement::HTMLButtonElement):
  51618. * html/HTMLButtonElement.h:
  51619. * html/HTMLDListElement.cpp:
  51620. (WebCore::HTMLDListElement::HTMLDListElement):
  51621. * html/HTMLDListElement.h:
  51622. * html/HTMLDirectoryElement.cpp:
  51623. (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  51624. * html/HTMLDirectoryElement.h:
  51625. * html/HTMLDivElement.cpp:
  51626. (WebCore::HTMLDivElement::HTMLDivElement):
  51627. * html/HTMLDivElement.h:
  51628. * html/HTMLElementFactory.cpp:
  51629. (WebCore::styleConstructor):
  51630. (WebCore::titleConstructor):
  51631. (WebCore::frameConstructor):
  51632. (WebCore::framesetConstructor):
  51633. (WebCore::iframeConstructor):
  51634. (WebCore::formConstructor):
  51635. (WebCore::buttonConstructor):
  51636. (WebCore::inputConstructor):
  51637. (WebCore::isindexConstructor):
  51638. (WebCore::fieldsetConstructor):
  51639. (WebCore::keygenConstructor):
  51640. (WebCore::labelConstructor):
  51641. (WebCore::legendConstructor):
  51642. (WebCore::optgroupConstructor):
  51643. (WebCore::optionConstructor):
  51644. (WebCore::selectConstructor):
  51645. (WebCore::textareaConstructor):
  51646. (WebCore::dlConstructor):
  51647. (WebCore::ulConstructor):
  51648. (WebCore::olConstructor):
  51649. (WebCore::dirConstructor):
  51650. (WebCore::menuConstructor):
  51651. (WebCore::liConstructor):
  51652. (WebCore::blockquoteConstructor):
  51653. (WebCore::divConstructor):
  51654. (WebCore::headingConstructor):
  51655. * html/HTMLFieldSetElement.cpp:
  51656. (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  51657. * html/HTMLFieldSetElement.h:
  51658. * html/HTMLFormElement.cpp:
  51659. (WebCore::HTMLFormElement::HTMLFormElement):
  51660. * html/HTMLFormElement.h:
  51661. * html/HTMLFrameElement.cpp:
  51662. (WebCore::HTMLFrameElement::HTMLFrameElement):
  51663. * html/HTMLFrameElement.h:
  51664. * html/HTMLFrameSetElement.cpp:
  51665. (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
  51666. * html/HTMLFrameSetElement.h:
  51667. * html/HTMLIFrameElement.cpp:
  51668. (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  51669. * html/HTMLIFrameElement.h:
  51670. * html/HTMLInputElement.cpp:
  51671. * html/HTMLInputElement.h:
  51672. * html/HTMLIsIndexElement.cpp:
  51673. (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
  51674. * html/HTMLIsIndexElement.h:
  51675. * html/HTMLKeygenElement.cpp:
  51676. (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  51677. * html/HTMLKeygenElement.h:
  51678. * html/HTMLLIElement.cpp:
  51679. (WebCore::HTMLLIElement::HTMLLIElement):
  51680. * html/HTMLLIElement.h:
  51681. * html/HTMLLabelElement.cpp:
  51682. (WebCore::HTMLLabelElement::HTMLLabelElement):
  51683. * html/HTMLLabelElement.h:
  51684. * html/HTMLLegendElement.cpp:
  51685. (WebCore::HTMLLegendElement::HTMLLegendElement):
  51686. * html/HTMLLegendElement.h:
  51687. * html/HTMLMenuElement.cpp:
  51688. (WebCore::HTMLMenuElement::HTMLMenuElement):
  51689. * html/HTMLMenuElement.h:
  51690. * html/HTMLOListElement.cpp:
  51691. (WebCore::HTMLOListElement::HTMLOListElement):
  51692. * html/HTMLOListElement.h:
  51693. * html/HTMLOptGroupElement.cpp:
  51694. (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
  51695. * html/HTMLOptGroupElement.h:
  51696. * html/HTMLOptionElement.cpp:
  51697. (WebCore::HTMLOptionElement::HTMLOptionElement):
  51698. * html/HTMLOptionElement.h:
  51699. * html/HTMLParser.cpp:
  51700. (WebCore::HTMLParser::formCreateErrorCheck):
  51701. (WebCore::HTMLParser::handleIsindex):
  51702. * html/HTMLSelectElement.cpp:
  51703. * html/HTMLSelectElement.h:
  51704. * html/HTMLStyleElement.cpp:
  51705. (WebCore::HTMLStyleElement::HTMLStyleElement):
  51706. * html/HTMLStyleElement.h:
  51707. * html/HTMLTextAreaElement.cpp:
  51708. (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  51709. * html/HTMLTextAreaElement.h:
  51710. * html/HTMLTitleElement.cpp:
  51711. (WebCore::HTMLTitleElement::HTMLTitleElement):
  51712. * html/HTMLTitleElement.h:
  51713. * html/HTMLUListElement.cpp:
  51714. (WebCore::HTMLUListElement::HTMLUListElement):
  51715. * html/HTMLUListElement.h:
  51716. * html/HTMLViewSourceDocument.cpp:
  51717. (WebCore::HTMLViewSourceDocument::createContainingTable):
  51718. * rendering/MediaControlElements.cpp:
  51719. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
  51720. (WebCore::MediaControlInputElement::MediaControlInputElement):
  51721. * rendering/RenderFileUploadControl.cpp:
  51722. (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
  51723. * rendering/RenderMedia.cpp:
  51724. (WebCore::RenderMedia::createPanel):
  51725. (WebCore::RenderMedia::createTimeDisplay):
  51726. * rendering/RenderSlider.cpp:
  51727. (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
  51728. * rendering/TextControlInnerElements.cpp:
  51729. (WebCore::TextControlInnerElement::TextControlInnerElement):
  51730. 2008-11-26 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51731. Reviewed by Sam Weinig.
  51732. Fix obvious problem in WMLPageState constructor, m_page was not set to the passed Page pointer.
  51733. * wml/WMLPageState.cpp:
  51734. (WebCore::WMLPageState::WMLPageState):
  51735. 2008-11-26 Matt Perry <mpcomplete@gmail.com>
  51736. Fix Qt bustage.
  51737. See https://bugs.webkit.org/show_bug.cgi?id=22051
  51738. * platform/qt/RenderThemeQt.cpp:
  51739. (WebCore::RenderThemeQt::extraDefaultStyleSheet):
  51740. 2008-11-26 Matt Perry <mpcomplete@gmail.com>
  51741. Reviewed by Maciej Stachowiak.
  51742. Fix https://bugs.webkit.org/show_bug.cgi?id=22051
  51743. Renderthemes should be able to supply additional CSS rules to the core
  51744. ones.
  51745. * DerivedSources.make:
  51746. * css/CSSStyleSelector.cpp:
  51747. (WebCore::parseUASheet):
  51748. (WebCore::loadFullDefaultStyle):
  51749. (WebCore::loadSimpleDefaultStyle):
  51750. * css/themeWin.css: Added.
  51751. * css/themeWinQuirks.css: Added.
  51752. * platform/qt/RenderThemeQt.cpp:
  51753. (WebCore::RenderThemeQt::extraDefaultStyleSheet):
  51754. * platform/qt/RenderThemeQt.h:
  51755. * rendering/RenderTheme.cpp:
  51756. * rendering/RenderTheme.h:
  51757. (WebCore::RenderTheme::extraDefaultStyleSheet):
  51758. (WebCore::RenderTheme::extraQuirksStyleSheet):
  51759. * rendering/RenderThemeWin.cpp:
  51760. (WebCore::RenderThemeWin::extraDefaultStyleSheet):
  51761. (WebCore::RenderThemeWin::extraQuirksStyleSheet):
  51762. * rendering/RenderThemeWin.h:
  51763. 2008-11-26 David Kilzer <ddkilzer@apple.com>
  51764. Make CSSStyleSheet::addSubresourceURLStrings() iterative
  51765. Part of the fix for Bug 11850: Webarchive fails to save images referenced in CSS
  51766. <https://bugs.webkit.org/show_bug.cgi?id=11850>
  51767. Reviewed by Brady Eidson.
  51768. * css/CSSStyleSheet.cpp:
  51769. (WebCore::CSSStyleSheet::addSubresourceURLStrings): Switch algorithm
  51770. from recursive to iterative for gathering the list of all CSS
  51771. stylesheets referenced in @import statements.
  51772. 2008-11-26 Dirk Schulze <krit@webkit.org>
  51773. Reviewed by Simon Hausmann.
  51774. Transformations to the context shouldn't transform the currentPath.
  51775. Fixed this on Qt.
  51776. [QT] GraphicsContext's currenPath can be transformed
  51777. https://bugs.webkit.org/show_bug.cgi?id=22163
  51778. * platform/graphics/GraphicsContextPrivate.h:
  51779. * platform/graphics/qt/GraphicsContextQt.cpp:
  51780. (WebCore::GraphicsContext::restorePlatformState):
  51781. (WebCore::GraphicsContext::fillPath):
  51782. (WebCore::GraphicsContext::strokePath):
  51783. (WebCore::GraphicsContext::fillRect):
  51784. (WebCore::GraphicsContext::translate):
  51785. (WebCore::GraphicsContext::rotate):
  51786. (WebCore::GraphicsContext::scale):
  51787. (WebCore::GraphicsContext::concatCTM):
  51788. 2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>
  51789. Gtk build script minor fixes. Not reviewed.
  51790. * GNUmakefile.am:
  51791. - Add ScriptInstance.h (introduced in r38774) to
  51792. the build.
  51793. - Move WML and GEOLOCATION conditionals before the SVG
  51794. conditional to be consistent with the style of the script.
  51795. - Move GeolocationGtk sources to webcoregtk_sources.
  51796. 2008-11-26 Dmitry Titov <dimich@chromium.org>
  51797. Reviewed by Darin Adler and Eric Seidel.
  51798. https://bugs.webkit.org/show_bug.cgi?id=22469
  51799. Move the class DOMWindowTimer from JSDOMWindowBase into its own file in
  51800. preparation to making it work for Workers. For now, just move the code and couple
  51801. of global variables.
  51802. * GNUmakefile.am:
  51803. * WebCore.pro:
  51804. * WebCore.vcproj/WebCore.vcproj:
  51805. * WebCore.xcodeproj/project.pbxproj:
  51806. * WebCoreSources.bkl:
  51807. * bindings/js/JSDOMWindowBase.cpp:
  51808. (WebCore::JSDOMWindowBase::installTimeout):
  51809. (WebCore::JSDOMWindowBase::pauseTimeouts):
  51810. (WebCore::JSDOMWindowBase::resumeTimeouts):
  51811. (WebCore::JSDOMWindowBase::timerFired):
  51812. * bindings/js/JSDOMWindowBase.h:
  51813. * bindings/js/DOMTimer.cpp: Added.
  51814. (WebCore::DOMTimer::DOMTimer):
  51815. (WebCore::DOMTimer::~DOMTimer):
  51816. (WebCore::DOMTimer::fired):
  51817. * bindings/js/DOMTimer.h: Added.
  51818. (WebCore::DOMTimer::timeoutId):
  51819. (WebCore::DOMTimer::nestingLevel):
  51820. (WebCore::DOMTimer::setNestingLevel):
  51821. (WebCore::DOMTimer::action):
  51822. (WebCore::DOMTimer::takeAction):
  51823. 2008-11-25 Darin Fisher <darin@chromium.org>
  51824. Fix bustage.
  51825. https://bugs.webkit.org/show_bug.cgi?id=22493
  51826. Need to expose bridge/*.h to the WebKit build.
  51827. * WebCore.vcproj/WebCore.vcproj:
  51828. 2008-11-25 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51829. Not reviewed. Fix build, by removing some wrong last-minute changes.
  51830. * wml/WMLIntrinsicEvent.cpp:
  51831. (WebCore::createTaskElement):
  51832. * wml/WMLOnEventElement.cpp:
  51833. (WebCore::WMLOnEventElement::registerTask):
  51834. 2008-11-25 Darin Fisher <darin@chromium.org>
  51835. Reviewed by Geoffrey Garen.
  51836. https://bugs.webkit.org/show_bug.cgi?id=22493
  51837. Abstract away JSC:: usage in WebCore/html
  51838. * WebCore.xcodeproj/project.pbxproj:
  51839. * bindings/js/JSPluginElementFunctions.cpp:
  51840. (WebCore::pluginInstance):
  51841. * bindings/js/ScriptController.h:
  51842. * bindings/js/ScriptControllerMac.mm:
  51843. (WebCore::ScriptController::createScriptInstanceForWidget):
  51844. * bindings/js/ScriptInstance.h: Added.
  51845. * html/HTMLPlugInElement.cpp:
  51846. (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
  51847. (WebCore::HTMLPlugInElement::getInstance):
  51848. * html/HTMLPlugInElement.h:
  51849. 2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  51850. Reviewed by Sam Weinig.
  51851. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22477
  51852. A WMLTaskElement checks wheter it's parent is an <anchor>/<do>/<onevent> element, and calls registerTask(this) on the parent.
  51853. Add a isWMLTaskElement() function to WMLElement, making it possible to cast to WMLTaskElement directly.
  51854. Add WMLEventHandlingElement class, inheriting from WMLElement, to serve as common base WMLTemplate/Option/CardElement,
  51855. centralizing the eventHandler() / createEventHandlerIfNeeded() implementation. Add a isWMLEventHandlingElement()
  51856. function to WMLElement, so WMLOnEventElement can create event handlers, without knowing wheter it's a
  51857. <template>/<option> or <card> element.
  51858. Add complete <onevent> support.
  51859. * WebCore.xcodeproj/project.pbxproj:
  51860. * wml/WMLCardElement.cpp:
  51861. (WebCore::WMLCardElement::WMLCardElement):
  51862. (WebCore::WMLCardElement::setActiveCardInDocument):
  51863. * wml/WMLCardElement.h:
  51864. (WebCore::WMLCardElement::isVisible):
  51865. (WebCore::WMLCardElement::setVisible):
  51866. * wml/WMLElement.h:
  51867. (WebCore::WMLElement::isWMLTaskElement):
  51868. * wml/WMLEventHandlingElement.cpp: Added.
  51869. (WebCore::WMLEventHandlingElement::WMLEventHandlingElement):
  51870. (WebCore::WMLEventHandlingElement::createEventHandlerIfNeeded):
  51871. * wml/WMLEventHandlingElement.h: Added.
  51872. (WebCore::WMLEventHandlingElement::isWMLEventHandlingElement):
  51873. (WebCore::WMLEventHandlingElement::eventHandler):
  51874. * wml/WMLOnEventElement.cpp: Added.
  51875. (WebCore::WMLOnEventElement::WMLOnEventElement):
  51876. (WebCore::WMLOnEventElement::parseMappedAttribute):
  51877. (WebCore::WMLOnEventElement::registerTask):
  51878. * wml/WMLOnEventElement.h: Added.
  51879. * wml/WMLSetvarElement.cpp:
  51880. (WebCore::WMLSetvarElement::parseMappedAttribute):
  51881. (WebCore::WMLSetvarElement::insertedIntoDocument):
  51882. * wml/WMLTagNames.in:
  51883. * wml/WMLTaskElement.cpp:
  51884. (WebCore::WMLTaskElement::insertedIntoDocument):
  51885. * wml/WMLTaskElement.h:
  51886. (WebCore::WMLTaskElement::isWMLTaskElement):
  51887. 2008-11-25 Pierre-Olivier Latour <pol@apple.com>
  51888. Reviewed by Mark Rowe.
  51889. createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL
  51890. https://bugs.webkit.org/show_bug.cgi?id=22503
  51891. * platform/graphics/mac/FontCustomPlatformData.cpp:
  51892. (WebCore::createFontCustomPlatformData):
  51893. 2008-11-25 Julien Chaffraix <jchaffraix@webkit.org>
  51894. Reviewed by Eric Seidel.
  51895. Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
  51896. https://bugs.webkit.org/show_bug.cgi?id=22441
  51897. Element's other than HTML ones take a QualifiedName in their constructors.
  51898. To make HTMLElementFactory closer to the other ElementFactory, we need
  51899. to make them take the same arguments.
  51900. This patch only makes the 5 first one in HTMLElementFactory abide by that. The others
  51901. will go into the next patch.
  51902. * dom/Document.cpp:
  51903. (WebCore::Document::implicitClose):
  51904. * html/HTMLBaseElement.cpp:
  51905. (WebCore::HTMLBaseElement::HTMLBaseElement):
  51906. * html/HTMLBaseElement.h:
  51907. * html/HTMLBodyElement.cpp:
  51908. (WebCore::HTMLBodyElement::HTMLBodyElement):
  51909. * html/HTMLBodyElement.h:
  51910. * html/HTMLElementFactory.cpp:
  51911. (WebCore::htmlConstructor):
  51912. (WebCore::headConstructor):
  51913. (WebCore::bodyConstructor):
  51914. (WebCore::baseConstructor):
  51915. (WebCore::linkConstructor):
  51916. (WebCore::metaConstructor):
  51917. * html/HTMLHeadElement.cpp:
  51918. (WebCore::HTMLHeadElement::HTMLHeadElement):
  51919. * html/HTMLHeadElement.h:
  51920. * html/HTMLHtmlElement.cpp:
  51921. (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  51922. * html/HTMLHtmlElement.h:
  51923. * html/HTMLLinkElement.cpp:
  51924. (WebCore::HTMLLinkElement::HTMLLinkElement):
  51925. * html/HTMLLinkElement.h:
  51926. * html/HTMLMetaElement.cpp:
  51927. (WebCore::HTMLMetaElement::HTMLMetaElement):
  51928. * html/HTMLMetaElement.h:
  51929. * html/HTMLParser.cpp:
  51930. (WebCore::HTMLParser::handleError):
  51931. (WebCore::HTMLParser::headCreateErrorCheck):
  51932. (WebCore::HTMLParser::createHead):
  51933. (WebCore::HTMLParser::finished):
  51934. * html/HTMLViewSourceDocument.cpp:
  51935. (WebCore::HTMLViewSourceDocument::createContainingTable):
  51936. 2008-11-25 Chris Marrin <cmarrin@apple.com>
  51937. Reviewed by Dan Bernstein.
  51938. Fix for https://bugs.webkit.org/show_bug.cgi?id=22487
  51939. I was not checking for the case of 0 length keyframe lists and dereffing a null pointer.
  51940. Tests: animations/empty-keyframes.html
  51941. animations/fill-unset-properties.html
  51942. * css/CSSStyleSelector.cpp:
  51943. (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  51944. 2008-11-25 Chris Marrin <cmarrin@apple.com>
  51945. Reviewed by Darin Adler
  51946. https://bugs.webkit.org/show_bug.cgi?id=22046
  51947. Fix a crash when an animation or transition end event handler
  51948. removes the element upon which the transition/animation is running,
  51949. by keeping a reference to the AnimationBase object on the stack.
  51950. Tests: animations/transform-animation-event-destroy-element.html
  51951. transitions/transform-transition-event-destroy-element.html
  51952. * page/animation/AnimationBase.cpp:
  51953. (WebCore::AnimationBase::setChanged):
  51954. (WebCore::AnimationBase::updateStateMachine):
  51955. * page/animation/AnimationBase.h:
  51956. (WebCore::AnimationBase::clearRenderer):
  51957. * page/animation/AnimationController.cpp:
  51958. (WebCore::AnimationControllerPrivate::clear):
  51959. * page/animation/CompositeAnimation.cpp:
  51960. (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
  51961. * page/animation/CompositeAnimation.h:
  51962. 2008-11-25 Kevin Ollivier <kevino@theolliviers.com>
  51963. Better wx build fix - support PurgeableBuffer on Mac.
  51964. * platform/PurgeableBuffer.h:
  51965. * webcore-wx.bkl:
  51966. 2008-11-25 Holger Hans Peter Freyther <zecke@selfish.org>
  51967. Reviewed by David Kilzer.
  51968. https://bugs.webkit.org/show_bug.cgi?id=22022
  51969. Add GeoleocationServiceGtk stubs and integrate it into the buildsystem
  51970. Add stubs for a Gtk Implementation.
  51971. * GNUmakefile.am:
  51972. * platform/gtk/GeolocationServiceGtk.cpp: Added.
  51973. (WebCore::GeolocationService::create):
  51974. (WebCore::GeolocationServiceGtk::GeolocationServiceGtk):
  51975. (WebCore::GeolocationServiceGtk::startUpdating):
  51976. (WebCore::GeolocationServiceGtk::stopUpdating):
  51977. (WebCore::GeolocationServiceGtk::suspend):
  51978. (WebCore::GeolocationServiceGtk::resume):
  51979. (WebCore::GeolocationServiceGtk::lastPosition):
  51980. (WebCore::GeolocationServiceGtk::lastError):
  51981. * platform/gtk/GeolocationServiceGtk.h: Added.
  51982. 2008-11-25 Kevin Ollivier <kevino@theolliviers.com>
  51983. wx build fix - we don't support PurgeableBuffer on Leopard for now.
  51984. * platform/PurgeableBuffer.h:
  51985. 2008-11-25 Antti Koivisto <antti@apple.com>
  51986. Reviewed by Mark Rowe.
  51987. Fix https://bugs.webkit.org/show_bug.cgi?id=22483
  51988. Assertion failure in CachedResource::makePurgeable during layout tests
  51989. Deleting SVG image can re-enter destroyDecodedData.
  51990. * loader/CachedImage.cpp:
  51991. (WebCore::CachedImage::destroyDecodedData):
  51992. 2008-11-25 David Levin <levin@chromium.org>
  51993. Reviewed by Alexey Proskuryakov.
  51994. https://bugs.webkit.org/show_bug.cgi?id=22443
  51995. Made the PreflightResultCache thread-safe in preparation for usage of XMLHttpRequest by
  51996. Workers on threads.
  51997. No observable change in behavior, so no test.
  51998. * platform/text/PlatformString.h:
  51999. * platform/text/String.cpp:
  52000. (WebCore::String::substringCopy):
  52001. * platform/text/StringImpl.cpp:
  52002. (WebCore::StringImpl::substringCopy):
  52003. * platform/text/StringImpl.h:
  52004. Added the ability to copy a substring.
  52005. * xml/XMLHttpRequest.cpp:
  52006. (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
  52007. (WebCore::PreflightResultCache::PreflightResultCache):
  52008. (WebCore::PreflightResultCacheItem::addToAccessControlAllowList):
  52009. (WebCore::PreflightResultCacheItem::parseAccessControlAllowList):
  52010. (WebCore::PreflightResultCacheItem::parseAccessControlMaxAge):
  52011. (WebCore::PreflightResultCacheItem::parse):
  52012. (WebCore::PreflightResultCacheItem::allowsRequest):
  52013. (WebCore::PreflightResultCache::shared):
  52014. (WebCore::PreflightResultCache::appendEntry):
  52015. (WebCore::PreflightResultCache::canSkipPreflight):
  52016. (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
  52017. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  52018. Made the PreflightResultCache threadsafe.
  52019. (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
  52020. (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
  52021. Consolidation of duplicate logic.
  52022. 2008-11-24 Jungshik Shin <jshin@chromium.org>
  52023. Reviewed by Darin Adler.
  52024. For Unicode encodings other than UTF-8, use UTF-8 for
  52025. form submission and URL query part encoding.
  52026. See https://bugs.webkit.org/show_bug.cgi?id=21635
  52027. Tests: http/tests/misc/submit-get-in-utf16be.html
  52028. http/tests/misc/submit-get-in-utf16le.html
  52029. http/tests/misc/submit-get-in-utf32be.html
  52030. http/tests/misc/submit-get-in-utf32le.html
  52031. http/tests/misc/submit-get-in-utf7.html
  52032. http/tests/misc/submit-post-in-utf16be.html
  52033. http/tests/misc/submit-post-in-utf16le.html
  52034. http/tests/misc/submit-post-in-utf32be.html
  52035. http/tests/misc/submit-post-in-utf32le.html
  52036. http/tests/misc/submit-post-in-utf7.html
  52037. http/tests/misc/url-in-utf16be.html
  52038. http/tests/misc/url-in-utf16le.html
  52039. http/tests/misc/url-in-utf32be.html
  52040. http/tests/misc/url-in-utf32le.html
  52041. http/tests/misc/url-in-utf7.html
  52042. * html/HTMLFormElement.cpp:
  52043. (WebCore::HTMLFormElement::formData):
  52044. * loader/TextResourceDecoder.cpp:
  52045. (WebCore::TextResourceDecoder::setEncoding):
  52046. * platform/KURL.cpp:
  52047. (WebCore::KURL::KURL):
  52048. * platform/text/TextEncoding.cpp:
  52049. (WebCore::UTF7Encoding):
  52050. (WebCore::TextEncoding::isNonByteBasedEncoding):
  52051. (WebCore::TextEncoding::closestByteBasedEquivalent):
  52052. (WebCore::TextEncoding::encodingForFormSubmission):
  52053. * platform/text/TextEncoding.h:
  52054. 2008-11-24 Julien Chaffraix <jchaffraix@webkit.org>
  52055. Reviewed by Darin Adler.
  52056. Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
  52057. https://bugs.webkit.org/show_bug.cgi?id=22441
  52058. - Make the generated ElementFactory constructors return PassRefPtr instead of raw pointers.
  52059. - Tweaked the generated files to better match our coding style.
  52060. * dom/make_names.pl:
  52061. 2008-11-24 Antti Koivisto <antti@apple.com>
  52062. Reviewed by Darin Adler.
  52063. Fix for https://bugs.webkit.org/show_bug.cgi?id=22073
  52064. REGRESSION(r33544): Palace in the Sky crashes WebKit
  52065. HTMLTokenizer::m_hasScriptsWaitingForStylesheets would still be set while
  52066. there were no scripts left to execute.
  52067. If m_hasScriptsWaitingForStylesheets becomes true during script execution
  52068. bail out from executing more scripts synchronously.
  52069. Test: fast/tokenizer/nested-cached-scripts-and-stylesheet.html
  52070. * html/HTMLTokenizer.cpp:
  52071. (WebCore::HTMLTokenizer::reset):
  52072. (WebCore::HTMLTokenizer::notifyFinished):
  52073. 2008-11-24 Darin Fisher <darin@chromium.org>
  52074. Reviewed by Geoffrey Garen.
  52075. https://bugs.webkit.org/show_bug.cgi?id=22465
  52076. Define KURL::copy() and use it in WorkerThread.cpp
  52077. * dom/WorkerThread.cpp:
  52078. (WebCore::WorkerThread::WorkerThread):
  52079. * platform/KURL.cpp:
  52080. (WebCore::KURL::copy):
  52081. * platform/KURL.h:
  52082. 2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52083. Reviewed by Sam Weinig.
  52084. Name enum values in a style guide compatible way.
  52085. Allow WMLIntrinsicEvent inclusion, without needing other includes.
  52086. * wml/WMLIntrinsicEvent.cpp:
  52087. (WebCore::createTaskElement):
  52088. * wml/WMLIntrinsicEvent.h:
  52089. * wml/WMLIntrinsicEventHandler.cpp:
  52090. * wml/WMLIntrinsicEventHandler.h:
  52091. (WebCore::):
  52092. 2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52093. Reviewed by Sam Weinig.
  52094. Add wmlPageStateForDocument() helper function and use it in some places.
  52095. * wml/WMLAccessElement.cpp:
  52096. (WebCore::WMLAccessElement::parseMappedAttribute):
  52097. * wml/WMLDocument.cpp:
  52098. (WebCore::WMLDocument::WMLDocument):
  52099. (WebCore::WMLDocument::finishedParsing):
  52100. (WebCore::wmlPageStateForDocument):
  52101. * wml/WMLDocument.h:
  52102. * wml/WMLGoElement.cpp:
  52103. (WebCore::WMLGoElement::executeTask):
  52104. * wml/WMLPrevElement.cpp:
  52105. (WebCore::WMLPrevElement::executeTask):
  52106. * wml/WMLRefreshElement.cpp:
  52107. (WebCore::WMLRefreshElement::executeTask):
  52108. * wml/WMLTaskElement.cpp:
  52109. (WebCore::WMLTaskElement::storeVariableState):
  52110. * wml/WMLTaskElement.h:
  52111. 2008-11-24 Antti Koivisto <antti@apple.com>
  52112. Reviewed by Geoff Garen and Sam Weinig.
  52113. https://bugs.webkit.org/show_bug.cgi?id=22214
  52114. Keep dead resources in memory cache in purgeable memory.
  52115. <rdar://problem/6333088>
  52116. OS X 10.5 has purgeable memory kernel facility that allows marking reserved memory
  52117. areas as less important. Under memory pressure system can steal pages that have
  52118. been marked purgeable for (hopefully) better uses. This is ideal for caches.
  52119. Only resources larger than 16KB will be moved to the purgeable memory.
  52120. * WebCore.base.exp:
  52121. * WebCore.vcproj/WebCore.vcproj:
  52122. * WebCore.xcodeproj/project.pbxproj:
  52123. * loader/Cache.cpp:
  52124. (WebCore::Cache::requestResource):
  52125. (WebCore::Cache::requestUserCSSStyleSheet):
  52126. (WebCore::Cache::resourceForURL):
  52127. (WebCore::Cache::pruneDeadResources):
  52128. (WebCore::Cache::TypeStatistic::addResource):
  52129. (WebCore::Cache::getStatistics):
  52130. (WebCore::Cache::dumpStats):
  52131. * loader/Cache.h:
  52132. (WebCore::Cache::TypeStatistic::TypeStatistic):
  52133. * loader/CachedCSSStyleSheet.cpp:
  52134. (WebCore::CachedCSSStyleSheet::allClientsRemoved):
  52135. (WebCore::CachedCSSStyleSheet::sheetText):
  52136. * loader/CachedCSSStyleSheet.h:
  52137. * loader/CachedImage.cpp:
  52138. (WebCore::CachedImage::addClient):
  52139. (WebCore::CachedImage::image):
  52140. (WebCore::CachedImage::imageSize):
  52141. (WebCore::CachedImage::imageRect):
  52142. (WebCore::CachedImage::destroyDecodedData):
  52143. * loader/CachedResource.cpp:
  52144. (WebCore::CachedResource::addClient):
  52145. (WebCore::CachedResource::makePurgeable):
  52146. (WebCore::CachedResource::isPurgeable):
  52147. (WebCore::CachedResource::wasPurged):
  52148. * loader/CachedResource.h:
  52149. (WebCore::CachedResource::data):
  52150. * loader/CachedScript.cpp:
  52151. (WebCore::CachedScript::allClientsRemoved):
  52152. (WebCore::CachedScript::script):
  52153. (WebCore::CachedScript::destroyDecodedData):
  52154. * platform/PurgeableBuffer.h: Added.
  52155. (WebCore::PurgeableBuffer::create):
  52156. (WebCore::PurgeableBuffer::size):
  52157. (WebCore::PurgeableBuffer::):
  52158. (WebCore::PurgeableBuffer::purgePriority):
  52159. (WebCore::PurgeableBuffer::isPurgeable):
  52160. (WebCore::PurgeableBuffer::~PurgeableBuffer):
  52161. (WebCore::PurgeableBuffer::data):
  52162. (WebCore::PurgeableBuffer::setPurgePriority):
  52163. (WebCore::PurgeableBuffer::wasPurged):
  52164. (WebCore::PurgeableBuffer::makePurgeable):
  52165. * platform/SharedBuffer.cpp:
  52166. (WebCore::SharedBuffer::~SharedBuffer):
  52167. (WebCore::SharedBuffer::adoptPurgeableBuffer):
  52168. (WebCore::SharedBuffer::size):
  52169. (WebCore::SharedBuffer::data):
  52170. (WebCore::SharedBuffer::append):
  52171. (WebCore::SharedBuffer::clear):
  52172. (WebCore::SharedBuffer::releasePurgeableBuffer):
  52173. * platform/SharedBuffer.h:
  52174. (WebCore::SharedBuffer::hasPurgeableBuffer):
  52175. * platform/cf/SharedBufferCF.cpp:
  52176. * platform/mac/PurgeableBufferMac.cpp: Added.
  52177. (WebCore::PurgeableBuffer::PurgeableBuffer):
  52178. (WebCore::PurgeableBuffer::~PurgeableBuffer):
  52179. (WebCore::PurgeableBuffer::create):
  52180. (WebCore::PurgeableBuffer::makePurgeable):
  52181. (WebCore::PurgeableBuffer::wasPurged):
  52182. (WebCore::PurgeableBuffer::setPurgePriority):
  52183. (WebCore::PurgeableBuffer::data):
  52184. 2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52185. Reviewed by George Staikos & Eric Seidel.
  52186. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22430
  52187. Regenerate WML layout test results after implementing WML specific <card> handling:
  52188. Only the first <card> element should be visible after loading the document, others
  52189. can be shown by using the <go> task element.
  52190. * dom/Document.h: Make 'finishedParsing()' a virtual function.
  52191. * wml/WMLCardElement.cpp:
  52192. (WebCore::WMLCardElement::WMLCardElement):
  52193. (WebCore::WMLCardElement::~WMLCardElement):
  52194. (WebCore::WMLCardElement::createRenderer):
  52195. (WebCore::WMLCardElement::setActiveCardInDocument):
  52196. (WebCore::WMLCardElement::setVisibility):
  52197. * wml/WMLCardElement.h:
  52198. * wml/WMLDocument.cpp:
  52199. (WebCore::WMLDocument::finishedParsing): Execute WML specific logic after tokenzing.
  52200. * wml/WMLDocument.h:
  52201. 2008-11-24 Glenn Wilson <gwilson@chromium.org>
  52202. Reviewed by Alexey Proskuryakov.
  52203. http://bugs.webkit.org/show_bug.cgi?id=15643
  52204. Added support for clients that wish to disable smart insert/delete
  52205. and enable the "trailing whitespace selection" work-around.
  52206. Tests: editing/selection/doubleclick-whitespace.html
  52207. * editing/Editor.cpp:
  52208. (WebCore::Editor::selectTrailingWhitespaceEnabled):
  52209. * editing/Editor.h:
  52210. * editing/Selection.cpp:
  52211. (WebCore::Selection::includeTrailingWhitespace):
  52212. * editing/Selection.h:
  52213. * loader/EmptyClients.h:
  52214. (WebCore::EmptyEditorClient::selectTrailingWhitespaceEnabled):
  52215. * page/EditorClient.h:
  52216. * page/EventHandler.cpp:
  52217. (WebCore::EventHandler::selectClosestWordFromMouseEvent):
  52218. 2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52219. Not reviewed. Forgot to include WMLPageState.h in last commit.
  52220. * wml/WMLPageState.h:
  52221. (WebCore::WMLPageState::restrictDeckAccessToDomain):
  52222. (WebCore::WMLPageState::restrictDeckAccessToPath):
  52223. 2008-11-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52224. Reviewed by Oliver Hunt & Eric Seidel.
  52225. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22431
  52226. Implement WMLAccessElement. It just propogates two attributes values to WMLPageState.
  52227. * WebCore.xcodeproj/project.pbxproj:
  52228. * wml/WMLAccessElement.cpp: Added.
  52229. (WebCore::WMLAccessElement::WMLAccessElement):
  52230. (WebCore::WMLAccessElement::parseMappedAttribute):
  52231. * wml/WMLAccessElement.h: Added.
  52232. * wml/WMLTagNames.in:
  52233. * wml/WMLPageState.h: Rename functions.
  52234. (WebCore::WMLPageState::restrictDeckAccessToDomain):
  52235. (WebCore::WMLPageState::restrictDeckAccessToPath):
  52236. * wml/WMLVariables.cpp: Add new helper function.
  52237. (WebCore::valueContainsVariableReference):
  52238. * wml/WMLVariables.h:
  52239. (WebCore::):
  52240. 2008-11-24 Darin Adler <darin@apple.com>
  52241. Reviewed by Dan Bernstein.
  52242. - https://bugs.webkit.org/show_bug.cgi?id=22470
  52243. remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
  52244. * loader/EmptyClients.h:
  52245. (WebCore::EmptyFrameLoaderClient::updateGlobalHistory): Remove argument.
  52246. * loader/FrameLoader.cpp:
  52247. (WebCore::FrameLoader::updateHistoryForStandardLoad): Don't pass the URL.
  52248. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
  52249. * loader/FrameLoaderClient.h: Remove argument.
  52250. 2008-11-24 Finnur Thorarinsson <finnur.webkit@gmail.com>
  52251. Reviewed by Darin Adler.
  52252. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22432
  52253. Add plumbing for tickmark support for the scrollbars. The painting code
  52254. for the scrollbar just needed to call paintTickmarks at the right time
  52255. and a default no-op implementation is provided, which the ports will
  52256. need to override.
  52257. * platform/ScrollbarThemeComposite.cpp:
  52258. (WebCore::ScrollbarThemeComposite::paint):
  52259. * platform/ScrollbarThemeComposite.h:
  52260. (WebCore::ScrollbarThemeComposite::paintTickmarks):
  52261. 2008-11-24 Darin Fisher <darin@chromium.org>
  52262. Reviewed by Sam Weinig.
  52263. https://bugs.webkit.org/show_bug.cgi?id=22448
  52264. Create an abstraction for JSC::SourceCode
  52265. * WebCore.vcproj/WebCore.vcproj:
  52266. * bindings/js/CachedScriptSourceProvider.h:
  52267. * bindings/js/ScriptController.cpp:
  52268. (WebCore::ScriptController::evaluate):
  52269. * bindings/js/ScriptController.h:
  52270. * bindings/js/ScriptSourceCode.h: Added.
  52271. (WebCore::ScriptSourceCode::ScriptSourceCode):
  52272. (WebCore::ScriptSourceCode::length):
  52273. (WebCore::ScriptSourceCode::jsSourceCode):
  52274. * bindings/js/WorkerScriptController.cpp:
  52275. (WebCore::Workevn ScriptController::evaluate):
  52276. * bindings/js/WorkerScriptController.h:
  52277. * dom/ScriptElement.cpp:
  52278. (WebCore::ScriptElement::insertedIntoDocument):
  52279. (WebCore::ScriptElement::childrenChanged):
  52280. (WebCore::ScriptElementData::evaluateScript):
  52281. (WebCore::ScriptElementData::notifyFinished):
  52282. * dom/ScriptElement.h:
  52283. * dom/WorkerThread.cpp:
  52284. (WebCore::WorkerThread::workerThread):
  52285. * dom/WorkerThread.h:
  52286. * dom/XMLTokenizer.cpp:
  52287. (WebCore::XMLTokenizer::notifyFinished):
  52288. * dom/XMLTokenizerLibxml2.cpp:
  52289. (WebCore::XMLTokenizer::endElementNs):
  52290. * dom/XMLTokenizerQt.cpp:
  52291. (WebCore::XMLTokenizer::parseEndElement):
  52292. * html/HTMLTokenizer.cpp:
  52293. (WebCore::HTMLTokenizer::scriptHandler):
  52294. (WebCore::HTMLTokenizer::scriptExecution):
  52295. (WebCore::HTMLTokenizer::notifyFinished):
  52296. * html/HTMLTokenizer.h:
  52297. * loader/FrameLoader.cpp:
  52298. (WebCore::FrameLoader::executeScript):
  52299. * loader/FrameLoader.h:
  52300. 2008-11-24 Darin Adler <darin@apple.com>
  52301. Reviewed by Dan Bernstein.
  52302. - finish https://bugs.webkit.org/show_bug.cgi?id=22295
  52303. track which history items are from page load failures
  52304. * WebCore.base.exp: Exported new function.
  52305. * loader/DocumentLoader.cpp:
  52306. (WebCore::DocumentLoader::urlForHistoryReflectsFailure): Added.
  52307. * loader/DocumentLoader.h: Ditto.
  52308. 2008-11-24 Chris Fleizach <cfleizach@apple.com>
  52309. Reviewed by Beth Dakin.
  52310. Bug 22461: AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class
  52311. https://bugs.webkit.org/show_bug.cgi?id=22461
  52312. Changing AccessibilityListBox to use its parent's signature for hit testing
  52313. * page/AccessibilityListBox.cpp:
  52314. (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  52315. * page/AccessibilityListBox.h:
  52316. 2008-11-24 Simon Fraser <simon.fraser@apple.com>
  52317. Fix Windows build: selectionRect() -> selectionBounds().
  52318. * page/win/FrameCGWin.cpp:
  52319. (WebCore::imageFromSelection):
  52320. 2008-11-24 Glenn Wilson <gwilson@chromium.org>
  52321. Reviewed by Darin Adler.
  52322. http://bugs.webkit.org/show_bug.cgi?id=18703
  52323. "Changing the 'size' property on a text input does not affect its length"
  52324. Text fields would not repaint themselves after having their "size"
  52325. attributes modified. This fix tells the object to recalculate its
  52326. width and repaint itself when its "size" attribute is parsed.
  52327. Test: fast/js/text-field-resize.html
  52328. * html/HTMLInputElement.cpp:
  52329. (WebCore::HTMLInputElement::parseMappedAttribute):
  52330. 2008-11-24 Simon Fraser <simon.fraser@apple.com>
  52331. Reviewed by Darin Adler
  52332. Followup from changes for https://bugs.webkit.org/show_bug.cgi?id=22433
  52333. Make RenderView::selectionRect() private to cause compile-time
  52334. errors if someone tries to call it.
  52335. * rendering/RenderView.h:
  52336. 2008-11-24 Simon Fraser <simon.fraser@apple.com>
  52337. Reviewed by Dan Bernstein
  52338. Via: https://bugs.webkit.org/show_bug.cgi?id=22433
  52339. Rename RenderView::selectionRect() to selectionBounds(), to remove
  52340. longstanding ambiguity with the base class selectionRect() method.
  52341. Do the same on Frame for consistency with RenderView. Assert
  52342. that RenderView::selectionRect() is never called.
  52343. * WebCore.base.exp:
  52344. * editing/SelectionController.cpp:
  52345. (WebCore::SelectionController::focusedOrActiveStateChanged):
  52346. * page/DragController.cpp:
  52347. (WebCore::dragLocForSelectionDrag):
  52348. * page/Frame.cpp:
  52349. (WebCore::Frame::selectionBounds):
  52350. (WebCore::Frame::revealSelection):
  52351. * page/Frame.h:
  52352. * page/mac/FrameMac.mm:
  52353. (WebCore::Frame::selectionImage):
  52354. * rendering/RenderView.cpp:
  52355. (WebCore::RenderView::selectionRect):
  52356. (WebCore::RenderView::selectionBounds):
  52357. * rendering/RenderView.h:
  52358. 2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
  52359. Reviewed by Darin Adler.
  52360. Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
  52361. https://bugs.webkit.org/show_bug.cgi?id=22441
  52362. - Make HTMLElementFactory::createHTMLElement take a QualifiedName instead of
  52363. an AtomicString.
  52364. - Updated the elements' constructors and the callers to reflect the previous change.
  52365. * dom/Document.cpp:
  52366. (WebCore::Document::createElement):
  52367. * html/HTMLDocument.cpp:
  52368. (WebCore::HTMLDocument::createElement):
  52369. * html/HTMLElement.cpp:
  52370. (WebCore::HTMLElement::cloneNode):
  52371. * html/HTMLElementFactory.cpp:
  52372. (WebCore::htmlConstructor):
  52373. (WebCore::headConstructor):
  52374. (WebCore::bodyConstructor):
  52375. (WebCore::baseConstructor):
  52376. (WebCore::linkConstructor):
  52377. (WebCore::metaConstructor):
  52378. (WebCore::styleConstructor):
  52379. (WebCore::titleConstructor):
  52380. (WebCore::frameConstructor):
  52381. (WebCore::framesetConstructor):
  52382. (WebCore::iframeConstructor):
  52383. (WebCore::formConstructor):
  52384. (WebCore::buttonConstructor):
  52385. (WebCore::inputConstructor):
  52386. (WebCore::isindexConstructor):
  52387. (WebCore::fieldsetConstructor):
  52388. (WebCore::keygenConstructor):
  52389. (WebCore::labelConstructor):
  52390. (WebCore::legendConstructor):
  52391. (WebCore::optgroupConstructor):
  52392. (WebCore::optionConstructor):
  52393. (WebCore::selectConstructor):
  52394. (WebCore::textareaConstructor):
  52395. (WebCore::dlConstructor):
  52396. (WebCore::ulConstructor):
  52397. (WebCore::olConstructor):
  52398. (WebCore::dirConstructor):
  52399. (WebCore::menuConstructor):
  52400. (WebCore::liConstructor):
  52401. (WebCore::blockquoteConstructor):
  52402. (WebCore::divConstructor):
  52403. (WebCore::headingConstructor):
  52404. (WebCore::hrConstructor):
  52405. (WebCore::paragraphConstructor):
  52406. (WebCore::preConstructor):
  52407. (WebCore::basefontConstructor):
  52408. (WebCore::fontConstructor):
  52409. (WebCore::modConstructor):
  52410. (WebCore::anchorConstructor):
  52411. (WebCore::imageConstructor):
  52412. (WebCore::mapConstructor):
  52413. (WebCore::areaConstructor):
  52414. (WebCore::canvasConstructor):
  52415. (WebCore::appletConstructor):
  52416. (WebCore::embedConstructor):
  52417. (WebCore::objectConstructor):
  52418. (WebCore::paramConstructor):
  52419. (WebCore::scriptConstructor):
  52420. (WebCore::tableConstructor):
  52421. (WebCore::tableCaptionConstructor):
  52422. (WebCore::tableColConstructor):
  52423. (WebCore::tableRowConstructor):
  52424. (WebCore::tableCellConstructor):
  52425. (WebCore::tableSectionConstructor):
  52426. (WebCore::brConstructor):
  52427. (WebCore::quoteConstructor):
  52428. (WebCore::marqueeConstructor):
  52429. (WebCore::audioConstructor):
  52430. (WebCore::videoConstructor):
  52431. (WebCore::sourceConstructor):
  52432. (WebCore::HTMLElementFactory::createHTMLElement):
  52433. * html/HTMLElementFactory.h:
  52434. * html/HTMLParser.cpp:
  52435. (WebCore::HTMLParser::getNode):
  52436. 2008-11-24 Brent Fulgham <bfulgham@gmail.com>
  52437. Reviewed by Alexey Proskuryakov.
  52438. https://bugs.webkit.org/show_bug.cgi?id=22444
  52439. Correct bad default constructor for Cairo FontPlatformData so that
  52440. the m_scaledFont member is initialized. Previously this would be
  52441. set to 0xbaadf00d, which would result in infinite loops while
  52442. attempting to deal with the font cache.
  52443. * platform/graphics/win/FontPlatformData.h:
  52444. (WebCore::FontPlatformData::FontPlatformData): Initialize m_scaledFont to 0
  52445. 2008-11-24 Alexey Proskuryakov <ap@webkit.org>
  52446. Reviewed by Darin Adler.
  52447. https://bugs.webkit.org/show_bug.cgi?id=22455
  52448. Add support for Worker.terminate()
  52449. Test: fast/workers/worker-terminate.html
  52450. * dom/Worker.idl:
  52451. * dom/Worker.cpp:
  52452. * dom/Worker.h:
  52453. Added terminate().
  52454. * dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
  52455. * dom/WorkerMessagingProxy.cpp:
  52456. (WebCore::MessageWorkerTask::performTask): Don't dispatch messages if the worker was asked
  52457. to terminate (this is not mentioned in draft spec, but makes sense anyway).
  52458. (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): The proxy now remembers if it was
  52459. asked to terminate in m_askedToTerminate member variable. Also, changed m_unconfirmedMessageCount
  52460. to only track messages that were posted to worker thread, avoiding a leak if the script
  52461. could not be loaded.
  52462. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Return early if terminating.
  52463. (WebCore::WorkerMessagingProxy::workerThreadCreated): Stop the thread if already asked for.
  52464. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Even if worker context
  52465. was destroyed, the worker object may still be alive now, so don't delete self in this case.
  52466. (WebCore::WorkerMessagingProxy::terminate): Stop the thread if it was already created, or
  52467. remember to stop it when it is created.
  52468. (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): Don't track activity
  52469. if the thread asked to stop anyway.
  52470. (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity): Ditto.
  52471. * dom/WorkerThread.cpp:
  52472. * dom/WorkerThread.h:
  52473. Fixed a race condition in stop().
  52474. 2008-11-24 Alexey Proskuryakov <ap@webkit.org>
  52475. Reviewed by Mark Rowe.
  52476. https://bugs.webkit.org/show_bug.cgi?id=22439
  52477. Won't load stylesheets with filenames less than 2 characters long in xhtml.
  52478. Test: http/tests/misc/single-character-pi-stylesheet.xhtml
  52479. * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  52480. Fix up the logic.
  52481. 2008-11-24 Holger Hans Peter Freyther <zecke@selfish.org>
  52482. Reviewed by Mark Rowe.
  52483. [Gtk+] Add configure option to enable Web Workers and enable it by default
  52484. Add --enable-workers to the buildsystem (used by build-webkit) add
  52485. the to be build files to the GNUmakefile.am and change build-webkit
  52486. to enable Web Workers by default.
  52487. * GNUmakefile.am:
  52488. 2008-11-24 Alexey Proskuryakov <ap@webkit.org>
  52489. Build fix (for Windows Cairo port?)
  52490. * page/DOMWindow.idl: Use ENABLE_CHANNEL_MESSAGING instead of ENABLE(CHANNEL_MESSAGING), as
  52491. the ENABLE macro is not available in idls.
  52492. 2008-11-22 Dimitri Glazkov <dglazkov@chromium.org>
  52493. Reviewed by Darin Adler.
  52494. https://bugs.webkit.org/show_bug.cgi?id=22421
  52495. Added ScriptValue to Visual Studio and XCode projects.
  52496. * WebCore.vcproj/WebCore.vcproj:
  52497. * WebCore.xcodeproj/project.pbxproj:
  52498. 2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52499. Reviewed by Holger Freyther.
  52500. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22426
  52501. Add WMLInstrinsicEvent/EventHandler implementation. Code not yet used.
  52502. * WebCore.xcodeproj/project.pbxproj:
  52503. * wml/WMLIntrinsicEvent.cpp: Added.
  52504. (WebCore::createTaskElement):
  52505. (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
  52506. * wml/WMLIntrinsicEvent.h: Added.
  52507. (WebCore::WMLIntrinsicEvent::create):
  52508. (WebCore::WMLIntrinsicEvent::createWithTask):
  52509. (WebCore::WMLIntrinsicEvent::taskElement):
  52510. * wml/WMLIntrinsicEventHandler.cpp: Added.
  52511. (WebCore::WMLIntrinsicEventHandler::WMLIntrinsicEventHandler):
  52512. (WebCore::WMLIntrinsicEventHandler::registerIntrinsicEvent):
  52513. (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
  52514. (WebCore::WMLIntrinsicEventHandler::hasIntrinsicEvent):
  52515. * wml/WMLIntrinsicEventHandler.h: Added.
  52516. (WebCore::):
  52517. 2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52518. Reviewed by Holger Freyther.
  52519. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22423
  52520. Add <go> stub implementation. Add complete <prev>/<refresh> and <setvar> implementation.
  52521. Activate code handling <setvar> registration in WMLTaskElement.
  52522. * wml/WMLGoElement.cpp: Added.
  52523. (WebCore::WMLGoElement::WMLGoElement):
  52524. (WebCore::WMLGoElement::~WMLGoElement):
  52525. (WebCore::WMLGoElement::parseMappedAttribute):
  52526. (WebCore::WMLGoElement::executeTask):
  52527. * wml/WMLGoElement.h: Added.
  52528. * wml/WMLPrevElement.cpp: Added.
  52529. (WebCore::WMLPrevElement::WMLPrevElement):
  52530. (WebCore::WMLPrevElement::~WMLPrevElement):
  52531. (WebCore::WMLPrevElement::executeTask):
  52532. * wml/WMLPrevElement.h: Added.
  52533. * wml/WMLRefreshElement.cpp: Added.
  52534. (WebCore::WMLRefreshElement::WMLRefreshElement):
  52535. (WebCore::WMLRefreshElement::~WMLRefreshElement):
  52536. (WebCore::WMLRefreshElement::executeTask):
  52537. * wml/WMLRefreshElement.h: Added.
  52538. * wml/WMLSetvarElement.cpp: Added.
  52539. (WebCore::WMLSetvarElement::WMLSetvarElement):
  52540. (WebCore::WMLSetvarElement::~WMLSetvarElement):
  52541. (WebCore::WMLSetvarElement::parseMappedAttribute):
  52542. (WebCore::WMLSetvarElement::insertedIntoDocument):
  52543. (WebCore::WMLSetvarElement::name):
  52544. (WebCore::WMLSetvarElement::value):
  52545. * wml/WMLSetvarElement.h: Added.
  52546. * wml/WMLTagNames.in:
  52547. * wml/WMLTaskElement.cpp:
  52548. (WebCore::WMLTaskElement::registerVariableSetter):
  52549. (WebCore::WMLTaskElement::storeVariableState):
  52550. * wml/WMLTaskElement.h:
  52551. * WebCore.xcodeproj/project.pbxproj:
  52552. 2008-11-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52553. Not reviewed. Forgot to include WMLPageState.* in the last commit.
  52554. * wml/WMLPageState.cpp:
  52555. (WebCore::WMLPageState::setNeedCheckDeckAccess):
  52556. * wml/WMLPageState.h:
  52557. (WebCore::WMLPageState::storeVariables):
  52558. 2008-11-21 Alexey Proskuryakov <ap@webkit.org>
  52559. Reviewed by Darin Adler.
  52560. https://bugs.webkit.org/show_bug.cgi?id=22397
  52561. Worker threads are not destroyed if running a JS loop
  52562. Since the event loop is not ever entered again in this case, the fix necessarily involves
  52563. some shared data hackery.
  52564. * dom/WorkerThread.cpp: (WebCore::WorkerThread::stop):
  52565. * dom/WorkerThread.h:
  52566. Added a stop() method, which asks the thread to exit as soon as possible. In the future, it
  52567. may need to abort other kinds of synchronous processing, such as importScripts or XHR.
  52568. * bindings/js/WorkerScriptController.cpp:
  52569. (WebCore::WorkerScriptController::WorkerScriptController):
  52570. (WebCore::WorkerScriptController::evaluate):
  52571. (WebCore::WorkerScriptController::forbidExecution):
  52572. * bindings/js/WorkerScriptController.h:
  52573. Added a forbidExecution() method, which interrupts currently running JS, and makes any
  52574. future calls to evaluate() return immediately.
  52575. * dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
  52576. Call WorkerThread::stop().
  52577. 2008-11-21 Kevin Watters <kevinwatters@gmail.com>
  52578. Reviewed by Kevin Ollivier.
  52579. Improve wx image drawing performance considerably when using wxGraphicsContext
  52580. by avoiding unnecessary copies and drawing.
  52581. https://bugs.webkit.org/show_bug.cgi?id=22404
  52582. * platform/graphics/wx/ImageWx.cpp:
  52583. (WebCore::BitmapImage::draw):
  52584. (WebCore::BitmapImage::drawPattern):
  52585. 2008-11-21 Kevin Watters <kevinwatters@gmail.com>
  52586. Reviewed by Kevin Ollivier.
  52587. Implementation of AffineTransform::mapRect for wx.
  52588. https://bugs.webkit.org/show_bug.cgi?id=22401
  52589. * platform/graphics/wx/AffineTransformWx.cpp:
  52590. (WebCore::AffineTransform::mapRect):
  52591. 2008-11-21 Justin Garcia <justin.garcia@apple.com>
  52592. Reviewed by Darin Adler.
  52593. <rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
  52594. Change link editing behavior to match TextEdit and MS Word when editing before and after
  52595. a link (Pages has two caret positions at link boundaries, Thunderbird and FF behave like we
  52596. used to, so it's difficult to get out of link editing mode):
  52597. When inserting before or after a link, always insert content outside of the link. This
  52598. makes it impossible to get stuck in link editing mode, while making it slightly more
  52599. difficult to edit link labels. WebKit editors that care about this can add UI for editing
  52600. link labels, like GMail and GoogleDocs have done. We never actually had any bugs complaining
  52601. about how it was difficult to edit link labels at the start/end, the code was just introduced
  52602. with another bug fix without much thought.
  52603. Don't remember removed links anymore, no other editor does this and it made it
  52604. difficult/impossible to get out of link editing mode. This code was added to fix
  52605. <rdar://problem/4069359>, which is fixed instead by removing the styles from an
  52606. enclosing anchor element from those styles that we remember when we delete content.
  52607. * editing/CompositeEditCommand.cpp:
  52608. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  52609. * editing/CompositeEditCommand.h:
  52610. * editing/DeleteSelectionCommand.cpp:
  52611. (WebCore::removeEnclosingAnchorStyle):
  52612. (WebCore::DeleteSelectionCommand::saveTypingStyleState):
  52613. (WebCore::DeleteSelectionCommand::doApply):
  52614. * editing/DeleteSelectionCommand.h:
  52615. * editing/EditCommand.cpp:
  52616. (WebCore::EditCommand::apply):
  52617. * editing/Editor.cpp:
  52618. (WebCore::Editor::appliedEditing):
  52619. * editing/InsertTextCommand.cpp:
  52620. (WebCore::InsertTextCommand::prepareForTextInsertion):
  52621. (WebCore::InsertTextCommand::input):
  52622. * editing/RemoveFormatCommand.cpp:
  52623. (WebCore::RemoveFormatCommand::doApply):
  52624. * editing/SelectionController.cpp:
  52625. (WebCore::SelectionController::setSelection):
  52626. * editing/SelectionController.h:
  52627. 2008-11-21 Alice Liu <alice.liu@apple.com>
  52628. Rubber-stamped by Dan Bernstein.
  52629. fixed <rdar://6340771> crashing on print preview
  52630. * platform/graphics/win/GraphicsContextCGWin.cpp:
  52631. (WebCore::GraphicsContext::drawWindowsBitmap):
  52632. 2008-11-21 Darin Fisher <darin@chromium.org>
  52633. Reviewed by Geoffrey Garen.
  52634. https://bugs.webkit.org/show_bug.cgi?id=22390
  52635. Abstract away JSC:: usage in WebCore/xml
  52636. * bindings/js/ScriptString.h: Added.
  52637. (WebCore::ScriptString::ScriptString):
  52638. (WebCore::ScriptString::operator JSC::UString):
  52639. (WebCore::ScriptString::isNull):
  52640. (WebCore::ScriptString::size):
  52641. (WebCore::ScriptString::operator=):
  52642. (WebCore::ScriptString::operator+=):
  52643. * inspector/InspectorController.cpp:
  52644. (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
  52645. (WebCore::InspectorResource::setXMLHttpRequestProperties):
  52646. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  52647. * inspector/InspectorController.h:
  52648. * xml/XMLHttpRequest.cpp:
  52649. (WebCore::XMLHttpRequest::responseText):
  52650. (WebCore::XMLHttpRequest::clearResponse):
  52651. (WebCore::XMLHttpRequest::dropProtection):
  52652. (WebCore::XMLHttpRequest::didFinishLoading):
  52653. (WebCore::XMLHttpRequest::didReceiveData):
  52654. * xml/XMLHttpRequest.h:
  52655. (WebCore::XMLHttpRequest::setLastSendURL):
  52656. 2008-11-21 Sam Weinig <sam@webkit.org>
  52657. Reviewed by Geoffrey Garen.
  52658. Destroy script decoded data on a zero-delay timer after
  52659. decoding. This means we now have no decoded script data
  52660. at the end of Membuster.
  52661. * loader/CachedScript.cpp:
  52662. (WebCore::CachedScript::CachedScript):
  52663. (WebCore::CachedScript::allClientsRemoved):
  52664. (WebCore::CachedScript::script):
  52665. (WebCore::CachedScript::decodedDataDeletionTimerFired):
  52666. * loader/CachedScript.h:
  52667. 2008-11-21 Simon Fraser <simon.fraser@apple.com>
  52668. Reviewed by Darin Adler
  52669. https://bugs.webkit.org/show_bug.cgi?id=22159
  52670. RenderBox::absoluteClippedOverflowRect() needs to inflate the rect by
  52671. maximalOutlineSize(), since a child might have an outline which projects
  52672. outside the parent overflowRect().
  52673. We also need to ensure that maximalOutlineSize() is updated early in styleDidChange,
  52674. so that it is valid for these repaints.
  52675. Test: fast/repaint/outline-child-repaint.html
  52676. * WebCore.xcodeproj/project.pbxproj:
  52677. * rendering/RenderBox.cpp:
  52678. (WebCore::RenderBox::styleDidChange):
  52679. (WebCore::RenderBox::absoluteClippedOverflowRect):
  52680. 2008-11-21 Jan Michael Alonzo <jmalonzo@webkit.org>
  52681. Gtk, Qt, and Wx build fix.
  52682. Add LinkHash.cpp in the build scripts.
  52683. Add LinkHash.h to Gtk's build script.
  52684. LinkHash.cpp/h was introduced in r38661.
  52685. * GNUmakefile.am:
  52686. * WebCore.pro:
  52687. * WebCoreSources.bkl:
  52688. 2008-11-21 Sam Weinig <sam@webkit.org>
  52689. Reviewed by Dan Bernstein.
  52690. Third step in https://bugs.webkit.org/show_bug.cgi?id=22394
  52691. Be more eager in destroying script decoded data
  52692. Destroy the decoded data when all clients are removed from a CachedScript.
  52693. * loader/CachedScript.cpp:
  52694. (WebCore::CachedScript::allClientsRemoved):
  52695. * loader/CachedScript.h:
  52696. (WebCore::CachedScript::allClientsRemoved):
  52697. 2008-11-21 Pierre-Olivier Latour <pol@apple.com>
  52698. Reviewed by Dan Bernstein.
  52699. WebKit should be using Device RGB colorspace everywhere for
  52700. consistency.
  52701. https://bugs.webkit.org/show_bug.cgi?id=22300
  52702. * page/mac/AccessibilityObjectWrapper.mm:
  52703. (CreateCGColorIfDifferent):
  52704. * platform/graphics/mac/ColorMac.h:
  52705. * platform/graphics/mac/ColorMac.mm:
  52706. (WebCore::nsColor):
  52707. (+[WebCoreControlTintObserver controlTintDidChange]):
  52708. * rendering/RenderThemeMac.mm:
  52709. (WebCore::convertNSColorToColor):
  52710. (WebCore::menuBackgroundColor):
  52711. 2008-11-20 Julien Chaffraix <jchaffraix@webkit.org>
  52712. Reviewed by Darin Adler.
  52713. Bug 22388: Add JSInterfaceName to the .in files
  52714. https://bugs.webkit.org/show_bug.cgi?id=22388
  52715. Add JSInterfaceName that is similar to interfaceName but
  52716. for the JS wrappers. JSInterfaceName is always equal to interfaceName
  52717. unless explicitly set.
  52718. * dom/make_names.pl:
  52719. * html/HTMLTagNames.in:
  52720. * svg/svgtags.in:
  52721. 2008-11-21 Sam Weinig <sam@webkit.org>
  52722. Reviewed by Geoffrey Garen.
  52723. Second step in https://bugs.webkit.org/show_bug.cgi?id=22394
  52724. Be more eager in destroying script decoded data
  52725. Use a new CachedScriptSourceProvider to keep CachedScripts as
  52726. CachedScripts, even down into JSC. This has the added benefit
  52727. of showing the CachedScripts as live in the Caches window.
  52728. * GNUmakefile.am:
  52729. * WebCore.vcproj/WebCore.vcproj:
  52730. * WebCore.xcodeproj/project.pbxproj:
  52731. * bindings/js/CachedScriptSourceProvider.h: Added.
  52732. (WebCore::CachedScriptSourceProvider::create):
  52733. (WebCore::CachedScriptSourceProvider::~CachedScriptSourceProvider):
  52734. (WebCore::CachedScriptSourceProvider::getRange):
  52735. (WebCore::CachedScriptSourceProvider::data):
  52736. (WebCore::CachedScriptSourceProvider::length):
  52737. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  52738. (WebCore::makeSource):
  52739. * dom/ScriptElement.cpp:
  52740. (WebCore::ScriptElementData::notifyFinished):
  52741. * dom/XMLTokenizer.cpp:
  52742. (WebCore::XMLTokenizer::notifyFinished):
  52743. * html/HTMLTokenizer.cpp:
  52744. (WebCore::HTMLTokenizer::notifyFinished):
  52745. 2008-11-21 Brett Wilson <brettw@chromium.org>
  52746. Fix debug-only build bustage due to a typo in an assert, and add new
  52747. files to the Windows build.
  52748. * Info.plist:
  52749. * WebCore.vcproj/WebCore.vcproj:
  52750. * platform/LinkHash.h:
  52751. (WebCore::LinkHashHash::avoidDeletedValue):
  52752. 2008-11-20 Brett Wilson <brettw@chromium.org>
  52753. Reviewed by Eric Seidel.
  52754. https://bugs.webkit.org/show_bug.cgi?id=22131
  52755. Factor out visited link hashing and types into a new file, LinkHash.
  52756. This also changes the hash type to 64 bits, but does not actually use
  52757. the extra bits yet.
  52758. * WebCore.xcodeproj/project.pbxproj:
  52759. (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
  52760. (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
  52761. * css/CSSStyleSelector.h:
  52762. (WebCore::CSSStyleSelector::visitedStateChanged):
  52763. * dom/Document.cpp:
  52764. * dom/Document.h:
  52765. * page/Page.cpp:
  52766. (WebCore::Page::visitedStateChanged):
  52767. * page/Page.h:
  52768. * page/PageGroup.cpp:
  52769. (WebCore::PageGroup::isLinkVisited):
  52770. (WebCore::PageGroup::addVisitedLink):
  52771. * page/PageGroup.h:
  52772. * platform/LinkHash.cpp: Added.
  52773. (WebCore::findSlashDotDotSlash):
  52774. (WebCore::findSlashSlash):
  52775. (WebCore::findSlashDotSlash):
  52776. (WebCore::containsColonSlashSlash):
  52777. (WebCore::cleanPath):
  52778. (WebCore::matchLetter):
  52779. (WebCore::needsTrailingSlash):
  52780. (WebCore::visitedLinkHash):
  52781. * platform/LinkHash.h: Added
  52782. (WebCore::LinkHashHash::hash):
  52783. (WebCore::LinkHashHash::equal):
  52784. (WebCore::LinkHashHash::avoidDeletedValue):
  52785. 2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52786. Reviewed by Alexey Proskuryakov.
  52787. No need to use getElementsByTagNameNS() in WML documents. Revert to using getElementByTagName() again.
  52788. * wml/WMLPElement.cpp:
  52789. (WebCore::WMLPElement::insertedIntoDocument):
  52790. 2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52791. Reviewed by Alexey Proskuryakov.
  52792. Fix some coding style/formatting issues in WMLAElement.
  52793. * wml/WMLAElement.cpp:
  52794. (WebCore::WMLAElement::parseMappedAttribute):
  52795. (WebCore::WMLAElement::defaultEventHandler):
  52796. * wml/WMLAElement.h:
  52797. 2008-11-21 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  52798. Reviewed by Alexey Proskuryakov.
  52799. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22399
  52800. Implement <anchor> support for WML, add WMLVariables file containing helper functions
  52801. for variable support, and a WMLTaskElement base class for WMLPrev/Go/RefreshElement.
  52802. * css/CSSStyleSelector.cpp:
  52803. (WebCore::linkAttribute):
  52804. * rendering/HitTestResult.cpp:
  52805. (WebCore::HitTestResult::absoluteImageURL):
  52806. (WebCore::HitTestResult::absoluteLinkURL):
  52807. (WebCore::HitTestResult::isLiveLink):
  52808. * wml/WMLAnchorElement.cpp: Added.
  52809. (WebCore::WMLAnchorElement::WMLAnchorElement):
  52810. (WebCore::WMLAnchorElement::~WMLAnchorElement):
  52811. (WebCore::WMLAnchorElement::defaultEventHandler):
  52812. * wml/WMLAnchorElement.h: Added.
  52813. (WebCore::WMLAnchorElement::registerTask):
  52814. * wml/WMLTagNames.in:
  52815. * wml/WMLTaskElement.cpp: Added.
  52816. (WebCore::WMLTaskElement::WMLTaskElement):
  52817. (WebCore::WMLTaskElement::~WMLTaskElement):
  52818. (WebCore::WMLTaskElement::insertedIntoDocument):
  52819. (WebCore::WMLTaskElement::addVariableSetter):
  52820. (WebCore::WMLTaskElement::removeVariableSetter):
  52821. (WebCore::WMLTaskElement::storeVariableState):
  52822. * wml/WMLTaskElement.h: Added.
  52823. * wml/WMLVariables.cpp: Added.
  52824. (WebCore::isValidVariableCharacter):
  52825. (WebCore::isValidVariableReferenceCharacter):
  52826. (WebCore::isValidVariableName):
  52827. (WebCore::substituteVariableReferences):
  52828. * wml/WMLVariables.h: Added.
  52829. (WebCore::):
  52830. 2008-11-21 Julien Chaffraix <jchaffraix@pleyo.com>
  52831. Rubber-stamped by Alexey Proskuryakov.
  52832. Build fix when building without WORKERS on non-POSIX, non-WINDOWS
  52833. machine.
  52834. Spotted by Mario Bensi.
  52835. * platform/text/TextCodecICU.cpp:
  52836. 2008-11-20 Sam Weinig <sam@webkit.org>
  52837. Reviewed by Geoffrey Garen.
  52838. First step in https://bugs.webkit.org/show_bug.cgi?id=22394
  52839. Be more eager in destroying script decoded data
  52840. Pass data to be used in script execution around as JSC::SourceCode instead
  52841. of a source, url, and starting line.
  52842. * bindings/js/ScriptController.cpp:
  52843. (WebCore::ScriptController::evaluate):
  52844. * bindings/js/ScriptController.h:
  52845. * bindings/js/StringSourceProvider.h:
  52846. (WebCore::makeSource):
  52847. * bindings/js/WorkerScriptController.cpp:
  52848. (WebCore::WorkerScriptController::evaluate):
  52849. * bindings/js/WorkerScriptController.h:
  52850. * dom/ScriptElement.cpp:
  52851. (WebCore::ScriptElement::insertedIntoDocument):
  52852. (WebCore::ScriptElement::childrenChanged):
  52853. (WebCore::ScriptElementData::evaluateScript):
  52854. (WebCore::ScriptElementData::notifyFinished):
  52855. * dom/ScriptElement.h:
  52856. * dom/WorkerThread.cpp:
  52857. (WebCore::WorkerThread::workerThread):
  52858. * dom/XMLTokenizer.cpp:
  52859. (WebCore::XMLTokenizer::notifyFinished):
  52860. * dom/XMLTokenizerLibxml2.cpp:
  52861. (WebCore::XMLTokenizer::endElementNs):
  52862. * dom/XMLTokenizerQt.cpp:
  52863. (WebCore::XMLTokenizer::parseEndElement):
  52864. * html/HTMLTokenizer.cpp:
  52865. (WebCore::HTMLTokenizer::scriptHandler):
  52866. (WebCore::HTMLTokenizer::scriptExecution):
  52867. (WebCore::HTMLTokenizer::notifyFinished):
  52868. * html/HTMLTokenizer.h:
  52869. * loader/FrameLoader.cpp:
  52870. (WebCore::FrameLoader::executeScript):
  52871. * loader/FrameLoader.h:
  52872. 2008-11-20 Sam Weinig <sam@webkit.org>
  52873. Reviewed by Geoffrey Garen.
  52874. Fix for https://bugs.webkit.org/show_bug.cgi?id=22392
  52875. REGRESION: XMLHttpRequest.responseText does unnecessary trip though WebCore::String
  52876. - Use jsOwnedStringOrNull to avoid conversion to WebCore::String.
  52877. * bindings/js/JSXMLHttpRequestCustom.cpp:
  52878. (WebCore::JSXMLHttpRequest::responseText):
  52879. * xml/XMLHttpRequest.idl:
  52880. 2008-11-20 Simon Fraser <simon.fraser@apple.com>
  52881. Reviewed by Dan Bernstein
  52882. https://bugs.webkit.org/show_bug.cgi?id=19623
  52883. When an non-layer object gained a transform, it would only repaint
  52884. the bounds of the new layer, which could result in redraw artifacts
  52885. if the new layer was smaller. So if we're gaining a transform, we
  52886. repaint.
  52887. Test: fast/repaint/change-transform.html
  52888. * rendering/RenderObject.cpp:
  52889. (WebCore::RenderObject::styleWillChange):
  52890. 2008-11-20 Adele Peterson <adele@apple.com>
  52891. Reviewed by Darin Adler.
  52892. Fix for <rdar://problem/6111436> Support upload progress events on Windows
  52893. * platform/network/cf/ResourceHandleCFNet.cpp:
  52894. (WebCore::didSendBodyData): Added.
  52895. (WebCore::ResourceHandle::start): Hook up didSendBodyData callback.
  52896. 2008-11-20 Justin Garcia <justin.garcia@apple.com>
  52897. Reviewed by Darin Adler.
  52898. <rdar://problem/2610675> Blank line that is quoted can't be deleted
  52899. If the caret is in an empty quoted paragraph, and either there is nothing before that
  52900. paragraph, or what is before is unquoted, and the user presses delete, unquote that
  52901. paragraph.
  52902. * editing/CompositeEditCommand.cpp:
  52903. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Added.
  52904. Removes the line break that holds open an empty paragraph and then attempts to
  52905. prune the blockquote(s) that held that line break in case they have been emptied
  52906. out. Places a line break to create in empty unquoted paragraph in place of the
  52907. quoted one that was removed.
  52908. * editing/CompositeEditCommand.h:
  52909. * editing/TypingCommand.cpp:
  52910. (WebCore::TypingCommand::deleteKeyPressed): Call breakOutOfEmptyBlockquotedParagraph.
  52911. * editing/htmlediting.cpp:
  52912. (WebCore::highestEnclosingNodeOfType): Added.
  52913. * editing/htmlediting.h:
  52914. 2008-11-20 Dean Jackson <dino@apple.com>
  52915. Reviewed by Antti Koivisto
  52916. https://bugs.webkit.org/show_bug.cgi?id=21247
  52917. Make transition shorthand property accept transition-delay.
  52918. Test: transitions/transition-shorthand-delay.html
  52919. * css/CSSParser.cpp:
  52920. (WebCore::CSSParser::parseTransitionShorthand):
  52921. 2008-11-20 Dean Jackson <dino@apple.com>
  52922. Reviewed by Antti Koivisto
  52923. https://bugs.webkit.org/show_bug.cgi?id=22368
  52924. Make sure pauseTransition API takes transition delay into account.
  52925. Test: transitions/transition-drt-api-delay.html
  52926. * page/animation/AnimationBase.cpp:
  52927. (WebCore::AnimationBase::pauseAtTime):
  52928. 2008-11-20 Simon Fraser <simon.fraser@apple.com>
  52929. Reviewed by Darin Adler
  52930. https://bugs.webkit.org/show_bug.cgi?id=20368
  52931. Implement getComputedStyle for animation properties. Remove individual
  52932. computed values for transform-origin-x, transform-origin-y, and just
  52933. return transform-origin instead. Return "none" for default animation-name,
  52934. and fix the initial value.
  52935. Tests: animations/computed-style.html
  52936. transforms/computed-style-origin.html
  52937. * css/CSSComputedStyleDeclaration.cpp:
  52938. (WebCore::):
  52939. (WebCore::getDelayValue):
  52940. (WebCore::getDurationValue):
  52941. (WebCore::getTimingFunctionValue):
  52942. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  52943. * rendering/style/RenderStyle.h:
  52944. (WebCore::InheritedFlags::initialAnimationName):
  52945. 2008-11-20 Justin Garcia <justin.garcia@apple.com>
  52946. Reviewed by Beth Dakin.
  52947. Preparation for:
  52948. <rdar://problem/2610675> Blank line that is quoted can't be deleted
  52949. To fix this we need to make changes to the code that creates selections to delete
  52950. when the user does a backward or forward delete with a caret selection. For certain
  52951. caret positions, we now want to remove something other than the standard "caret extended
  52952. backward/forward by one unit". The problem is that there were two pieces of code
  52953. responsible for doing this, one in Editor::deleteWithDirection, and another inside
  52954. TypingCommand::deleteKeyPressed. The code in deleteWithDirection is a recent
  52955. addition (r19172), and adding it there caused regressions because it prevented the
  52956. code in deleteKeyPressed from ever running. The regressions were never caught because
  52957. JS deletion uses deleteKeyPressed while manual deletion uses deleteWithDirection.
  52958. This patch removes selection creation code from deleteWithDirection so that deleteKeyPressed
  52959. can handle it. That required moving code to handle the kill ring down into deleteKeyPressed.
  52960. Follow up patches will fix <rdar://problem/2610675>, and attempt to eliminate the rest of the
  52961. discrepancies between the behavior of JS deletions and manual deletions, so that we
  52962. have better test coverage.
  52963. * editing/Editor.cpp:
  52964. (WebCore::Editor::deleteWithDirection): Early return if m_frame->document() is null, instead
  52965. of checking for that periodically throughout the function. There's really nothing to be done
  52966. if it's null anyway.
  52967. Move kill ring code down into deleteKeyPressed.
  52968. * editing/Editor.h:
  52969. * editing/TypingCommand.cpp:
  52970. (WebCore::TypingCommand::TypingCommand):
  52971. (WebCore::TypingCommand::deleteKeyPressed):
  52972. (WebCore::TypingCommand::forwardDeleteKeyPressed):
  52973. (WebCore::TypingCommand::doApply):
  52974. * editing/TypingCommand.h:
  52975. (WebCore::TypingCommand::create):
  52976. 2008-11-20 Darin Adler <darin@apple.com>
  52977. Earlier version reviewed by Justin Garcia.
  52978. - fix <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode
  52979. * editing/Editor.cpp:
  52980. (WebCore::Editor::handleKeyboardEvent): Remove isContentEditable check -- keyboard events can be
  52981. handled even when the selection is not in an editable area.
  52982. (WebCore::Editor::handleInputMethodKeydown): Ditto.
  52983. * editing/EditorCommand.cpp: Changed the enabled rule for operations that change the selection to
  52984. allow use when there's a selection even if it's not in an editable area. This includes commands
  52985. like shift-arrow keys to extend the slection, but not commands like arrow keys to move the
  52986. insertion point.
  52987. 2008-11-20 Alexey Proskuryakov <ap@webkit.org>
  52988. Reviewed by Darin Adler.
  52989. https://bugs.webkit.org/show_bug.cgi?id=22380
  52990. Fix WorkerContext refcounting
  52991. * dom/WorkerContext.cpp:
  52992. (WebCore::WorkerContext::WorkerContext):
  52993. * dom/WorkerContext.h:
  52994. (WebCore::WorkerContext::script):
  52995. (WebCore::WorkerContext::clearScript):
  52996. Added a method to manually destroy WorkerScriptController.
  52997. * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
  52998. Destroy WorkerScriptController to release any references to WorkerContext.
  52999. 2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
  53000. Reviewed by Darin Adler.
  53001. Last part of bug 21106: .in format discussed changes
  53002. https://bugs.webkit.org/show_bug.cgi?id=21106
  53003. - Renamed isAudioHack to wrapperOnlyIfMediaIsAvailable as requested.
  53004. - Cleaned up additionnal function parameters that were unneeded.
  53005. * dom/make_names.pl:
  53006. * html/HTMLTagNames.in:
  53007. 2008-11-20 Alexey Proskuryakov <ap@webkit.org>
  53008. Reviewed by Darin Adler.
  53009. https://bugs.webkit.org/show_bug.cgi?id=22383
  53010. Worker tests spill error messages over to consequent tests
  53011. * dom/Worker.cpp: (WebCore::Worker::Worker):
  53012. Raise an exception immediately if URL is empty. Dcoument::completeURL() returns document URL
  53013. in this case, and there is no sense in starting a thread and trying to parse document source
  53014. as JavaScript.
  53015. * bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  53016. Return quickly if toString() raised an exception.
  53017. 2008-11-19 Simon Fraser <simon.fraser@apple.com>
  53018. Reviewed by Adele Peterson.
  53019. https://bugs.webkit.org/show_bug.cgi?id=22190
  53020. Fix the painting and event handling in transformed search fields.
  53021. When painting the cancel and results button parts, get the rect from AppKit
  53022. relative to the input bounds (rather than in absolute coords), then convert
  53023. it into the coords of the part's renderer (which is the one that is painting).
  53024. To do this we need to compute an offset relative to some container, so expose
  53025. a method on RenderObject for that.
  53026. Also fix the location at which the search popup shows up to take transforms
  53027. into account, and fix the math that is used to figure out if the search
  53028. results button, or the cancel button should get the mouse events.
  53029. Test: fast/forms/search-transformed.html
  53030. * rendering/RenderBox.h:
  53031. * rendering/RenderObject.cpp:
  53032. (WebCore::RenderObject::offsetFromContainer):
  53033. * rendering/RenderObject.h:
  53034. * rendering/RenderTextControl.cpp:
  53035. (WebCore::RenderTextControl::forwardEvent):
  53036. (WebCore::RenderTextControl::showPopup):
  53037. * rendering/RenderThemeMac.h:
  53038. * rendering/RenderThemeMac.mm:
  53039. (WebCore::RenderThemeMac::convertToPaintingRect):
  53040. (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
  53041. (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
  53042. (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
  53043. 2008-11-20 Joerg Bornemann <joerg.bornemann@trolltech.com>
  53044. Reviewed by Simon Hausmann.
  53045. Steps towards making the the Qt port of WebKit compile on Windows CE
  53046. https://bugs.webkit.org/show_bug.cgi?id=20746
  53047. * WebCore.pro: Various fixes to include windows specific build options
  53048. also in the Windows CE build.
  53049. * loader/icon/IconDatabase.cpp: Removed unnecessary errno.h inclusion.
  53050. * platform/FileSystem.h: Changed Q_OS_WIN32 to Q_OS_WIN to include CE.
  53051. * platform/graphics/qt/GraphicsContextQt.cpp:
  53052. (WebCore::GraphicsContext::getWindowsContext): SetWorldTransform is
  53053. not available on CE.
  53054. * platform/graphics/qt/PathQt.cpp: Added local definition of M_PI.
  53055. * platform/qt/FileSystemQt.cpp: Changed Q_OS_WIN32 to Q_OS_WIN to include CE.
  53056. * platform/qt/KeyboardCodes.h: Extend #idefs to define the missing OEM
  53057. constants on CE.
  53058. * platform/qt/TemporaryLinkStubs.cpp: Added stubs for plugins.
  53059. * platform/text/RegularExpression.cpp: Removed unused sys/types.h and
  53060. pcre.h inclusions.
  53061. * platform/win/SystemTimeWin.cpp:
  53062. (WebCore::userIdleTime): Don't use GetLastInputInfo on CE, it does not
  53063. exist.
  53064. 2008-11-20 Antti Koivisto <antti@apple.com>
  53065. Reviewed by Maciej Stachowiak.
  53066. https://bugs.webkit.org/show_bug.cgi?id=22379
  53067. Make CSSOM use less memory
  53068. - Shrink CSSProperty by half by using bitfields.
  53069. - Get rid of m_strictParsing field in StyleBase by moving it up to CSSStyleSheet
  53070. and CSSMutableStyleDeclaration. This reduces size of many highly popular objects.
  53071. * css/CSSMutableStyleDeclaration.cpp:
  53072. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  53073. (WebCore::CSSMutableStyleDeclaration::operator=):
  53074. * css/CSSMutableStyleDeclaration.h:
  53075. (WebCore::CSSMutableStyleDeclaration::setStrictParsing):
  53076. (WebCore::CSSMutableStyleDeclaration::useStrictParsing):
  53077. * css/CSSProperty.h:
  53078. * css/CSSStyleSheet.cpp:
  53079. (WebCore::CSSStyleSheet::CSSStyleSheet):
  53080. * css/CSSStyleSheet.h:
  53081. (WebCore::CSSStyleSheet::setStrictParsing):
  53082. (WebCore::CSSStyleSheet::useStrictParsing):
  53083. * css/StyleBase.h:
  53084. (WebCore::StyleBase::useStrictParsing):
  53085. (WebCore::StyleBase::StyleBase):
  53086. 2008-11-19 Darin Fisher <darin@chromium.org>
  53087. Fix bustage.
  53088. https://bugs.webkit.org/show_bug.cgi?id=22373
  53089. Ports busted by addition of ScriptValue.{h,cpp}
  53090. * plugins/PluginView.cpp:
  53091. (WebCore::PluginView::performRequest):
  53092. 2008-11-19 Darin Fisher <darin@chromium.org>
  53093. Bustage fix.
  53094. https://bugs.webkit.org/show_bug.cgi?id=22373
  53095. Ports busted by addition of ScriptValue.{h,cpp}
  53096. * GNUmakefile.am:
  53097. * WebCore.pro:
  53098. * WebCoreSources.bkl:
  53099. * dom/XMLTokenizerQt.cpp:
  53100. * plugins/PluginView.cpp:
  53101. 2008-11-19 Darin Fisher <darin@chromium.org>
  53102. Reviewed by Geoff Garen.
  53103. https://bugs.webkit.org/show_bug.cgi?id=22345
  53104. Define ScriptValue as a thin container for a JSC::Value*.
  53105. * WebCore.vcproj/WebCore.vcproj:
  53106. * WebCore.xcodeproj/project.pbxproj:
  53107. * bindings/js/ScheduledAction.cpp:
  53108. * bindings/js/ScriptController.cpp:
  53109. (WebCore::ScriptController::evaluate):
  53110. * bindings/js/ScriptController.h:
  53111. * bindings/js/ScriptValue.cpp: Added.
  53112. (WebCore::ScriptValue::getString):
  53113. * bindings/js/ScriptValue.h: Added.
  53114. (WebCore::ScriptValue::ScriptValue):
  53115. (WebCore::ScriptValue::jsValue):
  53116. * dom/ScriptElement.cpp:
  53117. * dom/XMLTokenizer.cpp:
  53118. * dom/XMLTokenizerLibxml2.cpp:
  53119. * html/HTMLTokenizer.cpp:
  53120. * loader/FrameLoader.cpp:
  53121. (WebCore::FrameLoader::executeIfJavaScriptURL):
  53122. (WebCore::FrameLoader::executeScript):
  53123. * loader/FrameLoader.h:
  53124. 2008-11-19 Beth Dakin <bdakin@apple.com>
  53125. Reviewed by Justin Garcia.
  53126. Fix for <rdar://problem/5472507> Remove color property when a user
  53127. sets color to black
  53128. This patch prevents us from inserting font nodes during the
  53129. ApplyStyleCommand if they will not change the computed style of an
  53130. element.
  53131. * editing/ApplyStyleCommand.cpp:
  53132. (WebCore::fontColorChangesComputedStyle):
  53133. (WebCore::fontSizeChangesComputedStyle):
  53134. (WebCore::fontFaceChangesComputedStyle):
  53135. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  53136. 2008-11-19 Simon Fraser <simon.fraser@apple.com>
  53137. Reviewed by Antti Koivisto
  53138. https://bugs.webkit.org/show_bug.cgi?id=22111
  53139. Fix hit testing in controls on transformed video elements
  53140. by replacing absoluteBoundingBoxRect().contains() with
  53141. code that maps the point into local coords, taking
  53142. transforms into account.
  53143. Test: media/video-controls-transformed.html
  53144. * platform/graphics/MediaPlayer.h:
  53145. * rendering/RenderMedia.cpp:
  53146. (WebCore::rendererContainsPoint):
  53147. (WebCore::RenderMedia::forwardEvent):
  53148. 2008-11-19 Simon Fraser <simon.fraser@apple.com>
  53149. Reviewed by Darin Adler
  53150. https://bugs.webkit.org/show_bug.cgi?id=22348
  53151. Need to educate style sharing about autofill, so that style does not
  53152. get shared between input elements that are autofilled, and those
  53153. that are not. Setting autofill should also do a setChanged on the node.
  53154. * css/CSSStyleSelector.cpp:
  53155. (WebCore::CSSStyleSelector::canShareStyleWithElement):
  53156. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  53157. * dom/Node.h:
  53158. (WebCore::Node::isAutofilled):
  53159. * html/HTMLInputElement.cpp:
  53160. (WebCore::HTMLInputElement::setAutofilled):
  53161. * html/HTMLInputElement.h:
  53162. (WebCore::HTMLInputElement::isAutofilled):
  53163. 2008-11-19 Brett Wilson <brettw@chromium.org>
  53164. Reviewed by Antti Koivisto.
  53165. https://bugs.webkit.org/show_bug.cgi?id=22349
  53166. Clear the subresource loader client when the client is removed in
  53167. response to a 304 (not modified). This prevents an inconsistent state
  53168. where the loader thinks it's active and the loader::Host doesn't.
  53169. * loader/loader.cpp:
  53170. (WebCore::Loader::Host::didReceiveResponse):
  53171. 2008-11-19 Alexey Proskuryakov <ap@webkit.org>
  53172. Reviewed by Darin Adler.
  53173. https://bugs.webkit.org/show_bug.cgi?id=22355
  53174. Systematize code for replacing global constructors
  53175. Test: fast/workers/worker-replace-global-constructor.html
  53176. * bindings/js/JSDOMWindowBase.cpp:
  53177. (setJSDOMWindowBaseEvent): Changed to put the value as property, matching what generated
  53178. code for global constructor setters does.
  53179. (setJSDOMWindowBaseAudio): Ditto.
  53180. (setJSDOMWindowBaseImage): Ditto.
  53181. (setJSDOMWindowBaseMessageChannel): Ditto.
  53182. (setJSDOMWindowBaseOption): Ditto.
  53183. (setJSDOMWindowBaseWorker): Ditto.
  53184. (setJSDOMWindowBaseXMLHttpRequest): Ditto.
  53185. (setJSDOMWindowBaseXSLTProcessor): Ditto.
  53186. (WebCore::JSDOMWindowBase::put): Removed special cases for global constructors.
  53187. * bindings/js/JSWorkerContext.cpp:
  53188. (WebCore::JSWorkerContext::getOwnPropertySlot): Look up overrides before own properties,
  53189. as it is done for Window.
  53190. (WebCore::setJSWorkerContextMessageEvent): Implemented in the same way as Window global
  53191. constructors are.
  53192. (WebCore::setJSWorkerContextWorkerLocation): Ditto.
  53193. 2008-11-19 Alexey Proskuryakov <ap@webkit.org>
  53194. Reviewed by Darin Adler.
  53195. https://bugs.webkit.org/show_bug.cgi?id=22341
  53196. Text codecs should not use static data without locking
  53197. * platform/text/TextCodecICU.cpp:
  53198. * platform/text/mac/TextCodecMac.cpp:
  53199. Made cached converters per-thread.
  53200. * platform/text/TextEncodingRegistry.cpp:
  53201. (WebCore::encodingRegistryMutex): Added a mutex for codec maps access.
  53202. (WebCore::addToTextCodecMap): Don't use TextEncoding just to canonicalize the name, as it
  53203. causes a deadlock due to a recursive call into registry.
  53204. (WebCore::buildBaseTextCodecMaps): Added assertions.
  53205. (WebCore::newTextCodec): Take a lock to avoid concurrent access to codec maps.
  53206. (WebCore::atomicCanonicalTextEncodingName): Ditto.
  53207. (WebCore::noExtendedTextEncodingNameUsed): Added a comment, explaining why locking is not
  53208. necessary here.
  53209. 2008-11-19 Alexey Proskuryakov <ap@webkit.org>
  53210. Touch WebCorePrefix.h to force a rebuild, needed because of changed feature defines.
  53211. * WebCorePrefix.h:
  53212. 2008-11-19 Alexey Proskuryakov <ap@webkit.org>
  53213. Reviewed by Darin Adler.
  53214. https://bugs.webkit.org/show_bug.cgi?id=22310
  53215. Worker exceptions should be printed to console
  53216. * dom/Document.cpp: (WebCore::Document::reportException):
  53217. * dom/Document.h:
  53218. * dom/ScriptExecutionContext.h:
  53219. * dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  53220. * dom/WorkerContext.h:
  53221. Added a reportException() method on ScriptExecutionContext. It forwards the exception info
  53222. up until it finds a Document context, and then it prints it to console.
  53223. * bindings/js/JSEventListener.cpp:
  53224. (WebCore::JSAbstractEventListener::handleEvent): Don't talk to Console directly, use
  53225. ScriptExecutionContext::reportException. Also, fixed a bug where Document::updateDocumentsRendering()
  53226. could be called from workers.
  53227. (WebCore::JSLazyEventListener::parseCode): Moved variable declaration inside if block for clarity.
  53228. * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  53229. Report exceptions to ScriptExecutionContext.
  53230. * dom/WorkerMessagingProxy.cpp:
  53231. (WebCore::MessageWorkerTask::performTask):
  53232. (WebCore::WorkerExceptionTask::create):
  53233. (WebCore::WorkerExceptionTask::WorkerExceptionTask):
  53234. (WebCore::WorkerExceptionTask::performTask):
  53235. (WebCore::WorkerMessagingProxy::postWorkerException):
  53236. * dom/WorkerMessagingProxy.h:
  53237. Added a task for posting exception information.
  53238. * bindings/js/JSDOMBinding.cpp:
  53239. (WebCore::reportException):
  53240. (WebCore::reportCurrentException):
  53241. * bindings/js/JSDOMBinding.h:
  53242. Added helper methods for reporting exceptions via ScriptExecutionContext.
  53243. * page/Console.cpp:
  53244. * page/Console.h:
  53245. Removed methods for directly reporting exceptions to console.
  53246. * bindings/js/JSCustomPositionCallback.cpp:
  53247. (WebCore::JSCustomPositionCallback::handleEvent):
  53248. * bindings/js/JSCustomPositionErrorCallback.cpp:
  53249. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  53250. * bindings/js/JSCustomSQLStatementCallback.cpp:
  53251. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  53252. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  53253. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  53254. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  53255. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  53256. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  53257. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  53258. * bindings/js/JSCustomVoidCallback.cpp:
  53259. (WebCore::JSCustomVoidCallback::handleEvent):
  53260. * bindings/js/JSCustomXPathNSResolver.cpp:
  53261. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  53262. * bindings/js/ScheduledAction.cpp:
  53263. (WebCore::ScheduledAction::execute):
  53264. * bindings/js/ScriptController.cpp:
  53265. (WebCore::ScriptController::evaluate):
  53266. * bindings/objc/WebScriptObject.mm:
  53267. (WebCore::addExceptionToConsole):
  53268. Switch to JSDOMBinding methods for reporting exceptions.
  53269. 2008-11-18 Dan Bernstein <mitz@apple.com>
  53270. Reviewed by Mark Rowe.
  53271. - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=22331
  53272. <rdar://problem/6381657> REGRESSION: Contextual menu no longer has an "Inspect Element" item
  53273. * platform/ContextMenuItem.h:
  53274. (WebCore::ContextMenuAction): Reorder this enum to keep it in sync with
  53275. the one in WebUIDelegate.h.
  53276. 2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
  53277. Reviewed by Darin Adler.
  53278. https://bugs.webkit.org/show_bug.cgi?id=22346
  53279. PlatformString should also include HashSet.h for non-JSC builds
  53280. * platform/text/PlatformString.h:
  53281. 2008-11-18 Adele Peterson <adele@apple.com>
  53282. Reviewed by Holger Hans Peter Freyther.
  53283. Flip check added in recent refactoring so the background gets updated when the background color is valid, not invalid.
  53284. * loader/FrameLoaderClient.cpp: (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
  53285. 2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
  53286. Reviewed by Sam Weinig.
  53287. https://bugs.webkit.org/show_bug.cgi?id=22343
  53288. Remove unused runtime/Collector, JSLock includes in Page.cpp
  53289. * page/Page.cpp:
  53290. 2008-11-18 Ada Chan <adachan@apple.com>
  53291. Bug 22344: Make select popup window opaque
  53292. https://bugs.webkit.org/show_bug.cgi?id=22344
  53293. Reviewed by Steve Falkenburg.
  53294. * platform/win/PopupMenuWin.cpp:
  53295. (WebCore::PopupMenu::show):
  53296. 2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
  53297. Reviewed by Sam Weinig.
  53298. https://bugs.webkit.org/show_bug.cgi?id=22342
  53299. Remove unused JSLock.h include
  53300. * dom/Document.cpp:
  53301. 2008-11-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  53302. Reviewed by Sam Weinig.
  53303. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22334
  53304. Add WMLBRElement, correcting <br/> behaviour in WML.
  53305. Enable entity replacment for WML documents.
  53306. Handle WML specific <p> 'mode' attribute.
  53307. Generate layout tests results for fast/wml.
  53308. Tests cases that pass now:
  53309. fast/wml/br-element-in-table.wml
  53310. fast/wml/br-element-in-text.wml
  53311. fast/wml/case-sensitivity.wml
  53312. fast/wml/cdata-section.wml
  53313. fast/wml/comment.wml
  53314. fast/wml/entity.wml
  53315. fast/wml/p-align.wml
  53316. fast/wml/p-mode.wml
  53317. fast/wml/text-emphasis.wml
  53318. fast/wml/validate-dtd.wml
  53319. * GNUmakefile.am:
  53320. * WebCore.pro:
  53321. * WebCore.xcodeproj/project.pbxproj:
  53322. * dom/XMLTokenizer.cpp:
  53323. (WebCore::XMLTokenizer::isWMLDocument):
  53324. (WebCore::XMLTokenizer::insertErrorMessageBlock):
  53325. * dom/XMLTokenizer.h:
  53326. * dom/XMLTokenizerLibxml2.cpp:
  53327. (WebCore::XMLTokenizer::internalSubset):
  53328. (WebCore::getEntityHandler):
  53329. * dom/XMLTokenizerQt.cpp:
  53330. (WebCore::XMLTokenizer::parse):
  53331. * wml/WMLBRElement.cpp: Added.
  53332. (WebCore::WMLBRElement::WMLBRElement):
  53333. (WebCore::WMLBRElement::mapToEntry):
  53334. (WebCore::WMLBRElement::parseMappedAttribute):
  53335. (WebCore::WMLBRElement::createRenderer):
  53336. * wml/WMLBRElement.h: Added.
  53337. * wml/WMLPElement.cpp:
  53338. (WebCore::WMLPElement::parseMappedAttribute):
  53339. (WebCore::WMLPElement::insertedIntoDocument):
  53340. * wml/WMLPElement.h:
  53341. * wml/WMLTagNames.in:
  53342. 2008-11-18 Alexey Proskuryakov <ap@webkit.org>
  53343. Windows build fix.
  53344. * WebCore.vcproj/WebCore.vcproj: Fix relative paths to use $(WebKitOutputDir).
  53345. 2008-11-18 Darin Adler <darin@apple.com>
  53346. - try to fix Wx build
  53347. * WebCoreSources.bkl: Added FrameLoaderClient.cpp.
  53348. 2008-11-18 Alexey Proskuryakov <ap@webkit.org>
  53349. Reviewed by Darin Adler.
  53350. https://bugs.webkit.org/show_bug.cgi?id=22337
  53351. Enable workers by default
  53352. Tests: fast/workers/worker-constructor.html
  53353. fast/workers/worker-event-listener.html
  53354. fast/workers/worker-gc.html
  53355. fast/workers/worker-location.html
  53356. * Configurations/WebCore.xcconfig:
  53357. * WebCore.vcproj/WebCore.vcproj:
  53358. * WebCore.vcproj/build-generated-files.sh:
  53359. Define ENABLE_WORKERS.
  53360. 2008-11-18 Darin Adler <darin@apple.com>
  53361. Reviewed by Alexey Proskuryakov.
  53362. - first cut at https://bugs.webkit.org/show_bug.cgi?id=10957
  53363. <rdar://problem/5516594> please add support for HTTP-only cookies
  53364. Test: http/tests/xmlhttprequest/get-dangerous-headers.html
  53365. No test for HTTP-only support in JavaScript yet, since the Mac and Win changes
  53366. require an updated CFNetwork.
  53367. * platform/mac/CookieJar.mm:
  53368. (WebCore::isHTTPOnly): Added.
  53369. (WebCore::filterCookies): Added.
  53370. (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
  53371. (WebCore::setCookies): Use filterCookies to prevent setting HTTP-only cookies.
  53372. * platform/network/win/CookieJarCFNetWin.cpp:
  53373. (WebCore::isHTTPOnly): Added.
  53374. (WebCore::filterCookies): Added.
  53375. (WebCore::setCookies): Use filterCookies to prevent getting HTTP-only cookies.
  53376. (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
  53377. * xml/XMLHttpRequest.cpp:
  53378. (WebCore::isSetCookieHeader): Added.
  53379. (WebCore::XMLHttpRequest::getAllResponseHeaders): Hide Set-Cookie headers from
  53380. clients that don't have local-resource privileges.
  53381. (WebCore::XMLHttpRequest::getResponseHeader): Ditto.
  53382. - clean soup-specific details out of shared cookie jar header
  53383. * platform/CookieJar.h: Removed the soup-specific parts of this.
  53384. * platform/network/soup/CookieJarSoup.cpp: Changed to include
  53385. CookieJarSoup.h. Tweaked implementation a bit to handle UTF-8 better.
  53386. * platform/network/soup/CookieJarSoup.h: Added. Has the Soup-specified
  53387. part of CookieJar.h.
  53388. * platform/network/soup/ResourceHandleSoup.cpp: Changed to include
  53389. CookieJarSoup.h.
  53390. 2008-11-18 Steve Falkenburg <sfalken@apple.com>
  53391. https://bugs.webkit.org/show_bug.cgi?id=22329
  53392. Improper bitwise and tests against 0 in Windows context menu code
  53393. Reviewed by John Sullivan.
  53394. * platform/win/ContextMenuItemWin.cpp:
  53395. (WebCore::ContextMenuItem::type):
  53396. (WebCore::ContextMenuItem::enabled):
  53397. 2008-11-18 John Sullivan <sullivan@apple.com>
  53398. Yet more Mac build fixing
  53399. * WebCore.base.exp: Export __ZTVN7WebCore17FrameLoaderClientE
  53400. 2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
  53401. Reviewed by Simon Hausmann.
  53402. React properly to frame rect changes for QWidget based plugins
  53403. We now set the geometry of the QWidget in frameRectsChanged,
  53404. intead of setFrameRect, which means we pick up the changes to
  53405. the frame rect when scrolling. We also set a mask on the
  53406. widget to keep it from painting over scrollbars and the like
  53407. * platform/qt/WidgetQt.cpp:
  53408. (WebCore::Widget::setFrameRect):
  53409. 2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
  53410. Rubber-stamped by Simon Hausmann.
  53411. Don't mark scrollbars as focused in QtWebKit
  53412. When initing from the widget we also got the focus state,
  53413. but this does not make sense for scrollbars.
  53414. * platform/qt/ScrollbarThemeQt.cpp:
  53415. (WebCore::styleOptionSlider):
  53416. 2008-11-18 Alexey Proskuryakov <ap@webkit.org>
  53417. More Mac build fixing.
  53418. * WebCore.base.exp: Export FrameLoaderClient destructor.
  53419. 2008-11-18 Alexey Proskuryakov <ap@webkit.org>
  53420. Mac build fix.
  53421. * WebCore.xcodeproj/project.pbxproj: Add FrameLoaderClient.cpp for now.
  53422. 2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
  53423. Reviewed by Simon Hausmann.
  53424. https://bugs.webkit.org/show_bug.cgi?id=22056
  53425. Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
  53426. After Hyatt's work on Widget and ScrollView there is little difference
  53427. between the implementation of Qt, Gtk+ and Win. In fact any kind of
  53428. difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
  53429. port and the Qt port has at least one of them left.
  53430. The only difference between the implementations is in getting the the
  53431. IntSize for the new FrameView, the background color to be applied and
  53432. eventually some post processing.
  53433. Unify the implementations by providing a static helper function that
  53434. takes a Frame, IntSize, color and transparency bit and calling it from
  53435. the Gtk+, the Qt and the Windows port.
  53436. * GNUmakefile.am:
  53437. * WebCore.pro:
  53438. * WebCore.vcproj/WebCore.vcproj:
  53439. * loader/FrameLoaderClient.cpp: Added.
  53440. (WebCore::FrameLoaderClient::~FrameLoaderClient):
  53441. (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
  53442. * loader/FrameLoaderClient.h:
  53443. 2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
  53444. Reviewed by Simon Hausmann.
  53445. https://bugs.webkit.org/show_bug.cgi?id=22056
  53446. Move setting the background color and transparency from WebKit/win
  53447. to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
  53448. to share this code.
  53449. * page/FrameView.cpp:
  53450. (WebCore::FrameView::updateBackgroundRecursively):
  53451. * page/FrameView.h:
  53452. 2008-11-18 Ariya Hidayat <ariya.hidayat@trolltech.com>
  53453. Reviewed by Tor Arne Vestbø.
  53454. Fix the bug where select elements are painted without border.
  53455. http://trolltech.com/developer/task-tracker/index_html?id=218957&method=entry
  53456. * platform/qt/RenderThemeQt.cpp:
  53457. (WebCore::RenderThemeQt::paintMenuList):
  53458. 2008-11-18 Jan Michael Alonzo <jmalonzo@webkit.org>
  53459. Gtk build fix. Not reviewed.
  53460. * GNUmakefile.am: Fix USER_AGENT_STYLESHEETS, wml.css is in css/,
  53461. not in wml/.
  53462. 2008-11-18 Alexey Proskuryakov <ap@webkit.org>
  53463. Reviewed by Darin Adler.
  53464. https://bugs.webkit.org/show_bug.cgi?id=22308
  53465. Improve Worker GC behavior
  53466. * dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::hasPendingActivity):
  53467. * dom/ActiveDOMObject.h:
  53468. Made hasPendingActivity() virtual, letting Worker add behavior to it.
  53469. * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  53470. * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
  53471. Tell message proxy whether there are active objects in the worker whenever JS execution
  53472. finishes.
  53473. * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::activeDOMObjects):
  53474. Added a typedef for activeDOMObjects() return type, necessary to declare iterators.
  53475. * dom/Worker.h:
  53476. * dom/Worker.cpp: (WebCore::Worker::hasPendingActivity): A Worker is active if it is still
  53477. loading, or if it has unconfirmed messages, or it the worker thread has pending activity.
  53478. * dom/WorkerContext.h:
  53479. * dom/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Check all registered
  53480. active objects for pending activity.
  53481. * dom/WorkerMessagingProxy.cpp:
  53482. (WebCore::MessageWorkerContextTask::performTask):
  53483. (WebCore::WorkerThreadActivityReportTask::create):
  53484. (WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask):
  53485. (WebCore::WorkerThreadActivityReportTask::performTask):
  53486. (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
  53487. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
  53488. (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
  53489. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
  53490. (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
  53491. (WebCore::WorkerMessagingProxy::reportWorkerThreadActivity):
  53492. (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal):
  53493. (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity):
  53494. * dom/WorkerMessagingProxy.h:
  53495. Track outstanding messages, and activity reported by worker thread.
  53496. 2008-11-18 Alexey Proskuryakov <ap@webkit.org>
  53497. Rubber-stamped by Darin Adler.
  53498. https://bugs.webkit.org/show_bug.cgi?id=22306
  53499. Disable channel messaging support
  53500. * bindings/js/JSDOMWindowBase.cpp:
  53501. (jsDOMWindowBaseMessageChannel):
  53502. * page/DOMWindow.idl:
  53503. Hide MesssagePort and MessageChannel global constructors. Due to the way MessageChannel
  53504. constructor is added, it remains enumerable, but undefined.
  53505. 2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  53506. Reviewed by Mark Rowe.
  53507. Remove WBXML code. MainResourceLoader is not an appropriate location.
  53508. Revert until we find a better place.
  53509. The mime type which belongs to wmlc should be enabled anyway so WML documents get build.
  53510. Remove the ENABLE(WBXML) blocks around these types in MIMETypeRegistry / DOMImplementation.
  53511. * WebCore.pro:
  53512. * dom/DOMImplementation.cpp:
  53513. (WebCore::DOMImplementation::createDocument):
  53514. * loader/MainResourceLoader.cpp:
  53515. (WebCore::MainResourceLoader::addData):
  53516. * platform/MIMETypeRegistry.cpp:
  53517. (WebCore::initializeSupportedNonImageMimeTypes):
  53518. 2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  53519. Not reviewed. Build fix.
  53520. Oops, disable WML by default on Qt.
  53521. * WebCore.pro:
  53522. 2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
  53523. Reviewed by George Staikos.
  53524. Fixes: https://bugs.webkit.org/show_bug.cgi?id=22324 (Add basic subset of WML elements)
  53525. Add first bits of WML support. Only <card> & <p> and <a> elements are supported in this first patch.
  53526. Support for most other elements will be added step-by-step (merging in small chunks from a big patch).
  53527. WML is not build by default.
  53528. * DerivedSources.make: Handle WMLNames/WMLElementFactory generation.
  53529. * GNUmakefile.am: Add new files and generator hooks.
  53530. * WebCore.pro: Ditto.
  53531. * WebCore.xcodeproj/project.pbxproj: Ditto.
  53532. * css/CSSStyleSelector.cpp: Load wml.css on demand, just like it's done for SVG.
  53533. (WebCore::linkAttribute):
  53534. (WebCore::CSSStyleSelector::styleForElement):c
  53535. * css/wml.css: Added.
  53536. * dom/DOMImplementation.cpp: Handle WMLDocument creation
  53537. (WebCore::DOMImplementation::createDocument):
  53538. * dom/Document.cpp: Handle WMLElement creation.
  53539. (WebCore::Document::createElement):
  53540. * dom/Document.h: Add helper function identifying WML documents.
  53541. (WebCore::Document::isWMLDocument):
  53542. * dom/Node.h: Add heper function identifying WML elements.
  53543. (WebCore::Node::isWMLElement):
  53544. * dom/XMLTokenizer.cpp: Handle errors in WML documents
  53545. (WebCore::XMLTokenizer::insertErrorMessageBlock):
  53546. * dom/XMLTokenizerLibxml2.cpp: Add WML DTD checks.
  53547. (WebCore::XMLTokenizer::internalSubset):
  53548. * dom/XMLTokenizerQt.cpp: Ditto.
  53549. (WebCore::):
  53550. * dom/make_names.pl: Force internal linkage for the "tagConstructor" functions, avoiding SVG<->WML clashes.
  53551. * history/BackForwardList.cpp: Add WML specific function for clearing the history.
  53552. (WebCore::BackForwardList::clearWmlPageHistory):
  53553. * history/BackForwardList.h:
  53554. * loader/FrameLoader.cpp: Add WML specific 'shouldReload' logic.
  53555. (WebCore::FrameLoader::FrameLoader):
  53556. (WebCore::FrameLoader::setForceReloadWmlDeck):
  53557. (WebCore::FrameLoader::shouldReload):
  53558. (WebCore::FrameLoader::loadItem):
  53559. * loader/FrameLoader.h:
  53560. * loader/MainResourceLoader.cpp: Add WBXML support (only enabled on Linux/Qt at the moment)
  53561. (WebCore::MainResourceLoader::addData):
  53562. * page/Frame.cpp: Initialize WMLNames.
  53563. (WebCore::Frame::Frame):
  53564. * page/Page.cpp: Maintain WMLPageState object per Page.
  53565. (WebCore::Page::Page):
  53566. (WebCore::Page::setWMLPageState):
  53567. (WebCore::Page::wmlPageState):
  53568. * page/Page.h:
  53569. * platform/MIMETypeRegistry.cpp: Recognize WML extensions.
  53570. (WebCore::initializeSupportedNonImageMimeTypes):
  53571. * platform/gtk/MIMETypeRegistryGtk.cpp: Ditto.
  53572. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  53573. * platform/qt/MIMETypeRegistryQt.cpp: Ditto.
  53574. (WebCore::):
  53575. * platform/win/MIMETypeRegistryWin.cpp: Ditto.
  53576. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  53577. * manual-tests/wml: Added.
  53578. * manual-tests/wml/a-br-element.wml: Added.
  53579. * manual-tests/wml/a-element.wml: Added.
  53580. * manual-tests/wml/a-img-element.wml: Added.
  53581. * manual-tests/wml/access-target.wml: Added.
  53582. * manual-tests/wml/anchor-br-element.wml: Added.
  53583. * manual-tests/wml/anchor-element.wml: Added.
  53584. * manual-tests/wml/anchor-img-element.wml: Added.
  53585. * manual-tests/wml/card-newcontext-attr.wml: Added.
  53586. * manual-tests/wml/card-onenterbackward.wml: Added.
  53587. * manual-tests/wml/card-onenterforward.wml: Added.
  53588. * manual-tests/wml/card-ontimer.wml: Added.
  53589. * manual-tests/wml/deck-access-control.wml: Added.
  53590. * manual-tests/wml/go-element.wml: Added.
  53591. * manual-tests/wml/input-emptyok.wml: Added.
  53592. * manual-tests/wml/input-format.wml: Added.
  53593. * manual-tests/wml/onevent-go.wml: Added.
  53594. * manual-tests/wml/onevent-noop.wml: Added.
  53595. * manual-tests/wml/onevent-prev.wml: Added.
  53596. * manual-tests/wml/onevent-refresh.wml: Added.
  53597. * manual-tests/wml/onevent-shadow.wml: Added.
  53598. * manual-tests/wml/postfield-get.wml: Added.
  53599. * manual-tests/wml/postfield-post.wml: Added.
  53600. * manual-tests/wml/select-element.wml: Added.
  53601. * manual-tests/wml/select-onpick-event.wml: Added.
  53602. * manual-tests/wml/setvar-element.wml: Added.
  53603. * manual-tests/wml/targetdeck.wml: Added.
  53604. * manual-tests/wml/task-go-in-anchor.wml: Added.
  53605. * manual-tests/wml/task-noop-in-do.wml: Added.
  53606. * manual-tests/wml/task-noop-in-onevent.wml: Added.
  53607. * manual-tests/wml/task-prev-in-anchor.wml: Added.
  53608. * manual-tests/wml/task-refresh-in-anchor.wml: Added.
  53609. * manual-tests/wml/template-go.wml: Added.
  53610. * manual-tests/wml/template-onevent.wml: Added.
  53611. * manual-tests/wml/template-ontimer.wml: Added.
  53612. * manual-tests/wml/timer.wml: Added.
  53613. * manual-tests/wml/variable-substitution.wml: Added.
  53614. * wml: Added.
  53615. * wml/WMLAElement.cpp: Added.
  53616. (WebCore::WMLAElement::WMLAElement):
  53617. (WebCore::WMLAElement::parseMappedAttribute):
  53618. (WebCore::WMLAElement::supportsFocus):
  53619. (WebCore::WMLAElement::isFocusable):
  53620. (WebCore::WMLAElement::isMouseFocusable):
  53621. (WebCore::WMLAElement::isKeyboardFocusable):
  53622. (WebCore::WMLAElement::defaultEventHandler):
  53623. (WebCore::WMLAElement::accessKeyAction):
  53624. (WebCore::WMLAElement::isURLAttribute):
  53625. (WebCore::WMLAElement::target):
  53626. * wml/WMLAElement.h: Added.
  53627. * wml/WMLAttributeNames.in: Added.
  53628. * wml/WMLCardElement.cpp: Added.
  53629. (WebCore::WMLCardElement::WMLCardElement):
  53630. * wml/WMLCardElement.h: Added.
  53631. * wml/WMLDocument.cpp: Added.
  53632. (WebCore::WMLDocument::WMLDocument):
  53633. (WebCore::WMLDocument::~WMLDocument):
  53634. * wml/WMLDocument.h: Added.
  53635. (WebCore::WMLDocument::create):
  53636. (WebCore::WMLDocument::isWMLDocument):
  53637. * wml/WMLElement.cpp: Added.
  53638. (WebCore::WMLElement::WMLElement):
  53639. (WebCore::WMLElement::mapToEntry):
  53640. (WebCore::WMLElement::parseMappedAttribute):
  53641. (WebCore::WMLElement::rendererIsNeeded):
  53642. (WebCore::WMLElement::createRenderer):
  53643. * wml/WMLElement.h: Added.
  53644. (WebCore::WMLElement::isWMLElement):
  53645. * wml/WMLPElement.cpp: Added.
  53646. (WebCore::WMLPElement::WMLPElement):
  53647. (WebCore::WMLPElement::mapToEntry):
  53648. (WebCore::WMLPElement::parseMappedAttribute):
  53649. * wml/WMLPElement.h: Added.
  53650. * wml/WMLPageState.cpp: Added.
  53651. (WebCore::WMLPageState::WMLPageState):
  53652. (WebCore::WMLPageState::~WMLPageState):
  53653. (WebCore::WMLPageState::reset):
  53654. (WebCore::WMLPageState::setNeedCheckDeckAccess):
  53655. (WebCore::WMLPageState::isDeckAccessible):
  53656. * wml/WMLPageState.h: Added.
  53657. (WebCore::WMLPageState::storeVariable):
  53658. (WebCore::WMLPageState::storeVariables):
  53659. (WebCore::WMLPageState::getVaribale):
  53660. (WebCore::WMLPageState::hasVariables):
  53661. (WebCore::WMLPageState::historyLength):
  53662. (WebCore::WMLPageState::setHistoryLength):
  53663. (WebCore::WMLPageState::page):
  53664. (WebCore::WMLPageState::activeCard):
  53665. (WebCore::WMLPageState::setActiveCard):
  53666. (WebCore::WMLPageState::setDeckAccessDomain):
  53667. (WebCore::WMLPageState::setDeckAccessPath):
  53668. (WebCore::WMLPageState::hasDeckAccess):
  53669. * wml/WMLTagNames.in: Added.
  53670. 2008-11-17 Geoffrey Garen <ggaren@apple.com>
  53671. Reviewed by Sam Weinig.
  53672. Updated for JavaScriptCore renames.
  53673. * WebCore.pro:
  53674. * webcore-base.bkl:
  53675. 2008-11-17 Justin Garcia <justin.garcia@apple.com>
  53676. Reviewed by Beth Dakin.
  53677. <rdar://problem/4922709> Copying less than a paragraph of quoted text and pasting it doesn't retain quote level
  53678. There was code to intentionally avoid quoting pasted content if less than a paragraph of
  53679. it was copied. That was added for <rdar://problem/5006779>, but was unnecessary because
  53680. that bug was about Paste and Match style for single paragraphs. And quote stripping for
  53681. Paste and Match style is handled elsewhere.
  53682. * editing/markup.cpp:
  53683. (WebCore::createMarkup):
  53684. 2008-11-17 Geoffrey Garen <ggaren@apple.com>
  53685. Reviewed by Sam Weinig.
  53686. Updated for JavaScriptCore rename.
  53687. * ForwardingHeaders/interpreter/CallFrame.h: Copied from WebCore/ForwardingHeaders/runtime/ExecState.h.
  53688. * ForwardingHeaders/runtime/ExecState.h: Removed.
  53689. * bindings/objc/WebScriptObject.mm:
  53690. * bridge/c/c_instance.cpp:
  53691. * bridge/jni/jni_jsobject.mm:
  53692. * dom/Node.cpp:
  53693. * dom/NodeFilter.cpp:
  53694. * dom/NodeIterator.cpp:
  53695. * dom/TreeWalker.cpp:
  53696. * inspector/JavaScriptCallFrame.h:
  53697. 2008-11-17 Pierre-Olivier Latour <pol@apple.com>
  53698. Reviewed by Sam Weinig.
  53699. Added functionality to AnimationController to allow pausing a running
  53700. animation or transition at a given time for testing purposes.
  53701. https://bugs.webkit.org/show_bug.cgi?id=21261
  53702. Tests: animations/animation-drt-api.html
  53703. transitions/transition-drt-api.html
  53704. * WebCore.base.exp:
  53705. * WebCore.xcodeproj/project.pbxproj:
  53706. * page/animation/AnimationBase.cpp:
  53707. (WebCore::AnimationBase::updateStateMachine):
  53708. (WebCore::AnimationBase::progress):
  53709. (WebCore::AnimationBase::pauseAtTime):
  53710. * page/animation/AnimationBase.h:
  53711. * page/animation/AnimationController.cpp:
  53712. (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
  53713. (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  53714. (WebCore::AnimationController::pauseAnimationAtTime):
  53715. (WebCore::AnimationController::pauseTransitionAtTime):
  53716. * page/animation/AnimationController.h:
  53717. * page/animation/CompositeAnimation.cpp:
  53718. (WebCore::CompositeAnimationPrivate::isAnimating):
  53719. (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime):
  53720. (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
  53721. (WebCore::CompositeAnimation::pauseAnimationAtTime):
  53722. (WebCore::CompositeAnimation::pauseTransitionAtTime):
  53723. * page/animation/CompositeAnimation.h:
  53724. * page/animation/ImplicitAnimation.cpp:
  53725. (WebCore::ImplicitAnimation::animate):
  53726. 2008-11-17 Geoffrey Garen <ggaren@apple.com>
  53727. Reviewed by Sam Weinig.
  53728. Updated for JavaScriptCore renames.
  53729. * ForwardingHeaders/VM: Removed.
  53730. * ForwardingHeaders/VM/Machine.h: Removed.
  53731. * ForwardingHeaders/interpreter: Added.
  53732. * ForwardingHeaders/interpreter/Interpreter.h: Copied from ForwardingHeaders/VM/Machine.h.
  53733. * WebCore.pro:
  53734. * bindings/js/JSXMLHttpRequestCustom.cpp:
  53735. * page/Console.cpp:
  53736. * webcore-base.bkl:
  53737. 2008-11-17 Geoffrey Garen <ggaren@apple.com>
  53738. Reviewed by Sam Weinig.
  53739. Updated for JavaScriptCore renames.
  53740. * ForwardingHeaders/runtime/Interpreter.h: Removed.
  53741. * WebCore.vcproj/WebCore.vcproj:
  53742. * bindings/js/JSDOMBinding.h:
  53743. * bindings/js/WorkerScriptController.cpp:
  53744. * bindings/objc/WebScriptObject.mm:
  53745. * bridge/NP_jsobject.cpp:
  53746. * bridge/jni/jni_jsobject.mm:
  53747. * html/CanvasRenderingContext2D.cpp:
  53748. * inspector/JavaScriptCallFrame.cpp:
  53749. * page/Console.cpp:
  53750. 2008-11-17 Geoffrey Garen <ggaren@apple.com>
  53751. Not reviewed.
  53752. Try to fix wx build.
  53753. * webcore-base.bkl:
  53754. 2008-11-17 Greg Bolsinga <bolsinga@apple.com>
  53755. Reviewed by Darin Adler.
  53756. https://bugs.webkit.org/show_bug.cgi?id=21810
  53757. Remove use of static C++ objects that are destroyed at exit time (destructors)
  53758. Find some missing DEFINE_STATIC_LOCAL use cases.
  53759. * bindings/js/JSSVGPODTypeWrapper.h:
  53760. (WebCore::PODTypeWrapperCacheInfoTraits::emptyValue):
  53761. (WebCore::JSSVGDynamicPODTypeWrapperCache::dynamicWrapperHashMap):
  53762. * dom/make_names.pl: Generate code to use DEFINE_STATIC_LOCAL.
  53763. * page/AccessibilityRenderObject.cpp:
  53764. (WebCore::RoleEntry::): This method is only called once, so the array does not have to be static.
  53765. * platform/graphics/FontCache.cpp:
  53766. (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
  53767. (WebCore::FontDataCacheKeyTraits::emptyValue):
  53768. * rendering/style/RenderStyle.h:
  53769. (WebCore::InheritedFlags::initialTransform):
  53770. 2008-11-17 Geoffrey Garen <ggaren@apple.com>
  53771. Not reviewed.
  53772. Try to fix Qt build.
  53773. * WebCore.pro:
  53774. 2008-11-16 Simon Fraser <simon.fraser@apple.com>
  53775. Reviewed by Dan Bernstein
  53776. https://bugs.webkit.org/show_bug.cgi?id=22118
  53777. Fix resize corner tracking in transformed elements by using
  53778. mapping the point into local coords using absoluteToLocal,
  53779. rather than convertToLayerCoords.
  53780. Test: fast/css/resize-corner-tracking-transformed.html
  53781. * page/EventHandler.h:
  53782. * rendering/RenderLayer.cpp:
  53783. (WebCore::RenderLayer::absoluteToContents):
  53784. (WebCore::RenderLayer::offsetFromResizeCorner):
  53785. (WebCore::RenderLayer::isPointInResizeControl):
  53786. * rendering/RenderLayer.h:
  53787. 2008-11-16 Geoffrey Garen <ggaren@apple.com>
  53788. Not reviewed.
  53789. Try to fix Qt build.
  53790. * WebCore.pro:
  53791. 2008-11-16 Greg Bolsinga <bolsinga@apple.com>
  53792. Reviewed by Geoffrey Garen.
  53793. Use RefPtr and PassRefPtr where appropriate.
  53794. * loader/FTPDirectoryDocument.cpp:
  53795. (WebCore::createTemplateDocumentData):
  53796. 2008-11-16 Greg Bolsinga <bolsinga@apple.com>
  53797. Fix build break for real.
  53798. * loader/FTPDirectoryDocument.cpp:
  53799. (WebCore::createTemplateDocumentData):
  53800. 2008-11-16 Greg Bolsinga <bolsinga@apple.com>
  53801. Fix build break and bug.
  53802. * loader/FTPDirectoryDocument.cpp:
  53803. (WebCore::createTemplateDocumentData):
  53804. 2008-11-16 Greg Bolsinga <bolsinga@apple.com>
  53805. Reviewed by Darin Adler.
  53806. https://bugs.webkit.org/show_bug.cgi?id=21810
  53807. Remove use of static C++ objects that are destroyed at exit time (destructors)
  53808. Use DEFINE_STATIC_LOCAL for static RetainPtr<T>, RefPtr<T>. Add additional
  53809. uses of DEFINE_STATIC_LOCAL where appropriate.
  53810. * html/HTMLTableElement.cpp:
  53811. (WebCore::HTMLTableElement::addSharedCellBordersDecl): new the AtomicStrings
  53812. * loader/CachedImage.cpp:
  53813. (WebCore::brokenImage):
  53814. (WebCore::nullImage):
  53815. * loader/FTPDirectoryDocument.cpp:
  53816. (WebCore::_createTemplateDocumentData): Created so accessor has one line initialization
  53817. (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
  53818. * loader/icon/IconDatabase.cpp:
  53819. (WebCore::loadDefaultIconRecord):
  53820. * page/AccessibilityObject.cpp:
  53821. (WebCore::AccessibilityObject::actionVerb):
  53822. * page/AccessibilityRenderObject.cpp:
  53823. (WebCore::AccessibilityRenderObject::actionVerb):
  53824. * page/mac/EventHandlerMac.mm:
  53825. (WebCore::currentEvent):
  53826. * platform/ScrollView.cpp:
  53827. (WebCore::ScrollView::paint):
  53828. * platform/graphics/Image.cpp:
  53829. (WebCore::Image::nullImage):
  53830. * platform/graphics/mac/ColorMac.mm:
  53831. (WebCore::nsColor):
  53832. * platform/graphics/mac/FontCacheMac.mm: new the Strings
  53833. (WebCore::FontCache::getSimilarFontPlatformData):
  53834. * platform/graphics/mac/GraphicsContextMac.mm:
  53835. (WebCore::_createPatternColor): Created so accessor has one line initialization
  53836. (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  53837. * platform/graphics/mac/SimpleFontDataMac.mm:
  53838. (WebCore::webFallbackFontFamily):
  53839. * platform/mac/PasteboardMac.mm:
  53840. (WebCore::writableTypesForURL):
  53841. (WebCore::createWritableTypesForImage): Created so accessor has one line initialization
  53842. (WebCore::writableTypesForImage):
  53843. (WebCore::stripAttachmentCharacters):
  53844. * rendering/RenderLayer.cpp:
  53845. (WebCore::RenderLayer::paintResizer):
  53846. 2008-11-16 Holger Hans Peter Freyther <zecke@selfish.org>
  53847. Reviewed by Darin Adler.
  53848. Do not spit Curl errors into the stdout as this is used by DRT
  53849. We have failing tests results due the curl errors printed to stdout,
  53850. move them to stderr to be able to pass those tests.
  53851. * platform/network/curl/ResourceHandleManager.cpp:
  53852. (WebCore::ResourceHandleManager::startJob):
  53853. 2008-11-16 Holger Hans Peter Freyther <zecke@selfish.org>
  53854. - fix the Gtk+ build
  53855. * GNUmakefile.am:
  53856. 2008-11-16 Darin Adler <darin@apple.com>
  53857. - try to fix Qt build
  53858. * WebCore.pro: Add the worker-related source files.
  53859. 2008-11-16 Darin Adler <darin@apple.com>
  53860. Suggested by Alexey Proskuryakov.
  53861. - fix the GTK build another way
  53862. * GNUmakefile.am: Add the worker-related source files.
  53863. * bindings/js/JSEventTarget.cpp: Take the #if back out.
  53864. 2008-11-16 Darin Adler <darin@apple.com>
  53865. - try to fix GTK build
  53866. * bindings/js/JSEventTarget.cpp: Put worker includes inside an #if.
  53867. 2008-11-16 Darin Adler <darin@apple.com>
  53868. Reviewed by Dan Bernstein.
  53869. - https://bugs.webkit.org/show_bug.cgi?id=22295
  53870. track which history items are from page load failures
  53871. * history/HistoryItem.cpp: Sort includes, add newly needed ones, and remove
  53872. no-longer-needed ones.
  53873. (WebCore::HistoryItem::HistoryItem): Initialize m_lastVisitWasFailure to false.
  53874. (WebCore::HistoryItem::showTreeWithIndent): Rewrote to avoid appending to a
  53875. String, since that's not efficient.
  53876. * history/HistoryItem.h: Removed unneeded includes. Added lastVisitWasFailure,
  53877. setLastVisitWasFailure, and m_lastVisitWasFailure.
  53878. * history/mac/HistoryItemMac.mm: Add newly-needed include
  53879. (WebCore::HistoryItem::setTransientProperty): Rewrote to avoid keeping a
  53880. m_transientProperties map around when it is empty.
  53881. * loader/FrameLoader.cpp:
  53882. (WebCore::FrameLoader::createHistoryItem): Call setLastVisitWasFailure when
  53883. the page was unreachable or an HTTP page with a status code that indicates
  53884. failure.
  53885. 2008-11-16 Yong Li <yong.li@torchmobile.com>
  53886. Reviewed by Timothy Hatcher.
  53887. Landed by George Staikos.
  53888. Optimization: don't relayout, repaint, or emit a DOM event if the
  53889. scroll event didn't scroll anywhere.
  53890. * rendering/RenderLayer.cpp:
  53891. (WebCore::RenderLayer::scrollToOffset): add early exit
  53892. 2008-11-16 Alexey Proskuryakov <ap@webkit.org>
  53893. Reviewed by Dan Bernstein.
  53894. https://bugs.webkit.org/show_bug.cgi?id=22290
  53895. Remove cross-heap GC and MessagePort multi-threading support
  53896. It is broken (and may not be implementable at all), and no longer needed, as we
  53897. don't use MessagePorts for communication with workers any more.
  53898. * bindings/js/JSDOMBinding.cpp:
  53899. * bindings/js/JSDOMBinding.h:
  53900. * bindings/js/JSDOMWindowBase.cpp:
  53901. * bindings/js/JSDOMWindowBase.h:
  53902. Removed cross-heap GC implementation.
  53903. * dom/MessagePort.cpp:
  53904. (WebCore::MessagePort::hasPendingActivity):
  53905. * dom/MessagePort.h:
  53906. Made objects RefCounted instead of ThreadSafeShared, added FIXME comments for code that is
  53907. unnecessarily complicated for single threaded case.
  53908. 2008-11-14 Alexey Proskuryakov <ap@webkit.org>
  53909. Reviewed by Maciej Stachowiak.
  53910. https://bugs.webkit.org/show_bug.cgi?id=22266
  53911. Stop using MessagePort for communication with workers
  53912. The current MessagePort specification is not well suited for being implemented in a
  53913. multi-threaded or multi-process environment, and this doesn't appear to be easily fixable.
  53914. This patch implements a simpler Mozilla API for workers instead.
  53915. * WebCore.xcodeproj/project.pbxproj:
  53916. * DerivedSources.make:
  53917. * bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseWorker):
  53918. * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed.
  53919. * bindings/js/JSDedicatedWorkerConstructor.h: Removed.
  53920. * bindings/js/JSDedicatedWorkerCustom.cpp: Removed.
  53921. * bindings/js/JSWorkerConstructor.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.cpp.
  53922. * bindings/js/JSWorkerConstructor.h: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.h.
  53923. * bindings/js/JSWorkerCustom.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerCustom.cpp.
  53924. * dom/DedicatedWorker.cpp: Removed.
  53925. * dom/DedicatedWorker.h: Removed.
  53926. * dom/DedicatedWorker.idl: Removed.
  53927. Renamed DedicatedWorker to Worker to match Mozilla and current WHATWG cpec.
  53928. * bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
  53929. Clear worker exceptions to avoid hitting an assertion.
  53930. * dom/EventTarget.cpp: (WebCore::EventTarget::toWorker):
  53931. * dom/EventTarget.h:
  53932. * bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  53933. WorkerContext is now an EventTarget, too.
  53934. * bindings/js/JSWorkerContext.cpp: Removed onconnect, constructors for MessageChannel and
  53935. MessagePort. Added postMessage() and onmessage.
  53936. * dom/ScriptExecutionContext.cpp: (WebCore::performTask): Do not reference ScriptExecutionContext
  53937. when posting a task - this operation is not thread safe. It is also not necessary any more,
  53938. as the context is kept alive by WorkerMessagingProxy.
  53939. * dom/Worker.cpp: Copied from WebCore/dom/DedicatedWorker.cpp.
  53940. (WebCore::Worker::Worker): Start loading the script right away - there is no reason to do
  53941. that on a timer.
  53942. (WebCore::Worker::~Worker): Notify messaging proxy.
  53943. (WebCore::Worker::postMessage): Just ask the proxy to post the message.
  53944. (WebCore::Worker::notifyFinished): Notify messaging proxy when a thread object becomes
  53945. available. Also, it is now safe to unsetPendingActivity(), making the object collectable.
  53946. I'm not sure if this is the right lifetime for workers, as unreachable workers with event
  53947. listeners should probably be kept alive, but it at least lets the object be collected.
  53948. (WebCore::Worker::addEventListener): Added an EventTarget implementation.
  53949. (WebCore::Worker::removeEventListener): Added an EventTarget implementation.
  53950. (WebCore::Worker::dispatchEvent): Added an EventTarget implementation.
  53951. * dom/Worker.h: Copied from WebCore/dom/DedicatedWorker.h.
  53952. * dom/Worker.idl: Copied from WebCore/dom/DedicatedWorker.idl.
  53953. Removed onclose, made an EventListener. Actual messaging is now handled by WorkerMessagingProxy.
  53954. * dom/WorkerContext.cpp:
  53955. (WebCore::WorkerContext::~WorkerContext): Notify messaging proxy that the context was shut
  53956. down successfully.
  53957. (WebCore::WorkerContext::postMessage): Added. Post the message via messaging proxy.
  53958. * dom/WorkerContext.h: Added postMessage and onmessage, removed onconnect.
  53959. * dom/WorkerMessagingProxy.cpp: Added.
  53960. * dom/WorkerMessagingProxy.h: Added.
  53961. This new class implements actual messaging. It is notified when a Worker is garbage collected,
  53962. and asks the thread to shut down. It also owns the thread object, and references script
  53963. execution context, making it safe to post messages to it remotely.
  53964. * dom/WorkerThread.cpp:
  53965. * dom/WorkerThread.h:
  53966. Keep a reference to messaging proxy, not to Worker itself. Also, the thread object no longer
  53967. keeps itself alive - it is now the job of messaging proxy.
  53968. 2008-11-15 Darin Adler <darin@apple.com>
  53969. Rubber stamped by Geoff Garen.
  53970. - do the long-planned StructureID -> Structure rename
  53971. * ForwardingHeaders/runtime/Structure.h: Copied from WebCore/ForwardingHeaders/runtime/StructureID.h.
  53972. * ForwardingHeaders/runtime/StructureID.h: Removed.
  53973. * bindings/js/JSAudioConstructor.cpp:
  53974. (WebCore::JSAudioConstructor::JSAudioConstructor):
  53975. * bindings/js/JSDOMBinding.cpp:
  53976. (WebCore::getCachedDOMStructure):
  53977. (WebCore::cacheDOMStructure):
  53978. * bindings/js/JSDOMBinding.h:
  53979. (WebCore::DOMObject::DOMObject):
  53980. (WebCore::getDOMStructure):
  53981. * bindings/js/JSDOMGlobalObject.cpp:
  53982. (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
  53983. * bindings/js/JSDOMGlobalObject.h:
  53984. * bindings/js/JSDOMWindowBase.cpp:
  53985. (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  53986. * bindings/js/JSDOMWindowBase.h:
  53987. * bindings/js/JSDOMWindowShell.cpp:
  53988. (WebCore::JSDOMWindowShell::JSDOMWindowShell):
  53989. (WebCore::JSDOMWindowShell::setWindow):
  53990. * bindings/js/JSDOMWindowShell.h:
  53991. (WebCore::JSDOMWindowShell::createStructure):
  53992. * bindings/js/JSDedicatedWorkerConstructor.cpp:
  53993. (WebCore::JSDedicatedWorkerConstructor::JSDedicatedWorkerConstructor):
  53994. * bindings/js/JSHTMLAllCollection.h:
  53995. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
  53996. (WebCore::JSHTMLAllCollection::createStructure):
  53997. * bindings/js/JSImageConstructor.cpp:
  53998. (WebCore::JSImageConstructor::JSImageConstructor):
  53999. * bindings/js/JSInspectedObjectWrapper.cpp:
  54000. (WebCore::JSInspectedObjectWrapper::wrap):
  54001. (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
  54002. * bindings/js/JSInspectedObjectWrapper.h:
  54003. * bindings/js/JSInspectorCallbackWrapper.cpp:
  54004. (WebCore::leakInspectorCallbackWrapperStructure):
  54005. (WebCore::JSInspectorCallbackWrapper::wrap):
  54006. (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
  54007. * bindings/js/JSInspectorCallbackWrapper.h:
  54008. * bindings/js/JSMessageChannelConstructor.cpp:
  54009. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  54010. * bindings/js/JSNamedNodesCollection.h:
  54011. (WebCore::JSNamedNodesCollection::createStructure):
  54012. * bindings/js/JSOptionConstructor.cpp:
  54013. (WebCore::JSOptionConstructor::JSOptionConstructor):
  54014. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  54015. (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
  54016. * bindings/js/JSQuarantinedObjectWrapper.h:
  54017. (WebCore::JSQuarantinedObjectWrapper::createStructure):
  54018. * bindings/js/JSRGBColor.h:
  54019. (WebCore::JSRGBColor::createStructure):
  54020. * bindings/js/JSWorkerContext.cpp:
  54021. (WebCore::createJSWorkerContextStructure):
  54022. (WebCore::JSWorkerContext::JSWorkerContext):
  54023. (WebCore::JSWorkerContext::createPrototype):
  54024. * bindings/js/JSWorkerContext.h:
  54025. (WebCore::JSWorkerContext::createStructure):
  54026. (WebCore::JSWorkerContextPrototype::JSWorkerContextPrototype):
  54027. (WebCore::JSWorkerContextPrototype::createStructure):
  54028. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  54029. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  54030. * bindings/js/JSXSLTProcessorConstructor.cpp:
  54031. (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  54032. * bindings/scripts/CodeGeneratorJS.pm:
  54033. * bridge/objc/objc_runtime.h:
  54034. (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  54035. * bridge/qt/qt_runtime.cpp:
  54036. (JSC::Bindings::QtConnectionObject::execute):
  54037. * bridge/qt/qt_runtime.h:
  54038. (JSC::Bindings::QtRuntimeMethod::createStructure):
  54039. * bridge/runtime_array.h:
  54040. (JSC::RuntimeArray::createStructure):
  54041. * bridge/runtime_method.h:
  54042. (JSC::RuntimeMethod::createStructure):
  54043. * bridge/runtime_object.cpp:
  54044. (JSC::RuntimeObjectImp::RuntimeObjectImp):
  54045. * bridge/runtime_object.h:
  54046. (JSC::RuntimeObjectImp::createStructure):
  54047. 2008-11-15 Darin Adler <darin@apple.com>
  54048. Reviewed by Dan Bernstein.
  54049. - fix just-introduced crash in the svg/custom/svg-fonts-in-html.html test
  54050. This gets rid of the crash. It restores the behavior of the CG case from before Dirk
  54051. Shulze removed the platorm-dependent code, but perhaps it should be changed further
  54052. in the future so that the default for no style is "no stroke". I think the patch is
  54053. fine for fill.
  54054. * svg/graphics/SVGPaintServerSolid.cpp:
  54055. (WebCore::SVGPaintServerSolid::setup): Added null checks for svgStyle.
  54056. (WebCore::SVGPaintServerSolid::renderPath): Added null checks for style and svgStyle.
  54057. 2008-11-15 Kevin Ollivier <kevino@theolliviers.com>
  54058. Reviewed by Timothy Hatcher.
  54059. Initialize m_networkStateChangedFunction to 0 as otherwise the check for null will fail.
  54060. https://bugs.webkit.org/show_bug.cgi?id=22284
  54061. * platform/network/NetworkStateNotifier.h:
  54062. (WebCore::NetworkStateNotifier::NetworkStateNotifier):
  54063. 2008-11-15 Dirk Schulze <krit@webkit.org>
  54064. Reviewed by Geoffrey Garen.
  54065. r38426 caused a wrong drawing of a LayoutTest. Use another
  54066. way to set the color to pass this test again.
  54067. * svg/graphics/SVGPaintServerSolid.cpp:
  54068. (WebCore::SVGPaintServerSolid::setup):
  54069. 2008-11-15 Dirk Schulze <krit@webkit.org>
  54070. Reviewed by Darin Adler.
  54071. Removed platform dependent code on SVGPaintServerSolid.
  54072. * GNUmakefile.am:
  54073. * WebCore.pro:
  54074. * WebCore.vcproj/WebCore.vcproj:
  54075. * WebCore.xcodeproj/project.pbxproj:
  54076. * svg/graphics/SVGPaintServerSolid.cpp:
  54077. (WebCore::SVGPaintServerSolid::setup):
  54078. (WebCore::SVGPaintServerSolid::renderPath):
  54079. * svg/graphics/SVGPaintServerSolid.h:
  54080. * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp: Removed.
  54081. * svg/graphics/cg/SVGPaintServerSolidCg.cpp: Removed.
  54082. * svg/graphics/qt/SVGPaintServerSolidQt.cpp: Removed.
  54083. 2008-11-15 Geoffrey Garen <ggaren@apple.com>
  54084. Reviewed by Sam Weinig.
  54085. Updated for JavaScriptCore renames.
  54086. * bindings/js/JSNodeCustom.cpp:
  54087. (WebCore::JSNode::mark):
  54088. * bindings/js/JSXMLHttpRequestCustom.cpp:
  54089. (WebCore::JSXMLHttpRequest::send):
  54090. * bindings/js/ScriptController.cpp:
  54091. (WebCore::ScriptController::evaluate):
  54092. * bindings/js/WorkerScriptController.cpp:
  54093. (WebCore::WorkerScriptController::evaluate):
  54094. * bindings/objc/WebScriptObject.mm:
  54095. (-[WebScriptObject evaluateWebScript:]):
  54096. * bridge/NP_jsobject.cpp:
  54097. (_NPN_Evaluate):
  54098. * bridge/jni/jni_jsobject.mm:
  54099. (JavaJSObject::eval):
  54100. * page/Console.cpp:
  54101. (WebCore::retrieveLastCaller):
  54102. (WebCore::Console::trace):
  54103. 2008-11-14 Greg Bolsinga <bolsinga@apple.com>
  54104. Reviewed by Darin Adler.
  54105. https://bugs.webkit.org/show_bug.cgi?id=21810
  54106. Remove use of static C++ objects that are destroyed at exit time (destructors)
  54107. Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
  54108. exit-time destructor. Update code that was changed to fix this issue that ran
  54109. into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
  54110. in gcc build 5465). Also typdefs for template types needed to be added in some
  54111. cases so the type could make it through the macro successfully.
  54112. Basically code of the form:
  54113. static T m;
  54114. becomes:
  54115. DEFINE_STATIC_LOCAL(T, m, ());
  54116. Also any code of the form:
  54117. static T& m = *new T;
  54118. also becomes:
  54119. DEFINE_STATIC_LOCAL(T, m, ());
  54120. * ForwardingHeaders/wtf/StdLibExtras.h: Added.
  54121. * bindings/js/GCController.cpp:
  54122. (WebCore::gcController):
  54123. * bindings/js/JSDOMBinding.cpp:
  54124. (WebCore::wrapperSet):
  54125. * bindings/js/JSInspectedObjectWrapper.cpp:
  54126. (WebCore::wrappers):
  54127. * bindings/js/JSInspectorCallbackWrapper.cpp:
  54128. (WebCore::wrappers):
  54129. * bindings/js/JSNavigatorCustom.cpp:
  54130. (WebCore::needsYouTubeQuirk):
  54131. * bridge/runtime_root.cpp:
  54132. (JSC::Bindings::rootObjectSet):
  54133. * css/CSSMutableStyleDeclaration.cpp:
  54134. (WebCore::initShorthandMap):
  54135. (WebCore::CSSMutableStyleDeclaration::removeProperty):
  54136. * css/CSSPrimitiveValue.cpp:
  54137. (WebCore::CSSPrimitiveValue::cssText):
  54138. * css/CSSSelector.cpp:
  54139. (WebCore::CSSSelector::extractPseudoType):
  54140. * css/CSSStyleSelector.cpp:
  54141. (WebCore::screenEval):
  54142. (WebCore::printEval):
  54143. * dom/DOMImplementation.cpp:
  54144. (WebCore::addString):
  54145. (WebCore::isSVG10Feature):
  54146. (WebCore::isSVG11Feature):
  54147. (WebCore::DOMImplementation::isXMLMIMEType):
  54148. * dom/Document.cpp:
  54149. (WebCore::Document::hasPrefixNamespaceMismatch):
  54150. * dom/ScriptElement.cpp:
  54151. (WebCore::isSupportedJavaScriptLanguage):
  54152. * editing/ApplyStyleCommand.cpp:
  54153. (WebCore::styleSpanClassString):
  54154. * editing/HTMLInterchange.cpp:
  54155. (WebCore::):
  54156. * editing/IndentOutdentCommand.cpp:
  54157. (WebCore::indentBlockquoteString):
  54158. * editing/ReplaceSelectionCommand.cpp:
  54159. (WebCore::isInterchangeNewlineNode):
  54160. (WebCore::isInterchangeConvertedSpaceSpan):
  54161. * editing/htmlediting.cpp:
  54162. (WebCore::stringWithRebalancedWhitespace):
  54163. (WebCore::nonBreakingSpaceString):
  54164. * editing/markup.cpp:
  54165. (WebCore::appendAttributeValue):
  54166. (WebCore::appendEscapedContent):
  54167. (WebCore::shouldAddNamespaceAttr):
  54168. (WebCore::appendNamespace):
  54169. (WebCore::appendStartMarkup):
  54170. (WebCore::createMarkup):
  54171. * html/HTMLButtonElement.cpp:
  54172. (WebCore::HTMLButtonElement::type):
  54173. * html/HTMLElement.cpp:
  54174. (WebCore::HTMLElement::isRecognizedTagName):
  54175. (WebCore::inlineTagList):
  54176. (WebCore::blockTagList):
  54177. * html/HTMLFieldSetElement.cpp:
  54178. (WebCore::HTMLFieldSetElement::type):
  54179. * html/HTMLInputElement.cpp:
  54180. (WebCore::HTMLInputElement::type):
  54181. * html/HTMLKeygenElement.cpp:
  54182. (WebCore::HTMLKeygenElement::type):
  54183. * html/HTMLLegendElement.cpp:
  54184. (WebCore::HTMLLegendElement::type):
  54185. * html/HTMLOptGroupElement.cpp:
  54186. (WebCore::HTMLOptGroupElement::type):
  54187. * html/HTMLOptionElement.cpp:
  54188. (WebCore::HTMLOptionElement::type):
  54189. * html/HTMLParser.cpp:
  54190. (WebCore::HTMLParser::getNode):
  54191. (WebCore::HTMLParser::isHeaderTag):
  54192. (WebCore::HTMLParser::isResidualStyleTag):
  54193. (WebCore::HTMLParser::isAffectedByResidualStyle):
  54194. * html/HTMLSelectElement.cpp:
  54195. (WebCore::HTMLSelectElement::type):
  54196. * html/HTMLTextAreaElement.cpp:
  54197. (WebCore::HTMLTextAreaElement::type):
  54198. * inspector/InspectorController.cpp:
  54199. (WebCore::platform):
  54200. * inspector/JavaScriptDebugServer.cpp:
  54201. (WebCore::JavaScriptDebugServer::shared):
  54202. * inspector/JavaScriptProfile.cpp:
  54203. (WebCore::profileCache):
  54204. * inspector/JavaScriptProfileNode.cpp:
  54205. (WebCore::profileNodeCache):
  54206. * loader/FrameLoader.cpp:
  54207. (WebCore::localSchemes):
  54208. * loader/appcache/ApplicationCacheStorage.cpp:
  54209. (WebCore::cacheStorage):
  54210. * loader/archive/ArchiveFactory.cpp:
  54211. (WebCore::archiveMIMETypes):
  54212. (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
  54213. * loader/icon/IconDatabase.cpp:
  54214. (WebCore::IconDatabase::defaultDatabaseFilename):
  54215. * page/EventHandler.cpp:
  54216. (WebCore::EventHandler::dragState):
  54217. * page/Frame.cpp:
  54218. (WebCore::createRegExpForLabels):
  54219. (WebCore::keepAliveSet):
  54220. * page/Page.cpp:
  54221. (WebCore::Page::groupName):
  54222. * page/SecurityOrigin.cpp:
  54223. (WebCore::isDefaultPortForProtocol):
  54224. (WebCore::SecurityOrigin::databaseIdentifier):
  54225. * page/mac/FrameMac.mm:
  54226. (WebCore::regExpForLabels):
  54227. * platform/KURL.cpp:
  54228. (WebCore::blankURL):
  54229. * platform/graphics/FontCache.cpp:
  54230. (WebCore::alternateFamilyName):
  54231. * platform/graphics/mac/FontCacheMac.mm:
  54232. (WebCore::FontCache::getSimilarFontPlatformData):
  54233. (WebCore::FontCache::getLastResortFallbackFont):
  54234. * platform/mac/CursorMac.mm:
  54235. (WebCore::leakNamedCursor):
  54236. (WebCore::pointerCursor):
  54237. (WebCore::crossCursor):
  54238. (WebCore::handCursor):
  54239. (WebCore::moveCursor):
  54240. (WebCore::verticalTextCursor):
  54241. (WebCore::cellCursor):
  54242. (WebCore::contextMenuCursor):
  54243. (WebCore::aliasCursor):
  54244. (WebCore::zoomInCursor):
  54245. (WebCore::zoomOutCursor):
  54246. (WebCore::copyCursor):
  54247. (WebCore::noneCursor):
  54248. (WebCore::progressCursor):
  54249. (WebCore::noDropCursor):
  54250. (WebCore::notAllowedCursor):
  54251. (WebCore::iBeamCursor):
  54252. (WebCore::waitCursor):
  54253. (WebCore::helpCursor):
  54254. (WebCore::eastResizeCursor):
  54255. (WebCore::northResizeCursor):
  54256. (WebCore::northEastResizeCursor):
  54257. (WebCore::northWestResizeCursor):
  54258. (WebCore::southResizeCursor):
  54259. (WebCore::southEastResizeCursor):
  54260. (WebCore::southWestResizeCursor):
  54261. (WebCore::westResizeCursor):
  54262. (WebCore::northSouthResizeCursor):
  54263. (WebCore::eastWestResizeCursor):
  54264. (WebCore::northEastSouthWestResizeCursor):
  54265. (WebCore::northWestSouthEastResizeCursor):
  54266. (WebCore::columnResizeCursor):
  54267. (WebCore::rowResizeCursor):
  54268. (WebCore::grabCursor):
  54269. (WebCore::grabbingCursor):
  54270. * platform/mac/ScrollbarThemeMac.mm:
  54271. (WebCore::ScrollbarTheme::nativeTheme):
  54272. * platform/mac/ThemeMac.mm:
  54273. (WebCore::platformTheme):
  54274. * platform/mac/ThreadCheck.mm:
  54275. (WebCoreReportThreadViolation):
  54276. * platform/network/NetworkStateNotifier.cpp:
  54277. (WebCore::networkStateNotifier):
  54278. * platform/network/mac/FormDataStreamMac.mm:
  54279. (WebCore::getStreamFormDataMap):
  54280. (WebCore::getStreamResourceHandleMap):
  54281. * platform/network/mac/ResourceResponseMac.mm:
  54282. (WebCore::ResourceResponse::platformLazyInit):
  54283. * platform/text/TextEncoding.cpp:
  54284. (WebCore::TextEncoding::isJapanese):
  54285. * plugins/PluginMainThreadScheduler.cpp:
  54286. (WebCore::PluginMainThreadScheduler::scheduler):
  54287. * rendering/RenderBlock.cpp:
  54288. (WebCore::continuationOutlineTable):
  54289. (WebCore::RenderBlock::addContinuationWithOutline):
  54290. (WebCore::RenderBlock::paintContinuationOutlines):
  54291. * rendering/RenderCounter.cpp:
  54292. (WebCore::counterMaps):
  54293. * rendering/RenderFlexibleBox.cpp:
  54294. (WebCore::RenderFlexibleBox::layoutVerticalBox):
  54295. * rendering/RenderListItem.cpp:
  54296. (WebCore::RenderListItem::markerText):
  54297. * rendering/RenderScrollbarTheme.cpp:
  54298. (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
  54299. * rendering/RenderThemeMac.mm:
  54300. (WebCore::RenderThemeMac::systemFont):
  54301. * rendering/bidi.cpp:
  54302. (WebCore::RenderBlock::checkLinesForTextOverflow):
  54303. * rendering/style/RenderStyle.cpp:
  54304. (WebCore::RenderStyle::initialDashboardRegions):
  54305. (WebCore::RenderStyle::noneDashboardRegions):
  54306. * storage/Database.cpp:
  54307. (WebCore::guidMutex):
  54308. (WebCore::guidToVersionMap):
  54309. (WebCore::guidToDatabaseMap):
  54310. (WebCore::Database::databaseInfoTableName):
  54311. (WebCore::databaseVersionKey):
  54312. (WebCore::Database::getVersionFromDatabase):
  54313. (WebCore::Database::setVersionInDatabase):
  54314. (WebCore::guidForOriginAndName):
  54315. * storage/DatabaseTracker.cpp:
  54316. (WebCore::DatabaseTracker::tracker):
  54317. (WebCore::notificationMutex):
  54318. (WebCore::notificationQueue):
  54319. * storage/LocalStorage.cpp:
  54320. (WebCore::localStorageMap):
  54321. * svg/SVGAnimateMotionElement.cpp:
  54322. (WebCore::SVGAnimateMotionElement::rotateMode):
  54323. * svg/SVGAnimationElement.cpp:
  54324. (WebCore::SVGAnimationElement::calcMode):
  54325. (WebCore::SVGAnimationElement::attributeType):
  54326. (WebCore::SVGAnimationElement::isAdditive):
  54327. (WebCore::SVGAnimationElement::isAccumulated):
  54328. * svg/SVGLangSpace.cpp:
  54329. (WebCore::SVGLangSpace::xmlspace):
  54330. * svg/SVGSVGElement.cpp:
  54331. (WebCore::SVGSVGElement::contentScriptType):
  54332. (WebCore::SVGSVGElement::contentStyleType):
  54333. * svg/SVGStyleElement.cpp:
  54334. (WebCore::SVGStyleElement::type):
  54335. (WebCore::SVGStyleElement::media):
  54336. * svg/SVGTextContentElement.cpp:
  54337. (WebCore::SVGTextContentElement::parseMappedAttribute):
  54338. * svg/animation/SVGSMILElement.cpp:
  54339. (WebCore::SVGSMILElement::parseClockValue):
  54340. (WebCore::SVGSMILElement::restart):
  54341. (WebCore::SVGSMILElement::fill):
  54342. (WebCore::SVGSMILElement::repeatCount):
  54343. (WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
  54344. * svg/graphics/SVGResource.cpp:
  54345. (WebCore::clientMap):
  54346. (WebCore::SVGResource::removeClient):
  54347. * svg/graphics/SVGResourceMarker.cpp:
  54348. (WebCore::SVGResourceMarker::draw):
  54349. * xml/XMLHttpRequest.cpp:
  54350. (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
  54351. (WebCore::preflightResultCache):
  54352. (WebCore::appendPreflightResultCacheEntry):
  54353. (WebCore::isSafeRequestHeader):
  54354. (WebCore::isOnAccessControlResponseHeaderWhitelist):
  54355. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  54356. * xml/XPathExpressionNode.cpp:
  54357. (WebCore::XPath::Expression::evaluationContext):
  54358. * xml/XPathParser.cpp:
  54359. (WebCore::XPath::setUpAxisNamesMap):
  54360. (WebCore::XPath::isAxisName):
  54361. (WebCore::XPath::isNodeTypeName):
  54362. * xml/XPathValue.cpp:
  54363. (WebCore::XPath::Value::toNodeSet):
  54364. 2008-11-14 Dan Bernstein <mitz@apple.com>
  54365. - attempt to fix the Qt build
  54366. * platform/qt/Localizations.cpp:
  54367. (WebCore::contextMenuItemTagTextDirectionMenu): Added. Maybe this string
  54368. needs to go somewhere else in addition to here.
  54369. 2008-11-14 Kevin Ollivier <kevino@theolliviers.com>
  54370. wx build fix.
  54371. * platform/wx/LocalizedStringsWx.cpp:
  54372. (WebCore::contextMenuItemTagTextDirectionMenu):
  54373. 2008-11-14 Dan Bernstein <mitz@apple.com>
  54374. Reviewed by Darin Adler.
  54375. - <rdar://problem/6234307> Support action methods for setting and clearing character-level directionality
  54376. - WebCore part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
  54377. * WebCore.base.exp: Exported
  54378. WebCore::Settings::setTextDirectionSubmenuInclusionBehavior().
  54379. * editing/ApplyStyleCommand.cpp:
  54380. (StyleChange::init): Changed to always include the direction property
  54381. in the result if the unicode-bidi property is included.
  54382. (ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Added. Finds the
  54383. highest ancestor of the given node that establishes bidi embedding. If
  54384. that embedding agrees with the given allowed direction, finds the
  54385. second-highest embedding ancestor. Splits all nodes through that
  54386. ancestor. If the highest embedding ancestor did not need to be split,
  54387. it is returned.
  54388. (ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Added. Removes
  54389. bidi embedding attributes and styles from all ancestors of the given
  54390. node up to its enclosing block or the given node.
  54391. (ApplyStyleCommand::applyInlineStyle): Added code to handle the
  54392. unicode-bidi property. Applying style the includes this property
  54393. involves removing all bidi embedding in effect, except for one-level
  54394. embedding that agrees with the desired embedding, then applying the
  54395. desired embedding where it is not already in effect.
  54396. (ApplyStyleCommand::applyInlineStyleToRange): Factored out from
  54397. applyInlineStyle().
  54398. (ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added. Removed the
  54399. "dir" attribute if necessary and the element if it becomes an unstyled
  54400. style span.
  54401. (ApplyStyleCommand::removeCSSStyle): Changed to remove the direction
  54402. property when removing the unicode-bidi property.
  54403. (ApplyStyleCommand::removeInlineStyle): Added a call to
  54404. removeHTMLBidiEmbeddingStyle().
  54405. * editing/ApplyStyleCommand.h:
  54406. * editing/Editor.cpp:
  54407. (Editor::textDirectionForSelection): Added. Returns the character-level
  54408. writing direction of the selection if it is uniform and simple (at most
  54409. one level of embedding).
  54410. (Editor::hasBidiSelection): Added. Returns true if the selection lies
  54411. entirely within a single block, and that block has direction:rtl or
  54412. contains any inline boxes with non-zero bidi embedding level.
  54413. * editing/Editor.h:
  54414. * editing/EditorCommand.cpp:
  54415. (stateTextWritingDirection): Added this helper function for deciding
  54416. the state of Text Direction submenu items.
  54417. (executeMakeTextWritingDirectionLeftToRight): Added. Applies
  54418. "unicode-bidi: embed; direction: ltr;".
  54419. (executeMakeTextWritingDirectionNatural): Added. Applies
  54420. "unicode-bidi: normal;"
  54421. (executeMakeTextWritingDirectionRightToLeft): Added. Applies
  54422. "unicode-bidi: embed; direction: rtl;".
  54423. (stateTextWritingDirectionLeftToRight): Added.
  54424. (stateTextWritingDirectionNatural): Added.
  54425. (stateTextWritingDirectionRightToLeft): Added.
  54426. (createCommandMap): Added "MakeTextWritingDirectionLeftToRight",
  54427. "MakeTextWritingDirectionNatural",
  54428. and "MakeTextWritingDirectionRightToLeft".
  54429. * editing/InsertTextCommand.cpp:
  54430. (InsertTextCommand::input): Added code to maintain the unicode-bidi
  54431. and direction properties in the typing style. Even if they have the
  54432. same values as the computed style at the caret, they need to be included
  54433. in the typing style so that inserted text will not inherit any nested
  54434. embedding.
  54435. * page/ContextMenuController.cpp:
  54436. (ContextMenuController::contextMenuItemSelected): Added calls to
  54437. the editor for the text direction menu items.
  54438. * page/Frame.cpp
  54439. (Frame::computeAndSetTypingStyle): Added code to maintain the
  54440. unicode-bidi and direction properties in the typing style.
  54441. * page/Settings.cpp:
  54442. (Settings::setTextDirectionSubmenuInclusionBehavior): Added this setter.
  54443. * page/Settings.h: Added a TextDirectionSubmenuInclusionBehavior enum,
  54444. an m_textDirectionSubmenuInclusionBehavior member, and accessors.
  54445. * page/mac/WebCoreViewFactory.h:
  54446. * platform/ContextMenu.cpp:
  54447. (WebCore::createAndAppendTextDirectionSubMenu): Added.
  54448. (ContextMenu::populate): Added the Text Direction submenu item based on
  54449. the inclusion behavior and the existence of a bidi selection.
  54450. (ContextMenu::checkOrEnableIfNeeded): Added code for the text direction
  54451. menu items.
  54452. * platform/ContextMenuItem.h:
  54453. * platform/LocalizedStrings.h: Declared
  54454. contextMenuItemTagTextDirectionMenu().
  54455. * platform/mac/LocalizedStringsMac.mm: Defined
  54456. contextMenuItemTagTextDirectionMenu().
  54457. * rendering/RenderBlock.cpp:
  54458. (RenderBlock::containsNonZeroBidiLevel): Added.
  54459. * rendering/RenderBlock.h:
  54460. 2008-11-14 Greg Bolsinga <bolsinga@apple.com>
  54461. Reviewed by Darin Adler.
  54462. https://bugs.webkit.org/show_bug.cgi?id=22264
  54463. Need to update to latest Geolocation spec (13 November 2008)
  54464. Update to new error code constants and values.
  54465. * page/Geolocation.cpp: Use new named ErrorCode enums
  54466. (WebCore::Geolocation::GeoNotifier::timerFired):
  54467. (WebCore::Geolocation::getCurrentPosition):
  54468. (WebCore::Geolocation::watchPosition):
  54469. * page/PositionError.h: Have ErrorCode enum names match new error constant names and values
  54470. (WebCore::PositionError::):
  54471. * page/PositionError.idl: Add new named error constants
  54472. 2008-11-14 Beth Dakin <bdakin@apple.com>
  54473. Reviewed by Justin Garcia.
  54474. Fix (again) for <rdar://problem/5089327> Too much indentation when
  54475. pasting quoted paragraphs
  54476. This patch goes back to Justin's original approach to fix this bug,
  54477. written in revision 38273. That fix was mostly rolled out by
  54478. revision 38310 because of styling issues created by the addition of
  54479. extra blockquote nodes. This patch again goes back to Justin's
  54480. original fix because of cases we discovered the newer fix could not
  54481. possibly cover. This version of the patch minimizes the styling
  54482. issues of extra blockquotes by opting into the merge start code.
  54483. * editing/ReplaceSelectionCommand.cpp:
  54484. (WebCore::hasMatchingQuoteLevel): We want shouldMergeStart to
  54485. return true when the quoting level of the end of the inserted
  54486. content matches the quoting level of the end of the existing
  54487. content.
  54488. (WebCore::ReplaceSelectionCommand::shouldMergeStart): Now calls
  54489. hasMatchingQuoteLevel
  54490. (WebCore::ReplaceSelectionCommand::doApply):
  54491. 2008-11-14 Dirk Schulze <vbs85@gmx.de>
  54492. Reviewed by Eric Seidel.
  54493. Made SVGResourceClipper platform independent.
  54494. https://bugs.webkit.org/show_bug.cgi?id=21444
  54495. * GNUmakefile.am:
  54496. * WebCore.pro:
  54497. * WebCore.vcproj/WebCore.vcproj:
  54498. * WebCore.xcodeproj/project.pbxproj:
  54499. * platform/graphics/GraphicsContext.h:
  54500. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  54501. (WebCore::GraphicsContext::clipPath):
  54502. * platform/graphics/cg/GraphicsContextCG.cpp:
  54503. (WebCore::GraphicsContext::clipPath):
  54504. * platform/graphics/qt/GraphicsContextQt.cpp:
  54505. (WebCore::GraphicsContext::addPath):
  54506. (WebCore::GraphicsContext::clipPath):
  54507. * svg/graphics/SVGResourceClipper.cpp:
  54508. (WebCore::SVGResourceClipper::applyClip):
  54509. * svg/graphics/cairo/SVGResourceClipperCairo.cpp: Removed.
  54510. * svg/graphics/cg/SVGResourceClipperCg.cpp: Removed.
  54511. * svg/graphics/qt/SVGResourceClipperQt.cpp: Removed.
  54512. 2008-11-14 Antti Koivisto <antti@apple.com>
  54513. Reviewed by Anders Carlsson.
  54514. Combine loadFrameRequestWithFormState to loadFrameRequestWithFormAndValues.
  54515. * loader/FrameLoader.cpp:
  54516. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
  54517. * loader/FrameLoader.h:
  54518. 2008-11-14 Sam Weinig <sam@webkit.org>
  54519. Reviewed by Eric Seidel.
  54520. Remove unneeded forward declaration.
  54521. * plugins/Plugin.h:
  54522. 2008-11-14 Darin Fisher <darin@chromium.org>
  54523. Reviewed by Darin Adler.
  54524. https://bugs.webkit.org/show_bug.cgi?id=22251
  54525. HTMLCanvasElement.cpp unnecessarily includes runtime/Interpreter.h
  54526. * html/HTMLCanvasElement.cpp:
  54527. 2008-11-14 Yael Aharon <yael.aharon@nokia.com>
  54528. Reviewed by Simon Hausmann.
  54529. Add new files from the Qt port to the build.
  54530. * WebCore.pro:
  54531. 2008-11-14 Yael Aharon <yael.aharon@nokia.com>
  54532. Reviewed by Simon Hausmann.
  54533. Made DatabaseTracker::hasEntryForOrigin() public. This allows the Qt
  54534. port to apply a default quota only if there is no entry in the
  54535. database for a given origin yet.
  54536. * storage/DatabaseTracker.h:
  54537. 2008-11-14 Yael Aharon <yael.aharon@nokia.com>
  54538. Reviewed by Simon Hausmann.
  54539. Make it possible to get the cache directory set in the application
  54540. cache storage.
  54541. * loader/appcache/ApplicationCacheStorage.cpp:
  54542. (WebCore::ApplicationCacheStorage::cacheDirectory): Added.
  54543. * loader/appcache/ApplicationCacheStorage.h:
  54544. 2008-11-14 Justin Garcia <justin.garcia@apple.com>
  54545. Reviewed by Beth Dakin.
  54546. <rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages
  54547. When applying block styles, we would add block properties to the body element, and Mail's
  54548. Make Plain Text feature isn't equipped to remove those. This could have been fixed on our side,
  54549. but this change has the advantage that it fixes the bug on Tiger, where Mail does not plan future updates.
  54550. We have code that puts the paragraphs that we're operating on into blocks of their own before
  54551. adding or removing block properties from the blocks that enclose them. We need to run this code
  54552. when the enclosing block is the body element.
  54553. * editing/CompositeEditCommand.cpp:
  54554. (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Added, moved code from moveParagraphContents
  54555. to here.
  54556. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Renamed some variables for clarity.
  54557. Added a few comments. Fixed bug by not bailing out when the block about to be used is the body element.
  54558. * editing/CompositeEditCommand.h:
  54559. 2008-11-14 Cameron Zwarich <zwarich@apple.com>
  54560. Reviewed by Darin Adler.
  54561. Bug 22245: Move wtf/dtoa.h into the WTF namespace
  54562. <https://bugs.webkit.org/show_bug.cgi?id=22245>
  54563. Move wtf/dtoa.h into the WTF namespace from the JSC namespace.
  54564. * platform/text/String.cpp:
  54565. (WebCore::charactersToDouble):
  54566. 2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>
  54567. Rubber-stamped by Simon Hausmann.
  54568. Make sure Qt scrollbars follow the style with regard to context menus
  54569. * platform/qt/ScrollbarQt.cpp:
  54570. (WebCore::Scrollbar::contextMenu):
  54571. 2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>
  54572. Rubber-stamped by Simon Hausmann.
  54573. Make scrollbar look active when the window is active on Qt/Mac
  54574. * platform/qt/ScrollbarThemeQt.cpp:
  54575. (WebCore::styleOptionSlider):
  54576. (WebCore::ScrollbarThemeQt::paint):
  54577. 2008-11-13 Eric Seidel <eric@webkit.org>
  54578. Reviewed by Adam Roben.
  54579. Add a basic Scons-based build system for building
  54580. Chromium-Mac WebCore.
  54581. https://bugs.webkit.org/show_bug.cgi?id=21991
  54582. The build currently fails due to missing files from our
  54583. platform directory (platform skia and platform chromium)
  54584. I will be sending those up shortly in separate patches.
  54585. I expect it will be a while before our WebCore build links.
  54586. * SConstruct: Added.
  54587. * WebCore.scons: Added.
  54588. 2008-11-13 Darin Fisher <darin@chromium.org>
  54589. Reviewed by Darin Adler.
  54590. https://bugs.webkit.org/show_bug.cgi?id=22248
  54591. AtomicString.cpp uses JSC types outside of #if USE(JSC)
  54592. * platform/text/AtomicString.cpp:
  54593. (WebCore::AtomicString::add):
  54594. 2008-11-13 Justin Garcia <justin.garcia@apple.com>
  54595. Reviewed by Darin Adler.
  54596. https://bugs.webkit.org/show_bug.cgi?id=18620
  54597. Long hang under TextIterator::advance() when loading http://www.lsvd.de/
  54598. A huge section at the beginning of this document is invisible. As we iterate through it,
  54599. we create VisiblePositions unnecessarily.
  54600. * editing/TextIterator.cpp:
  54601. (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Don't proceed to VisiblePosition
  54602. creation if m_node is unrendered or invisible. The answers wouldn't have much meaning
  54603. and would be wasteful. Also fixed some comments to reflect the fact that this function
  54604. isn't specifically about emitting a newline.
  54605. 2008-11-13 Pierre-Olivier Latour <pol@apple.com>
  54606. Reviewed by Sam Weinig.
  54607. Remove unused or unnecessary code from AnimationBase class.
  54608. * page/animation/AnimationBase.cpp:
  54609. (WebCore::AnimationBase::AnimationBase):
  54610. (WebCore::AnimationBase::playStatePlaying):
  54611. * page/animation/AnimationBase.h:
  54612. 2008-11-12 Tor Arne Vestbø <tavestbo@trolltech.com>
  54613. Reviewed by Simon Hausmann.
  54614. Inital implementation of PluginPackage and PluginView for Mac NPAPI support in WebCore
  54615. Currently only used by QtWebKit. See also:
  54616. https://bugs.webkit.org/show_bug.cgi?id=21427
  54617. * WebCore.pro:
  54618. * platform/qt/TemporaryLinkStubs.cpp:
  54619. (PluginView::userAgentStatic):
  54620. (PluginView::getValueStatic):
  54621. * plugins/PluginView.cpp:
  54622. (WebCore::PluginView::handleEvent):
  54623. (WebCore::PluginView::setValue):
  54624. (WebCore::PluginView::PluginView):
  54625. * plugins/PluginView.h:
  54626. (WebCore::PluginView::setPlatformPluginWidget):
  54627. * plugins/mac/PluginPackageMac.cpp: Added.
  54628. (WebCore::PluginPackage::determineQuirks):
  54629. (WebCore::readPListFile):
  54630. (WebCore::stringListFromResourceId):
  54631. (WebCore::PluginPackage::fetchInfo):
  54632. (WebCore::PluginPackage::load):
  54633. (WebCore::PluginPackage::hash):
  54634. (WebCore::PluginPackage::equal):
  54635. (WebCore::PluginPackage::compareFileVersion):
  54636. * plugins/mac/PluginViewMac.cpp: Added.
  54637. (WebCore::nativeWindowFor):
  54638. (WebCore::cgHandleFor):
  54639. (WebCore::topLevelOffsetFor):
  54640. (WebCore::PluginView::init):
  54641. (WebCore::PluginView::~PluginView):
  54642. (WebCore::PluginView::stop):
  54643. (WebCore::PluginView::getValueStatic):
  54644. (WebCore::PluginView::getValue):
  54645. (WebCore::PluginView::setParent):
  54646. (WebCore::PluginView::show):
  54647. (WebCore::PluginView::hide):
  54648. (WebCore::PluginView::setFocus):
  54649. (WebCore::PluginView::setParentVisible):
  54650. (WebCore::PluginView::setNPWindowRect):
  54651. (WebCore::PluginView::setNPWindowIfNeeded):
  54652. (WebCore::PluginView::updatePluginWidget):
  54653. (WebCore::PluginView::paint):
  54654. (WebCore::PluginView::invalidateRect):
  54655. (WebCore::PluginView::invalidateRegion):
  54656. (WebCore::PluginView::forceRedraw):
  54657. (WebCore::PluginView::handleMouseEvent):
  54658. (WebCore::PluginView::handleKeyboardEvent):
  54659. (WebCore::PluginView::nullEventTimerFired):
  54660. (WebCore::modifiersForEvent):
  54661. (WebCore::PluginView::globalMousePosForPlugin):
  54662. (WebCore::PluginView::dispatchNPEvent):
  54663. (WebCore::PluginView::userAgent):
  54664. (WebCore::PluginView::userAgentStatic):
  54665. (WebCore::PluginView::handlePostReadFile):
  54666. 2008-11-12 Alexey Proskuryakov <ap@webkit.org>
  54667. Reviewed by Darin Adler.
  54668. https://bugs.webkit.org/show_bug.cgi?id=22200
  54669. Crash when close event is dispatched to MessagePort due to document destruction
  54670. Test: fast/events/message-port-onclose.html
  54671. * dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed):
  54672. Don't dispatch close event, even though HTML5 currently says that we should. It is not
  54673. right for GC to have observable effects.
  54674. 2008-11-12 Alexey Proskuryakov <ap@webkit.org>
  54675. Reviewed by Darin Adler.
  54676. https://bugs.webkit.org/show_bug.cgi?id=22203
  54677. Implement Worker messaging
  54678. No test cases included, because this functionality is disabled by default.
  54679. The implementation is known to still have many race condition, but works quite well for
  54680. testing.
  54681. * WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.
  54682. * bindings/js/JSDOMBinding.cpp:
  54683. (WebCore::markActiveObjectsForContext): Re-worded comments a little.
  54684. (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was
  54685. incorrect, changed it to a much simpler (but still incorrect) version.
  54686. * dom/WorkerTask.cpp: Added.
  54687. (WebCore::WorkerTask::~WorkerTask):
  54688. * dom/WorkerTask.h: Added.
  54689. Tasks posted to workers implement this new interface.
  54690. * bindings/js/JSDedicatedWorkerCustom.cpp:
  54691. (WebCore::JSDedicatedWorker::mark):
  54692. (WebCore::JSDedicatedWorker::connect):
  54693. * dom/DedicatedWorker.h:
  54694. * dom/DedicatedWorker.idl:
  54695. Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking
  54696. WHATWG discussions.
  54697. * dom/DedicatedWorker.cpp:
  54698. (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect()
  54699. operations.
  54700. (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer.
  54701. (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts
  54702. one to worker. Since message port registration in ScriptExecutionContext is not thread safe,
  54703. this port starts with a null context pointer.
  54704. (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately
  54705. after creation, we have to queue tasks until after a WorkerThread object is created. Then we
  54706. forward all queued tasks to its queue.
  54707. * dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
  54708. * dom/EventTarget.h:
  54709. * bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  54710. Added cases for WorkerContext, which is now an EventTarget, too.
  54711. * bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
  54712. * bindings/js/JSWorkerContext.cpp:
  54713. (WebCore::JSWorkerContext::mark): Mark event listeners.
  54714. (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID.
  54715. (WebCore::JSWorkerContext::put): Implemented.
  54716. (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation.
  54717. (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto.
  54718. (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto.
  54719. (WebCore::jsWorkerContextOnconnect): Added.
  54720. (WebCore::setJSWorkerContextOnconnect): Added.
  54721. * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  54722. Made it actually work by adding necessary setup.
  54723. * bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded):
  54724. Check the right variable - it is the wrapper that may not be initialized yet.
  54725. * dom/ActiveDOMObject.cpp:
  54726. (WebCore::ActiveDOMObject::ActiveDOMObject):
  54727. (WebCore::ActiveDOMObject::~ActiveDOMObject):
  54728. Assert being called from the correct thread, as active DOM object tracking is not thread safe.
  54729. * dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used
  54730. for asynchronously executing tasks in context's thread.
  54731. * dom/ScriptExecutionContext.cpp:
  54732. (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task
  54733. (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer.
  54734. It was an optimization that couldn't be easily preserved without introducing race conditions
  54735. in multithreading case.
  54736. (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask().
  54737. (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining
  54738. why it's OK to not ref() ports in a frozen copy.
  54739. (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called
  54740. from a wrong thread.
  54741. (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto.
  54742. (WebCore::ScriptExecutionContextTaskTimer): Part of
  54743. ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main
  54744. thread.
  54745. (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting
  54746. to a worker.
  54747. (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting
  54748. to main thread from a secondary one.
  54749. (WebCore::performTask): A helper function for callOnMainThread().
  54750. (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.
  54751. * dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would
  54752. ref/deref EventData::message from different threads, which is not allowed.
  54753. * dom/MessagePort.cpp:
  54754. (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads.
  54755. (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now.
  54756. (WebCore::MessagePort::EventData::EventData): Ditto.
  54757. (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at
  54758. first, because we need to create ports for posting to other threads, and it is not possible
  54759. to register in a context from another thread.
  54760. (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message
  54761. receiver's job to set the context.
  54762. (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any
  54763. context yet.
  54764. (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached.
  54765. (WebCore::MessagePort::contextDestroyed): Assert that we had a context.
  54766. (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in
  54767. context.
  54768. (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual.
  54769. (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask().
  54770. (WebCore::MessagePort::queueCloseEvent): Use postTask().
  54771. (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above,
  54772. MessagePort cross-heap GC is still quite wrong.
  54773. * dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
  54774. * dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions
  54775. now, but there is no harm in tracking it in release builds, too.
  54776. * dom/WorkerThread.cpp:
  54777. (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create().
  54778. (WebCore::WorkerThread::workerThread): Implemented a message loop.
  54779. * dom/WorkerThread.h:
  54780. (WebCore::WorkerThread::threadID): Also only used for assertions.
  54781. (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.
  54782. * page/DOMWindow.cpp:
  54783. (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it
  54784. always sets it to null.
  54785. (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.
  54786. 2008-11-12 Dirk Schulze <vbs85@gmx.de>
  54787. Reviewed Darin Adler.
  54788. use strokeColor.alpha() instead of fillColor.alpha()
  54789. on GraphicsContext::strokePath()
  54790. [Canvas] Transparent fillStyle stops line rendering
  54791. https://bugs.webkit.org/show_bug.cgi?id=21888
  54792. Test: fast/canvas/canvas-stroke-empty-fill.html
  54793. * ChangeLog:
  54794. * platform/graphics/cg/GraphicsContextCG.cpp:
  54795. (WebCore::GraphicsContext::strokePath):
  54796. 2008-11-12 Stephanie <slewis@apple.com>
  54797. Reviewed by Mark Rowe.
  54798. Fix context leak in XSLStyleSheets.
  54799. See bug https://bugs.webkit.org/show_bug.cgi?id=15715
  54800. * xml/XSLStyleSheet.cpp:
  54801. (WebCore::XSLStyleSheet::parseString):
  54802. 2008-11-12 Alp Toker <alp@nuanti.com>
  54803. autotools: List web worker-related headers needed for a successful
  54804. build. distcheck is passing again with this change.
  54805. * GNUmakefile.am:
  54806. 2008-11-12 Alp Toker <alp@nuanti.com>
  54807. autotools build system fix-up only. Add FloatQuad.h to the source
  54808. lists and sort them.
  54809. * GNUmakefile.am:
  54810. 2008-11-12 Alp Toker <alp@nuanti.com>
  54811. Build fixes for r38346. FloatQuad.cpp is missing:
  54812. 1) #include "config.h"
  54813. 2) #include <algorithm> for various mathematical definitions it uses.
  54814. * platform/graphics/FloatQuad.cpp:
  54815. 2008-11-12 Simon Fraser <simon.fraser@apple.com>
  54816. Reviewed by Dan Bernstein
  54817. https://bugs.webkit.org/show_bug.cgi?id=22212
  54818. Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
  54819. it may be the bounding outline box of a transformed element, and fix it
  54820. to respect transforms by mapping the outline box to an absolute quad and
  54821. taking the enclosing rect.
  54822. RenderBox::localToAbsoluteQuad() can no longer assert that there is no
  54823. LayoutState, but LayoutState cannot be used during quad mapping (it knows
  54824. nothing about transforms).
  54825. Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
  54826. borderTopExtra() from the object, rather than its container (as localToAbsolute()
  54827. does).
  54828. Test: fast/repaint/transform-absolute-child.html
  54829. * rendering/RenderBlock.cpp:
  54830. (WebCore::RenderBlock::layoutBlock):
  54831. * rendering/RenderBox.cpp:
  54832. (WebCore::RenderBox::localToAbsoluteQuad):
  54833. * rendering/RenderFlexibleBox.cpp:
  54834. (WebCore::RenderFlexibleBox::layoutBlock):
  54835. * rendering/RenderForeignObject.cpp:
  54836. (WebCore::RenderForeignObject::layout):
  54837. * rendering/RenderLayer.cpp:
  54838. (WebCore::RenderLayer::updateLayerPositions):
  54839. (WebCore::RenderLayer::setHasVisibleContent):
  54840. * rendering/RenderObject.cpp:
  54841. (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  54842. (WebCore::RenderObject::absoluteOutlineBounds):
  54843. * rendering/RenderObject.h:
  54844. * rendering/RenderPath.cpp:
  54845. (WebCore::RenderPath::layout):
  54846. * rendering/RenderReplaced.cpp:
  54847. (WebCore::RenderReplaced::layout):
  54848. * rendering/RenderSVGContainer.cpp:
  54849. (WebCore::RenderSVGContainer::layout):
  54850. * rendering/RenderSVGImage.cpp:
  54851. (WebCore::RenderSVGImage::layout):
  54852. * rendering/RenderSVGRoot.cpp:
  54853. (WebCore::RenderSVGRoot::layout):
  54854. * rendering/RenderSVGText.cpp:
  54855. (WebCore::RenderSVGText::layout):
  54856. * rendering/RenderSVGViewportContainer.cpp:
  54857. (WebCore::RenderSVGViewportContainer::layout):
  54858. * rendering/RenderTable.cpp:
  54859. (WebCore::RenderTable::layout):
  54860. 2008-11-12 Simon Fraser <simon.fraser@apple.com>
  54861. Reviewed by Dave Hyatt
  54862. https://bugs.webkit.org/show_bug.cgi?id=21942
  54863. https://bugs.webkit.org/show_bug.cgi?id=18557
  54864. Add methods which can be used to map renderer-local rectangles
  54865. to quads in absolute coordinates, taking transforms into account:
  54866. localToAbsoluteQuad() converts a local rect into an absolute quad.
  54867. collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()
  54868. that works with quads.
  54869. absoluteQuads() is an analogue of absoluteRects(), for quads.
  54870. Use the quad methods to fix the inspector highlight for transformed
  54871. elements.
  54872. * GNUmakefile.am:
  54873. * WebCore.pro:
  54874. * WebCore.vcproj/WebCore.vcproj:
  54875. * WebCore.xcodeproj/project.pbxproj:
  54876. * WebCoreSources.bkl:
  54877. * inspector/InspectorController.cpp:
  54878. (WebCore::drawOutlinedQuad):
  54879. (WebCore::drawHighlightForBoxes):
  54880. (WebCore::frameToMainFrameOffset):
  54881. (WebCore::InspectorController::drawNodeHighlight):
  54882. * platform/graphics/AffineTransform.cpp:
  54883. (WebCore::AffineTransform::mapQuad):
  54884. * platform/graphics/AffineTransform.h:
  54885. * platform/graphics/FloatQuad.cpp: Added.
  54886. (WebCore::min4):
  54887. (WebCore::max4):
  54888. (WebCore::FloatQuad::boundingBox):
  54889. * platform/graphics/FloatQuad.h: Added.
  54890. (WebCore::FloatQuad::FloatQuad):
  54891. (WebCore::FloatQuad::p1):
  54892. (WebCore::FloatQuad::p2):
  54893. (WebCore::FloatQuad::p3):
  54894. (WebCore::FloatQuad::p4):
  54895. (WebCore::FloatQuad::setP1):
  54896. (WebCore::FloatQuad::setP2):
  54897. (WebCore::FloatQuad::setP3):
  54898. (WebCore::FloatQuad::setP4):
  54899. (WebCore::FloatQuad::isEmpty):
  54900. (WebCore::FloatQuad::enclosingBoundingBox):
  54901. (WebCore::FloatQuad::move):
  54902. (WebCore::operator+=):
  54903. (WebCore::operator-=):
  54904. (WebCore::operator==):
  54905. (WebCore::operator!=):
  54906. * rendering/RenderBox.cpp:
  54907. (WebCore::RenderBox::localToAbsoluteQuad):
  54908. * rendering/RenderBox.h:
  54909. * rendering/RenderContainer.cpp:
  54910. (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
  54911. * rendering/RenderContainer.h:
  54912. * rendering/RenderInline.cpp:
  54913. (WebCore::RenderInline::absoluteQuads):
  54914. * rendering/RenderInline.h:
  54915. * rendering/RenderObject.cpp:
  54916. (WebCore::RenderObject::absoluteBoundingBoxRect):
  54917. (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
  54918. (WebCore::RenderObject::absoluteQuads):
  54919. (WebCore::RenderObject::localToAbsoluteQuad):
  54920. (WebCore::RenderObject::absoluteContentQuad):
  54921. * rendering/RenderObject.h:
  54922. * rendering/RenderPath.cpp:
  54923. (WebCore::RenderPath::absoluteQuads):
  54924. * rendering/RenderPath.h:
  54925. * rendering/RenderSVGContainer.cpp:
  54926. (WebCore::RenderSVGContainer::absoluteQuads):
  54927. * rendering/RenderSVGContainer.h:
  54928. * rendering/RenderSVGHiddenContainer.cpp:
  54929. (WebCore::RenderSVGHiddenContainer::absoluteQuads):
  54930. * rendering/RenderSVGHiddenContainer.h:
  54931. * rendering/RenderSVGImage.cpp:
  54932. (WebCore::RenderSVGImage::calculateAbsoluteBounds):
  54933. (WebCore::RenderSVGImage::absoluteQuads):
  54934. * rendering/RenderSVGImage.h:
  54935. * rendering/RenderSVGInlineText.cpp:
  54936. (WebCore::RenderSVGInlineText::absoluteQuads):
  54937. (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
  54938. * rendering/RenderSVGInlineText.h:
  54939. * rendering/RenderSVGRoot.cpp:
  54940. (WebCore::RenderSVGRoot::absoluteQuads):
  54941. * rendering/RenderSVGRoot.h:
  54942. * rendering/RenderSVGTSpan.cpp:
  54943. (WebCore::RenderSVGTSpan::absoluteRects):
  54944. (WebCore::RenderSVGTSpan::absoluteQuads):
  54945. * rendering/RenderSVGTSpan.h:
  54946. * rendering/RenderSVGText.cpp:
  54947. (WebCore::RenderSVGText::absoluteRects):
  54948. (WebCore::RenderSVGText::absoluteQuads):
  54949. * rendering/RenderSVGText.h:
  54950. * rendering/RenderSVGTextPath.cpp:
  54951. (WebCore::RenderSVGTextPath::absoluteRects):
  54952. (WebCore::RenderSVGTextPath::absoluteQuads):
  54953. * rendering/RenderSVGTextPath.h:
  54954. * rendering/RenderTableCell.cpp:
  54955. (WebCore::RenderTableCell::localToAbsolute):
  54956. (WebCore::RenderTableCell::localToAbsoluteQuad):
  54957. * rendering/RenderTableCell.h:
  54958. * rendering/RenderText.cpp:
  54959. (WebCore::RenderText::absoluteQuads):
  54960. (WebCore::RenderText::collectAbsoluteLineBoxQuads):
  54961. * rendering/RenderText.h:
  54962. * rendering/RenderView.cpp:
  54963. (WebCore::RenderView::localToAbsoluteQuad):
  54964. (WebCore::RenderView::absoluteQuads):
  54965. * rendering/RenderView.h:
  54966. 2008-11-12 Brent Fulgham <bfulgham@gmail.com>
  54967. Fix Bug 22178: Build errors in WebKit Cairo port
  54968. <https://bugs.webkit.org/show_bug.cgi?id=22178>
  54969. Reviewed by Mark Rowe.
  54970. * platform/graphics/cairo/PatternCairo.cpp: Correct build error under
  54971. Visual Studio.
  54972. (WebCore::Pattern::createPlatformPattern):
  54973. 2008-11-12 Adam Roben <aroben@apple.com>
  54974. Fix a typo in the include path for the Release_Cairo configuration
  54975. * WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.
  54976. 2008-11-12 Simon Fraser <simon.fraser@apple.com>
  54977. Reviewed by Dave Hyatt
  54978. https://bugs.webkit.org/show_bug.cgi?id=17840
  54979. Patch 2
  54980. Code cleanup in RenderBox::computeAbsoluteRepaintRect().
  54981. * rendering/RenderBox.cpp:
  54982. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  54983. 2008-11-12 Simon Fraser <simon.fraser@apple.com>
  54984. Reviewed by Dave Hyatt
  54985. https://bugs.webkit.org/show_bug.cgi?id=17840
  54986. Fix repainting when the transform on a positioned element changes.
  54987. In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
  54988. and being in a positioned container after applying the transform to the local
  54989. rect.
  54990. Tests: fast/repaint/transform-absolute-in-positioned-container.html
  54991. fast/repaint/transform-relative-position.html
  54992. * rendering/RenderBox.cpp:
  54993. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  54994. 2008-11-12 Justin Garcia <justin.garcia@apple.com>
  54995. Reviewed by Beth Dakin.
  54996. <rdar://problem/5495723> Selecting and deleting quoted text quotes other text
  54997. <rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted
  54998. We don't want to merge into a block if it will mean changing the quote level of content after deleting
  54999. selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
  55000. that such a selection actually ends at the start of the next paragraph. Instead we want to completely
  55001. remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
  55002. for indented paragraphs.
  55003. * editing/DeleteSelectionCommand.cpp:
  55004. (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not
  55005. try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied
  55006. so that we remove evidence of the deleted paragraphs' quote level.
  55007. (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also
  55008. make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection
  55009. started on, instead of one higher.
  55010. * editing/DeleteSelectionCommand.h:
  55011. * editing/htmlediting.cpp:
  55012. (WebCore::numEnclosingMailBlockquotes): Added.
  55013. * editing/htmlediting.h:
  55014. 2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
  55015. Reviewed by Simon Hausmann.
  55016. Move _web_encodingForResource from WebKit into WebCore and change return type
  55017. This change is needed to implement NSAPI in WebCore for Mac, see:
  55018. https://bugs.webkit.org/show_bug.cgi?id=21427
  55019. * WebCore.base.exp:
  55020. * platform/mac/WebCoreNSStringExtras.h:
  55021. * platform/mac/WebCoreNSStringExtras.mm:
  55022. (stringEncodingForResource):
  55023. 2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
  55024. Reviewed by Simon Hausmann.
  55025. Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
  55026. WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.
  55027. This change is needed to implement NSAPI in WebCore for Mac, see:
  55028. https://bugs.webkit.org/show_bug.cgi?id=21427
  55029. * WebCore.base.exp:
  55030. * platform/mac/WebCoreNSStringExtras.h:
  55031. * platform/mac/WebCoreNSStringExtras.mm:
  55032. (stringIsCaseInsensitiveEqualToString):
  55033. 2008-11-11 Stephanie <slewis@apple.com>
  55034. Reviewed by Dan Bernstein.
  55035. Null check image data before setting it as image source.
  55036. Test: fast/images/image-empty-data.html
  55037. * platform/graphics/BitmapImage.cpp:
  55038. (WebCore::BitmapImage::destroyDecodedData):
  55039. 2008-11-11 Adele Peterson <adele@apple.com>
  55040. Reviewed by Tim Hatcher.
  55041. Remove ifdef so future OS versions can use the new delegate method.
  55042. * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
  55043. 2008-11-11 Eric Seidel <eric@webkit.org>
  55044. Reviewed by Antti Koivisto and Sam Weinig.
  55045. Clean up HTMLTokenizer a litle
  55046. https://bugs.webkit.org/show_bug.cgi?id=22188
  55047. Rename pendingScripts to m_pendingScripts
  55048. Rename scriptNode to m_scriptNode make the type specific
  55049. Rename pendingSrc to m_pendingSrc
  55050. Rename currentPrependingSrc to m_currentPrependingSrc
  55051. Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
  55052. Remove long-since-dead kdDebug and qDebug calls
  55053. Rename brokenComments to m_brokenComments
  55054. Remove HTMLTokenizer includes and document the rest
  55055. Rename src to m_src
  55056. Rename parser to m_parser and make it an OwnPtr
  55057. Rename inWrite to m_inWrite and jsProxy to scriptController
  55058. Rename brokenServer to m_brokenServer
  55059. Rename buffer to m_buffer and dest to m_dest
  55060. Rename size to m_bufferSize
  55061. Rename attrName to m_attrName
  55062. Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
  55063. Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
  55064. Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
  55065. Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
  55066. Rename flat to selfClosingTag
  55067. Rename currToken to m_currentToken
  55068. * css/CSSParser.cpp:
  55069. * dom/XMLTokenizer.cpp:
  55070. * dom/XMLTokenizerLibxml2.cpp:
  55071. * html/HTMLDocument.cpp:
  55072. * html/HTMLElement.cpp:
  55073. * html/HTMLFormControlElement.cpp:
  55074. * html/HTMLParser.h:
  55075. * html/HTMLTokenizer.cpp:
  55076. (WebCore::Token::addAttribute):
  55077. (WebCore::HTMLTokenizer::HTMLTokenizer):
  55078. (WebCore::HTMLTokenizer::reset):
  55079. (WebCore::HTMLTokenizer::begin):
  55080. (WebCore::HTMLTokenizer::processListing):
  55081. (WebCore::HTMLTokenizer::parseSpecial):
  55082. (WebCore::HTMLTokenizer::scriptHandler):
  55083. (WebCore::HTMLTokenizer::scriptExecution):
  55084. (WebCore::HTMLTokenizer::parseComment):
  55085. (WebCore::HTMLTokenizer::parseServer):
  55086. (WebCore::HTMLTokenizer::parseProcessingInstruction):
  55087. (WebCore::HTMLTokenizer::parseText):
  55088. (WebCore::HTMLTokenizer::parseEntity):
  55089. (WebCore::HTMLTokenizer::parseTag):
  55090. (WebCore::HTMLTokenizer::write):
  55091. (WebCore::HTMLTokenizer::processingData):
  55092. (WebCore::HTMLTokenizer::end):
  55093. (WebCore::HTMLTokenizer::finish):
  55094. (WebCore::HTMLTokenizer::processToken):
  55095. (WebCore::HTMLTokenizer::processDoctypeToken):
  55096. (WebCore::HTMLTokenizer::~HTMLTokenizer):
  55097. (WebCore::HTMLTokenizer::enlargeBuffer):
  55098. (WebCore::HTMLTokenizer::enlargeScriptBuffer):
  55099. (WebCore::HTMLTokenizer::notifyFinished):
  55100. (WebCore::HTMLTokenizer::setSrc):
  55101. * html/HTMLTokenizer.h:
  55102. (WebCore::Token::Token):
  55103. (WebCore::Token::reset):
  55104. (WebCore::HTMLTokenizer::processingContentWrittenByScript):
  55105. (WebCore::HTMLTokenizer::htmlParser):
  55106. (WebCore::HTMLTokenizer::checkBuffer):
  55107. (WebCore::HTMLTokenizer::checkScriptBuffer):
  55108. * html/HTMLViewSourceDocument.h:
  55109. * rendering/RenderBlock.cpp:
  55110. (WebCore::RenderBlock::leftRelOffset):
  55111. (WebCore::RenderBlock::rightRelOffset):
  55112. (WebCore::RenderBlock::lineWidth):
  55113. * xml/XSLTProcessor.cpp:
  55114. 2008-11-11 Sam Weinig <sam@webkit.org>
  55115. Reviewed by Dan Bernstein.
  55116. Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
  55117. Track CachedScript decoded data
  55118. We now track the decoded size of CachedScripts in the Cache allowing
  55119. them to accounted for when deciding when to evict data. The decoded
  55120. data itself can be evicted when Cache pressure gets high enough through
  55121. CachedScript::destroyDecodedData.
  55122. * loader/CachedResource.h:
  55123. (WebCore::CachedResource::allClientsRemoved):
  55124. (WebCore::CachedResource::destroyDecodedData):
  55125. * loader/CachedScript.cpp:
  55126. (WebCore::CachedScript::script):
  55127. (WebCore::CachedScript::data):
  55128. (WebCore::CachedScript::destroyDecodedData):
  55129. * loader/CachedScript.h:
  55130. 2008-11-11 Cameron Zwarich <zwarich@apple.com>
  55131. Reviewed by Geoff Garen.
  55132. Remove pointless dependencies on the now-deleted kjs directory and
  55133. mentions of it in comments that are no longer relevant.
  55134. * WebCore.pro:
  55135. * webcore-base.bkl:
  55136. 2008-11-11 Dan Bernstein <mitz@apple.com>
  55137. Reviewed by Adam Roben.
  55138. WebCore part of adding a master volume control for media elements in a WebView
  55139. * WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
  55140. * dom/Document.cpp:
  55141. (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page
  55142. when the media volume is changed.
  55143. (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows
  55144. elements to register for a callback when the media volume is changed.
  55145. (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows
  55146. elements to unregister for the callback.
  55147. * dom/Document.h:
  55148. * dom/Element.h:
  55149. (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
  55150. * html/HTMLMediaElement.cpp:
  55151. (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to
  55152. registerForMediaVolumeCallbacks().
  55153. (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to
  55154. unregisterForMediaVolumeCallbacks().
  55155. (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the
  55156. element's intrinsic volume by the master volume from the page.
  55157. (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls
  55158. updateVolume().
  55159. * html/HTMLMediaElement.h:
  55160. * page/Page.cpp:
  55161. (WebCore::Page::Page): Initialize m_mediaVolume to 1.
  55162. (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on
  55163. every document in the page when the master volume changes.
  55164. * page/Page.h:
  55165. (WebCore::Page::mediaVolume): Added this getter.
  55166. 2008-11-11 David Hyatt <hyatt@apple.com>
  55167. https://bugs.webkit.org/show_bug.cgi?id=22182
  55168. Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
  55169. is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
  55170. errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.
  55171. Reviewed by Adele
  55172. * platform/Scrollbar.cpp:
  55173. (WebCore::Scrollbar::mouseDown):
  55174. 2008-11-11 Beth Dakin <bdakin@apple.com>
  55175. Reviewed by Darin Adler.
  55176. Fix for <rdar://problem/5089327> Too much indentation when pasting
  55177. quoted paragraphs
  55178. This patch re-addresses pasting blockquotes into blockquotes. It
  55179. backs out most of revision 38273. 38273 fixed the bug by inserting
  55180. the pasted content as a sibling blockquote node to the pre-existing
  55181. blockquote node. The problem with that is that by default,
  55182. blockquotes have a giant margin, so visually, this can be weird.
  55183. This patch instead inserts the pasted content as siblings of the
  55184. the content already inside the outer blockquote, and then removes
  55185. the blockquote node from the pasted content itself, so that it
  55186. doesn't nest itself into the outer blockquote.
  55187. * editing/ReplaceSelectionCommand.cpp:
  55188. (WebCore::ReplaceSelectionCommand::doApply):
  55189. Move contains() from Element to Node since there is nothing
  55190. Element-specific about it.
  55191. * dom/Element.cpp:
  55192. * dom/Element.h:
  55193. * dom/Node.cpp:
  55194. (WebCore::Node::contains):
  55195. * dom/Node.h:
  55196. 2008-11-11 David Hyatt <hyatt@apple.com>
  55197. https://bugs.webkit.org/show_bug.cgi?id=17997
  55198. Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
  55199. is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
  55200. is a Leopard-only workaround, since the API has been fixed on Snow Leopard.
  55201. Reviewed by John Sullivan
  55202. * platform/graphics/cg/ImageCG.cpp:
  55203. (WebCore::Image::drawPattern):
  55204. 2008-11-10 David Hyatt <hyatt@apple.com>
  55205. Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
  55206. when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
  55207. how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.
  55208. Reviewed by Adam Roben
  55209. * rendering/RenderThemeMac.mm:
  55210. (WebCore::RenderThemeMac::isControlStyled):
  55211. 2008-11-11 Darin Adler <darin@apple.com>
  55212. Reviewed by Dan Bernstein.
  55213. - https://bugs.webkit.org/show_bug.cgi?id=22160
  55214. speculative fix for <rdar://problem/5995450> Nil deref because nextLinePosition
  55215. (previousLinePosition, too) uses a nil node
  55216. * editing/visible_units.cpp:
  55217. (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element
  55218. to check editingIgnoresContent. It makes sense to use the associated DOM node for
  55219. this, even in cases of anonymous content, and it avoids the case where element() can
  55220. be 0.
  55221. (WebCore::previousLinePosition): Ditto.
  55222. 2008-11-11 Dirk Schulze <vbs85@gmx.de>
  55223. Reviewed by Darin Adler.
  55224. Removed default: in applySpreadMethod. This causes the problems
  55225. in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
  55226. or CSS.
  55227. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  55228. (WebCore::applySpreadMethod):
  55229. 2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
  55230. Reviewed by Tor Arne Vestbø.
  55231. Fix crash when rendering the file chooser.
  55232. Also proper implementation for multi-selected files.
  55233. * platform/qt/FileChooserQt.cpp:
  55234. (WebCore::FileChooser::basenameForWidth):
  55235. 2008-11-11 Dirk Schulze <vbs85@gmx.de>
  55236. Reviewed by Oliver Hunt.
  55237. PatternCairo needs to invert the pattern matrix because
  55238. of transformation from user space to pattern space.
  55239. Give a identity matrix to pattern for Qt and Cairo. Because the
  55240. context is transformed already.
  55241. [CAIRO][QT] Canvas transformations applied twice to Patterns
  55242. https://bugs.webkit.org/show_bug.cgi?id=21555
  55243. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  55244. (WebCore::GraphicsContext::fillPath):
  55245. (WebCore::GraphicsContext::strokePath):
  55246. * platform/graphics/cairo/PatternCairo.cpp:
  55247. (WebCore::Pattern::createPlatformPattern):
  55248. * platform/graphics/qt/GraphicsContextQt.cpp:
  55249. (WebCore::GraphicsContext::strokePath):
  55250. (WebCore::GraphicsContext::fillRect):
  55251. 2008-11-10 Stephanie Lewis <slewis@apple.com>
  55252. Reviewed by Dan Bernstein.
  55253. Clear the image source cache even if we haven't decoded any of the image data.
  55254. We use the image source cache when calculating layout.
  55255. * loader/Cache.cpp:
  55256. (WebCore::Cache::pruneDeadResources):
  55257. * platform/graphics/BitmapImage.cpp:
  55258. (WebCore::BitmapImage::destroyDecodedData):
  55259. 2008-11-10 Adam Roben <aroben@apple.com>
  55260. Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
  55261. loading microsoftpdc.com
  55262. <https://bugs.webkit.org/show_bug.cgi?id=22161>
  55263. Reviewed by Dan Bernstein.
  55264. Test: fast/css/outline-invert-assertion.html
  55265. * rendering/RenderThemeWin.cpp:
  55266. (WebCore::RenderThemeWin::systemColor): If we can't determine a good
  55267. Win32 system color to use, defer to RenderTheme instead of asserting.
  55268. This matches what RenderThemeMac does.
  55269. 2008-11-10 Justin Garcia <justin.garcia@apple.com>
  55270. Reviewed by Beth Dakin.
  55271. <rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
  55272. into quoted text yields double-quoting
  55273. Don't nest inserted content in Mail blockquotes. Perform a
  55274. BreakBlockquoteCommand if we're in
  55275. one and insert the incoming fragment between the split blockquotes.
  55276. * editing/ReplaceSelectionCommand.cpp:
  55277. (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from ->
  55278. source and to -> destination.
  55279. (WebCore::ReplaceSelectionCommand::doApply):
  55280. 2008-11-10 Adam Roben <aroben@apple.com>
  55281. Fix Bug 22158: Would like to turn on WebCore logging channels via an
  55282. environment variable
  55283. <https://bugs.webkit.org/show_bug.cgi?id=22158>
  55284. Logging channels can now be enabled by setting the WebCoreLogLevel
  55285. environment variable to a hexadecimal number.
  55286. Reviewed by Anders Carlsson.
  55287. * WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
  55288. * platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm.
  55289. (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel
  55290. environment variable, parse its value as a hexadecimal number, and
  55291. turn the channel on/off based on whether the mask bit is set.
  55292. (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each
  55293. logging channel in turn.
  55294. 2008-11-10 Darin Adler <darin@apple.com>
  55295. Reviewed by Adam Roben.
  55296. - fix https://bugs.webkit.org/show_bug.cgi?id=22103
  55297. Changing fonts in preferences does not immediately update WebViews
  55298. This broke when the meaning of FrameView::invalidate changed.
  55299. I changed setNeedsReapplyStyles to no longer depend on invalidate.
  55300. * dom/Document.cpp: (WebCore::Document::shouldScheduleLayout):
  55301. Removed the part of this function that duplicated what's already in
  55302. FrameView::needsLayout, since the copy here left out a few key things.
  55303. For example, it didn't handle the fact that "needs reapply styles"
  55304. counts as needing layout.
  55305. * page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called
  55306. FrameView::invalidate before. There were two things wrong with that.
  55307. 1) It requested that the entire view repaint even if the style change
  55308. didn't necessitate that. 2) FrameView::invalidate no longer causes any
  55309. repainting at all in certain cases, because of Hyatt's changes to how
  55310. widgets and the host window are involved in the repainting process.
  55311. So call FrameView::scheduleRelayout instead, which is more precisely
  55312. what we want and need here.
  55313. * page/FrameView.cpp:
  55314. (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here
  55315. so that Document::shouldScheduleLayout doesn't have to replicate the
  55316. logic that's in needsLayout and can instead rely on the fact that it
  55317. was already called.
  55318. (WebCore::FrameView::needsLayout): Tweaked the comments and formatting
  55319. in this function.
  55320. 2008-11-10 Darin Adler <darin@apple.com>
  55321. Reviewed by Adam Roben.
  55322. - speculative fix for <rdar://problem/5557243> crashes in Safari at
  55323. WebCore::HTMLSelectElement::updateListBoxSelection + 280
  55324. * html/HTMLSelectElement.cpp:
  55325. (WebCore::HTMLSelectElement::updateListBoxSelection):
  55326. Check index against size of vector before indexing into the vector.
  55327. 2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>
  55328. Reviewed by Tor Arne Vestbø.
  55329. Fix QtWebkit build failure on arm.
  55330. pen.widthF() is a qreal, which means it's a float on arm.
  55331. * platform/graphics/qt/GraphicsContextQt.cpp:
  55332. (WebCore::GraphicsContext::setLineDash):
  55333. 2008-11-10 Morten Sørvig <msorvig@trolltech.com>
  55334. Reviewed by Simon Hausmann.
  55335. Improve mouse wheel scolling on Qt/Cocoa.
  55336. Cocoa differs from Carbon (and other platforms I think) in that the
  55337. mouse wheel events we get have a much higher acceleration factor.
  55338. This submit switches over to scroll-per-pixel from scroll-per-line
  55339. for most of our scrolling views. This matches the native views
  55340. and works well with the increased acceleration.
  55341. * platform/qt/WheelEventQt.cpp:
  55342. 2008-11-09 Cameron Zwarich <zwarich@apple.com>
  55343. Reviewed by Darin Adler.
  55344. Bug 19541: Null pointer in showModalDialog()
  55345. <https://bugs.webkit.org/show_bug.cgi?id=19541>
  55346. Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
  55347. and JSDOMWindowBase::canShowModalDialogNow()C
  55348. * bindings/js/JSDOMWindowBase.cpp:
  55349. (WebCore::canShowModalDialog):
  55350. (WebCore::canShowModalDialogNow):
  55351. 2008-11-09 Darin Adler <darin@apple.com>
  55352. - try to fix Windows build
  55353. * platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules
  55354. about needed a separate definition for static const integer data members.
  55355. Until I get to the bottom of this, put the definitions inside an ifdef.
  55356. 2008-11-09 David Kilzer <ddkilzer@apple.com>
  55357. BUILD FIX: Qt build broke after r38235.
  55358. Added HAVE(ACCESSIBILITY) header guards to platform implementation
  55359. source files.
  55360. * page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY)
  55361. guards.
  55362. * page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
  55363. * page/qt/AccessibilityObjectQt.cpp: Ditto.
  55364. * page/win/AccessibilityObjectWin.cpp: Ditto.
  55365. * page/wx/AccessibilityObjectWx.cpp: Ditto.
  55366. 2008-11-09 Alexey Proskuryakov <ap@webkit.org>
  55367. Reviewed by Darin Adler.
  55368. https://bugs.webkit.org/show_bug.cgi?id=22104
  55369. Javascript URL percent encoding/decoding broken by some characters
  55370. Test: fast/loader/javascript-url-encoding-2.html
  55371. * platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
  55372. 2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>
  55373. Reviewed and tweaked by Darin Adler.
  55374. * platform/graphics/Color.cpp: Added definitions for the static data members
  55375. in this class. Static data members need a definition, even when they are the
  55376. simple integer constant kind that can be initialized in the header.
  55377. 2008-11-08 Antti Koivisto <antti@apple.com>
  55378. Reviewed by Sam Weinig.
  55379. Fix https://bugs.webkit.org/show_bug.cgi?id=22141
  55380. REGRESSION: Safari error page is not fully styled when loaded from cache
  55381. Reset text decoder on flush so it does not pass through the BOM when it is reused.
  55382. Test: fast/encoding/css-cached-bom.html
  55383. * loader/TextResourceDecoder.cpp:
  55384. (WebCore::TextResourceDecoder::flush):
  55385. 2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
  55386. Reviewed by Mark Rowe.
  55387. Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
  55388. it was causing these errors to end up in the page's text representation.
  55389. * platform/network/curl/ResourceHandleManager.cpp:
  55390. (WebCore::ResourceHandleManager::downloadTimerCallback):
  55391. 2008-11-08 Kevin Ollivier <kevino@theolliviers.com>
  55392. wx build fixes after addition of JSCore parser and bycompiler dirs.
  55393. * webcore-base.bkl:
  55394. * webcore-wx.bkl:
  55395. 2008-11-08 Simon Fraser <simon.fraser@apple.com>
  55396. Reviewed by Dan Bernstein
  55397. https://bugs.webkit.org/show_bug.cgi?id=21906
  55398. Override addFocusRingRects() in RenderTextControl to avoid
  55399. the RenderFlow behavior of recursing on descendent renderers.
  55400. RenderTextControl should only ever need a simple focus rect.
  55401. This fixes focus ring issues with transforms on text controls.
  55402. Test: fast/transforms/transformed-focused-text-input.html
  55403. * rendering/RenderTextControl.cpp:
  55404. (WebCore::RenderTextControl::addFocusRingRects):
  55405. * rendering/RenderTextControl.h:
  55406. 2008-11-08 Dimitri Dupuis-Latour <dupuislatour@apple.com>
  55407. Make sure the icon thumbnail width/height is at least 1px in
  55408. the Web Inspector's resource panel.
  55409. <rdar://problem/5988888>
  55410. Reviewed by Tim Hatcher.
  55411. * inspector/front-end/inspector.css:
  55412. 2008-11-08 David Kilzer <ddkilzer@apple.com>
  55413. Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled
  55414. <https://bugs.webkit.org/show_bug.cgi?id=22137>
  55415. Reviewed by Darin Adler.
  55416. * page/AccessibilityObject.h:
  55417. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  55418. Provide a default implementation when HAVE(ACCESSIBILITY) is false.
  55419. * page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
  55420. * page/mac/AccessibilityObjectMac.mm: Ditto.
  55421. * page/mac/AccessibilityObjectWrapper.mm: Ditto.
  55422. 2008-11-08 Dan Bernstein <mitz@apple.com>
  55423. Reviewed by Darin Adler.
  55424. - WebCore part of adding WebPreferences for controlling databases and local storage
  55425. * WebCore.base.exp: Exported Settings::setDatabasesEnabled() and
  55426. Settings::setLocalStorageEnabled().
  55427. * page/DOMWindow.cpp:
  55428. (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage
  55429. is disabled in settings.
  55430. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases
  55431. are disabled in settings.
  55432. * page/Settings.cpp:
  55433. (WebCore::Settings::Settings): Initialize m_databasesEnabled and
  55434. m_localStorageEnabled.
  55435. (WebCore::Settings::setDatabasesEnabled): Added.
  55436. (WebCore::Settings::setLocalStorageEnabled): Added.
  55437. * page/Settings.h:
  55438. (WebCore::Settings::databasesEnabled): Added.
  55439. (WebCore::Settings::localStorageEnabled): Added.
  55440. 2008-11-07 Alp Toker <alp@nuanti.com>
  55441. Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
  55442. now require that only their top-level header file is included.
  55443. Patch tested and still builds fine with older GTK+ versions (back to
  55444. 2.8).
  55445. Future WebKit GTK+ contributions are required to adhere to this
  55446. policy.
  55447. * platform/gtk/FileSystemGtk.cpp:
  55448. * platform/gtk/KeyEventGtk.cpp:
  55449. * platform/gtk/MouseEventGtk.cpp:
  55450. * platform/gtk/WheelEventGtk.cpp:
  55451. * platform/gtk/gtkdrawing.h:
  55452. * plugins/gtk/gtk2xtbin.c:
  55453. * plugins/gtk/gtk2xtbin.h:
  55454. 2008-11-07 Anders Carlsson <andersca@apple.com>
  55455. Reviewed by Kevin Decker
  55456. Explicitly initialize the NPDrawingModelCoreAnimation.
  55457. * bridge/npapi.h:
  55458. 2008-11-07 Alp Toker <alp@nuanti.com>
  55459. autotools fix. Always use the configured perl binary (which may be
  55460. different to the one in $PATH) when generating sources.
  55461. * GNUmakefile.am:
  55462. 2008-11-07 Simon Fraser <simon.fraser@apple.com>
  55463. Reviewed by Dan Bernstein
  55464. https://bugs.webkit.org/show_bug.cgi?id=22122
  55465. Use a stack-based object to simplify the pushLayoutState/popLayoutState
  55466. code. LayoutStateMaintainer either pushes in the constructor, or allows
  55467. an explicit push() later. Both cases require an explicit pop().
  55468. * rendering/RenderBlock.cpp:
  55469. (WebCore::RenderBlock::layoutBlock):
  55470. (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  55471. * rendering/RenderContainer.cpp:
  55472. (WebCore::RenderContainer::layout):
  55473. * rendering/RenderFlexibleBox.cpp:
  55474. (WebCore::RenderFlexibleBox::layoutBlock):
  55475. * rendering/RenderTable.cpp:
  55476. (WebCore::RenderTable::layout):
  55477. * rendering/RenderTableRow.cpp:
  55478. (WebCore::RenderTableRow::layout):
  55479. * rendering/RenderTableSection.cpp:
  55480. (WebCore::RenderTableSection::setCellWidths):
  55481. (WebCore::RenderTableSection::calcRowHeight):
  55482. (WebCore::RenderTableSection::layoutRows):
  55483. * rendering/RenderView.h:
  55484. (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
  55485. (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
  55486. (WebCore::LayoutStateMaintainer::pop):
  55487. (WebCore::LayoutStateMaintainer::push):
  55488. (WebCore::LayoutStateMaintainer::didPush):
  55489. 2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
  55490. Fix the QtWebKit build on Mac
  55491. * platform/qt/TemporaryLinkStubs.cpp:
  55492. (PluginView::invalidateRect):
  55493. 2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
  55494. Rubber-stamped by Simon Hausmann.
  55495. Don't allow Phonon's invisible video widget to keep the app running
  55496. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  55497. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
  55498. 2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>
  55499. Reviewed by Simon Hausmann.
  55500. Fix valgrind warning about uninitialized lastStop variable.
  55501. * platform/graphics/qt/GradientQt.cpp:
  55502. (WebCore::Gradient::platformGradient):
  55503. 2008-11-07 Alexey Proskuryakov <ap@webkit.org>
  55504. Reviewed by Maciej Stachowiak.
  55505. Fix layout test brokenness following r38211.
  55506. * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
  55507. Restore old Shift key behavior. We ignore Shift key state when matching access keys (which
  55508. matches neither IE nor Firefox), and this patch made WebKit behave like Firefox
  55509. inadvertently. This may or may not be a good thing, but it's certainly not something that
  55510. should change by accident.
  55511. 2008-11-06 Antti Koivisto <antti@apple.com>
  55512. Eh, this trivial last minute change was wrong.
  55513. * loader/CachedCSSStyleSheet.cpp:
  55514. (WebCore::CachedCSSStyleSheet::sheetText):
  55515. 2008-11-06 Antti Koivisto <antti@apple.com>
  55516. Reviewed by Dan Bernstein.
  55517. https://bugs.webkit.org/show_bug.cgi?id=22093
  55518. Delaying the text decoding caused regression since the decoding
  55519. also determines the encoding in case of @charset rule.
  55520. Decode immediately in data() and keep the decoded string around
  55521. during the checkNotify().
  55522. * loader/CachedCSSStyleSheet.cpp:
  55523. (WebCore::CachedCSSStyleSheet::sheetText):
  55524. (WebCore::CachedCSSStyleSheet::data):
  55525. * loader/CachedCSSStyleSheet.h:
  55526. 2008-11-06 Alexey Proskuryakov <ap@webkit.org>
  55527. Reviewed by Darin Adler.
  55528. https://bugs.webkit.org/show_bug.cgi?id=22097
  55529. Expose MessageEvent constructor on WorkerContext
  55530. * bindings/js/JSWorkerContext.cpp:
  55531. (WebCore::jsWorkerContextMessageEvent):
  55532. (WebCore::setJSWorkerContextMessageEvent):
  55533. 2008-11-06 Alexey Proskuryakov <ap@webkit.org>
  55534. Reviewed by Darin Adler.
  55535. https://bugs.webkit.org/show_bug.cgi?id=21107
  55536. <rdar://problem/6264219> New access key combination conflicts with VoiceOver
  55537. * page/EventHandler.h:
  55538. * page/gtk/EventHandlerGtk.cpp:
  55539. (WebCore::EventHandler::accessKeyModifiers):
  55540. * page/qt/EventHandlerQt.cpp:
  55541. (WebCore::EventHandler::accessKeyModifiers):
  55542. * page/win/EventHandlerWin.cpp:
  55543. (WebCore::EventHandler::accessKeyModifiers):
  55544. * page/wx/EventHandlerWx.cpp:
  55545. (WebCore::EventHandler::accessKeyModifiers):
  55546. Access access key modifiers via a function, not a static variable.
  55547. * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers):
  55548. Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is
  55549. less troublesome than one with VO keys.
  55550. * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
  55551. Also fix an access key matching bug introduced in r32424 - Any superset of specified
  55552. modifier set invoked access keys. We can use simple equality comparison instead because
  55553. CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
  55554. 2008-11-06 Anders Carlsson <andersca@apple.com>
  55555. Reviewed by Kevin Decker.
  55556. https://bugs.webkit.org/show_bug.cgi?id=22115
  55557. NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
  55558. Export _NPN_HasMethod and _NPN_HasProperty.
  55559. * WebCore.NPAPI.exp:
  55560. 2008-11-06 Simon Fraser <simon.fraser@apple.com>
  55561. Reviewed by Antti Koivisto
  55562. https://bugs.webkit.org/show_bug.cgi?id=15678
  55563. Fix transformed menu selects to show the popup in the correct
  55564. location.
  55565. * rendering/RenderMenuList.cpp:
  55566. (WebCore::RenderMenuList::showPopup):
  55567. 2008-11-06 David Kilzer <ddkilzer@apple.com>
  55568. BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
  55569. Apparently older versions of gcc have issues with this patch.
  55570. Backing out a second time until the issues are resolved.
  55571. 2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>
  55572. Reviewed by Maciej Stachowiak.
  55573. Bug 21106: .in format discussed changes
  55574. https://bugs.webkit.org/show_bug.cgi?id=21106
  55575. Include the namespace into the interfaceName.
  55576. * dom/make_names.pl: Do not append the namespace when
  55577. using the interfaceName.
  55578. * html/HTMLTagNames.in: Added namespace prefix for custom
  55579. interfaceName.
  55580. * svg/svgtags.in: Ditto.
  55581. 2008-11-06 Cameron Zwarich <zwarich@apple.com>
  55582. Reviewed by Geoff Garen.
  55583. Move the remaining files in the kjs subdirectory of JavaScriptCore to
  55584. a new parser subdirectory, and remove the kjs subdirectory entirely.
  55585. * ForwardingHeaders/kjs: Removed.
  55586. * ForwardingHeaders/kjs/Parser.h: Removed.
  55587. * ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  55588. * ForwardingHeaders/kjs/SourceCode.h: Removed.
  55589. * ForwardingHeaders/kjs/SourceProvider.h: Removed.
  55590. * ForwardingHeaders/parser: Added.
  55591. * ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  55592. * ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  55593. * ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  55594. * WebCore.pro:
  55595. * WebCore.vcproj/WebCore.vcproj:
  55596. * bindings/js/StringSourceProvider.h:
  55597. * bindings/js/WorkerScriptController.cpp:
  55598. * bridge/NP_jsobject.cpp:
  55599. * bridge/jni/jni_jsobject.mm:
  55600. * bridge/testbindings.pro:
  55601. * inspector/JavaScriptDebugServer.cpp:
  55602. 2008-11-06 David Kilzer <ddkilzer@apple.com>
  55603. BUILD WAS NOT BROKEN: Rolling r38189 back in.
  55604. Please perform a clean build if you see crashes.
  55605. 2008-11-06 David Kilzer <ddkilzer@apple.com>
  55606. BUILD FIX: Backed out r38189 since it apparently broke the world.
  55607. 2008-11-06 Chris Fleizach <cfleizach@apple.com>
  55608. Reviewed by Beth Dakin.
  55609. Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
  55610. https://bugs.webkit.org/show_bug.cgi?id=22112
  55611. Test: accessibility/content-editable.html
  55612. * page/AccessibilityRenderObject.cpp:
  55613. (WebCore::AccessibilityRenderObject::isReadOnly):
  55614. 2008-11-06 Sam Weinig <sam@webkit.org>
  55615. Reviewed by Alice Liu.
  55616. Fix failed assert at launch caused by unintialized data member on the mac.
  55617. * platform/network/mac/NetworkStateNotifierMac.cpp:
  55618. (WebCore::NetworkStateNotifier::NetworkStateNotifier):
  55619. 2008-11-06 Steve Falkenburg <sfalken@apple.com>
  55620. Fix failed assert at launch caused by unintialized data member.
  55621. Reviewed by Maciej Stachowiak.
  55622. * platform/network/win/NetworkStateNotifierWin.cpp:
  55623. (WebCore::NetworkStateNotifier::NetworkStateNotifier):
  55624. 2008-11-06 Simon Fraser <simon.fraser@apple.com>
  55625. Reviewed by Antti Koivisto
  55626. https://bugs.webkit.org/show_bug.cgi?id=22109
  55627. Make <input type="range"> work correctly with transforms
  55628. Test: fast/forms/slider-transformed.html
  55629. * html/HTMLInputElement.cpp:
  55630. (WebCore::HTMLInputElement::defaultEventHandler):
  55631. Compute a correct local point when the event is retargeted
  55632. * rendering/RenderSlider.cpp:
  55633. (WebCore::HTMLSliderThumbElement::defaultEventHandler):
  55634. Compute m_initialClickPoint in slider-local coords, so that
  55635. deltas are computed correctly with transforms
  55636. (WebCore::RenderSlider::mouseEventIsInThumb):
  55637. Rather than computing an absolute bounds for the thumb,
  55638. convert the point to local coords and compare it with the border box.
  55639. 2008-11-06 Greg Bolsinga <bolsinga@apple.com>
  55640. Reviewed by Darin Adler.
  55641. Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
  55642. https://bugs.webkit.org/show_bug.cgi?id=21810
  55643. * bindings/js/GCController.cpp:
  55644. (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
  55645. * bindings/js/JSDOMBinding.cpp:
  55646. (WebCore::wrapperSet): Ditto
  55647. * bindings/js/JSInspectedObjectWrapper.cpp:
  55648. (WebCore::wrappers): Ditto
  55649. * bindings/js/JSInspectorCallbackWrapper.cpp:
  55650. (WebCore::wrappers): Ditto
  55651. * bridge/runtime_root.cpp:
  55652. (JSC::Bindings::rootObjectSet): Ditto
  55653. * css/CSSMutableStyleDeclaration.cpp:
  55654. (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
  55655. * css/CSSPrimitiveValue.cpp:
  55656. (WebCore::CSSPrimitiveValue::cssText): Ditto
  55657. * css/CSSSelector.cpp:
  55658. (WebCore::CSSSelector::extractPseudoType): Ditto
  55659. * css/CSSStyleSelector.cpp:
  55660. (WebCore::screenEval): Ditto
  55661. (WebCore::printEval): Ditto
  55662. * dom/DOMImplementation.cpp:
  55663. (WebCore::isSVG10Feature): Ditto
  55664. (WebCore::isSVG11Feature): Ditto
  55665. (WebCore::DOMImplementation::isXMLMIMEType): Ditto
  55666. * dom/Document.cpp:
  55667. (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
  55668. * dom/ScriptElement.cpp:
  55669. (WebCore::isSupportedJavaScriptLanguage): Ditto
  55670. * editing/ApplyStyleCommand.cpp:
  55671. (WebCore::styleSpanClassString): Ditto
  55672. * editing/HTMLInterchange.cpp:
  55673. (WebCore::): Ditto
  55674. * editing/IndentOutdentCommand.cpp:
  55675. (WebCore::indentBlockquoteString): Ditto
  55676. * editing/ReplaceSelectionCommand.cpp:
  55677. (WebCore::isInterchangeNewlineNode): Ditto
  55678. (WebCore::isInterchangeConvertedSpaceSpan): Ditto
  55679. * editing/htmlediting.cpp:
  55680. (WebCore::stringWithRebalancedWhitespace): Ditto
  55681. (WebCore::nonBreakingSpaceString): Ditto
  55682. * editing/markup.cpp:
  55683. (WebCore::appendAttributeValue): Ditto
  55684. (WebCore::appendEscapedContent): Ditto
  55685. (WebCore::shouldAddNamespaceAttr): Ditto
  55686. (WebCore::appendNamespace): Ditto
  55687. (WebCore::appendStartMarkup): Ditto
  55688. (WebCore::createMarkup): Ditto
  55689. * html/HTMLButtonElement.cpp:
  55690. (WebCore::HTMLButtonElement::type): Ditto
  55691. * html/HTMLElement.cpp:
  55692. (WebCore::HTMLElement::isRecognizedTagName): Ditto
  55693. (WebCore::inlineTagList): Ditto
  55694. (WebCore::blockTagList): Ditto
  55695. * html/HTMLFieldSetElement.cpp:
  55696. (WebCore::HTMLFieldSetElement::type): Ditto
  55697. * html/HTMLInputElement.cpp:
  55698. (WebCore::HTMLInputElement::type): Ditto
  55699. * html/HTMLKeygenElement.cpp:
  55700. (WebCore::HTMLKeygenElement::type): Ditto
  55701. * html/HTMLLegendElement.cpp:
  55702. (WebCore::HTMLLegendElement::type): Ditto
  55703. * html/HTMLOptGroupElement.cpp:
  55704. (WebCore::HTMLOptGroupElement::type): Ditto
  55705. * html/HTMLOptionElement.cpp:
  55706. (WebCore::HTMLOptionElement::type): Ditto
  55707. * html/HTMLParser.cpp:
  55708. (WebCore::HTMLParser::getNode): Ditto
  55709. (WebCore::HTMLParser::isHeaderTag): Ditto
  55710. (WebCore::HTMLParser::isResidualStyleTag): Ditto
  55711. (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
  55712. * html/HTMLSelectElement.cpp:
  55713. (WebCore::HTMLSelectElement::type): Ditto
  55714. * html/HTMLTextAreaElement.cpp:
  55715. (WebCore::HTMLTextAreaElement::type): Ditto
  55716. * inspector/InspectorController.cpp:
  55717. (WebCore::platform): Ditto
  55718. * inspector/JavaScriptDebugServer.cpp:
  55719. (WebCore::JavaScriptDebugServer::shared): Ditto
  55720. * inspector/JavaScriptProfile.cpp:
  55721. (WebCore::profileCache): Ditto
  55722. * inspector/JavaScriptProfileNode.cpp:
  55723. (WebCore::profileNodeCache): Ditto
  55724. * loader/FrameLoader.cpp:
  55725. (WebCore::localSchemes): Ditto
  55726. * loader/appcache/ApplicationCacheStorage.cpp:
  55727. (WebCore::cacheStorage): Ditto
  55728. * loader/archive/ArchiveFactory.cpp:
  55729. (WebCore::archiveMIMETypes): Ditto
  55730. * loader/icon/IconDatabase.cpp:
  55731. (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
  55732. * page/EventHandler.cpp:
  55733. (WebCore::EventHandler::dragState): Ditto
  55734. * page/Frame.cpp:
  55735. (WebCore::createRegExpForLabels): Ditto
  55736. (WebCore::keepAliveSet): Ditto
  55737. * page/Page.cpp:
  55738. (WebCore::Page::groupName): Ditto
  55739. * page/SecurityOrigin.cpp:
  55740. (WebCore::isDefaultPortForProtocol): Ditto
  55741. (WebCore::SecurityOrigin::databaseIdentifier): Ditto
  55742. * page/mac/FrameMac.mm:
  55743. (WebCore::regExpForLabels): Ditto
  55744. * platform/KURL.cpp:
  55745. (WebCore::blankURL): Ditto
  55746. * platform/graphics/FontCache.cpp:
  55747. (WebCore::alternateFamilyName): Ditto
  55748. * platform/graphics/mac/FontCacheMac.mm:
  55749. (WebCore::FontCache::getSimilarFontPlatformData): Ditto
  55750. (WebCore::FontCache::getLastResortFallbackFont): Ditto
  55751. * platform/mac/ScrollbarThemeMac.mm:
  55752. (WebCore::ScrollbarTheme::nativeTheme): Ditto
  55753. * platform/mac/ThemeMac.mm:
  55754. (WebCore::platformTheme): Ditto
  55755. * platform/mac/ThreadCheck.mm:
  55756. (WebCoreReportThreadViolation): Ditto
  55757. * platform/network/NetworkStateNotifier.cpp:
  55758. (WebCore::networkStateNotifier): Ditto
  55759. * platform/network/mac/FormDataStreamMac.mm:
  55760. (WebCore::getStreamFormDataMap): Ditto
  55761. (WebCore::getStreamResourceHandleMap): Ditto
  55762. * platform/network/mac/ResourceResponseMac.mm:
  55763. (WebCore::ResourceResponse::platformLazyInit): Ditto
  55764. * platform/text/TextEncoding.cpp:
  55765. (WebCore::TextEncoding::isJapanese): Ditto
  55766. * rendering/RenderBlock.cpp:
  55767. (WebCore::continuationOutlineTable): Ditto
  55768. * rendering/RenderCounter.cpp:
  55769. (WebCore::counterMaps): Ditto
  55770. * rendering/RenderFlexibleBox.cpp:
  55771. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
  55772. * rendering/RenderListItem.cpp:
  55773. (WebCore::RenderListItem::markerText): Ditto
  55774. * rendering/RenderScrollbarTheme.cpp:
  55775. (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
  55776. * rendering/RenderThemeMac.mm:
  55777. (WebCore::RenderThemeMac::systemFont): Ditto
  55778. * rendering/bidi.cpp:
  55779. (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
  55780. * rendering/style/RenderStyle.cpp:
  55781. (WebCore::RenderStyle::initialDashboardRegions): Ditto
  55782. (WebCore::RenderStyle::noneDashboardRegions): Ditto
  55783. * storage/LocalStorage.cpp:
  55784. (WebCore::localStorageMap): Ditto
  55785. * svg/SVGAnimateMotionElement.cpp:
  55786. (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
  55787. * svg/SVGAnimationElement.cpp:
  55788. (WebCore::SVGAnimationElement::calcMode): Ditto
  55789. (WebCore::SVGAnimationElement::attributeType): Ditto
  55790. (WebCore::SVGAnimationElement::isAdditive): Ditto
  55791. (WebCore::SVGAnimationElement::isAccumulated): Ditto
  55792. * svg/SVGLangSpace.cpp:
  55793. (WebCore::SVGLangSpace::xmlspace): Ditto
  55794. * svg/SVGSVGElement.cpp:
  55795. (WebCore::SVGSVGElement::contentScriptType): Ditto
  55796. (WebCore::SVGSVGElement::contentStyleType): Ditto
  55797. * svg/SVGStyleElement.cpp:
  55798. (WebCore::SVGStyleElement::type): Ditto
  55799. (WebCore::SVGStyleElement::media): Ditto
  55800. * svg/SVGTextContentElement.cpp:
  55801. (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
  55802. * svg/animation/SVGSMILElement.cpp:
  55803. (WebCore::SVGSMILElement::parseClockValue): Ditto
  55804. (WebCore::SVGSMILElement::restart): Ditto
  55805. (WebCore::SVGSMILElement::fill): Ditto
  55806. (WebCore::SVGSMILElement::repeatCount): Ditto
  55807. (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
  55808. * svg/graphics/SVGResource.cpp:
  55809. (WebCore::clientMap): Ditto
  55810. * svg/graphics/SVGResourceMarker.cpp:
  55811. (WebCore::SVGResourceMarker::draw): Ditto
  55812. * xml/XMLHttpRequest.cpp:
  55813. (WebCore::preflightResultCache): Ditto
  55814. (WebCore::isSafeRequestHeader): Ditto
  55815. (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
  55816. * xml/XPathExpressionNode.cpp:
  55817. (WebCore::XPath::Expression::evaluationContext): Ditto
  55818. * xml/XPathParser.cpp:
  55819. (WebCore::XPath::isAxisName): Ditto
  55820. (WebCore::XPath::isNodeTypeName): Ditto
  55821. * xml/XPathValue.cpp:
  55822. (WebCore::XPath::Value::toNodeSet): Ditto
  55823. 2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
  55824. Rubber-stamped by Simon Hausmann.
  55825. Remove a bunch of unused methods in the Qt media element implementation
  55826. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  55827. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
  55828. * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  55829. 2008-11-05 Simon Fraser <simon.fraser@apple.com>
  55830. Reviewed by Dave Hyatt
  55831. https://bugs.webkit.org/show_bug.cgi?id=21870
  55832. Implement absoluteToLocal() to convert a point from absolute
  55833. to local coordinates, optionally taking transforms into account.
  55834. Use this to set offsetX/offsetY in mouse events, thus fixing
  55835. offsetX/offsetY in events on elements with transforms.
  55836. Test: fast/events/offsetX-offsetY.html
  55837. * dom/MouseRelatedEvent.cpp:
  55838. (WebCore::MouseRelatedEvent::receivedTarget):
  55839. * rendering/RenderBox.cpp:
  55840. (WebCore::RenderBox::localToAbsolute):
  55841. (WebCore::RenderBox::absoluteToLocal):
  55842. (WebCore::RenderBox::offsetFromContainer):
  55843. * rendering/RenderBox.h:
  55844. * rendering/RenderObject.cpp:
  55845. (WebCore::RenderObject::absoluteToLocal):
  55846. * rendering/RenderObject.h:
  55847. * rendering/RenderTableCell.cpp:
  55848. (WebCore::RenderTableCell::localToAbsolute):
  55849. (WebCore::RenderTableCell::absoluteToLocal):
  55850. * rendering/RenderTableCell.h:
  55851. * rendering/RenderView.cpp:
  55852. (WebCore::RenderView::absoluteToLocal):
  55853. * rendering/RenderView.h:
  55854. 2008-11-06 Alp Toker <alp@nuanti.com>
  55855. Reviewed by Cameron Zwarich.
  55856. https://bugs.webkit.org/show_bug.cgi?id=22067
  55857. [GTK] Sun Java plugin segfaults at PluginPackage::createPackage()
  55858. null-check symbols loaded from plugin modules, initialize the function
  55859. table (like Win already does) and update it with the latest
  55860. additions. Adjust whitespace for easy diff'ing with the Win port code
  55861. from which it was forked.
  55862. This fixes crashes with libnspr4.so and any other plugins that don't
  55863. provide the symbols we expect.
  55864. * plugins/gtk/PluginPackageGtk.cpp:
  55865. (WebCore::PluginPackage::fetchInfo):
  55866. (WebCore::PluginPackage::load):
  55867. 2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
  55868. Reviewed by Simon Hausmann.
  55869. Removed dead (and broken) code from an ancient Symbian port.
  55870. * config.h:
  55871. * platform/text/AtomicString.h:
  55872. * platform/text/PlatformString.h:
  55873. 2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
  55874. Reviewed by Simon Hausmann.
  55875. Use QLibrary as PlatformModule when compiling with Qt for S60.
  55876. * platform/FileSystem.h:
  55877. 2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
  55878. Reviewed by Simon Hausmann.
  55879. Compile fix for Symbian.
  55880. The snprintf function is defined in stdio.h, the inclusion
  55881. of snprintf.h inside this PLATFORM(SYMBIAN) block does not
  55882. compile.
  55883. * config.h:
  55884. 2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
  55885. Reviewed by Simon Hausmann.
  55886. Disable webkit plugins for Symbian.
  55887. * WebCore.pro:
  55888. 2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
  55889. Fix build break in debug mode when XSLT is not enabled
  55890. * loader/Cache.cpp:
  55891. (WebCore::Cache::dumpStats):
  55892. 2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
  55893. Reviewed by Simon Hausmann.
  55894. Repaint video on UpdateRequest to prevent recursive painting
  55895. Calling QWidget::render() to update the video generates a paint
  55896. event that's then picked up by the event filter once more :(
  55897. We're really only interested in updates from Phonon, which we
  55898. get through the UpdateRequest for each new frame.
  55899. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  55900. (WebCore::MediaPlayerPrivate::eventFilter):
  55901. 2008-11-06 Cameron Zwarich <zwarich@apple.com>
  55902. Not reviewed.
  55903. Fix the WebCore build for some platforms by changing build scripts to
  55904. account for the recent move of the create_hash_table script from the kjs
  55905. subdirectory of JavaScriptCore to the root directory.
  55906. * WebCore.pro:
  55907. * make-generated-sources.sh:
  55908. 2008-11-06 Cameron Zwarich <zwarich@apple.com>
  55909. Not reviewed.
  55910. Fix a case-sensitivity issue in Mac forwarding headers. Strangely
  55911. enough, this does not always cause the build to break, even with a
  55912. case-sensitive filesystem.
  55913. * ForwardingHeaders/runtime/Interpreter.h:
  55914. 2008-11-05 Alexey Proskuryakov <ap@webkit.org>
  55915. Reviewed by Maciej Stachowiak.
  55916. https://bugs.webkit.org/show_bug.cgi?id=22083
  55917. MessageEvents cannot be used across threads
  55918. * dom/Event.idl:
  55919. * dom/MessageEvent.idl:
  55920. Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables
  55921. won't work.
  55922. * dom/MessagePort.cpp:
  55923. (WebCore::MessagePort::EventData::EventData):
  55924. (WebCore::MessagePort::EventData::~EventData):
  55925. (WebCore::MessagePort::clone):
  55926. (WebCore::MessagePort::postMessage):
  55927. (WebCore::MessagePort::startConversation):
  55928. (WebCore::MessagePort::dispatchMessages):
  55929. * dom/MessagePort.h:
  55930. Don't create a MessageEvent until dispatch time - messages can be posted across threads,
  55931. but MessageEvents are tied to the thread that they were created in.
  55932. 2008-11-05 Alexey Proskuryakov <ap@webkit.org>
  55933. Reviewed by Darin Adler.
  55934. https://bugs.webkit.org/show_bug.cgi?id=22066
  55935. Implement Worker global object
  55936. * DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.
  55937. * WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker
  55938. support is still disabled by default.
  55939. * bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.
  55940. * bindings/js/JSMessageChannelConstructor.cpp:
  55941. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.
  55942. * bindings/js/JSWorkerContext.cpp: Added.
  55943. * bindings/js/JSWorkerContext.h: Added.
  55944. * bindings/js/WorkerScriptController.cpp: Added.
  55945. * bindings/js/WorkerScriptController.h: Added.
  55946. * dom/WorkerContext.cpp: Added.
  55947. * dom/WorkerContext.h: Added.
  55948. Added an implementation of worker contexts.
  55949. * dom/DedicatedWorker.cpp:
  55950. (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests.
  55951. (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership
  55952. and lifetime is not clear at all.
  55953. * dom/WorkerLocation.cpp: Added.
  55954. * dom/WorkerLocation.h: Added.
  55955. * dom/WorkerLocation.idl: Added.
  55956. Added WorkerLocation, which is one of the objects available to workers.
  55957. * dom/WorkerThread.cpp: Added.
  55958. (WebCore::WorkerThread::WorkerThread):
  55959. (WebCore::WorkerThread::start):
  55960. (WebCore::WorkerThread::workerThreadStart):
  55961. (WebCore::WorkerThread::workerThread):
  55962. * dom/WorkerThread.h: Added.
  55963. (WebCore::WorkerThread::create):
  55964. Run some code in a worker thread (no message loop yet).
  55965. 2008-11-05 Antti Koivisto <antti@apple.com>
  55966. Reviewed by Dan Bernstein.
  55967. https://bugs.webkit.org/show_bug.cgi?id=22093
  55968. Don't keep decoded stylesheet data in cache
  55969. <rdar://problem/6343588>
  55970. Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
  55971. performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
  55972. style sheet data in cache by 2/3 in common case.
  55973. * loader/CachedCSSStyleSheet.cpp:
  55974. (WebCore::CachedCSSStyleSheet::sheetText):
  55975. (WebCore::CachedCSSStyleSheet::data):
  55976. * loader/CachedCSSStyleSheet.h:
  55977. 2008-11-05 David Kilzer <ddkilzer@apple.com>
  55978. Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers
  55979. <https://bugs.webkit.org/show_bug.cgi?id=21596>
  55980. Reviewed by Antti.
  55981. This patch adds real parsing for Pragma and Cache-Control headers
  55982. based on RFC 2616, Sections 2, 14.9 and 14.32. It also adds some
  55983. new String and StringImpl methods to assist with the parsing.
  55984. * loader/Cache.cpp:
  55985. (WebCore::Cache::dumpStats): Added. Convenience method for dumping
  55986. stats outside of Safari.
  55987. * loader/Cache.h: Declared dumpStats().
  55988. * loader/CachedResource.cpp:
  55989. (WebCore::CachedResource::mustRevalidate): Updated to use
  55990. ResourceResponseBase::cacheControlDirectives() instead of substring
  55991. matching of the entire Cache-Control header.
  55992. * loader/loader.cpp:
  55993. (WebCore::Loader::Host::didReceiveResponse): Used the local
  55994. 'resource' variable instead of 'request->cachedResource()'.
  55995. * platform/network/ResourceResponseBase.cpp:
  55996. (WebCore::ResourceResponseBase::setHTTPHeaderField): Set
  55997. m_haveParsedCacheControlHeader to false when a "Cache-Control"
  55998. header is set. Ditto for m_haveParsedPragmaHeader and "Pragma".
  55999. (WebCore::ResourceResponseBase::parsePragmaDirectives): Added.
  56000. Provides parsed Pragma header directives.
  56001. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added.
  56002. Provides parsed Cache-Control header directives.
  56003. (WebCore::isCacheHeaderSeparator): Added. Returns true if a
  56004. character is a separator character per RFC 2616, Section 2.2, else
  56005. returns false.
  56006. (WebCore::isControlCharacter): Added. Returns true if a character
  56007. is a control character per RFC 2616 Section 2.2, else returns false.
  56008. (WebCore::trimToNextSeparator): Added. Returns a string truncated
  56009. at the first separator character per isCacheHeaderSeparator().
  56010. (WebCore::parseCacheHeader): Added. This is the main parsing
  56011. routine for both Cache-Control and Pragma headers.
  56012. (WebCore::parseCacheControlDirectiveValues): Added. This splits
  56013. certain Cache-Control directive values into a vector of strings.
  56014. * platform/network/ResourceResponseBase.h:
  56015. (WebCore::CacheControlDirectiveMap): Added. Typedef for a parsed
  56016. Cache-Control header.
  56017. (WebCore::PragmaDirectiveMap): Added. Typedef for a parsed Pragma
  56018. header.
  56019. (WebCore::ResourceResponseBase::parsePragmaDirectives): Added
  56020. declaration.
  56021. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto.
  56022. (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader):
  56023. Added. Boolean to describe when the "Cache-Control" header needs to
  56024. be reparsed.
  56025. (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader): Added.
  56026. Boolean to describe when the "Pragma" header needs to be reparsed.
  56027. (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added.
  56028. Cached map to hold parsed "Cache-Control" headers.
  56029. (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added.
  56030. Cached map to hold parsed "Pragma" headers.
  56031. * platform/text/PlatformString.h:
  56032. (WebCore::String::find): Added. Returns the first match based on
  56033. the character-matching function pointer passed in.
  56034. (WebCore::String::removeCharacters): Added declaration.
  56035. (WebCore::find): Added. Inline method that takes a character-
  56036. matching function pointer. Called by StringImpl::find().
  56037. * platform/text/String.cpp:
  56038. (WebCore::String::removeCharacters): Added. Calls
  56039. StringImpl::removeCharacters().
  56040. * platform/text/StringImpl.cpp:
  56041. (WebCore::StringImpl::removeCharacters): Added. Returns a string
  56042. with all characters removed that match the character-matching
  56043. function pointer passed in. If there is no change to the string, it
  56044. returns itself. Based heavily on StringImpl::simplifyWhitespace().
  56045. (WebCore::StringImpl::find): Added. Calls WebCore::find().
  56046. * platform/text/StringImpl.h:
  56047. (WebCore::FindMatchFunctionPtr): Added. Typedef for a character-
  56048. matching function pointer.
  56049. (WebCore::StringImpl::removeCharacters): Added declaration.
  56050. (WebCore::StringImpl::find): Ditto.
  56051. 2008-11-05 Justin Garcia <justin.garcia@apple.com>
  56052. Reviewed by Beth Dakin.
  56053. <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break
  56054. As a rule, we don't allow merges out of blockquotes. In the bug, we are inserting a text node
  56055. between two blockquotes. Because the start merge moves the text node into a blockquote, when we
  56056. determine whether or not we should do the end merge, it incorrectly appears as though the end merge
  56057. is merging out of a blockquote. The fix is to determine whether or not we should do the end merge
  56058. before we do the start merge, so that the start merge doesn't effect our decision.
  56059. * editing/ReplaceSelectionCommand.cpp:
  56060. (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean.
  56061. (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity.
  56062. (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
  56063. * editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.
  56064. 2008-11-05 Cameron Zwarich <zwarich@apple.com>
  56065. Not reviewed.
  56066. Speculatively fix the Windows build, even though these changes may not
  56067. actually matter for anything in the build, because the Windows bots are
  56068. behind.
  56069. * WebCore.vcproj/WebCore.vcproj:
  56070. 2008-11-05 Cameron Zwarich <zwarich@apple.com>
  56071. Not reviewed.
  56072. Fix the Qt build.
  56073. * bridge/qt/qt_class.cpp:
  56074. * bridge/qt/qt_runtime.h:
  56075. 2008-11-05 Cameron Zwarich <zwarich@apple.com>
  56076. Rubber-stamped by Sam Weinig.
  56077. Move more files to the runtime subdirectory of JavaScriptCore.
  56078. * ForwardingHeaders/kjs/collector.h: Removed.
  56079. * ForwardingHeaders/kjs/completion.h: Removed.
  56080. * ForwardingHeaders/kjs/identifier.h: Removed.
  56081. * ForwardingHeaders/kjs/interpreter.h: Removed.
  56082. * ForwardingHeaders/kjs/lookup.h: Removed.
  56083. * ForwardingHeaders/kjs/operations.h: Removed.
  56084. * ForwardingHeaders/kjs/protect.h: Removed.
  56085. * ForwardingHeaders/kjs/ustring.h: Removed.
  56086. * ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
  56087. * ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
  56088. * ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
  56089. * ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
  56090. * ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
  56091. * ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
  56092. * ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
  56093. * ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
  56094. * bindings/js/GCController.cpp:
  56095. * bindings/js/JSCustomPositionCallback.h:
  56096. * bindings/js/JSCustomPositionErrorCallback.h:
  56097. * bindings/js/JSCustomSQLStatementCallback.h:
  56098. * bindings/js/JSCustomSQLStatementErrorCallback.h:
  56099. * bindings/js/JSCustomSQLTransactionErrorCallback.h:
  56100. * bindings/js/JSCustomVoidCallback.h:
  56101. * bindings/js/JSDOMBinding.h:
  56102. * bindings/js/JSDOMWindowBase.h:
  56103. * bindings/js/JSEventListener.h:
  56104. * bindings/js/ScheduledAction.h:
  56105. * bindings/js/ScriptController.cpp:
  56106. * bindings/js/ScriptController.h:
  56107. * bindings/objc/WebScriptObject.mm:
  56108. * bindings/scripts/CodeGeneratorJS.pm:
  56109. * bridge/NP_jsobject.cpp:
  56110. * bridge/c/c_class.cpp:
  56111. * bridge/jni/jni_class.cpp:
  56112. * bridge/jni/jni_jsobject.mm:
  56113. * bridge/npruntime.cpp:
  56114. * bridge/runtime_root.h:
  56115. * history/CachedPage.h:
  56116. * html/CanvasRenderingContext2D.cpp:
  56117. * html/HTMLCanvasElement.cpp:
  56118. * inspector/InspectorController.cpp:
  56119. * inspector/JavaScriptCallFrame.cpp:
  56120. * page/Console.cpp:
  56121. * page/Page.cpp:
  56122. * platform/text/AtomicString.cpp:
  56123. * platform/text/PlatformString.h:
  56124. 2008-11-05 Sam Weinig <sam@webkit.org>
  56125. Reviewed by Anders Carlsson.
  56126. Fix https://bugs.webkit.org/show_bug.cgi?id=22085
  56127. The Plugin JS object should expose item() and namedItem() methods to match Firefox
  56128. * bindings/js/JSPluginCustom.cpp:
  56129. (WebCore::JSPlugin::nameGetter):
  56130. * plugins/Plugin.cpp:
  56131. (WebCore::Plugin::namedItem):
  56132. * plugins/Plugin.h:
  56133. * plugins/Plugin.idl:
  56134. 2008-11-05 Alexey Proskuryakov <ap@webkit.org>
  56135. Reviewed by Maciej Stachowiak.
  56136. https://bugs.webkit.org/show_bug.cgi?id=21060
  56137. Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR
  56138. Test: fast/dom/Range/surroundContents-check-boundary-points.html
  56139. * dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.
  56140. 2008-11-05 Anders Carlsson <andersca@apple.com>
  56141. Reviewed by Dan Bernstein.
  56142. Remove two global destructors from CoreTextController.
  56143. * platform/graphics/mac/CoreTextController.cpp:
  56144. (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
  56145. 2008-11-05 Darin Fisher <darin@chromium.org>
  56146. Reviewed by Darin Adler.
  56147. CRASH at Scrollbar::invalidateRect due to null m_client
  56148. https://bugs.webkit.org/show_bug.cgi?id=22080
  56149. * platform/Scrollbar.cpp:
  56150. (WebCore::Scrollbar::isWindowActive):
  56151. (WebCore::Scrollbar::invalidateRect):
  56152. 2008-11-04 Sam Weinig <sam@webkit.org>
  56153. Reviewed by Simon Hausmann.
  56154. Fix https://bugs.webkit.org/show_bug.cgi?id=21648
  56155. navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS
  56156. - Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.
  56157. * bindings/js/JSMimeTypeArrayCustom.cpp:
  56158. (WebCore::JSMimeTypeArray::nameGetter):
  56159. * bindings/js/JSPluginArrayCustom.cpp:
  56160. (WebCore::JSPluginArray::nameGetter):
  56161. * page/DOMWindow.idl:
  56162. * plugins/MimeType.idl:
  56163. * plugins/MimeTypeArray.cpp:
  56164. (WebCore::MimeTypeArray::namedItem):
  56165. * plugins/MimeTypeArray.h:
  56166. * plugins/MimeTypeArray.idl:
  56167. * plugins/Plugin.idl:
  56168. * plugins/PluginArray.cpp:
  56169. (WebCore::PluginArray::namedItem):
  56170. * plugins/PluginArray.h:
  56171. * plugins/PluginArray.idl:
  56172. 2008-11-05 Steve Falkenburg <sfalken@apple.com>
  56173. Build fix.
  56174. * plugins/PluginPackage.cpp:
  56175. 2008-11-05 Jeff Cook <cookiecaper@gmail.com>
  56176. Reviewed by Simon Hausmann and Tor Arne.
  56177. Fix crash in the Qt port when unloading swfdec and Flash 10
  56178. by reordering window destruction and plugin stop.
  56179. See https://bugs.webkit.org/show_bug.cgi?id=20779
  56180. * plugins/qt/PluginViewQt.cpp:
  56181. (WebCore::PluginView::stop):
  56182. 2008-11-05 Simon Hausmann <hausmann@webkit.org>
  56183. Reviewed by Tor Arne Vestbø
  56184. Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.
  56185. Otherwise Flash refuses to load and function :(
  56186. * plugins/PluginPackage.cpp:
  56187. (WebCore::PluginPackage::determineQuirks):
  56188. * plugins/PluginQuirkSet.h:
  56189. (WebCore::):
  56190. * plugins/qt/PluginViewQt.cpp:
  56191. (WebCore::PluginView::getValue):
  56192. 2008-11-05 Simon Hausmann <hausmann@webkit.org>
  56193. Reviewed by Tor Arne Vestbø
  56194. Unify determineQuirks between the Qt and the Gtk PluginPackage.
  56195. Share the code for parsing the module version from the description.
  56196. This is currently used to determine Flash based quirks.
  56197. * plugins/PluginPackage.cpp:
  56198. (WebCore::PluginPackage::createPackage):
  56199. (WebCore::PluginPackage::determineQuirks):
  56200. (WebCore::PluginPackage::determineModuleVersionFromDescription):
  56201. * plugins/PluginPackage.h:
  56202. * plugins/gtk/PluginPackageGtk.cpp:
  56203. (WebCore::PluginPackage::fetchInfo):
  56204. * plugins/qt/PluginPackageQt.cpp:
  56205. (WebCore::PluginPackage::fetchInfo):
  56206. 2008-11-04 Cameron Zwarich <zwarich@apple.com>
  56207. Rubber-stamped by Sam Weinig.
  56208. Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore.
  56209. * ForwardingHeaders/kjs/dtoa.h: Removed.
  56210. * ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
  56211. * css/CSSParser.cpp:
  56212. * platform/text/String.cpp:
  56213. * platform/text/StringImpl.cpp:
  56214. 2008-11-04 Jonathan Haas <myrdred@gmail.com>
  56215. Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>
  56216. Reviewed by Darin Adler.
  56217. Fixed an issue which could cause memory corruption using ToT libxml.
  56218. See https://bugs.webkit.org/show_bug.cgi?id=15715
  56219. Test: fast/xsl/xslt-nested-stylesheets.xml
  56220. * xml/XSLImportRule.cpp:
  56221. (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
  56222. * xml/XSLStyleSheet.cpp:
  56223. (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet
  56224. (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary
  56225. (WebCore::XSLStyleSheet::setParentStyleSheet): Added
  56226. * xml/XSLStyleSheet.h: Added m_parentStyleSheet member
  56227. 2008-11-04 Simon Fraser <simon.fraser@apple.com>
  56228. No review.
  56229. Improved buid fix: include MathExtras.h to get roundf on all platforms.
  56230. * platform/graphics/FloatPoint.h:
  56231. 2008-11-04 Brady Eidson <beidson@apple.com>
  56232. Reviewed by John Sullivan
  56233. Add a simple "visited" method to HistoryItem for use by global history
  56234. * WebCore.base.exp:
  56235. * history/HistoryItem.cpp:
  56236. (WebCore::HistoryItem::visited): Update the title on the item, set last visited time,
  56237. and bump the visit count. All things that should happen when a url is visited again!
  56238. * history/HistoryItem.h:
  56239. 2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>
  56240. Build fix. Not reviewed.
  56241. * platform/graphics/FloatPoint.h: include math.h.
  56242. reported by zdobersek in #webkit.
  56243. 2008-11-04 Darin Fisher <darin@chromium.org>
  56244. Reviewed by Anders Carlsson.
  56245. No need to clobber all ResourceRequest fields in FrameLoader::reload()
  56246. https://bugs.webkit.org/show_bug.cgi?id=21949
  56247. * loader/FrameLoader.cpp:
  56248. (WebCore::FrameLoader::reload):
  56249. 2008-11-04 Darin Adler <darin@apple.com>
  56250. Reviewed by Tim Hatcher.
  56251. * storage/Database.cpp:
  56252. (WebCore::databaseVersionKey): Tweaked formatting.
  56253. 2008-11-03 Darin Adler <darin@apple.com>
  56254. Reviewed by Tim Hatcher.
  56255. - https://bugs.webkit.org/show_bug.cgi?id=22061
  56256. create script to check for exit-time destructors
  56257. * WebCore.xcodeproj/project.pbxproj: Added a script
  56258. phase that runs the check-for-exit-time-destructors script.
  56259. * html/HTMLAttributeNames.in: Removed some unused attribute names.
  56260. * html/HTMLEmbedElement.cpp:
  56261. (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that
  56262. sets the write-only m_pluginPage.
  56263. * html/HTMLEmbedElement.h: Ditto.
  56264. * platform/mac/CursorMac.mm:
  56265. (WebCore::leakNamedCursor): Changed to return a Cursor&.
  56266. (WebCore::pointerCursor): Changed to leak an object to avoid an
  56267. exit-time destructor.
  56268. (WebCore::crossCursor): Ditto.
  56269. (WebCore::handCursor): Ditto.
  56270. (WebCore::moveCursor): Ditto.
  56271. (WebCore::verticalTextCursor): Ditto.
  56272. (WebCore::cellCursor): Ditto.
  56273. (WebCore::contextMenuCursor): Ditto.
  56274. (WebCore::aliasCursor): Ditto.
  56275. (WebCore::zoomInCursor): Ditto.
  56276. (WebCore::zoomOutCursor): Ditto.
  56277. (WebCore::copyCursor): Ditto.
  56278. (WebCore::noneCursor): Ditto.
  56279. (WebCore::progressCursor): Ditto.
  56280. (WebCore::noDropCursor): Ditto.
  56281. (WebCore::notAllowedCursor): Ditto.
  56282. (WebCore::iBeamCursor): Ditto.
  56283. (WebCore::waitCursor): Ditto.
  56284. (WebCore::helpCursor): Ditto.
  56285. (WebCore::eastResizeCursor): Ditto.
  56286. (WebCore::northResizeCursor): Ditto.
  56287. (WebCore::northEastResizeCursor): Ditto.
  56288. (WebCore::northWestResizeCursor): Ditto.
  56289. (WebCore::southResizeCursor): Ditto.
  56290. (WebCore::southEastResizeCursor): Ditto.
  56291. (WebCore::southWestResizeCursor): Ditto.
  56292. (WebCore::westResizeCursor): Ditto.
  56293. (WebCore::northSouthResizeCursor): Ditto.
  56294. (WebCore::eastWestResizeCursor): Ditto.
  56295. (WebCore::northEastSouthWestResizeCursor): Ditto.
  56296. (WebCore::northWestSouthEastResizeCursor): Ditto.
  56297. (WebCore::columnResizeCursor): Ditto.
  56298. (WebCore::rowResizeCursor): Ditto.
  56299. (WebCore::grabCursor): Ditto.
  56300. (WebCore::grabbingCursor): Ditto.
  56301. * storage/Database.cpp:
  56302. (WebCore::guidMutex): Changed to leak an object to avoid an
  56303. exit-time destructor. Also added a comment explaining why it's
  56304. thread safe.
  56305. (WebCore::guidToVersionMap): Ditto.
  56306. (WebCore::guidToDatabaseMap): Ditto.
  56307. (WebCore::Database::databaseInfoTableName): Ditto.
  56308. (WebCore::databaseVersionKey): Ditto.
  56309. (WebCore::Database::getVersionFromDatabase): Ditto.
  56310. (WebCore::Database::setVersionInDatabase): Ditto.
  56311. (WebCore::guidForOriginAndName): Ditto.
  56312. * storage/DatabaseTracker.cpp:
  56313. (WebCore::DatabaseTracker::tracker): Ditto.
  56314. (WebCore::notificationMutex): Ditto.
  56315. (WebCore::notificationQueue): Ditto.
  56316. (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.
  56317. 2008-11-04 Simon Fraser <simon.fraser@apple.com>
  56318. Reviewed by Dave Hyatt
  56319. https://bugs.webkit.org/show_bug.cgi?id=21941
  56320. Rename absolutePosition() to localToAbsolute(), and add the ability
  56321. to optionally take transforms into account (which will eventually be the
  56322. default behavior).
  56323. * WebCore.base.exp:
  56324. * WebCore.xcodeproj/project.pbxproj:
  56325. * dom/ContainerNode.cpp:
  56326. (WebCore::ContainerNode::getUpperLeftCorner):
  56327. (WebCore::ContainerNode::getLowerRightCorner):
  56328. (WebCore::ContainerNode::getRect):
  56329. * dom/ContainerNode.h:
  56330. * dom/MouseRelatedEvent.cpp:
  56331. (WebCore::MouseRelatedEvent::receivedTarget):
  56332. * dom/Node.cpp:
  56333. (WebCore::Node::getRect):
  56334. * editing/SelectionController.cpp:
  56335. (WebCore::SelectionController::layout):
  56336. (WebCore::SelectionController::caretRect):
  56337. * editing/visible_units.cpp:
  56338. (WebCore::previousLinePosition):
  56339. (WebCore::nextLinePosition):
  56340. * html/HTMLAnchorElement.cpp:
  56341. (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  56342. (WebCore::HTMLAnchorElement::defaultEventHandler):
  56343. * html/HTMLAreaElement.cpp:
  56344. (WebCore::HTMLAreaElement::getRect):
  56345. * html/HTMLImageElement.cpp:
  56346. (WebCore::HTMLImageElement::x):
  56347. (WebCore::HTMLImageElement::y):
  56348. * html/HTMLInputElement.cpp:
  56349. (WebCore::HTMLInputElement::defaultEventHandler):
  56350. * html/HTMLInputElement.h:
  56351. * page/AccessibilityRenderObject.cpp:
  56352. (WebCore::AccessibilityRenderObject::boundingBoxRect):
  56353. * page/EventHandler.cpp:
  56354. (WebCore::EventHandler::handleDrag):
  56355. * platform/graphics/FloatPoint.h:
  56356. (WebCore::roundedIntPoint):
  56357. * platform/graphics/IntSize.h:
  56358. (WebCore::IntSize::expand):
  56359. * rendering/LayoutState.cpp:
  56360. (WebCore::LayoutState::LayoutState):
  56361. * rendering/RenderBlock.cpp:
  56362. (WebCore::RenderBlock::layoutBlock):
  56363. (WebCore::RenderBlock::paintObject):
  56364. (WebCore::RenderBlock::selectionGapRects):
  56365. (WebCore::RenderBlock::fillBlockSelectionGaps):
  56366. (WebCore::RenderBlock::nodeAtPoint):
  56367. (WebCore::RenderBlock::positionForCoordinates):
  56368. * rendering/RenderBox.cpp:
  56369. (WebCore::RenderBox::localToAbsolute):
  56370. (WebCore::RenderBox::computeAbsoluteRepaintRect):
  56371. (WebCore::RenderBox::caretRect):
  56372. * rendering/RenderBox.h:
  56373. (WebCore::RenderBox::relativePositionOffset):
  56374. * rendering/RenderContainer.cpp:
  56375. (WebCore::RenderContainer::addLineBoxRects):
  56376. * rendering/RenderFlow.cpp:
  56377. (WebCore::RenderFlow::absoluteClippedOverflowRect):
  56378. (WebCore::RenderFlow::caretRect):
  56379. (WebCore::RenderFlow::addFocusRingRects):
  56380. * rendering/RenderLayer.cpp:
  56381. (WebCore::RenderLayer::updateLayerPosition):
  56382. (WebCore::RenderLayer::convertToLayerCoords):
  56383. (WebCore::RenderLayer::addScrolledContentOffset):
  56384. (WebCore::RenderLayer::subtractScrolledContentOffset):
  56385. (WebCore::RenderLayer::scrollRectToVisible):
  56386. * rendering/RenderLayer.h:
  56387. (WebCore::RenderLayer::scrolledContentOffset):
  56388. (WebCore::RenderLayer::relativePositionOffset):
  56389. * rendering/RenderListBox.cpp:
  56390. (WebCore::RenderListBox::panScroll):
  56391. (WebCore::RenderListBox::scrollToward):
  56392. * rendering/RenderListMarker.cpp:
  56393. (WebCore::RenderListMarker::selectionRect):
  56394. * rendering/RenderObject.cpp:
  56395. (WebCore::RenderObject::absoluteBoundingBoxRect):
  56396. (WebCore::RenderObject::computeAbsoluteRepaintRect):
  56397. (WebCore::RenderObject::localToAbsolute):
  56398. (WebCore::RenderObject::addDashboardRegions):
  56399. (WebCore::RenderObject::absoluteContentBox):
  56400. (WebCore::RenderObject::absoluteOutlineBox):
  56401. * rendering/RenderObject.h:
  56402. (WebCore::RenderObject::localToAbsoluteForContent):
  56403. * rendering/RenderPart.cpp:
  56404. (WebCore::RenderPart::updateWidgetPosition):
  56405. * rendering/RenderReplaced.cpp:
  56406. (WebCore::RenderReplaced::selectionRect):
  56407. * rendering/RenderSVGInlineText.cpp:
  56408. (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
  56409. * rendering/RenderSVGText.cpp:
  56410. (WebCore::RenderSVGText::absoluteRects):
  56411. * rendering/RenderTableCell.cpp:
  56412. (WebCore::RenderTableCell::localToAbsolute):
  56413. * rendering/RenderTableCell.h:
  56414. * rendering/RenderText.cpp:
  56415. (WebCore::RenderText::addLineBoxRects):
  56416. (WebCore::RenderText::caretRect):
  56417. (WebCore::RenderText::selectionRect):
  56418. * rendering/RenderVideo.cpp:
  56419. (WebCore::RenderVideo::updatePlayer):
  56420. * rendering/RenderView.cpp:
  56421. (WebCore::RenderView::localToAbsolute):
  56422. * rendering/RenderView.h:
  56423. * rendering/RenderWidget.cpp:
  56424. (WebCore::RenderWidget::updateWidgetPosition):
  56425. * svg/SVGSVGElement.cpp:
  56426. (WebCore::SVGSVGElement::getScreenCTM):
  56427. 2008-11-03 Yael Aharon <yael.aharon@nokia.com>
  56428. Reviewed by Simon Hausmann.
  56429. Add methods for getting and setting user data on History Item.
  56430. This change is limited to QT port only. Tests were added in
  56431. the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.
  56432. Minor change by Simon: made the functions inline and added a missing
  56433. const.
  56434. * history/HistoryItem.h:
  56435. 2008-11-01 Alexey Proskuryakov <ap@webkit.org>
  56436. Reviewed by Darin Adler.
  56437. https://bugs.webkit.org/show_bug.cgi?id=22030
  56438. Make EventNames usable from multiple threads
  56439. * platform/text/AtomicString.cpp:
  56440. (WebCore::stringTable):
  56441. (WebCore::AtomicString::add):
  56442. (WebCore::AtomicString::remove):
  56443. (WebCore::AtomicString::find):
  56444. (WebCore::AtomicString::init):
  56445. * platform/text/AtomicString.h:
  56446. Atomic string table is now per-thread. Individual strings cannot be shared between threads,
  56447. so global AtomicString constants cannot be used from threads other than the main one.
  56448. * dom/EventNames.cpp:
  56449. (WebCore::EventNames::EventNames):
  56450. (WebCore::eventNames):
  56451. (WebCore::EventNames::init):
  56452. * dom/EventNames.h:
  56453. Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
  56454. eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
  56455. threads.
  56456. * WebCore.base.exp:
  56457. * bindings/js/JSDOMWindowBase.cpp:
  56458. * bindings/js/JSEventListener.cpp:
  56459. * bindings/js/ScriptController.cpp:
  56460. (WebCore::ScriptController::processingUserGesture):
  56461. * dom/BeforeTextInsertedEvent.cpp:
  56462. (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent):
  56463. * dom/BeforeUnloadEvent.cpp:
  56464. (WebCore::BeforeUnloadEvent::BeforeUnloadEvent):
  56465. * dom/CharacterData.cpp:
  56466. (WebCore::CharacterData::dispatchModifiedEvent):
  56467. * dom/ContainerNode.cpp:
  56468. (WebCore::dispatchChildInsertionEvents):
  56469. (WebCore::dispatchChildRemovalEvents):
  56470. * dom/DedicatedWorker.cpp:
  56471. (WebCore::DedicatedWorker::dispatchErrorEvent):
  56472. * dom/Document.cpp:
  56473. (WebCore::Document::implicitClose):
  56474. (WebCore::Document::setFocusedNode):
  56475. (WebCore::Document::addListenerTypeIfNeeded):
  56476. (WebCore::Document::removeWindowInlineEventListenerForType):
  56477. (WebCore::Document::addWindowEventListener):
  56478. (WebCore::Document::removeWindowEventListener):
  56479. (WebCore::Document::finishedParsing):
  56480. * dom/EventTargetNode.cpp:
  56481. (WebCore::EventTargetNode::dispatchGenericEvent):
  56482. (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
  56483. (WebCore::EventTargetNode::dispatchWindowEvent):
  56484. (WebCore::EventTargetNode::dispatchUIEvent):
  56485. (WebCore::EventTargetNode::dispatchSimulatedClick):
  56486. (WebCore::EventTargetNode::dispatchMouseEvent):
  56487. (WebCore::EventTargetNode::dispatchFocusEvent):
  56488. (WebCore::EventTargetNode::dispatchBlurEvent):
  56489. (WebCore::EventTargetNode::defaultEventHandler):
  56490. (WebCore::EventTargetNode::on*): (multiple methods)
  56491. (WebCore::EventTargetNode::setOn*): (multiple methods)
  56492. * dom/KeyboardEvent.cpp:
  56493. (WebCore::eventTypeForKeyboardEventType):
  56494. (WebCore::KeyboardEvent::keyCode):
  56495. (WebCore::KeyboardEvent::charCode):
  56496. * dom/MessageEvent.cpp:
  56497. (WebCore::MessageEvent::MessageEvent):
  56498. * dom/MessagePort.cpp:
  56499. (WebCore::MessagePort::dispatchMessages):
  56500. (WebCore::MessagePort::dispatchCloseEvent):
  56501. * dom/MouseEvent.cpp:
  56502. (WebCore::MouseEvent::isDragEvent):
  56503. (WebCore::MouseEvent::toElement):
  56504. (WebCore::MouseEvent::fromElement):
  56505. * dom/OverflowEvent.cpp:
  56506. (WebCore::OverflowEvent::OverflowEvent):
  56507. * dom/TextEvent.cpp:
  56508. (WebCore::TextEvent::TextEvent):
  56509. * dom/WebKitAnimationEvent.cpp:
  56510. (WebCore::WebKitAnimationEvent::WebKitAnimationEvent):
  56511. (WebCore::WebKitAnimationEvent::~WebKitAnimationEvent):
  56512. (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent):
  56513. (WebCore::WebKitAnimationEvent::animationName):
  56514. (WebCore::WebKitAnimationEvent::elapsedTime):
  56515. * dom/WebKitTransitionEvent.cpp:
  56516. (WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
  56517. (WebCore::WebKitTransitionEvent::~WebKitTransitionEvent):
  56518. (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):
  56519. (WebCore::WebKitTransitionEvent::propertyName):
  56520. (WebCore::WebKitTransitionEvent::elapsedTime):
  56521. * dom/WheelEvent.cpp:
  56522. (WebCore::WheelEvent::WheelEvent):
  56523. (WebCore::WheelEvent::initWheelEvent):
  56524. * dom/XMLTokenizerLibxml2.cpp:
  56525. * dom/XMLTokenizerQt.cpp:
  56526. * editing/DeleteButton.cpp:
  56527. (WebCore::DeleteButton::defaultEventHandler):
  56528. * editing/EditCommand.cpp:
  56529. * editing/Editor.cpp:
  56530. (WebCore::Editor::canDHTMLCut):
  56531. (WebCore::Editor::canDHTMLCopy):
  56532. (WebCore::Editor::canDHTMLPaste):
  56533. (WebCore::Editor::tryDHTMLCopy):
  56534. (WebCore::Editor::tryDHTMLCut):
  56535. (WebCore::Editor::tryDHTMLPaste):
  56536. (WebCore::dispatchEditableContentChangedEvents):
  56537. * editing/ReplaceSelectionCommand.cpp:
  56538. (WebCore::ReplacementFragment::ReplacementFragment):
  56539. * editing/SelectionController.cpp:
  56540. (WebCore::SelectionController::setFocused):
  56541. * html/HTMLAnchorElement.cpp:
  56542. (WebCore::HTMLAnchorElement::defaultEventHandler):
  56543. * html/HTMLBodyElement.cpp:
  56544. (WebCore::HTMLBodyElement::parseMappedAttribute):
  56545. * html/HTMLButtonElement.cpp:
  56546. (WebCore::HTMLButtonElement::parseMappedAttribute):
  56547. (WebCore::HTMLButtonElement::defaultEventHandler):
  56548. * html/HTMLElement.cpp:
  56549. (WebCore::HTMLElement::parseMappedAttribute):
  56550. * html/HTMLFormControlElement.cpp:
  56551. (WebCore::HTMLFormControlElement::onChange):
  56552. * html/HTMLFormElement.cpp:
  56553. (WebCore::HTMLFormElement::handleLocalEvents):
  56554. (WebCore::HTMLFormElement::prepareSubmit):
  56555. (WebCore::HTMLFormElement::reset):
  56556. (WebCore::HTMLFormElement::parseMappedAttribute):
  56557. * html/HTMLFrameElementBase.cpp:
  56558. (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  56559. * html/HTMLFrameSetElement.cpp:
  56560. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  56561. * html/HTMLImageElement.cpp:
  56562. (WebCore::HTMLImageElement::parseMappedAttribute):
  56563. * html/HTMLImageLoader.cpp:
  56564. (WebCore::HTMLImageLoader::dispatchLoadEvent):
  56565. * html/HTMLInputElement.cpp:
  56566. (WebCore::HTMLInputElement::parseMappedAttribute):
  56567. (WebCore::HTMLInputElement::setValueFromRenderer):
  56568. (WebCore::HTMLInputElement::preDispatchEventHandler):
  56569. (WebCore::HTMLInputElement::postDispatchEventHandler):
  56570. (WebCore::HTMLInputElement::defaultEventHandler):
  56571. (WebCore::HTMLInputElement::onSearch):
  56572. * html/HTMLLabelElement.cpp:
  56573. (WebCore::HTMLLabelElement::defaultEventHandler):
  56574. * html/HTMLMediaElement.cpp:
  56575. (WebCore::HTMLMediaElement::load):
  56576. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
  56577. (WebCore::HTMLMediaElement::setReadyState):
  56578. (WebCore::HTMLMediaElement::progressEventTimerFired):
  56579. (WebCore::HTMLMediaElement::seek):
  56580. (WebCore::HTMLMediaElement::setDefaultPlaybackRate):
  56581. (WebCore::HTMLMediaElement::setPlaybackRate):
  56582. (WebCore::HTMLMediaElement::play):
  56583. (WebCore::HTMLMediaElement::pause):
  56584. (WebCore::HTMLMediaElement::setVolume):
  56585. (WebCore::HTMLMediaElement::setMuted):
  56586. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
  56587. (WebCore::HTMLMediaElement::documentWillBecomeInactive):
  56588. * html/HTMLObjectElement.cpp:
  56589. (WebCore::HTMLObjectElement::parseMappedAttribute):
  56590. * html/HTMLOptionElement.cpp:
  56591. * html/HTMLScriptElement.cpp:
  56592. (WebCore::HTMLScriptElement::parseMappedAttribute):
  56593. (WebCore::HTMLScriptElement::dispatchLoadEvent):
  56594. (WebCore::HTMLScriptElement::dispatchErrorEvent):
  56595. * html/HTMLSelectElement.cpp:
  56596. (WebCore::HTMLSelectElement::parseMappedAttribute):
  56597. (WebCore::HTMLSelectElement::defaultEventHandler):
  56598. (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
  56599. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  56600. * html/HTMLTextAreaElement.cpp:
  56601. (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  56602. (WebCore::HTMLTextAreaElement::defaultEventHandler):
  56603. * html/HTMLTokenizer.cpp:
  56604. (WebCore::HTMLTokenizer::notifyFinished):
  56605. * loader/FrameLoader.cpp:
  56606. (WebCore::FrameLoader::stopLoading):
  56607. (WebCore::FrameLoader::canCachePage):
  56608. * loader/ImageDocument.cpp:
  56609. (WebCore::ImageEventListener::handleEvent):
  56610. * loader/ImageLoader.cpp:
  56611. * loader/MediaDocument.cpp:
  56612. (WebCore::MediaDocument::defaultEventHandler):
  56613. * loader/appcache/DOMApplicationCache.cpp:
  56614. (WebCore::DOMApplicationCache::callCheckingListener):
  56615. (WebCore::DOMApplicationCache::callErrorListener):
  56616. (WebCore::DOMApplicationCache::callNoUpdateListener):
  56617. (WebCore::DOMApplicationCache::callDownloadingListener):
  56618. (WebCore::DOMApplicationCache::callProgressListener):
  56619. (WebCore::DOMApplicationCache::callUpdateReadyListener):
  56620. (WebCore::DOMApplicationCache::callCachedListener):
  56621. * page/AccessibilityObject.cpp:
  56622. * page/AccessibilityRenderObject.cpp:
  56623. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  56624. * page/ContextMenuController.cpp:
  56625. (WebCore::ContextMenuController::handleContextMenuEvent):
  56626. * page/DOMWindow.cpp:
  56627. (WebCore::DOMWindow::on*): (multiple methods)
  56628. (WebCore::DOMWindow::setOn*): (multiple methods)
  56629. * page/EventHandler.cpp:
  56630. (WebCore::EventHandler::handleMousePressEvent):
  56631. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  56632. (WebCore::EventHandler::handleMouseMoveEvent):
  56633. (WebCore::EventHandler::handleMouseReleaseEvent):
  56634. (WebCore::EventHandler::updateDragAndDrop):
  56635. (WebCore::EventHandler::cancelDragAndDrop):
  56636. (WebCore::EventHandler::performDragAndDrop):
  56637. (WebCore::EventHandler::updateMouseEventTargetNode):
  56638. (WebCore::EventHandler::dispatchMouseEvent):
  56639. (WebCore::EventHandler::sendContextMenuEvent):
  56640. (WebCore::EventHandler::canMouseDownStartSelect):
  56641. (WebCore::EventHandler::canMouseDragExtendSelect):
  56642. (WebCore::EventHandler::defaultKeyboardEventHandler):
  56643. (WebCore::EventHandler::dragSourceMovedTo):
  56644. (WebCore::EventHandler::dragSourceEndedAt):
  56645. (WebCore::EventHandler::handleDrag):
  56646. (WebCore::EventHandler::handleTextInputEvent):
  56647. * page/FocusController.cpp:
  56648. * page/Frame.cpp:
  56649. (WebCore::Frame::sendResizeEvent):
  56650. (WebCore::Frame::sendScrollEvent):
  56651. * page/Page.cpp:
  56652. (WebCore::networkStateChanged):
  56653. * page/animation/AnimationBase.cpp:
  56654. (WebCore::AnimationBase::updateStateMachine):
  56655. (WebCore::AnimationBase::animationTimerCallbackFired):
  56656. (WebCore::AnimationBase::primeEventTimers):
  56657. * page/animation/ImplicitAnimation.cpp:
  56658. (WebCore::ImplicitAnimation::onAnimationEnd):
  56659. (WebCore::ImplicitAnimation::sendTransitionEvent):
  56660. * page/animation/KeyframeAnimation.cpp:
  56661. (WebCore::KeyframeAnimation::onAnimationStart):
  56662. (WebCore::KeyframeAnimation::onAnimationIteration):
  56663. (WebCore::KeyframeAnimation::onAnimationEnd):
  56664. (WebCore::KeyframeAnimation::sendAnimationEvent):
  56665. * page/gtk/EventHandlerGtk.cpp:
  56666. * page/mac/EventHandlerMac.mm:
  56667. (WebCore::isKeyboardOptionTab):
  56668. * page/mac/FrameMac.mm:
  56669. * page/qt/EventHandlerQt.cpp:
  56670. (WebCore::isKeyboardOptionTab):
  56671. * plugins/PluginView.cpp:
  56672. * plugins/gtk/PluginViewGtk.cpp:
  56673. * plugins/qt/PluginViewQt.cpp:
  56674. * plugins/win/PluginViewWin.cpp:
  56675. (WebCore::PluginView::handleKeyboardEvent):
  56676. (WebCore::PluginView::handleMouseEvent):
  56677. * rendering/MediaControlElements.cpp:
  56678. (WebCore::MediaControlMuteButtonElement::defaultEventHandler):
  56679. (WebCore::MediaControlPlayButtonElement::defaultEventHandler):
  56680. (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
  56681. (WebCore::MediaControlTimelineElement::defaultEventHandler):
  56682. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
  56683. * rendering/RenderFrameSet.cpp:
  56684. (WebCore::RenderFrameSet::userResize):
  56685. * rendering/RenderLayer.cpp:
  56686. (WebCore::RenderLayer::scrollToOffset):
  56687. * rendering/RenderListBox.cpp:
  56688. (WebCore::RenderListBox::valueChanged):
  56689. * rendering/RenderMedia.cpp:
  56690. (WebCore::RenderMedia::forwardEvent):
  56691. * rendering/RenderObject.cpp:
  56692. * rendering/RenderSlider.cpp:
  56693. (WebCore::HTMLSliderThumbElement::defaultEventHandler):
  56694. * rendering/RenderTextControl.cpp:
  56695. (WebCore::RenderTextControl::forwardEvent):
  56696. (WebCore::RenderTextControl::selectionChanged):
  56697. * rendering/RenderWidget.cpp:
  56698. * rendering/TextControlInnerElements.cpp:
  56699. (WebCore::TextControlInnerTextElement::defaultEventHandler):
  56700. (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
  56701. (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  56702. * storage/LocalStorageArea.cpp:
  56703. (WebCore::LocalStorageArea::dispatchStorageEvent):
  56704. * storage/SessionStorageArea.cpp:
  56705. (WebCore::SessionStorageArea::dispatchStorageEvent):
  56706. * svg/SVGAElement.cpp:
  56707. (WebCore::SVGAElement::defaultEventHandler):
  56708. * svg/SVGDocument.cpp:
  56709. (WebCore::SVGDocument::dispatchZoomEvent):
  56710. (WebCore::SVGDocument::dispatchScrollEvent):
  56711. * svg/SVGElement.cpp:
  56712. (WebCore::SVGElement::parseMappedAttribute):
  56713. (WebCore::hasLoadListener):
  56714. (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  56715. * svg/SVGElementInstance.cpp:
  56716. (WebCore::SVGElementInstance::on*): (multiple methods)
  56717. (WebCore::SVGElementInstance::setOn*): (multiple methods)
  56718. * svg/SVGImageLoader.cpp:
  56719. (WebCore::SVGImageLoader::dispatchLoadEvent):
  56720. * svg/SVGSVGElement.cpp:
  56721. (WebCore::SVGSVGElement::parseMappedAttribute):
  56722. * svg/SVGScriptElement.cpp:
  56723. (WebCore::SVGScriptElement::dispatchErrorEvent):
  56724. * xml/XMLHttpRequest.cpp:
  56725. (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
  56726. (WebCore::XMLHttpRequest::dispatchAbortEvent):
  56727. (WebCore::XMLHttpRequest::dispatchErrorEvent):
  56728. (WebCore::XMLHttpRequest::dispatchLoadEvent):
  56729. (WebCore::XMLHttpRequest::dispatchLoadStartEvent):
  56730. (WebCore::XMLHttpRequest::dispatchProgressEvent):
  56731. * xml/XMLHttpRequestUpload.cpp:
  56732. (WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
  56733. (WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
  56734. (WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
  56735. (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
  56736. (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
  56737. * xml/XPathResult.cpp:
  56738. (WebCore::XPathResult::XPathResult):
  56739. (WebCore::XPathResult::~XPathResult):
  56740. (WebCore::XPathResult::invalidateIteratorState):
  56741. Access event names via eventNames() function.
  56742. 2008-11-04 Cameron Zwarich <zwarich@apple.com>
  56743. Reviewed by Mark Rowe.
  56744. Delete unused forwarding headers.
  56745. * ForwardingHeaders/kjs/Activation.h: Removed.
  56746. * ForwardingHeaders/kjs/Register.h: Removed.
  56747. * ForwardingHeaders/kjs/RegisterID.h: Removed.
  56748. 2008-11-04 Cameron Zwarich <zwarich@apple.com>
  56749. Not reviewed.
  56750. Fix stupid typo in previous build fix.
  56751. * bindings/js/JSStorageCustom.cpp:
  56752. * bindings/scripts/CodeGeneratorJS.pm:
  56753. * bridge/NP_jsobject.cpp:
  56754. 2008-11-03 Cameron Zwarich <zwarich@apple.com>
  56755. Not reviewed.
  56756. Fix the build for all non-Mac platforms.
  56757. * ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
  56758. * ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
  56759. * bindings/js/JSStorageCustom.cpp:
  56760. * bindings/scripts/CodeGeneratorJS.pm:
  56761. * bridge/NP_jsobject.cpp:
  56762. 2008-11-03 Cameron Zwarich <zwarich@apple.com>
  56763. Not reviewed.
  56764. Fix the wxWindows build.
  56765. * bridge/c/c_instance.cpp:
  56766. 2008-11-03 Cameron Zwarich <zwarich@apple.com>
  56767. Rubber-stamped by Maciej Stachowiak.
  56768. Move more files into the runtime subdirectory of JavaScriptCore.
  56769. * ForwardingHeaders/kjs/ArgList.h: Removed.
  56770. * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
  56771. * ForwardingHeaders/kjs/ExecState.h: Removed.
  56772. * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
  56773. * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
  56774. * ForwardingHeaders/kjs/JSLock.h: Removed.
  56775. * ForwardingHeaders/kjs/SymbolTable.h: Removed.
  56776. * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
  56777. * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
  56778. * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  56779. * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
  56780. * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
  56781. * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
  56782. * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
  56783. * bindings/js/GCController.cpp:
  56784. * bindings/js/JSCustomPositionCallback.cpp:
  56785. * bindings/js/JSCustomPositionErrorCallback.cpp:
  56786. * bindings/js/JSCustomSQLStatementCallback.cpp:
  56787. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  56788. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  56789. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  56790. * bindings/js/JSCustomVoidCallback.cpp:
  56791. * bindings/js/JSCustomXPathNSResolver.cpp:
  56792. * bindings/js/JSDOMWindowBase.cpp:
  56793. * bindings/js/JSEventCustom.cpp:
  56794. * bindings/js/JSEventListener.cpp:
  56795. * bindings/js/JSNodeFilterCondition.cpp:
  56796. * bindings/js/ScheduledAction.cpp:
  56797. * bindings/js/ScriptController.cpp:
  56798. * bindings/js/ScriptControllerMac.mm:
  56799. * bindings/objc/WebScriptObject.mm:
  56800. * bridge/NP_jsobject.cpp:
  56801. * bridge/c/c_class.cpp:
  56802. * bridge/c/c_instance.cpp:
  56803. * bridge/c/c_runtime.cpp:
  56804. * bridge/c/c_utility.cpp:
  56805. * bridge/jni/jni_class.cpp:
  56806. * bridge/jni/jni_instance.cpp:
  56807. * bridge/jni/jni_jsobject.mm:
  56808. * bridge/jni/jni_objc.mm:
  56809. * bridge/jni/jni_runtime.cpp:
  56810. * bridge/jni/jni_runtime.h:
  56811. * bridge/jni/jni_utility.cpp:
  56812. * bridge/npruntime.cpp:
  56813. * bridge/objc/objc_instance.mm:
  56814. * bridge/objc/objc_runtime.mm:
  56815. * bridge/objc/objc_utility.mm:
  56816. * bridge/runtime.cpp:
  56817. * dom/Document.cpp:
  56818. * dom/Node.cpp:
  56819. * dom/NodeFilter.cpp:
  56820. * dom/NodeIterator.cpp:
  56821. * dom/TreeWalker.cpp:
  56822. * history/CachedPage.cpp:
  56823. * inspector/InspectorController.cpp:
  56824. * inspector/JavaScriptCallFrame.cpp:
  56825. * inspector/JavaScriptCallFrame.h:
  56826. * inspector/JavaScriptDebugServer.cpp:
  56827. * inspector/JavaScriptProfileNode.cpp:
  56828. * loader/FrameLoader.cpp:
  56829. * loader/icon/IconDatabase.cpp:
  56830. * page/Console.cpp:
  56831. * page/Page.cpp:
  56832. * page/mac/FrameMac.mm:
  56833. * plugins/PluginView.cpp:
  56834. * plugins/gtk/PluginViewGtk.cpp:
  56835. * plugins/qt/PluginViewQt.cpp:
  56836. * plugins/win/PluginViewWin.cpp:
  56837. * storage/Database.cpp:
  56838. * xml/XMLHttpRequest.cpp:
  56839. 2008-11-03 Cameron Zwarich <zwarich@apple.com>
  56840. Reviewed by Sam Weinig.
  56841. Remove the forwarding header for FunctionCallProfile, because it was
  56842. renamed to ProfileNode in r33466.
  56843. * ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.
  56844. 2008-11-03 Simon Fraser <simon.fraser@apple.com>
  56845. Reviewed by Dave Hyatt
  56846. https://bugs.webkit.org/show_bug.cgi?id=22026
  56847. When computing the bounds of the transparency layer, we need to
  56848. map the clipRect through the enclosing transform.
  56849. Test: fast/layers/opacity-transforms.html
  56850. * rendering/RenderLayer.cpp:
  56851. (WebCore::transparencyClipBox):
  56852. 2008-11-03 Kevin Decker <kdecker@apple.com>
  56853. Reviewed by Anders Carlsson.
  56854. https://bugs.webkit.org/show_bug.cgi?id=22053
  56855. Added additional support needed for the NPDrawingModelCoreAnimation drawing model.
  56856. * bridge/npapi.h:
  56857. 2008-11-03 Xan Lopez <xan@gnome.org>
  56858. Reviewed by Alp Toker.
  56859. Update parseDataUrl() function in the libsoup http backend with
  56860. the one from the curl backend which has recent correctness and crash
  56861. fixes.
  56862. * platform/network/soup/ResourceHandleSoup.cpp:
  56863. (WebCore::parseDataUrl):
  56864. 2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
  56865. Reviewed by Alp Toker.
  56866. https://bugs.webkit.org/show_bug.cgi?id=22041
  56867. Fix CURL crashes on the test suite
  56868. Fix segfault with setDefersLoading(). Do not call into curl when we
  56869. don't have a CURL handle.
  56870. It is attempted to defer the loading before the load has been
  56871. started (no curl handle was allocated yet). If that happens then
  56872. just remember that. ResourceHandleManager::startJob is already taking
  56873. care of this and in initResourceHandle the the downloading will
  56874. be paused if needed.
  56875. Fixes fast/loader/simultaneous-reloads-assert.html
  56876. * platform/network/curl/ResourceHandleCurl.cpp:
  56877. (WebCore::ResourceHandle::setDefersLoading):
  56878. 2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
  56879. Reviewed by Alp Toker.
  56880. https://bugs.webkit.org/show_bug.cgi?id=22041
  56881. Fix CURL crashes on the test suite
  56882. Do not send "no data" to WebCore in parseDataUrl().
  56883. Fixes assert on fast/tokenizer/image-empty-crash.html
  56884. * platform/network/curl/ResourceHandleManager.cpp:
  56885. (WebCore::parseDataUrl):
  56886. 2008-11-02 Xan Lopez <xan@gnome.org>
  56887. Reviewed by Holger Freyther.
  56888. https://bugs.webkit.org/show_bug.cgi?id=22009
  56889. HTML5 Video with GStreamer pulls gnome-vfs without using it
  56890. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  56891. Remove gnome-vfs include.
  56892. 2008-11-01 Adam Barth <abarth@webkit.org>
  56893. Reviewed by Sam Weinig.
  56894. Be sure to check the final URLs of requested resources to make sure we
  56895. don't get fooled by HTTP redirects.
  56896. https://bugs.webkit.org/show_bug.cgi?id=21963
  56897. Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml
  56898. http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
  56899. * dom/XMLTokenizerLibxml2.cpp:
  56900. (WebCore::openFunc):
  56901. * loader/DocLoader.cpp:
  56902. (WebCore::DocLoader::canRequest):
  56903. (WebCore::DocLoader::requestResource):
  56904. * loader/DocLoader.h:
  56905. * xml/XSLTProcessor.cpp:
  56906. (WebCore::docLoaderFunc):
  56907. 2008-11-01 Alexey Proskuryakov <ap@webkit.org>
  56908. Reviewed by Darin Adler.
  56909. https://bugs.webkit.org/show_bug.cgi?id=22001
  56910. AtomicStringImpl* keys of event listener maps can outlive their strings
  56911. Test: fast/events/destroyed-atomic-string.html
  56912. * dom/MessagePort.cpp:
  56913. (WebCore::MessagePort::addEventListener):
  56914. (WebCore::MessagePort::removeEventListener):
  56915. (WebCore::MessagePort::dispatchEvent):
  56916. * dom/MessagePort.h:
  56917. * loader/appcache/DOMApplicationCache.cpp:
  56918. (WebCore::DOMApplicationCache::addEventListener):
  56919. (WebCore::DOMApplicationCache::removeEventListener):
  56920. (WebCore::DOMApplicationCache::dispatchEvent):
  56921. * loader/appcache/DOMApplicationCache.h:
  56922. * xml/XMLHttpRequest.cpp:
  56923. (WebCore::XMLHttpRequest::addEventListener):
  56924. (WebCore::XMLHttpRequest::removeEventListener):
  56925. (WebCore::XMLHttpRequest::dispatchEvent):
  56926. * xml/XMLHttpRequest.h:
  56927. * xml/XMLHttpRequestUpload.cpp:
  56928. (WebCore::XMLHttpRequestUpload::addEventListener):
  56929. (WebCore::XMLHttpRequestUpload::removeEventListener):
  56930. (WebCore::XMLHttpRequestUpload::dispatchEvent):
  56931. * xml/XMLHttpRequestUpload.h:
  56932. Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
  56933. 2008-10-31 Alexey Proskuryakov <ap@webkit.org>
  56934. Reviewed by Darin Adler.
  56935. https://bugs.webkit.org/show_bug.cgi?id=21998
  56936. Use JSDOMGlobalObject in EventListener-related bindings
  56937. * dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
  56938. * bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS
  56939. bindings for inline event handlers.
  56940. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  56941. (WebCore::JSDOMApplicationCache::addEventListener):
  56942. (WebCore::JSDOMApplicationCache::removeEventListener):
  56943. * bindings/js/JSEventTargetNodeCustom.cpp:
  56944. (WebCore::JSEventTargetNode::addEventListener):
  56945. (WebCore::JSEventTargetNode::removeEventListener):
  56946. * bindings/js/JSMessagePortCustom.cpp:
  56947. (WebCore::JSMessagePort::removeEventListener):
  56948. * bindings/js/JSSVGElementInstanceCustom.cpp:
  56949. (WebCore::JSSVGElementInstance::addEventListener):
  56950. (WebCore::JSSVGElementInstance::removeEventListener):
  56951. * bindings/js/JSXMLHttpRequestCustom.cpp:
  56952. (WebCore::JSXMLHttpRequest::addEventListener):
  56953. (WebCore::JSXMLHttpRequest::removeEventListener):
  56954. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  56955. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  56956. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  56957. Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
  56958. * dom/EventTarget.h:
  56959. * dom/EventTargetNode.cpp:
  56960. (WebCore::EventTargetNode::scriptExecutionContext):
  56961. * dom/EventTargetNode.h:
  56962. * dom/MessagePort.cpp:
  56963. * dom/MessagePort.h:
  56964. (WebCore::MessagePort::scriptExecutionContext):
  56965. * loader/appcache/DOMApplicationCache.cpp:
  56966. (WebCore::DOMApplicationCache::scriptExecutionContext):
  56967. * loader/appcache/DOMApplicationCache.h:
  56968. * svg/SVGElementInstance.cpp:
  56969. (WebCore::SVGElementInstance::scriptExecutionContext):
  56970. * svg/SVGElementInstance.h:
  56971. * xml/XMLHttpRequest.cpp:
  56972. (WebCore::XMLHttpRequest::scriptExecutionContext):
  56973. * xml/XMLHttpRequest.h:
  56974. * xml/XMLHttpRequestUpload.cpp:
  56975. (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
  56976. * xml/XMLHttpRequestUpload.h:
  56977. Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't
  56978. available yet.
  56979. 2008-10-31 Cameron Zwarich <zwarich@apple.com>
  56980. Rubber-stamped by Geoff Garen.
  56981. Rename SourceRange.h to SourceCode.h.
  56982. * ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
  56983. * ForwardingHeaders/kjs/SourceRange.h: Removed.
  56984. * bindings/js/StringSourceProvider.h:
  56985. * bridge/NP_jsobject.cpp:
  56986. 2008-10-31 Cameron Zwarich <zwarich@apple.com>
  56987. Reviewed by Darin Adler.
  56988. Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
  56989. <https://bugs.webkit.org/show_bug.cgi?id=22019>
  56990. * WebCore.base.exp:
  56991. * page/Console.cpp:
  56992. (WebCore::printToStandardOut):
  56993. (WebCore::Console::shouldPrintExceptions):
  56994. (WebCore::Console::setShouldPrintExceptions):
  56995. * page/Console.h:
  56996. 2008-10-31 Dan Bernstein <mitz@apple.com>
  56997. Reviewed by John Sullivan.
  56998. - WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
  56999. * dom/Document.cpp:
  57000. (WebCore::Document::cookie): Added checking if cookies are disabled.
  57001. (WebCore::Document::setCookie): Ditto.
  57002. * page/Navigator.cpp:
  57003. (WebCore::Navigator::cookieEnabled): Ditto.
  57004. * page/Page.cpp:
  57005. (WebCore::Page::Page): Initialize m_cookieEnabled to true.
  57006. * page/Page.h:
  57007. (WebCore::Page::cookieEnabled): Added.
  57008. (WebCore::Page::setCookieEnabled): Added.
  57009. 2008-10-31 Adele Peterson <adele@apple.com>
  57010. Reviewed by Darin Adler.
  57011. WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
  57012. https://bugs.webkit.org/show_bug.cgi?id=22008
  57013. * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon):
  57014. Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
  57015. * platform/graphics/Icon.h: ditto.
  57016. * platform/graphics/gtk/IconGtk.cpp:
  57017. (WebCore::Icon::createIconForFile): ditto.
  57018. (WebCore::Icon::createIconForFiles): ditto.
  57019. * platform/graphics/mac/IconMac.mm:
  57020. (WebCore::Icon::createIconForFile): ditto.
  57021. (WebCore::Icon::createIconForFiles): ditto.
  57022. * platform/graphics/qt/IconQt.cpp:
  57023. (WebCore::Icon::createIconForFile): ditto.
  57024. (WebCore::Icon::createIconForFiles): ditto.
  57025. * platform/wx/TemporaryLinkStubs.cpp:
  57026. (Icon::createIconForFile): ditto.
  57027. (Icon::createIconForFiles): ditto.
  57028. * platform/graphics/win/IconWin.cpp:
  57029. (WebCore::Icon::createIconForFile): ditto.
  57030. (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.
  57031. * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
  57032. Improve icon creation code to match new code in Icon::createIconForFiles
  57033. 2008-10-31 Timothy Hatcher <timothy@apple.com>
  57034. Add manual tests that check breakpoints on a blockless body of "for" loops.
  57035. https://bugs.webkit.org/show_bug.cgi?id=22004
  57036. Reviewed by Darin Adler.
  57037. * manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
  57038. * manual-tests/inspector/debugger-pause-on-for-statements.html: Added.
  57039. 2008-10-31 Darin Adler <darin@apple.com>
  57040. - fix build
  57041. * platform/win/WCDataObject.cpp: Added missing include of "config.h".
  57042. 2008-10-30 Alexey Proskuryakov <ap@webkit.org>
  57043. Reviewed by Darin Adler.
  57044. https://bugs.webkit.org/show_bug.cgi?id=21970
  57045. Make MessagePort event dispatch work in workers
  57046. * bindings/js/JSDOMGlobalObject.cpp:
  57047. (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
  57048. (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
  57049. (WebCore::JSDOMGlobalObject::findJSEventListener):
  57050. (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  57051. (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
  57052. (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
  57053. (WebCore::JSDOMGlobalObject::jsEventListeners):
  57054. (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
  57055. (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners):
  57056. (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners):
  57057. (WebCore::JSDOMGlobalObject::setCurrentEvent):
  57058. (WebCore::JSDOMGlobalObject::currentEvent):
  57059. (WebCore::toJSDOMGlobalObject):
  57060. * bindings/js/JSDOMGlobalObject.h:
  57061. * bindings/js/JSDOMWindowBase.cpp:
  57062. (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
  57063. (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  57064. (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
  57065. * bindings/js/JSDOMWindowBase.h:
  57066. Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.
  57067. * bindings/js/JSEventListener.cpp:
  57068. (WebCore::JSAbstractEventListener::handleEvent):
  57069. (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
  57070. (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
  57071. (WebCore::JSUnprotectedEventListener::globalObject):
  57072. (WebCore::JSUnprotectedEventListener::clearGlobalObject):
  57073. (WebCore::JSEventListener::JSEventListener):
  57074. (WebCore::JSEventListener::~JSEventListener):
  57075. (WebCore::JSEventListener::globalObject):
  57076. (WebCore::JSEventListener::clearGlobalObject):
  57077. (WebCore::JSLazyEventListener::JSLazyEventListener):
  57078. (WebCore::JSLazyEventListener::parseCode):
  57079. * bindings/js/JSEventListener.h:
  57080. (WebCore::JSUnprotectedEventListener::create):
  57081. (WebCore::JSEventListener::create):
  57082. (WebCore::JSLazyEventListener::create):
  57083. Changed to use JSDOMGlobalObject and ScriptExecutionContext.
  57084. * bindings/js/JSMessagePortCustom.cpp:
  57085. (WebCore::JSMessagePort::startConversation):
  57086. (WebCore::JSMessagePort::addEventListener):
  57087. (WebCore::JSMessagePort::removeEventListener):
  57088. (WebCore::JSMessagePort::setOnmessage):
  57089. (WebCore::JSMessagePort::setOnclose):
  57090. Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit
  57091. such code, and stop using a custom implementation for JSMessagePort inline event handler
  57092. getters and setters.
  57093. * dom/Document.cpp:
  57094. (WebCore::Document::virtualURL):
  57095. * dom/Document.h:
  57096. * dom/ScriptExecutionContext.h:
  57097. Expose url() method on ScriptExecutionContext (necessary for compiling scripts in
  57098. JSLazyEventListener).
  57099. 2008-10-31 Cameron Zwarich <zwarich@apple.com>
  57100. Not reviewed.
  57101. Speculative wxWindows build fix.
  57102. * webcore-base.bkl:
  57103. 2008-10-30 Mark Rowe <mrowe@apple.com>
  57104. Reviewed by Jon Homeycutt.
  57105. Explicitly default to building for only the native architecture in debug and release builds.
  57106. * Configurations/DebugRelease.xcconfig:
  57107. 2008-10-30 Cameron Zwarich <zwarich@apple.com>
  57108. Rubber-stamped by Sam Weinig.
  57109. Create a debugger directory in JavaScriptCore and move the relevant
  57110. files to it.
  57111. * ForwardingHeaders/debugger: Added.
  57112. * ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
  57113. * ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
  57114. * ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
  57115. * ForwardingHeaders/kjs/debugger.h: Removed.
  57116. * WebCore.pro:
  57117. * bindings/js/ScriptController.cpp:
  57118. * inspector/JavaScriptCallFrame.cpp:
  57119. * inspector/JavaScriptCallFrame.h:
  57120. * inspector/JavaScriptDebugServer.cpp:
  57121. * inspector/JavaScriptDebugServer.h:
  57122. 2008-10-30 Tony Chang <tony@chromium.org>
  57123. Fix 2 Windows theme bugs:
  57124. 1) Checkboxes marked readonly were rendered incorrectly
  57125. 2) If a button has focus and is pressed, it was rendered
  57126. as focused rather than pressed.
  57127. https://bugs.webkit.org/show_bug.cgi?id=21859
  57128. Reviewed by Dave Hyatt.
  57129. * rendering/RenderThemeWin.cpp:
  57130. (WebCore::RenderThemeWin::determineState):
  57131. (WebCore::RenderThemeWin::determineButtonState):
  57132. 2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>
  57133. gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
  57134. warnings; add some parentheses to disambiguate things. No functional
  57135. changes, so no tests.
  57136. https://bugs.webkit.org/show_bug.cgi?id=21973
  57137. Add parentheses to clean up some gcc warnings
  57138. Reviewed by Dan Bernstein.
  57139. * platform/graphics/Font.h:
  57140. (WebCore::Font::treatAsZeroWidthSpace):
  57141. 2008-10-30 Aaron Boodman <aa@chromium.org>
  57142. Added an explicit dependency on HashMap.h. It was getting pulled in via
  57143. <kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.
  57144. Reviewed by Darin Adler.
  57145. * platform/text/PlatformString.h:
  57146. 2008-10-30 Greg Bolsinga <bolsinga@apple.com>
  57147. Reviewed by Sam Weinig
  57148. https://bugs.webkit.org/show_bug.cgi?id=21967
  57149. For some platforms the GeolocationService must be suspended and resumed.
  57150. * page/Geolocation.cpp:
  57151. (WebCore::Geolocation::clearWatch): now uses Geolocation::hasListeners()
  57152. (WebCore::Geolocation::suspend): calls GeolocationService::suspend() if there are listeners
  57153. (WebCore::Geolocation::resume): calls GeolocationService::resume() if there are listeners
  57154. (WebCore::Geolocation::geolocationServicePositionChanged): now uses Geolocation::hasListeners()
  57155. * page/Geolocation.h:
  57156. (WebCore::Geolocation::hasListeners): Indicates of the Geolocation has interested GeolocationService listeners
  57157. * platform/GeolocationService.h:
  57158. (WebCore::GeolocationService::suspend): empty implementation
  57159. (WebCore::GeolocationService::resume): empty implementation
  57160. 2008-10-30 Greg Bolsinga <bolsinga@apple.com>
  57161. Reviewed by Sam Weinig
  57162. https://bugs.webkit.org/show_bug.cgi?id=21966
  57163. The Geolocation spec was updated on 10/27/2008. This brings WebCore up to date.
  57164. http://dev.w3.org/geo/api/spec-source.html
  57165. * page/Geolocation.cpp:
  57166. (WebCore::Geolocation::GeoNotifier::GeoNotifier): PositionOptions' timeout now unsigned
  57167. * page/Geoposition.cpp: velocity is now called speed
  57168. (WebCore::Geoposition::toString):
  57169. * page/Geoposition.h: velocity is now called speed
  57170. (WebCore::Geoposition::create):
  57171. (WebCore::Geoposition::speed):
  57172. (WebCore::Geoposition::Geoposition):
  57173. * page/Geoposition.idl: velocity is now called speed
  57174. * page/PositionOptions.h: timeout is now unsigned
  57175. (WebCore::PositionOptions::create):
  57176. (WebCore::PositionOptions::timeout):
  57177. (WebCore::PositionOptions::setTimeout):
  57178. (WebCore::PositionOptions::PositionOptions):
  57179. * page/PositionOptions.idl: timeout is now unsigned long
  57180. 2008-10-30 Justin Garcia <justin.garcia@apple.com>
  57181. Also handle preserved newlines.
  57182. * editing/BreakBlockquoteCommand.cpp:
  57183. (WebCore::BreakBlockquoteCommand::doApply):
  57184. 2008-10-30 Justin Garcia <justin.garcia@apple.com>
  57185. Reviewed by Beth Dakin.
  57186. <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
  57187. * editing/BreakBlockquoteCommand.cpp:
  57188. (WebCore::BreakBlockquoteCommand::doApply):
  57189. Don't store the endingSelection() in selection, just call endingSelection() in the few places it's
  57190. needed. This function is cheap since it just returns a reference to a Selection instead of creating one.
  57191. Don't store an affinity. In the one place that it was used, isLastVisiblePositionInNode(VisiblePosition(pos, affinity), topBlockquote),
  57192. we now use visiblePos (in order to avoid VisiblePosition creation).
  57193. Set pos after we delete the current selection (if there is one), and be consistent about what we set
  57194. pos to. Before, we upstream()ed it if there was a selection to delete and left it alone otherwise. In fact...
  57195. ...we need to use downstream() for pos so that when a caret is at the boundary between two nodes, pos is
  57196. in the first node that we want to move. This fixes the bug, since it lets code that checks for the case
  57197. where the caret is between text and a br work correctly.
  57198. 2008-10-30 Yael Aharon <yael.aharon@nokia.com>
  57199. Reviewed by Darin Adler.
  57200. Fix the Qt build.
  57201. https://bugs.webkit.org/show_bug.cgi?id=21969
  57202. * inspector/front-end/WebKit.qrc:
  57203. * platform/graphics/qt/ImageBufferQt.cpp:
  57204. (WebCore::ImageBufferData::ImageBufferData):
  57205. (WebCore::ImageBuffer::ImageBuffer):
  57206. (WebCore::ImageBuffer::context):
  57207. (WebCore::ImageBuffer::image):
  57208. (WebCore::ImageBuffer::toDataURL):
  57209. 2008-10-30 Justin Garcia <justin.garcia@apple.com>
  57210. Reviewed by Darin Adler.
  57211. More preparation for:
  57212. <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
  57213. * editing/BreakBlockquoteCommand.cpp:
  57214. (WebCore::BreakBlockquoteCommand::doApply): Added comments. Don't need to use newStartNode. If the
  57215. startNode needs to change, change it. Afterwords, check to make sure that it hasn't left topBlockquote.
  57216. This is slightly stricter than before, where we just made sure that it still had a topBlockquote. This
  57217. doesn't really fix a bug, since we can't really get into a situation where we move to a different
  57218. topBlockquote, but it simplifies the code.
  57219. 2008-10-30 Dirk Schulze <vbs85@gmx.de>
  57220. Reviewed by Alp Toker.
  57221. https://bugs.webkit.org/show_bug.cgi?id=21883
  57222. [CAIRO] globalAlpha has to be stored and restored
  57223. Cairo's globalAlpha has to be stored and reloaded on calling
  57224. save() and restore(). We use the power of GraphicsContextState for this.
  57225. * platform/graphics/GraphicsContextPrivate.h:
  57226. (WebCore::GraphicsContextState::GraphicsContextState):
  57227. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  57228. (WebCore::GraphicsContext::fillPath):
  57229. (WebCore::GraphicsContext::strokePath):
  57230. (WebCore::GraphicsContext::setAlpha):
  57231. (WebCore::GraphicsContext::getAlpha):
  57232. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  57233. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  57234. 2008-10-29 Alexey Proskuryakov <ap@webkit.org>
  57235. Reviewed by Maciej Stachowiak.
  57236. Rename "attachedToEventTargetNode" to "isInline".
  57237. Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
  57238. XMLHttpRequest, MessagePort et al.
  57239. Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
  57240. attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
  57241. And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
  57242. "inlineEventListenerForType", as they work with inline listeners.
  57243. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  57244. (WebCore::JSDOMApplicationCache::addEventListener):
  57245. (WebCore::JSDOMApplicationCache::removeEventListener):
  57246. * bindings/js/JSMessagePortCustom.cpp:
  57247. (WebCore::JSMessagePort::setOnmessage):
  57248. (WebCore::JSMessagePort::setOnclose):
  57249. * bindings/js/JSXMLHttpRequestCustom.cpp:
  57250. (WebCore::JSXMLHttpRequest::addEventListener):
  57251. (WebCore::JSXMLHttpRequest::removeEventListener):
  57252. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  57253. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  57254. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  57255. Pass a correct value for this argument - callers used to be confused, because they didn't
  57256. consider themselves event target nodes. This doesn't affect behavior however, as the only
  57257. difference between inline and non-inline event handlers is that the former treat
  57258. "return false" as "event.preventDefault()", which is not important to any of these objects.
  57259. * bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
  57260. Assert that isInline is true instead of checking its value, as the constructor of this class
  57261. always sets it to true.
  57262. * bindings/js/JSDOMWindowBase.cpp:
  57263. (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  57264. (WebCore::JSDOMWindowBase::findJSEventListener):
  57265. (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
  57266. (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
  57267. (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
  57268. (WebCore::JSDOMWindowBase::jsInlineEventListeners):
  57269. (WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
  57270. * bindings/js/JSDOMWindowBase.h:
  57271. * bindings/js/JSEventListener.cpp:
  57272. (WebCore::JSAbstractEventListener::handleEvent):
  57273. (WebCore::JSAbstractEventListener::isInline):
  57274. (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
  57275. (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
  57276. (WebCore::JSEventListener::JSEventListener):
  57277. (WebCore::JSEventListener::~JSEventListener):
  57278. (WebCore::JSLazyEventListener::parseCode):
  57279. * bindings/js/JSEventListener.h:
  57280. (WebCore::JSAbstractEventListener::JSAbstractEventListener):
  57281. (WebCore::JSUnprotectedEventListener::create):
  57282. (WebCore::JSEventListener::create):
  57283. * bindings/js/ScriptController.cpp:
  57284. (WebCore::ScriptController::createInlineEventHandler):
  57285. * bindings/js/ScriptController.h:
  57286. * dom/Document.cpp:
  57287. (WebCore::Document::setWindowInlineEventListenerForType):
  57288. (WebCore::Document::windowInlineEventListenerForType):
  57289. (WebCore::Document::removeWindowInlineEventListenerForType):
  57290. (WebCore::Document::createEventListener):
  57291. (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
  57292. * dom/Document.h:
  57293. * dom/EventListener.h:
  57294. (WebCore::EventListener::isInline):
  57295. * dom/EventTargetNode.cpp:
  57296. (WebCore::EventTargetNode::removeInlineEventListenerForType):
  57297. (WebCore::EventTargetNode::setInlineEventListenerForType):
  57298. (WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute):
  57299. (WebCore::EventTargetNode::inlineEventListenerForType):
  57300. (WebCore::EventTargetNode::on*): (many methods)
  57301. (WebCore::EventTargetNode::setOn*): (many methods)
  57302. * dom/EventTargetNode.h:
  57303. * editing/ReplaceSelectionCommand.cpp:
  57304. (WebCore::ReplacementFragment::ReplacementFragment):
  57305. * html/HTMLBodyElement.cpp:
  57306. (WebCore::HTMLBodyElement::parseMappedAttribute):
  57307. * html/HTMLButtonElement.cpp:
  57308. (WebCore::HTMLButtonElement::parseMappedAttribute):
  57309. * html/HTMLElement.cpp:
  57310. (WebCore::HTMLElement::parseMappedAttribute):
  57311. * html/HTMLFormElement.cpp:
  57312. (WebCore::HTMLFormElement::parseMappedAttribute):
  57313. * html/HTMLFrameElementBase.cpp:
  57314. (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  57315. * html/HTMLFrameSetElement.cpp:
  57316. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  57317. * html/HTMLImageElement.cpp:
  57318. (WebCore::HTMLImageElement::parseMappedAttribute):
  57319. * html/HTMLInputElement.cpp:
  57320. (WebCore::HTMLInputElement::parseMappedAttribute):
  57321. * html/HTMLObjectElement.cpp:
  57322. (WebCore::HTMLObjectElement::parseMappedAttribute):
  57323. * html/HTMLScriptElement.cpp:
  57324. (WebCore::HTMLScriptElement::parseMappedAttribute):
  57325. * html/HTMLSelectElement.cpp:
  57326. (WebCore::HTMLSelectElement::parseMappedAttribute):
  57327. * html/HTMLTextAreaElement.cpp:
  57328. (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  57329. * page/AccessibilityRenderObject.cpp:
  57330. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  57331. * page/DOMWindow.cpp:
  57332. (WebCore::DOMWindow::setInlineEventListenerForType):
  57333. (WebCore::DOMWindow::inlineEventListenerForType):
  57334. (WebCore::DOMWindow::on*): (many methods)
  57335. (WebCore::DOMWindow::setOn*): (many methods)
  57336. * page/DOMWindow.h:
  57337. * svg/SVGElement.cpp:
  57338. (WebCore::SVGElement::parseMappedAttribute):
  57339. * svg/SVGElementInstance.cpp:
  57340. (WebCore::SVGElementInstance::on*): (many methods)
  57341. (WebCore::SVGElementInstance::setOn*): (many methods)
  57342. * svg/SVGSVGElement.cpp:
  57343. (WebCore::SVGSVGElement::parseMappedAttribute):
  57344. Rename things, as described above.
  57345. 2008-10-29 Gustavo Noronha Silva <gns@gnome.org>
  57346. Reviewed and slightly changed by Holger Freyther.
  57347. Added all the files that need to be installed for the Inspector to
  57348. work.
  57349. * GNUmakefile.am: Invoke the shell to get the files.
  57350. 2008-10-29 Andrew Scherkus <scherkus@chromium.org>
  57351. Reviewed by Darin Adler
  57352. Add MediaPlayerPrivateChromium to MediaPlayer
  57353. https://bugs.webkit.org/show_bug.cgi?id=21930
  57354. * platform/graphics/MediaPlayer.cpp:
  57355. 2008-10-29 Justin Garcia <justin.garcia@apple.com>
  57356. Reviewed by Darin Adler.
  57357. Some preparation for:
  57358. <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
  57359. Added an early return to avoid a level of if-nesting. No other changes. We probably don't
  57360. need to rebalance whitespace before the early return but for now don't risk any change in behavior
  57361. I'll revisit that later.
  57362. * editing/BreakBlockquoteCommand.cpp:
  57363. (WebCore::BreakBlockquoteCommand::doApply):
  57364. 2008-10-29 Kevin Ollivier <kevino@theolliviers.com>
  57365. wx build fixes after addition of runtime and ImageBuffer changes.
  57366. * platform/graphics/wx/ImageBufferData.h: Added.
  57367. * platform/graphics/wx/ImageBufferWx.cpp:
  57368. (WebCore::ImageBufferData::ImageBufferData):
  57369. (WebCore::ImageBuffer::ImageBuffer):
  57370. (WebCore::ImageBuffer::context):
  57371. * webcore-base.bkl:
  57372. 2008-10-29 Brett Wilson <brettw@chromium.org>
  57373. Reviewed by Darin Adler
  57374. https://bugs.webkit.org/attachment.cgi?id=24745
  57375. Allow Skia implementations to get text style changed notifications.
  57376. * platform/graphics/GraphicsContext.cpp:
  57377. 2008-10-29 Timothy Hatcher <timothy@apple.com>
  57378. Add a manual test that checks breakpoints on a blockless body of
  57379. an "else" statement.
  57380. https://bugs.webkit.org/show_bug.cgi?id=21944
  57381. Reviewed by Maciej Stachowiak.
  57382. * manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
  57383. 2008-10-29 Alexey Proskuryakov <ap@webkit.org>
  57384. Reviewed by Darin Adler.
  57385. https://bugs.webkit.org/show_bug.cgi?id=21921
  57386. MessagePort messages are dispatched to documents that are not fully active
  57387. Covered by corrected fast/events/message-port-inactive-document.html
  57388. * bindings/js/JSEventListener.cpp:
  57389. (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts
  57390. that are not fully active.
  57391. 2008-10-29 Alexey Proskuryakov <ap@webkit.org>
  57392. Reviewed by Sam Weinig.
  57393. https://bugs.webkit.org/show_bug.cgi?id=21922
  57394. Expose MessagePort global constructor
  57395. Covered by existing dumper tests.
  57396. * dom/MessagePort.idl:
  57397. * page/DOMWindow.idl:
  57398. 2008-10-29 Alexey Proskuryakov <ap@webkit.org>
  57399. Reviewed by Darin Adler.
  57400. https://bugs.webkit.org/show_bug.cgi?id=21924
  57401. HashTable internal index is not always deleted
  57402. * bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
  57403. Call deleteTable for HashTables that are being deleted.
  57404. 2008-10-28 Alexey Proskuryakov <ap@webkit.org>
  57405. Reviewed by Darin Adler.
  57406. https://bugs.webkit.org/show_bug.cgi?id=21923
  57407. Create an abstraction for script execution context
  57408. * GNUmakefile.am:
  57409. * WebCore.pro:
  57410. * WebCore.vcproj/WebCore.vcproj:
  57411. * WebCore.xcodeproj/project.pbxproj:
  57412. * WebCoreSources.bkl:
  57413. Added ScriptExecutionContext.{h,cpp}.
  57414. * bindings/js/JSAudioConstructor.cpp:
  57415. (WebCore::JSAudioConstructor::JSAudioConstructor):
  57416. * bindings/js/JSAudioConstructor.h:
  57417. * bindings/js/JSImageConstructor.cpp:
  57418. (WebCore::JSImageConstructor::JSImageConstructor):
  57419. * bindings/js/JSImageConstructor.h:
  57420. * bindings/js/JSOptionConstructor.cpp:
  57421. (WebCore::JSOptionConstructor::JSOptionConstructor):
  57422. * bindings/js/JSOptionConstructor.h:
  57423. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  57424. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  57425. * bindings/js/JSXMLHttpRequestConstructor.h:
  57426. Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy.
  57427. Since these objects can only work within documents now, it is immediately converted back
  57428. to Document.
  57429. * bindings/js/JSMessageChannelConstructor.cpp:
  57430. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  57431. (WebCore::JSMessageChannelConstructor::construct):
  57432. * bindings/js/JSMessageChannelConstructor.h:
  57433. (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
  57434. MessageChannel needs to be supported in workers right away, so the constructor operates with
  57435. it directly.
  57436. * dom/ActiveDOMObject.cpp:
  57437. (WebCore::ActiveDOMObject::ActiveDOMObject):
  57438. (WebCore::ActiveDOMObject::~ActiveDOMObject):
  57439. (WebCore::ActiveDOMObject::contextDestroyed):
  57440. * dom/ActiveDOMObject.h:
  57441. (WebCore::ActiveDOMObject::scriptExecutionContext):
  57442. * bindings/js/JSDOMBinding.cpp:
  57443. (WebCore::markActiveObjectsForContext):
  57444. (WebCore::markCrossHeapDependentObjectsForContext):
  57445. Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort
  57446. tracking is handled by ScriptExecutionContext.
  57447. * bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
  57448. * bindings/js/JSDOMGlobalObject.h:
  57449. (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject.
  57450. Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible
  57451. to worker context implementation.
  57452. (WebCore::scriptExecutionContext): Added a pure virtual method to access
  57453. ScriptExecutionContext, implemented by subclasses.
  57454. * bindings/js/JSDOMWindowBase.h:
  57455. * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext):
  57456. Implement by returning the associated document. Note that this method currently gives bogus
  57457. results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document
  57458. that is currently in the frame, not the one associated with this window.
  57459. * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
  57460. * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
  57461. Call markActiveObjectsForContext() by its new name.
  57462. * dom/DedicatedWorker.cpp:
  57463. (WebCore::DedicatedWorker::DedicatedWorker):
  57464. (WebCore::DedicatedWorker::document):
  57465. * dom/DedicatedWorker.h:
  57466. * xml/XMLHttpRequest.cpp:
  57467. (WebCore::XMLHttpRequest::document):
  57468. * xml/XMLHttpRequest.h:
  57469. Added a document() function that upcasts ScriptExecutionContext, as these objects only work
  57470. within documents currently (at least for XMLHttpRequest, this will change soon though).
  57471. * dom/Document.cpp:
  57472. (WebCore::Document::Document):
  57473. (WebCore::Document::~Document):
  57474. Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code
  57475. with workers.
  57476. * dom/Document.h:
  57477. (WebCore::Document::isDocument):
  57478. (WebCore::Document::refScriptExecutionContext):
  57479. (WebCore::Document::derefScriptExecutionContext):
  57480. Inherit from ScriptExecutionContext.
  57481. * dom/MessageChannel.cpp:
  57482. (WebCore::MessageChannel::MessageChannel):
  57483. * dom/MessageChannel.h:
  57484. (WebCore::MessageChannel::create):
  57485. Use ScriptExecutionContext instead of Document.
  57486. * dom/MessagePort.cpp:
  57487. (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because
  57488. MessagePort doesn't ref() itself when posting this event any more (this is a fix for an
  57489. unrelated issue that was causing random crashes in layout tests).
  57490. (WebCore::MessagePort::MessagePort):
  57491. (WebCore::MessagePort::~MessagePort):
  57492. (WebCore::MessagePort::associatedFrame):
  57493. (WebCore::MessagePort::clone):
  57494. (WebCore::MessagePort::postMessage):
  57495. (WebCore::MessagePort::startConversation):
  57496. (WebCore::MessagePort::start):
  57497. (WebCore::MessagePort::contextDestroyed):
  57498. (WebCore::MessagePort::dispatchMessages):
  57499. * dom/MessagePort.h:
  57500. (WebCore::MessagePort::create):
  57501. (WebCore::MessagePort::scriptExecutionContext):
  57502. Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort
  57503. work in worker contexts - we need to also make some its method thread safe for cross-thread
  57504. messaging, and make event dispatching thread safe.
  57505. * dom/ScriptExecutionContext.cpp: Added.
  57506. * dom/ScriptExecutionContext.h: Added.
  57507. ActiveDOMObject and MessagePort tracking is moved from Document.
  57508. It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow,
  57509. but as I'm just moving Document code, and it is Document that is the main context object
  57510. in our implementation currently.
  57511. Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that
  57512. seem non-trivial to fix, and isn't really a part of this task.
  57513. 2008-10-28 Alp Toker <alp@nuanti.com>
  57514. List newly-added ImageBufferData.h in build system.
  57515. * GNUmakefile.am:
  57516. 2008-10-28 Alp Toker <alp@nuanti.com>
  57517. Reviewed by Cameron Zwarich.
  57518. De-list unused WebCore ForwardingHeaders to fix the dist target.
  57519. * GNUmakefile.am:
  57520. 2008-10-28 Cameron Zwarich <zwarich@apple.com>
  57521. Not reviewed.
  57522. Attempt to fix the Windows build by generating Forwardingheaders for the
  57523. runtime directory in JavaScriptCore.
  57524. * WebCore.vcproj/WebCore.vcproj:
  57525. 2008-10-28 Justin Garcia <justin.garcia@apple.com>
  57526. Reviewed by Darin Adler.
  57527. <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
  57528. * editing/Editor.cpp:
  57529. (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word.
  57530. (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which
  57531. will probably require a change more complicated than just marking the learned word as
  57532. misspelled. I'll address it with a separate patch.
  57533. * editing/EditorCommand.cpp:
  57534. (WebCore::executeIgnoreSpelling): Added.
  57535. (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.
  57536. 2008-10-28 Cameron Zwarich <zwarich@apple.com>
  57537. Reviewed by Mark Rowe.
  57538. Move ForwardingHeaders to their correct location after the creation of
  57539. the runtime directory in JavaScriptCore.
  57540. * ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
  57541. * ForwardingHeaders/kjs/BooleanObject.h: Removed.
  57542. * ForwardingHeaders/kjs/CallData.h: Removed.
  57543. * ForwardingHeaders/kjs/ConstructData.h: Removed.
  57544. * ForwardingHeaders/kjs/DateInstance.h: Removed.
  57545. * ForwardingHeaders/kjs/Error.h: Removed.
  57546. * ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
  57547. * ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
  57548. * ForwardingHeaders/kjs/InternalFunction.h: Removed.
  57549. * ForwardingHeaders/kjs/JSArray.h: Removed.
  57550. * ForwardingHeaders/kjs/JSFunction.h: Removed.
  57551. * ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
  57552. * ForwardingHeaders/kjs/JSNumberCell.h: Removed.
  57553. * ForwardingHeaders/kjs/JSObject.h: Removed.
  57554. * ForwardingHeaders/kjs/JSString.h: Removed.
  57555. * ForwardingHeaders/kjs/JSValue.h: Removed.
  57556. * ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
  57557. * ForwardingHeaders/kjs/PropertyMap.h: Removed.
  57558. * ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
  57559. * ForwardingHeaders/kjs/StringObject.h: Removed.
  57560. * ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
  57561. * ForwardingHeaders/kjs/StringPrototype.h: Removed.
  57562. * ForwardingHeaders/kjs/StructureID.h: Removed.
  57563. * ForwardingHeaders/runtime: Added.
  57564. * ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
  57565. * ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
  57566. * ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
  57567. * ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
  57568. * ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
  57569. * ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
  57570. * ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
  57571. * ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
  57572. * ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
  57573. * ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
  57574. * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
  57575. * ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
  57576. * ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
  57577. * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
  57578. * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
  57579. * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
  57580. * ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
  57581. * ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
  57582. * ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
  57583. * ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
  57584. * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
  57585. * ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
  57586. * ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
  57587. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  57588. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  57589. * bindings/js/JSClipboardCustom.cpp:
  57590. * bindings/js/JSConsoleCustom.cpp:
  57591. * bindings/js/JSCustomPositionCallback.h:
  57592. * bindings/js/JSCustomPositionErrorCallback.h:
  57593. * bindings/js/JSCustomSQLStatementCallback.h:
  57594. * bindings/js/JSCustomSQLStatementErrorCallback.h:
  57595. * bindings/js/JSCustomSQLTransactionErrorCallback.h:
  57596. * bindings/js/JSCustomVoidCallback.h:
  57597. * bindings/js/JSCustomXPathNSResolver.h:
  57598. * bindings/js/JSDOMBinding.cpp:
  57599. * bindings/js/JSDOMBinding.h:
  57600. * bindings/js/JSDOMGlobalObject.h:
  57601. * bindings/js/JSDOMWindowBase.cpp:
  57602. * bindings/js/JSDOMWindowCustom.cpp:
  57603. * bindings/js/JSDOMWindowShell.cpp:
  57604. * bindings/js/JSDatabaseCustom.cpp:
  57605. * bindings/js/JSEventListener.cpp:
  57606. * bindings/js/JSEventTarget.h:
  57607. * bindings/js/JSHTMLDocumentCustom.cpp:
  57608. * bindings/js/JSHistoryCustom.cpp:
  57609. * bindings/js/JSInspectedObjectWrapper.cpp:
  57610. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  57611. * bindings/js/JSLocationCustom.cpp:
  57612. * bindings/js/JSNodeFilterCondition.h:
  57613. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  57614. * bindings/js/JSQuarantinedObjectWrapper.h:
  57615. * bindings/js/JSXMLHttpRequestCustom.cpp:
  57616. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  57617. * bindings/objc/WebScriptObject.mm:
  57618. * bindings/objc/WebScriptObjectPrivate.h:
  57619. * bindings/scripts/CodeGeneratorJS.pm:
  57620. * bridge/NP_jsobject.cpp:
  57621. * bridge/c/c_instance.cpp:
  57622. * bridge/c/c_utility.cpp:
  57623. * bridge/c/c_utility.h:
  57624. * bridge/jni/jni_instance.cpp:
  57625. * bridge/jni/jni_jsobject.h:
  57626. * bridge/jni/jni_jsobject.mm:
  57627. * bridge/jni/jni_runtime.cpp:
  57628. * bridge/jni/jni_utility.cpp:
  57629. * bridge/jni/jni_utility.h:
  57630. * bridge/objc/objc_instance.mm:
  57631. * bridge/objc/objc_runtime.h:
  57632. * bridge/objc/objc_runtime.mm:
  57633. * bridge/objc/objc_utility.h:
  57634. * bridge/objc/objc_utility.mm:
  57635. * bridge/runtime.h:
  57636. * bridge/runtime_array.cpp:
  57637. * bridge/runtime_array.h:
  57638. * bridge/runtime_method.cpp:
  57639. * bridge/runtime_method.h:
  57640. * bridge/runtime_object.cpp:
  57641. * bridge/runtime_object.h:
  57642. * bridge/runtime_root.cpp:
  57643. * inspector/JavaScriptCallFrame.cpp:
  57644. * inspector/JavaScriptProfile.cpp:
  57645. * inspector/JavaScriptProfile.h:
  57646. * inspector/JavaScriptProfileNode.cpp:
  57647. * inspector/JavaScriptProfileNode.h:
  57648. * loader/FrameLoader.cpp:
  57649. * page/Console.cpp:
  57650. * plugins/PluginView.cpp:
  57651. * plugins/gtk/PluginViewGtk.cpp:
  57652. * plugins/qt/PluginViewQt.cpp:
  57653. * plugins/win/PluginViewWin.cpp:
  57654. 2008-10-28 Adele Peterson <adele@apple.com>
  57655. Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.
  57656. * WebCore.vcproj/WebCore.vcproj:
  57657. 2008-10-28 Adele Peterson <adele@apple.com>
  57658. Windows build fix.
  57659. * platform/graphics/ImageBuffer.h:
  57660. (WebCore::ImageBuffer::create):
  57661. 2008-10-28 Cameron Zwarich <zwarich@apple.com>
  57662. Not reviewed.
  57663. Roll out a mistaken attempt at fixing the GTK build in r37947.
  57664. * GNUmakefile.am:
  57665. 2008-10-28 Adele Peterson <adele@apple.com>
  57666. Reviewed by John Sullivan.
  57667. Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
  57668. "files" string for multifile uploads needs to be localized
  57669. * page/mac/WebCoreViewFactory.h:
  57670. * platform/LocalizedStrings.h:
  57671. * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
  57672. * platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
  57673. * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
  57674. * platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
  57675. * platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
  57676. * platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):
  57677. 2008-10-28 Brett Wilson <brettw@chromium.org>
  57678. Reviewed by Darin Adler.
  57679. https://bugs.webkit.org/show_bug.cgi?id=21816
  57680. Remove platform ifdefs in ImageBuffer.h by moving platform specific code
  57681. into a new PlatformImageBuffer class. Move the static create function
  57682. into the header because it can be cross-platform. Initialization now
  57683. happens in the cunstructor which sets a flag that create uses to know
  57684. whether it should return null or not. I also made passing of IntSize
  57685. more consistent (always by reference).
  57686. This change also changes the ifdefs in GraphicsContext to allow Skia
  57687. ports to implement text drawing modes.
  57688. * platform/graphics/ImageBuffer.h:
  57689. (WebCore::ImageBuffer::create):
  57690. (WebCore::ImageBuffer::size):
  57691. * platform/graphics/cairo/ImageBufferCairo.cpp:
  57692. (WebCore::ImageBufferData::ImageBufferData):
  57693. (WebCore::ImageBuffer::ImageBuffer):
  57694. (WebCore::ImageBuffer::~ImageBuffer):
  57695. (WebCore::ImageBuffer::image):
  57696. (WebCore::ImageBuffer::getImageData):
  57697. (WebCore::ImageBuffer::putImageData):
  57698. * platform/graphics/cairo/ImageBufferData.h:
  57699. * platform/graphics/cg/ImageBufferCG.cpp:
  57700. (WebCore::ImageBufferData::ImageBufferData):
  57701. (WebCore::ImageBuffer::ImageBuffer):
  57702. (WebCore::ImageBuffer::~ImageBuffer):
  57703. (WebCore::ImageBuffer::getImageData):
  57704. (WebCore::ImageBuffer::putImageData):
  57705. * platform/graphics/cg/ImageBufferData.h:
  57706. * platform/graphics/qt/ImageBufferData.h:
  57707. * platform/graphics/qt/ImageBufferQt.cpp:
  57708. (WebCore::ImageBufferData::ImageBufferData):
  57709. (WebCore::ImageBuffer::ImageBuffer):
  57710. (WebCore::ImageBuffer::~ImageBuffer):
  57711. 2008-10-28 Cameron Zwarich <zwarich@apple.com>
  57712. Not reviewed.
  57713. Fix the GTK build.
  57714. * GNUmakefile.am:
  57715. 2008-10-28 Cameron Zwarich <zwarich@apple.com>
  57716. Not reviewed.
  57717. Another Qt build fix.
  57718. * WebCore.pro:
  57719. 2008-10-28 Greg Bolsinga <bolsinga@apple.com>
  57720. Reviewed by David Kilzer.
  57721. https://bugs.webkit.org/show_bug.cgi?id=21932
  57722. Add non-pointer constant lookups to SoftLinking.h
  57723. * platform/mac/SoftLinking.h:
  57724. 2008-10-28 Greg Bolsinga <bolsinga@apple.com>
  57725. Reviewed by David Kilzer.
  57726. https://bugs.webkit.org/show_bug.cgi?id=2192
  57727. Missing semi-colons in Geoposition.idl
  57728. * page/Geoposition.idl: Add missing semi-colons
  57729. 2008-10-28 Timothy Hatcher <timothy@apple.com>
  57730. Make the Profiles panel in the Web Inspector have an enable screen.
  57731. Profiling now needs to be enabled before console.profile() works.
  57732. <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
  57733. not slow down JavaScript all the time
  57734. Reviewed by Darin Adler and Kevin McCullough.
  57735. * English.lproj/localizedStrings.js: New strings.
  57736. * WebCore.base.exp: New and changed exports.
  57737. * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
  57738. * bindings/js/JSDOMWindowBase.cpp:
  57739. (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
  57740. * inspector/InspectorController.cpp:
  57741. (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
  57742. Timer to call InspectorController::startUserInitiatedProfiling.
  57743. (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
  57744. that calls InspectorController::startUserInitiatedProfiling.
  57745. (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
  57746. and enable the profiler if the profiler was not enabled.
  57747. (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
  57748. (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
  57749. if the skipRecompile argument is false. Call the profilerWasEnabled script function.
  57750. (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
  57751. Call the profilerWasEnabled script function.
  57752. (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
  57753. so it won't be started later.
  57754. * inspector/InspectorController.h:
  57755. (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
  57756. * inspector/front-end/Images/debuggingButtons.png: Remove.
  57757. * inspector/front-end/Images/enableButtons.png: Added.
  57758. * inspector/front-end/Images/profilesSilhouette.png: Added.
  57759. * inspector/front-end/Images/scriptsSilhouette.png: Added.
  57760. * inspector/front-end/PanelEnablerView.js: Added.
  57761. (WebInspector.PanelEnablerView):
  57762. (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
  57763. event so listeners can do their thing.
  57764. (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
  57765. * inspector/front-end/ProfilesPanel.js:
  57766. (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
  57767. (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
  57768. (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
  57769. (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
  57770. (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
  57771. (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
  57772. (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
  57773. show/hide other buttons. Also show/hide the PanelEnablerView.
  57774. (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
  57775. (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
  57776. disableProfiler or enableProfiler.
  57777. * inspector/front-end/ScriptsPanel.js:
  57778. (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
  57779. debuggingButton with the enableToggleButton.
  57780. (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
  57781. the enableToggleButton.
  57782. (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
  57783. when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
  57784. with the enableToggleButton.
  57785. (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
  57786. (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
  57787. since reset is called from debuggerWasEnabled and debuggerWasDisabled.
  57788. * inspector/front-end/View.js: Inherit from WebInspector.Object.
  57789. * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
  57790. * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
  57791. * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
  57792. * inspector/front-end/inspector.js:
  57793. (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
  57794. (WebInspector.profilerWasDisabled): Ditto.
  57795. * page/Console.cpp:
  57796. (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
  57797. (WebCore::Console::info): Ditto.
  57798. (WebCore::Console::log): Ditto.
  57799. (WebCore::Console::assertCondition): Ditto.
  57800. (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
  57801. (WebCore::Console::count): Ditto.
  57802. (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
  57803. (WebCore::Console::profileEnd): Ditto.
  57804. (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
  57805. * page/Settings.cpp:
  57806. (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
  57807. (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
  57808. Now just sets the member boolean.
  57809. * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
  57810. 2008-10-28 Timothy Hatcher <timothy@apple.com>
  57811. Rename a few methods related to attaching and detaching the debugger. Also
  57812. adds stub methods for enabling and disabling the profiler.
  57813. * Rename attachDebugger to enableDebugger.
  57814. * Rename detachDebugger to disableDebugger.
  57815. * Rename the debuggerAttached getter to debuggerEnabled.
  57816. * Rename the debuggerAttached callback to debuggerWasEnabled.
  57817. * Rename the debuggerDetached callback to debuggerWasDisabled.
  57818. Reviewed by Darin Adler.
  57819. * WebCore.base.exp:
  57820. * inspector/InspectorController.cpp:
  57821. (WebCore::InspectorController::InspectorController):
  57822. (WebCore::InspectorController::setWindowVisible):
  57823. (WebCore::InspectorController::windowScriptObjectAvailable):
  57824. (WebCore::InspectorController::close):
  57825. (WebCore::InspectorController::enableProfiler):
  57826. (WebCore::InspectorController::disableProfiler):
  57827. (WebCore::InspectorController::enableDebugger):
  57828. (WebCore::InspectorController::disableDebugger):
  57829. (WebCore::InspectorController::pauseInDebugger):
  57830. (WebCore::InspectorController::resumeDebugger):
  57831. (WebCore::InspectorController::stepOverStatementInDebugger):
  57832. (WebCore::InspectorController::stepIntoStatementInDebugger):
  57833. (WebCore::InspectorController::stepOutOfFunctionInDebugger):
  57834. * inspector/InspectorController.h:
  57835. (WebCore::InspectorController::profilerEnabled):
  57836. (WebCore::InspectorController::debuggerEnabled):
  57837. * inspector/front-end/BreakpointsSidebarPane.js:
  57838. (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
  57839. (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
  57840. (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  57841. * inspector/front-end/Object.js:
  57842. * inspector/front-end/ProfilesPanel.js:
  57843. (WebInspector.ProfilesPanel):
  57844. * inspector/front-end/ScriptsPanel.js:
  57845. (WebInspector.ScriptsPanel):
  57846. (WebInspector.ScriptsPanel.prototype.get statusBarItems):
  57847. (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
  57848. (WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
  57849. (WebInspector.ScriptsPanel.prototype.reset):
  57850. (WebInspector.ScriptsPanel.prototype.canShowResource):
  57851. (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
  57852. (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
  57853. (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  57854. * inspector/front-end/View.js:
  57855. * inspector/front-end/inspector.css:
  57856. * inspector/front-end/inspector.html:
  57857. * inspector/front-end/inspector.js:
  57858. (WebInspector.addResource):
  57859. (WebInspector.debuggerWasEnabled):
  57860. (WebInspector.debuggerWasDisabled):
  57861. 2008-10-28 Timothy Hatcher <timothy@apple.com>
  57862. Fix an exception when searching the Resources panel while there
  57863. and resources queued to be added to the list.
  57864. Reviewed by Kevin McCullough.
  57865. * inspector/front-end/ResourcesPanel.js:
  57866. (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check
  57867. the _resourcesTreeElement property.
  57868. (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.
  57869. 2008-10-28 Alp Toker <alp@nuanti.com>
  57870. GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
  57871. isn't defined.
  57872. * platform/graphics/gtk/FontGtk.cpp:
  57873. (WebCore::getDefaultPangoLayout):
  57874. * platform/graphics/gtk/FontPlatformDataPango.cpp:
  57875. 2008-10-28 Alexey Proskuryakov <ap@webkit.org>
  57876. Reviewed by Darin Adler.
  57877. https://bugs.webkit.org/show_bug.cgi?id=21893
  57878. Character set is incorrect for external scripts in XHTML pages
  57879. <rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/
  57880. Test: fast/encoding/external-script-charset.xhtml
  57881. Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.
  57882. * dom/ScriptElement.h:
  57883. * dom/XMLTokenizerLibxml2.cpp:
  57884. (WebCore::XMLTokenizer::endElementNs):
  57885. * dom/XMLTokenizerQt.cpp:
  57886. (WebCore::XMLTokenizer::parseEndElement):
  57887. * html/HTMLScriptElement.h:
  57888. * svg/SVGScriptElement.cpp:
  57889. (WebCore::SVGScriptElement::scriptCharset):
  57890. * svg/SVGScriptElement.h:
  57891. 2008-10-28 Alp Toker <alp@nuanti.com>
  57892. Include copyright license files in the autotools dist target and
  57893. exclude unused zlib headers.
  57894. Change suggested by Mike Hommey.
  57895. * GNUmakefile.am:
  57896. 2008-10-27 Sam Weinig <sam@webkit.org>
  57897. Reviewed by Maciej Stachowiak.
  57898. Clear the window shell when destroying a page to allow documents
  57899. which have no way of being reached anymore, to be torn down.
  57900. * page/Frame.cpp:
  57901. (WebCore::Frame::pageDestroyed):
  57902. 2008-10-27 Kevin Watters <kevinwatters@gmail.com>
  57903. Reviewed by Kevin Ollivier.
  57904. Update the active state as well as the focused state as both need to be true
  57905. for the caret to be drawn.
  57906. https://bugs.webkit.org/show_bug.cgi?id=21900
  57907. * WebView.cpp:
  57908. (wxWebView::OnSetFocus):
  57909. (wxWebView::OnKillFocus):
  57910. 2008-10-27 Kevin Ollivier <kevino@theolliviers.com>
  57911. wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
  57912. * webcore-wx.bkl:
  57913. 2008-10-27 Michael Knaup <michael.knaup@mac.com>
  57914. Reviewed and tweaked by Darin Adler.
  57915. - https://bugs.webkit.org/show_bug.cgi?id=8988
  57916. Bug 8988: Add support for Mozilla CSS custom cursors.
  57917. Added -webkit-grab and -webkit-grabbing cursor suppport
  57918. for the Mac, dummy implementations for other platforms.
  57919. * css/CSSParser.cpp:
  57920. (WebCore::CSSParser::parseValue): Updated since the
  57921. -webkit-grabbing cursor is now the last one.
  57922. * css/CSSPrimitiveValueMappings.h:
  57923. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added
  57924. CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  57925. * css/CSSValueKeywords.in: Added -webkit-grab and
  57926. -webkit-grabbing.
  57927. * manual-tests/cursor.html: Added -webkit-zoom-in,
  57928. webkit-zoom-out, -webkit-grab, and -webkit-grabbing.
  57929. * page/EventHandler.cpp:
  57930. (WebCore::EventHandler::selectCursor): Added
  57931. CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  57932. * platform/Cursor.h: Added grabCursor and grabbingCursor.
  57933. * platform/gtk/CursorGtk.cpp:
  57934. (WebCore::grabCursor): Added.
  57935. (WebCore::grabbingCursor): Added.
  57936. * platform/mac/CursorMac.mm:
  57937. (WebCore::grabCursor): Added.
  57938. (WebCore::grabbingCursor): Added.
  57939. * platform/qt/CursorQt.cpp:
  57940. (WebCore::grabCursor): Added.
  57941. (WebCore::grabbingCursor): Added.
  57942. * platform/win/CursorWin.cpp:
  57943. (WebCore::grabCursor): Added.
  57944. (WebCore::grabbingCursor): Added.
  57945. * platform/wx/CursorWx.cpp:
  57946. (WebCore::grabCursor): Added.
  57947. (WebCore::grabbingCursor): Added.
  57948. * rendering/style/RenderStyleConstants.h:
  57949. Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  57950. Also broke ECursor out into a single constant per line.
  57951. Also added a couple of comments.
  57952. 2008-10-27 Dimitri Glazkov <dglazkov@chromium.org>
  57953. Reviewed by Darin Adler.
  57954. * svg/SVGAnimatedTemplate.h: needed a HashMap define
  57955. 2008-10-21 Eric Seidel <eric@webkit.org>
  57956. Reviewed by Dave Hyatt.
  57957. Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
  57958. https://bugs.webkit.org/show_bug.cgi?id=20400
  57959. Test: svg/custom/stop-crash.svg
  57960. * WebCore.xcodeproj/project.pbxproj:
  57961. * rendering/RenderSVGGradientStop.h:
  57962. (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):
  57963. 2008-10-27 Anders Carlsson <andersca@apple.com>
  57964. Reviewed by Sam Weinig.
  57965. No need to call release if the connection is null.
  57966. * platform/network/mac/ResourceHandleMac.mm:
  57967. (WebCore::ResourceHandle::start):
  57968. 2008-10-27 Anders Carlsson <andersca@apple.com>
  57969. Reviewed by Kevin Decker.
  57970. <rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html
  57971. Make sure to null check the NSURLConnection object.
  57972. * platform/network/mac/ResourceHandleMac.mm:
  57973. (WebCore::ResourceHandle::start):
  57974. (WebCore::ResourceHandle::setDefersLoading):
  57975. 2008-10-27 Alexey Proskuryakov <ap@webkit.org>
  57976. Fix non-Mac builds.
  57977. * GNUmakefile.am:
  57978. * WebCore.pro:
  57979. * WebCore.vcproj/WebCore.vcproj:
  57980. * WebCoreSources.bkl:
  57981. Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
  57982. 2008-10-26 Alexey Proskuryakov <ap@webkit.org>
  57983. Reviewed by Sam Weinig.
  57984. https://bugs.webkit.org/show_bug.cgi?id=21886
  57985. window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor
  57986. Test: fast/dom/HTMLOptionElement/option-prototype.html
  57987. We now have separate objects for window.Option and window.HTMLOptionElement - the latter
  57988. "constructor" cannot be used to construct anything. This matches Firefox behavior.
  57989. * WebCore.xcodeproj/project.pbxproj:
  57990. * bindings/js/JSDOMWindowBase.cpp:
  57991. (jsDOMWindowBaseOption):
  57992. * bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
  57993. * bindings/js/JSHTMLOptionElementConstructor.h: Removed.
  57994. * bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
  57995. * bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
  57996. * html/HTMLOptionElement.idl:
  57997. Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
  57998. * html/HTMLOptionElement.idl: Generate a constructor.
  57999. 2008-10-25 Geoffrey Garen <ggaren@apple.com>
  58000. Not reviewed.
  58001. Try to fix Mac debug build on the buildbot.
  58002. * platform/FileChooser.cpp:
  58003. (WebCore::FileChooserClient::~FileChooserClient):
  58004. * platform/FileChooser.h: Moved destructor to .cpp file, to avoid a
  58005. weak exported symbol.
  58006. 2008-10-25 Jade Han <jade.han@nokia.com>
  58007. Reviewed by Anders.
  58008. Enable custom properties for Qt runtime objects in QtWebKit
  58009. https://bugs.webkit.org/show_bug.cgi?id=21813
  58010. * bridge/runtime_object.cpp:
  58011. (JSC::RuntimeObjectImp::getOwnPropertySlot):
  58012. (JSC::RuntimeObjectImp::put):
  58013. 2008-10-24 Sam Weinig <sam@webkit.org>
  58014. Fix windows build.
  58015. * page/Chrome.cpp:
  58016. * page/Chrome.h:
  58017. 2008-10-24 Sam Weinig <sam@webkit.org>
  58018. Fix Qt build.
  58019. * platform/qt/FileChooserQt.cpp:
  58020. 2008-10-24 Sam Weinig <sam@webkit.org>
  58021. Reviewed by Dan Bernstein.
  58022. Fix https://bugs.webkit.org/show_bug.cgi?id=21759
  58023. Layering violation: FileChooser should not depend on Document/Frame/Page
  58024. Move file choosing into WebKit ChromeClient.
  58025. * loader/EmptyClients.h:
  58026. (WebCore::EmptyChromeClient::runOpenPanel):
  58027. * page/Chrome.cpp:
  58028. (WebCore::Chrome::runOpenPanel):
  58029. * page/Chrome.h:
  58030. * page/ChromeClient.h:
  58031. * page/mac/ChromeMac.mm:
  58032. * platform/FileChooser.h:
  58033. * platform/mac/FileChooserMac.mm:
  58034. * platform/qt/FileChooserQt.cpp:
  58035. * platform/win/FileChooserWin.cpp:
  58036. * platform/wx/TemporaryLinkStubs.cpp:
  58037. * rendering/RenderFileUploadControl.cpp:
  58038. (WebCore::RenderFileUploadControl::click):
  58039. 2008-10-24 Kevin Ollivier <kevino@theolliviers.com>
  58040. wx build fix - add newIconForFiles stub.
  58041. * platform/wx/TemporaryLinkStubs.cpp:
  58042. (Icon::newIconForFiles):
  58043. 2008-10-24 Kevin Watters <kevinwatters@gmail.com>
  58044. Reviewed by Kevin Ollivier.
  58045. Use the CGFont metrics APIs for more accurate measurements, and tweak the y
  58046. value the text is drawn at (it was a couple pixels off before because wx
  58047. internally adds to the y value.
  58048. https://bugs.webkit.org/show_bug.cgi?id=21853
  58049. * platform/wx/wxcode/mac/carbon/fontprops.cpp:
  58050. (wxFontProperties::wxFontProperties):
  58051. * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
  58052. (WebCore::drawTextWithSpacing):
  58053. 2008-10-24 Eric Seidel <eric@webkit.org>
  58054. Reviewed by Sam Weinig.
  58055. Generate missing constructors and add test to prevent missing ones in the future
  58056. https://bugs.webkit.org/show_bug.cgi?id=21846
  58057. Test: fast/js/global-constructors.html
  58058. * css/CSSStyleSheet.idl:
  58059. * css/RGBColor.idl:
  58060. * dom/NodeIterator.idl:
  58061. * dom/TreeWalker.idl:
  58062. * xml/XPathExpression.idl:
  58063. 2008-10-24 Alexey Proskuryakov <ap@webkit.org>
  58064. Reviewed by Darin Adler.
  58065. https://bugs.webkit.org/show_bug.cgi?id=21836
  58066. REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly
  58067. Test: http/tests/xmlhttprequest/detaching-frame.html
  58068. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window -
  58069. even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected
  58070. when dispatching the same callback that results in this function being called.
  58071. 2008-10-24 David Kilzer <ddkilzer@apple.com>
  58072. Gtk build fix.
  58073. * platform/gtk/TemporaryLinkStubs.cpp:
  58074. (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
  58075. 2008-10-24 Mark Rowe <mrowe@apple.com>
  58076. Reviewed by Sam Weinig.
  58077. <rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.
  58078. * platform/graphics/cg/GraphicsContextCG.cpp:
  58079. (WebCore::GraphicsContext::setImageInterpolationQuality):
  58080. (WebCore::GraphicsContext::imageInterpolationQuality):
  58081. 2008-10-24 Anders Carlsson <andersca@apple.com>
  58082. Reviewed by Sam Weinig.
  58083. <rdar://problem/5440917> Support NPN_Construct
  58084. * WebCore.NPAPI.exp:
  58085. Export _NPN_Construct.
  58086. * bridge/NP_jsobject.cpp:
  58087. (_NPN_Construct):
  58088. Implement this.
  58089. * bridge/c/c_instance.cpp:
  58090. (JSC::Bindings::CInstance::supportsConstruct):
  58091. (JSC::Bindings::CInstance::invokeConstruct):
  58092. Have this call the appropriate NPClass method.
  58093. * bridge/npruntime.h:
  58094. Add NPN_Construct.
  58095. * bridge/npruntime_impl.h:
  58096. Add _NPN_Construct.
  58097. * bridge/runtime.h:
  58098. (JSC::Bindings::Instance::supportsConstruct):
  58099. (JSC::Bindings::Instance::invokeConstruct):
  58100. New methods.
  58101. * bridge/runtime_object.cpp:
  58102. (JSC::callRuntimeConstructor):
  58103. Call the native instance.
  58104. (JSC::RuntimeObjectImp::getConstructData):
  58105. Implement this.
  58106. * bridge/runtime_object.h:
  58107. Add new method declarations.
  58108. * plugins/gtk/PluginPackageGtk.cpp:
  58109. (WebCore::PluginPackage::load):
  58110. * plugins/qt/PluginPackageQt.cpp:
  58111. (WebCore::PluginPackage::load):
  58112. * plugins/win/PluginPackageWin.cpp:
  58113. (WebCore::PluginPackage::load):
  58114. Initialize m_pluginFuncs.construct.
  58115. 2008-10-24 Adele Peterson <adele@apple.com>
  58116. Build fix.
  58117. * platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
  58118. * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):
  58119. 2008-10-24 Greg Bolsinga <bolsinga@apple.com>
  58120. Fix GTK build break.
  58121. Reviewed by David Kilzer.
  58122. * GNUmakefile.am: Do not include .idl files whose generated files should not be
  58123. compiled.
  58124. 2008-10-24 David Kilzer <ddkilzer@apple.com>
  58125. Wx build fix.
  58126. * platform/wx/TemporaryLinkStubs.cpp:
  58127. (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
  58128. 2008-10-24 Adele Peterson <adele@apple.com>
  58129. Reviewed by Sam Weinig.
  58130. WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
  58131. This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
  58132. This is consistent with the direction HTML5 will be going in the future.
  58133. The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
  58134. the individual files in a tooltip for now. Improvements to this control will come later.
  58135. Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
  58136. These FileList Files can also be sent in an XMLHTTPRequest.
  58137. * manual-tests/post-multi-file-upload.html: Added.
  58138. * manual-tests/resources/multiFileResources: Added.
  58139. * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
  58140. * manual-tests/resources/multiFileResources/testFile1.html: Added.
  58141. * manual-tests/resources/multiFileResources/testFile2.html: Added.
  58142. * manual-tests/resources/multiFileResources/testFile3.html: Added.
  58143. * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
  58144. * html/HTMLInputElement.cpp:
  58145. (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
  58146. (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control,
  58147. but we don't want to break the behavior for existing websites that may rely on this.
  58148. (WebCore::HTMLInputElement::setValue): ditto.
  58149. (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
  58150. (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
  58151. * html/HTMLInputElement.h:
  58152. * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
  58153. * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
  58154. * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
  58155. (WebCore::FileChooser::FileChooser):
  58156. (WebCore::FileChooser::create):
  58157. (WebCore::FileChooser::clear):
  58158. (WebCore::FileChooser::chooseFile):
  58159. (WebCore::FileChooser::chooseFiles):
  58160. (WebCore::FileChooser::chooseIcon):
  58161. * platform/FileChooser.h:
  58162. (WebCore::FileChooser::filePaths):
  58163. (WebCore::FileChooser::allowsMultipleFiles):
  58164. * platform/graphics/Icon.h:
  58165. * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
  58166. * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
  58167. * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
  58168. * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
  58169. * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
  58170. * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
  58171. * platform/qt/FileChooserQt.cpp:
  58172. (WebCore::FileChooser::openFileChooser):
  58173. (WebCore::FileChooser::basenameForWidth):
  58174. * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
  58175. * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
  58176. Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel
  58177. both get called for the same ResourceHandle. This getting called twice has no negative effect.
  58178. * rendering/RenderFileUploadControl.cpp:
  58179. (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer.
  58180. (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added.
  58181. (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser.
  58182. (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
  58183. * rendering/RenderFileUploadControl.h:
  58184. 2008-10-23 Peter Kasting <pkasting@google.com>
  58185. Reviewed by David Hyatt.
  58186. https://bugs.webkit.org/show_bug.cgi?id=21844
  58187. Remove setFocusRingColorChangeFunction.
  58188. * page/Page.cpp:
  58189. (WebCore::Page::Page):
  58190. * platform/graphics/Color.h:
  58191. * platform/graphics/mac/ColorMac.mm:
  58192. (WebCore::focusRingColor):
  58193. * platform/graphics/qt/GraphicsContextQt.cpp:
  58194. * platform/graphics/win/ColorSafari.cpp:
  58195. 2008-10-24 David Kilzer <ddkilzer@apple.com>
  58196. Build fix for Qt.
  58197. Reviewed by Greg.
  58198. * WebCore.pro: Added missing *.idl files.
  58199. 2008-10-24 Greg Bolsinga <bolsinga@apple.com>
  58200. Reviewed by Sam Weinig.
  58201. https://bugs.webkit.org/show_bug.cgi?id=21475
  58202. Provide support for the Geolocation API
  58203. http://dev.w3.org/geo/api/spec-source.html
  58204. Test: geolocation/geolocation-not-implemented.html
  58205. * DerivedSources.make:
  58206. * GNUmakefile.am: Added Geolocation support
  58207. * WebCore.pro: Added Geolocation support
  58208. * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
  58209. * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
  58210. * WebCoreSources.bkl: Added Geolocation support
  58211. * bindings/js/JSCustomPositionCallback.cpp: Added.
  58212. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
  58213. (WebCore::JSCustomPositionCallback::handleEvent):
  58214. * bindings/js/JSCustomPositionCallback.h: Added.
  58215. (WebCore::JSCustomPositionCallback::create):
  58216. * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
  58217. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
  58218. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  58219. * bindings/js/JSCustomPositionErrorCallback.h: Added.
  58220. (WebCore::JSCustomPositionErrorCallback::create):
  58221. * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
  58222. (WebCore::markDOMObjectWrapper):
  58223. * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
  58224. * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
  58225. * bindings/js/JSGeolocationCustom.cpp: Added.
  58226. (WebCore::JSGeolocation::getCurrentPosition):
  58227. (WebCore::JSGeolocation::watchPosition):
  58228. * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
  58229. (WebCore::JSNavigator::mark):
  58230. * dom/Document.cpp:
  58231. (WebCore::Document::Document):
  58232. * dom/Document.h:
  58233. (WebCore::Document::setUsingGeolocation):
  58234. (WebCore::Document::usingGeolocation):
  58235. * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
  58236. (WebCore::FrameLoader::canCachePage):
  58237. * page/Geolocation.cpp: Added.
  58238. (WebCore::Geolocation::GeoNotifier::GeoNotifier):
  58239. (WebCore::Geolocation::GeoNotifier::timerFired):
  58240. (WebCore::Geolocation::Geolocation):
  58241. (WebCore::Geolocation::disconnectFrame):
  58242. (WebCore::Geolocation::getCurrentPosition):
  58243. (WebCore::Geolocation::watchPosition):
  58244. (WebCore::Geolocation::clearWatch):
  58245. (WebCore::Geolocation::stopUpdatingIfEmpty):
  58246. (WebCore::Geolocation::sendErrorToOneShots):
  58247. (WebCore::Geolocation::sendErrorToWatchers):
  58248. (WebCore::Geolocation::sendPositionToOneShots):
  58249. (WebCore::Geolocation::sendPositionToWatchers):
  58250. (WebCore::Geolocation::handleError):
  58251. (WebCore::Geolocation::geolocationServicePositionChanged):
  58252. (WebCore::Geolocation::geolocationServiceErrorOccurred):
  58253. * page/Geolocation.h: Added.
  58254. (WebCore::Geolocation::create):
  58255. (WebCore::Geolocation::~Geolocation):
  58256. (WebCore::Geolocation::lastPosition):
  58257. (WebCore::Geolocation::GeoNotifier::create):
  58258. * page/Geolocation.idl: Added.
  58259. * page/Geoposition.cpp: Added.
  58260. (WebCore::Geoposition::toString):
  58261. * page/Geoposition.h: Added.
  58262. (WebCore::Geoposition::create):
  58263. (WebCore::Geoposition::latitude):
  58264. (WebCore::Geoposition::longitude):
  58265. (WebCore::Geoposition::altitude):
  58266. (WebCore::Geoposition::accuracy):
  58267. (WebCore::Geoposition::altitudeAccuracy):
  58268. (WebCore::Geoposition::heading):
  58269. (WebCore::Geoposition::velocity):
  58270. (WebCore::Geoposition::timestamp):
  58271. (WebCore::Geoposition::Geoposition):
  58272. * page/Geoposition.idl: Added.
  58273. * page/Navigator.cpp:
  58274. (WebCore::Navigator::disconnectFrame): disconnect Geolocation
  58275. (WebCore::Navigator::geolocation): accessor for Geolocation
  58276. * page/Navigator.h:
  58277. (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
  58278. * page/Navigator.idl: accessor for Geolocation
  58279. * page/PositionCallback.h: Added.
  58280. (WebCore::PositionCallback::~PositionCallback):
  58281. * page/PositionCallback.idl: Added.
  58282. * page/PositionError.h: Added.
  58283. (WebCore::PositionError::):
  58284. (WebCore::PositionError::create):
  58285. (WebCore::PositionError::code):
  58286. (WebCore::PositionError::message):
  58287. (WebCore::PositionError::PositionError):
  58288. * page/PositionError.idl: Added.
  58289. * page/PositionErrorCallback.h: Added.
  58290. (WebCore::PositionErrorCallback::~PositionErrorCallback):
  58291. * page/PositionErrorCallback.idl: Added.
  58292. * page/PositionOptions.h: Added.
  58293. (WebCore::PositionOptions::create):
  58294. (WebCore::PositionOptions::enableHighAccuracy):
  58295. (WebCore::PositionOptions::setEnableHighAccuracy):
  58296. (WebCore::PositionOptions::timeout):
  58297. (WebCore::PositionOptions::setTimeout):
  58298. (WebCore::PositionOptions::PositionOptions):
  58299. * page/PositionOptions.idl: Added.
  58300. * platform/GeolocationService.cpp: Added.
  58301. (WebCore::GeolocationService::GeolocationService):
  58302. (WebCore::GeolocationService::positionChanged):
  58303. (WebCore::GeolocationService::errorOccurred):
  58304. * platform/GeolocationService.h: Added.
  58305. (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
  58306. (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
  58307. (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
  58308. (WebCore::GeolocationService::~GeolocationService):
  58309. 2008-10-24 Simon Fraser <simon.fraser@apple.com>
  58310. Reviewed by Darin Adler
  58311. https://bugs.webkit.org/show_bug.cgi?id=21818
  58312. Add HashTraits for AtomicString so that AtomicString can be used as
  58313. the key for a HashMap or HashSet.
  58314. * GNUmakefile.am: add AtomicStringHash.h
  58315. * WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
  58316. * WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
  58317. * platform/text/AtomicString.h:
  58318. (WebCore::AtomicString::AtomicString):
  58319. (WebCore::AtomicString::isHashTableDeletedValue):
  58320. specialize DefaultHash for AtomicString to use AtomicStringHash
  58321. * platform/text/AtomicStringHash.h: Added.
  58322. * platform/text/StringImpl.cpp:
  58323. (WebCore::StringImpl::StringImpl):
  58324. compute the hash up-front for the empty string
  58325. * platform/text/StringImpl.h:
  58326. (WebCore::StringImpl::existingHash):
  58327. method to get the hash without a test and branch, for callers like
  58328. AtomicStringHash who can guarantee that the hash has already been computed.
  58329. 2008-10-24 Simon Fraser <simon.fraser@apple.com>
  58330. Reviewed by Sam Weinig
  58331. https://bugs.webkit.org/show_bug.cgi?id=21857
  58332. Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
  58333. switch in _wrapCSSRule.
  58334. * bindings/objc/DOMCSS.mm:
  58335. (+[DOMCSSRule _wrapCSSRule:WebCore::]):
  58336. 2008-10-24 Adam Roben <aroben@apple.com>
  58337. Windows build fix
  58338. * plugins/PluginView.cpp:
  58339. 2008-10-24 Dan Bernstein <mitz@apple.com>
  58340. Reviewed by Sam Weinig.
  58341. - fix https://bugs.webkit.org/show_bug.cgi?id=21851
  58342. <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height
  58343. Test: fast/replaced/percent-height-in-anonymous-block-widget.html
  58344. * rendering/RenderWidget.cpp:
  58345. (WebCore::RenderWidget::destroy): Copied code added to
  58346. RenderBox::destroy() in r36513 into this function.
  58347. 2008-10-24 Timothy Hatcher <timothy@apple.com>
  58348. Add a mechanism to ask the InspectorClient for key/value setting pairs.
  58349. These settings can be strings, numbers, booleans or string vectors. The
  58350. settings are also bridged to and from JavaScript.
  58351. https://bugs.webkit.org/show_bug.cgi?id=21856
  58352. Reviewed by Darin Adler.
  58353. * WebCore.base.exp: Expose the String CFStringRef constructor.
  58354. * inspector/InspectorClient.h:
  58355. (WebCore::InspectorClient::populateSetting): Added, pure virtual.
  58356. (WebCore::InspectorClient::storeSetting): Ditto.
  58357. (WebCore::InspectorClient::removeSetting): Ditto.
  58358. * inspector/InspectorController.cpp:
  58359. (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
  58360. (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
  58361. (WebCore::InspectorController::InspectorController): Increment a global static
  58362. to track the number of live InspectorControllers.
  58363. (WebCore::InspectorController::~InspectorController): Decrement the global static
  58364. that tracks the number of live InspectorControllers. Delete the setting cache if there
  58365. are no more live controllers.
  58366. (WebCore::InspectorController::setting): Check the cache and return the setting from there,
  58367. otherwise make a new Setting and ask the client to populate it.
  58368. (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
  58369. (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
  58370. to the InspectorController script class.
  58371. * inspector/InspectorController.h:
  58372. (WebCore::InspectorController::Setting::Setting):
  58373. (WebCore::InspectorController::Setting::operator=):
  58374. (WebCore::InspectorController::Setting::type): Return m_type.
  58375. (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
  58376. (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
  58377. Assert the type is correct.
  58378. (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
  58379. Assert the type is correct.
  58380. (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
  58381. Assert the type is correct.
  58382. (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
  58383. Assert the type is correct.
  58384. (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
  58385. field and the type.
  58386. * loader/EmptyClients.h:
  58387. (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
  58388. (WebCore::EmptyInspectorClient::storeSetting): Ditto.
  58389. (WebCore::EmptyInspectorClient::removeSetting): Ditto.
  58390. 2008-10-24 Cameron Zwarich <zwarich@apple.com>
  58391. Reviewed by Sam Weinig.
  58392. Remove some C-style casts.
  58393. * html/HTMLViewSourceDocument.cpp:
  58394. (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  58395. 2008-10-24 Darin Adler <darin@apple.com>
  58396. - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
  58397. * bindings/js/JSAttrCustom.cpp:
  58398. * bindings/js/JSCSSRuleCustom.cpp:
  58399. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  58400. * bindings/js/JSCSSValueCustom.cpp:
  58401. * bindings/js/JSCanvasPixelArrayCustom.h:
  58402. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  58403. * bindings/js/JSClipboardCustom.cpp:
  58404. * bindings/js/JSConsoleCustom.cpp:
  58405. * bindings/js/JSCustomSQLStatementCallback.cpp:
  58406. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  58407. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  58408. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  58409. * bindings/js/JSCustomVoidCallback.cpp:
  58410. * bindings/js/JSCustomVoidCallback.h:
  58411. * bindings/js/JSCustomXPathNSResolver.cpp:
  58412. * bindings/js/JSCustomXPathNSResolver.h:
  58413. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  58414. * bindings/js/JSDOMBinding.cpp:
  58415. * bindings/js/JSDOMBinding.h:
  58416. * bindings/js/JSDOMWindowBase.cpp:
  58417. * bindings/js/JSDOMWindowBase.h:
  58418. * bindings/js/JSDOMWindowCustom.cpp:
  58419. * bindings/js/JSDOMWindowCustom.h:
  58420. * bindings/js/JSDOMWindowShell.cpp:
  58421. * bindings/js/JSDOMWindowShell.h:
  58422. * bindings/js/JSDatabaseCustom.cpp:
  58423. * bindings/js/JSDedicatedWorkerCustom.cpp:
  58424. * bindings/js/JSDocumentCustom.cpp:
  58425. * bindings/js/JSElementCustom.cpp:
  58426. * bindings/js/JSEventCustom.cpp:
  58427. * bindings/js/JSEventListener.cpp:
  58428. * bindings/js/JSEventTarget.cpp:
  58429. * bindings/js/JSEventTarget.h:
  58430. * bindings/js/JSEventTargetBase.h:
  58431. * bindings/js/JSEventTargetNodeCustom.cpp:
  58432. * bindings/js/JSHTMLAllCollection.h:
  58433. * bindings/js/JSHTMLAppletElementCustom.cpp:
  58434. * bindings/js/JSHTMLCollectionCustom.cpp:
  58435. * bindings/js/JSHTMLDocumentCustom.cpp:
  58436. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  58437. * bindings/js/JSHTMLFormElementCustom.cpp:
  58438. * bindings/js/JSHTMLFrameElementCustom.cpp:
  58439. * bindings/js/JSHTMLFrameSetElementCustom.cpp:
  58440. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  58441. * bindings/js/JSHTMLInputElementCustom.cpp:
  58442. * bindings/js/JSHTMLObjectElementCustom.cpp:
  58443. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  58444. * bindings/js/JSHTMLSelectElementCustom.cpp:
  58445. * bindings/js/JSHTMLSelectElementCustom.h:
  58446. * bindings/js/JSHistoryCustom.cpp:
  58447. * bindings/js/JSImageDataCustom.cpp:
  58448. * bindings/js/JSInspectedObjectWrapper.cpp:
  58449. * bindings/js/JSInspectedObjectWrapper.h:
  58450. * bindings/js/JSInspectorCallbackWrapper.cpp:
  58451. * bindings/js/JSInspectorCallbackWrapper.h:
  58452. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  58453. * bindings/js/JSLocationCustom.cpp:
  58454. * bindings/js/JSMessagePortCustom.cpp:
  58455. * bindings/js/JSMimeTypeArrayCustom.cpp:
  58456. * bindings/js/JSNamedNodeMapCustom.cpp:
  58457. * bindings/js/JSNamedNodesCollection.cpp:
  58458. * bindings/js/JSNamedNodesCollection.h:
  58459. * bindings/js/JSNavigatorCustom.cpp:
  58460. * bindings/js/JSNodeCustom.cpp:
  58461. * bindings/js/JSNodeFilterCondition.cpp:
  58462. * bindings/js/JSNodeFilterCondition.h:
  58463. * bindings/js/JSNodeFilterCustom.cpp:
  58464. * bindings/js/JSNodeIteratorCustom.cpp:
  58465. * bindings/js/JSNodeListCustom.cpp:
  58466. * bindings/js/JSPluginArrayCustom.cpp:
  58467. * bindings/js/JSPluginCustom.cpp:
  58468. * bindings/js/JSPluginElementFunctions.cpp:
  58469. * bindings/js/JSPluginElementFunctions.h:
  58470. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  58471. * bindings/js/JSQuarantinedObjectWrapper.h:
  58472. * bindings/js/JSRGBColor.cpp:
  58473. * bindings/js/JSRGBColor.h:
  58474. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  58475. * bindings/js/JSSQLTransactionCustom.cpp:
  58476. * bindings/js/JSSVGElementInstanceCustom.cpp:
  58477. * bindings/js/JSSVGLengthCustom.cpp:
  58478. * bindings/js/JSSVGMatrixCustom.cpp:
  58479. * bindings/js/JSSVGPathSegCustom.cpp:
  58480. * bindings/js/JSSVGPathSegListCustom.cpp:
  58481. * bindings/js/JSSVGPointListCustom.cpp:
  58482. * bindings/js/JSSVGTransformListCustom.cpp:
  58483. * bindings/js/JSStorageCustom.cpp:
  58484. * bindings/js/JSStyleSheetCustom.cpp:
  58485. * bindings/js/JSStyleSheetListCustom.cpp:
  58486. * bindings/js/JSTextCustom.cpp:
  58487. * bindings/js/JSTreeWalkerCustom.cpp:
  58488. * bindings/js/JSXMLHttpRequestCustom.cpp:
  58489. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  58490. * bindings/js/JSXSLTProcessorCustom.cpp:
  58491. * bindings/js/ScheduledAction.cpp:
  58492. * bindings/js/ScheduledAction.h:
  58493. * bindings/js/ScriptController.cpp:
  58494. * bindings/js/ScriptController.h:
  58495. * bindings/objc/WebScriptObject.mm:
  58496. * bindings/objc/WebScriptObjectPrivate.h:
  58497. * bindings/scripts/CodeGeneratorJS.pm:
  58498. * bridge/NP_jsobject.cpp:
  58499. * bridge/c/c_instance.cpp:
  58500. * bridge/c/c_instance.h:
  58501. * bridge/c/c_runtime.cpp:
  58502. * bridge/c/c_runtime.h:
  58503. * bridge/c/c_utility.cpp:
  58504. * bridge/c/c_utility.h:
  58505. * bridge/jni/jni_instance.cpp:
  58506. * bridge/jni/jni_instance.h:
  58507. * bridge/jni/jni_jsobject.h:
  58508. * bridge/jni/jni_jsobject.mm:
  58509. * bridge/jni/jni_objc.mm:
  58510. * bridge/jni/jni_runtime.cpp:
  58511. * bridge/jni/jni_runtime.h:
  58512. * bridge/jni/jni_utility.cpp:
  58513. * bridge/jni/jni_utility.h:
  58514. * bridge/objc/WebScriptObject.h:
  58515. * bridge/objc/objc_class.h:
  58516. * bridge/objc/objc_class.mm:
  58517. * bridge/objc/objc_instance.h:
  58518. * bridge/objc/objc_instance.mm:
  58519. * bridge/objc/objc_runtime.h:
  58520. * bridge/objc/objc_runtime.mm:
  58521. * bridge/objc/objc_utility.h:
  58522. * bridge/objc/objc_utility.mm:
  58523. * bridge/qt/qt_class.cpp:
  58524. * bridge/qt/qt_class.h:
  58525. * bridge/qt/qt_instance.cpp:
  58526. * bridge/qt/qt_instance.h:
  58527. * bridge/qt/qt_runtime.cpp:
  58528. * bridge/qt/qt_runtime.h:
  58529. * bridge/runtime.cpp:
  58530. * bridge/runtime.h:
  58531. * bridge/runtime_array.cpp:
  58532. * bridge/runtime_array.h:
  58533. * bridge/runtime_method.cpp:
  58534. * bridge/runtime_method.h:
  58535. * bridge/runtime_object.cpp:
  58536. * bridge/runtime_object.h:
  58537. * bridge/testqtbindings.cpp:
  58538. * inspector/JavaScriptCallFrame.cpp:
  58539. * inspector/JavaScriptCallFrame.h:
  58540. * inspector/JavaScriptProfile.cpp:
  58541. * inspector/JavaScriptProfile.h:
  58542. * inspector/JavaScriptProfileNode.cpp:
  58543. * inspector/JavaScriptProfileNode.h:
  58544. * loader/FrameLoader.cpp:
  58545. * loader/FrameLoader.h:
  58546. * page/Console.cpp:
  58547. * page/Console.h:
  58548. * plugins/MimeTypeArray.h:
  58549. * plugins/Plugin.h:
  58550. * plugins/PluginArray.h:
  58551. * plugins/PluginView.cpp:
  58552. * xml/XMLHttpRequest.cpp:
  58553. Use JSValue* instead of JSValuePtr.
  58554. 2008-10-24 Simon Hausmann <hausmann@webkit.org>
  58555. Fix the Qt build.
  58556. * bridge/qt/qt_instance.cpp:
  58557. (JSC::Bindings::QtField::valueFromInstance):
  58558. 2008-10-24 David Kilzer <ddkilzer@apple.com>
  58559. Rolled out r37840 and r37841.
  58560. * DerivedSources.make:
  58561. * GNUmakefile.am:
  58562. * WebCore.pro:
  58563. * WebCore.vcproj/WebCore.vcproj:
  58564. * WebCore.xcodeproj/project.pbxproj:
  58565. * WebCoreSources.bkl:
  58566. * bindings/js/JSCustomPositionCallback.cpp: Removed.
  58567. * bindings/js/JSCustomPositionCallback.h: Removed.
  58568. * bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
  58569. * bindings/js/JSCustomPositionErrorCallback.h: Removed.
  58570. * bindings/js/JSDOMBinding.cpp:
  58571. * bindings/js/JSDOMBinding.h:
  58572. * bindings/js/JSDOMWindowCustom.cpp:
  58573. (WebCore::markDOMObjectWrapper):
  58574. * bindings/js/JSGeolocationCustom.cpp: Removed.
  58575. * bindings/js/JSNavigatorCustom.cpp:
  58576. * dom/Document.cpp:
  58577. (WebCore::Document::Document):
  58578. * dom/Document.h:
  58579. * loader/FrameLoader.cpp:
  58580. (WebCore::FrameLoader::canCachePage):
  58581. * page/Geolocation.cpp: Removed.
  58582. * page/Geolocation.h: Removed.
  58583. * page/Geolocation.idl: Removed.
  58584. * page/Geoposition.cpp: Removed.
  58585. * page/Geoposition.h: Removed.
  58586. * page/Geoposition.idl: Removed.
  58587. * page/Navigator.cpp:
  58588. (WebCore::Navigator::disconnectFrame):
  58589. * page/Navigator.h:
  58590. * page/Navigator.idl:
  58591. * page/PositionCallback.h: Removed.
  58592. * page/PositionCallback.idl: Removed.
  58593. * page/PositionError.h: Removed.
  58594. * page/PositionError.idl: Removed.
  58595. * page/PositionErrorCallback.h: Removed.
  58596. * page/PositionErrorCallback.idl: Removed.
  58597. * page/PositionOptions.h: Removed.
  58598. * page/PositionOptions.idl: Removed.
  58599. * platform/GeolocationService.cpp: Removed.
  58600. * platform/GeolocationService.h: Removed.
  58601. 2008-10-23 David Kilzer <ddkilzer@apple.com>
  58602. Attempt to fix GTK build.
  58603. * GNUmakefile.am: Added new *.idl files that were missing.
  58604. 2008-10-23 Greg Bolsinga <bolsinga@apple.com>
  58605. Reviewed by Sam Weinig.
  58606. https://bugs.webkit.org/show_bug.cgi?id=21475
  58607. Provide support for the Geolocation API
  58608. http://dev.w3.org/geo/api/spec-source.html
  58609. Test: geolocation/geolocation-not-implemented.html
  58610. * DerivedSources.make:
  58611. * GNUmakefile.am: Added Geolocation support
  58612. * WebCore.pro: Added Geolocation support
  58613. * WebCore.vcproj/WebCore.vcproj: Added Geolocation support
  58614. * WebCore.xcodeproj/project.pbxproj: Added Geolocation support
  58615. * WebCoreSources.bkl: Added Geolocation support
  58616. * bindings/js/JSCustomPositionCallback.cpp: Added.
  58617. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
  58618. (WebCore::JSCustomPositionCallback::handleEvent):
  58619. * bindings/js/JSCustomPositionCallback.h: Added.
  58620. (WebCore::JSCustomPositionCallback::create):
  58621. * bindings/js/JSCustomPositionErrorCallback.cpp: Added.
  58622. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
  58623. (WebCore::JSCustomPositionErrorCallback::handleEvent):
  58624. * bindings/js/JSCustomPositionErrorCallback.h: Added.
  58625. (WebCore::JSCustomPositionErrorCallback::create):
  58626. * bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
  58627. (WebCore::markDOMObjectWrapper):
  58628. * bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
  58629. * bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
  58630. * bindings/js/JSGeolocationCustom.cpp: Added.
  58631. (WebCore::JSGeolocation::getCurrentPosition):
  58632. (WebCore::JSGeolocation::watchPosition):
  58633. * bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
  58634. (WebCore::JSNavigator::mark):
  58635. * dom/Document.cpp:
  58636. (WebCore::Document::Document):
  58637. * dom/Document.h:
  58638. (WebCore::Document::setUsingGeolocation):
  58639. (WebCore::Document::usingGeolocation):
  58640. * loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
  58641. (WebCore::FrameLoader::canCachePage):
  58642. * page/Geolocation.cpp: Added.
  58643. (WebCore::Geolocation::GeoNotifier::GeoNotifier):
  58644. (WebCore::Geolocation::GeoNotifier::timerFired):
  58645. (WebCore::Geolocation::Geolocation):
  58646. (WebCore::Geolocation::disconnectFrame):
  58647. (WebCore::Geolocation::getCurrentPosition):
  58648. (WebCore::Geolocation::watchPosition):
  58649. (WebCore::Geolocation::clearWatch):
  58650. (WebCore::Geolocation::stopUpdatingIfEmpty):
  58651. (WebCore::Geolocation::sendErrorToOneShots):
  58652. (WebCore::Geolocation::sendErrorToWatchers):
  58653. (WebCore::Geolocation::sendPositionToOneShots):
  58654. (WebCore::Geolocation::sendPositionToWatchers):
  58655. (WebCore::Geolocation::handleError):
  58656. (WebCore::Geolocation::geolocationServicePositionChanged):
  58657. (WebCore::Geolocation::geolocationServiceErrorOccurred):
  58658. * page/Geolocation.h: Added.
  58659. (WebCore::Geolocation::create):
  58660. (WebCore::Geolocation::~Geolocation):
  58661. (WebCore::Geolocation::lastPosition):
  58662. (WebCore::Geolocation::GeoNotifier::create):
  58663. * page/Geolocation.idl: Added.
  58664. * page/Geoposition.cpp: Added.
  58665. (WebCore::Geoposition::toString):
  58666. * page/Geoposition.h: Added.
  58667. (WebCore::Geoposition::create):
  58668. (WebCore::Geoposition::latitude):
  58669. (WebCore::Geoposition::longitude):
  58670. (WebCore::Geoposition::altitude):
  58671. (WebCore::Geoposition::accuracy):
  58672. (WebCore::Geoposition::altitudeAccuracy):
  58673. (WebCore::Geoposition::heading):
  58674. (WebCore::Geoposition::velocity):
  58675. (WebCore::Geoposition::timestamp):
  58676. (WebCore::Geoposition::Geoposition):
  58677. * page/Geoposition.idl: Added.
  58678. * page/Navigator.cpp:
  58679. (WebCore::Navigator::disconnectFrame): disconnect Geolocation
  58680. (WebCore::Navigator::geolocation): accessor for Geolocation
  58681. * page/Navigator.h:
  58682. (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
  58683. * page/Navigator.idl: accessor for Geolocation
  58684. * page/PositionCallback.h: Added.
  58685. (WebCore::PositionCallback::~PositionCallback):
  58686. * page/PositionCallback.idl: Added.
  58687. * page/PositionError.h: Added.
  58688. (WebCore::PositionError::):
  58689. (WebCore::PositionError::create):
  58690. (WebCore::PositionError::code):
  58691. (WebCore::PositionError::message):
  58692. (WebCore::PositionError::PositionError):
  58693. * page/PositionError.idl: Added.
  58694. * page/PositionErrorCallback.h: Added.
  58695. (WebCore::PositionErrorCallback::~PositionErrorCallback):
  58696. * page/PositionErrorCallback.idl: Added.
  58697. * page/PositionOptions.h: Added.
  58698. (WebCore::PositionOptions::create):
  58699. (WebCore::PositionOptions::enableHighAccuracy):
  58700. (WebCore::PositionOptions::setEnableHighAccuracy):
  58701. (WebCore::PositionOptions::timeout):
  58702. (WebCore::PositionOptions::setTimeout):
  58703. (WebCore::PositionOptions::PositionOptions):
  58704. * page/PositionOptions.idl: Added.
  58705. * platform/GeolocationService.cpp: Added.
  58706. (WebCore::GeolocationService::GeolocationService):
  58707. (WebCore::GeolocationService::positionChanged):
  58708. (WebCore::GeolocationService::errorOccurred):
  58709. * platform/GeolocationService.h: Added.
  58710. (WebCore::GeolocationServiceClient::~GeolocationServiceClient):
  58711. (WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
  58712. (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
  58713. (WebCore::GeolocationService::~GeolocationService):
  58714. 2008-10-23 Alp Toker <alp@nuanti.com>
  58715. Fix typo in comment in previous commit. GTK -> GLIB
  58716. * platform/gtk/guriescape.c:
  58717. 2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>
  58718. Reviewed by Alp Toker.
  58719. https://bugs.webkit.org/show_bug.cgi?id=21824
  58720. [GTK] FileSystem abstraction uses features from Glib 2.16
  58721. Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib
  58722. * platform/gtk/guriescape.c:
  58723. (unescape_character):
  58724. (_webcore_g_uri_unescape_segment):
  58725. (_webcore_g_uri_unescape_string):
  58726. * platform/gtk/guriescape.h:
  58727. 2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
  58728. Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.
  58729. * GNUmakefile.am:
  58730. 2008-10-23 Darin Fisher <darin@chromium.org>
  58731. Reviewed by Eric Seidel.
  58732. m_frame null checked but then dereferenced
  58733. https://bugs.webkit.org/show_bug.cgi?id=21845
  58734. This error was found using a static analysis tool, and so I do not know
  58735. how to produce a null m_frame on entry to this method. Hence, I have
  58736. not included a regression test.
  58737. * page/EventHandler.cpp:
  58738. (WebCore::EventHandler::allowDHTMLDrag): Add an early return.
  58739. 2008-10-23 Dan Bernstein <mitz@apple.com>
  58740. Reviewed by Sam Weinig with no hesitation.
  58741. - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
  58742. <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
  58743. Test: fast/text/bidi-embedding-pop-and-push-same.html
  58744. * platform/text/BidiResolver.h:
  58745. (WebCore::BidiResolver::embed): Changed to only add the embedding
  58746. operation to a vector of pending operations.
  58747. (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
  58748. code that used to be in the PDF case of embed() here, except the part
  58749. that sets the context.
  58750. (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
  58751. code that used to be in the non-PDF case of embed() here, except the
  58752. part the sets the context.
  58753. (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
  58754. explicit embedding operations in the vector by creating an updated
  58755. context and determining the old and new embedding levels. If the levels
  58756. are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
  58757. sets the context to the new one.
  58758. (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
  58759. commitExplicitEmbedding() after calling embed() and after calling
  58760. increment().
  58761. * rendering/bidi.cpp:
  58762. (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
  58763. this function increments the resolver.
  58764. (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
  58765. 2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
  58766. Gtk build fix. Not reviewed.
  58767. Add DNSCurl and DNSSoup to the Gtk build
  58768. * GNUmakefile.am:
  58769. * platform/gtk/TemporaryLinkStubs.cpp:
  58770. * platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
  58771. (WebCore::prefetchDNS):
  58772. 2008-10-23 Eric Seidel <eric@webkit.org>
  58773. Reviewed by Sam Weinig.
  58774. Un-break the Darwin build.
  58775. * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  58776. * platform/graphics/cg/ImageCG.cpp:
  58777. 2008-10-23 Darin Fisher <darin@chromium.org>
  58778. Reviewed by Eric Seidel.
  58779. Fix forward decls to be struct instead of class.
  58780. https://bugs.webkit.org/show_bug.cgi?id=21838
  58781. * rendering/style/StyleRareInheritedData.h:
  58782. * rendering/style/StyleRareNonInheritedData.h:
  58783. 2008-10-23 Brent Fulgham <bfulgham@gmail.com>
  58784. Reviewed by Oliver Hunt.
  58785. * platform/network/curl/ResourceRequest.h: A better implementation
  58786. of CFURLRequest, rather than void*. This gives better compatibility
  58787. with the WebKit.idl interface.
  58788. (WebCore::ResourceRequest::cfURLRequest):
  58789. 2008-10-23 Mike Pinkerton <pinkerton@chromium.org>
  58790. Reviewed by Eric Seidel.
  58791. PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
  58792. ifdefs to reflect that.
  58793. * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  58794. * platform/graphics/cg/ImageCG.cpp:
  58795. 2008-10-23 Peter Kasting <pkasting@google.com>
  58796. Reviewed by Adam Roben.
  58797. https://bugs.webkit.org/show_bug.cgi?id=21833
  58798. Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
  58799. * inspector/InspectorController.cpp:
  58800. (WebCore::InspectorController::InspectorController):
  58801. (WebCore::InspectorController::setWindowVisible):
  58802. (WebCore::InspectorController::windowScriptObjectAvailable):
  58803. (WebCore::InspectorController::close):
  58804. * inspector/InspectorController.h:
  58805. * page/Page.cpp:
  58806. (WebCore::Page::Page):
  58807. 2008-10-23 Kevin McCullough <kmccullough@apple.com>
  58808. Reviewed by Tim Hatcher.
  58809. https://bugs.webkit.org/show_bug.cgi?id=21817
  58810. Bug 21817: Manual profiler tests should be made into layout tests
  58811. -Moving the tests before diffing so that it's clear what changed.
  58812. * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
  58813. * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
  58814. * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
  58815. * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
  58816. * manual-tests/inspector/profiler-test-apply.html: Removed.
  58817. * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
  58818. * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
  58819. * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
  58820. * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
  58821. * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
  58822. * manual-tests/inspector/profiler-test-constructor.html: Removed.
  58823. * manual-tests/inspector/profiler-test-dead-time.html: Removed.
  58824. * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
  58825. * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
  58826. * manual-tests/inspector/profiler-test-event-handler.html: Removed.
  58827. * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
  58828. * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
  58829. * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
  58830. * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
  58831. * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
  58832. * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
  58833. * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
  58834. * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
  58835. * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
  58836. * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
  58837. * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
  58838. * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
  58839. * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
  58840. * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
  58841. * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
  58842. * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
  58843. * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
  58844. * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
  58845. * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
  58846. * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
  58847. * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
  58848. * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
  58849. * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
  58850. * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
  58851. * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
  58852. * manual-tests/inspector/resources/other-frame.html: Removed.
  58853. * manual-tests/inspector/resources/other-window.html: Removed.
  58854. * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.
  58855. 2008-10-23 Adam Barth <abarth@webkit.org>
  58856. Reviewed by Sam Weinig.
  58857. https://bugs.webkit.org/show_bug.cgi?id=21826
  58858. Add accessor for SecurityOrigin::m_domainWasSetInDOM.
  58859. * page/SecurityOrigin.h:
  58860. (WebCore::SecurityOrigin::domainWasSetInDOM):
  58861. 2008-10-23 Darin Adler <darin@apple.com>
  58862. - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
  58863. * bindings/js/ScheduledAction.h:
  58864. * inspector/InspectorController.cpp:
  58865. ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
  58866. 2008-10-23 Simon Hausmann <hausmann@webkit.org>
  58867. Fix the Qt build.
  58868. * bridge/qt/qt_runtime.cpp:
  58869. (JSC::Bindings::QtConnectionObject::execute):
  58870. * bridge/qt/qt_runtime.h:
  58871. (JSC::Bindings::QtRuntimeMethod::createStructureID):
  58872. 2008-10-23 Alexey Proskuryakov <ap@webkit.org>
  58873. Reviewed by Maciej Stachowiak.
  58874. https://bugs.webkit.org/show_bug.cgi?id=21825
  58875. JSDOMBinding should not blindly cast the global object to JSDOMWindow
  58876. * bindings/js/JSDOMGlobalObject.cpp:
  58877. * bindings/js/JSDOMGlobalObject.h:
  58878. * GNUmakefile.am:
  58879. * WebCore.pro:
  58880. * WebCore.vcproj/WebCore.vcproj:
  58881. * WebCore.xcodeproj/project.pbxproj:
  58882. * WebCoreSources.bkl:
  58883. Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.
  58884. * bindings/js/JSDOMBinding.cpp:
  58885. (WebCore::getCachedDOMStructure):
  58886. (WebCore::cacheDOMStructure):
  58887. (WebCore::getCachedDOMConstructor):
  58888. (WebCore::cacheDOMConstructor):
  58889. Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.
  58890. * bindings/js/JSDOMWindowBase.cpp:
  58891. (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  58892. * bindings/js/JSDOMWindowBase.h:
  58893. * bindings/js/JSDOMWindowCustom.cpp:
  58894. (WebCore::JSDOMWindow::mark):
  58895. Moved constructor and structure tracking to JSDOMGlobalObject.
  58896. 2008-10-23 Adam Barth <abarth@webkit.org>
  58897. Reviewed by Sam Weinig.
  58898. https://bugs.webkit.org/show_bug.cgi?id=21787
  58899. Update postMessage to send origin = "null" for non-serializable
  58900. origins to match latest spec. Merge SecurityOrigin::toString and
  58901. SecurityOrigin::toHTTPOrigin because they are now the same.
  58902. Test: http/tests/security/postMessage/data-url-sends-null-origin.html
  58903. * loader/FrameLoader.cpp:
  58904. (WebCore::FrameLoader::outgoingOrigin):
  58905. (WebCore::FrameLoader::loadURL):
  58906. (WebCore::FrameLoader::addHTTPOriginIfNeeded):
  58907. (WebCore::FrameLoader::loadItem):
  58908. * loader/loader.cpp:
  58909. (WebCore::Loader::Host::servePendingRequests):
  58910. * page/SecurityOrigin.cpp:
  58911. (WebCore::SecurityOrigin::toString):
  58912. * page/SecurityOrigin.h:
  58913. * xml/XMLHttpRequest.cpp:
  58914. (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
  58915. (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
  58916. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
  58917. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  58918. 2008-10-22 David Kilzer <ddkilzer@apple.com>
  58919. Bug 21781: WebCore::Settings should have a maximum decoded image size setting
  58920. <https://bugs.webkit.org/show_bug.cgi?id=21781>
  58921. Reviewed by Antti.
  58922. No tests since there is no change in behavior.
  58923. * loader/CachedImage.cpp:
  58924. (WebCore::CachedImage::maximumDecodedImageSize): Added. Returns
  58925. WebCore::Settings::maximumDecodedImageSize() or 0 on error.
  58926. (WebCore::CachedImage::data): Flag an error if the image being
  58927. loaded is too big.
  58928. * loader/CachedImage.h:
  58929. (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
  58930. * page/Settings.cpp:
  58931. (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize
  58932. to the maximum value of size_t.
  58933. * page/Settings.h:
  58934. (WebCore::Settings::setMaximumDecodedImageSize): Added method.
  58935. (WebCore::Settings::maximumDecodedImageSize): Ditto.
  58936. 2008-10-22 Mike Pinkerton <pinkerton@chromium.org>
  58937. Reviewed by Dan Bernstein.
  58938. Landed and tweaked a bit by Darin Adler.
  58939. - fix https://bugs.webkit.org/show_bug.cgi?id=21809
  58940. Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
  58941. its use for PLATFORM(CHROMIUM) in the future.
  58942. * platform/graphics/SimpleFontData.h:
  58943. 2008-10-22 David Smith <catfish.man@gmail.com>
  58944. Reviewed by Anders Carlsson.
  58945. https://bugs.webkit.org/show_bug.cgi?id=19974
  58946. getElementsByClassName not live enough
  58947. Test: fast/dom/getElementsByClassName/015.html
  58948. * dom/StyledElement.cpp:
  58949. (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()
  58950. 2008-10-22 Darin Adler <darin@apple.com>
  58951. Reviewed by Sam Weinig.
  58952. - fix https://bugs.webkit.org/show_bug.cgi?id=21294
  58953. Bug 21294: Devirtualize getOwnPropertySlot()
  58954. * bindings/js/JSDOMWindowShell.h:
  58955. (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without
  58956. HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
  58957. * bindings/js/JSInspectorCallbackWrapper.cpp:
  58958. (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure
  58959. for this class rather than sharing nullProtoStructureID, which no longer exists.
  58960. * bindings/js/JSNamedNodesCollection.h:
  58961. (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without
  58962. HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
  58963. * bindings/js/JSRGBColor.h:
  58964. (WebCore::JSRGBColor::createStructureID): Ditto.
  58965. * bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers,
  58966. constructors, and prototypes in any case where they override getOwnPropertySlot, without
  58967. HasStandardGetOwnPropertySlot.
  58968. * bridge/objc/objc_runtime.h:
  58969. (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure
  58970. without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
  58971. * bridge/qt/qt_runtime.h:
  58972. (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
  58973. * bridge/runtime_array.h:
  58974. (JSC::RuntimeArray::createStructureID): Ditto.
  58975. * bridge/runtime_method.h:
  58976. (JSC::RuntimeMethod::createStructureID): Ditto.
  58977. * bridge/runtime_object.h:
  58978. (JSC::RuntimeObjectImp::createStructureID): Ditto.
  58979. 2008-10-22 Brent Fulgham <bfulgham@gmail.com>
  58980. Bring Windows Cairo Port's font handling in line with CG.
  58981. http://bugs.webkit.org/show_bug.cgi?id=21812.
  58982. Reviewed by Adam Roben.
  58983. * platform/graphics/win/FontCacheWin.cpp:
  58984. (WebCore::createGDIFont): Remove unnecessary special-case for Cairo
  58985. TrueType font search. It should match CG in all font selections.
  58986. 2008-10-22 Brent Fulgham <bfulgham@gmail.com>
  58987. http://bugs.webkit.org/show_bug.cgi?id=21812.
  58988. Bring Windows Cairo Port's font handling in line with CG.
  58989. Reviewed by David Hyatt.
  58990. * platform/graphics/win/FontCacheWin.cpp:
  58991. (WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.
  58992. 2008-10-22 Brady Eidson <beidson@apple.com>
  58993. Reviewed by Adam Roben
  58994. <rdar://6261773> - autocomplete="off" doesn't work on Windows
  58995. Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
  58996. statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
  58997. instead of the much more correct "true."
  58998. In the past we have worked around this by declaring the bitfield member as an unsigned instead
  58999. of the enum type.
  59000. For more discussion, see http://trac.webkit.org/changeset/25329
  59001. * html/HTMLInputElement.h: Work around insane Visual Studio enum issue *sigh*
  59002. 2008-10-22 Kevin McCullough <kmccullough@apple.com>
  59003. Reviewed by Oliver Hunt and Tim Hatcher.
  59004. https://bugs.webkit.org/show_bug.cgi?id=19225
  59005. Bug 19225: JSProfiler: Create automated profiler tests
  59006. - This change exports profiles on the console object so that they can be
  59007. iterated over via JavaScript, and thus can be used in automated tests.
  59008. * bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array
  59009. that JS can use.
  59010. (WebCore::JSConsole::profiles):
  59011. * inspector/InspectorController.h: Use the new typedef.
  59012. (WebCore::InspectorController::profiles):
  59013. * page/Console.cpp: Keep our own array of profile objects.
  59014. (WebCore::Console::profileEnd):
  59015. * page/Console.h: Ditto.
  59016. (WebCore::Console::profiles):
  59017. * page/Console.idl: Expose the profiles to JS.
  59018. 2008-10-22 David Hyatt <hyatt@apple.com>
  59019. https://bugs.webkit.org/show_bug.cgi?id=21775
  59020. Convert buttons over to use the new Theme API on OS X.
  59021. Reviewed by Adam Roben
  59022. * platform/LengthBox.h:
  59023. (WebCore::LengthBox::LengthBox):
  59024. * platform/Theme.cpp:
  59025. (WebCore::Theme::controlBorder):
  59026. (WebCore::Theme::controlPadding):
  59027. * platform/Theme.h:
  59028. (WebCore::Theme::controlFont):
  59029. (WebCore::Theme::controlSize):
  59030. (WebCore::Theme::minControlSize):
  59031. (WebCore::Theme::controlRequiresPreWhiteSpace):
  59032. * platform/mac/ThemeMac.h:
  59033. (WebCore::ThemeMac::controlRequiresPreWhiteSpace):
  59034. * platform/mac/ThemeMac.mm:
  59035. (WebCore::checkboxSize):
  59036. (WebCore::radioSize):
  59037. (WebCore::buttonSizes):
  59038. (WebCore::buttonMargins):
  59039. (WebCore::button):
  59040. (WebCore::paintButton):
  59041. (WebCore::ThemeMac::controlFont):
  59042. (WebCore::ThemeMac::controlSize):
  59043. (WebCore::ThemeMac::minControlSize):
  59044. (WebCore::ThemeMac::controlBorder):
  59045. (WebCore::ThemeMac::controlPadding):
  59046. (WebCore::ThemeMac::inflateControlPaintRect):
  59047. (WebCore::ThemeMac::paint):
  59048. * rendering/RenderTheme.cpp:
  59049. (WebCore::RenderTheme::adjustStyle):
  59050. (WebCore::RenderTheme::paint):
  59051. (WebCore::RenderTheme::controlStatesForRenderer):
  59052. (WebCore::RenderTheme::isDefault):
  59053. (WebCore::RenderTheme::adjustRadioStyle):
  59054. * rendering/RenderTheme.h:
  59055. (WebCore::RenderTheme::setRadioSize):
  59056. * rendering/RenderThemeMac.h:
  59057. * rendering/RenderThemeMac.mm:
  59058. (WebCore::RenderThemeMac::adjustRepaintRect):
  59059. (WebCore::menuListButtonSizes):
  59060. (WebCore::RenderThemeMac::adjustMenuListStyle):
  59061. * rendering/style/RenderStyle.h:
  59062. (WebCore::InheritedFlags::paddingBox):
  59063. (WebCore::InheritedFlags::setPaddingBox):
  59064. 2008-10-22 Chris Marrin <cmarrin@apple.com>
  59065. Reviewed by Dave Hyatt
  59066. Make sure that the AtomicString that identifies a set of animation keyframes
  59067. stays live by keeping a copy in the WebKitCSSKeyframesRule.
  59068. Also call styleSheetChanged() when the keyframes name changes, but
  59069. add an internal method that doesn't call styleSheetChanged() for use
  59070. during normal stylesheet parsing.
  59071. Test: animations/change-keyframes-name.html
  59072. * css/CSSGrammar.y:
  59073. * css/WebKitCSSKeyframesRule.cpp:
  59074. (WebCore::WebKitCSSKeyframesRule::setName):
  59075. * css/WebKitCSSKeyframesRule.h:
  59076. (WebCore::WebKitCSSKeyframesRule::setNameInternal):
  59077. 2008-10-22 Alexey Proskuryakov <ap@webkit.org>
  59078. Reviewed by Sam Weinig.
  59079. https://bugs.webkit.org/show_bug.cgi?id=21791
  59080. WebCore JS bindings should be able to use non-static hash tables for properties
  59081. Add a map for HashTables to WebCore JS client data.
  59082. This makes property access noticeably slower, so it is an opt-in. For classes that need to be
  59083. supported in workers in forseeable future this is not critical.
  59084. * bindings/js/JSDOMBinding.cpp:
  59085. (WebCore::DOMObjectHashTableMap::get):
  59086. (WebCore::DOMObjectHashTableMap::mapFor):
  59087. (WebCore::getHashTableForGlobalData):
  59088. (WebCore::DOMObjectWrapperMap::mapFor):
  59089. WebCore client data is now a class that contains both a DOM wrapper map and a property hash
  59090. table one.
  59091. * bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.
  59092. * bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
  59093. JSDOMBinding map to access its property hash tables.
  59094. * dom/MessageChannel.idl:
  59095. * dom/MessagePort.idl:
  59096. Added NoStaticTables attribute.
  59097. 2008-10-22 Gustavo Noronha Silva <gns@gnome.org>
  59098. Reviewed by Timothy Hatcher.
  59099. Build failure because of missing include
  59100. https://bugs.webkit.org/show_bug.cgi?id=21765
  59101. Build failure fix for WebKit/GTK+; added missing
  59102. include (GOwnPtr.h)
  59103. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  59104. 2008-10-22 Alp Toker <alp@nuanti.com>
  59105. Reviewed by Adam Roben.
  59106. Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
  59107. doesn't initialize values if the requested property doesn't exist, so
  59108. initialize the values to the documented defaults before calling it
  59109. where necessary. Additionally, avoid critical warnings by not calling
  59110. gtk_widget_style_get() when we know the property isn't available.
  59111. Note that this is an imported source file which doesn't follow the
  59112. WebKit coding style.
  59113. * platform/gtk/gtk2drawing.c:
  59114. (moz_gtk_init):
  59115. (moz_gtk_button_get_inner_border):
  59116. (moz_gtk_combo_box_paint):
  59117. (moz_gtk_toolbar_separator_paint):
  59118. (moz_gtk_menu_separator_paint):
  59119. (moz_gtk_get_widget_border):
  59120. (moz_gtk_get_tab_scroll_arrow_size):
  59121. (moz_gtk_get_toolbar_separator_width):
  59122. (moz_gtk_get_menu_separator_height):
  59123. 2008-10-22 Alp Toker <alp@nuanti.com>
  59124. Fix build for Cairo 1.2.
  59125. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  59126. (WebCore::GraphicsContext::clipOut):
  59127. * platform/gtk/RenderThemeGtk.cpp:
  59128. (WebCore::paintMozWidget):
  59129. 2008-10-22 Darin Fisher <darin@chromium.org>
  59130. Reviewed by Eric Seidel.
  59131. A little more PLATFORM(CHROMIUM) in WebCore
  59132. https://bugs.webkit.org/show_bug.cgi?id=21758
  59133. * page/AccessibilityObject.h:
  59134. * platform/graphics/Icon.h:
  59135. 2008-10-21 Alexey Proskuryakov <ap@webkit.org>
  59136. Reviewed by Darin Adler.
  59137. Test: fast/events/message-channel-gc-3.html
  59138. https://bugs.webkit.org/show_bug.cgi?id=21769
  59139. MessagePort should be GC protected if there are messages to be delivered
  59140. * dom/MessagePort.h: Removed pending activity count. Now we track if a close event is
  59141. pending, and check if the queue is non-empty.
  59142. (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug
  59143. fix (below).
  59144. * dom/MessagePort.cpp:
  59145. (WebCore::CloseMessagePortTimer::fired):
  59146. (WebCore::MessagePort::MessagePort):
  59147. (WebCore::MessagePort::queueCloseEvent):
  59148. (WebCore::MessagePort::dispatchCloseEvent):
  59149. (WebCore::MessagePort::hasPendingActivity):
  59150. Track message and close event activity separately.
  59151. * bindings/js/JSDOMBinding.cpp:
  59152. (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was
  59153. causing same-heap ports to never be deleted.
  59154. 2008-10-21 Dan Bernstein <mitz@apple.com>
  59155. Reviewed by Sam Weinig.
  59156. - remove unreachable code
  59157. * platform/text/BidiResolver.h:
  59158. (WebCore::::embed):
  59159. 2008-10-21 Beth Dakin <bdakin@apple.com>
  59160. Reviewed by Darin Adler.
  59161. Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
  59162. REGRESSION(r31030-31055): Choosing "Print window" from frame set
  59163. prints blank page
  59164. and corresponding: <rdar://problem/6142398>
  59165. viewHeight() and viewWidth() only return valuable information if we
  59166. are not printing. Everywhere else in the code, we make sure we are
  59167. not printing before we call these functions. Adding a check for
  59168. printing here fixes this bug, and framesets print again.
  59169. * rendering/RenderFrameSet.cpp:
  59170. (WebCore::RenderFrameSet::layout):
  59171. 2008-10-21 Yael Aharon <yael.aharon@nokia.com>
  59172. Reviewed by Simon.
  59173. Pixmap in canvas tag was not getting initialized.
  59174. See https://bugs.webkit.org/show_bug.cgi?id=21771
  59175. * platform/graphics/qt/ImageBufferQt.cpp:
  59176. (WebCore::ImageBuffer::create):
  59177. 2008-10-20 Simon Fraser <simon.fraser@apple.com>
  59178. Reviewed by Dan Bernstein
  59179. Add a comment explaining layoutDelta(), and an assertion
  59180. that checks that delta changes were correctly paired during layout.
  59181. * rendering/RenderView.cpp:
  59182. (WebCore::RenderView::layout):
  59183. * rendering/RenderView.h:
  59184. 2008-10-20 Timothy Hatcher <timothy@apple.com>
  59185. Make auto-complete only suggest properties that are valid syntax
  59186. when using dot-notation. Also when completing numeric properties,
  59187. the quotes are omitted inside the brackets.
  59188. https://bugs.webkit.org/show_bug.cgi?id=21760
  59189. https://bugs.webkit.org/show_bug.cgi?id=21761
  59190. Reviewed by Oliver Hunt.
  59191. * inspector/front-end/Console.js:
  59192. (WebInspector.Console.prototype.completions): Skip properties that
  59193. are not valid identifies when using dot-notation. And omit the quotes
  59194. when completing numbers in bracket-notation.
  59195. 2008-10-20 Timothy Hatcher <timothy@apple.com>
  59196. Fixes the Profiles panel in the Web Inspector, which was broken by
  59197. the JSValue base-class changes. Also renames some functions and
  59198. variables in JavaScriptProfileNode.cpp that where title case.
  59199. https://bugs.webkit.org/show_bug.cgi?id=21764
  59200. Reviewed by Oliver Hunt.
  59201. * inspector/JavaScriptProfile.cpp:
  59202. (WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the
  59203. returned JSValuePtr will be treated as an object and not a value.
  59204. * inspector/JavaScriptProfileNode.cpp:
  59205. (WebCore::toJS): Ditto.
  59206. 2008-10-20 Sam Weinig <sam@webkit.org>
  59207. Reviewed by Anders Carlsson.
  59208. Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
  59209. * loader/EmptyClients.h:
  59210. (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
  59211. * loader/FrameLoader.cpp:
  59212. (WebCore::FrameLoader::detachFromParent):
  59213. * loader/FrameLoaderClient.h:
  59214. 2008-10-20 Antti Koivisto <antti@apple.com>
  59215. Reviewed by Adele Peterson.
  59216. Fix https://bugs.webkit.org/show_bug.cgi?id=21763
  59217. REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
  59218. <rdar://problem/6285025
  59219. If we get 304 response we need to explicitly check if that completes the frame load.
  59220. No test case, simulating the condition is pretty difficult.
  59221. * loader/loader.cpp:
  59222. (WebCore::Loader::Host::didReceiveResponse):
  59223. 2008-10-20 Anders Carlsson <andersca@apple.com>
  59224. Reviewed by Mark Rowe.
  59225. Work around <rdar://problem/6301728>.
  59226. Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.
  59227. * loader/MainResourceLoader.cpp:
  59228. (WebCore::MainResourceLoader::didReceiveResponse):
  59229. (WebCore::MainResourceLoader::didReceiveData):
  59230. (WebCore::MainResourceLoader::didFinishLoading):
  59231. (WebCore::MainResourceLoader::didFail):
  59232. 2008-10-20 Beth Dakin <bdakin@apple.com>
  59233. Reviewed by Adele Peterson.
  59234. Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
  59235. crashes in Safari at com.apple.WebCore
  59236. WebCore::ScrollView::visibleContentRect const + 153
  59237. d->m_view can be null and is null-checked at other points in the
  59238. code. The logs indicate that this crash occurs when closing a
  59239. window containing a PDF, so in case where we crash, the PDF's view
  59240. is probably already null. So the fix is to simply add a null-check.
  59241. * page/Frame.cpp:
  59242. (WebCore::Frame::selectionRect):
  59243. 2008-10-20 Adele Peterson <adele@apple.com>
  59244. Reviewed by Darin Adler.
  59245. * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  59246. Removed stray increment that would screw up any form with multiple files in it.
  59247. 2008-10-20 Sam Weinig <sam@webkit.org>
  59248. Rubber-stamped by David Hyatt.
  59249. Split LengthBox and LengthSize into their own files.
  59250. * GNUmakefile.am:
  59251. * WebCore.vcproj/WebCore.vcproj:
  59252. * WebCore.xcodeproj/project.pbxproj:
  59253. * platform/Length.h:
  59254. (WebCore::Length::blend):
  59255. * platform/LengthBox.h: Copied from platform/Length.h.
  59256. (WebCore::LengthBox::LengthBox):
  59257. (WebCore::LengthBox::nonZero):
  59258. * platform/LengthSize.h: Copied from platform/Length.h.
  59259. (WebCore::LengthSize::LengthSize):
  59260. (WebCore::LengthSize::setWidth):
  59261. (WebCore::LengthSize::setHeight):
  59262. (WebCore::LengthSize::height):
  59263. * platform/Theme.h:
  59264. * rendering/style/FillLayer.h:
  59265. * rendering/style/NinePieceImage.h:
  59266. (WebCore::NinePieceImage::NinePieceImage):
  59267. * rendering/style/RenderStyle.h:
  59268. * rendering/style/StyleDashboardRegion.h:
  59269. * rendering/style/StyleSurroundData.h:
  59270. * rendering/style/StyleVisualData.h:
  59271. 2008-10-20 Dan Bernstein <mitz@apple.com>
  59272. - Mac build fix
  59273. * WebCore.xcodeproj/project.pbxproj:
  59274. 2008-10-20 Alp Toker <alp@nuanti.com>
  59275. Fix autotools dist build target by listing recently added header
  59276. files only. Not reviewed.
  59277. * GNUmakefile.am:
  59278. 2008-10-20 David Hyatt <hyatt@apple.com>
  59279. Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms). Also
  59280. refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
  59281. originally.
  59282. ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.
  59283. Reviewed by Adam Roben
  59284. * WebCore.xcodeproj/project.pbxproj:
  59285. * platform/Theme.cpp: Added.
  59286. (WebCore::Theme::controlSupportsBorder):
  59287. (WebCore::Theme::controlSupportsPadding):
  59288. * platform/Theme.h:
  59289. * platform/mac/ThemeMac.h:
  59290. * platform/mac/ThemeMac.mm:
  59291. * rendering/RenderTheme.cpp:
  59292. (WebCore::RenderTheme::adjustStyle):
  59293. * rendering/RenderTheme.h:
  59294. 2008-10-20 David Hyatt <hyatt@apple.com>
  59295. Rename LengthBox's members to have m_ in front of them.
  59296. Reviewed by Sam Weinig
  59297. * css/CSSComputedStyleDeclaration.cpp:
  59298. (WebCore::valueForNinePieceImage):
  59299. (WebCore::getPositionOffsetValue):
  59300. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  59301. * css/CSSStyleSelector.cpp:
  59302. (WebCore::CSSStyleSelector::mapNinePieceImage):
  59303. * platform/Length.h:
  59304. (WebCore::LengthBox::LengthBox):
  59305. (WebCore::LengthBox::left):
  59306. (WebCore::LengthBox::right):
  59307. (WebCore::LengthBox::top):
  59308. (WebCore::LengthBox::bottom):
  59309. (WebCore::LengthBox::operator==):
  59310. (WebCore::LengthBox::nonZero):
  59311. * rendering/RenderObject.cpp:
  59312. (WebCore::RenderObject::paintNinePieceImage):
  59313. (WebCore::RenderObject::addDashboardRegions):
  59314. * rendering/style/RenderStyle.cpp:
  59315. (WebCore::positionedObjectMoved):
  59316. (WebCore::RenderStyle::setClip):
  59317. (WebCore::RenderStyle::noneDashboardRegions):
  59318. * rendering/style/RenderStyle.h:
  59319. (WebCore::InheritedFlags::left):
  59320. (WebCore::InheritedFlags::right):
  59321. (WebCore::InheritedFlags::top):
  59322. (WebCore::InheritedFlags::bottom):
  59323. (WebCore::InheritedFlags::clipLeft):
  59324. (WebCore::InheritedFlags::clipRight):
  59325. (WebCore::InheritedFlags::clipTop):
  59326. (WebCore::InheritedFlags::clipBottom):
  59327. (WebCore::InheritedFlags::marginTop):
  59328. (WebCore::InheritedFlags::marginBottom):
  59329. (WebCore::InheritedFlags::marginLeft):
  59330. (WebCore::InheritedFlags::marginRight):
  59331. (WebCore::InheritedFlags::paddingTop):
  59332. (WebCore::InheritedFlags::paddingBottom):
  59333. (WebCore::InheritedFlags::paddingLeft):
  59334. (WebCore::InheritedFlags::paddingRight):
  59335. (WebCore::InheritedFlags::setLeft):
  59336. (WebCore::InheritedFlags::setRight):
  59337. (WebCore::InheritedFlags::setTop):
  59338. (WebCore::InheritedFlags::setBottom):
  59339. (WebCore::InheritedFlags::setDashboardRegion):
  59340. (WebCore::InheritedFlags::setClipLeft):
  59341. (WebCore::InheritedFlags::setClipRight):
  59342. (WebCore::InheritedFlags::setClipTop):
  59343. (WebCore::InheritedFlags::setClipBottom):
  59344. (WebCore::InheritedFlags::setMarginTop):
  59345. (WebCore::InheritedFlags::setMarginBottom):
  59346. (WebCore::InheritedFlags::setMarginLeft):
  59347. (WebCore::InheritedFlags::setMarginRight):
  59348. (WebCore::InheritedFlags::setPaddingTop):
  59349. (WebCore::InheritedFlags::setPaddingBottom):
  59350. (WebCore::InheritedFlags::setPaddingLeft):
  59351. (WebCore::InheritedFlags::setPaddingRight):
  59352. 2008-10-20 Timothy Hatcher <timothy@apple.com>
  59353. Make the Resource panel perform graph updates atomically, so when resources
  59354. are added the graph and summary graph update at the same time.
  59355. https://bugs.webkit.org/show_bug.cgi?id=21755
  59356. Reviewed by Kevin McCullough.
  59357. * inspector/front-end/Resource.js:
  59358. (WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime
  59359. property is undefined, null or 0. This allows callers to check for -1 and not
  59360. the other values when there is no startTime yet.
  59361. (WebInspector.Resource.prototype.get responseReceivedTime): Ditto.
  59362. (WebInspector.Resource.prototype.get endTime): Ditto.
  59363. (WebInspector.Resource.prototype.get duration): Remove an extra empty line.
  59364. (WebInspector.Resource.prototype.get latency): Ditto.
  59365. (WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration
  59366. property is undefined or null. This allows callers to always assume a number.
  59367. (WebInspector.Resource.prototype.get expectedContentLength): Ditto.
  59368. (WebInspector.Resource.prototype.get errors): Simplify the case where there is
  59369. no _errors property yet.
  59370. (WebInspector.Resource.prototype.set errors): Remove the check if the new value
  59371. if the same as the previous value, since there is no work to guard.
  59372. (WebInspector.Resource.prototype.get warnings): Simplify the case where there is
  59373. no _warnings property yet.
  59374. (WebInspector.Resource.prototype.set warnings): Remove the check if the new value
  59375. if the same as the previous value, since there is no work to guard.
  59376. (WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the
  59377. responseReceivedTime is -1.
  59378. (WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
  59379. * inspector/front-end/ResourcesPanel.js:
  59380. (WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not
  59381. have a _resourcesTreeElement yet, exclude it from the searchable views.
  59382. (WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources
  59383. and call refresh to refresh the entire graph.
  59384. (WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel
  59385. is visible that calls refresh.
  59386. (WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and
  59387. graph for a resource if it hasn't been created yet. If the boundaries changed during
  59388. the first stale resource pass, do a full pass of all resources when updating the graphs.
  59389. (WebInspector.ResourcesPanel.prototype.reset): Remove the legend items.
  59390. (WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and
  59391. graph, these are now created during the first refresh.
  59392. (WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement.
  59393. (WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto.
  59394. (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
  59395. (WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just
  59396. add the resource to the _staleResources and set needsRefresh.
  59397. (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check
  59398. _resourcesTreeElement.
  59399. (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear
  59400. the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild
  59401. since the insertBefore call will do it if needed.
  59402. (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to
  59403. clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded.
  59404. (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the
  59405. timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel,
  59406. since all the legend items are removed in one pass right before.
  59407. (WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction
  59408. before the calculator so the correct sortingFunction is there when a refresh happens.
  59409. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0
  59410. when the startTime is -1, since that looks best visually. Also set middle and end
  59411. to the start and middle (respectfully) when startAtZero. This looks best visually.
  59412. (WebInspector.ResourceGraph): Start the graph as hidden until the first refresh.
  59413. (WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.
  59414. 2008-10-20 David Hyatt <hyatt@apple.com>
  59415. https://bugs.webkit.org/show_bug.cgi?id=21733
  59416. Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
  59417. no attempt is made to re-cache the frame from a non-existent image source.
  59418. Reviewed by Sam Weinig
  59419. * platform/graphics/cairo/ImageCairo.cpp:
  59420. (WebCore::BitmapImage::BitmapImage):
  59421. * platform/graphics/cg/ImageCG.cpp:
  59422. (WebCore::BitmapImage::BitmapImage):
  59423. 2008-10-20 Dan Bernstein <mitz@apple.com>
  59424. Reviewed by John Sullivan.
  59425. - make hasARenderedDescendant() have internal linkage
  59426. * editing/CompositeEditCommand.cpp:
  59427. (WebCore::hasARenderedDescendant):
  59428. 2008-10-20 Chris Fleizach <cfleizach@apple.com>
  59429. Reviewed by Jon Honeycutt
  59430. Fix a crash in Accessibility where a table section was being
  59431. referenced without first checking if it was null
  59432. https://bugs.webkit.org/show_bug.cgi?id=21721
  59433. Test: accessibility/table-nofirstbody.html
  59434. * page/AccessibilityTable.cpp:
  59435. (WebCore::AccessibilityTable::addChildren):
  59436. 2008-10-20 David Hyatt <hyatt@apple.com>
  59437. Avoid some stderr spew from CG by checking if we have a decoder yet in ImageSourceCG.
  59438. Reviewed by Darin Adler
  59439. * platform/graphics/cg/ImageSourceCG.cpp:
  59440. (WebCore::ImageSource::repetitionCount):
  59441. (WebCore::ImageSource::frameDurationAtIndex):
  59442. 2008-10-20 Alp Toker <alp@nuanti.com>
  59443. Reviewed by Mark Rowe.
  59444. Fix the pthread conditionals in the FTP code to correctly define
  59445. threadsafe *_r functions on Windows. Partly fixes the GTK+/Win32
  59446. build.
  59447. * loader/FTPDirectoryDocument.cpp:
  59448. * loader/FTPDirectoryParser.cpp:
  59449. 2008-10-20 David Hyatt <hyatt@apple.com>
  59450. https://bugs.webkit.org/show_bug.cgi?id=21751
  59451. Convert checkboxes and radio buttons on OS X over to the new Theme API.
  59452. Reviewed by Adam Roben
  59453. * css/CSSComputedStyleDeclaration.cpp:
  59454. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  59455. * css/CSSStyleSelector.cpp:
  59456. (WebCore::CSSStyleSelector::mapFillSize):
  59457. * platform/Length.h:
  59458. (WebCore::LengthSize::LengthSize):
  59459. (WebCore::LengthSize::operator==):
  59460. (WebCore::LengthSize::width):
  59461. (WebCore::LengthSize::height):
  59462. (WebCore::LengthSize::setWidth):
  59463. (WebCore::LengthSize::setHeight):
  59464. * platform/Theme.h:
  59465. (WebCore::Theme::controlSize):
  59466. (WebCore::Theme::controlSupportsBorder):
  59467. (WebCore::Theme::controlSupportsPadding):
  59468. (WebCore::Theme::paint):
  59469. (WebCore::Theme::inflateControlPaintRect):
  59470. * platform/ThemeTypes.h:
  59471. (WebCore::):
  59472. * platform/mac/ThemeMac.h:
  59473. * platform/mac/ThemeMac.mm:
  59474. (WebCore::):
  59475. (WebCore::controlSizeForFont):
  59476. (WebCore::sizeFromFont):
  59477. (WebCore::setControlSize):
  59478. (WebCore::updateStates):
  59479. (WebCore::inflateRect):
  59480. (WebCore::checkboxSizes):
  59481. (WebCore::checkboxMargins):
  59482. (WebCore::checkboxSize):
  59483. (WebCore::checkbox):
  59484. (WebCore::paintCheckbox):
  59485. (WebCore::radioSizes):
  59486. (WebCore::radioMargins):
  59487. (WebCore::radioSize):
  59488. (WebCore::radio):
  59489. (WebCore::paintRadio):
  59490. (WebCore::ThemeMac::baselinePositionAdjustment):
  59491. (WebCore::ThemeMac::controlSize):
  59492. (WebCore::ThemeMac::controlSupportsBorder):
  59493. (WebCore::ThemeMac::controlSupportsPadding):
  59494. (WebCore::ThemeMac::inflateControlPaintRect):
  59495. (WebCore::ThemeMac::paint):
  59496. * rendering/RenderBox.cpp:
  59497. (WebCore::RenderBox::calculateBackgroundSize):
  59498. * rendering/RenderObject.cpp:
  59499. (WebCore::mustRepaintFillLayers):
  59500. * rendering/RenderTheme.cpp:
  59501. (WebCore::RenderTheme::adjustStyle):
  59502. (WebCore::RenderTheme::paint):
  59503. (WebCore::RenderTheme::baselinePosition):
  59504. (WebCore::RenderTheme::adjustRepaintRect):
  59505. (WebCore::RenderTheme::controlStatesForRenderer):
  59506. (WebCore::RenderTheme::isFocused):
  59507. * rendering/RenderTheme.h:
  59508. * rendering/RenderThemeMac.h:
  59509. * rendering/RenderThemeMac.mm:
  59510. (WebCore::RenderThemeMac::adjustRepaintRect):
  59511. * rendering/style/FillLayer.cpp:
  59512. (WebCore::FillLayer::operator==):
  59513. 2008-10-18 Geoffrey Garen <ggaren@apple.com>
  59514. Reviewed by Darin Adler.
  59515. Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
  59516. Emit profiling instrumentation only if the Web Inspector's profiling
  59517. feature is enabled
  59518. * bindings/js/JSDOMWindowBase.cpp:
  59519. (WebCore::JSDOMWindowBase::supportsProfiling):
  59520. * bindings/js/JSDOMWindowBase.h: Implemented the interface for specifying
  59521. whether a target global object has the Web Inspector's profiling feature
  59522. enabled.
  59523. * inspector/JavaScriptDebugServer.cpp:
  59524. (WebCore::JavaScriptDebugServer::recompileAllJSFunctionsSoon):
  59525. (WebCore::JavaScriptDebugServer::didAddListener):
  59526. (WebCore::JavaScriptDebugServer::didRemoveListener):
  59527. * inspector/JavaScriptDebugServer.h: Exported an API for recompiling,
  59528. used by the Settings object.
  59529. * page/Settings.cpp:
  59530. (WebCore::Settings::Settings):
  59531. (WebCore::Settings::setDeveloperExtrasEnabled):
  59532. * page/Settings.h: Recompile when the developer menu is enabled/disabled
  59533. for the first time, to add/remove profiling hooks. In the future, with
  59534. better Web Inspector UI, we can do this on a page-by-page basis,
  59535. instead of a global basis.
  59536. 2008-10-20 David Hyatt <hyatt@apple.com>
  59537. Move Length to platform/.
  59538. Reviewed by Adam Roben
  59539. * GNUmakefile.am:
  59540. * WebCore.pro:
  59541. * WebCore.vcproj/WebCore.vcproj:
  59542. * WebCore.xcodeproj/project.pbxproj:
  59543. * WebCoreSources.bkl:
  59544. * platform/Length.cpp: Copied from rendering/Length.cpp.
  59545. * platform/Length.h: Copied from rendering/Length.h.
  59546. 2008-10-20 Darin Adler <darin@apple.com>
  59547. - try to fix Qt build
  59548. * bridge/qt/qt_runtime.cpp:
  59549. (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Add asObject calls.
  59550. (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
  59551. 2008-10-20 Darin Adler <darin@apple.com>
  59552. - try to fix Qt build
  59553. * bridge/qt/qt_instance.cpp:
  59554. (JSC::Bindings::QtInstance::mark): Use JSValue* instead of JSValuePtr.
  59555. (JSC::Bindings::QtField::valueFromInstance): Ditto.
  59556. * bridge/qt/qt_instance.h: Ditto.
  59557. 2008-10-20 Darin Adler <darin@apple.com>
  59558. - try to fix Tiger build
  59559. * bridge/objc/objc_instance.mm:
  59560. (ObjcInstance::invokeMethod): Add a const_cast to remove the unwanted
  59561. volatile qualifier.
  59562. (ObjcInstance::invokeDefaultMethod): Ditto.
  59563. (ObjcInstance::getValueOfUndefinedField): Ditto.
  59564. * bridge/objc/objc_runtime.mm:
  59565. (JSC::Bindings::ObjcField::valueFromInstance): Ditto.
  59566. 2008-10-20 Alexey Proskuryakov <ap@webkit.org>
  59567. Reviewed by Darin Adler.
  59568. https://bugs.webkit.org/show_bug.cgi?id=21750
  59569. Eliminate the notion of "temporary events"
  59570. We mark some events as temporary when dispatching, for the sole reason of
  59571. manually calling forgetDOMObject when done dispatching.
  59572. There doesn't seem to be any reason to call it manually, as JSEvent destructor
  59573. will do this automatically right away.
  59574. * bindings/js/ScriptController.cpp:
  59575. * bindings/js/ScriptController.h:
  59576. Removed ScriptController::finishedWithEvent(), which was called after dispatching
  59577. a temporary event.
  59578. * dom/ContainerNode.cpp:
  59579. (WebCore::dispatchChildInsertionEvents):
  59580. (WebCore::dispatchChildRemovalEvents):
  59581. * dom/EventTarget.h:
  59582. * dom/EventTargetNode.cpp:
  59583. (WebCore::EventTargetNode::dispatchEvent):
  59584. (WebCore::EventTargetNode::dispatchGenericEvent):
  59585. (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
  59586. (WebCore::EventTargetNode::dispatchWindowEvent):
  59587. (WebCore::EventTargetNode::dispatchUIEvent):
  59588. (WebCore::EventTargetNode::dispatchKeyEvent):
  59589. (WebCore::EventTargetNode::dispatchMouseEvent):
  59590. (WebCore::EventTargetNode::dispatchWheelEvent):
  59591. (WebCore::EventTargetNode::dispatchWebKitAnimationEvent):
  59592. (WebCore::EventTargetNode::dispatchWebKitTransitionEvent):
  59593. (WebCore::EventTargetNode::dispatchEventForType):
  59594. (WebCore::EventTargetNode::dispatchProgressEvent):
  59595. (WebCore::EventTargetNode::dispatchStorageEvent):
  59596. * dom/EventTargetNode.h:
  59597. * dom/MessagePort.cpp:
  59598. (WebCore::MessagePort::dispatchMessages):
  59599. (WebCore::MessagePort::dispatchCloseEvent):
  59600. (WebCore::MessagePort::dispatchEvent):
  59601. * dom/MessagePort.h:
  59602. * editing/Editor.cpp:
  59603. (WebCore::Editor::dispatchCPPEvent):
  59604. (WebCore::dispatchEditableContentChangedEvents):
  59605. * editing/ReplaceSelectionCommand.cpp:
  59606. (WebCore::ReplacementFragment::ReplacementFragment):
  59607. * editing/TypingCommand.cpp:
  59608. (WebCore::TypingCommand::insertText):
  59609. * loader/appcache/DOMApplicationCache.cpp:
  59610. (WebCore::DOMApplicationCache::dispatchEvent):
  59611. (WebCore::DOMApplicationCache::callListener):
  59612. * loader/appcache/DOMApplicationCache.h:
  59613. * page/EventHandler.cpp:
  59614. (WebCore::EventHandler::dispatchDragEvent):
  59615. (WebCore::EventHandler::keyEvent):
  59616. (WebCore::EventHandler::handleTextInputEvent):
  59617. * page/FrameView.cpp:
  59618. (WebCore::FrameView::scheduleEvent):
  59619. (WebCore::FrameView::updateOverflowStatus):
  59620. (WebCore::FrameView::dispatchScheduledEvents):
  59621. * page/FrameView.h:
  59622. * rendering/RenderLayer.cpp:
  59623. (WebCore::RenderLayer::scrollToOffset):
  59624. (WebCore::RenderLayer::updateOverflowStatus):
  59625. * svg/SVGElement.cpp:
  59626. (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  59627. * svg/SVGElementInstance.cpp:
  59628. (WebCore::SVGElementInstance::dispatchEvent):
  59629. * svg/SVGElementInstance.h:
  59630. * xml/XMLHttpRequest.cpp:
  59631. (WebCore::XMLHttpRequest::dispatchEvent):
  59632. (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
  59633. (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
  59634. * xml/XMLHttpRequest.h:
  59635. * xml/XMLHttpRequestUpload.cpp:
  59636. (WebCore::XMLHttpRequestUpload::dispatchEvent):
  59637. (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
  59638. * xml/XMLHttpRequestUpload.h:
  59639. Don't pass the tempEvent boolean around.
  59640. 2008-10-20 Alp Toker <alp@nuanti.com>
  59641. Remove unused includes only. Partial GTK+/Win build fix.
  59642. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  59643. 2008-10-20 Alexey Proskuryakov <ap@webkit.org>
  59644. Reviewed by Oliver Hunt.
  59645. https://bugs.webkit.org/show_bug.cgi?id=21705
  59646. Implement Web Workers client-side API
  59647. The implementation is experimental, and disabled by default. It doesn't quite match the
  59648. published draft, being influenced by further WHATWG discussions.
  59649. This only implements the client-side API, and does not actually create any threads or
  59650. global contexts yet.
  59651. * DerivedSources.make: Added DedicatedWorker. SharedWorker is not implemented yet, as I'm
  59652. still not sure if having separate classes for these helps at all.
  59653. * WebCore.xcodeproj/project.pbxproj: Added new files.
  59654. * bindings/js/JSDOMWindowBase.cpp:
  59655. (jsDOMWindowBaseWorker):
  59656. (WebCore::JSDOMWindowBase::put):
  59657. (setJSDOMWindowBaseWorker):
  59658. Added window.Worker constructor. Moved JSXSLTProcessorConstructor.h include out of ifdef
  59659. to match prevailing style.
  59660. * bindings/js/JSDedicatedWorkerConstructor.cpp: Added.
  59661. * bindings/js/JSDedicatedWorkerConstructor.h: Added.
  59662. * bindings/js/JSDedicatedWorkerCustom.cpp: Added.
  59663. The implementation of event listeners are left custom intentionally, for easier implementation
  59664. of listeners that are not tied to any Document in the future.
  59665. * dom/DedicatedWorker.cpp: Added.
  59666. * dom/DedicatedWorker.h: Added.
  59667. * dom/DedicatedWorker.idl: Added.
  59668. Added an implementation that can only load requested scripts for now.
  59669. 2008-10-19 Darin Adler <darin@apple.com>
  59670. Reviewed by Dan Bernstein.
  59671. - fix assertion seen when opening inspector
  59672. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  59673. (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
  59674. Removed unneeded asObject cast.
  59675. 2008-10-19 Dan Bernstein <mitz@apple.com>
  59676. Rubber-stamped by Timothy Hatcher.
  59677. - remove empty directories and correct the MIME type of inspector images
  59678. * page/inspector: Removed.
  59679. * page/inspector/Images: Removed.
  59680. 2008-10-19 Timothy Hatcher <timothy@apple.com>
  59681. Make the Web Inspector Resources panel open quicker and change graphs
  59682. faster. There was some accidental n^2 logic at fault when updating the
  59683. graph boundaries.
  59684. https://bugs.webkit.org/show_bug.cgi?id=21742
  59685. Reviewed by Darin Adler.
  59686. * inspector/front-end/ResourcesPanel.js:
  59687. (WebInspector.ResourcesPanel.prototype.set calculator): Return early for
  59688. a null calculator. Remove the second argument passed to _refreshAllResources.
  59689. (WebInspector.ResourcesPanel.prototype.refresh): Call updateBoundaries on
  59690. the calculator for all the stale resources before calling refreshResource.
  59691. Pass true for the first argument of refreshResource to skip the boundary update.
  59692. (WebInspector.ResourcesPanel.prototype._updateGraphBoundariesIfNeeded): Remove
  59693. the second argument passed to _refreshAllResources.
  59694. (WebInspector.ResourcesPanel.prototype._refreshAllResourcesSoon): Remove the
  59695. skipSort argument since every passed true, and it would be bad to pass false.
  59696. (WebInspector.ResourcesPanel.prototype._refreshAllResources): Ditto. And if
  59697. skipBoundaryUpdate is false, call updateBoundaries on the calculator for all
  59698. the resources before calling refreshResource. Pass true for the first argument
  59699. of refreshResource to skip the boundary update.
  59700. 2008-10-19 Timothy Hatcher <timothy@apple.com>
  59701. Visually distinguish resources that loaded from the memory cache.
  59702. https://bugs.webkit.org/show_bug.cgi?id=14279
  59703. Reviewed by Dan Bernstein.
  59704. * English.lproj/localizedStrings.js: New string.
  59705. * inspector/front-end/Images/timelineHollowPillBlue.png: Added.
  59706. * inspector/front-end/Images/timelineHollowPillGray.png: Added.
  59707. * inspector/front-end/Images/timelineHollowPillGreen.png: Added.
  59708. * inspector/front-end/Images/timelineHollowPillOrange.png: Added.
  59709. * inspector/front-end/Images/timelineHollowPillPurple.png: Added.
  59710. * inspector/front-end/Images/timelineHollowPillRed.png: Added.
  59711. * inspector/front-end/Images/timelineHollowPillYellow.png: Added.
  59712. * inspector/front-end/ResourcesPanel.js:
  59713. (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels):
  59714. Add the "(from cache)" suffix to the tooltip.
  59715. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
  59716. Add the "(from cache)" suffix to the tooltip.
  59717. (WebInspector.ResourceGraph): Add the "resource-cached" class.
  59718. * inspector/front-end/inspector.css: New styles to make the timeline
  59719. bars use the hollow pill images.
  59720. 2008-10-19 Timothy Hatcher <timothy@apple.com>
  59721. Update the scroll position in the Resources panel when loading
  59722. a new page or toggling on small resource rows.
  59723. https://bugs.webkit.org/show_bug.cgi?id=20114
  59724. Reviewed by Darin Adler.
  59725. * inspector/front-end/ResourcesPanel.js:
  59726. (WebInspector.ResourcesPanel.prototype.reset): Scroll to the top,
  59727. since all the resource are being removed.
  59728. (WebInspector.ResourcesPanel.prototype.removeResource): Call
  59729. _adjustScrollPosition in case the view is shorter and needs scrolled.
  59730. (WebInspector.ResourcesPanel.prototype._toggleLargerResources): Ditto.
  59731. (WebInspector.ResourcesPanel.prototype._adjustScrollPosition): Check
  59732. the height of the sidebar against the scrollTop and height of the
  59733. resourcesContainerElement. If the sidebar is shorter, scroll up
  59734. so the last resource is at the bottom again.
  59735. 2008-10-19 Timothy Hatcher <timothy@apple.com>
  59736. Show per resource times and sizes when hovering over the bar graph for a resource.
  59737. https://bugs.webkit.org/show_bug.cgi?id=14300
  59738. rdar://problem/5712802
  59739. Reviewed by Cameron Zwarich.
  59740. * English.lproj/localizedStrings.js: Add new strings.
  59741. * inspector/front-end/Images/graphLabelCalloutLeft.png: Added.
  59742. * inspector/front-end/Images/graphLabelCalloutRight.png: Added.
  59743. * inspector/front-end/ResourcesPanel.js:
  59744. (WebInspector.ResourcesPanel.prototype.refreshResource): Pass the calculator to the
  59745. ResourceGraph.refresh function.
  59746. (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels): Default implementation
  59747. returns the formatted value.
  59748. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): Return discrete values
  59749. for the latency and download times. Also generate a custom tooltip.
  59750. (WebInspector.ResourceGraph): Add a mouseover event listener that calls refreshLabelPositions.
  59751. (WebInspector.ResourceGraph.prototype.refreshLabelPositions): Added. Updates the label positions
  59752. in case the bar has changed size.
  59753. (WebInspector.ResourceGraph.prototype.refresh): Set the label text and tooltips.
  59754. * inspector/front-end/inspector.css: New styles for the labels.
  59755. 2008-10-19 Darin Adler <darin@apple.com>
  59756. Reviewed by Oliver Hunt.
  59757. - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
  59758. improve performance by eliminating JSValue as a base class for JSCell
  59759. Remove most uses of JSValue, which will be removed in a future patch.
  59760. * bindings/js/JSCustomXPathNSResolver.h: Removed declaration of JSValue
  59761. and used JSValuePtr instead.
  59762. * bindings/js/JSEventTarget.h: Ditto.
  59763. * bindings/js/JSNodeFilterCondition.h: Ditto.
  59764. * bindings/js/ScheduledAction.h: Ditto.
  59765. * bindings/js/ScriptController.h: Ditto.
  59766. * bindings/objc/WebScriptObjectPrivate.h: Ditto.
  59767. * bridge/c/c_utility.h: Ditto.
  59768. * bridge/jni/jni_jsobject.h: Ditto.
  59769. * bridge/jni/jni_utility.h: Ditto.
  59770. * bridge/objc/WebScriptObject.h: Ditto.
  59771. * dom/Traversal.h: Ditto.
  59772. * inspector/InspectorController.cpp: Ditto.
  59773. * inspector/JavaScriptProfile.h: Ditto.
  59774. * inspector/JavaScriptProfileNode.h: Ditto.
  59775. * loader/FrameLoader.h: Ditto.
  59776. * page/Console.h: Ditto.
  59777. * plugins/MimeTypeArray.h: Ditto.
  59778. * plugins/Plugin.h: Ditto.
  59779. * plugins/PluginArray.h: Ditto.
  59780. * plugins/PluginView.cpp:
  59781. (WebCore::getString): Ditto.
  59782. (WebCore::PluginView::performRequest): Ditto.
  59783. * plugins/gtk/PluginViewGtk.cpp: Ditto.
  59784. * plugins/qt/PluginViewQt.cpp: Ditto.
  59785. * plugins/win/PluginViewWin.cpp: Ditto.
  59786. * bridge/qt/qt_class.cpp:
  59787. (JSC::Bindings::QtClass::fallbackObject): Use JSValuePtr and JSObject*
  59788. instead of JSValue*.
  59789. * bridge/qt/qt_class.h: Ditto.
  59790. * bridge/qt/qt_instance.cpp:
  59791. (JSC::Bindings::QtInstance::mark): Ditto.
  59792. (JSC::Bindings::QtInstance::invokeMethod): Ditto.
  59793. (JSC::Bindings::QtInstance::defaultValue): Ditto.
  59794. (JSC::Bindings::QtInstance::stringValue): Ditto.
  59795. (JSC::Bindings::QtInstance::numberValue): Ditto.
  59796. (JSC::Bindings::QtInstance::booleanValue): Ditto.
  59797. (JSC::Bindings::QtInstance::valueOf): Ditto.
  59798. (JSC::Bindings::QtField::valueFromInstance): Ditto.
  59799. (JSC::Bindings::QtField::setValueToInstance): Ditto.
  59800. * bridge/qt/qt_instance.h: Ditto.
  59801. * bridge/qt/qt_runtime.cpp: Ditto.
  59802. (JSC::Bindings::valueRealType): Ditto.
  59803. (JSC::Bindings::convertValueToQVariant): Ditto.
  59804. (JSC::Bindings::convertQVariantToValue): Ditto.
  59805. (JSC::Bindings::findMethodIndex): Ditto.
  59806. (JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.
  59807. (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): Ditto.
  59808. (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto.
  59809. (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
  59810. (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
  59811. (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto.
  59812. (JSC::Bindings::QtArray::setValueAt): Ditto.
  59813. (JSC::Bindings::QtArray::valueAt): Ditto.
  59814. * bridge/qt/qt_runtime.h: Ditto.
  59815. * bridge/testqtbindings.cpp:
  59816. (main): Use JSValuePtr.
  59817. 2008-10-18 Darin Adler <darin@apple.com>
  59818. Reviewed by Oliver Hunt.
  59819. - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
  59820. improve performance by eliminating JSValue as a base class for JSCell
  59821. Tweak a little more to get closer to where we can make JSValuePtr a class.
  59822. * bindings/js/JSAudioConstructor.cpp:
  59823. (WebCore::JSAudioConstructor::JSAudioConstructor): Use asObject.
  59824. (WebCore::constructAudio): Ditto.
  59825. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  59826. (WebCore::JSCSSStyleDeclaration::nameGetter): Ditto.
  59827. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  59828. (WebCore::toHTMLCanvasStyle): Use asString and asObject.
  59829. (WebCore::JSCanvasRenderingContext2D::setFillColor): Ditto.
  59830. (WebCore::JSCanvasRenderingContext2D::setStrokeColor): Ditto.
  59831. (WebCore::JSCanvasRenderingContext2D::drawImage): Ditto.
  59832. (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): Ditto.
  59833. (WebCore::JSCanvasRenderingContext2D::setShadow): Ditto.
  59834. (WebCore::JSCanvasRenderingContext2D::createPattern): Ditto.
  59835. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  59836. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): Use JSValuePtr.
  59837. * bindings/js/JSDOMBinding.cpp:
  59838. (WebCore::setDOMException): Use noValue.
  59839. * bindings/js/JSDOMBinding.h:
  59840. (WebCore::getDOMPrototype): Use asObject.
  59841. * bindings/js/JSDOMWindowBase.cpp:
  59842. (WebCore::showModalDialog): Use noValue.
  59843. (jsDOMWindowBaseEvent): Use asObject.
  59844. (jsDOMWindowBaseImage): Ditto.
  59845. (jsDOMWindowBaseMessageChannel): Ditto.
  59846. (jsDOMWindowBaseOption): Ditto.
  59847. (jsDOMWindowBaseXMLHttpRequest): Ditto.
  59848. (jsDOMWindowBaseAudio): Ditto.
  59849. (jsDOMWindowBaseXSLTProcessor): Ditto.
  59850. (WebCore::JSDOMWindowBase::childFrameGetter): Ditto.
  59851. (WebCore::JSDOMWindowBase::indexGetter): Ditto.
  59852. (WebCore::JSDOMWindowBase::namedItemGetter): Ditto.
  59853. (WebCore::JSDOMWindowBase::getOwnPropertySlot): Ditto.
  59854. (WebCore::JSDOMWindowBase::findJSEventListener): Ditto.
  59855. (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): Ditto.
  59856. (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): Ditto.
  59857. (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): Ditto.
  59858. (windowProtoFuncOpen): Use noValue.
  59859. (WebCore::toJSDOMWindow): Use asObject.
  59860. * bindings/js/JSDOMWindowCustom.cpp:
  59861. (WebCore::setTimeoutOrInterval): Use asString.
  59862. (WebCore::toDOMWindow): Use asObject.
  59863. * bindings/js/JSEventListener.cpp:
  59864. (WebCore::JSAbstractEventListener::handleEvent): Use noValue.
  59865. (WebCore::JSLazyEventListener::parseCode): Use asObject.
  59866. * bindings/js/JSHTMLCollectionCustom.cpp:
  59867. (WebCore::JSHTMLCollection::nameGetter): Use asObject.
  59868. * bindings/js/JSHTMLDocumentCustom.cpp:
  59869. (WebCore::JSHTMLDocument::nameGetter): Ditto.
  59870. * bindings/js/JSHTMLElementCustom.cpp:
  59871. (WebCore::JSHTMLElement::pushEventHandlerScope): Ditto.
  59872. * bindings/js/JSHTMLFormElementCustom.cpp:
  59873. (WebCore::JSHTMLFormElement::nameGetter): Ditto.
  59874. * bindings/js/JSHTMLFrameSetElementCustom.cpp:
  59875. (WebCore::JSHTMLFrameSetElement::nameGetter): Ditto.
  59876. * bindings/js/JSHTMLOptionElementConstructor.cpp:
  59877. (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
  59878. (WebCore::constructHTMLOptionElement): Ditto.
  59879. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  59880. (WebCore::JSHTMLOptionsCollection::remove): Ditto.
  59881. * bindings/js/JSImageConstructor.cpp:
  59882. (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
  59883. (WebCore::constructImage): Ditto.
  59884. * bindings/js/JSInspectedObjectWrapper.cpp:
  59885. (WebCore::JSInspectedObjectWrapper::wrap): Ditto.
  59886. * bindings/js/JSInspectorCallbackWrapper.cpp:
  59887. (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
  59888. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  59889. (WebCore::JSJavaScriptCallFrame::evaluate): Use noValue.
  59890. * bindings/js/JSMessageChannelConstructor.cpp:
  59891. (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Use asObject.
  59892. (WebCore::JSMessageChannelConstructor::construct): Ditto.
  59893. * bindings/js/JSMimeTypeArrayCustom.cpp:
  59894. (WebCore::JSMimeTypeArray::nameGetter): Ditto.
  59895. * bindings/js/JSNamedNodeMapCustom.cpp:
  59896. (WebCore::JSNamedNodeMap::nameGetter): Ditto.
  59897. * bindings/js/JSNamedNodesCollection.cpp:
  59898. (WebCore::JSNamedNodesCollection::lengthGetter): Ditto.
  59899. (WebCore::JSNamedNodesCollection::indexGetter): Ditto.
  59900. * bindings/js/JSNodeFilterCustom.cpp:
  59901. (WebCore::toNodeFilter): Ditto.
  59902. * bindings/js/JSNodeListCustom.cpp:
  59903. (WebCore::JSNodeList::nameGetter): Ditto.
  59904. * bindings/js/JSPluginArrayCustom.cpp:
  59905. (WebCore::JSPluginArray::nameGetter): Ditto.
  59906. * bindings/js/JSPluginCustom.cpp:
  59907. (WebCore::JSPlugin::nameGetter): Ditto.
  59908. * bindings/js/JSPluginElementFunctions.cpp:
  59909. (WebCore::runtimeObjectGetter): Ditto.
  59910. (WebCore::runtimeObjectPropertyGetter): Ditto.
  59911. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  59912. (WebCore::JSQuarantinedObjectWrapper::asWrapper): Ditto.
  59913. (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Ditto.
  59914. (WebCore::JSQuarantinedObjectWrapper::construct): Ditto.
  59915. * bindings/js/JSRGBColor.cpp:
  59916. (jsRGBColorRed): Ditto.
  59917. (jsRGBColorGreen): Ditto.
  59918. (jsRGBColorBlue): Ditto.
  59919. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  59920. (WebCore::JSSQLResultSetRowList::item): Use noValue.
  59921. * bindings/js/JSStorageCustom.cpp:
  59922. (WebCore::JSStorage::nameGetter): Use asObject.
  59923. (WebCore::JSStorage::deleteProperty): Ditto.
  59924. (WebCore::JSStorage::customPut): Ditto.
  59925. * bindings/js/JSStyleSheetListCustom.cpp:
  59926. (WebCore::JSStyleSheetList::nameGetter): Ditto.
  59927. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  59928. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): Ditto.
  59929. * bindings/js/JSXSLTProcessorCustom.cpp:
  59930. (WebCore::JSXSLTProcessor::importStylesheet): Ditto.
  59931. (WebCore::JSXSLTProcessor::transformToFragment): Ditto.
  59932. (WebCore::JSXSLTProcessor::transformToDocument): Ditto.
  59933. * bindings/js/ScriptController.cpp:
  59934. (WebCore::ScriptController::evaluate): Use noValue.
  59935. * bindings/objc/DOMInternal.mm:
  59936. (-[WebScriptObject _initializeScriptDOMNodeImp]): Ditto.
  59937. * bindings/objc/WebScriptObject.mm:
  59938. (-[WebScriptObject evaluateWebScript:]): Use JSValuePtr.
  59939. (-[WebScriptObject valueForKey:]): Ditto.
  59940. (-[WebScriptObject webScriptValueAtIndex:]): Ditto.
  59941. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  59942. Use asObject and asString.
  59943. * bindings/scripts/CodeGeneratorJS.pm: Use asObject.
  59944. * bridge/c/c_instance.h: Use JSValuePtr.
  59945. * bridge/c/c_runtime.cpp:
  59946. (JSC::Bindings::CField::setValueToInstance): Ditto.
  59947. * bridge/c/c_utility.cpp:
  59948. (JSC::Bindings::convertValueToNPVariant): Use asObject.
  59949. * bridge/jni/jni_instance.cpp:
  59950. (JavaInstance::booleanValue): Use JSValuePtr.
  59951. (JavaInstance::invokeMethod): Ditto. And noValue.
  59952. * bridge/jni/jni_jsobject.mm:
  59953. (JavaJSObject::getSlot): Ditto.
  59954. (JavaJSObject::convertValueToJObject): Ditto.
  59955. * bridge/jni/jni_runtime.cpp:
  59956. (JavaField::dispatchValueFromInstance): Ditto.
  59957. (JavaField::valueFromInstance): Ditto.
  59958. (JavaField::dispatchSetValueToInstance): Ditto.
  59959. (JavaField::setValueToInstance): Ditto.
  59960. (JavaArray::setValueAt): Ditto.
  59961. (JavaArray::valueAt): Ditto.
  59962. * bridge/jni/jni_runtime.h: Ditto.
  59963. * bridge/jni/jni_utility.cpp:
  59964. (JSC::Bindings::convertArrayInstanceToJavaArray): Take a JSArray*
  59965. instead of a JSValue*.
  59966. (JSC::Bindings::convertValueToJValue): Use asObject and asArray.
  59967. * bridge/objc/objc_class.h: Use JSValuePtr.
  59968. * bridge/objc/objc_instance.h: Ditto.
  59969. * bridge/objc/objc_runtime.h: Ditto.
  59970. * bridge/objc/objc_runtime.mm:
  59971. (JSC::Bindings::callObjCFallbackObject): Use asObject.
  59972. * bridge/objc/objc_utility.h: Use JSValuePtr.
  59973. * bridge/objc/objc_utility.mm:
  59974. (JSC::Bindings::convertValueToObjcValue): Use JSValuePtr and asObject.
  59975. (JSC::Bindings::convertObjcValueToValue): Use jsUndefined() instead of 0.
  59976. * bridge/runtime.cpp:
  59977. (JSC::Bindings::Instance::getValueOfField): Use JSValuePtr.
  59978. (JSC::Bindings::Instance::setValueOfField): Ditto.
  59979. * bridge/runtime_array.cpp:
  59980. (JSC::RuntimeArray::lengthGetter): Use JSValuePtr and asObject.
  59981. (JSC::RuntimeArray::indexGetter): Ditto.
  59982. * bridge/runtime_array.h: Ditto.
  59983. * bridge/runtime_method.cpp:
  59984. (JSC::RuntimeMethod::lengthGetter): Ditto.
  59985. (JSC::callRuntimeMethod): Ditto.
  59986. * bridge/runtime_object.cpp:
  59987. (JSC::RuntimeObjectImp::fallbackObjectGetter): Ditto.
  59988. (JSC::RuntimeObjectImp::fieldGetter): Ditto.
  59989. (JSC::RuntimeObjectImp::methodGetter): Ditto.
  59990. * loader/FrameLoader.cpp:
  59991. (WebCore::FrameLoader::executeScript): Use noValue.
  59992. * page/Console.cpp:
  59993. (WebCore::Console::trace): Use asInternalFunction.
  59994. 2008-10-19 Dan Bernstein <mitz@apple.com>
  59995. Reviewed by Timothy Hatcher.
  59996. - lower the default button repaint frequency
  59997. * rendering/RenderButton.cpp:
  59998. (WebCore::RenderButton::styleDidChange): Changed the timer interval from
  59999. 0.01 to 0.03.
  60000. 2008-10-18 Dan Bernstein <mitz@apple.com>
  60001. Reviewed by Mark Rowe.
  60002. - Windows build fix
  60003. * rendering/RenderThemeSafari.cpp:
  60004. (WebCore::RenderThemeSafari::paintMediaFullscreenButton):
  60005. (WebCore::RenderThemeSafari::paintMediaMuteButton):
  60006. (WebCore::RenderThemeSafari::paintMediaPlayButton):
  60007. (WebCore::RenderThemeSafari::paintMediaSeekBackButton):
  60008. (WebCore::RenderThemeSafari::paintMediaSeekForwardButton):
  60009. (WebCore::RenderThemeSafari::paintMediaSliderThumb):
  60010. 2008-10-18 Dan Bernstein <mitz@apple.com>
  60011. Reviewed by Sam Weinig.
  60012. - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=21736
  60013. Long-dead decoded image data make up for most of the object cache's memory use over time
  60014. Add a cache setting for how long decoded image data should be allowed to
  60015. persist in memory after the image has died. By default, this is set to
  60016. 0, which means "forever".
  60017. * loader/Cache.cpp:
  60018. (WebCore::Cache::Cache): Initialize m_deadDecodedDataDeletionInterval.
  60019. * loader/Cache.h:
  60020. (WebCore::Cache::setDeadDecodedDataDeletionInterval): Added a setter.
  60021. (WebCore::Cache::deadDecodedDataDeletionInterval): Added a getter.
  60022. * loader/CachedImage.cpp:
  60023. (WebCore::CachedImage::CachedImage): Initialize the decoded data
  60024. deletion timer.
  60025. (WebCore::CachedImage::decodedDataDeletionTimerFired): Added. Destroys
  60026. the decoded image data.
  60027. (WebCore::CachedImage::addClient): Stop the timer if it is active.
  60028. (WebCore::CachedImage::allClientsRemoved): Start the decoded data
  60029. deletion timer.
  60030. * loader/CachedImage.h:
  60031. 2008-10-18 Darin Adler <darin@apple.com>
  60032. Reviewed by Dan Bernstein.
  60033. - fix https://bugs.webkit.org/show_bug.cgi?id=21645
  60034. REGRESSION (r37469-r37605): File Input not Uploaded in Multipart/Form-data Form
  60035. * html/HTMLFormElement.cpp:
  60036. (WebCore::HTMLFormElement::formData):
  60037. Fix loop that goes through the FormDataList to go two at a time in a clearer
  60038. way. My last patch screwed up the way it got form content from the items.
  60039. This "two at a time" approach is a confusing way to do things, which explains
  60040. why I got it wrong last time through, but I decided to just fix it locally for
  60041. now rather than changing the design of FormDataList.
  60042. 2008-10-18 Darin Adler <darin@apple.com>
  60043. Reviewed by Cameron Zwarich.
  60044. - next step on https://bugs.webkit.org/show_bug.cgi?id=21732
  60045. improve performance by eliminating JSValue as a base class for JSCell
  60046. Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
  60047. changing JSValuePtr to be a class, and then eventually renaming it
  60048. to JSValue once that's done.
  60049. * bindings/js/JSAttrCustom.cpp:
  60050. * bindings/js/JSCSSRuleCustom.cpp:
  60051. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  60052. * bindings/js/JSCSSValueCustom.cpp:
  60053. * bindings/js/JSCanvasPixelArrayCustom.h:
  60054. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  60055. * bindings/js/JSClipboardCustom.cpp:
  60056. * bindings/js/JSConsoleCustom.cpp:
  60057. * bindings/js/JSCustomSQLStatementCallback.cpp:
  60058. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  60059. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  60060. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  60061. * bindings/js/JSCustomVoidCallback.cpp:
  60062. * bindings/js/JSCustomVoidCallback.h:
  60063. * bindings/js/JSCustomXPathNSResolver.cpp:
  60064. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  60065. * bindings/js/JSDOMBinding.cpp:
  60066. * bindings/js/JSDOMBinding.h:
  60067. * bindings/js/JSDOMWindowBase.cpp:
  60068. * bindings/js/JSDOMWindowBase.h:
  60069. * bindings/js/JSDOMWindowCustom.cpp:
  60070. * bindings/js/JSDOMWindowCustom.h:
  60071. * bindings/js/JSDOMWindowShell.cpp:
  60072. * bindings/js/JSDOMWindowShell.h:
  60073. * bindings/js/JSDatabaseCustom.cpp:
  60074. * bindings/js/JSDocumentCustom.cpp:
  60075. * bindings/js/JSElementCustom.cpp:
  60076. * bindings/js/JSEventCustom.cpp:
  60077. * bindings/js/JSEventListener.cpp:
  60078. * bindings/js/JSEventTarget.cpp:
  60079. * bindings/js/JSEventTargetBase.h:
  60080. * bindings/js/JSEventTargetNodeCustom.cpp:
  60081. * bindings/js/JSHTMLAllCollection.h:
  60082. * bindings/js/JSHTMLAppletElementCustom.cpp:
  60083. * bindings/js/JSHTMLCollectionCustom.cpp:
  60084. * bindings/js/JSHTMLDocumentCustom.cpp:
  60085. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  60086. * bindings/js/JSHTMLFormElementCustom.cpp:
  60087. * bindings/js/JSHTMLFrameElementCustom.cpp:
  60088. * bindings/js/JSHTMLFrameSetElementCustom.cpp:
  60089. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  60090. * bindings/js/JSHTMLInputElementCustom.cpp:
  60091. * bindings/js/JSHTMLObjectElementCustom.cpp:
  60092. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  60093. * bindings/js/JSHTMLSelectElementCustom.cpp:
  60094. * bindings/js/JSHTMLSelectElementCustom.h:
  60095. * bindings/js/JSHistoryCustom.cpp:
  60096. * bindings/js/JSImageDataCustom.cpp:
  60097. * bindings/js/JSInspectedObjectWrapper.cpp:
  60098. * bindings/js/JSInspectedObjectWrapper.h:
  60099. * bindings/js/JSInspectorCallbackWrapper.cpp:
  60100. * bindings/js/JSInspectorCallbackWrapper.h:
  60101. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  60102. * bindings/js/JSLocationCustom.cpp:
  60103. * bindings/js/JSMessagePortCustom.cpp:
  60104. * bindings/js/JSMimeTypeArrayCustom.cpp:
  60105. * bindings/js/JSNamedNodeMapCustom.cpp:
  60106. * bindings/js/JSNamedNodesCollection.cpp:
  60107. * bindings/js/JSNamedNodesCollection.h:
  60108. * bindings/js/JSNavigatorCustom.cpp:
  60109. * bindings/js/JSNodeCustom.cpp:
  60110. * bindings/js/JSNodeFilterCondition.cpp:
  60111. * bindings/js/JSNodeFilterCustom.cpp:
  60112. * bindings/js/JSNodeIteratorCustom.cpp:
  60113. * bindings/js/JSNodeListCustom.cpp:
  60114. * bindings/js/JSPluginArrayCustom.cpp:
  60115. * bindings/js/JSPluginCustom.cpp:
  60116. * bindings/js/JSPluginElementFunctions.cpp:
  60117. * bindings/js/JSPluginElementFunctions.h:
  60118. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  60119. * bindings/js/JSQuarantinedObjectWrapper.h:
  60120. * bindings/js/JSRGBColor.cpp:
  60121. * bindings/js/JSRGBColor.h:
  60122. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  60123. * bindings/js/JSSQLTransactionCustom.cpp:
  60124. * bindings/js/JSSVGElementInstanceCustom.cpp:
  60125. * bindings/js/JSSVGLengthCustom.cpp:
  60126. * bindings/js/JSSVGMatrixCustom.cpp:
  60127. * bindings/js/JSSVGPathSegCustom.cpp:
  60128. * bindings/js/JSSVGPathSegListCustom.cpp:
  60129. * bindings/js/JSSVGPointListCustom.cpp:
  60130. * bindings/js/JSSVGTransformListCustom.cpp:
  60131. * bindings/js/JSStorageCustom.cpp:
  60132. * bindings/js/JSStyleSheetCustom.cpp:
  60133. * bindings/js/JSStyleSheetListCustom.cpp:
  60134. * bindings/js/JSTextCustom.cpp:
  60135. * bindings/js/JSTreeWalkerCustom.cpp:
  60136. * bindings/js/JSXMLHttpRequestCustom.cpp:
  60137. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  60138. * bindings/js/JSXSLTProcessorCustom.cpp:
  60139. * bindings/js/ScheduledAction.cpp:
  60140. * bindings/js/ScheduledAction.h:
  60141. * bindings/js/ScriptController.cpp:
  60142. * bindings/js/ScriptController.h:
  60143. * bindings/objc/WebScriptObject.mm:
  60144. * bindings/scripts/CodeGeneratorJS.pm:
  60145. * bridge/NP_jsobject.cpp:
  60146. * bridge/c/c_instance.cpp:
  60147. * bridge/c/c_instance.h:
  60148. * bridge/c/c_runtime.cpp:
  60149. * bridge/c/c_runtime.h:
  60150. * bridge/c/c_utility.cpp:
  60151. * bridge/jni/jni_instance.cpp:
  60152. * bridge/jni/jni_instance.h:
  60153. * bridge/jni/jni_jsobject.mm:
  60154. * bridge/jni/jni_objc.mm:
  60155. * bridge/jni/jni_runtime.cpp:
  60156. * bridge/jni/jni_runtime.h:
  60157. * bridge/jni/jni_utility.cpp:
  60158. * bridge/objc/objc_class.mm:
  60159. * bridge/objc/objc_instance.h:
  60160. * bridge/objc/objc_instance.mm:
  60161. * bridge/objc/objc_runtime.h:
  60162. * bridge/objc/objc_runtime.mm:
  60163. * bridge/objc/objc_utility.h:
  60164. * bridge/objc/objc_utility.mm:
  60165. * bridge/runtime.h:
  60166. * bridge/runtime_array.cpp:
  60167. * bridge/runtime_array.h:
  60168. * bridge/runtime_method.cpp:
  60169. * bridge/runtime_method.h:
  60170. * bridge/runtime_object.cpp:
  60171. * bridge/runtime_object.h:
  60172. * inspector/JavaScriptCallFrame.cpp:
  60173. * inspector/JavaScriptCallFrame.h:
  60174. * inspector/JavaScriptProfile.cpp:
  60175. * inspector/JavaScriptProfileNode.cpp:
  60176. * loader/FrameLoader.cpp:
  60177. * loader/FrameLoader.h:
  60178. * page/Console.cpp:
  60179. * page/Console.h:
  60180. * plugins/MimeTypeArray.h:
  60181. * plugins/Plugin.h:
  60182. * plugins/PluginArray.h:
  60183. * xml/XMLHttpRequest.cpp:
  60184. Replace JSValue* with JSValuePtr.
  60185. 2008-10-18 Darin Adler <darin@apple.com>
  60186. Reviewed by Oliver Hunt.
  60187. - first step of https://bugs.webkit.org/show_bug.cgi?id=21732
  60188. improve performance by eliminating JSValue as a base class for JSCell
  60189. Update for change to make PreferredPrimitiveType no longer
  60190. a member of JSValue.
  60191. * bridge/c/c_instance.cpp:
  60192. (JSC::Bindings::CInstance::defaultValue): Removed JSValue:: prefix.
  60193. * bridge/jni/jni_instance.cpp:
  60194. (JavaInstance::defaultValue): Ditto.
  60195. * bridge/objc/objc_instance.mm:
  60196. (ObjcInstance::defaultValue): Ditto.
  60197. * bridge/qt/qt_instance.cpp:
  60198. (JSC::Bindings::QtInstance::defaultValue): Ditto.
  60199. * bridge/runtime.h: Ditto. Also removed typedef.
  60200. 2008-10-18 Darin Adler <darin@apple.com>
  60201. - try to fix Windows build
  60202. * rendering/RenderThemeSafari.cpp:
  60203. (WebCore::RenderThemeSafari::paintCheckbox): Explicitly qualify part name with
  60204. SafariTheme namespace, since there is now an identically named constant in
  60205. the ControlPart enum.
  60206. (WebCore::RenderThemeSafari::paintButton): Ditto.
  60207. (WebCore::RenderThemeSafari::paintTextField): Ditto.
  60208. (WebCore::RenderThemeSafari::paintTextArea): Ditto.
  60209. (WebCore::RenderThemeSafari::paintSearchField): Ditto.
  60210. (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Ditto.
  60211. (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Ditto.
  60212. (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.
  60213. 2008-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
  60214. Reviewed by Alp Toker.
  60215. [GTK] crash after selecting a file on an <input type=file>
  60216. https://bugs.webkit.org/show_bug.cgi?id=21385
  60217. Follow Mac and Win's behaviors for Icon::paint
  60218. * platform/graphics/gtk/IconGtk.cpp:
  60219. (WebCore::Icon::paint): check if painting is enabled before
  60220. painting the icon
  60221. 2008-10-18 Zan Dobersek <zandobersek@gmail.com>
  60222. Reviewed by Oliver Hunt.
  60223. Qt port build fix.
  60224. * platform/qt/RenderThemeQt.h:
  60225. 2008-10-17 Kevin Watters <kevinwatters@gmail.com>
  60226. Reviewed by Kevin Ollivier
  60227. Fix wx port's scrollbar and drawing handling after recent changes.
  60228. https://bugs.webkit.org/show_bug.cgi?id=21720
  60229. * platform/ScrollView.h:
  60230. * platform/wx/ScrollViewWx.cpp:
  60231. (WebCore::ScrollView::platformVisibleContentRect):
  60232. (WebCore::ScrollView::platformContentsSize):
  60233. (WebCore::ScrollView::platformSetContentsSize):
  60234. * platform/wx/WidgetWx.cpp:
  60235. (WebCore::Widget::paint):
  60236. 2008-10-17 Kevin Ollivier <kevino@theolliviers.com>
  60237. wx build fix. EAppearance -> ControlPart.
  60238. * platform/wx/RenderThemeWx.cpp:
  60239. (WebCore::RenderThemeWx::isControlStyled):
  60240. (WebCore::RenderThemeWx::adjustRepaintRect):
  60241. (WebCore::RenderThemeWx::controlSupportsTints):
  60242. (WebCore::RenderThemeWx::supportsFocus):
  60243. (WebCore::RenderThemeWx::paintButton):
  60244. 2008-10-17 David Hyatt <hyatt@apple.com>
  60245. Eliminate the EAppearance enum in favor of the new ControlPart enum. Cut out the scrollbar
  60246. values from the enum since they are handled by ScrollbarTheme instead.
  60247. Reviewed by Tim Hatcher
  60248. * css/CSSPrimitiveValueMappings.h:
  60249. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  60250. (WebCore::CSSPrimitiveValue::operator ControlPart):
  60251. * css/CSSStyleSelector.cpp:
  60252. (WebCore::CSSStyleSelector::adjustRenderStyle):
  60253. * css/CSSValueKeywords.in:
  60254. * platform/gtk/RenderThemeGtk.cpp:
  60255. (WebCore::supportsFocus):
  60256. (WebCore::RenderThemeGtk::baselinePosition):
  60257. (WebCore::setToggleSize):
  60258. (WebCore::RenderThemeGtk::setCheckboxSize):
  60259. (WebCore::RenderThemeGtk::setRadioSize):
  60260. (WebCore::RenderThemeGtk::adjustButtonStyle):
  60261. * platform/qt/RenderThemeQt.cpp:
  60262. (WebCore::RenderThemeQt::baselinePosition):
  60263. (WebCore::RenderThemeQt::controlSupportsTints):
  60264. (WebCore::RenderThemeQt::adjustRepaintRect):
  60265. (WebCore::RenderThemeQt::isControlStyled):
  60266. (WebCore::computeSizeBasedOnStyle):
  60267. (WebCore::RenderThemeQt::paintButton):
  60268. (WebCore::RenderThemeQt::paintTextField):
  60269. (WebCore::RenderThemeQt::paintMenuList):
  60270. (WebCore::RenderThemeQt::supportsFocus):
  60271. (WebCore::RenderThemeQt::applyTheme):
  60272. (WebCore::RenderThemeQt::adjustSliderThumbSize):
  60273. * platform/qt/RenderThemeQt.h:
  60274. * rendering/RenderSlider.cpp:
  60275. (WebCore::RenderSlider::createThumbStyle):
  60276. (WebCore::RenderSlider::layout):
  60277. (WebCore::RenderSlider::setValueForPosition):
  60278. (WebCore::RenderSlider::setPositionFromValue):
  60279. (WebCore::RenderSlider::positionForOffset):
  60280. (WebCore::RenderSlider::currentPosition):
  60281. (WebCore::RenderSlider::setCurrentPosition):
  60282. (WebCore::RenderSlider::trackSize):
  60283. * rendering/RenderTheme.cpp:
  60284. (WebCore::RenderTheme::adjustStyle):
  60285. (WebCore::RenderTheme::paint):
  60286. (WebCore::RenderTheme::paintBorderOnly):
  60287. (WebCore::RenderTheme::paintDecorations):
  60288. (WebCore::RenderTheme::isControlContainer):
  60289. (WebCore::RenderTheme::isControlStyled):
  60290. (WebCore::RenderTheme::supportsFocusRing):
  60291. (WebCore::RenderTheme::isDefault):
  60292. * rendering/RenderTheme.h:
  60293. * rendering/RenderThemeMac.mm:
  60294. (WebCore::RenderThemeMac::isControlStyled):
  60295. (WebCore::RenderThemeMac::adjustRepaintRect):
  60296. (WebCore::RenderThemeMac::baselinePosition):
  60297. (WebCore::RenderThemeMac::controlSupportsTints):
  60298. (WebCore::RenderThemeMac::adjustButtonStyle):
  60299. (WebCore::RenderThemeMac::setButtonCellState):
  60300. (WebCore::RenderThemeMac::popupInternalPaddingLeft):
  60301. (WebCore::RenderThemeMac::popupInternalPaddingRight):
  60302. (WebCore::RenderThemeMac::popupInternalPaddingTop):
  60303. (WebCore::RenderThemeMac::popupInternalPaddingBottom):
  60304. (WebCore::RenderThemeMac::paintSliderTrack):
  60305. (WebCore::RenderThemeMac::paintSliderThumb):
  60306. (WebCore::RenderThemeMac::adjustSliderThumbSize):
  60307. * rendering/RenderThemeSafari.cpp:
  60308. (WebCore::RenderThemeSafari::isControlStyled):
  60309. (WebCore::RenderThemeSafari::adjustRepaintRect):
  60310. (WebCore::RenderThemeSafari::baselinePosition):
  60311. (WebCore::RenderThemeSafari::controlSupportsTints):
  60312. (WebCore::RenderThemeSafari::adjustButtonStyle):
  60313. (WebCore::RenderThemeSafari::popupInternalPaddingLeft):
  60314. (WebCore::RenderThemeSafari::popupInternalPaddingRight):
  60315. (WebCore::RenderThemeSafari::popupInternalPaddingTop):
  60316. (WebCore::RenderThemeSafari::popupInternalPaddingBottom):
  60317. (WebCore::RenderThemeSafari::paintSliderTrack):
  60318. (WebCore::RenderThemeSafari::adjustSliderThumbSize):
  60319. * rendering/RenderThemeWin.cpp:
  60320. (WebCore::RenderThemeWin::supportsFocus):
  60321. (WebCore::RenderThemeWin::determineClassicState):
  60322. (WebCore::RenderThemeWin::getClassicThemeData):
  60323. (WebCore::RenderThemeWin::getThemeData):
  60324. (WebCore::drawControl):
  60325. (WebCore::RenderThemeWin::paintSliderTrack):
  60326. (WebCore::RenderThemeWin::adjustSliderThumbSize):
  60327. * rendering/RenderThemeWin.h:
  60328. * rendering/style/RenderStyle.h:
  60329. (WebCore::InheritedFlags::hasAppearance):
  60330. (WebCore::InheritedFlags::appearance):
  60331. (WebCore::InheritedFlags::setAppearance):
  60332. (WebCore::InheritedFlags::initialAppearance):
  60333. * rendering/style/RenderStyleConstants.h:
  60334. 2008-10-17 David Hyatt <hyatt@apple.com>
  60335. Beginning of the RenderTheme re-architecture (to share more code). Add the new Theme API header
  60336. file. Add new USE(NEW_THEME) switch that is enabled on Mac. The Mac theme will be converted first.
  60337. Reviewed by Tim Hatcher
  60338. * WebCore.vcproj/WebCore.vcproj:
  60339. * WebCore.xcodeproj/project.pbxproj:
  60340. * config.h:
  60341. * platform/Theme.h: Added.
  60342. (WebCore::Theme::Theme):
  60343. (WebCore::Theme::~Theme):
  60344. (WebCore::Theme::baselinePositionAdjustment):
  60345. (WebCore::Theme::controlHasInactiveAppearance):
  60346. (WebCore::Theme::controlsCanHaveInactiveAppearance):
  60347. (WebCore::Theme::controlsCanHaveHoveredAppearance):
  60348. (WebCore::Theme::controlDrawsBorder):
  60349. (WebCore::Theme::controlDrawsBackground):
  60350. (WebCore::Theme::controlDrawsFocusOutline):
  60351. (WebCore::Theme::selectionColor):
  60352. (WebCore::Theme::textSearchHighlightColor):
  60353. (WebCore::Theme::systemColor):
  60354. (WebCore::Theme::systemFont):
  60355. (WebCore::Theme::caretBlinkFrequency):
  60356. (WebCore::Theme::themeChanged):
  60357. (WebCore::Theme::controlSize):
  60358. (WebCore::Theme::controlFont):
  60359. (WebCore::Theme::controlPadding):
  60360. (WebCore::Theme::controlInternalPadding):
  60361. (WebCore::Theme::controlBorder):
  60362. (WebCore::Theme::controlBorderRadius):
  60363. (WebCore::Theme::paint):
  60364. (WebCore::Theme::inflateControlPaintRect):
  60365. * platform/ThemeTypes.h: Added.
  60366. (WebCore::):
  60367. (WebCore::ControlBox::ControlBox):
  60368. (WebCore::ControlBox::top):
  60369. (WebCore::ControlBox::right):
  60370. (WebCore::ControlBox::bottom):
  60371. (WebCore::ControlBox::left):
  60372. * platform/mac/ThemeMac.h: Added.
  60373. (WebCore::ThemeMac::ThemeMac):
  60374. (WebCore::ThemeMac::~ThemeMac):
  60375. * platform/mac/ThemeMac.mm: Added.
  60376. (WebCore::platformTheme):
  60377. * rendering/RenderTheme.cpp:
  60378. (WebCore::RenderTheme::RenderTheme):
  60379. * rendering/RenderTheme.h:
  60380. 2008-10-17 Marco Barisione <marco.barisione@collabora.co.uk>
  60381. Reviewed by Sam Weinig. Landed by Jan Alonzo.
  60382. https://bugs.webkit.org/show_bug.cgi?id=21603
  60383. [GTK] Minor fixes to GOwnPtr
  60384. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  60385. (WebCore::mediaPlayerPrivateErrorCallback):
  60386. 2008-10-17 Timothy Hatcher <timothy@apple.com>
  60387. Recompile the JavaScript functions when removing any listener, so functions that are
  60388. not being debugged can resume normal speed again.
  60389. https://bugs.webkit.org/show_bug.cgi?id=21715
  60390. Reviewed by Geoffrey Garen.
  60391. * bindings/js/JSDOMWindowBase.cpp:
  60392. (WebCore::JSDOMWindowBase::globalExec): Changed an assert into an if check. This assert
  60393. was firing when closing the window and having the recompile fire after. This was an
  60394. overzelious assert now.
  60395. * inspector/JavaScriptDebugServer.cpp:
  60396. (WebCore::JavaScriptDebugServer::didRemoveListener): Start the recompile timer.
  60397. (WebCore::JavaScriptDebugServer::didRemoveLastListener): Removed the recompile timer start.
  60398. 2008-10-17 Timothy Hatcher <timothy@apple.com>
  60399. Fixes a regression where starting a debugging session in
  60400. another Web Inspector window would not show any scripts.
  60401. Also only attach the debugger to only the required Pages.
  60402. https://bugs.webkit.org/show_bug.cgi?id=21708
  60403. Reviewed by Darin Adler.
  60404. * inspector/JavaScriptDebugServer.cpp:
  60405. (WebCore::JavaScriptDebugServer::addListener): Add an assert and
  60406. remove the call to willAddFirstListener(). Add a call to
  60407. didAddListener().
  60408. (WebCore::JavaScriptDebugServer::removeListener): Add an assert
  60409. and call to didRemoveListener().
  60410. (WebCore::JavaScriptDebugServer::pageCreated): Attach the debugger
  60411. if there is a listener interested in the new Page.
  60412. (WebCore::JavaScriptDebugServer::hasListenersInterestedInPage):
  60413. Use hasGlobalListeners() instead of isEmpty().
  60414. (WebCore::JavaScriptDebugServer::sourceParsed): Ditto.
  60415. (WebCore::JavaScriptDebugServer::didAddListener): Added. Attach the
  60416. debugger to the page if non-null, or all pages if page is null.
  60417. (WebCore::JavaScriptDebugServer::didRemoveListener): Added. Detach
  60418. the debugger only if there are no interested listeners.
  60419. (WebCore::JavaScriptDebugServer::didRemoveLastListener): Remove the
  60420. call to Page::setDebuggerForAllPages().
  60421. * inspector/JavaScriptDebugServer.h:
  60422. (WebCore::JavaScriptDebugServer::hasGlobalListeners): Added.
  60423. 2008-10-15 Brett Wilson <brettw@chromium.org>
  60424. Reviewed by Timothy Hatcher.
  60425. Have ImageDocument generate its own filename for the title of images
  60426. without relying on the suggested filename from the network layer, which
  60427. may be nonexistant or not relevant.
  60428. https://bugs.webkit.org/show_bug.cgi?id=21565
  60429. * loader/ImageDocument.cpp:
  60430. (WebCore::ImageTokenizer::finish):
  60431. 2008-10-17 Alexey Proskuryakov <ap@webkit.org>
  60432. Non-Mac build fix.
  60433. * GNUmakefile.am:
  60434. * WebCore.pro:
  60435. * WebCore.vcproj/WebCore.vcproj:
  60436. * WebCoreSources.bkl:
  60437. Added ActiveDOMObject to the build.
  60438. 2008-10-17 Alexey Proskuryakov <ap@webkit.org>
  60439. Reviewed by Sam Weinig.
  60440. https://bugs.webkit.org/show_bug.cgi?id=21642
  60441. Abstract out active object tracking
  60442. * WebCore.xcodeproj/project.pbxproj:
  60443. * bindings/js/JSDOMBinding.cpp:
  60444. (WebCore::markActiveObjectsForDocument):
  60445. * dom/ActiveDOMObject.cpp: Added.
  60446. (WebCore::ActiveDOMObject::ActiveDOMObject):
  60447. (WebCore::ActiveDOMObject::~ActiveDOMObject):
  60448. (WebCore::ActiveDOMObject::contextDestroyed):
  60449. (WebCore::ActiveDOMObject::stop):
  60450. * dom/ActiveDOMObject.h: Added.
  60451. (WebCore::ActiveDOMObject::document):
  60452. (WebCore::ActiveDOMObject::hasPendingActivity):
  60453. (WebCore::ActiveDOMObject::setPendingActivity):
  60454. (WebCore::ActiveDOMObject::unsetPendingActivity):
  60455. * dom/Document.cpp:
  60456. (WebCore::Document::~Document):
  60457. (WebCore::Document::stopActiveDOMObjects):
  60458. (WebCore::Document::createdActiveDOMObject):
  60459. (WebCore::Document::destroyedActiveDOMObject):
  60460. * dom/Document.h:
  60461. (WebCore::Document::activeDOMObjects):
  60462. * dom/MessagePort.cpp:
  60463. (WebCore::MessagePort::contextDestroyed):
  60464. * dom/MessagePort.h:
  60465. * loader/FrameLoader.cpp:
  60466. (WebCore::FrameLoader::stopLoading):
  60467. * xml/XMLHttpRequest.cpp:
  60468. (WebCore::XMLHttpRequest::XMLHttpRequest):
  60469. (WebCore::XMLHttpRequest::~XMLHttpRequest):
  60470. (WebCore::XMLHttpRequest::associatedFrame):
  60471. (WebCore::XMLHttpRequest::responseXML):
  60472. (WebCore::XMLHttpRequest::callReadyStateChangeListener):
  60473. (WebCore::XMLHttpRequest::initSend):
  60474. (WebCore::XMLHttpRequest::send):
  60475. (WebCore::XMLHttpRequest::createRequest):
  60476. (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
  60477. (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
  60478. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
  60479. (WebCore::XMLHttpRequest::loadRequestSynchronously):
  60480. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  60481. (WebCore::XMLHttpRequest::dropProtection):
  60482. (WebCore::XMLHttpRequest::setRequestHeader):
  60483. (WebCore::XMLHttpRequest::processSyncLoadResults):
  60484. (WebCore::XMLHttpRequest::didFinishLoading):
  60485. (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
  60486. (WebCore::XMLHttpRequest::willSendRequest):
  60487. (WebCore::XMLHttpRequest::accessControlCheck):
  60488. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  60489. (WebCore::XMLHttpRequest::stop):
  60490. (WebCore::XMLHttpRequest::contextDestroyed):
  60491. * xml/XMLHttpRequest.h:
  60492. Move activity tracking to a new ActiveDOMObject class.
  60493. 2008-10-16 David Hyatt <hyatt@apple.com>
  60494. Simplify styleForRenderer to avoid confusion. Callers in the SVG filter code thought "forRenderer" meant
  60495. they would be given a style that corresponded to the RenderObject* passed in. This is not what the code
  60496. did though. This patch removes the renderer argument and the Element subclass shadow implementation
  60497. so that confusion like this can't occur again.
  60498. Reviewed by Oliver Hunt
  60499. * dom/Element.cpp:
  60500. * dom/Element.h:
  60501. * dom/Node.cpp:
  60502. (WebCore::Node::createRendererIfNeeded):
  60503. (WebCore::Node::styleForRenderer):
  60504. * dom/Node.h:
  60505. * html/HTMLOptGroupElement.cpp:
  60506. (WebCore::HTMLOptGroupElement::attach):
  60507. * html/HTMLOptionElement.cpp:
  60508. (WebCore::HTMLOptionElement::attach):
  60509. * svg/SVGClipPathElement.cpp:
  60510. (WebCore::SVGClipPathElement::canvasResource):
  60511. * svg/SVGFEDiffuseLightingElement.cpp:
  60512. (WebCore::SVGFEDiffuseLightingElement::build):
  60513. * svg/SVGFEFloodElement.cpp:
  60514. (WebCore::SVGFEFloodElement::build):
  60515. * svg/SVGFESpecularLightingElement.cpp:
  60516. (WebCore::SVGFESpecularLightingElement::build):
  60517. * svg/SVGGradientElement.cpp:
  60518. (WebCore::SVGGradientElement::buildStops):
  60519. * svg/SVGUseElement.cpp:
  60520. (WebCore::SVGUseElement::attachShadowTree):
  60521. 2008-10-16 David Hyatt <hyatt@apple.com>
  60522. https://bugs.webkit.org/attachment.cgi?bugid=21647
  60523. Make RenderStyle inherit from RefCounted so that it works with RefPtr. RenderStyle was being malloced
  60524. out of the RenderArena. Years and years ago (before TCMalloc), the plan was to make RenderStyles and
  60525. all their associated sub-structs use the arena. However only the RenderStyle itself was ever changed
  60526. to use the arena.
  60527. At a later point style sharing was implemented, which made using the arena for styles pretty pointless,
  60528. as the bulk of the styles on a given page are actually shared. Not ever making the sub-structs use the
  60529. arena also limited the usefulness.
  60530. Now that we have RefPtr/PassRefPtr to eliminate manual ref/deref and now that we use TCMalloc for fast
  60531. mallocs, there is no reason to keep RenderStyles in the arena. The benefits of being able to eliminate
  60532. manual ref/deref far outweigh keeping them in the arena.
  60533. Reviewed by Adam Roben
  60534. * css/CSSStyleSelector.cpp:
  60535. (WebCore::CSSStyleSelector::CSSStyleSelector):
  60536. (WebCore::CSSStyleSelector::~CSSStyleSelector):
  60537. (WebCore::CSSStyleSelector::styleForElement):
  60538. (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  60539. (WebCore::CSSStyleSelector::pseudoStyleForElement):
  60540. These methods now return a PassRefPtr. They will null out the m_style variable as they hand it back
  60541. so that it isn't left pointing to the previous style resolve RenderStyle (which is what the old code did).
  60542. (WebCore::CSSStyleSelector::updateFont):
  60543. (WebCore::CSSStyleSelector::checkSelector):
  60544. (WebCore::CSSStyleSelector::applyProperty):
  60545. (WebCore::CSSStyleSelector::mapFillSize):
  60546. (WebCore::CSSStyleSelector::mapFillXPosition):
  60547. (WebCore::CSSStyleSelector::mapFillYPosition):
  60548. * css/CSSStyleSelector.h:
  60549. (WebCore::CSSStyleSelector::style):
  60550. * dom/Document.cpp:
  60551. (WebCore::Document::recalcStyle):
  60552. * dom/Element.cpp:
  60553. (WebCore::Element::styleForRenderer):
  60554. (WebCore::Element::recalcStyle):
  60555. (WebCore::Element::computedStyle):
  60556. * dom/Element.h:
  60557. * dom/ElementRareData.h:
  60558. (WebCore::ElementRareData::ElementRareData):
  60559. (WebCore::ElementRareData::resetComputedStyle):
  60560. * dom/Node.cpp:
  60561. (WebCore::Node::diff):
  60562. (WebCore::Node::createRendererIfNeeded):
  60563. (WebCore::Node::styleForRenderer):
  60564. (WebCore::Node::setRenderStyle):
  60565. * dom/Node.h:
  60566. * html/CanvasRenderingContext2D.cpp:
  60567. (WebCore::CanvasRenderingContext2D::setFont):
  60568. * html/HTMLOptGroupElement.cpp:
  60569. (WebCore::HTMLOptGroupElement::attach):
  60570. (WebCore::HTMLOptGroupElement::detach):
  60571. (WebCore::HTMLOptGroupElement::setRenderStyle):
  60572. (WebCore::HTMLOptGroupElement::nonRendererRenderStyle):
  60573. * html/HTMLOptGroupElement.h:
  60574. * html/HTMLOptionElement.cpp:
  60575. (WebCore::HTMLOptionElement::attach):
  60576. (WebCore::HTMLOptionElement::detach):
  60577. (WebCore::HTMLOptionElement::setRenderStyle):
  60578. (WebCore::HTMLOptionElement::nonRendererRenderStyle):
  60579. * html/HTMLOptionElement.h:
  60580. * page/animation/AnimationBase.h:
  60581. (WebCore::AnimationBase::animate):
  60582. * page/animation/AnimationController.cpp:
  60583. (WebCore::AnimationController::updateAnimations):
  60584. * page/animation/AnimationController.h:
  60585. * page/animation/CompositeAnimation.cpp:
  60586. (WebCore::CompositeAnimationPrivate::updateTransitions):
  60587. (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
  60588. (WebCore::CompositeAnimationPrivate::animate):
  60589. (WebCore::CompositeAnimation::animate):
  60590. * page/animation/CompositeAnimation.h:
  60591. * page/animation/ImplicitAnimation.cpp:
  60592. (WebCore::ImplicitAnimation::ImplicitAnimation):
  60593. (WebCore::ImplicitAnimation::~ImplicitAnimation):
  60594. (WebCore::ImplicitAnimation::animate):
  60595. (WebCore::ImplicitAnimation::reset):
  60596. (WebCore::ImplicitAnimation::isTargetPropertyEqual):
  60597. (WebCore::ImplicitAnimation::blendPropertyValueInStyle):
  60598. * page/animation/ImplicitAnimation.h:
  60599. (WebCore::ImplicitAnimation::create):
  60600. * page/animation/KeyframeAnimation.cpp:
  60601. (WebCore::KeyframeAnimation::KeyframeAnimation):
  60602. (WebCore::KeyframeAnimation::~KeyframeAnimation):
  60603. (WebCore::KeyframeAnimation::animate):
  60604. (WebCore::KeyframeAnimation::validateTransformFunctionList):
  60605. * page/animation/KeyframeAnimation.h:
  60606. (WebCore::KeyframeAnimation::create):
  60607. (WebCore::KeyframeAnimation::unanimatedStyle):
  60608. * rendering/InlineTextBox.cpp:
  60609. (WebCore::InlineTextBox::paint):
  60610. * rendering/MediaControlElements.cpp:
  60611. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
  60612. (WebCore::MediaControlInputElement::MediaControlInputElement):
  60613. * rendering/RenderBlock.cpp:
  60614. (WebCore::RenderBlock::styleDidChange):
  60615. (WebCore::RenderBlock::updateFirstLetter):
  60616. * rendering/RenderContainer.cpp:
  60617. (WebCore::RenderContainer::addChild):
  60618. (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  60619. * rendering/RenderFileUploadControl.cpp:
  60620. (WebCore::RenderFileUploadControl::updateFromElement):
  60621. (WebCore::RenderFileUploadControl::createButtonStyle):
  60622. * rendering/RenderFileUploadControl.h:
  60623. * rendering/RenderFlow.cpp:
  60624. (WebCore::RenderFlow::createAnonymousFlow):
  60625. * rendering/RenderFlow.h:
  60626. * rendering/RenderInline.cpp:
  60627. (WebCore::RenderInline::addChildToFlow):
  60628. * rendering/RenderLayer.cpp:
  60629. (WebCore::RenderLayer::updateScrollCornerStyle):
  60630. (WebCore::RenderLayer::updateResizerStyle):
  60631. (WebCore::RenderLayer::updateReflectionStyle):
  60632. * rendering/RenderListItem.cpp:
  60633. (WebCore::RenderListItem::styleDidChange):
  60634. * rendering/RenderMedia.cpp:
  60635. (WebCore::RenderMedia::createPanel):
  60636. (WebCore::RenderMedia::createTimeDisplay):
  60637. (WebCore::RenderMedia::changeOpacity):
  60638. * rendering/RenderObject.cpp:
  60639. (WebCore::RenderObject::selectionBackgroundColor):
  60640. (WebCore::RenderObject::selectionForegroundColor):
  60641. (WebCore::RenderObject::createAnonymousBlock):
  60642. (WebCore::RenderObject::setAnimatableStyle):
  60643. (WebCore::RenderObject::setStyle):
  60644. (WebCore::RenderObject::setStyleInternal):
  60645. (WebCore::RenderObject::arenaDelete):
  60646. (WebCore::RenderObject::firstLineStyle):
  60647. (WebCore::RenderObject::getPseudoStyle):
  60648. * rendering/RenderObject.h:
  60649. (WebCore::RenderObject::style):
  60650. * rendering/RenderSVGBlock.cpp:
  60651. (WebCore::RenderSVGBlock::setStyle):
  60652. * rendering/RenderSVGBlock.h:
  60653. * rendering/RenderScrollbar.cpp:
  60654. (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
  60655. (WebCore::RenderScrollbar::updateScrollbarPart):
  60656. * rendering/RenderScrollbar.h:
  60657. * rendering/RenderSlider.cpp:
  60658. (WebCore::RenderSlider::styleDidChange):
  60659. (WebCore::RenderSlider::createThumbStyle):
  60660. (WebCore::RenderSlider::updateFromElement):
  60661. * rendering/RenderSlider.h:
  60662. * rendering/RenderTable.cpp:
  60663. (WebCore::RenderTable::addChild):
  60664. * rendering/RenderTableRow.cpp:
  60665. (WebCore::RenderTableRow::addChild):
  60666. * rendering/RenderTableSection.cpp:
  60667. (WebCore::RenderTableSection::addChild):
  60668. * rendering/RenderTextControl.cpp:
  60669. (WebCore::RenderTextControl::styleDidChange):
  60670. (WebCore::RenderTextControl::createInnerBlockStyle):
  60671. (WebCore::RenderTextControl::createInnerTextStyle):
  60672. (WebCore::RenderTextControl::createResultsButtonStyle):
  60673. (WebCore::RenderTextControl::createCancelButtonStyle):
  60674. (WebCore::RenderTextControl::createSubtreeIfNeeded):
  60675. (WebCore::RenderTextControl::updatePlaceholderVisibility):
  60676. * rendering/RenderTextControl.h:
  60677. * rendering/TextControlInnerElements.cpp:
  60678. (WebCore::TextControlInnerElement::attachInnerElement):
  60679. * rendering/TextControlInnerElements.h:
  60680. * rendering/style/KeyframeList.cpp:
  60681. (WebCore::KeyframeList::clear):
  60682. (WebCore::KeyframeList::operator==):
  60683. (WebCore::KeyframeList::insert):
  60684. * rendering/style/KeyframeList.h:
  60685. (WebCore::KeyframeValue::KeyframeValue):
  60686. (WebCore::KeyframeValue::~KeyframeValue):
  60687. (WebCore::KeyframeValue::key):
  60688. (WebCore::KeyframeValue::style):
  60689. * rendering/style/RenderStyle.cpp:
  60690. (WebCore::defaultStyle):
  60691. (WebCore::RenderStyle::create):
  60692. (WebCore::RenderStyle::createDefaultStyle):
  60693. (WebCore::RenderStyle::clone):
  60694. (WebCore::RenderStyle::RenderStyle):
  60695. (WebCore::RenderStyle::getCachedPseudoStyle):
  60696. (WebCore::RenderStyle::addCachedPseudoStyle):
  60697. * rendering/style/RenderStyle.h:
  60698. (WebCore::):
  60699. (WebCore::InheritedFlags::operator!=):
  60700. * svg/SVGClipPathElement.cpp:
  60701. (WebCore::SVGClipPathElement::canvasResource):
  60702. * svg/SVGGradientElement.cpp:
  60703. (WebCore::SVGGradientElement::buildStops):
  60704. * svg/SVGStyledElement.cpp:
  60705. (WebCore::SVGStyledElement::resolveStyle):
  60706. * svg/SVGStyledElement.h:
  60707. * svg/SVGUseElement.cpp:
  60708. (WebCore::SVGUseElement::recalcStyle):
  60709. (WebCore::SVGUseElement::attachShadowTree):
  60710. 2008-10-16 Kenneth Russell <kenneth.russell@sun.com>
  60711. Reviewed and landed by Anders Carlsson.
  60712. https://bugs.webkit.org/show_bug.cgi?id=21587
  60713. NPN_PluginThreadAsyncCall does not work properly
  60714. * plugins/PluginMainThreadScheduler.cpp:
  60715. (WebCore::PluginMainThreadScheduler::dispatchCalls):
  60716. Make sure to set m_callPending to false once the queue has been cleared.
  60717. 2008-10-15 Alexey Proskuryakov <ap@webkit.org>
  60718. Reviewed by Darin Adler.
  60719. https://bugs.webkit.org/show_bug.cgi?id=21609
  60720. Make MessagePorts protect their peers across heaps
  60721. * dom/MessagePort.cpp:
  60722. (WebCore::MessagePort::MessagePort):
  60723. * dom/MessagePort.h:
  60724. (WebCore::MessagePort::setJSWrapperIsKnownToBeInaccessible):
  60725. (WebCore::MessagePort::jsWrapperIsKnownToBeInaccessible):
  60726. Track objects whose JS wrappers are no longer reachable in MessagePort. Unfortunately, this
  60727. means that the implementation object knows about JS bindings - but it is not possible to
  60728. access JS wrappers from another heap/thread.
  60729. * bindings/js/JSDOMBinding.cpp:
  60730. (WebCore::markCrossHeapDependentObjectsForDocument):
  60731. * bindings/js/JSDOMBinding.h:
  60732. * bindings/js/JSDOMWindowBase.cpp:
  60733. (WebCore::JSDOMWindowBase::markCrossHeapDependentObjects):
  60734. * bindings/js/JSDOMWindowBase.h:
  60735. Implement cross-heap dependency tracking for entangled MessagePorts. If a wrapper object
  60736. hasn't been marked normally, it is marked as inaccessible. It is then marked manually,
  60737. as long as its entangled port is accessible itself.
  60738. 2008-10-15 Jon Honeycutt <jhoneycutt@apple.com>
  60739. Remove unneeded check of whether a Page defers loading before running it
  60740. in a modal dialog.
  60741. No test possible.
  60742. Reviewed by Tim Hatcher.
  60743. * page/Chrome.cpp:
  60744. 2008-10-15 Geoffrey Garen <ggaren@apple.com>
  60745. Reviewed by Cameron Zwarich.
  60746. Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
  60747. Start the debugger without reloading the inspected page
  60748. * WebCore.base.exp: New symbols.
  60749. * ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
  60750. * ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
  60751. * WebCore.xcodeproj/project.pbxproj: New forwarding headers.
  60752. * inspector/InspectorController.cpp:
  60753. (WebCore::InspectorController::setWindowVisible):
  60754. (WebCore::InspectorController::windowScriptObjectAvailable):
  60755. (WebCore::InspectorController::startDebugging):
  60756. * inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage
  60757. to startDebugging, and changed its behavior to match.
  60758. * inspector/JavaScriptDebugListener.h:
  60759. * inspector/JavaScriptDebugServer.cpp:
  60760. (WebCore::JavaScriptDebugServer::JavaScriptDebugServer):
  60761. (WebCore::JavaScriptDebugServer::addListener):
  60762. (WebCore::JavaScriptDebugServer::removeListener):
  60763. (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
  60764. (WebCore::JavaScriptDebugServer::willAddFirstListener):
  60765. (WebCore::JavaScriptDebugServer::didRemoveLastListener):
  60766. * inspector/JavaScriptDebugServer.h: Refactored the
  60767. JavaScriptDebugServer to centralize handling of adding the first listener
  60768. and removing the last. Then, added a feature to recompile all JS functions
  60769. in these cases. This allows us to dynamically add and remove hooks like
  60770. the debugger hooks without reloading the page.
  60771. * inspector/front-end/ScriptsPanel.js:
  60772. * English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage =>
  60773. startDebugging rename. Removed all UI that claimed that starting the
  60774. debugger would reload the page.
  60775. 2008-10-15 Adele Peterson <adele@apple.com>
  60776. Attempt to fix the Tiger build.
  60777. * platform/network/mac/ResourceHandleMac.mm:
  60778. 2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
  60779. Build fix attempt.
  60780. Try to fix static/non-static declaration of g_string_append_uri_escape
  60781. by renaming that string. Another look needs to be taken.
  60782. * platform/gtk/guriescape.c:
  60783. (_webcore_g_string_append_uri_escaped):
  60784. (_webcore_g_uri_escape_string):
  60785. 2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
  60786. Build fix.
  60787. m_animatingImageType is gone.
  60788. * platform/graphics/cairo/ImageCairo.cpp:
  60789. (WebCore::BitmapImage::BitmapImage):
  60790. 2008-10-15 Jeff Cook <cookiecaper@gmail.com>
  60791. Reviewed by Holger Freyther.
  60792. Stop SIGSEGV when leaving a page with a Flash object by reordering
  60793. window destruction and plugin stop.
  60794. See https://bugs.webkit.org/show_bug.cgi?id=20779
  60795. * plugins/gtk/PluginViewGtk.cpp:
  60796. (WebCore::PluginView::stop):
  60797. 2008-10-15 Adele Peterson <adele@apple.com>
  60798. Reviewed by Sam Weinig.
  60799. Implement didSendBodyData delegate method, and use older code path when that delegate doesn't exist.
  60800. * platform/network/ResourceHandle.h:
  60801. * platform/network/mac/FormDataStreamMac.mm: (WebCore::formRead):
  60802. * platform/network/mac/ResourceHandleMac.mm:
  60803. (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
  60804. (WebCore::ResourceHandle::start):
  60805. (WebCore::ResourceHandle::cancel):
  60806. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
  60807. (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
  60808. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
  60809. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
  60810. 2008-10-15 Peter Kasting <pkasting@google.com>
  60811. Reviewed by David Hyatt.
  60812. Qt build bustage fix.
  60813. * platform/graphics/qt/StillImageQt.h:
  60814. (WebCore::StillImage::destroyDecodedData):
  60815. 2008-10-15 David Hyatt <hyatt@apple.com>
  60816. Make sure scrollbar styles get deleted if they aren't assigned to a renderer.
  60817. Reviewed by Mark Rowe
  60818. * rendering/RenderScrollbar.cpp:
  60819. (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
  60820. (WebCore::RenderScrollbar::updateScrollbarPart):
  60821. 2008-10-15 Peter Kasting <pkasting@google.com>
  60822. Reviewed by David Hyatt.
  60823. https://bugs.webkit.org/show_bug.cgi?id=19663 (Second attempt)
  60824. Account for paint and timer lag when animating images. Also pretend
  60825. that images whose animations were paused (by becoming invisible)
  60826. continued to animate, by "catching up" to the correct frame when they're
  60827. shown again.
  60828. * platform/graphics/BitmapImage.cpp:
  60829. (WebCore::BitmapImage::BitmapImage):
  60830. (WebCore::BitmapImage::destroyDecodedData):
  60831. (WebCore::BitmapImage::cacheFrame):
  60832. (WebCore::BitmapImage::frameIsCompleteAtIndex):
  60833. (WebCore::BitmapImage::frameDurationAtIndex):
  60834. (WebCore::BitmapImage::frameHasAlphaAtIndex):
  60835. (WebCore::BitmapImage::repetitionCount):
  60836. (WebCore::BitmapImage::shouldAnimate):
  60837. (WebCore::BitmapImage::startAnimation):
  60838. (WebCore::BitmapImage::resetAnimation):
  60839. (WebCore::BitmapImage::advanceAnimation):
  60840. (WebCore::BitmapImage::internalAdvanceAnimation):
  60841. (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
  60842. * platform/graphics/BitmapImage.h:
  60843. (WebCore::FrameData::FrameData):
  60844. (WebCore::BitmapImage::):
  60845. * platform/graphics/GeneratedImage.h:
  60846. (WebCore::GeneratedImage::destroyDecodedData):
  60847. * platform/graphics/Image.h:
  60848. * platform/graphics/cairo/ImageCairo.cpp:
  60849. (WebCore::FrameData::clear):
  60850. (WebCore::BitmapImage::BitmapImage):
  60851. (WebCore::BitmapImage::draw):
  60852. * platform/graphics/cg/ImageCG.cpp:
  60853. (WebCore::FrameData::clear):
  60854. (WebCore::BitmapImage::BitmapImage):
  60855. (WebCore::BitmapImage::draw):
  60856. * platform/graphics/cg/PDFDocumentImage.h:
  60857. (WebCore::PDFDocumentImage::destroyDecodedData):
  60858. * platform/graphics/qt/ImageQt.cpp:
  60859. (WebCore::FrameData::clear):
  60860. (WebCore::BitmapImage::draw):
  60861. * platform/graphics/wx/ImageWx.cpp:
  60862. (WebCore::FrameData::clear):
  60863. (WebCore::BitmapImage::draw):
  60864. * svg/graphics/SVGImage.h:
  60865. (WebCore::SVGImage::destroyDecodedData):
  60866. 2008-10-14 Maxime Britto <britto@apple.com>
  60867. Reviewed by Darin Adler, tweaked and landed by Beth.
  60868. * WebCore.base.exp: Exposes two functions to be able to create a
  60869. selection from a point on the screen. Also exposes the new
  60870. TextIterator::currentNode function.
  60871. * WebCore/editing/TextIterator.cpp:
  60872. (TextIterator::currentNode) : New function that returns the current
  60873. text node or NULL if there is no text node.
  60874. 2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
  60875. Reviewed by Holger Freyther.
  60876. http://bugs.webkit.org/show_bug.cgi?id=21211
  60877. [CURL] Upload doesn't work because cancel is called
  60878. FormDataStream::read returns 0 when retrieving data from the form
  60879. fails, but also when there is no more data to send. This means that
  60880. ResourceHandleManager::cancel is always called even when the data was
  60881. successfully sent.
  60882. Check if there are more elements in the form before calling
  60883. FormDataStream::read.
  60884. * platform/network/curl/FormDataStreamCurl.cpp:
  60885. (WebCore::FormDataStream::hasMoreElements):
  60886. * platform/network/curl/FormDataStreamCurl.h:
  60887. * platform/network/curl/ResourceHandleManager.cpp:
  60888. (WebCore::readCallback):
  60889. 2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
  60890. Reviewed by Holger Freyther.
  60891. http://bugs.webkit.org/show_bug.cgi?id=20664
  60892. [GTK] File names are not always encodable in UTF-8
  60893. On Linux file names are just raw data and cannot always be directly
  60894. encoded in UTF-8 or in any other encodings, so we escape them before
  60895. storing the file name in a String and unescape them before passing
  60896. them to native functions handling files.
  60897. * GNUmakefile.am:
  60898. * platform/FileSystem.h:
  60899. * platform/gtk/FileChooserGtk.cpp:
  60900. (WebCore::stringByAdoptingFileSystemRepresentation):
  60901. (WebCore::FileChooser::basenameForWidth):
  60902. * platform/gtk/FileSystemGtk.cpp:
  60903. (WebCore::filenameToString):
  60904. (WebCore::filenameFromString):
  60905. (WebCore::filenameForDisplay):
  60906. (WebCore::fileExists):
  60907. (WebCore::deleteFile):
  60908. (WebCore::deleteEmptyDirectory):
  60909. (WebCore::getFileSize):
  60910. (WebCore::getFileModificationTime):
  60911. (WebCore::makeAllDirectories):
  60912. (WebCore::homeDirectoryPath):
  60913. (WebCore::pathGetFileName):
  60914. (WebCore::listDirectory):
  60915. * platform/gtk/KURLGtk.cpp:
  60916. (WebCore::KURL::fileSystemPath):
  60917. * platform/gtk/SharedBufferGtk.cpp:
  60918. (WebCore::SharedBuffer::createWithContentsOfFile):
  60919. * platform/gtk/guriescape.c: Added.
  60920. (is_valid):
  60921. (gunichar_ok):
  60922. (g_string_append_uri_escaped):
  60923. (_webcore_g_uri_escape_string):
  60924. * platform/gtk/guriescape.h: Added.
  60925. 2008-10-15 Dirk Schulze <vbs85@gmx.de>
  60926. Reviewed by Eric Seidel.
  60927. - part of https://bugs.webkit.org/show_bug.cgi?id=20543
  60928. Moved gradient spread method out of SVG into the GraphicsContext.
  60929. * platform/graphics/GraphicsContext.cpp:
  60930. (WebCore::GraphicsContext::spreadMethod):
  60931. (WebCore::GraphicsContext::setSpreadMethod):
  60932. * platform/graphics/GraphicsContext.h:
  60933. (WebCore::):
  60934. * platform/graphics/GraphicsContextPrivate.h:
  60935. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  60936. (WebCore::applySpreadMethod):
  60937. (WebCore::GraphicsContext::fillPath):
  60938. (WebCore::GraphicsContext::strokePath):
  60939. * platform/graphics/qt/GraphicsContextQt.cpp:
  60940. (WebCore::applySpreadMethod):
  60941. (WebCore::GraphicsContext::fillPath):
  60942. (WebCore::GraphicsContext::strokePath):
  60943. * svg/GradientAttributes.h:
  60944. (WebCore::GradientAttributes::GradientAttributes):
  60945. (WebCore::GradientAttributes::spreadMethod):
  60946. (WebCore::GradientAttributes::setSpreadMethod):
  60947. * svg/SVGGradientElement.cpp:
  60948. (WebCore::SVGGradientElement::parseMappedAttribute):
  60949. * svg/SVGGradientElement.h:
  60950. * svg/SVGLinearGradientElement.cpp:
  60951. (WebCore::SVGLinearGradientElement::collectGradientProperties):
  60952. * svg/SVGRadialGradientElement.cpp:
  60953. (WebCore::SVGRadialGradientElement::collectGradientProperties):
  60954. * svg/graphics/SVGPaintServerGradient.cpp:
  60955. (WebCore::operator<<):
  60956. (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
  60957. (WebCore::SVGPaintServerGradient::spreadMethod):
  60958. (WebCore::SVGPaintServerGradient::setGradientSpreadMethod):
  60959. (WebCore::SVGPaintServerGradient::externalRepresentation):
  60960. * svg/graphics/SVGPaintServerGradient.h:
  60961. * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
  60962. (WebCore::SVGPaintServerGradient::setup):
  60963. * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
  60964. (WebCore::SVGPaintServerGradient::setup):
  60965. 2008-10-09 Darin Fisher <darin@chromium.org>
  60966. Reviewed by Sam Weinig.
  60967. Make pan scrolling a platform configurable option
  60968. https://bugs.webkit.org/show_bug.cgi?id=21515
  60969. * page/EventHandler.cpp:
  60970. (WebCore::EventHandler::handleAutoscroll):
  60971. (WebCore::EventHandler::autoscrollTimerFired):
  60972. (WebCore::EventHandler::stopAutoscrollTimer):
  60973. (WebCore::EventHandler::handleMousePressEvent):
  60974. (WebCore::EventHandler::keyEvent):
  60975. 2008-10-10 Darin Fisher <darin@chromium.org>
  60976. Reviewed by Darin Adler.
  60977. Add some PLATFORM(CHROMIUM) ifdefs to WebCore
  60978. https://bugs.webkit.org/show_bug.cgi?id=21511
  60979. * loader/FTPDirectoryDocument.cpp:
  60980. * loader/FTPDirectoryParser.cpp:
  60981. * loader/FrameLoader.cpp:
  60982. (WebCore::FrameLoader::finishedLoadingDocument):
  60983. * platform/ContextMenuItem.h:
  60984. * platform/Cursor.h:
  60985. * platform/DragData.h:
  60986. * platform/DragImage.h:
  60987. * platform/Pasteboard.h:
  60988. * platform/PlatformKeyboardEvent.h:
  60989. (WebCore::PlatformKeyboardEvent::isSystemKey):
  60990. * platform/PlatformMenuDescription.h:
  60991. * platform/PlatformMouseEvent.h:
  60992. * platform/PlatformWheelEvent.h:
  60993. * platform/PopupMenu.h:
  60994. * platform/ScrollView.h:
  60995. * platform/Widget.h:
  60996. * platform/network/NetworkStateNotifier.h:
  60997. 2008-10-14 Chris Marrin <cmarrin@apple.com>
  60998. Reviewed by Darin Adler.
  60999. Fixed https://bugs.webkit.org/show_bug.cgi?id=21490
  61000. Optimize keyframe style sheet changes by avoiding styleSheetChanged()
  61001. Test: css3/change-keyframes.html
  61002. * css/WebKitCSSKeyframesRule.cpp:
  61003. (WebCore::WebKitCSSKeyframesRule::append):
  61004. (WebCore::WebKitCSSKeyframesRule::deleteRule):
  61005. 2008-10-14 David Hyatt <hyatt@apple.com>
  61006. https://bugs.webkit.org/show_bug.cgi?id=21595
  61007. Clean up background and overflow propagation from the body to the viewport. Make it match the
  61008. latest CSS2.1 spec thinking.
  61009. Reviewed by Adam Roben
  61010. Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
  61011. (available at http://simon.html5.org/test/css/magic-body/).
  61012. * dom/Document.cpp:
  61013. (WebCore::Document::body):
  61014. * page/FrameView.cpp:
  61015. (WebCore::FrameView::layout):
  61016. * rendering/RenderBox.cpp:
  61017. (WebCore::RenderBox::styleDidChange):
  61018. (WebCore::RenderBox::paintRootBoxDecorations):
  61019. (WebCore::RenderBox::paintBoxDecorations):
  61020. (WebCore::RenderBox::repaintLayerRectsForImage):
  61021. 2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>
  61022. Reviewed and landed by Sam Weinig.
  61023. Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
  61024. remove NSResolver code, leaving only checking for selectors that need
  61025. NS resolution and throwing a coresponding error.
  61026. * WebCore.pro:
  61027. * WebCore.vcproj/WebCore.vcproj:
  61028. * WebCore.xcodeproj/project.pbxproj:
  61029. * WebCoreSources.bkl:
  61030. * bindings/js/JSDocumentCustom.cpp:
  61031. * bindings/js/JSDocumentFragmentCustom.cpp:
  61032. * bindings/js/JSElementCustom.cpp:
  61033. * bindings/js/JSNSResolver.cpp: Removed.
  61034. * bindings/js/JSNSResolver.h: Removed.
  61035. * dom/Document.idl:
  61036. * dom/DocumentFragment.idl:
  61037. * dom/Element.idl:
  61038. * dom/NSResolver.h: Removed.
  61039. * dom/NSResolver.idl: Removed.
  61040. * dom/Node.h:
  61041. * dom/Node.cpp:
  61042. (WebCore::forEachTagSelector):
  61043. (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
  61044. (WebCore::selectorNeedsNamespaceResolution):
  61045. (WebCore::Node::querySelector):
  61046. (WebCore::Node::querySelectorAll):
  61047. 2008-10-14 Darin Adler <darin@apple.com>
  61048. Reviewed by Sam Weinig (all but the FormDataListItem rename).
  61049. - https://bugs.webkit.org/show_bug.cgi?id=21593
  61050. Bug 21593: add multiple-file support to HTMLFormElement
  61051. * html/FormDataList.cpp: Removed appendFile since it's now inline.
  61052. Also took incorrect old copyrights off of this file that are left
  61053. over from when it was split.
  61054. * html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and
  61055. made it a member of FormDataList. Changed it to hold a File object
  61056. instead of a path. And made its data members private. Changed
  61057. FormDataList::appendFile accordingly.
  61058. * html/HTMLFormElement.cpp:
  61059. (WebCore::HTMLFormElement::formData): Updated for above changes.
  61060. Removed the code that special-cases HTMLInputElement, because now
  61061. the FormDataListItem has everything we need. And if there are
  61062. multiple files, we'll get multiple list items for them.
  61063. * html/HTMLInputElement.cpp:
  61064. (WebCore::HTMLInputElement::appendFormData): Changed the code for
  61065. <input type=file> to use File objects instead of path strings and
  61066. also to append multiple files if the file list has them.
  61067. 2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
  61068. Reviewed by Simon.
  61069. Fix QtWebKit scrollbar painting errors
  61070. * platform/qt/ScrollbarThemeQt.cpp:
  61071. (WebCore::ScrollbarThemeQt::paint):
  61072. (WebCore::ScrollbarThemeQt::paintScrollCorner):
  61073. 2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
  61074. Reviewed by Simon.
  61075. Fix scrollbar arrows for horizontal scrollbars
  61076. * platform/qt/ScrollbarThemeQt.cpp:
  61077. (WebCore::styleOptionSlider):
  61078. 2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
  61079. Reviewed by Simon.
  61080. Use style-painter to draw scrollbars in ScrollbarThemeQt
  61081. This has the benefit of setting up the painter properly without
  61082. antialiasing and saving and restoring the brush. It also ensures
  61083. that we use the style of the QWebView over the QApplication style
  61084. if possible.
  61085. * platform/qt/RenderThemeQt.cpp:
  61086. (WebCore::StylePainter::StylePainter):
  61087. (WebCore::StylePainter::init):
  61088. * platform/qt/RenderThemeQt.h:
  61089. * platform/qt/ScrollbarThemeQt.cpp:
  61090. (WebCore::ScrollbarThemeQt::paint):
  61091. 2008-10-13 David Hyatt <hyatt@apple.com>
  61092. Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
  61093. for how to add support for the rest.
  61094. Reviewed by Oliver Hunt
  61095. * page/animation/AnimationBase.cpp:
  61096. (WebCore::ensurePropertyMap):
  61097. * rendering/style/RenderStyle.h:
  61098. (WebCore::RenderStyle::fillOpacity):
  61099. (WebCore::RenderStyle::setFillOpacity):
  61100. (WebCore::RenderStyle::strokeOpacity):
  61101. (WebCore::RenderStyle::setStrokeOpacity):
  61102. (WebCore::RenderStyle::floodOpacity):
  61103. (WebCore::RenderStyle::setFloodOpacity):
  61104. 2008-10-13 David Hyatt <hyatt@apple.com>
  61105. <rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.
  61106. Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
  61107. implements paintTrackBackground so that when the thumb is not present the track still paints.
  61108. Reviewed by Oliver Hunt
  61109. * platform/ScrollbarThemeComposite.cpp:
  61110. (WebCore::ScrollbarThemeComposite::paint):
  61111. * platform/win/ScrollbarThemeWin.cpp:
  61112. (WebCore::ScrollbarThemeWin::paintTrackBackground):
  61113. * platform/win/ScrollbarThemeWin.h:
  61114. 2008-10-13 David Hyatt <hyatt@apple.com>
  61115. Fix over-invalidation of native scrollbars.
  61116. Reviewed by Oliver Hunt
  61117. * platform/Scrollbar.h:
  61118. (WebCore::Scrollbar::styleChanged):
  61119. * platform/mac/ScrollbarThemeMac.mm:
  61120. (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
  61121. * rendering/RenderScrollbar.cpp:
  61122. (WebCore::RenderScrollbar::styleChanged):
  61123. 2008-10-13 Alp Toker <alp@nuanti.com>
  61124. Fix autotools dist build target by listing recently added header
  61125. files only. Not reviewed.
  61126. * GNUmakefile.am:
  61127. 2008-10-13 Mark Rowe <mrowe@apple.com>
  61128. Reviewed by Brady Eidson.
  61129. Don't run a SQLite query on every iteration of the sync thread when the query
  61130. will touch a large portion of the icon database while performing no useful work.
  61131. * loader/icon/IconDatabase.cpp:
  61132. (WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
  61133. we modified the database.
  61134. (WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
  61135. unless we've been asked to prune any dangling pageURLs that we find.
  61136. 2008-10-13 Maciej Stachowiak <mjs@apple.com>
  61137. Rubber stamped by Mark Rowe.
  61138. - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  61139. * Configurations/DebugRelease.xcconfig:
  61140. 2008-10-13 David Hyatt <hyatt@apple.com>
  61141. Make dropdown lists on Windows work with CSS custom scrollbars.
  61142. Reviewed by Adele
  61143. * platform/PopupMenu.h:
  61144. (WebCore::PopupMenu::scrollbarCornerPresent):
  61145. * platform/PopupMenuClient.h:
  61146. * platform/win/PopupMenuWin.cpp:
  61147. (WebCore::PopupMenu::show):
  61148. * rendering/RenderMenuList.cpp:
  61149. (WebCore::RenderMenuList::createScrollbar):
  61150. * rendering/RenderMenuList.h:
  61151. * rendering/RenderTextControl.cpp:
  61152. (WebCore::RenderTextControl::createScrollbar):
  61153. * rendering/RenderTextControl.h:
  61154. 2008-10-13 Chris Fleizach <cfleizach@apple.com>
  61155. Reviewed by Beth Dakin.
  61156. <rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements
  61157. Links from image maps were not being included in the web area's AXLinkUIElements attribute.
  61158. The position of image map links was being reported incorrectly and the parent-chain
  61159. hierarchy for image map links was incorrect because image map links did not have a reference
  61160. to their parent image.
  61161. Test: accessibility/document-links.html
  61162. * page/AccessibilityImageMapLink.cpp:
  61163. (WebCore::AccessibilityImageMapLink::parentObject):
  61164. (WebCore::AccessibilityImageMapLink::actionElement):
  61165. (WebCore::AccessibilityImageMapLink::elementRect):
  61166. * page/AccessibilityImageMapLink.h:
  61167. (WebCore::AccessibilityImageMapLink::setHTMLMapElement):
  61168. (WebCore::AccessibilityImageMapLink::setParent):
  61169. * page/AccessibilityObject.cpp:
  61170. * page/AccessibilityObject.h:
  61171. * page/AccessibilityRenderObject.cpp:
  61172. (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
  61173. (WebCore::AccessibilityRenderObject::getDocumentLinks):
  61174. (WebCore::AccessibilityRenderObject::addChildren):
  61175. * page/AccessibilityRenderObject.h:
  61176. * page/mac/AccessibilityObjectWrapper.mm:
  61177. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  61178. 2008-10-13 David Hyatt <hyatt@apple.com>
  61179. Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
  61180. the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
  61181. idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
  61182. Reviewed by Tim Hatcher
  61183. Added scrollbars/listbox-scrollbar-combinations.html
  61184. * rendering/RenderListBox.cpp:
  61185. (WebCore::RenderListBox::~RenderListBox):
  61186. (WebCore::RenderListBox::updateFromElement):
  61187. (WebCore::RenderListBox::createScrollbar):
  61188. (WebCore::RenderListBox::destroyScrollbar):
  61189. (WebCore::RenderListBox::setHasVerticalScrollbar):
  61190. * rendering/RenderListBox.h:
  61191. 2008-10-13 David Hyatt <hyatt@apple.com>
  61192. In order to always match the :corner-present pseudo-class properly, delay initial updating of
  61193. scrollbar styles until the layer has the scrollbars in its member variables.
  61194. Reviewed by Tim Hatcher
  61195. * rendering/RenderLayer.cpp:
  61196. (WebCore::RenderLayer::setHasHorizontalScrollbar):
  61197. (WebCore::RenderLayer::setHasVerticalScrollbar):
  61198. * rendering/RenderScrollbar.cpp:
  61199. (WebCore::RenderScrollbar::RenderScrollbar):
  61200. 2008-10-13 Sam Weinig <sam@webkit.org>
  61201. Reviewed by Dan Bernstein.
  61202. Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
  61203. 5 false positive StructureID leaks
  61204. In WebCore, we intentionally leak the common JSGlobalData which in turn
  61205. leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
  61206. ignore the StructureIDs leaked within.
  61207. * bindings/js/JSDOMWindowBase.cpp:
  61208. (WebCore::JSDOMWindowBase::commonJSGlobalData):
  61209. 2008-10-13 David Hyatt <hyatt@apple.com>
  61210. Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
  61211. artwork based on whether there is a scrollbar corner present.
  61212. Reviewed by Tim Hatcher
  61213. * css/CSSSelector.cpp:
  61214. (WebCore::CSSSelector::extractPseudoType):
  61215. * css/CSSSelector.h:
  61216. (WebCore::CSSSelector::):
  61217. * css/CSSStyleSelector.cpp:
  61218. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61219. * platform/ScrollView.cpp:
  61220. (WebCore::ScrollView::scrollbarCornerPresent):
  61221. * platform/ScrollView.h:
  61222. * platform/ScrollbarClient.h:
  61223. * rendering/RenderLayer.cpp:
  61224. (WebCore::cornerRect):
  61225. (WebCore::scrollCornerRect):
  61226. (WebCore::resizerCornerRect):
  61227. (WebCore::RenderLayer::scrollbarCornerPresent):
  61228. (WebCore::RenderLayer::setHasHorizontalScrollbar):
  61229. (WebCore::RenderLayer::setHasVerticalScrollbar):
  61230. * rendering/RenderLayer.h:
  61231. (WebCore::RenderLayer::horizontalScrollbar):
  61232. (WebCore::RenderLayer::verticalScrollbar):
  61233. * rendering/RenderListBox.h:
  61234. (WebCore::RenderListBox::scrollbarCornerPresent):
  61235. 2008-10-13 David Hyatt <hyatt@apple.com>
  61236. Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
  61237. test case for all this can land).
  61238. Reviewed by Tim Hatcher
  61239. * css/CSSStyleSelector.cpp:
  61240. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  61241. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  61242. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61243. * rendering/RenderLayer.cpp:
  61244. (WebCore::RenderLayer::paintOverflowControls):
  61245. (WebCore::RenderLayer::paintScrollCorner):
  61246. (WebCore::RenderLayer::paintResizer):
  61247. (WebCore::RenderLayer::styleChanged):
  61248. (WebCore::RenderLayer::updateScrollCornerStyle):
  61249. (WebCore::RenderLayer::updateResizerStyle):
  61250. * rendering/RenderLayer.h:
  61251. * rendering/RenderScrollbar.cpp:
  61252. (WebCore::RenderScrollbar::paint):
  61253. * rendering/RenderScrollbarPart.cpp:
  61254. (WebCore::RenderScrollbarPart::paintIntoRect):
  61255. 2008-10-13 David Hyatt <hyatt@apple.com>
  61256. Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
  61257. and invalidate properly as images load, etc.
  61258. Reviewed by Tim Hatcher
  61259. * rendering/RenderLayer.cpp:
  61260. (WebCore::cornerRect):
  61261. (WebCore::scrollCornerRect):
  61262. (WebCore::resizerCornerRect):
  61263. (WebCore::RenderLayer::positionOverflowControls):
  61264. (WebCore::RenderLayer::paintOverflowControls):
  61265. (WebCore::RenderLayer::paintScrollCorner):
  61266. (WebCore::RenderLayer::paintResizer):
  61267. (WebCore::RenderLayer::isPointInResizeControl):
  61268. (WebCore::RenderLayer::hitTestOverflowControls):
  61269. (WebCore::RenderLayer::styleChanged):
  61270. * rendering/RenderLayer.h:
  61271. * rendering/RenderObject.h:
  61272. (WebCore::RenderObject::setRect):
  61273. * rendering/RenderScrollbarPart.cpp:
  61274. (WebCore::RenderScrollbarPart::styleDidChange):
  61275. (WebCore::RenderScrollbarPart::imageChanged):
  61276. 2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
  61277. Reviewed by Darin Adler. Landed by Jan Alonzo.
  61278. WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
  61279. http://bugs.webkit.org/show_bug.cgi?id=20483
  61280. Start the conversion to use GOwnPtr and fix a memory leak.
  61281. * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  61282. (WebCore::mediaPlayerPrivateErrorCallback):
  61283. 2008-10-12 Jon Honeycutt <jhoneycutt@apple.com>
  61284. Windows build fix.
  61285. * loader/TextResourceDecoder.cpp:
  61286. 2008-10-12 Darin Fisher <darin@chromium.org>
  61287. Reviewed by Darin Adler.
  61288. - fix https://bugs.webkit.org/show_bug.cgi?id=21229
  61289. Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)
  61290. * platform/network/NetworkStateNotifier.h: Add the #include.
  61291. 2008-10-12 Darin Adler <darin@apple.com>
  61292. Based on work by Holger Freyther.
  61293. - part of https://bugs.webkit.org/show_bug.cgi?id=20953
  61294. Split WidthIterator into its own source file.
  61295. * GNUmakefile.am: Added new source files.
  61296. * WebCore.vcproj/WebCore.vcproj: Ditto.
  61297. * WebCore.xcodeproj/project.pbxproj: Ditto.
  61298. * WebCoreSources.bkl: Ditto.
  61299. * platform/graphics/Font.cpp: Use WidthIterator from its new place.
  61300. * platform/graphics/WidthIterator.cpp: Added.
  61301. * platform/graphics/WidthIterator.h: Added.
  61302. 2008-10-12 Tony Chang <tony@chromium.org>
  61303. Reviewed by Sam Weinig.
  61304. - https://bugs.webkit.org/show_bug.cgi?id=21480
  61305. Remove duplicate definitions of MimeClassInfo and PluginInfo.
  61306. * plugins/PluginInfoStore.cpp: Added an include.
  61307. * plugins/PluginInfoStore.h: Removed struct declarations.
  61308. 2008-10-12 Darin Adler <darin@apple.com>
  61309. Reviewed by Dan Bernstein.
  61310. - https://bugs.webkit.org/show_bug.cgi?id=21563
  61311. Bug 21563: platform Gradient class should not use the CSS parser
  61312. * platform/graphics/Gradient.cpp: Removed the overload of addColorStop
  61313. that accepts a CSS color string. That's handled in the DOM now, not here.
  61314. (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own
  61315. copy of it here.
  61316. * platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
  61317. 2008-10-12 Glenn Wilson <gwilson@google.com>
  61318. Reviewed by Darin Adler.
  61319. - https://bugs.webkit.org/show_bug.cgi?id=20461
  61320. Added feature to allow multi-line inputs into text fields.
  61321. HTMLInputElement would cut the set text at the first 'system' character,
  61322. so it would truncate at the first carriage return or newline.
  61323. This fix modifies that behavior to truncate at any non-space system character
  61324. but changes \r, \n, and \r\n to a single space.
  61325. Tests: editing/pasteboard/paste-multiline-text-input.html
  61326. * html/HTMLInputElement.cpp:
  61327. (WebCore::HTMLInputElement::constrainValue):
  61328. 2008-10-12 Dirk Schulze <vbs85@gmx.de>
  61329. Reviewed by Eric Seidel.
  61330. - https://bugs.webkit.org/show_bug.cgi?id=20435
  61331. Added exception codes to canvas gradients to match current specification.
  61332. Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html
  61333. fast/canvas/linearGradient-infinite-values.html
  61334. fast/canvas/radialGradient-infinite-values.html
  61335. * html/CanvasGradient.cpp:
  61336. (WebCore::CanvasGradient::addColorStop):
  61337. * html/CanvasGradient.h:
  61338. * html/CanvasGradient.idl:
  61339. * html/CanvasRenderingContext2D.cpp:
  61340. (WebCore::CanvasRenderingContext2D::createLinearGradient):
  61341. (WebCore::CanvasRenderingContext2D::createRadialGradient):
  61342. * html/CanvasRenderingContext2D.h:
  61343. * html/CanvasRenderingContext2D.idl:
  61344. 2008-10-12 Eric Roman <eroman@chromium.org>
  61345. - https://bugs.webkit.org/show_bug.cgi?id=20246
  61346. Implement RenderThemeWin::systemColor() to match Windows colors.
  61347. Reviewed by David Hyatt.
  61348. * rendering/RenderThemeWin.cpp:
  61349. (WebCore::cssValueIdToSysColorIndex):
  61350. (WebCore::RenderThemeWin::systemColor):
  61351. * rendering/RenderThemeWin.h:
  61352. 2008-10-12 Aaron Bockover <abockover@novell.com>
  61353. Reviewed by Alp Toker.
  61354. Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
  61355. plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
  61356. handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>
  61357. * plugins/gtk/PluginPackageGtk.cpp:
  61358. 2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
  61359. Reviewed by Oliver Hunt.
  61360. - https://bugs.webkit.org/show_bug.cgi?id=19331
  61361. <rdar://problem/5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()
  61362. * page/DragController.cpp:
  61363. (WebCore::DragController::startDrag): When a link is dragged without any
  61364. text selected (note: for this to work, the EditableLinkBehavior setting must be
  61365. set to 'live' or 'default') and then dropped into an editable html document it
  61366. will eventually violate an ASSERT in MoveSelectionCommand that requires that there
  61367. is a selection. To prevent this, expand the selection to the enclosing anchor tag
  61368. when the drag begins.
  61369. 2008-10-12 Darin Adler <darin@apple.com>
  61370. Reviewed by Mark Rowe.
  61371. - fix https://bugs.webkit.org/show_bug.cgi?id=21557
  61372. Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing
  61373. * rendering/RenderObject.cpp:
  61374. (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain
  61375. until we hit an Element. Nowadays, Node::isElementNode() is just as efficient
  61376. as RenderObject::isText(), and this guarantees that the node can be cast to
  61377. Element*, which is done just below. The reason this is hit is that RenderLayer
  61378. can call getPseudoStyle on a RenderView, which has the document as its
  61379. element() -- and a document is neither a Text node nor an Element. A loose
  61380. end is that this seems to mean you can't style the scrollbar corner or the
  61381. resizer on a RenderView. Hyatt may want to look into that later.
  61382. 2008-10-12 Darin Adler <darin@apple.com>
  61383. Reviewed by Sam Weinig.
  61384. - https://bugs.webkit.org/show_bug.cgi?id=21556
  61385. Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
  61386. Tests: fast/dom/HTMLFontElement/size-attribute.html
  61387. fast/dom/HTMLInputElement/size-attribute.html
  61388. fast/dom/HTMLTableElement/cellpadding-attribute.html
  61389. * html/HTMLFontElement.cpp:
  61390. (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of
  61391. Unicode::isDigit, since non-ASCII digits are not valid here.
  61392. * html/HTMLFontElement.h: Tweaked formatting a bit and removed
  61393. the unneeded destructor declaration.
  61394. * platform/text/String.cpp:
  61395. (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead
  61396. of Unicode::isDigit, since non-ASCII digits are not valid.
  61397. 2008-10-12 Jungshik Shin <jshin@chromium.org>
  61398. Reviewed by Darin Adler.
  61399. Treat x-user-defined as windows-1252 for html files with meta charset
  61400. declaration to be compatible with Indian web sites.
  61401. ( https://bugs.webkit.org/show_bug.cgi?id=18270 )
  61402. Test: fast/encoding/charset-xuser-defined.html
  61403. * loader/TextResourceDecoder.cpp:
  61404. (WebCore::TextResourceDecoder::setEncoding):
  61405. 2008-10-12 Sam Weinig <sam@webkit.org>
  61406. Reviewed by Dan Bernstein.
  61407. Remove unneeded forward declaration.
  61408. * platform/graphics/ImageBuffer.h:
  61409. 2008-10-12 Sam Weinig <sam@webkit.org>
  61410. Reviewed by Darin Adler.
  61411. Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
  61412. Layering violation: String should not be responsible for creating Lengths
  61413. It was a layering violation for String to know haw to parse
  61414. into Lengths, LengthArrays, and CoordsArrays.
  61415. * GNUmakefile.am:
  61416. * WebCore.pro:
  61417. * WebCore.vcproj/WebCore.vcproj:
  61418. * WebCore.xcodeproj/project.pbxproj:
  61419. * WebCoreSources.bkl:
  61420. * html/HTMLAreaElement.cpp:
  61421. (WebCore::HTMLAreaElement::parseMappedAttribute):
  61422. * html/HTMLFrameSetElement.cpp:
  61423. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  61424. * platform/text/AtomicString.h:
  61425. (WebCore::AtomicString::percentage):
  61426. * platform/text/PlatformString.h:
  61427. * platform/text/String.cpp:
  61428. * platform/text/StringImpl.cpp:
  61429. * platform/text/StringImpl.h:
  61430. * rendering/Length.cpp: Added.
  61431. (WebCore::parseLength):
  61432. (WebCore::countCharacter):
  61433. (WebCore::newCoordsArray):
  61434. (WebCore::newLengthArray):
  61435. * rendering/Length.h:
  61436. (WebCore::LengthSize::LengthSize):
  61437. 2008-10-12 Brad Garcia <bgarcia@google.com>
  61438. Reviewed by Darin Adler.
  61439. Interpret fractional percentage values for %MultiLength values.
  61440. Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
  61441. Test: fast/frames/frame-length-fractional-percentage.html
  61442. * platform/text/StringImpl.cpp:
  61443. (WebCore::parseLength):
  61444. 2008-10-12 Timothy Hatcher <timothy@apple.com>
  61445. Remember the expanded state of the rules in the Styles pane. So
  61446. collapsing a rule will persist across all the elements that have
  61447. that same rule. The same applies to Computed Style, so the Computed
  61448. Style rule is now collapsed by default. This should help lessen the
  61449. confusion on why Computed Style can't be edited (a common confusion.)
  61450. https://bugs.webkit.org/show_bug.cgi?id=21553
  61451. Reviewed by Darin Adler.
  61452. * inspector/front-end/PropertiesSection.js:
  61453. (WebInspector.PropertiesSection): Set the _expanded property directly,
  61454. instead of using the setter. Expanded is the default, so no work is needed.
  61455. This prevents calling StylesSidebarPane.collapse before object initialization
  61456. is complete.
  61457. * inspector/front-end/StylesSidebarPane.js:
  61458. (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object
  61459. for the expanded state of the StylePropertiesSection. Collapse computed style
  61460. by default and expand everything else.
  61461. (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used
  61462. when remembering expanded state.
  61463. (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state
  61464. to true for this identifier in Preferences.styleRulesExpandedState. Don't remember
  61465. the state if the dontRememberState property is true.
  61466. (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state
  61467. to false for this identifier in Preferences.styleRulesExpandedState.
  61468. * inspector/front-end/inspector.js:
  61469. (Preferences.styleRulesExpandedState): Initialize to an empty object.
  61470. 2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
  61471. Reviewed by Alp Toker.
  61472. [Gtk] Remove libWebCoreJS.la when doing make clean
  61473. https://bugs.webkit.org/show_bug.cgi?id=21544
  61474. Remove libWebCoreJS.la when doing a clean target
  61475. * GNUmakefile.am: add libWebCoreJS.la to CLEANFILES
  61476. 2008-10-11 Alp Toker <alp@nuanti.com>
  61477. Reviewed by Darin Adler.
  61478. https://bugs.webkit.org/show_bug.cgi?id=20592
  61479. The focus ring is not shown while navigating on some pages
  61480. Fix drawFocusRing() so it doesn't depend on the current graphics
  61481. state, thus matching other platforms which already work this way.
  61482. This patch provides two code paths: one using straight Cairo and
  61483. one specialised for the GTK+ port with a more conventional appearance.
  61484. Also change focusRingColor() to return a null color, allowing the
  61485. focus ring to pick up the style's current color if it isn't overridden
  61486. with CSS.
  61487. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  61488. (WebCore::GraphicsContext::drawFocusRing):
  61489. * platform/gtk/TemporaryLinkStubs.cpp:
  61490. (WebCore::focusRingColor):
  61491. 2008-10-11 Dan Bernstein <mitz@apple.com>
  61492. Rubber-stamped by Sam Weinig.
  61493. - change all internal callers to use Cache::evict() instead of remove()
  61494. * loader/Cache.cpp:
  61495. (WebCore::Cache::revalidateResource):
  61496. (WebCore::Cache::revalidationSucceeded):
  61497. (WebCore::Cache::pruneDeadResources):
  61498. (WebCore::Cache::setDisabled):
  61499. 2008-10-11 David Hyatt <hyatt@apple.com>
  61500. Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.
  61501. Reviewed by Tim Hatcher
  61502. * platform/ScrollbarThemeComposite.cpp:
  61503. (WebCore::ScrollbarThemeComposite::invalidatePart):
  61504. 2008-10-11 David Hyatt <hyatt@apple.com>
  61505. https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).
  61506. Also fixed resizer positioning problems.
  61507. Reviewed by Tim Hatcher
  61508. * platform/ScrollbarThemeComposite.cpp:
  61509. (WebCore::ScrollbarThemeComposite::splitTrack):
  61510. (WebCore::ScrollbarThemeComposite::trackPosition):
  61511. (WebCore::ScrollbarThemeComposite::trackLength):
  61512. * platform/ScrollbarThemeComposite.h:
  61513. (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
  61514. * rendering/RenderLayer.cpp:
  61515. (WebCore::scrollCornerRect):
  61516. (WebCore::RenderLayer::positionOverflowControls):
  61517. (WebCore::RenderLayer::paintOverflowControls):
  61518. (WebCore::RenderLayer::isPointInResizeControl):
  61519. (WebCore::RenderLayer::hitTestOverflowControls):
  61520. * rendering/RenderScrollbarTheme.cpp:
  61521. (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
  61522. * rendering/RenderScrollbarTheme.h:
  61523. 2008-10-11 Alp Toker <alp@nuanti.com>
  61524. Reviewed by David Hyatt.
  61525. Implement release/retain for Widget GTK+.
  61526. * platform/Widget.cpp:
  61527. * platform/gtk/WidgetGtk.cpp:
  61528. (WebCore::Widget::~Widget):
  61529. (WebCore::Widget::releasePlatformWidget):
  61530. (WebCore::Widget::retainPlatformWidget):
  61531. 2008-10-11 Dan Bernstein <mitz@apple.com>
  61532. Reviewed by Sam Weinig.
  61533. - rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
  61534. and add a corresponding getter; add the same functions on Windows
  61535. * WebCore.base.exp:
  61536. * platform/graphics/Font.cpp:
  61537. (WebCore::Font::setCodePath):
  61538. (WebCore::codePath):
  61539. (WebCore::Font::canUseGlyphCache):
  61540. * platform/graphics/Font.h:
  61541. * platform/mac/WebCoreTextRenderer.h:
  61542. * platform/mac/WebCoreTextRenderer.mm:
  61543. (WebCoreSetAlwaysUsesComplexTextCodePath):
  61544. (WebCoreAlwaysUsesComplexTextCodePath):
  61545. * platform/win/WebCoreTextRenderer.cpp:
  61546. (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
  61547. (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
  61548. * platform/win/WebCoreTextRenderer.h:
  61549. 2008-10-11 Sam Weinig <sam@webkit.org>
  61550. Reviewed by Cameron Zwarich.
  61551. Stop leaking the event parameter names. The protected strings were showing up
  61552. in the caches window after one use. No measurable performance loss.
  61553. * bindings/js/JSEventListener.cpp:
  61554. (WebCore::eventParameterName):
  61555. 2008-10-11 Sam Weinig <sam@webkit.org>
  61556. Reviewed by Cameron Zwarich.
  61557. Remove unused function getNodeEventListener.
  61558. * bindings/js/JSEventListener.cpp:
  61559. * bindings/js/JSEventListener.h:
  61560. 2008-10-11 David Hyatt <hyatt@apple.com>
  61561. Add support for both positive and negative margins to tracks and track pieces.
  61562. Reviewed by Tim Hatcher
  61563. * platform/ScrollbarThemeComposite.cpp:
  61564. (WebCore::ScrollbarThemeComposite::paint):
  61565. (WebCore::ScrollbarThemeComposite::hitTest):
  61566. (WebCore::ScrollbarThemeComposite::splitTrack):
  61567. (WebCore::ScrollbarThemeComposite::trackPieceRects):
  61568. (WebCore::ScrollbarThemeComposite::trackPosition):
  61569. (WebCore::ScrollbarThemeComposite::trackLength):
  61570. * platform/ScrollbarThemeComposite.h:
  61571. (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
  61572. * rendering/RenderScrollbar.cpp:
  61573. (WebCore::RenderScrollbar::trackRect):
  61574. (WebCore::RenderScrollbar::trackPieceRectWithMargins):
  61575. * rendering/RenderScrollbar.h:
  61576. * rendering/RenderScrollbarPart.cpp:
  61577. (WebCore::RenderScrollbarPart::computeScrollbarWidth):
  61578. (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  61579. * rendering/RenderScrollbarTheme.cpp:
  61580. (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
  61581. * rendering/RenderScrollbarTheme.h:
  61582. 2008-10-10 David Hyatt <hyatt@apple.com>
  61583. Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
  61584. the scrollbar pseudo-elements anyway.
  61585. Reviewed by Tim Hatcher
  61586. * css/CSSSelector.cpp:
  61587. (WebCore::CSSSelector::extractPseudoType):
  61588. * css/CSSSelector.h:
  61589. (WebCore::CSSSelector::):
  61590. * css/CSSStyleSelector.cpp:
  61591. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61592. 2008-10-10 Dan Bernstein <mitz@apple.com>
  61593. Reviewed by Sam Weinig.
  61594. - separate Cache::remove() into a private method and a public interface,
  61595. then make Cache::pruneDeadResources() use the private method.
  61596. * loader/Cache.cpp:
  61597. (WebCore::Cache::pruneDeadResources):
  61598. (WebCore::Cache::evict):
  61599. * loader/Cache.h:
  61600. (WebCore::Cache::remove):
  61601. 2008-10-10 David Hyatt <hyatt@apple.com>
  61602. Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
  61603. now that the track pieces meet under the thumb.
  61604. Reviewed by Tim Hatcher
  61605. * platform/ScrollbarThemeComposite.cpp:
  61606. (WebCore::ScrollbarThemeComposite::paint):
  61607. (WebCore::ScrollbarThemeComposite::splitTrack):
  61608. 2008-10-10 David Hyatt <hyatt@apple.com>
  61609. Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).
  61610. Reviewed by Tim Hatcher
  61611. * platform/ScrollbarThemeComposite.cpp:
  61612. (WebCore::ScrollbarThemeComposite::hitTest):
  61613. (WebCore::ScrollbarThemeComposite::splitTrack):
  61614. 2008-10-10 David Hyatt <hyatt@apple.com>
  61615. Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.
  61616. Reviewed by Tim Hatcher
  61617. * rendering/RenderLayer.cpp:
  61618. (WebCore::RenderLayer::createScrollbar):
  61619. * rendering/RenderScrollbar.cpp:
  61620. (WebCore::RenderScrollbar::createCustomScrollbar):
  61621. (WebCore::RenderScrollbar::RenderScrollbar):
  61622. (WebCore::RenderScrollbar::setParent):
  61623. (WebCore::RenderScrollbar::updateScrollbarParts):
  61624. (WebCore::RenderScrollbar::updateScrollbarPart):
  61625. * rendering/RenderScrollbar.h:
  61626. * rendering/style/RenderStyle.h:
  61627. (WebCore::RenderStyle::):
  61628. 2008-10-10 David Hyatt <hyatt@apple.com>
  61629. Make sure scrollbar background images cause proper part invalidation to occur.
  61630. Reviewed by Tim Hatcher
  61631. * rendering/RenderScrollbar.cpp:
  61632. (WebCore::RenderScrollbar::setHoveredPart):
  61633. (WebCore::RenderScrollbar::setPressedPart):
  61634. * rendering/RenderScrollbarPart.cpp:
  61635. (WebCore::RenderScrollbarPart::styleDidChange):
  61636. (WebCore::RenderScrollbarPart::imageChanged):
  61637. * rendering/RenderScrollbarPart.h:
  61638. 2008-10-10 Simon Fraser <simon.fraser@apple.com>
  61639. Reviewed by Darin Adler
  61640. https://bugs.webkit.org/show_bug.cgi?id=21538
  61641. The blendFunc() for TransformOperations should never mess with the
  61642. operation lists by replacing some ops with identity, otherwise the lists
  61643. no longer match and transitions break.
  61644. Test: transitions/matched-transform-functions.html
  61645. * page/animation/AnimationBase.cpp:
  61646. (WebCore::blendFunc):
  61647. 2008-10-10 Simon Fraser <simon.fraser@apple.com>
  61648. Reviewed by Darin Adler
  61649. https://bugs.webkit.org/show_bug.cgi?id=21537
  61650. Fix re-targetting a running transition; if the target property
  61651. changes, we do need to make a new ImplicitAnimation.
  61652. Test: transitions/retargetted-transition.html
  61653. * page/animation/CompositeAnimation.cpp:
  61654. (WebCore::CompositeAnimationPrivate::updateTransitions):
  61655. 2008-10-10 Oliver Hunt <oliver@apple.com>
  61656. Reviewed by Cameron Zwarich.
  61657. Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion.
  61658. When JS is terminated by the user choosing to stop a slow script
  61659. the exception toString method throws, yet the console logger does
  61660. not perform exception checks after logging. This leaves an
  61661. exception on the Machine, which in turn results in an assertion
  61662. failure next time we attempt to enter JS. The solution is just to
  61663. clear the exception state after attempting to record the exception.
  61664. * page/Console.cpp:
  61665. (WebCore::Console::reportException):
  61666. 2008-10-10 David Hyatt <hyatt@apple.com>
  61667. Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
  61668. when looking for pseudo styles.
  61669. Reviewed by Tim Hatcher
  61670. * rendering/RenderLayer.cpp:
  61671. (WebCore::RenderLayer::createScrollbar):
  61672. (WebCore::RenderLayer::styleChanged):
  61673. 2008-10-10 David Hyatt <hyatt@apple.com>
  61674. Add the ability to style the scroll corner and the resizer from CSS.
  61675. Reviewed by Tim Hatcher
  61676. * css/CSSSelector.cpp:
  61677. (WebCore::CSSSelector::extractPseudoType):
  61678. * css/CSSSelector.h:
  61679. (WebCore::CSSSelector::):
  61680. * css/CSSStyleSelector.cpp:
  61681. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  61682. * rendering/RenderLayer.cpp:
  61683. (WebCore::RenderLayer::RenderLayer):
  61684. (WebCore::RenderLayer::~RenderLayer):
  61685. (WebCore::RenderLayer::paintOverflowControls):
  61686. (WebCore::RenderLayer::paintScrollCorner):
  61687. (WebCore::RenderLayer::paintResizer):
  61688. (WebCore::RenderLayer::styleChanged):
  61689. * rendering/RenderLayer.h:
  61690. * rendering/RenderScrollbar.cpp:
  61691. (WebCore::RenderScrollbar::updateScrollbarPart):
  61692. (WebCore::RenderScrollbar::paintPart):
  61693. * rendering/RenderScrollbarPart.cpp:
  61694. (WebCore::RenderScrollbarPart::RenderScrollbarPart):
  61695. (WebCore::RenderScrollbarPart::paintIntoRect):
  61696. * rendering/RenderScrollbarPart.h:
  61697. * rendering/style/RenderStyle.h:
  61698. (WebCore::RenderStyle::):
  61699. 2008-10-10 David Hyatt <hyatt@apple.com>
  61700. Make CSS scrollbars respect the OS setting regarding where buttons should be placed.
  61701. Reviewed by Sam Weinig
  61702. No test case possible, since the OS setting can vary.
  61703. * css/CSSSelector.cpp:
  61704. (WebCore::CSSSelector::extractPseudoType):
  61705. * css/CSSSelector.h:
  61706. (WebCore::CSSSelector::):
  61707. * css/CSSStyleSelector.cpp:
  61708. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61709. * platform/Scrollbar.h:
  61710. (WebCore::Scrollbar::styleChanged):
  61711. * platform/mac/ScrollbarThemeMac.mm:
  61712. (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
  61713. (WebCore::ScrollbarThemeMac::preferencesChanged):
  61714. * rendering/RenderLayer.cpp:
  61715. (WebCore::RenderLayer::invalidateScrollbarRect):
  61716. * rendering/RenderScrollbar.cpp:
  61717. (WebCore::RenderScrollbar::styleChanged):
  61718. (WebCore::RenderScrollbar::updateScrollbarPart):
  61719. * rendering/RenderScrollbar.h:
  61720. * rendering/RenderScrollbarTheme.h:
  61721. (WebCore::RenderScrollbarTheme::buttonsPlacement):
  61722. 2008-10-10 Timothy Hatcher <timothy@apple.com>
  61723. Fixes a regression with input search fields, where the placeholder text
  61724. would not be updated when the value of the placeholder attribute changed.
  61725. https://bugs.webkit.org/show_bug.cgi?id=21521
  61726. Reviewed by Adele Peterson.
  61727. Test: fast/forms/search-placeholder-value-changed.html
  61728. * html/HTMLInputElement.cpp:
  61729. (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
  61730. placeholderValueChanged parameter of updatePlaceholderVisibility.
  61731. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
  61732. for placeholderValueChanged that informs the method that the value changed.
  61733. * html/HTMLInputElement.h: Add the placeholderValueChanged to the
  61734. updatePlaceholderVisibility method. Made it default to false.
  61735. 2008-10-10 David Hyatt <hyatt@apple.com>
  61736. Allow the track part to have negative margins so that it can slightly overlap buttons. This
  61737. is necessary to emulate the Aqua look in CSS.
  61738. Reviewed by Sam Weinig
  61739. * platform/ScrollbarThemeComposite.cpp:
  61740. (WebCore::ScrollbarThemeComposite::paint):
  61741. (WebCore::ScrollbarThemeComposite::hitTest):
  61742. * rendering/RenderScrollbar.cpp:
  61743. (WebCore::RenderScrollbar::setHoveredPart):
  61744. (WebCore::RenderScrollbar::trackRect):
  61745. * rendering/RenderScrollbar.h:
  61746. * rendering/RenderScrollbarPart.cpp:
  61747. (WebCore::RenderScrollbarPart::computeScrollbarWidth):
  61748. (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  61749. * rendering/RenderScrollbarTheme.cpp:
  61750. (WebCore::RenderScrollbarTheme::backButtonRect):
  61751. (WebCore::RenderScrollbarTheme::forwardButtonRect):
  61752. (WebCore::RenderScrollbarTheme::trackRect):
  61753. 2008-10-10 David Hyatt <hyatt@apple.com>
  61754. https://bugs.webkit.org/show_bug.cgi?id=21527
  61755. Make CSS scrollbars support :not, :hover and :active.
  61756. Reviewed by Adam Roben
  61757. Added WebCore/manual-tests/scrollbar-hover-active.html
  61758. * css/CSSStyleSelector.cpp:
  61759. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  61760. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61761. * platform/Scrollbar.cpp:
  61762. (WebCore::Scrollbar::autoscrollPressedPart):
  61763. (WebCore::Scrollbar::startTimerIfNeeded):
  61764. (WebCore::Scrollbar::setHoveredPart):
  61765. (WebCore::Scrollbar::setPressedPart):
  61766. (WebCore::Scrollbar::mouseMoved):
  61767. (WebCore::Scrollbar::mouseExited):
  61768. (WebCore::Scrollbar::mouseUp):
  61769. (WebCore::Scrollbar::mouseDown):
  61770. * platform/Scrollbar.h:
  61771. * rendering/RenderScrollbar.cpp:
  61772. (WebCore::RenderScrollbar::setHoveredPart):
  61773. (WebCore::RenderScrollbar::setPressedPart):
  61774. (WebCore::RenderScrollbar::updateScrollbarParts):
  61775. (WebCore::pseudoForScrollbarPart):
  61776. (WebCore::RenderScrollbar::updateScrollbarPart):
  61777. * rendering/RenderScrollbar.h:
  61778. 2008-10-10 Chris Marrin <cmarrin@apple.com>
  61779. Reviewed by Dan Bernstein.
  61780. Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
  61781. CSS transition with duration=0 and delay=0 doesn't override ongoing transition
  61782. Test: transitions/interrupt-zero-duration.html
  61783. * page/animation/CompositeAnimation.cpp:
  61784. (WebCore::CompositeAnimation::updateTransitions):
  61785. 2008-10-10 Kevin Ollivier <kevino@theolliviers.com>
  61786. wx build fix. Add new scrollbar-related sources.
  61787. * WebCoreSources.bkl:
  61788. 2008-10-10 David Hyatt <hyatt@apple.com>
  61789. https://bugs.webkit.org/show_bug.cgi?id=21522
  61790. Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
  61791. created. (Just :hover/:active left to finish it up.)
  61792. Reviewed by Adam Roben
  61793. Added scrollbars/scrollbar-buttons.html
  61794. * css/CSSStyleSelector.cpp:
  61795. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61796. 2008-10-10 David Hyatt <hyatt@apple.com>
  61797. Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
  61798. back/forward to decrement/increment. Adding start/end pseudoclasses.
  61799. Reviewed by Eric Seidel
  61800. * css/CSSSelector.cpp:
  61801. (WebCore::CSSSelector::extractPseudoType):
  61802. * css/CSSSelector.h:
  61803. (WebCore::CSSSelector::):
  61804. * css/CSSStyleSelector.cpp:
  61805. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61806. 2008-10-10 David Hyatt <hyatt@apple.com>
  61807. Switch window-active to window-inactive, since that will work better as far as degrading in other
  61808. browsers.
  61809. Reviewed by Tim Hatcher
  61810. * css/CSSSelector.cpp:
  61811. (WebCore::CSSSelector::extractPseudoType):
  61812. * css/CSSSelector.h:
  61813. (WebCore::CSSSelector::):
  61814. * css/CSSStyleSelector.cpp:
  61815. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61816. 2008-10-09 Chris Marrin <cmarrin@apple.com>
  61817. Reviewed by Dan Bernstein.
  61818. https://bugs.webkit.org/show_bug.cgi?id=21310
  61819. Redesigned how animation events are sent in order to get rid of
  61820. AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
  61821. are now ref counted. While calling the event handler, I keep a
  61822. reference to this class to avoid it getting destroyed out from under me.
  61823. I also moved most of the functionality of CompositeAnimation to
  61824. and internal class (CompositeAnimationPrivate) to reduce the exposure
  61825. of the internals of the various animation classes.
  61826. We have several transition and animation LayoutTests which verify that
  61827. this fix works as expected and continues to avoid crashes.
  61828. * page/animation/AnimationBase.cpp:
  61829. (WebCore::AnimationBase::AnimationBase):
  61830. * page/animation/AnimationBase.h:
  61831. (WebCore::AnimationBase::cancelTimers):
  61832. (WebCore::AnimationBase::waitingForStyleAvailable):
  61833. * page/animation/CompositeAnimation.cpp:
  61834. (WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
  61835. (WebCore::CompositeAnimationPrivate::suspended):
  61836. (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
  61837. (WebCore::CompositeAnimationPrivate::updateTransitions):
  61838. (WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
  61839. (WebCore::CompositeAnimationPrivate::animate):
  61840. (WebCore::CompositeAnimationPrivate::setAnimating):
  61841. (WebCore::CompositeAnimationPrivate::animating):
  61842. (WebCore::CompositeAnimationPrivate::getAnimationForProperty):
  61843. (WebCore::CompositeAnimationPrivate::resetTransitions):
  61844. (WebCore::CompositeAnimationPrivate::resetAnimations):
  61845. (WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
  61846. (WebCore::CompositeAnimationPrivate::setAnimationStartTime):
  61847. (WebCore::CompositeAnimationPrivate::setTransitionStartTime):
  61848. (WebCore::CompositeAnimationPrivate::suspendAnimations):
  61849. (WebCore::CompositeAnimationPrivate::resumeAnimations):
  61850. (WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
  61851. (WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
  61852. (WebCore::compareAnimationIndices):
  61853. (WebCore::CompositeAnimationPrivate::styleAvailable):
  61854. (WebCore::CompositeAnimationPrivate::isAnimatingProperty):
  61855. (WebCore::CompositeAnimationPrivate::setWaitingForStyleAvailable):
  61856. (WebCore::CompositeAnimation::CompositeAnimation):
  61857. (WebCore::CompositeAnimation::~CompositeAnimation):
  61858. (WebCore::CompositeAnimation::animate):
  61859. (WebCore::CompositeAnimation::animating):
  61860. (WebCore::CompositeAnimation::setWaitingForStyleAvailable):
  61861. (WebCore::CompositeAnimation::resetTransitions):
  61862. (WebCore::CompositeAnimation::suspendAnimations):
  61863. (WebCore::CompositeAnimation::resumeAnimations):
  61864. (WebCore::CompositeAnimation::suspended):
  61865. (WebCore::CompositeAnimation::styleAvailable):
  61866. (WebCore::CompositeAnimation::setAnimating):
  61867. (WebCore::CompositeAnimation::isAnimatingProperty):
  61868. (WebCore::CompositeAnimation::setAnimationStartTime):
  61869. (WebCore::CompositeAnimation::setTransitionStartTime):
  61870. (WebCore::CompositeAnimation::overrideImplicitAnimations):
  61871. (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
  61872. * page/animation/CompositeAnimation.h:
  61873. * page/animation/ImplicitAnimation.cpp:
  61874. (WebCore::ImplicitAnimation::sendTransitionEvent):
  61875. * page/animation/ImplicitAnimation.h:
  61876. (WebCore::ImplicitAnimation::create):
  61877. * page/animation/KeyframeAnimation.cpp:
  61878. (WebCore::KeyframeAnimation::sendAnimationEvent):
  61879. * page/animation/KeyframeAnimation.h:
  61880. (WebCore::KeyframeAnimation::create):
  61881. 2008-10-09 David Hyatt <hyatt@apple.com>
  61882. Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
  61883. is active as well.
  61884. Reviewed by Tim Hatcher
  61885. Added scrollbars/scrollbar-orientation.html
  61886. * css/CSSSelector.cpp:
  61887. (WebCore::CSSSelector::extractPseudoType):
  61888. * css/CSSSelector.h:
  61889. (WebCore::CSSSelector::):
  61890. * css/CSSStyleSelector.cpp:
  61891. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61892. * platform/Scrollbar.cpp:
  61893. (WebCore::Scrollbar::isWindowActive):
  61894. * platform/Scrollbar.h:
  61895. * rendering/RenderScrollbar.cpp:
  61896. (WebCore::RenderScrollbar::paint):
  61897. (WebCore::RenderScrollbar::partForStyleResolve):
  61898. * rendering/RenderScrollbar.h:
  61899. 2008-10-09 David Hyatt <hyatt@apple.com>
  61900. Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
  61901. :enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.
  61902. Reviewed by Tim Hatcher
  61903. Added scrollbars/disabled-scrollbar.html
  61904. * css/CSSStyleSelector.cpp:
  61905. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  61906. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  61907. (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  61908. * css/CSSStyleSelector.h:
  61909. * rendering/RenderObject.cpp:
  61910. (WebCore::RenderObject::getPseudoStyle):
  61911. * rendering/RenderObject.h:
  61912. * rendering/RenderScrollbar.cpp:
  61913. (WebCore::RenderScrollbar::setEnabled):
  61914. (WebCore::RenderScrollbar::scrollbarForStyleResolve):
  61915. (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
  61916. (WebCore::RenderScrollbar::paintPart):
  61917. * rendering/RenderScrollbar.h:
  61918. 2008-10-09 Eric Carlson <eric.carlson@apple.com>
  61919. Media controls should not show when element is not visible
  61920. https://bugs.webkit.org/show_bug.cgi?id=21155
  61921. Reviewed by Adele Peterson.
  61922. * html/HTMLMediaElement.cpp:
  61923. (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay
  61924. in sync with visibility changes
  61925. * html/HTMLMediaElement.h:
  61926. * rendering/RenderMedia.cpp:
  61927. (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible
  61928. (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining
  61929. if element is visible or not. Don't animate controller visibility when change triggered by
  61930. showing or hiding media element.
  61931. * rendering/RenderMedia.h: declare m_previousVisible
  61932. 2008-10-09 Timothy Hatcher <timothy@apple.com>
  61933. Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
  61934. availability macros and version macros.
  61935. https://bugs.webkit.org/show_bug.cgi?id=21496
  61936. rdar://problem/6259225
  61937. Reviewed by Sam Weinig.
  61938. * bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
  61939. * bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h
  61940. and add an #if around the enum.
  61941. * bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the
  61942. comment to match the other headers.
  61943. * bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
  61944. * bindings/objc/DOMObject.h: Add a version #if around class interface.
  61945. * bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h
  61946. and add a version #if around the enum.
  61947. * bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
  61948. * bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
  61949. * bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for
  61950. when they where added to WebKit. Also annotate individual methods that are
  61951. deprecated or where added after the class was added to WebKit.
  61952. * bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h
  61953. since this header is included by most DOM headers. Annotate the JSObject method.
  61954. * bindings/scripts/CodeGeneratorObjC.pm:
  61955. (ReadPublicInterfaces): Parse out the availability macro for each function/property.
  61956. And parse out the availability version for the class/protocol. Default to
  61957. WEBKIT_VERSION_LATEST if the class is new.
  61958. (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the
  61959. interface availability version check if the class has a required version. Create
  61960. a public interface key (used to lookup in $publicInterfaces) and make a declaration
  61961. suffix that includes the availability macro (if needed). Use the "available in 1.3
  61962. and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as
  61963. the default availability macro for old style methods. Tweak line breaks in the generated
  61964. headers to look good and not have too many extra lines.
  61965. 2008-10-09 Simon Fraser <simon.fraser@apple.com>
  61966. Reviewed by Dave Hyatt
  61967. https://bugs.webkit.org/show_bug.cgi?id=20947
  61968. Refactor setStyle() methods into styleWillChange()
  61969. and styleDidChange(), so most of the setStyle() overrides can
  61970. be removed.
  61971. * rendering/RenderBR.cpp:
  61972. (WebCore::RenderBR::styleDidChange):
  61973. * rendering/RenderBR.h:
  61974. * rendering/RenderBlock.cpp:
  61975. (WebCore::RenderBlock::styleWillChange):
  61976. (WebCore::RenderBlock::styleDidChange):
  61977. * rendering/RenderBlock.h:
  61978. * rendering/RenderBox.cpp:
  61979. (WebCore::RenderBox::~RenderBox):
  61980. (WebCore::RenderBox::destroy):
  61981. (WebCore::RenderBox::styleWillChange):
  61982. (WebCore::RenderBox::styleDidChange):
  61983. * rendering/RenderBox.h:
  61984. * rendering/RenderButton.cpp:
  61985. (WebCore::RenderButton::styleWillChange):
  61986. (WebCore::RenderButton::styleDidChange):
  61987. * rendering/RenderButton.h:
  61988. * rendering/RenderFieldset.cpp:
  61989. (WebCore::RenderFieldset::styleDidChange):
  61990. * rendering/RenderFieldset.h:
  61991. * rendering/RenderFileUploadControl.cpp:
  61992. (WebCore::RenderFileUploadControl::styleDidChange):
  61993. * rendering/RenderFileUploadControl.h:
  61994. * rendering/RenderInline.cpp:
  61995. (WebCore::RenderInline::styleDidChange):
  61996. * rendering/RenderInline.h:
  61997. * rendering/RenderLayer.cpp:
  61998. (WebCore::RenderLayer::styleChanged):
  61999. * rendering/RenderLayer.h:
  62000. * rendering/RenderListBox.cpp:
  62001. (WebCore::RenderListBox::styleDidChange):
  62002. * rendering/RenderListBox.h:
  62003. * rendering/RenderListItem.cpp:
  62004. (WebCore::RenderListItem::styleDidChange):
  62005. * rendering/RenderListItem.h:
  62006. * rendering/RenderListMarker.cpp:
  62007. (WebCore::RenderListMarker::styleWillChange):
  62008. (WebCore::RenderListMarker::styleDidChange):
  62009. * rendering/RenderListMarker.h:
  62010. * rendering/RenderMenuList.cpp:
  62011. (WebCore::RenderMenuList::styleDidChange):
  62012. * rendering/RenderMenuList.h:
  62013. * rendering/RenderObject.cpp:
  62014. (WebCore::RenderObject::setStyle):
  62015. (WebCore::RenderObject::setStyleInternal):
  62016. (WebCore::RenderObject::styleWillChange):
  62017. (WebCore::RenderObject::styleDidChange):
  62018. * rendering/RenderObject.h:
  62019. * rendering/RenderReplaced.cpp:
  62020. (WebCore::RenderReplaced::styleDidChange):
  62021. * rendering/RenderReplaced.h:
  62022. * rendering/RenderSVGGradientStop.cpp:
  62023. (WebCore::RenderSVGGradientStop::styleDidChange):
  62024. * rendering/RenderSVGGradientStop.h:
  62025. * rendering/RenderScrollbarPart.cpp:
  62026. (WebCore::RenderScrollbarPart::styleDidChange):
  62027. * rendering/RenderScrollbarPart.h:
  62028. * rendering/RenderSlider.cpp:
  62029. (WebCore::RenderSlider::styleDidChange):
  62030. * rendering/RenderSlider.h:
  62031. * rendering/RenderTable.cpp:
  62032. (WebCore::RenderTable::styleDidChange):
  62033. * rendering/RenderTable.h:
  62034. * rendering/RenderTableCell.cpp:
  62035. (WebCore::RenderTableCell::styleWillChange):
  62036. (WebCore::RenderTableCell::styleDidChange):
  62037. * rendering/RenderTableCell.h:
  62038. * rendering/RenderTableRow.cpp:
  62039. (WebCore::RenderTableRow::styleWillChange):
  62040. * rendering/RenderTableRow.h:
  62041. * rendering/RenderText.cpp:
  62042. (WebCore::RenderText::styleDidChange):
  62043. * rendering/RenderText.h:
  62044. * rendering/RenderTextControl.cpp:
  62045. (WebCore::RenderTextControl::styleDidChange):
  62046. * rendering/RenderTextControl.h:
  62047. * rendering/RenderWidget.cpp:
  62048. (WebCore::RenderWidget::styleDidChange):
  62049. * rendering/RenderWidget.h:
  62050. 2008-10-09 David Hyatt <hyatt@apple.com>
  62051. Make sure to destroy a custom scrollbar's RenderObjects before the arena goes away. When our widget
  62052. parent is nulled out is a good time.
  62053. Reviewed by Oliver Hunt
  62054. * rendering/RenderScrollbar.cpp:
  62055. (WebCore::RenderScrollbar::~RenderScrollbar):
  62056. (WebCore::RenderScrollbar::setParent):
  62057. (WebCore::RenderScrollbar::updateScrollbarPart):
  62058. * rendering/RenderScrollbar.h:
  62059. 2008-10-09 David Hyatt <hyatt@apple.com>
  62060. https://bugs.webkit.org/show_bug.cgi?id=21446
  62061. This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
  62062. orientation and back vs. forward on the buttons, but it's a start.
  62063. Reviewed by Oliver Hunt
  62064. Added scrollbars/basic-scrollbar.html
  62065. * WebCore.xcodeproj/project.pbxproj:
  62066. * css/CSSSelector.cpp:
  62067. (WebCore::CSSSelector::extractPseudoType):
  62068. * css/CSSSelector.h:
  62069. (WebCore::CSSSelector::):
  62070. * css/CSSStyleSelector.cpp:
  62071. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  62072. * platform/ScrollTypes.h:
  62073. (WebCore::):
  62074. * platform/Scrollbar.h:
  62075. (WebCore::Scrollbar::styleChanged):
  62076. * platform/ScrollbarThemeComposite.cpp:
  62077. (WebCore::ScrollbarThemeComposite::paint):
  62078. (WebCore::ScrollbarThemeComposite::splitTrack):
  62079. * platform/ScrollbarThemeComposite.h:
  62080. (WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
  62081. (WebCore::ScrollbarThemeComposite::paintTrackBackground):
  62082. (WebCore::ScrollbarThemeComposite::paintTrackPiece):
  62083. * platform/win/ScrollbarThemeSafari.cpp:
  62084. (WebCore::ScrollbarThemeSafari::paintTrackBackground):
  62085. * platform/win/ScrollbarThemeSafari.h:
  62086. * platform/win/ScrollbarThemeWin.cpp:
  62087. (WebCore::ScrollbarThemeWin::paintTrack):
  62088. * platform/win/ScrollbarThemeWin.h:
  62089. * rendering/RenderLayer.cpp:
  62090. (WebCore::RenderLayer::createScrollbar):
  62091. (WebCore::RenderLayer::styleChanged):
  62092. * rendering/RenderScrollbar.cpp: Added.
  62093. (WebCore::RenderScrollbar::createCustomScrollbar):
  62094. (WebCore::RenderScrollbar::RenderScrollbar):
  62095. (WebCore::RenderScrollbar::~RenderScrollbar):
  62096. (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
  62097. (WebCore::RenderScrollbar::updateScrollbarParts):
  62098. (WebCore::RenderScrollbar::updateScrollbarPart):
  62099. (WebCore::RenderScrollbar::paintPart):
  62100. (WebCore::RenderScrollbar::buttonRect):
  62101. (WebCore::RenderScrollbar::minimumThumbLength):
  62102. * rendering/RenderScrollbar.h: Added.
  62103. (WebCore::RenderScrollbar::styleChanged):
  62104. (WebCore::RenderScrollbar::owningRenderer):
  62105. * rendering/RenderScrollbarPart.cpp: Added.
  62106. (WebCore::RenderScrollbarPart::RenderScrollbarPart):
  62107. (WebCore::RenderScrollbarPart::~RenderScrollbarPart):
  62108. (WebCore::RenderScrollbarPart::layout):
  62109. (WebCore::RenderScrollbarPart::layoutHorizontalPart):
  62110. (WebCore::RenderScrollbarPart::layoutVerticalPart):
  62111. (WebCore::calcScrollbarThicknessUsing):
  62112. (WebCore::RenderScrollbarPart::computeScrollbarWidth):
  62113. (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  62114. (WebCore::RenderScrollbarPart::calcPrefWidths):
  62115. (WebCore::RenderScrollbarPart::setStyle):
  62116. * rendering/RenderScrollbarPart.h: Added.
  62117. (WebCore::RenderScrollbarPart::renderName):
  62118. (WebCore::RenderScrollbarPart::requiresLayer):
  62119. * rendering/RenderScrollbarTheme.cpp: Added.
  62120. (WebCore::RenderScrollbarTheme::renderScrollbarTheme):
  62121. (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
  62122. (WebCore::RenderScrollbarTheme::hasButtons):
  62123. (WebCore::RenderScrollbarTheme::hasThumb):
  62124. (WebCore::RenderScrollbarTheme::minimumThumbLength):
  62125. (WebCore::RenderScrollbarTheme::backButtonRect):
  62126. (WebCore::RenderScrollbarTheme::forwardButtonRect):
  62127. (WebCore::RenderScrollbarTheme::trackRect):
  62128. (WebCore::RenderScrollbarTheme::paintScrollCorner):
  62129. (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
  62130. (WebCore::RenderScrollbarTheme::paintTrackBackground):
  62131. (WebCore::RenderScrollbarTheme::paintTrackPiece):
  62132. (WebCore::RenderScrollbarTheme::paintButton):
  62133. (WebCore::RenderScrollbarTheme::paintThumb):
  62134. * rendering/RenderScrollbarTheme.h: Added.
  62135. (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme):
  62136. (WebCore::RenderScrollbarTheme::scrollbarThickness):
  62137. (WebCore::RenderScrollbarTheme::buttonsPlacement):
  62138. (WebCore::RenderScrollbarTheme::supportsControlTints):
  62139. (WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
  62140. (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
  62141. (WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
  62142. (WebCore::RenderScrollbarTheme::registerScrollbar):
  62143. (WebCore::RenderScrollbarTheme::unregisterScrollbar):
  62144. * rendering/style/RenderStyle.h:
  62145. (WebCore::RenderStyle::):
  62146. 2008-10-09 Eric Seidel <eric@webkit.org>
  62147. Reviewed by Oliver Hunt.
  62148. Fix Canvex DOOM Game
  62149. Gradient clips were not getting cleared after filling the
  62150. gradient, this was causing nothing to draw in Canvex
  62151. https://bugs.webkit.org/show_bug.cgi?id=21498
  62152. Tests forthcoming.
  62153. * WebCore.xcodeproj/project.pbxproj:
  62154. * platform/graphics/cg/GraphicsContextCG.cpp:
  62155. (WebCore::GraphicsContext::fillPath):
  62156. (WebCore::GraphicsContext::strokePath):
  62157. (WebCore::GraphicsContext::fillRect):
  62158. 2008-10-09 Eric Seidel <eric@webkit.org>
  62159. Reviewed by Oliver Hunt.
  62160. Fix transformed patterns
  62161. https://bugs.webkit.org/show_bug.cgi?id=21498
  62162. Test: fast/canvas/patternfill-repeat.html
  62163. * WebCore.xcodeproj/project.pbxproj:
  62164. * platform/graphics/GraphicsContext.cpp:
  62165. (WebCore::GraphicsContext::setStrokePattern):
  62166. (WebCore::GraphicsContext::setFillPattern):
  62167. (WebCore::GraphicsContext::setStrokeGradient):
  62168. (WebCore::GraphicsContext::setFillGradient):
  62169. * platform/graphics/GraphicsContext.h:
  62170. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  62171. * platform/graphics/cg/GraphicsContextCG.cpp:
  62172. (WebCore::applyStrokePattern):
  62173. (WebCore::applyFillPattern):
  62174. (WebCore::GraphicsContext::drawPath):
  62175. (WebCore::GraphicsContext::fillPath):
  62176. (WebCore::GraphicsContext::strokePath):
  62177. (WebCore::GraphicsContext::fillRect):
  62178. * platform/graphics/qt/GraphicsContextQt.cpp:
  62179. * platform/graphics/wx/GraphicsContextWx.cpp:
  62180. 2008-10-09 Kevin Ollivier <kevino@theolliviers.com>
  62181. wx build fixes.
  62182. * platform/wx/WidgetWx.cpp:
  62183. * plugins/wx/PluginViewWx.cpp:
  62184. (WebCore::PluginView::invalidateRect):
  62185. * webcore-base.bkl:
  62186. 2008-10-09 Chris Marrin <cmarrin@apple.com>
  62187. Reviewed by Darin Adler.
  62188. Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
  62189. Animations assert when navigating from page
  62190. Changed assertions to test the right flag for the paused state
  62191. * page/animation/AnimationBase.cpp:
  62192. (WebCore::AnimationBase::updateStateMachine):
  62193. 2008-10-09 Chris Marrin <cmarrin@apple.com>
  62194. Reviewed by Dan Bernstein.
  62195. Fixed > 180 degree rotation bug
  62196. Ensure that validateTransformFunctionList() is called after updating keyframe styles
  62197. https://bugs.webkit.org/show_bug.cgi?id=21420
  62198. Test: animations/big-rotation.html
  62199. * page/animation/KeyframeAnimation.cpp:
  62200. (WebCore::KeyframeAnimation::KeyframeAnimation):
  62201. 2008-10-09 Brady Eidson <beidson@apple.com>
  62202. Reviewed by Anders
  62203. <rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things
  62204. The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.
  62205. * loader/FrameLoader.cpp:
  62206. (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion
  62207. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page,
  62208. so perform a second null check on the page. Bail if it has been cleared.
  62209. 2008-10-09 Alp Toker <alp@nuanti.com>
  62210. Build fix for recent DOM generation Makefile changes when custom
  62211. CFLAGS/CXXFLAGS are passed in.
  62212. * GNUmakefile.am:
  62213. 2008-10-09 Jan Michael Alonzo <jmalonzo@webkit.org>
  62214. Reviewed by Alp Toker.
  62215. https://bugs.webkit.org/show_bug.cgi?id=21390
  62216. [Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)
  62217. * platform/gtk/ScrollViewGtk.cpp:
  62218. (WebCore::ScrollView::platformRemoveChild):
  62219. 2008-10-09 Darin Adler <darin@apple.com>
  62220. - try to fix Qt build
  62221. * bridge/qt/qt_runtime.cpp:
  62222. (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.
  62223. 2008-10-08 Nikolas Zimmermann <zimmermann@kde.org>
  62224. Reviewed by Oliver Hunt & Sam Weinig.
  62225. Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
  62226. Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
  62227. Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)
  62228. Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
  62229. Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
  62230. use tree is rebuild.
  62231. Make SVGElementInstance a real EventTarget, as the SVG specification demands.
  62232. When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
  62233. is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
  62234. share an event listener list. Every event listener change on the SVGElementInstance object is forwared
  62235. to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
  62236. Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
  62237. to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
  62238. Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.
  62239. Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
  62240. see resources/use-instanceRoot-event-bubbling.js for details.
  62241. Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)
  62242. svg/custom/use-elementInstance-methods.svg (reenabled)
  62243. svg/custom/use-setAttribute-crash.svg (covers bug 20550)
  62244. svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
  62245. svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
  62246. svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)
  62247. * DerivedSources.make:
  62248. * GNUmakefile.am:
  62249. * WebCore.pro:
  62250. * WebCore.vcproj/WebCore.vcproj:
  62251. * WebCore.xcodeproj/project.pbxproj:
  62252. * bindings/js/JSEventListener.h:
  62253. (WebCore::JSLazyEventListener::wasCreatedFromMarkup):
  62254. * bindings/js/JSEventTarget.cpp:
  62255. * bindings/js/JSEventTargetSVGElementInstance.cpp: Removed.
  62256. * bindings/js/JSEventTargetSVGElementInstance.h: Removed.
  62257. * bindings/js/JSSVGElementInstanceCustom.cpp:
  62258. (WebCore::JSSVGElementInstance::addEventListener):
  62259. (WebCore::JSSVGElementInstance::removeEventListener):
  62260. (WebCore::JSSVGElementInstance::pushEventHandlerScope):
  62261. * bindings/scripts/CodeGeneratorJS.pm:
  62262. * bindings/scripts/CodeGeneratorObjC.pm:
  62263. * dom/EventListener.h:
  62264. (WebCore::EventListener::wasCreatedFromMarkup):
  62265. * dom/EventTargetNode.cpp:
  62266. (WebCore::updateSVGElementInstancesAfterEventListenerChange):
  62267. (WebCore::EventTargetNode::addEventListener):
  62268. (WebCore::EventTargetNode::removeEventListener):
  62269. (WebCore::eventTargetAsSVGElementInstance):
  62270. (WebCore::eventTargetRespectingSVGTargetRules):
  62271. (WebCore::EventTargetNode::dispatchEvent):
  62272. (WebCore::EventTargetNode::dispatchGenericEvent):
  62273. (WebCore::EventTargetNode::removeEventListenerForType):
  62274. * page/EventHandler.cpp:
  62275. (WebCore::EventHandler::clear):
  62276. (WebCore::instanceAssociatedWithShadowTreeElement):
  62277. (WebCore::EventHandler::updateMouseEventTargetNode):
  62278. * page/EventHandler.h:
  62279. * svg/EventTargetSVGElementInstance.cpp: Removed.
  62280. * svg/EventTargetSVGElementInstance.h: Removed.
  62281. * svg/SVGElementInstance.cpp:
  62282. (WebCore::SVGElementInstance::SVGElementInstance):
  62283. (WebCore::SVGElementInstance::~SVGElementInstance):
  62284. (WebCore::SVGElementInstance::childNodes):
  62285. (WebCore::SVGElementInstance::setShadowTreeElement):
  62286. (WebCore::SVGElementInstance::forgetWrapper):
  62287. (WebCore::SVGElementInstance::appendChild):
  62288. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  62289. (WebCore::SVGElementInstance::setNeedsUpdate):
  62290. (WebCore::SVGElementInstance::associatedFrame):
  62291. (WebCore::SVGElementInstance::addEventListener):
  62292. (WebCore::SVGElementInstance::removeEventListener):
  62293. (WebCore::SVGElementInstance::dispatchEvent):
  62294. (WebCore::SVGElementInstance::onabort):
  62295. (WebCore::SVGElementInstance::setOnabort):
  62296. (WebCore::SVGElementInstance::onblur):
  62297. (WebCore::SVGElementInstance::setOnblur):
  62298. (WebCore::SVGElementInstance::onchange):
  62299. (WebCore::SVGElementInstance::setOnchange):
  62300. (WebCore::SVGElementInstance::onclick):
  62301. (WebCore::SVGElementInstance::setOnclick):
  62302. (WebCore::SVGElementInstance::oncontextmenu):
  62303. (WebCore::SVGElementInstance::setOncontextmenu):
  62304. (WebCore::SVGElementInstance::ondblclick):
  62305. (WebCore::SVGElementInstance::setOndblclick):
  62306. (WebCore::SVGElementInstance::onerror):
  62307. (WebCore::SVGElementInstance::setOnerror):
  62308. (WebCore::SVGElementInstance::onfocus):
  62309. (WebCore::SVGElementInstance::setOnfocus):
  62310. (WebCore::SVGElementInstance::oninput):
  62311. (WebCore::SVGElementInstance::setOninput):
  62312. (WebCore::SVGElementInstance::onkeydown):
  62313. (WebCore::SVGElementInstance::setOnkeydown):
  62314. (WebCore::SVGElementInstance::onkeypress):
  62315. (WebCore::SVGElementInstance::setOnkeypress):
  62316. (WebCore::SVGElementInstance::onkeyup):
  62317. (WebCore::SVGElementInstance::setOnkeyup):
  62318. (WebCore::SVGElementInstance::onload):
  62319. (WebCore::SVGElementInstance::setOnload):
  62320. (WebCore::SVGElementInstance::onmousedown):
  62321. (WebCore::SVGElementInstance::setOnmousedown):
  62322. (WebCore::SVGElementInstance::onmousemove):
  62323. (WebCore::SVGElementInstance::setOnmousemove):
  62324. (WebCore::SVGElementInstance::onmouseout):
  62325. (WebCore::SVGElementInstance::setOnmouseout):
  62326. (WebCore::SVGElementInstance::onmouseover):
  62327. (WebCore::SVGElementInstance::setOnmouseover):
  62328. (WebCore::SVGElementInstance::onmouseup):
  62329. (WebCore::SVGElementInstance::setOnmouseup):
  62330. (WebCore::SVGElementInstance::onmousewheel):
  62331. (WebCore::SVGElementInstance::setOnmousewheel):
  62332. (WebCore::SVGElementInstance::onbeforecut):
  62333. (WebCore::SVGElementInstance::setOnbeforecut):
  62334. (WebCore::SVGElementInstance::oncut):
  62335. (WebCore::SVGElementInstance::setOncut):
  62336. (WebCore::SVGElementInstance::onbeforecopy):
  62337. (WebCore::SVGElementInstance::setOnbeforecopy):
  62338. (WebCore::SVGElementInstance::oncopy):
  62339. (WebCore::SVGElementInstance::setOncopy):
  62340. (WebCore::SVGElementInstance::onbeforepaste):
  62341. (WebCore::SVGElementInstance::setOnbeforepaste):
  62342. (WebCore::SVGElementInstance::onpaste):
  62343. (WebCore::SVGElementInstance::setOnpaste):
  62344. (WebCore::SVGElementInstance::ondragenter):
  62345. (WebCore::SVGElementInstance::setOndragenter):
  62346. (WebCore::SVGElementInstance::ondragover):
  62347. (WebCore::SVGElementInstance::setOndragover):
  62348. (WebCore::SVGElementInstance::ondragleave):
  62349. (WebCore::SVGElementInstance::setOndragleave):
  62350. (WebCore::SVGElementInstance::ondrop):
  62351. (WebCore::SVGElementInstance::setOndrop):
  62352. (WebCore::SVGElementInstance::ondragstart):
  62353. (WebCore::SVGElementInstance::setOndragstart):
  62354. (WebCore::SVGElementInstance::ondrag):
  62355. (WebCore::SVGElementInstance::setOndrag):
  62356. (WebCore::SVGElementInstance::ondragend):
  62357. (WebCore::SVGElementInstance::setOndragend):
  62358. (WebCore::SVGElementInstance::onreset):
  62359. (WebCore::SVGElementInstance::setOnreset):
  62360. (WebCore::SVGElementInstance::onresize):
  62361. (WebCore::SVGElementInstance::setOnresize):
  62362. (WebCore::SVGElementInstance::onscroll):
  62363. (WebCore::SVGElementInstance::setOnscroll):
  62364. (WebCore::SVGElementInstance::onsearch):
  62365. (WebCore::SVGElementInstance::setOnsearch):
  62366. (WebCore::SVGElementInstance::onselect):
  62367. (WebCore::SVGElementInstance::setOnselect):
  62368. (WebCore::SVGElementInstance::onselectstart):
  62369. (WebCore::SVGElementInstance::setOnselectstart):
  62370. (WebCore::SVGElementInstance::onsubmit):
  62371. (WebCore::SVGElementInstance::setOnsubmit):
  62372. (WebCore::SVGElementInstance::onunload):
  62373. (WebCore::SVGElementInstance::setOnunload):
  62374. * svg/SVGElementInstance.h:
  62375. (WebCore::SVGElementInstance::needsUpdate):
  62376. (WebCore::SVGElementInstance::toNode):
  62377. (WebCore::SVGElementInstance::toSVGElementInstance):
  62378. (WebCore::SVGElementInstance::correspondingElement):
  62379. (WebCore::SVGElementInstance::correspondingUseElement):
  62380. (WebCore::SVGElementInstance::shadowTreeElement):
  62381. (WebCore::SVGElementInstance::parentNode):
  62382. (WebCore::SVGElementInstance::previousSibling):
  62383. (WebCore::SVGElementInstance::nextSibling):
  62384. (WebCore::SVGElementInstance::firstChild):
  62385. (WebCore::SVGElementInstance::lastChild):
  62386. (WebCore::SVGElementInstance::ownerDocument):
  62387. (WebCore::SVGElementInstance::hasChildNodes):
  62388. (WebCore::SVGElementInstance::setFirstChild):
  62389. (WebCore::SVGElementInstance::setLastChild):
  62390. (WebCore::SVGElementInstance::setNextSibling):
  62391. (WebCore::SVGElementInstance::setPreviousSibling):
  62392. (WebCore::SVGElementInstance::refEventTarget):
  62393. (WebCore::SVGElementInstance::derefEventTarget):
  62394. * svg/SVGElementInstance.idl:
  62395. * svg/SVGStyledElement.cpp:
  62396. (WebCore::SVGStyledElement::svgAttributeChanged):
  62397. (WebCore::SVGStyledElement::childrenChanged):
  62398. * svg/SVGUseElement.cpp:
  62399. (WebCore::SVGUseElement::svgAttributeChanged):
  62400. (WebCore::shadowTreeContainsChangedNodes):
  62401. (WebCore::SVGUseElement::recalcStyle):
  62402. (WebCore::dumpInstanceTree):
  62403. (WebCore::SVGUseElement::buildPendingResource):
  62404. (WebCore::SVGUseElement::buildInstanceTree):
  62405. (WebCore::SVGUseElement::transferEventListenersToShadowTree):
  62406. * svg/SVGUseElement.h:
  62407. 2008-10-08 Sam Weinig <sam@webkit.org>
  62408. Reviewed by Cameron Zwarich.
  62409. Fix for https://bugs.webkit.org/show_bug.cgi?id=21241
  62410. REGRESSION (r36977): getRGBColorValue().red returning incorrect value
  62411. Update JSRGBColor to use the new static function per getter approach.
  62412. Test: fast/dom/css-RGBValue.html
  62413. * bindings/js/JSRGBColor.cpp:
  62414. (WebCore::):
  62415. (jsRGBColorRed):
  62416. (jsRGBColorGreen):
  62417. (jsRGBColorBlue):
  62418. * bindings/js/JSRGBColor.h:
  62419. 2008-10-08 Eric Seidel <eric@webkit.org>
  62420. Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.
  62421. svgElement.className.baseValue = "foo" does not work
  62422. https://bugs.webkit.org/show_bug.cgi?id=20651
  62423. * dom/StyledElement.cpp:
  62424. (WebCore::StyledElement::classAttributeChanged):
  62425. (WebCore::StyledElement::parseMappedAttribute):
  62426. * dom/StyledElement.h:
  62427. * svg/SVGStyledElement.cpp:
  62428. (WebCore::SVGStyledElement::svgAttributeChanged):
  62429. 2008-10-08 Anthony Ricaud <rik24d@gmail.com>
  62430. Make the toolbar label text-shadow not disappear when clicking on the
  62431. search result count or around the search field.
  62432. Reviewed by Timothy Hatcher.
  62433. * inspector/front-end/inspector.css:
  62434. (.toolbar-item:active .toolbar-label): Make this rule also require the
  62435. toggleable class with the toolbar-item class.
  62436. 2008-10-08 Tor Arne Vestbø <tavestbo@trolltech.com>
  62437. Reviewed by Simon.
  62438. Updated the qrc file for the Web Inspector to contain the current set
  62439. of images.
  62440. * inspector/front-end/WebKit.qrc:
  62441. 2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
  62442. Reviewed by Simon.
  62443. Fix the linking of applications against WebKit on Qt/Windows.
  62444. The prl files that qmake creates are buggy on Unix, but we they're
  62445. fine on Windows and we have to have them there in order to get the
  62446. dependencies correct.
  62447. * WebCore.pro:
  62448. 2008-10-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
  62449. Reviewed by Simon.
  62450. Speed up rectangle filling by not re-creating a QBrush all the time.
  62451. This triggers faster path in QPainter where the brush is reused.
  62452. * platform/graphics/qt/GraphicsContextQt.cpp:
  62453. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  62454. (WebCore::GraphicsContext::fillRect):
  62455. 2008-10-08 Thiago Macieira <thiago.macieira@nokia.com>
  62456. Reviewed by Simon.
  62457. Fixes: Encoding of Qt URLs
  62458. This encoding was added by Simon and I because QUrl's
  62459. tolerant parser wasn't tolerant enough. Now it is, so we don't need
  62460. this anymore.
  62461. * platform/qt/KURLQt.cpp:
  62462. (WebCore::KURL::operator QUrl):
  62463. 2008-10-08 Marius Storm-Olsen <marius@trolltech.com>
  62464. Reviewed by Simon.
  62465. Fixes dependencies in qmake generated visual studio projects.
  62466. Only add debug lib name if we're in the debug build_pass, else the release version.
  62467. The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.
  62468. * WebCore.pro:
  62469. 2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
  62470. Reviewed by Simon.
  62471. Fix compilation errors on VS2008 64Bit
  62472. * platform/text/TextStream.cpp:
  62473. (WebCore::TextStream::operator<<):
  62474. * platform/text/TextStream.h:
  62475. * plugins/win/PluginViewWin.cpp:
  62476. (WebCore::PluginView::init):
  62477. 2008-10-07 Alp Toker <alp@nuanti.com>
  62478. GTK+ build fix for older automake versions (1.7). Discussed in bug
  62479. #21392.
  62480. * GNUmakefile.am:
  62481. 2008-10-07 Anders Carlsson <andersca@apple.com>
  62482. Reviewed by Antti Koivisto.
  62483. <rdar://problem/6273887> Crash in ApplicationCacheGroup
  62484. Make sure to stop loading even before a cache update is in progress so that the
  62485. manifest load will be stopped.
  62486. * loader/appcache/ApplicationCacheGroup.cpp:
  62487. (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
  62488. (WebCore::ApplicationCacheGroup::stopLoading):
  62489. (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
  62490. 2008-10-07 Timothy Hatcher <timothy@apple.com>
  62491. Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.
  62492. https://bugs.webkit.org/show_bug.cgi?id=21433
  62493. Reviewed by Sam Weinig.
  62494. * WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
  62495. * bindings/objc/DOM.mm: Remove previous category implementations
  62496. on DOMDocument for createNodeIterator: and createTreeWalker:. Also
  62497. moves ObjCNodeFilterCondition to its own file.
  62498. * bindings/objc/DOMTraversal.h: Remove the category methods that added
  62499. createNodeIterator: and createTreeWalker: to DOMDocument. This is fine
  62500. to do since DOmDocument.h is included still, and has these methods.
  62501. * bindings/objc/DOMUtility.mm:
  62502. (JSC::createDOMWrapper): Remove special case for JSNodeIterator and
  62503. JSTreeWalker now that the ObjC binding conforms to the standard wrap.
  62504. * bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm.
  62505. (WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm.
  62506. (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
  62507. * bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm.
  62508. (WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
  62509. * bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and
  62510. createTreeWalker: methods to DOMDocument.
  62511. * bindings/scripts/CodeGeneratorObjC.pm:
  62512. (GetObjCTypeGetter): Add a case for NodeFilter.
  62513. (AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter.
  62514. (GenerateImplementation): Remove existing NodeFilter special case that
  62515. used the m_filter member variable. Add a new special getter for protocol
  62516. types that aren't EventTarget, so the right class is used for NodeFilter.
  62517. Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
  62518. * dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the
  62519. OldStyleObjC extended attribute to createNodeIterator and createTreeWalker.
  62520. Rename the entityReferenceExpansion parameter to expandEntityReferences to
  62521. match the previous ObjC API.
  62522. * dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The
  62523. m_filter member variable was never used in practice, it was always nil!
  62524. We can remove it and not pad the object because this can't be subclassed.
  62525. * dom/TreeWalker.idl: Ditto.
  62526. 2008-10-07 Timothy Hatcher <timothy@apple.com>
  62527. Auto-generate the DOMEventTarget protocol implementation for
  62528. DOMNode and DOMSVGElementInstance.
  62529. https://bugs.webkit.org/show_bug.cgi?id=21432
  62530. Reviewed by Darin Adler.
  62531. * WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
  62532. * bindings/objc/DOM.mm: Remove many unneeded header includes. Move
  62533. ObjCEventListener to it's own file. Remove the manual impelmentations
  62534. of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
  62535. * bindings/objc/DOMEvents.h: Remove the categories that defined
  62536. DOMEventTarget for DOMNode and DOMSVGElementInstance.
  62537. * bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
  62538. * bindings/objc/ObjCEventListener.mm: Split out from DOM.mm.
  62539. (WebCore::ObjCEventListener::find): Moved from DOM.mm.
  62540. (WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the
  62541. callers from doing a manual deref.
  62542. (WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm.
  62543. (WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
  62544. * bindings/scripts/CodeGeneratorObjC.pm:
  62545. (GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr.
  62546. (AddIncludesForType): Include ObjCEventListener.h for EventListener.
  62547. And include EventTargetSVGElementInstance.h for SVGElementInstance.
  62548. (GenerateHeader): Remove the check for multiple parents.
  62549. (GenerateImplementation): Remove the check for multiple parents. Remove
  62550. the @deprecatedFunctions array since deprecated methods get generated
  62551. into the main @interface now to work with protocols. Add support
  62552. for the EventTargetNodeCast extended attribute. Add support for
  62553. EventListener parameters.
  62554. * dom/Node.idl: Define superclasses for ObjC so the implementation
  62555. and interface implement the DOMEventTarget protocol. Explicitly
  62556. specify Object as a superclass to use DOMEventTarget. Object will turn
  62557. into DOMObject. This is needed to take the code generator down the right
  62558. path of multiple super-classes as protocols. It is ObjC only for legacy
  62559. reasons. The event target methods are normally on NodeEventTarget, a
  62560. subclass of Node. But the ObjC API has never has this subclass and
  62561. they are on DOMNode.
  62562. * svg/SVGElementInstance.idl: Ditto.
  62563. 2008-10-07 David Hyatt <hyatt@apple.com>
  62564. Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.
  62565. The new pseudo-elements are:
  62566. scrollbar
  62567. scrollbar-button
  62568. scrollbar-corner
  62569. scrollbar-thumb
  62570. scrollbar-track
  62571. These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
  62572. the following new pseudo-classes:
  62573. scrollbar-active
  62574. scrollbar-back
  62575. scrollbar-forward
  62576. scrollbar-horizontal
  62577. scrollbar-vertical
  62578. Reviewed by Adele
  62579. * css/CSSSelector.cpp:
  62580. (WebCore::CSSSelector::extractPseudoType):
  62581. * css/CSSSelector.h:
  62582. (WebCore::CSSSelector::):
  62583. 2008-10-06 Timothy Hatcher <timothy@apple.com>
  62584. Add support to the Resources panel for queries like "#123", "foo #123",
  62585. "line: 123" and "foo line: 123". These will match the query limiting
  62586. the search only to the line specified. If only a line is specified,
  62587. the whole line is matched.
  62588. https://bugs.webkit.org/show_bug.cgi?id=21422
  62589. Reviewed by Darin Adler.
  62590. * inspector/front-end/SourceFrame.js:
  62591. (WebInspector.SourceFrame.prototype.sourceRow): Don't return the last
  62592. row if the index is greater than the rows collection. Let it return
  62593. undefined by indexing out-of-bounds.
  62594. * inspector/front-end/SourceView.js:
  62595. (WebInspector.SourceView.prototype.performSearch): Add support for
  62596. queries like "#123", "foo #123", "line: 123" and "foo line: 123".
  62597. Also match the whole query to the whole document in case there are
  62598. colors like "#333".
  62599. 2008-10-07 Alp Toker <alp@nuanti.com>
  62600. Reviewed by Mark Rowe.
  62601. https://bugs.webkit.org/show_bug.cgi?id=21392
  62602. [GTK] Auto-generate JS DOM binding sources list
  62603. Remove the huge lists of generated DOM binding sources and headers in
  62604. the build system. These are difficult to maintain and can be derived
  62605. automatically.
  62606. The new strategy is to re-use the existing lists of IDL sources (which
  62607. are needed for dist support anyway). This will also ease the addition
  62608. of new language bindings.
  62609. * GNUmakefile.am:
  62610. 2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>
  62611. Reviewed by Simon.
  62612. Don't attempt to paint when updating control tints
  62613. We don't have a valid PlatformGraphicsContext so schedule
  62614. the dirty scrollbar/scrollview area for repaint instead.
  62615. * platform/qt/ScrollbarThemeQt.cpp:
  62616. (WebCore::ScrollbarThemeQt::paint):
  62617. (WebCore::ScrollbarThemeQt::paintScrollCorner):
  62618. 2008-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
  62619. [qt] Build fix after Scrollbar.h and Widget.h changes.
  62620. * plugins/qt/PluginViewQt.cpp:
  62621. (WebCore::PluginView::getValue):
  62622. (WebCore::PluginView::init):
  62623. 2008-10-06 David Hyatt <hyatt@apple.com>
  62624. Enable viewless Mac WebKit to (kinda sorta) paint basic pages (with no frames on them).
  62625. Reviewed by Sam Weinig
  62626. * WebCore.base.exp:
  62627. * WebCore.xcodeproj/project.pbxproj:
  62628. * loader/EmptyClients.h:
  62629. (WebCore::EmptyFrameLoaderClient::hasWebView):
  62630. * loader/FrameLoader.cpp:
  62631. (WebCore::FrameLoader::loadWithDocumentLoader):
  62632. (WebCore::FrameLoader::transitionToCommitted):
  62633. * loader/FrameLoaderClient.h:
  62634. * page/FocusController.cpp:
  62635. (WebCore::FocusController::setActive):
  62636. * page/FrameView.cpp:
  62637. (WebCore::FrameView::FrameView):
  62638. (WebCore::FrameView::init):
  62639. (WebCore::FrameView::layoutIfNeededRecursive):
  62640. * page/FrameView.h:
  62641. 2008-10-06 Dan Bernstein <mitz@apple.com>
  62642. - build fix
  62643. * bindings/objc/DOMEvents.h:
  62644. 2008-10-06 Mark Mentovai <mark@moxienet.com>
  62645. Reviewed by Tim Hatcher.
  62646. Use #if ENABLE(feature) where possible, and #if ENABLE_feature where
  62647. Platform.h is not available, in preference to #ifdef ENABLE_feature.
  62648. #ifdef is wrong now that features are disabled by #defining
  62649. ENABLE_feature to 0.
  62650. https://bugs.webkit.org/show_bug.cgi?id=21338
  62651. * bindings/objc/DOMEvents.h:
  62652. * bindings/objc/PublicDOMInterfaces.h:
  62653. * dom/Document.idl:
  62654. * page/DOMWindow.idl:
  62655. * svg/svgtags.in:
  62656. 2008-10-06 Mark Mentovai <mark@moxienet.com>
  62657. Reviewed by Sam Weinig.
  62658. * platform/network/mac/FormDataStreamMac.mm: #import <wtf/Threading.h>
  62659. to get the declaration for isMainThread().
  62660. 2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
  62661. Reviewed by Tim Hatcher.
  62662. WebCoreObjCExtras.c is actually an obj-c++ file, so change its name
  62663. to reflect that.
  62664. * WebCore.xcodeproj/project.pbxproj:
  62665. * platform/mac/WebCoreObjCExtras.c: Removed.
  62666. * platform/mac/WebCoreObjCExtras.mm: Copied from WebCore/platform/mac/WebCoreObjCExtras.c.
  62667. 2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
  62668. Reviewed by Dan Bernstein.
  62669. Added C++ forward declaration for the NSURLAuthenticationChallenge class
  62670. so that the m_currentMacChallenge variable doesn't cause a
  62671. compilation error when ResourceHandleInternal.h is included from a C++ file.
  62672. Fixes: https://bugs.webkit.org/show_bug.cgi?id=21411
  62673. * platform/network/ResourceHandleInternal.h:
  62674. 2008-10-06 Steve Falkenburg <sfalken@apple.com>
  62675. Windows build fix.
  62676. * WebCore.vcproj/WebCore.vcproj:
  62677. 2008-10-06 Steve Falkenburg <sfalken@apple.com>
  62678. https://bugs.webkit.org/show_bug.cgi?id=21416
  62679. Add missing null checks identified by Application Verifier.
  62680. Reviewed by Darin Adler.
  62681. * platform/win/SharedTimerWin.cpp:
  62682. (WebCore::clearTimer):
  62683. 2008-10-06 Kevin McCullough <kmccullough@apple.com>
  62684. Reviewed by Tim Hatcher.
  62685. Removed accidentally left in debugging statement.
  62686. * inspector/front-end/inspector.js:
  62687. 2008-10-06 Kevin McCullough <kmccullough@apple.com>
  62688. Reviewed by Tim Hatcher and Oliver Hunt.
  62689. https://bugs.webkit.org/show_bug.cgi?id=21412
  62690. Bug 21412: Refactor user initiated profile count to be more stable
  62691. * inspector/InspectorController.cpp: Keep track of the user-initiated
  62692. profiles here now.
  62693. (WebCore::InspectorController::InspectorController):
  62694. (WebCore::InspectorController::startUserInitiatedProfiling):
  62695. (WebCore::InspectorController::stopUserInitiatedProfiling):
  62696. * inspector/InspectorController.h:
  62697. The front end will now need to check for the existence of the user-
  62698. initiated profile title and use its count instead of keeping its own.
  62699. * inspector/front-end/ProfilesPanel.js:
  62700. 2008-10-06 Dan Bernstein <mitz@apple.com>
  62701. Reviewed by Sam Weinig.
  62702. - separate GDI text drawing into its own function
  62703. * platform/graphics/win/FontCGWin.cpp:
  62704. (WebCore::drawGDIGlyphs):
  62705. (WebCore::Font::drawGlyphs):
  62706. 2008-10-03 Steve Falkenburg <sfalken@apple.com>
  62707. <rdar://problem/6249833> Fix default button appearance
  62708. Reviewed by Adele Peterson.
  62709. * rendering/RenderThemeWin.cpp:
  62710. (WebCore::RenderThemeWin::supportsFocus):
  62711. (WebCore::RenderThemeWin::determineClassicState):
  62712. (WebCore::RenderThemeWin::determineButtonState):
  62713. (WebCore::RenderThemeWin::getClassicThemeData):
  62714. (WebCore::RenderThemeWin::getThemeData):
  62715. (WebCore::drawControl):
  62716. * rendering/RenderThemeWin.h:
  62717. 2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
  62718. Reviewed by Simon.
  62719. Add native virtual keycode to PlatformKeyboardEvent
  62720. * platform/PlatformKeyboardEvent.h:
  62721. * platform/gtk/KeyEventGtk.cpp:
  62722. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  62723. * platform/mac/KeyEventMac.mm:
  62724. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  62725. * platform/qt/PlatformKeyboardEventQt.cpp:
  62726. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  62727. * platform/win/KeyEventWin.cpp:
  62728. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  62729. * platform/wx/KeyboardEventWx.cpp:
  62730. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  62731. 2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
  62732. Reviewed by Simon.
  62733. Enable WebCore::String <> CFStringRef conversion functions for QtWebKit/Mac
  62734. * platform/text/PlatformString.h:
  62735. * platform/text/StringImpl.h:
  62736. * platform/text/cf/StringCF.cpp:
  62737. * platform/text/cf/StringImplCF.cpp:
  62738. 2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
  62739. Reviewed by Simon.
  62740. Use bundles on QtWebKit/Mac for platform modules
  62741. * platform/FileSystem.h:
  62742. * platform/qt/FileSystemQt.cpp:
  62743. (WebCore::unloadModule):
  62744. 2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
  62745. Reviewed by Simon.
  62746. Build fix for MinGW.
  62747. * platform/win/SystemTimeWin.cpp:
  62748. * plugins/win/PluginViewWin.cpp:
  62749. (WebCore::PluginView::invalidateRect):
  62750. 2008-10-06 Adam Roben <aroben@apple.com>
  62751. Mimic the inspector/ directory structure in WebCore.vcproj
  62752. * WebCore.vcproj/WebCore.vcproj:
  62753. 2008-10-06 Adam Roben <aroben@apple.com>
  62754. Windows build fix
  62755. * WebCore.vcproj/WebCore.vcproj: Update the Include path for all
  62756. configurations to include WebCore/inspector.
  62757. 2008-10-04 Eric Seidel <eric@webkit.org>
  62758. Reviewed by Darin Adler.
  62759. SVG should support ascent and descent properties <font-face> instead of <font>!
  62760. https://bugs.webkit.org/show_bug.cgi?id=21365
  62761. Tested by many many existing SVG tests.
  62762. * svg/SVGFontFaceElement.cpp:
  62763. (WebCore::SVGFontFaceElement::ascent):
  62764. (WebCore::SVGFontFaceElement::descent):
  62765. 2008-10-05 Darin Fisher <darin@chromium.org>
  62766. Reviewed by Eric Seidel.
  62767. REGRESSION: crash in ScriptElement::notifyFinished
  62768. Fixes https://bugs.webkit.org/show_bug.cgi?id=21329
  62769. * dom/ScriptElement.cpp:
  62770. (WebCore::ScriptElementData::notifyFinished): Revert part of r35744 to
  62771. ensure that the ScriptElementData object is not destroyed prematurely.
  62772. 2008-10-05 Chris Lord <chris@openedhand.com>
  62773. Reviewed by Alp Toker. Landed by Jan Alonzo.
  62774. https://bugs.webkit.org/show_bug.cgi?id=20624
  62775. WebKit-gtk uses deprecated GtkType/GtkObject
  62776. * plugins/gtk/gtk2xtbin.c:
  62777. (gtk_xtbin_get_type):
  62778. * plugins/gtk/gtk2xtbin.h:
  62779. 2008-10-05 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
  62780. Reviewed by David Hyatt.
  62781. GTK_WINDOW_HWND not GTK_WINDOWING_HWND
  62782. https://bugs.webkit.org/show_bug.cgi?id=20725
  62783. Updated to ToT by Jan Alonzo.
  62784. * plugins/gtk/PluginViewGtk.cpp:
  62785. (WebCore::PluginView::getValue):
  62786. 2008-10-05 Jan Michael Alonzo <jmalonzo@webkit.org>
  62787. Reviewed by Darin Adler.
  62788. Invalid cast from GdkWindow to GtkWidget
  62789. https://bugs.webkit.org/show_bug.cgi?id=21391
  62790. Fix a misplaced closing parenthesis to actually cast the widget, not the window
  62791. * platform/gtk/PlatformScreenGtk.cpp:
  62792. (WebCore::screenDepth):
  62793. 2008-10-05 Adam Barth <abarth@webkit.org>
  62794. Reviewed by Darin Alder.
  62795. Attach the Origin header to POST requests to help defend against
  62796. cross-site request forgery.
  62797. https://bugs.webkit.org/show_bug.cgi?id=20792
  62798. Collin Jackson <collinj@webkit.org> also contributed to this patch.
  62799. Tests: http/tests/security/originHeader/origin-header-for-data.html
  62800. http/tests/security/originHeader/origin-header-for-empty.html
  62801. http/tests/security/originHeader/origin-header-for-get.html
  62802. http/tests/security/originHeader/origin-header-for-https.html
  62803. http/tests/security/originHeader/origin-header-for-post.html
  62804. * bindings/js/JSDOMWindowBase.cpp:
  62805. (WebCore::createWindow):
  62806. * loader/FrameLoader.cpp:
  62807. (WebCore::FrameLoader::createWindow):
  62808. (WebCore::FrameLoader::urlSelected):
  62809. (WebCore::FrameLoader::submitForm):
  62810. (WebCore::FrameLoader::outgoingOrigin):
  62811. (WebCore::FrameLoader::loadURL):
  62812. (WebCore::FrameLoader::addExtraFieldsToRequest):
  62813. (WebCore::FrameLoader::loadPostRequest):
  62814. (WebCore::FrameLoader::loadResourceSynchronously):
  62815. (WebCore::FrameLoader::loadItem):
  62816. * loader/FrameLoader.h:
  62817. * loader/SubresourceLoader.cpp:
  62818. (WebCore::SubresourceLoader::create):
  62819. * loader/loader.cpp:
  62820. (WebCore::Loader::Host::servePendingRequests):
  62821. * platform/SecurityOrigin.cpp:
  62822. (WebCore::SecurityOrigin::toHTTPOrigin):
  62823. * platform/SecurityOrigin.h:
  62824. * platform/network/ResourceRequestBase.h:
  62825. (WebCore::ResourceRequestBase::httpOrigin):
  62826. (WebCore::ResourceRequestBase::setHTTPOrigin):
  62827. (WebCore::ResourceRequestBase::clearHTTPOrigin):
  62828. * xml/XMLHttpRequest.cpp:
  62829. (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
  62830. (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
  62831. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
  62832. (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  62833. 2008-10-04 Oliver Hunt <oliver@apple.com>
  62834. Reviewed by Tim Hatcher.
  62835. Bug 21381: Incremental parsing of html causes bogus line numbers in some cases
  62836. <https://bugs.webkit.org/show_bug.cgi?id=21381>
  62837. If we hit a parsing boundary (end of a packet, etc) in the middle of a
  62838. <script> element when we are doing an incremental parse, we exit the
  62839. parser, and reenter later when more data is available. During this
  62840. reentry we incorrectly reset the scriptStartLineno to the current line
  62841. in the parser, which is now part way through the script element.
  62842. The solution is to track whether we are entering or reentering the parsing
  62843. of a script element. We do this simply by 0 checking scriptStartLineno,
  62844. and resetting it after we complete parsing of each script element.
  62845. Test: http/tests/incremental/pause-in-script-element.pl
  62846. * ChangeLog:
  62847. * html/HTMLTokenizer.cpp:
  62848. (WebCore::HTMLTokenizer::parseSpecial):
  62849. (WebCore::HTMLTokenizer::scriptHandler):
  62850. 2008-10-04 Alp Toker <alp@nuanti.com>
  62851. Reviewed by David Hyatt. Landed by Jan Alonzo.
  62852. https://bugs.webkit.org/show_bug.cgi?id=20924
  62853. [Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3
  62854. https://bugs.webkit.org/show_bug.cgi?id=19578
  62855. [CURL] problem in parseDataUrl
  62856. De-obfuscate parseDataUrl() and fix regressions introduced in r35954.
  62857. This patch also fixes encoding support in escaped (non-Base64) data
  62858. URLs. All manual data URL tests now pass in both GLib and non-GLib
  62859. code paths.
  62860. * platform/network/curl/ResourceHandleManager.cpp:
  62861. (WebCore::parseDataUrl):
  62862. 2008-10-04 Timothy Hatcher <timothy@apple.com>
  62863. Makes breakpoints and debugging code during page load work in the
  62864. Web Inspector's debugger. Specifically, this makes the source
  62865. code for loading resources show up in the Scripts panel.
  62866. https://bugs.webkit.org/show_bug.cgi?id=19053
  62867. rdar://problem/5933408
  62868. Reviewed by Mark Rowe.
  62869. * WebCore.xcodeproj/project.pbxproj: Mark the inspector group as
  62870. not using tabs and a tab width of 8.
  62871. * inspector/InspectorController.cpp:
  62872. (WebCore::addResourceSourceToFrame): Return a bool to report if the
  62873. source was added successfully or not.
  62874. (WebCore::addSourceToFrame): Ditto.
  62875. * inspector/front-end/ScriptView.js:
  62876. (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
  62877. Return early if the InspectorController.addSourceToFrame fails.
  62878. Moved the delete of the _frameNeedsSetup property after that call so
  62879. if the source wasn't added it will be attempted again.
  62880. * inspector/front-end/SourceView.js:
  62881. (WebInspector.SourceView.prototype.detach): Move a comment.
  62882. (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
  62883. Don't check if the resource is finished or failed, just attempt
  62884. to add the source to the frame. WebCore has the source, but the
  62885. finished property hasn't been set yet. Return early if the
  62886. InspectorController.addSourceToFrame fails. Moved the delete
  62887. of the _frameNeedsSetup property after that call so if the source
  62888. wasn't added it will be attempted again.
  62889. (WebInspector.SourceView.prototype._resourceLoadingFinished):
  62890. Clear the _frameNeedsSetup and _sourceFrameSetup properties so
  62891. the source frame will we populated again now that the resource
  62892. load has finished.
  62893. * manual-tests/inspector/debugger-pause-during-load.html: Added.
  62894. 2008-10-04 Mark Rowe <mrowe@apple.com>
  62895. Reviewed by Tim Hatcher.
  62896. Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
  62897. * WebCore.xcodeproj/project.pbxproj:
  62898. 2008-10-04 David Hyatt <hyatt@apple.com>
  62899. https://bugs.webkit.org/show_bug.cgi?id=21373
  62900. Tear down scrollbars in FrameView rather than ScrollView so that the connection to the hostWindow()
  62901. is still present.
  62902. Reviewed by Mark Rowe
  62903. * page/FrameView.cpp:
  62904. (WebCore::FrameView::~FrameView):
  62905. 2008-10-04 Sam Weinig <sam@webkit.org>
  62906. Reviewed by Dan Bernstein.
  62907. Avoid copying a Vector when using getSupportedKeySizes.
  62908. * html/HTMLKeygenElement.cpp:
  62909. (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  62910. * platform/SSLKeyGenerator.h:
  62911. * platform/gtk/TemporaryLinkStubs.cpp:
  62912. (WebCore::getSupportedKeySizes):
  62913. * platform/mac/SSLKeyGeneratorMac.mm:
  62914. (WebCore::getSupportedKeySizes):
  62915. * platform/qt/TemporaryLinkStubs.cpp:
  62916. (WebCore::getSupportedKeySizes):
  62917. * platform/win/TemporaryLinkStubs.cpp:
  62918. (WebCore::getSupportedKeySizes):
  62919. * platform/wx/TemporaryLinkStubs.cpp:
  62920. (WebCore::getSupportedKeySizes):
  62921. 2008-10-04 Darin Adler <darin@apple.com>
  62922. Reviewed by Cameron Zwarich.
  62923. - prepare for https://bugs.webkit.org/show_bug.cgi?id=21295
  62924. Bug 21295: Replace ExecState with a call frame Register pointer
  62925. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  62926. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
  62927. Remove bogus "const".
  62928. * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
  62929. 2008-10-04 David Hyatt <hyatt@apple.com>
  62930. Make PopupMenuClient obey the platform abstraction. Remove any connection to Document and RenderStyle.
  62931. Reviewed by Darin Adler
  62932. * WebCore.xcodeproj/project.pbxproj:
  62933. * platform/PopupMenuClient.h:
  62934. * platform/gtk/PopupMenuGtk.cpp:
  62935. (WebCore::PopupMenu::show):
  62936. * platform/mac/PopupMenuMac.mm:
  62937. (WebCore::PopupMenu::populate):
  62938. (WebCore::PopupMenu::show):
  62939. * platform/qt/PopupMenuQt.cpp:
  62940. (WebCore::PopupMenu::populate):
  62941. * platform/win/PopupMenuWin.cpp:
  62942. (WebCore::PopupMenu::calculatePositionAndSize):
  62943. (WebCore::PopupMenu::paint):
  62944. (WebCore::PopupWndProc):
  62945. * rendering/RenderMenuList.cpp:
  62946. (WebCore::RenderMenuList::itemStyle):
  62947. (WebCore::RenderMenuList::menuStyle):
  62948. (WebCore::RenderMenuList::hostWindow):
  62949. * rendering/RenderMenuList.h:
  62950. * rendering/RenderTextControl.cpp:
  62951. (WebCore::RenderTextControl::itemStyle):
  62952. (WebCore::RenderTextControl::menuStyle):
  62953. (WebCore::RenderTextControl::hostWindow):
  62954. * rendering/RenderTextControl.h:
  62955. 2008-10-04 Matt Lilek <webkit@mattlilek.com>
  62956. Build fix - restore Private role to headers that had it before the move.
  62957. * WebCore.xcodeproj/project.pbxproj:
  62958. 2008-10-04 Darin Adler <darin@apple.com>
  62959. - try to fix build
  62960. * DerivedSources.make: Add new inspector directory to VPATH.
  62961. * GNUmakefile.am: Add new inspector directory to includes.
  62962. Re-sort the IDL_BINDINGS list. Add new inspector directory
  62963. to VPATH.
  62964. 2008-10-04 Matt Lilek <webkit@mattlilek.com>
  62965. Not reviewed, attempt to fix Gtk build.
  62966. * GNUmakefile.am:
  62967. 2008-10-03 Timothy Hatcher <timothy@apple.com>
  62968. Move the Web Inspector files into a top-level "inspector" folder.
  62969. https://bugs.webkit.org/show_bug.cgi?id=21359
  62970. Reviewed by Dave Hyatt.
  62971. * GNUmakefile.am:
  62972. * WebCore.pro:
  62973. * WebCore.vcproj/WebCore.vcproj:
  62974. * WebCore.xcodeproj/project.pbxproj:
  62975. * WebCoreSources.bkl:
  62976. * inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
  62977. * inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
  62978. * inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
  62979. * inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
  62980. * inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
  62981. * inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
  62982. * inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
  62983. * inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
  62984. * inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
  62985. * inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
  62986. * inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
  62987. * inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
  62988. * inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
  62989. * inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
  62990. * inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
  62991. * inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
  62992. * inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
  62993. * inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
  62994. * inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
  62995. * inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
  62996. * inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
  62997. * inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
  62998. * inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
  62999. * inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
  63000. * inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
  63001. * inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
  63002. * inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
  63003. * inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
  63004. * inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
  63005. * inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
  63006. * inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
  63007. * inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
  63008. * inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
  63009. * inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
  63010. * inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
  63011. * inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
  63012. * inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
  63013. * inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
  63014. * inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
  63015. * inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
  63016. * inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
  63017. * inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
  63018. * inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
  63019. * inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
  63020. * inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
  63021. * inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
  63022. * inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
  63023. * inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
  63024. * inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
  63025. * inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
  63026. * inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
  63027. * inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
  63028. * inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
  63029. * inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
  63030. * inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
  63031. * inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
  63032. * inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
  63033. * inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
  63034. * inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
  63035. * inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
  63036. * inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
  63037. * inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
  63038. * inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
  63039. * inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
  63040. * inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
  63041. * inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
  63042. * inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
  63043. * inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
  63044. * inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
  63045. * inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
  63046. * inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
  63047. * inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
  63048. * inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
  63049. * inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
  63050. * inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
  63051. * inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
  63052. * inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
  63053. * inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
  63054. * inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
  63055. * inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
  63056. * inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
  63057. * inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
  63058. * inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
  63059. * inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
  63060. * inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
  63061. * inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
  63062. * inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
  63063. * inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
  63064. * inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
  63065. * inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
  63066. * inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
  63067. * inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
  63068. * inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
  63069. * inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
  63070. * inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
  63071. * inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
  63072. * inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
  63073. * inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
  63074. * inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
  63075. * inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
  63076. * inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
  63077. * inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
  63078. * inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
  63079. * inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
  63080. * inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
  63081. * inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
  63082. * inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
  63083. * inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
  63084. * inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
  63085. * inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
  63086. * inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
  63087. * inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
  63088. * inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
  63089. * inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
  63090. * inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
  63091. * inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
  63092. * inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
  63093. * inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
  63094. * inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
  63095. * inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
  63096. * inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
  63097. * inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
  63098. * inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
  63099. * inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
  63100. * inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
  63101. * inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
  63102. * inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
  63103. * inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
  63104. * inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
  63105. * inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
  63106. * inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
  63107. * inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
  63108. * inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
  63109. * inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
  63110. * inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
  63111. * inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
  63112. * inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
  63113. * inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
  63114. * inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
  63115. * inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
  63116. * inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
  63117. * inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
  63118. * inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
  63119. * inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
  63120. * inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
  63121. * inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
  63122. * inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
  63123. * inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
  63124. * inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
  63125. * inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
  63126. * inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
  63127. * inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
  63128. * inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
  63129. * inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
  63130. * inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
  63131. * inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.
  63132. 2008-10-03 Timothy Hatcher <timothy@apple.com>
  63133. Adds support to the Web Inspector's Elements panel for fast tag name,
  63134. class name, id and attribute name searching. The panel first tries
  63135. using getElementById, getElementsByClassName and getElementsByTagName
  63136. with the search query. Then does a slower search using XPath for partial
  63137. matches, text and comment matches.
  63138. Adds support for search queries like "<div>", "<h" and "frame>".
  63139. These forms limit the search to tag names, text and comment matches.
  63140. https://bugs.webkit.org/show_bug.cgi?id=21353
  63141. Reviewed by Maciej Stachowiak.
  63142. * page/inspector/ElementsPanel.js:
  63143. (WebInspector.ElementsPanel.prototype.performSearch): Add tag syntax
  63144. support. Add new search functions that try exact matches first.
  63145. 2008-10-03 Timothy Hatcher <timothy@apple.com>
  63146. Changes how searching works in the Web Inspector's Elements
  63147. panel. The search tasks are divided into chunks that are small
  63148. units of work that are performed at a time interval. This
  63149. change also prevents queries that will select all elements,
  63150. since that isn't useful.
  63151. https://bugs.webkit.org/show_bug.cgi?id=21285
  63152. Reviewed by Oliver Hunt.
  63153. * page/inspector/ElementsPanel.js:
  63154. (WebInspector.ElementsPanel.prototype.searchCancled):
  63155. Remove the searchResultsProperty form results since there might
  63156. be an unfinished search.
  63157. (WebInspector.ElementsPanel.prototype.performSearch): Divide the
  63158. documents and search functions into chunks that are performed on
  63159. a interval of 25ms. Prevent searches for "//*" and "*".
  63160. 2008-10-03 Maciej Stachowiak <mjs@apple.com>
  63161. Reviewed by Cameron Zwarich.
  63162. - "this" object in methods called on primitives should be wrapper object
  63163. https://bugs.webkit.org/show_bug.cgi?id=21362
  63164. Updated so toThis conversion for the split window is handled properly.
  63165. * bindings/scripts/CodeGeneratorJS.pm:
  63166. 2008-10-03 Sam Weinig <sam@webkit.org>
  63167. Reviewed by David "The Motivator" Hyatt.
  63168. Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
  63169. Move SecurityOrigin out of platform/ to page/.
  63170. It was a layering violation for SecurityOrigin to be in platform
  63171. as it depended on FrameLoader.
  63172. * GNUmakefile.am:
  63173. * WebCore.pro:
  63174. * WebCore.vcproj/WebCore.vcproj:
  63175. * WebCore.xcodeproj/project.pbxproj:
  63176. * WebCoreSources.bkl:
  63177. * page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
  63178. * page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
  63179. * page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
  63180. * platform/SecurityOrigin.cpp: Removed.
  63181. * platform/SecurityOrigin.h: Removed.
  63182. * platform/SecurityOriginHash.h: Removed.
  63183. 2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>
  63184. Reviewed by Alp Toker.
  63185. http://bugs.webkit.org/show_bug.cgi?id=18832
  63186. [curl] file upload does not work
  63187. The curl_off_t integer type has a different size depending if large
  63188. file support is enabled or not. There is no different public API for
  63189. the two cases, so the same function accepts a different type based on
  63190. a compilation option the could be different in WebKit and libcurl.
  63191. To fix the bug we query libcurl at runtime for large file support and
  63192. pass the right type based on that.
  63193. * platform/network/curl/ResourceHandleManager.cpp:
  63194. (WebCore::ResourceHandleManager::setupPOST):
  63195. 2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>
  63196. Reviewed by David Hyatt.
  63197. Gtk build fixes.
  63198. * platform/gtk/FileChooserGtk.cpp:
  63199. (WebCore::FileChooser::openFileChooser):
  63200. * platform/gtk/PlatformScreenGtk.cpp:
  63201. (WebCore::screenDepth):
  63202. (WebCore::screenDepthPerComponent):
  63203. (WebCore::screenAvailableRect):
  63204. * platform/gtk/PopupMenuGtk.cpp:
  63205. (WebCore::PopupMenu::show):
  63206. * platform/gtk/ScrollViewGtk.cpp:
  63207. (WebCore::ScrollView::platformAddChild):
  63208. (WebCore::ScrollView::platformRemoveChild):
  63209. * platform/gtk/WidgetGtk.cpp:
  63210. (WebCore::Widget::setCursor):
  63211. * plugins/gtk/PluginViewGtk.cpp:
  63212. (WebCore::PluginView::getValue):
  63213. (WebCore::PluginView::forceRedraw):
  63214. (WebCore::PluginView::init):
  63215. 2008-10-03 David Hyatt <hyatt@apple.com>
  63216. Fix Qt bustage from missing include.
  63217. * platform/qt/PlatformScreenQt.cpp:
  63218. 2008-10-03 David Hyatt <hyatt@apple.com>
  63219. Fix Windows scrollbar bustage in popup menus.
  63220. * platform/win/PopupMenuWin.cpp:
  63221. (WebCore::PopupWndProc):
  63222. 2008-10-03 David Hyatt <hyatt@apple.com>
  63223. Fix Windows bustage.
  63224. * platform/win/FileChooserWin.cpp:
  63225. (WebCore::FileChooser::openFileChooser):
  63226. * platform/win/PlatformScreenWin.cpp:
  63227. (WebCore::monitorInfoForWidget):
  63228. * platform/win/WidgetWin.cpp:
  63229. * plugins/win/PluginViewWin.cpp:
  63230. (WebCore::PluginView::getValue):
  63231. (WebCore::PluginView::forceRedraw):
  63232. (WebCore::PluginView::init):
  63233. 2008-10-03 Darin Adler <darin@apple.com>
  63234. * bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure
  63235. seen on some machines but not others by adding an include.
  63236. 2008-10-03 Darin Adler <darin@apple.com>
  63237. - Qt build fix
  63238. * bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and
  63239. execute functions. Declarations for these relied on the CodeType
  63240. enumeration, which used to be in ExecState.h; but the functions
  63241. aren't needed at all.
  63242. * bridge/qt/qt_runtime.h: Ditto.
  63243. 2008-10-03 Darin Adler <darin@apple.com>
  63244. Reviewed by Geoff Garen.
  63245. - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
  63246. Turn ExecState into a call frame pointer.
  63247. Remove m_globalObject and m_globalData from ExecState.
  63248. * bindings/js/JSDOMWindowBase.cpp:
  63249. (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
  63250. Removed an argument now that JSGlobalObject doesn't need it any more.
  63251. (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from
  63252. the JSDOMWindowBaseData constructor, and added the this argument to the
  63253. JSGlobalObject constructor. This is because a couple key bits of
  63254. initialization moved from the data constructor to the JSGlobalObject
  63255. constructor.
  63256. * bindings/js/JSDOMWindowBase.h: Ditto.
  63257. * bridge/qt/qt_runtime.cpp:
  63258. (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
  63259. * bridge/runtime_method.cpp:
  63260. (JSC::RuntimeMethod::RuntimeMethod):
  63261. Pass JSGlobalData* instead of ExecState* to the InternalFunction
  63262. constructor.
  63263. 2008-10-03 David Hyatt <hyatt@apple.com>
  63264. Fix Windows/Qt build bustage.
  63265. Reviewed by ggaren
  63266. * loader/EmptyClients.h:
  63267. (WebCore::EmptyChromeClient::platformWindow):
  63268. * page/Chrome.cpp:
  63269. (WebCore::Chrome::platformWindow):
  63270. * page/Chrome.h:
  63271. * page/ChromeClient.h:
  63272. * platform/HostWindow.h:
  63273. * platform/qt/PlatformScreenQt.cpp:
  63274. (WebCore::screenDepth):
  63275. (WebCore::screenDepthPerComponent):
  63276. (WebCore::screenIsMonochrome):
  63277. (WebCore::screenRect):
  63278. (WebCore::screenAvailableRect):
  63279. * platform/qt/PopupMenuQt.cpp:
  63280. (WebCore::PopupMenu::show):
  63281. * platform/win/PopupMenuWin.cpp:
  63282. (WebCore::PopupMenu::show):
  63283. (WebCore::PopupMenu::calculatePositionAndSize):
  63284. (WebCore::PopupWndProc):
  63285. 2008-10-03 Simon Fraser <simon.fraser@apple.com>
  63286. Reviewed by Dave Hyatt
  63287. Make setStyle() take a const RenderStyle, to ensure that an
  63288. earlier RenderStyle::diff() remains valid.
  63289. * rendering/RenderBR.cpp:
  63290. * rendering/RenderBR.h:
  63291. * rendering/RenderBlock.cpp:
  63292. * rendering/RenderBlock.h:
  63293. * rendering/RenderBox.cpp:
  63294. * rendering/RenderBox.h:
  63295. * rendering/RenderButton.cpp:
  63296. * rendering/RenderButton.h:
  63297. * rendering/RenderFieldset.cpp:
  63298. * rendering/RenderFieldset.h:
  63299. * rendering/RenderFileUploadControl.cpp:
  63300. * rendering/RenderFileUploadControl.h:
  63301. * rendering/RenderInline.cpp:
  63302. * rendering/RenderInline.h:
  63303. * rendering/RenderListBox.cpp:
  63304. * rendering/RenderListBox.h:
  63305. * rendering/RenderListItem.cpp:
  63306. * rendering/RenderListItem.h:
  63307. * rendering/RenderListMarker.cpp:
  63308. * rendering/RenderListMarker.h:
  63309. * rendering/RenderMenuList.cpp:
  63310. * rendering/RenderMenuList.h:
  63311. * rendering/RenderObject.cpp:
  63312. (WebCore::RenderObject::setStyle):
  63313. * rendering/RenderObject.h:
  63314. * rendering/RenderReplaced.cpp:
  63315. * rendering/RenderReplaced.h:
  63316. * rendering/RenderSVGBlock.cpp:
  63317. (WebCore::RenderSVGBlock::setStyle):
  63318. * rendering/RenderSVGBlock.h:
  63319. * rendering/RenderSVGGradientStop.cpp:
  63320. * rendering/RenderSVGGradientStop.h:
  63321. * rendering/RenderSlider.cpp:
  63322. * rendering/RenderSlider.h:
  63323. * rendering/RenderTable.cpp:
  63324. * rendering/RenderTable.h:
  63325. * rendering/RenderTableCell.cpp:
  63326. * rendering/RenderTableCell.h:
  63327. * rendering/RenderTableRow.cpp:
  63328. * rendering/RenderTableRow.h:
  63329. * rendering/RenderText.cpp:
  63330. * rendering/RenderText.h:
  63331. * rendering/RenderTextControl.cpp:
  63332. * rendering/RenderTextControl.h:
  63333. * rendering/RenderWidget.cpp:
  63334. * rendering/RenderWidget.h:
  63335. * rendering/style/RenderStyle.h:
  63336. (WebCore::RenderStyle::isDisplayReplacedType):
  63337. (WebCore::RenderStyle::isDisplayInlineType):
  63338. 2008-10-03 David Hyatt <hyatt@apple.com>
  63339. Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
  63340. event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
  63341. method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
  63342. that will work properly for hit testing. This patch just stubs out that method to return the same
  63343. event untransformed.
  63344. Reviewed by Darin Adler
  63345. * page/EventHandler.cpp:
  63346. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  63347. (WebCore::EventHandler::handleMouseMoveEvent):
  63348. (WebCore::EventHandler::handleMouseReleaseEvent):
  63349. (WebCore::EventHandler::passMousePressEventToScrollbar):
  63350. * page/gtk/EventHandlerGtk.cpp:
  63351. * page/mac/EventHandlerMac.mm:
  63352. * page/qt/EventHandlerQt.cpp:
  63353. * page/win/EventHandlerWin.cpp:
  63354. * page/wx/EventHandlerWx.cpp:
  63355. * platform/Scrollbar.cpp:
  63356. (WebCore::Scrollbar::mouseMoved):
  63357. (WebCore::Scrollbar::mouseExited):
  63358. (WebCore::Scrollbar::mouseUp):
  63359. (WebCore::Scrollbar::mouseDown):
  63360. (WebCore::Scrollbar::transformEvent):
  63361. * platform/Scrollbar.h:
  63362. 2008-10-03 David Hyatt <hyatt@apple.com>
  63363. https://bugs.webkit.org/show_bug.cgi?id=21340
  63364. Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
  63365. Reviewed by Dan Bernstein & Darin Adler
  63366. * platform/ScrollView.cpp:
  63367. (WebCore::ScrollView::addChild):
  63368. * platform/Widget.cpp:
  63369. (WebCore::Widget::init):
  63370. * platform/Widget.h:
  63371. * platform/mac/WidgetMac.mm:
  63372. * platform/win/PopupMenuWin.cpp:
  63373. (WebCore::PopupMenu::show):
  63374. 2008-10-03 Adele Peterson <adele@apple.com>
  63375. Reviewed by Sam Weinig.
  63376. * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily):
  63377. Return early if settings is nil.
  63378. 2008-10-03 Rob Buis <buis@kde.org>
  63379. Reviewed by Darin.
  63380. https://bugs.webkit.org/show_bug.cgi?id=20134
  63381. REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
  63382. Make sure the input element gets the right default value when no value is set.
  63383. Test: fast/forms/range-default-value.html
  63384. * rendering/RenderSlider.cpp:
  63385. (WebCore::RenderSlider::setPositionFromValue):
  63386. 2008-10-03 David Hyatt <hyatt@apple.com>
  63387. Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
  63388. destructor that calls them, switch to having a cross-platform constructor/destructor that calls
  63389. platform-specific init/destroy methods.
  63390. With this change, ScrollViewWin.cpp can be removed from the build (yay!).
  63391. Reviewed by Darin Adler
  63392. * WebCore.vcproj/WebCore.vcproj:
  63393. * platform/ScrollView.cpp:
  63394. (WebCore::ScrollView::ScrollView):
  63395. (WebCore::ScrollView::~ScrollView):
  63396. (WebCore::ScrollView::platformInit):
  63397. (WebCore::ScrollView::platformDestroy):
  63398. (WebCore::ScrollView::platformAddChild):
  63399. (WebCore::ScrollView::platformRemoveChild):
  63400. * platform/ScrollView.h:
  63401. * platform/gtk/ScrollViewGtk.cpp:
  63402. (WebCore::ScrollView::platformInit):
  63403. (WebCore::ScrollView::platformDestroy):
  63404. * platform/mac/ScrollViewMac.mm:
  63405. * platform/qt/ScrollViewQt.cpp:
  63406. (WebCore::ScrollView::platformInit):
  63407. (WebCore::ScrollView::platformDestroy):
  63408. * platform/win/ScrollViewWin.cpp: Removed.
  63409. * platform/wx/ScrollViewWx.cpp:
  63410. (WebCore::ScrollView::platformInit):
  63411. (WebCore::ScrollView::platformDestroy):
  63412. (WebCore::ScrollView::setPlatformWidget):
  63413. 2008-10-03 Adele Peterson <adele@apple.com>
  63414. Reviewed by Dan Bernstein.
  63415. Fix for <rdar://problem/6012018>
  63416. https://bugs.webkit.org/show_bug.cgi?id=21335
  63417. CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8
  63418. * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
  63419. 2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
  63420. Build fix.
  63421. * platform/qt/WidgetQt.cpp:
  63422. (WebCore::Widget::invalidateRect):
  63423. 2008-10-03 Alp Toker <alp@nuanti.com>
  63424. Remove some left-over GTK+ includes. No change in functionality.
  63425. * platform/Cursor.h:
  63426. * platform/graphics/Icon.h:
  63427. * platform/gtk/RenderThemeGtk.h:
  63428. 2008-10-03 Alp Toker <alp@nuanti.com>
  63429. Build fix for trailing comment after #endif
  63430. * dom/ElementRareData.h:
  63431. 2008-10-03 David Hyatt <hyatt@apple.com>
  63432. Remove addToDirtyRegion.
  63433. Reviewed by Oliver Hunt
  63434. * page/Chrome.cpp:
  63435. * page/Chrome.h:
  63436. * page/ChromeClient.h:
  63437. * platform/ScrollView.h:
  63438. * platform/gtk/ScrollViewGtk.cpp:
  63439. * platform/qt/ScrollViewQt.cpp:
  63440. * platform/win/ScrollViewWin.cpp:
  63441. 2008-10-03 Dan Bernstein <mitz@apple.com>
  63442. Reviewed by Maciej Stachowiak.
  63443. - fix a CachedResource leak introduced in r37176
  63444. Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
  63445. afterwards bail out of the outer pruneDeadResources().
  63446. * loader/Cache.cpp:
  63447. (WebCore::Cache::Cache):
  63448. (WebCore::Cache::pruneDeadResources):
  63449. (WebCore::Cache::remove):
  63450. * loader/Cache.h:
  63451. 2008-10-03 David Hyatt <hyatt@apple.com>
  63452. https://bugs.webkit.org/show_bug.cgi?id=21330
  63453. Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
  63454. scrollbars.
  63455. Reviewed by Oliver Hunt
  63456. * platform/ScrollView.cpp:
  63457. (WebCore::ScrollView::setHasHorizontalScrollbar):
  63458. (WebCore::ScrollView::setHasVerticalScrollbar):
  63459. (WebCore::ScrollView::platformHasHorizontalAdjustment):
  63460. (WebCore::ScrollView::platformHasVerticalAdjustment):
  63461. * platform/ScrollView.h:
  63462. * platform/gtk/ScrollViewGtk.cpp:
  63463. (WebCore::ScrollView::adjustmentChanged):
  63464. (WebCore::ScrollView::ScrollView):
  63465. (WebCore::ScrollView::~ScrollView):
  63466. (WebCore::ScrollView::setGtkAdjustments):
  63467. (WebCore::ScrollView::platformHandleHorizontalAdjustment):
  63468. (WebCore::ScrollView::platformHandleVerticalAdjustment):
  63469. 2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>
  63470. Reviewed by Maciej Stachowiak.
  63471. Bug 21106: .in format discussed changes
  63472. https://bugs.webkit.org/show_bug.cgi?id=21106
  63473. Change "upperCase" to "interfaceName" per-tag parameter as
  63474. discussed on the mailing list. Removed the per-attribute version
  63475. as it was not used.
  63476. Also add the "Element" suffix to all interfaceName parameter to match
  63477. the class name (and thus remove it from make_names.pl).
  63478. * dom/make_names.pl:
  63479. * html/HTMLTagNames.in:
  63480. * svg/svgtags.in:
  63481. 2008-10-03 David Hyatt <hyatt@apple.com>
  63482. Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
  63483. Hopefully this is a temporary hack that could eventually be removed.
  63484. Reviewed by Sam Weinig
  63485. * platform/ScrollView.cpp:
  63486. (WebCore::ScrollView::scrollContents):
  63487. * platform/ScrollView.h:
  63488. (WebCore::ScrollView::rootPreventsBlitting):
  63489. * platform/qt/ScrollViewQt.cpp:
  63490. (WebCore::ScrollView::ScrollView):
  63491. (WebCore::ScrollView::~ScrollView):
  63492. (WebCore::ScrollView::platformAddChild):
  63493. (WebCore::ScrollView::platformRemoveChild):
  63494. 2008-10-02 David Hyatt <hyatt@apple.com>
  63495. https://bugs.webkit.org/show_bug.cgi?id=21328
  63496. Make widget invalidation more cross-platform.
  63497. (1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
  63498. (2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
  63499. This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
  63500. (3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
  63501. (4) FrameViews now do a repaintRectangle on their owner element's renderer.
  63502. Reviewed by Sam Weinig
  63503. * WebCore.base.exp:
  63504. * page/FrameView.cpp:
  63505. (WebCore::FrameView::invalidateRect):
  63506. (WebCore::FrameView::invalidateScrollbarRect):
  63507. * page/FrameView.h:
  63508. * platform/PopupMenu.h:
  63509. * platform/ScrollView.cpp:
  63510. (WebCore::ScrollView::scrollContents):
  63511. * platform/ScrollView.h:
  63512. * platform/Scrollbar.cpp:
  63513. (WebCore::Scrollbar::setEnabled):
  63514. (WebCore::Scrollbar::invalidateRect):
  63515. * platform/Scrollbar.h:
  63516. * platform/ScrollbarClient.h:
  63517. * platform/Widget.h:
  63518. * platform/gtk/WidgetGtk.cpp:
  63519. * platform/mac/WidgetMac.mm:
  63520. * platform/win/PopupMenuWin.cpp:
  63521. (WebCore::PopupMenu::invalidateScrollbarRect):
  63522. * platform/win/WidgetWin.cpp:
  63523. * plugins/PluginView.cpp:
  63524. (WebCore::PluginView::invalidateTimerFired):
  63525. (WebCore::PluginView::invalidateWindowlessPluginRect):
  63526. * plugins/PluginView.h:
  63527. * plugins/gtk/PluginViewGtk.cpp:
  63528. (WebCore::PluginView::invalidateRect):
  63529. * plugins/qt/PluginViewQt.cpp:
  63530. (WebCore::PluginView::invalidateRect):
  63531. * plugins/win/PluginViewWin.cpp:
  63532. (WebCore::PluginView::invalidateRect):
  63533. (WebCore::PluginView::invalidateRegion):
  63534. * rendering/RenderLayer.cpp:
  63535. (WebCore::RenderLayer::invalidateScrollbarRect):
  63536. * rendering/RenderLayer.h:
  63537. * rendering/RenderListBox.cpp:
  63538. (WebCore::RenderListBox::paintObject):
  63539. (WebCore::RenderListBox::paintScrollbar):
  63540. (WebCore::RenderListBox::invalidateScrollbarRect):
  63541. * rendering/RenderListBox.h:
  63542. 2008-10-02 Dan Bernstein <mitz@apple.com>
  63543. Reviewed by Geoffrey Garen and Sam Weinig.
  63544. - fix SVGFontFaceElement leaks seen in Acid3
  63545. - make font-face elements take effect only when they are in the document tree
  63546. Test: svg/custom/font-face-not-in-document.svg
  63547. * svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a
  63548. RefPtr to a plain pointer to break a ref cycle.
  63549. (WebCore::SVGFontData::svgFontFaceElement):
  63550. * svg/SVGFontFaceElement.cpp: Changed to insert and remove the
  63551. @font-face rule from the document's mapped element sheet when the
  63552. element is inserted and removed from the document, and to update it
  63553. only when the element is in the document.
  63554. (WebCore::SVGFontFaceElement::SVGFontFaceElement):
  63555. (WebCore::SVGFontFaceElement::parseMappedAttribute):
  63556. (WebCore::SVGFontFaceElement::rebuildFontFace):
  63557. (WebCore::SVGFontFaceElement::insertedIntoDocument):
  63558. (WebCore::SVGFontFaceElement::removedFromDocument):
  63559. (WebCore::SVGFontFaceElement::childrenChanged):
  63560. (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  63561. * svg/SVGFontFaceElement.h:
  63562. 2008-10-01 Simon Fraser <simon.fraser@apple.com>
  63563. Reviewed by Dave Hyatt
  63564. Fix RenderFileUploadControl::setStyle() and
  63565. RenderMenuList::setStyle() to not touch the style; replace
  63566. with html4.css and CSSStyleSelector changes.
  63567. https://bugs.webkit.org/show_bug.cgi?id=21287
  63568. * css/CSSStyleSelector.cpp:
  63569. (WebCore::CSSStyleSelector::adjustRenderStyle):
  63570. * css/html4.css:
  63571. * rendering/RenderBlock.cpp:
  63572. (WebCore::RenderBlock::setStyle):
  63573. * rendering/RenderFileUploadControl.cpp:
  63574. * rendering/RenderMenuList.cpp:
  63575. (WebCore::RenderMenuList::setStyle):
  63576. 2008-10-01 Simon Fraser <simon.fraser@apple.com>
  63577. Reviewed by Dave Hyatt
  63578. Clean up code that changes the RenderStyle passed in to
  63579. table renderer setStyle() methods.
  63580. https://bugs.webkit.org/show_bug.cgi?id=21287
  63581. Tests: fast/table/floating-th.html
  63582. fast/table/table-display-types-strict.html
  63583. fast/table/table-display-types.html
  63584. * css/CSSStyleSelector.cpp:
  63585. (WebCore::CSSStyleSelector::adjustRenderStyle):
  63586. * rendering/RenderTableCell.cpp:
  63587. (WebCore::RenderTableCell::setStyle):
  63588. * rendering/RenderTableRow.cpp:
  63589. (WebCore::RenderTableRow::setStyle):
  63590. * rendering/RenderTableSection.cpp:
  63591. (WebCore::RenderTableSection::setStyle):
  63592. 2008-10-02 Darin Adler <darin@apple.com>
  63593. - fix build
  63594. * bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too.
  63595. Not just locally in my generated file!
  63596. 2008-10-02 Adele Peterson <adele@apple.com>
  63597. Reviewed by Dan Bernstein.
  63598. Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
  63599. REGRESSION: <input> color specified in inline style applies to placeholder
  63600. I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
  63601. is more appropriate. This change adds "-webkit-input-placeholder".
  63602. * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  63603. Added definition for "-webkit-input-placeholder" pseudo element.
  63604. * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
  63605. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  63606. Added case for PseudoInputPlaceholder.
  63607. * css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
  63608. * rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
  63609. * html/HTMLInputElement.cpp:
  63610. (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility.
  63611. (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
  63612. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer.
  63613. setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
  63614. * rendering/RenderTextControl.cpp:
  63615. (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible.
  63616. (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so
  63617. the text will be updated correctly.
  63618. * rendering/RenderTextControl.h:
  63619. 2008-10-02 Chris Fleizach <cfleizach@apple.com>
  63620. Reviewed by Darin Adler.
  63621. https://bugs.webkit.org/show_bug.cgi?id=21280
  63622. <rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables
  63623. Updated AXTable detection to be more robust to false-positives. Specifically, added checks
  63624. to ensure that there is more than one valid table cell, and that at least half of the cells
  63625. have borders or have specific background colors. Modified the table detection layout test
  63626. to test for the tables mentioned in the bug
  63627. * page/AccessibilityTable.cpp:
  63628. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  63629. 2008-10-02 Darin Adler <darin@apple.com>
  63630. Reviewed by Geoff Garen.
  63631. - https://bugs.webkit.org/show_bug.cgi?id=21321
  63632. Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
  63633. * bindings/js/GCController.cpp:
  63634. (WebCore::collect): Use heap. instead of heap-> to work with the heap.
  63635. (WebCore::GCController::gcTimerFired): Ditto.
  63636. (WebCore::GCController::garbageCollectNow): Ditto.
  63637. * bindings/js/JSDOMWindowShell.cpp:
  63638. (WebCore::JSDOMWindowShell::operator new): Ditto.
  63639. * storage/Database.cpp:
  63640. (WebCore::Database::Database): Ditto.
  63641. 2008-10-02 Dan Bernstein <mitz@apple.com>
  63642. Reviewed by Alexey Proskuryakov.
  63643. - fix a Database leak that resulted in Document leaks
  63644. * storage/Database.cpp:
  63645. (WebCore::Database::openDatabase): Account for the fact that RefCounted
  63646. objects start out with a ref count of 1.
  63647. 2008-10-02 Sam Weinig <sam@webkit.org>
  63648. Reviewed by Mr. Geoffrey Garen.
  63649. Always mark your parent before marking members.
  63650. * bindings/js/JSDOMWindowCustom.cpp:
  63651. (WebCore::JSDOMWindow::mark):
  63652. 2008-10-02 David Hyatt <hyatt@apple.com>
  63653. https://bugs.webkit.org/show_bug.cgi?id=21314
  63654. Make scrollBackingStore cross-platform.
  63655. Reviewed by Sam Weinig
  63656. * loader/EmptyClients.h:
  63657. (WebCore::EmptyChromeClient::repaint):
  63658. (WebCore::EmptyChromeClient::scroll):
  63659. * page/Chrome.cpp:
  63660. (WebCore::Chrome::repaint):
  63661. (WebCore::Chrome::scroll):
  63662. * page/Chrome.h:
  63663. * page/ChromeClient.h:
  63664. * page/EventHandler.cpp:
  63665. (WebCore::EventHandler::handleAutoscroll):
  63666. * platform/HostWindow.h:
  63667. * platform/ScrollView.cpp:
  63668. (WebCore::ScrollView::scrollContents):
  63669. (WebCore::ScrollView::addPanScrollIcon):
  63670. (WebCore::ScrollView::removePanScrollIcon):
  63671. * platform/ScrollView.h:
  63672. * platform/gtk/ScrollViewGtk.cpp:
  63673. * platform/qt/ScrollViewQt.cpp:
  63674. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  63675. (WebCore::ScrollView::~ScrollView):
  63676. * platform/win/ScrollViewWin.cpp:
  63677. (WebCore::ScrollView::ScrollView):
  63678. (WebCore::ScrollView::~ScrollView):
  63679. 2008-10-02 Kevin Ollivier <kevino@theolliviers.com>
  63680. wx build fixes after Frame/ScrollView changes.
  63681. * WebCoreSources.bkl:
  63682. * platform/wx/ScrollViewWx.cpp:
  63683. (WebCore::ScrollView::platformContentsToScreen):
  63684. (WebCore::ScrollView::platformScreenToContents):
  63685. (WebCore::ScrollView::platformIsOffscreen):
  63686. 2008-10-02 Brett Wilson <brettw@chromium.org>
  63687. Reviewed by Sam Weinig
  63688. https://bugs.webkit.org/show_bug.cgi?id=21292
  63689. Revert the changes to enclosingIntRect made in r12530 since the new code
  63690. doesn't round correctly.
  63691. * ChangeLog:
  63692. * platform/graphics/FloatRect.cpp:
  63693. (WebCore::enclosingIntRect):
  63694. 2008-10-02 Dan Bernstein <mitz@apple.com>
  63695. Reviewed by Anders Carlsson and Eric Seidel.
  63696. - fix HTMLCanvaseElement leak from -webkit-canvas() values
  63697. Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
  63698. pointer, as the document owns the canvas elements. Added code to release
  63699. those elements in Document::removedLastRef() because they reference
  63700. the document.
  63701. * css/CSSCanvasValue.cpp:
  63702. (WebCore::CSSCanvasValue::element):
  63703. * css/CSSCanvasValue.h:
  63704. (WebCore::CSSCanvasValue::CSSCanvasValue):
  63705. * dom/Document.cpp:
  63706. (WebCore::Document::removedLastRef):
  63707. 2008-10-02 Alexey Proskuryakov <ap@webkit.org>
  63708. Reviewed by Maciej Stachowiak.
  63709. Build fix for platforms that don't implement WTF::ThreadSpecific.
  63710. * bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet):
  63711. Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this
  63712. code is only needed for JS bindings in worker threads.
  63713. 2008-10-01 David Hyatt <hyatt@apple.com>
  63714. https://bugs.webkit.org/show_bug.cgi?id=21298
  63715. Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
  63716. will make that cross-platform.
  63717. The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
  63718. multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
  63719. windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
  63720. Reviewed by Sam Weinig
  63721. * page/FrameView.cpp:
  63722. (WebCore::FrameView::windowClipRect):
  63723. (WebCore::FrameView::isActive):
  63724. * page/FrameView.h:
  63725. (WebCore::FrameView::visibleContentsResized):
  63726. * platform/PopupMenu.h:
  63727. * platform/ScrollView.cpp:
  63728. (WebCore::ScrollView::init):
  63729. (WebCore::ScrollView::destroy):
  63730. (WebCore::ScrollView::setHasHorizontalScrollbar):
  63731. (WebCore::ScrollView::setHasVerticalScrollbar):
  63732. (WebCore::ScrollView::valueChanged):
  63733. (WebCore::ScrollView::updateScrollbars):
  63734. (WebCore::ScrollView::scrollContents):
  63735. (WebCore::ScrollView::platformHandleHorizontalAdjustment):
  63736. (WebCore::ScrollView::platformHandleVerticalAdjustment):
  63737. * platform/ScrollView.h:
  63738. * platform/Scrollbar.cpp:
  63739. (WebCore::Scrollbar::windowClipRect):
  63740. * platform/ScrollbarClient.h:
  63741. * platform/gtk/ScrollViewGtk.cpp:
  63742. (WebCore::ScrollView::platformHandleHorizontalAdjustment):
  63743. (WebCore::ScrollView::platformHandleVerticalAdjustment):
  63744. * platform/qt/ScrollViewQt.cpp:
  63745. (WebCore::ScrollView::scrollContents):
  63746. * platform/win/PopupMenuWin.cpp:
  63747. (WebCore::PopupMenu::windowClipRect):
  63748. * platform/win/ScrollViewWin.cpp:
  63749. (WebCore::ScrollView::scrollContents):
  63750. * rendering/RenderLayer.cpp:
  63751. (WebCore::RenderLayer::windowClipRect):
  63752. * rendering/RenderLayer.h:
  63753. * rendering/RenderListBox.cpp:
  63754. (WebCore::RenderListBox::panScroll):
  63755. (WebCore::RenderListBox::windowClipRect):
  63756. * rendering/RenderListBox.h:
  63757. 2008-10-02 Alexey Proskuryakov <ap@webkit.org>
  63758. Reviewed by Darin Adler.
  63759. https://bugs.webkit.org/show_bug.cgi?id=21304
  63760. Stop using a static wrapper map for WebCore JS bindings
  63761. The static domObjects map was not thread safe.
  63762. * dom/Document.h:
  63763. (WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message
  63764. ports.
  63765. (WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
  63766. * dom/Document.cpp:
  63767. (WebCore::Document::createdXMLHttpRequest):
  63768. (WebCore::Document::destroyedXMLHttpRequest):
  63769. Moved XMLHttpRequest tracking from a global map to Document.
  63770. * GNUmakefile.am:
  63771. * WebCore.pro:
  63772. * WebCore.vcproj/WebCore.vcproj:
  63773. * WebCore.xcodeproj/project.pbxproj:
  63774. * WebCoreSources.bkl:
  63775. * webcore-base.bkl:
  63776. * bindings/DOMProtect.cpp: Removed.
  63777. * bindings/DOMProtect.h: Removed.
  63778. Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference,
  63779. so they can no longer protect bindings objects.
  63780. * dom/MessagePort.cpp:
  63781. (WebCore::CloseMessagePortTimer::CloseMessagePortTimer):
  63782. (WebCore::CloseMessagePortTimer::fired):
  63783. (WebCore::MessagePort::MessagePort):
  63784. (WebCore::MessagePort::queueCloseEvent):
  63785. (WebCore::MessagePort::setPendingActivity):
  63786. (WebCore::MessagePort::unsetPendingActivity):
  63787. * dom/MessagePort.h:
  63788. (WebCore::MessagePort::hasPendingActivity):
  63789. MessagePort now counts outstanding async events, so JSDocument::mark can decide whether
  63790. to protect it.
  63791. * xml/XMLHttpRequest.h:
  63792. (WebCore::XMLHttpRequest::hasPendingActivity):
  63793. * xml/XMLHttpRequest.cpp:
  63794. (WebCore::XMLHttpRequest::XMLHttpRequest):
  63795. (WebCore::XMLHttpRequest::~XMLHttpRequest):
  63796. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  63797. (WebCore::XMLHttpRequest::dropProtection):
  63798. (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
  63799. (WebCore::XMLHttpRequest::cancelRequests):
  63800. (WebCore::XMLHttpRequest::detachRequests):
  63801. (WebCore::XMLHttpRequest::setPendingActivity):
  63802. (WebCore::XMLHttpRequest::unsetPendingActivity):
  63803. Moved XMLHttpRequest tracking from a global map to Document.
  63804. * bindings/js/JSDOMBinding.cpp:
  63805. (WebCore::wrapperSet):
  63806. (WebCore::DOMObjectWrapperMap::mapFor):
  63807. (WebCore::DOMObjectWrapperMap::get):
  63808. (WebCore::DOMObjectWrapperMap::set):
  63809. (WebCore::DOMObjectWrapperMap::remove):
  63810. (WebCore::getCachedDOMObjectWrapper):
  63811. (WebCore::cacheDOMObjectWrapper):
  63812. (WebCore::forgetDOMObject):
  63813. (WebCore::getCachedDOMNodeWrapper):
  63814. (WebCore::forgetDOMNode):
  63815. (WebCore::cacheDOMNodeWrapper):
  63816. (WebCore::markActiveObjectsForDocument):
  63817. * bindings/js/JSDOMBinding.h:
  63818. (WebCore::createDOMObjectWrapper):
  63819. (WebCore::getDOMObjectWrapper):
  63820. Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet
  63821. to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug).
  63822. WebCore objects can never migrate between threads.
  63823. * bindings/js/JSDocumentCustom.cpp:
  63824. (WebCore::JSDocument::mark):
  63825. Call markActiveObjectsForDocument() from JSDOMBinding.
  63826. * bindings/js/JSCSSRuleCustom.cpp:
  63827. (WebCore::toJS):
  63828. * bindings/js/JSCSSValueCustom.cpp:
  63829. (WebCore::toJS):
  63830. * bindings/js/JSDOMWindowCustom.cpp:
  63831. (WebCore::markDOMObjectWrapper):
  63832. (WebCore::JSDOMWindow::mark):
  63833. * bindings/js/JSEventCustom.cpp:
  63834. (WebCore::toJS):
  63835. * bindings/js/JSEventTarget.cpp:
  63836. (WebCore::toJS):
  63837. * bindings/js/JSHTMLCollectionCustom.cpp:
  63838. (WebCore::toJS):
  63839. * bindings/js/JSImageDataCustom.cpp:
  63840. (WebCore::toJS):
  63841. * bindings/js/JSMessageChannelCustom.cpp:
  63842. (WebCore::JSMessageChannel::mark):
  63843. * bindings/js/JSMessagePortCustom.cpp:
  63844. (WebCore::JSMessagePort::mark):
  63845. * bindings/js/JSNodeCustom.cpp:
  63846. (WebCore::JSNode::mark):
  63847. * bindings/js/JSSVGPathSegCustom.cpp:
  63848. (WebCore::toJS):
  63849. * bindings/js/JSStyleSheetCustom.cpp:
  63850. (WebCore::toJS):
  63851. * bindings/js/JSXMLHttpRequestCustom.cpp:
  63852. (WebCore::JSXMLHttpRequest::mark):
  63853. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  63854. (WebCore::JSXMLHttpRequestUpload::mark):
  63855. * bindings/js/ScriptController.cpp:
  63856. (WebCore::ScriptController::finishedWithEvent):
  63857. * bindings/scripts/CodeGeneratorJS.pm:
  63858. Pass a JSGlobalData reference to functions that track JS wrapper objects.
  63859. 2008-10-02 Dan Bernstein <mitz@apple.com>
  63860. - build fix
  63861. * page/JavaScriptCallFrame.idl:
  63862. 2008-10-02 Oliver Hunt <oliver@apple.com>
  63863. Reviewed by NOBODY (Build fix).
  63864. Add new file to project files
  63865. * GNUmakefile.am:
  63866. * WebCore.pro:
  63867. * WebCore.vcproj/WebCore.vcproj:
  63868. 2008-10-02 Geoffrey Garen <ggaren@apple.com>
  63869. Not reviewed.
  63870. Try to fix some more builds.
  63871. * GNUmakefile.am:
  63872. * WebCore.pro:
  63873. 2008-10-02 Geoffrey Garen <ggaren@apple.com>
  63874. Not reviewed.
  63875. Try to fix Windows build.
  63876. * WebCore.vcproj/WebCore.vcproj:
  63877. 2008-10-01 Geoffrey Garen <ggaren@apple.com>
  63878. Reviewed by Darin Adler and Cameron Zwarich.
  63879. Updated for JavaScriptCore API changes: use a SourceCode instead of
  63880. broken out parameters; treat sourceId as intptr_t.
  63881. * ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  63882. * bindings/js/JSXMLHttpRequestCustom.cpp:
  63883. (WebCore::JSXMLHttpRequest::send):
  63884. * bindings/js/ScriptController.cpp:
  63885. (WebCore::ScriptController::evaluate):
  63886. * bindings/js/StringSourceProvider.h:
  63887. (WebCore::StringSourceProvider::create):
  63888. (WebCore::StringSourceProvider::StringSourceProvider):
  63889. (WebCore::makeSource): Added a makeSource function for convenience.
  63890. * bindings/objc/WebScriptObject.mm:
  63891. (-[WebScriptObject evaluateWebScript:]):
  63892. * bridge/NP_jsobject.cpp:
  63893. (_NPN_Evaluate):
  63894. * bridge/jni/jni_jsobject.mm:
  63895. (JavaJSObject::call):
  63896. (JavaJSObject::eval):
  63897. (JavaJSObject::getMember):
  63898. (JavaJSObject::setMember):
  63899. (JavaJSObject::removeMember):
  63900. * bridge/jni/jni_runtime.h:
  63901. (JSC::Bindings::JavaString::operator UString): Replaced the explicit
  63902. ustring() function with an implicit operator because this class already
  63903. holds a UString::rep.
  63904. * page/Console.cpp:
  63905. (WebCore::retrieveLastCaller):
  63906. (WebCore::Console::trace):
  63907. * page/InspectorController.cpp:
  63908. (WebCore::jsStringRef):
  63909. (WebCore::InspectorController::addBreakpoint):
  63910. (WebCore::InspectorController::removeBreakpoint):
  63911. (WebCore::InspectorController::didParseSource):
  63912. (WebCore::InspectorController::failedToParseSource):
  63913. * page/InspectorController.h:
  63914. * page/JavaScriptCallFrame.cpp:
  63915. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  63916. * page/JavaScriptCallFrame.h:
  63917. (WebCore::JavaScriptCallFrame::create):
  63918. (WebCore::JavaScriptCallFrame::sourceIdentifier):
  63919. (WebCore::JavaScriptCallFrame::update):
  63920. * page/JavaScriptDebugListener.h:
  63921. * page/JavaScriptDebugServer.cpp:
  63922. (WebCore::JavaScriptDebugServer::addBreakpoint):
  63923. (WebCore::JavaScriptDebugServer::removeBreakpoint):
  63924. (WebCore::JavaScriptDebugServer::hasBreakpoint):
  63925. (WebCore::dispatchDidParseSource):
  63926. (WebCore::dispatchFailedToParseSource):
  63927. (WebCore::JavaScriptDebugServer::sourceParsed):
  63928. (WebCore::JavaScriptDebugServer::callEvent):
  63929. (WebCore::JavaScriptDebugServer::atStatement):
  63930. (WebCore::JavaScriptDebugServer::returnEvent):
  63931. (WebCore::JavaScriptDebugServer::exception):
  63932. (WebCore::JavaScriptDebugServer::willExecuteProgram):
  63933. (WebCore::JavaScriptDebugServer::didExecuteProgram):
  63934. (WebCore::JavaScriptDebugServer::didReachBreakpoint):
  63935. * page/JavaScriptDebugServer.h:
  63936. * page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and
  63937. sourceIdentifier to sourceID.
  63938. 2008-10-01 Dan Bernstein <mitz@apple.com>
  63939. Reviewed by Geoffrey Garen.
  63940. - fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html
  63941. Broke a ref cycle by changing the m_svgFontFaceElement members of
  63942. CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
  63943. pointers. Also made sure that the @font-face rule added by
  63944. SVGFontFaceElement to the document's mapped element sheet is removed
  63945. when the font-face element is deleted or moved to another document.
  63946. * css/CSSFontFaceSource.cpp:
  63947. (WebCore::CSSFontFaceSource::CSSFontFaceSource):
  63948. (WebCore::CSSFontFaceSource::getFontData):
  63949. * css/CSSFontFaceSource.h:
  63950. (WebCore::CSSFontFaceSource::svgFontFaceElement):
  63951. * css/CSSFontFaceSrcValue.h:
  63952. (WebCore::CSSFontFaceSrcValue::svgFontFaceElement):
  63953. (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
  63954. * svg/SVGFontFaceElement.cpp:
  63955. (WebCore::SVGFontFaceElement::~SVGFontFaceElement):
  63956. (WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument):
  63957. (WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument):
  63958. (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  63959. * svg/SVGFontFaceElement.h:
  63960. 2008-10-01 Oliver Hunt <oliver@apple.com>
  63961. Reviewed by Maciej Stachowiak.
  63962. Bug 20315: Memory leak with Canvas getImageData
  63963. <https://bugs.webkit.org/show_bug.cgi?id=20315>
  63964. This wasn't a leak, the issue was that we were reporting the cost
  63965. of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
  63966. and we should have been reporting the cost when we create the
  63967. JSImageData wrapper.
  63968. * WebCore.xcodeproj/project.pbxproj:
  63969. * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed.
  63970. This was only needed to report the extra memory cost
  63971. of the CPA.
  63972. * bindings/js/JSImageDataCustom.cpp:
  63973. (WebCore::toJS):
  63974. We need a custom toJS function now so that we can report
  63975. the extra memory cost.
  63976. * bindings/scripts/CodeGeneratorJS.pm:
  63977. Need to replace the reference to CanvasPixelArray with ImageData
  63978. to be able to create the custom toJS implementation.
  63979. * html/CanvasPixelArray.idl:
  63980. * html/ImageData.idl:
  63981. 2008-10-01 Dan Bernstein <mitz@apple.com>
  63982. Reviewed by Mark Rowe.
  63983. - https://bugs.webkit.org/show_bug.cgi?id=21293
  63984. REGRESSION: Crash beneath RenderSVGViewportContainer::viewportTransform() during SVGSVGElement destruction
  63985. * svg/SVGMarkerElement.cpp:
  63986. (WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so
  63987. that renderer destruction happens before the SVGMarkerElement is
  63988. destroyed.
  63989. * svg/SVGSVGElement.cpp:
  63990. (WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
  63991. 2008-10-01 Evan Martin <evan@chromium.org>
  63992. Reviewed by Eric Seidel.
  63993. https://bugs.webkit.org/show_bug.cgi?id=20669
  63994. * css/makeprop.pl:
  63995. Die if gperf fails.
  63996. 2008-10-01 Evan Martin <evan@chromium.org>
  63997. Reviewed by Eric Seidel.
  63998. * loader/icon/IconDatabase.h:
  63999. IconDatabase uses HashMap, so it needs to #include the header.
  64000. 2008-10-01 Dan Bernstein <mitz@apple.com>
  64001. Reviewed by Mark Rowe.
  64002. - fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
  64003. * loader/Cache.cpp:
  64004. (WebCore::Cache::remove): Disable pruning temporarily during
  64005. CachedResource deletion.
  64006. 2008-10-01 Dan Bernstein <mitz@apple.com>
  64007. Reviewed by Mark Rowe.
  64008. - fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
  64009. * svg/SVGFontFaceElement.cpp:
  64010. (WebCore::SVGFontFaceElement::rebuildFontFace):
  64011. * svg/SVGFontFaceElement.h:
  64012. (WebCore::SVGFontFaceElement::associatedFontElement):
  64013. 2008-10-01 Brett Wilson <brettw@chromium.org>
  64014. Reviewed by Maciej Stachowiak.
  64015. Document the rounding behavior of the mapRect(IntRect) function in
  64016. AffineTransform.h.
  64017. * platform/graphics/AffineTransform.h:
  64018. 2008-10-01 David Hyatt <hyatt@apple.com>
  64019. Move prohibitsScrolling from the Frame to the ScrollView.
  64020. Reviewed by Sam Weinig
  64021. * WebCore.base.exp:
  64022. * page/Frame.cpp:
  64023. (WebCore::FramePrivate::FramePrivate):
  64024. * page/Frame.h:
  64025. * page/FramePrivate.h:
  64026. * page/FrameView.cpp:
  64027. (WebCore::FrameView::scrollRectIntoViewRecursively):
  64028. (WebCore::FrameView::setScrollPosition):
  64029. * platform/ScrollView.cpp:
  64030. (WebCore::ScrollView::init):
  64031. (WebCore::ScrollView::scrollRectIntoViewRecursively):
  64032. (WebCore::ScrollView::setScrollPosition):
  64033. * platform/ScrollView.h:
  64034. (WebCore::ScrollView::setProhibitsScrolling):
  64035. (WebCore::ScrollView::prohibitsScrolling):
  64036. * platform/gtk/ScrollViewGtk.cpp:
  64037. (WebCore::ScrollView::updateScrollbars):
  64038. * platform/qt/ScrollViewQt.cpp:
  64039. (WebCore::ScrollView::updateScrollbars):
  64040. * platform/win/ScrollViewWin.cpp:
  64041. (WebCore::ScrollView::updateScrollbars):
  64042. 2008-10-01 Mark Rowe <mrowe@apple.com>
  64043. Reviewed by Geoff Garen.
  64044. Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.
  64045. * xml/XMLHttpRequest.cpp:
  64046. (WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
  64047. that we do during the loadRequestAsynchronously of the preflight request with a deref and
  64048. GC unprotect.
  64049. 2008-10-01 David Hyatt <hyatt@apple.com>
  64050. Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
  64051. clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.
  64052. Reviewed by Tim Hatcher
  64053. * WebCore.base.exp:
  64054. * page/FrameView.cpp:
  64055. (WebCore::FrameView::setCanHaveScrollbars):
  64056. * page/FrameView.h:
  64057. * platform/ScrollView.cpp:
  64058. (WebCore::ScrollView::setCanHaveScrollbars):
  64059. (WebCore::ScrollView::wheelEvent):
  64060. * platform/ScrollView.h:
  64061. (WebCore::ScrollView::canHaveScrollbars):
  64062. 2008-10-01 Dan Bernstein <mitz@apple.com>
  64063. Reviewed by Mark Rowe.
  64064. - fix some CachedResource leaks seen on buildbot
  64065. The issue here was that emptying the cache was a no-op when it only
  64066. contained resources with no data. Changed to go after those
  64067. resources when the desired cache capacity is zero.
  64068. * loader/Cache.cpp:
  64069. (WebCore::Cache::pruneLiveResources):
  64070. (WebCore::Cache::pruneDeadResources):
  64071. * loader/Cache.h:
  64072. (WebCore::Cache::prune):
  64073. 2008-10-01 David Hyatt <hyatt@apple.com>
  64074. Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
  64075. HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)
  64076. Reviewed by Adam Roben
  64077. * platform/ScrollView.cpp:
  64078. (WebCore::ScrollView::isOffscreen):
  64079. (WebCore::ScrollView::platformIsOffscreen):
  64080. * platform/ScrollView.h:
  64081. * platform/gtk/ScrollViewGtk.cpp:
  64082. * platform/mac/ScrollViewMac.mm:
  64083. (WebCore::ScrollView::platformIsOffscreen):
  64084. * platform/qt/ScrollViewQt.cpp:
  64085. * platform/wx/ScrollViewWx.cpp:
  64086. 2008-10-01 David Hyatt <hyatt@apple.com>
  64087. Make show/hide/setParentVisible cross-platform on ScrollView.
  64088. Reviewed by Adam Roben
  64089. * platform/ScrollView.cpp:
  64090. (WebCore::ScrollView::setParentVisible):
  64091. (WebCore::ScrollView::show):
  64092. (WebCore::ScrollView::hide):
  64093. * platform/ScrollView.h:
  64094. * platform/win/ScrollViewWin.cpp:
  64095. 2008-10-01 Kevin McCullough <kmccullough@apple.com>
  64096. Reviewed by Dan Bernstein.
  64097. https://bugs.webkit.org/show_bug.cgi?id=21284
  64098. Bug 21284: Max height affects max width
  64099. - Looks like a cut and paste bug
  64100. - Added layout test fast/css/max-height-and-max-width.html
  64101. * css/CSSComputedStyleDeclaration.cpp:
  64102. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  64103. 2008-10-01 David Hyatt <hyatt@apple.com>
  64104. https://bugs.webkit.org/show_bug.cgi?id=21282
  64105. Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.
  64106. Reviewed by Adam Roben
  64107. * loader/EmptyClients.h:
  64108. (WebCore::EmptyChromeClient::screenToWindow):
  64109. (WebCore::EmptyChromeClient::windowToScreen):
  64110. * page/Chrome.cpp:
  64111. (WebCore::Chrome::screenToWindow):
  64112. (WebCore::Chrome::windowToScreen):
  64113. * page/Chrome.h:
  64114. * page/ChromeClient.h:
  64115. * platform/HostWindow.h:
  64116. * platform/ScrollView.cpp:
  64117. (WebCore::ScrollView::contentsToScreen):
  64118. (WebCore::ScrollView::screenToContents):
  64119. (WebCore::ScrollView::platformContentsToScreen):
  64120. (WebCore::ScrollView::platformScreenToContents):
  64121. * platform/ScrollView.h:
  64122. * platform/mac/ScrollViewMac.mm:
  64123. (WebCore::ScrollView::platformContentsToScreen):
  64124. (WebCore::ScrollView::platformScreenToContents):
  64125. * platform/win/ScrollViewWin.cpp:
  64126. 2008-10-01 Dan Bernstein <mitz@apple.com>
  64127. Reviewed by Darin Adler.
  64128. - fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
  64129. Test: fast/parser/residual-style-close-across-removed-block.html
  64130. * html/HTMLParser.cpp:
  64131. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed
  64132. an assertion that turned out to be wrong in this case, and changed to
  64133. terminate the algorithm at the first empty block.
  64134. 2008-10-01 David Hyatt <hyatt@apple.com>
  64135. Make setFrameRect on ScrollView cross-platform.
  64136. Reviewed by Sam Weinig
  64137. * page/FrameView.h:
  64138. (WebCore::FrameView::contentsResized):
  64139. * platform/ScrollView.cpp:
  64140. (WebCore::ScrollView::setFrameRect):
  64141. * platform/ScrollView.h:
  64142. * platform/gtk/ScrollViewGtk.cpp:
  64143. * platform/qt/ScrollViewQt.cpp:
  64144. * platform/win/ScrollViewWin.cpp:
  64145. 2008-10-01 Sam Weinig <sam@webkit.org>
  64146. Reviewed by Adele Peterson.
  64147. Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
  64148. to JSDOMWindow from JSDOMWindowBase.
  64149. * WebCore.xcodeproj/project.pbxproj:
  64150. * bindings/js/JSDOMWindowBase.cpp:
  64151. (WebCore::JSDOMWindowBase::removeTimeout):
  64152. * bindings/js/JSDOMWindowBase.h:
  64153. * bindings/js/JSDOMWindowCustom.cpp:
  64154. (WebCore::setTimeoutOrInterval):
  64155. (WebCore::JSDOMWindow::setTimeout):
  64156. (WebCore::JSDOMWindow::clearTimeout):
  64157. (WebCore::JSDOMWindow::setInterval):
  64158. (WebCore::JSDOMWindow::clearInterval):
  64159. (WebCore::JSDOMWindow::atob):
  64160. (WebCore::JSDOMWindow::btoa):
  64161. * page/DOMWindow.idl:
  64162. 2008-10-01 Dan Bernstein <mitz@apple.com>
  64163. - Mac build fix
  64164. * WebCore.base.exp:
  64165. 2008-10-01 Timothy Hatcher <timothy@apple.com>
  64166. Prevent stealing focus from the search field when focusing a DOM node.
  64167. https://bugs.webkit.org/show_bug.cgi?id=21275
  64168. Reviewed by Kevin McCullough.
  64169. * page/inspector/ElementsPanel.js:
  64170. (WebInspector.ElementsPanel.treeOutline.focusedNodeChanged):
  64171. Don't steal focus if the current focus element is the search field.
  64172. 2008-09-30 Sam Weinig <sam@webkit.org>
  64173. Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.
  64174. Final patch for https://bugs.webkit.org/show_bug.cgi?id=21122
  64175. Autogenerate JS event listeners
  64176. - Generate getting/setting of EventListeners.
  64177. - Adding a new named EventListener now has the same process as adding any other DOM
  64178. attribute. (Add a method with the same name in the c++ file).
  64179. (The EventListeners for MessagePort have been intentionally left custom so that we
  64180. can continue to experiment with making those EventListeners work in a frame-less world.)
  64181. * bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
  64182. * bindings/js/JSDOMWindowCustom.cpp: ditto.
  64183. * bindings/js/JSEventTargetNodeCustom.cpp: ditto.
  64184. * bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
  64185. * bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
  64186. * bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener
  64187. getter/setters
  64188. * dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
  64189. * dom/EventTargetNode.h: ditto.
  64190. * dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator
  64191. will use JSEventListerner instead of JSUnprotectedEventListener.
  64192. * loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
  64193. * page/DOMWindow.cpp: Add getter/setters for named EventListener
  64194. * page/DOMWindow.h: ditto.
  64195. * page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator
  64196. will use JSEventListerner instead of JSUnprotectedEventListener.
  64197. * xml/XMLHttpRequest.idl: Remove custom attributes.
  64198. * xml/XMLHttpRequestUpload.idl: ditto.
  64199. 2008-09-30 Mark Rowe <mrowe@apple.com>
  64200. Reviewed by Dan Bernstein.
  64201. Add a leak counter for CachedResources since we've had two recent leaks involving them.
  64202. * loader/CachedResource.cpp:
  64203. (WebCore::CachedResource::CachedResource):
  64204. (WebCore::CachedResource::~CachedResource):
  64205. 2008-09-30 Dan Bernstein <mitz@apple.com>
  64206. Reviewed by Dave Hyatt.
  64207. - fix https://bugs.webkit.org/show_bug.cgi?id=21127
  64208. <rdar://problem/6259134> REGRESSION: CFF format fonts fail to load
  64209. If TTLoadEmbeddedFont fails, use AddFontMemResourceEx after changing
  64210. the font name in memory.
  64211. * WebCore.vcproj/WebCore.vcproj: Renamed GetEOTHeader.* to
  64212. OpenTypeUtilities.*.
  64213. * platform/graphics/win/FontCustomPlatformData.cpp:
  64214. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a call
  64215. to RemoveFontMemResourceEx to match AddFontMemResourceEx when it is
  64216. used.
  64217. (WebCore::FontCustomPlatformData::fontPlatformData): Added a code path
  64218. for fonts loaded using AddFontMemResourceEx.
  64219. (WebCore::createFontCustomPlatformData): Added a call to
  64220. renameAndActivateFont() if TTLoadEmbeddedFont fails. If
  64221. TTLoadEmbeddedFont succeeds, set the font name to the null string, as
  64222. fontPlatformData() will retrieve the name from the font reference.
  64223. * platform/graphics/win/FontCustomPlatformData.h:
  64224. (WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a
  64225. font name member.
  64226. * platform/graphics/win/GetEOTHeader.cpp: Renamed.
  64227. * platform/graphics/win/GetEOTHeader.h: Renamed.
  64228. * platform/graphics/win/OpenTypeUtilities.cpp: Copied from platform/graphics/win/GetEOTHeader.cpp.
  64229. (WebCore::BigEndianUShort::BigEndianUShort): Added a constructor.
  64230. (WebCore::BigEndianULong::BigEndianULong): Ditto.
  64231. (WebCore::renameAndActivateFont): Added. Creates an in-memory copy of
  64232. the font data and modifies it to have the given name, then activates
  64233. it using AddFontMemResourceEx.
  64234. * platform/graphics/win/OpenTypeUtilities.h: Copied from platform/graphics/win/GetEOTHeader.h.
  64235. 2008-09-30 Mark Rowe <mrowe@apple.com>
  64236. Reviewed by Dan Bernstein.
  64237. Fix many leaks seen on fast/backgrounds/svg-as-mask.html.
  64238. * rendering/RenderObject.cpp:
  64239. (WebCore::RenderObject::arenaDelete): Balance the calls to addClient on maskLayer's images
  64240. with calls to removeClient when we're being destroyed.
  64241. 2008-09-30 Eric Carlson <eric.carlson@apple.com>
  64242. Reviewed by Antti Koivisto.
  64243. https://bugs.webkit.org/show_bug.cgi?id=21243
  64244. Fix loopstart and loopend default values.
  64245. Tests: media/loopend-limits.html
  64246. media/loopstart-limits.html
  64247. * html/HTMLMediaElement.cpp:
  64248. (WebCore::HTMLMediaElement::loopStart): the spec says start() is the default value
  64249. (WebCore::HTMLMediaElement::loopEnd): the spec says end() is the default value
  64250. 2008-09-30 Kevin Ollivier <kevino@theolliviers.com>
  64251. wx build fixes. Add file to build and remove call to (now gone) ScrollView::update.
  64252. * WebCoreSources.bkl:
  64253. * platform/wx/ScrollViewWx.cpp:
  64254. (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
  64255. 2008-09-30 Dan Bernstein <mitz@apple.com>
  64256. Reviewed by Sam Weinig.
  64257. - fix HTMLViewSourceDocument leaks by breaking a ref cycle which
  64258. was fixed in r17249 and re-introduced in r31435.
  64259. * html/HTMLViewSourceDocument.cpp:
  64260. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  64261. (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
  64262. (WebCore::HTMLViewSourceDocument::addLine):
  64263. (WebCore::HTMLViewSourceDocument::addLink):
  64264. * html/HTMLViewSourceDocument.h:
  64265. 2008-09-30 Sam Weinig <sam@webkit.org>
  64266. Reviewed by Eric Seidel.
  64267. More for https://bugs.webkit.org/show_bug.cgi?id=21122
  64268. Autogenerate JS event listeners
  64269. - Make EventListener getter/setters names in c++ files match those in
  64270. JS (ie. onLoadListener -> onload).
  64271. - Add standard way to access the frame associated with the EventTarget
  64272. for EventListener lookup.
  64273. - Autogenerate dispatchEvent, it wasn't doing anything custom.
  64274. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  64275. (WebCore::JSDOMApplicationCache::mark):
  64276. (WebCore::JSDOMApplicationCache::addEventListener):
  64277. (WebCore::JSDOMApplicationCache::removeEventListener):
  64278. (WebCore::JSDOMApplicationCache::setOnchecking):
  64279. (WebCore::JSDOMApplicationCache::onchecking):
  64280. (WebCore::JSDOMApplicationCache::setOnerror):
  64281. (WebCore::JSDOMApplicationCache::onerror):
  64282. (WebCore::JSDOMApplicationCache::setOnnoupdate):
  64283. (WebCore::JSDOMApplicationCache::onnoupdate):
  64284. (WebCore::JSDOMApplicationCache::setOndownloading):
  64285. (WebCore::JSDOMApplicationCache::ondownloading):
  64286. (WebCore::JSDOMApplicationCache::setOnprogress):
  64287. (WebCore::JSDOMApplicationCache::onprogress):
  64288. (WebCore::JSDOMApplicationCache::setOnupdateready):
  64289. (WebCore::JSDOMApplicationCache::onupdateready):
  64290. (WebCore::JSDOMApplicationCache::setOncached):
  64291. (WebCore::JSDOMApplicationCache::oncached):
  64292. * bindings/js/JSEventTargetNodeCustom.cpp:
  64293. (WebCore::JSEventTargetNode::addEventListener):
  64294. (WebCore::JSEventTargetNode::removeEventListener):
  64295. (WebCore::JSEventTargetNode::getListener):
  64296. (WebCore::JSEventTargetNode::setListener):
  64297. * bindings/js/JSMessagePortCustom.cpp:
  64298. (WebCore::JSMessagePort::mark):
  64299. (WebCore::JSMessagePort::addEventListener):
  64300. (WebCore::JSMessagePort::removeEventListener):
  64301. (WebCore::JSMessagePort::setOnmessage):
  64302. (WebCore::JSMessagePort::onmessage):
  64303. (WebCore::JSMessagePort::setOnclose):
  64304. (WebCore::JSMessagePort::onclose):
  64305. * bindings/js/JSXMLHttpRequestCustom.cpp:
  64306. (WebCore::JSXMLHttpRequest::mark):
  64307. (WebCore::JSXMLHttpRequest::onreadystatechange):
  64308. (WebCore::JSXMLHttpRequest::setOnreadystatechange):
  64309. (WebCore::JSXMLHttpRequest::onabort):
  64310. (WebCore::JSXMLHttpRequest::setOnabort):
  64311. (WebCore::JSXMLHttpRequest::onerror):
  64312. (WebCore::JSXMLHttpRequest::setOnerror):
  64313. (WebCore::JSXMLHttpRequest::onload):
  64314. (WebCore::JSXMLHttpRequest::setOnload):
  64315. (WebCore::JSXMLHttpRequest::onloadstart):
  64316. (WebCore::JSXMLHttpRequest::setOnloadstart):
  64317. (WebCore::JSXMLHttpRequest::onprogress):
  64318. (WebCore::JSXMLHttpRequest::setOnprogress):
  64319. (WebCore::JSXMLHttpRequest::addEventListener):
  64320. (WebCore::JSXMLHttpRequest::removeEventListener):
  64321. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  64322. (WebCore::JSXMLHttpRequestUpload::mark):
  64323. (WebCore::JSXMLHttpRequestUpload::onabort):
  64324. (WebCore::JSXMLHttpRequestUpload::setOnabort):
  64325. (WebCore::JSXMLHttpRequestUpload::onerror):
  64326. (WebCore::JSXMLHttpRequestUpload::setOnerror):
  64327. (WebCore::JSXMLHttpRequestUpload::onload):
  64328. (WebCore::JSXMLHttpRequestUpload::setOnload):
  64329. (WebCore::JSXMLHttpRequestUpload::onloadstart):
  64330. (WebCore::JSXMLHttpRequestUpload::setOnloadstart):
  64331. (WebCore::JSXMLHttpRequestUpload::onprogress):
  64332. (WebCore::JSXMLHttpRequestUpload::setOnprogress):
  64333. (WebCore::JSXMLHttpRequestUpload::addEventListener):
  64334. (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  64335. * bindings/scripts/CodeGeneratorJS.pm:
  64336. * dom/EventTarget.h:
  64337. * dom/EventTargetNode.cpp:
  64338. (WebCore::EventTargetNode::associatedFrame):
  64339. * dom/EventTargetNode.h:
  64340. * dom/EventTargetNode.idl:
  64341. * dom/MessagePort.cpp:
  64342. (WebCore::MessagePort::associatedFrame):
  64343. * dom/MessagePort.h:
  64344. (WebCore::MessagePort::setOnmessage):
  64345. (WebCore::MessagePort::onmessage):
  64346. (WebCore::MessagePort::setOnclose):
  64347. (WebCore::MessagePort::onclose):
  64348. * dom/MessagePort.idl:
  64349. * loader/appcache/DOMApplicationCache.h:
  64350. (WebCore::DOMApplicationCache::setOnchecking):
  64351. (WebCore::DOMApplicationCache::onchecking):
  64352. (WebCore::DOMApplicationCache::setOnerror):
  64353. (WebCore::DOMApplicationCache::onerror):
  64354. (WebCore::DOMApplicationCache::setOnnoupdate):
  64355. (WebCore::DOMApplicationCache::onnoupdate):
  64356. (WebCore::DOMApplicationCache::setOndownloading):
  64357. (WebCore::DOMApplicationCache::ondownloading):
  64358. (WebCore::DOMApplicationCache::setOnprogress):
  64359. (WebCore::DOMApplicationCache::onprogress):
  64360. (WebCore::DOMApplicationCache::setOnupdateready):
  64361. (WebCore::DOMApplicationCache::onupdateready):
  64362. (WebCore::DOMApplicationCache::setOncached):
  64363. (WebCore::DOMApplicationCache::oncached):
  64364. (WebCore::DOMApplicationCache::associatedFrame):
  64365. * loader/appcache/DOMApplicationCache.idl:
  64366. * svg/EventTargetSVGElementInstance.cpp:
  64367. (WebCore::EventTargetSVGElementInstance::associatedFrame):
  64368. (WebCore::EventTargetSVGElementInstance::addEventListener):
  64369. (WebCore::EventTargetSVGElementInstance::removeEventListener):
  64370. (WebCore::EventTargetSVGElementInstance::dispatchEvent):
  64371. * svg/EventTargetSVGElementInstance.h:
  64372. * xml/XMLHttpRequest.cpp:
  64373. (WebCore::XMLHttpRequest::associatedFrame):
  64374. * xml/XMLHttpRequest.h:
  64375. (WebCore::XMLHttpRequest::setOnreadystatechange):
  64376. (WebCore::XMLHttpRequest::onreadystatechange):
  64377. (WebCore::XMLHttpRequest::setOnabort):
  64378. (WebCore::XMLHttpRequest::onabort):
  64379. (WebCore::XMLHttpRequest::setOnerror):
  64380. (WebCore::XMLHttpRequest::onerror):
  64381. (WebCore::XMLHttpRequest::setOnload):
  64382. (WebCore::XMLHttpRequest::onload):
  64383. (WebCore::XMLHttpRequest::setOnloadstart):
  64384. (WebCore::XMLHttpRequest::onloadstart):
  64385. (WebCore::XMLHttpRequest::setOnprogress):
  64386. (WebCore::XMLHttpRequest::onprogress):
  64387. * xml/XMLHttpRequest.idl:
  64388. * xml/XMLHttpRequestUpload.cpp:
  64389. (WebCore::XMLHttpRequestUpload::associatedFrame):
  64390. * xml/XMLHttpRequestUpload.h:
  64391. (WebCore::XMLHttpRequestUpload::setOnabort):
  64392. (WebCore::XMLHttpRequestUpload::onabort):
  64393. (WebCore::XMLHttpRequestUpload::setOnerror):
  64394. (WebCore::XMLHttpRequestUpload::onerror):
  64395. (WebCore::XMLHttpRequestUpload::setOnload):
  64396. (WebCore::XMLHttpRequestUpload::onload):
  64397. (WebCore::XMLHttpRequestUpload::setOnloadstart):
  64398. (WebCore::XMLHttpRequestUpload::onloadstart):
  64399. (WebCore::XMLHttpRequestUpload::setOnprogress):
  64400. (WebCore::XMLHttpRequestUpload::onprogress):
  64401. * xml/XMLHttpRequestUpload.idl:
  64402. 2008-09-30 Darin Adler <darin@apple.com>
  64403. - roll out assertion breaking regression tests
  64404. * platform/ScrollView.cpp:
  64405. (WebCore::ScrollView::repaintContentRectangle): Temporarily remove assertion
  64406. that fires in regression tests. Hyatt can add it back later. The assertion
  64407. fires in the regression test because of layout that triggers repaint occuring
  64408. during the process of removing a frame.
  64409. 2008-09-30 Adele Peterson <adele@apple.com>
  64410. Reviewed by Darin Adler.
  64411. Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
  64412. <rdar://problem/6222134> add a way to set color for input placeholder text
  64413. Test: fast/forms/placeholder-pseudo-style.html
  64414. This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
  64415. input elements when they are displaying the placeholder text.
  64416. * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
  64417. * css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
  64418. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  64419. Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
  64420. * css/html4.css: Add rule to make placeholder text default to darkGray.
  64421. * html/HTMLInputElement.cpp:
  64422. (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible.
  64423. (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility.
  64424. (WebCore::HTMLInputElement::dispatchBlurEvent): ditto.
  64425. (WebCore::HTMLInputElement::parseMappedAttribute): ditto.
  64426. (WebCore::HTMLInputElement::setValue): ditto.
  64427. (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
  64428. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state.
  64429. This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the
  64430. renderer will just ask the node if it should draw the placeholder.
  64431. * html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
  64432. * rendering/RenderTextControl.cpp:
  64433. (WebCore::disabledTextColor): Moved to the top of the file. If there's not very much contrast between the disabled color and the background color,
  64434. just leave the text color alone. We don't want to change a good contrast color scheme so that it has really bad contrast.
  64435. If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme.
  64436. (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none".
  64437. This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which
  64438. is called directly from updateFromElement. updateFromElement will immediately update the text displayed.
  64439. (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed.
  64440. (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state. This is now done in HTMLInputElement.
  64441. * rendering/RenderTextControl.h:
  64442. 2008-09-30 Beth Dakin <bdakin@apple.com>
  64443. Reviewed by Darin Adler.
  64444. Fix for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
  64445. by failed allocation due to invalid counter/attr
  64446. and corresponding: <rdar://problem/6152371>
  64447. * css/CSSParser.cpp:
  64448. (WebCore::CSSParser::parseCounterContent): The spec indicates that
  64449. only identifiers should be accepted here.
  64450. 2008-09-30 Kevin McCullough <kmccullough@apple.com>
  64451. Reviewed by Oliver Hunt.
  64452. Bug 21255: console.profileEnd() without a console.profile() crashes the
  64453. web inspector
  64454. * page/Console.cpp:
  64455. (WebCore::Console::profileEnd):
  64456. 2008-09-30 Kevin McCullough <kmccullough@apple.com>
  64457. Reviewed by Tim Hatcher.
  64458. Bug 21252: calling console.profile() with a title that is 2 chars or
  64459. shorter does not linkify it
  64460. - Previously we tried to not linkify very short URLs but since profile
  64461. titles can be any length this is not always true.
  64462. * page/inspector/inspector.js:
  64463. 2008-09-30 Dave Hyatt <hyatt@apple.com>
  64464. Remove the update() method on ScrollView. This method was only called in one place, and its purpose
  64465. was to cause a display/flush to happen. Here is a breakdown of the method use on each platform:
  64466. (1) Not used on Mac
  64467. (2) Used on Windows
  64468. (3) Used on Qt, but implemented incorrectly to cause a full repaint for no reason.
  64469. (4) Used on Gtk, but implemented incorrectly to cause a full repaint for no reason.
  64470. (5) Used on wx, but probably not needed (since wx has platform widgets like Mac).
  64471. There is now a paint method on HostWindow that does an immediate mode repaint of an empty rect to
  64472. cause the display/flush to happen if needed (thus saving an extra method on ChromeClient).
  64473. With the changes to this method, the new behavior is as follows:
  64474. (1) Not used on Mac
  64475. (2) Used on Windows
  64476. (3) Nothing happens on Qt, but only because they have not implemented immediate mode updating.
  64477. (4) Gtk now behaves like Windows and will process updates but not do any incorrect additional invalidation.
  64478. (5) Not used on wx
  64479. This method was originally added for Windows. It's not clear the display/flush is really even necessary on the other
  64480. platforms. At the very least stopping unnecessary full invalidations on Qt/Gtk is a good thing. :)
  64481. Reviewed by Sam Weinig
  64482. * ChangeLog:
  64483. * dom/Document.cpp:
  64484. (WebCore::Document::implicitClose):
  64485. * platform/HostWindow.h:
  64486. (WebCore::HostWindow::paint):
  64487. * platform/ScrollView.h:
  64488. * platform/gtk/ScrollViewGtk.cpp:
  64489. * platform/mac/ScrollViewMac.mm:
  64490. * platform/qt/ScrollViewQt.cpp:
  64491. * platform/win/ScrollViewWin.cpp:
  64492. * platform/wx/ScrollViewWx.cpp:
  64493. 2008-09-30 Timothy Hatcher <timothy@apple.com>
  64494. Focus the DOM tree in the Web Inspector when a node is inspected.
  64495. So when the search field has focus, the focus moves to the tree,
  64496. allowing the arrow keys work. This can happen when using the new
  64497. find in page feature.
  64498. https://bugs.webkit.org/show_bug.cgi?id=21251
  64499. Reviewed by Geoff Garen.
  64500. * page/inspector/ElementsPanel.js:
  64501. (WebInspector.ElementsPanel): Set currentFocusElement to
  64502. the main-panels element if the panel is visible.
  64503. (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  64504. Remove a set of currentFocusElement since this moved.
  64505. * page/inspector/inspector.js:
  64506. (WebInspector.set currentFocusElement): Always focus the element.
  64507. This ensures that when focus changes in the page and we don't
  64508. catch it, we will still focus the elements even if we think it
  64509. was already focused.
  64510. 2008-09-30 Timothy Hatcher <timothy@apple.com>
  64511. Make the Web Inspector's toolbar icons darker when the mouse is
  64512. pressed on them. This matches the standard NSToolbar look.
  64513. https://bugs.webkit.org/show_bug.cgi?id=21249
  64514. rdar://problem/6033752
  64515. Reviewed by Adam Roben.
  64516. * page/inspector/Images/databasesIcon.png:
  64517. * page/inspector/Images/elementsIcon.png:
  64518. * page/inspector/Images/profilesIcon.png:
  64519. * page/inspector/Images/resourcesIcon.png:
  64520. * page/inspector/Images/scriptsIcon.png:
  64521. * page/inspector/Panel.js:
  64522. * page/inspector/inspector.css:
  64523. 2008-09-30 Kevin McCullough <kmccullough@apple.com>
  64524. Reviewed by Tim Hatcher.
  64525. Bug 21139: Profiler log message is wrong
  64526. - Correctly fix =(
  64527. Don't call _format twice.
  64528. * page/Page.h:
  64529. * page/inspector/Console.js:
  64530. * page/inspector/ProfilesPanel.js:
  64531. * page/inspector/inspector.js:
  64532. 2008-09-30 Dave Hyatt <hyatt@apple.com>
  64533. http://bugs.webkit.org/show_bug.cgi?id=21250
  64534. Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
  64535. repaints up through the ChromeClient.
  64536. Reviewed by Darin Adler
  64537. * loader/EmptyClients.h:
  64538. (WebCore::EmptyChromeClient::repaint):
  64539. * page/Chrome.cpp:
  64540. (WebCore::Chrome::repaint):
  64541. * page/Chrome.h:
  64542. * page/ChromeClient.h:
  64543. * page/FrameView.cpp:
  64544. (WebCore::FrameView::hostWindow):
  64545. (WebCore::FrameView::repaintContentRectangle):
  64546. * page/FrameView.h:
  64547. * platform/HostWindow.h:
  64548. * platform/ScrollView.cpp:
  64549. (WebCore::ScrollView::repaintContentRectangle):
  64550. (WebCore::ScrollView::platformRepaintContentRectangle):
  64551. * platform/ScrollView.h:
  64552. * platform/gtk/ScrollViewGtk.cpp:
  64553. * platform/mac/ScrollViewMac.mm:
  64554. (WebCore::ScrollView::platformRepaintContentRectangle):
  64555. * platform/qt/ScrollViewQt.cpp:
  64556. * platform/win/ScrollViewWin.cpp:
  64557. * platform/wx/ScrollViewWx.cpp:
  64558. (WebCore::ScrollView::platformRepaintContentRectangle):
  64559. 2008-09-30 Alexey Proskuryakov <ap@webkit.org>
  64560. Non-Mac build fixes.
  64561. * GNUmakefile.am:
  64562. * WebCore.pro:
  64563. * WebCore.vcproj/WebCore.vcproj:
  64564. * WebCoreSources.bkl:
  64565. * webcore-base.bkl:
  64566. Added DOMProtect.{cpp,h}.
  64567. 2008-09-39 Kevin Decker <kdecker@apple.com>
  64568. Reviewed by John Sullivan.
  64569. * bridge/npapi.h: Added skeleton for a new plug-in drawing model, the NPCoreAnimationDrawingModel. This model will eventually pave the way
  64570. for hardware accelerated drawing in plug-ins and out of process plug-in rendering.
  64571. 2008-09-29 Julien Chaffraix <jchaffraix@webkit.org>
  64572. Reviewed by Maciej Stachowiak.
  64573. Bug 21106: .in format discussed changes
  64574. https://bugs.webkit.org/show_bug.cgi?id=21106
  64575. - Removed "cppNamespace" global parameter and hard-coded "WebCore" as it
  64576. is the only namespace used.
  64577. - Removed "generateFactory" and "generateWrapperFactory" parameters and
  64578. re-introduced the command line options.
  64579. - Cleaned up the output of make_names.pl (removed unneeded new line).
  64580. * DerivedSources.make: Added factories command line options.
  64581. * GNUmakefile.am: Ditto.
  64582. * WebCore.pro: Ditto and removed some arguments that were migrated to
  64583. the .in files.
  64584. * dom/make_names.pl: Clean up (see above).
  64585. * html/HTMLAttributeNames.in: Removed "cppNamespace", "generateFactory"
  64586. and "generateWrapperFactory" occurences.
  64587. * html/HTMLTagNames.in: Ditto.
  64588. * svg/svgattrs.in: Ditto.
  64589. * svg/svgtags.in: Ditto.
  64590. * svg/xlinkattrs.in: Ditto.
  64591. * xml/xmlattrs.in: Ditto.
  64592. 2008-09-29 Chris Fleizach <cfleizach@apple.com>
  64593. Reviewed by John Sullivan.
  64594. <rdar://problem/6255456> AX: <file> input button shouldn't have children exposed
  64595. Make sure that certain types of elements do not return children and, moreover, do not waste their
  64596. energy trying to return children
  64597. Test: accessibility/nochildren-elements.html
  64598. * page/AccessibilityObject.h:
  64599. (WebCore::AccessibilityObject::canHaveChildren):
  64600. * page/AccessibilityRenderObject.cpp:
  64601. (WebCore::AccessibilityRenderObject::canHaveChildren):
  64602. (WebCore::AccessibilityRenderObject::addChildren):
  64603. * page/AccessibilityRenderObject.h:
  64604. 2008-09-30 Alexey Proskuryakov <ap@webkit.org>
  64605. Reviewed by Sam Weinig.
  64606. https://bugs.webkit.org/show_bug.cgi?id=21213
  64607. MessagePort crash when GC collects an object with a pending close event
  64608. Test: fast/events/message-channel-gc-2.html
  64609. fast/events/message-channel-listener-circular-ownership.html
  64610. * bindings/DOMProtect.cpp: Added.
  64611. (WebCore::gcProtectDOMObject):
  64612. (WebCore::gcUnprotectDOMObject):
  64613. * bindings/DOMProtect.h: Added.
  64614. Added an abstraction for GC protection to avoid the need to call JS bindings code from
  64615. DOM objects directly.
  64616. * dom/MessagePort.cpp:
  64617. (WebCore::CloseMessagePortTimer::fired):
  64618. (WebCore::MessagePort::queueCloseEvent):
  64619. GC protect MessagePort wrapper while there is a pending close event.
  64620. This may be necessary for message events, too, but that case is not a crasher, and actually
  64621. behaves to the letter of the current HTML5 text, so I'll consider it later.
  64622. * xml/XMLHttpRequest.cpp:
  64623. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  64624. (WebCore::XMLHttpRequest::dropProtection):
  64625. Use gcProtectDOMObject here, too. Unfortunately, XMLHttpRequest has more dependencies on JSC.
  64626. * bindings/js/JSMessagePortCustom.cpp:
  64627. (WebCore::JSMessagePort::addEventListener):
  64628. (WebCore::JSMessagePort::removeEventListener):
  64629. (WebCore::JSMessagePort::setOnmessage):
  64630. (WebCore::JSMessagePort::setOnclose):
  64631. Don't tell DOMWindowBase that MessagePort is a NodeEventTarget, this is not true. I do not
  64632. know if this was causing any real issues, but we shouldn't lie to DOMWindowBase.
  64633. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  64634. (WebCore::JSXMLHttpRequestUpload::mark):
  64635. While at it, changed to use a typedef for event listeners from XMLHttpRequestUpload, not
  64636. from XMLHttpRequest.
  64637. 2008-09-30 Adam Roben <aroben@apple.com>
  64638. Windows build fix
  64639. * DerivedSources.cpp: Add JSEventTargetNode.cpp.
  64640. 2008-09-29 Sam Weinig <sam@webkit.org>
  64641. Reviewed by Tim Hatcher.
  64642. Patch for https://bugs.webkit.org/show_bug.cgi?id=21122
  64643. Autogenerate JS event listeners
  64644. - Generate EventTargetNode.
  64645. * DerivedSources.make:
  64646. * GNUmakefile.am:
  64647. * WebCore.pro:
  64648. * WebCore.vcproj/WebCore.vcproj:
  64649. * WebCore.xcodeproj/project.pbxproj:
  64650. * WebCoreSources.bkl:
  64651. * bindings/js/JSEventListener.cpp:
  64652. * bindings/js/JSEventTarget.cpp: Added.
  64653. (WebCore::toJS):
  64654. * bindings/js/JSEventTarget.h: Added.
  64655. * bindings/js/JSEventTargetBase.cpp: Removed.
  64656. * bindings/js/JSEventTargetBase.h:
  64657. * bindings/js/JSEventTargetNode.cpp: Removed.
  64658. * bindings/js/JSEventTargetNode.h: Removed.
  64659. * bindings/js/JSEventTargetNodeCustom.cpp: Added.
  64660. (WebCore::JSEventTargetNode::addEventListener):
  64661. (WebCore::JSEventTargetNode::removeEventListener):
  64662. (WebCore::JSEventTargetNode::dispatchEvent):
  64663. (WebCore::JSEventTargetNode::getListener):
  64664. (WebCore::JSEventTargetNode::setListener):
  64665. (WebCore::JSEventTargetNode::pushEventHandlerScope):
  64666. * bindings/js/JSEventTargetSVGElementInstance.cpp:
  64667. (WebCore::):
  64668. (WebCore::JSEventTargetSVGElementInstancePrototype::self):
  64669. (WebCore::JSEventTargetSVGElementInstancePrototype::getOwnPropertySlot):
  64670. (jsEventTargetAddEventListener):
  64671. (jsEventTargetRemoveEventListener):
  64672. (jsEventTargetDispatchEvent):
  64673. * bindings/js/JSEventTargetSVGElementInstance.h:
  64674. (WebCore::JSEventTargetSVGElementInstancePrototype::JSEventTargetSVGElementInstancePrototype):
  64675. (WebCore::JSEventTargetSVGElementInstancePrototype::classInfo):
  64676. * bindings/scripts/CodeGeneratorJS.pm:
  64677. * dom/EventTargetNode.idl: Added.
  64678. 2008-09-29 Darin Adler <darin@apple.com>
  64679. Reviewed by Sam Weinig.
  64680. - https://bugs.webkit.org/show_bug.cgi?id=21214
  64681. work on getting rid of ExecState
  64682. * bindings/js/JSDOMWindowBase.cpp:
  64683. (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument
  64684. for base class constructor.
  64685. 2008-09-29 David Hyatt <hyatt@apple.com>
  64686. Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
  64687. now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
  64688. and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
  64689. (Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)
  64690. Reviewed by Sam Weinig
  64691. * WebCore.xcodeproj/project.pbxproj:
  64692. * page/Chrome.h:
  64693. * platform/HostWindow.h: Added.
  64694. (WebCore::HostWindow::HostWindow):
  64695. (WebCore::HostWindow::~HostWindow):
  64696. 2008-09-29 Kevin Decker <kdecker@apple.com>
  64697. Reviewed by Anders Carlsson.
  64698. * bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
  64699. 2000.
  64700. 2008-09-29 Dan Bernstein <mitz@apple.com>
  64701. Reviewed by Adam Roben.
  64702. - WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  64703. * rendering/RenderThemeWin.cpp:
  64704. (WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added.
  64705. (WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being
  64706. unloaded, to avoid calling uxtheme.dll functions after that library has
  64707. been unloaded.
  64708. * rendering/RenderThemeWin.h:
  64709. 2008-09-29 Chris Fleizach <cfleizach@apple.com>
  64710. Reviewed by John Sullivan
  64711. <rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas
  64712. Sends AXLoadComplete only when the top level web area is finished loading
  64713. * dom/Document.cpp:
  64714. (WebCore::Document::implicitClose):
  64715. 2008-09-29 Timothy Hatcher <timothy@apple.com>
  64716. Makes the node highlight always show up when hovering a node in
  64717. the Web Inspector now that the highlight does not scroll to reveal
  64718. the node. Also adds a hover effect in the inspector when hovering
  64719. causes a highlight in the page. This ties the user hovering action
  64720. to the highlight so it is clear what causes the highlight to appear.
  64721. Also the highlight now temporarily shows up for 2 seconds after
  64722. selecting a node in the DOM tree. So arrowing around in the tree
  64723. will show the node on the page, providing feedback to the user.
  64724. Plus fixes an issue where quickly moving away from hovering
  64725. a node would keep showing the page highlight. This was happening
  64726. in breadcrumbs and the DOM tree.
  64727. https://bugs.webkit.org/show_bug.cgi?id=21220
  64728. Reviewed by Kevin McCullough.
  64729. * page/inspector/Console.js:
  64730. (WebInspector.Console.prototype._mouseOverNode): Added. Used for
  64731. hovering DOM nodes in the console.
  64732. (WebInspector.Console.prototype._mouseOutOfNode): Ditto.
  64733. (WebInspector.Console.prototype._formatnode): Use the new event
  64734. listeners and add a class name to the anchor element.
  64735. * page/inspector/ElementsPanel.js:
  64736. (WebInspector.ElementsPanel): Add new event listeners to the
  64737. crumbs element to do the node hovering highlight.
  64738. (WebInspector.ElementsPanel.prototype.hide):
  64739. (WebInspector.ElementsPanel.prototype.reset):
  64740. (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs):
  64741. (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
  64742. (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  64743. * page/inspector/ElementsTreeOutline.js:
  64744. (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
  64745. Show the node hishlight for 2 seconds then restore the highlight
  64746. to the current hovered node.
  64747. (WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the
  64748. hovered node and set the hovered state on the tree element.
  64749. (WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the
  64750. hovered node to null and removed the hovered state from the previous
  64751. hovered tree element.
  64752. (WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds
  64753. the hovered class to the list item.
  64754. (WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
  64755. * page/inspector/inspector.css:
  64756. * page/inspector/inspector.js:
  64757. (WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon
  64758. based on the showingDOMNodeHighlight property of 50ms or 500ms. This
  64759. causes the highlight to change sooner if there is one already showing
  64760. and appear later if there isn't one showing. This is like tooltips,
  64761. hovering a node for 500ms will cause highlight then mousing between nodes
  64762. will keep the highlight and change to the new node.
  64763. (WebInspector._updateHoverHighlightSoon): Take a delay being passed in and
  64764. always reset the timeout so continuous mousing does not keep flasshing
  64765. the highlight on the screen.
  64766. (WebInspector._updateHoverHighlight): Removed the alt key check and added
  64767. the showingDOMNodeHighlight property.
  64768. (WebInspector.documentKeyDown): Removed the alt key check.
  64769. (WebInspector.documentKeyUp): Ditto.
  64770. (WebInspector.reset): Clear the hoveredDOMNode.
  64771. 2008-09-29 Simon Fraser <simon.fraser@apple.com>
  64772. Reviewed by Anders Carlsson
  64773. Fix RenderStyle leak in animation code, and assert that
  64774. keyframe resolution in CSSStyleSelector is not going to clobber
  64775. m_style.
  64776. * css/CSSStyleSelector.cpp:
  64777. (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  64778. * page/animation/KeyframeAnimation.cpp:
  64779. (WebCore::KeyframeAnimation::~KeyframeAnimation):
  64780. 2008-09-29 Chris Marrin <cmarrin@apple.com>
  64781. Reviewed by Dave Hyatt
  64782. Fixed https://bugs.webkit.org/show_bug.cgi?id=20995
  64783. Rewrite keyframe resolution to be like styleForElement()
  64784. Test: animations/lineheight-animation.html
  64785. * css/CSSStyleSelector.cpp:
  64786. (WebCore::CSSStyleSelector::addKeyframeStyle):
  64787. (WebCore::CSSStyleSelector::~CSSStyleSelector):
  64788. (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  64789. (WebCore::CSSRuleSet::addRulesFromSheet):
  64790. (WebCore::CSSStyleSelector::mapAnimationName):
  64791. * css/CSSStyleSelector.h:
  64792. * page/animation/CompositeAnimation.cpp:
  64793. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  64794. * page/animation/KeyframeAnimation.cpp:
  64795. (WebCore::KeyframeAnimation::KeyframeAnimation):
  64796. (WebCore::KeyframeAnimation::animate):
  64797. (WebCore::KeyframeAnimation::hasAnimationForProperty):
  64798. (WebCore::KeyframeAnimation::sendAnimationEvent):
  64799. (WebCore::KeyframeAnimation::overrideAnimations):
  64800. (WebCore::KeyframeAnimation::resumeOverriddenAnimations):
  64801. (WebCore::KeyframeAnimation::affectsProperty):
  64802. (WebCore::KeyframeAnimation::validateTransformFunctionList):
  64803. * page/animation/KeyframeAnimation.h:
  64804. * rendering/style/Animation.cpp:
  64805. (WebCore::Animation::animationsMatch):
  64806. * rendering/style/Animation.h:
  64807. * rendering/style/KeyframeList.cpp:
  64808. (WebCore::KeyframeList::~KeyframeList):
  64809. (WebCore::KeyframeList::clear):
  64810. (WebCore::KeyframeList::insert):
  64811. * rendering/style/KeyframeList.h:
  64812. (WebCore::KeyframeValue::KeyframeValue):
  64813. (WebCore::KeyframeList::KeyframeList):
  64814. (WebCore::KeyframeList::operator!=):
  64815. (WebCore::KeyframeList::animationName):
  64816. (WebCore::KeyframeList::addProperty):
  64817. (WebCore::KeyframeList::containsProperty):
  64818. (WebCore::KeyframeList::beginProperties):
  64819. (WebCore::KeyframeList::endProperties):
  64820. (WebCore::KeyframeList::isEmpty):
  64821. (WebCore::KeyframeList::size):
  64822. (WebCore::KeyframeList::beginKeyframes):
  64823. (WebCore::KeyframeList::endKeyframes):
  64824. * rendering/style/RenderStyle.h:
  64825. * rendering/style/StyleRareNonInheritedData.cpp:
  64826. * rendering/style/StyleRareNonInheritedData.h:
  64827. 2008-09-29 Chris Marrin <cmarrin@apple.com>
  64828. Reviewed by Eric Seidel
  64829. Clean up fix in PropertyWrapperGetter::equals
  64830. https://bugs.webkit.org/show_bug.cgi?id=21011
  64831. Test: transitions/override-transition-crash.html
  64832. * page/animation/AnimationBase.cpp:
  64833. (WebCore::PropertyWrapperGetter::equals):
  64834. * page/animation/CompositeAnimation.cpp:
  64835. (WebCore::CompositeAnimation::updateTransitions):
  64836. 2008-09-29 Chris Marrin <cmarrin@apple.com>
  64837. Reviewed by Eric Seidel
  64838. https://bugs.webkit.org/show_bug.cgi?id=21001
  64839. Starting transition after animation, when animation
  64840. is finished, transition is wrong.
  64841. Test: animations/transition-and-animation-2.html
  64842. * page/animation/AnimationBase.h:
  64843. * page/animation/CompositeAnimation.cpp:
  64844. (WebCore::CompositeAnimation::updateTransitions):
  64845. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  64846. (WebCore::CompositeAnimation::resetTransitions):
  64847. (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  64848. * page/animation/ImplicitAnimation.cpp:
  64849. (WebCore::ImplicitAnimation::ImplicitAnimation):
  64850. (WebCore::ImplicitAnimation::~ImplicitAnimation):
  64851. (WebCore::ImplicitAnimation::animate):
  64852. (WebCore::ImplicitAnimation::reset):
  64853. * page/animation/ImplicitAnimation.h:
  64854. 2008-09-29 Chris Marrin <cmarrin@apple.com>
  64855. Reviewed by Sam Weinig
  64856. https://bugs.webkit.org/show_bug.cgi?id=20921
  64857. -webkit-animation-timing-function: inside of keyframes is ignored
  64858. Test: animations/keyframe-timing-functions.html
  64859. * page/animation/AnimationBase.cpp:
  64860. (WebCore::AnimationBase::progress):
  64861. * page/animation/AnimationBase.h:
  64862. * page/animation/ImplicitAnimation.cpp:
  64863. (WebCore::ImplicitAnimation::animate):
  64864. * page/animation/KeyframeAnimation.cpp:
  64865. (WebCore::KeyframeAnimation::animate):
  64866. 2008-09-29 Dan Bernstein <mitz@apple.com>
  64867. - Windows build fix
  64868. * platform/ScrollView.cpp:
  64869. (WebCore::ScrollView::platformScroll):
  64870. 2008-09-29 Dan Bernstein <mitz@apple.com>
  64871. - another attempt at a Windows build fix
  64872. * platform/ScrollView.cpp:
  64873. (WebCore::platformScroll):
  64874. 2008-09-29 Dan Bernstein <mitz@apple.com>
  64875. - Windows build fix
  64876. * platform/ScrollView.cpp:
  64877. (WebCore::ScrollView::platformSetScrollPosition):
  64878. 2008-09-29 David Hyatt <hyatt@apple.com>
  64879. https://bugs.webkit.org/show_bug.cgi?id=21218
  64880. Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
  64881. It's silly that the code was this fragile, but for now just put the check back in.
  64882. Reviewed by Dan Bernstein
  64883. * platform/ScrollView.cpp:
  64884. (WebCore::ScrollView::setScrollbarModes):
  64885. 2008-09-29 David Hyatt <hyatt@apple.com>
  64886. https://bugs.webkit.org/show_bug.cgi?id=21216
  64887. Make setScrollPosition and scroll() cross-platform.
  64888. Reviewed by Anders
  64889. * platform/ScrollView.cpp:
  64890. (WebCore::ScrollView::setScrollPosition):
  64891. (WebCore::ScrollView::scroll):
  64892. * platform/ScrollView.h:
  64893. * platform/gtk/ScrollViewGtk.cpp:
  64894. * platform/mac/ScrollViewMac.mm:
  64895. (WebCore::ScrollView::platformSetScrollPosition):
  64896. (WebCore::ScrollView::platformScroll):
  64897. * platform/qt/ScrollViewQt.cpp:
  64898. * platform/win/ScrollViewWin.cpp:
  64899. * platform/wx/ScrollViewWx.cpp:
  64900. (WebCore::ScrollView::platformSetScrollPosition):
  64901. (WebCore::ScrollView::platformScroll):
  64902. 2008-09-29 Kevin McCullough <kmccullough@apple.com>
  64903. Reviewed by Oliver.
  64904. Bug 21139: Profiler log message is wrong
  64905. - Because _format was called twice the number in the log was incremented
  64906. too many times, but we were passing it around in the link the whole time
  64907. * page/inspector/ProfilesPanel.js:
  64908. * page/inspector/inspector.js:
  64909. 2008-09-29 Sam Weinig <sam@webkit.org>
  64910. Reviewed by Cameron Zwarich.
  64911. Autogenerate EventListeners, addEventListener and removeEventListener
  64912. for JSDOMWindow.
  64913. * bindings/js/JSDOMWindowBase.cpp:
  64914. * bindings/js/JSDOMWindowBase.h:
  64915. * bindings/js/JSDOMWindowCustom.cpp:
  64916. (WebCore::JSDOMWindow::onwebkitanimationstart):
  64917. (WebCore::JSDOMWindow::setOnwebkitanimationstart):
  64918. (WebCore::JSDOMWindow::onwebkitanimationiteration):
  64919. (WebCore::JSDOMWindow::setOnwebkitanimationiteration):
  64920. (WebCore::JSDOMWindow::onwebkitanimationend):
  64921. (WebCore::JSDOMWindow::setOnwebkitanimationend):
  64922. (WebCore::JSDOMWindow::onwebkittransitionend):
  64923. (WebCore::JSDOMWindow::setOnwebkittransitionend):
  64924. (WebCore::JSDOMWindow::addEventListener):
  64925. (WebCore::JSDOMWindow::removeEventListener):
  64926. (WebCore::JSDOMWindow::setListener):
  64927. (WebCore::JSDOMWindow::getListener):
  64928. * bindings/scripts/CodeGeneratorJS.pm:
  64929. * page/DOMWindow.idl:
  64930. 2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
  64931. Reviewed by Simon.
  64932. Changed copyright from Trolltech ASA to Nokia.
  64933. Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
  64934. * bindings/js/JSMimeTypeArrayCustom.cpp:
  64935. * bindings/js/JSNavigatorCustom.cpp:
  64936. * bindings/js/JSPluginArrayCustom.cpp:
  64937. * bindings/js/JSPluginCustom.cpp:
  64938. * bindings/js/ScriptControllerMac.mm:
  64939. * bindings/js/ScriptControllerQt.cpp:
  64940. * bridge/qt/qt_class.cpp:
  64941. * bridge/qt/qt_class.h:
  64942. * bridge/qt/qt_instance.cpp:
  64943. * bridge/qt/qt_instance.h:
  64944. * bridge/qt/qt_runtime.cpp:
  64945. * bridge/qt/qt_runtime.h:
  64946. * bridge/testqtbindings.cpp:
  64947. * css/makegrammar.pl:
  64948. * css/makeprop.pl:
  64949. * css/makevalues.pl:
  64950. * dom/Node.cpp:
  64951. * dom/TagNodeList.cpp:
  64952. * dom/TagNodeList.h:
  64953. * dom/XMLTokenizer.cpp:
  64954. * dom/XMLTokenizer.h:
  64955. * dom/XMLTokenizerLibxml2.cpp:
  64956. * dom/XMLTokenizerQt.cpp:
  64957. * editing/Editor.cpp:
  64958. * editing/EditorCommand.cpp:
  64959. * html/CanvasRenderingContext2D.cpp:
  64960. * html/CanvasStyle.cpp:
  64961. * html/HTMLAppletElement.cpp:
  64962. * html/HTMLEmbedElement.cpp:
  64963. * html/HTMLObjectElement.cpp:
  64964. * loader/FrameLoader.cpp:
  64965. * page/Chrome.cpp:
  64966. * page/EditorClient.h:
  64967. * page/Frame.cpp:
  64968. * page/Frame.h:
  64969. * page/FramePrivate.h:
  64970. * page/Navigator.cpp:
  64971. * page/Navigator.h:
  64972. * page/Navigator.idl:
  64973. * page/mac/FrameMac.mm:
  64974. * page/qt/EventHandlerQt.cpp:
  64975. * platform/graphics/qt/FontCacheQt.cpp:
  64976. * platform/graphics/qt/FontCustomPlatformData.cpp:
  64977. * platform/graphics/qt/FontCustomPlatformData.h:
  64978. * platform/graphics/qt/FontPlatformData.h:
  64979. * platform/graphics/qt/FontQt.cpp:
  64980. * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
  64981. * platform/graphics/qt/GraphicsContextQt.cpp:
  64982. * platform/graphics/qt/ImageDecoderQt.cpp:
  64983. * platform/graphics/qt/ImageDecoderQt.h:
  64984. * platform/graphics/qt/ImageSourceQt.cpp:
  64985. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  64986. * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  64987. * platform/graphics/qt/SimpleFontDataQt.cpp:
  64988. * platform/gtk/MIMETypeRegistryGtk.cpp:
  64989. * platform/mac/MIMETypeRegistryMac.mm:
  64990. * platform/network/qt/QNetworkReplyHandler.cpp:
  64991. * platform/network/qt/QNetworkReplyHandler.h:
  64992. * platform/network/qt/ResourceHandleQt.cpp:
  64993. * platform/network/qt/ResourceRequestQt.cpp:
  64994. * platform/qt/ClipboardQt.cpp:
  64995. * platform/qt/EventLoopQt.cpp:
  64996. * platform/qt/KURLQt.cpp:
  64997. * platform/qt/LoggingQt.cpp:
  64998. * platform/qt/MIMETypeRegistryQt.cpp:
  64999. * platform/qt/PasteboardQt.cpp:
  65000. * platform/qt/PlatformScreenQt.cpp:
  65001. * platform/qt/PopupMenuQt.cpp:
  65002. * platform/qt/QWebPopup.cpp:
  65003. * platform/qt/QWebPopup.h:
  65004. * platform/qt/RenderThemeQt.cpp:
  65005. * platform/qt/ScrollbarQt.cpp:
  65006. * platform/qt/ScrollbarThemeQt.cpp:
  65007. * platform/qt/WheelEventQt.cpp:
  65008. * platform/qt/html4-adjustments-qt.css:
  65009. * platform/wx/MimeTypeRegistryWx.cpp:
  65010. * plugins/MimeType.cpp:
  65011. * plugins/MimeType.h:
  65012. * plugins/MimeType.idl:
  65013. * plugins/MimeTypeArray.cpp:
  65014. * plugins/MimeTypeArray.h:
  65015. * plugins/MimeTypeArray.idl:
  65016. * plugins/Plugin.cpp:
  65017. * plugins/Plugin.h:
  65018. * plugins/Plugin.idl:
  65019. * plugins/PluginArray.cpp:
  65020. * plugins/PluginArray.h:
  65021. * plugins/PluginArray.idl:
  65022. * plugins/PluginData.cpp:
  65023. * plugins/PluginData.h:
  65024. * plugins/gtk/PluginDataGtk.cpp:
  65025. * plugins/mac/PluginDataMac.mm:
  65026. * plugins/qt/PluginDataQt.cpp:
  65027. * plugins/win/PluginDataWin.cpp:
  65028. * rendering/RenderTableCol.cpp:
  65029. * rendering/RenderTableCol.h:
  65030. 2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>
  65031. Reviewed by Simon
  65032. Fix compilation with gcc 4.3
  65033. gcc 4.3 is stricter and ctype.h isn't getting included
  65034. automatically here by dependencies. So do it directly.
  65035. * platform/qt/PlatformKeyboardEventQt.cpp:
  65036. 2008-09-29 Morten Sørvig <msorvig@trolltech.com>
  65037. Reviewed by Simon.
  65038. Fix compilation with Qt/Mac without plugins.
  65039. * platform/qt/TemporaryLinkStubs.cpp:
  65040. 2008-09-29 Mark Rowe <mrowe@apple.com>
  65041. Reviewed by Sam Weinig.
  65042. Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
  65043. In the few places that we call .upper() in WebCore the strings represent things like
  65044. tag and attribute names, which are nearly always going to be ASCII.
  65045. * platform/text/StringImpl.cpp:
  65046. (WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
  65047. in to Unicode::toLower the second time.
  65048. (WebCore::StringImpl::upper):
  65049. 2008-09-28 Mark Rowe <mrowe@apple.com>
  65050. Reviewed by Sam Weinig.
  65051. Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
  65052. rather than String::operator+=.
  65053. * css/CSSPrimitiveValue.cpp:
  65054. (WebCore::CSSPrimitiveValue::cssText):
  65055. 2008-09-28 Mark Rowe <mrowe@apple.com>
  65056. Reviewed by Oliver Hunt.
  65057. Speed up computedStyle.getPropertyValue('color') by 4.5x.
  65058. Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
  65059. as it avoids many memory reallocations.
  65060. This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
  65061. by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
  65062. unrelated properties on an element.
  65063. * css/CSSPrimitiveValue.cpp:
  65064. (WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
  65065. and use appendNumber rather than the String::number in order to cut down on memory allocations.
  65066. * platform/text/PlatformString.h:
  65067. (WebCore::appendNumber): A helper function for formatting an unsigned character as a number
  65068. into a Vector<UChar>.
  65069. 2008-09-28 Sam Weinig <sam@webkit.org>
  65070. Reviewed by Anders Carlsson.
  65071. Remove spurious call to lower().
  65072. * css/MediaQueryEvaluator.cpp:
  65073. (WebCore::MediaQueryEvaluator):
  65074. 2008-09-28 Sam Weinig <sam@webkit.org>
  65075. Reviewed by Dan Bernstein.
  65076. Use a CaseFoldingHash instead of calling lower on family strings.
  65077. * css/CSSFontSelector.cpp:
  65078. (WebCore::CSSFontSelector::addFontFaceRule):
  65079. (WebCore::CSSFontSelector::getFontData):
  65080. * css/CSSFontSelector.h:
  65081. 2008-09-28 Timothy Hatcher <timothy@apple.com>
  65082. Remove the scrollIntoViewIfNeeded() call when drawing the
  65083. Inspector node highlight.
  65084. <rdar://problem/6115804> Don't scroll when highlighting (21000)
  65085. https://bugs.webkit.org/show_bug.cgi?id=21000
  65086. Reviewed by Dan Bernstein.
  65087. * page/InspectorController.cpp:
  65088. (WebCore::InspectorController::drawNodeHighlight):
  65089. 2008-09-28 David Hyatt <hyatt@apple.com>
  65090. Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
  65091. changed.
  65092. Reviewed by Dan Bernstein
  65093. * platform/mac/ScrollbarThemeMac.mm:
  65094. (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
  65095. 2008-09-28 Timothy Hatcher <timothy@apple.com>
  65096. Clear the current search results in the Inspector when
  65097. the search query is less than 3 characters long. Incremental
  65098. searches only occur for 3 characters or longer, but deleting
  65099. under this limit would not clear the results unless the whole
  65100. query was deleted.
  65101. https://bugs.webkit.org/show_bug.cgi?id=21196
  65102. Reviewed by Dan Bernstein.
  65103. * page/inspector/inspector.js:
  65104. (WebInspector.performSearch): Check for short queries in the
  65105. if statement that triggers the clear.
  65106. 2008-09-28 Dan Bernstein <mitz@apple.com>
  65107. Reviewed by Dave Hyatt.
  65108. - fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED
  65109. * platform/graphics/win/FontCustomPlatformData.cpp:
  65110. (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and
  65111. overlayLength parameters.
  65112. (WebCore::EOTStream::read): Added code to overlay the
  65113. m_overlayLength bytes starting at m_overlayDst with the same number of
  65114. bytes from m_overlaySrc.
  65115. (WebCore::createFontCustomPlatformData): Changed to get overlay
  65116. parameters from getEOTHeader.
  65117. * platform/graphics/win/GetEOTHeader.cpp:
  65118. (WebCore::getEOTHeader): Added code to specify overlaying of the
  65119. family name with the prefix of the full name if they differ, because
  65120. that such a difference causes TTLoadEmbeddedFont to fail.
  65121. * platform/graphics/win/GetEOTHeader.h:
  65122. 2008-09-28 Alexey Proskuryakov <ap@webkit.org>
  65123. Reviewed by Eric Seidel.
  65124. https://bugs.webkit.org/show_bug.cgi?id=20366
  65125. Reproducible test failure for editing/undo/undo-iframe-location-change.html
  65126. * ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
  65127. 2008-09-28 Darin Adler <darin@apple.com>
  65128. Reviewed by Sam Weinig (except for a few comment and header tweaks).
  65129. - https://bugs.webkit.org/show_bug.cgi?id=21158
  65130. reduce use of virtual functions in Node for speed
  65131. Speeds up Dromaeo a bit less than 1%.
  65132. * bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of
  65133. Node.h now that some inlines are in there.
  65134. * dom/Attr.h: Override both the virtual and non-virtual name functions.
  65135. * dom/ChildNodeList.cpp:
  65136. (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
  65137. * dom/ChildNodeList.h: Ditto.
  65138. * dom/ClassNodeList.cpp:
  65139. (WebCore::ClassNodeList::nodeMatches): Ditto.
  65140. * dom/ClassNodeList.h: Ditto.
  65141. * dom/Document.h: Put the Node::isDocumentNode() function's inline
  65142. definition here where it can see the Document class definition.
  65143. * dom/DynamicNodeList.cpp:
  65144. (WebCore::DynamicNodeList::length): Changed to pass an Element.
  65145. (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto.
  65146. (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto.
  65147. (WebCore::DynamicNodeList::itemWithName): Ditto.
  65148. * dom/DynamicNodeList.h: Ditto.
  65149. * dom/Element.cpp: Removed virtualHasTagName.
  65150. * dom/Element.h: Made localName, prefix, namespaceURI, and
  65151. styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName,
  65152. virtualNamespaceURI, and removed virtualHasTagName. Put the
  65153. Node::hasTagName, Node::hasAttributes, and Node::attributes
  65154. functions' inline definitions here where they can see the Element
  65155. class definition.
  65156. * dom/NameNodeList.cpp:
  65157. (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
  65158. * dom/NameNodeList.h: Ditto.
  65159. * dom/Node.cpp:
  65160. (WebCore::Node::virtualPrefix): Renamed from prefix.
  65161. (WebCore::Node::virtualLocalName): Renamed from localName.
  65162. (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI.
  65163. (WebCore::Node::styleForRenderer): Handle the Element case here.
  65164. * dom/Node.h: Removed definition of hasTagName that calls virtual,
  65165. since we now have a non-virtual version. Made hasAttributes,
  65166. attributes, remove, localName, namespaceURI, prefix, isDocumentNode,
  65167. and styleForRenderer non-virtual. Added virtualPrefix,
  65168. virtualLocalName, and virtualNamespaceURI. Removed isMalformed
  65169. and setMalformed, which are used only on HTMLFormElement objects.
  65170. * dom/TagNodeList.cpp:
  65171. (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
  65172. * dom/TagNodeList.h: Ditto.
  65173. * html/HTMLAnchorElement.cpp: Added a comment.
  65174. * html/HTMLFormControlElement.cpp: Ditto.
  65175. * html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex
  65176. function. Marked tabIndex function virtual explicitly for clarity.
  65177. * html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex
  65178. function. Marked isFocusable function virtual explicitly for clarity.
  65179. * html/HTMLElement.h: Marked tabIndex function virtual explicitly for
  65180. clarity.
  65181. * html/HTMLFormControlElement.h: Ditto.
  65182. * html/HTMLFormElement.h: Made isMalformed non-virtual.
  65183. * html/HTMLParser.cpp:
  65184. (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement
  65185. pointer to call localName since that one does not need to call a virtual
  65186. function.
  65187. * rendering/RenderBlock.cpp:
  65188. (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before
  65189. calling isMalformed. We already did a tag name check so we know it's
  65190. an HTMLFormELement.
  65191. * xml/XPathUtil.cpp:
  65192. (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls
  65193. to nodeType(), since it's a virtual function.
  65194. 2008-09-28 David Hyatt <hyatt@apple.com>
  65195. Make frameRectsChanged() cross-platform on ScrollView.
  65196. Reviewed by Oliver Hunt
  65197. * platform/ScrollView.cpp:
  65198. (WebCore::ScrollView::frameRectsChanged):
  65199. * platform/ScrollView.h:
  65200. * platform/gtk/ScrollViewGtk.cpp:
  65201. * platform/qt/ScrollViewQt.cpp:
  65202. * platform/win/ScrollViewWin.cpp:
  65203. * platform/wx/ScrollViewWx.cpp:
  65204. 2008-09-28 Oliver Hunt <oliver@apple.com>
  65205. Reviewed by Maciej Stachowiak.
  65206. Bug 21141: REGRESSION: Exception messages for user entered commands are poor
  65207. <https://bugs.webkit.org/show_bug.cgi?id=21141>
  65208. The bug repsonsible for this was the the JSInspectedObjectWrapper instances
  65209. were not initialising their StructureID's to indicate that the wrapper
  65210. overrides hasInstance, etc. The solution is simply to use the createStructureID
  65211. helper on JSQuarantinedObjectWrapper to create a correct StructureID.
  65212. * bindings/js/JSInspectedObjectWrapper.cpp:
  65213. (WebCore::JSInspectedObjectWrapper::wrap):
  65214. 2008-09-28 David Hyatt <hyatt@apple.com>
  65215. Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
  65216. terms of lines.
  65217. Reviewed by Oliver Hunt
  65218. * dom/EventTargetNode.cpp:
  65219. (WebCore::EventTargetNode::dispatchWheelEvent):
  65220. 2008-09-28 David Hyatt <hyatt@apple.com>
  65221. https://bugs.webkit.org/show_bug.cgi?id=21191
  65222. Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
  65223. on ScrollView to be cross-platform.
  65224. Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
  65225. events are now pixel wheel events.
  65226. Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
  65227. (1) Page scrolling has been corrected to be properly detected (on Windows
  65228. page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
  65229. old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
  65230. you could page scroll horizontally.
  65231. (2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
  65232. This caused the scroll amount for page scrolling to be way too large on layers.
  65233. Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.
  65234. Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
  65235. for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).
  65236. Reviewed by Oliver Hunt
  65237. * editing/EditorCommand.cpp:
  65238. (WebCore::verticalScrollDistance):
  65239. * page/EventHandler.cpp:
  65240. (WebCore::scrollAndAcceptEvent):
  65241. (WebCore::EventHandler::handleWheelEvent):
  65242. * platform/PlatformWheelEvent.h:
  65243. (WebCore::):
  65244. (WebCore::PlatformWheelEvent::pos):
  65245. (WebCore::PlatformWheelEvent::globalPos):
  65246. (WebCore::PlatformWheelEvent::deltaX):
  65247. (WebCore::PlatformWheelEvent::deltaY):
  65248. (WebCore::PlatformWheelEvent::granularity):
  65249. (WebCore::PlatformWheelEvent::x):
  65250. (WebCore::PlatformWheelEvent::globalX):
  65251. (WebCore::PlatformWheelEvent::ignore):
  65252. (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
  65253. (WebCore::PlatformWheelEvent::verticalLineMultiplier):
  65254. * platform/ScrollView.cpp:
  65255. (WebCore::ScrollView::wheelEvent):
  65256. * platform/Scrollbar.h:
  65257. * platform/gtk/ScrollViewGtk.cpp:
  65258. (WebCore::ScrollView::updateScrollbars):
  65259. * platform/gtk/WheelEventGtk.cpp:
  65260. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  65261. * platform/mac/ScrollViewMac.mm:
  65262. * platform/mac/WheelEventMac.mm:
  65263. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  65264. * platform/qt/ScrollViewQt.cpp:
  65265. (WebCore::ScrollView::updateScrollbars):
  65266. * platform/qt/WheelEventQt.cpp:
  65267. * platform/win/ScrollViewWin.cpp:
  65268. (WebCore::ScrollView::updateScrollbars):
  65269. * platform/win/WheelEventWin.cpp:
  65270. (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
  65271. (WebCore::PlatformWheelEvent::verticalLineMultiplier):
  65272. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  65273. * platform/wx/ScrollViewWx.cpp:
  65274. (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
  65275. (WebCore::ScrollView::wheelEvent):
  65276. * rendering/RenderLayer.cpp:
  65277. (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  65278. 2008-09-27 Eric Carlson <eric.carlson@apple.com>
  65279. Reviewed by Sam Weinig.
  65280. fix https://bugs.webkit.org/show_bug.cgi?id=20994
  65281. <rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned
  65282. HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
  65283. all unsigned media attributes from string with toUInt() instead of toInt().
  65284. * html/HTMLMediaElement.cpp:
  65285. (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().
  65286. * html/HTMLVideoElement.cpp:
  65287. (WebCore::HTMLVideoElement::videoWidth):
  65288. (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl.
  65289. (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return
  65290. unsigned value.
  65291. (WebCore::HTMLVideoElement::height): Ditto.
  65292. (WebCore::HTMLVideoElement::setWidth): take unsigned value.
  65293. (WebCore::HTMLVideoElement::setHeight): Ditto.
  65294. * html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.
  65295. * html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.
  65296. 2008-09-27 Timothy Hatcher <timothy@apple.com>
  65297. Fixes an exception when typing a command in the Console.
  65298. Reviewed by Oliver Hunt.
  65299. * page/inspector/Console.js:
  65300. (WebInspector.Console.prototype.addMessage): Null check
  65301. this.previosMessage.
  65302. 2008-09-27 Timothy Hatcher <timothy@apple.com>
  65303. Fixes a bug where the Profiles panel sidebar would be empty
  65304. after closing and reopening the Web Inspector.
  65305. https://bugs.webkit.org/show_bug.cgi?id=21179
  65306. Reviewed by Sam Weinig.
  65307. * page/inspector/ProfilesPanel.js:
  65308. (WebInspector.ProfilesPanel.prototype.reset): Don't call
  65309. populateInterface, it is called automatically.
  65310. (WebInspector.ProfilesPanel.prototype._populateProfiles):
  65311. Return early if the sidebar is already populated.
  65312. 2008-09-27 Dave Hyatt <hyatt@apple.com>
  65313. Bug 21190. The line scroll amount on Windows is way too small. A patch for bug 17589 for wheel sensitivity
  65314. incorrectly applied the tinier wheel step delta (unmultiplied) to line scrolling. Line scrolling with the
  65315. scrollbar has nothing to do with mouse wheeling. This patch reverts the scrollbars to use the same line
  65316. step as other platforms while leaving the wheel delta alone for use with wheel scrolling.
  65317. There was a lot wrong with 17589, so more patches will be coming to deal with the fallout of this patch
  65318. (which should never have landed in the first place).
  65319. Reviewed by Tim Hatcher, Sam Weinig
  65320. * platform/win/ScrollViewWin.cpp:
  65321. (WebCore::adjustDeltaForPageScrollMode):
  65322. (WebCore::ScrollView::updateScrollbars):
  65323. (WebCore::ScrollView::wheelEvent):
  65324. 2008-09-27 David Hyatt <hyatt@apple.com>
  65325. Make the scrollbarUnderMouse method cross-platform.
  65326. Reviewed by Sam Weinig
  65327. * platform/ScrollView.cpp:
  65328. (WebCore::ScrollView::scrollbarUnderMouse):
  65329. * platform/gtk/ScrollViewGtk.cpp:
  65330. * platform/mac/ScrollViewMac.mm:
  65331. * platform/qt/ScrollViewQt.cpp:
  65332. * platform/win/ScrollViewWin.cpp:
  65333. * platform/wx/ScrollViewWx.cpp:
  65334. 2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
  65335. Gtk+ build fix.
  65336. * platform/gtk/ScrollViewGtk.cpp:
  65337. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65338. 2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
  65339. Reviewed by Holger Freyther.
  65340. https://bugs.webkit.org/show_bug.cgi?id=20287
  65341. [Gtk] disable plugins for gtk/directfb target
  65342. Introduce WTF_PLATFORM_X11 for X11 builds.
  65343. Also use target-specific packages when building the port
  65344. * platform/gtk/PlatformScreenGtk.cpp:
  65345. * plugins/gtk/PluginViewGtk.cpp:
  65346. (WebCore::PluginView::updatePluginWidget):
  65347. (WebCore::PluginView::getValueStatic):
  65348. (WebCore::PluginView::getValue):
  65349. (WebCore::PluginView::init):
  65350. 2008-09-27 David Hyatt <hyatt@apple.com>
  65351. https://bugs.webkit.org/show_bug.cgi?id=21188
  65352. Make scrollbar suppression and resizer avoidance cross-platform.
  65353. Reviewed by Anders
  65354. * loader/FrameLoader.cpp:
  65355. (WebCore::FrameLoader::transitionToCommitted):
  65356. * page/FrameView.cpp:
  65357. (WebCore::FrameView::resetScrollbars):
  65358. (WebCore::FrameView::clear):
  65359. (WebCore::FrameView::layout):
  65360. (WebCore::FrameView::restoreScrollbar):
  65361. (WebCore::FrameView::windowResizerRect):
  65362. * page/FrameView.h:
  65363. * platform/ScrollView.cpp:
  65364. (WebCore::ScrollView::init):
  65365. (WebCore::ScrollView::resizerOverlapsContent):
  65366. (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
  65367. (WebCore::ScrollView::setParent):
  65368. (WebCore::ScrollView::setScrollbarsSuppressed):
  65369. (WebCore::ScrollView::platformSetScrollbarsSuppressed):
  65370. * platform/ScrollView.h:
  65371. (WebCore::ScrollView::scrollbarsSuppressed):
  65372. (WebCore::ScrollView::windowResizerRect):
  65373. * platform/Scrollbar.cpp:
  65374. (WebCore::Scrollbar::setFrameRect):
  65375. (WebCore::Scrollbar::setParent):
  65376. * platform/gtk/ScrollViewGtk.cpp:
  65377. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  65378. (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
  65379. (WebCore::ScrollView::updateScrollbars):
  65380. (WebCore::ScrollView::paint):
  65381. * platform/mac/ScrollViewMac.mm:
  65382. (WebCore::ScrollView::ScrollView):
  65383. (WebCore::ScrollView::~ScrollView):
  65384. (WebCore::ScrollView::platformSetScrollbarsSuppressed):
  65385. (WebCore::ScrollView::setScrollPosition):
  65386. * platform/qt/ScrollViewQt.cpp:
  65387. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  65388. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65389. (WebCore::ScrollView::frameRectsChanged):
  65390. (WebCore::ScrollView::updateScrollbars):
  65391. (WebCore::ScrollView::paint):
  65392. * platform/win/ScrollViewWin.cpp:
  65393. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  65394. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65395. (WebCore::ScrollView::updateScrollbars):
  65396. (WebCore::ScrollView::paint):
  65397. * platform/wx/ScrollViewWx.cpp:
  65398. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  65399. 2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
  65400. Rubber-stamped by Anders Carlsson.
  65401. Compile fix.
  65402. * plugins/PluginView.cpp:
  65403. (WebCore::PluginView::load):
  65404. 2008-09-27 Mark Rowe <mrowe@apple.com>
  65405. Rubber-stamped by Sam Weinig.
  65406. Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
  65407. Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html
  65408. Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.
  65409. * loader/CachedResource.cpp:
  65410. (WebCore::CachedResource::~CachedResource):
  65411. 2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
  65412. Reviewed by Simon Hausmann.
  65413. [qt] Use QImageReader to figure out which image formats are supported
  65414. - Qt can have many different plugins for different image formats. Instead
  65415. of checking only for a few in WebCore use Qt to determine if this data
  65416. can be treated as an image.
  65417. * platform/graphics/qt/ImageSourceQt.cpp:
  65418. (WebCore::canHandleImage):
  65419. (WebCore::createDecoder):
  65420. 2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
  65421. [qt] Clean the pattern code
  65422. - Use save/restore on the painter after manipulating the
  65423. pen/brush
  65424. - Make the context and object null checking consistent. CG is using
  65425. the object unconditionally so the Qt webkit platform can do the
  65426. same.
  65427. - Move code below the early exit. Only use the m_ownerElement before
  65428. the early exit as the CG code is doing it.
  65429. * svg/graphics/SVGPaintServerPattern.h:
  65430. * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
  65431. (WebCore::SVGPaintServerPattern::setup):
  65432. (WebCore::SVGPaintServerPattern::teardown):
  65433. 2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
  65434. Added support for console.trace.
  65435. https://bugs.webkit.org/show_bug.cgi?id=19157
  65436. Reviewed by Kevin McCullough and Tim Hatcher.
  65437. * bindings/js/JSConsoleCustom.cpp:
  65438. (WebCore::JSConsole::trace):
  65439. * page/Console.cpp:
  65440. (WebCore::Console::trace): Calls Machine::retrieveCaller to
  65441. get a stack trace.
  65442. * page/Console.h:
  65443. (WebCore::): Added TraceMessageLevel.
  65444. * page/Console.idl: Added console.trace.
  65445. * page/inspector/Console.js:
  65446. (ConsoleMessage): Added case for TraceMessageLevel.
  65447. 2008-09-27 Anders Carlsson <andersca@apple.com>
  65448. Reviewed by Sam Weinig.
  65449. https://bugs.webkit.org/show_bug.cgi?id=21178
  65450. <rdar://problem/6248651>
  65451. Check if the plug-in is allowed to load the resource. This matches Firefox.
  65452. Test: http/tests/plugins/local-geturl-from-remote.html
  65453. * plugins/PluginView.cpp:
  65454. (WebCore::PluginView::load):
  65455. 2008-09-22 Dirk Schulze <vbs85@gmx.de>
  65456. Reviewed by Eric Seidel.
  65457. Added SVG pattern support to Qt.
  65458. [Qt] SVG patterns are missing
  65459. https://bugs.webkit.org/show_bug.cgi?id=20973
  65460. * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
  65461. (WebCore::SVGPaintServerPattern::setup):
  65462. 2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
  65463. Fixed a bug in the JS syntax highlighter with multiple line tokens.
  65464. https://bugs.webkit.org/show_bug.cgi?id=21171
  65465. Reviewed by Tim Hatcher.
  65466. * page/inspector/SourceFrame.js:
  65467. (syntaxHighlightJavascriptLine): Initialize previousMatchLength.
  65468. 2008-09-27 Timothy Hatcher <timothy@apple.com>
  65469. Change searching in the Profiles panel to not match the
  65470. Self and Total columns when there are no units. The only
  65471. column that is matched for unitless number searches is
  65472. now the Calls column.
  65473. https://bugs.webkit.org/show_bug.cgi?id=21169
  65474. Reviewed by Sam Weinig.
  65475. * page/inspector/ProfileView.js:
  65476. (WebInspector.ProfileView.prototype.performSearch):
  65477. 2008-09-27 David Hyatt <hyatt@apple.com>
  65478. Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.
  65479. Reviewed by Sam Weinig
  65480. * platform/ScrollView.h:
  65481. * platform/Widget.h:
  65482. (WebCore::Widget::boundsRect):
  65483. (WebCore::Widget::invalidate):
  65484. (WebCore::Widget::frameRectsChanged):
  65485. * platform/gtk/ScrollViewGtk.cpp:
  65486. (WebCore::ScrollViewScrollbar::frameRectsChanged):
  65487. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  65488. (WebCore::ScrollView::setFrameRect):
  65489. (WebCore::ScrollView::updateScrollbars):
  65490. (WebCore::ScrollView::frameRectsChanged):
  65491. * platform/gtk/ScrollbarGtk.cpp:
  65492. (ScrollbarGtk::setFrameRect):
  65493. (ScrollbarGtk::frameRectsChanged):
  65494. * platform/gtk/ScrollbarGtk.h:
  65495. * platform/gtk/WidgetGtk.cpp:
  65496. * platform/qt/ScrollViewQt.cpp:
  65497. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  65498. (WebCore::ScrollView::setFrameRect):
  65499. (WebCore::ScrollView::frameRectsChanged):
  65500. (WebCore::ScrollView::updateScrollbars):
  65501. * platform/win/ScrollViewWin.cpp:
  65502. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  65503. (WebCore::ScrollView::setFrameRect):
  65504. (WebCore::ScrollView::updateScrollbars):
  65505. (WebCore::ScrollView::frameRectsChanged):
  65506. * plugins/PluginView.cpp:
  65507. (WebCore::PluginView::frameRectsChanged):
  65508. * plugins/PluginView.h:
  65509. 2008-09-27 Simon Hausmann <hausmann@webkit.org>
  65510. Refix the previous build fix to compile on non-Qt platforms, too.
  65511. * WebCore.pro: Don't pass -i to create_hashtable, added missing -n
  65512. WebCore to generate the PrototypeTable in the WebCore namespace
  65513. * bindings/js/JSEventTargetBase.h: Revert previous fix, the Prototype
  65514. table remains in the Webcore namespace
  65515. (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
  65516. 2008-09-27 Simon Hausmann <hausmann@webkit.org>
  65517. Fix compilation with gcc 4.3 (probably > 4.0)
  65518. * bindings/js/JSDOMWindowBase.cpp: Don't define static property
  65519. get/put functions inside the WebCore namespace.
  65520. * bindings/js/JSEventTargetBase.cpp: Ditto.
  65521. * bindings/js/JSEventTargetNode.cpp: Ditto.
  65522. * bindings/js/JSEventTargetSVGElementInstance.cpp: Ditto.
  65523. * bindings/js/JSEventTargetBase.h: Forward declare
  65524. JSEventTargetPrototypeTable in the JSC namespace as the lut.h file
  65525. defines it in the JSC namespace.
  65526. (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot): Add JSC::
  65527. prefix for PrototypeTable symbol.
  65528. 2008-09-27 David Hyatt <hyatt@apple.com>
  65529. Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.
  65530. Reviewed by Dan Bernstein
  65531. * WebCore.base.exp:
  65532. * page/FrameView.cpp:
  65533. (WebCore::FrameView::FrameView):
  65534. (WebCore::FrameView::updateControlTints):
  65535. * platform/ScrollView.h:
  65536. * platform/Scrollbar.cpp:
  65537. (WebCore::Scrollbar::Scrollbar):
  65538. (WebCore::Scrollbar::paint):
  65539. (WebCore::Scrollbar::setFrameRect):
  65540. * platform/Scrollbar.h:
  65541. * platform/ScrollbarThemeComposite.cpp:
  65542. (WebCore::ScrollbarThemeComposite::paint):
  65543. * platform/Widget.h:
  65544. (WebCore::Widget::x):
  65545. (WebCore::Widget::y):
  65546. (WebCore::Widget::width):
  65547. (WebCore::Widget::height):
  65548. (WebCore::Widget::size):
  65549. (WebCore::Widget::pos):
  65550. (WebCore::Widget::resize):
  65551. (WebCore::Widget::move):
  65552. * platform/gtk/ScrollViewGtk.cpp:
  65553. (WebCore::ScrollViewScrollbar::geometryChanged):
  65554. (WebCore::ScrollView::update):
  65555. (WebCore::ScrollView::setFrameRect):
  65556. (WebCore::ScrollView::updateScrollbars):
  65557. (WebCore::ScrollView::scrollbarUnderMouse):
  65558. (WebCore::ScrollView::paint):
  65559. * platform/gtk/ScrollbarGtk.cpp:
  65560. (ScrollbarGtk::setFrameRect):
  65561. (ScrollbarGtk::geometryChanged):
  65562. * platform/gtk/ScrollbarGtk.h:
  65563. * platform/gtk/WidgetGtk.cpp:
  65564. (WebCore::Widget::frameRect):
  65565. (WebCore::Widget::setFrameRect):
  65566. * platform/mac/ScrollbarThemeMac.mm:
  65567. (WebCore::ScrollbarThemeMac::trackRect):
  65568. (WebCore::ScrollbarThemeMac::paint):
  65569. * platform/mac/WidgetMac.mm:
  65570. (WebCore::Widget::frameRect):
  65571. (WebCore::Widget::setFrameRect):
  65572. * platform/qt/ScrollViewQt.cpp:
  65573. (WebCore::ScrollView::setFrameRect):
  65574. (WebCore::ScrollView::updateScrollbars):
  65575. (WebCore::ScrollView::scrollbarUnderMouse):
  65576. (WebCore::ScrollView::paint):
  65577. * platform/qt/ScrollbarThemeQt.cpp:
  65578. (WebCore::styleOptionSlider):
  65579. * platform/qt/WidgetQt.cpp:
  65580. (WebCore::Widget::frameRect):
  65581. (WebCore::Widget::setFrameRect):
  65582. * platform/win/PopupMenuWin.cpp:
  65583. (WebCore::PopupMenu::invalidateItem):
  65584. (WebCore::PopupMenu::valueChanged):
  65585. (WebCore::PopupWndProc):
  65586. * platform/win/ScrollViewWin.cpp:
  65587. (WebCore::ScrollView::setFrameRect):
  65588. (WebCore::ScrollView::updateScrollbars):
  65589. (WebCore::ScrollView::scrollbarUnderMouse):
  65590. (WebCore::ScrollView::paint):
  65591. * platform/win/ScrollbarThemeSafari.cpp:
  65592. (WebCore::ScrollbarThemeSafari::trackRect):
  65593. * platform/win/WidgetWin.cpp:
  65594. (WebCore::Widget::frameRect):
  65595. (WebCore::Widget::setFrameRect):
  65596. * platform/wx/WidgetWx.cpp:
  65597. (WebCore::Widget::frameRect):
  65598. (WebCore::Widget::setFrameRect):
  65599. * plugins/PluginView.cpp:
  65600. (WebCore::PluginView::setFrameRect):
  65601. * plugins/PluginView.h:
  65602. * plugins/gtk/PluginViewGtk.cpp:
  65603. (WebCore::PluginView::updatePluginWidget):
  65604. (WebCore::PluginView::paint):
  65605. (WebCore::PluginView::init):
  65606. * plugins/qt/PluginViewQt.cpp:
  65607. (WebCore::PluginView::updatePluginWidget):
  65608. (WebCore::PluginView::init):
  65609. * plugins/win/PluginViewWin.cpp:
  65610. (WebCore::PluginView::updatePluginWidget):
  65611. (WebCore::PluginView::paintMissingPluginIcon):
  65612. (WebCore::PluginView::paint):
  65613. (WebCore::PluginView::init):
  65614. * rendering/RenderLayer.cpp:
  65615. (WebCore::RenderLayer::positionOverflowControls):
  65616. * rendering/RenderListBox.cpp:
  65617. (WebCore::RenderListBox::paintScrollbar):
  65618. * rendering/RenderPart.cpp:
  65619. (WebCore::RenderPart::updateWidgetPosition):
  65620. * rendering/RenderWidget.cpp:
  65621. (WebCore::RenderWidget::setWidgetGeometry):
  65622. (WebCore::RenderWidget::updateWidgetPosition):
  65623. 2008-09-27 David Hyatt <hyatt@apple.com>
  65624. <rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF
  65625. This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
  65626. access an actual member variable.
  65627. Reviewed by Dan Bernstein
  65628. * page/FocusController.cpp:
  65629. (WebCore::FocusController::setFocusedFrame):
  65630. 2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
  65631. Attempt to fix QT Build. Not reviewed.
  65632. * WebCore.pro: add -n WebCore parameter to create_hash_table
  65633. 2008-09-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
  65634. Reviewed by Eric Seidel.
  65635. http://bugs.webkit.org/show_bug.cgi?id=18905
  65636. [GTK] Fix build with older pango (1.14.8)
  65637. * platform/graphics/gtk/FontGtk.cpp:
  65638. * platform/gtk/Language.cpp:
  65639. (_pango_get_lc_ctype):
  65640. (pango_language_get_default):
  65641. 2008-09-26 David Hyatt <hyatt@apple.com>
  65642. https://bugs.webkit.org/show_bug.cgi?id=21168
  65643. Make contentsToWindow/windowToContents cross-platform.
  65644. Reviewed by Oliver Hunt
  65645. * platform/ScrollView.cpp:
  65646. (WebCore::ScrollView::windowToContents):
  65647. (WebCore::ScrollView::contentsToWindow):
  65648. * platform/ScrollView.h:
  65649. * platform/gtk/ScrollViewGtk.cpp:
  65650. * platform/mac/ScrollViewMac.mm:
  65651. * platform/qt/ScrollViewQt.cpp:
  65652. * platform/win/ScrollViewWin.cpp:
  65653. * platform/wx/ScrollViewWx.cpp:
  65654. 2008-09-26 Sam Weinig <sam@webkit.org>
  65655. GTK build fix.
  65656. * GNUmakefile.am:
  65657. 2008-09-26 David Hyatt <hyatt@apple.com>
  65658. Eliminate shouldUpdateWhileOffscreen from ScrollView. Make the concept of not invalidating while
  65659. offscreen cross-platform. Rename the inWindow method to isOffscreen (which flips the boolean), since that
  65660. more clearly conveys the intent of the method. Make isOffscreen also check NSWindow visibility on Mac.
  65661. Reviewed by Oliver Hunt
  65662. * page/FrameView.cpp:
  65663. (WebCore::FrameView::repaintContentRectangle):
  65664. * page/FrameView.h:
  65665. * platform/ScrollView.h:
  65666. * platform/gtk/ScrollViewGtk.cpp:
  65667. (WebCore::ScrollView::isOffscreen):
  65668. * platform/mac/ScrollViewMac.mm:
  65669. (WebCore::ScrollView::updateContents):
  65670. (WebCore::ScrollView::isOffscreen):
  65671. * platform/qt/ScrollViewQt.cpp:
  65672. (WebCore::ScrollView::isOffscreen):
  65673. * platform/win/ScrollViewWin.cpp:
  65674. (WebCore::ScrollView::isOffscreen):
  65675. * platform/wx/ScrollViewWx.cpp:
  65676. (WebCore::ScrollView::isOffscreen):
  65677. * rendering/RenderObject.cpp:
  65678. (WebCore::RenderObject::willRenderImage):
  65679. 2008-09-26 David Hyatt <hyatt@apple.com>
  65680. https://bugs.webkit.org/show_bug.cgi?id=21164
  65681. Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.
  65682. Reviewed by Sam Weinig
  65683. * WebCore.base.exp:
  65684. * page/FrameView.cpp:
  65685. (WebCore::FrameView::setAllowsScrolling):
  65686. * page/FrameView.h:
  65687. * platform/ScrollView.cpp:
  65688. (WebCore::ScrollView::setAllowsScrolling):
  65689. * platform/ScrollView.h:
  65690. (WebCore::ScrollView::allowsScrolling):
  65691. * platform/win/ScrollViewWin.cpp:
  65692. (WebCore::ScrollView::wheelEvent):
  65693. 2008-09-26 Kevin Ollivier <kevino@theolliviers.com>
  65694. wx build fixes after Widget/ScrollView changes.
  65695. * platform/wx/PopupMenuWx.cpp:
  65696. (WebCore::PopupMenu::show):
  65697. * platform/wx/ScrollViewWx.cpp:
  65698. (WebCore::ScrollView::platformSetContentsSize):
  65699. (WebCore::ScrollView::platformSetScrollbarModes):
  65700. (WebCore::ScrollView::wheelEvent):
  65701. * platform/wx/TemporaryLinkStubs.cpp:
  65702. * platform/wx/WidgetWx.cpp:
  65703. (WebCore::Widget::containingWindow):
  65704. 2008-09-26 Timothy Hatcher <timothy@apple.com>
  65705. Allow searching for paths by always performing the
  65706. three search methods in the Elements panel and not
  65707. assume a search with a "/" is a XPath query.
  65708. https://bugs.webkit.org/show_bug.cgi?id=21159
  65709. Reviewed by Geoff Garen.
  65710. * page/inspector/ElementsPanel.js:
  65711. (WebInspector.ElementsPanel.prototype.performSearch):
  65712. 2008-09-26 Sam Weinig <sam@webkit.org>
  65713. Reviewed by Darin Adler.
  65714. Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
  65715. Speedup static property get/put
  65716. * DerivedSources.make:
  65717. * GNUmakefile.am:
  65718. * WebCore.pro:
  65719. * WebCore.vcproj/WebCore.vcproj:
  65720. * WebCore.xcodeproj/project.pbxproj:
  65721. * bindings/js/JSDOMBinding.cpp:
  65722. * bindings/js/JSDOMBinding.h:
  65723. * bindings/js/JSDOMWindowBase.cpp:
  65724. (WebCore::getDOMConstructor):
  65725. (WebCore::jsDOMWindowBaseCrypto):
  65726. (WebCore::jsDOMWindowBaseEvent):
  65727. (WebCore::jsDOMWindowBaseImage):
  65728. (WebCore::jsDOMWindowBaseMessageChannel):
  65729. (WebCore::jsDOMWindowBaseOption):
  65730. (WebCore::jsDOMWindowBaseXMLHttpRequest):
  65731. (WebCore::jsDOMWindowBaseAudio):
  65732. (WebCore::jsDOMWindowBaseXSLTProcessor):
  65733. (WebCore::jsDOMWindowBaseOnabort):
  65734. (WebCore::jsDOMWindowBaseOnblur):
  65735. (WebCore::jsDOMWindowBaseOnchange):
  65736. (WebCore::jsDOMWindowBaseOnclick):
  65737. (WebCore::jsDOMWindowBaseOndblclick):
  65738. (WebCore::jsDOMWindowBaseOnerror):
  65739. (WebCore::jsDOMWindowBaseOnfocus):
  65740. (WebCore::jsDOMWindowBaseOnkeydown):
  65741. (WebCore::jsDOMWindowBaseOnkeypress):
  65742. (WebCore::jsDOMWindowBaseOnkeyup):
  65743. (WebCore::jsDOMWindowBaseOnload):
  65744. (WebCore::jsDOMWindowBaseOnmousedown):
  65745. (WebCore::jsDOMWindowBaseOnmousemove):
  65746. (WebCore::jsDOMWindowBaseOnmouseout):
  65747. (WebCore::jsDOMWindowBaseOnmouseover):
  65748. (WebCore::jsDOMWindowBaseOnmouseup):
  65749. (WebCore::jsDOMWindowBaseOnMouseWheel):
  65750. (WebCore::jsDOMWindowBaseOnreset):
  65751. (WebCore::jsDOMWindowBaseOnresize):
  65752. (WebCore::jsDOMWindowBaseOnscroll):
  65753. (WebCore::jsDOMWindowBaseOnsearch):
  65754. (WebCore::jsDOMWindowBaseOnselect):
  65755. (WebCore::jsDOMWindowBaseOnsubmit):
  65756. (WebCore::jsDOMWindowBaseOnbeforeunload):
  65757. (WebCore::jsDOMWindowBaseOnunload):
  65758. (WebCore::jsDOMWindowBaseOnWebKitAnimationStart):
  65759. (WebCore::jsDOMWindowBaseOnWebKitAnimationIteration):
  65760. (WebCore::jsDOMWindowBaseOnWebKitAnimationEnd):
  65761. (WebCore::jsDOMWindowBaseOnWebKitTransitionEnd):
  65762. (WebCore::JSDOMWindowBase::getOwnPropertySlot):
  65763. (WebCore::JSDOMWindowBase::put):
  65764. (WebCore::setJSDOMWindowBaseOnabort):
  65765. (WebCore::setJSDOMWindowBaseOnblur):
  65766. (WebCore::setJSDOMWindowBaseOnchange):
  65767. (WebCore::setJSDOMWindowBaseOnclick):
  65768. (WebCore::setJSDOMWindowBaseOndblclick):
  65769. (WebCore::setJSDOMWindowBaseOnerror):
  65770. (WebCore::setJSDOMWindowBaseOnfocus):
  65771. (WebCore::setJSDOMWindowBaseOnkeydown):
  65772. (WebCore::setJSDOMWindowBaseOnkeypress):
  65773. (WebCore::setJSDOMWindowBaseOnkeyup):
  65774. (WebCore::setJSDOMWindowBaseOnload):
  65775. (WebCore::setJSDOMWindowBaseOnmousedown):
  65776. (WebCore::setJSDOMWindowBaseOnmousemove):
  65777. (WebCore::setJSDOMWindowBaseOnmouseout):
  65778. (WebCore::setJSDOMWindowBaseOnmouseover):
  65779. (WebCore::setJSDOMWindowBaseOnmouseup):
  65780. (WebCore::setJSDOMWindowBaseOnMouseWheel):
  65781. (WebCore::setJSDOMWindowBaseOnreset):
  65782. (WebCore::setJSDOMWindowBaseOnresize):
  65783. (WebCore::setJSDOMWindowBaseOnscroll):
  65784. (WebCore::setJSDOMWindowBaseOnsearch):
  65785. (WebCore::setJSDOMWindowBaseOnselect):
  65786. (WebCore::setJSDOMWindowBaseOnsubmit):
  65787. (WebCore::setJSDOMWindowBaseOnbeforeunload):
  65788. (WebCore::setJSDOMWindowBaseOnunload):
  65789. (WebCore::setJSDOMWindowBaseOnWebKitAnimationStart):
  65790. (WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration):
  65791. (WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd):
  65792. (WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd):
  65793. (WebCore::setJSDOMWindowBaseEvent):
  65794. (WebCore::setJSDOMWindowBaseAudio):
  65795. (WebCore::setJSDOMWindowBaseImage):
  65796. (WebCore::setJSDOMWindowBaseMessageChannel):
  65797. (WebCore::setJSDOMWindowBaseOption):
  65798. (WebCore::setJSDOMWindowBaseXMLHttpRequest):
  65799. (WebCore::setJSDOMWindowBaseXSLTProcessor):
  65800. * bindings/js/JSDOMWindowBase.h:
  65801. * bindings/js/JSDOMWindowCustom.cpp:
  65802. (WebCore::nonCachingStaticCloseFunctionGetter):
  65803. (WebCore::nonCachingStaticBlurFunctionGetter):
  65804. (WebCore::nonCachingStaticFocusFunctionGetter):
  65805. (WebCore::nonCachingStaticPostMessageFunctionGetter):
  65806. * bindings/js/JSDOMWindowCustom.h:
  65807. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  65808. * bindings/js/JSEventTargetBase.cpp:
  65809. * bindings/js/JSEventTargetBase.h:
  65810. (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
  65811. (WebCore::JSEventTargetBasePrototype::classInfo):
  65812. * bindings/js/JSEventTargetNode.cpp:
  65813. (WebCore::):
  65814. (WebCore::JSEventTargetNode::getOwnPropertySlot):
  65815. (WebCore::JSEventTargetNode::put):
  65816. * bindings/js/JSEventTargetNode.h:
  65817. (WebCore::JSEventTargetNode::classInfo):
  65818. (WebCore::JSEventTargetNode::prototypeClassName):
  65819. * bindings/js/JSEventTargetSVGElementInstance.cpp:
  65820. (WebCore::):
  65821. (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
  65822. (WebCore::JSEventTargetSVGElementInstance::put):
  65823. * bindings/js/JSEventTargetSVGElementInstance.h:
  65824. (WebCore::JSEventTargetSVGElementInstance::classInfo):
  65825. (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
  65826. * bindings/js/JSHTMLInputElementCustom.cpp:
  65827. (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
  65828. * bindings/js/JSHistoryCustom.cpp:
  65829. (WebCore::nonCachingStaticBackFunctionGetter):
  65830. (WebCore::nonCachingStaticForwardFunctionGetter):
  65831. (WebCore::nonCachingStaticGoFunctionGetter):
  65832. (WebCore::JSHistory::customGetOwnPropertySlot):
  65833. * bindings/js/JSLocationCustom.cpp:
  65834. (WebCore::nonCachingStaticReplaceFunctionGetter):
  65835. (WebCore::nonCachingStaticReloadFunctionGetter):
  65836. (WebCore::nonCachingStaticAssignFunctionGetter):
  65837. (WebCore::JSLocation::customGetOwnPropertySlot):
  65838. (WebCore::JSLocation::customPut):
  65839. * bindings/scripts/CodeGeneratorJS.pm:
  65840. 2008-09-26 David Hyatt <hyatt@apple.com>
  65841. https://bugs.webkit.org/show_bug.cgi?id=21149
  65842. Make the concept of scroll modes cross-platform. Move the scrollbars up into ScrollView as well.
  65843. Eliminate the unused isScrollable() method.
  65844. Reviewed by Sam Weinig
  65845. * WebCore.base.exp:
  65846. * page/FrameView.cpp:
  65847. (WebCore::FrameView::resetScrollbars):
  65848. (WebCore::FrameView::initScrollbars):
  65849. (WebCore::FrameView::layout):
  65850. * page/FrameView.h:
  65851. * page/mac/WebCoreFrameView.h:
  65852. * platform/ScrollView.cpp:
  65853. (WebCore::ScrollView::init):
  65854. (WebCore::ScrollView::setScrollbarModes):
  65855. (WebCore::ScrollView::scrollbarModes):
  65856. (WebCore::ScrollView::platformSetScrollbarModes):
  65857. (WebCore::ScrollView::platformScrollbarModes):
  65858. * platform/ScrollView.h:
  65859. (WebCore::ScrollView::horizontalScrollbar):
  65860. (WebCore::ScrollView::verticalScrollbar):
  65861. (WebCore::ScrollView::isScrollViewScrollbar):
  65862. (WebCore::ScrollView::setHorizontalScrollbarMode):
  65863. (WebCore::ScrollView::setVerticalScrollbarMode):
  65864. (WebCore::ScrollView::horizontalScrollbarMode):
  65865. (WebCore::ScrollView::verticalScrollbarMode):
  65866. (WebCore::ScrollView::convertSelfToChild):
  65867. * platform/gtk/ScrollViewGtk.cpp:
  65868. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  65869. (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  65870. (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  65871. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65872. (WebCore::ScrollView::updateScrollbars):
  65873. (WebCore::ScrollView::scrollbarUnderMouse):
  65874. (WebCore::ScrollView::isScrollViewScrollbar):
  65875. (WebCore::ScrollView::paint):
  65876. (WebCore::ScrollView::scroll):
  65877. * platform/mac/ScrollViewMac.mm:
  65878. (WebCore::ScrollView::platformSetScrollbarModes):
  65879. (WebCore::ScrollView::platformScrollbarModes):
  65880. * platform/qt/ScrollViewQt.cpp:
  65881. (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  65882. (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  65883. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65884. (WebCore::ScrollView::horizontalScrollbar):
  65885. (WebCore::ScrollView::verticalScrollbar):
  65886. (WebCore::ScrollView::invalidateScrollbars):
  65887. (WebCore::ScrollView::updateScrollbars):
  65888. (WebCore::ScrollView::scrollbarUnderMouse):
  65889. (WebCore::ScrollView::paint):
  65890. (WebCore::ScrollView::scroll):
  65891. * platform/win/ScrollViewWin.cpp:
  65892. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  65893. (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  65894. (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  65895. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65896. (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
  65897. (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling):
  65898. (WebCore::ScrollView::suppressScrollbars):
  65899. (WebCore::ScrollView::updateScrollbars):
  65900. (WebCore::ScrollView::scrollbarUnderMouse):
  65901. (WebCore::ScrollView::paint):
  65902. (WebCore::ScrollView::scroll):
  65903. * platform/wx/ScrollViewWx.cpp:
  65904. (WebCore::ScrollView::platformSetScrollbarModes):
  65905. (WebCore::ScrollView::platformScrollbarModes):
  65906. 2008-09-26 David Kilzer <ddkilzer@apple.com>
  65907. Fix Mac build with XPATH and XSLT disabled
  65908. Reviewed by Alexey.
  65909. * bindings/objc/DOMUtility.mm:
  65910. (JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
  65911. * dom/XMLTokenizerLibxml2.cpp:
  65912. (WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to
  65913. prevent an unused code warning.
  65914. 2008-09-26 Kevin McCullough <kmccullough@apple.com>
  65915. Rubber stamped by Tim Hatcher.
  65916. Bug 21098: Crashing under Console::log
  65917. - Speculative ASSERT to help find the problem.
  65918. * page/InspectorController.cpp:
  65919. (WebCore::ConsoleMessage::isEqual):
  65920. 2008-09-26 Holger Hans Peter Freyther <zecke@selfish.org>
  65921. [gtk+] Build fix for the latest ScrollView changes
  65922. * platform/gtk/ScrollViewGtk.cpp:
  65923. (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
  65924. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  65925. 2008-09-26 Timothy Hatcher <timothy@apple.com>
  65926. Fixes a bug where the console message repeat count would be wrong
  65927. when typing commands in between repeated messages.
  65928. https://bugs.webkit.org/show_bug.cgi?id=21145
  65929. Reviewed by Kevin McCullough.
  65930. * page/InspectorController.cpp:
  65931. (WebCore::InspectorController::clearConsoleMessages): Reset m_groupLevel.
  65932. (WebCore::InspectorController::didCommitLoad): Call clearConsoleMessages.
  65933. * page/inspector/Console.js:
  65934. (WebInspector.Console.prototype.addMessage): Remember the original repeat count
  65935. for each message as totalRepeatCount, since we now modify repeatCount to mean
  65936. repeats since previous console command. If repeatCountBeforeCommand is a number,
  65937. subtract that value from the repeatCount.
  65938. (WebInspector.Console.prototype.clearMessages): Delete the repeatCountBeforeCommand
  65939. and commandSincePreviousMessage properties.
  65940. 2008-09-26 Eric Carlson <eric.carlson@apple.com>
  65941. Reviewed by Antti
  65942. https://bugs.webkit.org/show_bug.cgi?id=21116
  65943. <rdar://problem/5726325> Audio from <video> can still be heard after navigating
  65944. back to page with <video>, then closing tab
  65945. Rename willSaveToCache/didRestoreFromCache callbacks to documentWillBecomeInactive/
  65946. documentDidBecomeActive, and post documentWillBecomeInactive when a page is marked for
  65947. deletion.
  65948. * dom/Document.cpp:
  65949. (WebCore::Document::documentWillBecomeInactive):
  65950. (WebCore::Document::documentDidBecomeActive):
  65951. (WebCore::Document::registerForDocumentActivationCallbacks):
  65952. (WebCore::Document::unregisterForDocumentActivationCallbacks):
  65953. * dom/Document.h:
  65954. * dom/Element.h:
  65955. (WebCore::Element::documentWillBecomeInactive):
  65956. (WebCore::Element::documentDidBecomeActive):
  65957. * history/CachedPage.cpp:
  65958. (WebCore::CachedPage::CachedPage):
  65959. * html/HTMLFormElement.cpp:
  65960. (WebCore::HTMLFormElement::~HTMLFormElement):
  65961. (WebCore::HTMLFormElement::parseMappedAttribute):
  65962. (WebCore::HTMLFormElement::documentDidBecomeActive):
  65963. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument):
  65964. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
  65965. * html/HTMLFormElement.h:
  65966. * html/HTMLInputElement.cpp:
  65967. (WebCore::HTMLInputElement::~HTMLInputElement):
  65968. (WebCore::HTMLInputElement::setInputType):
  65969. (WebCore::HTMLInputElement::parseMappedAttribute):
  65970. (WebCore::HTMLInputElement::needsActivationCallback):
  65971. (WebCore::HTMLInputElement::registerForActivationCallbackIfNeeded):
  65972. (WebCore::HTMLInputElement::unregisterForActivationCallbackIfNeeded):
  65973. (WebCore::HTMLInputElement::documentDidBecomeActive):
  65974. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
  65975. (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
  65976. * html/HTMLInputElement.h:
  65977. * html/HTMLMediaElement.cpp:
  65978. (WebCore::HTMLMediaElement::HTMLMediaElement):
  65979. (WebCore::HTMLMediaElement::~HTMLMediaElement):
  65980. (WebCore::HTMLMediaElement::documentWillBecomeInactive):
  65981. (WebCore::HTMLMediaElement::documentDidBecomeActive):
  65982. * html/HTMLMediaElement.h:
  65983. (WebCore::HTMLMediaElement::inActiveDocument):
  65984. * loader/FrameLoader.cpp:
  65985. (WebCore::FrameLoader::opened):
  65986. * page/Page.cpp:
  65987. (WebCore::Page::~Page):
  65988. * rendering/RenderMedia.cpp:
  65989. (WebCore::RenderMedia::updateControls):
  65990. * rendering/RenderVideo.cpp:
  65991. (WebCore::RenderVideo::updatePlayer):
  65992. * svg/SVGSVGElement.cpp:
  65993. (WebCore::SVGSVGElement::SVGSVGElement):
  65994. (WebCore::SVGSVGElement::~SVGSVGElement):
  65995. (WebCore::SVGSVGElement::documentWillBecomeInactive):
  65996. (WebCore::SVGSVGElement::documentDidBecomeActive):
  65997. * svg/SVGSVGElement.h:
  65998. 2008-09-26 Ariya Hidayat <ariya.hidayat@trolltech.com>
  65999. Reviewed by Simon
  66000. Fix the build inside Qt, don't create faulty prl files for now.
  66001. * WebCore.pro:
  66002. 2008-09-26 Simon Hausmann <hausmann@webkit.org>
  66003. Fix compilation on Qt/Windows
  66004. * Add WebCore/ to the include path so that config.h is found that enables JSC
  66005. * Link against winmm for the multimedia timer functions
  66006. * Include DateMath.h instead of JavaScriptCore/DateMath.h as file is in the kjs/
  66007. subdirectory
  66008. * In PluginViewWin.cpp don't use setPlatformWidget with the HWND for the Qt/Windows port
  66009. but set m_window directly as setPlatformWidget takes a QWidget*.
  66010. * WebCore.pro:
  66011. * platform/win/SystemTimeWin.cpp:
  66012. * plugins/win/PluginViewWin.cpp:
  66013. (WebCore::PluginView::init):
  66014. 2008-09-26 Oliver Hunt <oliver@apple.com>
  66015. Reviewed by Maciej Stachowiak.
  66016. Bug 21054: Construction of certain DOM objects is heavily regressed by r36675
  66017. <https://bugs.webkit.org/show_bug.cgi?id=21054>
  66018. This performance regression is actually just a symptom of a correctness
  66019. bug. The constructor objects for a number of properties that have security
  66020. checks on access were returning new objects each time. The most obvious
  66021. symptom of this bug is that window.Image != window.Image, etc.
  66022. The solution to this is to make sure we cache these constructors
  66023. in the same way as all the other DOM constructors. To achieve this
  66024. without causing any refcount cycles it is necessary to replace the
  66025. refcounted document pointer in the Image, MessageChannel, Option,
  66026. XMLHttpRequest, and Audio constructor objects with a reference to
  66027. the document's JS wrapper.
  66028. Tests: fast/dom/constructors-cached-navigate.html
  66029. fast/dom/constructors-cached.html
  66030. * WebCore.xcodeproj/project.pbxproj:
  66031. * bindings/js/JSAudioConstructor.cpp:
  66032. (WebCore::JSAudioConstructor::mark):
  66033. * bindings/js/JSAudioConstructor.h:
  66034. (WebCore::JSAudioConstructor::document):
  66035. * bindings/js/JSDOMWindowBase.cpp:
  66036. (WebCore::getDOMConstructor):
  66037. (WebCore::JSDOMWindowBase::getValueProperty):
  66038. * bindings/js/JSDOMWindowBase.h:
  66039. * bindings/js/JSHTMLOptionElementConstructor.cpp:
  66040. (WebCore::JSHTMLOptionElementConstructor::mark):
  66041. * bindings/js/JSHTMLOptionElementConstructor.h:
  66042. (WebCore::JSHTMLOptionElementConstructor::document):
  66043. * bindings/js/JSImageConstructor.cpp:
  66044. (WebCore::JSImageConstructor::mark):
  66045. * bindings/js/JSImageConstructor.h:
  66046. (WebCore::JSImageConstructor::document):
  66047. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  66048. (WebCore::JSXMLHttpRequestConstructor::mark):
  66049. * bindings/js/JSXMLHttpRequestConstructor.h:
  66050. (WebCore::JSXMLHttpRequestConstructor::document):
  66051. 2008-09-26 Simon Hausmann <hausmann@webkit.org>
  66052. Unreviewed one-liner build fix for the Qt/Windows build.
  66053. The build requires NPAPI support to be enabled, fix the condition in
  66054. the .pro file for that.
  66055. * WebCore.pro:
  66056. 2008-09-26 Trenton Schulz <twschulz@trolltech.com>
  66057. Reviewed by Simon.
  66058. Fix compilation with the Qt/Cocoa port.
  66059. * platform/qt/ScrollViewQt.cpp:
  66060. (WebCore::ScrollView::updateScrollbars):
  66061. 2008-09-26 Simon Hausmann <hausmann@webkit.org>
  66062. Reviewed by Holger.
  66063. Fix compilation with VC9SP1, work around bug in TR1 library by
  66064. disabling it.
  66065. * WebCore.pro:
  66066. 2008-09-26 Simon Hausmann <hausmann@webkit.org>
  66067. Reviewed by Holger.
  66068. Fix an lupdate() warning.
  66069. Don't use tr() in a class that is not a QObject, use
  66070. QCoreApplication::translate() directly.
  66071. * platform/qt/ScrollbarQt.cpp:
  66072. (WebCore::Scrollbar::handleContextMenuEvent):
  66073. 2008-09-25 David Hyatt <hyatt@apple.com>
  66074. Remove the scrollTo() method from FrameView, since it is not used by anyone.
  66075. Reviewed by Oliver Hunt
  66076. * page/FrameView.cpp:
  66077. * page/FrameView.h:
  66078. 2008-09-25 David Hyatt <hyatt@apple.com>
  66079. Make scrollRectIntoViewRecursively cross-platform.
  66080. Reviewed by Oliver Hunt
  66081. * platform/ScrollView.cpp:
  66082. (WebCore::ScrollView::scrollRectIntoViewRecursively):
  66083. * platform/gtk/ScrollViewGtk.cpp:
  66084. * platform/mac/ScrollViewMac.mm:
  66085. * platform/qt/ScrollViewQt.cpp:
  66086. * platform/win/ScrollViewWin.cpp:
  66087. * platform/wx/ScrollViewWx.cpp:
  66088. 2008-09-25 David Hyatt <hyatt@apple.com>
  66089. https://bugs.webkit.org/show_bug.cgi?id=21133
  66090. Rename resizeContents method on ScrollView to setContentsSize (to match contentsSize()). Make it
  66091. cross-platform.
  66092. Reviewed by Oliver Hunt
  66093. * loader/FrameLoader.cpp:
  66094. (WebCore::FrameLoader::begin):
  66095. * page/FrameView.cpp:
  66096. (WebCore::FrameView::adjustViewSize):
  66097. * platform/ScrollView.cpp:
  66098. (WebCore::ScrollView::setContentsSize):
  66099. * platform/ScrollView.h:
  66100. (WebCore::ScrollView::updateScrollbars):
  66101. * platform/gtk/ScrollViewGtk.cpp:
  66102. * platform/mac/ScrollViewMac.mm:
  66103. (WebCore::ScrollView::platformSetContentsSize):
  66104. * platform/qt/ScrollViewQt.cpp:
  66105. * platform/win/ScrollViewWin.cpp:
  66106. * platform/wx/ScrollViewWx.cpp:
  66107. (WebCore::ScrollView::platformSetContentsSize):
  66108. 2008-09-25 David Hyatt <hyatt@apple.com>
  66109. https://bugs.webkit.org/show_bug.cgi?id=21132
  66110. Clean up the methods that actually do the scrolling in ScrollView.
  66111. Reviewed by Oliver Hunt
  66112. * html/HTMLBodyElement.cpp:
  66113. (WebCore::HTMLBodyElement::setScrollLeft):
  66114. (WebCore::HTMLBodyElement::setScrollTop):
  66115. * loader/FrameLoader.cpp:
  66116. (WebCore::FrameLoader::restoreScrollPositionAndViewState):
  66117. * loader/ImageDocument.cpp:
  66118. (WebCore::ImageDocument::imageClicked):
  66119. * page/DOMWindow.cpp:
  66120. (WebCore::DOMWindow::scrollBy):
  66121. (WebCore::DOMWindow::scrollTo):
  66122. * page/FrameView.cpp:
  66123. (WebCore::FrameView::scrollTo):
  66124. (WebCore::FrameView::setScrollPosition):
  66125. * page/FrameView.h:
  66126. * platform/ScrollView.cpp:
  66127. (WebCore::ScrollView::maximumScrollPosition):
  66128. * platform/ScrollView.h:
  66129. (WebCore::ScrollView::contentsWidth):
  66130. (WebCore::ScrollView::contentsHeight):
  66131. (WebCore::ScrollView::scrollBy):
  66132. * platform/gtk/ScrollViewGtk.cpp:
  66133. (WebCore::ScrollView::setScrollPosition):
  66134. * platform/mac/ScrollViewMac.mm:
  66135. (WebCore::ScrollView::setScrollPosition):
  66136. * platform/qt/ScrollViewQt.cpp:
  66137. (WebCore::ScrollView::setScrollPosition):
  66138. (WebCore::ScrollView::scrollRectIntoViewRecursively):
  66139. * platform/win/ScrollViewWin.cpp:
  66140. (WebCore::ScrollView::setScrollPosition):
  66141. (WebCore::ScrollView::scrollRectIntoViewRecursively):
  66142. * platform/wx/ScrollViewWx.cpp:
  66143. (WebCore::ScrollView::setScrollPosition):
  66144. * rendering/RenderLayer.cpp:
  66145. (WebCore::RenderLayer::scrollByRecursively):
  66146. (WebCore::RenderLayer::scrollRectToVisible):
  66147. 2008-09-25 Dan Bernstein <mitz@apple.com>
  66148. - attempted Windows build fix
  66149. * platform/win/ScrollViewWin.cpp:
  66150. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  66151. (WebCore::ScrollView::setContentsPos):
  66152. (WebCore::ScrollView::paint):
  66153. 2008-09-25 Timothy Hatcher <timothy@apple.com>
  66154. Revert the padding changes done in r36905 to prevent the
  66155. scrollbar from overlapping the URLs in the Console.
  66156. https://bugs.webkit.org/show_bug.cgi?id=21126
  66157. * page/inspector/inspector.css:
  66158. 2008-09-25 David Hyatt <hyatt@apple.com>
  66159. https://bugs.webkit.org/show_bug.cgi?id=21129
  66160. Refactor contents size and scroll offset to be cross-platform. Reduce further the number
  66161. of platform-specific methods required of ScrollView implementations.
  66162. Reviewed by Tim Hatcher
  66163. * dom/MouseRelatedEvent.cpp:
  66164. (WebCore::contentsX):
  66165. (WebCore::contentsY):
  66166. * html/HTMLBodyElement.cpp:
  66167. (WebCore::HTMLBodyElement::scrollLeft):
  66168. (WebCore::HTMLBodyElement::setScrollLeft):
  66169. (WebCore::HTMLBodyElement::scrollTop):
  66170. (WebCore::HTMLBodyElement::setScrollTop):
  66171. * loader/FrameLoader.cpp:
  66172. (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
  66173. * page/DOMWindow.cpp:
  66174. (WebCore::DOMWindow::scrollX):
  66175. (WebCore::DOMWindow::scrollY):
  66176. * page/EventHandler.cpp:
  66177. (WebCore::EventHandler::hitTestResultAtPoint):
  66178. * page/FrameView.cpp:
  66179. (WebCore::FrameView::scrollTo):
  66180. (WebCore::FrameView::windowClipRect):
  66181. * platform/ScrollView.cpp:
  66182. (WebCore::ScrollView::visibleContentRect):
  66183. (WebCore::ScrollView::contentsSize):
  66184. (WebCore::ScrollView::platformContentsSize):
  66185. * platform/ScrollView.h:
  66186. (WebCore::ScrollView::scrollPosition):
  66187. (WebCore::ScrollView::scrollOffset):
  66188. (WebCore::ScrollView::scrollX):
  66189. (WebCore::ScrollView::scrollY):
  66190. (WebCore::ScrollView::contentsWidth):
  66191. (WebCore::ScrollView::contentsHeight):
  66192. * platform/gtk/ScrollViewGtk.cpp:
  66193. (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
  66194. (WebCore::ScrollView::setGtkAdjustments):
  66195. (WebCore::ScrollView::resizeContents):
  66196. (WebCore::ScrollView::contentsWidth):
  66197. (WebCore::ScrollView::contentsHeight):
  66198. (WebCore::ScrollView::scrollOffset):
  66199. (WebCore::ScrollView::maximumScroll):
  66200. (WebCore::ScrollView::scrollBy):
  66201. (WebCore::ScrollView::suppressScrollbars):
  66202. (WebCore::ScrollView::setHScrollbarMode):
  66203. (WebCore::ScrollView::setVScrollbarMode):
  66204. (WebCore::ScrollView::setScrollbarsMode):
  66205. (WebCore::ScrollView::setFrameGeometry):
  66206. (WebCore::ScrollView::updateScrollbars):
  66207. * platform/mac/ScrollViewMac.mm:
  66208. (WebCore::ScrollView::platformContentsSize):
  66209. (WebCore::ScrollView::scrollBy):
  66210. * platform/mac/WidgetMac.mm:
  66211. (WebCore::Widget::convertFromContainingWindow):
  66212. (WebCore::Widget::convertToContainingWindow):
  66213. * platform/qt/ScrollViewQt.cpp:
  66214. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  66215. (WebCore::ScrollView::resizeContents):
  66216. (WebCore::ScrollView::setFrameGeometry):
  66217. (WebCore::ScrollView::scrollOffset):
  66218. (WebCore::ScrollView::maximumScroll):
  66219. (WebCore::ScrollView::scrollBy):
  66220. (WebCore::ScrollView::setHScrollbarMode):
  66221. (WebCore::ScrollView::setVScrollbarMode):
  66222. (WebCore::ScrollView::setScrollbarsMode):
  66223. (WebCore::ScrollView::updateScrollbars):
  66224. * platform/win/ScrollViewWin.cpp:
  66225. (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
  66226. (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
  66227. (WebCore::ScrollView::resizeContents):
  66228. (WebCore::ScrollView::setFrameGeometry):
  66229. (WebCore::ScrollView::scrollOffset):
  66230. (WebCore::ScrollView::maximumScroll):
  66231. (WebCore::ScrollView::scrollBy):
  66232. (WebCore::ScrollView::setHScrollbarMode):
  66233. (WebCore::ScrollView::setVScrollbarMode):
  66234. (WebCore::ScrollView::setScrollbarsMode):
  66235. (WebCore::ScrollView::updateScrollbars):
  66236. * platform/wx/ScrollViewWx.cpp:
  66237. (WebCore::ScrollView::platformVisibleContentRect):
  66238. (WebCore::ScrollView::platformContentsSize):
  66239. * rendering/RenderBlock.cpp:
  66240. (WebCore::RenderBlock::nodeAtPoint):
  66241. * rendering/RenderLayer.cpp:
  66242. (WebCore::RenderLayer::scrollRectToVisible):
  66243. (WebCore::RenderLayer::calculateClipRects):
  66244. (WebCore::RenderLayer::calculateRects):
  66245. * rendering/RenderView.cpp:
  66246. (WebCore::RenderView::absolutePosition):
  66247. (WebCore::RenderView::computeAbsoluteRepaintRect):
  66248. 2008-09-25 David Smith <catfish.man@gmail.com>
  66249. Reviewed by Dave Hyatt.
  66250. Fix a nasty regression I introduced in the previous commit, which caused infinite recursion on facebook.
  66251. * dom/Element.cpp:
  66252. (WebCore::Element::rareData):
  66253. * dom/Element.h:
  66254. * dom/Node.cpp:
  66255. (WebCore::Node::rareData):
  66256. * dom/Node.h:
  66257. 2008-09-25 David Smith <catfish.man@gmail.com>
  66258. Reviewed by Darin Adler.
  66259. https://bugs.webkit.org/show_bug.cgi?id=20980
  66260. Split off uncommonly used data from Node similar to ElementRareData
  66261. Saves an OwnPtr and a short on Node, as well as providing room for an isContainer bit,
  66262. which in turn allows inlining firstChild(), lastChild(), childNodeCount(), and childNode()
  66263. for a 5-10+% performance win on SlickSpeed and assorted speedups on other tests.
  66264. * WebCore.base.exp:
  66265. * WebCore.xcodeproj/project.pbxproj:
  66266. * dom/ChildNodeList.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
  66267. * dom/ContainerNode.cpp: Set isContainer to true
  66268. (WebCore::ContainerNode::ContainerNode):
  66269. * dom/ContainerNode.h: These Node inlines are here to avoid including ContainerNode.h in Node.h
  66270. (WebCore::Node::containerChildNodeCount): Use ContainerNode's definition, having proved that the Node is a container
  66271. (WebCore::Node::containerChildNode): ditto
  66272. (WebCore::Node::containerFirstChild): ditto
  66273. (WebCore::Node::containerLastChild): ditto
  66274. * dom/Element.cpp: Most of the changes here are moving ElementRareData to ElementRareData.h and NodeRareData.h
  66275. (WebCore::Element::Element):
  66276. (WebCore::Element::~Element):
  66277. (WebCore::Element::rareData):
  66278. (WebCore::Element::ensureRareData): Renamed from createRareData
  66279. (WebCore::Element::createRareData): Used by ensureRareData to get the correct rareData type
  66280. (WebCore::Element::attach): Check hasRareData rather than null-checking rareData()
  66281. (WebCore::Element::detach): ditto
  66282. (WebCore::Element::recalcStyle): ditto
  66283. (WebCore::Element::focus):
  66284. (WebCore::Element::minimumSizeForResizing): ditto
  66285. (WebCore::Element::setMinimumSizeForResizing): ditto
  66286. (WebCore::Element::computedStyle):
  66287. (WebCore::Element::cancelFocusAppearanceUpdate): ditto
  66288. * dom/Element.h:
  66289. * dom/ElementRareData.h: Added; everything copied from Element.cpp
  66290. (WebCore::defaultMinimumSizeForResizing):
  66291. (WebCore::ElementRareData::ElementRareData):
  66292. (WebCore::ElementRareData::resetComputedStyle):
  66293. * dom/EventTargetNode.cpp:
  66294. (WebCore::EventTargetNode::EventTargetNode): Pass the isContainer flag up the chain
  66295. * dom/EventTargetNode.h:
  66296. * dom/Node.cpp:
  66297. (WebCore::Node::Node):
  66298. (WebCore::Node::~Node): rareData cleanup code moved from Element and changed to use hasRareData
  66299. (WebCore::Node::rareData):
  66300. (WebCore::Node::ensureRareData):
  66301. (WebCore::Node::createRareData):
  66302. (WebCore::Node::tabIndex): nonzero tab indexes are now in rareData
  66303. (WebCore::Node::setTabIndexExplicitly):
  66304. (WebCore::Node::childNodes): NodeLists are now in rareData
  66305. (WebCore::Node::setFocus):
  66306. (WebCore::Node::rareDataFocused):
  66307. (WebCore::Node::isFocusable):
  66308. (WebCore::Node::isKeyboardFocusable):
  66309. (WebCore::Node::registerDynamicNodeList): NodeLists are now in rareData
  66310. (WebCore::Node::unregisterDynamicNodeList): ditto
  66311. (WebCore::Node::notifyLocalNodeListsAttributeChanged): ditto
  66312. (WebCore::Node::notifyLocalNodeListsChildrenChanged): ditto
  66313. (WebCore::Node::getElementsByName): ditto
  66314. (WebCore::Node::getElementsByClassName): ditto
  66315. * dom/Node.h:
  66316. (WebCore::Node::firstChild): Use isContainerNode() to devirtualize
  66317. (WebCore::Node::lastChild): ditto
  66318. (WebCore::Node::isContainerNode): Take advantage of a newly freed bit to store whether we're a container
  66319. (WebCore::Node::focused): focus is in rareData if set
  66320. (WebCore::Node::childTypeAllowed):
  66321. (WebCore::Node::childNodeCount): Use isContainerNode() to devirtualize
  66322. (WebCore::Node::childNode): ditto
  66323. (WebCore::Node::hasRareData): Use another newly freed bit to store whether we have rare data; avoids doing hash lookups in the common case
  66324. * dom/NodeRareData.h: Added. Most of this is just properties moved from Node
  66325. (WebCore::NodeListsNodeData::~NodeListsNodeData): Moved from Node.cpp since we NodeRareData needs to put them in a HashTable :(
  66326. (WebCore::NodeRareData::NodeRareData):
  66327. (WebCore::NodeRareData::rareDataMap):
  66328. (WebCore::NodeRareData::rareDataFromMap):
  66329. (WebCore::NodeRareData::clearNodeLists):
  66330. (WebCore::NodeRareData::setNodeLists):
  66331. (WebCore::NodeRareData::nodeLists):
  66332. (WebCore::NodeRareData::tabIndex):
  66333. (WebCore::NodeRareData::setTabIndex):
  66334. (WebCore::NodeRareData::tabIndexSetExplicitly):
  66335. * dom/TreeWalker.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
  66336. * xml/XPathUtil.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
  66337. 2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
  66338. Reviewed by Simon Hausmann.
  66339. [qt] ImageBuffer::toDataURL implementation
  66340. There needs to be a Qt specific test result for the above mentioned
  66341. implementation.
  66342. * platform/graphics/qt/ImageBufferQt.cpp:
  66343. (WebCore::ImageBuffer::toDataURL):
  66344. 2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
  66345. Reviewed by Simon Hausmann.
  66346. [qt] Implement SharedBuffer for Qt.
  66347. * WebCore.pro:
  66348. * platform/qt/SharedBufferQt.cpp: Added.
  66349. (WebCore::SharedBuffer::createWithContentsOfFile):
  66350. * platform/qt/TemporaryLinkStubs.cpp:
  66351. 2008-09-25 Feng Qian <feng@chromium.org>
  66352. Fix bug: https://bugs.webkit.org/show_bug.cgi?id=21032
  66353. <rdar://problem/6243032>
  66354. Reviewed by Dave Hyatt.
  66355. Test: fast/dom/attribute-downcast-right.html
  66356. Add isMappedAttribute function to Attribute for checking if an object
  66357. is an instance of MappedAttribute. Removed attributeItem,
  66358. getAttributeItem functions from NamedMappedAttrMap, and callers
  66359. expecting MappedAttribute have to check isMappedAttribute before
  66360. downcasting the return value to MappedAttribute.
  66361. * css/CSSStyleSelector.cpp:
  66362. (WebCore::CSSStyleSelector::styleForElement):
  66363. * dom/Attribute.h:
  66364. (WebCore::Attribute::isMappedAttribute):
  66365. * dom/MappedAttribute.h:
  66366. (WebCore::MappedAttribute::isMappedAttribute):
  66367. * dom/NamedMappedAttrMap.cpp:
  66368. (WebCore::NamedMappedAttrMap::declCount):
  66369. (WebCore::NamedMappedAttrMap::mapsEquivalent):
  66370. * dom/NamedMappedAttrMap.h:
  66371. * dom/StyledElement.cpp:
  66372. (WebCore::StyledElement::attributeChanged):
  66373. * html/HTMLInputElement.cpp:
  66374. (WebCore::HTMLInputElement::setInputType):
  66375. * svg/SVGForeignObjectElement.cpp:
  66376. (WebCore::addCSSPropertyAndNotifyAttributeMap):
  66377. * svg/SVGStyledElement.cpp:
  66378. (WebCore::SVGStyledElement::getPresentationAttribute):
  66379. 2008-09-25 David Hyatt <hyatt@apple.com>
  66380. https://bugs.webkit.org/show_bug.cgi?id=21120
  66381. Make visibleContentRect cross-platform. Note this does add new horizontal/verticalScrollbar accessors
  66382. to a bunch of platforms. This is a temporary evil until the scrollbars get made cross-platform (and I
  66383. didn't want to mix that change in with this patch).
  66384. Reviewed by Sam Weinig
  66385. * page/Frame.cpp:
  66386. (WebCore::Frame::markAllMatchesForText):
  66387. * page/FrameView.cpp:
  66388. (WebCore::FrameView::repaintContentRectangle):
  66389. (WebCore::FrameView::windowClipRect):
  66390. (WebCore::FrameView::updateControlTints):
  66391. * platform/ScrollView.cpp:
  66392. (WebCore::ScrollView::visibleContentRect):
  66393. (WebCore::ScrollView::platformVisibleContentRect):
  66394. * platform/ScrollView.h:
  66395. (WebCore::ScrollView::visibleWidth):
  66396. (WebCore::ScrollView::visibleHeight):
  66397. * platform/gtk/ScrollViewGtk.cpp:
  66398. (WebCore::ScrollView::horizontalScrollbar):
  66399. (WebCore::ScrollView::verticalScrollbar):
  66400. * platform/mac/ScrollViewMac.mm:
  66401. (WebCore::ScrollView::horizontalScrollbar):
  66402. (WebCore::ScrollView::verticalScrollbar):
  66403. (WebCore::ScrollView::platformVisibleContentRect):
  66404. * platform/qt/ScrollViewQt.cpp:
  66405. (WebCore::ScrollView::horizontalScrollbar):
  66406. (WebCore::ScrollView::verticalScrollbar):
  66407. * platform/win/ScrollViewWin.cpp:
  66408. (WebCore::ScrollView::horizontalScrollbar):
  66409. (WebCore::ScrollView::verticalScrollbar):
  66410. * platform/wx/ScrollViewWx.cpp:
  66411. (WebCore::ScrollView::platformVisibleContentRect):
  66412. (WebCore::ScrollView::horizontalScrollbar):
  66413. (WebCore::ScrollView::verticalScrollbar):
  66414. * rendering/RenderLayer.cpp:
  66415. (WebCore::RenderLayer::scrollRectToVisible):
  66416. (WebCore::frameVisibleRect):
  66417. * rendering/RenderView.cpp:
  66418. (WebCore::RenderView::viewRect):
  66419. 2008-09-25 David Smith <catfish.man@gmail.com>
  66420. Reviewed by Timothy Hatcher
  66421. https://bugs.webkit.org/show_bug.cgi?id=21052
  66422. Generalize id selector special case for querySelectorAll
  66423. By checking the element we get with getElementById against the selector, we can use the special case in many more circumstances.
  66424. Changes results on http://native.khan.mozilla.org
  66425. from
  66426. #title: 2ms
  66427. h1#title: 55ms
  66428. div #title: 55ms
  66429. to:
  66430. #title: 1ms
  66431. h1#title: 2ms
  66432. div #title: 5ms
  66433. * dom/Node.cpp:
  66434. (WebCore::Node::querySelector):
  66435. * dom/SelectorNodeList.cpp:
  66436. (WebCore::createSelectorNodeList):
  66437. 2008-09-25 David Hyatt <hyatt@apple.com>
  66438. https://bugs.webkit.org/show_bug.cgi?id=21118
  66439. Make the concept of whether you can blit on scroll cross-platform on ScrollView.
  66440. Reviewed by Sam Weinig
  66441. * page/FrameView.cpp:
  66442. (WebCore::FrameView::clear):
  66443. (WebCore::FrameView::layout):
  66444. (WebCore::FrameView::setUseSlowRepaints):
  66445. (WebCore::FrameView::addSlowRepaintObject):
  66446. (WebCore::FrameView::removeSlowRepaintObject):
  66447. * platform/ScrollView.cpp:
  66448. (WebCore::ScrollView::init):
  66449. (WebCore::ScrollView::addChild):
  66450. (WebCore::ScrollView::removeChild):
  66451. (WebCore::ScrollView::setCanBlitOnScroll):
  66452. * platform/ScrollView.h:
  66453. (WebCore::ScrollView::canBlitOnScroll):
  66454. * platform/gtk/ScrollViewGtk.cpp:
  66455. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  66456. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  66457. (WebCore::ScrollView::ScrollView):
  66458. * platform/mac/ScrollViewMac.mm:
  66459. (WebCore::ScrollView::ScrollView):
  66460. (WebCore::ScrollView::platformAddChild):
  66461. (WebCore::ScrollView::platformRemoveChild):
  66462. (WebCore::ScrollView::platformSetCanBlitOnScroll):
  66463. * platform/qt/ScrollViewQt.cpp:
  66464. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  66465. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  66466. (WebCore::ScrollView::ScrollView):
  66467. * platform/win/ScrollViewWin.cpp:
  66468. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  66469. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  66470. (WebCore::ScrollView::ScrollView):
  66471. * platform/wx/ScrollViewWx.cpp:
  66472. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  66473. (WebCore::ScrollView::ScrollView):
  66474. (WebCore::ScrollView::scrollBy):
  66475. 2008-09-25 Kevin McCullough <kmccullough@apple.com>
  66476. Reviewed by Tim Hatcher.
  66477. Bug 21109: Console should right-align urls
  66478. * page/inspector/Console.js: Re-order the message elements so that when
  66479. it overflows it doesn't get mixed in with the next message.
  66480. * page/inspector/inspector.css:
  66481. 2008-09-25 David Hyatt <hyatt@apple.com>
  66482. https://bugs.webkit.org/show_bug.cgi?id=21113
  66483. Putting r36771 back in with a fix to the addPendingSheet check in CSSImportRule::insertedIntoParent.
  66484. Reviewed by Darin Adler
  66485. * css/CSSImportRule.cpp:
  66486. (WebCore::CSSImportRule::insertedIntoParent):
  66487. * css/CSSRule.cpp:
  66488. (WebCore::CSSRule::parentStyleSheet):
  66489. (WebCore::CSSRule::parentRule):
  66490. * css/CSSStyleSheet.cpp:
  66491. (WebCore::CSSStyleSheet::CSSStyleSheet):
  66492. * css/CSSStyleSheet.h:
  66493. 2008-09-25 Darin Adler <darin@apple.com>
  66494. Reviewed by Adele Peterson.
  66495. - fix https://bugs.webkit.org/show_bug.cgi?id=21115
  66496. <rdar://problem/6245773> REGRESSION (r34702): Safari no longer zips
  66497. bundled documents
  66498. * html/HTMLFormElement.cpp:
  66499. (WebCore::HTMLFormElement::formData): Use files() instead of value()
  66500. to get the path, since value() now returns just the basename.
  66501. 2008-09-25 Brady Eidson <beidson@apple.com>
  66502. Rubberstamped by Mark Rowe
  66503. Roll out 36771 as it caused <rdar://problem/6246554>
  66504. "nytimes.com doesn't display after returning to it with back/forward"
  66505. * css/CSSImportRule.cpp:
  66506. (WebCore::CSSImportRule::insertedIntoParent):
  66507. * css/CSSRule.cpp:
  66508. (WebCore::CSSRule::parentStyleSheet):
  66509. (WebCore::CSSRule::parentRule):
  66510. * css/CSSStyleSheet.cpp:
  66511. (WebCore::CSSStyleSheet::CSSStyleSheet):
  66512. (WebCore::CSSStyleSheet::docLoader):
  66513. * css/CSSStyleSheet.h:
  66514. (WebCore::CSSStyleSheet::doc):
  66515. 2008-09-25 Adam Roben <aroben@apple.com>
  66516. Windows build fix
  66517. * WebCore.vcproj/WebCore.vcproj: Add ScrollView.cpp to the project.
  66518. 2008-09-25 Dan Bernstein <mitz@apple.com>
  66519. - Windows build fix
  66520. * platform/win/ScrollViewWin.cpp:
  66521. (WebCore::ScrollView::addChildPlatformWidget):
  66522. (WebCore::ScrollView::removeChildPlatformWidget):
  66523. 2008-09-25 Timothy Hatcher <timothy@apple.com>
  66524. Fixes a leak of ConsoleMessage seen when repeated console
  66525. messages occur.
  66526. Reviewed by Mark Rowe.
  66527. * page/InspectorController.cpp:
  66528. (WebCore::InspectorController::addConsoleMessage): Delete the repeat
  66529. since we don't add it to m_consoleMessages.
  66530. 2008-09-25 Kevin McCullough <kmccullough@apple.com>
  66531. Reviewed by Dan Bernstein.
  66532. Bug 21105: XHRs logged in the console may show the wrong URL for the
  66533. source
  66534. - Get the url at the time of the send() and pass it on to the XHR.
  66535. * bindings/js/JSXMLHttpRequestCustom.cpp:
  66536. (WebCore::JSXMLHttpRequest::send):
  66537. * xml/XMLHttpRequest.cpp:
  66538. (WebCore::XMLHttpRequest::didFinishLoading):
  66539. * xml/XMLHttpRequest.h:
  66540. (WebCore::XMLHttpRequest::setLastSendURL):
  66541. 2008-09-25 Kevin McCullough <kmccullough@apple.com>
  66542. Reviewed by Geoff and Tim.
  66543. Bug 20322: XHRs logged in the console do not have line numbers
  66544. - Get the line number at the time of the send and pass it on to the XHR.
  66545. * bindings/js/JSXMLHttpRequestCustom.cpp:
  66546. (WebCore::JSXMLHttpRequest::send):
  66547. * xml/XMLHttpRequest.cpp:
  66548. (WebCore::XMLHttpRequest::XMLHttpRequest):
  66549. (WebCore::XMLHttpRequest::didFinishLoading):
  66550. * xml/XMLHttpRequest.h:
  66551. (WebCore::XMLHttpRequest::setLastSendLineNumber):
  66552. 2008-09-25 Eric Carlson <eric.carlson@apple.com>
  66553. Reviewed by Eric Seidel.
  66554. <rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
  66555. https://bugs.webkit.org/show_bug.cgi?id=21003
  66556. * dom/EventNames.h: remove "begin" event
  66557. * html/HTMLMediaElement.cpp:
  66558. (WebCore::HTMLMediaElement::load): Post "loadstart" event instead of "begin"
  66559. 2008-09-25 Alexey Proskuryakov <ap@webkit.org>
  66560. Reviewed by Eric Seidel.
  66561. https://bugs.webkit.org/show_bug.cgi?id=21097
  66562. Calling a MessageChannel constructor from a destroyed document results in a crash
  66563. Test: fast/events/message-port-constructor-for-deleted-document.html
  66564. * bindings/js/JSMessageChannelConstructor.cpp:
  66565. (WebCore::JSMessageChannelConstructor::construct):
  66566. * bindings/js/JSMessageChannelConstructor.h:
  66567. Made m_document a RefPtr.
  66568. 2008-09-24 Alexey Proskuryakov <ap@webkit.org>
  66569. Reviewed by Sam Weinig, Anders Carlsson, and (unofficially) Adam Barth.
  66570. https://bugs.webkit.org/show_bug.cgi?id=20879
  66571. Implement HTML5 channel messaging
  66572. Tests: fast/events/message-channel-gc.html
  66573. fast/events/message-port-deleted-document.html
  66574. fast/events/message-port-deleted-frame.html
  66575. fast/events/message-port-inactive-document.html
  66576. fast/events/message-port.html
  66577. http/tests/security/MessagePort/event-listener-context.html
  66578. * Configurations/WebCore.xcconfig:
  66579. Removed unused ENABLE_CROSS_DOCUMENT_MESSAGING macro.
  66580. * DerivedSources.make:
  66581. Added MessageChannel and MessagePort.
  66582. * WebCore.pro: Made MessageEvent compilation unconditional, as it could not possibly be
  66583. turmed off anyway. Added new files.
  66584. * GNUmakefile.am:
  66585. * WebCore.pro:
  66586. * WebCore.vcproj/WebCore.vcproj:
  66587. * WebCore.xcodeproj/project.pbxproj:
  66588. * WebCoreSources.bkl:
  66589. Added new files.
  66590. * bindings/js/JSDOMWindowBase.h:
  66591. * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
  66592. Added suport for window.MessageChannel constructor.
  66593. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  66594. * page/DOMWindow.cpp:
  66595. (WebCore::DOMWindow::postMessage):
  66596. * page/DOMWindow.h:
  66597. * page/DOMWindow.idl:
  66598. Added support for three-argument postMessage (that posts a MessagePort).
  66599. * dom/EventTarget.cpp:
  66600. (WebCore::EventTarget::toMessagePort):
  66601. * dom/EventTarget.h:
  66602. * bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): Added MessagePort as yet another
  66603. EventTarget variant.
  66604. * bindings/js/JSMessageChannelConstructor.h:
  66605. * bindings/js/JSMessageChannelConstructor.cpp: Added a custom constructor, so that it could
  66606. take a browsing context (document) parameter.
  66607. * bindings/js/JSMessageChannelCustom.cpp: Added.
  66608. (WebCore::JSMessageChannel::mark): JSMessageChannel uses a custom mark function to mark
  66609. port1 and port2 that it owns.
  66610. * bindings/js/JSMessagePortCustom.cpp: Added.
  66611. (WebCore::JSMessagePort::startConversation):
  66612. (WebCore::JSMessagePort::addEventListener):
  66613. (WebCore::JSMessagePort::removeEventListener):
  66614. (WebCore::JSMessagePort::dispatchEvent):
  66615. (WebCore::JSMessagePort::setOnmessage):
  66616. (WebCore::JSMessagePort::onmessage):
  66617. (WebCore::JSMessagePort::setOnclose):
  66618. (WebCore::JSMessagePort::onclose):
  66619. (WebCore::JSMessagePort::mark):
  66620. * dom/MessagePort.cpp: Added.
  66621. * dom/MessagePort.h: Added.
  66622. * dom/MessagePort.idl: Added.
  66623. Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works
  66624. with Documents as contexts, but in the future, it will be used for communication with worker
  66625. threads.
  66626. * bindings/objc/DOMInternal.h: Include "DOMMessagePortInternal.h". The new APIs do not
  66627. really have Obj-C bindings, as they are far from being final, but a MessagePort stub is
  66628. needed for MessageEvent.
  66629. * bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h for MessagePort happiness.
  66630. * dom/Document.cpp:
  66631. (WebCore::MessagePortTimer::MessagePortTimer):
  66632. (WebCore::MessagePortTimer::fired):
  66633. (WebCore::Document::processMessagePortMessagesSoon):
  66634. (WebCore::Document::~Document):
  66635. (WebCore::Document::dispatchMessagePortEvents):
  66636. (WebCore::Document::createdMessagePort):
  66637. (WebCore::Document::destroyedMessagePort):
  66638. * dom/Document.h:
  66639. Document keeps track of all MessagePort objects that were created when it was fully active
  66640. in its context.
  66641. * dom/EventNames.h: Added closeEvent.
  66642. * dom/MessageChannel.cpp: Added.
  66643. (WebCore::MessageChannel::MessageChannel):
  66644. (WebCore::MessageChannel::~MessageChannel):
  66645. * dom/MessageChannel.h: Added.
  66646. (WebCore::MessageChannel::create):
  66647. (WebCore::MessageChannel::port1):
  66648. (WebCore::MessageChannel::port2):
  66649. * dom/MessageChannel.idl: Added.
  66650. Addded JSMessageChannel implementation.
  66651. * dom/MessageEvent.cpp:
  66652. (WebCore::MessageEvent::MessageEvent):
  66653. (WebCore::MessageEvent::initMessageEvent):
  66654. * dom/MessageEvent.h:
  66655. (WebCore::MessageEvent::create):
  66656. (WebCore::MessageEvent::messagePort):
  66657. * dom/MessageEvent.idl:
  66658. MessageEvent has a MessagePort member now, making it possible to pass ports across
  66659. documents.
  66660. 2008-09-25 David Smith <catfish.man@gmail.com>
  66661. Reviewed by Eric Seidel
  66662. fix https://bugs.webkit.org/show_bug.cgi?id=21091
  66663. Regression: querySelector matches tag names case sensitively
  66664. Tests: fast/dom/SelectorAPI/caseTag.html
  66665. fast/dom/SelectorAPI/caseTagX.xhtml
  66666. * css/CSSParser.cpp:
  66667. (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
  66668. * css/CSSParser.h:
  66669. * dom/Node.cpp:
  66670. (WebCore::Node::querySelector):
  66671. (WebCore::Node::querySelectorAll):
  66672. 2008-09-24 David Hyatt <hyatt@apple.com>
  66673. https://bugs.webkit.org/show_bug.cgi?id=21084
  66674. Make the m_children member of ScrollView cross-platform. Consolidate children add/remove
  66675. functionality. Add platform stubs for connecting/disconnecting the platform widgets.
  66676. Reviewed by Sam Weinig
  66677. * GNUmakefile.am:
  66678. * WebCore.pro:
  66679. * WebCore.vcproj/WebCore.vcproj:
  66680. * WebCore.xcodeproj/project.pbxproj:
  66681. * WebCoreSources.bkl:
  66682. * platform/ScrollView.h:
  66683. (WebCore::ScrollView::children):
  66684. * platform/Widget.h:
  66685. * platform/gtk/ScrollViewGtk.cpp:
  66686. (WebCore::ScrollView::addChildPlatformWidget):
  66687. (WebCore::ScrollView::removeChildPlatformWidget):
  66688. (WebCore::ScrollView::geometryChanged):
  66689. * platform/mac/ScrollViewMac.mm:
  66690. (WebCore::ScrollView::addChildPlatformWidget):
  66691. (WebCore::ScrollView::removeChildPlatformWidget):
  66692. * platform/qt/ScrollViewQt.cpp:
  66693. (WebCore::ScrollView::geometryChanged):
  66694. (WebCore::ScrollView::addChildPlatformWidget):
  66695. (WebCore::ScrollView::removeChildPlatformWidget):
  66696. * platform/win/ScrollViewWin.cpp:
  66697. (WebCore::ScrollView::geometryChanged):
  66698. (WebCore::ScrollView::setParentVisible):
  66699. (WebCore::ScrollView::show):
  66700. (WebCore::ScrollView::hide):
  66701. * platform/wx/ScrollViewWx.cpp:
  66702. (WebCore::ScrollView::addChildPlatformWidget):
  66703. (WebCore::ScrollView::removeChildPlatformWidget):
  66704. 2008-09-25 Dan Bernstein <mitz@apple.com>
  66705. Reviewed by Dave Hyatt.
  66706. - fix https://bugs.webkit.org/show_bug.cgi?id=21024
  66707. <rdar://problem/6240821> Scrollbar not painted until hovered
  66708. * rendering/RenderWidget.cpp:
  66709. (WebCore::RenderWidget::setWidgetGeometry): Replaced resizeWidget with
  66710. this method, which sets both the location and the size.
  66711. (WebCore::RenderWidget::setWidget): Replaced the call to resizeWidget
  66712. with a call to the new method setWidgetGeometry. Positioning the
  66713. widget correctly ensures that the scroll bars invalidate correctly when
  66714. they are created and resized.
  66715. * rendering/RenderWidget.h:
  66716. 2008-09-24 Dan Bernstein <mitz@apple.com>
  66717. Rubber-stamped by Sam Weinig.
  66718. - create a "style" subfolder under "rendering" and move style files to that folder
  66719. * WebCore.vcproj/WebCore.vcproj:
  66720. 2008-09-24 Sam Weinig <sam@webkit.org>
  66721. Reviewed by Maciej Stachowiak.
  66722. Remove staticFunctionGetter. There is only one remaining user of
  66723. staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.
  66724. * bindings/js/JSDOMWindowBase.cpp:
  66725. (WebCore::JSDOMWindowBase::getOwnPropertySlot):
  66726. 2008-09-24 Jeremy Moskovich <jeremy@chromium.org>
  66727. Reviewed by Dan Bernstein.
  66728. Test: editing/spelling/inline_spelling_markers.html
  66729. - https://bugs.webkit.org/show_bug.cgi?id=20092
  66730. Spelling markers positioned incorrectly in RTL text
  66731. Measure spelling markers with selectionRectForText() to fix RTL.
  66732. This patch also fixes hit-testing for spelling marker tool tips,
  66733. which used to work only on the first line.
  66734. * rendering/InlineTextBox.cpp:
  66735. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
  66736. 2008-09-24 David Hyatt <hyatt@apple.com>
  66737. https://bugs.webkit.org/show_bug.cgi?id=21074
  66738. Make sure the viewless scrollbar knows how to paint properly when transformed.
  66739. Reviewed by Sam Weinig
  66740. * platform/mac/ScrollbarThemeMac.mm:
  66741. (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
  66742. (WebCore::ScrollbarThemeMac::paint):
  66743. 2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
  66744. Not reviewed. Try to fix win build.
  66745. * bindings/js/JSSVGElementInstanceCustom.cpp:
  66746. (WebCore::toJS):
  66747. * dom/ContainerNodeAlgorithms.h:
  66748. (WebCore::removeAllChildrenInContainer):
  66749. (WebCore::appendChildToContainer):
  66750. (WebCore::Private::addChildNodesToDeletionQueue):
  66751. 2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
  66752. Reviewed by Oliver.
  66753. Add ContainerNodeAlgorithms.h, as central place to share algorithms
  66754. operating on TreeShared-derived classes with a Node-style interface.
  66755. This allows SVGElementInstance & ContainerNode to share code.
  66756. * dom/ContainerNode.cpp:
  66757. (WebCore::ContainerNode::removeAllChildren):
  66758. (WebCore::ContainerNode::addChild):
  66759. * dom/ContainerNode.h:
  66760. * dom/ContainerNodeAlgorithms.h: Added.
  66761. (WebCore::removeAllChildrenInContainer):
  66762. (WebCore::appendChildToContainer):
  66763. (WebCore::Private::NodeRemovalDispatcher::dispatch):
  66764. (WebCore::Private::addChildNodesToDeletionQueue):
  66765. 2008-09-24 Simon Fraser <simon.fraser@apple.com>
  66766. Reviewed by Dave Hyatt
  66767. Wrap up dirtying the z-order list of the stacking context
  66768. RenderLayer into a method.
  66769. https://bugs.webkit.org/show_bug.cgi?id=21072
  66770. * rendering/RenderLayer.cpp:
  66771. (WebCore::RenderLayer::setHasVisibleContent):
  66772. (WebCore::RenderLayer::addChild):
  66773. (WebCore::RenderLayer::removeChild):
  66774. (WebCore::RenderLayer::dirtyStackingContextZOrderLists):
  66775. (WebCore::RenderLayer::styleChanged):
  66776. * rendering/RenderLayer.h:
  66777. * rendering/RenderObject.cpp:
  66778. (WebCore::RenderObject::setStyle):
  66779. 2008-09-24 Kevin McCullough <kmccullough@apple.com>
  66780. Reviewed by Tim.
  66781. Bug 21070: REGRESSION Repeated messages with arguments are not repeated
  66782. or displayed multiple times
  66783. - The Insepctor Controller was comparing JSValue pointers so thought the
  66784. message was not a repeat, but the JS of the inspector compared the
  66785. strings and so knew it was the same message and so overwrote the old
  66786. message.
  66787. * page/InspectorController.cpp:
  66788. (WebCore::ConsoleMessage::isEqual):
  66789. (WebCore::InspectorController::addMessageToConsole):
  66790. (WebCore::InspectorController::addConsoleMessage):
  66791. (WebCore::InspectorController::startGroup):
  66792. (WebCore::InspectorController::endGroup):
  66793. * page/InspectorController.h:
  66794. 2008-09-24 David Hyatt <hyatt@apple.com>
  66795. Make sure the viewless Mac scrollbar responds properly to system preference changes (including the
  66796. arrow placement preference and the thumb jump preference).
  66797. Reviewed by Adam Roben
  66798. * platform/Scrollbar.cpp:
  66799. (WebCore::Scrollbar::Scrollbar):
  66800. (WebCore::Scrollbar::~Scrollbar):
  66801. * platform/ScrollbarTheme.h:
  66802. (WebCore::ScrollbarTheme::registerScrollbar):
  66803. (WebCore::ScrollbarTheme::unregisterScrollbar):
  66804. * platform/mac/ScrollbarThemeMac.h:
  66805. * platform/mac/ScrollbarThemeMac.mm:
  66806. (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
  66807. (+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
  66808. (+[ScrollbarPrefsObserver registerAsObserver]):
  66809. (WebCore::ScrollbarThemeMac::registerScrollbar):
  66810. (WebCore::ScrollbarThemeMac::unregisterScrollbar):
  66811. (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
  66812. (WebCore::ScrollbarThemeMac::preferencesChanged):
  66813. 2008-09-24 Rob Buis <buis@kde.org>
  66814. Reviewed by Darin.
  66815. https://bugs.webkit.org/show_bug.cgi?id=20557
  66816. getScreenCTM() returns wrong values
  66817. Use the absolute position of the svg root when
  66818. determining the screen ctm.
  66819. Test: svg/custom/getscreenctm-in-mixed-content2.xhtml
  66820. * svg/SVGSVGElement.cpp:
  66821. (WebCore::SVGSVGElement::getScreenCTM):
  66822. 2008-09-24 David Hyatt <hyatt@apple.com>
  66823. Turn off support for CSS variables.
  66824. * ChangeLog:
  66825. * css/CSSParser.cpp:
  66826. (WebCore::CSSParser::createVariablesRule):
  66827. (WebCore::CSSParser::addVariable):
  66828. (WebCore::CSSParser::addVariableDeclarationBlock):
  66829. 2008-09-24 David Hyatt <hyatt@apple.com>
  66830. Back out the alternate forms of CSS variable call syntax (leaving only the -webkit-var version).
  66831. * css/CSSGrammar.y:
  66832. * css/CSSParserValues.cpp:
  66833. (WebCore::CSSParserValue::isVariable):
  66834. * css/CSSPrimitiveValue.cpp:
  66835. (WebCore::CSSPrimitiveValue::cleanup):
  66836. (WebCore::CSSPrimitiveValue::getStringValue):
  66837. (WebCore::CSSPrimitiveValue::cssText):
  66838. (WebCore::CSSPrimitiveValue::parserValue):
  66839. * css/CSSPrimitiveValue.h:
  66840. (WebCore::CSSPrimitiveValue::):
  66841. (WebCore::CSSPrimitiveValue::isVariable):
  66842. 2008-09-24 Timothy Hatcher <timothy@apple.com>
  66843. Fixes a regression where the "incorrect MIME-type" warning would not
  66844. show up correctly in the Console or the resources sidebar.
  66845. Reviewed by Kevin McCullough.
  66846. * page/inspector/Resource.js:
  66847. (WebInspector.Resource.prototype._addTip): Add the repeat count argument
  66848. to the WebInspector.ConsoleMessage constructor call.
  66849. (WebInspector.Resource.prototype._checkWarning): Ditto.
  66850. 2008-09-23 Tor Arne Vestbø <tavestbo@trolltech.com>
  66851. Reviewed by Simon.
  66852. Remove deprecated JS Qt bindings object call/construct code and fix autotests
  66853. * bridge/qt/qt_instance.cpp:
  66854. (JSC::Bindings::QtInstance::QtInstance):
  66855. * bridge/qt/qt_instance.h:
  66856. 2008-09-23 Julien Chaffraix <jchaffraix@pleyo.com>
  66857. Reviewed by Alp Toker. Landed by Jan Alonzo.
  66858. Bug 20883: [CURL] Add deferred loading
  66859. https://bugs.webkit.org/show_bug.cgi?id=20883
  66860. Implement deferred loading for the libcURL backend using curl_easy_pause.
  66861. As the method was introduced in version 7.18.0, all the code checks for libcURL
  66862. version.
  66863. * platform/network/curl/ResourceHandleCurl.cpp:
  66864. (WebCore::ResourceHandle::setDefersLoading):
  66865. * platform/network/curl/ResourceHandleManager.cpp:
  66866. (WebCore::writeCallback): Add an assertion that deferred loading is not
  66867. activated.
  66868. (WebCore::headerCallback): Ditto.
  66869. (WebCore::readCallback): Ditto.
  66870. (WebCore::ResourceHandleManager::dispatchSynchronousJob): Force
  66871. defersLoading to be false in order to avoid triggering an assertion.
  66872. (WebCore::ResourceHandleManager::initializeHandle): If deferred loading is
  66873. activated, pause the easy handle.
  66874. 2008-09-23 Matt Lilek <webkit@mattlilek.com>
  66875. Reviewed by Tim Hatcher.
  66876. Inspector search field style tweaks.
  66877. * page/inspector/inspector.css:
  66878. 2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
  66879. Reviewed by Eric.
  66880. Fixes: https://bugs.webkit.org/show_bug.cgi?id=21046 (Several LayoutTests crash)
  66881. Fix missing negation in EventTargetNode::insertedIntoDocument.
  66882. Made handleLocalEvents() virtual again, HTMLFormElement overrides it.
  66883. Remove code, that wasn't supposed to go in in dispatchGenericEvent().
  66884. * dom/EventTargetNode.cpp:
  66885. (WebCore::EventTargetNode::insertedIntoDocument):
  66886. (WebCore::EventTargetNode::dispatchGenericEvent):
  66887. * dom/EventTargetNode.h:
  66888. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  66889. Adds search support to the Profiles panel.
  66890. The Profiles panel supports a few types of queries:
  66891. * Standard string matching for function names and file URLs.
  66892. * Greater than and less than search for numeric columns.
  66893. So a query of ">24" will match all rows that have calls
  66894. greater than 24. Or "<=42" will match all 42 or less.
  66895. * Percent and time units. Adding a unit of "s", "ms" or "%"
  66896. is supported and will match only the Self and Total columns.
  66897. So a query of ">1.25s" will match all rows that took longer
  66898. than 1.25 seconds.
  66899. Reviewed by Oliver Hunt.
  66900. * page/inspector/ProfileView.js:
  66901. (WebInspector.ProfileView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
  66902. it will start at the first result.
  66903. (WebInspector.ProfileView.prototype.refreshShowAsPercents): Moved from the bottom of the file.
  66904. (WebInspector.ProfileView.prototype.searchCanceled): Clear the search properties and refresh highlighted
  66905. data grid nodes.
  66906. (WebInspector.ProfileView.prototype.performSearch): Search the profile nodes.
  66907. (WebInspector.ProfileView.prototype.jumpToFirstSearchResult): Does what the function says. Calls _jumpToSearchResult.
  66908. (WebInspector.ProfileView.prototype.jumpToLastSearchResult): Ditto.
  66909. (WebInspector.ProfileView.prototype.jumpToNextSearchResult): Ditto.
  66910. (WebInspector.ProfileView.prototype.jumpToPreviousSearchResult): Ditto.
  66911. (WebInspector.ProfileView.prototype.showingFirstSearchResult): Does what the function says.
  66912. (WebInspector.ProfileView.prototype.showingLastSearchResult): Ditto.
  66913. (WebInspector.ProfileView.prototype._jumpToSearchResult): Select and reveal the profile node.
  66914. Expand all the ancestors first so the profile node will have a DataGridNode.
  66915. (WebInspector.ProfileView.prototype._changeView): Perform the search again on the new tree.
  66916. (WebInspector.ProfileDataGridNode.prototype.createCell): Add the highlight class to cells that
  66917. have search matches.
  66918. * page/inspector/ProfilesPanel.js:
  66919. (WebInspector.ProfilesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
  66920. (WebInspector.ProfilesPanel.prototype.showProfile): Use profileViewForProfile.
  66921. (WebInspector.ProfilesPanel.prototype.showView): Call showProfile. Used by Panel to show a view.
  66922. (WebInspector.ProfilesPanel.prototype.profileViewForProfile): Create the ProfileView if needed.
  66923. (WebInspector.ProfilesPanel.prototype.closeVisibleView): Renamed visibleProfileView to visibleView.
  66924. (WebInspector.ProfilesPanel.prototype.get searchableViews): Return all the views.
  66925. (WebInspector.ProfilesPanel.prototype.searchMatchFound): Update the sidebar search matches.
  66926. (WebInspector.ProfilesPanel.prototype.searchCanceled): Clear all the sidebar search matches.
  66927. (WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches): Set the class and bubbleText.
  66928. * page/inspector/inspector.css: New style rules for the cell highlight color.
  66929. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  66930. Adds search support to the Resources and Scripts panels.
  66931. https://bugs.webkit.org/show_bug.cgi?id=21005
  66932. Reviewed by Oliver Hunt.
  66933. * page/inspector/Images/searchSmallBlue.png: Added.
  66934. * page/inspector/Images/searchSmallBrightBlue.png: Added.
  66935. * page/inspector/Images/searchSmallGray.png: Added.
  66936. * page/inspector/Images/searchSmallWhite.png: Added.
  66937. * page/inspector/ResourceView.js:
  66938. (WebInspector.ResourceView.prototype.attach): Attempt to attach to "resource-views"
  66939. or "script-resource-views" since one might not be created yet.
  66940. * page/inspector/ResourcesPanel.js:
  66941. (WebInspector.ResourcesPanel.prototype.show): Hide any views that are visible that
  66942. are not this panel's current visible view. This can happen when a ResourceView is
  66943. visible in the Scripts panel then switched to the this panel.
  66944. (WebInspector.ResourcesPanel.prototype.get searchableViews): Return all views, with the
  66945. visibleView first.
  66946. (WebInspector.ResourcesPanel.prototype.searchResultsSortFunction): Return a sort function
  66947. that uses the current graph search function. So cycling through results will be in the order
  66948. things appear in the sidebar.
  66949. (WebInspector.ResourcesPanel.prototype.searchMatchFound): Update the search matches on the
  66950. resource's sidebar tree element.
  66951. (WebInspector.ResourcesPanel.prototype.searchCanceled): Restore the error and warning bubbles
  66952. in the sidebar. Calls the Panel prototype's searchCanceled.
  66953. (WebInspector.ResourcesPanel.prototype.performSearch): Hide all the error and warning bubbles
  66954. in the sidebar. Calls the Panel prototype's performSearch.
  66955. (WebInspector.ResourcesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
  66956. (WebInspector.ResourcesPanel.prototype.addMessageToResource): Don't call updateErrorsAndWarnings
  66957. if there is a current search query.
  66958. (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
  66959. (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Ditto.
  66960. (WebInspector.ResourcesPanel.prototype.showView): Call showResource. Used by Panel to show a view.
  66961. (WebInspector.ResourceSidebarTreeElement.prototype.resetBubble): Clear all the classes and content.
  66962. (WebInspector.ResourceSidebarTreeElement.prototype.set searchMatches): Set the bubbleText and class.
  66963. (WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings): Call resetBubble.
  66964. * page/inspector/ScriptView.js:
  66965. (WebInspector.ScriptView): Set _sourceFrameSetup to flase.
  66966. (WebInspector.ScriptView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
  66967. it will start at the first result.
  66968. (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): Add an event listener for "syntax
  66969. highlighting complete".
  66970. (WebInspector.ScriptView.prototype): Share many methods with SourceView.
  66971. * page/inspector/ScriptsPanel.js:
  66972. (WebInspector.ScriptsPanel.prototype.show): Hide any views that are visible that are not this
  66973. This can happen when a ResourceView is visible in the Resources panel then switched to the this panel.
  66974. (WebInspector.ScriptsPanel.prototype.get searchableViews): Return all views, with the visibleView first.
  66975. (WebInspector.ScriptsPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
  66976. (WebInspector.ScriptsPanel.prototype.showView): Call _showScriptOrResource. Used by Panel to show a view.
  66977. (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource): Added helper.
  66978. * page/inspector/SourceFrame.js:
  66979. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Dispatch a "syntax highlighting complete" event.
  66980. * page/inspector/SourceView.js:
  66981. (WebInspector.SourceView.prototype.hide):
  66982. (WebInspector.SourceView.prototype.detach):
  66983. (WebInspector.SourceView.prototype._resourceLoadingFinished): Moved from the bottom of the file.
  66984. (WebInspector.SourceView.prototype._addBreakpoint): Ditto.
  66985. (WebInspector.SourceView.prototype.searchCanceled): Delete search properties.
  66986. (WebInspector.SourceView.prototype.performSearch): Search the frame if it is loaded, otherwise
  66987. store the worker function as _delayedFindSearchMatches and call it later in _sourceFrameSetupFinished.
  66988. (WebInspector.SourceView.prototype.jumpToFirstSearchResult):
  66989. (WebInspector.SourceView.prototype.jumpToLastSearchResult):
  66990. (WebInspector.SourceView.prototype.jumpToNextSearchResult):
  66991. (WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
  66992. (WebInspector.SourceView.prototype.showingFirstSearchResult):
  66993. (WebInspector.SourceView.prototype.showingLastSearchResult):
  66994. (WebInspector.SourceView.prototype._jumpToSearchResult): Selects the found Range.
  66995. (WebInspector.SourceView.prototype._sourceFrameSetupFinished): Calls _delayedFindSearchMatches.
  66996. (WebInspector.SourceView.prototype._syntaxHighlightingComplete): Call _sourceFrameSetupFinished.
  66997. * page/inspector/inspector.css:
  66998. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  66999. Rename some properties of ResourcesPanel and ScriptsPanel to be the same,
  67000. so future code can be shared.
  67001. https://bugs.webkit.org/show_bug.cgi?id=21005
  67002. Reviewed by Oliver Hunt.
  67003. * page/inspector/ResourcesPanel.js: Renamed resourceViews to viewsContainerElement.
  67004. And visibleResourceView to visibleView.
  67005. * page/inspector/ScriptsPanel.js: Renamed scriptResourceViews to viewsContainerElement.
  67006. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67007. Highlight all matched search results in the Elements panel DOM tree.
  67008. https://bugs.webkit.org/show_bug.cgi?id=21005
  67009. Reviewed by Oliver Hunt.
  67010. * page/inspector/ElementsPanel.js:
  67011. (WebInspector.ElementsPanel.prototype.searchCanceled): Clear the highlight
  67012. on all previous search results.
  67013. (WebInspector.ElementsPanel.prototype.performSearch): Set the hihglight
  67014. on all new search results.
  67015. * page/inspector/ElementsTreeOutline.js:
  67016. (WebInspector.ElementsTreeElement): Delay setting the title until onattach.
  67017. (WebInspector.ElementsTreeElement.prototype.get/set highlighted): Sets or removes
  67018. the highlighted class on the listItemElement.
  67019. (WebInspector.ElementsTreeElement.prototype.onattach): Set the highlighted class
  67020. if needed. Calls _updateTitle.
  67021. (WebInspector.ElementsTreeElement.prototype._updateTitle): Adds a span with the highlight
  67022. class so it can be styled when the highlighted class is present.
  67023. * page/inspector/inspector.css: New style rules for the hihglight.
  67024. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67025. Add search support to the Elements panel.
  67026. https://bugs.webkit.org/show_bug.cgi?id=21005
  67027. Reviewed by Oliver Hunt.
  67028. * page/inspector/ElementsPanel.js:
  67029. (WebInspector.ElementsPanel.prototype.searchCanceled): Call updateSearchMatchesCount
  67030. with a 0 match count to rest. Reset the other search properties.
  67031. (WebInspector.ElementsPanel.prototype.performSearch): Evaluates the search as an XPath
  67032. query and a CSS selector on all the Documents in the page. Remembers the found nodes
  67033. and avoids duplicates. Focuses the first result.
  67034. (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): Focuses the next result.
  67035. (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): Focuses the previous result.
  67036. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67037. Add support to Panel that allows easy searching of sub-views.
  67038. https://bugs.webkit.org/show_bug.cgi?id=21005
  67039. Reviewed by Oliver Hunt.
  67040. * page/inspector/Panel.js:
  67041. (WebInspector.Panel.prototype.searchCanceled): Call searchCanceled on all the
  67042. views in the search results and delete the currentQuery property. Call
  67043. WebInspector.updateSearchMatchesCount wit ha 0 match count to rest. Reset the
  67044. other search properties.
  67045. (WebInspector.Panel.prototype.performSearch): Call searchCanceled since it will
  67046. reset everything we need before doing a new search. Get an array of searchableViews
  67047. from the panel, implemented by sub-classes. Iterate over the views one-by-one
  67048. with an interval to prevent blocking the UI for large lists of searchableViews.
  67049. This keeps the interface really responsive. Pass a finishedCallback function to
  67050. the performSearch on each view so it can notify the panel of results.
  67051. (WebInspector.Panel.prototype.jumpToNextSearchResult): Finds the index in the
  67052. searchResults of the visibleView, so we know where in the results we are.
  67053. This is done every time incase the user manually navigates to a new view.
  67054. If the view is showing the last result, jump to the next view and show it's
  67055. first result. Otherwise jump to the next result in the current view.
  67056. (WebInspector.Panel.prototype.jumpToPreviousSearchResult): Ditto, but in reverse.
  67057. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67058. Add support for asking the current panel to perform a search, find next/previous and clear.
  67059. A search is performed on the new new current panel when switching between panels. The search
  67060. label/placeholder in the toolbar now includes the panel name to make it clear that panel will
  67061. be searched. The search field contents are selected when Command/Control-F or Enter/Return
  67062. is pressed, so the user can easily type an entirely new query. The search match count shows
  67063. up in the toolbar next to the search field.
  67064. Also changed:
  67065. * Rename lastQuery to currentQuery since it better matches the truth.
  67066. * Set the search field "results" attribute to zero since results arn't saved for
  67067. how we use the search field.
  67068. * Make repeated presses of the Return key jump to the next search result instead
  67069. of doing nothing.
  67070. * Increased the search field width.
  67071. https://bugs.webkit.org/show_bug.cgi?id=21005
  67072. Reviewed by Oliver Hunt.
  67073. * English.lproj/localizedStrings.js: New strings.
  67074. * page/inspector/inspector.css: New styles.
  67075. * page/inspector/inspector.html: Add the search-results-matches element. Add the
  67076. incremental attribute to the search field and set the results attribute to zero.
  67077. * page/inspector/inspector.js:
  67078. (WebInspector.set currentPanel): perform the search on the new panel.
  67079. (WebInspector.loaded): Change the event listeners and remove code that changes
  67080. the search label text.
  67081. (WebInspector.documentKeyDown): Add support for Command/Control-G and
  67082. Command/Control-Shift-G. To jump to the next and previous search results.
  67083. (WebInspector.updateSearchLabel): Added. Update the search placeholder/label.
  67084. This does different things depending on the attached state.
  67085. (WebInspector.searchKeyDown): Call preventDefault since this was the Enter key.
  67086. This prevents a "search" event from firing for key down. We handle the Enter key
  67087. on key up in searchKeyUp. This stops performSearch from being called twice in a row.
  67088. (WebInspector.searchKeyUp): Calls performSearch when it is the Enter key.
  67089. (WebInspector.performSearch): Delete the currentQuery property and call searchCanceled
  67090. on all the panels. Call jumpToNextSearchResult when this is the same query or a forced search.
  67091. Call updateSearchMatchesCount to reset the matches count in the toolbar.
  67092. (WebInspector.updateSearchMatchesCount): Added. Updates the matches count in the toolbar.
  67093. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67094. Remove the previous Inspector search code to make room for the new stuff.
  67095. https://bugs.webkit.org/show_bug.cgi?id=21005
  67096. Reviewed by Oliver Hunt.
  67097. * page/inspector/inspector.css:
  67098. * page/inspector/inspector.html:
  67099. * page/inspector/inspector.js:
  67100. (WebInspector.get/set showingSearchResults): Removed.
  67101. (WebInspector.searchResultsKeyDown): Removed.
  67102. (WebInspector.searchResultsResizerDragStart): Removed.
  67103. (WebInspector.searchResultsResizerDragEnd): Removed.
  67104. (WebInspector.searchResultsResizerDrag): Removed.
  67105. (WebInspector.performSearch): Removed searching parts.
  67106. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67107. Use the Array.remove helper function in more places.
  67108. https://bugs.webkit.org/show_bug.cgi?id=21037
  67109. Reviewed by Kevin McCullough.
  67110. * page/inspector/ResourceCategory.js:
  67111. (WebInspector.ResourceCategory.prototype.removeResource): Use Array.remove.
  67112. * page/inspector/ResourcesPanel.js:
  67113. (WebInspector.ResourcesPanel.prototype.removeResource): Ditto.
  67114. * page/inspector/inspector.js:
  67115. (WebInspector.removeResource): Ditto.
  67116. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67117. Fixes a bug where inspecting a node after reloading the page
  67118. would not reveal the node in the DOM tree. The TreeOutline
  67119. was not being told to forget decendants of a removed child.
  67120. So old TreeElements would be found that are not in the tree.
  67121. https://bugs.webkit.org/show_bug.cgi?id=21036
  67122. Reviewed by Kevin McCullough.
  67123. * page/inspector/treeoutline.js:
  67124. (TreeOutline._removeChildAtIndex): Call _forgetChildrenRecursive
  67125. in addition to _forgetTreeElement.
  67126. (TreeOutline._removeChildren): Call _forgetChildrenRecursive
  67127. in addition to _forgetTreeElement.
  67128. (TreeOutline._rememberTreeElement): Use Array.indexOf to quickly
  67129. search for known elements.
  67130. (TreeOutline._forgetTreeElement): Use Array.remove to remove elements.
  67131. (TreeOutline._forgetChildrenRecursive): Recursively traverse the
  67132. descendants and call _forgetTreeElement.
  67133. * page/inspector/utilities.js:
  67134. (Array.prototype.remove): Speed up this function by using Array.indexOf
  67135. when onlyFirst is true.
  67136. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67137. Fixes a bug where inspecting some short text nodes does
  67138. not reveal them in the Elements panel DOM tree.
  67139. https://bugs.webkit.org/show_bug.cgi?id=21035
  67140. Reviewed by Oliver Hunt.
  67141. * page/inspector/ElementsTreeOutline.js:
  67142. (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
  67143. The revealAndSelectNode() method might find a different element
  67144. if there is inlined text, and the select() call would change the
  67145. focusedDOMNode and reenter this setter. So to avoid calling
  67146. focusedNodeChanged() twice, first check if _focusedDOMNode is
  67147. the same node as the one passed in.
  67148. (WebInspector.ElementsTreeOutline.prototype.update): Remove use of
  67149. this.treeOutline, since this is the TreeOutline.
  67150. (WebInspector.ElementsTreeOutline.prototype.findTreeElement): Added.
  67151. Provides default functions for isAncestor, getParet and equal.
  67152. Calls the base protoype's findTreeElement. If that returns null
  67153. and the node is a text node, try finding it's parent.
  67154. (WebInspector.ElementsTreeOutline.prototype.revealNode): Removed.
  67155. Renamed to revealAndSelectNode.
  67156. (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
  67157. Selects and reveals the node passed in. Use the simple findTreeElement.
  67158. (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
  67159. Remove use of this.treeOutline, since this is the TreeOutline.
  67160. 2008-09-23 Timothy Hatcher <timothy@apple.com>
  67161. Fixes an exception that happened when removing a Resource
  67162. from the ResourcesPanel.
  67163. https://bugs.webkit.org/show_bug.cgi?id=21034
  67164. Reviewed by Kevin McCullough.
  67165. * page/inspector/ResourcesPanel.js:
  67166. (WebInspctor.ResourcesPanel.prototype.removeResource):
  67167. Remove the graphElement.
  67168. 2008-09-23 Kevin McCullough <kmccullough@apple.com>
  67169. Fixed "Time" to "Tim"
  67170. * ChangeLog:
  67171. 2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
  67172. Reviewed by Oliver.
  67173. Move mapInstanceToElement/removeInstanceMapping/instancesForElement
  67174. from SVGDocumentExtensions to SVGElement. It's more useful to store
  67175. the list of SVGElementInstances per SVGElement, instead of using
  67176. a document-wide hash for this purpose.
  67177. * svg/SVGAnimateMotionElement.cpp:
  67178. (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  67179. * svg/SVGAnimateTransformElement.cpp:
  67180. (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  67181. * svg/SVGAnimationElement.cpp:
  67182. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
  67183. * svg/SVGDocumentExtensions.cpp:
  67184. (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
  67185. * svg/SVGDocumentExtensions.h:
  67186. * svg/SVGElement.cpp:
  67187. (WebCore::SVGElement::mapInstanceToElement):
  67188. (WebCore::SVGElement::removeInstanceMapping):
  67189. (WebCore::SVGElement::instancesForElement):
  67190. * svg/SVGElement.h:
  67191. * svg/SVGElementInstance.cpp:
  67192. (WebCore::SVGElementInstance::SVGElementInstance):
  67193. (WebCore::SVGElementInstance::~SVGElementInstance):
  67194. (WebCore::SVGElementInstance::updateAllInstancesOfElement):
  67195. * svg/SVGElementInstance.h:
  67196. * svg/SVGStyledElement.cpp:
  67197. (WebCore::SVGStyledElement::svgAttributeChanged):
  67198. (WebCore::SVGStyledElement::childrenChanged):
  67199. * svg/SVGStyledElement.h:
  67200. 2008-09-23 Kevin Ollivier <kevino@theolliviers.com>
  67201. wx build fix.
  67202. * WebCoreSources.bkl:
  67203. 2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
  67204. Rubber stamped by Sam.
  67205. Move code from EventTarget to EventTargetNode.
  67206. I refactored most parts to live in EventTarget, a year ago,
  67207. though the implementation of EventTargetSVGElementInstance is
  67208. done in another way, that obsoletes this.
  67209. * dom/Document.cpp:
  67210. (WebCore::Document::addListenerTypeIfNeeded):
  67211. * dom/Document.h:
  67212. * dom/EventTarget.cpp:
  67213. * dom/EventTarget.h:
  67214. (WebCore::allowEventDispatch):
  67215. * dom/EventTargetNode.cpp:
  67216. (WebCore::EventTargetNode::insertedIntoDocument):
  67217. (WebCore::EventTargetNode::removedFromDocument):
  67218. (WebCore::EventTargetNode::willMoveToNewOwnerDocument):
  67219. (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
  67220. (WebCore::EventTargetNode::addEventListener):
  67221. (WebCore::EventTargetNode::removeEventListener):
  67222. (WebCore::EventTargetNode::removeAllEventListeners):
  67223. (WebCore::EventTargetNode::handleLocalEvents):
  67224. (WebCore::setCurrentEventTargetRespectingSVGTargetRules):
  67225. (WebCore::EventTargetNode::dispatchEvent):
  67226. (WebCore::EventTargetNode::dispatchGenericEvent):
  67227. (WebCore::EventTargetNode::dispatchWindowEvent):
  67228. (WebCore::EventTargetNode::removeEventListenerForType):
  67229. * dom/EventTargetNode.h:
  67230. * svg/EventTargetSVGElementInstance.cpp:
  67231. (WebCore::EventTargetSVGElementInstance::dispatchEvent):
  67232. * svg/SVGElement.cpp:
  67233. (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  67234. * svg/SVGElement.h:
  67235. (WebCore::SVGElement::supplementalTransform):
  67236. 2008-09-23 Dave Hyatt <hyatt@apple.com>
  67237. Fix for bug 21012. The Aqua scrollbar was returning the wrong track rect on Windows Aqua theme. Make
  67238. sure to not accidentally fall into the vertical scrollbar case for horizontal scrollbars. :)
  67239. Reviewed by Sam Weinig
  67240. * platform/mac/ScrollbarThemeMac.mm:
  67241. (WebCore::ScrollbarThemeMac::trackRect):
  67242. * platform/win/ScrollbarThemeSafari.cpp:
  67243. (WebCore::ScrollbarTheme::nativeTheme):
  67244. (WebCore::ScrollbarThemeSafari::trackRect):
  67245. 2008-09-23 Beth Dakin <bdakin@apple.com>
  67246. Reviewed by Sam Weinig.
  67247. Fix for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add Contact"
  67248. link at gmail does not support AXPress action
  67249. and corresponding: <rdar://problem/6216178>
  67250. I fixed this bug by making AccessibilityObject::anchorElement
  67251. support ARIA links.
  67252. * page/AccessibilityImageMapLink.cpp:
  67253. (WebCore::AccessibilityImageMapLink::anchorElement):
  67254. * page/AccessibilityImageMapLink.h:
  67255. * page/AccessibilityObject.cpp:
  67256. (WebCore::AccessibilityObject::anchorElement):
  67257. * page/AccessibilityObject.h:
  67258. (WebCore::AccessibilityObject::isNativeAnchor):
  67259. * page/AccessibilityRenderObject.cpp:
  67260. (WebCore::AccessibilityRenderObject::isNativeAnchor):
  67261. (WebCore::AccessibilityRenderObject::anchorElement):
  67262. (WebCore::AccessibilityRenderObject::internalLinkElement):
  67263. (WebCore::AccessibilityRenderObject::url):
  67264. * page/AccessibilityRenderObject.h:
  67265. * page/mac/AccessibilityObjectWrapper.mm:
  67266. (AXLinkElementForNode):
  67267. 2008-09-23 Kevin McCullough <kmccullough@apple.com>
  67268. Reviewed by Tim and Oliver.
  67269. Bug 20949: Catch repeated messages in Inspector Controller to limit
  67270. memory usage
  67271. - Store the repeat count in the Console Message object, in the
  67272. Inspector Controller and JS ConsoleMessage object.
  67273. * page/InspectorController.cpp:
  67274. (WebCore::ConsoleMessage::ConsoleMessage):
  67275. (WebCore::ConsoleMessage::operator==):
  67276. (WebCore::InspectorController::InspectorController):
  67277. (WebCore::InspectorController::addConsoleMessage):
  67278. (WebCore::InspectorController::addScriptConsoleMessage):
  67279. * page/InspectorController.h:
  67280. * page/inspector/Console.js:
  67281. * page/inspector/Resource.js:
  67282. * page/inspector/ResourcesPanel.js:
  67283. * page/inspector/SourceFrame.js:
  67284. 2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
  67285. Reviewed by Eric.
  67286. Working on proper EventTarget support for SVGElementInstance.
  67287. Add new EventTargetSVGElementInstance class, and it's corresponding JS wrapper.
  67288. Finally JSEventTargetBase, is actually used for another class than JSEventTargetnode.
  67289. Remove EventTarget inheritance from SVGElementInstance, and the manual "TreeShared"
  67290. implementation. Let it use TreeShared directly.
  67291. It's not activated so far (SVGUseElement still creating SVGElementInstance objects).
  67292. The transition to EventTargetSVGElementInstance will be done in a few individual patches.
  67293. * GNUmakefile.am:
  67294. * WebCore.pro:
  67295. * WebCore.vcproj/WebCore.vcproj:
  67296. * WebCore.xcodeproj/project.pbxproj:
  67297. * bindings/js/JSEventTargetBase.cpp:
  67298. (WebCore::retrieveEventTargetAndCorrespondingNode):
  67299. (WebCore::toJS):
  67300. * bindings/js/JSEventTargetBase.h:
  67301. * bindings/js/JSEventTargetSVGElementInstance.cpp: Added.
  67302. (WebCore::):
  67303. (WebCore::JSEventTargetSVGElementInstance::JSEventTargetSVGElementInstance):
  67304. (WebCore::JSEventTargetSVGElementInstance::createPrototype):
  67305. (WebCore::JSEventTargetSVGElementInstance::setListener):
  67306. (WebCore::JSEventTargetSVGElementInstance::getListener):
  67307. (WebCore::toEventTargetSVGElementInstance):
  67308. * bindings/js/JSEventTargetSVGElementInstance.h: Added.
  67309. (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
  67310. (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
  67311. (WebCore::JSEventTargetSVGElementInstance::getValueProperty):
  67312. (WebCore::JSEventTargetSVGElementInstance::put):
  67313. (WebCore::JSEventTargetSVGElementInstance::putValueProperty):
  67314. * bindings/js/JSSVGElementInstanceCustom.cpp: Added.
  67315. (WebCore::toJS):
  67316. * bindings/objc/DOM.mm:
  67317. (+[DOMNode _wrapEventTarget:WebCore::]):
  67318. (-[DOMSVGElementInstance _initWithSVGElementInstance:WebCore::]):
  67319. (+[DOMSVGElementInstance _wrapSVGElementInstance:WebCore::]):
  67320. (+[DOMSVGElementInstance _wrapEventTarget:WebCore::]):
  67321. (-[DOMSVGElementInstance WebCore::]):
  67322. (-[DOMSVGElementInstance addEventListener:listener:useCapture:]):
  67323. (-[DOMSVGElementInstance addEventListener:::]):
  67324. (-[DOMSVGElementInstance removeEventListener:listener:useCapture:]):
  67325. (-[DOMSVGElementInstance removeEventListener:::]):
  67326. (-[DOMSVGElementInstance dispatchEvent:]):
  67327. * bindings/objc/DOMEvents.h:
  67328. * bindings/scripts/CodeGeneratorJS.pm:
  67329. * bindings/scripts/CodeGeneratorObjC.pm:
  67330. * svg/EventTargetSVGElementInstance.cpp: Added.
  67331. (WebCore::EventTargetSVGElementInstance::EventTargetSVGElementInstance):
  67332. (WebCore::EventTargetSVGElementInstance::~EventTargetSVGElementInstance):
  67333. (WebCore::EventTargetSVGElementInstance::addEventListener):
  67334. (WebCore::EventTargetSVGElementInstance::removeEventListener):
  67335. (WebCore::EventTargetSVGElementInstance::dispatchEvent):
  67336. * svg/EventTargetSVGElementInstance.h: Added.
  67337. (WebCore::EventTargetSVGElementInstance::isEventTargetSVGElementInstance):
  67338. (WebCore::EventTargetSVGElementInstance::toNode):
  67339. (WebCore::EventTargetSVGElementInstance::toSVGElementInstance):
  67340. (WebCore::EventTargetSVGElementInstance::refEventTarget):
  67341. (WebCore::EventTargetSVGElementInstance::derefEventTarget):
  67342. (WebCore::EventTargetSVGElementInstanceCast):
  67343. * svg/SVGElement.cpp:
  67344. (WebCore::SVGElement::dispatchEvent):
  67345. * svg/SVGElementInstance.cpp:
  67346. (WebCore::SVGElementInstance::SVGElementInstance):
  67347. (WebCore::SVGElementInstance::~SVGElementInstance):
  67348. * svg/SVGElementInstance.h:
  67349. (WebCore::SVGElementInstance::isEventTargetSVGElementInstance):
  67350. * svg/SVGElementInstance.idl:
  67351. 2008-09-23 Dan Bernstein <mitz@apple.com>
  67352. Reviewed by Dave Hyatt.
  67353. - https://bugs.webkit.org/show_bug.cgi?id=21040
  67354. Pass NULL instead of the identity matrix to CTFontCreateWithGraphicsFont()
  67355. * platform/graphics/mac/SimpleFontDataMac.mm:
  67356. (WebCore::SimpleFontData::getCTFont):
  67357. 2008-09-23 David Hyatt <hyatt@apple.com>
  67358. https://bugs.webkit.org/show_bug.cgi?id=21039
  67359. Teach the viewless Mac scrollbar how to avoid NSWindow's resizer.
  67360. Reviewed by Sam Weinig
  67361. * platform/ScrollView.h:
  67362. * platform/Scrollbar.cpp:
  67363. (WebCore::Scrollbar::setFrameGeometry):
  67364. * platform/Scrollbar.h:
  67365. * platform/Widget.cpp:
  67366. (WebCore::Widget::convertFromContainingWindow):
  67367. * platform/Widget.h:
  67368. * platform/mac/ScrollViewMac.mm:
  67369. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  67370. (WebCore::ScrollView::ScrollView):
  67371. (WebCore::ScrollView::~ScrollView):
  67372. (WebCore::ScrollView::windowResizerRect):
  67373. (WebCore::ScrollView::resizerOverlapsContent):
  67374. (WebCore::ScrollView::adjustOverlappingScrollbarCount):
  67375. (WebCore::ScrollView::setParent):
  67376. * platform/mac/WidgetMac.mm:
  67377. (WebCore::Widget::convertFromContainingWindow):
  67378. 2008-09-23 Dirk Schulze <vbs85@gmx.de>
  67379. Reviewed by Darin Adler. Landed by Jan Alonzo.
  67380. Added support for getImageData() and putImageData()
  67381. to Cairo.
  67382. [CAIRO] needs getImageData and putImageData support
  67383. https://bugs.webkit.org/show_bug.cgi?id=20838
  67384. * platform/graphics/cairo/ImageBufferCairo.cpp:
  67385. (WebCore::ImageBuffer::ImageBuffer):
  67386. (WebCore::ImageBuffer::getImageData):
  67387. (WebCore::ImageBuffer::putImageData):
  67388. 2008-09-23 Marco Barisione <marco.barisione@collabora.co.uk>
  67389. Reviewed by Holger Freyther.
  67390. http://bugs.webkit.org/show_bug.cgi?id=18987
  67391. [GTK] Implement SharedBuffer::createWithContentsOfFile and
  67392. KURL::fileSystemPath
  67393. * GNUmakefile.am: Add KURLGtk.cpp and SharedBufferGtk.cpp.
  67394. * platform/gtk/KURLGtk.cpp: Added.
  67395. (WebCore::KURL::fileSystemPath): Implemented.
  67396. * platform/gtk/SharedBufferGtk.cpp: Added.
  67397. (WebCore::SharedBuffer::createWithContentsOfFile): Implemented.
  67398. * platform/gtk/TemporaryLinkStubs.cpp: Remove the old stubs.
  67399. 2008-09-23 Alexey Proskuryakov <ap@webkit.org>
  67400. Reviewed by Oliver Hunt, okayed by Darin Adler.
  67401. <rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app
  67402. * rendering/InlineTextBox.cpp:
  67403. (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
  67404. 2008-09-23 Alexey Proskuryakov <ap@webkit.org>
  67405. Reviewed by Darin Adler.
  67406. https://bugs.webkit.org/show_bug.cgi?id=21023
  67407. Don't use TEC for encodings supported by ICU
  67408. * platform/text/mac/mac-encodings.txt: Removed x-mac-centraleurroman, x-mac-cyrillic,
  67409. x-mac-greek, and x-mac-turkish.
  67410. * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
  67411. Register aliases for these encodings that are not registered automatically; updated comments.
  67412. 2008-09-23 Maciej Stachowiak <mjs@apple.com>
  67413. Reviewed by Darin.
  67414. - speed up instanceof some more
  67415. https://bugs.webkit.org/show_bug.cgi?id=20818
  67416. ~2% speedup on EarleyBoyer
  67417. (WebCore updates.)
  67418. * bindings/js/JSQuarantinedObjectWrapper.h:
  67419. (WebCore::JSQuarantinedObjectWrapper::createStructureID):
  67420. 2008-09-22 Darin Adler <darin@apple.com>
  67421. Reviewed by Oliver Hunt.
  67422. - fix https://bugs.webkit.org/show_bug.cgi?id=21008
  67423. getting pixels by index from CanvasPixelArray is unnecessarily slow
  67424. * GNUmakefile.am: Added JSCanvasPixelArrayCustom.h.
  67425. * WebCore.vcproj/WebCore.vcproj: Ditto.
  67426. * WebCore.xcodeproj/project.pbxproj: Ditto.
  67427. * bindings/js/JSCanvasPixelArrayCustom.cpp: Removed indexGetter and
  67428. indexSetter. These are now both inlined, so in the header.
  67429. * bindings/js/JSCanvasPixelArrayCustom.h: Added. The getByIndex
  67430. function is what's used for HasCustomIndexGetter. Also moved the
  67431. indexSetter function here.
  67432. * bindings/scripts/CodeGeneratorJS.pm: Changed HasCustomIndexGetter
  67433. to use a getByIndex member function rather than an indexGetter static
  67434. member function in a property slot. This lets us avoid the property
  67435. slot mechanism's rule where it turns numeric property names into
  67436. strings in the identifier table, which is good because that's slow.
  67437. Also added a new property CustomHeader that allows IDL files to
  67438. introduce headers to be included -- useful when we have functions
  67439. that we want to inline into the binding.
  67440. * html/CanvasPixelArray.idl: Added CustomHeader attribute.
  67441. 2008-09-23 Eric Seidel <eric@webkit.org>
  67442. No review, build fix only.
  67443. Another blind stab in the dark.
  67444. * svg/graphics/cg/SVGResourceClipperCg.cpp: Add missing header.
  67445. 2008-09-23 Eric Seidel <eric@webkit.org>
  67446. No review, build fix only.
  67447. Third time's the charm, eh? My local build is sadly still not done...
  67448. * platform/graphics/AffineTransform.cpp: remove extra &
  67449. * platform/graphics/AffineTransform.h: remove extra &
  67450. 2008-09-22 Eric Seidel <eric@webkit.org>
  67451. No review, build fix only.
  67452. * platform/graphics/AffineTransform.cpp: remove extra ;
  67453. 2008-09-22 Eric Seidel <eric@webkit.org>
  67454. No review, build fix only.
  67455. Speculative fix for the build while I wait for my compile to finish.
  67456. * platform/graphics/AffineTransform.cpp:
  67457. 2008-09-22 Dirk Schulze <vbs85@gmx.de>
  67458. Reviewed by eseidel. Landed by eseidel.
  67459. Moved makeMapBetweenRects from SVG/CG to AffineTransform
  67460. Make SVGResourceClipper::applyClip more cross-platform
  67461. * platform/graphics/AffineTransform.cpp:
  67462. * platform/graphics/AffineTransform.h:
  67463. * svg/graphics/cg/CgSupport.cpp:
  67464. * svg/graphics/cg/CgSupport.h:
  67465. * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
  67466. (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
  67467. * svg/graphics/cg/SVGResourceClipperCg.cpp:
  67468. (WebCore::SVGResourceClipper::applyClip):
  67469. 2008-09-22 Alp Toker <alp@nuanti.com>
  67470. Reviewed by David Hyatt.
  67471. https://bugs.webkit.org/show_bug.cgi?id=16331
  67472. [Gtk] no focus when button/checkbox/radiobutton clicked, only when tabbed
  67473. Obey GTK+ focusing conventions for controls and anchor elements.
  67474. It could be interesting to push these decisions up to Settings or
  67475. ChromeClient some day but this gets things working.
  67476. Right and middle click events still need some work to match GTK+
  67477. conventions.
  67478. * html/HTMLAnchorElement.cpp:
  67479. (WebCore::HTMLAnchorElement::isMouseFocusable):
  67480. * html/HTMLFormControlElement.cpp:
  67481. (WebCore::HTMLFormControlElement::isMouseFocusable):
  67482. * page/EventHandler.cpp:
  67483. (WebCore::EventHandler::sendContextMenuEvent):
  67484. 2008-09-22 Darin Adler <darin@apple.com>
  67485. * page/mac/FrameMac.mm:
  67486. (WebCore::Frame::baseWritingDirectionForSelectionStart): Fix indentation.
  67487. 2008-09-22 Sam Weinig <sam@webkit.org>
  67488. Reviewed by Dan Bernstein.
  67489. Patch for https://bugs.webkit.org/show_bug.cgi?id=21013
  67490. Match Firefox in how we hide HTMLInputElement.selectionStart, selectionEnd
  67491. and setSelectionRange. This also allows us to remove the legacy JSHTMLInputElementBase
  67492. class!
  67493. - selectionStart, selectionEnd and setSelectionRange now are visible in iteration of
  67494. non-selectable input types, but return undefined when accessed.
  67495. * DerivedSources.make:
  67496. * GNUmakefile.am:
  67497. * WebCore.pro:
  67498. * WebCore.vcproj/WebCore.vcproj:
  67499. * WebCore.xcodeproj/project.pbxproj:
  67500. * WebCoreSources.bkl:
  67501. * bindings/js/JSHTMLInputElementBase.cpp: Removed.
  67502. * bindings/js/JSHTMLInputElementBase.h: Removed.
  67503. * bindings/js/JSHTMLInputElementCustom.cpp: Added.
  67504. (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
  67505. (WebCore::JSHTMLInputElement::selectionStart):
  67506. (WebCore::JSHTMLInputElement::selectionEnd):
  67507. * bindings/js/JSHTMLInputElementCustom.h: Added.
  67508. * html/HTMLInputElement.idl:
  67509. 2008-09-22 Dan Bernstein <mitz@apple.com>
  67510. Reviewed by Sam Weinig.
  67511. - fix <rdar://problem/5699571> Mail: Unable to change writing direction to LTR in an empty message
  67512. Not testable in DumpRenderTree or in Safari
  67513. * page/mac/FrameMac.mm:
  67514. (WebCore::Frame::baseWritingDirectionForSelectionStart): Account for the
  67515. case that the selection start node is a block.
  67516. 2008-09-22 David Hyatt <hyatt@apple.com>
  67517. https://bugs.webkit.org/show_bug.cgi?id=21007
  67518. Make sure that the scrollbar gets sent a release event on platforms that call handleMouseDoubleClickEvent.
  67519. Reviewed by Sam Weinig
  67520. * page/EventHandler.cpp:
  67521. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  67522. 2008-09-22 Eric Seidel <eric@webkit.org>
  67523. No review, rollback only.
  67524. Roll out Peter's change (per his request)
  67525. http://trac.webkit.org/changeset/36069
  67526. https://bugs.webkit.org/show_bug.cgi?id=19663
  67527. This change has been the source of numerous regressions
  67528. (several of which were latent bugs revealed by this change,
  67529. others were bugs in this change)
  67530. * platform/graphics/BitmapImage.cpp:
  67531. (WebCore::BitmapImage::BitmapImage):
  67532. (WebCore::BitmapImage::startAnimation):
  67533. (WebCore::BitmapImage::advanceAnimation):
  67534. * platform/graphics/BitmapImage.h:
  67535. * platform/graphics/cairo/ImageCairo.cpp:
  67536. (WebCore::BitmapImage::draw):
  67537. * platform/graphics/cg/ImageCG.cpp:
  67538. (WebCore::BitmapImage::draw):
  67539. * platform/graphics/qt/ImageQt.cpp:
  67540. (WebCore::BitmapImage::draw):
  67541. * platform/graphics/wx/ImageWx.cpp:
  67542. (WebCore::BitmapImage::draw):
  67543. 2008-09-22 Dan Bernstein <mitz@apple.com>
  67544. Reviewed by Sam Weinig.
  67545. - fix <rdar://problem/5158514> Switch the complex text code path to Core Text
  67546. Tests: platform/mac-snowleopard/fast/text/myanmar-shaping.html
  67547. platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html
  67548. * config.h: Use Core Text if not building for Leopard or Tiger.
  67549. 2008-09-22 David Hyatt <hyatt@apple.com>
  67550. https://bugs.webkit.org/show_bug.cgi?id=21006
  67551. Add code that paints an NSView-less scroller using HIThemeDrawTrack. This scrollbar is still not
  67552. switched on. There are still a few more refinements to make to the rendering and behavior.
  67553. Reviewed by Darin Adler
  67554. * platform/ScrollbarThemeComposite.cpp:
  67555. (WebCore::ScrollbarThemeComposite::paint):
  67556. * platform/ScrollbarThemeComposite.h:
  67557. (WebCore::ScrollbarThemeComposite::paintTrack):
  67558. (WebCore::ScrollbarThemeComposite::paintButton):
  67559. (WebCore::ScrollbarThemeComposite::paintThumb):
  67560. * platform/mac/ScrollbarThemeMac.h:
  67561. * platform/mac/ScrollbarThemeMac.mm:
  67562. (WebCore::ScrollbarThemeMac::backButtonRect):
  67563. (WebCore::ScrollbarThemeMac::forwardButtonRect):
  67564. (WebCore::scrollbarPartToHIPressedState):
  67565. (WebCore::ScrollbarThemeMac::paint):
  67566. * platform/mac/WidgetMac.mm:
  67567. (WebCore::Widget::invalidateRect):
  67568. 2008-09-22 Chris Marrin <cmarrin@apple.com>
  67569. Reviewed by Sam Weinig
  67570. transition end event when -webkit-transition-property: all puts wrong
  67571. propertyName in event
  67572. https://bugs.webkit.org/show_bug.cgi?id=20903
  67573. * page/animation/ImplicitAnimation.cpp:
  67574. (WebCore::ImplicitAnimation::sendTransitionEvent):
  67575. 2008-09-22 Chris Fleizach <cfleizach@apple.com>
  67576. Reviewed by Darin Adler.
  67577. <rdar://problem/6230234> AXTable should probably not be exposed in there's only one cell
  67578. Test: accessibility/table-one-cell.html
  67579. * page/AccessibilityTable.cpp:
  67580. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  67581. 2008-09-22 Chris Fleizach <cfleizach@apple.com>
  67582. Reviewed by Darin Adler.
  67583. <rdar://problem/6167779> Setting AXSelectedTextRange for TextAreas in a WebView behaves incorrectly
  67584. Test: accessibility/textarea-selected-text-range.html
  67585. * page/AccessibilityRenderObject.cpp:
  67586. (WebCore::AccessibilityRenderObject::setSelectedTextRange):
  67587. 2008-09-22 David Hyatt <hyatt@apple.com>
  67588. Clean up some parent relationships in the back end stylesheet code. Make sure parentStyleSheet
  67589. properly walks up nested rule blocks to reach the parent sheet instead of giving up at the immediate
  67590. parent. Also fix the doc() method so that it is properly set when the parent of the sheet is an import
  67591. rule.
  67592. Reviewed by Sam Weinig
  67593. Added fast/css/nested-rule-parent-sheet.html
  67594. * css/CSSImportRule.cpp:
  67595. (WebCore::CSSImportRule::insertedIntoParent):
  67596. * css/CSSRule.cpp:
  67597. (WebCore::CSSRule::parentStyleSheet):
  67598. (WebCore::CSSRule::parentRule):
  67599. * css/CSSStyleSheet.cpp:
  67600. (WebCore::CSSStyleSheet::CSSStyleSheet):
  67601. * css/CSSStyleSheet.h:
  67602. 2008-09-22 Dan Bernstein <mitz@apple.com>
  67603. Reviewed by Sam Weinig.
  67604. - fix https://bugs.webkit.org/show_bug.cgi?id=21002
  67605. Make the ATSUI code path respect spacingDisabled()
  67606. Fixes svg/text/text-spacing-01-b.svg in run-webkit-tests --complex-text
  67607. * platform/graphics/mac/FontMacATSUI.mm:
  67608. (WebCore::overrideLayoutOperation):
  67609. 2008-09-22 Maciej Stachowiak <mjs@apple.com>
  67610. Reviewed by Cameron Zwarich.
  67611. - speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
  67612. Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
  67613. 2.2% speedup on EarleyBoyer benchmark.
  67614. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  67615. * bindings/js/JSQuarantinedObjectWrapper.h:
  67616. (WebCore::JSQuarantinedObjectWrapper::createStructureID):
  67617. * bindings/scripts/CodeGeneratorJS.pm:
  67618. 2008-09-22 Adam Roben <aroben@apple.com>
  67619. Windows build fix
  67620. * WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag.
  67621. 2008-09-22 Maciej Stachowiak <mjs@apple.com>
  67622. Reviewed by Dave Hyatt.
  67623. Based on initial work by Darin Adler.
  67624. - replace masqueradesAsUndefined virtual method with a flag in TypeInfo
  67625. - use this to JIT inline code for eq_null and neq_null
  67626. https://bugs.webkit.org/show_bug.cgi?id=20823
  67627. * WebCore.xcodeproj/project.pbxproj:
  67628. * WebCore.vcproj/WebCore.vcproj:
  67629. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  67630. (WebCore::JSCSSStyleDeclaration::nameGetter):
  67631. * bindings/js/JSHTMLAllCollection.cpp: Added.
  67632. (WebCore::):
  67633. * bindings/js/JSHTMLAllCollection.h:
  67634. (WebCore::JSHTMLAllCollection::createStructureID):
  67635. (WebCore::JSHTMLAllCollection::toBoolean):
  67636. 2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
  67637. Reviewed by Simon.
  67638. Fix the QtWebKit build
  67639. * bridge/qt/qt_instance.cpp:
  67640. (JSC::Bindings::QtRuntimeObjectImp::construct):
  67641. * bridge/qt/qt_runtime.cpp:
  67642. 2008-09-22 Alp Toker <alp@nuanti.com>
  67643. Suggested by David Hyatt.
  67644. Build fix: ScrollView::update() is still used by Document.cpp on !MAC
  67645. so make it public.
  67646. * platform/ScrollView.h:
  67647. 2008-09-22 David Hyatt <hyatt@apple.com>
  67648. Fix a regression in Windows scrollbar painting. (Also fix the same
  67649. bug in my new viewless Mac scrollbar painting code). The track rect
  67650. was being improperly inflated when painting resulting in the scrollbar
  67651. being too tall and painting in the border of overflow sections.
  67652. Reviewed by Oliver Hunt
  67653. * platform/mac/ScrollbarThemeMac.mm:
  67654. (WebCore::ScrollbarThemeMac::trackRect):
  67655. * platform/win/ScrollbarThemeSafari.cpp:
  67656. (WebCore::ScrollbarThemeSafari::trackRect):
  67657. 2008-09-22 David Hyatt <hyatt@apple.com>
  67658. Fix a hit testing bug where events are mistakenly passed to subframes
  67659. if the mouse is over the border or padding area of the frame. Add
  67660. a boolean flag, isOverWidget(), to hit test results so that EventHandler
  67661. can check it to tell if the mouse is really over the content box of a
  67662. RenderWidget and not just in the border/padding area.
  67663. This is not testable, since the old code properly recovered when it detected
  67664. that the mouse was outside the bounds of the view, but this prevents
  67665. the extra passdown from even occurring (and is basically a nice cleanup).
  67666. Reviewed by Oliver Hunt
  67667. * page/EventHandler.cpp:
  67668. (WebCore::EventHandler::handleMousePressEvent):
  67669. (WebCore::EventHandler::hitTestResultAtPoint):
  67670. (WebCore::subframeForHitTestResult):
  67671. (WebCore::EventHandler::handleMouseDoubleClickEvent):
  67672. (WebCore::EventHandler::handleMouseMoveEvent):
  67673. (WebCore::EventHandler::handleMouseReleaseEvent):
  67674. (WebCore::EventHandler::handleWheelEvent):
  67675. * page/MouseEventWithHitTestResults.h:
  67676. (WebCore::MouseEventWithHitTestResults::isOverWidget):
  67677. * rendering/HitTestResult.cpp:
  67678. (WebCore::HitTestResult::HitTestResult):
  67679. (WebCore::HitTestResult::operator=):
  67680. * rendering/HitTestResult.h:
  67681. (WebCore::HitTestResult::isOverWidget):
  67682. (WebCore::HitTestResult::setIsOverWidget):
  67683. * rendering/RenderWidget.cpp:
  67684. (WebCore::RenderWidget::nodeAtPoint):
  67685. * rendering/RenderWidget.h:
  67686. 2008-09-21 David Hyatt <hyatt@apple.com>
  67687. Rename FrameView's repaintRectangle method to repaintContentRectangle. Make
  67688. both it and ScrollView's updateContents method be off-limits to everyone in
  67689. WebCore except for RenderView.
  67690. Make repaintViewRectangle the only possible method for WebCore code to do
  67691. an invalidation. This ensures that all invalidates triggered by WebCore
  67692. cross-platform code that cross ownerElement() boundaries are transform-aware.
  67693. Make sure that iframes/frames contained inside objects that have transforms
  67694. or reflections are not allowed to blit (this was already true for transparency).
  67695. It is not possible to make a test for any of this, since iframe scrolling
  67696. still doesn't work on Mac (since the invalidates are not being done
  67697. through WebCore's cross-platform invalidation code but are instead going
  67698. through NSScrollView's setNeedsDisplay still).
  67699. Reviewed by Oliver Hunt
  67700. * editing/SelectionController.cpp:
  67701. (WebCore::SelectionController::recomputeCaretRect):
  67702. (WebCore::SelectionController::invalidateCaretRect):
  67703. (WebCore::SelectionController::focusedOrActiveStateChanged):
  67704. * page/FrameView.cpp:
  67705. (WebCore::FrameView::repaintContentRectangle):
  67706. (WebCore::FrameView::endDeferredRepaints):
  67707. * page/FrameView.h:
  67708. * platform/ScrollView.h:
  67709. * rendering/RenderBox.cpp:
  67710. (WebCore::RenderBox::paintFillLayerExtended):
  67711. * rendering/RenderLayer.cpp:
  67712. (WebCore::RenderLayer::enclosingPositionedAncestor):
  67713. (WebCore::RenderLayer::requiresSlowRepaints):
  67714. * rendering/RenderLayer.h:
  67715. (WebCore::RenderLayer::hasTransform):
  67716. * rendering/RenderView.cpp:
  67717. (WebCore::RenderView::paintBoxDecorations):
  67718. (WebCore::RenderView::repaintViewRectangle):
  67719. (WebCore::RenderView::setSelection):
  67720. 2008-09-21 Maciej Stachowiak <mjs@apple.com>
  67721. Reviewed by Darin.
  67722. - introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
  67723. https://bugs.webkit.org/show_bug.cgi?id=20981
  67724. * bindings/js/JSAudioConstructor.cpp:
  67725. (WebCore::JSAudioConstructor::JSAudioConstructor):
  67726. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  67727. (WebCore::JSCSSStyleDeclaration::nameGetter):
  67728. * bindings/js/JSDOMBinding.cpp:
  67729. (WebCore::createDOMStructure):
  67730. * bindings/js/JSDOMBinding.h:
  67731. (WebCore::getDOMStructure):
  67732. * bindings/js/JSDOMWindowShell.cpp:
  67733. (WebCore::JSDOMWindowShell::JSDOMWindowShell):
  67734. (WebCore::JSDOMWindowShell::setWindow):
  67735. * bindings/js/JSEventTargetNode.cpp:
  67736. (WebCore::JSEventTargetNode::createPrototype):
  67737. * bindings/js/JSHTMLOptionElementConstructor.cpp:
  67738. (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  67739. * bindings/js/JSImageConstructor.cpp:
  67740. (WebCore::JSImageConstructor::JSImageConstructor):
  67741. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  67742. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  67743. * bindings/js/JSXSLTProcessorConstructor.cpp:
  67744. (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  67745. * bindings/scripts/CodeGeneratorJS.pm:
  67746. 2008-09-21 Darin Adler <darin@apple.com>
  67747. Reviewed by Maciej Stachowiak.
  67748. - fix problem Maciej noticed where every JSNamedNodesCollection
  67749. gets its own StructureID
  67750. * bindings/js/JSNamedNodesCollection.cpp:
  67751. (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Use
  67752. getDOMStructure to get the structure.
  67753. * bindings/js/JSNamedNodesCollection.h:
  67754. (WebCore::JSNamedNodesCollection::createPrototype): Return the
  67755. object prototype.
  67756. 2008-09-20 David Hyatt <hyatt@apple.com>
  67757. Make sure transformed scrollbars in overflow sections position
  67758. properly. This patch mimics the same behavior that works for
  67759. iframes, namely making sure that the same code that dynamically
  67760. adjusts iframe widget positions at paint time for fixed positioning
  67761. and transforms also applies to scrollbars. (This is as simple as passing
  67762. in the current translation factor at paint time rather than crawling
  67763. up the layer tree to compute a "false" absolute position.)
  67764. An existing transform test covers this (although only a pixel result
  67765. reveals the correct rendering).
  67766. Reviewed by Darin Adler
  67767. * rendering/RenderLayer.cpp:
  67768. (WebCore::RenderLayer::updateLayerPositions):
  67769. (WebCore::RenderLayer::positionOverflowControls):
  67770. (WebCore::RenderLayer::paintOverflowControls):
  67771. (WebCore::RenderLayer::paintLayer):
  67772. * rendering/RenderLayer.h:
  67773. 2008-09-21 Steve Falkenburg <sfalken@apple.com>
  67774. Removed unnecessary nested timer check.
  67775. Rubber-stamped by Dan Bernstein.
  67776. * platform/win/SharedTimerWin.cpp:
  67777. (WebCore::TimerWindowWndProc):
  67778. 2008-09-21 Steve Falkenburg <sfalken@apple.com>
  67779. Improve timer resolution on WinXP.
  67780. https://bugs.webkit.org/show_bug.cgi?id=20979
  67781. Removed last-chance timer. It should not be necessary.
  67782. Change timeEndPeriod timer to fire in 300ms instead of 20ms. Calling timeBeginPeriod/timeEndPeriod too often throws off accuracy.
  67783. Remove Vista checks. We now run the same code on both XP and Vista.
  67784. Call through to JSC::getCurrentUTCTimeWithMicroseconds from WebCore::currentTime.
  67785. The code previously called GetSystemTimeAsFileTime, which is always low-resolution on XP, even within timeBeginPeriod(1).
  67786. Reviewed by Maciej Stachowiak.
  67787. * platform/win/SharedTimerWin.cpp:
  67788. (WebCore::):
  67789. (WebCore::TimerWindowWndProc):
  67790. (WebCore::setSharedTimerFireTime):
  67791. * platform/win/SystemTimeWin.cpp:
  67792. (WebCore::currentTime):
  67793. 2008-09-21 Dirk Schulze <vbs85@gmx.de>
  67794. Reviewed by eseidel. Landed by eseidel.
  67795. All platforms use the DashArray in the GraphicsContext.
  67796. * svg/graphics/SVGPaintServer.h:
  67797. * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
  67798. (WebCore::SVGPaintServerGradient::setup):
  67799. * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
  67800. (WebCore::SVGPaintServerPattern::setup):
  67801. * svg/graphics/cairo/SVGPaintServerSolidCairo.cpp:
  67802. (WebCore::SVGPaintServerSolid::setup):
  67803. * svg/graphics/qt/SVGPaintServerGradientQt.cpp:
  67804. (WebCore::SVGPaintServerGradient::setup):
  67805. * svg/graphics/qt/SVGPaintServerQt.cpp:
  67806. * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
  67807. (WebCore::SVGPaintServerSolid::setup):
  67808. 2008-09-21 Dirk Schulze <vbs85@gmx.de>
  67809. Reviewed by eseidel. Landed by eseidel.
  67810. Moved DashArray to GraphicsContext.
  67811. * GNUmakefile.am:
  67812. * WebCore.vcproj/WebCore.vcproj:
  67813. * WebCore.xcodeproj/project.pbxproj:
  67814. * platform/graphics/DashArray.h: Added.
  67815. * platform/graphics/GraphicsContext.h:
  67816. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  67817. (WebCore::GraphicsContext::setLineDash):
  67818. * platform/graphics/cg/GraphicsContextCG.cpp:
  67819. (WebCore::GraphicsContext::setLineDash):
  67820. * platform/graphics/qt/GraphicsContextQt.cpp:
  67821. (WebCore::GraphicsContext::setLineDash):
  67822. * svg/graphics/SVGPaintServer.cpp:
  67823. (WebCore::applyStrokeStyleToContext):
  67824. * svg/graphics/SVGPaintServer.h:
  67825. * svg/graphics/cg/CgSupport.cpp:
  67826. * svg/graphics/cg/CgSupport.h:
  67827. 2008-09-21 Dan Bernstein <mitz@apple.com>
  67828. Reviewed by Mark Rowe.
  67829. - fix linker warnings
  67830. * WebCore.base.exp:
  67831. 2008-09-20 Darin Adler <darin@apple.com>
  67832. - another try at fixing Qt
  67833. * bridge/qt/qt_runtime.cpp: "using namespce WebCore"
  67834. 2008-09-20 Darin Adler <darin@apple.com>
  67835. - blind attempt to fix Qt build
  67836. * bridge/qt/qt_runtime.cpp:
  67837. (JSC::Bindings::convertQVariantToValue): Use regExpStructure instead
  67838. of regExpPrototype to make a RegExpObject. There should really be
  67839. some sort of public helper function for this. Same thing for
  67840. DateInstance and dateStructure. For JSObject, use constructEmptyObject.
  67841. (JSC::Bindings::):
  67842. (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): Use getDOMStructure.
  67843. It is not correct to do this inside the constructor because it could
  67844. cause a garbage collect while the QtRuntimeMethod object is half-
  67845. allocated, which could lead to a crash; note that RuntimeMethod,
  67846. QtRuntimeObjectImp, and RuntimeObjectImp have the same bug.
  67847. * bridge/qt/qt_runtime.h: Add s_info and createPrototype.
  67848. 2008-09-20 Collin Jackson <collinj@webkit.org>
  67849. Prefetch DNS for hyperlinks that the user mouses over.
  67850. https://bugs.webkit.org/show_bug.cgi?id=20931
  67851. Reviewed by Sam Weinig.
  67852. * page/Chrome.cpp:
  67853. (WebCore::Chrome::mouseDidMoveOverElement):
  67854. 2008-09-20 Darin Adler <darin@apple.com>
  67855. Reviewed by Maciej Stachowiak.
  67856. - finish https://bugs.webkit.org/show_bug.cgi?id=20858
  67857. make each distinct C++ class get a distinct JSC::Structure
  67858. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  67859. (WebCore::JSCSSStyleDeclaration::nameGetter): Pass in a structure
  67860. ID. Note that this makes a new structure every time -- we could
  67861. optimize this slightly be caching and reusing a single one.
  67862. * bridge/runtime_method.cpp:
  67863. (JSC::RuntimeMethod::RuntimeMethod): Create a unique structure using
  67864. getDOMStructure.
  67865. * bridge/runtime_method.h:
  67866. (JSC::RuntimeMethod::createPrototype): Added createPrototype so
  67867. getDOMStructure will work.
  67868. * bindings/js/JSDOMWindowShell.cpp:
  67869. (WebCore::JSDOMWindowShell::JSDOMWindowShell): Initialize m_window to
  67870. 0; needed in case garbage collection happens while creating the
  67871. JSDOMWindow.
  67872. 2008-09-20 Dan Bernstein <mitz@apple.com>
  67873. Reviewed by Eric Seidel.
  67874. - fix https://bugs.webkit.org/show_bug.cgi?id=20950
  67875. <rdar://problem/6234059> Reproducible assertion failure running svg/custom/acid3-test-77.html multiple times under guard malloc
  67876. * svg/SVGTextContentElement.cpp:
  67877. (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): Changed to
  67878. not include the first character in the extraCharsAvailable count.
  67879. 2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
  67880. Reviewed by Dan Bernstein.
  67881. Fix memory leak.
  67882. https://bugs.webkit.org/show_bug.cgi?id=20505
  67883. * platform/wx/wxcode/mac/carbon/fontprops.cpp:
  67884. (GetTextExtent):
  67885. 2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
  67886. wx build fixes. Added/removed build sources, and nativeWindow->platformWidget updates.
  67887. * WebCoreSources.bkl:
  67888. * platform/ScrollView.h:
  67889. * platform/wx/PopupMenuWx.cpp:
  67890. (WebCore::PopupMenu::show):
  67891. * platform/wx/RenderThemeWx.cpp:
  67892. (WebCore::RenderThemeWx::paintButton):
  67893. (WebCore::RenderThemeWx::paintTextField):
  67894. (WebCore::RenderThemeWx::paintMenuList):
  67895. (WebCore::RenderThemeWx::paintMenuListButton):
  67896. * platform/wx/ScrollViewWx.cpp:
  67897. (WebCore::ScrollView::setPlatformWidget):
  67898. (WebCore::ScrollView::updateContents):
  67899. (WebCore::ScrollView::update):
  67900. (WebCore::ScrollView::visibleWidth):
  67901. (WebCore::ScrollView::visibleHeight):
  67902. (WebCore::ScrollView::scrollBy):
  67903. (WebCore::ScrollView::resizeContents):
  67904. (WebCore::ScrollView::contentsWidth):
  67905. (WebCore::ScrollView::contentsHeight):
  67906. (WebCore::ScrollView::isScrollViewScrollbar):
  67907. (WebCore::ScrollView::adjustScrollbars):
  67908. (WebCore::ScrollView::inWindow):
  67909. (WebCore::ScrollView::removeChild):
  67910. * platform/wx/WidgetWx.cpp:
  67911. * plugins/wx/PluginViewWx.cpp:
  67912. (WebCore::PluginView::setParentVisible):
  67913. (WebCore::PluginView::updatePluginWidget):
  67914. 2008-09-20 Timothy Hatcher <timothy@apple.com>
  67915. Fix the new Node Search button image to not be blurry.
  67916. * page/inspector/Images/nodeSearchButtons.png:
  67917. 2008-09-20 Matt Lilek <webkit@mattlilek.com>
  67918. Reviewed by Tim Hatcher.
  67919. Cut down some of the inspector javascript -> InspectorController glue code
  67920. with two new macros. Also rearrange the exposed function list to be grouped
  67921. by implementation and to all explicitly use the WebCore namespace.
  67922. * page/InspectorController.cpp:
  67923. (WebCore::InspectorController::windowScriptObjectAvailable):
  67924. 2008-09-20 Matt Lilek <webkit@mattlilek.com>
  67925. Reviewed by Tim Hatcher.
  67926. Fix regression from my previous patch where the breadcrumbs bar was not displayed.
  67927. * page/inspector/inspector.css:
  67928. 2008-09-20 Nikolas Zimmermann <zimmermann@kde.org>
  67929. Reviewed by Eric.
  67930. Refactor HTMLImageLoader/SVGImageLoader code.
  67931. Move html/HTMLImageLoader.* to loader/ImageLoader.*
  67932. Let HTMLImageLoader & SVGImageLoader inherit from the new base class.
  67933. SVGImageLoader used to inherit from HTMLImageLoader which is awkward.
  67934. * GNUmakefile.am:
  67935. * WebCore.pro:
  67936. * WebCore.vcproj/WebCore.vcproj:
  67937. * WebCore.xcodeproj/project.pbxproj:
  67938. * WebCoreSources.bkl:
  67939. * dom/Document.cpp:
  67940. (WebCore::Document::dispatchImageLoadEventSoon):
  67941. (WebCore::Document::removeImage):
  67942. (WebCore::Document::dispatchImageLoadEventsNow):
  67943. * dom/Document.h:
  67944. * html/HTMLImageLoader.cpp:
  67945. (WebCore::HTMLImageLoader::HTMLImageLoader):
  67946. (WebCore::HTMLImageLoader::~HTMLImageLoader):
  67947. (WebCore::HTMLImageLoader::sourceURI):
  67948. (WebCore::HTMLImageLoader::notifyFinished):
  67949. * html/HTMLImageLoader.h:
  67950. * loader/DocLoader.h:
  67951. * loader/ImageLoader.cpp: Copied from html/HTMLImageLoader.cpp.
  67952. (WebCore::ImageLoader::ImageLoader):
  67953. (WebCore::ImageLoader::~ImageLoader):
  67954. (WebCore::ImageLoader::setImage):
  67955. (WebCore::ImageLoader::setLoadingImage):
  67956. (WebCore::ImageLoader::updateFromElement):
  67957. (WebCore::ImageLoader::notifyFinished):
  67958. * loader/ImageLoader.h: Copied from html/HTMLImageLoader.h.
  67959. * svg/SVGImageElement.cpp:
  67960. (WebCore::SVGImageElement::attach):
  67961. (WebCore::SVGImageElement::insertedIntoDocument):
  67962. (WebCore::SVGImageElement::imageSourceAttributeName):
  67963. * svg/SVGImageElement.h:
  67964. * svg/SVGImageLoader.cpp:
  67965. (WebCore::SVGImageLoader::SVGImageLoader):
  67966. (WebCore::SVGImageLoader::dispatchLoadEvent):
  67967. (WebCore::SVGImageLoader::sourceURI):
  67968. * svg/SVGImageLoader.h:
  67969. 2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
  67970. Build fix.
  67971. [qtwebkit] ScrollBar build fix after r36684.
  67972. BackButtonPart was split into Start and End Part
  67973. ForwardButtonPart was split into Start and End Part
  67974. * platform/qt/ScrollbarThemeQt.cpp:
  67975. (WebCore::scPart):
  67976. (WebCore::scrollbarPart):
  67977. (WebCore::styleOptionSlider):
  67978. 2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
  67979. Build fix.
  67980. [qtwebkit] Make qt_instance.cpp compile.
  67981. Revision of 36675 introduced getDOMStructure to give unique
  67982. structure id's to C++ classes. Catch up. RuntimeObjectImp assigns
  67983. the the StructureID inside the c'tor, do the same in QtRuntimeObjectImp
  67984. * bridge/qt/qt_instance.cpp:
  67985. (JSC::Bindings::QtInstance::getRuntimeObject):
  67986. 2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
  67987. Reviewed by Nikolas Zimmermann.
  67988. [svg] Change SVGLocatable to deal with a plain SVGElement
  67989. There is no requirement in the code that we have to have a
  67990. SVGStyledElement. Remove that artificial limitation and compile
  67991. with SVGElement.
  67992. * svg/SVGLocatable.cpp:
  67993. * svg/SVGLocatable.h:
  67994. 2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
  67995. Reviewed by Nikolas Zimmermann.
  67996. [svg] Use OwnPtr for the SVGExtensions to avoid custom lifetime
  67997. management.
  67998. * dom/Document.cpp:
  67999. (WebCore::Document::~Document):
  68000. (WebCore::Document::svgExtensions):
  68001. (WebCore::Document::accessSVGExtensions):
  68002. * dom/Document.h:
  68003. 2008-09-19 David Hyatt <hyatt@apple.com>
  68004. Fix for crash in updateTransitions. Make sure to test for a style
  68005. being null when comparing two RenderStyles.
  68006. Reviewed by Oliver Hunt
  68007. * page/animation/AnimationBase.cpp:
  68008. (WebCore::PropertyWrapperGetter::equals):
  68009. 2008-09-19 David Hyatt <hyatt@apple.com>
  68010. https://bugs.webkit.org/show_bug.cgi?id=20954
  68011. Roll out r36628 since it has caused horrible regressions with
  68012. animated GIF CPU usage.
  68013. * platform/graphics/BitmapImage.cpp:
  68014. (WebCore::BitmapImage::cacheFrame):
  68015. (WebCore::BitmapImage::startAnimation):
  68016. * platform/graphics/BitmapImage.h:
  68017. (WebCore::FrameData::FrameData):
  68018. * platform/graphics/cairo/ImageCairo.cpp:
  68019. (WebCore::FrameData::clear):
  68020. * platform/graphics/cg/ImageCG.cpp:
  68021. (WebCore::FrameData::clear):
  68022. * platform/graphics/qt/ImageQt.cpp:
  68023. (WebCore::FrameData::clear):
  68024. * platform/graphics/wx/ImageWx.cpp:
  68025. (WebCore::FrameData::clear):
  68026. 2008-09-20 Alp Toker <alp@nuanti.com>
  68027. Reviewed by Timothy Hatcher.
  68028. https://bugs.webkit.org/show_bug.cgi?id=20913
  68029. Avoid redudant includes
  68030. Document.h is included excessively such that a modification to Document.h (or
  68031. any of the header it includes itself) triggers a rebuild of many files
  68032. including the whole of SVG and a lot of the JS bindings.
  68033. Some of these includes can be avoided by only including Document.h where
  68034. necessary.
  68035. * bindings/js/JSAttrCustom.cpp:
  68036. * bindings/js/JSElementCustom.cpp:
  68037. * bindings/js/JSEventTargetBase.cpp:
  68038. * bindings/js/JSEventTargetBase.h:
  68039. * bindings/js/JSEventTargetNode.cpp:
  68040. * bindings/js/JSHTMLFrameElementCustom.cpp:
  68041. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  68042. * bindings/scripts/CodeGeneratorJS.pm:
  68043. * css/CSSCursorImageValue.cpp:
  68044. * css/SVGCSSStyleSelector.cpp:
  68045. * dom/make_names.pl:
  68046. * svg/SVGAnimateElement.h:
  68047. * svg/SVGAnimatedProperty.h:
  68048. (WebCore::::baseValue):
  68049. (WebCore::::setBaseValue):
  68050. (WebCore::::startAnimation):
  68051. (WebCore::::stopAnimation):
  68052. * svg/SVGElement.cpp:
  68053. (WebCore::SVGElement::accessDocumentSVGExtensions):
  68054. * svg/SVGElement.h:
  68055. * svg/SVGElementInstance.cpp:
  68056. * svg/SVGFitToViewBox.cpp:
  68057. * svg/SVGFontElement.cpp:
  68058. * svg/SVGFontFaceElement.cpp:
  68059. * svg/SVGLinearGradientElement.cpp:
  68060. * svg/SVGMPathElement.cpp:
  68061. * svg/SVGViewSpec.cpp:
  68062. 2008-09-19 Nikolas Zimmermann <zimmermann@kde.org>
  68063. Reviewed by Antti & Eric.
  68064. Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
  68065. Finish HTMLScriptElement / SVGScriptElement unification.
  68066. SVG <script> support is complete now, full SVGLoad event
  68067. respecting the influence of the externalResourcesRequired attribute
  68068. as well as SVGError event support. All other features shared with HTML.
  68069. Tests: fast/dom/HTMLScriptElement/script-reexecution.html
  68070. svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
  68071. svg/dom/SVGScriptElement/script-load-and-error-events.svg
  68072. svg/dom/SVGScriptElement/script-reexecution.svg
  68073. svg/dom/SVGScriptElement/script-set-href.svg
  68074. * dom/ScriptElement.cpp:
  68075. (WebCore::ScriptElementData::ScriptElementData):
  68076. (WebCore::ScriptElementData::requestScript):
  68077. * dom/ScriptElement.h:
  68078. (WebCore::ScriptElementData::haveFiredLoadEvent):
  68079. (WebCore::ScriptElementData::setHaveFiredLoadEvent):
  68080. * dom/XMLTokenizer.cpp:
  68081. (WebCore::XMLTokenizer::notifyFinished):
  68082. * html/HTMLScriptElement.cpp:
  68083. (WebCore::HTMLScriptElement::dispatchLoadEvent):
  68084. * svg/SVGScriptElement.cpp:
  68085. (WebCore::SVGScriptElement::setCreatedByParser):
  68086. (WebCore::SVGScriptElement::parseMappedAttribute):
  68087. (WebCore::SVGScriptElement::svgAttributeChanged):
  68088. (WebCore::SVGScriptElement::insertedIntoDocument):
  68089. (WebCore::SVGScriptElement::removedFromDocument):
  68090. (WebCore::SVGScriptElement::childrenChanged):
  68091. (WebCore::SVGScriptElement::isURLAttribute):
  68092. (WebCore::SVGScriptElement::finishParsingChildren):
  68093. (WebCore::SVGScriptElement::type):
  68094. (WebCore::SVGScriptElement::setType):
  68095. (WebCore::SVGScriptElement::haveLoadedRequiredResources):
  68096. (WebCore::SVGScriptElement::dispatchLoadEvent):
  68097. (WebCore::SVGScriptElement::dispatchErrorEvent):
  68098. * svg/SVGScriptElement.h:
  68099. 2008-09-19 Dan Bernstein <mitz@apple.com>
  68100. Reviewed by John Sullivan.
  68101. - fix https://bugs.webkit.org/show_bug.cgi?id=20951
  68102. Typo in Position::getInlineBoxAndOffset()
  68103. and add an assertion
  68104. Without the fix, the newly-added assertion fails in platform/mac/editing/input/caret-primary-bidi.html
  68105. * dom/Position.cpp:
  68106. (WebCore::Position::getInlineBoxAndOffset):
  68107. * rendering/InlineTextBox.cpp:
  68108. (WebCore::InlineTextBox::positionForOffset):
  68109. 2008-09-19 David Hyatt <hyatt@apple.com>
  68110. Add support for hit testing of all five possible scrollbar button placements.
  68111. Reviewed by Sam Weinig
  68112. * platform/ScrollbarThemeComposite.cpp:
  68113. (WebCore::ScrollbarThemeComposite::paint):
  68114. * platform/mac/ScrollbarThemeMac.mm:
  68115. (WebCore::):
  68116. (WebCore::ScrollbarThemeMac::backButtonRect):
  68117. (WebCore::ScrollbarThemeMac::forwardButtonRect):
  68118. (WebCore::ScrollbarThemeMac::trackRect):
  68119. (WebCore::ScrollbarThemeMac::paintButton):
  68120. 2008-09-19 Darin Adler <darin@apple.com>
  68121. - try to fix Qt build
  68122. * bridge/qt/qt_instance.cpp:
  68123. (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): Add structure argument.
  68124. (JSC::Bindings::QtInstance::getRuntimeObject): Ditto.
  68125. * bridge/runtime_object.cpp:
  68126. (JSC::RuntimeObjectImp::RuntimeObjectImp): Add an overload just for Qt.
  68127. * bridge/runtime_object.h: Ditto.
  68128. 2008-09-19 Chris Marrin <cmarrin@apple.com>
  68129. Reviewed by Dave Hyatt.
  68130. Transition starts running when it shouldn't
  68131. https://bugs.webkit.org/show_bug.cgi?id=20892
  68132. When there is a transition and an animation on the
  68133. same element, make sure the animation wins.
  68134. The fix is to save the unanimated style when an animation is started.
  68135. Then, when starting a transition, check to see if there is a current
  68136. animation on the same prop. If so, use the unanimated style as the
  68137. fromStyle rather than the current style.
  68138. Test: animations/transition-and-animation-1.html
  68139. * page/animation/CompositeAnimation.cpp:
  68140. (WebCore::CompositeAnimation::updateTransitions):
  68141. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  68142. (WebCore::CompositeAnimation::animate):
  68143. (WebCore::CompositeAnimation::getAnimationForProperty):
  68144. * page/animation/CompositeAnimation.h:
  68145. * page/animation/ImplicitAnimation.cpp:
  68146. (WebCore::ImplicitAnimation::reset):
  68147. * page/animation/ImplicitAnimation.h:
  68148. * page/animation/KeyframeAnimation.cpp:
  68149. (WebCore::KeyframeAnimation::hasAnimationForProperty):
  68150. * page/animation/KeyframeAnimation.h:
  68151. (WebCore::KeyframeAnimation::KeyframeAnimation):
  68152. (WebCore::KeyframeAnimation::unanimatedStyle):
  68153. 2008-09-19 David Hyatt <hyatt@apple.com>
  68154. Add support for painting/hit testing of four possible scrollbar buttons.
  68155. The Windows themes simply ignore the two parts that they will never
  68156. show. The Mac theme also ignores the other two buttons for now.
  68157. The cross-platform base for all three themes, ScrollbarThemeComposite,
  68158. has all the proper support though.
  68159. Reviewed by Sam Weinig
  68160. * platform/ScrollbarThemeComposite.cpp:
  68161. (WebCore::ScrollbarThemeComposite::hitTest):
  68162. (WebCore::ScrollbarThemeComposite::invalidatePart):
  68163. * platform/ScrollbarThemeComposite.h:
  68164. * platform/mac/ScrollbarThemeMac.h:
  68165. * platform/mac/ScrollbarThemeMac.mm:
  68166. (WebCore::ScrollbarThemeMac::backButtonRect):
  68167. (WebCore::ScrollbarThemeMac::forwardButtonRect):
  68168. (WebCore::ScrollbarThemeMac::paintButton):
  68169. * platform/win/ScrollbarThemeSafari.cpp:
  68170. (WebCore::ScrollbarThemeSafari::backButtonRect):
  68171. (WebCore::ScrollbarThemeSafari::forwardButtonRect):
  68172. (WebCore::ScrollbarThemeSafari::paintButton):
  68173. * platform/win/ScrollbarThemeSafari.h:
  68174. * platform/win/ScrollbarThemeWin.cpp:
  68175. (WebCore::ScrollbarThemeWin::backButtonRect):
  68176. (WebCore::ScrollbarThemeWin::forwardButtonRect):
  68177. (WebCore::ScrollbarThemeWin::paintButton):
  68178. * platform/win/ScrollbarThemeWin.h:
  68179. 2008-09-19 Matt Lilek <webkit@mattlilek.com>
  68180. Reviewed by Tim Hatcher.
  68181. Bug 17772: Inspector should support point-and-click to select a node to inspect
  68182. https://bugs.webkit.org/show_bug.cgi?id=17772
  68183. <rdar://problem/5792395>
  68184. * English.lproj/localizedStrings.js:
  68185. * page/Chrome.cpp:
  68186. (WebCore::Chrome::mouseDidMoveOverElement):
  68187. * page/EventHandler.cpp:
  68188. (WebCore::EventHandler::handleMousePressEvent):
  68189. * page/InspectorController.cpp:
  68190. (WebCore::toggleNodeSearch):
  68191. (WebCore::searchingForNode):
  68192. (WebCore::InspectorController::InspectorController):
  68193. (WebCore::InspectorController::toggleSearchForNodeInPage):
  68194. (WebCore::InspectorController::mouseDidMoveOverElement):
  68195. (WebCore::InspectorController::handleMousePressOnNode):
  68196. (WebCore::InspectorController::windowScriptObjectAvailable):
  68197. * page/InspectorController.h:
  68198. (WebCore::InspectorController::searchingForNodeInPage):
  68199. * page/inspector/ElementsPanel.js:
  68200. * page/inspector/Images/nodeSearchButtons.png: Added.
  68201. * page/inspector/inspector.css:
  68202. 2008-09-19 David Hyatt <hyatt@apple.com>
  68203. Add new scrollbar parts to be able to represent back and forward buttons
  68204. at either end of the scrollbar. The current scrollbar still just draws
  68205. a single button at either end, but the parts now exist.
  68206. Reviewed by Sam Weinig
  68207. * platform/ScrollTypes.h:
  68208. (WebCore::):
  68209. * platform/Scrollbar.cpp:
  68210. (WebCore::Scrollbar::autoscrollTimerFired):
  68211. (WebCore::Scrollbar::pressedPartScrollDirection):
  68212. (WebCore::Scrollbar::pressedPartScrollGranularity):
  68213. (WebCore::Scrollbar::handleMouseMoveEvent):
  68214. * platform/ScrollbarTheme.h:
  68215. (WebCore::ScrollbarTheme::buttonsPlacement):
  68216. (WebCore::ScrollbarTheme::invalidateParts):
  68217. * platform/ScrollbarThemeComposite.cpp:
  68218. (WebCore::ScrollbarThemeComposite::paint):
  68219. (WebCore::ScrollbarThemeComposite::hitTest):
  68220. (WebCore::ScrollbarThemeComposite::invalidatePart):
  68221. * platform/ScrollbarThemeComposite.h:
  68222. 2008-09-19 Beth Dakin <bdakin@apple.com>
  68223. Reviewed by Dave Hyatt.
  68224. Fix for <rdar://problem/6231308> crash in AutoTableLayout
  68225. The code assumes later on that a TableSection's grid's row vector
  68226. will never be empty. So make 1 the minimum number of columns.
  68227. * rendering/RenderTableSection.cpp:
  68228. (WebCore::RenderTableSection::ensureRows):
  68229. 2008-09-19 David Hyatt <hyatt@apple.com>
  68230. Add a new ScrollbarButtonsPlacement type for specifying where
  68231. the button arrows are in a scrollbar.
  68232. Read in the placement settings for Mac. Nothing is done with the
  68233. setting yet.
  68234. Add a new buttonsPlacement() method to ScrollbarTheme composite
  68235. so that the arrow settings can be obtained.
  68236. Reviewed by Sam Weinig
  68237. * platform/ScrollTypes.h:
  68238. (WebCore::):
  68239. * platform/ScrollbarThemeComposite.h:
  68240. (WebCore::ScrollbarThemeComposite::buttonsPlacement):
  68241. * platform/mac/ScrollbarThemeMac.mm:
  68242. (WebCore::updateArrowPlacement):
  68243. (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
  68244. 2008-09-19 Steve Falkenburg <sfalken@apple.com>
  68245. Roll out r36626. It is causing variance in SunSpider numbers on XP.
  68246. Rubber stamped by Mark Rowe.
  68247. * platform/win/SharedTimerWin.cpp:
  68248. (WebCore::isRunningOnVistaOrLater):
  68249. (WebCore::setSharedTimerFireTime):
  68250. 2008-09-19 Kevin McCullough <kmccullough@apple.com>
  68251. Reviewed by Tim.
  68252. https://bugs.webkit.org/show_bug.cgi?id=20942
  68253. Bug 20942: Repeated messages in resources don't collapse
  68254. - Now repeated messages in a resource's view are collapsed and a message
  68255. says how many were repeated.
  68256. * English.lproj/localizedStrings.js:
  68257. * manual-tests/inspector/multiple-console-messages.html:
  68258. * page/inspector/Console.js: Send all the messages to the resource's
  68259. view before possibly returning early if the message is a repeat.
  68260. * page/inspector/SourceFrame.js: Add the text about the message being
  68261. repeated, if it is, and increment it when necessary.
  68262. 2008-09-19 Chris Fleizach <cfleizach@apple.com>
  68263. Removed unnecessary #if
  68264. * page/mac/AccessibilityObjectWrapper.mm:
  68265. 2008-09-19 David Hyatt <hyatt@apple.com>
  68266. Read in prefs for the scroll delay repeat values for buttons. Also
  68267. honor the option-click pref for jumping to the thumb when clicking in
  68268. the track.
  68269. Reviewed by Sam Weinig
  68270. * platform/mac/ScrollbarThemeMac.h:
  68271. * platform/mac/ScrollbarThemeMac.mm:
  68272. (WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
  68273. (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
  68274. (WebCore::ScrollbarThemeMac::autoscrollTimerDelay):
  68275. (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
  68276. 2008-09-19 David Hyatt <hyatt@apple.com>
  68277. Move ScrollbarThemeMac.cpp to ScrollbarThemeMac.mm so it can use Obj-C.
  68278. Set the initial button repeat delay to 0.5 for Mac.
  68279. Reviewed by Sam Weinig
  68280. * WebCore.xcodeproj/project.pbxproj:
  68281. * platform/mac/ScrollbarThemeMac.cpp: Removed.
  68282. * platform/mac/ScrollbarThemeMac.h:
  68283. (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
  68284. * platform/mac/ScrollbarThemeMac.mm: Copied from platform/mac/ScrollbarThemeMac.cpp.
  68285. 2008-09-19 Darin Adler <darin@apple.com>
  68286. Reviewed by Sam Weinig.
  68287. - part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
  68288. make each distinct C++ class get a distinct JSC::Structure
  68289. + Fixed all cases where we were using a shared structure for multiple
  68290. C++ classes in WebCore. This still has to be done in JavaScriptCore.
  68291. + Got rid of cacheGlobalObject.
  68292. + Improved use of PassRefPtr in bindings code.
  68293. + Removed a couple cases where we were potentially allocating prototypes
  68294. inside a JSObject's construction process -- this can lead to trouble if
  68295. we do a garbage collection while an object is only partly constructed.
  68296. * bindings/js/JSAudioConstructor.cpp:
  68297. (WebCore::JSAudioConstructor::JSAudioConstructor): Create a structure explicitly
  68298. so we don't implicitly share the structure with other objects that use the object
  68299. prototype.
  68300. * bindings/js/JSDOMBinding.cpp:
  68301. (WebCore::getCachedDOMConstructor): Added. To be used for constructors so we
  68302. don't need cacheGlobalObject any more.
  68303. (WebCore::cacheDOMConstructor): Ditto.
  68304. * bindings/js/JSDOMBinding.h: Removed DOMObject constructor that takes a prototype.
  68305. Added functions and a function template for getting cached DOM constructors.
  68306. Removed cacheGlobalObject function template.
  68307. * bindings/js/JSDOMWindowBase.cpp:
  68308. (WebCore::JSDOMWindowBase::JSDOMWindowBase): Take a PassRefPtr<DOMWindow> since
  68309. we're taking ownership.
  68310. * bindings/js/JSDOMWindowBase.h: Changed constructor to take PassRefPtr, since
  68311. we're taking ownership. Added constructor map.
  68312. * bindings/js/JSDOMWindowCustom.cpp:
  68313. (WebCore::JSDOMWindow::mark): Mark the constructors in the map.
  68314. * bindings/js/JSDOMWindowShell.cpp:
  68315. (WebCore::JSDOMWindowShell::JSDOMWindowShell): Take a PassRefPtr<DOMWindow> since
  68316. we're taking ownership. Use the new setWindow function to create the JSDOMWindow;
  68317. this is now done in only that one place.
  68318. (WebCore::JSDOMWindowShell::setWindow): Added. Creates the JSDOMWindow based on
  68319. the passed-in DOMWindow. Code was moved here and changed to allocate unique
  68320. structures for both the window prototype and the window.
  68321. * bindings/js/JSDOMWindowShell.h: Ditto.
  68322. * bindings/js/JSEventTargetBase.h: Changed class template argument so it doesn't
  68323. have the same name (JSEventTarget) as an actual class. Removed unhelpful use of
  68324. private/friend in JSEventTargetBase. Removed comments referring to defunct
  68325. macros. Changed JSEventTargetBasePrototype to get the prototype with the new
  68326. rather than its own copy of cacheGlobalObject (I missed this during pass 1).
  68327. Changed JSEventTargetBasePrototype so it doesn't have so many template arguments.
  68328. * bindings/js/JSEventTargetNode.cpp: Added s_info; needed for the new scheme
  68329. for caching structures and prototypes.
  68330. (WebCore::JSEventTargetNode::JSEventTargetNode): Use PassRefPtr.
  68331. (WebCore::JSEventTargetNode::createPrototype): Added.
  68332. * bindings/js/JSEventTargetNode.h: Updated for above changes.
  68333. * bindings/js/JSHTMLAllCollection.h:
  68334. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Use PassRefPtr.
  68335. * bindings/js/JSHTMLCollectionCustom.cpp:
  68336. (WebCore::getNamedItems): Pass ExecState instead of prototype.
  68337. * bindings/js/JSHTMLFormElementCustom.cpp:
  68338. (WebCore::JSHTMLFormElement::nameGetter): Ditto.
  68339. * bindings/js/JSHTMLInputElementBase.cpp:
  68340. (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Use PassRefPtr.
  68341. * bindings/js/JSHTMLInputElementBase.h: Ditto.
  68342. * bindings/js/JSHTMLOptionElementConstructor.cpp:
  68343. (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  68344. Create a unique structure instead of sharing.
  68345. * bindings/js/JSImageConstructor.cpp:
  68346. (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
  68347. * bindings/js/JSInspectedObjectWrapper.cpp:
  68348. (WebCore::JSInspectedObjectWrapper::wrap): Removed overload that takes
  68349. a prototype rather than a structure. Made the use of inheritorID() here
  68350. explicit.
  68351. * bindings/js/JSInspectedObjectWrapper.h: Ditto.
  68352. * bindings/js/JSInspectorCallbackWrapper.cpp:
  68353. (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
  68354. * bindings/js/JSInspectorCallbackWrapper.h: Ditto.
  68355. * bindings/js/JSNamedNodesCollection.cpp:
  68356. (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Changed to
  68357. take an ExecState argument instead of a prototype. Create a unique
  68358. StructureID instead of sharing.
  68359. * bindings/js/JSNamedNodesCollection.h: Ditto.
  68360. * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed overloaded
  68361. constructor that takes a prototype instead of a structure.
  68362. * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
  68363. * bindings/js/JSRGBColor.cpp:
  68364. (WebCore::JSRGBColor::JSRGBColor): Take ExecState instead of a
  68365. prototype; create a unique structure.
  68366. (WebCore::getJSRGBColor): Ditto.
  68367. * bindings/js/JSRGBColor.h: Ditto.
  68368. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  68369. (WebCore::JSSQLResultSetRowList::item): Use constructEmptyObject instead
  68370. of explicit coding the idiom for making a new object.
  68371. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  68372. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  68373. Create a unique structure instead of the shared one.
  68374. * bindings/js/JSXSLTProcessorConstructor.cpp:
  68375. (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  68376. Ditto.
  68377. * bindings/js/ScriptController.cpp:
  68378. (WebCore::ScriptController::clearWindowShell): Let the window shell's
  68379. setWindow function create the JSDOMWindow instead of doing it here.
  68380. * bindings/scripts/CodeGeneratorJS.pm: Changed to use PassRefPtr for
  68381. the structure and the wrapped object when creating wrappers.
  68382. Simplified some of the special cases for DOMWindow so they are
  68383. different only in ways the need to be. Eliminated the
  68384. JSDOMWindow::createPrototype and JSDOMWindowPrototype::self
  68385. functions. Moved responsibility for creating the structure and
  68386. parent prototype out of the prototype constructor into the
  68387. createPrototype function. Removed the unused "DoNotCache" flag for
  68388. objects other than DOMWindow. Use getDOMConstructor instead of
  68389. cacheGlobalObject for constructors. Make each constructor have
  68390. a unique structure ID.
  68391. * bridge/objc/objc_runtime.h: Added createPrototype and changed the
  68392. name of the info member to s_info so we can use the standard DOM
  68393. binding macros to handl the prototype.
  68394. * bridge/objc/objc_runtime.mm: Fixed namespacing a bit.
  68395. (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  68396. Create a unique structure using getDOMStructure.
  68397. * bridge/runtime_array.cpp: Fixed namespacing a bit.
  68398. (JSC::RuntimeArray::RuntimeArray): Create a unique structure using
  68399. getDOMStructure.
  68400. * bridge/runtime_array.h: Added createPrototype so getDOMStructure
  68401. will work.
  68402. * bridge/runtime_object.cpp:
  68403. (JSC::RuntimeObjectImp::RuntimeObjectImp): Create a unique structure using
  68404. getDOMStructure.
  68405. * bridge/runtime_object.h: Added createPrototype so getDOMStructure
  68406. will work.
  68407. * history/CachedPage.cpp:
  68408. (WebCore::CachedPage::restore): Let the window shell's
  68409. setWindow function create the JSDOMWindow instead of doing it here.
  68410. * page/DOMWindow.idl: Removed DoNotCache, which is no longer used.
  68411. 2008-09-19 Dan Bernstein <mitz@apple.com>
  68412. Reviewed by Dave Hyatt.
  68413. This optimization was suggested by Daniel Fenwick
  68414. - speed up measuring text on the Core Text code path by not specifying a paragraph writing direction
  68415. Specifying LTR paragraph directionality when measuring runs of RTL text
  68416. resulted in typically two CTRuns being generated for every run instead
  68417. of one, due to the leading space being reordered to the left.
  68418. * platform/graphics/SimpleFontData.h: Removed the ltr parameter to
  68419. getCFStringAttributes() and changed m_CFStringAttributes from an array
  68420. to a single value.
  68421. * platform/graphics/mac/CoreTextController.cpp:
  68422. (WebCore::CoreTextController::CoreTextController): Added a
  68423. mayUseNaturalWritingDirection parameter.
  68424. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Changed
  68425. to force the bidi embedding level whenever
  68426. m_mayUseNaturalWritingDirectrion is false. Since this is now a common
  68427. case, made the typesetter options dictionaries static.
  68428. * platform/graphics/mac/CoreTextController.h:
  68429. * platform/graphics/mac/FontMacCoreText.cpp:
  68430. (WebCore::Font::selectionRectForComplexText): Renamed a local variable.
  68431. (WebCore::Font::floatWidthForComplexText): Changed to allow the
  68432. CoreTextController to not set the writing direction.
  68433. * platform/graphics/mac/SimpleFontDataMac.mm:
  68434. (WebCore::SimpleFontData::getCFStringAttributes): Removed the ltr
  68435. parameter and the paragraph style attribute.
  68436. 2008-09-19 David Hyatt <hyatt@apple.com>
  68437. Reviewed by Sam Weinig
  68438. https://bugs.webkit.org/show_bug.cgi?id=20941
  68439. Incorrect height calculation for replaced element inside nested
  68440. positioned elements (where the inner has a percentage height and
  68441. the outer implicitly has a fixed height because of explicit top/bottom
  68442. values).
  68443. Added fast/block/positioning/replaced-inside-top-bottom.html
  68444. * rendering/RenderBox.cpp:
  68445. (WebCore::RenderBox::availableHeightUsing):
  68446. 2008-09-19 Chris Fleizach <cfleizach@apple.com>
  68447. Fix Tiger bustage
  68448. * page/mac/AccessibilityObjectWrapper.mm:
  68449. 2008-09-18 Chris Fleizach <cfleizach@apple.com>
  68450. Reviewed by Darin Adler.
  68451. <rdar://problem/6211041> Expose legend tag in accessibility
  68452. Exposes the legend tag as the titleUIElement of a fieldset
  68453. Test: accessibility/legend.html
  68454. * page/AccessibilityObject.h:
  68455. (WebCore::AccessibilityObject::isFieldset):
  68456. * page/AccessibilityRenderObject.cpp:
  68457. (WebCore::AccessibilityRenderObject::isFieldset):
  68458. (WebCore::AccessibilityRenderObject::titleUIElement):
  68459. * page/AccessibilityRenderObject.h:
  68460. * rendering/RenderFieldset.h:
  68461. 2008-09-19 Chris Fleizach <cfleizach@apple.com>
  68462. Reviewed by Darin Adler.
  68463. <rdar://problem/6213171> WebKit should use new array-centric methods for AX performance
  68464. Implement a few AX API methods that will be called by AppKit, which will
  68465. speed up access to accessibility objects
  68466. * page/mac/AccessibilityObjectWrapper.mm:
  68467. (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
  68468. (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
  68469. (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
  68470. 2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
  68471. Reviewed by Simon Hausmann.
  68472. [qtwebkit] Set the m_should* flags to their proper value on entry
  68473. With plugins it was possible that we finished a job twice. This was
  68474. some kind of reentrancy in QNetworkReplyHandler::sendQueuedItems. By
  68475. setting the flag to (m_loadMode == LoadDeferred) they will always have
  68476. the right value and we will not send responses twice.
  68477. * platform/network/qt/QNetworkReplyHandler.cpp:
  68478. 2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
  68479. Reviewed by Simon Hausmann.
  68480. [qtwebkit] Pass test 70 of acid3. Handle text decoding errors
  68481. Handle text decoding errors before instructing the parser to parse. We
  68482. have converted the text to QString and all encoding errors are gone and
  68483. the parser will not be able to detect them. So handle them before parsing.
  68484. * dom/XMLTokenizerQt.cpp:
  68485. (WebCore::XMLTokenizer::doWrite):
  68486. 2008-09-18 Darin Adler <darin@apple.com>
  68487. Reviewed by Maciej Stachowiak.
  68488. - part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
  68489. make each distinct C++ class get a distinct JSC::Structure
  68490. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  68491. (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
  68492. instead of DOMExceptionTranslator.
  68493. * bindings/js/JSDOMBinding.cpp:
  68494. (WebCore::getCachedDOMObjectWrapper): Updated function name.
  68495. (WebCore::cacheDOMObjectWrapper): Ditto.
  68496. (WebCore::forgetDOMObject): Ditto.
  68497. (WebCore::getCachedDOMNodeWrapper): Ditto.
  68498. (WebCore::forgetDOMNode): Ditto.
  68499. (WebCore::cacheDOMNodeWrapper): Ditto.
  68500. (WebCore::forgetAllDOMNodesForDocument): Ditto.
  68501. (WebCore::markDOMNodesForDocument): Ditto.
  68502. (WebCore::updateDOMNodeDocument): Ditto.
  68503. (WebCore::getCachedDOMStructure): Added.
  68504. (WebCore::createDOMStructure): Ditto.
  68505. * bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
  68506. class and replace the static member functions with non-member
  68507. functions. Added many other functions for getting at structures,
  68508. prototypes, wrappers, and creating them. Also moved the
  68509. cacheGlobalObject function here from JavaScriptCore; eventually
  68510. I'll remove that once I get rid of the remaining callers. Also
  68511. removed the DOMExceptionTranslator class.
  68512. * bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
  68513. and put one of those maps in each window.
  68514. * bindings/js/JSDOMWindowCustom.cpp:
  68515. (WebCore::markDOMObjectWrapper): Updated for function name change.
  68516. (WebCore::JSDOMWindow::mark): Added code to mark all the structures
  68517. in the structure map.
  68518. * bindings/js/JSEventTargetNode.cpp:
  68519. (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
  68520. a structure instead of a prototype.
  68521. * bindings/js/JSEventTargetNode.h: Ditto.
  68522. * bindings/js/JSHTMLAllCollection.h:
  68523. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
  68524. * bindings/js/JSHTMLInputElementBase.cpp:
  68525. (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
  68526. use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
  68527. structure instead of a prototype.
  68528. * bindings/js/JSHTMLInputElementBase.h: Removed use of the
  68529. JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
  68530. to take a structure instead of a prototype. Created a dummy prototype
  68531. class that causes the HTMLInputElement prototype to have the
  68532. HTMLElement prototype.
  68533. * bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
  68534. structures instead of prototypes. Changed the prototype self function
  68535. to use the getDOMPrototype function -- later we can eliminate it and
  68536. have callers invoke getDOMPrototype directly instead. Updated other
  68537. functions that have name changes. Added code to generate the
  68538. createPrototype member function. Changed use of cacheGlobalObject to
  68539. get it from the WebCore namespace instead of the JSC namespace.
  68540. Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
  68541. * dom/Document.cpp:
  68542. (WebCore::Document::~Document): Updated for name change and also
  68543. removed unnecessary JSLock use -- there's no need to lock around this.
  68544. * dom/Node.cpp:
  68545. (WebCore::Node::setDocument): Ditto.
  68546. * dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
  68547. instead of calling new directly.
  68548. * bindings/js/JSCSSRuleCustom.cpp:
  68549. (WebCore::toJS): Updated for function name changes and used the
  68550. CREATE_DOM_OBJECT_WRAPPER macro.
  68551. * bindings/js/JSCSSValueCustom.cpp:
  68552. (WebCore::toJS): Ditto.
  68553. * bindings/js/JSCanvasPixelArrayCustom.cpp:
  68554. (WebCore::toJS): Ditto.
  68555. * bindings/js/JSDocumentCustom.cpp:
  68556. (WebCore::JSDocument::mark): Ditto.
  68557. (WebCore::toJS): Ditto.
  68558. * bindings/js/JSElementCustom.cpp:
  68559. (WebCore::toJSNewlyCreated): Ditto.
  68560. * bindings/js/JSEventCustom.cpp:
  68561. (WebCore::toJS): Ditto.
  68562. * bindings/js/JSEventTargetBase.cpp:
  68563. (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
  68564. of DOMExceptionTranslator.
  68565. (WebCore::toJS): Updated for function name changes and used the
  68566. CREATE_DOM_OBJECT_WRAPPER macro.
  68567. * bindings/js/JSHTMLCollectionCustom.cpp:
  68568. (WebCore::toJS): Ditto.
  68569. * bindings/js/JSNodeCustom.cpp:
  68570. (WebCore::JSNode::mark): Ditto.
  68571. (WebCore::createWrapper): Ditto.
  68572. (WebCore::toJS): Ditto.
  68573. * bindings/js/JSSVGPathSegCustom.cpp:
  68574. (WebCore::toJS): Ditto.
  68575. * bindings/js/JSStyleSheetCustom.cpp:
  68576. (WebCore::toJS): Ditto.
  68577. (WebCore::JSStyleSheet::mark): Ditto.
  68578. * bindings/js/JSTextCustom.cpp:
  68579. (WebCore::toJSNewlyCreated): Ditto.
  68580. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  68581. (WebCore::constructXMLHttpRequest): Ditto.
  68582. * bindings/js/JSXMLHttpRequestCustom.cpp:
  68583. (WebCore::JSXMLHttpRequest::mark): Ditto.
  68584. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  68585. (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
  68586. * bindings/js/JSXSLTProcessorConstructor.cpp:
  68587. (WebCore::constructXSLTProcessor): Ditto.
  68588. * bindings/js/ScriptController.cpp:
  68589. (WebCore::ScriptController::finishedWithEvent): Ditto.
  68590. * xml/XMLHttpRequest.cpp:
  68591. (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
  68592. (WebCore::XMLHttpRequest::dropProtection): Ditto.
  68593. 2008-09-18 David Hyatt <hyatt@apple.com>
  68594. This patch gets a viewless scrollbar working on Mac. It is turned off
  68595. by default. Hit testing works. For now the scrollbar just paints ugly
  68596. debug rects in the place of the buttons, track and thumb. It does match
  68597. Aqua metrics though.
  68598. Reviewed by Sam Weinig
  68599. * WebCore.xcodeproj/project.pbxproj:
  68600. * page/mac/EventHandlerMac.mm:
  68601. (WebCore::EventHandler::passMousePressEventToScrollbar):
  68602. * platform/ScrollbarThemeComposite.cpp:
  68603. (WebCore::ScrollbarThemeComposite::paint):
  68604. (WebCore::ScrollbarThemeComposite::trackPosition):
  68605. * platform/ScrollbarThemeComposite.h:
  68606. * platform/mac/ScrollViewMac.mm:
  68607. (WebCore::ScrollView::addChild):
  68608. * platform/mac/ScrollbarThemeMac.cpp:
  68609. (WebCore::):
  68610. (WebCore::ScrollbarThemeMac::hasButtons):
  68611. (WebCore::ScrollbarThemeMac::hasThumb):
  68612. (WebCore::buttonRepaintRect):
  68613. (WebCore::ScrollbarThemeMac::backButtonRect):
  68614. (WebCore::ScrollbarThemeMac::forwardButtonRect):
  68615. (WebCore::trackRepaintRect):
  68616. (WebCore::ScrollbarThemeMac::trackRect):
  68617. (WebCore::ScrollbarThemeMac::minimumThumbLength):
  68618. (WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
  68619. (WebCore::ScrollbarThemeMac::paintTrack):
  68620. (WebCore::ScrollbarThemeMac::paintButton):
  68621. (WebCore::ScrollbarThemeMac::paintThumb):
  68622. * platform/mac/ScrollbarThemeMac.h:
  68623. (WebCore::ScrollbarThemeMac::supportsControlTints):
  68624. * platform/qt/ScrollbarThemeQt.cpp:
  68625. (WebCore::ScrollbarThemeQt::trackPosition):
  68626. 2008-09-18 Collin Jackson <collinj@webkit.org>
  68627. Build fix; added missing header file to GNUmakefile.am
  68628. * GNUmakefile.am:
  68629. 2008-09-18 Sam Weinig <sam@webkit.org>
  68630. Reviewed by David "the Hair" Hyatt.
  68631. Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
  68632. * GNUmakefile.am:
  68633. * WebCore.pro:
  68634. * WebCore.vcproj/WebCore.vcproj:
  68635. * WebCore.xcodeproj/project.pbxproj:
  68636. * rendering/DataRef.h: Removed.
  68637. * rendering/SVGRenderStyle.cpp: Removed.
  68638. * rendering/SVGRenderStyle.h: Removed.
  68639. * rendering/SVGRenderStyleDefs.cpp: Removed.
  68640. * rendering/SVGRenderStyleDefs.h: Removed.
  68641. * rendering/style/DataRef.h: Copied from rendering/DataRef.h.
  68642. * rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
  68643. * rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
  68644. * rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
  68645. * rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
  68646. 2008-09-18 Mark Rowe <mrowe@apple.com>
  68647. Reviewed by Dan Bernstein.
  68648. Add a means of clearing a FrameTree's name.
  68649. * WebCore.base.exp:
  68650. * page/FrameTree.cpp:
  68651. (WebCore::FrameTree::clearName):
  68652. * page/FrameTree.h:
  68653. 2008-09-18 David Hyatt <hyatt@apple.com>
  68654. Eliminate addToSuperview from Widget, since it was only called
  68655. by ScrollViewMac's addChild method. Just shift the original body
  68656. of addToSuperView into addChild.
  68657. Reviewed by Sam Weinig
  68658. * platform/Widget.h:
  68659. * platform/mac/ScrollViewMac.mm:
  68660. (WebCore::ScrollView::addChild):
  68661. * platform/mac/WidgetMac.mm:
  68662. 2008-09-18 Collin Jackson <collinj@webkit.org>
  68663. Reviewed by Antti Koivisto and Mark Rowe.
  68664. Test: http/tests/misc/dns-prefetch-control.html
  68665. https://bugs.webkit.org/show_bug.cgi?id=20690
  68666. Invoke WebCore::prefetchDNS() on host names that appear in
  68667. in the href of hyperlinks and <link rel="dns-prefetch">. This
  68668. can be used to implement DNS prefetching.
  68669. * WebCore.vcproj/WebCore.vcproj:
  68670. * WebCore.xcodeproj/project.pbxproj:
  68671. * dom/Document.cpp:
  68672. (WebCore::Document::Document):
  68673. (WebCore::Document::processHttpEquiv):
  68674. (WebCore::Document::setSecurityOrigin):
  68675. (WebCore::Document::initDNSPrefetch):
  68676. (WebCore::Document::parseDNSPrefetchControlHeader):
  68677. * dom/Document.h:
  68678. (WebCore::Document::isDNSPrefetchEnabled):
  68679. * html/HTMLAnchorElement.cpp:
  68680. (WebCore::HTMLAnchorElement::parseMappedAttribute):
  68681. * html/HTMLLinkElement.cpp:
  68682. (WebCore::HTMLLinkElement::HTMLLinkElement):
  68683. (WebCore::HTMLLinkElement::parseMappedAttribute):
  68684. (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  68685. (WebCore::HTMLLinkElement::process):
  68686. * html/HTMLLinkElement.h:
  68687. * html/PreloadScanner.cpp:
  68688. (WebCore::PreloadScanner::processAttribute):
  68689. * loader/FrameLoader.cpp:
  68690. (WebCore::FrameLoader::begin):
  68691. * platform/gtk/TemporaryLinkStubs.cpp:
  68692. (WebCore::prefetchDNS):
  68693. * platform/network/DNS.h: Added.
  68694. * platform/network/cf/DNSCFNet.cpp: Added.
  68695. (WebCore::prefetchDNS):
  68696. * platform/qt/TemporaryLinkStubs.cpp:
  68697. (WebCore::prefetchDNS):
  68698. * platform/wx/TemporaryLinkStubs.cpp:
  68699. (WebCore::prefetchDNS):
  68700. 2008-09-18 David Hyatt <hyatt@apple.com>
  68701. Eliminate the convertToScreenCoordinate method on Widget, since
  68702. ScrollView has redundant methods that already do the same thing.
  68703. Reviewed by Sam Weinig
  68704. * editing/mac/SelectionControllerMac.mm:
  68705. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  68706. * platform/Widget.h:
  68707. * platform/mac/WidgetMac.mm:
  68708. (WebCore::Widget::containingWindow):
  68709. 2008-09-18 David Hyatt <hyatt@apple.com>
  68710. Move to only one constructor for Widgets. Rename data to m_data and make
  68711. it have an #ifdef only for platforms that have platform-specific data (Mac
  68712. and Gtk).
  68713. Reviewed by Sam Weinig
  68714. * WebCore.base.exp:
  68715. * platform/Widget.cpp:
  68716. (WebCore::Widget::init):
  68717. * platform/Widget.h:
  68718. * platform/gtk/WidgetGtk.cpp:
  68719. (WebCore::Widget::Widget):
  68720. (WebCore::Widget::~Widget):
  68721. (WebCore::Widget::cursor):
  68722. (WebCore::Widget::setCursor):
  68723. * platform/mac/WidgetMac.mm:
  68724. (WebCore::Widget::Widget):
  68725. (WebCore::Widget::~Widget):
  68726. (WebCore::Widget::addToSuperview):
  68727. (WebCore::Widget::removeFromSuperview):
  68728. (WebCore::Widget::beforeMouseDown):
  68729. (WebCore::Widget::afterMouseDown):
  68730. * platform/qt/WidgetQt.cpp:
  68731. (WebCore::Widget::Widget):
  68732. * platform/win/WidgetWin.cpp:
  68733. (WebCore::Widget::Widget):
  68734. * platform/wx/WidgetWx.cpp:
  68735. (WebCore::Widget::Widget):
  68736. 2008-09-18 David Hyatt <hyatt@apple.com>
  68737. Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
  68738. was no reason for it to be on Widget. This change eliminates Qt ifdefs
  68739. from Widget.
  68740. Reviewed by Sam Weinig
  68741. * bindings/js/ScriptControllerQt.cpp:
  68742. (WebCore::ScriptController::createScriptInstanceForWidget):
  68743. * platform/qt/WidgetQt.cpp:
  68744. (WebCore::WidgetPrivate::WidgetPrivate):
  68745. (WebCore::WidgetPrivate::~WidgetPrivate):
  68746. (WebCore::Widget::Widget):
  68747. (WebCore::Widget::~Widget):
  68748. * plugins/PluginView.cpp:
  68749. (WebCore::PluginView::PluginView):
  68750. * plugins/PluginView.h:
  68751. (WebCore::PluginView::isNPAPIPlugin):
  68752. (WebCore::PluginView::setIsNPAPIPlugin):
  68753. 2008-09-18 David Hyatt <hyatt@apple.com>
  68754. Make geometryChanged() cross-platform on Widget. GTK and WIN platform
  68755. ifdefs are now gone from Widget!
  68756. Reviewed by Sam Weinig
  68757. * platform/Widget.h:
  68758. (WebCore::Widget::geometryChanged):
  68759. * platform/gtk/WidgetGtk.cpp:
  68760. * platform/qt/WidgetQt.cpp:
  68761. 2008-09-18 David Hyatt <hyatt@apple.com>
  68762. Consolidate convertTo/FromContainingWindow methods so that all platforms
  68763. but Mac share the same code.
  68764. Move convertSelfToChild and convertChildToSelf to ScrollView, since
  68765. Widget should know nothing about children. Make the methods cross-platform
  68766. on ScrollView.
  68767. Reviewed by Sam Weinig
  68768. * platform/ScrollView.h:
  68769. (WebCore::ScrollView::convertChildToSelf):
  68770. (WebCore::ScrollView::convertSelfToChild):
  68771. * platform/Widget.cpp:
  68772. (WebCore::Widget::convertToContainingWindow):
  68773. (WebCore::Widget::convertFromContainingWindow):
  68774. * platform/Widget.h:
  68775. (WebCore::Widget::geometryChanged):
  68776. * platform/gtk/ScrollViewGtk.cpp:
  68777. (WebCore::ScrollView::isScrollViewScrollbar):
  68778. * platform/gtk/WidgetGtk.cpp:
  68779. * platform/mac/ScrollViewMac.mm:
  68780. (WebCore::ScrollView::isScrollViewScrollbar):
  68781. * platform/mac/WidgetMac.mm:
  68782. * platform/qt/ScrollViewQt.cpp:
  68783. (WebCore::ScrollView::isScrollViewScrollbar):
  68784. * platform/qt/WidgetQt.cpp:
  68785. * platform/win/ScrollViewWin.cpp:
  68786. (WebCore::ScrollView::isScrollViewScrollbar):
  68787. * platform/win/WidgetWin.cpp:
  68788. 2008-09-18 David Hyatt <hyatt@apple.com>
  68789. Make the conversion methods that go to and from some containingWindow
  68790. cross-platform. Implement them on Mac.
  68791. Reviewed by Sam Weinig
  68792. * platform/Widget.h:
  68793. (WebCore::Widget::setContainingWindow):
  68794. * platform/mac/WidgetMac.mm:
  68795. (WebCore::Widget::convertFromContainingWindow):
  68796. (WebCore::Widget::convertToContainingWindow):
  68797. 2008-09-18 Sam Weinig <sam@webkit.org>
  68798. Rubber-stamped by David "Yeah-yeah" Hyatt.
  68799. Cleanup RenderStyle.
  68800. * WebCore.xcodeproj/project.pbxproj:
  68801. * rendering/style/CounterContent.h:
  68802. * rendering/style/RenderStyle.cpp:
  68803. * rendering/style/RenderStyle.h:
  68804. 2008-09-18 Chris Marrin <cmarrin@apple.com>
  68805. Reviewed by Sam Weinig
  68806. Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
  68807. Now TransformOperations and AnimationList no longer
  68808. inherit from Vector<> but rather have API to access.
  68809. * css/CSSComputedStyleDeclaration.cpp:
  68810. (WebCore::computedTransform):
  68811. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  68812. * css/CSSStyleSelector.cpp:
  68813. (WebCore::CSSStyleSelector::createTransformOperations):
  68814. * page/animation/AnimationBase.cpp:
  68815. (WebCore::blendFunc):
  68816. * page/animation/CompositeAnimation.cpp:
  68817. (WebCore::CompositeAnimation::updateTransitions):
  68818. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  68819. (WebCore::CompositeAnimation::animate):
  68820. * page/animation/ImplicitAnimation.cpp:
  68821. (WebCore::ImplicitAnimation::validateTransformFunctionList):
  68822. * page/animation/KeyframeAnimation.cpp:
  68823. (WebCore::KeyframeAnimation::validateTransformFunctionList):
  68824. * rendering/RenderLayer.cpp:
  68825. (WebCore::RenderLayer::updateReflectionStyle):
  68826. * rendering/style/AnimationList.cpp:
  68827. (WebCore::AnimationList::operator==):
  68828. * rendering/style/AnimationList.h:
  68829. (WebCore::AnimationList::operator!=):
  68830. (WebCore::AnimationList::size):
  68831. (WebCore::AnimationList::isEmpty):
  68832. (WebCore::AnimationList::resize):
  68833. (WebCore::AnimationList::remove):
  68834. (WebCore::AnimationList::append):
  68835. (WebCore::AnimationList::animation):
  68836. * rendering/style/RenderStyle.cpp:
  68837. (WebCore::StyleRareNonInheritedData::updateKeyframes):
  68838. (WebCore::RenderStyle::applyTransform):
  68839. (WebCore::RenderStyle::adjustAnimations):
  68840. (WebCore::RenderStyle::adjustTransitions):
  68841. (WebCore::RenderStyle::transitionForProperty):
  68842. * rendering/style/RenderStyle.h:
  68843. (WebCore::RenderStyle::hasTransform):
  68844. * rendering/style/TransformOperations.cpp:
  68845. (WebCore::TransformOperations::TransformOperations):
  68846. (WebCore::TransformOperations::operator==):
  68847. * rendering/style/TransformOperations.h:
  68848. (WebCore::TransformOperations::apply):
  68849. (WebCore::TransformOperations::operations):
  68850. 2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
  68851. Build fix.
  68852. [qt] Build fixes after the Widget/ScrollView cleanup
  68853. topLevel() is now root()
  68854. * platform/qt/ScrollViewQt.cpp:
  68855. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
  68856. (WebCore::ScrollView::addChild):
  68857. (WebCore::ScrollView::removeChild):
  68858. 2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
  68859. Reviewed by Mark Rowe.
  68860. https://bugs.webkit.org/show_bug.cgi?id=20437
  68861. XMLTokenizer.cpp used to contain two different implementations. One was using
  68862. libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
  68863. separating the two implementations from each other.
  68864. Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
  68865. was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
  68866. XMLTokenizerLibxml2.cpp. There should be no functional changes.
  68867. Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
  68868. to work.
  68869. * GNUmakefile.am:
  68870. * WebCore.pro:
  68871. * WebCore.vcproj/WebCore.vcproj:
  68872. * WebCore.xcodeproj/project.pbxproj:
  68873. * WebCoreSources.bkl:
  68874. * dom/XMLTokenizer.cpp:
  68875. (WebCore::isScriptElement):
  68876. (WebCore::castToScriptElement):
  68877. (WebCore::XMLTokenizer::setCurrentNode):
  68878. (WebCore::XMLTokenizer::write):
  68879. (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
  68880. (WebCore::XMLTokenizer::enterText):
  68881. (WebCore::toString):
  68882. (WebCore::XMLTokenizer::exitText):
  68883. (WebCore::XMLTokenizer::end):
  68884. (WebCore::XMLTokenizer::insertErrorMessageBlock):
  68885. * dom/XMLTokenizer.h:
  68886. (WebCore::XMLTokenizer::wellFormed):
  68887. * dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
  68888. (WebCore::createMemoryParser):
  68889. (WebCore::XMLTokenizer::XMLTokenizer):
  68890. (WebCore::XMLTokenizer::~XMLTokenizer):
  68891. (WebCore::XMLTokenizer::doWrite):
  68892. (WebCore::ignorableWhitespaceHandler):
  68893. (WebCore::XMLTokenizer::initializeParserContext):
  68894. (WebCore::XMLTokenizer::doEnd):
  68895. (WebCore::XMLTokenizer::lineNumber):
  68896. (WebCore::XMLTokenizer::columnNumber):
  68897. (WebCore::XMLTokenizer::stopParsing):
  68898. (WebCore::XMLTokenizer::resumeParsing):
  68899. (WebCore::parseXMLDocumentFragment):
  68900. (WebCore::attributesStartElementNsHandler):
  68901. (WebCore::parseAttributes):
  68902. * dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
  68903. (WebCore::EntityResolver::resolveUndeclaredEntity):
  68904. (WebCore::XMLTokenizer::XMLTokenizer):
  68905. (WebCore::XMLTokenizer::~XMLTokenizer):
  68906. (WebCore::XMLTokenizer::doWrite):
  68907. (WebCore::XMLTokenizer::initializeParserContext):
  68908. (WebCore::XMLTokenizer::doEnd):
  68909. (WebCore::XMLTokenizer::lineNumber):
  68910. (WebCore::XMLTokenizer::columnNumber):
  68911. (WebCore::XMLTokenizer::stopParsing):
  68912. (WebCore::XMLTokenizer::resumeParsing):
  68913. (WebCore::parseXMLDocumentFragment):
  68914. (WebCore::attributesStartElementNsHandler):
  68915. (WebCore::parseAttributes):
  68916. (WebCore::):
  68917. 2008-09-18 Beth Dakin <bdakin@apple.com>
  68918. Reviewed by Geoff Garen.
  68919. Build fix for non-Mac builds.
  68920. * css/CSSPrimitiveValue.cpp:
  68921. (WebCore::CSSPrimitiveValue::cssText):
  68922. 2008-09-18 Peter Kasting <pkasting@google.com>
  68923. Reviewed by hyatt. Landed by eseidel.
  68924. https://bugs.webkit.org/show_bug.cgi?id=20745
  68925. Animated GIFs do not animate properly with (at least) CG.
  68926. * WebCore\platform\graphics\BitmapImage.cpp:
  68927. * WebCore\platform\graphics\BitmapImage.h:
  68928. * WebCore\platform\graphics\cairo\ImageCairo.cpp:
  68929. * WebCore\platform\graphics\cg\ImageCG.cpp:
  68930. * WebCore\platform\graphics\qt\ImageQt.cpp:
  68931. * WebCore\platform\graphics\wx\ImageWx.cpp:
  68932. 2008-09-18 Chris Fleizach <cfleizach@apple.com>
  68933. Reviewed by Beth Dakin
  68934. <rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
  68935. role specifies otherwise
  68936. If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
  68937. Test: accessibility/table-with-aria-role.html
  68938. * page/AccessibilityTable.cpp:
  68939. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  68940. (WebCore::AccessibilityTable::addChildren):
  68941. (WebCore::AccessibilityTable::roleValue):
  68942. (WebCore::AccessibilityTable::accessibilityIsIgnored):
  68943. (WebCore::AccessibilityTable::title):
  68944. * page/AccessibilityTableCell.cpp:
  68945. (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
  68946. (WebCore::AccessibilityTableCell::isTableCell):
  68947. (WebCore::AccessibilityTableCell::roleValue):
  68948. * page/AccessibilityTableCell.h:
  68949. * page/AccessibilityTableRow.cpp:
  68950. (WebCore::AccessibilityTableRow::roleValue):
  68951. (WebCore::AccessibilityTableRow::isTableRow):
  68952. (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
  68953. * page/AccessibilityTableRow.h:
  68954. 2008-09-18 Steve Falkenburg <sfalken@apple.com>
  68955. Use higher-resolution timers on all variants of Windows.
  68956. Reviewed by Darin Adler.
  68957. * platform/win/SharedTimerWin.cpp:
  68958. (WebCore::setSharedTimerFireTime):
  68959. 2008-09-18 David Hyatt <hyatt@apple.com>
  68960. Make containingWindow() and setContainingWindow() cross-platform.
  68961. Add a root() function cross-platform so Qt doesn't have to
  68962. define its own.
  68963. Reviewed by Darin Adler
  68964. * platform/Widget.cpp:
  68965. (WebCore::Widget::root):
  68966. * platform/Widget.h:
  68967. (WebCore::Widget::setContainingWindow):
  68968. * platform/gtk/WidgetGtk.cpp:
  68969. (WebCore::Widget::Widget):
  68970. (WebCore::Widget::containingWindow):
  68971. * platform/mac/ScrollViewMac.mm:
  68972. (WebCore::ScrollView::addChild):
  68973. (WebCore::ScrollView::removeChild):
  68974. * platform/mac/WidgetMac.mm:
  68975. (WebCore::Widget::containingWindow):
  68976. * platform/qt/WidgetQt.cpp:
  68977. (WebCore::Widget::invalidateRect):
  68978. (WebCore::Widget::containingWindow):
  68979. * platform/win/WidgetWin.cpp:
  68980. (WebCore::Widget::Widget):
  68981. (WebCore::Widget::~Widget):
  68982. (WebCore::Widget::containingWindow):
  68983. 2008-09-18 Beth Dakin <bdakin@apple.com>
  68984. Reviewed by Dave Hyatt.
  68985. Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
  68986. parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
  68987. dashboard-region=
  68988. and corresponding: <rdar://problem/6174100>
  68989. This patch makes CSSParserValue::createCSSValue handle unknown
  68990. identifiers.
  68991. * css/CSSParserValues.cpp:
  68992. (WebCore::CSSParserValue::createCSSValue): If we have an identifier
  68993. with no id (an unknown identifier) create a CSSPrimitiveValue of
  68994. type CSS_PARSER_IDENTIFIER
  68995. * css/CSSPrimitiveValue.cpp:
  68996. (WebCore::CSSPrimitiveValue::cssText):
  68997. (WebCore::CSSPrimitiveValue::parserValue):
  68998. * css/CSSPrimitiveValue.h:
  68999. (WebCore::CSSPrimitiveValue::):
  69000. 2008-09-18 Sam Weinig <sam@webkit.org>
  69001. Rubber-stamped by David "I'd prefer not" Hyatt.
  69002. More the remaining class out of RenderStyle.h/cpp
  69003. * GNUmakefile.am:
  69004. * WebCore.pro:
  69005. * WebCore.vcproj/WebCore.vcproj:
  69006. * WebCore.xcodeproj/project.pbxproj:
  69007. * WebCoreSources.bkl:
  69008. * rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
  69009. (WebCore::CursorData::CursorData):
  69010. (WebCore::CursorData::operator==):
  69011. (WebCore::CursorData::operator!=):
  69012. * rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
  69013. (WebCore::CursorList::operator[]):
  69014. (WebCore::CursorList::CursorList):
  69015. * rendering/style/RenderStyle.cpp:
  69016. * rendering/style/RenderStyle.h:
  69017. (WebCore::RenderStyle::deref):
  69018. (WebCore::RenderStyle::hasOneRef):
  69019. (WebCore::RenderStyle::InheritedFlags::operator!=):
  69020. (WebCore::RenderStyle::NonInheritedFlags::operator!=):
  69021. (WebCore::RenderStyle::hasBackground):
  69022. (WebCore::RenderStyle::outlineWidth):
  69023. (WebCore::RenderStyle::autoWrap):
  69024. (WebCore::RenderStyle::preserveNewline):
  69025. (WebCore::RenderStyle::collapseWhiteSpace):
  69026. (WebCore::RenderStyle::isCollapsibleWhiteSpace):
  69027. (WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
  69028. (WebCore::RenderStyle::breakWords):
  69029. (WebCore::RenderStyle::outlineOffset):
  69030. (WebCore::RenderStyle::setLeft):
  69031. (WebCore::RenderStyle::setRight):
  69032. (WebCore::RenderStyle::setTop):
  69033. (WebCore::RenderStyle::setBottom):
  69034. (WebCore::RenderStyle::setDashboardRegion):
  69035. (WebCore::RenderStyle::setBackgroundColor):
  69036. (WebCore::RenderStyle::setBorderImage):
  69037. (WebCore::RenderStyle::setBorderRadius):
  69038. (WebCore::RenderStyle::setFontDescription):
  69039. (WebCore::RenderStyle::adjustBackgroundLayers):
  69040. (WebCore::RenderStyle::adjustMaskLayers):
  69041. (WebCore::RenderStyle::deleteBindingURIs):
  69042. (WebCore::RenderStyle::inheritBindingURIs):
  69043. (WebCore::RenderStyle::isDisplayReplacedType):
  69044. (WebCore::RenderStyle::isDisplayInlineType):
  69045. (WebCore::RenderStyle::isOriginalDisplayInlineType):
  69046. * rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69047. * rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
  69048. (WebCore::StyleInheritedData::operator!=):
  69049. * rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69050. * rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
  69051. (WebCore::StyleRareInheritedData::operator!=):
  69052. * rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69053. * rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
  69054. * rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
  69055. 2008-09-18 David Hyatt <hyatt@apple.com>
  69056. Move the concept of suppression invalidation on Widgets to Scrollbar
  69057. instead. Since this is only used by Scrollbars, there is no need for
  69058. it to be on Widget.
  69059. Reviewed by Sam Weinig
  69060. * platform/Scrollbar.cpp:
  69061. (WebCore::Scrollbar::Scrollbar):
  69062. (WebCore::Scrollbar::invalidateRect):
  69063. * platform/Scrollbar.h:
  69064. (WebCore::Scrollbar::suppressInvalidation):
  69065. (WebCore::Scrollbar::setSuppressInvalidation):
  69066. * platform/Widget.h:
  69067. * platform/gtk/WidgetGtk.cpp:
  69068. (WebCore::Widget::Widget):
  69069. (WebCore::Widget::invalidateRect):
  69070. * platform/qt/WidgetQt.cpp:
  69071. (WebCore::WidgetPrivate::WidgetPrivate):
  69072. (WebCore::Widget::invalidateRect):
  69073. * platform/win/WidgetWin.cpp:
  69074. (WebCore::Widget::Widget):
  69075. (WebCore::Widget::invalidateRect):
  69076. 2008-09-18 David Hyatt <hyatt@apple.com>
  69077. Make invalidate() on Widget non-virtual and make it just call
  69078. invalidateRect() on the boundsGeometry() of the Widget.
  69079. Reviewed by Dan Bernstein
  69080. * platform/Widget.h:
  69081. (WebCore::Widget::boundsGeometry):
  69082. (WebCore::Widget::invalidate):
  69083. * platform/gtk/WidgetGtk.cpp:
  69084. * platform/mac/WidgetMac.mm:
  69085. * platform/qt/WidgetQt.cpp:
  69086. * platform/win/WidgetWin.cpp:
  69087. * platform/wx/WidgetWx.cpp:
  69088. 2008-09-18 Sam Weinig <sam@webkit.org>
  69089. Rubber-stamped in exile by David Hyatt.
  69090. Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
  69091. KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
  69092. RenderStyle.h/cpp
  69093. * GNUmakefile.am:
  69094. * WebCore.pro:
  69095. * WebCore.vcproj/WebCore.vcproj:
  69096. * WebCore.xcodeproj/project.pbxproj:
  69097. * WebCoreSources.bkl:
  69098. * css/CSSStyleSelector.cpp:
  69099. * css/CSSStyleSelector.h:
  69100. * page/animation/CompositeAnimation.cpp:
  69101. * page/animation/KeyframeAnimation.cpp:
  69102. * page/animation/KeyframeAnimation.h:
  69103. * rendering/RenderCounter.h:
  69104. * rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
  69105. (WebCore::Animation::~Animation):
  69106. (WebCore::Animation::animationsMatch):
  69107. (WebCore::Animation::keyframeList):
  69108. (WebCore::Animation::setAnimationKeyframe):
  69109. * rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
  69110. * rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
  69111. * rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
  69112. * rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
  69113. * rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
  69114. (WebCore::BindingURI::operator!=):
  69115. * rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69116. * rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
  69117. (WebCore::ContentData::ContentData):
  69118. (WebCore::ContentData::~ContentData):
  69119. * rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
  69120. (WebCore::CounterContent::CounterContent):
  69121. * rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
  69122. * rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
  69123. (WebCore::CounterDirectives::CounterDirectives):
  69124. * rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
  69125. (WebCore::KeyframeList::insert):
  69126. * rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
  69127. (WebCore::KeyframeValue::KeyframeValue):
  69128. (WebCore::KeyframeList::create):
  69129. (WebCore::KeyframeList::KeyframeList):
  69130. * rendering/style/RenderStyle.cpp:
  69131. * rendering/style/RenderStyle.h:
  69132. * rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69133. * rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
  69134. (WebCore::ShadowData::ShadowData):
  69135. (WebCore::ShadowData::~ShadowData):
  69136. (WebCore::ShadowData::operator!=):
  69137. * rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69138. * rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
  69139. (WebCore::StyleFlexibleBoxData::operator!=):
  69140. * rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
  69141. (WebCore::TimingFunction::TimingFunction):
  69142. (WebCore::TimingFunction::operator==):
  69143. 2008-09-18 Adele Peterson <adele@apple.com>
  69144. Reviewed by Dan Bernstein.
  69145. Fix RenderStyle leaks.
  69146. * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
  69147. 2008-09-18 Kevin McCullough <kmccullough@apple.com>
  69148. Accidentally checked in code.
  69149. * html/HTMLElementFactory.cpp:
  69150. (WebCore::frameConstructor):
  69151. (WebCore::iframeConstructor):
  69152. 2008-09-18 Kevin McCullough <kmccullough@apple.com>
  69153. Reviewed by Tim.
  69154. <rdar://problem/5722310> gracefully handle too many console messages
  69155. (20904)
  69156. - Keep track of the most previous message and then compare it to the
  69157. subsequent messages as they come in. If there are multiple of the same
  69158. message create a count that indicates the current number.
  69159. * manual-tests/inspector/multiple-console-messages.html: Added.
  69160. * page/inspector/Console.js:
  69161. * page/inspector/inspector.css:
  69162. 2008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
  69163. Reviewed by Alp Toker
  69164. https://bugs.webkit.org/show_bug.cgi?id=20830
  69165. [GTK] Don't use deprecated pango API
  69166. Replace deprecated pango functions with non-deprecated ones for newer
  69167. versions of pango
  69168. * platform/graphics/gtk/FontGtk.cpp:
  69169. (WebCore::getDefaultPangoLayout):
  69170. * platform/graphics/gtk/FontPlatformDataPango.cpp:
  69171. (WebCore::FontPlatformData::FontPlatformData):
  69172. 2008-09-18 Alp Toker <alp@nuanti.com>
  69173. Build fix for r36587. Add new sources (and sort the lists).
  69174. * GNUmakefile.am:
  69175. 2008-09-17 Sam Weinig <sam@webkit.org>
  69176. Fix Windows build.
  69177. * WebCore.vcproj/WebCore.vcproj:
  69178. 2008-09-17 David Hyatt <hyatt@apple.com>
  69179. Switch back to having frameGeometry be virtual in order to keep Mac
  69180. the way it used to be.
  69181. Reviewed by Sam Weinig
  69182. * WebCore.base.exp:
  69183. * platform/Widget.cpp:
  69184. (WebCore::Widget::setParent):
  69185. * platform/Widget.h:
  69186. * platform/gtk/WidgetGtk.cpp:
  69187. (WebCore::Widget::frameGeometry):
  69188. (WebCore::Widget::setFrameGeometry):
  69189. * platform/mac/WidgetMac.mm:
  69190. (WebCore::Widget::frameGeometry):
  69191. (WebCore::Widget::setFrameGeometry):
  69192. * platform/qt/WidgetQt.cpp:
  69193. (WebCore::Widget::frameGeometry):
  69194. (WebCore::Widget::setFrameGeometry):
  69195. * platform/win/WidgetWin.cpp:
  69196. (WebCore::Widget::frameGeometry):
  69197. (WebCore::Widget::setFrameGeometry):
  69198. * platform/wx/WidgetWx.cpp:
  69199. (WebCore::Widget::frameGeometry):
  69200. (WebCore::Widget::setFrameGeometry):
  69201. * plugins/PluginView.cpp:
  69202. (WebCore::PluginView::setFrameGeometry):
  69203. (WebCore::PluginView::geometryChanged):
  69204. * plugins/PluginView.h:
  69205. * plugins/gtk/PluginViewGtk.cpp:
  69206. (WebCore::PluginView::updatePluginWidget):
  69207. * plugins/qt/PluginViewQt.cpp:
  69208. (WebCore::PluginView::updatePluginWidget):
  69209. * plugins/win/PluginViewWin.cpp:
  69210. (WebCore::PluginView::updatePluginWidget):
  69211. 2008-09-17 Sam Weinig <sam@webkit.org>
  69212. Reviewed by Mark Rowe.
  69213. Fix assertion in DOMWindow::adjustWindowRect where we were passing
  69214. in garbage values and were getting lucky that they were a not Nan.
  69215. * bindings/js/JSDOMWindowBase.cpp:
  69216. (WebCore::windowProtoFuncOpen):
  69217. 2008-09-17 Sam Weinig <sam@webkit.org>
  69218. Fix gtk build.
  69219. * rendering/style/MatrixTransformOperation.cpp:
  69220. 2008-09-17 Sam Weinig <sam@webkit.org>
  69221. Rubber-stamped with love by David Hyatt.
  69222. Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
  69223. ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
  69224. TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
  69225. * GNUmakefile.am:
  69226. * WebCore.pro:
  69227. * WebCore.vcproj/WebCore.vcproj:
  69228. * WebCore.xcodeproj/project.pbxproj:
  69229. * WebCoreSources.bkl:
  69230. * css/CSSStyleSelector.cpp:
  69231. * page/animation/AnimationBase.cpp:
  69232. (WebCore::solveEpsilon):
  69233. * rendering/RenderLayer.cpp:
  69234. * rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69235. * rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  69236. * rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69237. (WebCore::MatrixTransformOperation::MatrixTransformOperation):
  69238. * rendering/style/RenderStyle.cpp:
  69239. * rendering/style/RenderStyle.h:
  69240. * rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  69241. * rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69242. (WebCore::RotateTransformOperation::RotateTransformOperation):
  69243. * rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  69244. * rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69245. (WebCore::ScaleTransformOperation::ScaleTransformOperation):
  69246. * rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  69247. * rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69248. (WebCore::SkewTransformOperation::SkewTransformOperation):
  69249. * rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69250. * rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
  69251. (WebCore::StyleTransformData::operator!=):
  69252. * rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69253. (WebCore::TransformOperation::):
  69254. * rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
  69255. (WebCore::TransformOperations::TransformOperations):
  69256. * rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
  69257. (WebCore::TransformOperations::operator!=):
  69258. * rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  69259. * rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  69260. (WebCore::TranslateTransformOperation::TranslateTransformOperation):
  69261. 2008-09-17 Mark Rowe <mrowe@apple.com>
  69262. Build fix.
  69263. * rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
  69264. 2008-09-17 David Hyatt <hyatt@apple.com>
  69265. (1) Inline a bunch of methods for accessing frame geometry.
  69266. (2) Make sure frameGeometry() works even when you have no underlying
  69267. native widget.
  69268. (3) Cache a frame geometry rect cross-platform (even for widgets that
  69269. have underlying native widgets.
  69270. (4) PluginView's updateWindow call is now a virtual function on Widget.
  69271. Reviewed by Sam Weinig
  69272. * ChangeLog:
  69273. * WebCore.base.exp:
  69274. * platform/Widget.cpp:
  69275. (WebCore::Widget::setFrameGeometry):
  69276. * platform/Widget.h:
  69277. (WebCore::Widget::x):
  69278. (WebCore::Widget::y):
  69279. (WebCore::Widget::width):
  69280. (WebCore::Widget::height):
  69281. (WebCore::Widget::size):
  69282. (WebCore::Widget::pos):
  69283. (WebCore::Widget::frameGeometry):
  69284. (WebCore::Widget::resize):
  69285. (WebCore::Widget::move):
  69286. (WebCore::Widget::isFrameView):
  69287. (WebCore::Widget::windowClipRect):
  69288. * platform/mac/WidgetMac.mm:
  69289. (WebCore::Widget::~Widget):
  69290. (WebCore::Widget::updatePlatformWidgetFrameGeometry):
  69291. * platform/win/WidgetWin.cpp:
  69292. (WebCore::Widget::updatePlatformWidgetFrameGeometry):
  69293. * plugins/PluginView.cpp:
  69294. (WebCore::PluginView::setFrameGeometry):
  69295. (WebCore::PluginView::geometryChanged):
  69296. * plugins/PluginView.h:
  69297. * plugins/gtk/PluginViewGtk.cpp:
  69298. (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
  69299. * plugins/qt/PluginViewQt.cpp:
  69300. (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
  69301. * plugins/win/PluginViewWin.cpp:
  69302. (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
  69303. * plugins/wx/PluginViewWx.cpp:
  69304. 2008-09-17 Sam Weinig <sam@webkit.org>
  69305. Reviewed by David "Waterman" Hyatt.
  69306. Fix a leak of NSViews in WidgetMac.mm.
  69307. * platform/mac/WidgetMac.mm:
  69308. (WebCore::Widget::~Widget):
  69309. 2008-09-17 Sam Weinig <sam@webkit.org>
  69310. Rubber-stamped by David Waterman Hyatt.
  69311. Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
  69312. StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
  69313. * GNUmakefile.am:
  69314. * WebCore.pro:
  69315. * WebCore.vcproj/WebCore.vcproj:
  69316. * WebCore.xcodeproj/project.pbxproj:
  69317. * WebCoreSources.bkl:
  69318. * rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
  69319. * rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
  69320. (WebCore::FillLayer::operator!=):
  69321. (WebCore::FillLayer::hasImage):
  69322. (WebCore::FillLayer::hasFixedImage):
  69323. * rendering/style/RenderStyle.cpp:
  69324. * rendering/style/RenderStyle.h:
  69325. * rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69326. (WebCore::StyleBackgroundData::StyleBackgroundData):
  69327. * rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
  69328. (WebCore::StyleBackgroundData::~StyleBackgroundData):
  69329. (WebCore::StyleBackgroundData::operator!=):
  69330. * rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69331. * rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
  69332. (WebCore::StyleBoxData::operator!=):
  69333. * rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
  69334. (WebCore::StyleDashboardRegion::operator!=):
  69335. * rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69336. * rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
  69337. (WebCore::StyleMarqueeData::operator!=):
  69338. * rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69339. * rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
  69340. (WebCore::StyleMultiColData::operator!=):
  69341. (WebCore::StyleMultiColData::ruleWidth):
  69342. * rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69343. * rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
  69344. (WebCore::StyleVisualData::operator==):
  69345. 2008-09-17 David Hyatt <hyatt@apple.com>
  69346. Remove WidgetClient from Widget.
  69347. Reviewed by Sam Weinig
  69348. * WebCore.xcodeproj/project.pbxproj:
  69349. * platform/Widget.h:
  69350. (WebCore::Widget::setClient):
  69351. (WebCore::Widget::client):
  69352. * platform/WidgetClient.h: Removed.
  69353. * platform/gtk/WidgetGtk.cpp:
  69354. * platform/mac/WidgetMac.mm:
  69355. (WebCore::Widget::Widget):
  69356. (WebCore::Widget::show):
  69357. (WebCore::Widget::hide):
  69358. * platform/qt/WidgetQt.cpp:
  69359. (WebCore::WidgetPrivate::WidgetPrivate):
  69360. * platform/win/WidgetWin.cpp:
  69361. (WebCore::Widget::Widget):
  69362. * platform/wx/WidgetWx.cpp:
  69363. (WebCore::Widget::Widget):
  69364. 2008-09-17 David Hyatt <hyatt@apple.com>
  69365. Remove isEnabled/setEnabled from Widget. The concept of being enabled now
  69366. only applies to Scrollbars so the method has been moved there and made
  69367. cross-platform. Scrollbar subclasses that have a corresponding native
  69368. widget can subclass setEnabled to change the enabled state of the native
  69369. widget.
  69370. Reviewed by Sam Weinig & Darin Adler
  69371. * WebCore.base.exp:
  69372. * platform/Scrollbar.cpp:
  69373. (WebCore::Scrollbar::Scrollbar):
  69374. * platform/Scrollbar.h:
  69375. (WebCore::Scrollbar::enabled):
  69376. (WebCore::Scrollbar::setEnabled):
  69377. * platform/Widget.h:
  69378. * platform/gtk/ScrollbarGtk.cpp:
  69379. (ScrollbarGtk::setEnabled):
  69380. * platform/gtk/ScrollbarGtk.h:
  69381. * platform/gtk/WidgetGtk.cpp:
  69382. * platform/mac/ScrollbarMac.h:
  69383. * platform/mac/ScrollbarMac.mm:
  69384. (WebCore::ScrollbarMac::scrollbarHit):
  69385. (WebCore::ScrollbarMac::setEnabled):
  69386. * platform/mac/WidgetMac.mm:
  69387. * platform/qt/WidgetQt.cpp:
  69388. (WebCore::WidgetPrivate::WidgetPrivate):
  69389. * platform/win/WidgetWin.cpp:
  69390. (WebCore::Widget::Widget):
  69391. * platform/wx/WidgetWx.cpp:
  69392. 2008-09-17 Sam Weinig <sam@webkit.org>
  69393. Rubber-stamped by David Hyatt.
  69394. Split all RenderStyle enums into their own file.
  69395. * GNUmakefile.am:
  69396. * WebCore.vcproj/WebCore.vcproj:
  69397. * WebCore.xcodeproj/project.pbxproj:
  69398. * rendering/style/BorderValue.h:
  69399. * rendering/style/CollapsedBorderValue.h:
  69400. * rendering/style/RenderStyle.h:
  69401. * rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
  69402. (WebCore::):
  69403. * rendering/style/StyleCachedImage.h:
  69404. * rendering/style/StyleGeneratedImage.h:
  69405. * rendering/style/StyleImage.h:
  69406. 2008-09-17 Steve Falkenburg <sfalken@apple.com>
  69407. Add back isFrameView check to fix failed assertion during scroll bar teardown.
  69408. Reviewed by Dave Hyatt.
  69409. * platform/Scrollbar.cpp:
  69410. (WebCore::Scrollbar::setParent):
  69411. 2008-09-17 Brady Eidson <beidson@apple.com>
  69412. Reviewed by Mac build fix
  69413. * WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
  69414. 2008-09-17 Steve Falkenburg <sfalken@apple.com>
  69415. Fix build.
  69416. * platform/win/ScrollViewWin.cpp:
  69417. (WebCore::ScrollView::setParentVisible):
  69418. * plugins/win/PluginViewWin.cpp:
  69419. (WebCore::PluginView::init):
  69420. 2008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
  69421. Reviewed by Simon.
  69422. [QtWebKit] Implement error handling in TextCodecQt::decode
  69423. Use the QTextCodec parsing state to set the sawError out variable. This
  69424. is needed to pass Test 70 of acid3. The test case for this bug is
  69425. fast/encoding/invalid-xml.html that is now partially passed. To pass
  69426. it completely the Qt text codecs need to be adjusted to have proper
  69427. error handling.
  69428. * platform/text/qt/TextCodecQt.cpp:
  69429. (WebCore::TextCodecQt::decode):
  69430. 2008-09-17 Sam Weinig <sam@webkit.org>
  69431. Rubber-stamped by Dave Hyatt.
  69432. Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
  69433. out of RenderStyle.h/cpp
  69434. * GNUmakefile.am:
  69435. * WebCore.pro:
  69436. * WebCore.vcproj/WebCore.vcproj:
  69437. * WebCore.xcodeproj/project.pbxproj:
  69438. * WebCoreSources.bkl:
  69439. * rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
  69440. (WebCore::BorderData::hasBorderRadius):
  69441. (WebCore::BorderData::borderLeftWidth):
  69442. (WebCore::BorderData::borderRightWidth):
  69443. (WebCore::BorderData::borderTopWidth):
  69444. (WebCore::BorderData::borderBottomWidth):
  69445. (WebCore::BorderData::operator!=):
  69446. * rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
  69447. (WebCore::):
  69448. (WebCore::BorderValue::BorderValue):
  69449. (WebCore::BorderValue::nonZero):
  69450. (WebCore::BorderValue::isTransparent):
  69451. (WebCore::BorderValue::isVisible):
  69452. * rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
  69453. (WebCore::):
  69454. (WebCore::CollapsedBorderValue::CollapsedBorderValue):
  69455. (WebCore::CollapsedBorderValue::operator==):
  69456. * rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
  69457. (WebCore::OutlineValue::OutlineValue):
  69458. * rendering/style/RenderStyle.cpp:
  69459. * rendering/style/RenderStyle.h:
  69460. * rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
  69461. * rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
  69462. (WebCore::StyleSurroundData::operator!=):
  69463. 2008-09-17 Beth Dakin <bdakin@apple.com>
  69464. Reviewed by Darin Adler.
  69465. This is a better fix for: Invalid CSS code crashes Safari
  69466. https://bugs.webkit.org/show_bug.cgi?id=20512
  69467. The spec indicates that the only valid input for a counter is a
  69468. number or an identifier. So that is exactly what we allow.
  69469. * css/CSSParser.cpp:
  69470. (WebCore::CSSParser::parseCounterContent):
  69471. 2008-09-17 Alp Toker <alp@nuanti.com>
  69472. GTK+ build fix. Adapt to use PlatformWidget functions.
  69473. * platform/gtk/ScrollViewGtk.cpp:
  69474. (WebCore::ScrollViewScrollbar::geometryChanged):
  69475. (WebCore::ScrollView::addChild):
  69476. (WebCore::ScrollView::removeChild):
  69477. * platform/gtk/ScrollbarGtk.cpp:
  69478. (ScrollbarGtk::ScrollbarGtk):
  69479. (ScrollbarGtk::~ScrollbarGtk):
  69480. (ScrollbarGtk::geometryChanged):
  69481. 2008-09-17 Sam Weinig <sam@webkit.org>
  69482. Reviewed by Adele Peterson.
  69483. Patch for <rdar://problem/6133884>
  69484. Calling window.resizeTo() on a subframe shouldn't change the window size
  69485. Test: fast/dom/Window/window-resize-and-move-sub-frame.html
  69486. * page/DOMWindow.cpp:
  69487. (WebCore::DOMWindow::moveBy):
  69488. (WebCore::DOMWindow::moveTo):
  69489. (WebCore::DOMWindow::resizeBy):
  69490. (WebCore::DOMWindow::resizeTo):
  69491. 2008-09-17 Beth Dakin <bdakin@apple.com>
  69492. Reviewed by Adam Roben.
  69493. Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
  69494. code crashes Safari
  69495. and corresponding: <rdar://problem/6173832>
  69496. Reading through the spec, it seems like a function is not valid
  69497. input for a counter. So this patch checks for that and bails in the
  69498. case of invalid input.
  69499. * css/CSSParser.cpp:
  69500. (WebCore::CSSParser::parseCounterContent):
  69501. 2008-09-17 Greg Bolsinga <bolsinga@apple.com>
  69502. Reviewed by Antti Koivisto.
  69503. Fix <rdar://problem/6227089>
  69504. Crash in WebCore::Frame::setNeedsReapplyStyles()
  69505. View is null checked elsewhere too.
  69506. * page/Frame.cpp:
  69507. (WebCore::Frame::setNeedsReapplyStyles):
  69508. 2008-09-17 David Hyatt <hyatt@apple.com>
  69509. Make the notion of having a native widget backing a Widget cross-platform.
  69510. The PlatformWidget abstraction (which already existed) is used for this.
  69511. Windows = HWND
  69512. Qt = QWidget
  69513. Mac = NSView
  69514. wx = wxWindow
  69515. Gtk = GtkWidget
  69516. There are new cross-platform methods that replace all of the unique
  69517. platform-specific methods.
  69518. platformWidget()
  69519. setPlatformWidget()
  69520. For plugins, on every platform except Qt on Windows, the plugin's native
  69521. widget is now stored in the Widget base class. Since Qt on Windows uses
  69522. HWNDs for plugins instead of QWidget, it is the only platform to keep the
  69523. m_window variable in PluginView.
  69524. Reviewed by Sam Weinig
  69525. * WebCore.base.exp:
  69526. * bindings/js/ScriptControllerMac.mm:
  69527. (WebCore::ScriptController::createScriptInstanceForWidget):
  69528. * page/mac/AccessibilityObjectWrapper.mm:
  69529. (-[AccessibilityObjectWrapper attachmentView]):
  69530. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  69531. * page/mac/EventHandlerMac.mm:
  69532. (WebCore::EventHandler::passMouseDownEventToWidget):
  69533. (WebCore::EventHandler::mouseDownViewIfStillGood):
  69534. (WebCore::EventHandler::passWheelEventToWidget):
  69535. (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
  69536. * platform/Widget.cpp:
  69537. (WebCore::Widget::init):
  69538. (WebCore::Widget::setParent):
  69539. (WebCore::Widget::releasePlatformWidget):
  69540. (WebCore::Widget::retainPlatformWidget):
  69541. * platform/Widget.h:
  69542. (WebCore::Widget::platformWidget):
  69543. (WebCore::Widget::setPlatformWidget):
  69544. * platform/gtk/WidgetGtk.cpp:
  69545. (WebCore::Widget::Widget):
  69546. (WebCore::Widget::setFocus):
  69547. (WebCore::gdkDrawable):
  69548. (WebCore::Widget::setCursor):
  69549. (WebCore::Widget::show):
  69550. (WebCore::Widget::hide):
  69551. (WebCore::Widget::setEnabled):
  69552. (WebCore::Widget::isEnabled):
  69553. (WebCore::Widget::paint):
  69554. * platform/mac/PlatformScreenMac.mm:
  69555. (WebCore::screenRect):
  69556. (WebCore::screenAvailableRect):
  69557. * platform/mac/ScrollViewMac.mm:
  69558. (WebCore::ScrollView::scrollView):
  69559. (WebCore::ScrollView::update):
  69560. (WebCore::ScrollView::inWindow):
  69561. * platform/mac/ScrollbarMac.mm:
  69562. (WebCore::ScrollbarMac::ScrollbarMac):
  69563. (WebCore::ScrollbarMac::~ScrollbarMac):
  69564. (WebCore::ScrollbarMac::updateThumbPosition):
  69565. (WebCore::ScrollbarMac::updateThumbProportion):
  69566. (WebCore::ScrollbarMac::scrollbarHit):
  69567. * platform/mac/WidgetMac.mm:
  69568. (WebCore::Widget::Widget):
  69569. (WebCore::Widget::setEnabled):
  69570. (WebCore::Widget::isEnabled):
  69571. (WebCore::Widget::setFocus):
  69572. (WebCore::Widget::getOuterView):
  69573. (WebCore::Widget::paint):
  69574. (WebCore::Widget::invalidate):
  69575. (WebCore::Widget::invalidateRect):
  69576. (WebCore::Widget::setIsSelected):
  69577. (WebCore::Widget::releasePlatformWidget):
  69578. (WebCore::Widget::retainPlatformWidget):
  69579. * platform/qt/WidgetQt.cpp:
  69580. (WebCore::WidgetPrivate::WidgetPrivate):
  69581. (WebCore::Widget::Widget):
  69582. (WebCore::Widget::setFrameGeometry):
  69583. (WebCore::Widget::show):
  69584. (WebCore::Widget::hide):
  69585. (WebCore::Widget::isEnabled):
  69586. (WebCore::Widget::setEnabled):
  69587. (WebCore::Widget::invalidateRect):
  69588. (WebCore::Widget::containingWindow):
  69589. * platform/win/WidgetWin.cpp:
  69590. (WebCore::Widget::Widget):
  69591. * platform/wx/WidgetWx.cpp:
  69592. (WebCore::Widget::Widget):
  69593. (WebCore::Widget::frameGeometry):
  69594. (WebCore::Widget::setFocus):
  69595. (WebCore::Widget::setCursor):
  69596. (WebCore::Widget::show):
  69597. (WebCore::Widget::hide):
  69598. (WebCore::Widget::setFrameGeometry):
  69599. (WebCore::Widget::setEnabled):
  69600. (WebCore::Widget::isEnabled):
  69601. (WebCore::Widget::invalidate):
  69602. (WebCore::Widget::invalidateRect):
  69603. (WebCore::Widget::paint):
  69604. * plugins/PluginView.cpp:
  69605. (WebCore::PluginView::PluginView):
  69606. * plugins/PluginView.h:
  69607. (WebCore::PluginView::platformPluginWidget):
  69608. * plugins/gtk/PluginViewGtk.cpp:
  69609. (WebCore::PluginView::updateWindow):
  69610. (WebCore::PluginView::setFocus):
  69611. (WebCore::PluginView::show):
  69612. (WebCore::PluginView::hide):
  69613. (WebCore::PluginView::setParent):
  69614. (WebCore::PluginView::setNPWindowRect):
  69615. (WebCore::PluginView::setParentVisible):
  69616. (WebCore::PluginView::getValue):
  69617. (WebCore::PluginView::forceRedraw):
  69618. (WebCore::PluginView::init):
  69619. * plugins/qt/PluginViewQt.cpp:
  69620. (WebCore::PluginView::updateWindow):
  69621. (WebCore::PluginView::setFocus):
  69622. (WebCore::PluginView::show):
  69623. (WebCore::PluginView::hide):
  69624. (WebCore::PluginView::setParent):
  69625. (WebCore::PluginView::setNPWindowRect):
  69626. (WebCore::PluginView::setParentVisible):
  69627. (WebCore::PluginView::getValue):
  69628. (WebCore::PluginView::~PluginView):
  69629. (WebCore::PluginView::init):
  69630. * plugins/win/PluginViewWin.cpp:
  69631. (WebCore::PluginView::updateWindow):
  69632. (WebCore::PluginView::setFocus):
  69633. (WebCore::PluginView::show):
  69634. (WebCore::PluginView::hide):
  69635. (WebCore::PluginView::paint):
  69636. (WebCore::PluginView::setParent):
  69637. (WebCore::PluginView::setParentVisible):
  69638. (WebCore::PluginView::setNPWindowRect):
  69639. (WebCore::PluginView::stop):
  69640. (WebCore::PluginView::invalidateRect):
  69641. (WebCore::PluginView::forceRedraw):
  69642. (WebCore::PluginView::~PluginView):
  69643. (WebCore::PluginView::init):
  69644. 2008-09-17 Sam Weinig <sam@webkit.org>
  69645. Fix assert.
  69646. * platform/Widget.cpp:
  69647. (WebCore::Widget::setParent):
  69648. 2008-09-17 David Hyatt <hyatt@apple.com>
  69649. Beginnings of Widget refactoring (in order to make the mixing of
  69650. widgets with and without corresponding native widgets more cross-platform).
  69651. This first patch makes the concept of a parent ScrollView cross-platform.
  69652. Note the similarity of the show/hide methods on the three PluginViews. This
  69653. will be refactored better in a later patch so that they can all share
  69654. a base class Widget show/hide method. For now the changes were made
  69655. simply to be able to bring WidgetWin's setParent method up into Widget.
  69656. Reviewed by Sam Weinig
  69657. * WebCore.base.exp:
  69658. * platform/ScrollView.h:
  69659. * platform/Widget.cpp:
  69660. (WebCore::Widget::init):
  69661. (WebCore::Widget::setParent):
  69662. * platform/Widget.h:
  69663. (WebCore::Widget::isSelfVisible):
  69664. (WebCore::Widget::isParentVisible):
  69665. (WebCore::Widget::isVisible):
  69666. (WebCore::Widget::setParentVisible):
  69667. (WebCore::Widget::isPluginView):
  69668. (WebCore::Widget::parent):
  69669. (WebCore::Widget::handleEvent):
  69670. (WebCore::Widget::geometryChanged):
  69671. * platform/gtk/WidgetGtk.cpp:
  69672. (WebCore::Widget::Widget):
  69673. * platform/mac/ScrollViewMac.mm:
  69674. (WebCore::ScrollView::addChild):
  69675. (WebCore::ScrollView::removeChild):
  69676. * platform/mac/ScrollbarMac.mm:
  69677. (WebCore::ScrollbarMac::~ScrollbarMac):
  69678. * platform/mac/WidgetMac.mm:
  69679. (WebCore::Widget::Widget):
  69680. (WebCore::Widget::~Widget):
  69681. * platform/qt/WidgetQt.cpp:
  69682. (WebCore::WidgetPrivate::WidgetPrivate):
  69683. (WebCore::Widget::Widget):
  69684. (WebCore::Widget::topLevel):
  69685. * platform/win/ScrollViewWin.cpp:
  69686. (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
  69687. (WebCore::ScrollView::setAncestorVisible):
  69688. (WebCore::ScrollView::show):
  69689. (WebCore::ScrollView::hide):
  69690. * platform/win/WidgetWin.cpp:
  69691. (WebCore::Widget::Widget):
  69692. (WebCore::Widget::setParent):
  69693. * platform/wx/WidgetWx.cpp:
  69694. (WebCore::Widget::Widget):
  69695. * plugins/PluginView.cpp:
  69696. (WebCore::PluginView::PluginView):
  69697. * plugins/PluginView.h:
  69698. * plugins/gtk/PluginViewGtk.cpp:
  69699. (WebCore::PluginView::show):
  69700. (WebCore::PluginView::hide):
  69701. (WebCore::PluginView::setParentVisible):
  69702. * plugins/qt/PluginViewQt.cpp:
  69703. (WebCore::PluginView::show):
  69704. (WebCore::PluginView::hide):
  69705. (WebCore::PluginView::setParentVisible):
  69706. * plugins/win/PluginViewWin.cpp:
  69707. (WebCore::PluginView::show):
  69708. (WebCore::PluginView::hide):
  69709. (WebCore::PluginView::setParentVisible):
  69710. 2008-09-17 Alexey Proskuryakov <ap@webkit.org>
  69711. Reviewed by Adam Roben.
  69712. <rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
  69713. * platform/text/TextCodecICU.cpp:
  69714. (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
  69715. 2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
  69716. Fix the QtWebKit/Mac build
  69717. * platform/qt/ScrollViewQt.cpp: add include
  69718. 2008-09-17 David Hyatt <hyatt@apple.com>
  69719. Add a #define to control whether or not to use an NSScroller on Mac.
  69720. This ifdef will allow the new NSView-less NSScroller on Mac to be
  69721. developed side by side with the current one.
  69722. The new scroller paints a debug red if turned on (although due to
  69723. Widget issues you won't see anything paint yet).
  69724. Reviewed by olliej
  69725. * platform/Scrollbar.cpp:
  69726. * platform/Scrollbar.h:
  69727. * platform/mac/ScrollbarMac.h:
  69728. * platform/mac/ScrollbarMac.mm:
  69729. * platform/mac/ScrollbarThemeMac.cpp:
  69730. (WebCore::ScrollbarThemeMac::paint):
  69731. * platform/mac/ScrollbarThemeMac.h:
  69732. 2008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
  69733. Reviewed by Alp Toker.
  69734. http://bugs.webkit.org/show_bug.cgi?id=20854
  69735. [GTK] Windows can be not realized in ScrollView::update
  69736. Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
  69737. * platform/gtk/ScrollViewGtk.cpp:
  69738. (WebCore::ScrollView::update):
  69739. 2008-09-16 Alp Toker <alp@nuanti.com>
  69740. Suggested by Dave Hyatt.
  69741. Build fix and cleanup. Rename ScrollBar to Scrollbar.
  69742. * GNUmakefile.am:
  69743. * WebCore.pro:
  69744. * WebCore.vcproj/WebCore.vcproj:
  69745. * WebCore.xcodeproj/project.pbxproj:
  69746. * WebCoreSources.bkl:
  69747. * editing/EditorCommand.cpp:
  69748. * page/EventHandler.cpp:
  69749. * page/gtk/EventHandlerGtk.cpp:
  69750. * page/mac/EventHandlerMac.mm:
  69751. * page/mac/FrameMac.mm:
  69752. * page/qt/EventHandlerQt.cpp:
  69753. * page/wx/EventHandlerWx.cpp:
  69754. * platform/PopupMenu.h:
  69755. * platform/ScrollBar.cpp: Removed.
  69756. * platform/ScrollBar.h: Removed.
  69757. * platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
  69758. * platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
  69759. * platform/gtk/ScrollbarGtk.cpp:
  69760. (ScrollbarGtk::ScrollbarGtk):
  69761. * platform/gtk/ScrollbarGtk.h:
  69762. * platform/mac/ScrollbarMac.h:
  69763. * platform/qt/ScrollViewQt.cpp:
  69764. * platform/qt/ScrollbarQt.cpp:
  69765. * platform/qt/ScrollbarThemeQt.cpp:
  69766. * platform/win/PlatformScrollBar.h:
  69767. * platform/win/PopupMenuWin.cpp:
  69768. * platform/win/ScrollViewWin.cpp:
  69769. * platform/win/ScrollbarThemeWin.cpp:
  69770. * platform/wx/ScrollViewWx.cpp:
  69771. * platform/wx/TemporaryLinkStubs.cpp:
  69772. * rendering/HitTestResult.cpp:
  69773. * rendering/RenderLayer.cpp:
  69774. * rendering/RenderTextControl.cpp:
  69775. 2008-09-16 David Hyatt <hyatt@apple.com>
  69776. Fix Qt build bustage by making moveThumb a member of Scrollbar so that
  69777. it can be called from ScrollbarQt.
  69778. * platform/ScrollBar.cpp:
  69779. (WebCore::Scrollbar::moveThumb):
  69780. (WebCore::Scrollbar::handleMouseMoveEvent):
  69781. (WebCore::Scrollbar::handleMousePressEvent):
  69782. * platform/ScrollBar.h:
  69783. * platform/qt/ScrollViewQt.cpp:
  69784. * platform/qt/ScrollbarQt.cpp:
  69785. (WebCore::Scrollbar::handleContextMenuEvent):
  69786. 2008-09-16 David Hyatt <hyatt@apple.com>
  69787. Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
  69788. native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
  69789. now just use Scrollbar.
  69790. Reviewed by Sam Weinig
  69791. * GNUmakefile.am:
  69792. * WebCore.pro:
  69793. * WebCore.vcproj/WebCore.vcproj:
  69794. * WebCore.xcodeproj/project.pbxproj:
  69795. * page/mac/FrameMac.mm:
  69796. * platform/PopupMenu.h:
  69797. (WebCore::PopupMenu::scrollbar):
  69798. * platform/ScrollBar.cpp:
  69799. (WebCore::createNativeScrollbar):
  69800. * platform/ScrollBar.h:
  69801. * platform/gtk/PlatformScrollBar.h: Removed.
  69802. * platform/gtk/PlatformScrollBarGtk.cpp: Removed.
  69803. * platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
  69804. (gtkScrollEventCallback):
  69805. (ScrollbarGtk::ScrollbarGtk):
  69806. (ScrollbarGtk::~ScrollbarGtk):
  69807. (ScrollbarGtk::updateThumbPosition):
  69808. (ScrollbarGtk::updateThumbProportion):
  69809. (ScrollbarGtk::setFrameGeometry):
  69810. (ScrollbarGtk::geometryChanged):
  69811. (ScrollbarGtk::gtkValueChanged):
  69812. * platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
  69813. * platform/mac/PlatformScrollBar.h: Removed.
  69814. * platform/mac/PlatformScrollBarMac.mm: Removed.
  69815. * platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
  69816. * platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
  69817. (-[WebCoreScrollBar initWithScrollbarMac:]):
  69818. (-[WebCoreScrollBar detachScrollbarMac]):
  69819. (WebCore::Scrollbar::createNativeScrollbar):
  69820. (WebCore::ScrollbarMac::ScrollbarMac):
  69821. (WebCore::ScrollbarMac::~ScrollbarMac):
  69822. (WebCore::ScrollbarMac::updateThumbPosition):
  69823. (WebCore::ScrollbarMac::updateThumbProportion):
  69824. (WebCore::ScrollbarMac::scrollbarHit):
  69825. * platform/qt/PlatformScrollBar.h: Removed.
  69826. * platform/qt/PlatformScrollBarQt.cpp: Removed.
  69827. * platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
  69828. (WebCore::Scrollbar::handleContextMenuEvent):
  69829. * rendering/HitTestResult.cpp:
  69830. * rendering/RenderLayer.cpp:
  69831. (WebCore::RenderLayer::createScrollbar):
  69832. (WebCore::RenderLayer::destroyScrollbar):
  69833. * rendering/RenderLayer.h:
  69834. * rendering/RenderListBox.cpp:
  69835. (WebCore::RenderListBox::~RenderListBox):
  69836. (WebCore::RenderListBox::updateFromElement):
  69837. (WebCore::RenderListBox::isPointInOverflowControl):
  69838. * rendering/RenderObject.h:
  69839. * rendering/RenderTextControl.cpp:
  69840. 2008-09-16 David Hyatt <hyatt@apple.com>
  69841. Make the scrollbar resizer-dodging logic cross-platform in the
  69842. Scrollbar class.
  69843. Reviewed by Sam Weinig
  69844. * platform/ScrollBar.cpp:
  69845. (WebCore::Scrollbar::setFrameGeometry):
  69846. (WebCore::Scrollbar::setParent):
  69847. (WebCore::Scrollbar::windowClipRect):
  69848. * platform/ScrollBar.h:
  69849. * platform/ScrollView.h:
  69850. (WebCore::ScrollView::windowResizerRect):
  69851. (WebCore::ScrollView::resizerOverlapsContent):
  69852. (WebCore::ScrollView::adjustOverlappingScrollbarCount):
  69853. * platform/Widget.h:
  69854. (WebCore::Widget::setParent):
  69855. * platform/mac/WidgetMac.mm:
  69856. (WebCore::Widget::convertToContainingWindow):
  69857. * platform/win/PlatformScrollBar.h:
  69858. * platform/win/PlatformScrollBarWin.cpp:
  69859. 2008-09-16 Dan Bernstein <mitz@apple.com>
  69860. Reviewed by Darin Adler.
  69861. - fix https://bugs.webkit.org/show_bug.cgi?id=15129
  69862. <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
  69863. Covered by fast/repaint/4776765.html
  69864. * rendering/RenderBlock.cpp:
  69865. (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
  69866. did not have layout in the beginning.
  69867. (WebCore::RenderBlock::layoutBlockChildren): If a child did not have
  69868. layout in the beginning, repaint it in its new position, to compensate
  69869. for the above (regardless of whether it "moved").
  69870. * rendering/RenderObject.cpp:
  69871. (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
  69872. about generalizing this fix in the future.
  69873. 2008-09-16 Dan Bernstein <mitz@apple.com>
  69874. Reviewed by Dave Hyatt.
  69875. - fix https://bugs.webkit.org/show_bug.cgi?id=15384
  69876. Div does not notice when grandparent changes height
  69877. Test: fast/block/basic/quirk-percent-height-grandchild.html
  69878. - fix https://bugs.webkit.org/show_bug.cgi?id=20714
  69879. Resizing Gmail inbox vertically results in whitespace at the bottom of the window
  69880. Test: fast/replaced/percent-height-in-anonymous-block.html
  69881. Added a two-way mapping between boxes with percentage heights and
  69882. their non-parent ancestors up to the one the height is computed relative
  69883. to. In quirks mode (the first bug), this can be any number of containing
  69884. block with auto height. In strict mode (the second bug) this can be
  69885. the containing block of an anonymous block containing a replaced
  69886. element.
  69887. * rendering/RenderBlock.cpp:
  69888. (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
  69889. mapping to/from this block to percentage-height descendants.
  69890. (WebCore::RenderBlock::layoutBlockChildren): Added code to mark
  69891. percentage-height descendants (and their containing block ancestry chain
  69892. up to this block) for layout. This ensures that those descendants whose
  69893. height depends on the height of this block (or an ancestor) are updated.
  69894. (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
  69895. a two-way mapping between this block and the given box.
  69896. (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
  69897. all the mapping to/from this box.
  69898. * rendering/RenderBlock.h:
  69899. * rendering/RenderBox.cpp:
  69900. (WebCore::RenderBox::setStyle): Added calls to
  69901. removePercentHeightDescendant() when style changes and the box
  69902. previously had a percentage height. An exception is when the style
  69903. change does not require layout, in which case the box still has
  69904. a percentage height and the mappings are valid. In all other cases,
  69905. any required mappings will be (re-)established during layout.
  69906. (WebCore::RenderBox::destroy): Added a call to
  69907. removePercentHeightDescendant.
  69908. (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
  69909. mode, if a higher-than-parent containing block is affecting the box's
  69910. height, creates a mapping between the box and that block.
  69911. (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
  69912. anonymous containing blocks, if any, and when that happens, use
  69913. addPercentHeightDescendant() to ensure that the non-anonymous block
  69914. is aware of the dependent percent-height box.
  69915. 2008-09-16 Dirk Schulze <vbs85@gmx.de>
  69916. Reviewed by Oliver Hunt and Alp Toker.
  69917. Implemented toDataURL in Cairo. Only PNG support
  69918. at the moment.
  69919. Qt, Cairo and wx require toDataURL implementations
  69920. https://bugs.webkit.org/show_bug.cgi?id=17719
  69921. * platform/MIMETypeRegistry.cpp:
  69922. (WebCore::initializeSupportedImageMIMETypesForEncoding):
  69923. * platform/graphics/cairo/ImageBufferCairo.cpp:
  69924. (WebCore::ImageBuffer::ImageBuffer):
  69925. (WebCore::writeFunction):
  69926. (WebCore::ImageBuffer::toDataURL):
  69927. 2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
  69928. Reviewed by Simon.
  69929. Hide unused media element controls in the QtWebKit port
  69930. * platform/qt/html4-adjustments-qt.css
  69931. 2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
  69932. Reviewed by Simon.
  69933. Fix compilation of the Qt scrollbar code.
  69934. * platform/qt/PlatformScrollBarQt.cpp:
  69935. (WebCore::scPart):
  69936. (WebCore::styleOptionSlider):
  69937. (WebCore::thumbLength):
  69938. (WebCore::pixelPosToRangeValue):
  69939. (WebCore::PlatformScrollbar::handleContextMenuEvent):
  69940. 2008-09-16 Adam Treat <treat@kde.org>
  69941. Reviewed by Anders Carlsson.
  69942. Prevent accesses off of the end of the buffer introduced in r36450
  69943. and when checking for descriptions of mime. Also, coding style fix.
  69944. * plugins/qt/PluginPackageQt.cpp:
  69945. (WebCore::PluginPackage::fetchInfo):
  69946. 2008-09-15 Rob Buis <buis@kde.org>
  69947. Reviewed by Eric.
  69948. https://bugs.webkit.org/show_bug.cgi?id=20634
  69949. SVG transform attribute is ignored by <use> in <clipPath>
  69950. Transform the paths with the local transform when part
  69951. of a clip path.
  69952. Test: svg/custom/use-clipped-transform.svg
  69953. * svg/SVGClipPathElement.cpp:
  69954. (WebCore::SVGClipPathElement::canvasResource):
  69955. * svg/SVGStyledTransformableElement.cpp:
  69956. (WebCore::SVGStyledTransformableElement::toClipPath):
  69957. * svg/SVGStyledTransformableElement.h:
  69958. 2008-09-15 Dave Hyatt <hyatt@apple.com>
  69959. Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
  69960. to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
  69961. Reviewed by Sam Weinig
  69962. * platform/ScrollBar.cpp:
  69963. (WebCore::thumbUnderMouse):
  69964. (WebCore::Scrollbar::autoscrollPressedPart):
  69965. (WebCore::Scrollbar::startTimerIfNeeded):
  69966. (WebCore::moveThumb):
  69967. (WebCore::Scrollbar::handleMouseMoveEvent):
  69968. (WebCore::Scrollbar::handleMousePressEvent):
  69969. * platform/ScrollBar.h:
  69970. (WebCore::Scrollbar::pressedPos):
  69971. (WebCore::Scrollbar::pixelStep):
  69972. (WebCore::Scrollbar::setPressedPos):
  69973. * platform/ScrollbarTheme.h:
  69974. (WebCore::ScrollbarTheme::thumbPosition):
  69975. (WebCore::ScrollbarTheme::thumbLength):
  69976. (WebCore::ScrollbarTheme::trackPosition):
  69977. (WebCore::ScrollbarTheme::trackLength):
  69978. * platform/ScrollbarThemeComposite.cpp:
  69979. (WebCore::ScrollbarThemeComposite::trackPosition):
  69980. * platform/ScrollbarThemeComposite.h:
  69981. * platform/qt/PlatformScrollBarQt.cpp:
  69982. (WebCore::PlatformScrollbar::PlatformScrollbar):
  69983. (WebCore::):
  69984. * platform/qt/ScrollbarThemeQt.cpp:
  69985. (WebCore::styleOptionSlider):
  69986. (WebCore::ScrollbarThemeQt::hitTest):
  69987. (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
  69988. (WebCore::ScrollbarThemeQt::invalidatePart):
  69989. (WebCore::ScrollbarThemeQt::thumbPosition):
  69990. (WebCore::):
  69991. * platform/qt/ScrollbarThemeQt.h:
  69992. * platform/win/ScrollbarThemeSafari.cpp:
  69993. (WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
  69994. * platform/win/ScrollbarThemeSafari.h:
  69995. * platform/win/ScrollbarThemeWin.cpp:
  69996. (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
  69997. * platform/win/ScrollbarThemeWin.h:
  69998. 2008-09-15 David Smith <catfish.man@gmail.com>
  69999. Reviewed by Sam Weinig.
  70000. https://bugs.webkit.org/show_bug.cgi?id=20180
  70001. Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
  70002. * GNUmakefile.am: Add CSSNthSelector
  70003. * WebCore.pro: Add CSSNthSelector
  70004. * WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
  70005. * WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
  70006. * css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
  70007. * css/CSSNthSelector.cpp: Added.
  70008. (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
  70009. (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
  70010. * css/CSSNthSelector.h: Added.
  70011. (WebCore::CSSNthSelector::CSSNthSelector):
  70012. (WebCore::CSSNthSelector::~CSSNthSelector):
  70013. * css/CSSParser.cpp:
  70014. (WebCore::CSSParser::createFloatingNthSelector):
  70015. * css/CSSParser.h:
  70016. * css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
  70017. (WebCore::CSSSelector::CSSSelector):
  70018. * css/CSSStyleSelector.cpp:
  70019. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
  70020. 2008-09-15 Matt Lilek <webkit@mattlilek.com>
  70021. Reviewed by Tim Hatcher.
  70022. Clean up some inspector JS callbacks to remove an extra return.
  70023. * page/InspectorController.cpp:
  70024. (WebCore::hideDOMNodeHighlight):
  70025. (WebCore::loaded):
  70026. (WebCore::unloading):
  70027. (WebCore::attach):
  70028. (WebCore::detach):
  70029. (WebCore::startDebuggingAndReloadInspectedPage):
  70030. (WebCore::stopDebugging):
  70031. (WebCore::debuggerAttached):
  70032. (WebCore::pauseOnExceptions):
  70033. (WebCore::pauseInDebugger):
  70034. (WebCore::resumeDebugger):
  70035. (WebCore::stepOverStatementInDebugger):
  70036. (WebCore::stepIntoStatementInDebugger):
  70037. (WebCore::stepOutOfFunctionInDebugger):
  70038. (WebCore::isWindowVisible):
  70039. (WebCore::closeWindow):
  70040. 2008-09-15 Dave Hyatt <hyatt@apple.com>
  70041. Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
  70042. now share most of their code.
  70043. Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
  70044. also is never used in our code anyway.
  70045. Reviewed by Sam Weinig
  70046. * WebCore.vcproj/WebCore.vcproj:
  70047. * platform/ScrollTypes.h:
  70048. (WebCore::):
  70049. * platform/ScrollbarThemeComposite.cpp:
  70050. (WebCore::ScrollbarThemeComposite::splitTrack):
  70051. (WebCore::ScrollbarThemeComposite::thumbLength):
  70052. (WebCore::ScrollbarThemeComposite::minimumThumbLength):
  70053. * platform/ScrollbarThemeComposite.h:
  70054. * platform/mac/PlatformScrollBarMac.mm:
  70055. (NSControlSizeForScrollBarControlSize):
  70056. * platform/win/PlatformScrollBar.h:
  70057. * platform/win/PlatformScrollBarSafari.cpp: Removed.
  70058. * platform/win/PlatformScrollBarWin.cpp:
  70059. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70060. * platform/win/ScrollbarThemeSafari.cpp:
  70061. (WebCore::ScrollbarTheme::nativeTheme):
  70062. (WebCore::):
  70063. (WebCore::scrollbarControlStateFromThemeState):
  70064. (WebCore::ScrollbarThemeSafari::hasButtons):
  70065. (WebCore::ScrollbarThemeSafari::hasThumb):
  70066. (WebCore::buttonRepaintRect):
  70067. (WebCore::ScrollbarThemeSafari::backButtonRect):
  70068. (WebCore::ScrollbarThemeSafari::forwardButtonRect):
  70069. (WebCore::trackRepaintRect):
  70070. (WebCore::ScrollbarThemeSafari::trackRect):
  70071. (WebCore::ScrollbarThemeSafari::minimumThumbLength):
  70072. (WebCore::ScrollbarThemeSafari::paintTrack):
  70073. (WebCore::ScrollbarThemeSafari::paintButton):
  70074. (WebCore::ScrollbarThemeSafari::paintThumb):
  70075. * platform/win/ScrollbarThemeSafari.h:
  70076. * platform/win/ScrollbarThemeWin.cpp:
  70077. * platform/win/ScrollbarThemeWin.h:
  70078. 2008-09-15 Chris Fleizach <cfleizach@apple.com>
  70079. Reviewed by Darin Adler, Beth Dakin
  70080. <rdar://problem/4003789> Expose lists as AXList
  70081. <rdar://problem/5707399> VO: Definition lists not announced in Safari
  70082. Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
  70083. AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
  70084. Inside the definition list, each <dt> "term" has an accessibility description ("term"),
  70085. as does each <dd> tag ("definition")
  70086. Test: accessibility/lists.html
  70087. * GNUmakefile.am:
  70088. * WebCore.pro:
  70089. * WebCore.vcproj/WebCore.vcproj:
  70090. * WebCore.xcodeproj/project.pbxproj:
  70091. * WebCoreSources.bkl:
  70092. * page/AXObjectCache.cpp:
  70093. * page/AccessibilityList.cpp: Added.
  70094. * page/AccessibilityList.h: Added.
  70095. * page/AccessibilityObject.h:
  70096. * page/AccessibilityRenderObject.cpp:
  70097. * page/AccessibilityTable.cpp:
  70098. * page/mac/AccessibilityObjectWrapper.mm:
  70099. * page/mac/WebCoreViewFactory.h:
  70100. * platform/LocalizedStrings.h:
  70101. * platform/mac/LocalizedStringsMac.mm:
  70102. * platform/qt/Localizations.cpp:
  70103. 2008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
  70104. Reviewed by Eric.
  70105. Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
  70106. Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
  70107. Several renames:
  70108. dispatchHTMLEvent -> dispatchEventForType
  70109. setHTMLEventListener -> setEventListenerForType
  70110. getHTMLEventListener -> eventListenerForType
  70111. removeHTMLEventListener -> removeEventListenerForType
  70112. isHTMLEventListener -> isAttachedToEventTargetNode
  70113. ...
  70114. Similar renames for the dispatch/get/set/*Window*Event functions.
  70115. Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
  70116. Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
  70117. as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
  70118. setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
  70119. SVG is able to use the code as well now. This affects most files in html/.
  70120. No functional changes.
  70121. * GNUmakefile.am:
  70122. * WebCore.pro:
  70123. * WebCore.vcproj/WebCore.vcproj:
  70124. * WebCore.xcodeproj/project.pbxproj:
  70125. * bindings/js/JSDOMWindowBase.cpp:
  70126. (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  70127. (WebCore::JSDOMWindowBase::setListener):
  70128. (WebCore::JSDOMWindowBase::getListener):
  70129. (WebCore::JSDOMWindowBase::findJSEventListener):
  70130. (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
  70131. (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
  70132. (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
  70133. (WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
  70134. (WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
  70135. * bindings/js/JSDOMWindowBase.h:
  70136. * bindings/js/JSEventListener.cpp:
  70137. (WebCore::JSAbstractEventListener::handleEvent):
  70138. (WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
  70139. (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
  70140. (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
  70141. (WebCore::JSEventListener::JSEventListener):
  70142. (WebCore::JSEventListener::~JSEventListener):
  70143. (WebCore::JSLazyEventListener::JSLazyEventListener):
  70144. (WebCore::eventParameterName):
  70145. (WebCore::JSLazyEventListener::parseCode):
  70146. (WebCore::getNodeEventListener):
  70147. * bindings/js/JSEventListener.h:
  70148. (WebCore::JSAbstractEventListener::JSAbstractEventListener):
  70149. (WebCore::JSUnprotectedEventListener::create):
  70150. (WebCore::JSEventListener::create):
  70151. (WebCore::JSLazyEventListener::):
  70152. (WebCore::JSLazyEventListener::create):
  70153. * bindings/js/JSEventTargetNode.cpp:
  70154. (WebCore::JSEventTargetNode::setListener):
  70155. (WebCore::JSEventTargetNode::getListener):
  70156. * bindings/js/JSSVGLazyEventListener.cpp: Removed.
  70157. * bindings/js/JSSVGLazyEventListener.h: Removed.
  70158. * bindings/js/ScriptController.cpp:
  70159. (WebCore::ScriptController::createHTMLEventHandler):
  70160. (WebCore::ScriptController::createSVGEventHandler):
  70161. * dom/Document.cpp:
  70162. (WebCore::Document::setFocusedNode):
  70163. (WebCore::Document::handleWindowEvent):
  70164. (WebCore::Document::setWindowEventListenerForType):
  70165. (WebCore::Document::windowEventListenerForType):
  70166. (WebCore::Document::removeWindowEventListenerForType):
  70167. (WebCore::Document::addWindowEventListener):
  70168. (WebCore::Document::hasWindowEventListener):
  70169. (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
  70170. (WebCore::Document::createEventListener):
  70171. (WebCore::Document::setWindowEventListenerForTypeAndAttribute):
  70172. * dom/Document.h:
  70173. * dom/EventListener.h:
  70174. (WebCore::EventListener::isAttachedToEventTargetNode):
  70175. * dom/EventTargetNode.cpp:
  70176. (WebCore::EventTargetNode::dispatchFocusEvent):
  70177. (WebCore::EventTargetNode::dispatchBlurEvent):
  70178. (WebCore::EventTargetNode::dispatchEventForType):
  70179. (WebCore::EventTargetNode::removeEventListenerForType):
  70180. (WebCore::EventTargetNode::setEventListenerForType):
  70181. (WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
  70182. (WebCore::EventTargetNode::eventListenerForType):
  70183. * dom/EventTargetNode.h:
  70184. * dom/XMLTokenizer.cpp:
  70185. (WebCore::XMLTokenizer::notifyFinished):
  70186. * editing/ReplaceSelectionCommand.cpp:
  70187. (WebCore::ReplacementFragment::ReplacementFragment):
  70188. * html/HTMLBodyElement.cpp:
  70189. (WebCore::HTMLBodyElement::parseMappedAttribute):
  70190. * html/HTMLButtonElement.cpp:
  70191. (WebCore::HTMLButtonElement::parseMappedAttribute):
  70192. * html/HTMLElement.cpp:
  70193. (WebCore::HTMLElement::parseMappedAttribute):
  70194. (WebCore::HTMLElement::checkDTD):
  70195. * html/HTMLElement.h:
  70196. * html/HTMLFormControlElement.cpp:
  70197. (WebCore::HTMLFormControlElement::onChange):
  70198. * html/HTMLFormElement.cpp:
  70199. (WebCore::HTMLFormElement::prepareSubmit):
  70200. (WebCore::HTMLFormElement::reset):
  70201. (WebCore::HTMLFormElement::parseMappedAttribute):
  70202. * html/HTMLFrameElementBase.cpp:
  70203. (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  70204. * html/HTMLFrameSetElement.cpp:
  70205. (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  70206. * html/HTMLImageElement.cpp:
  70207. (WebCore::HTMLImageElement::parseMappedAttribute):
  70208. * html/HTMLImageLoader.cpp:
  70209. (WebCore::HTMLImageLoader::dispatchLoadEvent):
  70210. * html/HTMLInputElement.cpp:
  70211. (WebCore::HTMLInputElement::parseMappedAttribute):
  70212. (WebCore::HTMLInputElement::setValueFromRenderer):
  70213. (WebCore::HTMLInputElement::onSearch):
  70214. * html/HTMLMediaElement.cpp:
  70215. (WebCore::HTMLMediaElement::asyncEventTimerFired):
  70216. (WebCore::HTMLMediaElement::load):
  70217. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
  70218. (WebCore::HTMLMediaElement::setReadyState):
  70219. (WebCore::HTMLMediaElement::seek):
  70220. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
  70221. (WebCore::HTMLMediaElement::willSaveToCache):
  70222. * html/HTMLObjectElement.cpp:
  70223. (WebCore::HTMLObjectElement::parseMappedAttribute):
  70224. * html/HTMLScriptElement.cpp:
  70225. (WebCore::HTMLScriptElement::parseMappedAttribute):
  70226. (WebCore::HTMLScriptElement::dispatchLoadEvent):
  70227. (WebCore::HTMLScriptElement::dispatchErrorEvent):
  70228. * html/HTMLSelectElement.cpp:
  70229. (WebCore::HTMLSelectElement::parseMappedAttribute):
  70230. * html/HTMLTextAreaElement.cpp:
  70231. (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  70232. * html/HTMLTokenizer.cpp:
  70233. (WebCore::HTMLTokenizer::notifyFinished):
  70234. * page/AccessibilityRenderObject.cpp:
  70235. (WebCore::AccessibilityRenderObject::mouseButtonListener):
  70236. * page/EventHandler.cpp:
  70237. (WebCore::EventHandler::canMouseDownStartSelect):
  70238. (WebCore::EventHandler::canMouseDragExtendSelect):
  70239. * page/Frame.cpp:
  70240. (WebCore::Frame::sendScrollEvent):
  70241. * page/Page.cpp:
  70242. (WebCore::networkStateChanged):
  70243. * rendering/RenderListBox.cpp:
  70244. (WebCore::RenderListBox::valueChanged):
  70245. * rendering/RenderTextControl.cpp:
  70246. (WebCore::RenderTextControl::selectionChanged):
  70247. * svg/SVGDocumentExtensions.cpp:
  70248. * svg/SVGDocumentExtensions.h:
  70249. * svg/SVGElement.cpp:
  70250. (WebCore::SVGElement::parseMappedAttribute):
  70251. (WebCore::SVGElement::finishParsingChildren):
  70252. * svg/SVGElement.h:
  70253. * svg/SVGSVGElement.cpp:
  70254. (WebCore::SVGSVGElement::parseMappedAttribute):
  70255. * svg/SVGSVGElement.h:
  70256. 2008-09-15 Dave Hyatt <hyatt@apple.com>
  70257. Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
  70258. need to be converted.
  70259. Reviewed by Sam Weinig
  70260. * platform/ScrollBar.cpp:
  70261. (WebCore::Scrollbar::Scrollbar):
  70262. (WebCore::Scrollbar::updateThumbPosition):
  70263. (WebCore::Scrollbar::updateThumbProportion):
  70264. (WebCore::Scrollbar::autoscrollPressedPart):
  70265. (WebCore::Scrollbar::startTimerIfNeeded):
  70266. * platform/ScrollBar.h:
  70267. * platform/ScrollbarTheme.h:
  70268. (WebCore::ScrollbarTheme::invalidateParts):
  70269. * platform/ScrollbarThemeComposite.cpp:
  70270. (WebCore::ScrollbarThemeComposite::hitTest):
  70271. (WebCore::ScrollbarThemeComposite::invalidatePart):
  70272. (WebCore::ScrollbarThemeComposite::thumbPosition):
  70273. (WebCore::ScrollbarThemeComposite::thumbLength):
  70274. (WebCore::ScrollbarThemeComposite::trackLength):
  70275. * platform/ScrollbarThemeComposite.h:
  70276. * platform/win/PlatformScrollBarSafari.cpp:
  70277. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70278. * platform/win/PlatformScrollBarWin.cpp:
  70279. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70280. 2008-09-15 David Smith <catfish.man@gmail.com>
  70281. "Just do it"'d by Mark Rowe
  70282. https://bugs.webkit.org/show_bug.cgi?id=20856
  70283. Add missing license header
  70284. * dom/NodeRenderStyle.h:
  70285. 2008-09-15 Dean Jackson <dino@apple.com>
  70286. Reviewed by Tim Hatcher.
  70287. Add default constructor for ShadowData
  70288. https://bugs.webkit.org/show_bug.cgi?id=20757
  70289. Test: transitions/shadow.html
  70290. * rendering/style/RenderStyle.h:
  70291. 2008-09-15 Dean Jackson <dino@apple.com>
  70292. Reviewed by Tim Hatcher.
  70293. RenderStyle should update keyframes.
  70294. http://bugs.webkit.org/show_bug.cgi?id=20756
  70295. * rendering/style/RenderStyle.cpp:
  70296. (WebCore::StyleRareNonInheritedData::updateKeyframes):
  70297. 2008-09-15 Dean Jackson <dino@apple.com>
  70298. Reviewed by Tim Hatcher.
  70299. Unnecessary ASSERT in ImplicitAnimation destructor.
  70300. https://bugs.webkit.org/show_bug.cgi?id=20817
  70301. * page/animation/ImplicitAnimation.cpp:
  70302. (WebCore::ImplicitAnimation::~ImplicitAnimation):
  70303. 2008-09-15 Adam Treat <treat@kde.org>
  70304. Reviewed by Simon.
  70305. Fix plugin extension info. It was returning the mimetype where the
  70306. extension was given.
  70307. * plugins/qt/PluginPackageQt.cpp:
  70308. (WebCore::PluginPackage::fetchInfo):
  70309. 2008-09-15 Dean Jackson <dino@apple.com>
  70310. Reviewed by Tim Hatcher
  70311. Coding style violation!!!! Cleanup AnimationBase.cpp
  70312. * page/animation/AnimationBase.cpp:
  70313. (WebCore::blendFunc):
  70314. 2008-09-15 David Hyatt <hyatt@apple.com>
  70315. Move all hit testing code for scrollbars into the base class. Refactor
  70316. it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
  70317. functions.
  70318. No platform is using this code yet. Although it has been moved and compiles
  70319. (even on Mac), it is not being used on any platform.
  70320. Reviewed by Sam Weinig
  70321. * platform/ScrollBar.cpp:
  70322. (WebCore::Scrollbar::autoscrollPressedPart):
  70323. (WebCore::Scrollbar::startTimerIfNeeded):
  70324. (WebCore::Scrollbar::handleMouseMoveEvent):
  70325. (WebCore::Scrollbar::handleMouseOutEvent):
  70326. (WebCore::Scrollbar::handleMouseReleaseEvent):
  70327. (WebCore::Scrollbar::handleMousePressEvent):
  70328. * platform/ScrollBar.h:
  70329. (WebCore::Scrollbar::handleContextMenuEvent):
  70330. * platform/ScrollbarTheme.h:
  70331. (WebCore::ScrollbarTheme::hitTest):
  70332. (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
  70333. (WebCore::ScrollbarTheme::invalidatePart):
  70334. (WebCore::ScrollbarTheme::shouldCenterOnThumb):
  70335. (WebCore::ScrollbarTheme::centerOnThumb):
  70336. (WebCore::ScrollbarTheme::thumbPosition):
  70337. (WebCore::ScrollbarTheme::thumbLength):
  70338. (WebCore::ScrollbarTheme::trackLength):
  70339. (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
  70340. (WebCore::ScrollbarTheme::autoscrollTimerDelay):
  70341. * platform/Widget.h:
  70342. (WebCore::Widget::parent):
  70343. * platform/mac/PlatformScrollBar.h:
  70344. (WebCore::PlatformScrollbar::handleMouseMoveEvent):
  70345. (WebCore::PlatformScrollbar::handleMouseOutEvent):
  70346. (WebCore::PlatformScrollbar::handleMousePressEvent):
  70347. (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
  70348. * platform/mac/WidgetMac.mm:
  70349. (WebCore::Widget::convertFromContainingWindow):
  70350. * platform/win/ScrollbarThemeWin.cpp:
  70351. (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
  70352. * platform/win/ScrollbarThemeWin.h:
  70353. 2008-09-15 Dan Bernstein <mitz@apple.com>
  70354. Reviewed by Sam Weinig.
  70355. - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
  70356. Cache the next breakable position for text nodes in InlineIterator.
  70357. * rendering/bidi.cpp:
  70358. (WebCore::InlineIterator::InlineIterator):
  70359. (WebCore::InlineIterator::increment):
  70360. (WebCore::RenderBlock::findNextLineBreak):
  70361. 2008-09-15 Simon Fraser <simon.fraser@apple.com>
  70362. Reviewed by Dan Bernstein
  70363. Fix assertion and integral pixel issue when creating subimages.
  70364. https://bugs.webkit.org/show_bug.cgi?id=20786
  70365. * platform/graphics/cg/ImageCG.cpp:
  70366. (WebCore::BitmapImage::draw):
  70367. 2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
  70368. Reviewed by Simon.
  70369. Implment seek() and clean up and improve debugging output
  70370. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  70371. (debugMediaObject):
  70372. (WebCore::MediaPlayerPrivate::seek):
  70373. (WebCore::MediaPlayerPrivate::setVolume):
  70374. (WebCore::MediaPlayerPrivate::setMuted):
  70375. (WebCore::MediaPlayerPrivate::updateStates):
  70376. (WebCore::MediaPlayerPrivate::naturalSize):
  70377. (WebCore::MediaPlayerPrivate::paint):
  70378. (WebCore::MediaPlayerPrivate::stateChanged):
  70379. (WebCore::MediaPlayerPrivate::tick):
  70380. 2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
  70381. Reviewed by Simon.
  70382. Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
  70383. m_mediaObject, m_audioOutput, m_videoWidget get created in the
  70384. c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
  70385. only check if we use the MediaPlayerPrivate after it has been deleted.
  70386. Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
  70387. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  70388. (WebCore::MediaPlayerPrivate::play):
  70389. (WebCore::MediaPlayerPrivate::setVolume):
  70390. (WebCore::MediaPlayerPrivate::updateStates):
  70391. 2008-09-15 Anders Carlsson <andersca@apple.com>
  70392. Reviewed by Maciej.
  70393. <rdar://problem/6163988>
  70394. https://bugs.webkit.org/show_bug.cgi?id=20457
  70395. Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
  70396. Check the width and height and throw an exception if any of them are 0.
  70397. * html/CanvasRenderingContext2D.cpp:
  70398. (WebCore::CanvasRenderingContext2D::createPattern):
  70399. 2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
  70400. Reviewed by Simon.
  70401. Render media element controls with antialiasing enabled
  70402. * platform/qt/RenderThemeQt.cpp:
  70403. (WebCore::RenderThemeQt::paintMediaMuteButton):
  70404. (WebCore::RenderThemeQt::paintMediaPlayButton):
  70405. (WebCore::RenderThemeQt::paintMediaSliderTrack):
  70406. (WebCore::RenderThemeQt::paintMediaSliderThumb):
  70407. 2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
  70408. Reviewed by Simon.
  70409. Upon non fatal error, switch to the pause state (so that playback can continue)
  70410. * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  70411. (WebCore::MediaPlayerPrivate::updateStates):
  70412. 2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
  70413. Reviewed by Simon.
  70414. Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
  70415. * WebCore.pro:
  70416. 2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
  70417. Reviewed by Simon.
  70418. Make QtInstance::create() private and fix caching
  70419. * bindings/js/ScriptControllerQt.cpp:
  70420. (WebCore::ScriptController::createScriptInstanceForWidget):
  70421. * bridge/qt/qt_instance.cpp:
  70422. (JSC::Bindings::QtInstance::getQtInstance):
  70423. (JSC::Bindings::QtInstance::getRuntimeObject):
  70424. * bridge/qt/qt_instance.h:
  70425. (JSC::Bindings::QtInstance::create):
  70426. * bridge/qt/qt_runtime.cpp:
  70427. (JSC::Bindings::convertQVariantToValue):
  70428. (JSC::Bindings::QtConnectionObject::execute):
  70429. 2008-09-15 David Smith <catfish.man@gmail.com>
  70430. Reviewed by Dave Hyatt.
  70431. https://bugs.webkit.org/show_bug.cgi?id=20180
  70432. >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
  70433. With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
  70434. querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
  70435. * css/CSSStyleSelector.cpp:
  70436. (WebCore::CSSStyleSelector::CSSStyleSelector):
  70437. (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
  70438. * css/CSSStyleSelector.h:
  70439. 2008-09-14 Dave Hyatt <hyatt@apple.com>
  70440. Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
  70441. is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
  70442. Reviewed by Sam Weinig
  70443. * platform/ScrollBar.h:
  70444. (WebCore::Scrollbar::client):
  70445. (WebCore::Scrollbar::currentPos):
  70446. (WebCore::Scrollbar::totalSize):
  70447. * platform/ScrollbarTheme.h:
  70448. * platform/ScrollbarThemeComposite.cpp:
  70449. (WebCore::pageForScrollView):
  70450. (WebCore::ScrollbarThemeComposite::paint):
  70451. * platform/ScrollbarThemeComposite.h:
  70452. (WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
  70453. * platform/win/PlatformScrollBar.h:
  70454. * platform/win/PlatformScrollBarSafari.cpp:
  70455. * platform/win/PlatformScrollBarWin.cpp:
  70456. * platform/win/ScrollbarThemeSafari.h:
  70457. (WebCore::ScrollbarThemeSafari::hasButtons):
  70458. (WebCore::ScrollbarThemeSafari::hasThumb):
  70459. (WebCore::ScrollbarThemeSafari::backButtonRect):
  70460. (WebCore::ScrollbarThemeSafari::forwardButtonRect):
  70461. (WebCore::ScrollbarThemeSafari::trackRect):
  70462. (WebCore::ScrollbarThemeSafari::splitTrack):
  70463. (WebCore::ScrollbarThemeSafari::paintTrack):
  70464. (WebCore::ScrollbarThemeSafari::paintButton):
  70465. (WebCore::ScrollbarThemeSafari::paintThumb):
  70466. * platform/win/ScrollbarThemeWin.cpp:
  70467. (WebCore::isRunningOnVistaOrLater):
  70468. (WebCore::checkAndInitScrollbarTheme):
  70469. (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
  70470. (WebCore::ScrollbarThemeWin::themeChanged):
  70471. (WebCore::ScrollbarThemeWin::hasThumb):
  70472. (WebCore::ScrollbarThemeWin::backButtonRect):
  70473. (WebCore::ScrollbarThemeWin::forwardButtonRect):
  70474. (WebCore::ScrollbarThemeWin::trackRect):
  70475. (WebCore::ScrollbarThemeWin::splitTrack):
  70476. (WebCore::ScrollbarThemeWin::paintTrack):
  70477. (WebCore::ScrollbarThemeWin::paintButton):
  70478. (WebCore::gripperRect):
  70479. (WebCore::paintGripper):
  70480. (WebCore::ScrollbarThemeWin::paintThumb):
  70481. (WebCore::ScrollbarThemeWin::thumbPosition):
  70482. (WebCore::ScrollbarThemeWin::thumbLength):
  70483. (WebCore::ScrollbarThemeWin::trackLength):
  70484. * platform/win/ScrollbarThemeWin.h:
  70485. (WebCore::ScrollbarThemeWin::hasButtons):
  70486. (WebCore::ScrollbarThemeWin::trackIsSinglePiece):
  70487. 2008-09-14 Anthony Ricaud <rik24d@gmail.com>
  70488. Moving all resource graphs under the same container for future scalable feature.
  70489. This is a speedup on resize but maybe a loss on changing the sorting function.
  70490. https://bugs.webkit.org/show_bug.cgi?id=20555
  70491. Reviewed by Timothy Hatcher.
  70492. * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
  70493. Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
  70494. * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
  70495. 2008-09-14 Alexey Proskuryakov <ap@webkit.org>
  70496. Reviewed by Maciej Stachowiak.
  70497. https://bugs.webkit.org/show_bug.cgi?id=20738
  70498. compareBoundaryPoints gives incorrect results
  70499. Test: fast/dom/Range/compareBoundaryPoints-2.html
  70500. * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
  70501. and END_TO_START.
  70502. * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
  70503. 2008-09-14 Maciej Stachowiak <mjs@apple.com>
  70504. Unreviewed build fix.
  70505. Trying again.
  70506. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  70507. (WebCore::JSQuarantinedObjectWrapper::hasInstance):
  70508. 2008-09-14 Maciej Stachowiak <mjs@apple.com>
  70509. Unreviewed build fix.
  70510. Blind attempt to fix build. Correct parameters for hasInstance.
  70511. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  70512. (WebCore::JSQuarantinedObjectWrapper::hasInstance):
  70513. * bindings/js/JSQuarantinedObjectWrapper.h:
  70514. 2008-09-14 Dan Bernstein <mitz@apple.com>
  70515. Rubber-stamped by Sam Weinig.
  70516. - revert <http://trac.webkit.org/changeset/36382> because it exposed
  70517. <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
  70518. on Tiger.
  70519. * platform/graphics/mac/FontCacheMac.mm:
  70520. (WebCore::FontCache::getFontDataForCharacters):
  70521. (WebCore::FontCache::getLastResortFallbackFont):
  70522. 2008-09-14 Dave Hyatt <hyatt@apple.com>
  70523. Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
  70524. ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
  70525. theme.
  70526. Reviewed by Sam Weinig
  70527. * WebCore.vcproj/WebCore.vcproj:
  70528. * platform/win/ScrollbarThemeSafari.h:
  70529. * platform/win/ScrollbarThemeWin.h:
  70530. 2008-09-14 Alp Toker <alp@nuanti.com>
  70531. https://bugs.webkit.org/show_bug.cgi?id=20320
  70532. [GTK] A white rectangle is visible behind widgets with rounded corners
  70533. Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
  70534. style exempt).
  70535. Requested by Michael Monreal.
  70536. * platform/gtk/RenderThemeGtk.cpp:
  70537. (WebCore::RenderThemeGtk::RenderThemeGtk):
  70538. * platform/gtk/gtk2drawing.c:
  70539. (moz_gtk_set_widget_name):
  70540. (ensure_window_widget):
  70541. (setup_widget_prototype):
  70542. (ensure_button_arrow_widget):
  70543. (moz_gtk_get_combo_box_inner_button):
  70544. (moz_gtk_get_combo_box_button_inner_widgets):
  70545. (ensure_combo_box_widgets):
  70546. (moz_gtk_get_combo_box_entry_inner_widgets):
  70547. (moz_gtk_get_combo_box_entry_arrow):
  70548. (ensure_combo_box_entry_widgets):
  70549. (ensure_toolbar_widget):
  70550. (ensure_tooltip_widget):
  70551. (ensure_menu_bar_widget):
  70552. (ensure_menu_bar_item_widget):
  70553. (ensure_menu_popup_widget):
  70554. (ensure_menu_item_widget):
  70555. (ensure_image_menu_item_widget):
  70556. (ensure_menu_separator_widget):
  70557. (ensure_check_menu_item_widget):
  70558. (ensure_tree_header_cell_widget):
  70559. (ensure_scrolled_window_widget):
  70560. (moz_gtk_button_paint):
  70561. (moz_gtk_init):
  70562. (moz_gtk_button_get_inner_border):
  70563. (moz_gtk_toggle_paint):
  70564. (calculate_button_inner_rect):
  70565. (calculate_arrow_rect):
  70566. (moz_gtk_scrollbar_button_paint):
  70567. (moz_gtk_scrollbar_thumb_paint):
  70568. (moz_gtk_caret_paint):
  70569. (moz_gtk_entry_paint):
  70570. (moz_gtk_treeview_paint):
  70571. (moz_gtk_tree_header_cell_paint):
  70572. (moz_gtk_combo_box_paint):
  70573. (moz_gtk_downarrow_paint):
  70574. (moz_gtk_combo_box_entry_button_paint):
  70575. (moz_gtk_toolbar_paint):
  70576. (moz_gtk_tab_scroll_arrow_paint):
  70577. (moz_gtk_menu_bar_paint):
  70578. (moz_gtk_menu_item_paint):
  70579. (moz_gtk_get_widget_border):
  70580. (moz_gtk_get_combo_box_entry_button_size):
  70581. (moz_gtk_get_tab_scroll_arrow_size):
  70582. (moz_gtk_get_downarrow_size):
  70583. (moz_gtk_images_in_menus):
  70584. (moz_gtk_widget_paint):
  70585. (moz_gtk_shutdown):
  70586. * platform/gtk/gtkdrawing.h:
  70587. 2008-09-14 David Hyatt <hyatt@apple.com>
  70588. Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
  70589. painting. Mac and Gtk themes don't do anything and just let the
  70590. underlying widget paint. Qt now uses the theme to paint. wx doesn't
  70591. do anything yet.
  70592. Reviewed by Sam Weinig
  70593. * platform/ScrollBar.cpp:
  70594. (WebCore::Scrollbar::paint):
  70595. * platform/ScrollBar.h:
  70596. (WebCore::Scrollbar::value):
  70597. (WebCore::Scrollbar::visibleSize):
  70598. (WebCore::Scrollbar::maximum):
  70599. (WebCore::Scrollbar::lineStep):
  70600. (WebCore::Scrollbar::pageStep):
  70601. (WebCore::Scrollbar::pixelStep):
  70602. (WebCore::Scrollbar::pressedPart):
  70603. (WebCore::Scrollbar::hoveredPart):
  70604. (WebCore::Scrollbar::theme):
  70605. * platform/ScrollbarTheme.h:
  70606. (WebCore::ScrollbarTheme::paint):
  70607. (WebCore::ScrollbarTheme::scrollbarThickness):
  70608. (WebCore::ScrollbarTheme::supportsControlTints):
  70609. (WebCore::ScrollbarTheme::themeChanged):
  70610. * platform/gtk/PlatformScrollBar.h:
  70611. * platform/gtk/PlatformScrollBarGtk.cpp:
  70612. * platform/mac/PlatformScrollBar.h:
  70613. * platform/mac/PlatformScrollBarMac.mm:
  70614. * platform/qt/PlatformScrollBar.h:
  70615. * platform/qt/PlatformScrollBarQt.cpp:
  70616. * platform/qt/ScrollbarThemeQt.cpp:
  70617. (WebCore::styleOptionSlider):
  70618. * platform/qt/ScrollbarThemeQt.h:
  70619. (WebCore::ScrollbarThemeQt::paint):
  70620. * platform/win/PlatformScrollBarSafari.cpp:
  70621. (WebCore::PlatformScrollbar::paint):
  70622. * platform/win/ScrollbarThemeSafari.h:
  70623. (WebCore::ScrollbarThemeSafari::supportsControlTints):
  70624. * platform/wx/PlatformScrollBar.h:
  70625. * platform/wx/TemporaryLinkStubs.cpp:
  70626. (PlatformScrollbar::~PlatformScrollbar):
  70627. 2008-09-14 Sam Weinig <sam@webkit.org>
  70628. Qt build fix.
  70629. * platform/qt/PlatformScrollBarQt.cpp:
  70630. 2008-09-14 Sam Weinig <sam@webkit.org>
  70631. Reviewed by Mark Rowe.
  70632. Remove extraneous semicolons.
  70633. * bindings/scripts/CodeGeneratorObjC.pm:
  70634. * html/HTMLLinkElement.cpp:
  70635. (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  70636. * html/HTMLScriptElement.cpp:
  70637. (WebCore::HTMLScriptElement::charsetAttributeValue):
  70638. (WebCore::HTMLScriptElement::typeAttributeValue):
  70639. * platform/graphics/qt/GradientQt.cpp:
  70640. (WebCore::Gradient::platformGradient):
  70641. * platform/qt/ScrollViewQt.cpp:
  70642. (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  70643. * platform/win/ScrollViewWin.cpp:
  70644. (WebCore::ScrollView::updateScrollbars):
  70645. * rendering/RenderBlock.cpp:
  70646. (WebCore::RenderBlock::paintEllipsisBoxes):
  70647. * svg/SVGPathSegList.cpp:
  70648. (WebCore::SVGPathSegList::toPathData):
  70649. 2008-09-14 Sam Weinig <sam@webkit.org>
  70650. Qt build fix.
  70651. * platform/qt/ScrollViewQt.cpp:
  70652. (WebCore::ScrollView::updateScrollbars):
  70653. 2008-09-14 Sam Weinig <sam@webkit.org>
  70654. Qt build fix.
  70655. * platform/qt/PlatformScrollBarQt.cpp:
  70656. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70657. (WebCore::PlatformScrollbar::paint):
  70658. 2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
  70659. Gtk build fix, not reviewed.
  70660. * platform/gtk/PlatformScrollBarGtk.cpp:
  70661. (PlatformScrollbar::PlatformScrollbar):
  70662. * platform/gtk/ScrollViewGtk.cpp:
  70663. (WebCore::ScrollView::updateScrollbars):
  70664. 2008-09-13 Dave Hyatt <hyatt@apple.com>
  70665. Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
  70666. to set the dimensions of a scrollbar.
  70667. Reviewed by Sam Weinig
  70668. * platform/ScrollBar.h:
  70669. * platform/gtk/PlatformScrollBar.h:
  70670. * platform/gtk/PlatformScrollBarGtk.cpp:
  70671. (PlatformScrollbar::setFrameGeometry):
  70672. * platform/gtk/ScrollViewGtk.cpp:
  70673. (WebCore::ScrollView::updateScrollbars):
  70674. * platform/mac/PlatformScrollBarMac.mm:
  70675. * platform/qt/PlatformScrollBarQt.cpp:
  70676. * platform/qt/ScrollViewQt.cpp:
  70677. (WebCore::ScrollView::updateScrollbars):
  70678. * platform/win/PlatformScrollBar.h:
  70679. * platform/win/PlatformScrollBarSafari.cpp:
  70680. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70681. (WebCore::PlatformScrollbar::setFrameGeometry):
  70682. * platform/win/PlatformScrollBarWin.cpp:
  70683. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70684. (WebCore::PlatformScrollbar::setFrameGeometry):
  70685. * platform/win/PopupMenuWin.cpp:
  70686. (WebCore::PopupWndProc):
  70687. * platform/win/ScrollViewWin.cpp:
  70688. (WebCore::ScrollView::updateScrollbars):
  70689. * platform/wx/PlatformScrollBar.h:
  70690. * platform/wx/TemporaryLinkStubs.cpp:
  70691. (PlatformScrollbar::updateThumbProportion):
  70692. * rendering/RenderLayer.cpp:
  70693. (WebCore::RenderLayer::positionOverflowControls):
  70694. * rendering/RenderListBox.cpp:
  70695. (WebCore::RenderListBox::paintScrollbar):
  70696. 2008-09-13 Dave Hyatt <hyatt@apple.com>
  70697. Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
  70698. Reviewed by Sam Weinig
  70699. * platform/ScrollBar.h:
  70700. * platform/gtk/PlatformScrollBar.h:
  70701. * platform/gtk/PlatformScrollBarGtk.cpp:
  70702. * platform/mac/PlatformScrollBar.h:
  70703. * platform/mac/PlatformScrollBarMac.mm:
  70704. * platform/win/PlatformScrollBar.h:
  70705. * platform/win/PlatformScrollBarSafari.cpp:
  70706. * platform/win/PlatformScrollBarWin.cpp:
  70707. * platform/wx/PlatformScrollBar.h:
  70708. * platform/wx/TemporaryLinkStubs.cpp:
  70709. (PlatformScrollbar::~PlatformScrollbar):
  70710. 2008-09-13 Dave Hyatt <hyatt@apple.com>
  70711. Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
  70712. all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
  70713. Reviewed by Sam Weinig
  70714. * platform/ScrollBar.h:
  70715. * platform/gtk/PlatformScrollBar.h:
  70716. * platform/gtk/PlatformScrollBarGtk.cpp:
  70717. * platform/mac/PlatformScrollBar.h:
  70718. * platform/mac/PlatformScrollBarMac.mm:
  70719. * platform/win/PlatformScrollBarSafari.cpp:
  70720. * platform/win/PlatformScrollBarWin.cpp:
  70721. * platform/wx/PlatformScrollBar.h:
  70722. * platform/wx/TemporaryLinkStubs.cpp:
  70723. (PlatformScrollbar::~PlatformScrollbar):
  70724. 2008-09-13 Dave Hyatt <hyatt@apple.com>
  70725. Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
  70726. Reviewed by Sam Weinig
  70727. * platform/ScrollBar.cpp:
  70728. (WebCore::Scrollbar::~Scrollbar):
  70729. * platform/ScrollBar.h:
  70730. * platform/qt/PlatformScrollBarQt.cpp:
  70731. (WebCore::PlatformScrollbar::~PlatformScrollbar):
  70732. * platform/win/PlatformScrollBarSafari.cpp:
  70733. (WebCore::PlatformScrollbar::~PlatformScrollbar):
  70734. * platform/win/PlatformScrollBarWin.cpp:
  70735. (WebCore::PlatformScrollbar::~PlatformScrollbar):
  70736. 2008-09-13 David Hyatt <hyatt@apple.com>
  70737. Move maximum() from Qt's PlatformScrollbar to be a cross-platform
  70738. function on Scrollbar. Fixes Qt build bustage.
  70739. Reviewed by Sam Weinig
  70740. * platform/ScrollBar.h:
  70741. (WebCore::Scrollbar::orientation):
  70742. (WebCore::Scrollbar::value):
  70743. (WebCore::Scrollbar::maximum):
  70744. * platform/qt/PlatformScrollBar.h:
  70745. 2008-09-13 Dan Bernstein <mitz@apple.com>
  70746. Reviewed by Sam Weinig.
  70747. - use the LastResort font for missing glyphs instead of showing the
  70748. primary font's missing glyph
  70749. Test: platform/mac/fast/text/last-resort-font.html
  70750. * platform/graphics/mac/FontCacheMac.mm:
  70751. (WebCore::FontCache::getFontDataForCharacters): Changed to return the
  70752. last resort font if a substitute font cannot be found.
  70753. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
  70754. comment (the user's preferred standard font is included in the search
  70755. thanks to code in FontCache::getFontData()) and changed to return the
  70756. LastResort font.
  70757. 2008-09-13 Dave Hyatt <hyatt@apple.com>
  70758. This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
  70759. scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
  70760. patches will move rendering and hit testing functionality into this class.
  70761. Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
  70762. implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
  70763. Reviewed by Sam Weinig
  70764. * GNUmakefile.am:
  70765. * WebCore.pro:
  70766. * WebCore.vcproj/WebCore.vcproj:
  70767. * platform/ScrollBar.cpp:
  70768. (WebCore::Scrollbar::Scrollbar):
  70769. * platform/ScrollBar.h:
  70770. * platform/ScrollbarTheme.h: Added.
  70771. (WebCore::ScrollbarTheme::~ScrollbarTheme):
  70772. (WebCore::ScrollbarTheme::scrollbarThickness):
  70773. (WebCore::ScrollbarTheme::themeChanged):
  70774. * platform/gtk/ScrollbarThemeGtk.cpp: Added.
  70775. (WebCore::ScrollbarTheme::nativeTheme):
  70776. (WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
  70777. (WebCore::ScrollbarThemeGtk::scrollbarThickness):
  70778. * platform/gtk/ScrollbarThemeGtk.h: Added.
  70779. * platform/mac/PlatformScrollBar.h:
  70780. * platform/mac/ScrollbarThemeMac.cpp: Added.
  70781. (WebCore::ScrollbarTheme::nativeTheme):
  70782. (WebCore::):
  70783. (WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
  70784. (WebCore::ScrollbarThemeMac::scrollbarThickness):
  70785. * platform/mac/ScrollbarThemeMac.h: Added.
  70786. * platform/qt/PlatformScrollBarQt.cpp:
  70787. * platform/qt/ScrollbarThemeQt.cpp: Added.
  70788. (WebCore::ScrollbarTheme::nativeTheme):
  70789. (WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
  70790. (WebCore::ScrollbarThemeQt::scrollbarThickness):
  70791. * platform/qt/ScrollbarThemeQt.h: Added.
  70792. * platform/win/PlatformScrollBar.h:
  70793. * platform/win/PlatformScrollBarSafari.cpp:
  70794. * platform/win/PlatformScrollBarWin.cpp:
  70795. * platform/win/PopupMenuWin.cpp:
  70796. (WebCore::PopupMenu::calculatePositionAndSize):
  70797. * platform/win/ScrollViewWin.cpp:
  70798. (WebCore::ScrollView::updateScrollbars):
  70799. (WebCore::ScrollView::themeChanged):
  70800. * platform/win/ScrollbarThemeSafari.cpp: Added.
  70801. (WebCore::ScrollbarTheme::nativeTheme):
  70802. (WebCore::):
  70803. (WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
  70804. (WebCore::ScrollbarThemeSafari::scrollbarThickness):
  70805. * platform/win/ScrollbarThemeSafari.h: Added.
  70806. * platform/win/ScrollbarThemeWin.cpp: Added.
  70807. (WebCore::ScrollbarTheme::nativeTheme):
  70808. (WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
  70809. (WebCore::ScrollbarThemeWin::scrollbarThickness):
  70810. (WebCore::ScrollbarThemeWin::themeChanged):
  70811. * platform/win/ScrollbarThemeWin.h: Added.
  70812. * platform/wx/TemporaryLinkStubs.cpp:
  70813. (ScrollbarTheme::nativeTheme):
  70814. * rendering/RenderLayer.cpp:
  70815. (WebCore::scrollCornerRect):
  70816. * rendering/RenderTextControl.cpp:
  70817. (WebCore::RenderTextControl::calcHeight):
  70818. (WebCore::RenderTextControl::calcPrefWidths):
  70819. 2008-09-13 Chris Fleizach <cfleizach@apple.com>
  70820. Reviewed by Timothy Hatcher.
  70821. <rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
  70822. * page/mac/AccessibilityObjectWrapper.mm:
  70823. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  70824. 2008-09-13 Dan Bernstein <mitz@apple.com>
  70825. Reviewed by Timothy Hatcher.
  70826. - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
  70827. No regression test because the back/forward cache is disabled in DumpRenderTree
  70828. * rendering/RenderContainer.cpp:
  70829. (WebCore::RenderContainer::invalidateCounters): Bail out if the document
  70830. is being destroyed.
  70831. 2008-09-13 Kevin Ollivier <kevino@theolliviers.com>
  70832. wx build fixes for new methods recently introduced.
  70833. * platform/graphics/wx/AffineTransformWx.cpp:
  70834. (WebCore::AffineTransform::AffineTransform):
  70835. (WebCore::AffineTransform::setMatrix):
  70836. (WebCore::AffineTransform::setA):
  70837. (WebCore::AffineTransform::setB):
  70838. (WebCore::AffineTransform::setC):
  70839. (WebCore::AffineTransform::setD):
  70840. (WebCore::AffineTransform::setE):
  70841. (WebCore::AffineTransform::setF):
  70842. * platform/wx/LocalizedStringsWx.cpp:
  70843. (WebCore::AXDefinitionListTermText):
  70844. (WebCore::AXDefinitionListDefinitionText):
  70845. 2008-09-12 Dave Hyatt <hyatt@apple.com>
  70846. Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
  70847. up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
  70848. "PlatformScrollbar."
  70849. Reviewed by Sam Weinig
  70850. * WebCore.vcproj/WebCore.vcproj:
  70851. * editing/EditorCommand.cpp:
  70852. * page/EventHandler.cpp:
  70853. (WebCore::EventHandler::selectCursor):
  70854. (WebCore::EventHandler::handleMousePressEvent):
  70855. (WebCore::EventHandler::handleMouseMoveEvent):
  70856. * page/EventHandler.h:
  70857. * page/MouseEventWithHitTestResults.cpp:
  70858. (WebCore::MouseEventWithHitTestResults::scrollbar):
  70859. * page/MouseEventWithHitTestResults.h:
  70860. * page/gtk/EventHandlerGtk.cpp:
  70861. (WebCore::EventHandler::passMousePressEventToScrollbar):
  70862. * page/mac/EventHandlerMac.mm:
  70863. (WebCore::EventHandler::passMousePressEventToScrollbar):
  70864. * page/qt/EventHandlerQt.cpp:
  70865. (WebCore::EventHandler::passMousePressEventToScrollbar):
  70866. * page/win/EventHandlerWin.cpp:
  70867. (WebCore::EventHandler::passMousePressEventToScrollbar):
  70868. * page/wx/EventHandlerWx.cpp:
  70869. (WebCore::EventHandler::passMousePressEventToScrollbar):
  70870. * platform/PopupMenu.h:
  70871. * platform/ScrollBar.cpp:
  70872. (WebCore::Scrollbar::Scrollbar):
  70873. (WebCore::Scrollbar::autoscrollTimerFired):
  70874. (WebCore::Scrollbar::autoscrollPressedPart):
  70875. (WebCore::Scrollbar::startTimerIfNeeded):
  70876. (WebCore::Scrollbar::stopTimerIfNeeded):
  70877. (WebCore::Scrollbar::pressedPartScrollDirection):
  70878. (WebCore::Scrollbar::pressedPartScrollGranularity):
  70879. * platform/ScrollBar.h:
  70880. (WebCore::Scrollbar::handleMousePressEvent):
  70881. (WebCore::Scrollbar::invalidatePart):
  70882. (WebCore::Scrollbar::thumbUnderMouse):
  70883. * platform/ScrollView.h:
  70884. * platform/ScrollbarClient.h: Added.
  70885. (WebCore::ScrollbarClient::~ScrollbarClient):
  70886. * platform/gtk/ScrollViewGtk.cpp:
  70887. (WebCore::ScrollView::scrollbarUnderMouse):
  70888. * platform/qt/PlatformScrollBar.h:
  70889. * platform/qt/PlatformScrollBarQt.cpp:
  70890. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70891. (WebCore::scrollbarPart):
  70892. (WebCore::PlatformScrollbar::handleMouseMoveEvent):
  70893. (WebCore::PlatformScrollbar::handleMouseOutEvent):
  70894. (WebCore::PlatformScrollbar::handleMousePressEvent):
  70895. (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
  70896. * platform/qt/ScrollViewQt.cpp:
  70897. (WebCore::ScrollView::scrollbarUnderMouse):
  70898. (WebCore::ScrollView::wheelEvent):
  70899. * platform/win/PlatformScrollBar.h:
  70900. * platform/win/PlatformScrollBarSafari.cpp:
  70901. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70902. * platform/win/PlatformScrollBarWin.cpp:
  70903. (WebCore::PlatformScrollbar::PlatformScrollbar):
  70904. * platform/win/ScrollViewWin.cpp:
  70905. (WebCore::ScrollView::scrollbarUnderMouse):
  70906. * rendering/HitTestResult.cpp:
  70907. (WebCore::HitTestResult::setScrollbar):
  70908. * rendering/HitTestResult.h:
  70909. (WebCore::HitTestResult::scrollbar):
  70910. * rendering/RenderLayer.cpp:
  70911. (WebCore::RenderLayer::hitTestOverflowControls):
  70912. * rendering/RenderLayer.h:
  70913. * rendering/RenderListBox.h:
  70914. 2008-09-12 Steve Falkenburg <sfalken@apple.com>
  70915. Fix Mac build.
  70916. * css/CSSStyleSelector.cpp:
  70917. (WebCore::getTransformOperationType):
  70918. 2008-09-12 Chris Marrin <cmarrin@apple.com>
  70919. Reviewed by Dave Hyatt.
  70920. Make transform animation behavior match spec
  70921. https://bugs.webkit.org/show_bug.cgi?id=20770
  70922. Tests: transitions/transform-op-list-match.html
  70923. transitions/transform-op-list-no-match.html
  70924. * css/CSSStyleSelector.cpp:
  70925. * css/CSSStyleSelector.h:
  70926. * page/animation/AnimationBase.cpp:
  70927. * page/animation/AnimationBase.h:
  70928. * page/animation/ImplicitAnimation.cpp:
  70929. * page/animation/ImplicitAnimation.h:
  70930. * page/animation/KeyframeAnimation.cpp:
  70931. * page/animation/KeyframeAnimation.h:
  70932. * rendering/RenderLayer.cpp:
  70933. * rendering/style/RenderStyle.cpp:
  70934. * rendering/style/RenderStyle.h:
  70935. 2008-09-12 Ojan Vafai <ojan@chromium.org>
  70936. Properly escape contents of links added to the inspector.
  70937. For now, just build the link with the DOM and get the
  70938. outerHTML. Eventually, we probably just want to do
  70939. this entirely with the DOM.
  70940. Reviewed by Timothy Hatcher.
  70941. https://bugs.webkit.org/show_bug.cgi?id=20684
  70942. * manual-tests/inspector/escape-links.html: Added.
  70943. * page/inspector/StylesSidebarPane.js:
  70944. * page/inspector/inspector.js:
  70945. * page/inspector/utilities.js:
  70946. 2008-09-12 Adele Peterson <adele@apple.com>
  70947. Reviewed by John Sullivan and Kevin McCullough.
  70948. Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
  70949. * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
  70950. Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
  70951. cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
  70952. 2008-09-12 Kevin McCullough <kmccullough@apple.com>
  70953. RS by Tim .
  70954. Re-introducing the code since it was not the cause of the crash.
  70955. See r36343.
  70956. * rendering/RenderObject.cpp:
  70957. (WebCore::RenderObject::canBeProgramaticallyScrolled):
  70958. * rendering/RenderObject.h:
  70959. 2008-09-12 Chris Marrin <cmarrin@apple.com>
  70960. Reviewed by Dave Hyatt.
  70961. When changing one animation in a list, don't reset other animations
  70962. https://bugs.webkit.org/show_bug.cgi?id=20675
  70963. Test: animations/change-one-anim.html
  70964. * page/animation/AnimationBase.cpp:
  70965. (WebCore::AnimationBase::getNumProperties):
  70966. * page/animation/AnimationBase.h:
  70967. * page/animation/AnimationController.cpp:
  70968. * page/animation/CompositeAnimation.cpp:
  70969. (WebCore::CompositeAnimation::updateKeyframeAnimations):
  70970. * page/animation/CompositeAnimation.h:
  70971. * page/animation/ImplicitAnimation.cpp:
  70972. * page/animation/KeyframeAnimation.cpp:
  70973. * page/animation/KeyframeAnimation.h:
  70974. (WebCore::KeyframeAnimation::setIndex):
  70975. 2008-09-12 Brady Eidson <beidson@apple.com>
  70976. Reviewed by Mitz Pettel
  70977. Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
  70978. * loader/DocumentLoader.cpp:
  70979. (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
  70980. Subresources can never be created from nil data, but there is always a MainResource, whether
  70981. or not there's any data. So in the case where the main resource has no data, fake it for the
  70982. sake of creating the ArchiveResource.
  70983. 2008-09-12 Dave Hyatt <hyatt@apple.com>
  70984. Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
  70985. scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
  70986. Remove all the isWidget and hasPlatformScrollbars guards.
  70987. Reviewed by Tim Hatcher
  70988. * platform/ScrollBar.h:
  70989. * platform/gtk/PlatformScrollBar.h:
  70990. * platform/mac/PlatformScrollBar.h:
  70991. * platform/qt/PlatformScrollBar.h:
  70992. * platform/win/PlatformScrollBar.h:
  70993. * platform/win/ScrollViewWin.cpp:
  70994. (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  70995. (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  70996. * platform/wx/PlatformScrollBar.h:
  70997. * rendering/RenderLayer.cpp:
  70998. (WebCore::RenderLayer::horizontalScrollbarWidget):
  70999. (WebCore::RenderLayer::verticalScrollbarWidget):
  71000. (WebCore::RenderLayer::createScrollbar):
  71001. (WebCore::RenderLayer::destroyScrollbar):
  71002. * rendering/RenderListBox.cpp:
  71003. (WebCore::RenderListBox::~RenderListBox):
  71004. (WebCore::RenderListBox::updateFromElement):
  71005. (WebCore::RenderListBox::isPointInOverflowControl):
  71006. 2008-09-12 Dan Bernstein <mitz@apple.com>
  71007. Reviewed by Sam Weinig.
  71008. - https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
  71009. * page/animation/AnimationController.cpp:
  71010. * page/animation/AnimationController.h:
  71011. * page/animation/CompositeAnimation.cpp:
  71012. * page/animation/CompositeAnimation.h:
  71013. * page/animation/ImplicitAnimation.cpp:
  71014. * page/animation/ImplicitAnimation.h:
  71015. * page/animation/KeyframeAnimation.cpp:
  71016. * page/animation/KeyframeAnimation.h:
  71017. 2008-09-11 Timothy Hatcher <timothy@apple.com>
  71018. Add a renderedImage method to DOMNode to get an image
  71019. of the rendering for the node and it's descendants.
  71020. <rdar://problem/5849349> Would like API to create
  71021. an image for a DOM node
  71022. Reviewed by Oliver Hunt.
  71023. * bindings/objc/DOM.mm:
  71024. (-[DOMNode renderedImage]): Call Frame::nodeImage.
  71025. * bindings/objc/DOMPrivate.h:
  71026. * page/Frame.h:
  71027. * page/mac/FrameMac.mm:
  71028. (WebCore::Frame::nodeImage):
  71029. 2008-09-08 Chris Marrin <cmarrin@apple.com>
  71030. Reviewed by Dave Hyatt
  71031. Need to support comma separated list of key times in keyframes selectors
  71032. https://bugs.webkit.org/show_bug.cgi?id=20680
  71033. Test: animations/keyframes-comma-separated.html
  71034. * css/CSSGrammar.y:
  71035. * css/CSSParser.cpp:
  71036. (WebCore::CSSParser::createKeyframeRule):
  71037. * css/CSSParser.h:
  71038. * css/CSSStyleSelector.cpp:
  71039. (WebCore::CSSStyleSelector::addKeyframeStyle):
  71040. * css/WebKitCSSKeyframeRule.cpp:
  71041. (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
  71042. (WebCore::WebKitCSSKeyframeRule::cssText):
  71043. (WebCore::WebKitCSSKeyframeRule::parseKeyString):
  71044. * css/WebKitCSSKeyframeRule.h:
  71045. (WebCore::WebKitCSSKeyframeRule::keyText):
  71046. (WebCore::WebKitCSSKeyframeRule::setKeyText):
  71047. (WebCore::WebKitCSSKeyframeRule::getKeys):
  71048. * css/WebKitCSSKeyframesRule.cpp:
  71049. (WebCore::WebKitCSSKeyframesRule::append):
  71050. (WebCore::WebKitCSSKeyframesRule::insertRule):
  71051. (WebCore::WebKitCSSKeyframesRule::deleteRule):
  71052. (WebCore::WebKitCSSKeyframesRule::findRule):
  71053. (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
  71054. * css/WebKitCSSKeyframesRule.h:
  71055. * page/animation/AnimationBase.cpp:
  71056. (WebCore::AnimationBase::blendProperties):
  71057. 2008-09-11 Kevin McCullough <kmccullough@apple.com>
  71058. RS by Tim.
  71059. Reverting because this caused a crash.
  71060. * rendering/RenderObject.cpp:
  71061. (WebCore::RenderObject::canBeProgramaticallyScrolled):
  71062. (WebCore::RenderObject::hasScrollableView):
  71063. * rendering/RenderObject.h:
  71064. 2008-09-11 Dean Jackson <dino@apple.com>
  71065. Reviewed by Dan Bernstein.
  71066. Fix assertion on transition property "none"
  71067. https://bugs.webkit.org/show_bug.cgi?id=20751
  71068. Test: transitions/transition-end-event-set-none.html
  71069. * page/animation/CompositeAnimation.cpp:
  71070. (WebCore::CompositeAnimation::updateTransitions):
  71071. 2008-09-11 David Smith <catfish.man@gmail.com>
  71072. Rubber-stamped by mitzpettel.
  71073. Remove an accidentally added extra file.
  71074. * WebCore: Removed.
  71075. 2008-09-11 David Smith <catfish.man@gmail.com>
  71076. Reviewed by Darin
  71077. https://bugs.webkit.org/show_bug.cgi?id=20180
  71078. This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
  71079. * WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
  71080. * css/CSSStyleSelector.cpp: include NodeRenderStyle.h
  71081. * dom/Element.cpp: include NodeRenderStyle.h
  71082. * dom/Node.cpp: Remove the definition of renderStyle()
  71083. (WebCore::Node::nonRendererRenderStyle):
  71084. * dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
  71085. * dom/NodeRenderStyle.h: Added.
  71086. (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
  71087. * html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
  71088. * html/HTMLOptGroupElement.h:
  71089. (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
  71090. * html/HTMLOptionElement.cpp: include NodeRenderStyle.h
  71091. * html/HTMLOptionElement.h:
  71092. (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
  71093. * rendering/RenderListBox.cpp: include NodeRenderStyle.h
  71094. * rendering/RenderMenuList.cpp: include NodeRenderStyle.h
  71095. * svg/SVGUseElement.cpp: include NodeRenderStyle.h
  71096. 2008-09-11 Kevin McCullough <kmccullough@apple.com>
  71097. Reviewed by Adele and Tim.
  71098. <rdar://problem/6100597> REGRESSION: clicking on search results in Web
  71099. Inspector does not scroll to the line of the results (20167)
  71100. - This was put in by Max to fix auto scrolling but is not correct for
  71101. the whole web: rdar://problem/6213098
  71102. * rendering/RenderObject.cpp:
  71103. (WebCore::RenderObject::canBeProgramaticallyScrolled):
  71104. * rendering/RenderObject.h:
  71105. 2008-09-11 Chris Fleizach <cfleizach@apple.com>
  71106. Reviewed by Beth Dakin
  71107. <rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
  71108. Test: accessibility/frame-with-title.html
  71109. * page/AccessibilityRenderObject.cpp:
  71110. (WebCore::AccessibilityRenderObject::accessibilityDescription):
  71111. 2008-09-11 Dirk Schulze <vbs85@gmx.de>
  71112. Reviewed by Simon.
  71113. Fixed stroke() and strokeRect() to support gradients
  71114. and patterns on Qt.
  71115. [Qt] Canvas stroke don't work for gradients and patterns
  71116. [https://bugs.webkit.org/show_bug.cgi?id=20749]
  71117. * platform/graphics/qt/GraphicsContextQt.cpp:
  71118. (WebCore::GraphicsContext::strokePath):
  71119. (WebCore::GraphicsContext::strokeRect):
  71120. 2008-09-11 Dirk Schulze <vbs85@gmx.de>
  71121. Reviewed by Simon.
  71122. https://bugs.webkit.org/show_bug.cgi?id=20729
  71123. Fixed canvas gradients for Qt
  71124. [Qt] Canvas gradients don't work as expected
  71125. [https://bugs.webkit.org/show_bug.cgi?id=20729]
  71126. * platform/graphics/qt/GradientQt.cpp:
  71127. (WebCore::Gradient::platformGradient):
  71128. 2008-09-11 Dirk Schulze <vbs85@gmx.de>
  71129. Reviewed by Simon.
  71130. https://bugs.webkit.org/show_bug.cgi?id=20568
  71131. Add support for patterns to Qt.
  71132. * platform/graphics/qt/PatternQt.cpp:
  71133. (WebCore::Pattern::createPlatformPattern):
  71134. 2008-09-10 Dan Bernstein <mitz@apple.com>
  71135. Reviewed by Sam Weinig.
  71136. - clean up AnimationBase
  71137. * page/animation/AnimationBase.cpp:
  71138. * page/animation/AnimationBase.h:
  71139. * page/animation/CompositeAnimation.cpp:
  71140. * page/animation/ImplicitAnimation.cpp:
  71141. * page/animation/ImplicitAnimation.h:
  71142. * page/animation/KeyframeAnimation.cpp:
  71143. * page/animation/KeyframeAnimation.h:
  71144. 2008-09-10 Alexey Proskuryakov <ap@webkit.org>
  71145. Reviewed by Darin Adler.
  71146. https://bugs.webkit.org/show_bug.cgi?id=20741
  71147. REGRESSION: ISO-8859-8-I encoding is registered incorrectly
  71148. Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
  71149. check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
  71150. tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
  71151. I also found and fixed a potential crasher for non-Mac ports.
  71152. Tests: fast/encoding/hebrew/8859-8-e.html
  71153. fast/encoding/hebrew/8859-8-i.html
  71154. fast/encoding/hebrew/8859-8.html
  71155. fast/encoding/hebrew/csISO88598I.html
  71156. fast/encoding/hebrew/hebrew.html
  71157. fast/encoding/hebrew/iso-ir-138.html
  71158. fast/encoding/hebrew/logical.html
  71159. * platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
  71160. (case-insensitively, because different versions of ICU report this MIME name in different
  71161. case).
  71162. * platform/text/TextCodecICU.cpp:
  71163. (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
  71164. (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
  71165. There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
  71166. with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
  71167. we also support these via TEC (which we should stop doing), but on Windows, this would
  71168. likely crash.
  71169. 2008-09-09 Dave Hyatt <hyatt@apple.com
  71170. Resurrect PlatformScrollbarWin.
  71171. Reviewed by Adam Roben
  71172. * WebCore.vcproj/WebCore.vcproj:
  71173. * platform/win/PlatformScrollBarWin.cpp:
  71174. (WebCore::isRunningOnVistaOrLater):
  71175. (WebCore::checkAndInitScrollbarTheme):
  71176. (WebCore::PlatformScrollbar::PlatformScrollbar):
  71177. (WebCore::PlatformScrollbar::invalidateTrack):
  71178. (WebCore::PlatformScrollbar::invalidatePart):
  71179. (WebCore::PlatformScrollbar::paint):
  71180. (WebCore::PlatformScrollbar::hasButtons):
  71181. (WebCore::PlatformScrollbar::hasThumb):
  71182. (WebCore::PlatformScrollbar::backButtonRect):
  71183. (WebCore::PlatformScrollbar::forwardButtonRect):
  71184. (WebCore::PlatformScrollbar::trackRect):
  71185. (WebCore::PlatformScrollbar::gripperRect):
  71186. (WebCore::PlatformScrollbar::thumbLength):
  71187. (WebCore::PlatformScrollbar::paintButton):
  71188. (WebCore::PlatformScrollbar::paintTrack):
  71189. (WebCore::PlatformScrollbar::paintThumb):
  71190. (WebCore::PlatformScrollbar::paintGripper):
  71191. (WebCore::PlatformScrollbar::hitTest):
  71192. (WebCore::PlatformScrollbar::handleMouseMoveEvent):
  71193. (WebCore::PlatformScrollbar::handleMouseOutEvent):
  71194. (WebCore::PlatformScrollbar::themeChanged):
  71195. 2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  71196. Reviewed by Maciej Stachowiak.
  71197. Bug 20759: Remove MacroAssembler
  71198. <https://bugs.webkit.org/show_bug.cgi?id=20759>
  71199. Make the necessary changes to ForwardingHeaders to remove
  71200. MacroAssembler.
  71201. * ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
  71202. * ForwardingHeaders/masm/MacroAssembler.h: Removed.
  71203. * ForwardingHeaders/masm/X86Assembler.h: Added.
  71204. 2008-09-09 Alp Toker <alp@nuanti.com>
  71205. Reviewed by Dave Hyatt.
  71206. https://bugs.webkit.org/show_bug.cgi?id=16792
  71207. [GTK] Fails to render Japanese/Chinese text with simple path
  71208. https://bugs.webkit.org/show_bug.cgi?id=16942
  71209. [GTK] Oddities in font selection and fall back
  71210. https://bugs.webkit.org/show_bug.cgi?id=16862
  71211. [GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
  71212. GTK+ font fixes and enhancements.
  71213. Implement font fallback for the simple FontConfig-based text path and
  71214. improve the Pango-based complex text path to make use of requested
  71215. font properties and available font selection.
  71216. Add text shadow support to the complex path.
  71217. * platform/graphics/gtk/FontCacheGtk.cpp:
  71218. (WebCore::FontCache::getFontDataForCharacters):
  71219. (WebCore::FontCache::getSimilarFontPlatformData):
  71220. * platform/graphics/gtk/FontGtk.cpp:
  71221. (WebCore::setPangoAttributes):
  71222. (WebCore::Font::drawComplexText):
  71223. (WebCore::getDefaultPangoLayout):
  71224. (WebCore::Font::floatWidthForComplexText):
  71225. (WebCore::Font::offsetForPositionForComplexText):
  71226. (WebCore::Font::selectionRectForComplexText):
  71227. * platform/graphics/gtk/FontPlatformData.h:
  71228. (WebCore::FontPlatformData::FontPlatformData):
  71229. (WebCore::FontPlatformData::hash):
  71230. * platform/graphics/gtk/FontPlatformDataGtk.cpp:
  71231. (WebCore::FontPlatformData::FontPlatformData):
  71232. * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  71233. (WebCore::SimpleFontData::platformDestroy):
  71234. 2008-09-09 Dave Hyatt <hyatt@apple.com>
  71235. Make the Windows classic case work again. Overlap in slider constants and other constants broke
  71236. the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
  71237. value to make sure it's really a slider thumb to resolve this conflict.
  71238. Reviewed by Adam Roben
  71239. * rendering/RenderThemeWin.cpp:
  71240. (WebCore::drawControl):
  71241. 2008-09-05 Chris Marrin <cmarrin@apple.com>
  71242. Reviewed by Sam Weinig.
  71243. Need to handle the case when 0% or 100% keyframe is omitted
  71244. https://bugs.webkit.org/show_bug.cgi?id=20679
  71245. Tests: animations/keyframes-from-missing.html
  71246. animations/keyframes-to-missing.html
  71247. * css/CSSStyleSelector.cpp:
  71248. (WebCore::CSSStyleSelector::addKeyframeStyle):
  71249. 2008-09-09 Dave Hyatt <hyatt@apple.com>
  71250. Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
  71251. RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
  71252. merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
  71253. what changes have been made as compared with the old RenderThemeWin).
  71254. Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
  71255. text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
  71256. vs. printer advancement rounding).
  71257. Reviewed by Adam/Sam
  71258. * css/CSSStyleSelector.cpp:
  71259. (WebCore::CSSStyleSelector::applyProperty):
  71260. * platform/graphics/Icon.h:
  71261. (WebCore::Icon::create):
  71262. * rendering/RenderThemeWin.cpp:
  71263. (WebCore::RenderThemeWin::RenderThemeWin):
  71264. (WebCore::RenderThemeWin::~RenderThemeWin):
  71265. (WebCore::RenderThemeWin::buttonTheme):
  71266. (WebCore::RenderThemeWin::textFieldTheme):
  71267. (WebCore::RenderThemeWin::menuListTheme):
  71268. (WebCore::RenderThemeWin::sliderTheme):
  71269. (WebCore::RenderThemeWin::close):
  71270. (WebCore::RenderThemeWin::themeChanged):
  71271. (WebCore::RenderThemeWin::supportsHover):
  71272. (WebCore::fillFontDescription):
  71273. (WebCore::RenderThemeWin::systemFont):
  71274. (WebCore::RenderThemeWin::supportsFocus):
  71275. (WebCore::RenderThemeWin::determineClassicState):
  71276. (WebCore::RenderThemeWin::determineState):
  71277. (WebCore::RenderThemeWin::determineSliderThumbState):
  71278. (WebCore::RenderThemeWin::getClassicThemeData):
  71279. (WebCore::RenderThemeWin::getThemeData):
  71280. (WebCore::drawControl):
  71281. (WebCore::RenderThemeWin::paintButton):
  71282. (WebCore::RenderThemeWin::paintTextField):
  71283. (WebCore::RenderThemeWin::paintMenuList):
  71284. (WebCore::RenderThemeWin::adjustMenuListStyle):
  71285. (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
  71286. (WebCore::RenderThemeWin::paintMenuListButton):
  71287. (WebCore::RenderThemeWin::paintSliderTrack):
  71288. (WebCore::RenderThemeWin::paintSliderThumb):
  71289. (WebCore::RenderThemeWin::adjustSliderThumbSize):
  71290. (WebCore::RenderThemeWin::paintSearchField):
  71291. (WebCore::RenderThemeWin::adjustSearchFieldStyle):
  71292. (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
  71293. (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
  71294. (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
  71295. (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
  71296. (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
  71297. (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
  71298. (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
  71299. * rendering/RenderThemeWin.h:
  71300. (WebCore::ThemeData::ThemeData):
  71301. (WebCore::RenderThemeWin::paintSearchFieldDecoration):
  71302. (WebCore::RenderThemeWin::adjustButtonStyle):
  71303. (WebCore::RenderThemeWin::adjustTextFieldStyle):
  71304. (WebCore::RenderThemeWin::adjustTextAreaStyle):
  71305. 2008-09-09 Dean Jackson <dino@apple.com>
  71306. Reviewed by Sam Weinig.
  71307. Document::createEvent missing cases for animation and
  71308. transition events.
  71309. https://bugs.webkit.org/show_bug.cgi?id=20734
  71310. Test: transitions/transition-end-event-create.html
  71311. Test: animations/animation-events-create.html
  71312. * dom/Document.cpp:
  71313. (WebCore::Document::createEvent):
  71314. - add the two cases
  71315. 2008-09-09 Dan Bernstein <mitz@apple.com>
  71316. - Tiger build fix
  71317. * WebCore.Tiger.exp:
  71318. * WebCore.base.exp:
  71319. * platform/mac/WebCoreSystemInterface.h:
  71320. * platform/mac/WebCoreSystemInterface.mm:
  71321. 2008-09-09 Dan Bernstein <mitz@apple.com>
  71322. Reviewed by Darin Adler.
  71323. - WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
  71324. * WebCore.Tiger.exp:
  71325. * WebCore.base.exp:
  71326. * platform/graphics/SimpleFontData.h:
  71327. * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  71328. (WebCore::GlyphPage::fill):
  71329. * platform/graphics/mac/SimpleFontDataMac.mm:
  71330. (WebCore::initFontData):
  71331. (WebCore::SimpleFontData::platformInit):
  71332. (WebCore::SimpleFontData::platformDestroy):
  71333. * platform/mac/WebCoreSystemInterface.h:
  71334. * platform/mac/WebCoreSystemInterface.mm:
  71335. 2008-09-09 Kevin McCullough <kmccullough@apple.com>
  71336. Reviewed by Tim.
  71337. <rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
  71338. breakpoints inside eval.
  71339. * page/inspector/inspector.js:
  71340. 2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
  71341. Reviewed by Simon.
  71342. Fix compilation of the Qt port with disabled plugins on Windows
  71343. * WebCore.pro:
  71344. * plugins/PluginView.cpp:
  71345. (WebCore::PluginView::PluginView):
  71346. * plugins/PluginView.h:
  71347. 2008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
  71348. Reviewed by Alexey Proskuryakov.
  71349. Try MIME charset names before trying IANA names
  71350. ( https://bugs.webkit.org/show_bug.cgi?id=17537 )
  71351. With this change, shorter and more widely used names (preferred MIME
  71352. names) are returned by document.charset, document.characterSet,
  71353. document.inputEncoding rather than IANA names. This helps
  71354. fixing bug 18085 in addition to web developers who are more familiar
  71355. with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
  71356. returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
  71357. ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
  71358. Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
  71359. used, the former is still recognized as aliases to the latter so that
  71360. there's very little, if any, to worry about.
  71361. * platform/text/TextCodecICU.cpp:
  71362. (WebCore::TextCodecICU::registerExtendedEncodingNames):
  71363. 2008-09-08 Sam Weinig <sam@webkit.org>
  71364. Reviewed by Maciej Stachowiak and Oliver Hunt.
  71365. Add forwarding headers.
  71366. * ForwardingHeaders/wtf/HashFunctions.h: Added.
  71367. 2008-09-05 Dean Jackson <dino@apple.com>
  71368. Reviewed by Dan Bernstein.
  71369. Update grammar so that we can add a keyframe rule via the DOM.
  71370. https://bugs.webkit.org/show_bug.cgi?id=20613
  71371. * css/CSSGrammar.y:
  71372. * css/tokenizer.flex:
  71373. 2008-09-08 Antti Koivisto <antti@apple.com>
  71374. Reviewed by Dan Bernstein.
  71375. Allow <br> for simple UA stylesheet. Editing code generates them. It does not
  71376. actually show up in any of the default stylesheets.
  71377. * css/CSSStyleSelector.cpp:
  71378. (WebCore::elementCanUseSimpleDefaultStyle):
  71379. 2008-09-08 Dimitri Glazkov <dglazkov@google.com>
  71380. Reviewed by Dan Bernstein.
  71381. - fix https://bugs.webkit.org/show_bug.cgi?id=20237
  71382. Zero width and space characters are displayed incorrectly if not contained in a fallback font
  71383. Adds an extra check for Object Replacement Character (U+FFFC) to address
  71384. the issue with fast/text/zero-width-characters.html test when run
  71385. with Windows system default fonts.
  71386. * platform/graphics/Font.h:
  71387. (WebCore::Font::treatAsZeroWidthSpace):
  71388. 2008-09-08 Dean Jackson <dino@apple.com>
  71389. Reviewed by Sam Weinig.
  71390. Code style issue I forgot to fix from previous commit.
  71391. * platform/graphics/AffineTransform.cpp:
  71392. (WebCore::AffineTransform::blend):
  71393. 2008-09-08 Chris Marrin <cmarrin@apple.com>
  71394. Reviewed by Sam Weinig
  71395. - Animation of -webkit-transform matrix() function should not do linear interpolation
  71396. https://bugs.webkit.org/show_bug.cgi?id=20667
  71397. Test: animations/matrix-anim.html
  71398. * ChangeLog:
  71399. * platform/graphics/AffineTransform.cpp:
  71400. (WebCore::affineTransformDecompose):
  71401. (WebCore::affineTransformCompose):
  71402. (WebCore::AffineTransform::blend):
  71403. * platform/graphics/AffineTransform.h:
  71404. * rendering/style/RenderStyle.cpp:
  71405. (WebCore::MatrixTransformOperation::blend):
  71406. 2008-09-08 Alexey Proskuryakov <ap@webkit.org>
  71407. Reviewed by Darin Adler.
  71408. https://bugs.webkit.org/show_bug.cgi?id=20668
  71409. multipart/form-data does not always include Content-type for submitted files
  71410. Cannot be tested with DRT or manual tests.
  71411. * platform/MIMETypeRegistry.cpp:
  71412. (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
  71413. (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
  71414. unknown extensions, not just missing ones.
  71415. 2008-09-08 Simon Hausmann <hausmann@webkit.org>
  71416. Build fix for the Qt/Windows build, define USE_JSC to
  71417. enable the WebCore::String -> JSC::UString operator that
  71418. MSVC insists on seeing
  71419. * WebCore.pro:
  71420. 2008-09-08 Anders Carlsson <andersca@apple.com>
  71421. Reviewed by Maciej.
  71422. <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
  71423. In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
  71424. page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
  71425. Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
  71426. * bindings/js/JSDOMWindowBase.h:
  71427. * loader/FrameLoader.cpp:
  71428. (WebCore::FrameLoader::commitProvisionalLoad):
  71429. 2008-09-07 Antti Koivisto <antti@apple.com>
  71430. Reviewed by Dave Hyatt.
  71431. Don't leak the simple stylesheet.
  71432. Also call RenderTheme::adjustDefaultStyleSheet() in right place.
  71433. * css/CSSStyleSelector.cpp:
  71434. (WebCore::loadFullDefaultStyle):
  71435. (WebCore::loadSimpleDefaultStyle):
  71436. (WebCore::CSSStyleSelector::styleForElement):
  71437. 2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  71438. Reviewed by Oliver Hunt.
  71439. Bug 20711: Change KJS prefix on preprocessor macros to JSC
  71440. <https://bugs.webkit.org/show_bug.cgi?id=20711>
  71441. * bindings/js/JSEventTargetBase.h:
  71442. * bindings/js/JSHTMLInputElementBase.cpp:
  71443. * bindings/js/JSHTMLInputElementBase.h:
  71444. * bindings/scripts/CodeGeneratorJS.pm:
  71445. 2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  71446. Reviewed by Maciej Stachowiak.
  71447. Bug 20704: Replace the KJS namespace
  71448. <https://bugs.webkit.org/show_bug.cgi?id=20704>
  71449. Rename the KJS namespace to JSC. There are still some uses of KJS in the
  71450. names of JNI functions, and I will check if these are safe to change
  71451. as well.
  71452. * WebCore.base.exp:
  71453. * bindings/js/GCController.cpp:
  71454. * bindings/js/JSAttrCustom.cpp:
  71455. * bindings/js/JSAudioConstructor.cpp:
  71456. * bindings/js/JSAudioConstructor.h:
  71457. (WebCore::JSAudioConstructor::classInfo):
  71458. * bindings/js/JSCSSRuleCustom.cpp:
  71459. * bindings/js/JSCSSStyleDeclarationCustom.cpp:
  71460. * bindings/js/JSCSSValueCustom.cpp:
  71461. * bindings/js/JSCanvasPixelArrayCustom.cpp:
  71462. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  71463. * bindings/js/JSClipboardCustom.cpp:
  71464. * bindings/js/JSConsoleCustom.cpp:
  71465. * bindings/js/JSCustomSQLStatementCallback.cpp:
  71466. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  71467. * bindings/js/JSCustomSQLStatementCallback.h:
  71468. (WebCore::JSCustomSQLStatementCallback::create):
  71469. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  71470. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  71471. * bindings/js/JSCustomSQLStatementErrorCallback.h:
  71472. (WebCore::JSCustomSQLStatementErrorCallback::create):
  71473. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  71474. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  71475. * bindings/js/JSCustomSQLTransactionCallback.h:
  71476. (WebCore::JSCustomSQLTransactionCallback::create):
  71477. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  71478. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  71479. * bindings/js/JSCustomSQLTransactionErrorCallback.h:
  71480. (WebCore::JSCustomSQLTransactionErrorCallback::create):
  71481. * bindings/js/JSCustomVoidCallback.cpp:
  71482. (WebCore::JSCustomVoidCallback::handleEvent):
  71483. * bindings/js/JSCustomVoidCallback.h:
  71484. (WebCore::JSCustomVoidCallback::create):
  71485. * bindings/js/JSCustomXPathNSResolver.cpp:
  71486. (WebCore::JSCustomXPathNSResolver::create):
  71487. * bindings/js/JSCustomXPathNSResolver.h:
  71488. * bindings/js/JSDOMApplicationCacheCustom.cpp:
  71489. (WebCore::JSDOMApplicationCache::dispatchEvent):
  71490. * bindings/js/JSDOMBinding.cpp:
  71491. (WebCore::jsOwnedStringOrNull):
  71492. * bindings/js/JSDOMBinding.h:
  71493. (WebCore::DOMObject::DOMObject):
  71494. (WebCore::cacheDOMObject):
  71495. (WebCore::cacheSVGDOMObject):
  71496. (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
  71497. (WebCore::toJS):
  71498. * bindings/js/JSDOMWindowBase.cpp:
  71499. * bindings/js/JSDOMWindowBase.h:
  71500. (WebCore::JSDOMWindowBase::classInfo):
  71501. (WebCore::JSDOMWindowBase::d):
  71502. * bindings/js/JSDOMWindowCustom.cpp:
  71503. (WebCore::JSDOMWindow::getPropertyAttributes):
  71504. * bindings/js/JSDOMWindowCustom.h:
  71505. (WebCore::asJSDOMWindow):
  71506. (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  71507. (WebCore::JSDOMWindow::customPut):
  71508. (WebCore::JSDOMWindowBase::allowsAccessFrom):
  71509. (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
  71510. * bindings/js/JSDOMWindowShell.cpp:
  71511. (WebCore::JSDOMWindowShell::getPropertyAttributes):
  71512. * bindings/js/JSDOMWindowShell.h:
  71513. (WebCore::JSDOMWindowShell::classInfo):
  71514. * bindings/js/JSDatabaseCustom.cpp:
  71515. * bindings/js/JSDocumentCustom.cpp:
  71516. * bindings/js/JSDocumentFragmentCustom.cpp:
  71517. * bindings/js/JSElementCustom.cpp:
  71518. * bindings/js/JSEventCustom.cpp:
  71519. * bindings/js/JSEventListener.cpp:
  71520. * bindings/js/JSEventListener.h:
  71521. (WebCore::JSUnprotectedEventListener::create):
  71522. (WebCore::JSEventListener::create):
  71523. * bindings/js/JSEventTargetBase.cpp:
  71524. * bindings/js/JSEventTargetBase.h:
  71525. (WebCore::JSEventTargetBase::getValueProperty):
  71526. (WebCore::JSEventTargetBase::putValueProperty):
  71527. (WebCore::JSEventTargetBase::getOwnPropertySlot):
  71528. (WebCore::JSEventTargetBase::put):
  71529. (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
  71530. (WebCore::JSEventTargetPrototype::self):
  71531. (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
  71532. (WebCore::JSEventTargetPrototype::classInfo):
  71533. * bindings/js/JSEventTargetNode.cpp:
  71534. * bindings/js/JSEventTargetNode.h:
  71535. (WebCore::JSEventTargetNode::getOwnPropertySlot):
  71536. (WebCore::JSEventTargetNode::getValueProperty):
  71537. (WebCore::JSEventTargetNode::put):
  71538. (WebCore::JSEventTargetNode::putValueProperty):
  71539. * bindings/js/JSHTMLAllCollection.h:
  71540. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
  71541. (WebCore::JSHTMLAllCollection::toBoolean):
  71542. * bindings/js/JSHTMLAppletElementCustom.cpp:
  71543. * bindings/js/JSHTMLCollectionCustom.cpp:
  71544. * bindings/js/JSHTMLDocumentCustom.cpp:
  71545. * bindings/js/JSHTMLElementCustom.cpp:
  71546. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  71547. * bindings/js/JSHTMLFormElementCustom.cpp:
  71548. * bindings/js/JSHTMLFrameElementCustom.cpp:
  71549. * bindings/js/JSHTMLFrameSetElementCustom.cpp:
  71550. * bindings/js/JSHTMLIFrameElementCustom.cpp:
  71551. * bindings/js/JSHTMLInputElementBase.cpp:
  71552. (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
  71553. (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
  71554. * bindings/js/JSHTMLInputElementBase.h:
  71555. (WebCore::JSHTMLInputElementBase::classInfo):
  71556. * bindings/js/JSHTMLObjectElementCustom.cpp:
  71557. * bindings/js/JSHTMLOptionElementConstructor.cpp:
  71558. * bindings/js/JSHTMLOptionElementConstructor.h:
  71559. (WebCore::JSHTMLOptionElementConstructor::classInfo):
  71560. * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  71561. * bindings/js/JSHTMLSelectElementCustom.cpp:
  71562. (WebCore::selectIndexSetter):
  71563. (WebCore::JSHTMLSelectElement::indexSetter):
  71564. * bindings/js/JSHTMLSelectElementCustom.h:
  71565. * bindings/js/JSHistoryCustom.cpp:
  71566. * bindings/js/JSImageConstructor.cpp:
  71567. * bindings/js/JSImageConstructor.h:
  71568. (WebCore::JSImageConstructor::classInfo):
  71569. * bindings/js/JSInspectedObjectWrapper.cpp:
  71570. * bindings/js/JSInspectedObjectWrapper.h:
  71571. (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
  71572. (WebCore::JSInspectedObjectWrapper::classInfo):
  71573. * bindings/js/JSInspectorCallbackWrapper.cpp:
  71574. * bindings/js/JSInspectorCallbackWrapper.h:
  71575. (WebCore::JSInspectorCallbackWrapper::classInfo):
  71576. (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
  71577. * bindings/js/JSJavaScriptCallFrameCustom.cpp:
  71578. * bindings/js/JSLocationCustom.cpp:
  71579. * bindings/js/JSMimeTypeArrayCustom.cpp:
  71580. * bindings/js/JSNSResolver.cpp:
  71581. * bindings/js/JSNSResolver.h:
  71582. (WebCore::JSNSResolver::create):
  71583. * bindings/js/JSNamedNodeMapCustom.cpp:
  71584. * bindings/js/JSNamedNodesCollection.cpp:
  71585. (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
  71586. * bindings/js/JSNamedNodesCollection.h:
  71587. (WebCore::JSNamedNodesCollection::classInfo):
  71588. * bindings/js/JSNavigatorCustom.cpp:
  71589. * bindings/js/JSNodeCustom.cpp:
  71590. * bindings/js/JSNodeFilterCondition.cpp:
  71591. (WebCore::JSNodeFilterCondition::acceptNode):
  71592. * bindings/js/JSNodeFilterCondition.h:
  71593. (WebCore::JSNodeFilterCondition::create):
  71594. * bindings/js/JSNodeFilterCustom.cpp:
  71595. * bindings/js/JSNodeIteratorCustom.cpp:
  71596. * bindings/js/JSNodeListCustom.cpp:
  71597. * bindings/js/JSPluginArrayCustom.cpp:
  71598. * bindings/js/JSPluginCustom.cpp:
  71599. * bindings/js/JSPluginElementFunctions.cpp:
  71600. (WebCore::getRuntimeObject):
  71601. * bindings/js/JSPluginElementFunctions.h:
  71602. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  71603. (WebCore::JSQuarantinedObjectWrapper::construct):
  71604. (WebCore::JSQuarantinedObjectWrapper::call):
  71605. * bindings/js/JSQuarantinedObjectWrapper.h:
  71606. (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
  71607. (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
  71608. (WebCore::JSQuarantinedObjectWrapper::className):
  71609. * bindings/js/JSRGBColor.cpp:
  71610. * bindings/js/JSRGBColor.h:
  71611. (WebCore::JSRGBColor::classInfo):
  71612. * bindings/js/JSSQLResultSetRowListCustom.cpp:
  71613. * bindings/js/JSSQLTransactionCustom.cpp:
  71614. * bindings/js/JSSVGLazyEventListener.cpp:
  71615. * bindings/js/JSSVGLazyEventListener.h:
  71616. * bindings/js/JSSVGLengthCustom.cpp:
  71617. * bindings/js/JSSVGMatrixCustom.cpp:
  71618. (WebCore::JSSVGMatrix::inverse):
  71619. (WebCore::JSSVGMatrix::rotateFromVector):
  71620. * bindings/js/JSSVGPathSegCustom.cpp:
  71621. * bindings/js/JSSVGPathSegListCustom.cpp:
  71622. (WebCore::JSSVGPathSegList::initialize):
  71623. (WebCore::JSSVGPathSegList::getItem):
  71624. (WebCore::JSSVGPathSegList::insertItemBefore):
  71625. (WebCore::JSSVGPathSegList::replaceItem):
  71626. (WebCore::JSSVGPathSegList::removeItem):
  71627. (WebCore::JSSVGPathSegList::appendItem):
  71628. * bindings/js/JSSVGPointListCustom.cpp:
  71629. * bindings/js/JSSVGTransformListCustom.cpp:
  71630. * bindings/js/JSStorageCustom.cpp:
  71631. * bindings/js/JSStyleSheetCustom.cpp:
  71632. * bindings/js/JSStyleSheetListCustom.cpp:
  71633. * bindings/js/JSTextCustom.cpp:
  71634. * bindings/js/JSTreeWalkerCustom.cpp:
  71635. * bindings/js/JSXMLHttpRequestConstructor.cpp:
  71636. * bindings/js/JSXMLHttpRequestConstructor.h:
  71637. (WebCore::JSXMLHttpRequestConstructor::classInfo):
  71638. * bindings/js/JSXMLHttpRequestCustom.cpp:
  71639. * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  71640. * bindings/js/JSXSLTProcessorConstructor.cpp:
  71641. * bindings/js/JSXSLTProcessorConstructor.h:
  71642. (WebCore::JSXSLTProcessorConstructor::classInfo):
  71643. * bindings/js/JSXSLTProcessorCustom.cpp:
  71644. * bindings/js/ScheduledAction.cpp:
  71645. * bindings/js/ScheduledAction.h:
  71646. * bindings/js/ScriptController.cpp:
  71647. (WebCore::ScriptController::attachDebugger):
  71648. (WebCore::ScriptController::windowScriptNPObject):
  71649. * bindings/js/ScriptController.h:
  71650. * bindings/js/ScriptControllerGtk.cpp:
  71651. (WebCore::ScriptController::createScriptInstanceForWidget):
  71652. * bindings/js/ScriptControllerMac.mm:
  71653. (WebCore::ScriptController::createScriptInstanceForWidget):
  71654. (WebCore::ScriptController::windowScriptObject):
  71655. (WebCore::ScriptController::clearPlatformScriptObjects):
  71656. (WebCore::updateRenderingForBindings):
  71657. (WebCore::ScriptController::initJavaJSBindings):
  71658. * bindings/js/ScriptControllerQt.cpp:
  71659. (WebCore::ScriptController::createScriptInstanceForWidget):
  71660. * bindings/js/ScriptControllerWin.cpp:
  71661. (WebCore::ScriptController::createScriptInstanceForWidget):
  71662. * bindings/js/ScriptControllerWx.cpp:
  71663. (WebCore::ScriptController::createScriptInstanceForWidget):
  71664. * bindings/js/StringSourceProvider.h:
  71665. (WebCore::StringSourceProvider::getRange):
  71666. * bindings/objc/DOM.mm:
  71667. (-[DOMNode JSC::Bindings::]):
  71668. * bindings/objc/DOMInternal.h:
  71669. * bindings/objc/DOMInternal.mm:
  71670. (-[WebScriptObject _initializeScriptDOMNodeImp]):
  71671. * bindings/objc/DOMUtility.mm:
  71672. (JSC::createDOMWrapper):
  71673. (WebCore::createDOMWrapper):
  71674. * bindings/objc/WebScriptObject.mm:
  71675. (WebCore::createJSWrapper):
  71676. (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
  71677. * bindings/objc/WebScriptObjectPrivate.h:
  71678. * bindings/scripts/CodeGeneratorJS.pm:
  71679. * bridge/NP_jsobject.cpp:
  71680. * bridge/NP_jsobject.h:
  71681. * bridge/c/c_class.cpp:
  71682. * bridge/c/c_class.h:
  71683. * bridge/c/c_instance.cpp:
  71684. * bridge/c/c_instance.h:
  71685. * bridge/c/c_runtime.cpp:
  71686. * bridge/c/c_runtime.h:
  71687. * bridge/c/c_utility.cpp:
  71688. * bridge/c/c_utility.h:
  71689. * bridge/jni/jni_class.cpp:
  71690. * bridge/jni/jni_class.h:
  71691. * bridge/jni/jni_instance.cpp:
  71692. * bridge/jni/jni_instance.h:
  71693. * bridge/jni/jni_jsobject.h:
  71694. * bridge/jni/jni_jsobject.mm:
  71695. (JavaJSObject::call):
  71696. (JavaJSObject::convertJObjectToValue):
  71697. * bridge/jni/jni_objc.mm:
  71698. (JSC::Bindings::dispatchJNICall):
  71699. * bridge/jni/jni_runtime.cpp:
  71700. * bridge/jni/jni_runtime.h:
  71701. * bridge/jni/jni_utility.cpp:
  71702. * bridge/jni/jni_utility.h:
  71703. * bridge/npruntime.cpp:
  71704. (_NPN_GetStringIdentifier):
  71705. * bridge/objc/WebScriptObject.h:
  71706. * bridge/objc/objc_class.h:
  71707. * bridge/objc/objc_class.mm:
  71708. * bridge/objc/objc_instance.h:
  71709. * bridge/objc/objc_instance.mm:
  71710. * bridge/objc/objc_runtime.h:
  71711. * bridge/objc/objc_runtime.mm:
  71712. * bridge/objc/objc_utility.h:
  71713. * bridge/objc/objc_utility.mm:
  71714. * bridge/qt/qt_class.cpp:
  71715. * bridge/qt/qt_class.h:
  71716. * bridge/qt/qt_instance.cpp:
  71717. * bridge/qt/qt_instance.h:
  71718. * bridge/qt/qt_runtime.cpp:
  71719. (JSC::Bindings::convertQVariantToValue):
  71720. (JSC::Bindings::):
  71721. * bridge/qt/qt_runtime.h:
  71722. * bridge/runtime.cpp:
  71723. * bridge/runtime.h:
  71724. * bridge/runtime_array.cpp:
  71725. * bridge/runtime_array.h:
  71726. * bridge/runtime_method.cpp:
  71727. * bridge/runtime_method.h:
  71728. * bridge/runtime_object.cpp:
  71729. * bridge/runtime_object.h:
  71730. * bridge/runtime_root.cpp:
  71731. (JSC::Bindings::RootObject::invalidate):
  71732. (JSC::Bindings::RootObject::gcProtect):
  71733. (JSC::Bindings::RootObject::gcUnprotect):
  71734. * bridge/runtime_root.h:
  71735. * bridge/testbindings.cpp:
  71736. * bridge/testbindings.mm:
  71737. * bridge/testqtbindings.cpp:
  71738. * dom/Document.cpp:
  71739. (WebCore::Document::~Document):
  71740. * dom/NSResolver.h:
  71741. * dom/Node.cpp:
  71742. (WebCore::Node::setDocument):
  71743. (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
  71744. (WebCore::resolveNamespacesForSelector):
  71745. (WebCore::Node::querySelector):
  71746. (WebCore::Node::querySelectorAll):
  71747. * dom/Node.h:
  71748. * dom/NodeFilter.cpp:
  71749. * dom/NodeFilter.h:
  71750. * dom/NodeFilterCondition.cpp:
  71751. * dom/NodeFilterCondition.h:
  71752. * dom/NodeIterator.cpp:
  71753. * dom/NodeIterator.h:
  71754. * dom/Traversal.cpp:
  71755. * dom/Traversal.h:
  71756. * dom/TreeWalker.cpp:
  71757. * dom/TreeWalker.h:
  71758. * dom/make_names.pl:
  71759. * history/CachedPage.cpp:
  71760. * history/CachedPage.h:
  71761. * html/HTMLPlugInElement.cpp:
  71762. (WebCore::HTMLPlugInElement::getInstance):
  71763. * html/HTMLPlugInElement.h:
  71764. * loader/FrameLoader.cpp:
  71765. * loader/FrameLoader.h:
  71766. * loader/icon/IconDatabase.cpp:
  71767. (WebCore::iconDatabase):
  71768. * page/Console.cpp:
  71769. * page/Console.h:
  71770. * page/InspectorController.cpp:
  71771. (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
  71772. (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
  71773. (WebCore::InspectorResource::setXMLHttpRequestProperties):
  71774. (WebCore::InspectorResource::sourceString):
  71775. (WebCore::getResourceDocumentNode):
  71776. (WebCore::search):
  71777. (WebCore::InspectorController::focusNode):
  71778. (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
  71779. (WebCore::InspectorController::addDatabaseScriptResource):
  71780. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  71781. * page/InspectorController.h:
  71782. (WebCore::InspectorController::profiles):
  71783. * page/JavaScriptCallFrame.cpp:
  71784. (WebCore::JavaScriptCallFrame::scopeChain):
  71785. * page/JavaScriptCallFrame.h:
  71786. (WebCore::JavaScriptCallFrame::create):
  71787. (WebCore::JavaScriptCallFrame::update):
  71788. * page/JavaScriptDebugListener.h:
  71789. * page/JavaScriptDebugServer.cpp:
  71790. (WebCore::dispatchDidParseSource):
  71791. * page/JavaScriptDebugServer.h:
  71792. * page/JavaScriptProfile.cpp:
  71793. * page/JavaScriptProfile.h:
  71794. * page/JavaScriptProfileNode.cpp:
  71795. (WebCore::getTotalTime):
  71796. (WebCore::getSelfTime):
  71797. (WebCore::getTotalPercent):
  71798. (WebCore::getSelfPercent):
  71799. (WebCore::getNumberOfCalls):
  71800. (WebCore::getChildren):
  71801. (WebCore::getVisible):
  71802. * page/JavaScriptProfileNode.h:
  71803. * page/Page.cpp:
  71804. (WebCore::Page::setDebuggerForAllPages):
  71805. (WebCore::Page::setDebugger):
  71806. * page/Page.h:
  71807. (WebCore::Page::debugger):
  71808. * page/mac/FrameMac.mm:
  71809. * platform/KURL.h:
  71810. (WebCore::KURL::operator JSC::UString):
  71811. * platform/text/AtomicString.cpp:
  71812. (WebCore::AtomicString::add):
  71813. (WebCore::AtomicString::find):
  71814. * platform/text/AtomicString.h:
  71815. (WebCore::AtomicString::AtomicString):
  71816. * platform/text/PlatformString.h:
  71817. * platform/text/String.cpp:
  71818. (WebCore::charactersToDouble):
  71819. * platform/win/BString.cpp:
  71820. * platform/win/BString.h:
  71821. * plugins/MimeTypeArray.h:
  71822. * plugins/Plugin.h:
  71823. * plugins/PluginArray.h:
  71824. * plugins/PluginView.cpp:
  71825. (WebCore::PluginView::start):
  71826. (WebCore::PluginView::performRequest):
  71827. (WebCore::PluginView::bindingInstance):
  71828. * plugins/PluginView.h:
  71829. * plugins/gtk/PluginViewGtk.cpp:
  71830. (WebCore::PluginView::paint):
  71831. (WebCore::PluginView::handleKeyboardEvent):
  71832. (WebCore::PluginView::handleMouseEvent):
  71833. (WebCore::PluginView::setNPWindowRect):
  71834. (WebCore::PluginView::stop):
  71835. (WebCore::PluginView::init):
  71836. * plugins/qt/PluginViewQt.cpp:
  71837. (WebCore::PluginView::setNPWindowRect):
  71838. (WebCore::PluginView::stop):
  71839. (WebCore::PluginView::init):
  71840. * plugins/win/PluginViewWin.cpp:
  71841. (WebCore::PluginView::dispatchNPEvent):
  71842. (WebCore::PluginView::handleKeyboardEvent):
  71843. (WebCore::PluginView::handleMouseEvent):
  71844. (WebCore::PluginView::setNPWindowRect):
  71845. (WebCore::PluginView::stop):
  71846. * storage/Database.cpp:
  71847. (WebCore::Database::Database):
  71848. * xml/XMLHttpRequest.cpp:
  71849. (WebCore::XMLHttpRequest::responseText):
  71850. (WebCore::XMLHttpRequest::loadRequestAsynchronously):
  71851. (WebCore::XMLHttpRequest::clearResponse):
  71852. (WebCore::XMLHttpRequest::dropProtection):
  71853. (WebCore::XMLHttpRequest::didFinishLoading):
  71854. (WebCore::XMLHttpRequest::didReceiveData):
  71855. * xml/XMLHttpRequest.h:
  71856. 2008-09-07 Adam Barth <abarth@webkit.org>
  71857. Reviewed by Sam Weinig.
  71858. Adopt opener restriction on frame navigation.
  71859. https://bugs.webkit.org/show_bug.cgi?id=20642
  71860. This restriction helps prevent an attacker from navigating top-level
  71861. windows that were created by another web site.
  71862. Tests: http/tests/security/frameNavigation/not-opener.html
  71863. http/tests/security/frameNavigation/opener.html
  71864. * loader/FrameLoader.cpp:
  71865. (WebCore::canAccessAncestor):
  71866. (WebCore::FrameLoader::shouldAllowNavigation):
  71867. 2008-09-07 Dan Bernstein <mitz@apple.com>
  71868. Reviewed by Maciej Stachowiak.
  71869. - use the correct sign for vertical offsets of combining marks
  71870. * platform/graphics/win/UniscribeController.cpp:
  71871. (WebCore::UniscribeController::shapeAndPlaceItem):
  71872. 2008-09-07 Dan Bernstein <mitz@apple.com>
  71873. Reviewed by Dave Hyatt.
  71874. - add the combining mark offsets in two places where I forgot them
  71875. * platform/graphics/win/FontCGWin.cpp:
  71876. (WebCore::Font::drawGlyphs):
  71877. 2008-09-07 Dan Bernstein <mitz@apple.com>
  71878. Reviewed by Dave Hyatt.
  71879. - correct glyph advances in complex text using web fonts rendered with
  71880. Core Graphics
  71881. * platform/graphics/win/FontCustomPlatformData.cpp:
  71882. (WebCore::FontCustomPlatformData::fontPlatformData):
  71883. 2008-09-07 Keishi Hattori <casey.hattori@gmail.com>
  71884. Adds console.dirxml support to the Web Inspector.
  71885. https://bugs.webkit.org/show_bug.cgi?id=19156
  71886. Reviewed by Timothy Hatcher.
  71887. * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
  71888. * bindings/js/JSConsoleCustom.cpp:
  71889. (WebCore::JSConsole::dirxml):
  71890. * page/Console.cpp:
  71891. (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
  71892. * page/Console.h:
  71893. (WebCore::): Added NodeMessageLevel.
  71894. * page/Console.idl: Added console.dirxml.
  71895. * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
  71896. * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
  71897. in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
  71898. * page/inspector/ElementsTreeOutline.js: Added.
  71899. (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
  71900. (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
  71901. * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
  71902. * page/inspector/inspector.css:
  71903. * page/inspector/inspector.html: Added ElementsTreeOutline.js.
  71904. * page/inspector/inspector.js: Moved hover related methods to WebInspector.
  71905. (WebInspector.altKeyDown):
  71906. (WebInspector.forceHoverHighlight):
  71907. (WebInspector.hoveredDOMNode):
  71908. (WebInspector._updateHoverHighlightSoon):
  71909. (WebInspector._updateHoverHighlight):
  71910. (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
  71911. (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
  71912. * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
  71913. isAncestorIncludingParentFrames.
  71914. 2008-09-06 Mark Rowe <mrowe@apple.com>
  71915. Qt build fix.
  71916. * bridge/qt/qt_runtime.cpp:
  71917. (KJS::Bindings::convertQVariantToValue):
  71918. === End merge of squirrelfish-extreme ===
  71919. 2008-09-05 Oliver Hunt <oliver@apple.com>
  71920. Start bringing up SFX on windows.
  71921. Reviewed by Mark Rowe and Sam Weinig
  71922. Start doing the work to bring up SFX on windows. Initially
  71923. just working on WREC, as it does not make any calls so reduces
  71924. the amount of code that needs to be corrected.
  71925. Add forwarding headers
  71926. * ChangeLog:
  71927. * ForwardingHeaders/masm/MacroAssembler.h: Added.
  71928. * WebCore.vcproj/WebCore.vcproj:
  71929. 2008-08-27 Mark Rowe <mrowe@apple.com>
  71930. Reviewed by Oliver Hunt.
  71931. Fix the build of the full WebKit stack.
  71932. Add forwarding headers.
  71933. * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
  71934. * ForwardingHeaders/wrec/WREC.h: Added.
  71935. === Start merge of squirrelfish-extreme ===
  71936. 2008-09-06 Antti Koivisto <antti@apple.com>
  71937. Reviewed by Dave Hyatt.
  71938. <rdar://problem/6187043>
  71939. Don't parse full HTML user agent style sheet unless it is actually needed
  71940. <rdar://problem/6131889>
  71941. WebView is significantly more expensive to create recently
  71942. Parsing the html4.css takes significant amount of time and memory (~50kb) on application
  71943. startup. Some clients may never use most of the rules.
  71944. With this patch we use simplified UA stylesheet until we hit something it can't handle.
  71945. This avoids full stylesheet parsing on application startup (due to empty document construction)
  71946. and also makes it possible for clients with very simple demands (divs and spans only) never to load
  71947. the full style.
  71948. It also delays view source style parsing until it is used.
  71949. * css/CSSStyleSelector.cpp:
  71950. (WebCore::elementCanUseSimpleDefaultStyle):
  71951. (WebCore::CSSStyleSelector::CSSStyleSelector):
  71952. (WebCore::loadFullDefaultStyle):
  71953. (WebCore::loadSimpleDefaultStyle):
  71954. (WebCore::loadViewSourceStyle):
  71955. (WebCore::CSSStyleSelector::matchUARules):
  71956. (WebCore::CSSStyleSelector::styleForElement):
  71957. 2008-09-06 Kevin Ollivier <kevino@theolliviers.com>
  71958. wx build fix.
  71959. * WebCoreSources.bkl:
  71960. 2008-09-06 Antti Koivisto <antti@apple.com>
  71961. Reverting r35953 which was causing problems on Windows which relies on
  71962. WebCore timers in nested event loops. r36132 did alternative fix.
  71963. * page/Chrome.cpp:
  71964. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  71965. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  71966. 2008-09-06 Antti Koivisto <antti@apple.com>
  71967. Reviewed by Dan Bernstein.
  71968. Fix <rdar://problem/6201644>
  71969. https://bugs.webkit.org/show_bug.cgi?id=20493
  71970. Crash after OK in dialog box and reloading page in secure mode
  71971. Limited loader only fix since the general timer fix is causing problems on Windows.
  71972. * loader/loader.cpp:
  71973. (WebCore::Loader::servePendingRequests):
  71974. (WebCore::Loader::Host::Host):
  71975. (WebCore::Loader::Host::didFinishLoading):
  71976. (WebCore::Loader::Host::didFail):
  71977. (WebCore::Loader::Host::didReceiveData):
  71978. * loader/loader.h:
  71979. (WebCore::Loader::Host::processingResource):
  71980. 2008-09-06 Dan Bernstein <mitz@apple.com>
  71981. Reviewed by Dave Hyatt.
  71982. The initial Core Text adoption prototype was made by Daniel Fenwick.
  71983. - <rdar://problem/5158514> Add a Core Text-based complex text code path
  71984. Currently the Core Text code path is not used in any configuration.
  71985. * WebCore.xcodeproj/project.pbxproj: Added files.
  71986. * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
  71987. * platform/graphics/Font.cpp:
  71988. (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
  71989. of the loop.
  71990. * platform/graphics/GlyphBuffer.h:
  71991. (WebCore::GlyphBuffer::add): Added this version that takes an advance.
  71992. * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
  71993. Added getCTFont() and getCFStringAttributes() and corresponding data
  71994. members for Core Text.
  71995. * platform/graphics/mac/CoreTextController.cpp: Added.
  71996. (WebCore::roundCGFloat): Helper function.
  71997. (WebCore::ceilCGFloat): Helper function.
  71998. (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
  71999. (WebCore::CoreTextController::CoreTextController):
  72000. (WebCore::CoreTextController::offsetForPosition):
  72001. (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
  72002. run into subruns as necessary such that each subrun can be rendered with
  72003. a single font. Also separates out soft hyphens and replaces them with
  72004. real hyphens, because Core Text does not emit a glyph for soft hyphens.
  72005. Then calls collectCoreTextRunsForCharacters() on each subrun.
  72006. (WebCore::CoreTextController::advance):
  72007. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
  72008. a CTLine from the given subrun and collects its CoreTextRuns.
  72009. (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
  72010. rounding hacks, letter- and word-spacing and glyph substitutions and
  72011. stores the resulting adjusted glyphs and advances.
  72012. * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
  72013. (WebCore::CoreTextController::totalWidth):
  72014. (WebCore::CoreTextController::finalRoundingWidth):
  72015. (WebCore::CoreTextController::CoreTextRun::ctRun):
  72016. (WebCore::CoreTextController::CoreTextRun::glyphCount):
  72017. (WebCore::CoreTextController::CoreTextRun::fontData):
  72018. (WebCore::CoreTextController::CoreTextRun::characters):
  72019. (WebCore::CoreTextController::CoreTextRun::stringLocation):
  72020. (WebCore::CoreTextController::CoreTextRun::stringLength):
  72021. (WebCore::CoreTextController::CoreTextRun::indexAt):
  72022. * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
  72023. FontMacATSUI.mm.
  72024. * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
  72025. (WebCore::disableLigatures): Changed to call
  72026. FontPlatformData::allowsLigatures().
  72027. (WebCore::overrideLayoutOperation): Changed to call
  72028. FontPlatformData::roundsGlyphAdvances().
  72029. * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
  72030. (WebCore::Font::selectionRectForComplexText): Changed to use
  72031. totalWidth() instead of advancing to the end and using runWidthSoFar().
  72032. (WebCore::Font::drawComplexText):
  72033. (WebCore::Font::floatWidthForComplexText): Ditto.
  72034. (WebCore::Font::offsetForPositionForComplexText):
  72035. * platform/graphics/mac/FontPlatformData.h:
  72036. * platform/graphics/mac/FontPlatformDataMac.mm:
  72037. (WebCore::FontPlatformData::setFont):
  72038. (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
  72039. AppKit rendering mode.
  72040. (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
  72041. heuristic that allows ligatures in fonts that do not have a glyph for
  72042. 'a', based on the assumption that such fonts are only used in complex
  72043. text.
  72044. * platform/graphics/mac/SimpleFontDataMac.mm:
  72045. (WebCore::SimpleFontData::platformInit):
  72046. (WebCore::SimpleFontData::platformDestroy):
  72047. (WebCore::SimpleFontData::getCTFont): Added.
  72048. (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
  72049. returns an attributes dictionary.
  72050. * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
  72051. * platform/text/mac/ShapeArabic.h: Ditto.
  72052. 2008-09-06 Dan Bernstein <mitz@apple.com>
  72053. Reviewed by Dave Hyatt.
  72054. - make combining mark offsets work in CG text on Windows
  72055. * platform/graphics/win/FontCGWin.cpp:
  72056. (WebCore::Font::drawGlyphs): The old code tried to translate the text
  72057. matrix, but failed for two reasons: it did not actually change the
  72058. matrix, and even if it did, CGContextSetTextPosition overwrites the
  72059. translation values in the text matrix. Instead, just added the
  72060. translation to the anchor point.
  72061. 2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
  72062. Reviewed by Alp Toker.
  72063. https://bugs.webkit.org/show_bug.cgi?id=18346
  72064. [GTK] Remove build warnings
  72065. Applied some casts, and removed an unused typedef to make the
  72066. compiler happy, printing less warnings when building.
  72067. * page/gtk/AccessibilityObjectWrapperAtk.cpp:
  72068. * platform/graphics/gtk/SimpleFontDataPango.cpp:
  72069. (WebCore::SimpleFontData::containsCharacters):
  72070. * platform/graphics/gtk/VideoSinkGStreamer.cpp:
  72071. (webkit_video_sink_set_caps):
  72072. * platform/network/soup/ResourceHandleSoup.cpp:
  72073. 2008-09-05 Eric Seidel <eric@webkit.org>
  72074. Reviewed by Adam Roben.
  72075. Build fix for WebKitWin and Chromium
  72076. * platform/FileSystem.h:
  72077. 2008-09-05 Eric Seidel <eric@webkit.org>
  72078. Reviewed by Darin Adler.
  72079. Try to make Chromium compile with ToT:
  72080. - Wrap a few places which depend on KJS:: in #if USE(JSC)
  72081. - Include some windows forward declarations
  72082. * dom/Node.h:
  72083. * page/Console.h:
  72084. * page/animation/CompositeAnimation.h:
  72085. * platform/FileSystem.h:
  72086. * platform/graphics/Image.h:
  72087. * platform/text/AtomicString.h:
  72088. * platform/text/String.cpp:
  72089. * rendering/style/RenderStyle.h:
  72090. 2008-09-05 Dave Hyatt <hyatt@apple.com>
  72091. Add support for runtime switchability of the Aqua look and the native look on Windows.
  72092. Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
  72093. Reviewed by Adam Roben
  72094. * WebCore.vcproj/WebCore.vcproj:
  72095. * page/Settings.cpp:
  72096. (WebCore::Settings::setShouldPaintNativeControls):
  72097. * page/Settings.h:
  72098. (WebCore::Settings::shouldPaintNativeControls):
  72099. * rendering/RenderThemeSafari.cpp:
  72100. (WebCore::theme):
  72101. * rendering/RenderThemeWin.cpp:
  72102. 2008-09-05 Antti Koivisto <antti@apple.com>
  72103. Qt build fix.
  72104. * svg/SVGFEImageElement.cpp:
  72105. (WebCore::SVGFEImageElement::build):
  72106. 2008-09-05 Dirk Schulze <vbs85@gmx.de>
  72107. Gtk build fix
  72108. * GNUmakefile.am:
  72109. 2008-09-05 Antti Koivisto <antti@apple.com>
  72110. Another build fix.
  72111. * svg/SVGFEImageElement.cpp:
  72112. (WebCore::SVGFEImageElement::notifyFinished):
  72113. 2008-09-05 Antti Koivisto <antti@apple.com>
  72114. Build fixes.
  72115. * WebCore.xcodeproj/project.pbxproj:
  72116. * svg/graphics/filters/SVGFEImage.cpp:
  72117. (WebCore::FEImage::cachedImage):
  72118. 2008-09-05 Antti Koivisto <antti@apple.com>
  72119. Reviewed by Darin Adler.
  72120. Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
  72121. When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
  72122. Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
  72123. not yet enable it for the biggest use case, reloading. However it is good for general browsing as
  72124. well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
  72125. we avoid re-decoding resources, especially images.
  72126. To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
  72127. CacheControl: max-age=0 header. That would be added in reload case.
  72128. The approach for revalidation is to kick the original resource out from the memory cache
  72129. and create a new CachedResource that represents the revalidation request. In case
  72130. we get 304 back for the request we put the original resource back to the cache, update
  72131. its expiration date and switch the clients registered to revalidation resource to be
  72132. clients of the original resource.
  72133. All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
  72134. This allows updating the handles to point to the original resource when the revalidation succeeds. It
  72135. also acts as refcounting smart pointer.
  72136. * WebCore.pro:
  72137. * WebCore.vcproj/WebCore.vcproj:
  72138. * WebCore.xcodeproj/project.pbxproj:
  72139. * css/CSSFontFaceSource.h:
  72140. * css/CSSImportRule.h:
  72141. * dom/Clipboard.h:
  72142. (WebCore::Clipboard::dragImage):
  72143. * dom/ProcessingInstruction.h:
  72144. * dom/ScriptElement.h:
  72145. * dom/XMLTokenizer.cpp:
  72146. (WebCore::XMLTokenizer::isWaitingForScripts):
  72147. * dom/XMLTokenizer.h:
  72148. * html/HTMLImageLoader.cpp:
  72149. (WebCore::HTMLImageLoader::setImage):
  72150. (WebCore::HTMLImageLoader::updateFromElement):
  72151. (WebCore::HTMLImageLoader::notifyFinished):
  72152. * html/HTMLImageLoader.h:
  72153. (WebCore::HTMLImageLoader::image):
  72154. * html/HTMLLinkElement.h:
  72155. * html/HTMLTokenizer.cpp:
  72156. (WebCore::HTMLTokenizer::reset):
  72157. (WebCore::HTMLTokenizer::scriptHandler):
  72158. (WebCore::HTMLTokenizer::notifyFinished):
  72159. * html/HTMLTokenizer.h:
  72160. * loader/Cache.cpp:
  72161. (WebCore::Cache::revalidateResource):
  72162. (WebCore::Cache::revalidationSucceeded):
  72163. (WebCore::Cache::revalidationFailed):
  72164. * loader/Cache.h:
  72165. * loader/CachedResource.cpp:
  72166. (WebCore::CachedResource::CachedResource):
  72167. (WebCore::CachedResource::~CachedResource):
  72168. (WebCore::CachedResource::isExpired):
  72169. (WebCore::CachedResource::setResponse):
  72170. (WebCore::CachedResource::deleteIfPossible):
  72171. (WebCore::CachedResource::setResourceToRevalidate):
  72172. (WebCore::CachedResource::clearResourceToRevalidate):
  72173. (WebCore::CachedResource::switchClientsToRevalidatedResource):
  72174. (WebCore::CachedResource::canUseCacheValidator):
  72175. (WebCore::CachedResource::mustRevalidate):
  72176. * loader/CachedResource.h:
  72177. (WebCore::CachedResource::canDelete):
  72178. (WebCore::CachedResource::registerHandle):
  72179. (WebCore::CachedResource::unregisterHandle):
  72180. (WebCore::CachedResource::isCacheValidator):
  72181. (WebCore::CachedResource::resourceToRevalidate):
  72182. (WebCore::CachedResource::setExpirationDate):
  72183. * loader/CachedResourceHandle.cpp: Added.
  72184. (WebCore::CachedResourceHandleBase::setResource):
  72185. * loader/CachedResourceHandle.h: Added.
  72186. (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
  72187. (WebCore::CachedResourceHandleBase::get):
  72188. (WebCore::CachedResourceHandleBase::operator!):
  72189. (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
  72190. (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
  72191. (WebCore::CachedResourceHandleBase::operator=):
  72192. (WebCore::CachedResourceHandle::CachedResourceHandle):
  72193. (WebCore::CachedResourceHandle::get):
  72194. (WebCore::CachedResourceHandle::operator->):
  72195. (WebCore::CachedResourceHandle::operator=):
  72196. (WebCore::CachedResourceHandle::operator==):
  72197. (WebCore::CachedResourceHandle::operator!=):
  72198. (WebCore::operator==):
  72199. (WebCore::operator!=):
  72200. * loader/DocLoader.cpp:
  72201. (WebCore::DocLoader::checkForReload):
  72202. * loader/UserStyleSheetLoader.h:
  72203. * loader/loader.cpp:
  72204. (WebCore::Loader::Host::servePendingRequests):
  72205. (WebCore::Loader::Host::didFinishLoading):
  72206. (WebCore::Loader::Host::didFail):
  72207. (WebCore::Loader::Host::didReceiveResponse):
  72208. (WebCore::Loader::Host::didReceiveData):
  72209. * page/EventHandler.cpp:
  72210. (WebCore::EventHandler::selectCursor):
  72211. * rendering/RenderImage.cpp:
  72212. (WebCore::RenderImage::setCachedImage):
  72213. (WebCore::RenderImage::imageChanged):
  72214. * rendering/RenderImage.h:
  72215. (WebCore::RenderImage::cachedImage):
  72216. (WebCore::RenderImage::imagePtr):
  72217. * rendering/style/RenderStyle.h:
  72218. * rendering/style/StyleCachedImage.h:
  72219. (WebCore::StyleCachedImage::data):
  72220. (WebCore::StyleCachedImage::cachedImage):
  72221. * svg/SVGFEImageElement.h:
  72222. * svg/graphics/filters/SVGFEImage.h:
  72223. * xml/XSLImportRule.h:
  72224. 2008-09-04 Brady Eidson <beidson@apple.com>
  72225. Reviewed by Mitz
  72226. <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
  72227. A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
  72228. to model default NSURLRequest behavior in a cross-platform manner.
  72229. Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
  72230. client that wished to enforce a much larger default timeout using NSURLRequest API.
  72231. Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
  72232. behavior on the web and this restores previous Safari/WebKit behavior.
  72233. It would be easy to write a layout test for this, but to be effective it would have
  72234. to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
  72235. * manual-tests/timeout-test.html: Added.
  72236. * manual-tests/timeout-test.php: Added.
  72237. * platform/network/ResourceRequestBase.h:
  72238. (WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
  72239. and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
  72240. * platform/network/mac/ResourceRequestMac.mm:
  72241. (WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
  72242. "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
  72243. WebKit applications to enforce their own default timeout.
  72244. 2008-09-04 Dan Bernstein <mitz@apple.com>
  72245. Reviewed by Beth Dakin.
  72246. - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
  72247. Test: fast/repaint/button-spurious-layout-hint.html
  72248. * rendering/RenderButton.cpp:
  72249. (WebCore::RenderButton::setStyle): Reset the inner block's style box
  72250. flex to 0 to avoid getting a spurious layout hint.
  72251. 2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
  72252. wx build fixes.
  72253. * WebCoreSources.bkl:
  72254. * bindings/js/ScriptControllerWx.cpp: Added.
  72255. (WebCore::ScriptController::createScriptInstanceForWidget):
  72256. * page/wx/AccessibilityObjectWx.cpp: Added.
  72257. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  72258. * platform/graphics/wx/GraphicsContextWx.cpp:
  72259. * webcore-base.bkl:
  72260. * webcore-wx.bkl:
  72261. 2008-09-04 Dan Bernstein <mitz@apple.com>
  72262. Reviewed by Mark Rowe.
  72263. - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
  72264. and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
  72265. require a different approach
  72266. * css/CSSGrammar.y:
  72267. 2008-09-04 Mark Rowe <mrowe@apple.com>
  72268. Reviewed by Eric Seidel.
  72269. Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
  72270. Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
  72271. * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
  72272. * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
  72273. for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
  72274. 2008-09-04 Mark Rowe <mrowe@apple.com>
  72275. Mac build fix.
  72276. * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
  72277. 2008-09-04 Eric Seidel <eric@webkit.org>
  72278. Build fix only, no review.
  72279. * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
  72280. 2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
  72281. Reviewed by Eric Seidel.
  72282. http://bugs.webkit.org/show_bug.cgi?id=20380
  72283. [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
  72284. * config.h: Include the configuration header generated by autotools if
  72285. available.
  72286. 2008-09-04 Dan Bernstein <mitz@apple.com>
  72287. Rubber-stamped by Dave Hyatt.
  72288. - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
  72289. * loader/CachedFont.cpp:
  72290. (WebCore::CachedFont::allClientsRemoved):
  72291. * loader/CachedFont.h:
  72292. * loader/CachedImage.cpp:
  72293. (WebCore::CachedImage::allClientsRemoved):
  72294. * loader/CachedImage.h:
  72295. * loader/CachedResource.cpp:
  72296. (WebCore::CachedResource::removeClient):
  72297. * loader/CachedResource.h:
  72298. (WebCore::CachedResource::allClientsRemoved):
  72299. 2008-09-04 Adam Roben <aroben@apple.com>
  72300. Windows build fix after r36071
  72301. We were getting these errors:
  72302. error C2356: initialization segment must not change during translation
  72303. unit
  72304. This was happening because multiple files #included by
  72305. DerivedSources.cpp were themselves #including StaticConstructors.h. I
  72306. fixed the error by adding header guards to StaticConstructors.h so its
  72307. contents will only be included once.
  72308. But it's also not a good idea for StaticConstructors.h to end up in
  72309. DerivedSources.cpp, since it ends up "polluting" all the source files
  72310. we have in there. So I removed all the files that include
  72311. StaticConstructors.h and added some preprocessor directives to
  72312. DerivedSources.cpp to catch this error in the future.
  72313. * DerivedSources.cpp: Removed the *Names.cpp files, which include
  72314. StaticConstructors.h, and added some preprocessor directives to make
  72315. sure we don't end up accidentally including StaticConstructors.h in
  72316. the future.
  72317. * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
  72318. * platform/StaticConstructors.h: Added header guards.
  72319. 2008-09-04 Adam Roben <aroben@apple.com>
  72320. Windows build fix
  72321. * platform/graphics/win/FontPlatformData.h: Added a missing #include
  72322. of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
  72323. * platform/text/PlatformString.h: Added a missing #include of
  72324. PassRefPtr.h.
  72325. 2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
  72326. Reviewed by Simon.
  72327. Fix the QtWebKit build to match changes in r36016
  72328. * WebCore.pro:
  72329. * bridge/qt/qt_instance.cpp:
  72330. (KJS::Bindings::QtInstance::getRuntimeObject):
  72331. * bridge/qt/qt_runtime.cpp:
  72332. (KJS::Bindings::convertQVariantToValue):
  72333. (KJS::Bindings::QtConnectionObject::execute):
  72334. 2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
  72335. Reviewed by Simon.
  72336. Re-enable support for user stylesheets in QtWebKit
  72337. QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
  72338. code path, which allows us to keep API support for
  72339. loading user style sheets from remote URLs.
  72340. As part of the change UserStyleSheetLoader.cpp/h was
  72341. moved from WebCore/loader/mac to WebCore/loader.
  72342. * WebCore.pro:
  72343. * WebCore.xcodeproj/project.pbxproj:
  72344. * dom/Document.h:
  72345. * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
  72346. (UserStyleSheetLoader::UserStyleSheetLoader):
  72347. (UserStyleSheetLoader::~UserStyleSheetLoader):
  72348. * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
  72349. * page/qt/FrameQt.cpp:
  72350. (WebCore::Frame::setUserStyleSheetLocation):
  72351. (WebCore::Frame::setUserStyleSheet):
  72352. 2008-09-04 Alp Toker <alp@nuanti.com>
  72353. Reviewed by Eric.
  72354. Remove left-over QT and CAIRO platform checks.
  72355. * html/CanvasRenderingContext2D.cpp:
  72356. 2008-09-04 Eric Seidel <eric@webkit.org>
  72357. Reviewed by Mark Rowe.
  72358. Fix leak of TextMetrics due to over-ref as see on buildbot.
  72359. * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
  72360. 2008-09-04 Dan Bernstein <mitz@apple.com>
  72361. Reviewed by Dave Hyatt.
  72362. - fix https://bugs.webkit.org/show_bug.cgi?id=19717
  72363. <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
  72364. * rendering/RenderBlock.cpp:
  72365. (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
  72366. positioned movement only case, call
  72367. tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
  72368. layout if that fails.
  72369. (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
  72370. * rendering/RenderBox.h:
  72371. (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
  72372. layoutDoingPositionedMovementOnly to this, and made this function
  72373. check if the width changed. If it did, return, leaving the object
  72374. dirty. The caller can then call layout(). The width can change even
  72375. in the "positioned movement only" case if the object is shrink-to-fit
  72376. and the available width constraint is met. (This was the case in the
  72377. bug).
  72378. * rendering/RenderObject.h:
  72379. (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
  72380. Renamed layoutDoingPositionedMovementOnly() to this.
  72381. 2008-09-03 Eric Seidel <eric@webkit.org>
  72382. No review, build fix only.
  72383. Attempt to fix the Qt build.
  72384. * WebCore.pro: add page/animation to include path
  72385. 2008-09-03 Mark Rowe <mrowe@apple.com>
  72386. Mac build fix. Correctly detect whether dashboard support is enabled.
  72387. * DerivedSources.make:
  72388. 2008-09-03 Eric Seidel <eric@webkit.org>
  72389. Reviewed by Sam.
  72390. Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
  72391. * Configurations/WebCore.xcconfig: add missing ENABLE_*
  72392. * config.h: add rules for V8_BINDINGS
  72393. 2008-09-03 Eric Seidel <eric@webkit.org>
  72394. Reviewed by Sam.
  72395. https://bugs.webkit.org/show_bug.cgi?id=20620
  72396. Add #if USE(JSC) around KJS dependencies
  72397. Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
  72398. 1. Most platforms have it on anyway
  72399. 2. V8 is going to want to share some of that code
  72400. 3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
  72401. * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
  72402. * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
  72403. * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  72404. * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  72405. * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  72406. * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  72407. * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  72408. * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  72409. * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
  72410. * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
  72411. * platform/text/AtomicString.cpp: add USE(JSC)
  72412. * platform/text/AtomicString.h: add USE(JSC)
  72413. * platform/text/PlatformString.h: add USE(JSC)
  72414. * platform/text/String.cpp: add USE(JSC)
  72415. * platform/text/StringImpl.cpp: add USE(JSC)
  72416. * platform/text/StringImpl.h: add USE(JSC)
  72417. 2008-09-03 Dean McNamee <deanm@chromium.org>
  72418. Reviewed by Darin Adler.
  72419. Fix https://bugs.webkit.org/show_bug.cgi?id=20511
  72420. Bug 20511: Remove static initializers on Windows
  72421. Avoid static initializers on Windows by forcing Visual C++ to put
  72422. all static initializers in a code segment that is never executed.
  72423. * config.h:
  72424. * css/MediaFeatureNames.cpp:
  72425. * dom/EventNames.cpp:
  72426. * dom/QualifiedName.cpp:
  72427. * dom/make_names.pl:
  72428. * platform/StaticConstructors.h:
  72429. * platform/text/AtomicString.cpp:
  72430. 2008-09-03 Dirk Schulze <vbs85@gmx.de>
  72431. Reviewed by Dave Hyatt.
  72432. Make FontCairo draw TextStroke and TextFill separately.
  72433. [CAIRO] draw TextFill and TextStroke separately.
  72434. [https://bugs.webkit.org/show_bug.cgi?id=20631]
  72435. * platform/graphics/cairo/FontCairo.cpp:
  72436. (WebCore::Font::drawGlyphs):
  72437. 2008-09-03 Peter Kasting <pkasting@google.com>
  72438. Reviewed by Dave Hyatt.
  72439. https://bugs.webkit.org/show_bug.cgi?id=19663
  72440. Account for paint and timer lag when animating images. Also pretend
  72441. that images whose animations were paused (by becoming invisible)
  72442. continued to animate, by "catching up" to the correct frame when they're
  72443. shown again.
  72444. * platform/graphics/BitmapImage.cpp:
  72445. (WebCore::BitmapImage::BitmapImage):
  72446. (WebCore::BitmapImage::startAnimation):
  72447. (WebCore::BitmapImage::advanceAnimation):
  72448. (WebCore::BitmapImage::internalAdvanceAnimation):
  72449. (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
  72450. * platform/graphics/BitmapImage.h:
  72451. * platform/graphics/cairo/ImageCairo.cpp:
  72452. (WebCore::BitmapImage::draw):
  72453. * platform/graphics/cg/ImageCG.cpp:
  72454. (WebCore::BitmapImage::draw):
  72455. * platform/graphics/qt/ImageQt.cpp:
  72456. (WebCore::BitmapImage::draw):
  72457. * platform/graphics/wx/ImageWx.cpp:
  72458. (WebCore::BitmapImage::draw):
  72459. 2008-09-03 Kevin McCullough <kmccullough@apple.com>
  72460. Reviewed by Tim.
  72461. Remove the rest of the "zombie" code from the profiler.
  72462. - There is no longer a need for the ProfilerClient callback mechanism.
  72463. * page/Console.cpp:
  72464. (WebCore::Console::Console):
  72465. (WebCore::Console::profile):
  72466. (WebCore::Console::profileEnd): Move the variables from the header to
  72467. here since we don't have to wait for a callback to use them.
  72468. * page/Console.h:
  72469. * page/InspectorController.cpp:
  72470. (WebCore::InspectorController::startUserInitiatedProfiling):
  72471. (WebCore::InspectorController::stopUserInitiatedProfiling):
  72472. * page/InspectorController.h:
  72473. 2008-09-03 Ada Chan <adachan@apple.com>
  72474. Windows build fix.
  72475. * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
  72476. 2008-09-01 Dean Jackson <dino@apple.com>
  72477. Reviewed by Dave Hyatt.
  72478. https://bugs.webkit.org/show_bug.cgi?id=20594
  72479. Add DOM interfaces for WebKitCSSKeyframeRule
  72480. and WebKitCSSKeyframesRule.
  72481. TEST: LayoutTests/css3/keyframes-rule.html
  72482. * css/WebKitCSSKeyframeRule.idl: Added
  72483. * css/WebKitCSSKeyframesRule.idl: Added
  72484. * bindings/js/JSCSSRuleCustom.cpp:
  72485. (WebCore::toJS):
  72486. Add return of new JS Keyframe rules
  72487. * bindings/objc/DOMInternal.h:
  72488. Include new internal header
  72489. * DerivedSources.make:
  72490. * GNUmakefile.am:
  72491. * WebCore.pro:
  72492. * WebCore.vcproj/WebCore.vcproj:
  72493. * WebCore.xcodeproj/project.pbxproj:
  72494. * WebCoreSources.bkl:
  72495. Build configs for new files
  72496. 2008-09-03 Adam Roben <aroben@apple.com>
  72497. Windows build fix
  72498. * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
  72499. * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
  72500. convenience/consistency.
  72501. 2008-09-03 Adele Peterson <adele@apple.com>
  72502. Build fix.
  72503. * WebCore.vcproj/WebCore.vcproj:
  72504. 2008-09-03 David Hyatt <hyatt@apple.com>
  72505. Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
  72506. Reviewed by Darin (ages ago)
  72507. Added fast/block/float/clamped-right-float.html
  72508. * rendering/RenderBlock.cpp:
  72509. (WebCore::RenderBlock::positionNewFloats):
  72510. 2008-09-02 David Hyatt <hyatt@apple.com>
  72511. Add support for canvas text drawing APIs.
  72512. Reviewed by olliej
  72513. Tests added as fast/canvas/canvas-text-*.html
  72514. * DerivedSources.make:
  72515. * WebCore.xcodeproj/project.pbxproj:
  72516. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  72517. (WebCore::JSCanvasRenderingContext2D::fillText):
  72518. (WebCore::JSCanvasRenderingContext2D::strokeText):
  72519. * css/CSSStyleSelector.cpp:
  72520. (WebCore::CSSStyleSelector::initForStyleResolve):
  72521. (WebCore::CSSStyleSelector::applyPropertyToStyle):
  72522. * css/CSSStyleSelector.h:
  72523. * html/CanvasRenderingContext2D.cpp:
  72524. (WebCore::CanvasRenderingContext2D::State::State):
  72525. (WebCore::CanvasRenderingContext2D::font):
  72526. (WebCore::CanvasRenderingContext2D::setFont):
  72527. (WebCore::CanvasRenderingContext2D::textAlign):
  72528. (WebCore::CanvasRenderingContext2D::setTextAlign):
  72529. (WebCore::CanvasRenderingContext2D::textBaseline):
  72530. (WebCore::CanvasRenderingContext2D::setTextBaseline):
  72531. (WebCore::CanvasRenderingContext2D::fillText):
  72532. (WebCore::CanvasRenderingContext2D::strokeText):
  72533. (WebCore::CanvasRenderingContext2D::measureText):
  72534. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  72535. (WebCore::CanvasRenderingContext2D::accessFont):
  72536. * html/CanvasRenderingContext2D.h:
  72537. * html/CanvasRenderingContext2D.idl:
  72538. * html/TextMetrics.h: Added.
  72539. (WebCore::TextMetrics::create):
  72540. (WebCore::TextMetrics::width):
  72541. (WebCore::TextMetrics::setWidth):
  72542. (WebCore::TextMetrics::TextMetrics):
  72543. * html/TextMetrics.idl: Added.
  72544. * platform/graphics/Font.cpp:
  72545. (WebCore::Font::lineGap):
  72546. * platform/graphics/Font.h:
  72547. * platform/graphics/GraphicsContext.cpp:
  72548. (WebCore::GraphicsContext::drawBidiText):
  72549. * platform/graphics/GraphicsContext.h:
  72550. * platform/graphics/GraphicsTypes.cpp:
  72551. (WebCore::textAlignName):
  72552. (WebCore::parseTextAlign):
  72553. (WebCore::textBaselineName):
  72554. (WebCore::parseTextBaseline):
  72555. * platform/graphics/GraphicsTypes.h:
  72556. (WebCore::):
  72557. 2008-09-03 John Sullivan <sullivan@apple.com>
  72558. Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
  72559. Fixed by Darin, reviewed by me
  72560. * page/animation/AnimationBase.cpp:
  72561. (WebCore::AnimationBase::propertiesEqual):
  72562. added ensurePropertyMap() to this static function
  72563. (WebCore::AnimationBase::getPropertyAtIndex):
  72564. ditto
  72565. (WebCore::AnimationBase::getNumProperties):
  72566. ditto
  72567. 2008-09-03 Kevin McCullough <kmccullough@apple.com>
  72568. Reviewed by Darin and Tim.
  72569. Remove most of the "zombie" mode from the profiler. Next we will need
  72570. to remove the client callback mechanism in profiles.
  72571. - These changes are a result of changes to JSCore.
  72572. * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
  72573. * page/Console.cpp:
  72574. (WebCore::retrieveLastCaller):
  72575. (WebCore::Console::profileEnd):
  72576. * page/InspectorController.cpp:
  72577. (WebCore::InspectorController::stopUserInitiatedProfiling):
  72578. 2008-09-03 Adele Peterson <adele@apple.com>
  72579. Reviewed by Darin Adler.
  72580. Test: fast/forms/search-display-none-cancel-button.html
  72581. Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
  72582. * css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
  72583. * rendering/RenderTextControl.cpp:
  72584. (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
  72585. (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
  72586. (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
  72587. (WebCore::RenderTextControl::createSubtreeIfNeeded):
  72588. Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
  72589. (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
  72590. (WebCore::RenderTextControl::subtreeHasChanged): ditto.
  72591. (WebCore::RenderTextControl::calcHeight): ditto.
  72592. (WebCore::RenderTextControl::nodeAtPoint): ditto.
  72593. (WebCore::RenderTextControl::layout): ditto.
  72594. (WebCore::RenderTextControl::calcPrefWidths): ditto.
  72595. (WebCore::RenderTextControl::clientPaddingLeft): ditto.
  72596. (WebCore::RenderTextControl::clientPaddingRight): ditto.
  72597. * rendering/TextControlInnerElements.cpp:
  72598. (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
  72599. (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
  72600. (WebCore::TextControlInnerElement::attachInnerElement): Added.
  72601. This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
  72602. (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
  72603. * rendering/TextControlInnerElements.h:
  72604. 2008-08-28 Alexey Proskuryakov <ap@webkit.org>
  72605. Reviewed by Maciej.
  72606. Elminate SQLiteAuthorizer class.
  72607. * WebCore.xcodeproj/project.pbxproj:
  72608. * WebCore.vcproj/WebCore.vcproj:
  72609. * GNUmakefile.am
  72610. Removed SQLiteAuthorizer.h.
  72611. * platform/sql/SQLiteAuthorizer.cpp:
  72612. * platform/sql/SQLiteAuthorizer.h: Removed.
  72613. * platform/sql/SQLiteDatabase.cpp:
  72614. (WebCore::SQLiteDatabase::authorizerFunction):
  72615. (WebCore::SQLiteDatabase::setAuthorizer):
  72616. * platform/sql/SQLiteDatabase.h:
  72617. * storage/DatabaseAuthorizer.h:
  72618. (WebCore::DatabaseAuthorizer::create):
  72619. (WebCore::DatabaseAuthorizer::createView):
  72620. (WebCore::DatabaseAuthorizer::createTempView):
  72621. (WebCore::DatabaseAuthorizer::dropView):
  72622. (WebCore::DatabaseAuthorizer::dropTempView):
  72623. (WebCore::DatabaseAuthorizer::allowSelect):
  72624. (WebCore::DatabaseAuthorizer::allowReindex):
  72625. Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
  72626. 2008-09-03 Dirk Schulze <vbs85@gmx.de>
  72627. Reviewed by Mark Rowe.
  72628. WebKitGtk build fix.
  72629. * GNUmakefile.am:
  72630. * page/animation/AnimationController.h:
  72631. 2008-09-02 Robert Blaut <webkit@blaut.biz>
  72632. Reviewed by Geoff Garen.
  72633. Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
  72634. Misplaced elements should not close DL lists.
  72635. Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
  72636. * html/HTMLParser.cpp:
  72637. (WebCore::HTMLParser::handleError):
  72638. 2008-09-02 Glenn Wilson <wilsong@gmail.com>
  72639. Reviewed by Darin Adler.
  72640. Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
  72641. Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
  72642. We would inappropriately interpret and apply an invalid CSS "color" property
  72643. when the value is a predefined color preceded by a '#' symbol. For example,
  72644. style="color:#gray;" would apply the color gray when it should not.
  72645. In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
  72646. This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
  72647. interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
  72648. an ignorable token.
  72649. To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
  72650. '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
  72651. CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
  72652. Test: css1/color_and_background/invalid_color.html
  72653. * css/CSSGrammar.y:
  72654. 2008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
  72655. Reviewed by Darin Adler.
  72656. Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
  72657. Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
  72658. Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
  72659. Test: css3/khtml-background-size-0x0-bmp.html
  72660. * rendering/RenderBox.cpp:
  72661. (WebCore::RenderBox::repaintLayerRectsForImage):
  72662. 2008-09-02 Glenn Wilson <wilsong@gmail.com>
  72663. Reviewed by Eric Seidel.
  72664. Fix https://bugs.webkit.org/show_bug.cgi?id=20397
  72665. Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
  72666. The function checkForOrphanedUnits() would change the length of a list whose size was
  72667. was already determined before the call to checkForOrphanedUnits was made. Later in
  72668. the caller, the old size was being used for boundary management.
  72669. This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
  72670. calling function, before the size of the list is determined.
  72671. Test: fast/css/orphaned_units_crash.html
  72672. * css/CSSParser.cpp:
  72673. (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
  72674. 2008-09-02 Dirk Schulze <vbs85@gmx.de>
  72675. Reviewed by Darin Adler.
  72676. Fallback on invalid fill or stroke styles in Canvas was
  72677. transparent black. Changed it to last valid style.
  72678. Canvas fillStyle() and strokeStyle() needs fallback
  72679. https://bugs.webkit.org/show_bug.cgi?id=20474
  72680. Tests: fast/canvas/canvas-invalid-fillstyle.html
  72681. fast/canvas/canvas-invalid-strokestyle.html
  72682. * html/CanvasStyle.cpp:
  72683. (WebCore::CanvasStyle::applyStrokeColor):
  72684. (WebCore::CanvasStyle::applyFillColor):
  72685. 2008-09-02 Dirk Schulze <vbs85@gmx.de>
  72686. Reviewed by Darin Adler.
  72687. Fix https://bugs.webkit.org/show_bug.cgi?id=20468
  72688. Updated drawImage() in canvas to match the current specification.
  72689. Test: fast/canvas/drawImage-with-negative-source-destination.html
  72690. * html/CanvasRenderingContext2D.cpp:
  72691. (WebCore::normalizeRect):
  72692. (WebCore::CanvasRenderingContext2D::drawImage):
  72693. 2008-08-26 Mark Rowe <mrowe@apple.com>
  72694. Reviewed by Darin Adler.
  72695. <rdar://problem/5768210> Switch back to the system version of SQLite
  72696. Use the system version of SQLite when it is new enough to provide the functionality
  72697. that WebCore requires.
  72698. * Configurations/Base.xcconfig:
  72699. * Configurations/DebugRelease.xcconfig:
  72700. * Configurations/WebCore.xcconfig:
  72701. 2008-09-02 Dan Bernstein <mitz@apple.com>
  72702. - build fix
  72703. * page/animation/AnimationBase.h:
  72704. 2008-09-02 Chris Marrin <cmarrin@apple.com>
  72705. Reviewed by Dave Hyatt.
  72706. AnimationController.cpp should be split into separate files
  72707. https://bugs.webkit.org/show_bug.cgi?id=20604
  72708. Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
  72709. recommendation of Dave Hyatt.
  72710. * GNUmakefile.am:
  72711. * WebCore.pro:
  72712. * WebCore.vcproj/WebCore.vcproj:
  72713. * WebCore.xcodeproj/project.pbxproj:
  72714. * WebCoreSources.bkl:
  72715. Build files.
  72716. * page/AnimationController.cpp: Removed.
  72717. * page/AnimationController.h: Removed.
  72718. * page/animation: Added.
  72719. * page/animation/AnimationBase.cpp: Added.
  72720. * page/animation/AnimationBase.h: Added.
  72721. * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
  72722. * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
  72723. * page/animation/CompositeAnimation.cpp: Added.
  72724. * page/animation/CompositeAnimation.h: Added.
  72725. * page/animation/ImplicitAnimation.cpp: Added.
  72726. * page/animation/ImplicitAnimation.h: Added.
  72727. * page/animation/KeyframeAnimation.cpp: Added.
  72728. * page/animation/KeyframeAnimation.h: Added.
  72729. 2008-09-02 Dan Bernstein <mitz@apple.com>
  72730. - release build fix
  72731. * platform/graphics/cg/GraphicsContextCG.cpp:
  72732. (WebCore::calculateDrawingMode):
  72733. 2008-09-02 Timothy Hatcher <timothy@apple.com>
  72734. Make console functions log the correct resource URL and
  72735. line number for where the call originated.
  72736. https://bugs.webkit.org/show_bug.cgi?id=17234
  72737. <rdar://problem/5732837>
  72738. Reviewed by Kevin McCullough.
  72739. Test: manual-tests/inspector/console-call-line-numbers.html
  72740. * bindings/js/JSConsoleCustom.cpp:
  72741. (WebCore::JSConsole::count): Call the impl.
  72742. (WebCore::JSConsole::timeEnd): Ditto.
  72743. * manual-tests/inspector/console-call-line-numbers.html: Added.
  72744. * manual-tests/inspector/resources/script-console-calls.js: Added.
  72745. * page/Console.cpp:
  72746. (WebCore::retrieveLastCaller): Helper to get the URL and line.
  72747. (WebCore::Console::error): Call retrieveLastCaller to get the URL and
  72748. line number to pass to addMessageToConsole.
  72749. (WebCore::Console::info): Ditto.
  72750. (WebCore::Console::log): Ditto.
  72751. (WebCore::Console::assertCondition): Ditto.
  72752. (WebCore::Console::count): Ditto.
  72753. (WebCore::Console::timeEnd): Ditto.
  72754. (WebCore::Console::warn): Ditto.
  72755. * page/Console.h:
  72756. * page/Console.idl: Make count and timeEnd custom.
  72757. 2008-09-02 Timothy Hatcher <timothy@apple.com>
  72758. Removed IDL files from WebCore's framework resources.
  72759. * WebCore.xcodeproj/project.pbxproj:
  72760. 2008-09-02 Dan Bernstein <mitz@apple.com>
  72761. Reviewed by Dave Hyatt.
  72762. - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
  72763. * html/HTMLParser.cpp:
  72764. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
  72765. cap on the number of consecutive identical residual style tags to
  72766. reopen.
  72767. (WebCore::HTMLParser::popBlock): Ditto.
  72768. 2008-09-02 Alexey Proskuryakov <ap@webkit.org>
  72769. Reviewed by Adam Roben.
  72770. A little database quota management cleanup.
  72771. * storage/OriginQuotaManager.cpp:
  72772. (WebCore::OriginQuotaManager::OriginQuotaManager):
  72773. (WebCore::OriginQuotaManager::lock):
  72774. (WebCore::OriginQuotaManager::unlock):
  72775. (WebCore::OriginQuotaManager::trackOrigin):
  72776. (WebCore::OriginQuotaManager::tracksOrigin):
  72777. (WebCore::OriginQuotaManager::addDatabase):
  72778. (WebCore::OriginQuotaManager::removeDatabase):
  72779. (WebCore::OriginQuotaManager::removeOrigin):
  72780. (WebCore::OriginQuotaManager::markDatabase):
  72781. (WebCore::OriginQuotaManager::diskUsage):
  72782. * storage/OriginQuotaManager.h:
  72783. Changed to assert that a lock is taken more directly and reliably. Removed comments about
  72784. main/background threads, as this is likely to stop being true with synchronous Database calls
  72785. being made on worker threads.
  72786. * storage/OriginUsageRecord.cpp:
  72787. (WebCore::OriginUsageRecord::OriginUsageRecord):
  72788. (WebCore::OriginUsageRecord::addDatabase):
  72789. (WebCore::OriginUsageRecord::removeDatabase):
  72790. (WebCore::OriginUsageRecord::markDatabase):
  72791. (WebCore::OriginUsageRecord::diskUsage):
  72792. * storage/OriginUsageRecord.h:
  72793. (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
  72794. Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
  72795. can be replaced with a single boolean for OriginUsageRecord.
  72796. Added assertions for string parameters being unshared.
  72797. 2008-09-01 Adam Barth <abarth@webkit.org>
  72798. Reviewed by Sam Weinig.
  72799. https://bugs.webkit.org/show_bug.cgi?id=19760
  72800. Make granting LoadLocalResources conditional on a policy.
  72801. * WebCore.base.exp:
  72802. * dom/Document.cpp:
  72803. (WebCore::Document::initSecurityContext):
  72804. * loader/FrameLoader.cpp:
  72805. (WebCore::FrameLoader::setLocalLoadPolicy):
  72806. (WebCore::FrameLoader::restrictAccessToLocal):
  72807. * loader/FrameLoader.h:
  72808. (WebCore::FrameLoader::):
  72809. * platform/SecurityOrigin.cpp:
  72810. (WebCore::SecurityOrigin::grantLoadLocalResources):
  72811. * platform/SecurityOrigin.h:
  72812. 2008-09-01 Dean Jackson <dino@apple.com>
  72813. Reviewed by Sam Weinig.
  72814. https://bugs.webkit.org/show_bug.cgi?id=20571
  72815. Make sure Window object can assign Animation/Transition event
  72816. listeners via attributes.
  72817. Also added a bunch of transition event tests, although
  72818. only transition-end-event-window is directly relevant to this patch.
  72819. (WebCore::JSDOMWindowBase::put):
  72820. Tests: transitions/transition-end-event-all-properties.html
  72821. transitions/transition-end-event-attributes.html
  72822. transitions/transition-end-event-container.html
  72823. transitions/transition-end-event-left.html
  72824. transitions/transition-end-event-multiple-01.html
  72825. transitions/transition-end-event-multiple-02.html
  72826. transitions/transition-end-event-multiple-03.html
  72827. transitions/transition-end-event-multiple-04.html
  72828. transitions/transition-end-event-nested.html
  72829. transitions/transition-end-event-transform.html
  72830. transitions/transition-end-event-window.html
  72831. 2008-09-01 Dean Jackson <dino@apple.com>
  72832. Reviewed by Sam Weinig
  72833. Code styling cleanup.
  72834. * bindings/js/JSDOMWindowBase.cpp:
  72835. (WebCore::JSDOMWindowBase::getValueProperty):
  72836. (WebCore::JSDOMWindowBase::put):
  72837. 2008-09-01 Geoffrey Garen <ggaren@apple.com>
  72838. Reviewed by Darin Adler.
  72839. First cut at inline caching for access to vanilla JavaScript properties.
  72840. Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
  72841. to WebCore classes, and PutPropertySlot& arguments to put functions.
  72842. (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
  72843. inline caching for global properties, so global assignment can be optimized.
  72844. * ForwardingHeaders/kjs/StructureID.h: Added.
  72845. * bindings/js/JSDOMBinding.h:
  72846. (WebCore::DOMObject::DOMObject):
  72847. * bindings/js/JSDOMWindowBase.cpp:
  72848. (WebCore::JSDOMWindowBase::put):
  72849. * bindings/js/JSDOMWindowBase.h:
  72850. * bindings/js/JSDOMWindowCustom.h:
  72851. (WebCore::JSDOMWindow::customPut):
  72852. * bindings/js/JSDOMWindowShell.cpp:
  72853. (WebCore::JSDOMWindowShell::JSDOMWindowShell):
  72854. (WebCore::JSDOMWindowShell::put):
  72855. * bindings/js/JSDOMWindowShell.h:
  72856. * bindings/js/JSEventTargetBase.h:
  72857. (WebCore::JSEventTargetBase::put):
  72858. * bindings/js/JSEventTargetNode.h:
  72859. (WebCore::JSEventTargetNode::put):
  72860. * bindings/js/JSHTMLAppletElementCustom.cpp:
  72861. (WebCore::JSHTMLAppletElement::customPut):
  72862. * bindings/js/JSHTMLEmbedElementCustom.cpp:
  72863. (WebCore::JSHTMLEmbedElement::customPut):
  72864. * bindings/js/JSHTMLInputElementBase.cpp:
  72865. (WebCore::JSHTMLInputElementBase::put):
  72866. * bindings/js/JSHTMLInputElementBase.h:
  72867. * bindings/js/JSHTMLObjectElementCustom.cpp:
  72868. (WebCore::JSHTMLObjectElement::customPut):
  72869. * bindings/js/JSHistoryCustom.cpp:
  72870. (WebCore::JSHistory::customPut):
  72871. * bindings/js/JSInspectedObjectWrapper.cpp:
  72872. (WebCore::JSInspectedObjectWrapper::wrap):
  72873. (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
  72874. * bindings/js/JSInspectedObjectWrapper.h:
  72875. * bindings/js/JSInspectorCallbackWrapper.cpp:
  72876. (WebCore::JSInspectorCallbackWrapper::wrap):
  72877. (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
  72878. * bindings/js/JSInspectorCallbackWrapper.h:
  72879. * bindings/js/JSLocationCustom.cpp:
  72880. (WebCore::JSLocation::customPut):
  72881. * bindings/js/JSPluginElementFunctions.cpp:
  72882. (WebCore::runtimeObjectCustomPut):
  72883. * bindings/js/JSPluginElementFunctions.h:
  72884. * bindings/js/JSQuarantinedObjectWrapper.cpp:
  72885. (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
  72886. (WebCore::JSQuarantinedObjectWrapper::put):
  72887. * bindings/js/JSQuarantinedObjectWrapper.h:
  72888. * bindings/js/JSStorageCustom.cpp:
  72889. (WebCore::JSStorage::customPut):
  72890. * bindings/objc/WebScriptObject.mm:
  72891. (-[WebScriptObject setValue:forKey:]):
  72892. * bindings/scripts/CodeGeneratorJS.pm:
  72893. * bridge/NP_jsobject.cpp:
  72894. (_NPN_SetProperty):
  72895. * bridge/jni/jni_jsobject.mm:
  72896. (JavaJSObject::setMember):
  72897. * bridge/objc/objc_class.mm:
  72898. (KJS::Bindings::ObjcClass::fallbackObject):
  72899. * bridge/objc/objc_runtime.h:
  72900. * bridge/objc/objc_runtime.mm:
  72901. (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  72902. (ObjcFallbackObjectImp::put):
  72903. * bridge/runtime.cpp:
  72904. (KJS::Bindings::Instance::createRuntimeObject):
  72905. * bridge/runtime_array.cpp:
  72906. (RuntimeArray::put):
  72907. * bridge/runtime_array.h:
  72908. * bridge/runtime_object.cpp:
  72909. (RuntimeObjectImp::RuntimeObjectImp):
  72910. (RuntimeObjectImp::put):
  72911. * bridge/runtime_object.h:
  72912. 2008-09-01 Dirk Schulze <vbs85@gmx.de>
  72913. Reviewed by Eric Seidel.
  72914. Fixed border-radius for Cairo.
  72915. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  72916. (WebCore::GraphicsContext::strokeArc):
  72917. 2008-09-01 Dirk Schulze <vbs85@gmx.de>
  72918. Reviewed by Eric Seidel.
  72919. Added canvas's globalAlpha to cairo.
  72920. * platform/graphics/GraphicsContext.h:
  72921. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  72922. (WebCore::GraphicsContext::fillPath):
  72923. (WebCore::GraphicsContext::strokePath):
  72924. (WebCore::GraphicsContext::setAlpha):
  72925. (WebCore::GraphicsContext::getAlpha):
  72926. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  72927. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  72928. * platform/graphics/cairo/ImageCairo.cpp:
  72929. (WebCore::BitmapImage::draw):
  72930. 2008-08-31 Simon Hausmann <hausmann@webkit.org>
  72931. Unreviewed Qt build fix.
  72932. * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
  72933. the .h file
  72934. 2008-08-30 Darin Adler <darin@apple.com>
  72935. Reviewed by Maciej.
  72936. - adopt some new JavaScriptCore functions where appropriate
  72937. * bindings/js/JSDOMWindowBase.cpp:
  72938. (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
  72939. (WebCore::windowProtoFuncBToA): Ditto.
  72940. * bindings/js/JSEventListener.cpp:
  72941. (WebCore::JSLazyEventListener::eventParameterName): Adopted
  72942. jsNontrivialString.
  72943. * bindings/js/JSSVGLazyEventListener.cpp:
  72944. (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
  72945. 2008-08-29 Brady Eidson <beidson@apple.com>
  72946. Reviewed by Anders' rubberstamp
  72947. Style cleanup to match MediaTokenizer::writeRawData()
  72948. * loader/PluginDocument.cpp:
  72949. (WebCore::PluginTokenizer::writeRawData):
  72950. 2008-08-29 Brady Eidson <beidson@apple.com>
  72951. Reviewed by Anders
  72952. https://bugs.webkit.org/show_bug.cgi?id=20556
  72953. <rdar://problem/6181817> REGRESSION (r35946): media/video-click-dlbclick-standalone.html [sic] fails because load never fires
  72954. Fix regression I introducted in 35946
  72955. Already covered by media/video-click-dlbclick-standalone.html
  72956. * loader/MediaDocument.cpp:
  72957. (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
  72958. (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
  72959. an ASSERT signifying that this method should only be called once, to more closely follow the
  72960. PluginDocument case.
  72961. 2008-08-29 Beth Dakin <bdakin@apple.com>
  72962. Reviewed by Sam Weinig.
  72963. Fix for <rdar://problem/6181588>
  72964. This patch makes hit testing take into account the new concept of a
  72965. disconnected frame, in which some of the content may not be
  72966. visible. The current hit testing mechanism starts at a target frame
  72967. and drills down for a HitTestResult. In some cases, drilling down
  72968. will find a non-visible result. When this happens, we need to try
  72969. again, starting at a higher level -- namely, starting at the main
  72970. frame.
  72971. * editing/Editor.cpp:
  72972. (WebCore::Editor::insideVisibleArea): New function that tests if a
  72973. point is inside the visible area for a disconnected frame.
  72974. * editing/Editor.h:
  72975. * page/EventHandler.cpp:
  72976. (WebCore::EventHandler::hitTestResultAtPoint):
  72977. 2008-08-29 Adele Peterson <adele@apple.com>
  72978. Reviewed by Adam Roben.
  72979. Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
  72980. * GNUmakefile.am:
  72981. * WebCore.pro:
  72982. * WebCore.vcproj/WebCore.vcproj:
  72983. * WebCore.xcodeproj/project.pbxproj:
  72984. * WebCoreSources.bkl:
  72985. * html/HTMLTextFieldInnerElement.cpp: Removed.
  72986. * html/HTMLTextFieldInnerElement.h: Removed.
  72987. * rendering/RenderTextControl.cpp:
  72988. (WebCore::RenderTextControl::createSubtreeIfNeeded):
  72989. * rendering/RenderTextControl.h:
  72990. * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
  72991. (WebCore::TextControlInnerElement::TextControlInnerElement):
  72992. (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
  72993. (WebCore::TextControlInnerTextElement::defaultEventHandler):
  72994. (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
  72995. (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
  72996. (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
  72997. (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  72998. * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
  72999. 2008-08-29 Eric Seidel <eric@webkit.org>
  73000. Rubber-stamped by aroben.
  73001. Add GraphicsContext.h include to GraphcisContextPrivate.h
  73002. GraphicsContextPrivate uses StrokeStyle which is defined
  73003. in GraphicsContext.h but it doesn't include that header.
  73004. CoreGraphics build doesn't fail here due to the order
  73005. it happens to include files.
  73006. * platform/graphics/GraphicsContextPrivate.h:
  73007. 2008-08-29 Eric Seidel <eric@webkit.org>
  73008. Reviewed by hyatt.
  73009. Fix GeneratedImage to respect Image's refcounting
  73010. Fixing potential crashers (future if not current)
  73011. https://bugs.webkit.org/show_bug.cgi?id=20567
  73012. I don't know if it's possible to make the current code
  73013. crash, thus I've not made a test.
  73014. * css/CSSGradientValue.cpp:
  73015. (WebCore::CSSGradientValue::image):
  73016. * css/CSSImageGeneratorValue.cpp:
  73017. (WebCore::CSSImageGeneratorValue::removeClient):
  73018. (WebCore::CSSImageGeneratorValue::getImage):
  73019. * css/CSSImageGeneratorValue.h:
  73020. * platform/graphics/GeneratedImage.h:
  73021. (WebCore::GeneratedImage::GeneratedImage):
  73022. * rendering/style/RenderStyle.cpp:
  73023. (WebCore::RenderStyle::setContent):
  73024. * rendering/style/RenderStyle.h:
  73025. 2008-08-29 Eric Carlson <eric.carlson@apple.com>
  73026. Reviewed by Adele.
  73027. Fix for <rdar://problem/6093767>
  73028. https://bugs.webkit.org/show_bug.cgi?id=20526
  73029. Don't allow video to render until unsupported track types have been disabled.
  73030. * platform/graphics/win/QTMovieWin.cpp:
  73031. (QTMovieWinPrivate::task):
  73032. (QTMovieWinPrivate::drawingComplete):
  73033. (QTMovieWinPrivate::clearGWorld):
  73034. 2008-08-29 Eric Carlson <eric.carlson@apple.com>
  73035. Reviewed by Adele.
  73036. Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
  73037. <rdar://problem/6169301>
  73038. Return the size of the movie data instead of 1000.
  73039. Test: media/progress-event-total.html
  73040. * platform/graphics/win/QTMovieWin.cpp:
  73041. (QTMovieWin::dataSize):
  73042. 2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
  73043. Reviewed by Eric Seidel.
  73044. [janitor/qt] Start replacing port specific getters with the generic native getter
  73045. To get the native presentation of an image we currently have platform
  73046. specific #ifdef's and a generic getter using NativeImagePtr. This patch
  73047. extends this to the ImageBuffer and updates the Qt platform to get rid
  73048. of the special #ifdefs.
  73049. https://bugs.webkit.org/attachment.cgi?id=22861
  73050. * platform/graphics/BitmapImage.h:
  73051. * platform/graphics/Image.h:
  73052. * platform/graphics/qt/ImageQt.cpp:
  73053. * platform/graphics/qt/StillImageQt.cpp:
  73054. * platform/graphics/qt/StillImageQt.h:
  73055. * platform/qt/ClipboardQt.cpp:
  73056. (WebCore::ClipboardQt::createDragImage):
  73057. (WebCore::ClipboardQt::declareAndWriteDragImage):
  73058. * platform/qt/CursorQt.cpp:
  73059. * platform/qt/PasteboardQt.cpp:
  73060. (WebCore::Pasteboard::writeImage):
  73061. 2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
  73062. Reviewed by Simon.
  73063. [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
  73064. * svg/graphics/qt/SVGPaintServerQt.cpp:
  73065. (WebCore::SVGPaintServer::renderPath):
  73066. * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
  73067. (WebCore::SVGPaintServerSolid::setup):
  73068. 2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
  73069. Reviewed by Simon.
  73070. [network/qt] Implement defering of loading ResourceHandle's
  73071. This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
  73072. implementation is simply not forwarding anything to the
  73073. ResourceHandleClient until we are allowed to. This might lead to a deadlock
  73074. in Qt as we do not empty the QNetworkReply input buffer and wait until we
  73075. are allowed to read. If that happens we are forced to buffer the data
  73076. within QNetworkReplyHandler, for now this is not done.
  73077. Manual test:
  73078. - Open http://acid3.acidtests.org
  73079. - Wait for the test to complete
  73080. - Click on the Reference Rendering link
  73081. - Be fast and see the results of acid3
  73082. => assert
  73083. * platform/network/qt/QNetworkReplyHandler.cpp:
  73084. (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  73085. (WebCore::QNetworkReplyHandler::setLoadMode):
  73086. (WebCore::QNetworkReplyHandler::finish):
  73087. (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  73088. (WebCore::QNetworkReplyHandler::forwardData):
  73089. (WebCore::QNetworkReplyHandler::start):
  73090. (WebCore::QNetworkReplyHandler::resetState):
  73091. (WebCore::QNetworkReplyHandler::sendQueuedItems):
  73092. * platform/network/qt/QNetworkReplyHandler.h:
  73093. (WebCore::QNetworkReplyHandler::):
  73094. * platform/network/qt/ResourceHandleQt.cpp:
  73095. (WebCore::ResourceHandle::start):
  73096. (WebCore::ResourceHandle::loadResourceSynchronously):
  73097. (WebCore::ResourceHandle::setDefersLoading):
  73098. 2008-08-29 Simon Hausmann <hausmann@webkit.org>
  73099. Reviewed by Holger.
  73100. Don't crash when drawing patterns with the HTML canvas. Patterns
  73101. remain unimplemented but at least they don't crash anymore. This is
  73102. done by changing the PlatformPatternPtr to be a brush for the Qt
  73103. platform.
  73104. * platform/graphics/Pattern.h:
  73105. * platform/graphics/qt/GraphicsContextQt.cpp:
  73106. (WebCore::GraphicsContext::fillPath):
  73107. (WebCore::GraphicsContext::strokePath):
  73108. (WebCore::GraphicsContext::fillRect):
  73109. * platform/graphics/qt/PatternQt.cpp:
  73110. (WebCore::Pattern::createPlatformPattern):
  73111. 2008-08-29 Simon Hausmann <hausmann@webkit.org>
  73112. Fix the Qt build, fontSelector() is not used by the Qt port yet
  73113. and we just return 0 in Font::fontSelector().
  73114. * platform/graphics/Font.h:
  73115. 2008-08-28 Alp Toker <alp@nuanti.com>
  73116. GTK+ dist/build fix. List newly added header files.
  73117. * GNUmakefile.am:
  73118. 2008-08-28 Simon Fraser <simon.fraser@apple.com>
  73119. Reviewed by Dave Hyatt
  73120. Various WebKitCSSTransformValue-related fixes
  73121. https://bugs.webkit.org/show_bug.cgi?id=20562
  73122. Test: css3/transform-value-types.html
  73123. * bindings/js/JSCSSValueCustom.cpp:
  73124. (WebCore::toJS):
  73125. * css/CSSValue.h:
  73126. * css/WebKitCSSTransformValue.cpp:
  73127. (WebCore::WebKitCSSTransformValue::cssText):
  73128. * css/WebKitCSSTransformValue.h:
  73129. (WebCore::WebKitCSSTransformValue::):
  73130. * css/WebKitCSSTransformValue.idl:
  73131. 2008-08-28 Dan Bernstein <mitz@apple.com>
  73132. Reviewed by Steve Falkenburg.
  73133. - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
  73134. * platform/win/SharedTimerWin.cpp:
  73135. (WebCore::TimerWindowWndProc):
  73136. 2008-08-28 David Hyatt <hyatt@apple.com>
  73137. RenderStyle cleanup.
  73138. Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
  73139. Reviewed by Adam
  73140. * css/CSSImageGeneratorValue.cpp:
  73141. * css/CSSImageValue.cpp:
  73142. * css/CSSStyleSelector.cpp:
  73143. * rendering/RenderImageGeneratedContent.cpp:
  73144. * rendering/style/NinePieceImage.cpp: Added.
  73145. * rendering/style/NinePieceImage.h: Added.
  73146. * rendering/style/RenderStyle.cpp:
  73147. (WebCore::FillLayer::operator==):
  73148. (WebCore::FillLayer::containsImage):
  73149. (WebCore::StyleInheritedData::operator==):
  73150. (WebCore::RenderStyle::contentDataEquivalent):
  73151. * rendering/style/RenderStyle.h:
  73152. * rendering/style/StyleCachedImage.cpp: Added.
  73153. * rendering/style/StyleCachedImage.h: Added.
  73154. * rendering/style/StyleGeneratedImage.cpp: Added.
  73155. * rendering/style/StyleGeneratedImage.h: Added.
  73156. * rendering/style/StyleImage.h: Added.
  73157. 2008-08-28 Simon Fraser <simon.fraser@apple.com>
  73158. Reviewed by Dave Hyatt
  73159. Make all the 'isFoo()' methods on CSSValue const,
  73160. and fix the subclasses.
  73161. https://bugs.webkit.org/show_bug.cgi?id=20561
  73162. * css/CSSTimingFunctionValue.h:
  73163. * css/CSSValue.h:
  73164. (WebCore::CSSValue::isFontValue):
  73165. (WebCore::CSSValue::isImageGeneratorValue):
  73166. (WebCore::CSSValue::isImageValue):
  73167. (WebCore::CSSValue::isImplicitInitialValue):
  73168. * css/CSSValueList.h:
  73169. * css/FontValue.h:
  73170. 2008-08-28 David Hyatt <hyatt@apple.com>
  73171. The great RenderStyle cleanup begins!
  73172. Move LengthBox and LengthSize out of RenderStyle and into Length.
  73173. Reviewed by Adam
  73174. * rendering/Length.h:
  73175. (WebCore::):
  73176. (WebCore::Length::Length):
  73177. (WebCore::Length::operator==):
  73178. (WebCore::Length::operator!=):
  73179. (WebCore::Length::value):
  73180. (WebCore::Length::rawValue):
  73181. (WebCore::Length::percent):
  73182. (WebCore::Length::type):
  73183. (WebCore::Length::quirk):
  73184. (WebCore::Length::setValue):
  73185. (WebCore::Length::setRawValue):
  73186. (WebCore::Length::calcValue):
  73187. (WebCore::Length::calcMinValue):
  73188. (WebCore::Length::calcFloatValue):
  73189. (WebCore::Length::isUndefined):
  73190. (WebCore::Length::isZero):
  73191. (WebCore::Length::isPositive):
  73192. (WebCore::Length::isNegative):
  73193. (WebCore::Length::isAuto):
  73194. (WebCore::Length::isRelative):
  73195. (WebCore::Length::isPercent):
  73196. (WebCore::Length::isFixed):
  73197. (WebCore::Length::isStatic):
  73198. (WebCore::Length::isIntrinsicOrAuto):
  73199. (WebCore::Length::blend):
  73200. (WebCore::LengthBox::LengthBox):
  73201. (WebCore::LengthBox::operator=):
  73202. (WebCore::LengthBox::operator==):
  73203. (WebCore::LengthBox::operator!=):
  73204. (WebCore::LengthBox::nonZero):
  73205. (WebCore::LengthSize::LengthSize):
  73206. * rendering/style/RenderStyle.h:
  73207. 2008-08-28 David Hyatt <hyatt@apple.com>
  73208. Reviewed by Darin
  73209. https://bugs.webkit.org/show_bug.cgi?id=18091
  73210. font-size should be animatable using -webkit-transition.
  73211. * page/AnimationController.cpp:
  73212. (WebCore::AnimationControllerPrivate::ensurePropertyMap):
  73213. * rendering/style/RenderStyle.h:
  73214. (WebCore::RenderStyle::setFontSize):
  73215. 2008-08-28 Brad Garcia <bgarcia@google.com>
  73216. Reviewed by Dan Bernstein.
  73217. https://bugs.webkit.org/show_bug.cgi?id=20549
  73218. Correctly determine when cursor is over a resizable border within
  73219. a nested frameset.
  73220. * rendering/RenderFrameSet.cpp:
  73221. (WebCore::RenderFrameSet::canResizeRow):
  73222. (WebCore::RenderFrameSet::canResizeColumn):
  73223. 2008-08-28 Simon Fraser <simon.fraser@apple.com>
  73224. Reviewed by Eric Seidel
  73225. Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
  73226. https://bugs.webkit.org/show_bug.cgi?id=20552
  73227. Test: animations/animation-css-rule-types.html
  73228. * css/CSSRule.idl:
  73229. 2008-08-28 Anders Carlsson <andersca@apple.com>
  73230. Reviewed by Kevin and Darin.
  73231. <rdar://problem/6182541>
  73232. https://bugs.webkit.org/show_bug.cgi?id=20202
  73233. Missing http status line from the http headers.
  73234. Add a status line to the header string.
  73235. * plugins/PluginStream.cpp:
  73236. (WebCore::PluginStream::startStream):
  73237. 2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
  73238. Rubber-stamped by Darin Adler.
  73239. https://bugs.webkit.org/show_bug.cgi?id=17261
  73240. Make it possible to theme the default Url icon and enable this for
  73241. the Qt port. To have a minimal usage of #ifdef in the code the setting
  73242. of the icon was moved to a new method which comes in two flavors.
  73243. * loader/icon/IconDatabase.cpp:
  73244. (WebCore::loadDefaultIconRecord): Load or set the default icon
  73245. (WebCore::IconDatabase::defaultIcon):
  73246. 2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
  73247. Unreviewed compile fix
  73248. * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
  73249. 2008-08-28 Adam Roben <aroben@apple.com>
  73250. Windows (and others?) build fix
  73251. * page/Chrome.cpp: Added a missing #include.
  73252. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
  73253. 2008-08-27 Eric Seidel <eric@webkit.org>
  73254. Reviewed by Oliver Hunt.
  73255. Qt and Cairo support from krit (and blind stab @ wx compile support)
  73256. https://bugs.webkit.org/show_bug.cgi?id=20373
  73257. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  73258. (WebCore::GraphicsContext::fillPath):
  73259. (WebCore::GraphicsContext::strokePath):
  73260. (WebCore::GraphicsContext::drawPath):
  73261. (WebCore::GraphicsContext::fillRect):
  73262. (WebCore::GraphicsContext::setPlatformFillColor):
  73263. (WebCore::GraphicsContext::setPlatformStrokeColor):
  73264. (WebCore::GraphicsContext::setPlatformStrokeStyle):
  73265. (WebCore::GraphicsContext::strokeRect):
  73266. (WebCore::GraphicsContext::setImageInterpolationQuality):
  73267. (WebCore::GraphicsContext::imageInterpolationQuality):
  73268. (WebCore::GraphicsContext::setPlatformFillPattern):
  73269. (WebCore::GraphicsContext::setPlatformStrokePattern):
  73270. (WebCore::GraphicsContext::setPlatformFillGradient):
  73271. (WebCore::GraphicsContext::setPlatformStrokeGradient):
  73272. * platform/graphics/qt/GraphicsContextQt.cpp:
  73273. (WebCore::GraphicsContext::fillPath):
  73274. (WebCore::GraphicsContext::strokePath):
  73275. (WebCore::GraphicsContext::fillRect):
  73276. (WebCore::GraphicsContext::strokeRect):
  73277. (WebCore::GraphicsContext::clipToImageBuffer):
  73278. (WebCore::GraphicsContext::setPlatformFillPattern):
  73279. (WebCore::GraphicsContext::setPlatformStrokePattern):
  73280. (WebCore::GraphicsContext::setPlatformFillGradient):
  73281. (WebCore::GraphicsContext::setPlatformStrokeGradient):
  73282. (WebCore::GraphicsContext::setImageInterpolationQuality):
  73283. (WebCore::GraphicsContext::imageInterpolationQuality):
  73284. * platform/graphics/wx/GraphicsContextWx.cpp:
  73285. (WebCore::GraphicsContext::clipToImageBuffer):
  73286. (WebCore::GraphicsContext::setImageInterpolationQuality):
  73287. (WebCore::GraphicsContext::imageInterpolationQuality):
  73288. (WebCore::GraphicsContext::fillPath):
  73289. (WebCore::GraphicsContext::strokePath):
  73290. (WebCore::GraphicsContext::drawPath):
  73291. (WebCore::GraphicsContext::fillRect):
  73292. (WebCore::GraphicsContext::setPlatformFillPattern):
  73293. (WebCore::GraphicsContext::setPlatformStrokePattern):
  73294. (WebCore::GraphicsContext::setPlatformFillGradient):
  73295. 2008-08-27 Eric Seidel <eric@webkit.org>
  73296. Reviewed by Oliver Hunt.
  73297. Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
  73298. https://bugs.webkit.org/show_bug.cgi?id=20373
  73299. Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
  73300. Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
  73301. have to store large Gradient objects in the GraphicsContextState
  73302. Made Pattern RefCounted for the same reason.
  73303. Many updates to GraphicsContext to support easier drawing with
  73304. Patterns and Gradients.
  73305. * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
  73306. * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  73307. (WebCore::toJS):
  73308. * css/CSSGradientValue.cpp:
  73309. (WebCore::CSSGradientValue::createGradient):
  73310. * css/CSSGradientValue.h:
  73311. * html/CanvasGradient.cpp:
  73312. (WebCore::CanvasGradient::CanvasGradient):
  73313. * html/CanvasGradient.h:
  73314. (WebCore::CanvasGradient::gradient):
  73315. (WebCore::CanvasGradient::addColorStop):
  73316. (WebCore::CanvasGradient::getColor):
  73317. * html/CanvasPattern.cpp:
  73318. * html/CanvasPattern.h:
  73319. (WebCore::CanvasPattern::pattern):
  73320. (WebCore::CanvasPattern::originClean):
  73321. * html/CanvasRenderingContext2D.cpp:
  73322. (WebCore::CanvasRenderingContext2D::State::State):
  73323. (WebCore::CanvasRenderingContext2D::setStrokeStyle):
  73324. (WebCore::CanvasRenderingContext2D::setFillStyle):
  73325. (WebCore::CanvasRenderingContext2D::fill):
  73326. (WebCore::CanvasRenderingContext2D::stroke):
  73327. (WebCore::CanvasRenderingContext2D::fillRect):
  73328. (WebCore::CanvasRenderingContext2D::strokeRect):
  73329. * html/CanvasRenderingContext2D.h:
  73330. * html/CanvasStyle.cpp:
  73331. (WebCore::CanvasStyle::applyStrokeColor):
  73332. (WebCore::CanvasStyle::applyFillColor):
  73333. * html/CanvasStyle.h:
  73334. * platform/graphics/GeneratedImage.h:
  73335. (WebCore::GeneratedImage::GeneratedImage):
  73336. * platform/graphics/Generator.h:
  73337. * platform/graphics/Gradient.h:
  73338. (WebCore::Gradient::create):
  73339. * platform/graphics/GraphicsContext.cpp:
  73340. (WebCore::GraphicsContext::fillRule):
  73341. (WebCore::GraphicsContext::setFillRule):
  73342. (WebCore::GraphicsContext::setStrokePattern):
  73343. (WebCore::GraphicsContext::setFillPattern):
  73344. (WebCore::GraphicsContext::setStrokeGradient):
  73345. (WebCore::GraphicsContext::setFillGradient):
  73346. * platform/graphics/GraphicsContext.h:
  73347. * platform/graphics/GraphicsContextPrivate.h:
  73348. (WebCore::):
  73349. (WebCore::GraphicsContextState::GraphicsContextState):
  73350. * platform/graphics/GraphicsTypes.h:
  73351. * platform/graphics/Path.h:
  73352. * platform/graphics/Pattern.h:
  73353. (WebCore::Pattern::create):
  73354. (WebCore::Pattern::tileImage):
  73355. * platform/graphics/cg/GraphicsContextCG.cpp:
  73356. (WebCore::GraphicsContext::drawRect):
  73357. (WebCore::GraphicsContext::drawEllipse):
  73358. (WebCore::GraphicsContext::drawConvexPolygon):
  73359. (WebCore::calculateDrawingMode):
  73360. (WebCore::GraphicsContext::drawPath):
  73361. (WebCore::fillPathWithFillRule):
  73362. (WebCore::GraphicsContext::fillPath):
  73363. (WebCore::GraphicsContext::strokePath):
  73364. (WebCore::GraphicsContext::fillRect):
  73365. (WebCore::GraphicsContext::fillRoundedRect):
  73366. (WebCore::GraphicsContext::setPlatformStrokePattern):
  73367. (WebCore::GraphicsContext::setPlatformFillPattern):
  73368. (WebCore::GraphicsContext::setPlatformStrokeGradient):
  73369. (WebCore::GraphicsContext::setPlatformFillGradient):
  73370. 2008-08-20 Eric Seidel <eric@webkit.org>
  73371. Reviewed by Darin and Alexey.
  73372. Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
  73373. with timeouts paused.
  73374. https://bugs.webkit.org/show_bug.cgi?id=20469
  73375. I attempted to clean up the memory management of PausedTimeouts, I'm not
  73376. sure the solution I came up with is "cleaner", but it's in some ways
  73377. "safer", since it no longer uses raw pointers and manual new/delete.
  73378. This also now prevents CachedPage from needlessly creating Window
  73379. objects when caching pages which didn't already have one. :)
  73380. I also made Chrome.cpp no longer depend on the JavaScript bindings
  73381. (aka JSDOMWindowBase.h), since there was no real reason for it to.
  73382. * bindings/js/JSDOMWindowBase.cpp:
  73383. (WebCore::JSDOMWindowBase::pauseTimeouts):
  73384. (WebCore::JSDOMWindowBase::resumeTimeouts):
  73385. * bindings/js/JSDOMWindowBase.h:
  73386. * bindings/js/ScriptController.cpp:
  73387. (WebCore::ScriptController::pauseTimeouts):
  73388. (WebCore::ScriptController::resumeTimeouts):
  73389. * bindings/js/ScriptController.h:
  73390. * history/CachedPage.cpp:
  73391. (WebCore::CachedPage::CachedPage):
  73392. (WebCore::CachedPage::restore):
  73393. * page/Chrome.cpp:
  73394. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  73395. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  73396. * page/JavaScriptDebugServer.cpp:
  73397. (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
  73398. (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  73399. 2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
  73400. Unreviewed compile fix
  73401. Add the stub for the Qt port.
  73402. * WebCore.pro:
  73403. * page/qt/AccessibilityObjectQt.cpp: Added.
  73404. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  73405. 2008-08-27 Alp Toker <alp@nuanti.com>
  73406. Reviewed by Eric.
  73407. https://bugs.webkit.org/show_bug.cgi?id=20551
  73408. [GTK] search popup crash
  73409. * platform/gtk/SearchPopupMenuGtk.cpp:
  73410. (WebCore::SearchPopupMenu::enabled):
  73411. Fix a search popup crasher by disabling the history popup since we
  73412. don't support this feature yet in the GTK+ port.
  73413. 2008-08-27 Alp Toker <alp@nuanti.com>
  73414. Reviewed by Eric.
  73415. https://bugs.webkit.org/show_bug.cgi?id=20551
  73416. [GTK] curl crashers
  73417. * platform/network/curl/ResourceHandleManager.cpp:
  73418. (WebCore::ResourceHandleManager::startScheduledJobs):
  73419. Remove the resource handle from the pending list before starting the
  73420. job, not afterwards. Fixes crashers in the test suite.
  73421. Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
  73422. Test: fast/encoding/char-encoding.html
  73423. 2008-08-27 Dirk Schulze <vbs85@gmx.de>
  73424. Reviewed by eseidel.
  73425. Fix canvas drawImage to support composite operations.
  73426. Composite had no effect on canvas elements like these:
  73427. http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
  73428. [CAIRO] Canvas composite don't work on canvas-elements.
  73429. https://bugs.webkit.org/show_bug.cgi?id=20548
  73430. * html/CanvasRenderingContext2D.cpp:
  73431. (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
  73432. 2008-08-27 Mario Bensi <mbensi@pleyo.com>
  73433. Reviewed by Eric Seidel.
  73434. Fix the data content of an image with a base64.
  73435. * platform/network/curl/ResourceHandleManager.cpp:
  73436. (WebCore::parseDataUrl): Remove the String and use only the data
  73437. Vector because the data.latin1().data() convert the data content and
  73438. the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
  73439. not drawn correctly.
  73440. 2008-08-27 Antti Koivisto <antti@apple.com>
  73441. Reviewed by Eric Seidel.
  73442. Crash after OK in dialog box and reloading page in secure mode
  73443. https://bugs.webkit.org/show_bug.cgi?id=20493
  73444. The new run loop spawned by a modal dialog causes a timer in the loader to run
  73445. synchronously inside didFinishLoading() deleting "this" object.
  73446. Defer all WebCore timers when a modal dialog is up. They are not
  73447. safe to execute.
  73448. * page/Chrome.cpp:
  73449. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  73450. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  73451. 2008-08-27 Chris Marrin <cmarrin@apple.com>
  73452. Reviewed by Dave Hyatt
  73453. Memory leaks when animating transforms
  73454. https://bugs.webkit.org/show_bug.cgi?id=20532
  73455. * rendering/style/RenderStyle.cpp:
  73456. (WebCore::ScaleTransformOperation::blend):
  73457. (WebCore::RotateTransformOperation::blend):
  73458. (WebCore::SkewTransformOperation::blend):
  73459. (WebCore::TranslateTransformOperation::blend):
  73460. (WebCore::MatrixTransformOperation::blend):
  73461. * rendering/style/RenderStyle.h:
  73462. 2008-08-27 Timothy Hatcher <timothy@apple.com>
  73463. Add support for support for -webkit-appearance: default-button on the Mac platform.
  73464. <rdar://problem/6173530>
  73465. Reviewed by Dave Hyatt.
  73466. * WebCore.base.exp: Export new symbols.
  73467. * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
  73468. * platform/mac/WebCoreSystemInterface.mm: Ditto.
  73469. * rendering/RenderButton.cpp:
  73470. (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
  73471. (WebCore::RenderButton::setStyle): Ditto.
  73472. * rendering/RenderButton.h: Ditto.
  73473. * rendering/RenderThemeMac.mm:
  73474. (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
  73475. (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
  73476. key if the button is default, otherwise reset the key equivalent.
  73477. (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
  73478. on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
  73479. the window's previous default button cell when finished.
  73480. 2008-08-26 David Hyatt <hyatt@apple.com>
  73481. First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
  73482. Reviewed by weinig
  73483. Added fast/forms/zoomed-controls.html
  73484. * css/CSSStyleSelector.cpp:
  73485. (WebCore::addIntrinsicMargins):
  73486. * rendering/RenderSlider.cpp:
  73487. (WebCore::RenderSlider::calcPrefWidths):
  73488. * rendering/RenderThemeMac.h:
  73489. * rendering/RenderThemeMac.mm:
  73490. (WebCore::RenderThemeMac::adjustRepaintRect):
  73491. (WebCore::RenderThemeMac::inflateRect):
  73492. (WebCore::RenderThemeMac::baselinePosition):
  73493. (WebCore::RenderThemeMac::setControlSize):
  73494. (WebCore::RenderThemeMac::sizeForFont):
  73495. (WebCore::RenderThemeMac::sizeForSystemFont):
  73496. (WebCore::RenderThemeMac::setFontFromControlSize):
  73497. (WebCore::RenderThemeMac::paintCheckbox):
  73498. (WebCore::RenderThemeMac::setCheckboxCellState):
  73499. (WebCore::RenderThemeMac::paintRadio):
  73500. (WebCore::RenderThemeMac::setRadioCellState):
  73501. (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
  73502. (WebCore::RenderThemeMac::adjustButtonStyle):
  73503. (WebCore::RenderThemeMac::setButtonCellState):
  73504. (WebCore::RenderThemeMac::paintButton):
  73505. (WebCore::RenderThemeMac::paintMenuList):
  73506. (WebCore::RenderThemeMac::paintMenuListButton):
  73507. (WebCore::RenderThemeMac::popupInternalPaddingLeft):
  73508. (WebCore::RenderThemeMac::popupInternalPaddingRight):
  73509. (WebCore::RenderThemeMac::popupInternalPaddingTop):
  73510. (WebCore::RenderThemeMac::popupInternalPaddingBottom):
  73511. (WebCore::RenderThemeMac::setPopupButtonCellState):
  73512. (WebCore::RenderThemeMac::paintSliderTrack):
  73513. (WebCore::RenderThemeMac::paintSliderThumb):
  73514. (WebCore::RenderThemeMac::adjustSliderThumbSize):
  73515. (WebCore::RenderThemeMac::paintSearchField):
  73516. (WebCore::RenderThemeMac::adjustSearchFieldStyle):
  73517. (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
  73518. (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
  73519. 2008-08-27 Brady Eidson <beidson@apple.com>
  73520. Reviewed by Anders
  73521. <rdar://problem/6134133> - Crash when loading large movie as a standalone document
  73522. We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
  73523. to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
  73524. away the virtual address space and a crash.
  73525. * loader/EmptyClients.h:
  73526. (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
  73527. * loader/FrameLoaderClient.h: Added client method to get platform specific error for
  73528. "plugin will handle load"
  73529. * loader/MediaDocument.cpp:
  73530. (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
  73531. and cancel the WebCore-managed load
  73532. (WebCore::MediaTokenizer::writeRawData):
  73533. (WebCore::MediaTokenizer::finish):
  73534. 2008-08-26 Simon Fraser <simon.fraser@apple.com>
  73535. Reviewed by Eric Seidel
  73536. Linear timing functions should have control points 0, 0, 1, 1.
  73537. https://bugs.webkit.org/show_bug.cgi?id=20535
  73538. * css/CSSStyleSelector.cpp:
  73539. (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
  73540. * rendering/style/RenderStyle.h:
  73541. 2008-08-27 Adam Roben <aroben@apple.com>
  73542. Windows build fix
  73543. * WebCore.vcproj/WebCore.vcproj: Fix file extension.
  73544. 2008-08-26 Chris Fleizach <cfleizach@apple.com>
  73545. Reviewed by Beth Dakin.
  73546. <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
  73547. Added platform-specific accessibilityIgnoreAttachment, which allows the platform
  73548. to determine if an attachment is ignored through accessibility. Added equivalent
  73549. methods in Gtk, Win and Mac
  73550. Test: accessibility/plugin.html
  73551. * GNUmakefile.am:
  73552. * WebCore.vcproj/WebCore.vcproj:
  73553. * WebCore.xcodeproj/project.pbxproj:
  73554. * page/AccessibilityObject.h:
  73555. * page/AccessibilityRenderObject.cpp:
  73556. (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  73557. * page/gtk/AccessibilityObjectAtk.cpp: Added.
  73558. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  73559. * page/mac/AccessibilityObjectMac.mm: Added.
  73560. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  73561. * page/mac/AccessibilityObjectWrapper.h:
  73562. * page/win/AccessibilityObjectWin.cpp: Added.
  73563. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
  73564. 2008-08-26 Chris Fleizach <cfleizach@apple.com>
  73565. Reviewed by Beth Dakin.
  73566. <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
  73567. * page/mac/AccessibilityObjectWrapper.mm:
  73568. (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
  73569. (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
  73570. 2008-08-26 Chris Fleizach <cfleizach@apple.com>
  73571. Reviewed by Darin Adler.
  73572. <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
  73573. Tests: accessibility/table-notbody.html
  73574. * page/AccessibilityTable.cpp:
  73575. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  73576. 2008-08-26 Sam Weinig <sam@webkit.org>
  73577. Reviewed by Beth Dakin.
  73578. Fix typo.
  73579. * dom/DOMCoreException.h:
  73580. 2008-08-26 Sam Weinig <sam@webkit.org>
  73581. Reviewed by Oliver Hunt.
  73582. Fix https://bugs.webkit.org/show_bug.cgi?id=20479
  73583. <rdar://problem/6167660>
  73584. Take image redirects into account when tainting the canvas.
  73585. Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
  73586. * html/CanvasRenderingContext2D.cpp:
  73587. (WebCore::CanvasRenderingContext2D::drawImage):
  73588. (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  73589. 2008-08-26 Sam Weinig <sam@webkit.org>
  73590. Reviewed by Darin Adler.
  73591. Change canvas tainting logic to ask the image if it contains
  73592. any resources outside of its own origin. Since there is no
  73593. way to determine if SVG images contain any resources outside its
  73594. origin, we always assume it does.
  73595. * html/CanvasRenderingContext2D.cpp:
  73596. (WebCore::CanvasRenderingContext2D::drawImage):
  73597. (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  73598. * platform/graphics/BitmapImage.h:
  73599. (WebCore::BitmapImage::hasSingleSecurityOrigin):
  73600. * platform/graphics/GeneratedImage.h:
  73601. (WebCore::GeneratedImage::hasSingleSecurityOrigin):
  73602. * platform/graphics/Image.h:
  73603. (WebCore::Image::hasSingleSecurityOrigin):
  73604. * platform/graphics/cg/PDFDocumentImage.h:
  73605. (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
  73606. * svg/graphics/SVGImage.h:
  73607. 2008-08-26 Maxime Britto <britto@apple.com>
  73608. Reviewed by Adele.
  73609. <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
  73610. This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
  73611. This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
  73612. * page/EventHandler.cpp:
  73613. (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
  73614. * page/EventHandler.h:
  73615. * rendering/RenderLayer.cpp:
  73616. (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
  73617. (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
  73618. * rendering/RenderLayer.h:
  73619. * rendering/RenderObject.cpp:
  73620. (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
  73621. (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
  73622. (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
  73623. 2008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
  73624. Reviewed by Darin Adler.
  73625. Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
  73626. https://bugs.webkit.org/show_bug.cgi?id=20247
  73627. <rdar://problem/6118218>
  73628. Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
  73629. check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
  73630. (case insensitive for HTML elements).
  73631. Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
  73632. * dom/Element.cpp:
  73633. (WebCore::Element::getAttribute):
  73634. * dom/NamedAttrMap.cpp:
  73635. (WebCore::NamedAttrMap::getNamedItem):
  73636. (WebCore::NamedAttrMap::getAttributeItem):
  73637. * dom/NamedAttrMap.h:
  73638. 2008-08-25 Sam Weinig <sam@webkit.org>
  73639. Reviewed by Oliver Hunt.
  73640. Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
  73641. <rdar://problem/6174096>
  73642. Treat SVG images as dirty when drawing to a canvas.
  73643. Test: http/tests/security/canvas-remote-read-svg-image.html
  73644. * html/CanvasRenderingContext2D.cpp:
  73645. (WebCore::CanvasRenderingContext2D::drawImage):
  73646. (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  73647. * platform/graphics/Image.h:
  73648. (WebCore::Image::isSVGImage):
  73649. * svg/graphics/SVGImage.h:
  73650. (WebCore::SVGImage::isSVGImage):
  73651. 2008-08-25 Sam Weinig <sam@webkit.org>
  73652. Reviewed by Mark Rowe.
  73653. Fix https://bugs.webkit.org/show_bug.cgi?id=20377
  73654. Leak in XMLHttpRequest.
  73655. * xml/XMLHttpRequest.cpp:
  73656. (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
  73657. 2008-08-25 Brady Eidson <beidson@apple.com>
  73658. Reviewed by Anders
  73659. Speculative fix for <rdar://problem/6173217>
  73660. Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
  73661. Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
  73662. the first null check invalid.
  73663. * loader/FrameLoader.cpp:
  73664. (WebCore::FrameLoader::stopAllLoaders):
  73665. 2008-08-25 Kevin McCullough <kmccullough@apple.com>
  73666. Reviewed by Tim.
  73667. <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
  73668. there is no profile, can cause crash
  73669. * page/inspector/ProfilesPanel.js:
  73670. 2008-08-25 Dean Jackson <dino@apple.com>
  73671. Reviewed by Dave Hyatt
  73672. Make sure 'inherit' is handled by transition property.
  73673. https://bugs.webkit.org/show_bug.cgi?id=20513
  73674. Test: transitions/inherit.html
  73675. Test: transitions/inherit-other-props.html
  73676. * css/CSSStyleSelector.cpp:
  73677. fix macro to check existence of list before getting size
  73678. 2008-08-25 Anders Carlsson <andersca@apple.com>
  73679. Reviewed by Mark.
  73680. <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
  73681. Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
  73682. (safely) that any class that needs finalization on the main thread will also need to be deallocated
  73683. on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
  73684. calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
  73685. * platform/mac/WebCoreObjCExtras.c:
  73686. (WebCoreObjCFinalizeOnMainThread):
  73687. 2008-08-25 Antti Koivisto <antti@apple.com>
  73688. Reviewed by Dan Bernstein.
  73689. Rename CachedResource::referenced() to CachedResource::hasClients() to
  73690. match previous ref() -> addClient() rename.
  73691. * loader/Cache.cpp:
  73692. (WebCore::Cache::pruneLiveResources):
  73693. (WebCore::Cache::pruneDeadResources):
  73694. (WebCore::Cache::remove):
  73695. (WebCore::Cache::getStatistics):
  73696. (WebCore::Cache::dumpLRULists):
  73697. * loader/CachedResource.cpp:
  73698. (WebCore::CachedResource::addClient):
  73699. (WebCore::CachedResource::removeClient):
  73700. (WebCore::CachedResource::setDecodedSize):
  73701. (WebCore::CachedResource::setEncodedSize):
  73702. * loader/CachedResource.h:
  73703. (WebCore::CachedResource::hasClients):
  73704. (WebCore::CachedResource::canDelete):
  73705. 2008-08-25 Anthony Ricaud <rik24d@gmail.com>
  73706. Add a missing Inspector localized string for "other".
  73707. https://bugs.webkit.org/show_bug.cgi?id=20509
  73708. Reviewed by Tim Hatcher.
  73709. * English.lproj/localizedStrings.js:
  73710. 2008-08-22 Kevin McCullough <kmccullough@apple.com>
  73711. Reviewed by Geoff, Mark and Tim.
  73712. <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
  73713. in the console said what file and line number they came from
  73714. - Lay the foundation for getting line numbers and other data from the
  73715. JavaScript engine.
  73716. * ForwardingHeaders/VM: Added.
  73717. * ForwardingHeaders/VM/Machine.h: Added.
  73718. * page/Console.cpp: Gather the line number and file information when
  73719. profileEnd has been called, but don't use it until didFinishProfiling is
  73720. called. We won't need to wait once we remove the profiler "zombie" mode
  73721. which this patch helps pave the foundation for.
  73722. (WebCore::Console::Console):
  73723. (WebCore::Console::profileEnd):
  73724. (WebCore::Console::finishedProfiling):
  73725. * page/Console.h:
  73726. * page/InspectorController.cpp: Modify calls to
  73727. addProfileMessageToConsole to satisfy the new arguments it takes.
  73728. (WebCore::InspectorController::finishedProfiling):
  73729. (WebCore::InspectorController::addProfile):
  73730. (WebCore::InspectorController::addProfileMessageToConsole):
  73731. (WebCore::InspectorController::finishedProfiling):
  73732. * page/InspectorController.h:
  73733. 2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
  73734. Reviewed by Simon.
  73735. [inspector] Update the WebKit.qrc Qt resources file
  73736. Catchup with the changes in the directory.
  73737. * page/inspector/WebKit.qrc:
  73738. 2008-08-25 Dirk Schulze <vbs85@gmx.de>
  73739. Reviewed by Simon.
  73740. Transformed the radian to degree, to get rotate()
  73741. in canvas work as expected.
  73742. [Qt] Canvas.rotate() doesn't work
  73743. https://bugs.webkit.org/show_bug.cgi?id=20496
  73744. * platform/graphics/qt/GraphicsContextQt.cpp:
  73745. (WebCore::GraphicsContext::rotate):
  73746. 2008-08-24 Steve Falkenburg <sfalken@apple.com>
  73747. Add a "last chance" WM_TIMER to the Windows shared timer.
  73748. The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
  73749. Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
  73750. timers if a timer with an earlier expiration is already pending. This results in no timers
  73751. firing from that point on.
  73752. We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
  73753. buggy window message hook.
  73754. This timer will start when the first WM_TIMER is scheduled, and will
  73755. fire every 5 seconds thereafter, causing any lost timers to be fired.
  73756. Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
  73757. and prevents the WebFrame leak.
  73758. Reviewed by Darin Adler, Geoff Garen.
  73759. * platform/win/SharedTimerWin.cpp:
  73760. (WebCore::):
  73761. (WebCore::TimerWindowWndProc):
  73762. (WebCore::setSharedTimerFireTime):
  73763. 2008-08-24 Dan Bernstein <mitz@apple.com>
  73764. Reviewed by Darin Adler.
  73765. - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
  73766. Test: fast/css/font-property-priority.html
  73767. * css/CSSParser.cpp:
  73768. (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
  73769. to the font-property-parsing functions.
  73770. (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
  73771. changed to use it rather than the m_important member.
  73772. (WebCore::CSSParser::parseFontVariant): Ditto.
  73773. (WebCore::CSSParser::parseFontWeight): Ditto.
  73774. * css/CSSParser.h:
  73775. 2008-08-24 Timothy Hatcher <timothy@apple.com>
  73776. Fixes a bug where the Inspector's UI would not animate or
  73777. fully function because JavaScript timeouts, intervals and
  73778. CSS animation timers where not firing while paused at a
  73779. a breakpoint in the inspected page.
  73780. https://bugs.webkit.org/show_bug.cgi?id=20042
  73781. Reviewed by Darin Adler.
  73782. Test: manual-tests/inspector/forzen-ui-while-paused.html
  73783. * page/JavaScriptDebugServer.cpp:
  73784. (WebCore::JavaScriptDebugServer::pauseIfNeeded):
  73785. Add a call to TimerBase::fireTimersInNestedEventLoop before
  73786. spinning the EventLoop.
  73787. 2008-08-24 Rob Buis <buis@kde.org>
  73788. Reviewed by Sam Weinig.
  73789. https://bugs.webkit.org/show_bug.cgi?id=20324
  73790. A change in SVG Glyph wont show up
  73791. Invalidate the glyph cache when the d attribute is set.
  73792. Test: svg/custom/glyph-setting-d-attribute.svg
  73793. * svg/SVGGlyphElement.cpp:
  73794. (WebCore::SVGGlyphElement::invalidateGlyphCache):
  73795. (WebCore::SVGGlyphElement::parseMappedAttribute):
  73796. (WebCore::SVGGlyphElement::insertedIntoDocument):
  73797. (WebCore::SVGGlyphElement::removedFromDocument):
  73798. * svg/SVGGlyphElement.h:
  73799. 2008-08-24 Dan Bernstein <mitz@apple.com>
  73800. Reviewed by Sam Weinig.
  73801. - fix https://bugs.webkit.org/show_bug.cgi?id=13864
  73802. <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
  73803. * rendering/RenderText.cpp:
  73804. (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
  73805. beginWS and endWS before the early return to ensure that they are
  73806. initialized in that case.
  73807. 2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  73808. Rubber-stamped by Mark Rowe.
  73809. Remove modelines.
  73810. * WebCore.pro:
  73811. * bridge/testbindings.cpp:
  73812. * dom/DocPtr.h:
  73813. * loader/SubstituteData.h:
  73814. * page/Chrome.cpp:
  73815. * page/Chrome.h:
  73816. * page/ChromeClient.h:
  73817. * page/Frame.h:
  73818. * page/FrameLoadRequest.h:
  73819. * page/FrameTree.cpp:
  73820. * page/FrameTree.h:
  73821. * page/Page.h:
  73822. * page/mac/ChromeMac.mm:
  73823. * platform/network/HTTPHeaderMap.h:
  73824. * platform/network/ResourceErrorBase.cpp:
  73825. * platform/network/ResourceErrorBase.h:
  73826. * platform/network/ResourceHandleInternal.h:
  73827. * platform/network/ResourceRequestBase.cpp:
  73828. * platform/network/ResourceRequestBase.h:
  73829. * platform/network/ResourceResponseBase.cpp:
  73830. * platform/network/ResourceResponseBase.h:
  73831. * platform/network/cf/ResourceError.h:
  73832. * platform/network/cf/ResourceRequest.h:
  73833. * platform/network/cf/ResourceRequestCFNet.h:
  73834. * platform/network/cf/ResourceResponse.h:
  73835. * platform/network/cf/ResourceResponseCFNet.h:
  73836. * platform/network/curl/ResourceError.h:
  73837. * platform/network/curl/ResourceRequest.h:
  73838. * platform/network/curl/ResourceResponse.h:
  73839. * platform/network/mac/ResourceError.h:
  73840. * platform/network/mac/ResourceErrorMac.mm:
  73841. * platform/network/mac/ResourceRequest.h:
  73842. * platform/network/mac/ResourceRequestMac.mm:
  73843. * platform/network/mac/ResourceResponse.h:
  73844. * platform/network/mac/ResourceResponseMac.mm:
  73845. * platform/network/qt/ResourceError.h:
  73846. * platform/network/qt/ResourceRequest.h:
  73847. * platform/network/qt/ResourceResponse.h:
  73848. * platform/network/soup/CookieJarSoup.cpp:
  73849. * platform/network/soup/ResourceError.h:
  73850. * platform/network/soup/ResourceRequest.h:
  73851. * platform/network/soup/ResourceResponse.h:
  73852. 2008-08-23 Dan Bernstein <mitz@apple.com>
  73853. Reviewed by Dave Hyatt.
  73854. - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
  73855. Test: fast/table/vertical-align-baseline.html
  73856. * rendering/RenderTable.cpp:
  73857. (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
  73858. baseline of the first table row, if there is one, -1 otherwise.
  73859. * rendering/RenderTable.h:
  73860. * rendering/RenderTableCell.cpp:
  73861. (WebCore::RenderTableCell::baselinePosition): Changed to follow the
  73862. CSS2.1 definition of the baseline of a table cell.
  73863. * rendering/RenderTableSection.cpp:
  73864. (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
  73865. the baseline of the first row in the section.
  73866. * rendering/RenderTableSection.h:
  73867. 2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
  73868. Add SPI to make a Windows WebView transparent.
  73869. Reviewed by Dan Bernstein.
  73870. * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
  73871. determines whether the created context has an alpha channel.
  73872. * platform/graphics/win/GraphicsContextCGWin.cpp:
  73873. (WebCore::CGContextWithHDC):
  73874. 2008-08-22 Timothy Hatcher <timothy@apple.com>
  73875. Rolls out r35834 because it caused a regression in the Inspector's
  73876. Console where some expressions always threw a syntax error.
  73877. https://bugs.webkit.org/show_bug.cgi?id=20487
  73878. * page/inspector/Console.js:
  73879. (Console.prototype._evalInInspectedWindow): Removes parenthesis
  73880. around the expression.
  73881. 2008-08-22 Timothy Hatcher <timothy@apple.com>
  73882. Makes getStyleProperty return a value for the overflow property
  73883. when overflow-x and overflow-y are equal.
  73884. https://bugs.webkit.org/show_bug.cgi?id=20485
  73885. Reviewed by Dan Bernstein.
  73886. Test: fast/css/overflow-property.html
  73887. * css/CSSMutableStyleDeclaration.cpp:
  73888. (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  73889. 2008-08-22 Timothy Hatcher <timothy@apple.com>
  73890. Fixes a bug where while editing in the Inspector the
  73891. sidebar scroll position would jump to the top.
  73892. https://bugs.webkit.org/show_bug.cgi?id=20484
  73893. Reviewed by Darin Adler.
  73894. * page/inspector/treeoutline.js:
  73895. (TreeOutline._removeChildren): Remove the offsetTop call that
  73896. was forcing a layout, since layout causes scroll positions
  73897. to be clamped to the new scrollHeight/Width. Layout will happen
  73898. normally when needed.
  73899. 2008-08-22 Kevin Ollivier <kevino@theolliviers.com>
  73900. wx build fix. Add AccessibilityTable sources.
  73901. * WebCoreSources.bkl:
  73902. 2008-08-21 Dan Bernstein <mitz@apple.com>
  73903. Reviewed by Jon Honeycutt and Alexey Proskuryakov.
  73904. - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
  73905. Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
  73906. * platform/graphics/mac/SimpleFontDataMac.mm:
  73907. (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
  73908. ascent and 100% to its reported descent.
  73909. 2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
  73910. Reviewed by Darin Adler.
  73911. https://bugs.webkit.org/show_bug.cgi?id=20267
  73912. [GTK] Crash on some pages due to a plugin
  73913. Fix handling of badly formatted and empty plugin mime descriptions
  73914. * plugins/gtk/PluginPackageGtk.cpp:
  73915. (WebCore::PluginPackage::fetchInfo):
  73916. 2008-08-21 Kevin Watters <kevinwatters@gmail.com>
  73917. Reviewed by Darin Adler.
  73918. Follow other ports (and IE) in ImageSourceWx.cpp never to return an
  73919. animated GIF frame duration of less than 50ms.
  73920. * platform/graphics/wx/ImageSourceWx.cpp:
  73921. (WebCore::ImageSource::frameDurationAtIndex):
  73922. 2008-08-21 Maxime Britto <britto@apple.com>
  73923. Reviewed by Kevin McCullough.
  73924. Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
  73925. https://bugs.webkit.org/show_bug.cgi?id=20451
  73926. rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
  73927. When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
  73928. This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
  73929. * page/EventHandler.cpp:
  73930. (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
  73931. (WebCore::EventHandler::handleMousePressEvent): ditto
  73932. 2008-08-21 Anthony Ricaud <rik24d@gmail.com>
  73933. Small optimization for when the dividers in the Inspector's
  73934. Resources panel are updated.
  73935. Reviewed by Tim Hatcher.
  73936. * page/inspector/ResourcesPanel.js:
  73937. (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
  73938. Combind a for loop and clone the divider element.
  73939. 2008-08-21 Chris Marrin <cmarrin@apple.com>
  73940. Allow 0 (without units) for Time eg. duration
  73941. Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
  73942. Reviewed by Dave Hyatt.
  73943. Test: css1/units/zero-duration-without-units.html
  73944. * css/CSSParser.cpp:
  73945. (WebCore::CSSParser::validUnit):
  73946. 2008-08-21 Timothy Hatcher <timothy@apple.com>
  73947. Make deleting all text while editing a DOM attribute in
  73948. the Inspector delete the attribute. This also fixes
  73949. an exception that would happen before.
  73950. https://bugs.webkit.org/show_bug.cgi?id=20472
  73951. Reviewed by Kevin McCullough.
  73952. * page/inspector/ElementsPanel.js:
  73953. (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
  73954. Don't check for hasAttributes on the parseElement, continuing
  73955. through the function will correctly remove the attribute.
  73956. If the parseElement is null, call _editingCancelled not
  73957. editingCancelled, this fixes an exception.
  73958. 2008-08-21 Timothy Hatcher <timothy@apple.com>
  73959. Update the Inspector's Metrics pane when editing in
  73960. the Styles pane. This makes sure the metrics shown
  73961. always match what the Styles pane shows.
  73962. https://bugs.webkit.org/show_bug.cgi?id=20470
  73963. Reviewed by Kevin McCullough.
  73964. * page/inspector/ElementsPanel.js:
  73965. (WebInspector.ElementsPanel): Add event listeners for
  73966. the "style edited" and "style property toggled" events,
  73967. so the Metrics pane is updated.
  73968. (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
  73969. Update the Metrics pane.
  73970. * page/inspector/StylesSidebarPane.js:
  73971. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
  73972. Dispatch the "style property toggled" event.
  73973. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
  73974. Dispatch the "style edited" event when the CSS text is restored.
  73975. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
  73976. Dispatch the "style edited" event.
  73977. 2008-08-21 Timothy Hatcher <timothy@apple.com>
  73978. Make the Inspector's Metrics sidebar pane editable.
  73979. https://bugs.webkit.org/show_bug.cgi?id=17218
  73980. rdar://problem/5732818
  73981. Reviewed by Kevin McCullough.
  73982. * page/inspector/ElementsPanel.js:
  73983. (WebInspector.ElementsPanel): Add an event listener for
  73984. the "metrics edited" event, so the Styles pane is updated.
  73985. * page/inspector/MetricsSidebarPane.js:
  73986. (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
  73987. so future updates work. Add a double click event listener for the
  73988. metric values to start editing.
  73989. (WebInspector.MetricsSidebarPane.prototype.startEditing):
  73990. Call WebInspector.startEditing with some context.
  73991. (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
  73992. (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  73993. Set the user input on the elements inline style. Fire the
  73994. "metrics edited" event.
  73995. 2008-08-21 Steve Falkenburg <sfalken@apple.com>
  73996. Fix a race condition in Windows timer code.
  73997. Timer function could end up being called with a 0 timer, leading to a Windows exception.
  73998. Don't post a timer message if one is already pending.
  73999. Reviewed by Ada Chan.
  74000. * platform/win/SharedTimerWin.cpp:
  74001. (WebCore::TimerWindowWndProc):
  74002. (WebCore::clearTimer):
  74003. (WebCore::queueTimerProc):
  74004. (WebCore::setSharedTimerFireTime):
  74005. 2008-08-21 Anthony Ricaud <rik24d@gmail.com>
  74006. After trying to add the expression, try again with quotes for
  74007. easier edition.
  74008. https://bugs.webkit.org/show_bug.cgi?id=20466
  74009. Reviewed by Tim Hatcher.
  74010. * page/inspector/ObjectPropertiesSection.js: Added an
  74011. evaluateExpression function.
  74012. 2008-08-21 Anthony Ricaud <rik24d@gmail.com>
  74013. Perform Inspector searches on search event to clear results when
  74014. clicking the cross to empty it. Delete the lastQuery when the field
  74015. is emptied in order to perform the search if exactly the same query
  74016. is entered next.
  74017. https://bugs.webkit.org/show_bug.cgi?id=20462
  74018. Reviewed by Tim Hatcher.
  74019. * page/inspector/inspector.js:
  74020. 2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
  74021. Reviewed by Mark Rowe.
  74022. http://bugs.webkit.org/show_bug.cgi?id=19656
  74023. [SOUP] The gio code should call didFail() instead of
  74024. didFinishLoading() in case of error
  74025. In case of error call didFail() instead of didReceiveResponse() and
  74026. didFinishLoading().
  74027. * platform/network/soup/ResourceHandleSoup.cpp:
  74028. (WebCore::networkErrorForFile):
  74029. (WebCore::readCallback):
  74030. (WebCore::openCallback):
  74031. (WebCore::queryInfoCallback):
  74032. 2008-08-20 Mark Rowe <mrowe@apple.com>
  74033. Reviewed by Jon Honeycutt.
  74034. Fix build failure.
  74035. * bridge/c/c_instance.cpp:
  74036. (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
  74037. as that is what NPEnumerationFunctionPtr is declared as accepting.
  74038. 2008-08-20 Mark Rowe <mrowe@apple.com>
  74039. Reviewed by Dan Bernstein.
  74040. Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
  74041. * platform/graphics/GraphicsContext.h:
  74042. (WebCore::):
  74043. * platform/graphics/cg/GraphicsContextCG.cpp:
  74044. (WebCore::GraphicsContext::setImageInterpolationQuality):
  74045. (WebCore::GraphicsContext::imageInterpolationQuality):
  74046. 2008-08-20 Dan Bernstein <mitz@apple.com>
  74047. Rubber-stamped by John Sullivan.
  74048. - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
  74049. rename related methods and variables accordingly.
  74050. * WebCore.base.exp:
  74051. * page/FrameView.cpp:
  74052. (WebCore::FrameViewPrivate::FrameViewPrivate):
  74053. (WebCore::FrameView::shouldUpdateWhileOffscreen):
  74054. (WebCore::FrameView::setShouldUpdateWhileOffscreen):
  74055. * page/FrameView.h:
  74056. * platform/ScrollView.h:
  74057. * platform/mac/ScrollViewMac.mm:
  74058. (WebCore::ScrollView::updateContents):
  74059. 2008-08-20 Brady Eidson <beidson@apple.com>
  74060. Reviewed by Mitzpettel
  74061. <rdar://problem/6153432> - Many images broken in Mail
  74062. This can be traced back to the preload scanner. With that change, CachedResources are created a lot
  74063. sooner than before and confuse the WebArchive machinery.
  74064. When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
  74065. such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
  74066. machinery and nothing is known about where the data will eventually come from.
  74067. * loader/DocumentLoader.cpp:
  74068. (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
  74069. CachedResource::PreloadReferenced.
  74070. 2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
  74071. Unreviewed compile fix
  74072. Catch up with the JSValue::type elimination.
  74073. * bridge/qt/qt_instance.cpp:
  74074. (KJS::Bindings::QtRuntimeObjectImp::construct):
  74075. (KJS::Bindings::QtInstance::defaultValue):
  74076. * bridge/qt/qt_runtime.cpp:
  74077. (KJS::Bindings::QtRuntimeConnectionMethod::call):
  74078. 2008-08-20 Chris Teague <chris.teague@gmail.com>
  74079. Reviewed by Mark Rowe.
  74080. Fix https://bugs.webkit.org/show_bug.cgi?id=20449
  74081. Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
  74082. * ChangeLog:
  74083. * loader/FrameLoader.cpp:
  74084. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
  74085. 2008-08-20 Simon Fraser <simon.fraser@apple.com>
  74086. Reviewed by Dave Hyatt
  74087. getComputedStyle() for webkitTransform should return a transform
  74088. that does not have the transform origin baked into it.
  74089. https://bugs.webkit.org/show_bug.cgi?id=20464
  74090. Test: fast/css/getComputedStyle-transform.html
  74091. * css/CSSComputedStyleDeclaration.cpp:
  74092. (WebCore::computedTransform):
  74093. * rendering/style/RenderStyle.cpp:
  74094. (WebCore::RenderStyle::applyTransform):
  74095. * rendering/style/RenderStyle.h:
  74096. 2008-08-20 Josh Aas <joshmoz@gmail.com>
  74097. Reviewed and landed by Anders.
  74098. <rdar://problem/6163636>
  74099. rename NPCocoaEvent's "event" struct to "data" (20446)
  74100. * bridge/npapi.h:
  74101. (_NPCocoaEvent::):
  74102. 2008-08-20 Beth Dakin <bdakin@apple.com>
  74103. Reviewed by Darin Adler.
  74104. Fix for <rdar://problem/6145626>
  74105. This patch fixes a number of remaining problems getting
  74106. disconnected frames to work correctly with markAllMatchesForText()
  74107. and findString(). Details inline.
  74108. This was a static helper function in Frame, but this patch requires
  74109. the same functionality in Editor, so I just added it as a function
  74110. on Node.
  74111. * dom/Node.cpp:
  74112. (WebCore::Node::isInShadowTree):
  74113. * dom/Node.h:
  74114. * editing/Editor.cpp:
  74115. (WebCore::Editor::insideVisibleArea): Returns false if
  74116. excludeFromTextSearch() is true.
  74117. In a normal (non-disconnected) frame, findString returns a range of
  74118. the document node if the text is not found in the frame. I changed
  74119. firstVisibleRange and lastVisibleRange to match that behavior when
  74120. the text is not found
  74121. (WebCore::Editor::firstVisibleRange):
  74122. (WebCore::Editor::lastVisibleRange):
  74123. Here are the bulk of the changes in the patch. A lot of text was
  74124. not being found in disconnected frames because I failed to account
  74125. for all of the possible problems associated with shadow trees. That
  74126. is fixed here.
  74127. (WebCore::Editor::nextVisibleRange):
  74128. * editing/Editor.h:
  74129. excludeFromTextSearch() is new. It allows a WebKit client to mark a
  74130. frame as not-text-searchable through SPI.
  74131. * WebCore.base.exp:
  74132. * page/Frame.cpp:
  74133. (WebCore::Frame::excludeFromTextSearch):
  74134. (WebCore::Frame::setExcludeFromTextSearch):
  74135. (WebCore::FramePrivate::FramePrivate):
  74136. * page/Frame.h:
  74137. * page/FramePrivate.h:
  74138. (WebCore::Frame::findString):
  74139. (WebCore::Frame::markAllMatchesForText): I kept running into an
  74140. assertion failure in paining code because of the forced paint on
  74141. empty visible rects.
  74142. 2008-08-20 Timothy Hatcher <timothy@apple.com>
  74143. Adds a positon box to the Inspector's Metrics sidebar
  74144. pane. When an element is not statically positioned, there
  74145. is now a position box that show top, right, bottom and
  74146. left computed values.
  74147. Reviewed by Kevin McCullough.
  74148. * English.lproj/localizedStrings.js: Updated the strings.
  74149. * page/inspector/MetricsSidebarPane.js:
  74150. (WebInspector.MetricsSidebarPane.prototype.update):
  74151. Renamed the boxPartValue function to createBoxPartElement
  74152. and made it create the entire element. Made it understand
  74153. how to get position style properties. Don't use the figure dash
  74154. when 0px is used for positions, since the 0 is meaningful there.
  74155. Instead use the figure dash when a position is auto.
  74156. * page/inspector/inspector.css: Added a new rule for position.
  74157. 2008-08-20 Chris Fleizach <cfleizach@apple.com>
  74158. Reviewed by Beth Dakin
  74159. Qt build fix
  74160. * WebCore.pro:
  74161. 2008-08-20 Dan Bernstein <mitz@apple.com>
  74162. Reviewed by Anders Carlsson.
  74163. - avoid using a deprecated NSScroller method on Leopard
  74164. * platform/mac/PlatformScrollBarMac.mm:
  74165. (WebCore::PlatformScrollbar::updateThumbPosition):
  74166. (WebCore::PlatformScrollbar::updateThumbProportion):
  74167. 2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
  74168. Reviewed by Oliver Hunt.
  74169. Gtk build fix
  74170. * GNUmakefile.am:
  74171. * page/AccessibilityTable.cpp: Change nil to 0
  74172. (WebCore::AccessibilityTable::cellForColumnAndRow):
  74173. 2008-08-19 Alexey Proskuryakov <ap@webkit.org>
  74174. Reviewed by Geoff Garen.
  74175. Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
  74176. * ForwardingHeaders/kjs/JSLock.h: Added.
  74177. * WebCore.vcproj/WebCore.vcproj:
  74178. * bindings/js/GCController.cpp:
  74179. (WebCore::collect):
  74180. (WebCore::GCController::gcTimerFired):
  74181. (WebCore::GCController::garbageCollectNow):
  74182. * bindings/js/JSCustomSQLStatementCallback.cpp:
  74183. (WebCore::JSCustomSQLStatementCallback::handleEvent):
  74184. * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  74185. (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  74186. * bindings/js/JSCustomSQLTransactionCallback.cpp:
  74187. (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  74188. * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  74189. (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  74190. * bindings/js/JSCustomVoidCallback.cpp:
  74191. (WebCore::JSCustomVoidCallback::handleEvent):
  74192. * bindings/js/JSCustomXPathNSResolver.cpp:
  74193. (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  74194. * bindings/js/JSDOMWindowBase.cpp:
  74195. (WebCore::DOMWindowTimer::~DOMWindowTimer):
  74196. (WebCore::JSDOMWindowBase::clear):
  74197. (WebCore::JSDOMWindowBase::timerFired):
  74198. * bindings/js/JSEventCustom.cpp:
  74199. (WebCore::toJS):
  74200. * bindings/js/JSEventListener.cpp:
  74201. (WebCore::JSAbstractEventListener::handleEvent):
  74202. * bindings/js/JSNSResolver.cpp:
  74203. (WebCore::JSNSResolver::lookupNamespaceURI):
  74204. * bindings/js/JSNodeFilterCondition.cpp:
  74205. (WebCore::JSNodeFilterCondition::acceptNode):
  74206. * bindings/js/ScheduledAction.cpp:
  74207. (WebCore::ScheduledAction::execute):
  74208. * bindings/js/ScriptController.cpp:
  74209. (WebCore::ScriptController::evaluate):
  74210. (WebCore::ScriptController::clearWindowShell):
  74211. (WebCore::ScriptController::createHTMLEventHandler):
  74212. (WebCore::ScriptController::createSVGEventHandler):
  74213. (WebCore::ScriptController::initScript):
  74214. (WebCore::ScriptController::updateDocument):
  74215. (WebCore::ScriptController::bindingRootObject):
  74216. (WebCore::ScriptController::windowScriptNPObject):
  74217. (WebCore::ScriptController::createScriptObjectForPluginElement):
  74218. (WebCore::ScriptController::clearScriptObjects):
  74219. * bindings/js/ScriptControllerMac.mm:
  74220. (WebCore::ScriptController::windowScriptObject):
  74221. * bindings/objc/WebScriptObject.mm:
  74222. (_didExecute):
  74223. (-[WebScriptObject callWebScriptMethod:withArguments:]):
  74224. (-[WebScriptObject evaluateWebScript:]):
  74225. (-[WebScriptObject setValue:forKey:]):
  74226. (-[WebScriptObject valueForKey:]):
  74227. (-[WebScriptObject removeWebScriptKey:]):
  74228. (-[WebScriptObject stringRepresentation]):
  74229. (-[WebScriptObject webScriptValueAtIndex:]):
  74230. (-[WebScriptObject setWebScriptValueAtIndex:value:]):
  74231. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  74232. * bridge/NP_jsobject.cpp:
  74233. (_NPN_InvokeDefault):
  74234. (_NPN_Invoke):
  74235. (_NPN_Evaluate):
  74236. (_NPN_GetProperty):
  74237. (_NPN_SetProperty):
  74238. (_NPN_RemoveProperty):
  74239. (_NPN_HasProperty):
  74240. (_NPN_HasMethod):
  74241. (_NPN_Enumerate):
  74242. * bridge/c/c_class.cpp:
  74243. (KJS::Bindings::CClass::~CClass):
  74244. (KJS::Bindings::CClass::methodsNamed):
  74245. (KJS::Bindings::CClass::fieldNamed):
  74246. * bridge/c/c_instance.cpp:
  74247. (KJS::Bindings::CInstance::invokeMethod):
  74248. (KJS::Bindings::CInstance::invokeDefaultMethod):
  74249. (KJS::Bindings::CInstance::getPropertyNames):
  74250. * bridge/c/c_runtime.cpp:
  74251. (KJS::Bindings::CField::valueFromInstance):
  74252. (KJS::Bindings::CField::setValueToInstance):
  74253. * bridge/c/c_utility.cpp:
  74254. (KJS::Bindings::convertValueToNPVariant):
  74255. (KJS::Bindings::convertNPVariantToValue):
  74256. * bridge/jni/jni_class.cpp:
  74257. (JavaClass::JavaClass):
  74258. (JavaClass::~JavaClass):
  74259. * bridge/jni/jni_instance.cpp:
  74260. (JavaInstance::stringValue):
  74261. * bridge/jni/jni_jsobject.mm:
  74262. (JavaJSObject::call):
  74263. (JavaJSObject::eval):
  74264. (JavaJSObject::getMember):
  74265. (JavaJSObject::setMember):
  74266. (JavaJSObject::removeMember):
  74267. (JavaJSObject::getSlot):
  74268. (JavaJSObject::setSlot):
  74269. (JavaJSObject::toString):
  74270. (JavaJSObject::convertValueToJObject):
  74271. (JavaJSObject::convertJObjectToValue):
  74272. * bridge/jni/jni_objc.mm:
  74273. (KJS::Bindings::dispatchJNICall):
  74274. * bridge/jni/jni_runtime.cpp:
  74275. (appendClassName):
  74276. (JavaMethod::signature):
  74277. * bridge/jni/jni_runtime.h:
  74278. (KJS::Bindings::JavaString::JavaString):
  74279. (KJS::Bindings::JavaString::_commonInit):
  74280. (KJS::Bindings::JavaString::~JavaString):
  74281. (KJS::Bindings::JavaString::UTF8String):
  74282. * bridge/jni/jni_utility.cpp:
  74283. (KJS::Bindings::convertValueToJValue):
  74284. * bridge/npruntime.cpp:
  74285. (_NPN_GetStringIdentifier):
  74286. * bridge/objc/objc_instance.mm:
  74287. (ObjcInstance::moveGlobalExceptionToExecState):
  74288. (ObjcInstance::invokeMethod):
  74289. (ObjcInstance::invokeDefaultMethod):
  74290. (ObjcInstance::setValueOfUndefinedField):
  74291. (ObjcInstance::getValueOfUndefinedField):
  74292. * bridge/objc/objc_runtime.mm:
  74293. (ObjcField::valueFromInstance):
  74294. (ObjcField::setValueToInstance):
  74295. * bridge/objc/objc_utility.mm:
  74296. (KJS::Bindings::convertValueToObjcValue):
  74297. (KJS::Bindings::convertNSStringToString):
  74298. (KJS::Bindings::convertObjcValueToValue):
  74299. * bridge/qt/qt_instance.cpp:
  74300. (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
  74301. (KJS::Bindings::QtInstance::~QtInstance):
  74302. (KJS::Bindings::QtInstance::getQtInstance):
  74303. (KJS::Bindings::QtInstance::getRuntimeObject):
  74304. * bridge/qt/qt_runtime.cpp:
  74305. (KJS::Bindings::convertValueToQVariant):
  74306. (KJS::Bindings::convertQVariantToValue):
  74307. (KJS::Bindings::QtRuntimeMetaMethod::call):
  74308. (KJS::Bindings::QtRuntimeConnectionMethod::call):
  74309. (KJS::Bindings::QtConnectionObject::QtConnectionObject):
  74310. (KJS::Bindings::QtConnectionObject::execute):
  74311. * bridge/runtime.cpp:
  74312. (KJS::Bindings::Instance::createRuntimeObject):
  74313. * bridge/testbindings.cpp:
  74314. (main):
  74315. * bridge/testbindings.mm:
  74316. (main):
  74317. * bridge/testqtbindings.cpp:
  74318. (main):
  74319. * dom/Document.cpp:
  74320. (WebCore::Document::~Document):
  74321. * dom/Node.cpp:
  74322. (WebCore::Node::setDocument):
  74323. * history/CachedPage.cpp:
  74324. (WebCore::CachedPage::CachedPage):
  74325. (WebCore::CachedPage::restore):
  74326. (WebCore::CachedPage::clear):
  74327. * loader/FrameLoader.cpp:
  74328. (WebCore::getString):
  74329. * page/InspectorController.cpp:
  74330. (WebCore::ConsoleMessage::ConsoleMessage):
  74331. (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
  74332. (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
  74333. (WebCore::getResourceDocumentNode):
  74334. (WebCore::search):
  74335. (WebCore::inspectedWindow):
  74336. (WebCore::wrapCallback):
  74337. (WebCore::currentCallFrame):
  74338. (WebCore::profiles):
  74339. (WebCore::InspectorController::focusNode):
  74340. (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
  74341. (WebCore::InspectorController::addDatabaseScriptResource):
  74342. (WebCore::InspectorController::addScriptProfile):
  74343. * page/JavaScriptCallFrame.cpp:
  74344. (WebCore::JavaScriptCallFrame::evaluate):
  74345. * page/JavaScriptProfileNode.cpp:
  74346. (WebCore::getTotalTime):
  74347. (WebCore::getSelfTime):
  74348. (WebCore::getTotalPercent):
  74349. (WebCore::getSelfPercent):
  74350. (WebCore::getNumberOfCalls):
  74351. (WebCore::getChildren):
  74352. (WebCore::getVisible):
  74353. * page/Page.cpp:
  74354. * page/mac/FrameMac.mm:
  74355. * plugins/PluginView.cpp:
  74356. (WebCore::PluginView::start):
  74357. (WebCore::getString):
  74358. (WebCore::PluginView::performRequest):
  74359. (WebCore::PluginView::bindingInstance):
  74360. * plugins/gtk/PluginViewGtk.cpp:
  74361. (WebCore::PluginView::paint):
  74362. (WebCore::PluginView::handleKeyboardEvent):
  74363. (WebCore::PluginView::handleMouseEvent):
  74364. (WebCore::PluginView::setNPWindowRect):
  74365. (WebCore::PluginView::stop):
  74366. (WebCore::PluginView::init):
  74367. * plugins/qt/PluginViewQt.cpp:
  74368. (WebCore::PluginView::setNPWindowRect):
  74369. (WebCore::PluginView::stop):
  74370. (WebCore::PluginView::init):
  74371. * plugins/win/PluginViewWin.cpp:
  74372. (WebCore::PluginView::dispatchNPEvent):
  74373. (WebCore::PluginView::handleKeyboardEvent):
  74374. (WebCore::PluginView::handleMouseEvent):
  74375. (WebCore::PluginView::setNPWindowRect):
  74376. (WebCore::PluginView::stop):
  74377. * xml/XMLHttpRequest.cpp:
  74378. (WebCore::XMLHttpRequest::clearResponse):
  74379. (WebCore::XMLHttpRequest::didFinishLoading):
  74380. (WebCore::XMLHttpRequest::didReceiveData):
  74381. 2008-08-19 Eric Seidel <eric@webkit.org>
  74382. Reviewed by Geoff Garen.
  74383. Add the beginnings of Skia graphics support to WebCore
  74384. as I try to begin the long process of un-forking the changes
  74385. needed to WebCore to make Andriod's WebCore build.
  74386. I'll follow this up with actual *Skia.cpp files in a separate patch.
  74387. * platform/graphics/AffineTransform.h:
  74388. * platform/graphics/FloatPoint.h:
  74389. * platform/graphics/FloatRect.h:
  74390. * platform/graphics/Gradient.h:
  74391. * platform/graphics/GraphicsContext.h:
  74392. * platform/graphics/Image.h:
  74393. * platform/graphics/ImageBuffer.h:
  74394. * platform/graphics/ImageSource.h:
  74395. * platform/graphics/IntPoint.h:
  74396. * platform/graphics/IntRect.h:
  74397. * platform/graphics/Path.h:
  74398. * platform/graphics/Pattern.h:
  74399. * svg/graphics/SVGPaintServerPattern.h:
  74400. * svg/graphics/SVGPaintServerSolid.h:
  74401. 2008-08-19 Steve Falkenburg <sfalken@apple.com>
  74402. Fix Windows build more.
  74403. * WebCore.vcproj/WebCore.vcproj:
  74404. 2008-08-19 Steve Falkenburg <sfalken@apple.com>
  74405. Fix Windows build.
  74406. * page/AccessibilityRenderObject.cpp:
  74407. (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  74408. 2008-08-19 Chris Fleizach <cfleizach@apple.com>
  74409. Reviewed by Beth Dakin.
  74410. <rdar://problem/4003764> Expose tables as AXTables
  74411. Tests: accessibility/table-attributes.html
  74412. accessibility/table-cell-spans.html
  74413. accessibility/table-cells.html
  74414. accessibility/table-detection.html
  74415. accessibility/table-sections.html
  74416. accessibility/table-with-rules.html
  74417. * WebCore.xcodeproj/project.pbxproj:
  74418. * page/AXObjectCache.cpp:
  74419. (WebCore::AXObjectCache::get):
  74420. * page/AccessibilityObject.h:
  74421. (WebCore::):
  74422. (WebCore::AccessibilityObject::isDataTable):
  74423. (WebCore::AccessibilityObject::isTableRow):
  74424. (WebCore::AccessibilityObject::isTableColumn):
  74425. (WebCore::AccessibilityObject::isTableCell):
  74426. * page/AccessibilityRenderObject.cpp:
  74427. (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  74428. * page/AccessibilityTable.cpp: Added.
  74429. (WebCore::AccessibilityTable::AccessibilityTable):
  74430. (WebCore::AccessibilityTable::~AccessibilityTable):
  74431. (WebCore::AccessibilityTable::create):
  74432. (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  74433. (WebCore::AccessibilityTable::clearChildren):
  74434. (WebCore::AccessibilityTable::addChildren):
  74435. (WebCore::AccessibilityTable::headerContainer):
  74436. (WebCore::AccessibilityTable::columns):
  74437. (WebCore::AccessibilityTable::rows):
  74438. (WebCore::AccessibilityTable::rowHeaders):
  74439. (WebCore::AccessibilityTable::columnHeaders):
  74440. (WebCore::AccessibilityTable::cells):
  74441. (WebCore::AccessibilityTable::columnCount):
  74442. (WebCore::AccessibilityTable::rowCount):
  74443. (WebCore::AccessibilityTable::cellForColumnAndRow):
  74444. (WebCore::AccessibilityTable::roleValue):
  74445. (WebCore::AccessibilityTable::accessibilityIsIgnored):
  74446. (WebCore::AccessibilityTable::title):
  74447. (WebCore::AccessibilityTable::isDataTable):
  74448. * page/AccessibilityTable.h: Added.
  74449. * page/AccessibilityTableCell.cpp: Added.
  74450. (WebCore::AccessibilityTableCell::AccessibilityTableCell):
  74451. (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
  74452. (WebCore::AccessibilityTableCell::create):
  74453. (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
  74454. (WebCore::AccessibilityTableCell::rowIndexRange):
  74455. (WebCore::AccessibilityTableCell::columnIndexRange):
  74456. * page/AccessibilityTableCell.h: Added.
  74457. (WebCore::AccessibilityTableCell::isTableCell):
  74458. (WebCore::AccessibilityTableCell::roleValue):
  74459. * page/AccessibilityTableColumn.cpp: Added.
  74460. (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
  74461. (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
  74462. (WebCore::AccessibilityTableColumn::create):
  74463. (WebCore::AccessibilityTableColumn::setParentTable):
  74464. (WebCore::AccessibilityTableColumn::elementRect):
  74465. (WebCore::AccessibilityTableColumn::size):
  74466. (WebCore::AccessibilityTableColumn::children):
  74467. (WebCore::AccessibilityTableColumn::headerObject):
  74468. (WebCore::AccessibilityTableColumn::headerObjectForSection):
  74469. (WebCore::AccessibilityTableColumn::addChildren):
  74470. * page/AccessibilityTableColumn.h: Added.
  74471. (WebCore::AccessibilityTableColumn::parentObject):
  74472. (WebCore::AccessibilityTableColumn::roleValue):
  74473. (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
  74474. (WebCore::AccessibilityTableColumn::isTableColumn):
  74475. (WebCore::AccessibilityTableColumn::setColumnIndex):
  74476. (WebCore::AccessibilityTableColumn::columnIndex):
  74477. * page/AccessibilityTableHeaderContainer.cpp: Added.
  74478. (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
  74479. (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
  74480. (WebCore::AccessibilityTableHeaderContainer::create):
  74481. (WebCore::AccessibilityTableHeaderContainer::children):
  74482. (WebCore::AccessibilityTableHeaderContainer::elementRect):
  74483. (WebCore::AccessibilityTableHeaderContainer::size):
  74484. (WebCore::AccessibilityTableHeaderContainer::addChildren):
  74485. * page/AccessibilityTableHeaderContainer.h: Added.
  74486. (WebCore::AccessibilityTableHeaderContainer::roleValue):
  74487. (WebCore::AccessibilityTableHeaderContainer::setParentTable):
  74488. (WebCore::AccessibilityTableHeaderContainer::parentObject):
  74489. (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
  74490. * page/AccessibilityTableRow.cpp: Added.
  74491. (WebCore::AccessibilityTableRow::AccessibilityTableRow):
  74492. (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
  74493. (WebCore::AccessibilityTableRow::create):
  74494. (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
  74495. (WebCore::AccessibilityTableRow::headerObject):
  74496. * page/AccessibilityTableRow.h: Added.
  74497. (WebCore::AccessibilityTableRow::isTableRow):
  74498. (WebCore::AccessibilityTableRow::roleValue):
  74499. (WebCore::AccessibilityTableRow::setRowIndex):
  74500. (WebCore::AccessibilityTableRow::rowIndex):
  74501. * page/mac/AccessibilityObjectWrapper.mm:
  74502. (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
  74503. (RoleEntry::):
  74504. (-[AccessibilityObjectWrapper roleDescription]):
  74505. (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  74506. (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
  74507. (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
  74508. 2008-08-19 Steve Falkenburg <sfalken@apple.com>
  74509. Build fix.
  74510. Add buildfailed support to stop builds early (preventing inaccurate error messages).
  74511. Add missing post-build rule to Release.
  74512. * WebCore.vcproj/QTMovieWin.vcproj:
  74513. 2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
  74514. Added support for console.count in the inspector.
  74515. Reviewed by Geoff Garen.
  74516. * page/Console.cpp:
  74517. (WebCore::Console::count):
  74518. * page/Console.h:
  74519. * page/Console.idl: Added console.count.
  74520. * page/InspectorController.cpp:
  74521. (WebCore::InspectorController::didCommitLoad): Clears m_counts.
  74522. (WebCore::InspectorController::count): Updates the count number
  74523. sing "title@source:line" as the identifier, and adds a
  74524. message to the console.
  74525. * page/InspectorController.h: Added m_counts.
  74526. 2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
  74527. Clear console.time timers when changing page.
  74528. Reviewed by Geoff Garen.
  74529. * page/InspectorController.cpp:
  74530. (WebCore::InspectorController::didCommitLoad):
  74531. 2008-08-19 Eric Carlson <eric.carlson@apple.com>
  74532. Reviewed by Adele.
  74533. Fix for <rdar://problem/6154695> Full-page movies flicker while playing
  74534. https://bugs.webkit.org/show_bug.cgi?id=20404
  74535. Ignore setVisible() when visibility doesn't change.
  74536. * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  74537. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  74538. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
  74539. (WebCore::MediaPlayerPrivate::setVisible):
  74540. 2008-08-19 Timothy Hatcher <timothy@apple.com>
  74541. Fixes a bug in the Profile view where switching sort order, then
  74542. switching from heavy to tree mode would show the tree in the
  74543. previous sort order.
  74544. https://bugs.webkit.org/show_bug.cgi?id=20441
  74545. Reviewed by Kevin McCullough.
  74546. * page/inspector/ProfileView.js:
  74547. (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
  74548. on the next profile before assigning it to this.profile.
  74549. (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
  74550. (WebInspector.ProfileView.prototype._sortProfile): Moves from
  74551. _sortData and takes a profile argument. If the profile passed in
  74552. matches the this.profile, then call refresh.
  74553. 2008-08-18 Timothy Hatcher <timothy@apple.com>
  74554. Changed the default sort order now that heavy view is the default.
  74555. Also fixes a bug where the heavy profile was not sorted at first.
  74556. https://bugs.webkit.org/show_bug.cgi?id=20440
  74557. Reviewed by Kevin McCullough.
  74558. * page/inspector/ProfileView.js:
  74559. (WebInspector.ProfileView): Changed the default sort column. Also assign
  74560. heavyProfile to profile, so the sortSelfTimeDescending call happens
  74561. on the heavy profile before assigning to this.profile.
  74562. 2008-08-18 Timothy Hatcher <timothy@apple.com>
  74563. Add support for editing DOM properties and scope variables by double
  74564. clicking a property to enter edit mode.
  74565. https://bugs.webkit.org/show_bug.cgi?id=20415
  74566. Reviewed by Kevin McCullough.
  74567. * page/inspector/ObjectPropertiesSection.js:
  74568. (WebInspector.ObjectPropertiesSection): Set editable to true by default.
  74569. (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
  74570. Factored out code into update, and calls update.
  74571. (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
  74572. Call removeChildren since this method can be called multiple times now.
  74573. (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
  74574. gets made later in onattach.
  74575. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
  74576. if shouldRefreshChildren is true. Call removeChildren since this method can be
  74577. called multiple times now.
  74578. (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
  74579. (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
  74580. (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
  74581. this element (code moved from the constructor.)
  74582. (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
  74583. sibling property elements.
  74584. (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
  74585. WebInspector.startEditing after rememebring some context.
  74586. (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
  74587. for the list element, since it might have scrolled during editing.
  74588. (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
  74589. then restore the state from the context. Then call update to restore the title.
  74590. (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
  74591. if the user input and the previous input are the same. Call editingEnded, then call applyExpression
  74592. to commit the user input.
  74593. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
  74594. and stores the result on the object for the property name of this element. If the expression is
  74595. empty, delete the property and remove the tree element.
  74596. * page/inspector/ScopeChainSidebarPane.js:
  74597. (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
  74598. property on each ObjectPropertiesSection.
  74599. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
  74600. since it is now implemented.
  74601. * page/inspector/ScriptsPanel.js:
  74602. (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
  74603. that defaults to true if omitted. It specifies whether to call update on the scope chain.
  74604. * page/inspector/inspector.css: New styles.
  74605. * page/inspector/treeoutline.js:
  74606. (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
  74607. change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
  74608. 2008-08-18 Timothy Hatcher <timothy@apple.com>
  74609. Surround the expression to be evaluated in parenthesis so the
  74610. result of the eval is the result of the whole expression not
  74611. the last potential sub-expression. So evaluating {x: 123}
  74612. will show the Object not 123.
  74613. https://bugs.webkit.org/show_bug.cgi?id=20428
  74614. Reviewed by Kevin McCullough.
  74615. * page/inspector/Console.js:
  74616. (Console.prototype._evalInInspectedWindow): Add parenthesis
  74617. around the expression. And add couple comments.
  74618. 2008-08-19 Kevin McCullough <kmccullough@apple.com>
  74619. Reviewed by Geoff.
  74620. -Implement a page() function to extract a common code pattern.
  74621. * WebCore.xcodeproj/project.pbxproj:
  74622. * page/Console.cpp:
  74623. (WebCore::Console::addMessage):
  74624. (WebCore::Console::error):
  74625. (WebCore::Console::info):
  74626. (WebCore::Console::log):
  74627. (WebCore::Console::dir):
  74628. (WebCore::Console::assertCondition):
  74629. (WebCore::Console::time):
  74630. (WebCore::Console::timeEnd):
  74631. (WebCore::Console::group):
  74632. (WebCore::Console::groupEnd):
  74633. (WebCore::Console::finishedProfiling):
  74634. (WebCore::Console::warn):
  74635. (WebCore::Console::framePage):
  74636. * page/Console.h:
  74637. 2008-08-12 Darin Adler <darin@apple.com>
  74638. Reviewed by Geoff.
  74639. - eliminate JSValue::type()
  74640. * bridge/c/c_instance.cpp:
  74641. (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
  74642. argument instead of JSType argument. Removed unneeded code to handle
  74643. boolean, since that's never passed.
  74644. * bridge/c/c_instance.h: Ditto.
  74645. * bridge/c/c_utility.cpp:
  74646. (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
  74647. instead of JSValue::type(). Removed unneeded code to handle
  74648. "unspecified".
  74649. * bridge/jni/jni_instance.cpp:
  74650. (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
  74651. instead of JSType argument. Removed unneeded code to handle boolean.
  74652. * bridge/jni/jni_instance.h: Ditto.
  74653. * bridge/jni/jni_jsobject.mm:
  74654. (JavaJSObject::convertValueToJObject): Use JSValue::is functions
  74655. instead of JSValue::type().
  74656. * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
  74657. instead of JSType argument. Removed unused argument.
  74658. * bridge/objc/objc_instance.mm:
  74659. (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
  74660. (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
  74661. instead of JSType argument. Removed unneeded code to handle boolean
  74662. and another dead code path for unknown types.
  74663. * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
  74664. instead of JSType argument. Removed override of type() that caused
  74665. the fallback object to return "UndefinedType" when there is no
  74666. invokeUndefinedMethodFromWebScript:withArguments: method defined.
  74667. That didn't accomplish much, since most checks for undefined don't
  74668. ever call type().
  74669. * bridge/objc/objc_runtime.mm:
  74670. (ObjcFallbackObjectImp::defaultValue): Ditto.
  74671. * bridge/qt/qt_instance.cpp:
  74672. (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
  74673. argument instead of JSType argument. Removed unneeded code to handle
  74674. boolean.
  74675. * bridge/qt/qt_instance.h: Ditto.
  74676. * bridge/runtime.h:
  74677. (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
  74678. unsed argument.
  74679. * bridge/runtime_object.cpp:
  74680. (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
  74681. argument instead of JSType argument.
  74682. * bridge/runtime_object.h: Ditto.
  74683. 2008-08-18 Maxime Britto <britto@apple.com>
  74684. Reviewed by Adele.
  74685. <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
  74686. Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
  74687. We shouldn't be able to create another window while we are in pan scrolling.
  74688. Other browsers behaviors :
  74689. FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
  74690. IE7 : Keys are not disabled but stops immediately the panning.
  74691. This patch matches FF3 behavior by disabling every key but the esc key.
  74692. * page/EventHandler.cpp:
  74693. (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
  74694. (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
  74695. 2008-08-18 Dan Bernstein <mitz@apple.com>
  74696. Reviewed by Dave Hyatt.
  74697. - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
  74698. Test: fast/replaced/max-width-percent.html
  74699. Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
  74700. When false, max-width is not factored into the
  74701. calculation.
  74702. Changed RenderReplaced and subclasses' calcPrefWidths() to call
  74703. calcReplacedWidth(false) and then apply max-width only if it has a
  74704. fixed, positive value.
  74705. * rendering/RenderBox.cpp:
  74706. (WebCore::RenderBox::calcReplacedWidth):
  74707. * rendering/RenderBox.h:
  74708. * rendering/RenderImage.cpp:
  74709. (WebCore::RenderImage::calcReplacedWidth):
  74710. (WebCore::RenderImage::calcPrefWidths):
  74711. * rendering/RenderImage.h:
  74712. * rendering/RenderReplaced.cpp:
  74713. (WebCore::RenderReplaced::calcPrefWidths):
  74714. * rendering/RenderSVGRoot.cpp:
  74715. (WebCore::RenderSVGRoot::calcPrefWidths):
  74716. * rendering/RenderVideo.cpp:
  74717. (WebCore::RenderVideo::calcReplacedWidth):
  74718. (WebCore::RenderVideo::calcPrefWidths):
  74719. * rendering/RenderVideo.h:
  74720. 2008-08-18 Daniel Macks <dmacks@netspace.org>
  74721. Reviewed by Mark Rowe.
  74722. https://bugs.webkit.org/show_bug.cgi?id=20410
  74723. More portable/self-documenting replacement for SIZE_MAX.
  74724. * platform/network/curl/FormDataStreamCurl.cpp:
  74725. (WebCore::FormDataStream::read):
  74726. 2008-08-18 Simon Fraser <simon.fraser@apple.com>
  74727. Reviewed by Dave Hyatt
  74728. Need to make sure we have an Animation in the AnimationList
  74729. before setting the initial value.
  74730. https://bugs.webkit.org/show_bug.cgi?id=20408
  74731. Test: fast/css/transition_shorthand_parsing.html
  74732. * css/CSSStyleSelector.cpp:
  74733. 2008-08-18 Kevin McCullough <kmccullough@apple.com>
  74734. Reviewed by Tim.
  74735. <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
  74736. is another profile.
  74737. * page/inspector/ProfilesPanel.js:
  74738. 2008-08-18 Kevin McCullough <kmccullough@apple.com>
  74739. Reviewed by Geoff.
  74740. <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
  74741. all console messages
  74742. * page/inspector/Console.js:
  74743. 2008-08-18 Dirk Schulze <vbs85@gmx.de>
  74744. Reviewed by Eric Seidel.
  74745. Fixed Canvas for Cairo. Stroke and fill colors didn't work after
  74746. the canvas clean up.
  74747. https://bugs.webkit.org/show_bug.cgi?id=20405
  74748. * html/CanvasRenderingContext2D.cpp:
  74749. (WebCore::CanvasRenderingContext2D::fill):
  74750. (WebCore::CanvasRenderingContext2D::stroke):
  74751. (WebCore::CanvasRenderingContext2D::fillRect):
  74752. 2008-08-17 Timothy Hatcher <timothy@apple.com>
  74753. Complete in scope variables in the Console when paused.
  74754. https://bugs.webkit.org/show_bug.cgi?id=19115
  74755. Reviewed by Geoffrey Garen.
  74756. * page/inspector/Console.js:
  74757. (WebInspector.Console.prototype.completions): If the expressionString
  74758. is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
  74759. to get an object that declares all the in scope variables. That way
  74760. "top level" expressions are completed.
  74761. * page/inspector/ScriptsPanel.js:
  74762. (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
  74763. Return an object that has all the variables that are in scope for the
  74764. selected call frame. The value of each property is just true.
  74765. The return object is useful for quick lookups or auto completion.
  74766. 2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  74767. Not reviewed.
  74768. Speculative Qt build fix.
  74769. * bridge/qt/qt_runtime.cpp:
  74770. (KJS::Bindings::convertValueToQVariant):
  74771. (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
  74772. 2008-08-17 Geoffrey Garen <ggaren@apple.com>
  74773. Reviewed by Cameron Zwarich.
  74774. Updated project files to XCode 3.1.
  74775. * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
  74776. 2008-08-17 Geoffrey Garen <ggaren@apple.com>
  74777. Reviewed by Cameron Zwarich.
  74778. Made room for a free word in JSCell.
  74779. Changed JSDOMWindowBase to store its auxiliary data in a subclass of
  74780. JSGlobalData, so the two could share a pointer.
  74781. Added a bunch of ASSERTs, to help catch over-sized objects.
  74782. 2008-08-15 Mark Rowe <mrowe@apple.com>
  74783. Reviewed by Dan Bernstein.
  74784. Disable dead code stripping in debug builds.
  74785. * Configurations/Base.xcconfig:
  74786. * WebCore.xcodeproj/project.pbxproj:
  74787. 2008-08-15 Mark Rowe <mrowe@apple.com>
  74788. Rubber-stamped by Geoff Garen.
  74789. <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
  74790. * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
  74791. between the Debug configuration and debug Production variant.
  74792. * WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
  74793. 2008-08-15 Antti Koivisto <antti@apple.com>
  74794. Reviewed by Anders.
  74795. Don't start preloading body resources before the head is complete. This prevents
  74796. body preloads from slowing down initial display when there is limited amount
  74797. of bandwidth available.
  74798. Works by queuing up found body preloads to DocLoader and only issuing them
  74799. after document has rendering.
  74800. With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
  74801. without affecting complete load time.
  74802. * html/PreloadScanner.cpp:
  74803. (WebCore::PreloadScanner::PreloadScanner):
  74804. (WebCore::PreloadScanner::scanningBody):
  74805. (WebCore::PreloadScanner::emitTag):
  74806. (WebCore::PreloadScanner::emitCSSRule):
  74807. * html/PreloadScanner.h:
  74808. * loader/DocLoader.cpp:
  74809. (WebCore::DocLoader::preload):
  74810. (WebCore::DocLoader::checkForPendingPreloads):
  74811. (WebCore::DocLoader::requestPreload):
  74812. * loader/DocLoader.h:
  74813. * loader/loader.cpp:
  74814. (WebCore::Loader::Host::didFinishLoading):
  74815. (WebCore::Loader::Host::didFail):
  74816. 2008-08-15 Ada Chan <adachan@apple.com>
  74817. Use item's computed style if the render style is 0 before falling back to the <select>'s style.
  74818. This way style set on an <hr> within a <select> will be honored.
  74819. Reviewed by Dave Hyatt and Dan Bernstein.
  74820. * rendering/RenderMenuList.cpp:
  74821. (WebCore::RenderMenuList::itemStyle):
  74822. 2008-08-15 Antti Koivisto <antti@apple.com>
  74823. Reviewed by Oliver.
  74824. Some loader performance tweaks:
  74825. - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
  74826. Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
  74827. to not delay rendering.
  74828. - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
  74829. can take long time when latency is high so it is good to get started early.
  74830. - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
  74831. load queues. Issue remaining loads to the network layer.
  74832. * loader/loader.cpp:
  74833. (WebCore::Loader::determinePriority):
  74834. (WebCore::Loader::load):
  74835. (WebCore::Loader::Host::servePendingRequests):
  74836. * loader/loader.h:
  74837. 2008-08-15 Timothy Hatcher <timothy@apple.com>
  74838. Detach the script debugger when the Web Inspector's window closes.
  74839. This has always been the intended design, but never fully implemented.
  74840. https://bugs.webkit.org/show_bug.cgi?id=20402
  74841. Reviewed by Adam Roben.
  74842. * page/InspectorController.cpp:
  74843. (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
  74844. if the window is no longer visible.
  74845. 2008-08-15 Håvard Wall <hwall@trolltech.com>
  74846. Reviewed by Simon.
  74847. Fixes: compile with QT_NO_CONTEXTMENU
  74848. * platform/qt/PlatformMouseEventQt.cpp:
  74849. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  74850. * platform/qt/PlatformScrollBarQt.cpp:
  74851. (WebCore::PlatformScrollbar::handleMouseMoveEvent):
  74852. (WebCore::PlatformScrollbar::handleContextMenuEvent):
  74853. 2008-08-15 Håvard Wall <hwall@trolltech.com>
  74854. Reviewed by Simon.
  74855. Fixes: compile with QT_NO_WHEELEVENT
  74856. * platform/qt/WheelEventQt.cpp:
  74857. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  74858. 2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
  74859. Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
  74860. https://bugs.webkit.org/show_bug.cgi?id=20210
  74861. Reviewed by Tim Hatcher.
  74862. * page/Console.cpp:
  74863. (WebCore::Console::group):
  74864. (WebCore::Console::groupEnd):
  74865. * page/Console.h:
  74866. (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
  74867. * page/InspectorController.cpp:
  74868. (WebCore::InspectorController::startGroup): Increments group level by
  74869. one and adds console message with StartGroupMessaageLevel.
  74870. (WebCore::InspectorController::endGroup): Decrements group level by one
  74871. and adds console message with EndGroupMessaageLevel.
  74872. * page/InspectorController.h:
  74873. * page/inspector/Console.js:
  74874. (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
  74875. if the message is StartGroupMessaageLevel.
  74876. (WebInspector.ConsoleMessage.prototype.toMessageElement):
  74877. (WebInspector.ConsoleGroup.prototype.addMessage):
  74878. * page/inspector/inspector.js:
  74879. 2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
  74880. Adds support for console.dir to the Inspector
  74881. https://bugs.webkit.org/show_bug.cgi?id=19155
  74882. Reviewed by Tim Hatcher.
  74883. * bindings/js/JSConsoleCustom.cpp:
  74884. (WebCore::JSConsole::dir):
  74885. * page/Console.cpp:
  74886. (WebCore::Console::dir):
  74887. * page/Console.h: Added ObjectMessageLevel.
  74888. * page/Console.idl: Added console.dir.
  74889. * page/inspector/Console.js:
  74890. (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
  74891. ObjectPropertiesSection if the MessageLevel is Object.
  74892. * page/inspector/ObjectPropertiesSection.js: "in" operator can't be
  74893. used on primitive data types.
  74894. * page/inspector/inspector.css:
  74895. 2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
  74896. Adds support for clear() in the Inspector console.
  74897. https://bugs.webkit.org/show_bug.cgi?id=19873
  74898. Reviewed by Tim Hatcher.
  74899. * page/inspector/Console.js:
  74900. 2008-08-15 Anthony Ricaud <rik24d@gmail.com>
  74901. Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
  74902. Platform distinction and modifier key matching adjusted
  74903. by Daniel Jalkut <jalkut@red-sweater.com>
  74904. Bug 16313: text search (find) keybindings should work in the Web Inspector
  74905. https://bugs.webkit.org/show_bug.cgi?id=16313
  74906. Reviewed by Tim Hatcher.
  74907. * page/inspector/inspector.js: Added a case for the F key
  74908. 2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
  74909. Fix for error when the string doesn't contain a webkit-profile link.
  74910. https://bugs.webkit.org/show_bug.cgi?id=20399
  74911. Reviewed by Tim Hatcher.
  74912. * page/inspector/inspector.js:
  74913. 2008-08-15 Timothy Hatcher <timothy@apple.com>
  74914. Fixes two bugs where JavaScript could be executed from the page
  74915. while the debugger is paused.
  74916. The first issue was JSLazyEventListener not checking the paused
  74917. state before parsing the code.
  74918. The second issue was with the PageGroup version of
  74919. JavaScriptDebugServer::setJavaScriptPaused always passing false
  74920. to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
  74921. and not the paused argument.
  74922. https://bugs.webkit.org/show_bug.cgi?id=20284
  74923. Reviewed by Adam Roben.
  74924. * bindings/js/JSEventListener.cpp:
  74925. (WebCore::JSLazyEventListener::parseCode): Check the paused
  74926. state of the ScriptController. Return early if paused.
  74927. * manual-tests/inspector/debugger-execution-while-paused.html: Added.
  74928. * page/JavaScriptDebugServer.cpp:
  74929. (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  74930. Pass the paused argument to the Page version of setJavaScriptPaused.
  74931. 2008-08-15 Alexey Proskuryakov <ap@webkit.org>
  74932. Reviewed by Geoff Garen.
  74933. JSStringRef is created context-free, but can get linked to one via an identifier table,
  74934. breaking an implicit API contract.
  74935. * page/InspectorController.cpp:
  74936. (WebCore::jsStringRef):
  74937. (WebCore::InspectorController::didParseSource):
  74938. (WebCore::InspectorController::failedToParseSource):
  74939. * page/JavaScriptProfile.cpp:
  74940. (WebCore::getTitleCallback):
  74941. Updated for JavaScriptCore changes.
  74942. 2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
  74943. wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
  74944. an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
  74945. * platform/graphics/AffineTransform.h:
  74946. 2008-08-14 Eric Carlson <eric.carlson@apple.com>
  74947. Reviewed by Adele.
  74948. Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
  74949. <video> elements on Windows never becomes visible when a page is restored from the cache
  74950. Always pass "set" calls down to MediaPlayerPrivate instead of only when the
  74951. value is different from the cached value. Let the implementation decide when
  74952. to avoid work because nothing has changed.
  74953. * platform/graphics/MediaPlayer.cpp:
  74954. (WebCore::MediaPlayer::setVolume):
  74955. (WebCore::MediaPlayer::setRate):
  74956. (WebCore::MediaPlayer::setRect):
  74957. (WebCore::MediaPlayer::setVisible):
  74958. 2008-08-14 Keishi Hattori <casey.hattori@gmail.com>
  74959. Make Firebug command line API respect predefined variables.
  74960. https://bugs.webkit.org/show_bug.cgi?id=20385
  74961. Reviewed by Tim Hatcher.
  74962. * page/inspector/Console.js:
  74963. 2008-08-14 Sam Weinig <sam@webkit.org>
  74964. Reviewed by Geoffrey Garen and Timothy Hatcher.
  74965. Allow programatically setting the HTMLTokenizers time delay and chunk size
  74966. which are used for determining how aggressively we yield.
  74967. * WebCore.base.exp:
  74968. * html/HTMLTokenizer.cpp:
  74969. (WebCore::HTMLTokenizer::begin):
  74970. (WebCore::HTMLTokenizer::continueProcessing):
  74971. * html/HTMLTokenizer.h:
  74972. * page/Page.cpp:
  74973. (WebCore::Page::Page):
  74974. (WebCore::Page::setCustomHTMLTokenizerTimeDelay):
  74975. (WebCore::Page::setCustomHTMLTokenizerChunkSize):
  74976. * page/Page.h:
  74977. (WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
  74978. (WebCore::Page::customHTMLTokenizerTimeDelay):
  74979. (WebCore::Page::hasCustomHTMLTokenizerChunkSize):
  74980. (WebCore::Page::customHTMLTokenizerChunkSize):
  74981. 2008-08-14 Eric Seidel <eric@webkit.org>
  74982. Reviewed by Beth.
  74983. Move us one step closer to cross-platform svg/graphics code
  74984. * WebCore.xcodeproj/project.pbxproj:
  74985. * html/CanvasStyle.cpp:
  74986. * platform/graphics/Color.cpp:
  74987. (WebCore::colorWithOverrideAlpha):
  74988. * platform/graphics/Color.h:
  74989. * svg/graphics/cg/CgSupport.cpp:
  74990. (WebCore::applyStrokeStyleToContext):
  74991. (WebCore::strokeBoundingBox):
  74992. * svg/graphics/cg/SVGPaintServerSolidCg.cpp:
  74993. (WebCore::SVGPaintServerSolid::setup):
  74994. 2008-08-14 Eric Seidel <eric@webkit.org>
  74995. Reviewed by Alexey.
  74996. Remove un-need includes from HTMLCanvas and use the
  74997. Gradient platform abstraction in one place in CanvasStyle
  74998. * html/CanvasRenderingContext2D.cpp:
  74999. (WebCore::CanvasRenderingContext2D::fillRect):
  75000. * html/CanvasStyle.cpp:
  75001. * html/HTMLCanvasElement.cpp:
  75002. 2008-08-14 Eric Seidel <eric@webkit.org>
  75003. Reviewed by Alexey.
  75004. Clean up GlyphBuffer.h, removing more #ifdefs
  75005. * platform/graphics/GlyphBuffer.h:
  75006. (WebCore::GlyphBuffer::glyphAt):
  75007. (WebCore::GlyphBuffer::advanceAt):
  75008. (WebCore::GlyphBuffer::add):
  75009. 2008-08-14 Eric Seidel <eric@webkit.org>
  75010. Reviewed by Sam.
  75011. Clean up AffineTransform.h, removing #ifdefs
  75012. * platform/graphics/AffineTransform.h:
  75013. * platform/graphics/cairo/AffineTransformCairo.cpp:
  75014. * platform/graphics/cg/AffineTransformCG.cpp:
  75015. * platform/graphics/qt/AffineTransformQt.cpp:
  75016. * platform/graphics/wx/AffineTransformWx.cpp:
  75017. 2008-08-14 Dan Bernstein <mitz@apple.com>
  75018. - fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
  75019. * platform/graphics/cairo/ImageSourceCairo.cpp:
  75020. (WebCore::ImageSource::frameSizeAtIndex):
  75021. * platform/graphics/qt/ImageSourceQt.cpp:
  75022. (WebCore::ImageSource::frameSizeAtIndex):
  75023. * platform/graphics/wx/ImageSourceWx.cpp:
  75024. (WebCore::ImageSource::frameSizeAtIndex):
  75025. 2008-08-14 Dan Bernstein <mitz@apple.com>
  75026. Reviewed by Brady Eidson.
  75027. - fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
  75028. * platform/graphics/BitmapImage.cpp:
  75029. (WebCore::BitmapImage::BitmapImage): Added initialization of
  75030. m_hasUniformFrameSize.
  75031. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the
  75032. cached frame for use in decoded size computation and for setting
  75033. m_hasUniformFrameSize.
  75034. (WebCore::BitmapImage::currentFrameSize): Added.
  75035. (WebCore::BitmapImage::dataChanged): Added code to reset
  75036. m_hasUniformFrameSize.
  75037. * platform/graphics/BitmapImage.h: Added currentFrameSize() and
  75038. m_hasUniformFrameSize.
  75039. * platform/graphics/ImageSource.h: Added frameSizeAtIndex().
  75040. * platform/graphics/cg/ImageCG.cpp:
  75041. (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
  75042. fixes the bug, which resulted from assuming that the frame being drawn
  75043. was the same size as the first frame.
  75044. * platform/graphics/cg/ImageSourceCG.cpp:
  75045. (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
  75046. changed to get the size of the frame at the given index.
  75047. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
  75048. 2008-08-13 Simon Fraser <simon.fraser@apple.com>
  75049. Reviewed by Eric Seidel
  75050. Fix @font-face inside @media rule crash.
  75051. https://bugs.webkit.org/show_bug.cgi?id=20367
  75052. Test: fast/css/font-face-in-media-rule.html
  75053. * css/CSSStyleSelector.cpp:
  75054. (WebCore::CSSRuleSet::addRulesFromSheet):
  75055. 2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
  75056. wx build fixes after recent changes to Canvas and Image classes.
  75057. * platform/graphics/Pattern.h:
  75058. * platform/graphics/wx/GradientWx.cpp:
  75059. (WebCore::Gradient::fill):
  75060. * platform/graphics/wx/GraphicsContextWx.cpp:
  75061. (WebCore::GraphicsContext::applyFillPattern):
  75062. (WebCore::GraphicsContext::applyStrokePattern):
  75063. * platform/graphics/wx/ImageBufferWx.cpp:
  75064. (WebCore::ImageBuffer::image):
  75065. * platform/graphics/wx/ImageWx.cpp:
  75066. (WebCore::Image::loadPlatformResource):
  75067. 2008-08-14 Maxime Britto <britto@apple.com>
  75068. Reviewed by Sam Weinig.
  75069. rdar://6102511
  75070. When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
  75071. IE and FF are both preventing the keyboard event to interact with the page while scrolling.
  75072. Some differences exist between them concerning the kind of key which is pressed :
  75073. IE7 : every key leads to a stop of the panning
  75074. FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
  75075. For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
  75076. * page/EventHandler.cpp:
  75077. (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
  75078. 2008-08-14 Christian Dywan <christian@twotoasts.de>
  75079. Gtk+/ Cairo build fix, patch by Dirk Schulze.
  75080. * html/CanvasStyle.cpp:
  75081. * platform/graphics/cairo/PatternCairo.cpp:
  75082. (WebCore::Pattern::createPlatformPattern):
  75083. * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
  75084. 2008-08-14 Kevin McCullough <kmccullough@apple.com>
  75085. Reviewed by Tim.
  75086. <rdar://problem/6115819> Notify of profile in console
  75087. * page/InspectorController.cpp:
  75088. (WebCore::InspectorController::addProfile):
  75089. (WebCore::InspectorController::addProfileMessageToConsole): Called by
  75090. addProfile this is the function that adds a message to the console that
  75091. a profile finished.
  75092. * page/InspectorController.h:
  75093. * page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
  75094. the console log to the profile in the web inspector.
  75095. (WebCore::getUniqueIdCallback):
  75096. (WebCore::ProfileClass):
  75097. * page/inspector/ProfilesPanel.js: Created a map of all the profiles by
  75098. Id to bring up the requested profile. Also select and reveal the
  75099. profile in the profile panel. And created displayTitleForProfileLink()
  75100. which formats a title taking into account if it's user initiated or if
  75101. there are multiples. Lasty, I put the user initiated profile in a
  75102. variable.
  75103. * page/inspector/inspector.js: Make the profile title be a clickable
  75104. link that will take the user to the identified profile. Also expose
  75105. the count of user initiated profiles so they can be displayed in the
  75106. console with the correct count.
  75107. 2008-08-14 Timothy Hatcher <timothy@apple.com>
  75108. Avoid formating ConsoleMessages twice unless the message will be
  75109. displayed in bubbles of a SourceFrame.
  75110. Reviewed by Kevin McCullough.
  75111. * page/inspector/Console.js:
  75112. (WebInspector.ConsoleMessage): Only format the plain text message
  75113. if the URL and line are valid and the level is error or warning.
  75114. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
  75115. Helper to test for error or warning level.
  75116. * page/inspector/SourceFrame.js:
  75117. (WebInspector.SourceFrame.prototype.addMessage): Don't add the
  75118. message if there is no message or valid line or if the msg
  75119. isn't an error or warning.
  75120. 2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
  75121. partial Gtk build fix, not reviewed
  75122. * platform/graphics/cairo/PatternCairo.cpp:
  75123. 2008-08-13 Sam Weinig <sam@webkit.org>
  75124. Reviewed by Anders Carlsson.
  75125. Fix style issue.
  75126. * html/HTMLMediaElement.cpp:
  75127. (WebCore::HTMLMediaElement::pickMedia):
  75128. 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
  75129. Build fix for Cairo, not reviewed. (exposed by gtk build slave)
  75130. Continue Erics build fixes, after the Image cleanup.
  75131. * platform/graphics/cairo/ImageBufferCairo.cpp:
  75132. (WebCore::ImageBuffer::image):
  75133. 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
  75134. Build fix for Qt, not reviewed.
  75135. Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
  75136. * dom/XMLTokenizer.cpp:
  75137. (WebCore::eventuallyMarkAsParserCreated): Was erre
  75138. 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
  75139. Build fix, not reviewed.
  75140. Add ScriptElement.cpp to Gtk build.
  75141. * GNUmakefile.am:
  75142. 2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
  75143. Reviewed by Eric.
  75144. Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
  75145. Refactor HTMLScriptElement's code into a common base class: ScriptElement.
  75146. SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
  75147. This resolves code duplications and allows us to completly replace the old
  75148. SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
  75149. As ScriptElement, doesn't actually inherit from Element, we may want to rename
  75150. it, though StyleElement uses the same naming convention, so I left it as is for now.
  75151. Eventually we'll rename both files in future.
  75152. No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
  75153. * WebCore.pro: Add new ScriptElement.cpp to build.
  75154. * WebCore.vcproj/WebCore.vcproj: Ditto.
  75155. * WebCore.xcodeproj/project.pbxproj: Ditto.
  75156. * WebCoreSources.bkl: Dutto.
  75157. * dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
  75158. (WebCore::ScriptElement::insertedIntoDocument):
  75159. (WebCore::ScriptElement::removedFromDocument):
  75160. (WebCore::ScriptElement::childrenChanged):
  75161. (WebCore::ScriptElement::finishParsingChildren):
  75162. (WebCore::ScriptElement::handleSourceAttribute):
  75163. (WebCore::isSupportedJavaScriptLanguage):
  75164. (WebCore::ScriptElementData::ScriptElementData):
  75165. (WebCore::ScriptElementData::~ScriptElementData):
  75166. (WebCore::ScriptElementData::requestScript):
  75167. (WebCore::ScriptElementData::evaluateScript):
  75168. (WebCore::ScriptElementData::stopLoadRequest):
  75169. (WebCore::ScriptElementData::notifyFinished):
  75170. (WebCore::ScriptElementData::ignoresLoadRequest):
  75171. (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
  75172. (WebCore::ScriptElementData::scriptCharset):
  75173. (WebCore::ScriptElementData::scriptContent):
  75174. * dom/ScriptElement.h: Added.
  75175. (WebCore::ScriptElement::ScriptElement):
  75176. (WebCore::ScriptElement::~ScriptElement):
  75177. (WebCore::ScriptElementData::element):
  75178. (WebCore::ScriptElementData::createdByParser):
  75179. (WebCore::ScriptElementData::setCreatedByParser):
  75180. * dom/XMLTokenizer.cpp:
  75181. (WebCore::isScriptElement):
  75182. (WebCore::castToScriptElement):
  75183. (WebCore::eventuallyMarkAsParserCreated):
  75184. (WebCore::XMLTokenizer::startElementNs):
  75185. (WebCore::XMLTokenizer::endElementNs):
  75186. (WebCore::createXHTMLParserErrorHeader):
  75187. (WebCore::XMLTokenizer::insertErrorMessageBlock):
  75188. * html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
  75189. (WebCore::HTMLScriptElement::HTMLScriptElement):
  75190. (WebCore::HTMLScriptElement::~HTMLScriptElement):
  75191. (WebCore::HTMLScriptElement::isURLAttribute):
  75192. (WebCore::HTMLScriptElement::setCreatedByParser):
  75193. (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
  75194. (WebCore::HTMLScriptElement::childrenChanged):
  75195. (WebCore::HTMLScriptElement::parseMappedAttribute):
  75196. (WebCore::HTMLScriptElement::finishParsingChildren):
  75197. (WebCore::HTMLScriptElement::insertedIntoDocument):
  75198. (WebCore::HTMLScriptElement::removedFromDocument):
  75199. (WebCore::HTMLScriptElement::text):
  75200. (WebCore::HTMLScriptElement::setText):
  75201. (WebCore::HTMLScriptElement::setHtmlFor):
  75202. (WebCore::HTMLScriptElement::setEvent):
  75203. (WebCore::HTMLScriptElement::charset):
  75204. (WebCore::HTMLScriptElement::src):
  75205. (WebCore::HTMLScriptElement::type):
  75206. (WebCore::HTMLScriptElement::scriptCharset):
  75207. (WebCore::HTMLScriptElement::scriptContent):
  75208. (WebCore::HTMLScriptElement::sourceAttributeValue):
  75209. (WebCore::HTMLScriptElement::charsetAttributeValue):
  75210. (WebCore::HTMLScriptElement::typeAttributeValue):
  75211. (WebCore::HTMLScriptElement::languageAttributeValue):
  75212. (WebCore::HTMLScriptElement::dispatchLoadEvent):
  75213. (WebCore::HTMLScriptElement::dispatchErrorEvent):
  75214. * html/HTMLScriptElement.h:
  75215. * svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
  75216. * svg/SVGScriptElement.cpp:
  75217. (WebCore::SVGScriptElement::SVGScriptElement):
  75218. (WebCore::SVGScriptElement::scriptContent):
  75219. (WebCore::SVGScriptElement::sourceAttributeValue):
  75220. (WebCore::SVGScriptElement::charsetAttributeValue):
  75221. (WebCore::SVGScriptElement::typeAttributeValue):
  75222. (WebCore::SVGScriptElement::languageAttributeValue):
  75223. (WebCore::SVGScriptElement::dispatchLoadEvent):
  75224. (WebCore::SVGScriptElement::dispatchErrorEvent):
  75225. * svg/SVGScriptElement.h:
  75226. (WebCore::SVGScriptElement::setCreatedByParser):
  75227. 2008-08-13 Eric Seidel <eric@webkit.org>
  75228. Attempt to fix the Gtk build, no review.
  75229. I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
  75230. * platform/graphics/GraphicsContext.h:
  75231. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  75232. * platform/graphics/qt/GradientQt.cpp:
  75233. * platform/graphics/qt/GraphicsContextQt.cpp:
  75234. * platform/gtk/RenderThemeGtk.cpp:
  75235. (WebCore::paintMozWidget):
  75236. 2008-08-13 Eric Seidel <eric@webkit.org>
  75237. Yet another attempt to fix the Qt build, no review.
  75238. * platform/graphics/qt/GradientQt.cpp:
  75239. * platform/graphics/qt/GraphicsContextQt.cpp:
  75240. (WebCore::GraphicsContext::applyStrokePattern):
  75241. (WebCore::GraphicsContext::applyFillPattern):
  75242. 2008-08-13 Eric Seidel <eric@webkit.org>
  75243. Attempt to fix the Windows build, no review.
  75244. * platform/win/CursorWin.cpp:
  75245. (WebCore::loadCursorByName):
  75246. * platform/win/ScrollViewWin.cpp:
  75247. (WebCore::ScrollView::paint):
  75248. 2008-08-13 Eric Seidel <eric@webkit.org>
  75249. Attempt to fix the Windows build, no review.
  75250. * platform/win/CursorWin.cpp:
  75251. (WebCore::loadCursorByName):
  75252. * platform/win/ScrollViewWin.cpp:
  75253. (WebCore::ScrollView::paint):
  75254. 2008-08-13 Eric Seidel <eric@webkit.org>
  75255. Attempt to fix the Qt build, no review.
  75256. * platform/graphics/qt/ImageBufferQt.cpp:
  75257. (WebCore::ImageBuffer::image):
  75258. 2008-08-13 Eric Seidel <eric@webkit.org>
  75259. Attempt to fix the Windows build, no review.
  75260. * platform/graphics/win/ImageWin.cpp:
  75261. (WebCore::Image::loadPlatformResource):
  75262. * plugins/win/PluginViewWin.cpp:
  75263. (WebCore::PluginView::paintMissingPluginIcon):
  75264. 2008-08-13 Eric Seidel <eric@webkit.org>
  75265. Another attempt to fix the Qt build, no review.
  75266. * platform/graphics/qt/ImageQt.cpp:
  75267. * platform/graphics/qt/StillImageQt.h:
  75268. 2008-08-13 Eric Seidel <eric@webkit.org>
  75269. No review, build fix only.
  75270. Fix mac build, due to change in new code since my patch was written.
  75271. * svg/graphics/cg/SVGResourceMaskerCg.mm:
  75272. (WebCore::SVGResourceMasker::applyMask):
  75273. 2008-08-13 Eric Seidel <eric@webkit.org>
  75274. Build fix only, no review.
  75275. Attempt to fix the Qt build.
  75276. * platform/graphics/qt/ImageBufferQt.cpp:
  75277. * platform/graphics/qt/StillImageQt.h:
  75278. (WebCore::StillImage::create):
  75279. (WebCore::StillImage::destroyDecodedData):
  75280. (WebCore::StillImage::decodedSize):
  75281. 2008-08-13 Eric Seidel <eric@webkit.org>
  75282. Build fix only, no review.
  75283. Attempt to fix the Qt build.
  75284. * html/CanvasStyle.cpp:
  75285. (WebCore::CanvasStyle::applyStrokeColor):
  75286. (WebCore::CanvasStyle::applyFillColor):
  75287. 2008-08-13 Eric Seidel <eric@webkit.org>
  75288. Reviewed by Sam.
  75289. Match HTML5 spec by throwing INVALID_STATE_ERR when
  75290. createPattern is called and the HTMLImageElement is not
  75291. yet done loading the image (!isComplete)
  75292. https://bugs.webkit.org/show_bug.cgi?id=20351
  75293. Test: http/misc/canvas-pattern-from-incremental-image.html
  75294. * html/CanvasRenderingContext2D.cpp:
  75295. (WebCore::CanvasRenderingContext2D::createPattern):
  75296. 2008-08-13 Eric Seidel <eric@webkit.org>
  75297. Reviewed by Niko.
  75298. Split out a Pattern class from CanvasPattern
  75299. and remove all the Pattern-related #ifdefs
  75300. (This will break non-mac platforms! I will fix them.)
  75301. https://bugs.webkit.org/show_bug.cgi?id=20351
  75302. * GNUmakefile.am:
  75303. * WebCore.pro:
  75304. * WebCore.vcproj/WebCore.vcproj:
  75305. * WebCore.xcodeproj/project.pbxproj:
  75306. * WebCoreSources.bkl:
  75307. * html/CanvasPattern.cpp:
  75308. (WebCore::CanvasPattern::parseRepetitionType):
  75309. (WebCore::CanvasPattern::CanvasPattern):
  75310. * html/CanvasPattern.h:
  75311. (WebCore::CanvasPattern::create):
  75312. (WebCore::CanvasPattern::pattern):
  75313. (WebCore::CanvasPattern::originClean):
  75314. * html/CanvasRenderingContext2D.cpp:
  75315. (WebCore::CanvasRenderingContext2D::createPattern):
  75316. (WebCore::CanvasRenderingContext2D::applyStrokePattern):
  75317. (WebCore::CanvasRenderingContext2D::applyFillPattern):
  75318. * html/CanvasRenderingContext2D.h:
  75319. * html/HTMLCanvasElement.cpp:
  75320. * html/HTMLCanvasElement.h:
  75321. * loader/FrameLoader.cpp:
  75322. (WebCore::FrameLoader::createHistoryItem):
  75323. * platform/graphics/GraphicsContext.h:
  75324. * platform/graphics/cairo/GraphicsContextCairo.cpp:
  75325. (WebCore::GraphicsContext::applyStrokePattern):
  75326. (WebCore::GraphicsContext::applyFillPattern):
  75327. * platform/graphics/cg/GraphicsContextCG.cpp:
  75328. (WebCore::GraphicsContext::clipToImageBuffer):
  75329. (WebCore::GraphicsContext::applyStrokePattern):
  75330. (WebCore::GraphicsContext::applyFillPattern):
  75331. 2008-08-13 Eric Seidel <eric@webkit.org>
  75332. Reviewed by Niko.
  75333. Make Images RefCounted (and clean up callers)
  75334. https://bugs.webkit.org/show_bug.cgi?id=20351
  75335. * editing/DeleteButtonController.cpp:
  75336. (WebCore::DeleteButtonController::createDeletionUI):
  75337. * loader/CachedImage.cpp:
  75338. (WebCore::CachedImage::CachedImage):
  75339. (WebCore::brokenImage):
  75340. (WebCore::nullImage):
  75341. (WebCore::CachedImage::image):
  75342. (WebCore::CachedImage::notifyObservers):
  75343. (WebCore::CachedImage::createImage):
  75344. * loader/CachedImage.h:
  75345. * loader/icon/IconRecord.cpp:
  75346. (WebCore::IconRecord::setImageData):
  75347. (WebCore::IconRecord::loadImageFromResource):
  75348. * loader/icon/IconRecord.h:
  75349. * platform/graphics/BitmapImage.h:
  75350. (WebCore::BitmapImage::create):
  75351. * platform/graphics/GeneratedImage.h:
  75352. * platform/graphics/Gradient.cpp:
  75353. * platform/graphics/Gradient.h:
  75354. * platform/graphics/Image.cpp:
  75355. (WebCore::Image::nullImage):
  75356. * platform/graphics/Image.h:
  75357. * platform/graphics/ImageBuffer.h:
  75358. * platform/graphics/cairo/ImageBufferCairo.cpp:
  75359. (WebCore::ImageBuffer::image):
  75360. * platform/graphics/cg/ImageBufferCG.cpp:
  75361. (WebCore::ImageBuffer::image):
  75362. (WebCore::ImageBuffer::getImageData):
  75363. (WebCore::ImageBuffer::putImageData):
  75364. * platform/graphics/cg/PDFDocumentImage.h:
  75365. (WebCore::PDFDocumentImage::create):
  75366. (WebCore::PDFDocumentImage::destroyDecodedData):
  75367. (WebCore::PDFDocumentImage::decodedSize):
  75368. * platform/graphics/gtk/ImageGtk.cpp:
  75369. (WebCore::Image::loadPlatformResource):
  75370. * platform/graphics/mac/ImageMac.mm:
  75371. (WebCore::Image::loadPlatformResource):
  75372. * rendering/RenderImage.cpp:
  75373. * rendering/RenderLayer.cpp:
  75374. (WebCore::RenderLayer::paintOverflowControls):
  75375. * svg/graphics/SVGImage.cpp:
  75376. (WebCore::SVGImage::nativeImageForCurrentFrame):
  75377. * svg/graphics/SVGImage.h:
  75378. (WebCore::SVGImage::create):
  75379. (WebCore::SVGImage::destroyDecodedData):
  75380. (WebCore::SVGImage::decodedSize):
  75381. (WebCore::SVGImage::frameAtIndex):
  75382. * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
  75383. (WebCore::SVGPaintServerPattern::setup):
  75384. * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
  75385. (WebCore::SVGResourceMasker::applyMask):
  75386. * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
  75387. (WebCore::patternCallback):
  75388. * svg/graphics/cg/SVGResourceMaskerCg.mm:
  75389. (WebCore::SVGResourceMasker::applyMask):
  75390. 2008-08-13 Eric Seidel <eric@webkit.org>
  75391. Reviewed by Niko.
  75392. Remove #ifdefs from CanvasStyle by using platform/Color.h
  75393. https://bugs.webkit.org/show_bug.cgi?id=20351
  75394. There are some down-sides to this commit.
  75395. This commit limits us to 255 levels of grey for calls like:
  75396. context.setStrokeStyle(.37, 1.0)
  75397. previously CG might have used up to 32bits to store the grey level
  75398. Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
  75399. Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
  75400. to RGBA32 (like all the rest of colors in WebCore), thus:
  75401. context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
  75402. context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
  75403. If this is a problem for Dashboard, we can either roll out this commit
  75404. or add a beefier Color abstraction, which can be used internally by GraphicsContext
  75405. when keeping state, and then GraphicsContext can grow some additional set* routines
  75406. for setting the a grey/float/whatever fill and stroke.
  75407. * html/CanvasRenderingContext2D.cpp:
  75408. (WebCore::CanvasRenderingContext2D::setFillStyle):
  75409. * html/CanvasStyle.cpp:
  75410. (WebCore::CanvasStyle::CanvasStyle):
  75411. (WebCore::colorWithOverrideAlpha):
  75412. (WebCore::CanvasStyle::applyStrokeColor):
  75413. (WebCore::CanvasStyle::applyFillColor):
  75414. * html/CanvasStyle.h:
  75415. * platform/graphics/Color.cpp:
  75416. (WebCore::colorFloatToRGBAByte):
  75417. (WebCore::makeRGBA32FromFloats):
  75418. * platform/graphics/Color.h:
  75419. 2008-08-13 Eric Carlson <eric.carlson@apple.com>
  75420. Reviewed by Adele Peterson.
  75421. Fix for <rdar://problem/6137931>
  75422. https://bugs.webkit.org/show_bug.cgi?id=20360
  75423. Remove all parameters from the MIME type before checking with the MIME type registry
  75424. Tests: media/video-source-type-params.html
  75425. * html/HTMLMediaElement.cpp:
  75426. (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
  75427. to isSupportedMediaMIMEType()
  75428. 2008-08-13 Beth Dakin <bdakin@apple.com>
  75429. Reviewed by Sam Weinig.
  75430. Fix for <rdar://problem/6141345>
  75431. This patch refines findString and markAllMatchesForText functions'
  75432. interactions with disconnected frames. They no longer rely on
  75433. knowing where a range is relative to the visible region and work
  75434. with disconnected frames that contain frames.
  75435. * editing/Editor.cpp:
  75436. (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
  75437. the visiblity enum.
  75438. (WebCore::Editor::firstVisibleRange): This now returns the very
  75439. first visible range in the document. It's no longer dependent on
  75440. searching forward.
  75441. (WebCore::Editor::lastVisibleRange): This now returns the very last
  75442. visible range in the document. It's no longer dependent on
  75443. searching backwards.
  75444. (WebCore::Editor::nextVisibleRange): This returns the next visible
  75445. range in the appropriate direction from the current range.
  75446. * editing/Editor.h:
  75447. * page/Frame.cpp:
  75448. (WebCore::Frame::findString):
  75449. (WebCore::Frame::markAllMatchesForText):
  75450. 2008-08-13 Kevin Ollivier <kevino@theolliviers.com>
  75451. wx build fix for case-sensitive platforms, like Linux.
  75452. * WebCoreSources.bkl:
  75453. 2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
  75454. Reviewed by Holger Freyther.
  75455. http://bugs.webkit.org/show_bug.cgi?id=16881
  75456. [GTK] PlatformScreenGtk is unimplemented
  75457. Original patch by Christian Dywan.
  75458. * platform/gtk/PlatformScreenGtk.cpp:
  75459. (WebCore::screenDepth):
  75460. (WebCore::screenDepthPerComponent):
  75461. (WebCore::screenIsMonochrome):
  75462. (WebCore::screenRect):
  75463. (WebCore::screenAvailableRect):
  75464. 2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
  75465. Reviewed by Holger Freyther.
  75466. http://bugs.webkit.org/show_bug.cgi?id=20318
  75467. SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
  75468. g_idle_add is the same as g_idle_add_full with a priority of
  75469. G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
  75470. * platform/gtk/SharedTimerGtk.cpp:
  75471. (WebCore::setSharedTimerFireTime):
  75472. 2008-08-13 Timothy Hatcher <timothy@apple.com>
  75473. Changed the InspectorController so it can be notified when the
  75474. attached state of the Inspector changes in WebKit.
  75475. Reviewed by Kevin McCullough.
  75476. * WebCore.base.exp: Updated the symbol for setWindowVisible.
  75477. * page/InspectorController.cpp:
  75478. (WebCore::InspectorController::setWindowVisible): Added an attached argument,
  75479. that defaults to false.Call setAttachedWindow with the attached argument.
  75480. (WebCore::InspectorController::setAttachedWindow): Call the script version
  75481. of setAttachedWindow.
  75482. * page/InspectorController.h:
  75483. * page/inspector/inspector.js:
  75484. (WebInspector.setAttachedWindow): Set the attached property.
  75485. 2008-08-12 Timothy Hatcher <timothy@apple.com>
  75486. Added a close button to the Inspector's toolbar when docked.
  75487. https://bugs.webkit.org/show_bug.cgi?id=14270
  75488. Reviewed by Kevin McCullough.
  75489. * page/InspectorController.cpp:
  75490. (WebCore::closeWindow): Call InspectorController::closeWindow.
  75491. (WebCore::InspectorController::windowScriptObjectAvailable):
  75492. Added closeWindow to the script class.
  75493. * page/InspectorController.h:
  75494. * page/inspector/Images/closeButtons.png: Added.
  75495. * page/inspector/inspector.css: Added and changed styles.
  75496. * page/inspector/inspector.html: Added the close button.
  75497. * page/inspector/inspector.js:
  75498. (WebInspector.loaded): Added click event listener to the close button.
  75499. (WebInspector.close): Call InspectorController.closeWindow.
  75500. 2008-08-12 Timothy Hatcher <timothy@apple.com>
  75501. Make the docked Web Inspector resizable. This is the cross platform
  75502. portion of the code. Each InspectorClient needs to implement the
  75503. real resize code.
  75504. https://bugs.webkit.org/show_bug.cgi?id=14282
  75505. Reviewed by Kevin McCullough.
  75506. * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
  75507. * page/InspectorClient.h: Added setAttachedWindowHeight.
  75508. * page/InspectorController.cpp:
  75509. (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
  75510. on the InspectorController.
  75511. (WebCore::InspectorController::setAttachedWindowHeight): Call
  75512. setAttachedWindowHeight on the client.
  75513. (WebCore::InspectorController::windowScriptObjectAvailable):
  75514. Added setAttachedWindowHeight to the script class.
  75515. * page/InspectorController.h:
  75516. * page/inspector/inspector.css: Make the cursor on the toolbar be
  75517. row-resize when docked.
  75518. * page/inspector/inspector.js:
  75519. (WebInspector.loaded): Always add the toolbarDragStart event listener.
  75520. (WebInspector.toolbarDragStart): Return early if we are not attached
  75521. and not on Leopard. Call WebInspector.elementDragStart.
  75522. (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
  75523. (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
  75524. otherwise call moveByUnrestricted.
  75525. 2008-08-13 Simon Hausmann <hausmann@webkit.org>
  75526. Reviewed by Holger.
  75527. Initialize m_zoomsTextOnly in the Settings constructor.
  75528. * page/Settings.cpp:
  75529. (WebCore::Settings::Settings):
  75530. 2008-08-13 Brad Hughes <bhughes@trolltech.com>
  75531. Reviewed by Simon.
  75532. Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
  75533. The latest upgrade of the intel compiler allows us to compile all of
  75534. Qt with optimizations enabled (yay!).
  75535. * WebCore.pro:
  75536. 2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
  75537. Reviewed by Simon.
  75538. Fix QtWebKit not displaying content on 403 HTTP responses
  75539. Just like with 404 responses also display content with 403, as
  75540. used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
  75541. * platform/network/qt/QNetworkReplyHandler.cpp:
  75542. (WebCore::QNetworkReplyHandler::finish):
  75543. 2008-08-13 Simon Hausmann <hausmann@webkit.org>
  75544. Reviewed by Holger.
  75545. Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
  75546. Make the formatting of String::format() locale independent through the use of QString::vsprintf.
  75547. * platform/text/String.cpp:
  75548. (WebCore::String::format):
  75549. 2008-08-13 Simon Hausmann <hausmann@webkit.org>
  75550. Reviewed by Lars.
  75551. Fix QWebFrame::setHtml() not setting the new contents immediately.
  75552. Added a setter to the DocumentLoader to toggle the deferred loading of the main
  75553. resource when it comes from substitute data.
  75554. Disable deferred loading of the main resource when we have valid substitute data,
  75555. as used by QWebFrame::setHtml.
  75556. * loader/DocumentLoader.h:
  75557. 2008-08-13 Mark Rowe <mrowe@apple.com>
  75558. Speculative GTK build fix.
  75559. * GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
  75560. 2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
  75561. Reviewed by Simon.
  75562. Fix encoding of [ and ] in the host part of the URL
  75563. Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
  75564. add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
  75565. doesn't encode [ and ] when they are found in the host part. That is, the
  75566. following URL:
  75567. http://[::1]/
  75568. is valid and should not be reencoded to:
  75569. http://%5b::1%5d/
  75570. * platform/qt/KURLQt.cpp:
  75571. (WebCore::KURL::operator QUrl):
  75572. 2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
  75573. Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
  75574. Broken HTML object elements cause de-reference of pointer to freed memory.
  75575. If we fail to load an image for an object tag and we no longer believe the object tag points at
  75576. an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
  75577. fall back content.
  75578. Reviewed by Dave Hyatt and Alexey Proskuryakov.
  75579. Test: http/tests/misc/object-image-error-with-onload.html
  75580. * html/HTMLObjectElement.cpp:
  75581. (WebCore::HTMLObjectElement::renderFallbackContent):
  75582. * page/Frame.cpp:
  75583. (WebCore::Frame::Frame):
  75584. 2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
  75585. Reviewed by Dave.
  75586. Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
  75587. Masks are translated, and the mask images are swapped on the y-axis.
  75588. Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
  75589. is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
  75590. Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
  75591. the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
  75592. * svg/graphics/cg/SVGResourceMaskerCg.mm:
  75593. (WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
  75594. 2008-08-12 Dan Bernstein <mitz@apple.com>
  75595. - WebCore part of <rdar://problem/6121636>
  75596. Make fast*alloc() abort() on failure and add "try" variants that
  75597. return NULL on failure.
  75598. Reviewed by Darin Adler.
  75599. * platform/Arena.cpp:
  75600. (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
  75601. result.
  75602. * platform/graphics/cg/ImageBufferCG.cpp:
  75603. (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
  75604. 2008-08-12 Dan Bernstein <mitz@apple.com>
  75605. Reviewed by Darin Adler.
  75606. - fix https://bugs.webkit.org/show_bug.cgi?id=19348
  75607. <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
  75608. Test: fast/frames/frameset-style-recalc.html
  75609. * html/HTMLFrameSetElement.cpp:
  75610. (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
  75611. class implementation after marking for layout.
  75612. 2008-08-12 Dan Bernstein <mitz@apple.com>
  75613. Reviewed by John Sullivan.
  75614. - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
  75615. * WebCore.base.exp:
  75616. * page/FrameView.cpp:
  75617. (WebCore::FrameViewPrivate::FrameViewPrivate):
  75618. (WebCore::FrameView::shouldUpdateWhileHidden):
  75619. (WebCore::FrameView::setShouldUpdateWhileHidden):
  75620. * page/FrameView.h:
  75621. * page/Settings.cpp:
  75622. * page/Settings.h:
  75623. 2008-08-12 Adam Roben <aroben@apple.com>
  75624. Windows build fix
  75625. * bindings/js/JSSVGPODTypeWrapper.h: Align
  75626. JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
  75627. members on 16-byte boundaries to avoid an alignment warning.
  75628. 2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
  75629. Reviewed by Oliver.
  75630. Add new dynamice-update layout tests covering SVGMarkerElement.
  75631. Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
  75632. Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
  75633. Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
  75634. svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
  75635. svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
  75636. svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
  75637. svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
  75638. svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
  75639. svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
  75640. svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
  75641. svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
  75642. svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
  75643. svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
  75644. svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
  75645. svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
  75646. svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
  75647. svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
  75648. * svg/SVGMarkerElement.cpp:
  75649. (WebCore::SVGMarkerElement::SVGMarkerElement):
  75650. (WebCore::SVGMarkerElement::parseMappedAttribute):
  75651. (WebCore::SVGMarkerElement::svgAttributeChanged):
  75652. (WebCore::SVGMarkerElement::childrenChanged):
  75653. (WebCore::SVGMarkerElement::setOrientToAuto):
  75654. (WebCore::SVGMarkerElement::setOrientToAngle):
  75655. (WebCore::SVGMarkerElement::canvasResource):
  75656. 2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
  75657. Reviewed by Oliver.
  75658. Add new dynamic-update layout tests covering SVGImageElement.
  75659. Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
  75660. Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
  75661. svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
  75662. svg/dynamic-updates/SVGImageElement-dom-width-attr.html
  75663. svg/dynamic-updates/SVGImageElement-dom-x-attr.html
  75664. svg/dynamic-updates/SVGImageElement-dom-y-attr.html
  75665. svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
  75666. svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
  75667. svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
  75668. svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
  75669. svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
  75670. * svg/SVGImageElement.cpp:
  75671. (WebCore::SVGImageElement::svgAttributeChanged):
  75672. 2008-08-11 Anthony Ricaud <rik24d@gmail.com>
  75673. Changed Option/Alt-Up or Down in CSS editing when the value is
  75674. near zero to jump to the next integer.
  75675. Reviewed by Tim Hatcher.
  75676. https://bugs.webkit.org/show_bug.cgi?id=20326
  75677. * page/inspector/StylesSidebarPane.js:
  75678. 2008-08-11 Anthony Ricaud <rik24d@gmail.com>
  75679. Changed the line highlight transition for an easier animation.
  75680. Reviewed by Tim Hatcher.
  75681. * page/inspector/SourceFrame.js:
  75682. 2008-08-11 Keishi Hattori <casey.hattori@gmail.com>
  75683. Added support for some Firebug Command Line APIs.
  75684. Reviewed by Tim Hatcher.
  75685. https://bugs.webkit.org/show_bug.cgi?id=19867
  75686. https://bugs.webkit.org/show_bug.cgi?id=19868
  75687. https://bugs.webkit.org/show_bug.cgi?id=19869
  75688. https://bugs.webkit.org/show_bug.cgi?id=19875
  75689. https://bugs.webkit.org/show_bug.cgi?id=19876
  75690. https://bugs.webkit.org/show_bug.cgi?id=19880
  75691. * page/inspector/Console.js:
  75692. (WebInspector.Console.prototype._evalInInspectedWindow):
  75693. Create an object on the inspected window that holds the console
  75694. command line API functions. This object is used in a with statement
  75695. around the typed expression.
  75696. 2008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
  75697. Reviewed by Antti.
  75698. Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
  75699. JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
  75700. failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
  75701. Added tests: svg/custom/svg-modify-currentTranslate.html
  75702. svg/custom/tearoffs-with-tearoffs.html
  75703. svg/custom/immutable-properties.html
  75704. Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
  75705. * bindings/js/JSSVGPODTypeWrapper.h:
  75706. (WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
  75707. (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
  75708. (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
  75709. (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
  75710. (WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
  75711. (WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
  75712. (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
  75713. (WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
  75714. * bindings/scripts/CodeGenerator.pm:
  75715. * bindings/scripts/CodeGeneratorJS.pm:
  75716. * svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
  75717. * svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
  75718. 2008-08-11 Brady Eidson <beidson@apple.com>
  75719. Reviewed by John and Anders
  75720. Fix for <rdar://problem/6141797>
  75721. When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
  75722. would never have nil data.
  75723. When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
  75724. semantics with some WebKit applications.
  75725. The guarantee was a good one and should be restored.
  75726. Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
  75727. creates an empty data object in the case of null data for its own purposes.
  75728. * loader/SubstituteResource.h:
  75729. (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
  75730. well help any future subclassers not make this mistake.
  75731. * loader/archive/ArchiveResource.cpp:
  75732. (WebCore::ArchiveResource::create): Return 0 if the data is null.
  75733. 2008-08-11 Simon Fraser <simon.fraser@apple.com>
  75734. Reviewed by Dave Hyatt
  75735. https://bugs.webkit.org/show_bug.cgi?id=20328
  75736. Fix a problem when an 'all' transition transition with more than
  75737. one property changing is interrupted, and did some AnimationController
  75738. cleanup.
  75739. Test: transitions/interrupted-all-transition.html
  75740. * page/AnimationController.cpp:
  75741. (WebCore::ImplicitAnimation::ImplicitAnimation):
  75742. (WebCore::AnimationControllerPrivate::blendProperties):
  75743. (WebCore::CompositeAnimation::updateTransitions):
  75744. (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  75745. (WebCore::CompositeAnimation::setTransitionStartTime):
  75746. (WebCore::CompositeAnimation::overrideImplicitAnimations):
  75747. (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
  75748. (WebCore::ImplicitAnimation::animate):
  75749. (WebCore::ImplicitAnimation::onAnimationEnd):
  75750. (WebCore::ImplicitAnimation::sendTransitionEvent):
  75751. (WebCore::ImplicitAnimation::affectsProperty):
  75752. (WebCore::KeyframeAnimation::endAnimation):
  75753. (WebCore::KeyframeAnimation::onAnimationEnd):
  75754. 2008-08-11 Kevin McCullough <kmccullough@apple.com>
  75755. Reviewed by Tim.
  75756. - Because console messages have group levels now, newly created messages
  75757. that do not specify the level lose their message since the number of
  75758. arguments is wrong.
  75759. * page/inspector/Console.js:
  75760. * page/inspector/Resource.js:
  75761. 2008-08-11 Alp Toker <alp@nuanti.com>
  75762. Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
  75763. the opportunity to sort the sources lists.
  75764. * GNUmakefile.am:
  75765. 2008-08-11 Timothy Hatcher <timothy@apple.com>
  75766. Speed up the the JavaScript syntax highlighter by generating
  75767. the finders only once per script instead of per line.
  75768. https://bugs.webkit.org/show_bug.cgi?id=20346
  75769. Reviewed by Adam Roben.
  75770. * page/inspector/SourceFrame.js:
  75771. (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
  75772. Removed, factored into syntaxHighlightJavascript as an inline function.
  75773. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
  75774. Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
  75775. Generate the finders before iterating the lines.
  75776. 2008-08-11 Adam Roben <aroben@apple.com>
  75777. Windows build fix
  75778. * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
  75779. JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
  75780. too.
  75781. 2008-08-11 Dan Bernstein <mitz@apple.com>
  75782. Reviewed by Darin Adler.
  75783. - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
  75784. Test: fast/css/counters/invalidate-cached-counter-node.html
  75785. * rendering/RenderContainer.cpp:
  75786. (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
  75787. RenderCounters in :before and :after content.
  75788. * rendering/RenderContainer.h:
  75789. * rendering/RenderCounter.cpp:
  75790. (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
  75791. to match the RenderObject method.
  75792. (WebCore::RenderCounter::invalidate): Added. Resets the cached
  75793. CounterNode and invalidates the object's layout and preferred widths.
  75794. (WebCore::destroyCounterNodeChildren): Added a call to
  75795. invalidateCounters().
  75796. * rendering/RenderCounter.h:
  75797. * rendering/RenderObject.h:
  75798. (WebCore::RenderObject::invalidateCounters):
  75799. 2008-08-11 Dean Jackson <dino@apple.com>
  75800. Implement CSS Animation and Transition Events
  75801. https://bugs.webkit.org/show_bug.cgi?id=20337
  75802. Implement the events defined in the CSS Animations
  75803. and Transitions specifications so code can react
  75804. to animations and transitions.
  75805. Reviewed by Tim Hatcher and Dave Hyatt.
  75806. * DerivedSources.make:
  75807. * GNUmakefile.am:
  75808. * WebCore.pro:
  75809. * WebCore.vcproj/WebCore.vcproj:
  75810. * WebCore.xcodeproj/project.pbxproj:
  75811. * WebCoreSources.bkl:
  75812. Build configs for new files
  75813. * bindings/js/JSDOMWindowBase.cpp:
  75814. * bindings/js/JSDOMWindowBase.h:
  75815. * bindings/js/JSEventCustom.cpp:
  75816. * dom/Document.h:
  75817. * dom/Event.cpp:
  75818. * dom/Event.h:
  75819. * dom/EventTarget.cpp:
  75820. * dom/EventTargetNode.cpp:
  75821. * dom/EventTargetNode.h:
  75822. * html/HTMLElement.cpp:
  75823. * page/AnimationController.cpp:
  75824. do all the new event stuff
  75825. * html/HTMLAttributeNames.in:
  75826. the onwebkitanimation* and onwebkittransitionend attrs
  75827. * dom/WebKitAnimationEvent.cpp: Added.
  75828. * dom/WebKitAnimationEvent.h: Added.
  75829. * dom/WebKitAnimationEvent.idl: Added.
  75830. * dom/WebKitTransitionEvent.cpp: Added.
  75831. * dom/WebKitTransitionEvent.h: Added.
  75832. * dom/WebKitTransitionEvent.idl: Added.
  75833. New files for the events
  75834. * manual-tests/transition-events.html: Added.
  75835. New testfile
  75836. 2008-08-11 Adam Roben <aroben@apple.com>
  75837. Add a ForwardingHeader for wtf/NotFound.h
  75838. Rubberstamped by Darin Adler.
  75839. * ForwardingHeaders/wtf/NotFound.h: Added.
  75840. 2008-08-11 Timothy Hatcher <timothy@apple.com>
  75841. Fixes a bug where error bubbles in JavaScript resources would
  75842. be clobbered by the syntax highlighter.
  75843. https://bugs.webkit.org/show_bug.cgi?id=20345
  75844. Reviewed by Adam Roben.
  75845. * manual-tests/inspector/resources/script-error.js: Added.
  75846. * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
  75847. * page/inspector/SourceFrame.js:
  75848. (WebInspector.SourceFrame.prototype._addMessageToSource):
  75849. Check the nodeType and not the nodeName, this is less fragile.
  75850. (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
  75851. Check if the lastChild is an error bubble, if so remove it before
  75852. getting the line's textContent. Add the error bubble back at the end.
  75853. == Rolled over to ChangeLog-2008-08-10 ==