#4 to gravatar or not to gravatar - this is a question

gravatar is now optional in the upstream version but only if 'OFFLINE_MODE' is set to false (fetch remote assets) - upstream has 'DISABLE_GRAVATAR' set implicitly to true (disabled) when 'OFFLINE_MODE' is set to true (Disable CDN even in "prod" mode)

this is sensible because the purpose of 'OFFLINE_MODE' is to serve all files locally but the 'Gravatar E-mail' field on the notabug user profile page has a red star so is presumably a required field and notabug has TemplateFuncs::"CdnMode": func() bool { return false } in modules/base/template.go so this is now an unsatisfiable configuration

my thoughts are that gravatar is a proprietary 3rd-party tracking service and notabug has taken similar steps to remove reference to proprietary 3rd-parties such as slack so gravatar should not be used either or at least it should be optional but it seems notabug wants to disable remote script fetching so perhaps an upstream PR is in order?

related to issue #3

I use notabug mostly because how it has taken steps away from proprietary 3rd parties. If it wasn't for that I may of just used github instead...

the 'Gravatar E-mail' field on the notabug user profile page has a red star so is presumably a required field

I think in the old Gogs it was a mandatory field

Gravatar should just not be used. There's no exception to this. As far as I know in the new Gogs there's an option in app.ini to disable Gravatar. When this is true, ideally the input field for the gravatar email in the user settings page should also be hidden/removed. If this is not the case, than I guess they could accept a PR?

yes i was just pointing out that disabling remote script fetching now implicitly disabled gravatar - so i was putting it to the vote to see if anyone really wanted it cause i wasnt sure why it was there at all - i assumed probably because there was no other way to get a photo in