bill-auger/gogs

2016-08-09: @hp - the upgrade is complete on the notabug-new branch of this fork - this is how i would go about the production upgrade:

git remote add bill-auger https://notabug.org/bill-auger/gogs.git
git fetch bill-auger
git co -b notabug-new bill-auger/notabug-new
make
go build --tags "whatever you need"
./gogs web

after this the database schema should be upgraded automatically - it did for me using sqlite

if all is sparkles - commit the auto-magic changes that the re-build made to the "bindata" then reset master like so:

'initial-fork' is at the commit that the first notabug commit was based on from 2015-02-16 - from here it is just a fast-forward merge to the notabug-new branch

git add -A && git commit -m 'rebuild notabug-new'
git checkout master
git reset --hard bill-auger/initial-fork
git merge notabug-new

2016-08-04: zPlus has suggested perhaps it is best to start from a fresh clone and redo the notabug customizations by hand - from what ive found during the merge process this seems reasonable - many of the notabug changes appear to be superseded by upstream at some point - this is a list of what would need to be done on top of a pristine upstream:

configure the settings for features originally implemented by notabug but now re-implemented upstream --> [DONE] disabling captchas (proposed upstream #3340) --> [DONE] disabling CDN (serve only files from local instance) --> [DONE] setting default branch to "master"
manicure HTML templates --> [DONE] remove references to slack (proposed upstream issue #3356) --> [DONE] hide email addresses per User.HideEmail DB value (proposed upstream issue #3358)
restore notabug branding and custom pages --> [DONE] titlebar --> [DONE] logo --> [DONE] favicon --> [DONE] homepage --> [DONE] header --> [DONE] footer --> [DONE] about --> [DONE] help --> [DONE] outages --> [DONE] tos
ensure DB schema sanity --> [DONE] re-add HideEmail column to model --> [DONE] rename DB column UserName to Name (supposedly gogs will do this automatically)

progress on this is approach is on the notabug-new branch

2016-08-09: @hp - the upgrade is complete on the notabug-new branch of this fork - this is how i would go about the production upgrade: ``` git remote add bill-auger https://notabug.org/bill-auger/gogs.git git fetch bill-auger git co -b notabug-new bill-auger/notabug-new make go build --tags "whatever you need" ./gogs web ``` after this the database schema should be upgraded automatically - it did for me using sqlite if all is sparkles - commit the auto-magic changes that the re-build made to the "bindata" then reset master like so: * 'initial-fork' is at the commit that the first notabug commit was based on from 2015-02-16 - from here it is just a fast-forward merge to the notabug-new branch ``` git add -A && git commit -m 'rebuild notabug-new' git checkout master git reset --hard bill-auger/initial-fork git merge notabug-new ``` ----- 2016-08-04: zPlus has suggested perhaps it is best to start from a fresh clone and redo the notabug customizations by hand - from what ive found during the merge process this seems reasonable - many of the notabug changes appear to be superseded by upstream at some point - this is a list of what would need to be done on top of a pristine upstream: * configure the settings for features originally implemented by notabug but now re-implemented upstream --> [DONE] disabling captchas ([proposed upstream #3340)](https://github.com/gogits/gogs/issues/3340) --> [DONE] disabling CDN (serve only files from local instance) --> [DONE] setting default branch to "master" * manicure HTML templates --> [DONE] remove references to slack [(proposed upstream issue #3356)](https://github.com/gogits/gogs/issues/3356) --> [DONE] hide email addresses per User.HideEmail DB value [(proposed upstream issue #3358)](https://github.com/gogits/gogs/issues/3358) * restore notabug branding and custom pages --> [DONE] titlebar --> [DONE] logo --> [DONE] favicon --> [DONE] homepage --> [DONE] header --> [DONE] footer --> [DONE] about --> [DONE] help --> [DONE] outages --> [DONE] tos * ensure DB schema sanity --> [DONE] re-add HideEmail column to model --> [DONE] rename DB column UserName to Name (supposedly gogs will do this automatically) progress on this is approach is on the [notabug-new branch](https://notabug.org/bill-auger/gogs/src/notabug-new)

the hide email feature is implemented on the upstream-dev branch which ive sent as PR upstream https://github.com/gogits/gogs/pull/3381

will backport to notabug later

I'll just copy here the comment from TMM, which I think is useful

I think the best way forwards is to just start from scratch, reintroduce hideemail, send that as a PR to upstream, install that version on nab and redo the templates from scratch

In your first point ("configure the settings for features originally implemented by notabug but now re-implemented upstream"), there is also Gravatar

About this

 --> re-add HideEmail column to model

why would we need to re-add the hide_email column to the schema?

I believe making a PR for removing Slack will be much simpler than the one for "hide email". If can be as simple as a global setting (in app.ini), and a small change to the corresponding HTML template.

regarding HideEmail - the OP here was written before i sent the PR upstream but even if it is accepted it will be some time before that patch makes it into upstream master

regarding gravatar - nothing need to be done because gravatar is now implicitly disabled when external scripts are disabled - there is a separate issue for gravatar

regarding the slack button - yes that would be very simply change but upstream is not interested in that patch

regarding the slack button - yes that would be very simply change but upstream is not interested in that patch

this is just ridiculous... I'll keep asking them until they add an option to disable Slack. Why wouldn't they accept a patch for this? Is Slack paying for the development of Gogs? What's so special about Slack anyway to give it a free pass?

there is an option already to disable slack but when it is disabled the slack button is still visible even though it does not work - what is proposed now is to remove the useless button and it is thais that they not interested changing - follow the link in the OP above for issue 3356

#2 merging latest upstream master