123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148 |
- From 74c664bcd6b9a5fcf3466310c07f608d12456f7f Mon Sep 17 00:00:00 2001
- From: Chen Qi <Qi.Chen@windriver.com>
- Date: Mon, 25 Feb 2019 14:56:21 +0800
- Subject: [PATCH] don't fail if GLOB_BRACE and GLOB_ALTDIRFUNC is not defined
- If the standard library doesn't provide brace
- expansion users just won't get it.
- Dont use GNU GLOB extentions on non-glibc systems
- Conditionalize use of GLOB_ALTDIRFUNC
- Upstream-Status: Inappropriate [musl specific]
- Signed-off-by: Khem Raj <raj.khem@gmail.com>
- Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
- [rebased for systemd 243]
- Signed-off-by: Scott Murray <scott.murray@konsulko.com>
- ---
- src/basic/glob-util.c | 12 ++++++++++++
- src/test/test-glob-util.c | 16 ++++++++++++++++
- src/tmpfiles/tmpfiles.c | 10 ++++++++++
- 3 files changed, 38 insertions(+)
- --- a/src/basic/glob-util.c
- +++ b/src/basic/glob-util.c
- @@ -12,6 +12,12 @@
- #include "path-util.h"
- #include "strv.h"
-
- +/* Don't fail if the standard library
- + * doesn't provide brace expansion */
- +#ifndef GLOB_BRACE
- +#define GLOB_BRACE 0
- +#endif
- +
- static void closedir_wrapper(void* v) {
- (void) closedir(v);
- }
- @@ -19,6 +25,7 @@ static void closedir_wrapper(void* v) {
- int safe_glob(const char *path, int flags, glob_t *pglob) {
- int k;
-
- +#ifdef GLOB_ALTDIRFUNC
- /* We want to set GLOB_ALTDIRFUNC ourselves, don't allow it to be set. */
- assert(!(flags & GLOB_ALTDIRFUNC));
-
- @@ -32,9 +39,14 @@ int safe_glob(const char *path, int flag
- pglob->gl_lstat = lstat;
- if (!pglob->gl_stat)
- pglob->gl_stat = stat;
- +#endif
-
- errno = 0;
- +#ifdef GLOB_ALTDIRFUNC
- k = glob(path, flags | GLOB_ALTDIRFUNC, NULL, pglob);
- +#else
- + k = glob(path, flags, NULL, pglob);
- +#endif
- if (k == GLOB_NOMATCH)
- return -ENOENT;
- if (k == GLOB_NOSPACE)
- --- a/src/test/test-glob-util.c
- +++ b/src/test/test-glob-util.c
- @@ -34,6 +34,12 @@ TEST(glob_first) {
- assert_se(first == NULL);
- }
-
- +/* Don't fail if the standard library
- + * doesn't provide brace expansion */
- +#ifndef GLOB_BRACE
- +#define GLOB_BRACE 0
- +#endif
- +
- TEST(glob_exists) {
- char name[] = "/tmp/test-glob_exists.XXXXXX";
- int fd = -1;
- @@ -61,11 +67,13 @@ TEST(glob_no_dot) {
- const char *fn;
-
- _cleanup_globfree_ glob_t g = {
- +#ifdef GLOB_ALTDIRFUNC
- .gl_closedir = closedir_wrapper,
- .gl_readdir = (struct dirent *(*)(void *)) readdir_no_dot,
- .gl_opendir = (void *(*)(const char *)) opendir,
- .gl_lstat = lstat,
- .gl_stat = stat,
- +#endif
- };
-
- int r;
- @@ -73,11 +81,19 @@ TEST(glob_no_dot) {
- assert_se(mkdtemp(template));
-
- fn = strjoina(template, "/*");
- +#ifdef GLOB_ALTDIRFUNC
- r = glob(fn, GLOB_NOSORT|GLOB_BRACE|GLOB_ALTDIRFUNC, NULL, &g);
- +#else
- + r = glob(fn, GLOB_NOSORT|GLOB_BRACE, NULL, &g);
- +#endif
- assert_se(r == GLOB_NOMATCH);
-
- fn = strjoina(template, "/.*");
- +#ifdef GLOB_ALTDIRFUNC
- r = glob(fn, GLOB_NOSORT|GLOB_BRACE|GLOB_ALTDIRFUNC, NULL, &g);
- +#else
- + r = glob(fn, GLOB_NOSORT|GLOB_BRACE, NULL, &g);
- +#endif
- assert_se(r == GLOB_NOMATCH);
-
- (void) rm_rf(template, REMOVE_ROOT|REMOVE_PHYSICAL);
- --- a/src/tmpfiles/tmpfiles.c
- +++ b/src/tmpfiles/tmpfiles.c
- @@ -71,6 +71,12 @@
- #include "user-util.h"
- #include "virt.h"
-
- +/* Don't fail if the standard library
- + * doesn't provide brace expansion */
- +#ifndef GLOB_BRACE
- +#define GLOB_BRACE 0
- +#endif
- +
- /* This reads all files listed in /etc/tmpfiles.d/?*.conf and creates
- * them in the file system. This is intended to be used to create
- * properly owned directories beneath /tmp, /var/tmp, /run, which are
- @@ -2174,7 +2180,9 @@ finish:
-
- static int glob_item(Item *i, action_t action) {
- _cleanup_globfree_ glob_t g = {
- +#ifdef GLOB_ALTDIRFUNC
- .gl_opendir = (void *(*)(const char *)) opendir_nomod,
- +#endif
- };
- int r = 0, k;
-
- @@ -2194,7 +2202,9 @@ static int glob_item(Item *i, action_t a
-
- static int glob_item_recursively(Item *i, fdaction_t action) {
- _cleanup_globfree_ glob_t g = {
- +#ifdef GLOB_ALTDIRFUNC
- .gl_opendir = (void *(*)(const char *)) opendir_nomod,
- +#endif
- };
- int r = 0, k;
-
|