#1 Update/add missing files and improve wagon illumination feature

Sloučený
Marnack sloučil 6 revizí z větve advtrains_supplemental/misc-updates do větve advtrains_supplemental/main před před 1 rokem
Marnack okomentoval před 1 rokem

Miscellaneous Updates:

  • Update readme.txt and rename it to README.md
  • Add license files, mod.conf and screenshot.png
  • Eliminate startup error message by moving sample textures directory
  • Add mod setting for controlling illumination appearance at night
  • Improve activation timing of illumination effect
  • Eliminate redundant update of wagon properties to reduce load on server
  • Tweak start and end times of illumination period
Miscellaneous Updates: - Update readme.txt and rename it to README.md - Add license files, mod.conf and screenshot.png - Eliminate startup error message by moving sample textures directory - Add mod setting for controlling illumination appearance at night - Improve activation timing of illumination effect - Eliminate redundant update of wagon properties to reduce load on server - Tweak start and end times of illumination period
W3RQ01 okomentoval před 1 rokem
Vlastník

It's interesting how you managed to add the lights effect during nighttime. It would be great if you could add it also to other mods

It's interesting how you managed to add the lights effect during nighttime. It would be great if you could add it also to other mods
Marnack okomentoval před 1 rokem
Spolupracovník

Well, I didn't add the effect; takaosan wrote it. All I did was tweak the existing code to make the illumination effect turn on and off more effectively as well as add a mod setting so that the effect could be disabled since it does incur a small amount of extra processing for the server for each wagon.

Given the level of effort needed to apply this effect to other mods, particularly if they also support any type of livery customization or have distorted texture mappings defined in their B3D files, I’m not convinced yet that this is the right approach to use in other mods. It’s possible that it could be the best method but I would want to spend some time investigating alternatives first. However, I think there are some higher priority things to work on before getting to that.

Well, I didn't add the effect; takaosan wrote it. All I did was tweak the existing code to make the illumination effect turn on and off more effectively as well as add a mod setting so that the effect could be disabled since it does incur a small amount of extra processing for the server for each wagon. Given the level of effort needed to apply this effect to other mods, particularly if they also support any type of livery customization or have distorted texture mappings defined in their B3D files, I’m not convinced yet that this is the right approach to use in other mods. It’s possible that it could be the best method but I would want to spend some time investigating alternatives first. However, I think there are some higher priority things to work on before getting to that.
W3RQ01 okomentoval před 1 rokem
Vlastník

Approved! Feel free to merge when you want

Approved! Feel free to merge when you want
Tento požadavek na natažení byl sloučen!
Přihlaste se pro zapojení do konverzace.
Bez štítku
Bez milníku
Bez zpracovatele
2 účastníků
Načítání...
Zrušit
Uložit
Není zde žádný obsah.