#353 [DOC] Update FSR doc -- will likely be gone from Proton derivatives

Gesloten
2 jaren geleden werd geopend door DistantThunder · 4 opmerkingen

This section needs to be updated as FSR through Wine may be gone from Proton downstream forks soon.

I don't have much hope TKG will stick where GE couldn't.

https://github.com/GloriousEggroll/proton-ge-custom/releases/tag/GE-Proton7-36

FSR Removed/Disabled indefinitely:

Due to this commit in upstream proton -- ValveSoftware/wine@7c5306e

The FSR patches had to be disabled.

The commit is important because it fixes some problems that were happening with winevulkan, but unfortunately it also patches in a lot of components that were already part of the FSR patch. The problem is that the commit has much of the same contents as the FSR patch, but the FSR patch has the FSR bits all mixed in and its not within my know how to rebase.

The original author of the FSR patches has already stated since the functionality was moved to gamescope (he was the one who moved it to gamescope) the wine patches will not be updated.

With that being said the FSR patches have been increasingly problematic to maintain over time due to the lack of the original author willing to rebase the wine version in favor of instead of using the gamescope version. Moving forward if you need to use FSR, you will need to either use gamescope, or rely on the game itself having FSR as a built-in feature.

* https://notabug.org/Krock/dawn/src/master/TWEAKS.md#fsr---fidelityfx-super-resolution This section needs to be updated as FSR through Wine may be gone from Proton downstream forks soon. I don't have much hope TKG will stick where GE couldn't. https://github.com/GloriousEggroll/proton-ge-custom/releases/tag/GE-Proton7-36 > FSR Removed/Disabled indefinitely: > >Due to this commit in upstream proton -- ValveSoftware/wine@7c5306e > >The FSR patches had to be disabled. > >The commit is important because it fixes some problems that were happening with winevulkan, but unfortunately it also patches in a lot of components that were already part of the FSR patch. The problem is that the commit has much of the same contents as the FSR patch, but the FSR patch has the FSR bits all mixed in and its not within my know how to rebase. > The original author of the FSR patches has already stated since the functionality was moved to gamescope (he was the one who moved it to gamescope) the wine patches will not be updated. > With that being said the FSR patches have been increasingly problematic to maintain over time due to the lack of the original author willing to rebase the wine version in favor of instead of using the gamescope version. Moving forward if you need to use FSR, you will need to either use gamescope, or rely on the game itself having FSR as a built-in feature.
Krock reageerde 2 jaren geleden
Eigenaar

If you - or anyone else from the community - is familiar with gamescope, please feel free to open a PR or suggest a patch (link?) so that it can be documented properly. Gamescope is actively maintained and the preferred solution in long-term, so having brief yet accurate documentation would be great to have.

EDIT: Other things to document:

  • Where to get gamescope builds (how to install?)
  • How to handle virtual desktops
  • How to handle borderless window modes
  • Example command line
  • Links to user documentation (Wiki is rather spare)
If you - or anyone else from the community - is familiar with gamescope, please feel free to open a PR or suggest a patch (link?) so that it can be documented properly. Gamescope is actively maintained and the preferred solution in long-term, so having brief yet accurate documentation would be great to have. EDIT: Other things to document: * Where to get gamescope builds (how to install?) * How to handle virtual desktops * How to handle borderless window modes * Example command line * Links to user documentation (Wiki is rather spare)

Had not heard of gamescope before this, but really wanted FSR, so I gave it a go. Turns out it was ridiculously simple. Just install and run. e.g., for 1440p -> 4K on AMD GPU, do:

gamescope -h 1440 -H 2160 -U -f -- wine cmd /c launcher.bat

wine-staging-tkg never worked for me (crashes just after hoyo logo), so for me this is a win-win :)

Had not heard of gamescope before this, but really wanted FSR, so I gave it a go. Turns out it was ridiculously simple. Just install and run. e.g., for 1440p -> 4K on AMD GPU, do: ``` gamescope -h 1440 -H 2160 -U -f -- wine cmd /c launcher.bat ``` wine-staging-tkg never worked for me (crashes just after hoyo logo), so for me this is a win-win :)
DistantThunder reageerde 2 jaren geleden
Poster

I'm preparing a PR.

Edit: https://notabug.org/Krock/dawn/pulls/354

I'm preparing a PR. Edit: https://notabug.org/Krock/dawn/pulls/354

It seems that some mad person did the rebase and restored the FSR patch.

It seems that some mad person did the rebase and restored the FSR patch.
Krock gesloten om 2 jaren geleden
Sign in to join this conversation.
Geen mijlpaal
Geen verantwoordelijke
4 deelnemers
Laden...
Annuleren
Opslaan
Er is nog geen inhoud.